Failed: ZOOKEEPER-2178 PreCommit Build #2733

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2178
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2733/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 369631 lines...]
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2733//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2733//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2733//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 92bc3f7aef3924519c4b523d06779721efebe02e logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1782:
 exec returned: 1

Total time: 13 minutes 34 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2727
Archived 24 artifacts
Archive block size is 32768
Received 9 blocks and 33470192 bytes
Compression is 0.9%
Took 12 sec
Recording test results
Description set: ZOOKEEPER-2178
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2178) Native client fails compilation on Windows.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566990#comment-14566990
 ] 

Hadoop QA commented on ZOOKEEPER-2178:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12729979/ZOOKEEPER-2178.001.patch
  against trunk revision 1682701.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2733//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2733//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2733//console

This message is automatically generated.

> Native client fails compilation on Windows.
> ---
>
> Key: ZOOKEEPER-2178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2178
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.5.0
> Environment: Windows
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2178.001.patch
>
>
> Due to several recent changes, the native client fails to compile on Windows:
> # ZOOKEEPER-827 (read-only mode) mismatched a function return type between 
> the declaration and definition.
> # ZOOKEEPER-1626 (monotonic clock for tolerance to time adjustments) added an 
> include of unistd.h, which does not exist on Windows.
> # Additionally, ZOOKEEPER-1626 did not implement a code path for accessing 
> the Windows monotonic clock.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2178) Native client fails compilation on Windows.

[Michi Mutsuzaki (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566985#comment-14566985
 ] 

Michi Mutsuzaki commented on ZOOKEEPER-2178:


+1 good catch. Thanks Chris!

> Native client fails compilation on Windows.
> ---
>
> Key: ZOOKEEPER-2178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2178
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.5.0
> Environment: Windows
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2178.001.patch
>
>
> Due to several recent changes, the native client fails to compile on Windows:
> # ZOOKEEPER-827 (read-only mode) mismatched a function return type between 
> the declaration and definition.
> # ZOOKEEPER-1626 (monotonic clock for tolerance to time adjustments) added an 
> include of unistd.h, which does not exist on Windows.
> # Additionally, ZOOKEEPER-1626 did not implement a code path for accessing 
> the Windows monotonic clock.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2178) Native client fails compilation on Windows.

[Michi Mutsuzaki (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michi Mutsuzaki updated ZOOKEEPER-2178:
---
Fix Version/s: 3.6.0
   3.5.1

> Native client fails compilation on Windows.
> ---
>
> Key: ZOOKEEPER-2178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2178
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.5.0
> Environment: Windows
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2178.001.patch
>
>
> Due to several recent changes, the native client fails to compile on Windows:
> # ZOOKEEPER-827 (read-only mode) mismatched a function return type between 
> the declaration and definition.
> # ZOOKEEPER-1626 (monotonic clock for tolerance to time adjustments) added an 
> include of unistd.h, which does not exist on Windows.
> # Additionally, ZOOKEEPER-1626 did not implement a code path for accessing 
> the Windows monotonic clock.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2199) Don't include unistd.h in windows

[Michi Mutsuzaki (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566982#comment-14566982
 ] 

Michi Mutsuzaki commented on ZOOKEEPER-2199:


Oops sorry I totally missed that.

> Don't include unistd.h in windows
> -
>
> Key: ZOOKEEPER-2199
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2199
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2199.patch
>
>
> Windows doesn't have unistd.h.
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-WinVS2008/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2197) non-ascii character in FinalRequestProcessor.java

[Chris Nauroth (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566937#comment-14566937
 ] 

Chris Nauroth commented on ZOOKEEPER-2197:
--

This is looking good to me.  I tested a build locally.  Do we also want to 
include the contrib changes that I mentioned in my last comment?

> non-ascii character in FinalRequestProcessor.java
> -
>
> Key: ZOOKEEPER-2197
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2197
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
>Priority: Minor
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2197.patch, ZOOKEEPER-2197.patch, 
> ZOOKEEPER-2197.patch
>
>
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java:134: 
> error: unmappable character for encoding ASCII
> [javac] // was not being queued ??? ZOOKEEPER-558) properly. This 
> happens, for example,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2199) Don't include unistd.h in windows

[Chris Nauroth (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566935#comment-14566935
 ] 

Chris Nauroth commented on ZOOKEEPER-2199:
--

Hi [~michim].  I had posted a patch on ZOOKEEPER-2178 a few weeks ago that 
includes this fix as well as a monotonic clock implementation for Windows.

> Don't include unistd.h in windows
> -
>
> Key: ZOOKEEPER-2199
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2199
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2199.patch
>
>
> Windows doesn't have unistd.h.
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-WinVS2008/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-2199 PreCommit Build #2732

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2199
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2732/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 373117 lines...]
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2732//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2732//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2732//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 2f58168fc0c09aa4e43eda751a32b6b7ee5bb962 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1782:
 exec returned: 2

Total time: 13 minutes 11 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2727
Archived 24 artifacts
Archive block size is 32768
Received 10 blocks and 33702533 bytes
Compression is 1.0%
Took 14 sec
Recording test results
Description set: ZOOKEEPER-2199
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2199) Don't include unistd.h in windows

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566852#comment-14566852
 ] 

Hadoop QA commented on ZOOKEEPER-2199:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12736476/ZOOKEEPER-2199.patch
  against trunk revision 1682701.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2732//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2732//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2732//console

This message is automatically generated.

> Don't include unistd.h in windows
> -
>
> Key: ZOOKEEPER-2199
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2199
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2199.patch
>
>
> Windows doesn't have unistd.h.
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-WinVS2008/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2199) Don't include unistd.h in windows

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566849#comment-14566849
 ] 

Hadoop QA commented on ZOOKEEPER-2199:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12736476/ZOOKEEPER-2199.patch
  against trunk revision 1682701.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2731//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2731//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2731//console

This message is automatically generated.

> Don't include unistd.h in windows
> -
>
> Key: ZOOKEEPER-2199
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2199
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2199.patch
>
>
> Windows doesn't have unistd.h.
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-WinVS2008/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-2199 PreCommit Build #2731

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2199
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2731/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 372516 lines...]
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2731//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2731//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2731//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 1a8f8f0ff416940e593680316c62ef2b7091a01f logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1782:
 exec returned: 2

Total time: 13 minutes 16 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2727
Archived 24 artifacts
Archive block size is 32768
Received 10 blocks and 33730207 bytes
Compression is 1.0%
Took 11 sec
Recording test results
Description set: ZOOKEEPER-2199
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2199) Don't include unistd.h in windows

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566840#comment-14566840
 ] 

Hadoop QA commented on ZOOKEEPER-2199:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12736476/ZOOKEEPER-2199.patch
  against trunk revision 1682701.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2730//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2730//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2730//console

This message is automatically generated.

> Don't include unistd.h in windows
> -
>
> Key: ZOOKEEPER-2199
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2199
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2199.patch
>
>
> Windows doesn't have unistd.h.
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-WinVS2008/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-2199 PreCommit Build #2730

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2199
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2730/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 374090 lines...]
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2730//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2730//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2730//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 364d56b6d5e2f3d9e72085087cdcdb0ee5192f6f logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1782:
 exec returned: 2

Total time: 13 minutes 21 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2727
Archived 24 artifacts
Archive block size is 32768
Received 10 blocks and 33669245 bytes
Compression is 1.0%
Took 9.3 sec
Recording test results
Description set: ZOOKEEPER-2199
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
All tests passed

[GitHub] zookeeper pull request: ZooKeeper client in C# for 3.4.6

[shayhatsor]

GitHub user shayhatsor opened a pull request:

https://github.com/apache/zookeeper/pull/31

ZooKeeper client in C# for 3.4.6

inspired by the work of [ewhauser](https://github.com/ewhauser) .
I've created a C# Client that supports the current stable version of ZK 
3.4.6.
Main features:
* a .NET async version of every ZK method
* all relevant unit tests have been converted and passing consistently
* recipes are included, async versions will be added soon
* a great measure was taken to follow the logic of the java version. In 
fact, the code is almost identical. thus allowing easy evolution alongside the 
java version.

I still need to add support for system properties (currently the defaults 
are used). also, the async versions of zk methods that return a stat object are 
cumbersome to work with, will be fixed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shayhatsor/zookeeper CSharp

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #31


commit 2ce061129d71dd2a533e1972bf5fcba4ab7f9d19
Author: Flavio Paiva Junqueira 
Date:   2014-02-19T23:12:33Z

ZooKeeper 3.4.6-rc0 release.

git-svn-id: 
https://svn.apache.org/repos/asf/zookeeper/tags/release-3.4.6-rc0@1569963 
13f79535-47bb-0310-9956-ffa450edef68

commit 601207e1151b2691112c431fc3b4130a85ac93b5
Author: Flavio Paiva Junqueira 
Date:   2014-03-12T09:25:48Z

ZooKeeper 3.4.6 release.

git-svn-id: 
https://svn.apache.org/repos/asf/zookeeper/tags/release-3.4.6@1576670 
13f79535-47bb-0310-9956-ffa450edef68

commit 752f4300e67eaafdea527b76797c2db1083e0e2f
Author: shayhatsor 
Date:   2015-05-31T23:21:17Z

ZooKeeperEx 3.4.6 - recipes aren't async yet




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (ZOOKEEPER-2199) Don't include unistd.h in windows

[Michi Mutsuzaki (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michi Mutsuzaki updated ZOOKEEPER-2199:
---
Attachment: ZOOKEEPER-2199.patch

> Don't include unistd.h in windows
> -
>
> Key: ZOOKEEPER-2199
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2199
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2199.patch
>
>
> Windows doesn't have unistd.h.
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-WinVS2008/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZOOKEEPER-2199) Don't include unistd.h in windows

[Michi Mutsuzaki (JIRA)]

Michi Mutsuzaki created ZOOKEEPER-2199:
--

 Summary: Don't include unistd.h in windows
 Key: ZOOKEEPER-2199
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2199
 Project: ZooKeeper
  Issue Type: Bug
  Components: c client
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
 Fix For: 3.5.1, 3.6.0


Windows doesn't have unistd.h.

https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-WinVS2008/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2197) non-ascii character in FinalRequestProcessor.java

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566811#comment-14566811
 ] 

Hadoop QA commented on ZOOKEEPER-2197:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12736463/ZOOKEEPER-2197.patch
  against trunk revision 1682701.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2729//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2729//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2729//console

This message is automatically generated.

> non-ascii character in FinalRequestProcessor.java
> -
>
> Key: ZOOKEEPER-2197
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2197
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
>Priority: Minor
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2197.patch, ZOOKEEPER-2197.patch, 
> ZOOKEEPER-2197.patch
>
>
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java:134: 
> error: unmappable character for encoding ASCII
> [javac] // was not being queued ??? ZOOKEEPER-558) properly. This 
> happens, for example,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-2197 PreCommit Build #2729

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2197
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2729/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 373167 lines...]
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2729//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2729//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2729//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 33efb4809ea4ed723a2fb653b8ffe5cb839068c9 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1782:
 exec returned: 1

Total time: 13 minutes 12 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2727
Archived 24 artifacts
Archive block size is 32768
Received 10 blocks and 33665607 bytes
Compression is 1.0%
Took 9.8 sec
Recording test results
Description set: ZOOKEEPER-2197
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Updated] (ZOOKEEPER-2197) non-ascii character in FinalRequestProcessor.java

[Michi Mutsuzaki (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michi Mutsuzaki updated ZOOKEEPER-2197:
---
Attachment: ZOOKEEPER-2197.patch

> non-ascii character in FinalRequestProcessor.java
> -
>
> Key: ZOOKEEPER-2197
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2197
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
>Priority: Minor
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2197.patch, ZOOKEEPER-2197.patch, 
> ZOOKEEPER-2197.patch
>
>
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java:134: 
> error: unmappable character for encoding ASCII
> [javac] // was not being queued ??? ZOOKEEPER-558) properly. This 
> happens, for example,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: using utf-8 encoding on java files

[Michi Mutsuzaki]

Sounds good. I'll update the patch to use utf8 consistently across all
the javac invocations.

On Sun, May 31, 2015 at 1:08 PM, Chris Nauroth  wrote:
> Another small benefit of UTF-8 source encoding is that we can write test
> cases for passing around multi-byte characters without having to use the
> "\u"-style escaping syntax.
>
> --Chris Nauroth
>
>
>
>
> On 5/31/15, 12:15 PM, "Raúl Gutiérrez Segalés"  wrote:
>
>>On 31 May 2015 at 10:51, Michi Mutsuzaki  wrote:
>>
>>> It sounds fine to me, but any reason why we shouldn't stick to ascii?
>>>
>>
>>No strong reasons tbh, just the fact that utf-8 is sometimes useful for
>>comments and it's
>>probably becoming (if not already) the norm, etc.
>>
>>
>>-rgs
>>
>>
>>
>>> On Sun, May 31, 2015 at 9:14 AM, Raúl Gutiérrez Segalés
>>>  wrote:
>>> > Heya,
>>> >
>>> > So in this issue:
>>> >
>>> > https://issues.apache.org/jira/browse/ZOOKEEPER-2197
>>> >
>>> > we ran into a problem with utf-8 chars. How what about we teach javac
>>>to
>>> > treat
>>> > all files as utf-8? Would that be a problem for anyone/any platform?
>>> > Something like
>>> > this in build.xml:
>>> >
>>> > 
>>> > >> > includeantruntime="false"
>>> >target="${javac.target}" source="${javac.source}"
>>> debug="on"
>>> > encoding="UTF-8">
>>> > 
>>> > 
>>> > 
>>> > 
>>> > 
>>> >
>>> > Thoughts?
>>> >
>>> >
>>> > -rgs
>>>
>

Re: using utf-8 encoding on java files

[Chris Nauroth]

Another small benefit of UTF-8 source encoding is that we can write test
cases for passing around multi-byte characters without having to use the
"\u"-style escaping syntax.

--Chris Nauroth




On 5/31/15, 12:15 PM, "Raúl Gutiérrez Segalés"  wrote:

>On 31 May 2015 at 10:51, Michi Mutsuzaki  wrote:
>
>> It sounds fine to me, but any reason why we shouldn't stick to ascii?
>>
>
>No strong reasons tbh, just the fact that utf-8 is sometimes useful for
>comments and it's
>probably becoming (if not already) the norm, etc.
>
>
>-rgs
>
>
>
>> On Sun, May 31, 2015 at 9:14 AM, Raúl Gutiérrez Segalés
>>  wrote:
>> > Heya,
>> >
>> > So in this issue:
>> >
>> > https://issues.apache.org/jira/browse/ZOOKEEPER-2197
>> >
>> > we ran into a problem with utf-8 chars. How what about we teach javac
>>to
>> > treat
>> > all files as utf-8? Would that be a problem for anyone/any platform?
>> > Something like
>> > this in build.xml:
>> >
>> > 
>> > > > includeantruntime="false"
>> >target="${javac.target}" source="${javac.source}"
>> debug="on"
>> > encoding="UTF-8">
>> > 
>> > 
>> > 
>> > 
>> > 
>> >
>> > Thoughts?
>> >
>> >
>> > -rgs
>>

[jira] [Commented] (ZOOKEEPER-2197) non-ascii character in FinalRequestProcessor.java

[Raul Gutierrez Segales (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566687#comment-14566687
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-2197:
---

yup, that makes sense. maybe we should update this ticket description to 'use 
utf-8 everywhere' then?

> non-ascii character in FinalRequestProcessor.java
> -
>
> Key: ZOOKEEPER-2197
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2197
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
>Priority: Minor
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2197.patch, ZOOKEEPER-2197.patch
>
>
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java:134: 
> error: unmappable character for encoding ASCII
> [javac] // was not being queued ??? ZOOKEEPER-558) properly. This 
> happens, for example,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: using utf-8 encoding on java files

[Raúl Gutiérrez Segalés]

On 31 May 2015 at 10:51, Michi Mutsuzaki  wrote:

> It sounds fine to me, but any reason why we shouldn't stick to ascii?
>

No strong reasons tbh, just the fact that utf-8 is sometimes useful for
comments and it's
probably becoming (if not already) the norm, etc.


-rgs



> On Sun, May 31, 2015 at 9:14 AM, Raúl Gutiérrez Segalés
>  wrote:
> > Heya,
> >
> > So in this issue:
> >
> > https://issues.apache.org/jira/browse/ZOOKEEPER-2197
> >
> > we ran into a problem with utf-8 chars. How what about we teach javac to
> > treat
> > all files as utf-8? Would that be a problem for anyone/any platform?
> > Something like
> > this in build.xml:
> >
> > 
> >  > includeantruntime="false"
> >target="${javac.target}" source="${javac.source}"
> debug="on"
> > encoding="UTF-8">
> > 
> > 
> > 
> > 
> > 
> >
> > Thoughts?
> >
> >
> > -rgs
>

[jira] [Commented] (ZOOKEEPER-2198) Set default test.junit.threads to 1.

[Chris Nauroth (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566678#comment-14566678
 ] 

Chris Nauroth commented on ZOOKEEPER-2198:
--

Michi, thank you for the review and commit.

> Set default test.junit.threads to 1.
> 
>
> Key: ZOOKEEPER-2198
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2198
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
>Priority: Minor
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2198.001.patch
>
>
> Some systems are seeing test failures under concurrent execution.  This issue 
> proposes to change the default {{test.junit.threads}} to 1 so that those 
> environments continue to get consistent test runs.  Jenkins and individual 
> developer environments can set multiple threads with a command line argument, 
> so most environments will still get the benefit of faster test runs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2197) non-ascii character in FinalRequestProcessor.java

[Chris Nauroth (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566656#comment-14566656
 ] 

Chris Nauroth commented on ZOOKEEPER-2197:
--

If we set the source encoding, then I recommend making it consistent across all 
invocations of {{}}.  That would involve making the same change for 
targets like jute and compile-test.  Under contrib, we also have {{}} 
invocations in src/contrib/rest/build.xml and 
src/contrib/zooinspector/build.xml.

> non-ascii character in FinalRequestProcessor.java
> -
>
> Key: ZOOKEEPER-2197
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2197
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
>Priority: Minor
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2197.patch, ZOOKEEPER-2197.patch
>
>
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java:134: 
> error: unmappable character for encoding ASCII
> [javac] // was not being queued ??? ZOOKEEPER-558) properly. This 
> happens, for example,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: using utf-8 encoding on java files

[Chris Nauroth]

This sounds good to me.

Whether we reach consensus on UTF-8 or ASCII, it's good to pass some kind
of value to javac for -encoding.  If the value is unspecified, then it
assumes the platform default encoding, which may vary between different
developer environments and so give different results.  This might explain
why some developers could compile source with multi-byte characters, but
some couldn't, i.e. if Flavio's platform default encoding was ASCII or
CP-1252, but Michi's was UTF-8.

--Chris Nauroth




On 5/31/15, 10:51 AM, "Michi Mutsuzaki"  wrote:

>It sounds fine to me, but any reason why we shouldn't stick to ascii?
>
>On Sun, May 31, 2015 at 9:14 AM, Raúl Gutiérrez Segalés
> wrote:
>> Heya,
>>
>> So in this issue:
>>
>> https://issues.apache.org/jira/browse/ZOOKEEPER-2197
>>
>> we ran into a problem with utf-8 chars. How what about we teach javac to
>> treat
>> all files as utf-8? Would that be a problem for anyone/any platform?
>> Something like
>> this in build.xml:
>>
>> 
>> > includeantruntime="false"
>>target="${javac.target}" source="${javac.source}"
>>debug="on"
>> encoding="UTF-8">
>> 
>> 
>> 
>> 
>> 
>>
>> Thoughts?
>>
>>
>> -rgs
>

Re: using utf-8 encoding on java files

[Michi Mutsuzaki]

It sounds fine to me, but any reason why we shouldn't stick to ascii?

On Sun, May 31, 2015 at 9:14 AM, Raúl Gutiérrez Segalés
 wrote:
> Heya,
>
> So in this issue:
>
> https://issues.apache.org/jira/browse/ZOOKEEPER-2197
>
> we ran into a problem with utf-8 chars. How what about we teach javac to
> treat
> all files as utf-8? Would that be a problem for anyone/any platform?
> Something like
> this in build.xml:
>
> 
>  includeantruntime="false"
>target="${javac.target}" source="${javac.source}" debug="on"
> encoding="UTF-8">
> 
> 
> 
> 
> 
>
> Thoughts?
>
>
> -rgs

[jira] [Commented] (ZOOKEEPER-2197) non-ascii character in FinalRequestProcessor.java

[Mizanur Rahman (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566604#comment-14566604
 ] 

Mizanur Rahman commented on ZOOKEEPER-2197:
---

For http://www.latestdatabase.com/";>email marketing lists  you can 
visit 

> non-ascii character in FinalRequestProcessor.java
> -
>
> Key: ZOOKEEPER-2197
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2197
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
>Priority: Minor
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2197.patch, ZOOKEEPER-2197.patch
>
>
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java:134: 
> error: unmappable character for encoding ASCII
> [javac] // was not being queued ??? ZOOKEEPER-558) properly. This 
> happens, for example,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2197) non-ascii character in FinalRequestProcessor.java

[Raul Gutierrez Segales (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566601#comment-14566601
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-2197:
---

The 2nd uploaded patch added the new encoding, but remove the the — utf-8 char 
(which should stay). 

> non-ascii character in FinalRequestProcessor.java
> -
>
> Key: ZOOKEEPER-2197
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2197
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
>Priority: Minor
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2197.patch, ZOOKEEPER-2197.patch
>
>
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java:134: 
> error: unmappable character for encoding ASCII
> [javac] // was not being queued ??? ZOOKEEPER-558) properly. This 
> happens, for example,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

using utf-8 encoding on java files

[Raúl Gutiérrez Segalés]

Heya,

So in this issue:

https://issues.apache.org/jira/browse/ZOOKEEPER-2197

we ran into a problem with utf-8 chars. How what about we teach javac to
treat
all files as utf-8? Would that be a problem for anyone/any platform?
Something like
this in build.xml:









Thoughts?


-rgs

[jira] [Commented] (ZOOKEEPER-2197) non-ascii character in FinalRequestProcessor.java

[Raul Gutierrez Segales (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566600#comment-14566600
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-2197:
---

Yeah, I think it should be fine. I'll start a quick thread. 

> non-ascii character in FinalRequestProcessor.java
> -
>
> Key: ZOOKEEPER-2197
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2197
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
>Priority: Minor
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2197.patch, ZOOKEEPER-2197.patch
>
>
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java:134: 
> error: unmappable character for encoding ASCII
> [javac] // was not being queued ??? ZOOKEEPER-558) properly. This 
> happens, for example,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: ZooKeeper client in C# that's working with 3.4.6 servers

[Flavio Junqueira]

Hi Shay,

It's great to see this, could you give us a pointer to your repo so that we can 
have a look?

One question out of curiosity. You say that the old version doesn't support 
async/await, which is definitely very C#-ish and good to have, but I was 
wondering how you got around the fact that async/await doesn't guarantee the 
order of continuations. Our clients currently execute callbacks in order by 
using a single dispatcher thread. 

Thanks,
-Flavio
 
> On 31 May 2015, at 15:08, Shay Hatsor  wrote:
> 
> hi,
> 
> inspired by the work of ewhauser  I've created
> a new and improved version.
> There are some issues with his version:
> * no support for multi
> * no support for sync
> * bugs in first connecting to zk (it allows the client to send request
> packets before the connect packet)
> * the current c# code is a bit too different than the java code (which
> makes it almost impossible to keep up with the java changes.
> * no support for .NET 4.5 and async/await.
> 
> I've been working for the past several weeks on making this a reality. I
> branched from the release of 3.4.6 and I'm happy to say it looks very good.
> I've converted all tests that don't need the server object directly,
> working against a local java ZK server. 81 tests are passing, consistently
> :)
> 
> I wish to contribute the code back, so others can enjoy and contribute.
> 
> Regards,
> Shay Hazor

ZooKeeper client in C# that's working with 3.4.6 servers

[Shay Hatsor]

hi,

inspired by the work of ewhauser  I've created
a new and improved version.
There are some issues with his version:
* no support for multi
* no support for sync
* bugs in first connecting to zk (it allows the client to send request
packets before the connect packet)
* the current c# code is a bit too different than the java code (which
makes it almost impossible to keep up with the java changes.
* no support for .NET 4.5 and async/await.

I've been working for the past several weeks on making this a reality. I
branched from the release of 3.4.6 and I'm happy to say it looks very good.
I've converted all tests that don't need the server object directly,
working against a local java ZK server. 81 tests are passing, consistently
:)

I wish to contribute the code back, so others can enjoy and contribute.

Regards,
Shay Hazor

ZooKeeper_branch35_jdk7 - Build # 311 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/311/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 364610 lines...]
[junit] at 
org.apache.zookeeper.server.quorum.LearnerHandler.shutdown(LearnerHandler.java:877)
[junit] at 
org.apache.zookeeper.server.quorum.LearnerHandler.run(LearnerHandler.java:598)
[junit] 2015-05-31 10:56:08,141 [myid:] - WARN  
[LearnerHandler-/127.0.0.1:48389:LearnerHandler@879] - Ignoring unexpected 
exception
[junit] java.lang.InterruptedException
[junit] at 
java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireInterruptibly(AbstractQueuedSynchronizer.java:1219)
[junit] at 
java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:340)
[junit] at 
java.util.concurrent.LinkedBlockingQueue.put(LinkedBlockingQueue.java:338)
[junit] at 
org.apache.zookeeper.server.quorum.LearnerHandler.shutdown(LearnerHandler.java:877)
[junit] at 
org.apache.zookeeper.server.quorum.LearnerHandler.run(LearnerHandler.java:598)
[junit] 2015-05-31 10:56:08,141 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2015-05-31 10:56:08,142 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2015-05-31 10:56:08,142 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11363:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2015-05-31 10:56:08,142 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2015-05-31 10:56:08,143 [myid:] - INFO  
[QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:11363)(secure=disabled):MBeanRegistry@119]
 - Unregister MBean 
[org.apache.ZooKeeperService:name0=ReplicatedServer_id3,name1=replica.3,name2=Leader]
[junit] 2015-05-31 10:56:08,143 [myid:] - INFO  
[/127.0.0.1:11365:QuorumCnxManager$Listener@659] - Leaving listener
[junit] 2015-05-31 10:56:08,143 [myid:] - WARN  
[QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:11363)(secure=disabled):QuorumPeer@1039]
 - Unexpected exception
[junit] java.lang.InterruptedException
[junit] at java.lang.Object.wait(Native Method)
[junit] at 
org.apache.zookeeper.server.quorum.Leader.lead(Leader.java:559)
[junit] at 
org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:1036)
[junit] 2015-05-31 10:56:08,143 [myid:] - INFO  
[QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:11363)(secure=disabled):Leader@613] 
- Shutting down
[junit] 2015-05-31 10:56:08,143 [myid:] - WARN  
[QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:11363)(secure=disabled):QuorumPeer@1070]
 - PeerState set to LOOKING
[junit] 2015-05-31 10:56:08,143 [myid:] - WARN  
[QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:11363)(secure=disabled):QuorumPeer@1052]
 - QuorumPeer main thread exited
[junit] 2015-05-31 10:56:08,143 [myid:] - INFO  [main:QuorumUtil@254] - 
Shutting down leader election 
QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:11363)(secure=disabled)
[junit] 2015-05-31 10:56:08,143 [myid:] - INFO  
[QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:11363)(secure=disabled):MBeanRegistry@119]
 - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id3]
[junit] 2015-05-31 10:56:08,144 [myid:] - INFO  [main:QuorumUtil@259] - 
Waiting for QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:11363)(secure=disabled) 
to exit thread
[junit] 2015-05-31 10:56:08,144 [myid:] - INFO  
[QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:11363)(secure=disabled):MBeanRegistry@119]
 - Unregister MBean 
[org.apache.ZooKeeperService:name0=ReplicatedServer_id3,name1=replica.3]
[junit] 2015-05-31 10:56:08,144 [myid:] - INFO  
[QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:11363)(secure=disabled):MBeanRegistry@119]
 - Unregister MBean 
[org.apache.ZooKeeperService:name0=ReplicatedServer_id3,name1=replica.1]
[junit] 2015-05-31 10:56:08,144 [myid:] - INFO  
[QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:11363)(secure=disabled):MBeanRegistry@119]
 - Unregister MBean 
[org.apache.ZooKeeperService:name0=ReplicatedServer_id3,name1=replica.2]
[junit] 2015-05-31 10:56:08,144 [myid:] - INFO  
[main:FourLetterWordMain@63] - connecting to 127.0.0.1 11357
[junit] 2015-05-31 10:56:08,145 [myid:] - INFO  [main:QuorumUtil@243] - 
127.0.0.1:11357 is no longer accepting client connections
[junit] 2015-05-31 10:56:08,145 [myid:] - INFO  
[main:FourLetterWordMain@63] - connecting to 127.0.0.1 11360
[junit] 2015-05-31 10:56:08,145 [myid:] - INFO  [main:QuorumUtil@243] - 
127.0.0.1:11360 is no longer accepting client connections
[junit] 2015-05-31 10:56:08,145 [myid:] - INFO  
[main:FourLetterWordMain@63] - 

[jira] [Commented] (ZOOKEEPER-2197) non-ascii character in FinalRequestProcessor.java

[Flavio Junqueira (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566511#comment-14566511
 ] 

Flavio Junqueira commented on ZOOKEEPER-2197:
-

Hmm, I tried what you suggested but ant/javac complains:

{noformat}
compile:
[javac] Compiling 210 source files to 
/home/fpj/code/zookeeper-3.5.1-alpha/build/classes
[javac] javac: invalid flag: -Dfile.encoding=utf8
{noformat}

This change worked instead for me:

{noformat}







{noformat}

In general, is everyone happy that we change the encoding to utf-8? I 
personally don't see a big problem, but perhaps we should send a separate note 
to the dev list to see if anyone has a concern. What do you think? 


> non-ascii character in FinalRequestProcessor.java
> -
>
> Key: ZOOKEEPER-2197
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2197
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
>Priority: Minor
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2197.patch, ZOOKEEPER-2197.patch
>
>
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java:134: 
> error: unmappable character for encoding ASCII
> [javac] // was not being queued ??? ZOOKEEPER-558) properly. This 
> happens, for example,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk - Build # 2710 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/2710/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 373096 lines...]
 [exec] Log Message Received: [2015-05-31 
10:40:44,151:12168(0x2b76337c5540):ZOO_INFO@log_env@1002: Client 
environment:user.name=jenkins]
 [exec] Log Message Received: [2015-05-31 
10:40:44,152:12168(0x2b76337c5540):ZOO_INFO@log_env@1010: Client 
environment:user.home=/home/jenkins]
 [exec] Log Message Received: [2015-05-31 
10:40:44,152:12168(0x2b76337c5540):ZOO_INFO@log_env@1022: Client 
environment:user.dir=/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build/test/test-cppunit]
 [exec] Log Message Received: [2015-05-31 
10:40:44,152:12168(0x2b76337c5540):ZOO_INFO@zookeeper_init_internal@1065: 
Initiating client connection, host=127.0.0.1:22181 sessionTimeout=1 
watcher=0x45d2f0 sessionId=0 sessionPasswd= context=0x7fff85834ad0 
flags=0]
 [exec] Log Message Received: [2015-05-31 
10:40:44,152:12168(0x2b7635e54700):ZOO_INFO@check_events@2303: initiated 
connection to server [127.0.0.1:22181]]
 [exec] Log Message Received: [2015-05-31 
10:40:44,155:12168(0x2b7635e54700):ZOO_INFO@check_events@2355: session 
establishment complete on server [127.0.0.1:22181], 
sessionId=0x100d8333d4d000f, negotiated timeout=1 ]
 [exec]  : elapsed 1001 : OK
 [exec] Zookeeper_simpleSystem::testAsyncWatcherAutoReset ZooKeeper server 
started : elapsed 10095 : OK
 [exec] Zookeeper_simpleSystem::testDeserializeString : elapsed 0 : OK
 [exec] Zookeeper_simpleSystem::testFirstServerDown : elapsed 1001 : OK
 [exec] Zookeeper_simpleSystem::testNullData : elapsed 1022 : OK
 [exec] Zookeeper_simpleSystem::testIPV6 : elapsed 1003 : OK
 [exec] Zookeeper_simpleSystem::testCreate : elapsed 1007 : OK
 [exec] Zookeeper_simpleSystem::testPath : elapsed 1012 : OK
 [exec] Zookeeper_simpleSystem::testPathValidation : elapsed 1036 : OK
 [exec] Zookeeper_simpleSystem::testPing : elapsed 17162 : OK
 [exec] Zookeeper_simpleSystem::testAcl : elapsed 1011 : OK
 [exec] Zookeeper_simpleSystem::testChroot : elapsed 3034 : OK
 [exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started ZooKeeper 
server started : elapsed 30217 : OK
 [exec] Zookeeper_simpleSystem::testHangingClient : elapsed 1020 : OK
 [exec] Zookeeper_simpleSystem::testWatcherAutoResetWithGlobal ZooKeeper 
server started ZooKeeper server started ZooKeeper server started : elapsed 
14341 : OK
 [exec] Zookeeper_simpleSystem::testWatcherAutoResetWithLocal ZooKeeper 
server started ZooKeeper server started ZooKeeper server started : elapsed 
14379 : OK
 [exec] Zookeeper_simpleSystem::testGetChildren2 : elapsed 1029 : OK
 [exec] Zookeeper_simpleSystem::testLastZxid : elapsed 4511 : OK
 [exec] Zookeeper_simpleSystem::testRemoveWatchers ZooKeeper server started 
: elapsed 4143 : OK
 [exec] Zookeeper_readOnly::testReadOnly : elapsed 4079 : OK
 [exec] 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/tests/TestReconfig.cc:504:
 Assertion: equality assertion failed [Expected: 10.10.10.12:2012, Actual  : 
10.10.10.11:2011]
 [exec] Failures !!!
 [exec] Run: 72   Failure total: 1   Failures: 1   Errors: 0
 [exec] FAIL: zktest-mt
 [exec] ==
 [exec] 1 of 2 tests failed
 [exec] Please report to u...@zookeeper.apache.org
 [exec] ==
 [exec] make[1]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build/test/test-cppunit'
 [exec] make[1]: *** [check-TESTS] Error 1
 [exec] make: *** [check-am] Error 2

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build.xml:1489: The 
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build.xml:1449: The 
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build.xml:1459: 
exec returned: 2

Total time: 11 minutes 0 seconds
Build step 'Execute shell' marked build as failure
[FINDBUGS] Skipping publisher since build result is FAILURE
[WARNINGS] Skipping publisher since build result is FAILURE
Archiving artifacts
Sending artifact delta relative to ZooKeeper-trunk #2709
Archived 5 artifacts
Archive block size is 32768
Received 2 blocks and 18212497 bytes
Compression is 0.4%
Took 8.7 sec
Recording fingerprints
Recording test results
Publishing Javadoc
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
All tests passed

ZooKeeper-trunk-WinVS2008 - Build # 1816 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/1816/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 112 lines...]
   [javacc] File "SimpleCharStream.java" does not exist.  Will create one.
   [javacc] Parser generated successfully.

jute:
[javac] Compiling 39 source files to 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\build\classes

compile_jute_uptodate:

compile_jute:
[mkdir] Created dir: 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\java\generated
[mkdir] Created dir: 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\generated
 [java] ../../zookeeper.jute Parsed Successfully
 [java] ../../zookeeper.jute Parsed Successfully
[touch] Creating 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\java\generated\.generated

BUILD SUCCESSFUL
Total time: 8 seconds
[ZooKeeper-trunk-WinVS2008] $ cmd /c call 
C:\Windows\TEMP\hudson454221839826607340.bat

f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008>set 
ZOOKEEPER_HOME=f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk 

f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008>msbuild 
trunk/src/c/zookeeper.sln /p:Configuration=Release 
Microsoft (R) Build Engine version 4.0.30319.18408
[Microsoft .NET Framework, version 4.0.30319.18444]
Copyright (C) Microsoft Corporation. All rights reserved.

Building the projects in this solution one at a time. To enable parallel build, 
please add the "/m" switch.
Build started 5/31/2015 10:25:10 AM.
Project 
"f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln"
 on node 1 (default targets).
ValidateSolutionConfiguration:
  Building solution configuration "Release|Win32".
zookeeper:
  C:\Program Files (x86)\Microsoft Visual Studio 
9.0\Common7\IDE\..\..\vc\vcpackages\VCBuild.exe 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.vcproj
 "Release|Win32" 
cl : Command line warning D9035: option 'Wp64' has been deprecated and will be 
removed in a future release 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]
.\src\zookeeper.c(43): fatal error C1083: Cannot open include file: 'unistd.h': 
No such file or directory 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]
Cli:
  C:\Program Files (x86)\Microsoft Visual Studio 
9.0\Common7\IDE\..\..\vc\vcpackages\VCBuild.exe 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\Cli.vcproj
 "Release|Win32" 
Done Building Project 
"f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln"
 (default targets) -- FAILED.

Build FAILED.

"f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln"
 (default target) (1) ->
(zookeeper target) -> 
  cl : Command line warning D9035: option 'Wp64' has been deprecated and will 
be removed in a future release 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]


"f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln"
 (default target) (1) ->
(zookeeper target) -> 
  .\src\zookeeper.c(43): fatal error C1083: Cannot open include file: 
'unistd.h': No such file or directory 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]

1 Warning(s)
1 Error(s)

Time Elapsed 00:00:01.32

f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008>exit 1 
Build step 'Execute Windows batch command' marked build as failure
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2198) Set default test.junit.threads to 1.

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566480#comment-14566480
 ] 

Hudson commented on ZOOKEEPER-2198:
---

ABORTED: Integrated in ZooKeeper-trunk #2708 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/2708/])
ZOOKEEPER-2198 Set default test.junit.threads to 1 (Chris Nauroth via michim) 
(michim: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1682701)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/build.xml
* /zookeeper/trunk/src/java/test/bin/test-patch.sh


> Set default test.junit.threads to 1.
> 
>
> Key: ZOOKEEPER-2198
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2198
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
>Priority: Minor
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2198.001.patch
>
>
> Some systems are seeing test failures under concurrent execution.  This issue 
> proposes to change the default {{test.junit.threads}} to 1 so that those 
> environments continue to get consistent test runs.  Jenkins and individual 
> developer environments can set multiple threads with a command line argument, 
> so most environments will still get the benefit of faster test runs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2189) multiple leaders can be elected when configs conflict

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566479#comment-14566479
 ] 

Hudson commented on ZOOKEEPER-2189:
---

ABORTED: Integrated in ZooKeeper-trunk #2708 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/2708/])
ZOOKEEPER-2189: QuorumCnxManager: use BufferedOutputStream for initial msg
(Raul Gutierrez Segales via hdeng) (hdeng: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1682623)
* /zookeeper/trunk/CHANGES.txt


> multiple leaders can be elected when configs conflict
> -
>
> Key: ZOOKEEPER-2189
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2189
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: leaderElection
>Affects Versions: 3.5.0
>Reporter: Akihiro Suda
>
> This sequence leads the ensemble to a split-brain state:
>  * Start server 1 (config=1:participant, 2:participant, 3:participant)
>  * Start server 2 (config=1:participant, 2:participant, 3:participant)
>  * 1 and 2 believe 2 is the leader
>  * Start server 3 (config=1:observer, 2:observer, 3:participant)
>  * 3 believes 3 is the leader, although 1 and 2 still believe 2 is the leader
> Such a split-brain ensemble is very unstable.
> Znodes can be lost easily:
>  * Create some znodes on 2
>  * Restart 1 and 2
>  * 1, 2 and 3 can think 3 is the leader
>  * znodes created on 2 are lost, as 1 and 2 sync with 3
> I consider this behavior as a bug and that ZK should fail gracefully if a 
> participant is listed as an observer in the config.
> In current implementation, ZK cannot detect such an invalid config, as 
> FastLeaderElection.sendNotification() sends notifications to only voting 
> members and hence there is no message from observers(1 and 2) to the new 
> voter (3).
> I think FastLeaderElection.sendNotification() should send notifications to 
> all the members and FastLeaderElection.Messenger.WorkerReceiver.run() should 
> verify acks.
> Any thoughts?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2198) Set default test.junit.threads to 1.

[Michi Mutsuzaki (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566474#comment-14566474
 ] 

Michi Mutsuzaki commented on ZOOKEEPER-2198:


+1 Thanks Chris!

> Set default test.junit.threads to 1.
> 
>
> Key: ZOOKEEPER-2198
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2198
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
>Priority: Minor
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2198.001.patch
>
>
> Some systems are seeing test failures under concurrent execution.  This issue 
> proposes to change the default {{test.junit.threads}} to 1 so that those 
> environments continue to get consistent test runs.  Jenkins and individual 
> developer environments can set multiple threads with a command line argument, 
> so most environments will still get the benefit of faster test runs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk-WinVS2008 - Build # 1815 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/1815/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 108 lines...]
   [javacc] File "SimpleCharStream.java" does not exist.  Will create one.
   [javacc] Parser generated successfully.

jute:
[javac] Compiling 39 source files to 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\build\classes

compile_jute_uptodate:

compile_jute:
[mkdir] Created dir: 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\java\generated
[mkdir] Created dir: 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\generated
 [java] ../../zookeeper.jute Parsed Successfully
 [java] ../../zookeeper.jute Parsed Successfully
[touch] Creating 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\java\generated\.generated

BUILD SUCCESSFUL
Total time: 11 seconds
[ZooKeeper-trunk-WinVS2008] $ cmd /c call 
C:\Windows\TEMP\hudson1294754451157107762.bat

f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008>set 
ZOOKEEPER_HOME=f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk 

f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008>msbuild 
trunk/src/c/zookeeper.sln /p:Configuration=Release 
Microsoft (R) Build Engine version 4.0.30319.18408
[Microsoft .NET Framework, version 4.0.30319.18444]
Copyright (C) Microsoft Corporation. All rights reserved.

Building the projects in this solution one at a time. To enable parallel build, 
please add the "/m" switch.
Build started 5/31/2015 9:03:13 AM.
Project 
"f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln"
 on node 1 (default targets).
ValidateSolutionConfiguration:
  Building solution configuration "Release|Win32".
zookeeper:
  C:\Program Files (x86)\Microsoft Visual Studio 
9.0\Common7\IDE\..\..\vc\vcpackages\VCBuild.exe 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.vcproj
 "Release|Win32" 
cl : Command line warning D9035: option 'Wp64' has been deprecated and will be 
removed in a future release 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]
.\src\zookeeper.c(43): fatal error C1083: Cannot open include file: 'unistd.h': 
No such file or directory 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]
Cli:
  C:\Program Files (x86)\Microsoft Visual Studio 
9.0\Common7\IDE\..\..\vc\vcpackages\VCBuild.exe 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\Cli.vcproj
 "Release|Win32" 
Done Building Project 
"f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln"
 (default targets) -- FAILED.

Build FAILED.

"f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln"
 (default target) (1) ->
(zookeeper target) -> 
  cl : Command line warning D9035: option 'Wp64' has been deprecated and will 
be removed in a future release 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]


"f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln"
 (default target) (1) ->
(zookeeper target) -> 
  .\src\zookeeper.c(43): fatal error C1083: Cannot open include file: 
'unistd.h': No such file or directory 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]

1 Warning(s)
1 Error(s)

Time Elapsed 00:00:08.30

f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008>exit 1 
Build step 'Execute Windows batch command' marked build as failure
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

Failed: ZOOKEEPER-2197 PreCommit Build #2728

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2197
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2728/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 368689 lines...]
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2728//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2728//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2728//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 256f9cd98093cda9596661b5732e644bdefdb718 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1782:
 exec returned: 2

Total time: 8 minutes 2 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2724
Archived 7 artifacts
Archive block size is 32768
Received 4 blocks and 432177 bytes
Compression is 23.3%
Took 4.6 sec
Recording test results
Publish JUnit test result report is waiting for a checkpoint on 
PreCommit-ZOOKEEPER-Build #2727
Description set: ZOOKEEPER-2197
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
1 tests failed.
REGRESSION:  org.apache.zookeeper.test.ReconfigTest.testPortChange

Error Message:
expected: but was:

Stack Trace:
junit.framework.AssertionFailedError: expected: but was:
at 
org.apache.zookeeper.test.ReconfigTest.testNormalOperation(ReconfigTest.java:150)
at 
org.apache.zookeeper.test.ReconfigTest.testPortChange(ReconfigTest.java:598)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55)

[jira] [Commented] (ZOOKEEPER-2198) Set default test.junit.threads to 1.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566443#comment-14566443
 ] 

Hadoop QA commented on ZOOKEEPER-2198:
--

+1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12736407/ZOOKEEPER-2198.001.patch
  against trunk revision 1682623.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 4 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2727//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2727//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2727//console

This message is automatically generated.

> Set default test.junit.threads to 1.
> 
>
> Key: ZOOKEEPER-2198
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2198
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
>Priority: Minor
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2198.001.patch
>
>
> Some systems are seeing test failures under concurrent execution.  This issue 
> proposes to change the default {{test.junit.threads}} to 1 so that those 
> environments continue to get consistent test runs.  Jenkins and individual 
> developer environments can set multiple threads with a command line argument, 
> so most environments will still get the benefit of faster test runs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Success: ZOOKEEPER-2198 PreCommit Build #2727

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2198
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2727/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 369212 lines...]
 [exec] +1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12736407/ZOOKEEPER-2198.001.patch
 [exec]   against trunk revision 1682623.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 4 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2727//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2727//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2727//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 2b7587e79f5e41e7e9acebcdfa9bde7a01f85d47 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 48 minutes 40 seconds
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2724
Archived 24 artifacts
Archive block size is 32768
Received 4 blocks and 33926124 bytes
Compression is 0.4%
Took 11 sec
Recording test results
Description set: ZOOKEEPER-2198
Email was triggered for: Success
Sending email for trigger: Success



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2197) non-ascii character in FinalRequestProcessor.java

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566419#comment-14566419
 ] 

Hadoop QA commented on ZOOKEEPER-2197:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12736412/ZOOKEEPER-2197.patch
  against trunk revision 1682623.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2728//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2728//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2728//console

This message is automatically generated.

> non-ascii character in FinalRequestProcessor.java
> -
>
> Key: ZOOKEEPER-2197
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2197
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
>Priority: Minor
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2197.patch, ZOOKEEPER-2197.patch
>
>
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java:134: 
> error: unmappable character for encoding ASCII
> [javac] // was not being queued ??? ZOOKEEPER-558) properly. This 
> happens, for example,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2197) non-ascii character in FinalRequestProcessor.java

[Michi Mutsuzaki (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michi Mutsuzaki updated ZOOKEEPER-2197:
---
Attachment: ZOOKEEPER-2197.patch

> non-ascii character in FinalRequestProcessor.java
> -
>
> Key: ZOOKEEPER-2197
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2197
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
>Priority: Minor
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2197.patch, ZOOKEEPER-2197.patch
>
>
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java:134: 
> error: unmappable character for encoding ASCII
> [javac] // was not being queued ??? ZOOKEEPER-558) properly. This 
> happens, for example,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2197) non-ascii character in FinalRequestProcessor.java

[Raul Gutierrez Segales (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566413#comment-14566413
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-2197:
---

yup. something like (untested) this:

{code}








{code}

> non-ascii character in FinalRequestProcessor.java
> -
>
> Key: ZOOKEEPER-2197
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2197
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
>Priority: Minor
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2197.patch
>
>
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java:134: 
> error: unmappable character for encoding ASCII
> [javac] // was not being queued ??? ZOOKEEPER-558) properly. This 
> happens, for example,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2197) non-ascii character in FinalRequestProcessor.java

[Raul Gutierrez Segales (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566412#comment-14566412
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-2197:
---

yup. something like (untested) this:

{code}








{code}

> non-ascii character in FinalRequestProcessor.java
> -
>
> Key: ZOOKEEPER-2197
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2197
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
>Priority: Minor
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2197.patch
>
>
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java:134: 
> error: unmappable character for encoding ASCII
> [javac] // was not being queued ??? ZOOKEEPER-558) properly. This 
> happens, for example,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2197) non-ascii character in FinalRequestProcessor.java

[Raul Gutierrez Segales (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566414#comment-14566414
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-2197:
---

yup. something like (untested) this:

{code}








{code}

> non-ascii character in FinalRequestProcessor.java
> -
>
> Key: ZOOKEEPER-2197
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2197
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
>Priority: Minor
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2197.patch
>
>
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java:134: 
> error: unmappable character for encoding ASCII
> [javac] // was not being queued ??? ZOOKEEPER-558) properly. This 
> happens, for example,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2164) fast leader election keeps failing

[Michi Mutsuzaki (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michi Mutsuzaki updated ZOOKEEPER-2164:
---
Fix Version/s: 3.6.0
   3.5.2

> fast leader election keeps failing
> --
>
> Key: ZOOKEEPER-2164
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2164
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: leaderElection
>Affects Versions: 3.4.5
>Reporter: Michi Mutsuzaki
>Assignee: Hongchao Deng
> Fix For: 3.5.2, 3.6.0
>
>
> I have a 3-node cluster with sids 1, 2 and 3. Originally 2 is the leader. 
> When I shut down 2, 1 and 3 keep going back to leader election. Here is what 
> seems to be happening.
> - Both 1 and 3 elect 3 as the leader.
> - 1 receives votes from 3 and itself, and starts trying to connect to 3 as a 
> follower.
> - 3 doesn't receive votes for 5 seconds because connectOne() to 2 doesn't 
> timeout for 5 seconds: 
> https://github.com/apache/zookeeper/blob/41c9fcb3ca09cd3d05e59fe47f08ecf0b85532c8/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L346
> - By the time 3 receives votes, 1 has given up trying to connect to 3: 
> https://github.com/apache/zookeeper/blob/41c9fcb3ca09cd3d05e59fe47f08ecf0b85532c8/src/java/main/org/apache/zookeeper/server/quorum/Learner.java#L247
> I'm using 3.4.5, but it looks like this part of the code hasn't changed for a 
> while, so I'm guessing later versions have the same issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)