[jira] [Commented] (ZOOKEEPER-2205) Log type of unexpected quorum packet in learner handler loop
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574101#comment-14574101 ] Hitoshi Mitake commented on ZOOKEEPER-2205: --- Hi, The problem in the Observer class is similar but not directly related to this issue. Could you open your own issue and send patch to the new one? > Log type of unexpected quorum packet in learner handler loop > > > Key: ZOOKEEPER-2205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2205 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Attachments: ZOOKEEPER-2205-v2.patch, ZOOKEEPER-2205-v3.patch, > ZOOKEEPER-2205-v4.patch, ZOOKEEPER-2205.patch > > > Current learner handler loop doesn't log anything when it receives unexpected > type of quorum packet from learner. > This patch lets the learner handler loop log the type of packet for defensive > purpose. It would make debugging and trouble shooting a little bit easier. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2205) Log type of unexpected quorum packet in learner handler loop
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hitoshi Mitake updated ZOOKEEPER-2205: -- Attachment: ZOOKEEPER-2205-v4.patch > Log type of unexpected quorum packet in learner handler loop > > > Key: ZOOKEEPER-2205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2205 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Attachments: ZOOKEEPER-2205-v2.patch, ZOOKEEPER-2205-v3.patch, > ZOOKEEPER-2205-v4.patch, ZOOKEEPER-2205.patch > > > Current learner handler loop doesn't log anything when it receives unexpected > type of quorum packet from learner. > This patch lets the learner handler loop log the type of packet for defensive > purpose. It would make debugging and trouble shooting a little bit easier. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2205) Log type of unexpected quorum packet in learner handler loop
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574102#comment-14574102 ] Hitoshi Mitake commented on ZOOKEEPER-2205: --- Hi [~rgs], Thanks for your review! I attached v4 patch based on your comments. > Log type of unexpected quorum packet in learner handler loop > > > Key: ZOOKEEPER-2205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2205 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Attachments: ZOOKEEPER-2205-v2.patch, ZOOKEEPER-2205-v3.patch, > ZOOKEEPER-2205-v4.patch, ZOOKEEPER-2205.patch > > > Current learner handler loop doesn't log anything when it receives unexpected > type of quorum packet from learner. > This patch lets the learner handler loop log the type of packet for defensive > purpose. It would make debugging and trouble shooting a little bit easier. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2207) Enhance error logs with LearnerHandler.packetToString()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hitoshi Mitake updated ZOOKEEPER-2207: -- Attachment: ZOOKEEPER-2207-v2.patch > Enhance error logs with LearnerHandler.packetToString() > --- > > Key: ZOOKEEPER-2207 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2207 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Attachments: ZOOKEEPER-2207-v2.patch, ZOOKEEPER-2207.patch > > > This patch enhances error logs related to unexpected types of QuorumPacket > with LearnerHandler.packetToString(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2207) Enhance error logs with LearnerHandler.packetToString()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574109#comment-14574109 ] Hitoshi Mitake commented on ZOOKEEPER-2207: --- Hi [~rgs], Thanks for your review! I attached v2 patch based on your comments. BTW, I fixed the unconditional return branch problem in the v4 patch of ZOOKEEPER-2205 (https://issues.apache.org/jira/browse/ZOOKEEPER-2205). Should I remove the return branch in this 2207? If I should do so, I'll fix both of the patches in 2205 and 2207. > Enhance error logs with LearnerHandler.packetToString() > --- > > Key: ZOOKEEPER-2207 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2207 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Attachments: ZOOKEEPER-2207-v2.patch, ZOOKEEPER-2207.patch > > > This patch enhances error logs related to unexpected types of QuorumPacket > with LearnerHandler.packetToString(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZOOKEEPER-2208) Log type of unexpected quorum packet in observer loop
Akihiro Suda created ZOOKEEPER-2208: --- Summary: Log type of unexpected quorum packet in observer loop Key: ZOOKEEPER-2208 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2208 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: Akihiro Suda Assignee: Hitoshi Mitake Priority: Trivial Current learner handler loop doesn't log anything when it receives unexpected type of quorum packet from learner. This patch lets the learner handler loop log the type of packet for defensive purpose. It would make debugging and trouble shooting a little bit easier. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2208) Log type of unexpected quorum packet in observer loop
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akihiro Suda updated ZOOKEEPER-2208: Description: This patch lets the observer loop log the type of packet for debugging. This issue is a clone of was: Current learner handler loop doesn't log anything when it receives unexpected type of quorum packet from learner. This patch lets the learner handler loop log the type of packet for defensive purpose. It would make debugging and trouble shooting a little bit easier. > Log type of unexpected quorum packet in observer loop > - > > Key: ZOOKEEPER-2208 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2208 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Akihiro Suda >Assignee: Hitoshi Mitake >Priority: Trivial > > This patch lets the observer loop log the type of packet for debugging. > This issue is a clone of -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2208) Log type of unexpected quorum packet in observer loop
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akihiro Suda updated ZOOKEEPER-2208: Attachment: ZOOKEEPER-2208.patch > Log type of unexpected quorum packet in observer loop > - > > Key: ZOOKEEPER-2208 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2208 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Akihiro Suda >Assignee: Hitoshi Mitake >Priority: Trivial > Attachments: ZOOKEEPER-2208.patch > > > This patch lets the observer loop log the type of packet for debugging. > This issue is tightly related to ZOOKEEPER-2205 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2208) Log type of unexpected quorum packet in observer loop
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akihiro Suda updated ZOOKEEPER-2208: Description: This patch lets the observer loop log the type of packet for debugging. This issue is tightly related to ZOOKEEPER-2205 was: This patch lets the observer loop log the type of packet for debugging. This issue is a clone of > Log type of unexpected quorum packet in observer loop > - > > Key: ZOOKEEPER-2208 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2208 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Akihiro Suda >Assignee: Hitoshi Mitake >Priority: Trivial > Attachments: ZOOKEEPER-2208.patch > > > This patch lets the observer loop log the type of packet for debugging. > This issue is tightly related to ZOOKEEPER-2205 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2205) Log type of unexpected quorum packet in learner handler loop
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574123#comment-14574123 ] Akihiro Suda commented on ZOOKEEPER-2205: - OK, I move to ZOOKEEPER-2208. > Log type of unexpected quorum packet in learner handler loop > > > Key: ZOOKEEPER-2205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2205 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Attachments: ZOOKEEPER-2205-v2.patch, ZOOKEEPER-2205-v3.patch, > ZOOKEEPER-2205-v4.patch, ZOOKEEPER-2205.patch > > > Current learner handler loop doesn't log anything when it receives unexpected > type of quorum packet from learner. > This patch lets the learner handler loop log the type of packet for defensive > purpose. It would make debugging and trouble shooting a little bit easier. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2205) Log type of unexpected quorum packet in learner handler loop
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574128#comment-14574128 ] Akihiro Suda commented on ZOOKEEPER-2205: - Hi, Thank you for the comment. You are right in regard to this issue. I would be happy if we could discuss other possible cases in ZOOKEEPER-2162. > Log type of unexpected quorum packet in learner handler loop > > > Key: ZOOKEEPER-2205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2205 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Attachments: ZOOKEEPER-2205-v2.patch, ZOOKEEPER-2205-v3.patch, > ZOOKEEPER-2205-v4.patch, ZOOKEEPER-2205.patch > > > Current learner handler loop doesn't log anything when it receives unexpected > type of quorum packet from learner. > This patch lets the learner handler loop log the type of packet for defensive > purpose. It would make debugging and trouble shooting a little bit easier. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1922) Negative min latency value
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574182#comment-14574182 ] Hari Sekhon commented on ZOOKEEPER-1922: This has been reported for my check_zookeeper.pl Nagios plugin too: https://github.com/harisekhon/nagios-plugins/issues/51 Apparently doing an 'srst' to reset the stats fixes it. I wouldn't be surprised if this was due to correcting a server's time in a sudden large step via ntpdate. I've worked around this in my code by resetting the returned value to N/A and notifying the user to do 'srst'. The more I think about this the more it seems like a minor ZooKeeper bug in not checking whether min latency < 0 for sanity. I propose a simple fix that ZooKeeper check < 0 and if so do an internal 'srst' on it's stats. > Negative min latency value > -- > > Key: ZOOKEEPER-1922 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1922 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.4.6 >Reporter: J Potter >Priority: Minor > > We're seeing the output of stat on one node return a negative value for min > latency time: > stat > Zookeeper version: 3.4.6-1569965, built on 02/20/2014 09:09 GMT > Clients: > ... > Latency min/avg/max: -477/149/261002 > (The max value seems suspicious, too.) > Figured I'd report this, as I don't see any mention of it online or in other > bug reports. Maybe negative values shouldn't be recorded? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
ZooKeeper_branch35_jdk7 - Build # 316 - Failure
See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/316/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 373624 lines...] [junit] 2015-06-05 10:09:24,810 [myid:] - WARN [LearnerHandler-/127.0.0.1:39654:LearnerHandler@879] - Ignoring unexpected exception [junit] java.lang.InterruptedException [junit] at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireInterruptibly(AbstractQueuedSynchronizer.java:1219) [junit] at java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:340) [junit] at java.util.concurrent.LinkedBlockingQueue.put(LinkedBlockingQueue.java:338) [junit] at org.apache.zookeeper.server.quorum.LearnerHandler.shutdown(LearnerHandler.java:877) [junit] at org.apache.zookeeper.server.quorum.LearnerHandler.run(LearnerHandler.java:598) [junit] 2015-06-05 10:09:24,810 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2015-06-05 10:09:24,810 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:30214:NIOServerCnxnFactory$AcceptThread@219] - accept thread exitted run method [junit] 2015-06-05 10:09:24,810 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2015-06-05 10:09:24,811 [myid:] - INFO [/127.0.0.1:30216:QuorumCnxManager$Listener@659] - Leaving listener [junit] 2015-06-05 10:09:24,811 [myid:] - INFO [QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:30214)(secure=disabled):MBeanRegistry@119] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id3,name1=replica.3,name2=Leader] [junit] 2015-06-05 10:09:24,812 [myid:] - INFO [main:QuorumUtil@254] - Shutting down leader election QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:30214)(secure=disabled) [junit] 2015-06-05 10:09:24,812 [myid:] - WARN [QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:30214)(secure=disabled):QuorumPeer@1039] - Unexpected exception [junit] java.lang.InterruptedException [junit] at java.lang.Object.wait(Native Method) [junit] at org.apache.zookeeper.server.quorum.Leader.lead(Leader.java:559) [junit] at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:1036) [junit] 2015-06-05 10:09:24,812 [myid:] - INFO [QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:30214)(secure=disabled):Leader@613] - Shutting down [junit] 2015-06-05 10:09:24,812 [myid:] - WARN [QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:30214)(secure=disabled):QuorumPeer@1070] - PeerState set to LOOKING [junit] 2015-06-05 10:09:24,812 [myid:] - WARN [QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:30214)(secure=disabled):QuorumPeer@1052] - QuorumPeer main thread exited [junit] 2015-06-05 10:09:24,812 [myid:] - INFO [QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:30214)(secure=disabled):MBeanRegistry@119] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id3] [junit] 2015-06-05 10:09:24,812 [myid:] - INFO [main:QuorumUtil@259] - Waiting for QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:30214)(secure=disabled) to exit thread [junit] 2015-06-05 10:09:24,813 [myid:] - INFO [QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:30214)(secure=disabled):MBeanRegistry@119] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id3,name1=replica.3] [junit] 2015-06-05 10:09:24,813 [myid:] - INFO [QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:30214)(secure=disabled):MBeanRegistry@119] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id3,name1=replica.1] [junit] 2015-06-05 10:09:24,813 [myid:] - INFO [QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:30214)(secure=disabled):MBeanRegistry@119] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id3,name1=replica.2] [junit] 2015-06-05 10:09:24,813 [myid:] - INFO [main:FourLetterWordMain@63] - connecting to 127.0.0.1 30208 [junit] 2015-06-05 10:09:24,814 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:30208 is no longer accepting client connections [junit] 2015-06-05 10:09:24,814 [myid:] - INFO [main:FourLetterWordMain@63] - connecting to 127.0.0.1 30211 [junit] 2015-06-05 10:09:24,814 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:30211 is no longer accepting client connections [junit] 2015-06-05 10:09:24,814 [myid:] - INFO [main:FourLetterWordMain@63] - connecting to 127.0.0.1 30214 [junit] 2015-06-05 10:09:24,815 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:30214 is no longer accepting client connections [junit] 2015-06-05 10:09:24,816 [myid:] - INFO [main:ZKTestCase$1@65] - SUCCEEDED testJMXBeanAfterRoleChange [junit] 2015-06-05 10:09:24,816 [myid:] - INFO [main:ZKTestCase$1@60] - FINISHED
[jira] [Commented] (ZOOKEEPER-2194) Let DataNode.getChildren() return an unmodifiable view of its children set
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574298#comment-14574298 ] Hudson commented on ZOOKEEPER-2194: --- SUCCESS: Integrated in ZooKeeper-trunk #2716 (See [https://builds.apache.org/job/ZooKeeper-trunk/2716/]) ZOOKEEPER-2194: Let DataNode.getChildren() return an unmodifiable view of its children set (Hitoshi Mitake via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1683587) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/DataNode.java > Let DataNode.getChildren() return an unmodifiable view of its children set > -- > > Key: ZOOKEEPER-2194 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2194 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Fix For: 3.4.7, 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2194-v2.patch, ZOOKEEPER-2194.patch > > > Current DataNode.getChildren() directly returns a pointer of its private > member, children. However, the member should be modified through addChild() > and removeChild(). Callers of getChildren() shouldn't modify it directly. > For preventing the direct modification by the callers, this patch lets > getChildren() return an unmodifiable view of its children set. If the callers > try to modify directly, runtime exception will be risen. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2204) LearnerSnapshotThrottlerTest.testHighContentionWithTimeout fails occasionally
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574296#comment-14574296
]
Hudson commented on ZOOKEEPER-2204:
---
SUCCESS: Integrated in ZooKeeper-trunk #2716 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2716/])
ZOOKEEPER-2204: LearnerSnapshotThrottlerTest.testHighContentionWithTimeout
fails occasionally (Donny Nadolny via rgs) (rgs:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1683602)
* /zookeeper/trunk/CHANGES.txt
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/LearnerSnapshotThrottlerTest.java
> LearnerSnapshotThrottlerTest.testHighContentionWithTimeout fails occasionally
> -
>
> Key: ZOOKEEPER-2204
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2204
> Project: ZooKeeper
> Issue Type: Test
>Affects Versions: 3.5.0
>Reporter: Donny Nadolny
>Assignee: Donny Nadolny
>Priority: Minor
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2204.patch, ZOOKEEPER-2204.patch
>
>
> The {{LearnerSnapshotThrottler}} will only allow 2 concurrent snapshots to be
> taken, and if there are already 2 snapshots in progress it will wait up to
> 200ms for one to complete. This isn't enough time for
> {{testHighContentionWithTimeout}} to consistently pass - on a cold JVM
> running just the one test I was able to get it to fail 3 times in around 50
> runs. This 200ms timeout will be hit if there is a delay between a thread
> calling {{LearnerSnapshot snap = throttler.beginSnapshot(false);}} and
> {{throttler.endSnapshot();}}.
> This also erroneously fails on the build server, see
> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2747/testReport/org.apache.zookeeper.server.quorum/LearnerSnapshotThrottlerTest/testHighContentionWithTimeout/
> for an example.
> I have bumped the timeout up to 5 seconds (which should be more than enough
> for warmup / gc pauses), as well as added logging to the {{catch (Exception
> e)}} block to assist in debugging any future issues.
> An alternate approach would be to separate out results gathered from the
> threads, because although we only record true/false there are really three
> outcomes:
> 1. The {{snapshotNumber}} was <= 2, meaning the individual call operated
> correctly
> 2. The {{snapshotNumber}} was > 2, meaning the test should definitely fail
> 3. We were unable to snapshot in the time given, so we can't determine if we
> should fail or pass (although if we have "enough" successes from #1 with no
> failures from #2 maybe we would pass the test anyway).
> Bumping up the timeout is easier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2163) Introduce new ZNode type: container
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574297#comment-14574297
]
Hudson commented on ZOOKEEPER-2163:
---
SUCCESS: Integrated in ZooKeeper-trunk #2716 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2716/])
ZOOKEEPER-2163: Introduce new ZNode type: container
(Jordan Zimmerman via rgs) (rgs:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1683605)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml
*
/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/CreateMode.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/MultiTransactionRecord.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/Op.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooDefs.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/CreateCommand.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ContainerManager.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/Request.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/TraceFormatter.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/CreateContainerTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/CreateModeTest.java
* /zookeeper/trunk/src/zookeeper.jute
> Introduce new ZNode type: container
> ---
>
> Key: ZOOKEEPER-2163
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2163
> Project: ZooKeeper
> Issue Type: New Feature
> Components: c client, java client, server
>Affects Versions: 3.5.0
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
> Fix For: 3.6.0
>
> Attachments: zookeeper-2163.10.patch, zookeeper-2163.11.patch,
> zookeeper-2163.12.patch, zookeeper-2163.13.patch, zookeeper-2163.14.patch,
> zookeeper-2163.3.patch, zookeeper-2163.5.patch, zookeeper-2163.6.patch,
> zookeeper-2163.7.patch, zookeeper-2163.8.patch, zookeeper-2163.9.patch
>
>
> BACKGROUND
>
> A recurring problem for ZooKeeper users is garbage collection of parent
> nodes. Many recipes (e.g. locks, leaders, etc.) call for the creation of a
> parent node under which participants create sequential nodes. When the
> participant is done, it deletes its node. In practice, the ZooKeeper tree
> begins to fill up with orphaned parent nodes that are no longer needed. The
> ZooKeeper APIs don’t provide a way to clean these. Over time, ZooKeeper can
> become unstable due to the number of these nodes.
> CURRENT SOLUTIONS
> ===
> Apache Curator has a workaround solution for this by providing the Reaper
> class which runs in the background looking for orphaned parent nodes and
> deleting them. This isn’t ideal and it would be better if ZooKeeper supported
> this directly.
> PROPOSAL
> =
> ZOOKEEPER-723 and ZOOKEEPER-834 have been proposed to allow EPHEMERAL nodes
> to contain child nodes. This is not optimum as EPHEMERALs are tied to a
> session and the general use case of parent nodes is for PERSISTENT nodes.
> This proposal adds a new node type, CONTAINER. A CONTAINER node is the same
> as a PERSISTENT node with the additional property that when its last child is
> deleted, it is deleted (and CONTAINER nodes recursively up the tree are
> deleted if empty).
> CANONICAL USAGE
>
> {code}
> while ( true) { // or some reasonable limit
> try {
> zk.create(path, ...);
> break;
> } catch ( KeeperException.NoNodeException e ) {
> try {
> zk.createContainer(containerPath, ...);
> } catch ( KeeperException.NodeExistsExce
[jira] [Commented] (ZOOKEEPER-2163) Introduce new ZNode type: container
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574414#comment-14574414
]
Rakesh R commented on ZOOKEEPER-2163:
-
Should we write different release version in 3.5 branch and trunk ? like {{New
in 3.5.2}} and {{New in 3.6.0}}. IMHO we could write the same releasing version
in both 3.5 branch and trunk. If this is planning for 3.5.2 then say {{New in
3.5.2}} in 3.5 branch as well as trunk.
> Introduce new ZNode type: container
> ---
>
> Key: ZOOKEEPER-2163
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2163
> Project: ZooKeeper
> Issue Type: New Feature
> Components: c client, java client, server
>Affects Versions: 3.5.0
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
> Fix For: 3.6.0
>
> Attachments: zookeeper-2163.10.patch, zookeeper-2163.11.patch,
> zookeeper-2163.12.patch, zookeeper-2163.13.patch, zookeeper-2163.14.patch,
> zookeeper-2163.3.patch, zookeeper-2163.5.patch, zookeeper-2163.6.patch,
> zookeeper-2163.7.patch, zookeeper-2163.8.patch, zookeeper-2163.9.patch
>
>
> BACKGROUND
>
> A recurring problem for ZooKeeper users is garbage collection of parent
> nodes. Many recipes (e.g. locks, leaders, etc.) call for the creation of a
> parent node under which participants create sequential nodes. When the
> participant is done, it deletes its node. In practice, the ZooKeeper tree
> begins to fill up with orphaned parent nodes that are no longer needed. The
> ZooKeeper APIs don’t provide a way to clean these. Over time, ZooKeeper can
> become unstable due to the number of these nodes.
> CURRENT SOLUTIONS
> ===
> Apache Curator has a workaround solution for this by providing the Reaper
> class which runs in the background looking for orphaned parent nodes and
> deleting them. This isn’t ideal and it would be better if ZooKeeper supported
> this directly.
> PROPOSAL
> =
> ZOOKEEPER-723 and ZOOKEEPER-834 have been proposed to allow EPHEMERAL nodes
> to contain child nodes. This is not optimum as EPHEMERALs are tied to a
> session and the general use case of parent nodes is for PERSISTENT nodes.
> This proposal adds a new node type, CONTAINER. A CONTAINER node is the same
> as a PERSISTENT node with the additional property that when its last child is
> deleted, it is deleted (and CONTAINER nodes recursively up the tree are
> deleted if empty).
> CANONICAL USAGE
>
> {code}
> while ( true) { // or some reasonable limit
> try {
> zk.create(path, ...);
> break;
> } catch ( KeeperException.NoNodeException e ) {
> try {
> zk.createContainer(containerPath, ...);
> } catch ( KeeperException.NodeExistsException ignore) {
>}
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2163) Introduce new ZNode type: container
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574686#comment-14574686
]
Jordan Zimmerman commented on ZOOKEEPER-2163:
-
I'm hoping to get it ported to 3.4.7 so, maybe use that number.
> Introduce new ZNode type: container
> ---
>
> Key: ZOOKEEPER-2163
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2163
> Project: ZooKeeper
> Issue Type: New Feature
> Components: c client, java client, server
>Affects Versions: 3.5.0
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
> Fix For: 3.6.0
>
> Attachments: zookeeper-2163.10.patch, zookeeper-2163.11.patch,
> zookeeper-2163.12.patch, zookeeper-2163.13.patch, zookeeper-2163.14.patch,
> zookeeper-2163.3.patch, zookeeper-2163.5.patch, zookeeper-2163.6.patch,
> zookeeper-2163.7.patch, zookeeper-2163.8.patch, zookeeper-2163.9.patch
>
>
> BACKGROUND
>
> A recurring problem for ZooKeeper users is garbage collection of parent
> nodes. Many recipes (e.g. locks, leaders, etc.) call for the creation of a
> parent node under which participants create sequential nodes. When the
> participant is done, it deletes its node. In practice, the ZooKeeper tree
> begins to fill up with orphaned parent nodes that are no longer needed. The
> ZooKeeper APIs don’t provide a way to clean these. Over time, ZooKeeper can
> become unstable due to the number of these nodes.
> CURRENT SOLUTIONS
> ===
> Apache Curator has a workaround solution for this by providing the Reaper
> class which runs in the background looking for orphaned parent nodes and
> deleting them. This isn’t ideal and it would be better if ZooKeeper supported
> this directly.
> PROPOSAL
> =
> ZOOKEEPER-723 and ZOOKEEPER-834 have been proposed to allow EPHEMERAL nodes
> to contain child nodes. This is not optimum as EPHEMERALs are tied to a
> session and the general use case of parent nodes is for PERSISTENT nodes.
> This proposal adds a new node type, CONTAINER. A CONTAINER node is the same
> as a PERSISTENT node with the additional property that when its last child is
> deleted, it is deleted (and CONTAINER nodes recursively up the tree are
> deleted if empty).
> CANONICAL USAGE
>
> {code}
> while ( true) { // or some reasonable limit
> try {
> zk.create(path, ...);
> break;
> } catch ( KeeperException.NoNodeException e ) {
> try {
> zk.createContainer(containerPath, ...);
> } catch ( KeeperException.NodeExistsException ignore) {
>}
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2205) Log type of unexpected quorum packet in learner handler loop
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-2205: -- Affects Version/s: 3.4.6 3.5.0 > Log type of unexpected quorum packet in learner handler loop > > > Key: ZOOKEEPER-2205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2205 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Attachments: ZOOKEEPER-2205-v2.patch, ZOOKEEPER-2205-v3.patch, > ZOOKEEPER-2205-v4.patch, ZOOKEEPER-2205.patch > > > Current learner handler loop doesn't log anything when it receives unexpected > type of quorum packet from learner. > This patch lets the learner handler loop log the type of packet for defensive > purpose. It would make debugging and trouble shooting a little bit easier. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2205) Log type of unexpected quorum packet in learner handler loop
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-2205: -- Fix Version/s: 3.6.0 3.5.1 3.4.7 > Log type of unexpected quorum packet in learner handler loop > > > Key: ZOOKEEPER-2205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2205 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Fix For: 3.4.7, 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2205-v2.patch, ZOOKEEPER-2205-v3.patch, > ZOOKEEPER-2205-v4.patch, ZOOKEEPER-2205.patch > > > Current learner handler loop doesn't log anything when it receives unexpected > type of quorum packet from learner. > This patch lets the learner handler loop log the type of packet for defensive > purpose. It would make debugging and trouble shooting a little bit easier. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Failed: ZOOKEEPER-2208 PreCommit Build #2753
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2208 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2753/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 126 lines...] [exec] Skipping patch. [exec] 1 out of 1 hunk ignored [exec] PATCH APPLICATION FAILED [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12737869/ZOOKEEPER-2208.patch [exec] against trunk revision 1683605. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] -1 patch. The patch command could not apply the patch. [exec] [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2753//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 7f08ec390e2073a7d3f37a0570fcf781651b0f74 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1782: exec returned: 1 Total time: 42 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2752 Archived 1 artifacts Archive block size is 32768 Received 0 blocks and 60816 bytes Compression is 0.0% Took 4.1 sec Recording test results Description set: ZOOKEEPER-2208 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-2208) Log type of unexpected quorum packet in observer loop
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574953#comment-14574953 ] Hadoop QA commented on ZOOKEEPER-2208: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12737869/ZOOKEEPER-2208.patch against trunk revision 1683605. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2753//console This message is automatically generated. > Log type of unexpected quorum packet in observer loop > - > > Key: ZOOKEEPER-2208 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2208 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Akihiro Suda >Assignee: Hitoshi Mitake >Priority: Trivial > Attachments: ZOOKEEPER-2208.patch > > > This patch lets the observer loop log the type of packet for debugging. > This issue is tightly related to ZOOKEEPER-2205 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2206) Add missing packet types to LearnerHandler.packetToString()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-2206: -- Fix Version/s: 3.6.0 3.5.1 > Add missing packet types to LearnerHandler.packetToString() > --- > > Key: ZOOKEEPER-2206 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2206 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.5.0 >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2206.patch > > > packetToString() is a method which is suitable for obtaining string > representation of QuorumPacket. But it lacks some types of QuorumPacket. This > patch adds the missing types and enhance the method for more friendly logging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2206) Add missing packet types to LearnerHandler.packetToString()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-2206: -- Affects Version/s: 3.5.0 > Add missing packet types to LearnerHandler.packetToString() > --- > > Key: ZOOKEEPER-2206 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2206 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.5.0 >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2206.patch > > > packetToString() is a method which is suitable for obtaining string > representation of QuorumPacket. But it lacks some types of QuorumPacket. This > patch adds the missing types and enhance the method for more friendly logging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2205) Log type of unexpected quorum packet in learner handler loop
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574977#comment-14574977 ] Hadoop QA commented on ZOOKEEPER-2205: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12737866/ZOOKEEPER-2205-v4.patch against trunk revision 1683605. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2754//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2754//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2754//console This message is automatically generated. > Log type of unexpected quorum packet in learner handler loop > > > Key: ZOOKEEPER-2205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2205 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Fix For: 3.4.7, 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2205-v2.patch, ZOOKEEPER-2205-v3.patch, > ZOOKEEPER-2205-v4.patch, ZOOKEEPER-2205.patch > > > Current learner handler loop doesn't log anything when it receives unexpected > type of quorum packet from learner. > This patch lets the learner handler loop log the type of packet for defensive > purpose. It would make debugging and trouble shooting a little bit easier. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Failed: ZOOKEEPER-2205 PreCommit Build #2754
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2205 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2754/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 374926 lines...] [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2754//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2754//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2754//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 24135db87ad4e3a940224f67796e4e8eb19d23d6 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1782: exec returned: 3 Total time: 13 minutes 42 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2752 Archived 24 artifacts Archive block size is 32768 Received 5 blocks and 33834885 bytes Compression is 0.5% Took 7.1 sec Recording test results Description set: ZOOKEEPER-2205 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## All tests passed
Failed: ZOOKEEPER-2206 PreCommit Build #2755
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2206 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2755/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 374087 lines...] [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2755//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2755//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2755//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] c91fcf65d371c2edcece4cbb9213ffc390cdb198 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1782: exec returned: 2 Total time: 8 minutes 28 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2752 Archived 7 artifacts Archive block size is 32768 Received 7 blocks and 335315 bytes Compression is 40.6% Took 2.5 sec Recording test results Description set: ZOOKEEPER-2206 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## 1 tests failed. REGRESSION: org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig Error Message: waiting for server 2 being up Stack Trace: junit.framework.AssertionFailedError: waiting for server 2 being up at org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig(ReconfigRecoveryTest.java:529) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55)
[jira] [Commented] (ZOOKEEPER-2205) Log type of unexpected quorum packet in learner handler loop
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574990#comment-14574990 ] Raul Gutierrez Segales commented on ZOOKEEPER-2205: --- +1, merging. > Log type of unexpected quorum packet in learner handler loop > > > Key: ZOOKEEPER-2205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2205 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Fix For: 3.4.7, 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2205-v2.patch, ZOOKEEPER-2205-v3.patch, > ZOOKEEPER-2205-v4.patch, ZOOKEEPER-2205.patch > > > Current learner handler loop doesn't log anything when it receives unexpected > type of quorum packet from learner. > This patch lets the learner handler loop log the type of packet for defensive > purpose. It would make debugging and trouble shooting a little bit easier. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2205) Log type of unexpected quorum packet in learner handler loop
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574989#comment-14574989 ] Raul Gutierrez Segales commented on ZOOKEEPER-2205: --- Hmm, not sure why -1 for core tests given nothing failed: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2754//testReport/ Everything passes for me locally too (and tbh, this patch only adds a log statement). So merging. > Log type of unexpected quorum packet in learner handler loop > > > Key: ZOOKEEPER-2205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2205 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Fix For: 3.4.7, 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2205-v2.patch, ZOOKEEPER-2205-v3.patch, > ZOOKEEPER-2205-v4.patch, ZOOKEEPER-2205.patch > > > Current learner handler loop doesn't log anything when it receives unexpected > type of quorum packet from learner. > This patch lets the learner handler loop log the type of packet for defensive > purpose. It would make debugging and trouble shooting a little bit easier. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2206) Add missing packet types to LearnerHandler.packetToString()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574981#comment-14574981 ] Hadoop QA commented on ZOOKEEPER-2206: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12737496/ZOOKEEPER-2206.patch against trunk revision 1683605. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2755//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2755//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2755//console This message is automatically generated. > Add missing packet types to LearnerHandler.packetToString() > --- > > Key: ZOOKEEPER-2206 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2206 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.5.0 >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2206.patch > > > packetToString() is a method which is suitable for obtaining string > representation of QuorumPacket. But it lacks some types of QuorumPacket. This > patch adds the missing types and enhance the method for more friendly logging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2206) Add missing packet types to LearnerHandler.packetToString()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575008#comment-14575008 ] Raul Gutierrez Segales commented on ZOOKEEPER-2206: --- +1, lgtm. > Add missing packet types to LearnerHandler.packetToString() > --- > > Key: ZOOKEEPER-2206 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2206 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.5.0 >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2206.patch > > > packetToString() is a method which is suitable for obtaining string > representation of QuorumPacket. But it lacks some types of QuorumPacket. This > patch adds the missing types and enhance the method for more friendly logging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2206) Add missing packet types to LearnerHandler.packetToString()
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575015#comment-14575015
]
Raul Gutierrez Segales commented on ZOOKEEPER-2206:
---
Note that the failed test is totally unrelated:
{code}
waiting for server 2 being up
Stacktrace
junit.framework.AssertionFailedError: waiting for server 2 being up
at
org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig(ReconfigRecoveryTest.java:529)
at
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55)
{code}
> Add missing packet types to LearnerHandler.packetToString()
> ---
>
> Key: ZOOKEEPER-2206
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2206
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.5.0
>Reporter: Hitoshi Mitake
>Assignee: Hitoshi Mitake
>Priority: Trivial
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2206.patch
>
>
> packetToString() is a method which is suitable for obtaining string
> representation of QuorumPacket. But it lacks some types of QuorumPacket. This
> patch adds the missing types and enhance the method for more friendly logging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2206) Add missing packet types to LearnerHandler.packetToString()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575026#comment-14575026 ] Raul Gutierrez Segales commented on ZOOKEEPER-2206: --- And ReconfigRecoveryTest passes for me locally fwiw. > Add missing packet types to LearnerHandler.packetToString() > --- > > Key: ZOOKEEPER-2206 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2206 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.5.0 >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2206.patch > > > packetToString() is a method which is suitable for obtaining string > representation of QuorumPacket. But it lacks some types of QuorumPacket. This > patch adds the missing types and enhance the method for more friendly logging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2207) Enhance error logs with LearnerHandler.packetToString()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-2207: -- Affects Version/s: 3.5.0 > Enhance error logs with LearnerHandler.packetToString() > --- > > Key: ZOOKEEPER-2207 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2207 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.5.0 >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2207-v2.patch, ZOOKEEPER-2207.patch > > > This patch enhances error logs related to unexpected types of QuorumPacket > with LearnerHandler.packetToString(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2207) Enhance error logs with LearnerHandler.packetToString()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-2207: -- Fix Version/s: 3.6.0 3.5.1 > Enhance error logs with LearnerHandler.packetToString() > --- > > Key: ZOOKEEPER-2207 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2207 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.5.0 >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2207-v2.patch, ZOOKEEPER-2207.patch > > > This patch enhances error logs related to unexpected types of QuorumPacket > with LearnerHandler.packetToString(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2208) Log type of unexpected quorum packet in observer loop
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-2208: -- Affects Version/s: 3.5.0 > Log type of unexpected quorum packet in observer loop > - > > Key: ZOOKEEPER-2208 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2208 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.5.0 >Reporter: Akihiro Suda >Assignee: Hitoshi Mitake >Priority: Trivial > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2208.patch > > > This patch lets the observer loop log the type of packet for debugging. > This issue is tightly related to ZOOKEEPER-2205 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2208) Log type of unexpected quorum packet in observer loop
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-2208: -- Fix Version/s: 3.6.0 3.5.1 > Log type of unexpected quorum packet in observer loop > - > > Key: ZOOKEEPER-2208 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2208 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.5.0 >Reporter: Akihiro Suda >Assignee: Hitoshi Mitake >Priority: Trivial > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2208.patch > > > This patch lets the observer loop log the type of packet for debugging. > This issue is tightly related to ZOOKEEPER-2205 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2208) Log type of unexpected quorum packet in observer loop
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575064#comment-14575064 ] Raul Gutierrez Segales commented on ZOOKEEPER-2208: --- +1, lgtm. > Log type of unexpected quorum packet in observer loop > - > > Key: ZOOKEEPER-2208 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2208 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.5.0 >Reporter: Akihiro Suda >Assignee: Hitoshi Mitake >Priority: Trivial > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2208.patch > > > This patch lets the observer loop log the type of packet for debugging. > This issue is tightly related to ZOOKEEPER-2205 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2205) Log type of unexpected quorum packet in learner handler loop
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575177#comment-14575177
]
Chris Nauroth commented on ZOOKEEPER-2205:
--
bq. Hmm, not sure why -1 for core tests given nothing failed
This was a failure in one of the CppUnit tests. These will get reported with a
-1 by Jenkins, but they won't be visible in the test report. AFAIK, the only
way to get the details is to view the console output.
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2754/consoleText
Near the bottom, we have this:
{code}
[exec] [exec] FAIL: zktest-mt
[exec] [exec] ==
[exec] [exec] 1 of 2 tests failed
[exec] [exec] Please report to u...@zookeeper.apache.org
[exec] [exec] ==
[exec] [exec] make[1]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/test/test-cppunit'
[exec] [exec] *** Error in `./zktest-mt': corrupted double-linked
list: 0x008231b0 ***
[exec] [exec] /bin/bash: line 5: 10525 Aborted
ZKROOT=/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/c/../..
CLASSPATH=$CLASSPATH:$CLOVER_HOME/lib/clover.jar ${dir}$tst
[exec] [exec] make[1]: *** [check-TESTS] Error 1
[exec] [exec] make: *** [check-am] Error 2
{code}
It's an interesting failure, but like you said, unrelated to this logging patch.
> Log type of unexpected quorum packet in learner handler loop
>
>
> Key: ZOOKEEPER-2205
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2205
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.4.6, 3.5.0
>Reporter: Hitoshi Mitake
>Assignee: Hitoshi Mitake
>Priority: Trivial
> Fix For: 3.4.7, 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2205-v2.patch, ZOOKEEPER-2205-v3.patch,
> ZOOKEEPER-2205-v4.patch, ZOOKEEPER-2205.patch
>
>
> Current learner handler loop doesn't log anything when it receives unexpected
> type of quorum packet from learner.
> This patch lets the learner handler loop log the type of packet for defensive
> purpose. It would make debugging and trouble shooting a little bit easier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2080) ReconfigRecoveryTest fails intermittently
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575180#comment-14575180
]
Chris Nauroth commented on ZOOKEEPER-2080:
--
We've also seen some intermittent failures from the similar CppUnit tests:
TestReconfig.cc and TestReconfigServer.cc.
> ReconfigRecoveryTest fails intermittently
> -
>
> Key: ZOOKEEPER-2080
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2080
> Project: ZooKeeper
> Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Raul Gutierrez Segales
>Priority: Minor
>
> I got the following test failure on MacBook with trunk code:
> {code}
> Testcase: testCurrentObserverIsParticipantInNewConfig took 93.628 sec
> FAILED
> waiting for server 2 being up
> junit.framework.AssertionFailedError: waiting for server 2 being up
> at
> org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig(ReconfigRecoveryTest.java:529)
> at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2205) Log type of unexpected quorum packet in learner handler loop
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575182#comment-14575182 ] Raul Gutierrez Segales commented on ZOOKEEPER-2205: --- ah, thanks [~cnauroth]! > Log type of unexpected quorum packet in learner handler loop > > > Key: ZOOKEEPER-2205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2205 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Fix For: 3.4.7, 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2205-v2.patch, ZOOKEEPER-2205-v3.patch, > ZOOKEEPER-2205-v4.patch, ZOOKEEPER-2205.patch > > > Current learner handler loop doesn't log anything when it receives unexpected > type of quorum packet from learner. > This patch lets the learner handler loop log the type of packet for defensive > purpose. It would make debugging and trouble shooting a little bit easier. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2163) Introduce new ZNode type: container
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575322#comment-14575322
]
Flavio Junqueira commented on ZOOKEEPER-2163:
-
yeah, I prefer the other approach just because I'd rather avoid spinning
threads unnecessarily, even if they are background tasks. given that it has
already gone into trunk, I don't think it makes sense to revert it, so let's
just keep it in mind.
> Introduce new ZNode type: container
> ---
>
> Key: ZOOKEEPER-2163
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2163
> Project: ZooKeeper
> Issue Type: New Feature
> Components: c client, java client, server
>Affects Versions: 3.5.0
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
> Fix For: 3.6.0
>
> Attachments: zookeeper-2163.10.patch, zookeeper-2163.11.patch,
> zookeeper-2163.12.patch, zookeeper-2163.13.patch, zookeeper-2163.14.patch,
> zookeeper-2163.3.patch, zookeeper-2163.5.patch, zookeeper-2163.6.patch,
> zookeeper-2163.7.patch, zookeeper-2163.8.patch, zookeeper-2163.9.patch
>
>
> BACKGROUND
>
> A recurring problem for ZooKeeper users is garbage collection of parent
> nodes. Many recipes (e.g. locks, leaders, etc.) call for the creation of a
> parent node under which participants create sequential nodes. When the
> participant is done, it deletes its node. In practice, the ZooKeeper tree
> begins to fill up with orphaned parent nodes that are no longer needed. The
> ZooKeeper APIs don’t provide a way to clean these. Over time, ZooKeeper can
> become unstable due to the number of these nodes.
> CURRENT SOLUTIONS
> ===
> Apache Curator has a workaround solution for this by providing the Reaper
> class which runs in the background looking for orphaned parent nodes and
> deleting them. This isn’t ideal and it would be better if ZooKeeper supported
> this directly.
> PROPOSAL
> =
> ZOOKEEPER-723 and ZOOKEEPER-834 have been proposed to allow EPHEMERAL nodes
> to contain child nodes. This is not optimum as EPHEMERALs are tied to a
> session and the general use case of parent nodes is for PERSISTENT nodes.
> This proposal adds a new node type, CONTAINER. A CONTAINER node is the same
> as a PERSISTENT node with the additional property that when its last child is
> deleted, it is deleted (and CONTAINER nodes recursively up the tree are
> deleted if empty).
> CANONICAL USAGE
>
> {code}
> while ( true) { // or some reasonable limit
> try {
> zk.create(path, ...);
> break;
> } catch ( KeeperException.NoNodeException e ) {
> try {
> zk.createContainer(containerPath, ...);
> } catch ( KeeperException.NodeExistsException ignore) {
>}
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2163) Introduce new ZNode type: container
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575324#comment-14575324
]
Flavio Junqueira commented on ZOOKEEPER-2163:
-
given that it is a new feature, it shouldn't go into the 3.4 branch.
> Introduce new ZNode type: container
> ---
>
> Key: ZOOKEEPER-2163
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2163
> Project: ZooKeeper
> Issue Type: New Feature
> Components: c client, java client, server
>Affects Versions: 3.5.0
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
> Fix For: 3.6.0
>
> Attachments: zookeeper-2163.10.patch, zookeeper-2163.11.patch,
> zookeeper-2163.12.patch, zookeeper-2163.13.patch, zookeeper-2163.14.patch,
> zookeeper-2163.3.patch, zookeeper-2163.5.patch, zookeeper-2163.6.patch,
> zookeeper-2163.7.patch, zookeeper-2163.8.patch, zookeeper-2163.9.patch
>
>
> BACKGROUND
>
> A recurring problem for ZooKeeper users is garbage collection of parent
> nodes. Many recipes (e.g. locks, leaders, etc.) call for the creation of a
> parent node under which participants create sequential nodes. When the
> participant is done, it deletes its node. In practice, the ZooKeeper tree
> begins to fill up with orphaned parent nodes that are no longer needed. The
> ZooKeeper APIs don’t provide a way to clean these. Over time, ZooKeeper can
> become unstable due to the number of these nodes.
> CURRENT SOLUTIONS
> ===
> Apache Curator has a workaround solution for this by providing the Reaper
> class which runs in the background looking for orphaned parent nodes and
> deleting them. This isn’t ideal and it would be better if ZooKeeper supported
> this directly.
> PROPOSAL
> =
> ZOOKEEPER-723 and ZOOKEEPER-834 have been proposed to allow EPHEMERAL nodes
> to contain child nodes. This is not optimum as EPHEMERALs are tied to a
> session and the general use case of parent nodes is for PERSISTENT nodes.
> This proposal adds a new node type, CONTAINER. A CONTAINER node is the same
> as a PERSISTENT node with the additional property that when its last child is
> deleted, it is deleted (and CONTAINER nodes recursively up the tree are
> deleted if empty).
> CANONICAL USAGE
>
> {code}
> while ( true) { // or some reasonable limit
> try {
> zk.create(path, ...);
> break;
> } catch ( KeeperException.NoNodeException e ) {
> try {
> zk.createContainer(containerPath, ...);
> } catch ( KeeperException.NodeExistsException ignore) {
>}
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2201) Network issues can cause cluster to hang due to near-deadlock
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575364#comment-14575364
]
Hongchao Deng commented on ZOOKEEPER-2201:
--
+1
The patch looks good!
> Network issues can cause cluster to hang due to near-deadlock
> -
>
> Key: ZOOKEEPER-2201
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2201
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.4.6
>Reporter: Donny Nadolny
>Assignee: Donny Nadolny
>Priority: Critical
> Fix For: 3.4.7, 3.5.2
>
> Attachments: ZOOKEEPER-2201-branch-34.patch, ZOOKEEPER-2201.patch,
> ZOOKEEPER-2201.patch, ZOOKEEPER-2201.patch, ZOOKEEPER-2201.patch,
> ZOOKEEPER-2201.patch
>
>
> {{DataTree.serializeNode}} synchronizes on the {{DataNode}} it is about to
> serialize then writes it out via {{OutputArchive.writeRecord}}, potentially
> to a network connection. Under default linux TCP settings, a network
> connection where the other side completely disappears will hang (blocking on
> the {{java.net.SocketOutputStream.socketWrite0}} call) for over 15 minutes.
> During this time, any attempt to create/delete/modify the {{DataNode}} will
> cause the leader to hang at the beginning of the request processor chain:
> {noformat}
> "ProcessThread(sid:5 cport:-1):" prio=10 tid=0x026f1800 nid=0x379c
> waiting for monitor entry [0x7fe6c2a8c000]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at
> org.apache.zookeeper.server.PrepRequestProcessor.getRecordForPath(PrepRequestProcessor.java:163)
> - waiting to lock <0xd4cd9e28> (a
> org.apache.zookeeper.server.DataNode)
> - locked <0xd2ef81d0> (a java.util.ArrayList)
> at
> org.apache.zookeeper.server.PrepRequestProcessor.pRequest2Txn(PrepRequestProcessor.java:345)
> at
> org.apache.zookeeper.server.PrepRequestProcessor.pRequest(PrepRequestProcessor.java:534)
> at
> org.apache.zookeeper.server.PrepRequestProcessor.run(PrepRequestProcessor.java:131)
> {noformat}
> Additionally, any attempt to send a snapshot to a follower or to disk will
> hang.
> Because the ping packets are sent by another thread which is unaffected,
> followers never time out and become leader, even though the cluster will make
> no progress until either the leader is killed or the TCP connection times
> out. This isn't exactly a deadlock since it will resolve itself eventually,
> but as mentioned above this will take > 15 minutes with the default TCP retry
> settings in linux.
> A simple solution to this is: in {{DataTree.serializeNode}} we can take a
> copy of the contents of the {{DataNode}} (as is done with its children) in
> the synchronized block, then call {{writeRecord}} with the copy of the
> {{DataNode}} outside of the original {{DataNode}} synchronized block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2205) Log type of unexpected quorum packet in learner handler loop
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575439#comment-14575439 ] Hitoshi Mitake commented on ZOOKEEPER-2205: --- Thanks for merging, [~rgs]! > Log type of unexpected quorum packet in learner handler loop > > > Key: ZOOKEEPER-2205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2205 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.6, 3.5.0 >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Fix For: 3.4.7, 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2205-v2.patch, ZOOKEEPER-2205-v3.patch, > ZOOKEEPER-2205-v4.patch, ZOOKEEPER-2205.patch > > > Current learner handler loop doesn't log anything when it receives unexpected > type of quorum packet from learner. > This patch lets the learner handler loop log the type of packet for defensive > purpose. It would make debugging and trouble shooting a little bit easier. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2206) Add missing packet types to LearnerHandler.packetToString()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575443#comment-14575443 ] Hitoshi Mitake commented on ZOOKEEPER-2206: --- Thanks, [~rgs]! > Add missing packet types to LearnerHandler.packetToString() > --- > > Key: ZOOKEEPER-2206 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2206 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.5.0 >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2206.patch > > > packetToString() is a method which is suitable for obtaining string > representation of QuorumPacket. But it lacks some types of QuorumPacket. This > patch adds the missing types and enhance the method for more friendly logging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2207) Enhance error logs with LearnerHandler.packetToString()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575441#comment-14575441 ] Hitoshi Mitake commented on ZOOKEEPER-2207: --- Thanks, [~rgs]! > Enhance error logs with LearnerHandler.packetToString() > --- > > Key: ZOOKEEPER-2207 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2207 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.5.0 >Reporter: Hitoshi Mitake >Assignee: Hitoshi Mitake >Priority: Trivial > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2207-v2.patch, ZOOKEEPER-2207.patch > > > This patch enhances error logs related to unexpected types of QuorumPacket > with LearnerHandler.packetToString(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2201) Network issues can cause cluster to hang due to near-deadlock
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-2201:
--
Fix Version/s: 3.6.0
> Network issues can cause cluster to hang due to near-deadlock
> -
>
> Key: ZOOKEEPER-2201
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2201
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.4.6, 3.5.0
>Reporter: Donny Nadolny
>Assignee: Donny Nadolny
>Priority: Critical
> Fix For: 3.4.7, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2201-branch-34.patch, ZOOKEEPER-2201.patch,
> ZOOKEEPER-2201.patch, ZOOKEEPER-2201.patch, ZOOKEEPER-2201.patch,
> ZOOKEEPER-2201.patch
>
>
> {{DataTree.serializeNode}} synchronizes on the {{DataNode}} it is about to
> serialize then writes it out via {{OutputArchive.writeRecord}}, potentially
> to a network connection. Under default linux TCP settings, a network
> connection where the other side completely disappears will hang (blocking on
> the {{java.net.SocketOutputStream.socketWrite0}} call) for over 15 minutes.
> During this time, any attempt to create/delete/modify the {{DataNode}} will
> cause the leader to hang at the beginning of the request processor chain:
> {noformat}
> "ProcessThread(sid:5 cport:-1):" prio=10 tid=0x026f1800 nid=0x379c
> waiting for monitor entry [0x7fe6c2a8c000]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at
> org.apache.zookeeper.server.PrepRequestProcessor.getRecordForPath(PrepRequestProcessor.java:163)
> - waiting to lock <0xd4cd9e28> (a
> org.apache.zookeeper.server.DataNode)
> - locked <0xd2ef81d0> (a java.util.ArrayList)
> at
> org.apache.zookeeper.server.PrepRequestProcessor.pRequest2Txn(PrepRequestProcessor.java:345)
> at
> org.apache.zookeeper.server.PrepRequestProcessor.pRequest(PrepRequestProcessor.java:534)
> at
> org.apache.zookeeper.server.PrepRequestProcessor.run(PrepRequestProcessor.java:131)
> {noformat}
> Additionally, any attempt to send a snapshot to a follower or to disk will
> hang.
> Because the ping packets are sent by another thread which is unaffected,
> followers never time out and become leader, even though the cluster will make
> no progress until either the leader is killed or the TCP connection times
> out. This isn't exactly a deadlock since it will resolve itself eventually,
> but as mentioned above this will take > 15 minutes with the default TCP retry
> settings in linux.
> A simple solution to this is: in {{DataTree.serializeNode}} we can take a
> copy of the contents of the {{DataNode}} (as is done with its children) in
> the synchronized block, then call {{writeRecord}} with the copy of the
> {{DataNode}} outside of the original {{DataNode}} synchronized block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2201) Network issues can cause cluster to hang due to near-deadlock
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raul Gutierrez Segales updated ZOOKEEPER-2201:
--
Affects Version/s: 3.5.0
> Network issues can cause cluster to hang due to near-deadlock
> -
>
> Key: ZOOKEEPER-2201
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2201
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.4.6, 3.5.0
>Reporter: Donny Nadolny
>Assignee: Donny Nadolny
>Priority: Critical
> Fix For: 3.4.7, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2201-branch-34.patch, ZOOKEEPER-2201.patch,
> ZOOKEEPER-2201.patch, ZOOKEEPER-2201.patch, ZOOKEEPER-2201.patch,
> ZOOKEEPER-2201.patch
>
>
> {{DataTree.serializeNode}} synchronizes on the {{DataNode}} it is about to
> serialize then writes it out via {{OutputArchive.writeRecord}}, potentially
> to a network connection. Under default linux TCP settings, a network
> connection where the other side completely disappears will hang (blocking on
> the {{java.net.SocketOutputStream.socketWrite0}} call) for over 15 minutes.
> During this time, any attempt to create/delete/modify the {{DataNode}} will
> cause the leader to hang at the beginning of the request processor chain:
> {noformat}
> "ProcessThread(sid:5 cport:-1):" prio=10 tid=0x026f1800 nid=0x379c
> waiting for monitor entry [0x7fe6c2a8c000]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at
> org.apache.zookeeper.server.PrepRequestProcessor.getRecordForPath(PrepRequestProcessor.java:163)
> - waiting to lock <0xd4cd9e28> (a
> org.apache.zookeeper.server.DataNode)
> - locked <0xd2ef81d0> (a java.util.ArrayList)
> at
> org.apache.zookeeper.server.PrepRequestProcessor.pRequest2Txn(PrepRequestProcessor.java:345)
> at
> org.apache.zookeeper.server.PrepRequestProcessor.pRequest(PrepRequestProcessor.java:534)
> at
> org.apache.zookeeper.server.PrepRequestProcessor.run(PrepRequestProcessor.java:131)
> {noformat}
> Additionally, any attempt to send a snapshot to a follower or to disk will
> hang.
> Because the ping packets are sent by another thread which is unaffected,
> followers never time out and become leader, even though the cluster will make
> no progress until either the leader is killed or the TCP connection times
> out. This isn't exactly a deadlock since it will resolve itself eventually,
> but as mentioned above this will take > 15 minutes with the default TCP retry
> settings in linux.
> A simple solution to this is: in {{DataTree.serializeNode}} we can take a
> copy of the contents of the {{DataNode}} (as is done with its children) in
> the synchronized block, then call {{writeRecord}} with the copy of the
> {{DataNode}} outside of the original {{DataNode}} synchronized block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
