[jira] [Commented] (ZOOKEEPER-2281) ZK Server startup fails if there are spaces in the JAVA_HOME path

2015-09-28 Thread Arshad Mohammad (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14910114#comment-14910114
 ] 

Arshad Mohammad commented on ZOOKEEPER-2281:


[~neha.bathra], create patch with --no-prefix option. for eaxmple {{git diff 
--no-prefix >> ZOOKEEPER-2281-01.patch}}

> ZK Server startup fails if there are spaces in the JAVA_HOME path
> -
>
> Key: ZOOKEEPER-2281
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2281
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
> Environment: Windows
>Reporter: neha
>Priority: Minor
> Attachments: ZOOKEEPER-2281-00.patch
>
>
> Zookeeper startup fails if there are spaces in the %JAVA_HOME% variable. 
> {code}
> if not exist %JAVA_HOME%\bin\java.exe (
>   echo Error: JAVA_HOME is incorrectly set.
>   goto :eof
> )
> set JAVA=%JAVA_HOME%\bin\java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2244) On Windows zookeeper fails to restart.

2015-09-28 Thread Arshad Mohammad (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arshad Mohammad updated ZOOKEEPER-2244:
---
Attachment: ZOOKEEPER-2244-05.patch

Thanks [~rgs] for your review comments.
# Used {{org.apache.zookeeper.test.ClientBase.CountdownWatcher}} to ensure 
ZooKeeper client connected before use.
# I could not find any existing API which gives connection string, so adding 
{{org.apache.zookeeper.server.quorum.QuorumPeerTestBase.getCxnString(int[])}} 
new API

Submitted new patch ZOOKEEPER-2244-05.patch

> On Windows zookeeper fails to restart.
> --
>
> Key: ZOOKEEPER-2244
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2244
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Critical
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2244-01.patch, ZOOKEEPER-2244-02.patch, 
> ZOOKEEPER-2244-03.patch, ZOOKEEPER-2244-04.patch, ZOOKEEPER-2244-05.patch
>
>
> This issue occurs in following scenario
> 1) configure server properties in  zookeeper configuration file(zoo.cfg)
> example:
> {code}
> server.1=localhost:43222:43225:participant;0.0.0.0:43228
> server.2=localhost:43223:43226:participant;0.0.0.0:43229
> server.3=localhost:43224:43227:participant;0.0.0.0:43230
> {code}
> 2)  start the servers on windows. All the servers started successfully
> 3) stop any of the server
> 4)  try to start the stopped server. It fails with following error
> {code}
> org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Error 
> processing D:SystemTestCasesZKServer1confzoo.cfg.dynamic.1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Failed: ZOOKEEPER-2244 PreCommit Build #2889

2015-09-28 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2244
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2889/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 377903 lines...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2889//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2889//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2889//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 21fb83b8e6cdbd5d8abe30ebe623151155b02dc1 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1787:
 exec returned: 1

Total time: 8 minutes 37 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2880
Archived 7 artifacts
Archive block size is 32768
Received 8 blocks and 304796 bytes
Compression is 46.2%
Took 0.88 sec
Recording test results
Description set: ZOOKEEPER-2244
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
1 tests failed.
REGRESSION:  org.apache.zookeeper.test.ClientPortBindTest.testBindByAddress

Error Message:
No such device

Stack Trace:
java.net.SocketException: No such device
at java.net.NetworkInterface.isLoopback0(Native Method)
at java.net.NetworkInterface.isLoopback(NetworkInterface.java:382)
at 
org.apache.zookeeper.test.ClientPortBindTest.testBindByAddress(ClientPortBindTest.java:61)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)




[jira] [Commented] (ZOOKEEPER-2244) On Windows zookeeper fails to restart.

2015-09-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933152#comment-14933152
 ] 

Hadoop QA commented on ZOOKEEPER-2244:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12763994/ZOOKEEPER-2244-05.patch
  against trunk revision 1705482.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2889//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2889//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2889//console

This message is automatically generated.

> On Windows zookeeper fails to restart.
> --
>
> Key: ZOOKEEPER-2244
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2244
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Critical
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2244-01.patch, ZOOKEEPER-2244-02.patch, 
> ZOOKEEPER-2244-03.patch, ZOOKEEPER-2244-04.patch, ZOOKEEPER-2244-05.patch
>
>
> This issue occurs in following scenario
> 1) configure server properties in  zookeeper configuration file(zoo.cfg)
> example:
> {code}
> server.1=localhost:43222:43225:participant;0.0.0.0:43228
> server.2=localhost:43223:43226:participant;0.0.0.0:43229
> server.3=localhost:43224:43227:participant;0.0.0.0:43230
> {code}
> 2)  start the servers on windows. All the servers started successfully
> 3) stop any of the server
> 4)  try to start the stopped server. It fails with following error
> {code}
> org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Error 
> processing D:SystemTestCasesZKServer1confzoo.cfg.dynamic.1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


3-server Zab cluster

2015-09-28 Thread Ibrahim El-sanosi (PGR)
In Zab, assume we have a cluster consists of 3-servers. To deliver a write 
request, it must run 3 communication steps proposal, acknowledgement and commit.
As Zab uses reliable FIFO, it is possible to remove commit round. As soon as a 
follower receives a proposal, it logs, sends an ACK and commits locally. Upon 
receiving ACK from any follower, leader commits a proposal locally, no COMMIT 
message need to be sent to followers. In this case, all servers commit a 
proposal in two round-trips, resulting in reducing latency particularly in 
followers.

Note that this optimization can only work in 3-servers cluster (follower 
reaches a majority as soon as it acks).
Does anyone see any problems with such (small) optimization?
Ibrahim


[jira] [Commented] (ZOOKEEPER-2244) On Windows zookeeper fails to restart.

2015-09-28 Thread Rakesh R (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933259#comment-14933259
 ] 

Rakesh R commented on ZOOKEEPER-2244:
-

Thanks [~arshad.mohammad] for taking care this.

bq. Used org.apache.zookeeper.test.ClientBase.CountdownWatcher to ensure 
ZooKeeper client connected before use.
Agreed. But I couldn't see unit test case in latest patch, is that missed?

bq.  I could not find any existing API which gives connection string, so adding 
org.apache.zookeeper.server.quorum.QuorumPeerTestBase.getCxnString(int[]) new 
API
Here, instead of passing full connection string, we can pass one of the client 
port as you are ensuring that all the servers are running before the ZooKeeper 
client creation, right?. Please refer 
[QuorumPeerMainTest.java#L100|https://github.com/apache/zookeeper/blob/trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java#L100]
 to see similar usage in existing tests.

> On Windows zookeeper fails to restart.
> --
>
> Key: ZOOKEEPER-2244
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2244
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Critical
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2244-01.patch, ZOOKEEPER-2244-02.patch, 
> ZOOKEEPER-2244-03.patch, ZOOKEEPER-2244-04.patch, ZOOKEEPER-2244-05.patch
>
>
> This issue occurs in following scenario
> 1) configure server properties in  zookeeper configuration file(zoo.cfg)
> example:
> {code}
> server.1=localhost:43222:43225:participant;0.0.0.0:43228
> server.2=localhost:43223:43226:participant;0.0.0.0:43229
> server.3=localhost:43224:43227:participant;0.0.0.0:43230
> {code}
> 2)  start the servers on windows. All the servers started successfully
> 3) stop any of the server
> 4)  try to start the stopped server. It fails with following error
> {code}
> org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Error 
> processing D:SystemTestCasesZKServer1confzoo.cfg.dynamic.1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2281) ZK Server startup fails if there are spaces in the JAVA_HOME path

2015-09-28 Thread neha (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

neha updated ZOOKEEPER-2281:

Attachment: ZOOKEEPER-2281-01.patch

[~arshad.mohammad], thanks for your review. Updated the patch as per your 
review comment. Please check.

> ZK Server startup fails if there are spaces in the JAVA_HOME path
> -
>
> Key: ZOOKEEPER-2281
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2281
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
> Environment: Windows
>Reporter: neha
>Priority: Minor
> Attachments: ZOOKEEPER-2281-00.patch, ZOOKEEPER-2281-01.patch
>
>
> Zookeeper startup fails if there are spaces in the %JAVA_HOME% variable. 
> {code}
> if not exist %JAVA_HOME%\bin\java.exe (
>   echo Error: JAVA_HOME is incorrectly set.
>   goto :eof
> )
> set JAVA=%JAVA_HOME%\bin\java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Failed: ZOOKEEPER-2281 PreCommit Build #2890

2015-09-28 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2281
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2890/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 376220 lines...]
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2890//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2890//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2890//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 44c8d92cdf1e7129767a29f2a21d848b744cab02 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1787:
 exec returned: 1

Total time: 17 minutes 33 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2880
Archived 24 artifacts
Archive block size is 32768
Received 8 blocks and 33737439 bytes
Compression is 0.8%
Took 7.2 sec
Recording test results
Description set: ZOOKEEPER-2281
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2281) ZK Server startup fails if there are spaces in the JAVA_HOME path

2015-09-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933306#comment-14933306
 ] 

Hadoop QA commented on ZOOKEEPER-2281:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12764014/ZOOKEEPER-2281-01.patch
  against trunk revision 1705482.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2890//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2890//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2890//console

This message is automatically generated.

> ZK Server startup fails if there are spaces in the JAVA_HOME path
> -
>
> Key: ZOOKEEPER-2281
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2281
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
> Environment: Windows
>Reporter: neha
>Priority: Minor
> Attachments: ZOOKEEPER-2281-00.patch, ZOOKEEPER-2281-01.patch
>
>
> Zookeeper startup fails if there are spaces in the %JAVA_HOME% variable. 
> {code}
> if not exist %JAVA_HOME%\bin\java.exe (
>   echo Error: JAVA_HOME is incorrectly set.
>   goto :eof
> )
> set JAVA=%JAVA_HOME%\bin\java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2211) PurgeTxnLog does not correctly purge when snapshots and logs are at different locations

2015-09-28 Thread Arshad Mohammad (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arshad Mohammad updated ZOOKEEPER-2211:
---
Attachment: ZOOKEEPER-2211-04.patch

Thanks [~rgs] for your comments.
# Handled  NumberFormatException
# Added file exist validation for snap and log directory
# Apart from args following things also are different
## comments
## snapshot creation directory
## assertion
I think if extracted to a method it will increase the code complexity, code 
will be less understandable. at least four places need to add if else. So not 
changing
is it ok?

Submitting patch ZOOKEEPER-2211-04.patch

> PurgeTxnLog does not correctly purge when snapshots and logs are at different 
> locations
> ---
>
> Key: ZOOKEEPER-2211
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2211
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: scripts
>Affects Versions: 3.4.6, 3.5.0
> Environment: Ubuntu 12.04, Java 1.7.
>Reporter: Wesley Chow
>Assignee: Arshad Mohammad
> Fix For: 3.4.7, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2211-02.patch, ZOOKEEPER-2211-03.patch, 
> ZOOKEEPER-2211-04.patch, ZOOKEEPER-2211.patch
>
>
> PurgeTxnLog does not work when snapshots and transaction logs are at 
> different file paths. The argument handling is buggy and only works when both 
> snap and datalog dirs are given, and datalog dir contains both logs and snaps 
> (snap is ignored).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2244) On Windows zookeeper fails to restart.

2015-09-28 Thread Arshad Mohammad (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arshad Mohammad updated ZOOKEEPER-2244:
---
Attachment: ZOOKEEPER-2244-06.patch

Thanks [~rakeshr] for your suggestion.
Submitting new patch ZOOKEEPER-2244-06.patch

> On Windows zookeeper fails to restart.
> --
>
> Key: ZOOKEEPER-2244
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2244
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Critical
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2244-01.patch, ZOOKEEPER-2244-02.patch, 
> ZOOKEEPER-2244-03.patch, ZOOKEEPER-2244-04.patch, ZOOKEEPER-2244-05.patch, 
> ZOOKEEPER-2244-06.patch
>
>
> This issue occurs in following scenario
> 1) configure server properties in  zookeeper configuration file(zoo.cfg)
> example:
> {code}
> server.1=localhost:43222:43225:participant;0.0.0.0:43228
> server.2=localhost:43223:43226:participant;0.0.0.0:43229
> server.3=localhost:43224:43227:participant;0.0.0.0:43230
> {code}
> 2)  start the servers on windows. All the servers started successfully
> 3) stop any of the server
> 4)  try to start the stopped server. It fails with following error
> {code}
> org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Error 
> processing D:SystemTestCasesZKServer1confzoo.cfg.dynamic.1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2281) ZK Server startup fails if there are spaces in the JAVA_HOME path

2015-09-28 Thread neha (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933400#comment-14933400
 ] 

neha commented on ZOOKEEPER-2281:
-

Changes done are in batch file, hence tests are not included.

> ZK Server startup fails if there are spaces in the JAVA_HOME path
> -
>
> Key: ZOOKEEPER-2281
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2281
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
> Environment: Windows
>Reporter: neha
>Priority: Minor
> Attachments: ZOOKEEPER-2281-00.patch, ZOOKEEPER-2281-01.patch
>
>
> Zookeeper startup fails if there are spaces in the %JAVA_HOME% variable. 
> {code}
> if not exist %JAVA_HOME%\bin\java.exe (
>   echo Error: JAVA_HOME is incorrectly set.
>   goto :eof
> )
> set JAVA=%JAVA_HOME%\bin\java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2211) PurgeTxnLog does not correctly purge when snapshots and logs are at different locations

2015-09-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933408#comment-14933408
 ] 

Hadoop QA commented on ZOOKEEPER-2211:
--

+1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12764025/ZOOKEEPER-2211-04.patch
  against trunk revision 1705482.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2891//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2891//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2891//console

This message is automatically generated.

> PurgeTxnLog does not correctly purge when snapshots and logs are at different 
> locations
> ---
>
> Key: ZOOKEEPER-2211
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2211
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: scripts
>Affects Versions: 3.4.6, 3.5.0
> Environment: Ubuntu 12.04, Java 1.7.
>Reporter: Wesley Chow
>Assignee: Arshad Mohammad
> Fix For: 3.4.7, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2211-02.patch, ZOOKEEPER-2211-03.patch, 
> ZOOKEEPER-2211-04.patch, ZOOKEEPER-2211.patch
>
>
> PurgeTxnLog does not work when snapshots and transaction logs are at 
> different file paths. The argument handling is buggy and only works when both 
> snap and datalog dirs are given, and datalog dir contains both logs and snaps 
> (snap is ignored).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Success: ZOOKEEPER-2211 PreCommit Build #2891

2015-09-28 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2211
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2891/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 379159 lines...]
 [exec] +1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12764025/ZOOKEEPER-2211-04.patch
 [exec]   against trunk revision 1705482.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2891//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2891//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2891//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 8294570c4a12ab96786100e3770263ea2bdeb478 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 17 minutes 44 seconds
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2880
Archived 24 artifacts
Archive block size is 32768
Received 6 blocks and 33914062 bytes
Compression is 0.6%
Took 7 sec
Recording test results
Description set: ZOOKEEPER-2211
Email was triggered for: Success
Sending email for trigger: Success



###
## FAILED TESTS (if any) 
##
All tests passed

Failed: ZOOKEEPER-2244 PreCommit Build #2892

2015-09-28 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2244
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2892/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 375783 lines...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 2 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2892//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2892//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2892//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 4edd2fc6159a389fadb2e6996820309d771f0d7b logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1787:
 exec returned: 1

Total time: 9 minutes 33 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2891
Archived 7 artifacts
Archive block size is 32768
Received 6 blocks and 370527 bytes
Compression is 34.7%
Took 0.78 sec
Recording test results
Description set: ZOOKEEPER-2244
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
1 tests failed.
REGRESSION:  org.apache.zookeeper.test.ClientPortBindTest.testBindByAddress

Error Message:
No such device

Stack Trace:
java.net.SocketException: No such device
at java.net.NetworkInterface.isLoopback0(Native Method)
at java.net.NetworkInterface.isLoopback(NetworkInterface.java:382)
at 
org.apache.zookeeper.test.ClientPortBindTest.testBindByAddress(ClientPortBindTest.java:61)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)




[jira] [Commented] (ZOOKEEPER-2244) On Windows zookeeper fails to restart.

2015-09-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933410#comment-14933410
 ] 

Hadoop QA commented on ZOOKEEPER-2244:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12764027/ZOOKEEPER-2244-06.patch
  against trunk revision 1705482.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 2 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2892//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2892//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2892//console

This message is automatically generated.

> On Windows zookeeper fails to restart.
> --
>
> Key: ZOOKEEPER-2244
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2244
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Critical
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2244-01.patch, ZOOKEEPER-2244-02.patch, 
> ZOOKEEPER-2244-03.patch, ZOOKEEPER-2244-04.patch, ZOOKEEPER-2244-05.patch, 
> ZOOKEEPER-2244-06.patch
>
>
> This issue occurs in following scenario
> 1) configure server properties in  zookeeper configuration file(zoo.cfg)
> example:
> {code}
> server.1=localhost:43222:43225:participant;0.0.0.0:43228
> server.2=localhost:43223:43226:participant;0.0.0.0:43229
> server.3=localhost:43224:43227:participant;0.0.0.0:43230
> {code}
> 2)  start the servers on windows. All the servers started successfully
> 3) stop any of the server
> 4)  try to start the stopped server. It fails with following error
> {code}
> org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Error 
> processing D:SystemTestCasesZKServer1confzoo.cfg.dynamic.1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [ANNOUNCE] New committer: Chris Nauroth

2015-09-28 Thread Rakesh Radhakrishnan
Welcome Chris, thanks for all your great work and congrats!

-Rakesh

On Mon, Sep 28, 2015 at 8:11 PM, Flavio Junqueira  wrote:

> The Apache ZooKeeper PMC is pleased to announce that Chris Nauroth has
> accepted to become a committer. Chris has been a great contributor and very
> active in the community.
>
> Congrats, Chris!
>
> -Flavio


Re: [ANNOUNCE] New committer: Chris Nauroth

2015-09-28 Thread Alexander Shraer
Congrats Chris, and welcome!

On Mon, Sep 28, 2015 at 9:52 AM, Rakesh Radhakrishnan <
rakeshr.apa...@gmail.com> wrote:

> Welcome Chris, thanks for all your great work and congrats!
>
> -Rakesh
>
> On Mon, Sep 28, 2015 at 8:11 PM, Flavio Junqueira  wrote:
>
> > The Apache ZooKeeper PMC is pleased to announce that Chris Nauroth has
> > accepted to become a committer. Chris has been a great contributor and
> very
> > active in the community.
> >
> > Congrats, Chris!
> >
> > -Flavio
>


[jira] [Created] (ZOOKEEPER-2282) chroot not stripped from path in asynchronous callbacks

2015-09-28 Thread Andrew Grasso (JIRA)
Andrew Grasso created ZOOKEEPER-2282:


 Summary: chroot not stripped from path in asynchronous callbacks
 Key: ZOOKEEPER-2282
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2282
 Project: ZooKeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.5.0, 3.4.6
 Environment: Centos 6.6
Reporter: Andrew Grasso


Callbacks passed to [zoo_acreate], [zoo_async], and [zoo_amulti] (for create 
ops) are called on paths that include the chroot. This is analagous to issue 
1027, which fixed this bug for synchronous calls.
I've created a patch to fix this in trunk



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2281) ZK Server startup fails if there are spaces in the JAVA_HOME path

2015-09-28 Thread Chris Nauroth (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933606#comment-14933606
 ] 

Chris Nauroth commented on ZOOKEEPER-2281:
--

Hello [~neha.bathra].  Thank you for the bug report and the patch.

The existing code works fine if the {{JAVA_HOME}} environment variable value 
wraps a path containing spaces in double quotes.  For example:

{code}
C:\zkdep\zookeeper-3.6.0-SNAPSHOT>set JAVA_HOME
JAVA_HOME="C:\Java\jdk1.7.0_75-x86 with spaces"
{code}

However, the existing code doesn't work if the environment variable value is 
not wrapped in double quotes.

{code}
C:\zkdep\zookeeper-3.6.0-SNAPSHOT>set JAVA_HOME
JAVA_HOME=C:\Java\jdk1.7.0_75-x86 with spaces
{code}

I'm guessing that your test environment was not using double quotes, which 
would explain why you were able to repro this bug.

I tested the current patch, and it makes startup work for the unquoted case, 
but it breaks startup for the quoted case, because the file existence check 
will use a path containing multiple nested quotes.  My experience is that it's 
more common to quote the environment variable value, because that also 
simplifies nested environment variable constructs, like {{set 
PATH=%JAVA_HOME%\bin;...}}.

I think we'll need to ensure backwards-compatibility if we want to proceed with 
this patch.  That likely would involve trying to check for whether or not the 
value is already quoted before wrapping our own quotes around it.

> ZK Server startup fails if there are spaces in the JAVA_HOME path
> -
>
> Key: ZOOKEEPER-2281
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2281
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
> Environment: Windows
>Reporter: neha
>Priority: Minor
> Attachments: ZOOKEEPER-2281-00.patch, ZOOKEEPER-2281-01.patch
>
>
> Zookeeper startup fails if there are spaces in the %JAVA_HOME% variable. 
> {code}
> if not exist %JAVA_HOME%\bin\java.exe (
>   echo Error: JAVA_HOME is incorrectly set.
>   goto :eof
> )
> set JAVA=%JAVA_HOME%\bin\java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2281) ZK Server startup fails if there are spaces in the JAVA_HOME path

2015-09-28 Thread Chris Nauroth (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated ZOOKEEPER-2281:
-
Assignee: neha

[~neha.bathra], I've added you to the ZooKeeper Contributor role in JIRA, so 
issues can be assigned to you now.  I'm assigning this one to you.  Thanks 
again.

> ZK Server startup fails if there are spaces in the JAVA_HOME path
> -
>
> Key: ZOOKEEPER-2281
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2281
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
> Environment: Windows
>Reporter: neha
>Assignee: neha
>Priority: Minor
> Attachments: ZOOKEEPER-2281-00.patch, ZOOKEEPER-2281-01.patch
>
>
> Zookeeper startup fails if there are spaces in the %JAVA_HOME% variable. 
> {code}
> if not exist %JAVA_HOME%\bin\java.exe (
>   echo Error: JAVA_HOME is incorrectly set.
>   goto :eof
> )
> set JAVA=%JAVA_HOME%\bin\java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2282) chroot not stripped from path in asynchronous callbacks

2015-09-28 Thread Andrew Grasso (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Grasso updated ZOOKEEPER-2282:
-
Attachment: strip_chroot.patch

> chroot not stripped from path in asynchronous callbacks
> ---
>
> Key: ZOOKEEPER-2282
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2282
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.4.6, 3.5.0
> Environment: Centos 6.6
>Reporter: Andrew Grasso
> Attachments: strip_chroot.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Callbacks passed to [zoo_acreate], [zoo_async], and [zoo_amulti] (for create 
> ops) are called on paths that include the chroot. This is analagous to issue 
> 1027, which fixed this bug for synchronous calls.
> I've created a patch to fix this in trunk



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2244) On Windows zookeeper fails to restart.

2015-09-28 Thread Rakesh R (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh R updated ZOOKEEPER-2244:

Fix Version/s: 3.6.0

> On Windows zookeeper fails to restart.
> --
>
> Key: ZOOKEEPER-2244
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2244
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Critical
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2244-01.patch, ZOOKEEPER-2244-02.patch, 
> ZOOKEEPER-2244-03.patch, ZOOKEEPER-2244-04.patch, ZOOKEEPER-2244-05.patch, 
> ZOOKEEPER-2244-06.patch
>
>
> This issue occurs in following scenario
> 1) configure server properties in  zookeeper configuration file(zoo.cfg)
> example:
> {code}
> server.1=localhost:43222:43225:participant;0.0.0.0:43228
> server.2=localhost:43223:43226:participant;0.0.0.0:43229
> server.3=localhost:43224:43227:participant;0.0.0.0:43230
> {code}
> 2)  start the servers on windows. All the servers started successfully
> 3) stop any of the server
> 4)  try to start the stopped server. It fails with following error
> {code}
> org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Error 
> processing D:SystemTestCasesZKServer1confzoo.cfg.dynamic.1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2268) Zookeeper doc creation fails on windows

2015-09-28 Thread Chris Nauroth (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated ZOOKEEPER-2268:
-
 Hadoop Flags: Reviewed
Fix Version/s: 3.4.7

+1 for the patch.

I applied the patch locally and verified the docs build on both Mac and 
Windows, using trunk and branch-3.4.  I discovered an unrelated problem with 
the docs build on branch-3.5.  The releasenotes.xml file is missing.  I'm going 
to start a separate thread on that.

I plan to commit this to trunk, branch-3.5 and branch-3.4 later this week, 
unless any other committers have comments.


> Zookeeper doc creation fails on windows
> ---
>
> Key: ZOOKEEPER-2268
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2268
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.4.7, 3.5.2
>
> Attachments: ZOOKEEPER-2268-01.patch
>
>
> Zookeeper doc creation fails on windows with following error
> {code}
> D:\gitHome\zookeeper-trunk\build.xml:484: Execute failed: 
> java.io.IOException: Cannot run program 
> "C:\non-install\apache-forrest-0.9\bin\forrest"
> y "D:\gitHome\zookeeper-trunk\src\docs"): CreateProcess error=193, %1 is not 
> a valid Win32 application
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


releasenotes.xml missing from branch-3.5?

2015-09-28 Thread Chris Nauroth
While doing testing for ZOOKEEPER-2268 (fix docs build on Windows), I 
discovered that "ant docs" is failing on branch-3.5.  (Both trunk and 
branch-3.4 are fine.)  The root cause appears to be a missing file on 
branch-3.5: src/docs/src/documentation/content/xdocs/releasenotes.xml.  This 
causes Forrest to report a failure due to broken hyperlinks targeting 
releasenotes.html.

Does anyone know why this file might be missing?  Is it intentional?  If not, 
then is it appropriate simply to copy in the trunk version?

--Chris Nauroth


[jira] [Created] (ZOOKEEPER-2283) traceFile property is not used in the ZooKeeper, it should be removed from documentation

2015-09-28 Thread Arshad Mohammad (JIRA)
Arshad Mohammad created ZOOKEEPER-2283:
--

 Summary: traceFile property is not used in the ZooKeeper,  it 
should be removed from documentation
 Key: ZOOKEEPER-2283
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2283
 Project: ZooKeeper
  Issue Type: Bug
  Components: documentation
Affects Versions: 3.5.0
Reporter: Arshad Mohammad
Assignee: Arshad Mohammad
 Fix For: 3.5.2


zookeeperAdmin guide have following description for traceFile property
{noformat}
traceFile
(Java system property: requestTraceFile)
If this option is defined, requests will be will logged to a trace file named 
traceFile.year.month.day.
Use of this option provides useful debugging information, but will impact 
performance. (Note: The system property has no zookeeper prefix, and the 
configuration variable name is different from the system property. Yes - it's 
not consistent, and it's annoying.)
{noformat}
But this property is used no where  in the whole ZooKeeper code.it should 
be removed from documentation





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2283) traceFile property is not used in the ZooKeeper, it should be removed from documentation

2015-09-28 Thread Arshad Mohammad (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arshad Mohammad updated ZOOKEEPER-2283:
---
Attachment: ZOOKEEPER-2283-01.patch

> traceFile property is not used in the ZooKeeper,  it should be removed from 
> documentation
> -
>
> Key: ZOOKEEPER-2283
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2283
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2283-01.patch
>
>
> zookeeperAdmin guide have following description for traceFile property
> {noformat}
> traceFile
> (Java system property: requestTraceFile)
> If this option is defined, requests will be will logged to a trace file named 
> traceFile.year.month.day.
> Use of this option provides useful debugging information, but will impact 
> performance. (Note: The system property has no zookeeper prefix, and the 
> configuration variable name is different from the system property. Yes - it's 
> not consistent, and it's annoying.)
> {noformat}
> But this property is used no where  in the whole ZooKeeper code.it should 
> be removed from documentation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Success: ZOOKEEPER-2283 PreCommit Build #2893

2015-09-28 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2283
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2893/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 376254 lines...]
 [exec] +1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12764057/ZOOKEEPER-2283-01.patch
 [exec]   against trunk revision 1705482.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +0 tests included.  The patch appears to be a documentation 
patch that doesn't require tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2893//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2893//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2893//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] cbb2ad819f55da5622e135dde8148a9224e65a6d logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 16 minutes 57 seconds
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2891
Archived 24 artifacts
Archive block size is 32768
Received 7 blocks and 33869943 bytes
Compression is 0.7%
Took 7.3 sec
Recording test results
Description set: ZOOKEEPER-2283
Email was triggered for: Success
Sending email for trigger: Success



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2283) traceFile property is not used in the ZooKeeper, it should be removed from documentation

2015-09-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933722#comment-14933722
 ] 

Hadoop QA commented on ZOOKEEPER-2283:
--

+1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12764057/ZOOKEEPER-2283-01.patch
  against trunk revision 1705482.

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2893//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2893//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2893//console

This message is automatically generated.

> traceFile property is not used in the ZooKeeper,  it should be removed from 
> documentation
> -
>
> Key: ZOOKEEPER-2283
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2283
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2283-01.patch
>
>
> zookeeperAdmin guide have following description for traceFile property
> {noformat}
> traceFile
> (Java system property: requestTraceFile)
> If this option is defined, requests will be will logged to a trace file named 
> traceFile.year.month.day.
> Use of this option provides useful debugging information, but will impact 
> performance. (Note: The system property has no zookeeper prefix, and the 
> configuration variable name is different from the system property. Yes - it's 
> not consistent, and it's annoying.)
> {noformat}
> But this property is used no where  in the whole ZooKeeper code.it should 
> be removed from documentation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: 3-server Zab cluster

2015-09-28 Thread Alexander Shraer
Committing locally when sending an ACK at a server would lead to loss of
consistency - it is possible that this is the only
server that acks, e.g., this server is temporarily disconnected from the
leader, the leader gets re-elected and the operation is truncated from logs
at other servers. Its ok to ACK it but its not ok to commit since this
exposes this to users as a committed operation that they can see.

On Mon, Sep 28, 2015 at 4:19 AM, Ibrahim El-sanosi (PGR) <
i.s.el-san...@newcastle.ac.uk> wrote:

> In Zab, assume we have a cluster consists of 3-servers. To deliver a write
> request, it must run 3 communication steps proposal, acknowledgement and
> commit.
> As Zab uses reliable FIFO, it is possible to remove commit round. As soon
> as a follower receives a proposal, it logs, sends an ACK and commits
> locally. Upon receiving ACK from any follower, leader commits a proposal
> locally, no COMMIT message need to be sent to followers. In this case, all
> servers commit a proposal in two round-trips, resulting in reducing latency
> particularly in followers.
>
> Note that this optimization can only work in 3-servers cluster (follower
> reaches a majority as soon as it acks).
> Does anyone see any problems with such (small) optimization?
> Ibrahim
>


[jira] [Created] (ZOOKEEPER-2284) LogFormatter and SnapshotFormatter does not handle FileNotFoundException gracefully

2015-09-28 Thread Arshad Mohammad (JIRA)
Arshad Mohammad created ZOOKEEPER-2284:
--

 Summary: LogFormatter and SnapshotFormatter does not handle 
FileNotFoundException gracefully
 Key: ZOOKEEPER-2284
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2284
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.5.0
Reporter: Arshad Mohammad
Assignee: Arshad Mohammad
Priority: Minor
 Fix For: 3.5.2


{{LogFormatter}} and {{SnapshotFormatter}} does not handle 
FileNotFoundException gracefully. If file no exist then these classes propagate 
the exception to console.
{code}
Exception in thread "main" java.io.FileNotFoundException: log.1 (The system 
cannot find the file specified)
at java.io.FileInputStream.open(Native Method)
at java.io.FileInputStream.(FileInputStream.java:146)
at java.io.FileInputStream.(FileInputStream.java:101)
at org.apache.zookeeper.server.LogFormatter.main(LogFormatter.java:49)
{code}

 File existence should be validated and appropriate message should be displayed 
on console if file does not exist



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2244) On Windows zookeeper fails to restart.

2015-09-28 Thread Rakesh R (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933741#comment-14933741
 ] 

Rakesh R commented on ZOOKEEPER-2244:
-

Thanks [~arshad.mohammad].

Just one last comment, I failed to identify this point in my previous 
reviews:(. For me this unit test case looks like a backward compatibility 
testing for the reconfiguration module. I could see there is a similar unit 
test in 
[ReconfigLegacyTest.java#L54|https://github.com/apache/zookeeper/blob/trunk/src/java/test/org/apache/zookeeper/server/quorum/ReconfigLegacyTest.java#L54].
 Can we move the newly added unit test case into 
{{ReconfigLegacyTest#testRestartZooKeeperServer}} test class?

Apart from this +1 from me.

> On Windows zookeeper fails to restart.
> --
>
> Key: ZOOKEEPER-2244
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2244
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Critical
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2244-01.patch, ZOOKEEPER-2244-02.patch, 
> ZOOKEEPER-2244-03.patch, ZOOKEEPER-2244-04.patch, ZOOKEEPER-2244-05.patch, 
> ZOOKEEPER-2244-06.patch
>
>
> This issue occurs in following scenario
> 1) configure server properties in  zookeeper configuration file(zoo.cfg)
> example:
> {code}
> server.1=localhost:43222:43225:participant;0.0.0.0:43228
> server.2=localhost:43223:43226:participant;0.0.0.0:43229
> server.3=localhost:43224:43227:participant;0.0.0.0:43230
> {code}
> 2)  start the servers on windows. All the servers started successfully
> 3) stop any of the server
> 4)  try to start the stopped server. It fails with following error
> {code}
> org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Error 
> processing D:SystemTestCasesZKServer1confzoo.cfg.dynamic.1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2284) LogFormatter and SnapshotFormatter does not handle FileNotFoundException gracefully

2015-09-28 Thread Arshad Mohammad (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arshad Mohammad updated ZOOKEEPER-2284:
---
Attachment: ZOOKEEPER-2284-01.patch

> LogFormatter and SnapshotFormatter does not handle FileNotFoundException 
> gracefully
> ---
>
> Key: ZOOKEEPER-2284
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2284
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Minor
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2284-01.patch
>
>
> {{LogFormatter}} and {{SnapshotFormatter}} does not handle 
> FileNotFoundException gracefully. If file no exist then these classes 
> propagate the exception to console.
> {code}
> Exception in thread "main" java.io.FileNotFoundException: log.1 (The system 
> cannot find the file specified)
> at java.io.FileInputStream.open(Native Method)
> at java.io.FileInputStream.(FileInputStream.java:146)
> at java.io.FileInputStream.(FileInputStream.java:101)
> at org.apache.zookeeper.server.LogFormatter.main(LogFormatter.java:49)
> {code}
>  File existence should be validated and appropriate message should be 
> displayed on console if file does not exist



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2244) On Windows zookeeper fails to restart.

2015-09-28 Thread Arshad Mohammad (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arshad Mohammad updated ZOOKEEPER-2244:
---
Attachment: ZOOKEEPER-2244-07.patch

Thanks once again [~rakeshr]. Submitting  ZOOKEEPER-2244-07.patch :-)

> On Windows zookeeper fails to restart.
> --
>
> Key: ZOOKEEPER-2244
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2244
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Critical
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2244-01.patch, ZOOKEEPER-2244-02.patch, 
> ZOOKEEPER-2244-03.patch, ZOOKEEPER-2244-04.patch, ZOOKEEPER-2244-05.patch, 
> ZOOKEEPER-2244-06.patch, ZOOKEEPER-2244-07.patch
>
>
> This issue occurs in following scenario
> 1) configure server properties in  zookeeper configuration file(zoo.cfg)
> example:
> {code}
> server.1=localhost:43222:43225:participant;0.0.0.0:43228
> server.2=localhost:43223:43226:participant;0.0.0.0:43229
> server.3=localhost:43224:43227:participant;0.0.0.0:43230
> {code}
> 2)  start the servers on windows. All the servers started successfully
> 3) stop any of the server
> 4)  try to start the stopped server. It fails with following error
> {code}
> org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Error 
> processing D:SystemTestCasesZKServer1confzoo.cfg.dynamic.1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2244) On Windows zookeeper fails to restart.

2015-09-28 Thread Chris Nauroth (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933840#comment-14933840
 ] 

Chris Nauroth commented on ZOOKEEPER-2244:
--

+1 from me again on patch v07, pending a fresh pre-commit run.  I confirmed 
once again that the test fails on Windows before applying the product code fix, 
and then it passes after applying the fix.

[~arshad.mohammad], thank you for fixing this!

[~rgs] and [~rakeshr], thank you for the help on code review and pointing out 
some test improvements.

> On Windows zookeeper fails to restart.
> --
>
> Key: ZOOKEEPER-2244
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2244
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Critical
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2244-01.patch, ZOOKEEPER-2244-02.patch, 
> ZOOKEEPER-2244-03.patch, ZOOKEEPER-2244-04.patch, ZOOKEEPER-2244-05.patch, 
> ZOOKEEPER-2244-06.patch, ZOOKEEPER-2244-07.patch
>
>
> This issue occurs in following scenario
> 1) configure server properties in  zookeeper configuration file(zoo.cfg)
> example:
> {code}
> server.1=localhost:43222:43225:participant;0.0.0.0:43228
> server.2=localhost:43223:43226:participant;0.0.0.0:43229
> server.3=localhost:43224:43227:participant;0.0.0.0:43230
> {code}
> 2)  start the servers on windows. All the servers started successfully
> 3) stop any of the server
> 4)  try to start the stopped server. It fails with following error
> {code}
> org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Error 
> processing D:SystemTestCasesZKServer1confzoo.cfg.dynamic.1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [ANNOUNCE] New committer: Chris Nauroth

2015-09-28 Thread Edward Ribeiro
Congratulations, Chris!!!

Best,
Edward
Em 28/09/2015 14:12, "Alexander Shraer"  escreveu:

> Congrats Chris, and welcome!
>
> On Mon, Sep 28, 2015 at 9:52 AM, Rakesh Radhakrishnan <
> rakeshr.apa...@gmail.com> wrote:
>
> > Welcome Chris, thanks for all your great work and congrats!
> >
> > -Rakesh
> >
> > On Mon, Sep 28, 2015 at 8:11 PM, Flavio Junqueira 
> wrote:
> >
> > > The Apache ZooKeeper PMC is pleased to announce that Chris Nauroth has
> > > accepted to become a committer. Chris has been a great contributor and
> > very
> > > active in the community.
> > >
> > > Congrats, Chris!
> > >
> > > -Flavio
> >
>


[jira] [Commented] (ZOOKEEPER-2284) LogFormatter and SnapshotFormatter does not handle FileNotFoundException gracefully

2015-09-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933844#comment-14933844
 ] 

Hadoop QA commented on ZOOKEEPER-2284:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12764068/ZOOKEEPER-2284-01.patch
  against trunk revision 1705482.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2894//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2894//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2894//console

This message is automatically generated.

> LogFormatter and SnapshotFormatter does not handle FileNotFoundException 
> gracefully
> ---
>
> Key: ZOOKEEPER-2284
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2284
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Minor
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2284-01.patch
>
>
> {{LogFormatter}} and {{SnapshotFormatter}} does not handle 
> FileNotFoundException gracefully. If file no exist then these classes 
> propagate the exception to console.
> {code}
> Exception in thread "main" java.io.FileNotFoundException: log.1 (The system 
> cannot find the file specified)
> at java.io.FileInputStream.open(Native Method)
> at java.io.FileInputStream.(FileInputStream.java:146)
> at java.io.FileInputStream.(FileInputStream.java:101)
> at org.apache.zookeeper.server.LogFormatter.main(LogFormatter.java:49)
> {code}
>  File existence should be validated and appropriate message should be 
> displayed on console if file does not exist



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Failed: ZOOKEEPER-2284 PreCommit Build #2894

2015-09-28 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2284
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2894/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 657267 lines...]
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2894//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2894//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2894//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 02c948e688352146130d72fa19f2f7ab30fd87f6 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1787:
 exec returned: 2

Total time: 23 minutes 50 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2893
Archived 7 artifacts
Archive block size is 32768
Received 8 blocks and 304795 bytes
Compression is 46.2%
Took 2.2 sec
Recording test results
Description set: ZOOKEEPER-2284
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
2 tests failed.
REGRESSION:  org.apache.zookeeper.test.LETest.testLE

Error Message:
Threads didn't join

Stack Trace:
junit.framework.AssertionFailedError: Threads didn't join
at org.apache.zookeeper.test.LETest.testLE(LETest.java:123)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)


REGRESSION:  org.apache.zookeeper.test.QuorumTest.testSessionMoved

Error Message:
Timeout occurred. Please note the time in the report does not reflect the time 
until the timeout.

Stack Trace:
junit.framework.AssertionFailedError: Timeout occurred. Please note the time in 
the report does not reflect the time until the timeout.
at java.lang.Thread.run(Thread.java:722)




[jira] [Commented] (ZOOKEEPER-2244) On Windows zookeeper fails to restart.

2015-09-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933928#comment-14933928
 ] 

Hadoop QA commented on ZOOKEEPER-2244:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12764076/ZOOKEEPER-2244-07.patch
  against trunk revision 1705482.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2895//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2895//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2895//console

This message is automatically generated.

> On Windows zookeeper fails to restart.
> --
>
> Key: ZOOKEEPER-2244
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2244
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Critical
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2244-01.patch, ZOOKEEPER-2244-02.patch, 
> ZOOKEEPER-2244-03.patch, ZOOKEEPER-2244-04.patch, ZOOKEEPER-2244-05.patch, 
> ZOOKEEPER-2244-06.patch, ZOOKEEPER-2244-07.patch
>
>
> This issue occurs in following scenario
> 1) configure server properties in  zookeeper configuration file(zoo.cfg)
> example:
> {code}
> server.1=localhost:43222:43225:participant;0.0.0.0:43228
> server.2=localhost:43223:43226:participant;0.0.0.0:43229
> server.3=localhost:43224:43227:participant;0.0.0.0:43230
> {code}
> 2)  start the servers on windows. All the servers started successfully
> 3) stop any of the server
> 4)  try to start the stopped server. It fails with following error
> {code}
> org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Error 
> processing D:SystemTestCasesZKServer1confzoo.cfg.dynamic.1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Failed: ZOOKEEPER-2244 PreCommit Build #2895

2015-09-28 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2244
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2895/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 334867 lines...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2895//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2895//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2895//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] f69cb3af409b752d777f1ab2d35454dbd269c37a logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1787:
 exec returned: 1

Total time: 9 minutes 32 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2893
Archived 7 artifacts
Archive block size is 32768
Received 8 blocks and 304797 bytes
Compression is 46.2%
Took 6.4 sec
Recording test results
Description set: ZOOKEEPER-2244
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  org.apache.zookeeper.test.LETest.testLE

Error Message:
Threads didn't join

Stack Trace:
junit.framework.AssertionFailedError: Threads didn't join
at org.apache.zookeeper.test.LETest.testLE(LETest.java:123)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)




[jira] [Commented] (ZOOKEEPER-2244) On Windows zookeeper fails to restart.

2015-09-28 Thread Arshad Mohammad (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933954#comment-14933954
 ] 

Arshad Mohammad commented on ZOOKEEPER-2244:


Test failure is not related to this patch

> On Windows zookeeper fails to restart.
> --
>
> Key: ZOOKEEPER-2244
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2244
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Critical
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2244-01.patch, ZOOKEEPER-2244-02.patch, 
> ZOOKEEPER-2244-03.patch, ZOOKEEPER-2244-04.patch, ZOOKEEPER-2244-05.patch, 
> ZOOKEEPER-2244-06.patch, ZOOKEEPER-2244-07.patch
>
>
> This issue occurs in following scenario
> 1) configure server properties in  zookeeper configuration file(zoo.cfg)
> example:
> {code}
> server.1=localhost:43222:43225:participant;0.0.0.0:43228
> server.2=localhost:43223:43226:participant;0.0.0.0:43229
> server.3=localhost:43224:43227:participant;0.0.0.0:43230
> {code}
> 2)  start the servers on windows. All the servers started successfully
> 3) stop any of the server
> 4)  try to start the stopped server. It fails with following error
> {code}
> org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Error 
> processing D:SystemTestCasesZKServer1confzoo.cfg.dynamic.1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (ZOOKEEPER-2285) QuorumTest's ignored test case causes wrong CI pre-commit feedback

2015-09-28 Thread Arshad Mohammad (JIRA)
Arshad Mohammad created ZOOKEEPER-2285:
--

 Summary: QuorumTest's ignored test case causes wrong CI pre-commit 
feedback
 Key: ZOOKEEPER-2285
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2285
 Project: ZooKeeper
  Issue Type: Bug
  Components: tests
Affects Versions: 3.5.0
Reporter: Arshad Mohammad
Assignee: Arshad Mohammad
 Fix For: 3.5.2


# test case {{org.apache.zookeeper.test.QuorumTest.testSessionMove()}} is 
marked ignored by ZOOKEEPER-907
# Most of the CI pre-commit feedback is -1 because of above ignored test case.
# Test case is locally passing

The ignore tag should be removed from testSessionMove test case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2285) QuorumTest's ignored test case causes wrong CI pre-commit feedback

2015-09-28 Thread Arshad Mohammad (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arshad Mohammad updated ZOOKEEPER-2285:
---
Attachment: ZOOKEEPER-2285-01.patch

Removed Ignore tag from testSessionMove test case. Verified, it pass locally. 
don't know why it was ignored.

> QuorumTest's ignored test case causes wrong CI pre-commit feedback
> --
>
> Key: ZOOKEEPER-2285
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2285
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2285-01.patch
>
>
> # test case {{org.apache.zookeeper.test.QuorumTest.testSessionMove()}} is 
> marked ignored by ZOOKEEPER-907
> # Most of the CI pre-commit feedback is -1 because of above ignored test case.
> # Test case is locally passing
> The ignore tag should be removed from testSessionMove test case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [ANNOUNCE] New committer: Chris Nauroth

2015-09-28 Thread Arshad Mohammad
Congratulations  Chris Nauroth!  Well deserved

Best Regards
Mohammad Arshad

On Tue, Sep 29, 2015 at 12:56 AM, Edward Ribeiro 
wrote:

> Congratulations, Chris!!!
>
> Best,
> Edward
> Em 28/09/2015 14:12, "Alexander Shraer"  escreveu:
>
> > Congrats Chris, and welcome!
> >
> > On Mon, Sep 28, 2015 at 9:52 AM, Rakesh Radhakrishnan <
> > rakeshr.apa...@gmail.com> wrote:
> >
> > > Welcome Chris, thanks for all your great work and congrats!
> > >
> > > -Rakesh
> > >
> > > On Mon, Sep 28, 2015 at 8:11 PM, Flavio Junqueira 
> > wrote:
> > >
> > > > The Apache ZooKeeper PMC is pleased to announce that Chris Nauroth
> has
> > > > accepted to become a committer. Chris has been a great contributor
> and
> > > very
> > > > active in the community.
> > > >
> > > > Congrats, Chris!
> > > >
> > > > -Flavio
> > >
> >
>


[jira] [Updated] (ZOOKEEPER-2202) Cluster crashes when reconfig adds an unreachable observer

2015-09-28 Thread Raul Gutierrez Segales (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raul Gutierrez Segales updated ZOOKEEPER-2202:
--
Attachment: ZOOKEEPER-2202.patch

[~shralex]: does this make sense to you? I'll add a test a bit later today. 
Thanks!

cc: [~cnauroth], [~hdeng]

> Cluster crashes when reconfig adds an unreachable observer
> --
>
> Key: ZOOKEEPER-2202
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2202
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0, 3.6.0
>Reporter: Raul Gutierrez Segales
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2202.patch
>
>
> While adding support for reconfig() in Kazoo 
> (https://github.com/python-zk/kazoo/pull/333) I found that the cluster can be 
> crashed if you add an observer whose election port isn't reachable (i.e.: 
> packets for that destination are dropped, not rejected). This will raise a 
> SocketTimeoutException which will bring down the PrepRequestProcessor:
> {code}
> 2015-06-02 14:37:16,473 [myid:3] - WARN  [ProcessThread(sid:3 
> cport:-1)::QuorumCnxManager@384] - Cannot open channel to 100 at election 
> address /8.8.8.8:38703
> java.net.SocketTimeoutException: connect timed out
> at java.net.PlainSocketImpl.socketConnect(Native Method)
> at 
> java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:345)
> at 
> java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
> at 
> java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
> at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
> at java.net.Socket.connect(Socket.java:589)
> at 
> org.apache.zookeeper.server.quorum.QuorumCnxManager.connectOne(QuorumCnxManager.java:369)
> at 
> org.apache.zookeeper.server.quorum.QuorumPeer.connectNewPeers(QuorumPeer.java:1288)
> at 
> org.apache.zookeeper.server.quorum.QuorumPeer.setLastSeenQuorumVerifier(QuorumPeer.java:1315)
> at org.apache.zookeeper.server.quorum.Leader.propose(Leader.java:1056)
> at 
> org.apache.zookeeper.server.quorum.ProposalRequestProcessor.processRequest(ProposalRequestProcessor.java:78)
> at 
> org.apache.zookeeper.server.PrepRequestProcessor.pRequest(PrepRequestProcessor.java:877)
> at 
> org.apache.zookeeper.server.PrepRequestProcessor.run(PrepRequestProcessor.java:143)
> {code}
> A simple repro can be obtained by using the code in the referenced pull 
> request above and using 8.8.8.8:3888 (for example) instead of a free (but 
> closed) port in the loopback. 
> I think that adding an Observer (or a Participant) that isn't currently 
> reachable is a valid use case (i.e.: you are provisioning the machine and 
> it's not currently needed) so I think we could handle this with lower connect 
> timeouts, not sure. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2202) Cluster crashes when reconfig adds an unreachable observer

2015-09-28 Thread Alexander Shraer (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934133#comment-14934133
 ] 

Alexander Shraer commented on ZOOKEEPER-2202:
-

Thanks Raul! Why not extend the catch block in ConnectOne to catch the thrown 
exceptions here ? Is there a case we want the exceptions to be thrown ?

> Cluster crashes when reconfig adds an unreachable observer
> --
>
> Key: ZOOKEEPER-2202
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2202
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0, 3.6.0
>Reporter: Raul Gutierrez Segales
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2202.patch
>
>
> While adding support for reconfig() in Kazoo 
> (https://github.com/python-zk/kazoo/pull/333) I found that the cluster can be 
> crashed if you add an observer whose election port isn't reachable (i.e.: 
> packets for that destination are dropped, not rejected). This will raise a 
> SocketTimeoutException which will bring down the PrepRequestProcessor:
> {code}
> 2015-06-02 14:37:16,473 [myid:3] - WARN  [ProcessThread(sid:3 
> cport:-1)::QuorumCnxManager@384] - Cannot open channel to 100 at election 
> address /8.8.8.8:38703
> java.net.SocketTimeoutException: connect timed out
> at java.net.PlainSocketImpl.socketConnect(Native Method)
> at 
> java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:345)
> at 
> java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
> at 
> java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
> at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
> at java.net.Socket.connect(Socket.java:589)
> at 
> org.apache.zookeeper.server.quorum.QuorumCnxManager.connectOne(QuorumCnxManager.java:369)
> at 
> org.apache.zookeeper.server.quorum.QuorumPeer.connectNewPeers(QuorumPeer.java:1288)
> at 
> org.apache.zookeeper.server.quorum.QuorumPeer.setLastSeenQuorumVerifier(QuorumPeer.java:1315)
> at org.apache.zookeeper.server.quorum.Leader.propose(Leader.java:1056)
> at 
> org.apache.zookeeper.server.quorum.ProposalRequestProcessor.processRequest(ProposalRequestProcessor.java:78)
> at 
> org.apache.zookeeper.server.PrepRequestProcessor.pRequest(PrepRequestProcessor.java:877)
> at 
> org.apache.zookeeper.server.PrepRequestProcessor.run(PrepRequestProcessor.java:143)
> {code}
> A simple repro can be obtained by using the code in the referenced pull 
> request above and using 8.8.8.8:3888 (for example) instead of a free (but 
> closed) port in the loopback. 
> I think that adding an Observer (or a Participant) that isn't currently 
> reachable is a valid use case (i.e.: you are provisioning the machine and 
> it's not currently needed) so I think we could handle this with lower connect 
> timeouts, not sure. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't honor maxClientCnxns param

2015-09-28 Thread Edward Ribeiro (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edward Ribeiro updated ZOOKEEPER-2280:
--
Attachment: ZOOKEEPER-2280.2.patch

Hi [~rgs], addressed your review comments, so I am uploading a new version of 
the patch. _Please_, Let me know if I miss something. Thanks!

> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> -
>
> Key: ZOOKEEPER-2280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.5.0, 3.5.1
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
> Fix For: 3.5.1
>
> Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it 
> doesn't enforce this limit in the code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2238) Support limiting the maximum number of connections/clients to a zookeeper server.

2015-09-28 Thread Edward Ribeiro (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edward Ribeiro updated ZOOKEEPER-2238:
--
Attachment: ZOOKEEPER-2238.4.patch

Hi [~rgs], I am attaching the latest patch with your review comments addressed. 
Let's see what Jenkins has to spill. :) _Please_, let me know if I have missed 
something. Thanks!

> Support limiting the maximum number of connections/clients to a zookeeper 
> server.
> -
>
> Key: ZOOKEEPER-2238
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2238
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: nijel
>Assignee: Edward Ribeiro
> Attachments: ZOOKEEPER-2238.2.patch, ZOOKEEPER-2238.3.patch, 
> ZOOKEEPER-2238.4.patch, ZOOKEEPER-2238.diff
>
>
> Currently zookeeper have the feature of limiting the maximum number of 
> connection/client  per IP or Host (maxClientCnxns).
> But to safe guard zookeeper server from DoS attack due to many clients from 
> different IPs,  it is better to have a limit of total number of 
> connections/clients to a a single member of the ZooKeeper ensemble as well.
> So the idea is to introduce a new configuration to limit the maximum number 
> of total connections/clients.
> Please share your thoughts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2284) LogFormatter and SnapshotFormatter does not handle FileNotFoundException gracefully

2015-09-28 Thread Edward Ribeiro (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934207#comment-14934207
 ] 

Edward Ribeiro commented on ZOOKEEPER-2284:
---

Thanks for the patch [~arshad.mohammad]! As you are doing a clean File 
treatment, would you mind to detect if the File is readable 
({{file.canRead()}}) and/or is a file ({{file.isFile()}}), too? I think that 
particularly the read permissions can be quite handy in a production 
environment.

> LogFormatter and SnapshotFormatter does not handle FileNotFoundException 
> gracefully
> ---
>
> Key: ZOOKEEPER-2284
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2284
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Minor
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2284-01.patch
>
>
> {{LogFormatter}} and {{SnapshotFormatter}} does not handle 
> FileNotFoundException gracefully. If file no exist then these classes 
> propagate the exception to console.
> {code}
> Exception in thread "main" java.io.FileNotFoundException: log.1 (The system 
> cannot find the file specified)
> at java.io.FileInputStream.open(Native Method)
> at java.io.FileInputStream.(FileInputStream.java:146)
> at java.io.FileInputStream.(FileInputStream.java:101)
> at org.apache.zookeeper.server.LogFormatter.main(LogFormatter.java:49)
> {code}
>  File existence should be validated and appropriate message should be 
> displayed on console if file does not exist



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Failed: ZOOKEEPER-2285 PreCommit Build #2896

2015-09-28 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2285
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2896/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 341011 lines...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2896//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2896//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2896//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 25944ace6edc71f4da725c246c3d58c8d3aac0b6 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1787:
 exec returned: 1

Total time: 9 minutes 59 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2893
Archived 7 artifacts
Archive block size is 32768
Received 10 blocks and 239256 bytes
Compression is 57.8%
Took 0.79 sec
Recording test results
Description set: ZOOKEEPER-2285
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  org.apache.zookeeper.test.LETest.testLE

Error Message:
Threads didn't join

Stack Trace:
junit.framework.AssertionFailedError: Threads didn't join
at org.apache.zookeeper.test.LETest.testLE(LETest.java:123)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)




[jira] [Commented] (ZOOKEEPER-2285) QuorumTest's ignored test case causes wrong CI pre-commit feedback

2015-09-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934220#comment-14934220
 ] 

Hadoop QA commented on ZOOKEEPER-2285:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12764108/ZOOKEEPER-2285-01.patch
  against trunk revision 1705482.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2896//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2896//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2896//console

This message is automatically generated.

> QuorumTest's ignored test case causes wrong CI pre-commit feedback
> --
>
> Key: ZOOKEEPER-2285
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2285
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2285-01.patch
>
>
> # test case {{org.apache.zookeeper.test.QuorumTest.testSessionMove()}} is 
> marked ignored by ZOOKEEPER-907
> # Most of the CI pre-commit feedback is -1 because of above ignored test case.
> # Test case is locally passing
> The ignore tag should be removed from testSessionMove test case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Failed: ZOOKEEPER-2238 PreCommit Build #2898

2015-09-28 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2238
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2898/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 778 lines...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 69 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2898//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2898//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2898//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] fc5402148cf060777af31c436e86aeda1b2fbf5c logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build@2/trunk/build.xml:1787:
 exec returned: 1

Total time: 3 minutes 7 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2893
Archived 7 artifacts
Archive block size is 32768
Received 0 blocks and 570591 bytes
Compression is 0.0%
Took 0.71 sec
Recording test results
Description set: ZOOKEEPER-2238
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

Failed: ZOOKEEPER-2280 PreCommit Build #2897

2015-09-28 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2897/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 162531 lines...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] -1 contrib tests.  The patch failed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2897//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2897//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2897//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/java/test/bin/test-patch.sh:
 line 493: 29440 Killed  $ANT_HOME/bin/ant 
-DZookeeperPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes 
test-contrib
 [exec] Comment added.
 [exec] ff826dd1492fd6166c2653290889ebd9e3d3af5e logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1787:
 exec returned: 2

Total time: 5 minutes 50 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2893
Archived 7 artifacts
Archive block size is 32768
Received 8 blocks and 304790 bytes
Compression is 46.2%
Took 0.73 sec
Recording test results
Description set: ZOOKEEPER-2280
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't honor maxClientCnxns param

2015-09-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934294#comment-14934294
 ] 

Hadoop QA commented on ZOOKEEPER-2280:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12764119/ZOOKEEPER-2280.2.patch
  against trunk revision 1705482.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

-1 contrib tests.  The patch failed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2897//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2897//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2897//console

This message is automatically generated.

> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> -
>
> Key: ZOOKEEPER-2280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.5.0, 3.5.1
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
> Fix For: 3.5.1
>
> Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it 
> doesn't enforce this limit in the code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2238) Support limiting the maximum number of connections/clients to a zookeeper server.

2015-09-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934295#comment-14934295
 ] 

Hadoop QA commented on ZOOKEEPER-2238:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12764120/ZOOKEEPER-2238.4.patch
  against trunk revision 1705482.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 69 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2898//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2898//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2898//console

This message is automatically generated.

> Support limiting the maximum number of connections/clients to a zookeeper 
> server.
> -
>
> Key: ZOOKEEPER-2238
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2238
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: nijel
>Assignee: Edward Ribeiro
> Attachments: ZOOKEEPER-2238.2.patch, ZOOKEEPER-2238.3.patch, 
> ZOOKEEPER-2238.4.patch, ZOOKEEPER-2238.diff
>
>
> Currently zookeeper have the feature of limiting the maximum number of 
> connection/client  per IP or Host (maxClientCnxns).
> But to safe guard zookeeper server from DoS attack due to many clients from 
> different IPs,  it is better to have a limit of total number of 
> connections/clients to a a single member of the ZooKeeper ensemble as well.
> So the idea is to introduce a new configuration to limit the maximum number 
> of total connections/clients.
> Please share your thoughts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2202) Cluster crashes when reconfig adds an unreachable observer

2015-09-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934315#comment-14934315
 ] 

Hadoop QA commented on ZOOKEEPER-2202:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12764113/ZOOKEEPER-2202.patch
  against trunk revision 1705482.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2899//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2899//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2899//console

This message is automatically generated.

> Cluster crashes when reconfig adds an unreachable observer
> --
>
> Key: ZOOKEEPER-2202
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2202
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0, 3.6.0
>Reporter: Raul Gutierrez Segales
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2202.patch
>
>
> While adding support for reconfig() in Kazoo 
> (https://github.com/python-zk/kazoo/pull/333) I found that the cluster can be 
> crashed if you add an observer whose election port isn't reachable (i.e.: 
> packets for that destination are dropped, not rejected). This will raise a 
> SocketTimeoutException which will bring down the PrepRequestProcessor:
> {code}
> 2015-06-02 14:37:16,473 [myid:3] - WARN  [ProcessThread(sid:3 
> cport:-1)::QuorumCnxManager@384] - Cannot open channel to 100 at election 
> address /8.8.8.8:38703
> java.net.SocketTimeoutException: connect timed out
> at java.net.PlainSocketImpl.socketConnect(Native Method)
> at 
> java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:345)
> at 
> java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
> at 
> java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
> at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
> at java.net.Socket.connect(Socket.java:589)
> at 
> org.apache.zookeeper.server.quorum.QuorumCnxManager.connectOne(QuorumCnxManager.java:369)
> at 
> org.apache.zookeeper.server.quorum.QuorumPeer.connectNewPeers(QuorumPeer.java:1288)
> at 
> org.apache.zookeeper.server.quorum.QuorumPeer.setLastSeenQuorumVerifier(QuorumPeer.java:1315)
> at org.apache.zookeeper.server.quorum.Leader.propose(Leader.java:1056)
> at 
> org.apache.zookeeper.server.quorum.ProposalRequestProcessor.processRequest(ProposalRequestProcessor.java:78)
> at 
> org.apache.zookeeper.server.PrepRequestProcessor.pRequest(PrepRequestProcessor.java:877)
> at 
> org.apache.zookeeper.server.PrepRequestProcessor.run(PrepRequestProcessor.java:143)
> {code}
> A simple repro can be obtained by using the code in the referenced pull 
> request above and using 8.8.8.8:3888 (for example) instead of a free (but 
> closed) port in the loopback. 
> I think that adding an Observer (or a Participant) that isn't currently 
> reachable is a valid use case (i.e.: you are provisioning the machine and 
> it's not currently needed) so I think we could handle this with lower connect 
> timeouts, not sure. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Failed: ZOOKEEPER-2202 PreCommit Build #2899

2015-09-28 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2202
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2899/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 372708 lines...]
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2899//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2899//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2899//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] e8dde615d22e260a76312ed1a505f0a239bd6ef1 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1787:
 exec returned: 2

Total time: 13 minutes 28 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2893
Archived 24 artifacts
Archive block size is 32768
Received 8 blocks and 34246297 bytes
Compression is 0.8%
Took 7.3 sec
Recording test results
Description set: ZOOKEEPER-2202
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2244) On Windows zookeeper fails to restart.

2015-09-28 Thread Rakesh R (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934477#comment-14934477
 ] 

Rakesh R commented on ZOOKEEPER-2244:
-

+1 I'll commit this shortly.

Thanks [~arshad.mohammad] for the contribution!
Thanks [~cnauroth], [~rgs], [~benjamin.jaton] for the reviews!

> On Windows zookeeper fails to restart.
> --
>
> Key: ZOOKEEPER-2244
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2244
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Critical
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2244-01.patch, ZOOKEEPER-2244-02.patch, 
> ZOOKEEPER-2244-03.patch, ZOOKEEPER-2244-04.patch, ZOOKEEPER-2244-05.patch, 
> ZOOKEEPER-2244-06.patch, ZOOKEEPER-2244-07.patch
>
>
> This issue occurs in following scenario
> 1) configure server properties in  zookeeper configuration file(zoo.cfg)
> example:
> {code}
> server.1=localhost:43222:43225:participant;0.0.0.0:43228
> server.2=localhost:43223:43226:participant;0.0.0.0:43229
> server.3=localhost:43224:43227:participant;0.0.0.0:43230
> {code}
> 2)  start the servers on windows. All the servers started successfully
> 3) stop any of the server
> 4)  try to start the stopped server. It fails with following error
> {code}
> org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Error 
> processing D:SystemTestCasesZKServer1confzoo.cfg.dynamic.1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2244) On Windows zookeeper fails to restart

2015-09-28 Thread Rakesh R (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh R updated ZOOKEEPER-2244:

Summary: On Windows zookeeper fails to restart  (was: On Windows zookeeper 
fails to restart.)

> On Windows zookeeper fails to restart
> -
>
> Key: ZOOKEEPER-2244
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2244
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Critical
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2244-01.patch, ZOOKEEPER-2244-02.patch, 
> ZOOKEEPER-2244-03.patch, ZOOKEEPER-2244-04.patch, ZOOKEEPER-2244-05.patch, 
> ZOOKEEPER-2244-06.patch, ZOOKEEPER-2244-07.patch
>
>
> This issue occurs in following scenario
> 1) configure server properties in  zookeeper configuration file(zoo.cfg)
> example:
> {code}
> server.1=localhost:43222:43225:participant;0.0.0.0:43228
> server.2=localhost:43223:43226:participant;0.0.0.0:43229
> server.3=localhost:43224:43227:participant;0.0.0.0:43230
> {code}
> 2)  start the servers on windows. All the servers started successfully
> 3) stop any of the server
> 4)  try to start the stopped server. It fails with following error
> {code}
> org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Error 
> processing D:SystemTestCasesZKServer1confzoo.cfg.dynamic.1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2244) On Windows zookeeper fails to restart

2015-09-28 Thread Rakesh R (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh R updated ZOOKEEPER-2244:

Attachment: ZOOKEEPER-2244-09.patch

> On Windows zookeeper fails to restart
> -
>
> Key: ZOOKEEPER-2244
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2244
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Critical
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2244-01.patch, ZOOKEEPER-2244-02.patch, 
> ZOOKEEPER-2244-03.patch, ZOOKEEPER-2244-04.patch, ZOOKEEPER-2244-05.patch, 
> ZOOKEEPER-2244-06.patch, ZOOKEEPER-2244-07.patch, ZOOKEEPER-2244-09.patch
>
>
> This issue occurs in following scenario
> 1) configure server properties in  zookeeper configuration file(zoo.cfg)
> example:
> {code}
> server.1=localhost:43222:43225:participant;0.0.0.0:43228
> server.2=localhost:43223:43226:participant;0.0.0.0:43229
> server.3=localhost:43224:43227:participant;0.0.0.0:43230
> {code}
> 2)  start the servers on windows. All the servers started successfully
> 3) stop any of the server
> 4)  try to start the stopped server. It fails with following error
> {code}
> org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Error 
> processing D:SystemTestCasesZKServer1confzoo.cfg.dynamic.1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


ZooKeeper-trunk - Build # 2801 - Still Failing

2015-09-28 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/2801/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 385713 lines...]
 [exec] Using config: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/../../build/test/test-cppunit/conf/2.conf
 [exec] ZooKeeper JMX enabled by default
 [exec] Using config: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/../../build/test/test-cppunit/conf/0.conf
 [exec] ZooKeeper JMX enabled by default
 [exec] Using config: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/../../build/test/test-cppunit/conf/1.conf
 [exec] ZooKeeper JMX enabled by default
 [exec] Using config: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/../../build/test/test-cppunit/conf/0.conf
 [exec] ZooKeeper JMX enabled by default
 [exec] Using config: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/../../build/test/test-cppunit/conf/1.conf
 [exec] ZooKeeper JMX enabled by default
 [exec] Using config: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/../../build/test/test-cppunit/conf/2.conf
 [exec] ZooKeeper JMX enabled by default
 [exec] Using config: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/../../build/test/test-cppunit/conf/0.conf
 [exec] ZooKeeper JMX enabled by default
 [exec] Using config: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/../../build/test/test-cppunit/conf/1.conf
 [exec] Stopping zookeeper ... STOPPED
 [exec] Stopping zookeeper ... STOPPED
 [exec] ZooKeeper JMX enabled by default
 [exec] Using config: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/../../build/test/test-cppunit/conf/2.conf
 [exec] Stopping zookeeper ... STOPPED
 [exec]  : elapsed 7258 : OK
 [exec] Zookeeper_clientretry::testRetry ZooKeeper server started ZooKeeper 
server started : elapsed 7850 : OK
 [exec] Zookeeper_operations::testAsyncWatcher1 : elapsed 4 : OK
 [exec] Zookeeper_operations::testAsyncGetOperation : elapsed 4 : OK
 [exec] Zookeeper_operations::testOperationsAndDisconnectConcurrently1 : 
assertion : elapsed 355
 [exec] Zookeeper_operations::testOperationsAndDisconnectConcurrently2 : 
elapsed 0 : OK
 [exec] Zookeeper_operations::testConcurrentOperations1 : assertion : 
elapsed 49
 [exec] Zookeeper_multi::testCreateFAIL: zktest-mt
 [exec] ==
 [exec] 1 of 2 tests failed
 [exec] Please report to u...@zookeeper.apache.org
 [exec] ==
 [exec] make[1]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build/test/test-cppunit'
 [exec] /bin/bash: line 5:   892 Segmentation fault  
ZKROOT=/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/../.. 
CLASSPATH=$CLASSPATH:$CLOVER_HOME/lib/clover.jar ${dir}$tst
 [exec] make[1]: *** [check-TESTS] Error 1
 [exec] make: *** [check-am] Error 2

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build.xml:1494: The 
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build.xml:1454: The 
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build.xml:1464: 
exec returned: 2

Total time: 15 minutes 53 seconds
Build step 'Execute shell' marked build as failure
[FINDBUGS] Skipping publisher since build result is FAILURE
[WARNINGS] Skipping publisher since build result is FAILURE
Archiving artifacts
Sending artifact delta relative to ZooKeeper-trunk #2798
Archived 5 artifacts
Archive block size is 32768
Received 2 blocks and 18279170 bytes
Compression is 0.4%
Took 13 sec
Recording fingerprints
Updating ZOOKEEPER-2244
Recording test results
Publishing Javadoc
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2244) On Windows zookeeper fails to restart

2015-09-28 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934524#comment-14934524
 ] 

Hudson commented on ZOOKEEPER-2244:
---

FAILURE: Integrated in ZooKeeper-trunk #2801 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/2801/])
ZOOKEEPER-2244: On Windows zookeeper fails to restart (Arshad Mohammad via 
rakeshr) (rakeshr: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1705794)
* /zookeeper/trunk/CHANGES.txt
* 
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
* 
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/ReconfigLegacyTest.java


> On Windows zookeeper fails to restart
> -
>
> Key: ZOOKEEPER-2244
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2244
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Critical
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2244-01.patch, ZOOKEEPER-2244-02.patch, 
> ZOOKEEPER-2244-03.patch, ZOOKEEPER-2244-04.patch, ZOOKEEPER-2244-05.patch, 
> ZOOKEEPER-2244-06.patch, ZOOKEEPER-2244-07.patch, ZOOKEEPER-2244-09.patch
>
>
> This issue occurs in following scenario
> 1) configure server properties in  zookeeper configuration file(zoo.cfg)
> example:
> {code}
> server.1=localhost:43222:43225:participant;0.0.0.0:43228
> server.2=localhost:43223:43226:participant;0.0.0.0:43229
> server.3=localhost:43224:43227:participant;0.0.0.0:43230
> {code}
> 2)  start the servers on windows. All the servers started successfully
> 3) stop any of the server
> 4)  try to start the stopped server. It fails with following error
> {code}
> org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Error 
> processing D:SystemTestCasesZKServer1confzoo.cfg.dynamic.1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2285) QuorumTest's ignored test case causes wrong CI pre-commit feedback

2015-09-28 Thread Arshad Mohammad (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934686#comment-14934686
 ] 

Arshad Mohammad commented on ZOOKEEPER-2285:


# Test case {{org.apache.zookeeper.test.LETest.testLE}} failure is not because 
of this patch.
# CI test report show that now 
{{org.apache.zookeeper.test.QuorumTest.testSessionMove()}} is not skipped, it 
is run and passed.

> QuorumTest's ignored test case causes wrong CI pre-commit feedback
> --
>
> Key: ZOOKEEPER-2285
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2285
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2285-01.patch
>
>
> # test case {{org.apache.zookeeper.test.QuorumTest.testSessionMove()}} is 
> marked ignored by ZOOKEEPER-907
> # Most of the CI pre-commit feedback is -1 because of above ignored test case.
> # Test case is locally passing
> The ignore tag should be removed from testSessionMove test case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)