RE: How to extend ZooKeeper data structure without breaking the backward compatibility

[Mohammad arshad]

Thanks Patrick and Falvio

I also was more inclined towards the option 3 but it does not solve the problem.
It works for bellow scenarios
i) all new server with fresh data 
ii) all new servers but with old data

As Patrick already pointed out, mixed servers have some unavoidable problems 
(AFAIK). 
Option 3 fails for bellow mix servers mode scenarios

i) Suppose existing quorum of old servers is running, another server (new 
server) joins the quorum, while receiving the snapshot from the old server 
failure occurs.
This is because leader does not send FileHeader. So there is nothing which can 
used to decide which version to de serialize.
Also cannot change the leader code to send the FileHeader while sending the 
snapshot, as this will cascade the problem.
ii) In the rolling upgrade scenario, suppose new server becomes the leader, 
while sending the data to older follower, follower will fail as it will not 
know how to de-serialize the new data


FYI:
Here is what I was doing to implement option 3
a) Increment the dbId in the code
b) Decide whether database is old or not based on the dbId from the FileHeader
De-serialize old data model StatPersistedV0
copy data from old data model StatPersistedV0 to new data model StatPersisted
but off course, the new field cuser will have null.

stat = new StatPersisted();
if (dbIdFromFileHeader < currentDbId)
{
StatPersistedV0 old=new StatPersistedV0();
old.deserialize(archive, "statpersisted");
copyFromOldToNewVersion(old, stat);
}else
{
stat.deserialize(archive, "statpersisted");
}
---

is there anything which can be done to make the Option 3 work for mix mode 
server cases?


Best Regards
Mohammad Arshad
HUAWEI TECHNOLOGIES CO.LTD.
Huawei Tecnologies India Pvt. Ltd.
Near EPIP Industrial Area, Kundalahalli Village
Whitefield, Bangalore-560066
www.huawei.com
-
This e-mail and its attachments contain confidential information from HUAWEI, 
which 
is intended only for the person or entity whose address is listed above. Any 
use of the 
information contained herein in any way (including, but not limited to, total 
or partial 
disclosure, reproduction, or dissemination) by persons other than the intended 
recipient(s) is prohibited. If you receive this e-mail in error, please notify 
the sender by 
phone or email immediately and delete it!


-Original Message-
From: Patrick Hunt [mailto:ph...@apache.org] 
Sent: 13 May 2016 03:58
To: DevZooKeeper
Subject: Re: How to extend ZooKeeper data structure without breaking the 
backward compatibility

I thought we added the version to the file header for exactly this case.
Allowing the server to differentiate in case we need to upgrade the on-disk 
format. Option 3 seems the best to me -- "one time conversions" typically have 
bad corner cases.

You'll also want to think through the upgrade implications re having mixed 
server versions in the ensemble (some old and some new). Might be worth 
thinking about downgrade for that matter...

Patrick

On Wed, May 11, 2016 at 2:13 PM, Flavio Junqueira  wrote:

> We currently put a version in the directory name and afaict the 
> version isn't used anywhere else. We also have a version in FileHeader.
>
> The options I see are:
>
> - We write a tool to convert the data from one format to another. In 
> the case of upgrade, we run the tool before starting the upgraded 
> server. If we do it, then we will be simply moving all the data from 
> the old version to the new version.
> - We can do the same thing as in the first bullet without the tool in 
> the case the server detects that the current data is in the old 
> format. In this case, the serves converts it all before it fully 
> starts. This procedure will of course introduce some delay when starting an 
> upgraded server.
> - Another way is to mix files with different versions and then let the 
> server figure out how to process the data with a given version.
>
> Option 3 is a bit messier because we will be mixing files of different 
> versions, but I'd be interested in hearing opinions. Does it make 
> sense at all?
>
> -Flavio
>
>
> > On 11 May 2016, at 18:06, Flavio P JUNQUEIRA  wrote:
> >
> > We need a file format version in this case.  Let me have look and 
> > get
> back
> > to you.
> >
> > -Flavio
> > On 11 May 2016 15:49, "Mohammad arshad" 
> wrote:
> >
> > Loading snapshot file into memory(deserialization) does not involve 
> > any protocol version.
> > are you suggesting version and dbId from FileHeader?
> > Which field (version, dbId) would be more appropriate to decide 
> > which version ,StatPersisted or StatPersistedV0, to be deserialized. 
> > I think it should be the dbId.
> >
> > Best Regards
> > Mohammad Arshad
> > HUAWEI TECHNOLOGIES CO.LTD.
> > Huawei Te

[jira] [Commented] (ZOOKEEPER-2366) Reconfiguration of client port causes a socket leak

[Alexander Shraer (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297685#comment-15297685
 ] 

Alexander Shraer commented on ZOOKEEPER-2366:
-

I think its actually worse - consider a reconfig changing just one client port, 
of one of the servers. All the other servers don't need to perform any 
operation besides updating the config in their memory, so they won't have any 
issue. The single server may object because it can't bind to the port, but the 
leader only needs a majority vote, so his objection may not arrive on time for 
the commit.

I just want to point out that there is no voting in Paxos or ZooKeeper. Servers 
don't say no to the leader's proposals. Protocols in which servers can say no 
are distributed commit protocols (e.g., 2 phase commit, 3 phase commit, E3PC, 
etc.) but ZooKeeper solves consensus, in which servers don't have a Yes/No vote 
or veto powers.

> Reconfiguration of client port causes a socket leak
> ---
>
> Key: ZOOKEEPER-2366
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2366
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: quorum
>Affects Versions: 3.5.0
>Reporter: Timothy Ward
>Assignee: Flavio Junqueira
>Priority: Blocker
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2366.patch, ZOOKEEPER-2366.patch, 
> zookeeper.patch
>
>
> The NIOServerCnxnFactory reconfigure method can leak server sockets, and 
> hence make ports unusable until the JVM restarts:
> The first line of the method takes a reference to the current 
> ServerSocketChannel and then the next line replaces it. The subsequent 
> interactions with the server socket can fail (for example if the 
> reconfiguration tries to bind to an in-use port). If they fail *before* the  
> call to oldSS.close() then oldSS is *never* closed. This holds that port open 
> forever, and prevents the user from rolling back to the previous port!
> The code from reconfigure is shown below:
>  ServerSocketChannel oldSS = ss;
> try {
>this.ss = ServerSocketChannel.open();
>ss.socket().setReuseAddress(true);
>LOG.info("binding to port " + addr);
>ss.socket().bind(addr);
>ss.configureBlocking(false);
>acceptThread.setReconfiguring();
>oldSS.close();   
>acceptThread.wakeupSelector();
>try {
> acceptThread.join();
>  } catch (InterruptedException e) {
>  LOG.error("Error joining old acceptThread when 
> reconfiguring client port " + e.getMessage());
>  }
>acceptThread = new AcceptThread(ss, addr, selectorThreads);
>acceptThread.start();
> } catch(IOException e) {
>LOG.error("Error reconfiguring client port to " + addr + " " + 
> e.getMessage());
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch34_jdk8 - Build # 579 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/579/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 221455 lines...]
[junit] 2016-05-24 02:56:32,110 [myid:] - INFO  [main:JMXEnv@246] - 
expect:StandaloneServer_port
[junit] 2016-05-24 02:56:32,111 [myid:] - INFO  [main:JMXEnv@250] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221
[junit] 2016-05-24 02:56:32,111 [myid:] - INFO  [main:ClientBase@490] - 
STOPPING server
[junit] 2016-05-24 02:56:32,111 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@219] - 
NIOServerCnxn factory exited run method
[junit] 2016-05-24 02:56:32,111 [myid:] - INFO  [main:ZooKeeperServer@469] 
- shutting down
[junit] 2016-05-24 02:56:32,112 [myid:] - INFO  
[main:SessionTrackerImpl@225] - Shutting down
[junit] 2016-05-24 02:56:32,112 [myid:] - INFO  
[main:PrepRequestProcessor@765] - Shutting down
[junit] 2016-05-24 02:56:32,112 [myid:] - INFO  
[main:SyncRequestProcessor@209] - Shutting down
[junit] 2016-05-24 02:56:32,112 [myid:] - INFO  [ProcessThread(sid:0 
cport:11221)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop!
[junit] 2016-05-24 02:56:32,112 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@187] - SyncRequestProcessor exited!
[junit] 2016-05-24 02:56:32,113 [myid:] - INFO  
[main:FinalRequestProcessor@402] - shutdown of request processor complete
[junit] 2016-05-24 02:56:32,113 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2016-05-24 02:56:32,114 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-05-24 02:56:32,115 [myid:] - INFO  [main:ClientBase@443] - 
STARTING server
[junit] 2016-05-24 02:56:32,116 [myid:] - INFO  [main:ClientBase@364] - 
CREATING server instance 127.0.0.1:11221
[junit] 2016-05-24 02:56:32,116 [myid:] - INFO  
[main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2016-05-24 02:56:32,116 [myid:] - INFO  [main:ClientBase@339] - 
STARTING server instance 127.0.0.1:11221
[junit] 2016-05-24 02:56:32,117 [myid:] - INFO  [main:ZooKeeperServer@170] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/x1/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/branch-3.4/build/test/tmp/test1230804030359585289.junit.dir/version-2
 snapdir 
/x1/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/branch-3.4/build/test/tmp/test1230804030359585289.junit.dir/version-2
[junit] 2016-05-24 02:56:32,120 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2016-05-24 02:56:32,120 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - 
Accepted socket connection from /127.0.0.1:39503
[junit] 2016-05-24 02:56:32,121 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing 
stat command from /127.0.0.1:39503
[junit] 2016-05-24 02:56:32,121 [myid:] - INFO  
[Thread-4:NIOServerCnxn$StatCommand@663] - Stat command output
[junit] 2016-05-24 02:56:32,121 [myid:] - INFO  
[Thread-4:NIOServerCnxn@1008] - Closed socket connection for client 
/127.0.0.1:39503 (no session established for client)
[junit] 2016-05-24 02:56:32,121 [myid:] - INFO  [main:JMXEnv@229] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-05-24 02:56:32,123 [myid:] - INFO  [main:JMXEnv@246] - 
expect:InMemoryDataTree
[junit] 2016-05-24 02:56:32,123 [myid:] - INFO  [main:JMXEnv@250] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree
[junit] 2016-05-24 02:56:32,123 [myid:] - INFO  [main:JMXEnv@246] - 
expect:StandaloneServer_port
[junit] 2016-05-24 02:56:32,123 [myid:] - INFO  [main:JMXEnv@250] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221
[junit] 2016-05-24 02:56:32,124 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 5427
[junit] 2016-05-24 02:56:32,124 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20
[junit] 2016-05-24 02:56:32,124 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota
[junit] 2016-05-24 02:56:32,125 [myid:] - INFO  [main:ClientBase@520] - 
tearDown starting
[junit] 2016-05-24 02:56:32,194 [myid:] - INFO  [main:ZooKeeper@684] - 
Session: 0x154e0b13a21 closed
[junit] 2016-05-24 02:56:32,194 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@519] - EventThread shut down for 
session: 0x154e0b13a21
[junit] 2016-05-24 02:56:32,194 [myid:] - INFO  [main:ClientBase@490] - 
STOPPING server
[junit] 2016-05-24 02:56:32,194 [myid:] - INFO  
[NIOServerCxn.Fa

ZooKeeper_branch35_openjdk7 - Build # 91 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/91/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 1522 lines...]
[ivy:retrieve] downloading 
http://repo1.maven.org/maven2/log4j/log4j/1.2.17/log4j-1.2.17.jar ...
[ivy:retrieve] . (478kB)
[ivy:retrieve] .. (0kB)
[ivy:retrieve]  [SUCCESSFUL ] log4j#log4j;1.2.17!log4j.jar(bundle) (38ms)
[ivy:retrieve] downloading 
http://repo1.maven.org/maven2/io/netty/netty/3.10.5.Final/netty-3.10.5.Final.jar
 ...
[ivy:retrieve]  (1299kB)
[ivy:retrieve] .. (0kB)
[ivy:retrieve]  [SUCCESSFUL ] io.netty#netty;3.10.5.Final!netty.jar (50ms)
[ivy:retrieve] downloading 
http://repo1.maven.org/maven2/net/java/dev/javacc/javacc/5.0/javacc-5.0.jar ...
[ivy:retrieve] ... (291kB)
[ivy:retrieve] .. (0kB)
[ivy:retrieve]  [SUCCESSFUL ] net.java.dev.javacc#javacc;5.0!javacc.jar (39ms)
[ivy:retrieve] :: resolution report :: resolve 5383ms :: artifacts dl 485ms
-
|  |modules||   artifacts   |
|   conf   | number| search|dwnlded|evicted|| number|dwnlded|
-
|  default |   12  |   12  |   12  |   0   ||   12  |   12  |
-
[ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper
[ivy:retrieve]  confs: [default]
[ivy:retrieve]  12 artifacts copied, 0 already retrieved (4167kB/38ms)

clover.setup:

clover.info:

clover:

generate_jute_parser:
[mkdir] Created dir: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_openjdk7/branch-3.5/build/jute_compiler/org/apache/jute/compiler/generated
[ivy:artifactproperty] DEPRECATED: 'ivy.conf.file' is deprecated, use 
'ivy.settings.file' instead
[ivy:artifactproperty] :: loading settings :: file = 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_openjdk7/branch-3.5/ivysettings.xml
 [move] Moving 1 file to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_openjdk7/branch-3.5/build/lib
   [javacc] Java Compiler Compiler Version 5.0 (Parser Generator)
   [javacc] (type "javacc" with no arguments for help)
   [javacc] Reading from file 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_openjdk7/branch-3.5/src/java/main/org/apache/jute/compiler/generated/rcc.jj
 . . .
   [javacc] File "TokenMgrError.java" does not exist.  Will create one.
   [javacc] File "ParseException.java" does not exist.  Will create one.
   [javacc] File "Token.java" does not exist.  Will create one.
   [javacc] File "SimpleCharStream.java" does not exist.  Will create one.
   [javacc] Parser generated successfully.

jute:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_openjdk7/branch-3.5/build.xml:1322:
 The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_openjdk7/branch-3.5/build.xml:272:
 Unable to find a javac compiler;
com.sun.tools.javac.Main is not on the classpath.
Perhaps JAVA_HOME does not point to the JDK.
It is currently set to "/usr/lib/jvm/java-7-openjdk-amd64/jre"

Total time: 8 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Recording test results
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

ZooKeeper_branch35_jdk8 - Build # 94 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/94/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 388473 lines...]
[junit] 2016-05-24 01:05:06,202 [myid:] - INFO  [ProcessThread(sid:0 
cport:11222)::PrepRequestProcessor@154] - PrepRequestProcessor exited loop!
[junit] 2016-05-24 01:05:06,202 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2016-05-24 01:05:06,202 [myid:] - INFO  
[main:FinalRequestProcessor@479] - shutdown of request processor complete
[junit] 2016-05-24 01:05:06,202 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree]
[junit] 2016-05-24 01:05:06,203 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port11222]
[junit] 2016-05-24 01:05:06,203 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-05-24 01:05:06,204 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-05-24 01:05:06,219 [myid:] - INFO  [main:ClientBase@562] - 
fdcount after test is: 50 at start it was 35
[junit] 2016-05-24 01:05:06,219 [myid:] - INFO  [main:ClientBase@564] - 
sleeping for 20 secs
[junit] 2016-05-24 01:05:06,220 [myid:] - INFO  [main:ZKTestCase$1@65] - 
SUCCEEDED testQuota
[junit] 2016-05-24 01:05:06,220 [myid:] - INFO  [main:ZKTestCase$1@60] - 
FINISHED testQuota
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 1.032 sec

junit.run-concurrent:

junit.run:

test-core-java:

call-test-cppunit:

init:

check-cppunit-makefile:

create-cppunit-makefile:

init:

check-cppunit-configure:

create-cppunit-configure:
[mkdir] Created dir: 
/x1/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk8/branch-3.5/build/test/test-cppunit
 [exec] checking for doxygen... no
 [exec] checking for perl... /usr/bin/perl
 [exec] checking for dot... no
 [exec] checking for a BSD-compatible install... /usr/bin/install -c
 [exec] checking whether build environment is sane... 
 [exec] /bin/bash: 
/x1/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk8/branch-3.5/src/c/missing:
 No such file or directory
 [exec] configure: WARNING: `missing' script is too old or missing
 [exec] 
/x1/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk8/branch-3.5/src/c/configure:
 line 4907: syntax error near unexpected token `1.10.2'
 [exec] 
/x1/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk8/branch-3.5/src/c/configure:
 line 4907: `   AM_PATH_CPPUNIT(1.10.2)'
 [exec] yes
 [exec] checking for a thread-safe mkdir -p... /bin/mkdir -p
 [exec] checking for gawk... no
 [exec] checking for mawk... mawk
 [exec] checking whether make sets $(MAKE)... yes

BUILD FAILED
/x1/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk8/branch-3.5/build.xml:1322:
 The following error occurred while executing this line:
/x1/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk8/branch-3.5/build.xml:1281:
 The following error occurred while executing this line:
/x1/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk8/branch-3.5/build.xml:1273:
 exec returned: 2

Total time: 67 minutes 31 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Recording test results
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2366) Reconfiguration of client port causes a socket leak

[Chris Nauroth (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297431#comment-15297431
 ] 

Chris Nauroth commented on ZOOKEEPER-2366:
--

If we pursued something like this, then we'd open up another edge case to worry 
about: a port getting bound on a subset of servers, but not accepted by the 
quorum, so then the bound port is left lingering on that subset of servers.

> Reconfiguration of client port causes a socket leak
> ---
>
> Key: ZOOKEEPER-2366
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2366
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: quorum
>Affects Versions: 3.5.0
>Reporter: Timothy Ward
>Assignee: Flavio Junqueira
>Priority: Blocker
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2366.patch, ZOOKEEPER-2366.patch, 
> zookeeper.patch
>
>
> The NIOServerCnxnFactory reconfigure method can leak server sockets, and 
> hence make ports unusable until the JVM restarts:
> The first line of the method takes a reference to the current 
> ServerSocketChannel and then the next line replaces it. The subsequent 
> interactions with the server socket can fail (for example if the 
> reconfiguration tries to bind to an in-use port). If they fail *before* the  
> call to oldSS.close() then oldSS is *never* closed. This holds that port open 
> forever, and prevents the user from rolling back to the previous port!
> The code from reconfigure is shown below:
>  ServerSocketChannel oldSS = ss;
> try {
>this.ss = ServerSocketChannel.open();
>ss.socket().setReuseAddress(true);
>LOG.info("binding to port " + addr);
>ss.socket().bind(addr);
>ss.configureBlocking(false);
>acceptThread.setReconfiguring();
>oldSS.close();   
>acceptThread.wakeupSelector();
>try {
> acceptThread.join();
>  } catch (InterruptedException e) {
>  LOG.error("Error joining old acceptThread when 
> reconfiguring client port " + e.getMessage());
>  }
>acceptThread = new AcceptThread(ss, addr, selectorThreads);
>acceptThread.start();
> } catch(IOException e) {
>LOG.error("Error reconfiguring client port to " + addr + " " + 
> e.getMessage());
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2366) Reconfiguration of client port causes a socket leak

[Chris Nauroth (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297388#comment-15297388
 ] 

Chris Nauroth commented on ZOOKEEPER-2366:
--

[~shralex], thank you for your comments.  I missed a lot of subtlety in the 
error handling here when I reviewed.

bq. At that point, the operation is committed for all practical purposes 
(quorum already accepted), there is no way to abort it. What can we do without 
redesigning ZK ?

Thinking out loud, so I'm probably missing something, but can we do something 
like bind to the new port during the proposal, but still keep the old port 
listening too?  Then, during commit, we'd transition the accept thread to the 
new already-bound port and close the old one.  The effect I'm trying to achieve 
is moving the bind failure to proposal time, so it won't get ack'd as 
successful, and therefore the quorum won't accept it.

Of course, this is a much heavier change and maybe strays towards "redesigning 
ZK".

bq. so either we log and proceed or we exit the server.

Thinking about the operational model, I could see "exit the server" easily 
escalating to "exit the ensemble."  If the admin accidentally reconfigs to a 
commonly bound port, such as 8080 for an HTTP server, then there is a strong 
possibility that all servers in the ensemble would hit the bind failure and 
exit.

> Reconfiguration of client port causes a socket leak
> ---
>
> Key: ZOOKEEPER-2366
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2366
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: quorum
>Affects Versions: 3.5.0
>Reporter: Timothy Ward
>Assignee: Flavio Junqueira
>Priority: Blocker
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2366.patch, ZOOKEEPER-2366.patch, 
> zookeeper.patch
>
>
> The NIOServerCnxnFactory reconfigure method can leak server sockets, and 
> hence make ports unusable until the JVM restarts:
> The first line of the method takes a reference to the current 
> ServerSocketChannel and then the next line replaces it. The subsequent 
> interactions with the server socket can fail (for example if the 
> reconfiguration tries to bind to an in-use port). If they fail *before* the  
> call to oldSS.close() then oldSS is *never* closed. This holds that port open 
> forever, and prevents the user from rolling back to the previous port!
> The code from reconfigure is shown below:
>  ServerSocketChannel oldSS = ss;
> try {
>this.ss = ServerSocketChannel.open();
>ss.socket().setReuseAddress(true);
>LOG.info("binding to port " + addr);
>ss.socket().bind(addr);
>ss.configureBlocking(false);
>acceptThread.setReconfiguring();
>oldSS.close();   
>acceptThread.wakeupSelector();
>try {
> acceptThread.join();
>  } catch (InterruptedException e) {
>  LOG.error("Error joining old acceptThread when 
> reconfiguring client port " + e.getMessage());
>  }
>acceptThread = new AcceptThread(ss, addr, selectorThreads);
>acceptThread.start();
> } catch(IOException e) {
>LOG.error("Error reconfiguring client port to " + addr + " " + 
> e.getMessage());
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

[Michael Han]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47354/#review134426
---




ivy.xml (line 94)


Nit: Trailing whitespaces could be removed.



ivy.xml (line 115)


Nit: Trailing whitespaces could be removed.



src/java/main/org/apache/zookeeper/server/quorum/Learner.java (line 245)


This will throw SaslException when authentication failed. As a result, we 
should probably update the exception description of connectToLeader method:

@throws SaslException - if Sasl authentication failed.



src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java (line 173)


Should we use LOG.error instead of LOG.warn here? The presence of a 
SaslException indicates an authentication failure, and in existing ZK codebase, 
such auth failures were logged as errors, instead of warnings.



src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java (line 
244)


Should we use LOG.error here?



src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java (line 
326)


Should we use LOG.error here?



src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java (line 375)


Nit: Trailing whitespaces could be removed. Missing full stop.



src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java (line 1418)


Not sure if we really need this log, since the value of enableClientAuth is 
also captured in the following Log.info.



src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java (line 1423)


Maybe move this line at the start of the method, to be consistent with the 
rest of setQuorum methods where logs are after assignment statement.



src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuth.java (line 32)


I am tempted to rename this variable to QUORUM_SERVER_SASL_REQUIRED so it 
is consistent just like other configuration variables where the value of the 
variable and its name literally match. There are also other places in code 
where we could replace 'auth' with 'sasl', for example: 
quorumServerAuthRequired -> quorumServerSaslRequired

Not sure what others think about this.



src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuth.java (line 49)


I am not sure if I follow this comment - is this comment completed?



src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuth.java (line 70)


Should we return ERROR here for unknown status? The follow up question is 
under what use cases would we get unknown status in a QuorumAuthPacket - if 
there is never such case then probably assert(false) is better here.



src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthClient.java 
(line 34)


Similar to the comment on QuorumAuthServer::authenticate interface, we 
could provide some clarifications on the return value and the exception throwed 
for a user of this interface. Also the QuorumAuthClient::authenticate will 
never return false under current implementation.



src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthServer.java 
(line 39)


The current implementation of this method in SaslQuorumAuthServer will 
never return false. Also, there is one case that this will return true even if 
authentication fail: that is, when sasl is not required. So it appears to me 
that first, the semantic of 'authentication success' is not very clearly 
defined, and a clarification might be worth it; and secondly, it might be 
better to clarify what the caller should use to decide an authentication is a 
success or not. Since NullQuorumAuthServer will return false, a caller of the 
API has to check both the return code and catch the SaslException to decide an 
authentication is failed.

So I am thinking updating the documentation with something like:

@return true in these cases: 1. after successfully authenticating the 
quorum client when sasl is required; or
2. when sasl is not required.
Will return false if authentication failed.

@throws SaslException When authentication failed. Caller should catch this 
exception which declares failing of an authentication.

Alte

[jira] [Updated] (ZOOKEEPER-2384) Support atomic increment / decrement of znode value

[Ted Yu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated ZOOKEEPER-2384:
--
Description: 
Use case is to store reference count (integer type) in znode.

It is desirable to provide support for atomic increment / decrement of the 
znode value.

Suggestion from Flavio:
{quote}
you can read the znode, keep the version of the znode, update the value, write 
back conditionally. The condition for the setData operation to succeed is that 
the version is the same that it read
{quote}
While the above is feasible, developer has to implement retry logic 
him/herself. It is not easy to combine increment / decrement with other 
operations using multi.

  was:
Use case is to store reference count (integer type) in znode.

It is desirable to provide support for atomic increment / decrement of the 
znode value.

Suggestion from Flavio:

you can read the znode, keep the version of the znode, update the value, write 
back conditionally. The condition for the setData operation to succeed is that 
the version is the same that it read

While the above is feasible, developer has to implement retry logic 
him/herself. It is not easy to combine increment / decrement with other 
operations using multi.


> Support atomic increment / decrement of znode value
> ---
>
> Key: ZOOKEEPER-2384
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2384
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Ted Yu
>  Labels: atomic
>
> Use case is to store reference count (integer type) in znode.
> It is desirable to provide support for atomic increment / decrement of the 
> znode value.
> Suggestion from Flavio:
> {quote}
> you can read the znode, keep the version of the znode, update the value, 
> write back conditionally. The condition for the setData operation to succeed 
> is that the version is the same that it read
> {quote}
> While the above is feasible, developer has to implement retry logic 
> him/herself. It is not easy to combine increment / decrement with other 
> operations using multi.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk-solaris - Build # 1169 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1169/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 343845 lines...]
[junit] 2016-05-23 23:19:56,145 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-05-23 23:19:56,146 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-05-23 23:19:56,146 [myid:] - INFO  [main:ClientBase@355] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-05-23 23:19:56,147 [myid:] - INFO  [main:ZooKeeperServer@858] 
- minSessionTimeout set to 6000
[junit] 2016-05-23 23:19:56,147 [myid:] - INFO  [main:ZooKeeperServer@867] 
- maxSessionTimeout set to 6
[junit] 2016-05-23 23:19:56,147 [myid:] - INFO  [main:ZooKeeperServer@156] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test3327735661255203695.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test3327735661255203695.junit.dir/version-2
[junit] 2016-05-23 23:19:56,148 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test3327735661255203695.junit.dir/version-2/snapshot.b
[junit] 2016-05-23 23:19:56,150 [myid:] - INFO  [main:FileTxnSnapLog@298] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test3327735661255203695.junit.dir/version-2/snapshot.b
[junit] 2016-05-23 23:19:56,151 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-05-23 23:19:56,152 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:43564
[junit] 2016-05-23 23:19:56,152 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:43564
[junit] 2016-05-23 23:19:56,153 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-05-23 23:19:56,153 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:43564 (no session established for client)
[junit] 2016-05-23 23:19:56,153 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-05-23 23:19:56,155 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-05-23 23:19:56,155 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-05-23 23:19:56,155 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-05-23 23:19:56,155 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-05-23 23:19:56,155 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17716
[junit] 2016-05-23 23:19:56,156 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-05-23 23:19:56,156 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-05-23 23:19:56,156 [myid:] - INFO  [main:ClientBase@537] - 
tearDown starting
[junit] 2016-05-23 23:19:56,232 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x1215ce81a21 closed
[junit] 2016-05-23 23:19:56,232 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1215ce81a21
[junit] 2016-05-23 23:19:56,232 [myid:] - INFO  [main:ClientBase@507] - 
STOPPING server
[junit] 2016-05-23 23:19:56,232 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-05-23 23:19:56,232 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-05-23 23:19:56,233 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-05-23 23:19:56,233 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-05-23 23:19:56,233 [myid:] - INFO  [main:ZooKeeperServer@498] 
- shut

[jira] [Commented] (ZOOKEEPER-2366) Reconfiguration of client port causes a socket leak

[Alexander Shraer (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297325#comment-15297325
 ] 

Alexander Shraer commented on ZOOKEEPER-2366:
-

Yeah I also say this in the manual, so I must have checked it "When the client 
port of a server is modified, it does not drop existing client connections. New 
connections to the server will have to use the new client port."

> Reconfiguration of client port causes a socket leak
> ---
>
> Key: ZOOKEEPER-2366
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2366
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: quorum
>Affects Versions: 3.5.0
>Reporter: Timothy Ward
>Assignee: Flavio Junqueira
>Priority: Blocker
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2366.patch, ZOOKEEPER-2366.patch, 
> zookeeper.patch
>
>
> The NIOServerCnxnFactory reconfigure method can leak server sockets, and 
> hence make ports unusable until the JVM restarts:
> The first line of the method takes a reference to the current 
> ServerSocketChannel and then the next line replaces it. The subsequent 
> interactions with the server socket can fail (for example if the 
> reconfiguration tries to bind to an in-use port). If they fail *before* the  
> call to oldSS.close() then oldSS is *never* closed. This holds that port open 
> forever, and prevents the user from rolling back to the previous port!
> The code from reconfigure is shown below:
>  ServerSocketChannel oldSS = ss;
> try {
>this.ss = ServerSocketChannel.open();
>ss.socket().setReuseAddress(true);
>LOG.info("binding to port " + addr);
>ss.socket().bind(addr);
>ss.configureBlocking(false);
>acceptThread.setReconfiguring();
>oldSS.close();   
>acceptThread.wakeupSelector();
>try {
> acceptThread.join();
>  } catch (InterruptedException e) {
>  LOG.error("Error joining old acceptThread when 
> reconfiguring client port " + e.getMessage());
>  }
>acceptThread = new AcceptThread(ss, addr, selectorThreads);
>acceptThread.start();
> } catch(IOException e) {
>LOG.error("Error reconfiguring client port to " + addr + " " + 
> e.getMessage());
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2366) Reconfiguration of client port causes a socket leak

[Alexander Shraer (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297318#comment-15297318
 ] 

Alexander Shraer commented on ZOOKEEPER-2366:
-

I don't think we're loosing the connected clients since the port is only used 
to accept connections, but then another random port is used to actually 
communicate. I'm not 100% sure, but if I remember correctly this is how it 
works. 

> Reconfiguration of client port causes a socket leak
> ---
>
> Key: ZOOKEEPER-2366
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2366
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: quorum
>Affects Versions: 3.5.0
>Reporter: Timothy Ward
>Assignee: Flavio Junqueira
>Priority: Blocker
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2366.patch, ZOOKEEPER-2366.patch, 
> zookeeper.patch
>
>
> The NIOServerCnxnFactory reconfigure method can leak server sockets, and 
> hence make ports unusable until the JVM restarts:
> The first line of the method takes a reference to the current 
> ServerSocketChannel and then the next line replaces it. The subsequent 
> interactions with the server socket can fail (for example if the 
> reconfiguration tries to bind to an in-use port). If they fail *before* the  
> call to oldSS.close() then oldSS is *never* closed. This holds that port open 
> forever, and prevents the user from rolling back to the previous port!
> The code from reconfigure is shown below:
>  ServerSocketChannel oldSS = ss;
> try {
>this.ss = ServerSocketChannel.open();
>ss.socket().setReuseAddress(true);
>LOG.info("binding to port " + addr);
>ss.socket().bind(addr);
>ss.configureBlocking(false);
>acceptThread.setReconfiguring();
>oldSS.close();   
>acceptThread.wakeupSelector();
>try {
> acceptThread.join();
>  } catch (InterruptedException e) {
>  LOG.error("Error joining old acceptThread when 
> reconfiguring client port " + e.getMessage());
>  }
>acceptThread = new AcceptThread(ss, addr, selectorThreads);
>acceptThread.start();
> } catch(IOException e) {
>LOG.error("Error reconfiguring client port to " + addr + " " + 
> e.getMessage());
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk-WinVS2008 - Build # 2032 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/2032/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 53 lines...]

clean:
   [delete] Deleting directory 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\build

init:
[mkdir] Created dir: 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\build\classes
[mkdir] Created dir: 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\build\lib
[mkdir] Created dir: 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\build\package\lib
[mkdir] Created dir: 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\build\test\lib

ivy-download:

ivy-taskdef:

ivy-init:

ivy-retrieve:
[ivy:retrieve] :: Apache Ivy 2.4.0 - 20141213170938 :: 
http://ant.apache.org/ivy/ ::
[ivy:retrieve] :: loading settings :: file = 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\ivysettings.xml
[ivy:retrieve] :: resolving dependencies :: 
org.apache.zookeeper#zookeeper;3.6.0-SNAPSHOT
[ivy:retrieve]  confs: [default]
[ivy:retrieve]  found jline#jline;2.11 in maven2
[ivy:retrieve]  found org.mortbay.jetty#jetty;6.1.26 in maven2
[ivy:retrieve]  found org.mortbay.jetty#jetty-util;6.1.26 in maven2
[ivy:retrieve]  found org.mortbay.jetty#servlet-api;2.5-20081211 in maven2
[ivy:retrieve]  found org.codehaus.jackson#jackson-mapper-asl;1.9.11 in maven2
[ivy:retrieve]  found org.codehaus.jackson#jackson-core-asl;1.9.11 in maven2
[ivy:retrieve]  found org.slf4j#slf4j-api;1.7.5 in maven2
[ivy:retrieve]  found org.slf4j#slf4j-log4j12;1.7.5 in maven2
[ivy:retrieve]  found commons-cli#commons-cli;1.2 in maven2
[ivy:retrieve]  found log4j#log4j;1.2.17 in maven2
[ivy:retrieve]  found io.netty#netty;3.10.5.Final in maven2
[ivy:retrieve]  found net.java.dev.javacc#javacc;5.0 in maven2
[ivy:retrieve] :: resolution report :: resolve 767ms :: artifacts dl 36ms
-
|  |modules||   artifacts   |
|   conf   | number| search|dwnlded|evicted|| number|dwnlded|
-
|  default |   12  |   0   |   0   |   0   ||   12  |   0   |
-
[ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper
[ivy:retrieve]  confs: [default]
[ivy:retrieve]  12 artifacts copied, 0 already retrieved (4167kB/567ms)

generate_jute_parser:
[mkdir] Created dir: 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\build\jute_compiler\org\apache\jute\compiler\generated
[ivy:artifactproperty] DEPRECATED: 'ivy.conf.file' is deprecated, use 
'ivy.settings.file' instead
[ivy:artifactproperty] :: loading settings :: file = 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\ivysettings.xml
 [move] Moving 1 file to 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\build\lib
   [javacc] Error occurred during initialization of VM
   [javacc] Could not reserve enough space for code cache

BUILD FAILED
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\build.xml:266: 
f:\hudson\tools\java\latest-1.7-64\jre\bin\java.exe failed with return code 1

Total time: 4 seconds
Build step 'Invoke Ant' marked build as failure
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2402) Document client side properties

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297310#comment-15297310
 ] 

Hudson commented on ZOOKEEPER-2402:
---

SUCCESS: Integrated in ZooKeeper-trunk #2934 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/2934/])
ZOOKEEPER-2402: Document client side properties (Arshad Mohammad via fpj) (fpj: 
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1745279])
* trunk/CHANGES.txt
* trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml
* trunk/src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml


> Document client side properties
> ---
>
> Key: ZOOKEEPER-2402
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2402
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: documentation
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2402-01.patch, ZOOKEEPER-2402-02.patch, 
> ZOOKEEPER-2402-03.patch, ZOOKEEPER-2402-04.patch
>
>
> There are many ZooKeeper java client properties which are not documented. 
> Bellow client properties are not documented in Admin Guide
> # zookeeper.sasl.client.username
> # zookeeper.sasl.clientconfig
> # zookeeper.sasl.client
> # zookeeper.server.realm
> # zookeeper.disableAutoWatchReset
> Bellow two client properties are documented in Admin Guide but these are 
> documented in server configuration section
> # zookeeper.client.secure
> # zookeeper.clientCnxnSocket



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2366) Reconfiguration of client port causes a socket leak

[Flavio Junqueira (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297305#comment-15297305
 ] 

Flavio Junqueira commented on ZOOKEEPER-2366:
-

Let's see if we can agree on the behavior. Without reconfiguration, if there is 
an IOException while starting the cnxn factory, then the server will exit. 
You're saying that upon a reconfiguration of the client port, the situation is 
different because the server might already have a number of clients connected 
to it. But, if we are to close the old port regardless of whether binding to 
the new port succeeded, then we'll be losing those clients connections in any 
case. I get the point of the server being re-elected and failing every time, we 
do want to avoid that scenario, so either we log and proceed or we exit the 
server. 



> Reconfiguration of client port causes a socket leak
> ---
>
> Key: ZOOKEEPER-2366
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2366
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: quorum
>Affects Versions: 3.5.0
>Reporter: Timothy Ward
>Assignee: Flavio Junqueira
>Priority: Blocker
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2366.patch, ZOOKEEPER-2366.patch, 
> zookeeper.patch
>
>
> The NIOServerCnxnFactory reconfigure method can leak server sockets, and 
> hence make ports unusable until the JVM restarts:
> The first line of the method takes a reference to the current 
> ServerSocketChannel and then the next line replaces it. The subsequent 
> interactions with the server socket can fail (for example if the 
> reconfiguration tries to bind to an in-use port). If they fail *before* the  
> call to oldSS.close() then oldSS is *never* closed. This holds that port open 
> forever, and prevents the user from rolling back to the previous port!
> The code from reconfigure is shown below:
>  ServerSocketChannel oldSS = ss;
> try {
>this.ss = ServerSocketChannel.open();
>ss.socket().setReuseAddress(true);
>LOG.info("binding to port " + addr);
>ss.socket().bind(addr);
>ss.configureBlocking(false);
>acceptThread.setReconfiguring();
>oldSS.close();   
>acceptThread.wakeupSelector();
>try {
> acceptThread.join();
>  } catch (InterruptedException e) {
>  LOG.error("Error joining old acceptThread when 
> reconfiguring client port " + e.getMessage());
>  }
>acceptThread = new AcceptThread(ss, addr, selectorThreads);
>acceptThread.start();
> } catch(IOException e) {
>LOG.error("Error reconfiguring client port to " + addr + " " + 
> e.getMessage());
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk-WinVS2008 - Build # 2031 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/2031/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 31 lines...]

clean:
 [echo] contrib: zkpython

clean:
 [echo] contrib: zktreeutil

clean:
 [echo] contrib: ZooInspector

clean-recipes:

clean:

clean:
 [echo] recipes: election

clean:
 [echo] recipes: lock

clean:
 [echo] recipes: queue

clean:
   [delete] Deleting directory 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\build
   [delete] Deleting directory 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\java\generated
   [delete] Deleting directory 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\generated

init:
[mkdir] Created dir: 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\build\classes
[mkdir] Created dir: 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\build\lib
[mkdir] Created dir: 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\build\package\lib
[mkdir] Created dir: 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\build\test\lib

ivy-download:

ivy-taskdef:

ivy-init:

ivy-retrieve:
[ivy:retrieve] :: Apache Ivy 2.4.0 - 20141213170938 :: 
http://ant.apache.org/ivy/ ::
[ivy:retrieve] :: loading settings :: file = 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\ivysettings.xml
[ivy:retrieve] :: resolving dependencies :: 
org.apache.zookeeper#zookeeper;3.6.0-SNAPSHOT
[ivy:retrieve]  confs: [default]
[ivy:retrieve]  found jline#jline;2.11 in maven2
[ivy:retrieve]  found org.mortbay.jetty#jetty;6.1.26 in maven2
[ivy:retrieve]  found org.mortbay.jetty#jetty-util;6.1.26 in maven2

[error occurred during error reporting (null), id 0xc005]

#
# There is insufficient memory for the Java Runtime Environment to continue.
# Native memory allocation (malloc) failed to allocate 418896 bytes for 
Chunk::new
# An error report file with more information is saved as:
# 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\hs_err_pid388860.log
Build step 'Invoke Ant' marked build as failure
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-1467) Server principal on client side is derived using hostname.

[Eugene Koontz (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297160#comment-15297160
 ] 

Eugene Koontz commented on ZOOKEEPER-1467:
--

Hi Arshad,
Sure, thanks for the reminder. Should be able to submit tomorrow.
-Eugene

> Server principal on client side is derived using hostname.
> --
>
> Key: ZOOKEEPER-1467
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1467
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.3, 3.4.4, 3.5.0, 4.0.0
>Reporter: Laxman
>Assignee: Eugene Koontz
>Priority: Critical
>  Labels: Security, client, kerberos, sasl
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-1467.patch, ZOOKEEPER-1467.patch
>
>
> Server principal on client side is derived using hostname.
> org.apache.zookeeper.ClientCnxn.SendThread.startConnect()
> {code}
>try {
> zooKeeperSaslClient = new 
> ZooKeeperSaslClient("zookeeper/"+addr.getHostName());
> }
> {code}
> This may have problems when admin wanted some customized principals like 
> zookeeper/cluste...@hadoop.com where clusterid is the cluster identifier but 
> not the host name.
> IMO, server principal also should be configurable as hadoop is doing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2402) Document client side properties

[Flavio Junqueira (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Junqueira updated ZOOKEEPER-2402:

Issue Type: Improvement  (was: Bug)

> Document client side properties
> ---
>
> Key: ZOOKEEPER-2402
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2402
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: documentation
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2402-01.patch, ZOOKEEPER-2402-02.patch, 
> ZOOKEEPER-2402-03.patch, ZOOKEEPER-2402-04.patch
>
>
> There are many ZooKeeper java client properties which are not documented. 
> Bellow client properties are not documented in Admin Guide
> # zookeeper.sasl.client.username
> # zookeeper.sasl.clientconfig
> # zookeeper.sasl.client
> # zookeeper.server.realm
> # zookeeper.disableAutoWatchReset
> Bellow two client properties are documented in Admin Guide but these are 
> documented in server configuration section
> # zookeeper.client.secure
> # zookeeper.clientCnxnSocket



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

[Michael Han]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47354/#review133626
---




src/java/main/org/apache/zookeeper/server/quorum/Learner.java 


I think the reason ZOOKEEPER-1506 is reverted as part of this patch is 
because the working branch which was used to generate the patch was out of sync 
with the target branch (branch-3.4). Rebase working branch with branch-3.4 
first and then generate the patch after applying updates would hopefully fix it.


This is fixed revision 3.

- Michael Han


On May 20, 2016, 3:10 a.m., Rakesh R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47354/
> ---
> 
> (Updated May 20, 2016, 3:10 a.m.)
> 
> 
> Review request for zookeeper, fpj, Ivan Kelly, Patrick Hunt, and Raul 
> Gutierrez Segales.
> 
> 
> Bugs: ZOOKEEPER-1045
> https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> 
> 
> Repository: zookeeper-git
> 
> 
> Description
> ---
> 
> Quorum mutual authentication using SASL mechanism - Digest/Kerberos
> 
> 
> Diffs
> -
> 
>   build.xml ab254b2 
>   ivy.xml 95b0e5a 
>   src/java/main/org/apache/zookeeper/Login.java a214c9c 
>   src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 21ef0fa 
>   src/java/main/org/apache/zookeeper/server/ZooKeeperSaslServer.java 71870ce 
>   
> src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java 
> 2fbd6ed 
>   src/java/main/org/apache/zookeeper/server/quorum/Leader.java 40c6748 
>   src/java/main/org/apache/zookeeper/server/quorum/Learner.java c73a8ee 
>   src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 
> 8a748c7 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 
> 20e5f16 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 2f0f21b 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 
> 8ae820d 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 
> e9c8007 
>   
> src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthClient.java
>  PRE-CREATION 
>   
> src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthServer.java
>  PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuth.java 
> PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthClient.java 
> PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthServer.java 
> PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/README.md 
> PRE-CREATION 
>   
> src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthClient.java
>  PRE-CREATION 
>   
> src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthServer.java
>  PRE-CREATION 
>   src/java/main/org/apache/zookeeper/util/SecurityUtils.java PRE-CREATION 
>   src/java/test/data/kerberos/minikdc-krb5.conf PRE-CREATION 
>   src/java/test/data/kerberos/minikdc.ldiff PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/CnxManagerTest.java 
> 831d3ed 
>   
> src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java
>  c1259d1 
>   src/java/test/org/apache/zookeeper/server/quorum/FLECompatibilityTest.java 
> 72e4fc9 
>   src/java/test/org/apache/zookeeper/server/quorum/FLEDontCareTest.java 
> a4c0cb0 
>   src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java 
> 39a53ca 
>   src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java 2ae57ce 
>   src/java/test/org/apache/zookeeper/server/quorum/QuorumCnxManagerTest.java 
> PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 
> ef552db 
>   src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java ab8ce42 
>   
> src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosSecurityTestcase.java
>  PRE-CREATION 
>   
> src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosTestUtils.java 
> PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdc.java 
> PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java 
> PRE-CREATION 
>   
> src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthTestBase.java 
> PRE-CREATION 
>   
> src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthUpgradeTest.java
>  PRE-CREATION 
>   
> src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumDigestAuthTest.java
>  PRE-CREATION 
>   
> src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosAuthTest.java
>  PRE-CREATION 
>   src/java/test/org/apache/zookeeper/test/FLEPredicateTest.java 8088505 
>   src/zookeeper.jute 6521e54 
> 
>

ZooKeeper-trunk-openjdk7 - Build # 1032 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1032/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 1520 lines...]
[ivy:retrieve] .. (0kB)
[ivy:retrieve]  [SUCCESSFUL ] commons-cli#commons-cli;1.2!commons-cli.jar (58ms)
[ivy:retrieve] downloading 
http://repo1.maven.org/maven2/log4j/log4j/1.2.17/log4j-1.2.17.jar ...
[ivy:retrieve] . (478kB)
[ivy:retrieve] .. (0kB)
[ivy:retrieve]  [SUCCESSFUL ] log4j#log4j;1.2.17!log4j.jar(bundle) (64ms)
[ivy:retrieve] downloading 
http://repo1.maven.org/maven2/io/netty/netty/3.10.5.Final/netty-3.10.5.Final.jar
 ...
[ivy:retrieve] .. (1299kB)
[ivy:retrieve] .. (0kB)
[ivy:retrieve]  [SUCCESSFUL ] io.netty#netty;3.10.5.Final!netty.jar (73ms)
[ivy:retrieve] downloading 
http://repo1.maven.org/maven2/net/java/dev/javacc/javacc/5.0/javacc-5.0.jar ...
[ivy:retrieve] .. (291kB)
[ivy:retrieve] .. (0kB)
[ivy:retrieve]  [SUCCESSFUL ] net.java.dev.javacc#javacc;5.0!javacc.jar (61ms)
[ivy:retrieve] :: resolution report :: resolve 5514ms :: artifacts dl 839ms
-
|  |modules||   artifacts   |
|   conf   | number| search|dwnlded|evicted|| number|dwnlded|
-
|  default |   12  |   12  |   12  |   0   ||   12  |   12  |
-
[ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper
[ivy:retrieve]  confs: [default]
[ivy:retrieve]  12 artifacts copied, 0 already retrieved (4167kB/29ms)

clover.setup:

clover.info:

clover:

generate_jute_parser:
[mkdir] Created dir: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/trunk/build/jute_compiler/org/apache/jute/compiler/generated
[ivy:artifactproperty] DEPRECATED: 'ivy.conf.file' is deprecated, use 
'ivy.settings.file' instead
[ivy:artifactproperty] :: loading settings :: file = 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/trunk/ivysettings.xml
 [move] Moving 1 file to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/trunk/build/lib
   [javacc] Java Compiler Compiler Version 5.0 (Parser Generator)
   [javacc] (type "javacc" with no arguments for help)
   [javacc] Reading from file 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/trunk/src/java/main/org/apache/jute/compiler/generated/rcc.jj
 . . .
   [javacc] File "TokenMgrError.java" does not exist.  Will create one.
   [javacc] File "ParseException.java" does not exist.  Will create one.
   [javacc] File "Token.java" does not exist.  Will create one.
   [javacc] File "SimpleCharStream.java" does not exist.  Will create one.
   [javacc] Parser generated successfully.

jute:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/trunk/build.xml:272:
 Unable to find a javac compiler;
com.sun.tools.javac.Main is not on the classpath.
Perhaps JAVA_HOME does not point to the JDK.
It is currently set to "/usr/lib/jvm/java-7-openjdk-amd64/jre"

Total time: 8 seconds
Build step 'Invoke Ant' marked build as failure
Recording test results
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2402) Document client side properties

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15296973#comment-15296973
 ] 

Hadoop QA commented on ZOOKEEPER-2402:
--

+1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12805723/ZOOKEEPER-2402-04.patch
  against trunk revision 1743978.

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3173//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3173//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3173//console

This message is automatically generated.

> Document client side properties
> ---
>
> Key: ZOOKEEPER-2402
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2402
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: documentation
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2402-01.patch, ZOOKEEPER-2402-02.patch, 
> ZOOKEEPER-2402-03.patch, ZOOKEEPER-2402-04.patch
>
>
> There are many ZooKeeper java client properties which are not documented. 
> Bellow client properties are not documented in Admin Guide
> # zookeeper.sasl.client.username
> # zookeeper.sasl.clientconfig
> # zookeeper.sasl.client
> # zookeeper.server.realm
> # zookeeper.disableAutoWatchReset
> Bellow two client properties are documented in Admin Guide but these are 
> documented in server configuration section
> # zookeeper.client.secure
> # zookeeper.clientCnxnSocket



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Success: ZOOKEEPER-2402 PreCommit Build #3173

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2402
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3173/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 377862 lines...]
 [exec]   
http://issues.apache.org/jira/secure/attachment/12805723/ZOOKEEPER-2402-04.patch
 [exec]   against trunk revision 1743978.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +0 tests included.  The patch appears to be a documentation 
patch that doesn't require tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3173//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3173//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3173//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] b4e89150fde0d90abe87a9e2bb064ec06218a9a2 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 14 minutes 44 seconds
Archiving artifacts
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Recording test results
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
[description-setter] Description set: ZOOKEEPER-2402
Email was triggered for: Success
Sending email for trigger: Success
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Updated] (ZOOKEEPER-2402) Document client side properties

[Arshad Mohammad (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arshad Mohammad updated ZOOKEEPER-2402:
---
Attachment: ZOOKEEPER-2402-04.patch

Submitting new patch as previous patch was not getting applied. Content is same 
as previous patch.

> Document client side properties
> ---
>
> Key: ZOOKEEPER-2402
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2402
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: documentation
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2402-01.patch, ZOOKEEPER-2402-02.patch, 
> ZOOKEEPER-2402-03.patch, ZOOKEEPER-2402-04.patch
>
>
> There are many ZooKeeper java client properties which are not documented. 
> Bellow client properties are not documented in Admin Guide
> # zookeeper.sasl.client.username
> # zookeeper.sasl.clientconfig
> # zookeeper.sasl.client
> # zookeeper.server.realm
> # zookeeper.disableAutoWatchReset
> Bellow two client properties are documented in Admin Guide but these are 
> documented in server configuration section
> # zookeeper.client.secure
> # zookeeper.clientCnxnSocket



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2402) Document client side properties

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15296699#comment-15296699
 ] 

Hadoop QA commented on ZOOKEEPER-2402:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12805491/ZOOKEEPER-2402-03.patch
  against trunk revision 1743978.

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3172//console

This message is automatically generated.

> Document client side properties
> ---
>
> Key: ZOOKEEPER-2402
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2402
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: documentation
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2402-01.patch, ZOOKEEPER-2402-02.patch, 
> ZOOKEEPER-2402-03.patch
>
>
> There are many ZooKeeper java client properties which are not documented. 
> Bellow client properties are not documented in Admin Guide
> # zookeeper.sasl.client.username
> # zookeeper.sasl.clientconfig
> # zookeeper.sasl.client
> # zookeeper.server.realm
> # zookeeper.disableAutoWatchReset
> Bellow two client properties are documented in Admin Guide but these are 
> documented in server configuration section
> # zookeeper.client.secure
> # zookeeper.clientCnxnSocket



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-2402 PreCommit Build #3172

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2402
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3172/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 94 lines...]
 [exec] patching file 
src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml
 [exec] patching file 
src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
 [exec] PATCH APPLICATION FAILED
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12805491/ZOOKEEPER-2402-03.patch
 [exec]   against trunk revision 1743978.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +0 tests included.  The patch appears to be a documentation 
patch that doesn't require tests.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3172//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 9bfb5241db5d70faf402336c65490d4dfaaed116 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1605:
 exec returned: 1

Total time: 45 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Recording test results
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
[description-setter] Description set: ZOOKEEPER-2402
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

ZooKeeper_branch35_solaris - Build # 108 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_solaris/108/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 346023 lines...]
[junit] 2016-05-23 17:04:53,281 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-05-23 17:04:53,282 [myid:] - INFO  [main:ClientBase@460] - 
STARTING server
[junit] 2016-05-23 17:04:53,282 [myid:] - INFO  [main:ClientBase@380] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-05-23 17:04:53,282 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-05-23 17:04:53,283 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-05-23 17:04:53,284 [myid:] - INFO  [main:ClientBase@355] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-05-23 17:04:53,284 [myid:] - INFO  [main:ZooKeeperServer@858] 
- minSessionTimeout set to 6000
[junit] 2016-05-23 17:04:53,285 [myid:] - INFO  [main:ZooKeeperServer@867] 
- maxSessionTimeout set to 6
[junit] 2016-05-23 17:04:53,285 [myid:] - INFO  [main:ZooKeeperServer@156] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test3154708889001182018.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test3154708889001182018.junit.dir/version-2
[junit] 2016-05-23 17:04:53,285 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test3154708889001182018.junit.dir/version-2/snapshot.b
[junit] 2016-05-23 17:04:53,287 [myid:] - INFO  [main:FileTxnSnapLog@298] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test3154708889001182018.junit.dir/version-2/snapshot.b
[junit] 2016-05-23 17:04:53,289 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-05-23 17:04:53,289 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:63394
[junit] 2016-05-23 17:04:53,290 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:63394
[junit] 2016-05-23 17:04:53,290 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-05-23 17:04:53,290 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:63394 (no session established for client)
[junit] 2016-05-23 17:04:53,291 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-05-23 17:04:53,292 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-05-23 17:04:53,292 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-05-23 17:04:53,292 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-05-23 17:04:53,292 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-05-23 17:04:53,293 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17737
[junit] 2016-05-23 17:04:53,293 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-05-23 17:04:53,293 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-05-23 17:04:53,293 [myid:] - INFO  [main:ClientBase@537] - 
tearDown starting
[junit] 2016-05-23 17:04:53,372 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x1215b90bc61 closed
[junit] 2016-05-23 17:04:53,372 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1215b90bc61
[junit] 2016-05-23 17:04:53,372 [myid:] - INFO  [main:ClientBase@507] - 
STOPPING server
[junit] 2016-05-23 17:04:53,373 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-05-23 17:04:53,373 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-05-23 17:04:53,373 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThrea

[jira] [Updated] (ZOOKEEPER-2433) ZooKeeperSaslServer: allow user principals in subject

[Andy B (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy B updated ZOOKEEPER-2433:
--
Description: 
The createSaslServer function in ZooKeeperSaslServer handles only service 
principal names (eg. service_name/machine_name@realm), though sometimes 
user/service principal names without host name (eg. service_name@realm) are 
used for authentication.



  was:
The createSaslServer function in ZooKeeperSaslServer handles only service 
principal names (eg. service_name/machine_name@realm), though sometimes user 
principal names like service_name@realm are used for authentication.




> ZooKeeperSaslServer: allow user principals in subject
> -
>
> Key: ZOOKEEPER-2433
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2433
> Project: ZooKeeper
>  Issue Type: Wish
>  Components: security
>Affects Versions: 3.5.1
>Reporter: Andy B
>  Labels: easyfix
> Fix For: 3.5.1
>
> Attachments: ZOOKEEPER-2433.patch
>
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> The createSaslServer function in ZooKeeperSaslServer handles only service 
> principal names (eg. service_name/machine_name@realm), though sometimes 
> user/service principal names without host name (eg. service_name@realm) are 
> used for authentication.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2433) ZooKeeperSaslServer: allow user principals in subject

[Andy B (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy B updated ZOOKEEPER-2433:
--
Description: 
The createSaslServer function in ZooKeeperSaslServer handles only service 
principal names (eg. service_name/machine_name@realm), though sometimes user 
principal names like service_name@realm are used for authentication.



  was:
The createSaslServer function in ZooKeeperSaslServer handles only service 
principal names (eg. service_name/machine_name@realm), though sometimes user 
principal names like servicen...@example.com are used for authentication.




> ZooKeeperSaslServer: allow user principals in subject
> -
>
> Key: ZOOKEEPER-2433
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2433
> Project: ZooKeeper
>  Issue Type: Wish
>  Components: security
>Affects Versions: 3.5.1
>Reporter: Andy B
>  Labels: easyfix
> Fix For: 3.5.1
>
> Attachments: ZOOKEEPER-2433.patch
>
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> The createSaslServer function in ZooKeeperSaslServer handles only service 
> principal names (eg. service_name/machine_name@realm), though sometimes user 
> principal names like service_name@realm are used for authentication.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-2433 PreCommit Build #3171

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2433
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3171/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 379824 lines...]
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3171//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3171//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3171//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] f5da8bf803b1a83837d8f801b575c8f488848557 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1605:
 exec returned: 1

Total time: 13 minutes 57 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Recording test results
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
[description-setter] Description set: ZOOKEEPER-2433
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2433) ZooKeeperSaslServer: allow user principals in subject

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15296465#comment-15296465
 ] 

Hadoop QA commented on ZOOKEEPER-2433:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12805640/ZOOKEEPER-2433.patch
  against trunk revision 1743978.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3171//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3171//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3171//console

This message is automatically generated.

> ZooKeeperSaslServer: allow user principals in subject
> -
>
> Key: ZOOKEEPER-2433
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2433
> Project: ZooKeeper
>  Issue Type: Wish
>  Components: security
>Affects Versions: 3.5.1
>Reporter: Andy B
>  Labels: easyfix
> Fix For: 3.5.1
>
> Attachments: ZOOKEEPER-2433.patch
>
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> The createSaslServer function in ZooKeeperSaslServer handles only service 
> principal names (eg. service_name/machine_name@realm), though sometimes user 
> principal names like servicen...@example.com are used for authentication.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2433) ZooKeeperSaslServer: allow user principals in subject

[Andy B (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy B updated ZOOKEEPER-2433:
--
Attachment: ZOOKEEPER-2433.patch

> ZooKeeperSaslServer: allow user principals in subject
> -
>
> Key: ZOOKEEPER-2433
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2433
> Project: ZooKeeper
>  Issue Type: Wish
>  Components: security
>Affects Versions: 3.5.1
>Reporter: Andy B
>  Labels: easyfix
> Fix For: 3.5.1
>
> Attachments: ZOOKEEPER-2433.patch
>
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> The createSaslServer function in ZooKeeperSaslServer handles only service 
> principal names (eg. service_name/machine_name@realm), though sometimes user 
> principal names like servicen...@example.com are used for authentication.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2433) ZooKeeperSaslServer: allow user principals in subject

[Andy B (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy B updated ZOOKEEPER-2433:
--
Attachment: (was: ZOOKEEPER-2433.patch)

> ZooKeeperSaslServer: allow user principals in subject
> -
>
> Key: ZOOKEEPER-2433
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2433
> Project: ZooKeeper
>  Issue Type: Wish
>  Components: security
>Affects Versions: 3.5.1
>Reporter: Andy B
>  Labels: easyfix
> Fix For: 3.5.1
>
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> The createSaslServer function in ZooKeeperSaslServer handles only service 
> principal names (eg. service_name/machine_name@realm), though sometimes user 
> principal names like servicen...@example.com are used for authentication.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk-jdk8 - Build # 608 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/608/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 584439 lines...]
[junit] 2016-05-23 11:53:11,839 [myid:] - INFO  [main:QuorumUtil@243] - 
127.0.0.1:22129 is no longer accepting client connections
[junit] 2016-05-23 11:53:11,839 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 22132
[junit] 2016-05-23 11:53:11,839 [myid:] - INFO  [main:QuorumUtil@243] - 
127.0.0.1:22132 is no longer accepting client connections
[junit] 2016-05-23 11:53:11,839 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 22135
[junit] 2016-05-23 11:53:11,840 [myid:] - INFO  [main:QuorumUtil@243] - 
127.0.0.1:22135 is no longer accepting client connections
[junit] 2016-05-23 11:53:11,841 [myid:] - INFO  [main:ZKTestCase$1@65] - 
SUCCEEDED testRemoveOneAsynchronous
[junit] 2016-05-23 11:53:11,842 [myid:] - INFO  [main:ZKTestCase$1@60] - 
FINISHED testRemoveOneAsynchronous
[junit] 2016-05-23 11:53:11,855 [myid:127.0.0.1:22032] - INFO  
[main-SendThread(127.0.0.1:22032):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:22032. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-05-23 11:53:11,855 [myid:127.0.0.1:22032] - WARN  
[main-SendThread(127.0.0.1:22032):ClientCnxn$SendThread@1235] - Session 
0x10036aaa589 for server 127.0.0.1/127.0.0.1:22032, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:712)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
122.689 sec, Thread: 5, Class: org.apache.zookeeper.test.ReconfigTest
[junit] 2016-05-23 11:53:34,145 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 51104
[junit] 2016-05-23 11:53:34,146 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 55
[junit] 2016-05-23 11:53:34,146 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testManyChildWatchersAutoReset
[junit] 2016-05-23 11:53:34,146 [myid:] - INFO  [main:ClientBase@537] - 
tearDown starting
[junit] 2016-05-23 11:53:34,147 [myid:] - INFO  [ProcessThread(sid:0 
cport:24690)::PrepRequestProcessor@647] - Processed session termination for 
sessionid: 0x10036a6c029
[junit] 2016-05-23 11:53:34,154 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x10036a6c029 closed
[junit] 2016-05-23 11:53:34,155 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x10036a6c029
[junit] 2016-05-23 11:53:34,155 [myid:] - INFO  
[NIOWorkerThread-23:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port24690,name1=Connections,name2=127.0.0.1,name3=0x10036a6c029]
[junit] 2016-05-23 11:53:34,156 [myid:] - INFO  [ProcessThread(sid:0 
cport:24690)::PrepRequestProcessor@647] - Processed session termination for 
sessionid: 0x10036a6c0290001
[junit] 2016-05-23 11:53:34,157 [myid:] - INFO  
[NIOWorkerThread-23:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:46847 which had sessionid 0x10036a6c029
[junit] 2016-05-23 11:53:34,162 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x10036a6c0290001 closed
[junit] 2016-05-23 11:53:34,162 [myid:] - INFO  [main:ClientBase@507] - 
STOPPING server
[junit] 2016-05-23 11:53:34,163 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x10036a6c0290001
[junit] 2016-05-23 11:53:34,163 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-05-23 11:53:34,163 [myid:] - INFO  
[NIOWorkerThread-18:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port24690,name1=Connections,name2=127.0.0.1,name3=0x10036a6c0290001]
[junit] 2016-05-23 11:53:34,164 [myid:] - INFO  
[NIOWorkerThread-18:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:46890 which had sessionid 0x10036a6c0290001
[junit] 2016-05-23 11:53:34,164 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:24690:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-05-23 11:53:34,166 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorTh

[jira] [Commented] (ZOOKEEPER-2433) ZooKeeperSaslServer: allow user principals in subject

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15296240#comment-15296240
 ] 

Hadoop QA commented on ZOOKEEPER-2433:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12805617/ZOOKEEPER-2433.patch
  against trunk revision 1743978.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3170//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3170//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3170//console

This message is automatically generated.

> ZooKeeperSaslServer: allow user principals in subject
> -
>
> Key: ZOOKEEPER-2433
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2433
> Project: ZooKeeper
>  Issue Type: Wish
>  Components: security
>Affects Versions: 3.5.1
>Reporter: Andy B
>  Labels: easyfix
> Fix For: 3.5.1
>
> Attachments: ZOOKEEPER-2433.patch
>
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> The createSaslServer function in ZooKeeperSaslServer handles only service 
> principal names (eg. service_name/machine_name@realm), though sometimes user 
> principal names like servicen...@example.com are used for authentication.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-2433 PreCommit Build #3170

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2433
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3170/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 374478 lines...]
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3170//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3170//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3170//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 57c0a337a59c51897018cf7952c11274a0cd03cd logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1605:
 exec returned: 1

Total time: 14 minutes 44 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Recording test results
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
[description-setter] Description set: ZOOKEEPER-2433
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Updated] (ZOOKEEPER-2433) ZooKeeperSaslServer: allow user principals in subject

[Andy B (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy B updated ZOOKEEPER-2433:
--
Attachment: ZOOKEEPER-2433.patch

> ZooKeeperSaslServer: allow user principals in subject
> -
>
> Key: ZOOKEEPER-2433
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2433
> Project: ZooKeeper
>  Issue Type: Wish
>  Components: security
>Affects Versions: 3.5.1
>Reporter: Andy B
>  Labels: easyfix
> Fix For: 3.5.1
>
> Attachments: ZOOKEEPER-2433.patch
>
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> The createSaslServer function in ZooKeeperSaslServer handles only service 
> principal names (eg. service_name/machine_name@realm), though sometimes user 
> principal names like servicen...@example.com are used for authentication.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2433) ZooKeeperSaslServer: allow user principals in subject

[Andy B (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy B updated ZOOKEEPER-2433:
--
Attachment: (was: ZOOKEEPER-2433.patch)

> ZooKeeperSaslServer: allow user principals in subject
> -
>
> Key: ZOOKEEPER-2433
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2433
> Project: ZooKeeper
>  Issue Type: Wish
>  Components: security
>Affects Versions: 3.5.1
>Reporter: Andy B
>  Labels: easyfix
> Fix For: 3.5.1
>
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> The createSaslServer function in ZooKeeperSaslServer handles only service 
> principal names (eg. service_name/machine_name@realm), though sometimes user 
> principal names like servicen...@example.com are used for authentication.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

[Ivan Kelly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47354/#review134333
---


Ship it!




Ship It!

- Ivan Kelly


On May 20, 2016, 3:10 a.m., Rakesh R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47354/
> ---
> 
> (Updated May 20, 2016, 3:10 a.m.)
> 
> 
> Review request for zookeeper, fpj, Ivan Kelly, Patrick Hunt, and Raul 
> Gutierrez Segales.
> 
> 
> Bugs: ZOOKEEPER-1045
> https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> 
> 
> Repository: zookeeper-git
> 
> 
> Description
> ---
> 
> Quorum mutual authentication using SASL mechanism - Digest/Kerberos
> 
> 
> Diffs
> -
> 
>   build.xml ab254b2 
>   ivy.xml 95b0e5a 
>   src/java/main/org/apache/zookeeper/Login.java a214c9c 
>   src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 21ef0fa 
>   src/java/main/org/apache/zookeeper/server/ZooKeeperSaslServer.java 71870ce 
>   
> src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java 
> 2fbd6ed 
>   src/java/main/org/apache/zookeeper/server/quorum/Leader.java 40c6748 
>   src/java/main/org/apache/zookeeper/server/quorum/Learner.java c73a8ee 
>   src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 
> 8a748c7 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 
> 20e5f16 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 2f0f21b 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 
> 8ae820d 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 
> e9c8007 
>   
> src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthClient.java
>  PRE-CREATION 
>   
> src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthServer.java
>  PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuth.java 
> PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthClient.java 
> PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthServer.java 
> PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/auth/README.md 
> PRE-CREATION 
>   
> src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthClient.java
>  PRE-CREATION 
>   
> src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthServer.java
>  PRE-CREATION 
>   src/java/main/org/apache/zookeeper/util/SecurityUtils.java PRE-CREATION 
>   src/java/test/data/kerberos/minikdc-krb5.conf PRE-CREATION 
>   src/java/test/data/kerberos/minikdc.ldiff PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/CnxManagerTest.java 
> 831d3ed 
>   
> src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java
>  c1259d1 
>   src/java/test/org/apache/zookeeper/server/quorum/FLECompatibilityTest.java 
> 72e4fc9 
>   src/java/test/org/apache/zookeeper/server/quorum/FLEDontCareTest.java 
> a4c0cb0 
>   src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java 
> 39a53ca 
>   src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java 2ae57ce 
>   src/java/test/org/apache/zookeeper/server/quorum/QuorumCnxManagerTest.java 
> PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 
> ef552db 
>   src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java ab8ce42 
>   
> src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosSecurityTestcase.java
>  PRE-CREATION 
>   
> src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosTestUtils.java 
> PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdc.java 
> PRE-CREATION 
>   src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java 
> PRE-CREATION 
>   
> src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthTestBase.java 
> PRE-CREATION 
>   
> src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthUpgradeTest.java
>  PRE-CREATION 
>   
> src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumDigestAuthTest.java
>  PRE-CREATION 
>   
> src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosAuthTest.java
>  PRE-CREATION 
>   src/java/test/org/apache/zookeeper/test/FLEPredicateTest.java 8088505 
>   src/zookeeper.jute 6521e54 
> 
> Diff: https://reviews.apache.org/r/47354/diff/
> 
> 
> Testing
> ---
> 
> Added unit test cases to verify the changes.
> 
> 
> Thanks,
> 
> Rakesh R
> 
>

ZooKeeper_branch35_openjdk7 - Build # 90 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/90/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 1523 lines...]
[ivy:retrieve] downloading 
http://repo1.maven.org/maven2/log4j/log4j/1.2.17/log4j-1.2.17.jar ...
[ivy:retrieve] . (478kB)
[ivy:retrieve] .. (0kB)
[ivy:retrieve]  [SUCCESSFUL ] log4j#log4j;1.2.17!log4j.jar(bundle) (63ms)
[ivy:retrieve] downloading 
http://repo1.maven.org/maven2/io/netty/netty/3.10.5.Final/netty-3.10.5.Final.jar
 ...
[ivy:retrieve] ... (1299kB)
[ivy:retrieve] .. (0kB)
[ivy:retrieve]  [SUCCESSFUL ] io.netty#netty;3.10.5.Final!netty.jar (83ms)
[ivy:retrieve] downloading 
http://repo1.maven.org/maven2/net/java/dev/javacc/javacc/5.0/javacc-5.0.jar ...
[ivy:retrieve] .. (291kB)
[ivy:retrieve] .. (0kB)
[ivy:retrieve]  [SUCCESSFUL ] net.java.dev.javacc#javacc;5.0!javacc.jar (64ms)
[ivy:retrieve] :: resolution report :: resolve 5743ms :: artifacts dl 909ms
-
|  |modules||   artifacts   |
|   conf   | number| search|dwnlded|evicted|| number|dwnlded|
-
|  default |   12  |   12  |   12  |   0   ||   12  |   12  |
-
[ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper
[ivy:retrieve]  confs: [default]
[ivy:retrieve]  12 artifacts copied, 0 already retrieved (4167kB/35ms)

clover.setup:

clover.info:

clover:

generate_jute_parser:
[mkdir] Created dir: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_openjdk7/branch-3.5/build/jute_compiler/org/apache/jute/compiler/generated
[ivy:artifactproperty] DEPRECATED: 'ivy.conf.file' is deprecated, use 
'ivy.settings.file' instead
[ivy:artifactproperty] :: loading settings :: file = 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_openjdk7/branch-3.5/ivysettings.xml
 [move] Moving 1 file to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_openjdk7/branch-3.5/build/lib
   [javacc] Java Compiler Compiler Version 5.0 (Parser Generator)
   [javacc] (type "javacc" with no arguments for help)
   [javacc] Reading from file 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_openjdk7/branch-3.5/src/java/main/org/apache/jute/compiler/generated/rcc.jj
 . . .
   [javacc] File "TokenMgrError.java" does not exist.  Will create one.
   [javacc] File "ParseException.java" does not exist.  Will create one.
   [javacc] File "Token.java" does not exist.  Will create one.
   [javacc] File "SimpleCharStream.java" does not exist.  Will create one.
   [javacc] Parser generated successfully.

jute:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_openjdk7/branch-3.5/build.xml:1322:
 The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_openjdk7/branch-3.5/build.xml:272:
 Unable to find a javac compiler;
com.sun.tools.javac.Main is not on the classpath.
Perhaps JAVA_HOME does not point to the JDK.
It is currently set to "/usr/lib/jvm/java-7-openjdk-amd64/jre"

Total time: 9 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Recording test results
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2433) ZooKeeperSaslServer: allow user principals in subject

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15296214#comment-15296214
 ] 

Hadoop QA commented on ZOOKEEPER-2433:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12805606/ZOOKEEPER-2433.patch
  against trunk revision 1743978.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3169//console

This message is automatically generated.

> ZooKeeperSaslServer: allow user principals in subject
> -
>
> Key: ZOOKEEPER-2433
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2433
> Project: ZooKeeper
>  Issue Type: Wish
>  Components: security
>Affects Versions: 3.5.1
>Reporter: Andy B
>  Labels: easyfix
> Fix For: 3.5.1
>
> Attachments: ZOOKEEPER-2433.patch
>
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> The createSaslServer function in ZooKeeperSaslServer handles only service 
> principal names (eg. service_name/machine_name@realm), though sometimes user 
> principal names like servicen...@example.com are used for authentication.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-2433 PreCommit Build #3169

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2433
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3169/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 104 lines...]
 [exec] PATCH APPLICATION FAILED
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12805606/ZOOKEEPER-2433.patch
 [exec]   against trunk revision 1743978.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3169//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] ff1a7fa32966eadd7dcc971a0fe5f6d08d7da914 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1605:
 exec returned: 1

Total time: 45 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Recording test results
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
[description-setter] Description set: ZOOKEEPER-2433
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Updated] (ZOOKEEPER-2433) ZooKeeperSaslServer: allow user principals in subject

[Andy B (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy B updated ZOOKEEPER-2433:
--
Labels: easyfix  (was: )

> ZooKeeperSaslServer: allow user principals in subject
> -
>
> Key: ZOOKEEPER-2433
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2433
> Project: ZooKeeper
>  Issue Type: Wish
>  Components: security
>Reporter: Andy B
>  Labels: easyfix
> Attachments: ZOOKEEPER-2433.patch
>
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> The createSaslServer function in ZooKeeperSaslServer handles only service 
> principal names (eg. service_name/machine_name@realm), though sometimes user 
> principal names like servicen...@example.com are used for authentication.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2433) ZooKeeperSaslServer: allow user principals in subject

[Andy B (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy B updated ZOOKEEPER-2433:
--
Attachment: ZOOKEEPER-2433.patch

Handle Kerberos Service as well as User Principal Names

> ZooKeeperSaslServer: allow user principals in subject
> -
>
> Key: ZOOKEEPER-2433
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2433
> Project: ZooKeeper
>  Issue Type: Wish
>  Components: security
>Reporter: Andy B
> Attachments: ZOOKEEPER-2433.patch
>
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> The createSaslServer function in ZooKeeperSaslServer handles only service 
> principal names (eg. service_name/machine_name@realm), though sometimes user 
> principal names like servicen...@example.com are used for authentication.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZOOKEEPER-2433) ZooKeeperSaslServer: allow user principals in subject

[Andy B (JIRA)]

Andy B created ZOOKEEPER-2433:
-

 Summary: ZooKeeperSaslServer: allow user principals in subject
 Key: ZOOKEEPER-2433
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2433
 Project: ZooKeeper
  Issue Type: Wish
  Components: security
Reporter: Andy B


The createSaslServer function in ZooKeeperSaslServer handles only service 
principal names (eg. service_name/machine_name@realm), though sometimes user 
principal names like servicen...@example.com are used for authentication.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk-solaris - Build # 1168 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1168/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 332235 lines...]
[junit] 2016-05-23 08:28:20,105 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-05-23 08:28:20,106 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-05-23 08:28:20,107 [myid:] - INFO  [main:ClientBase@355] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-05-23 08:28:20,107 [myid:] - INFO  [main:ZooKeeperServer@858] 
- minSessionTimeout set to 6000
[junit] 2016-05-23 08:28:20,107 [myid:] - INFO  [main:ZooKeeperServer@867] 
- maxSessionTimeout set to 6
[junit] 2016-05-23 08:28:20,107 [myid:] - INFO  [main:ZooKeeperServer@156] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test4047351590815931681.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test4047351590815931681.junit.dir/version-2
[junit] 2016-05-23 08:28:20,108 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test4047351590815931681.junit.dir/version-2/snapshot.b
[junit] 2016-05-23 08:28:20,110 [myid:] - INFO  [main:FileTxnSnapLog@298] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test4047351590815931681.junit.dir/version-2/snapshot.b
[junit] 2016-05-23 08:28:20,111 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-05-23 08:28:20,112 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:43314
[junit] 2016-05-23 08:28:20,113 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:43314
[junit] 2016-05-23 08:28:20,113 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-05-23 08:28:20,113 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:43314 (no session established for client)
[junit] 2016-05-23 08:28:20,113 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-05-23 08:28:20,115 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-05-23 08:28:20,115 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-05-23 08:28:20,115 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-05-23 08:28:20,115 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-05-23 08:28:20,115 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17717
[junit] 2016-05-23 08:28:20,116 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-05-23 08:28:20,116 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-05-23 08:28:20,116 [myid:] - INFO  [main:ClientBase@537] - 
tearDown starting
[junit] 2016-05-23 08:28:20,192 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x12159b7d084 closed
[junit] 2016-05-23 08:28:20,192 [myid:] - INFO  [main:ClientBase@507] - 
STOPPING server
[junit] 2016-05-23 08:28:20,192 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x12159b7d084
[junit] 2016-05-23 08:28:20,192 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-05-23 08:28:20,192 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-05-23 08:28:20,193 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-05-23 08:28:20,192 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-05-23 08:28:20,193 [myid:] - INFO  [main:ZooKeeperServer@498] 
- shut