Failed: ZOOKEEPER-2470 PreCommit Build #3265
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2470 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3265/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 444922 lines...] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3265//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3265//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3265//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 27287f0215d1957d0a8bc17c8dce01d78a583301 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1605: exec returned: 1 Total time: 20 minutes 2 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Recording test results Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 [description-setter] Description set: ZOOKEEPER-2470 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-2470) ServerConfig#parse(String[]) ignores tickTime
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367267#comment-15367267
]
Hadoop QA commented on ZOOKEEPER-2470:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12816772/ZOOKEEPER-2470.patch
against trunk revision 1750739.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3265//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3265//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3265//console
This message is automatically generated.
> ServerConfig#parse(String[]) ignores tickTime
> --
>
> Key: ZOOKEEPER-2470
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2470
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.4.7, 3.5.1
>Reporter: Alexander Shraer
>Assignee: Alexander Shraer
>Priority: Trivial
> Fix For: 3.4.9, 3.5.3
>
> Attachments: ZOOKEEPER-2470.patch
>
>
> Based on bug report from ykgarfield:
> ServerConfig#parse(String[]) method has the following code:
> public void parse(String[] args) {
> ...
> if (args.length == 3) {
> tickTime = Integer.parseInt(args[2]);
> }
> if (args.length == 4) {
> maxClientCnxns = Integer.parseInt(args[3]);
> }
> }
> ```
> So if args.length == 4 tickTime isn't parsed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2470) ServerConfig#parse(String[]) ignores tickTime
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Shraer updated ZOOKEEPER-2470:
Attachment: ZOOKEEPER-2470.patch
Failed test passes locally for me, and doesn't even invoke the affected
function. Attaching again to see if this was something transient.
> ServerConfig#parse(String[]) ignores tickTime
> --
>
> Key: ZOOKEEPER-2470
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2470
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.4.7, 3.5.1
>Reporter: Alexander Shraer
>Assignee: Alexander Shraer
>Priority: Trivial
> Fix For: 3.4.9, 3.5.3
>
> Attachments: ZOOKEEPER-2470.patch
>
>
> Based on bug report from ykgarfield:
> ServerConfig#parse(String[]) method has the following code:
> public void parse(String[] args) {
> ...
> if (args.length == 3) {
> tickTime = Integer.parseInt(args[2]);
> }
> if (args.length == 4) {
> maxClientCnxns = Integer.parseInt(args[3]);
> }
> }
> ```
> So if args.length == 4 tickTime isn't parsed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2470) ServerConfig#parse(String[]) ignores tickTime
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Shraer updated ZOOKEEPER-2470:
Attachment: (was: ZOOKEEPER-2470.patch)
> ServerConfig#parse(String[]) ignores tickTime
> --
>
> Key: ZOOKEEPER-2470
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2470
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.4.7, 3.5.1
>Reporter: Alexander Shraer
>Assignee: Alexander Shraer
>Priority: Trivial
> Fix For: 3.4.9, 3.5.3
>
>
> Based on bug report from ykgarfield:
> ServerConfig#parse(String[]) method has the following code:
> public void parse(String[] args) {
> ...
> if (args.length == 3) {
> tickTime = Integer.parseInt(args[2]);
> }
> if (args.length == 4) {
> maxClientCnxns = Integer.parseInt(args[3]);
> }
> }
> ```
> So if args.length == 4 tickTime isn't parsed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [VOTE] Apache ZooKeeper release 3.5.2-alpha candidate 1
+1 * ran zk-shell's test suite (all passes: https://asciinema.org/a/buko9me6x0ct294cba5e9zk49) * ran an Observer w/ 3.5.2-alpha taking some (light prod traffic) (all looks good) Thanks Chris et al! -rgs On 4 July 2016 at 05:31, Enrico Olivelli wrote: > +1 (non binding) > > Tested Apache BookKeeper trunk (4.5.0-SNAPSHOT) > > Tested Majordodo (http://majordodo.org). These tests also include > running Apache BookKeeper 4.4.0 Client using the 3.5.2-alpha java > client. > > Tested BlazingCache (http://blazingcache.org) . These tests also > include running Apache BookKeeper 4.4.0 Client using the 3.5.2-alpha > java client. > > I have used the binary artifact published on Maven staging repo > > Regards > Enrico > > 2016-07-03 0:54 GMT+02:00 Edward Ribeiro : > > +1 (non-binding) > > > > - built ZK from source > > - ran all the unit tests > > - generated and checked javadocs > > - generated and checked docs > > - executed few manual test (zkCli.sh) and 4lw > > > > Some small issues (imho): > > > > - the copyright notice is still dating "2008-2013". It's worth updating > to > > the current year? > > - I consistently ran on an test error equals to the one at > > https://builds.apache.org/job/ZooKeeper-trunk/2982/console > > - Also this one: > > > https://mail-archives.apache.org/mod_mbox/zookeeper-dev/201601.mbox/%3C1279938263.1283.1453526737790.JavaMail.jenkins@crius%3E > > > > - In fact, there were 14 failing tests total (I suspect all of them > related > > to the C tests). Any ideas? A couple of flacky tests? > > > > > > Regards, > > Eddie > > > > > > On Sat, Jul 2, 2016 at 1:46 PM, Rakesh Radhakrishnan < > > rakeshr.apa...@gmail.com> wrote: > > > >> +1 > >> > >> - built zookeeper jar from source, > >> - ran unit test cases, few zkCli commands, few four letter words, > >> - tested few scenarios against Hadoop-2.7.2 version(3 node Kerberos > secure > >> cluster environment). > >> > >> Thanks Chris for making the release. > >> > >> Regards, > >> Rakesh > >> > >> On Sat, Jul 2, 2016 at 7:43 PM, Flavio Junqueira > wrote: > >> > >> > +1 > >> > > >> > - Checked license information > >> > - Ran RAT tool > >> > - Ran tests > >> > - Ran some smoke tests > >> > - Verified digests and signature > >> > - Checked release notes > >> > > >> > All of the above LGTM > >> > > >> > -Flavio > >> > > >> > > >> > > On 01 Jul 2016, at 08:45, Chris Nauroth > >> > wrote: > >> > > > >> > > This is a release candidate for 3.5.2-alpha. The full release notes > are > >> > > available at: > >> > > > >> > > > >> > > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&v > >> > > ersion=12331981 > >> > > > >> > > *** Please download, test and vote by July 5th 2016, 23:59 UTC+0. > *** > >> > > > >> > > Source files: > >> > > > http://people.apache.org/~cnauroth/zookeeper-3.5.2-alpha-candidate-1/ > >> > > > >> > > Maven staging repo: > >> > > > >> > > >> > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/z > >> > > ookeeper/3.5.2-alpha/ > >> > > > >> > > The tag to be voted upon: > >> > > https://svn.apache.org/repos/asf/zookeeper/tags/release-3.5.2-rc1/ > >> > > > >> > > ZooKeeper's KEYS file containing PGP keys we use to sign the > release: > >> > > http://www.apache.org/dist/zookeeper/KEYS > >> > > > >> > > Should we release this candidate? > >> > > > >> > > > >> > > --Chris Nauroth > >> > > > >> > > > >> > > > >> > > > >> > > >> > > >> >
[jira] [Commented] (ZOOKEEPER-2470) ServerConfig#parse(String[]) ignores tickTime
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367238#comment-15367238
]
Hadoop QA commented on ZOOKEEPER-2470:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12816769/ZOOKEEPER-2470.patch
against trunk revision 1750739.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3264//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3264//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3264//console
This message is automatically generated.
> ServerConfig#parse(String[]) ignores tickTime
> --
>
> Key: ZOOKEEPER-2470
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2470
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.4.7, 3.5.1
>Reporter: Alexander Shraer
>Assignee: Alexander Shraer
>Priority: Trivial
> Fix For: 3.4.9, 3.5.3
>
> Attachments: ZOOKEEPER-2470.patch
>
>
> Based on bug report from ykgarfield:
> ServerConfig#parse(String[]) method has the following code:
> public void parse(String[] args) {
> ...
> if (args.length == 3) {
> tickTime = Integer.parseInt(args[2]);
> }
> if (args.length == 4) {
> maxClientCnxns = Integer.parseInt(args[3]);
> }
> }
> ```
> So if args.length == 4 tickTime isn't parsed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Failed: ZOOKEEPER-2470 PreCommit Build #3264
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2470 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3264/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 429363 lines...] [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3264//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3264//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3264//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 7106d8e7772711ddaaaf29421a2b5d49b51cf3b0 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1605: exec returned: 2 Total time: 12 minutes 3 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Compressed 552.44 KB of artifacts by 34.8% relative to #3258 Recording test results Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 [description-setter] Description set: ZOOKEEPER-2470 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 ### ## FAILED TESTS (if any) ## 7 tests failed. FAILED: org.apache.zookeeper.test.WatcherTest.testWatchAutoResetWithPending Error Message: Unexpected bean exists! expected:<0> but was:<1> Stack Trace: junit.framework.AssertionFailedError: Unexpected bean exists! expected:<0> but was:<1> at org.apache.zookeeper.test.ClientBase.verifyUnexpectedBeans(ClientBase.java:498) at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:477) at org.apache.zookeeper.test.ClientBase.setUp(ClientBase.java:460) at org.apache.zookeeper.test.WatcherTest.setUp(WatcherTest.java:73) FAILED: org.apache.zookeeper.test.WatcherTest.testWatcherCorrectness Error Message: Unexpected bean exists! expected:<0> but was:<1> Stack Trace: junit.framework.AssertionFailedError: Unexpected bean exists! expected:<0> but was:<1> at org.apache.zookeeper.test.ClientBase.verifyUnexpectedBeans(ClientBase.java:498) at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:477) at org.apache.zookeeper.test.ClientBase.setUp(ClientBase.java:460) at org.apache.zookeeper.test.WatcherTest.setUp(WatcherTest.java:73) FAILED: org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetDisabledWithLocal Error Message:
[jira] [Updated] (ZOOKEEPER-2470) ServerConfig#parse(String[]) ignores tickTime
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Shraer updated ZOOKEEPER-2470:
Attachment: ZOOKEEPER-2470.patch
> ServerConfig#parse(String[]) ignores tickTime
> --
>
> Key: ZOOKEEPER-2470
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2470
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.4.7, 3.5.1
>Reporter: Alexander Shraer
>Assignee: Alexander Shraer
>Priority: Trivial
> Fix For: 3.4.9, 3.5.3
>
> Attachments: ZOOKEEPER-2470.patch
>
>
> Based on bug report from ykgarfield:
> ServerConfig#parse(String[]) method has the following code:
> public void parse(String[] args) {
> ...
> if (args.length == 3) {
> tickTime = Integer.parseInt(args[2]);
> }
> if (args.length == 4) {
> maxClientCnxns = Integer.parseInt(args[3]);
> }
> }
> ```
> So if args.length == 4 tickTime isn't parsed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (ZOOKEEPER-2470) ServerConfig#parse(String[]) ignores tickTime
Alexander Shraer created ZOOKEEPER-2470:
---
Summary: ServerConfig#parse(String[]) ignores tickTime
Key: ZOOKEEPER-2470
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2470
Project: ZooKeeper
Issue Type: Bug
Components: server
Affects Versions: 3.5.1, 3.4.7
Reporter: Alexander Shraer
Assignee: Alexander Shraer
Priority: Trivial
Fix For: 3.4.9, 3.5.3
Based on bug report from ykgarfield:
ServerConfig#parse(String[]) method has the following code:
public void parse(String[] args) {
...
if (args.length == 3) {
tickTime = Integer.parseInt(args[2]);
}
if (args.length == 4) {
maxClientCnxns = Integer.parseInt(args[3]);
}
}
```
So if args.length == 4 tickTime isn't parsed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (ZOOKEEPER-2469) infinite loop in ZK re-login
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367170#comment-15367170
]
Edward Ribeiro edited comment on ZOOKEEPER-2469 at 7/8/16 3:44 AM:
---
Nice catch [~sershe]! I am not aware of this code path, but [~arshadmohammad]
has been working with credentials on ZK so I think it's nice to let him take a
look at the patch too. :) I would like to make a few comments though.
The "is" prefix is usually used to Java boolean methods. In the case a boolean
parameter, {{immediateRetry}} seems more readable, imho.
{code}
if (!hasSufficientTimeElapsed(isImmediateRetry)) {
return;
}
{code}
can be rewritten as:
{code}
if (!immediateRetry && !hasSufficientTimeElapsed()) {
return;
}
{code}
That is, there's no need to propagate the {{immediateRetry}} boolean down
{{hasSuficientTimeElapsed()}} if it is only needed at the {{reLogin}} level.
{quote}
// TODO: should we also exit the refresh thread?
{quote}
Well, see that there's an outer try-catch block that catches the LoginException
and exit the thread. As far as I can see, this means that we would need to
re-throw the last exception {{le}} at this exact same line.
I see you trying to preserve the first LoginException, but I am asking myself
if it was not better just to spit out the {{LOG.error}} as below:
{code}
catch (LoginException le) {
LOG.error("Could not refresh TGT for principal:
{}.", principal, le);
if (retry > 0) {
// sleep for 10 seconds.
try {
Thread.sleep(10 * 1000);
} catch (InterruptedException e) {
LOG.error("Interrupted during login
retry after LoginException:", le);
throw le;
}
} else {
throw le;
}
LOG.debug("Retrying login for principal:{}...",
principal);
--retry;
}
{code}
It would be nice to provide some unit tests to exercise those scenarios. This
probably would require some method extraction tough, so it is harder and more
error prone, but maybe worth doing (idk).
Last but not least, as we are using Java 7, then we can replace
{{Thread.sleep(10 * 1000);}} by {{TimeUnit.SECONDS.sleep(10);}} (more clearer,
no need to code comment anymore).
was (Author: eribeiro):
Nice catch [~sershe]! I am not aware of this code path, but [~arshadmohammad]
has been working with credentials on ZK so I think it's nice to have it take a
look at the patch too. :) I would like to make a few comments though.
The "is" prefix is usually used to Java boolean methods. In the case a boolean
parameter, {{immediateRetry}} seems more readable, imho.
{code}
if (!hasSufficientTimeElapsed(isImmediateRetry)) {
return;
}
{code}
can be rewritten as:
{code}
if (!immediateRetry && !hasSufficientTimeElapsed()) {
return;
}
{code}
That is, there's no need to propagate the {{immediateRetry}} boolean down
{{hasSuficientTimeElapsed()}} if it is only needed at the {{reLogin}} level.
{quote}
// TODO: should we also exit the refresh thread?
{quote}
Well, see that there's an outer try-catch block that catches the LoginException
and exit the thread. As far as I can see, this means that we would need to
re-throw the last exception {{le}} at this exact same line.
I see you trying to preserve the first LoginException, but I am asking myself
if it was not better just to spit out the {{LOG.error}} as below:
{code}
catch (LoginException le) {
LOG.error("Could not refresh TGT for principal:
{}.", principal, le);
if (retry > 0) {
// sleep for 10 seconds.
try {
Thread.sleep(10 * 1000);
} catch (InterruptedException e) {
LOG.error("Interrupted during login
retry after LoginException:", le);
throw le;
}
} else {
throw le;
}
LOG.debug("Retrying login for principal:{}...",
principal);
--retry;
}
{code}
It would be nice to provide some un
[jira] [Commented] (ZOOKEEPER-2469) infinite loop in ZK re-login
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367170#comment-15367170
]
Edward Ribeiro commented on ZOOKEEPER-2469:
---
Nice catch [~sershe]! I am not aware of this code path, but [~arshadmohammad]
has been working with credentials on ZK so I think it's nice to have it take a
look at the patch too. :) I would like to make a few comments though.
The "is" prefix is usually used to Java boolean methods. In the case a boolean
parameter, {{immediateRetry}} seems more readable, imho.
{code}
if (!hasSufficientTimeElapsed(isImmediateRetry)) {
return;
}
{code}
can be rewritten as:
{code}
if (!immediateRetry && !hasSufficientTimeElapsed()) {
return;
}
{code}
That is, there's no need to propagate the {{immediateRetry}} boolean down
{{hasSuficientTimeElapsed()}} if it is only needed at the {{reLogin}} level.
{quote}
// TODO: should we also exit the refresh thread?
{quote}
Well, see that there's an outer try-catch block that catches the LoginException
and exit the thread. As far as I can see, this means that we would need to
re-throw the last exception {{le}} at this exact same line.
I see you trying to preserve the first LoginException, but I am asking myself
if it was not better just to spit out the {{LOG.error}} as below:
{code}
catch (LoginException le) {
LOG.error("Could not refresh TGT for principal:
{}.", principal, le);
if (retry > 0) {
// sleep for 10 seconds.
try {
Thread.sleep(10 * 1000);
} catch (InterruptedException e) {
LOG.error("Interrupted during login
retry after LoginException:", le);
throw le;
}
} else {
throw le;
}
LOG.debug("Retrying login for principal:{}...",
principal);
--retry;
}
{code}
It would be nice to provide some unit tests to exercise those scenarios. This
probably would require some method extraction tough, so it is harder and more
error prone, but maybe worth doing (idk).
Last but not least, as we are using Java 7, then we can replace
{{Thread.sleep(10 * 1000);}} by {{TimeUnit.SECONDS.sleep(10);}} (more clearer,
no need to code comment anymore).
> infinite loop in ZK re-login
>
>
> Key: ZOOKEEPER-2469
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2469
> Project: ZooKeeper
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: ZOOKEEPER-2469.patch
>
>
> {noformat}
> int retry = 1;
> while (retry >= 0) {
> try {
> reLogin();
> break;
> } catch (LoginException le) {
> if (retry > 0) {
> --retry;
> // sleep for 10 seconds.
> try {
> Thread.sleep(10 * 1000);
> } catch (InterruptedException e) {
> LOG.error("Interrupted during login
> retry after LoginException:", le);
> throw le;
> }
> } else {
> LOG.error("Could not refresh TGT for
> principal: " + principal + ".", le);
> }
> }
> }
> {noformat}
> will retry forever. Should return like the one above
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] zookeeper pull request #74: ServerConfig#parse(String[]) parse params has pr...
GitHub user ykgarfield opened a pull request:
https://github.com/apache/zookeeper/pull/74
ServerConfig#parse(String[]) parse params has problems
When debug zookeeper, run `ZooKeeperServerMain` then pass 4 args, e.g:
`2181 F:\\zk\\data 2000 30`, that is:
```
clientPort = 2181
dataDir = F:\\zk\\data
tickTime = 2000
maxClientCnxns = 30
```
But ServerConfig#parse(String[]) method has a little problemï¼
``` java
public void parse(String[] args) {
...
if (args.length == 3) {
tickTime = Integer.parseInt(args[2]);
}
if (args.length == 4) {
maxClientCnxns = Integer.parseInt(args[3]);
}
}
```
The problem is:
```java
if (args.length == 4) {
maxClientCnxns = Integer.parseInt(args[3]);
}
```
It can't parse `tickTime`, igone the `tickTime`.This coe snippet should be:
```java
if (args.length == 4) {
tickTime = Integer.parseInt(args[2]);
maxClientCnxns = Integer.parseInt(args[3]);
}
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/zookeeper branch-3.4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/74.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #74
commit b19ae792c3fa4f164f89e83d45d4fcd3ac5fe3cb
Author: Patrick D. Hunt
Date: 2012-07-17T21:27:04Z
ZOOKEEPER-1489. Data loss after truncate on transaction log (phunt)
git-svn-id:
https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1362661
13f79535-47bb-0310-9956-ffa450edef68
commit c37e8f0a6739a696f9408faff0212fb030cbd154
Author: Patrick D. Hunt
Date: 2012-07-29T05:04:27Z
ZOOKEEPER-1521. LearnerHandler initLimit/syncLimit problems specifying
follower socket timeout limits (phunt)
git-svn-id:
https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1366782
13f79535-47bb-0310-9956-ffa450edef68
commit 61837bc135521cabdb073aaa8992024c4b15a8b2
Author: Patrick D. Hunt
Date: 2012-07-29T05:32:17Z
ZOOKEEPER-1493. C Client: zookeeper_process doesn't invoke completion
callback if zookeeper_close has been called (Michi Mutsuzaki via phunt and
mahadev)
git-svn-id:
https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1366785
13f79535-47bb-0310-9956-ffa450edef68
commit 4aaafb6dea065c1bc7620f93e893386585975a4a
Author: Patrick D. Hunt
Date: 2012-08-01T15:55:58Z
ZOOKEEPER-1522. intermittent failures in Zab test due to NPE in
recursiveDelete test function (phunt via flavio)
git-svn-id:
https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1368077
13f79535-47bb-0310-9956-ffa450edef68
commit 7e325d9ccd84e879e47d75675fe1514183fab1aa
Author: Patrick D. Hunt
Date: 2012-08-01T19:22:55Z
ZOOKEEPER-1503. remove redundant JAAS configuration code in SaslAuthTest
and SaslAuthFailTest (Eugene Koontz via phunt)
git-svn-id:
https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1368205
13f79535-47bb-0310-9956-ffa450edef68
commit 2244be2c1d6c01f82ef1a288f882513d8fe38cf6
Author: Patrick D. Hunt
Date: 2012-08-01T21:39:22Z
ZOOKEEPER-1510. Should not log SASL errors for non-secure usage (Todd
Lipcon via phunt)
git-svn-id:
https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1368270
13f79535-47bb-0310-9956-ffa450edef68
commit 20850d79fac70c5a9a8f4cd7b36bf23c96ce0487
Author: Patrick D. Hunt
Date: 2012-08-01T22:25:03Z
ZOOKEEPER-1510. Should not log SASL errors for non-secure usage (Todd
Lipcon via phunt) Missed a bit in the prior commit
git-svn-id:
https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1368301
13f79535-47bb-0310-9956-ffa450edef68
commit 0490eb86c2b5e7349f4e52d600ad91bd680af116
Author: Henry Robinson
Date: 2012-08-02T22:18:57Z
ZOOKEEPER-1514. FastLeaderElection - leader ignores the round information
when joining a quorum (flavio via henryr)
git-svn-id:
https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1368739
13f79535-47bb-0310-9956-ffa450edef68
commit 9dc9c00da5830a29df1c1633ffc0ae82e7c6c209
Author: Patrick D. Hunt
Date: 2012-08-28T19:57:18Z
ZOOKEEPER-1497. Allow server-side SASL login with JAAS configuration to be
programmatically set (rather than only by reading JAAS configuration file)
(Matteo Bertozzi via phunt)
git-svn-id:
https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1378287
13f79535-47bb-0310-9956-ffa450edef68
commit 679164cd0173920ccd6e70ecb0d965650ad40666
Author: Michi Mutsuzaki
Date: 2012-08-30T19:26:58Z
ZOOKEEPER-1536 c client : memory leak in winport.c (brooklin via michim)
git-svn-i
[jira] [Commented] (ZOOKEEPER-2469) infinite loop in ZK re-login
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367103#comment-15367103
]
Hadoop QA commented on ZOOKEEPER-2469:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12816737/ZOOKEEPER-2469.patch
against trunk revision 1750739.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3263//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3263//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3263//console
This message is automatically generated.
> infinite loop in ZK re-login
>
>
> Key: ZOOKEEPER-2469
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2469
> Project: ZooKeeper
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: ZOOKEEPER-2469.patch
>
>
> {noformat}
> int retry = 1;
> while (retry >= 0) {
> try {
> reLogin();
> break;
> } catch (LoginException le) {
> if (retry > 0) {
> --retry;
> // sleep for 10 seconds.
> try {
> Thread.sleep(10 * 1000);
> } catch (InterruptedException e) {
> LOG.error("Interrupted during login
> retry after LoginException:", le);
> throw le;
> }
> } else {
> LOG.error("Could not refresh TGT for
> principal: " + principal + ".", le);
> }
> }
> }
> {noformat}
> will retry forever. Should return like the one above
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Failed: ZOOKEEPER-2469 PreCommit Build #3263
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2469 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3263/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 443649 lines...] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3263//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3263//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3263//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 78931e085659da672f035057bcc9f0f00fcf83db logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1605: exec returned: 1 Total time: 21 minutes 5 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Recording test results Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 [description-setter] Description set: ZOOKEEPER-2469 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Updated] (ZOOKEEPER-2469) infinite loop in ZK re-login
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated ZOOKEEPER-2469:
Attachment: (was: ZOOKEEPER-2469.patch)
> infinite loop in ZK re-login
>
>
> Key: ZOOKEEPER-2469
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2469
> Project: ZooKeeper
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: ZOOKEEPER-2469.patch
>
>
> {noformat}
> int retry = 1;
> while (retry >= 0) {
> try {
> reLogin();
> break;
> } catch (LoginException le) {
> if (retry > 0) {
> --retry;
> // sleep for 10 seconds.
> try {
> Thread.sleep(10 * 1000);
> } catch (InterruptedException e) {
> LOG.error("Interrupted during login
> retry after LoginException:", le);
> throw le;
> }
> } else {
> LOG.error("Could not refresh TGT for
> principal: " + principal + ".", le);
> }
> }
> }
> {noformat}
> will retry forever. Should return like the one above
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2469) infinite loop in ZK re-login
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367084#comment-15367084
]
Sergey Shelukhin commented on ZOOKEEPER-2469:
-
[~cnauroth] can you review rather? Enis is not a committer it appears.
> infinite loop in ZK re-login
>
>
> Key: ZOOKEEPER-2469
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2469
> Project: ZooKeeper
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: ZOOKEEPER-2469.patch, ZOOKEEPER-2469.patch
>
>
> {noformat}
> int retry = 1;
> while (retry >= 0) {
> try {
> reLogin();
> break;
> } catch (LoginException le) {
> if (retry > 0) {
> --retry;
> // sleep for 10 seconds.
> try {
> Thread.sleep(10 * 1000);
> } catch (InterruptedException e) {
> LOG.error("Interrupted during login
> retry after LoginException:", le);
> throw le;
> }
> } else {
> LOG.error("Could not refresh TGT for
> principal: " + principal + ".", le);
> }
> }
> }
> {noformat}
> will retry forever. Should return like the one above
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2469) infinite loop in ZK re-login
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367081#comment-15367081
]
Sergey Shelukhin commented on ZOOKEEPER-2469:
-
[~enis] can you review? thanks
> infinite loop in ZK re-login
>
>
> Key: ZOOKEEPER-2469
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2469
> Project: ZooKeeper
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: ZOOKEEPER-2469.patch, ZOOKEEPER-2469.patch
>
>
> {noformat}
> int retry = 1;
> while (retry >= 0) {
> try {
> reLogin();
> break;
> } catch (LoginException le) {
> if (retry > 0) {
> --retry;
> // sleep for 10 seconds.
> try {
> Thread.sleep(10 * 1000);
> } catch (InterruptedException e) {
> LOG.error("Interrupted during login
> retry after LoginException:", le);
> throw le;
> }
> } else {
> LOG.error("Could not refresh TGT for
> principal: " + principal + ".", le);
> }
> }
> }
> {noformat}
> will retry forever. Should return like the one above
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2469) infinite loop in ZK re-login
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated ZOOKEEPER-2469:
Attachment: ZOOKEEPER-2469.patch
I suspect logout would also fail on retry if it succeeded the first time,
producing a different error, so here's a small update
> infinite loop in ZK re-login
>
>
> Key: ZOOKEEPER-2469
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2469
> Project: ZooKeeper
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: ZOOKEEPER-2469.patch, ZOOKEEPER-2469.patch
>
>
> {noformat}
> int retry = 1;
> while (retry >= 0) {
> try {
> reLogin();
> break;
> } catch (LoginException le) {
> if (retry > 0) {
> --retry;
> // sleep for 10 seconds.
> try {
> Thread.sleep(10 * 1000);
> } catch (InterruptedException e) {
> LOG.error("Interrupted during login
> retry after LoginException:", le);
> throw le;
> }
> } else {
> LOG.error("Could not refresh TGT for
> principal: " + principal + ".", le);
> }
> }
> }
> {noformat}
> will retry forever. Should return like the one above
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2469) infinite loop in ZK re-login
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367054#comment-15367054
]
Sergey Shelukhin commented on ZOOKEEPER-2469:
-
[~cnauroth] [~enis] [~mahadev] can you assign this to me?
> infinite loop in ZK re-login
>
>
> Key: ZOOKEEPER-2469
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2469
> Project: ZooKeeper
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>
> {noformat}
> int retry = 1;
> while (retry >= 0) {
> try {
> reLogin();
> break;
> } catch (LoginException le) {
> if (retry > 0) {
> --retry;
> // sleep for 10 seconds.
> try {
> Thread.sleep(10 * 1000);
> } catch (InterruptedException e) {
> LOG.error("Interrupted during login
> retry after LoginException:", le);
> throw le;
> }
> } else {
> LOG.error("Could not refresh TGT for
> principal: " + principal + ".", le);
> }
> }
> }
> {noformat}
> will retry forever. Should return like the one above
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2469) infinite loop in ZK re-login
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated ZOOKEEPER-2469:
Attachment: ZOOKEEPER-2469.patch
> infinite loop in ZK re-login
>
>
> Key: ZOOKEEPER-2469
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2469
> Project: ZooKeeper
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: ZOOKEEPER-2469.patch
>
>
> {noformat}
> int retry = 1;
> while (retry >= 0) {
> try {
> reLogin();
> break;
> } catch (LoginException le) {
> if (retry > 0) {
> --retry;
> // sleep for 10 seconds.
> try {
> Thread.sleep(10 * 1000);
> } catch (InterruptedException e) {
> LOG.error("Interrupted during login
> retry after LoginException:", le);
> throw le;
> }
> } else {
> LOG.error("Could not refresh TGT for
> principal: " + principal + ".", le);
> }
> }
> }
> {noformat}
> will retry forever. Should return like the one above
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2469) infinite loop in ZK re-login
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367064#comment-15367064
]
Mahadev konar commented on ZOOKEEPER-2469:
--
[~sershe] done.
> infinite loop in ZK re-login
>
>
> Key: ZOOKEEPER-2469
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2469
> Project: ZooKeeper
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>
> {noformat}
> int retry = 1;
> while (retry >= 0) {
> try {
> reLogin();
> break;
> } catch (LoginException le) {
> if (retry > 0) {
> --retry;
> // sleep for 10 seconds.
> try {
> Thread.sleep(10 * 1000);
> } catch (InterruptedException e) {
> LOG.error("Interrupted during login
> retry after LoginException:", le);
> throw le;
> }
> } else {
> LOG.error("Could not refresh TGT for
> principal: " + principal + ".", le);
> }
> }
> }
> {noformat}
> will retry forever. Should return like the one above
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2469) infinite loop in ZK re-login
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-2469:
-
Assignee: Sergey Shelukhin
> infinite loop in ZK re-login
>
>
> Key: ZOOKEEPER-2469
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2469
> Project: ZooKeeper
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>
> {noformat}
> int retry = 1;
> while (retry >= 0) {
> try {
> reLogin();
> break;
> } catch (LoginException le) {
> if (retry > 0) {
> --retry;
> // sleep for 10 seconds.
> try {
> Thread.sleep(10 * 1000);
> } catch (InterruptedException e) {
> LOG.error("Interrupted during login
> retry after LoginException:", le);
> throw le;
> }
> } else {
> LOG.error("Could not refresh TGT for
> principal: " + principal + ".", le);
> }
> }
> }
> {noformat}
> will retry forever. Should return like the one above
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2469) infinite loop in ZK re-login
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367052#comment-15367052
]
Sergey Shelukhin commented on ZOOKEEPER-2469:
-
Additionally, after that reLogin quietly returns (due to Not attempting), so if
it fails once, the exception is swallowed, the retry doesn't happen and the
loop ends
> infinite loop in ZK re-login
>
>
> Key: ZOOKEEPER-2469
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2469
> Project: ZooKeeper
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>
> {noformat}
> int retry = 1;
> while (retry >= 0) {
> try {
> reLogin();
> break;
> } catch (LoginException le) {
> if (retry > 0) {
> --retry;
> // sleep for 10 seconds.
> try {
> Thread.sleep(10 * 1000);
> } catch (InterruptedException e) {
> LOG.error("Interrupted during login
> retry after LoginException:", le);
> throw le;
> }
> } else {
> LOG.error("Could not refresh TGT for
> principal: " + principal + ".", le);
> }
> }
> }
> {noformat}
> will retry forever. Should return like the one above
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2469) infinite loop in ZK re-login
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367042#comment-15367042
]
Sergey Shelukhin commented on ZOOKEEPER-2469:
-
FWIW, {noformat} LOG.warn("Not attempting to re-login since the last
re-login was " +
"attempted less than " + (MIN_TIME_BEFORE_RELOGIN/1000) + "
seconds"+
" before.");{noformat}
seems to sabotage this retry anyway.
> infinite loop in ZK re-login
>
>
> Key: ZOOKEEPER-2469
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2469
> Project: ZooKeeper
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>
> {noformat}
> int retry = 1;
> while (retry >= 0) {
> try {
> reLogin();
> break;
> } catch (LoginException le) {
> if (retry > 0) {
> --retry;
> // sleep for 10 seconds.
> try {
> Thread.sleep(10 * 1000);
> } catch (InterruptedException e) {
> LOG.error("Interrupted during login
> retry after LoginException:", le);
> throw le;
> }
> } else {
> LOG.error("Could not refresh TGT for
> principal: " + principal + ".", le);
> }
> }
> }
> {noformat}
> will retry forever. Should return like the one above
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2469) infinite loop in ZK re-login
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated ZOOKEEPER-2469:
Description:
{noformat}
int retry = 1;
while (retry >= 0) {
try {
reLogin();
break;
} catch (LoginException le) {
if (retry > 0) {
--retry;
// sleep for 10 seconds.
try {
Thread.sleep(10 * 1000);
} catch (InterruptedException e) {
LOG.error("Interrupted during login
retry after LoginException:", le);
throw le;
}
} else {
LOG.error("Could not refresh TGT for
principal: " + principal + ".", le);
}
}
}
{noformat}
will retry forever. Should return like the one above
was:
{noformat}
int retry = 1;
while (retry >= 0) {
try {
LOG.debug("running ticket cache refresh
command: " + cmd + " " + kinitArgs);
Shell.execCommand(cmd, kinitArgs);
break;
} catch (Exception e) {
if (retry > 0) {
--retry;
// sleep for 10 seconds
try {
Thread.sleep(10 * 1000);
} catch (InterruptedException ie) {
LOG.error("Interrupted while renewing
TGT, exiting Login thread");
return;
}
} else {
LOG.warn("Could not renew TGT due to
problem running shell command: '" + cmd
+ " " + kinitArgs + "'" + ";
exception was:" + e + ". Exiting refresh thread.",e);
return;
}
}
}
{noformat}
And one more (at least) below that will retry forever.
> infinite loop in ZK re-login
>
>
> Key: ZOOKEEPER-2469
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2469
> Project: ZooKeeper
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>
> {noformat}
> int retry = 1;
> while (retry >= 0) {
> try {
> reLogin();
> break;
> } catch (LoginException le) {
> if (retry > 0) {
> --retry;
> // sleep for 10 seconds.
> try {
> Thread.sleep(10 * 1000);
> } catch (InterruptedException e) {
> LOG.error("Interrupted during login
> retry after LoginException:", le);
> throw le;
> }
> } else {
> LOG.error("Could not refresh TGT for
> principal: " + principal + ".", le);
> }
> }
> }
> {noformat}
> will retry forever. Should return like the one above
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (ZOOKEEPER-2469) infinite loop in ZK re-login
Sergey Shelukhin created ZOOKEEPER-2469:
---
Summary: infinite loop in ZK re-login
Key: ZOOKEEPER-2469
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2469
Project: ZooKeeper
Issue Type: Bug
Reporter: Sergey Shelukhin
{noformat}
int retry = 1;
while (retry >= 0) {
try {
LOG.debug("running ticket cache refresh
command: " + cmd + " " + kinitArgs);
Shell.execCommand(cmd, kinitArgs);
break;
} catch (Exception e) {
if (retry > 0) {
--retry;
// sleep for 10 seconds
try {
Thread.sleep(10 * 1000);
} catch (InterruptedException ie) {
LOG.error("Interrupted while renewing
TGT, exiting Login thread");
return;
}
} else {
LOG.warn("Could not renew TGT due to
problem running shell command: '" + cmd
+ " " + kinitArgs + "'" + ";
exception was:" + e + ". Exiting refresh thread.",e);
return;
}
}
}
{noformat}
And one more (at least) below that will retry forever.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: ZooKeeper release validation cluster access
I'll help validating the release on our internal cluster using zk-smoke and manual testing. Do we have a standard protocol on what should be validated and how? Also do we perform integration tests (e.g. with HBase / Kafka) as part of release validation? On Thu, Jul 7, 2016 at 12:25 PM, Flavio P JUNQUEIRA wrote: > And thanks for doing this, Camile, this is great. > > -Flavio > On 7 Jul 2016 8:25 p.m., "Flavio P JUNQUEIRA" wrote: > > > Perhaps start from phunt's smoke test? > > > > https://github.com/phunt/zk-smoketest > > > > -Flavio > > On 7 Jul 2016 7:04 p.m., "Camille Fournier" wrote: > > > >> So I'm working with the CNCF to see about getting cluster access to spin > >> up > >> ZK clusters for release validation. I was wondering if anyone has > scripts > >> for deploying and configuring ZK clusters quickly for stress testing > that > >> we could use if we get this access? I'm sure some of you in the > community > >> must do some of this internally. > >> > >> I would also very much appreciate any volunteers to contribute to making > >> better public release validation work, if possible, since it's unclear > how > >> much time I personally will be able to dedicate to this effort beyond > >> getting access to the cluster. > >> > >> Thanks, > >> C > >> > > > -- Cheers Michael.
Re: ZooKeeper release validation cluster access
Hi, Camille, We (twitter) are definitely interested in helping. We would need to test this release anyway for our own sake. However, we have very limited OSS experience so please guide us along the way. So what’s the next step? > On Jul 7, 2016, at 11:04 AM, Camille Fournier wrote: > > So I'm working with the CNCF to see about getting cluster access to spin up > ZK clusters for release validation. I was wondering if anyone has scripts > for deploying and configuring ZK clusters quickly for stress testing that > we could use if we get this access? I'm sure some of you in the community > must do some of this internally. > > I would also very much appreciate any volunteers to contribute to making > better public release validation work, if possible, since it's unclear how > much time I personally will be able to dedicate to this effort beyond > getting access to the cluster. > > Thanks, > C
[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366709#comment-15366709 ] Michael Han commented on ZOOKEEPER-1045: [~rakeshr] Thanks for putting up the feedback! I'll update the test doc early next week. > Support Quorum Peer mutual authentication via SASL > -- > > Key: ZOOKEEPER-1045 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1045 > Project: ZooKeeper > Issue Type: New Feature > Components: server >Reporter: Eugene Koontz >Assignee: Rakesh R >Priority: Critical > Fix For: 3.4.9, 3.5.3 > > Attachments: 0001-ZOOKEEPER-1045-br-3-4.patch, > 1045_failing_phunt.tar.gz, ZK-1045-test-case-failure-logs.zip, > ZOOKEEPER-1045-00.patch, ZOOKEEPER-1045-Rolling Upgrade Design Proposal.pdf, > ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, > ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, > ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045TestValidationDesign.pdf > > > ZOOKEEPER-938 addresses mutual authentication between clients and servers. > This bug, on the other hand, is for authentication among quorum peers. > Hopefully much of the work done on SASL integration with Zookeeper for > ZOOKEEPER-938 can be used as a foundation for this enhancement. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
ZooKeeper-trunk-openjdk7 - Build # 1085 - Failure
See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1085/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 431295 lines...] [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2016-07-07 19:58:02,877 [myid:] - INFO [ProcessThread(sid:0 cport:30317)::PrepRequestProcessor@647] - Processed session termination for sessionid: 0x10120935853 [junit] 2016-07-07 19:58:02,893 [myid:] - WARN [New I/O worker #6635:NettyServerCnxnFactory$CnxnChannelHandler@142] - Exception caught [id: 0x2df4028a, /127.0.0.1:34435 :> /127.0.0.1:30317] EXCEPTION: java.nio.channels.ClosedChannelException [junit] java.nio.channels.ClosedChannelException [junit] at sun.nio.ch.SocketChannelImpl.ensureWriteOpen(SocketChannelImpl.java:270) [junit] at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:479) [junit] at org.jboss.netty.channel.socket.nio.SocketSendBufferPool$UnpooledSendBuffer.transferTo(SocketSendBufferPool.java:203) [junit] at org.jboss.netty.channel.socket.nio.AbstractNioWorker.write0(AbstractNioWorker.java:201) [junit] at org.jboss.netty.channel.socket.nio.AbstractNioWorker.writeFromTaskLoop(AbstractNioWorker.java:151) [junit] at org.jboss.netty.channel.socket.nio.AbstractNioChannel$WriteTask.run(AbstractNioChannel.java:315) [junit] at org.jboss.netty.channel.socket.nio.AbstractNioSelector.processTaskQueue(AbstractNioSelector.java:391) [junit] at org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:315) [junit] at org.jboss.netty.channel.socket.nio.AbstractNioWorker.run(AbstractNioWorker.java:89) [junit] at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:178) [junit] at org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108) [junit] at org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42) [junit] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [junit] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [junit] at java.lang.Thread.run(Thread.java:745) [junit] 2016-07-07 19:58:02,893 [myid:] - INFO [SyncThread:0:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port30317,name1=Connections,name2=127.0.0.1,name3=0x10120935853] [junit] 2016-07-07 19:58:02,993 [myid:] - INFO [main:ZooKeeper@1313] - Session: 0x10120935853 closed [junit] 2016-07-07 19:58:02,993 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x10120935853 [junit] 2016-07-07 19:58:02,994 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 122890 [junit] 2016-07-07 19:58:02,994 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 1640 [junit] 2016-07-07 19:58:02,994 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testWatcherAutoResetWithLocal [junit] 2016-07-07 19:58:02,994 [myid:] - INFO [main:ClientBase@543] - tearDown starting [junit] 2016-07-07 19:58:02,994 [myid:] - INFO [main:ClientBase@513] - STOPPING server [junit] 2016-07-07 19:58:02,995 [myid:] - INFO [main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:30317 [junit] 2016-07-07 19:58:03,000 [myid:] - INFO [main:ZooKeeperServer@498] - shutting down [junit] 2016-07-07 19:58:03,000 [myid:] - INFO [main:SessionTrackerImpl@232] - Shutting down [junit] 2016-07-07 19:58:03,000 [myid:] - INFO [main:PrepRequestProcessor@965] - Shutting down [junit] 2016-07-07 19:58:03,000 [myid:] - INFO [main:SyncRequestProcessor@191] - Shutting down [junit] 2016-07-07 19:58:03,000 [myid:] - INFO [ProcessThread(sid:0 cport:30317)::PrepRequestProcessor@154] - PrepRequestProcessor exited loop! [junit] 2016-07-07 19:58:03,001 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited! [junit] 2016-07-07 19:58:03,001 [myid:] - INFO [main:FinalRequestProcessor@479] - shutdown of request processor complete [junit] 2016-07-07 19:58:03,001 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port30317,name1=InMemoryDataTree] [junit] 2016-07-07 19:58:03,001 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port30317] [junit] 2016-07-07 19:58:03,001 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 30317 [junit] 2016-07-07 19:58:03,002 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2016-07-07 19:58:03,006 [myid:127.0.0.1:30197] - I
Re: ZooKeeper release validation cluster access
And thanks for doing this, Camile, this is great. -Flavio On 7 Jul 2016 8:25 p.m., "Flavio P JUNQUEIRA" wrote: > Perhaps start from phunt's smoke test? > > https://github.com/phunt/zk-smoketest > > -Flavio > On 7 Jul 2016 7:04 p.m., "Camille Fournier" wrote: > >> So I'm working with the CNCF to see about getting cluster access to spin >> up >> ZK clusters for release validation. I was wondering if anyone has scripts >> for deploying and configuring ZK clusters quickly for stress testing that >> we could use if we get this access? I'm sure some of you in the community >> must do some of this internally. >> >> I would also very much appreciate any volunteers to contribute to making >> better public release validation work, if possible, since it's unclear how >> much time I personally will be able to dedicate to this effort beyond >> getting access to the cluster. >> >> Thanks, >> C >> >
Re: ZooKeeper release validation cluster access
Perhaps start from phunt's smoke test? https://github.com/phunt/zk-smoketest -Flavio On 7 Jul 2016 7:04 p.m., "Camille Fournier" wrote: > So I'm working with the CNCF to see about getting cluster access to spin up > ZK clusters for release validation. I was wondering if anyone has scripts > for deploying and configuring ZK clusters quickly for stress testing that > we could use if we get this access? I'm sure some of you in the community > must do some of this internally. > > I would also very much appreciate any volunteers to contribute to making > better public release validation work, if possible, since it's unclear how > much time I personally will be able to dedicate to this effort beyond > getting access to the cluster. > > Thanks, > C >
Re: Status: Apache ZooKeeper release 3.5.2-alpha candidate 1
Add my data points: Java unit tests all passed on my mac and test cluster (Ubuntu 14.04). Both NioNettySuiteTest and NettyNettySuiteTest also passed on mac in 5 runs. Source used for testing: http://people.apache.org/~cnauroth/zookeeper-3.5.2-alpha-candidate-1/zookeeper-3.5.2-alpha.tar.gz On Thu, Jul 7, 2016 at 9:22 AM, Camille Fournier wrote: > Testcase: testRemoveOneAsynchronous took 60.235 sec > FAILED > Waiting for server down > junit.framework.AssertionFailedError: Waiting for server down > at > org.apache.zookeeper.test.QuorumUtil.shutdownAll(QuorumUtil.java:241) > at > org.apache.zookeeper.test.QuorumUtil.startAll(QuorumUtil.java:143) > at > > org.apache.zookeeper.test.ReconfigTest.testRemoveOneAsynchronous(ReconfigTest.java:436) > at > > org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79) > > FAILED > Waiting for server down > junit.framework.AssertionFailedError: Waiting for server down > at > org.apache.zookeeper.test.QuorumUtil.shutdownAll(QuorumUtil.java:241) > at > org.apache.zookeeper.test.QuorumUtil.tearDown(QuorumUtil.java:306) > at > org.apache.zookeeper.test.ReconfigTest.tearDown(ReconfigTest.java:64) > > Both of these say they're waiting for server down. The logs are not > particularly helpful. However, this does not fail in the earlier version of > this code for me. > > I'm going to abstain from voting on this release, don't think I have the > setup to accommodate even testing the java environment in a way that will > be satisfactory for me given this incongruence. I suspect the problem is > netty-related and not ZK but I don't have the time to keep fussing with > this right now. > > C > > > On Thu, Jul 7, 2016 at 12:01 PM, Flavio P JUNQUEIRA > wrote: > > > It has been passing for me and I have a macbook too, but clearly doesn't > > mean there is nothing wrong with the test. You may want to upload logs so > > that we can have a look. > > > > -Flavio > > On 7 Jul 2016 4:40 p.m., "Camille Fournier" wrote: > > > > > NioNettySuiteTest also regularly fails with this release. Can anyone > > > confirm if this is an env issue? > > > > > > On Thu, Jul 7, 2016 at 11:36 AM, Camille Fournier > > > wrote: > > > > > > > The NettyNettySuiteTest fails regularly for me in this release and > does > > > > not fail in 3.5.1. Is this macbook specific? > > > > > > > > On Thu, Jul 7, 2016 at 11:17 AM, Raúl Gutiérrez Segalés < > > > > r...@itevenworks.net> wrote: > > > > > > > >> I'll cast my vote today, after I see this behave for a while at a > > > staging > > > >> cluster at work. > > > >> > > > >> Sorry for the lag. > > > >> > > > >> -rgs > > > >> On Jul 7, 2016 12:58 AM, "Flavio P JUNQUEIRA" > wrote: > > > >> > > > >> Hey PMC, > > > >> > > > >> Where are your votes? > > > >> > > > >> -Flavio > > > >> On 7 Jul 2016 5:51 a.m., "Chris Nauroth" > > > >> wrote: > > > >> > > > >> > I need to leave for vacation now. Unfortunately, the binding > votes > > > have > > > >> > not rolled in, so I won't be able to complete the release process > > > >> before I > > > >> > leave. I'll be available again on Monday, 7/18. I can pick up > the > > > work > > > >> > then. Alternatively, if the votes comes in during my absence and > > > >> someone > > > >> > else wants to complete the release, please feel free. If we go > that > > > >> way, > > > >> > then I could potentially pick up 3.5.3 release manager duties from > > > >> Patrick > > > >> > to make up for it. > > > >> > > > > >> > --Chris Nauroth > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > On 7/6/16, 8:51 AM, "Chris Nauroth" > > wrote: > > > >> > > > > >> > >With inclusion of my own +1 (non-binding), the current tally on > the > > > >> > >[VOTE] for release 3.5.2-alpha candidate 1 is: > > > >> > > > > > >> > >1 +1 (binding) > > > >> > >4 +1 (non-binding) > > > >> > > > > > >> > >Can we please have 2 more PMC members cast a binding vote to push > > > this > > > >> > >[VOTE] to completion? Thank you. > > > >> > > > > > >> > >--Chris Nauroth > > > >> > > > > >> > > > > >> > > > > > > > > > > > > > > -- Cheers Michael.
ZooKeeper release validation cluster access
So I'm working with the CNCF to see about getting cluster access to spin up ZK clusters for release validation. I was wondering if anyone has scripts for deploying and configuring ZK clusters quickly for stress testing that we could use if we get this access? I'm sure some of you in the community must do some of this internally. I would also very much appreciate any volunteers to contribute to making better public release validation work, if possible, since it's unclear how much time I personally will be able to dedicate to this effort beyond getting access to the cluster. Thanks, C
ZooKeeper_branch35_solaris - Build # 163 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch35_solaris/163/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 117677 lines...] [junit] 2016-07-07 16:58:29,878 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testOverwriteFile [junit] 2016-07-07 16:58:30,027 [myid:] - INFO [main:ZKTestCase$1@65] - SUCCEEDED testOverwriteFile [junit] 2016-07-07 16:58:30,027 [myid:] - INFO [main:ZKTestCase$1@60] - FINISHED testOverwriteFile [junit] 2016-07-07 16:58:30,062 [myid:] - INFO [main:ZKTestCase$1@55] - STARTING testAbortNewFileAfterFlush [junit] 2016-07-07 16:58:30,155 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@77] - RUNNING TEST METHOD testAbortNewFileAfterFlush [junit] 2016-07-07 16:58:30,156 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 12239 [junit] 2016-07-07 16:58:30,156 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 4 [junit] 2016-07-07 16:58:30,156 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testAbortNewFileAfterFlush [junit] 2016-07-07 16:58:30,204 [myid:] - INFO [main:ZKTestCase$1@65] - SUCCEEDED testAbortNewFileAfterFlush [junit] 2016-07-07 16:58:30,204 [myid:] - INFO [main:ZKTestCase$1@60] - FINISHED testAbortNewFileAfterFlush [junit] 2016-07-07 16:58:30,207 [myid:] - INFO [main:ZKTestCase$1@55] - STARTING testAbortNewFile [junit] 2016-07-07 16:58:30,207 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@77] - RUNNING TEST METHOD testAbortNewFile [junit] 2016-07-07 16:58:30,207 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 12239 [junit] 2016-07-07 16:58:30,208 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 4 [junit] 2016-07-07 16:58:30,208 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testAbortNewFile [junit] 2016-07-07 16:58:30,246 [myid:] - INFO [main:ZKTestCase$1@65] - SUCCEEDED testAbortNewFile [junit] 2016-07-07 16:58:30,246 [myid:] - INFO [main:ZKTestCase$1@60] - FINISHED testAbortNewFile [junit] 2016-07-07 16:58:30,246 [myid:] - INFO [main:ZKTestCase$1@55] - STARTING testAbortExistingFileAfterFlush [junit] 2016-07-07 16:58:30,247 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@77] - RUNNING TEST METHOD testAbortExistingFileAfterFlush [junit] 2016-07-07 16:58:30,247 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 12577 [junit] 2016-07-07 16:58:30,247 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 4 [junit] 2016-07-07 16:58:30,248 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testAbortExistingFileAfterFlush [junit] 2016-07-07 16:58:30,268 [myid:] - INFO [main:ZKTestCase$1@65] - SUCCEEDED testAbortExistingFileAfterFlush [junit] 2016-07-07 16:58:30,268 [myid:] - INFO [main:ZKTestCase$1@60] - FINISHED testAbortExistingFileAfterFlush [junit] 2016-07-07 16:58:30,269 [myid:] - INFO [main:ZKTestCase$1@55] - STARTING testAbortExistingFile [junit] 2016-07-07 16:58:30,269 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@77] - RUNNING TEST METHOD testAbortExistingFile [junit] 2016-07-07 16:58:30,269 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 12577 [junit] 2016-07-07 16:58:30,270 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 4 [junit] 2016-07-07 16:58:30,270 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testAbortExistingFile [junit] 2016-07-07 16:58:30,284 [myid:] - INFO [main:ZKTestCase$1@65] - SUCCEEDED testAbortExistingFile [junit] 2016-07-07 16:58:30,284 [myid:] - INFO [main:ZKTestCase$1@60] - FINISHED testAbortExistingFile [junit] 2016-07-07 16:58:30,285 [myid:] - INFO [main:ZKTestCase$1@55] - STARTING testWriteNewFile [junit] 2016-07-07 16:58:30,285 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@77] - RUNNING TEST METHOD testWriteNewFile [junit] 2016-07-07 16:58:30,287 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 12577 [junit] 2016-07-07 16:58:30,287 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 4 [junit] 2016-07-07 16:58:30,287 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testWriteNewFile [junit] 2016-07-07 16:58:30,288 [myid:] - INFO [main:ZKTestCase$1@65] - SUCCEEDED testWriteNewFile [junit] 2016-07-07 16:58:30,288 [myid:] - INFO [main:ZKTestCase$1@60] - FINISHED testWriteNewFile [junit] 2016-07-07
Re: Status: Apache ZooKeeper release 3.5.2-alpha candidate 1
Testcase: testRemoveOneAsynchronous took 60.235 sec FAILED Waiting for server down junit.framework.AssertionFailedError: Waiting for server down at org.apache.zookeeper.test.QuorumUtil.shutdownAll(QuorumUtil.java:241) at org.apache.zookeeper.test.QuorumUtil.startAll(QuorumUtil.java:143) at org.apache.zookeeper.test.ReconfigTest.testRemoveOneAsynchronous(ReconfigTest.java:436) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79) FAILED Waiting for server down junit.framework.AssertionFailedError: Waiting for server down at org.apache.zookeeper.test.QuorumUtil.shutdownAll(QuorumUtil.java:241) at org.apache.zookeeper.test.QuorumUtil.tearDown(QuorumUtil.java:306) at org.apache.zookeeper.test.ReconfigTest.tearDown(ReconfigTest.java:64) Both of these say they're waiting for server down. The logs are not particularly helpful. However, this does not fail in the earlier version of this code for me. I'm going to abstain from voting on this release, don't think I have the setup to accommodate even testing the java environment in a way that will be satisfactory for me given this incongruence. I suspect the problem is netty-related and not ZK but I don't have the time to keep fussing with this right now. C On Thu, Jul 7, 2016 at 12:01 PM, Flavio P JUNQUEIRA wrote: > It has been passing for me and I have a macbook too, but clearly doesn't > mean there is nothing wrong with the test. You may want to upload logs so > that we can have a look. > > -Flavio > On 7 Jul 2016 4:40 p.m., "Camille Fournier" wrote: > > > NioNettySuiteTest also regularly fails with this release. Can anyone > > confirm if this is an env issue? > > > > On Thu, Jul 7, 2016 at 11:36 AM, Camille Fournier > > wrote: > > > > > The NettyNettySuiteTest fails regularly for me in this release and does > > > not fail in 3.5.1. Is this macbook specific? > > > > > > On Thu, Jul 7, 2016 at 11:17 AM, Raúl Gutiérrez Segalés < > > > r...@itevenworks.net> wrote: > > > > > >> I'll cast my vote today, after I see this behave for a while at a > > staging > > >> cluster at work. > > >> > > >> Sorry for the lag. > > >> > > >> -rgs > > >> On Jul 7, 2016 12:58 AM, "Flavio P JUNQUEIRA" wrote: > > >> > > >> Hey PMC, > > >> > > >> Where are your votes? > > >> > > >> -Flavio > > >> On 7 Jul 2016 5:51 a.m., "Chris Nauroth" > > >> wrote: > > >> > > >> > I need to leave for vacation now. Unfortunately, the binding votes > > have > > >> > not rolled in, so I won't be able to complete the release process > > >> before I > > >> > leave. I'll be available again on Monday, 7/18. I can pick up the > > work > > >> > then. Alternatively, if the votes comes in during my absence and > > >> someone > > >> > else wants to complete the release, please feel free. If we go that > > >> way, > > >> > then I could potentially pick up 3.5.3 release manager duties from > > >> Patrick > > >> > to make up for it. > > >> > > > >> > --Chris Nauroth > > >> > > > >> > > > >> > > > >> > > > >> > On 7/6/16, 8:51 AM, "Chris Nauroth" > wrote: > > >> > > > >> > >With inclusion of my own +1 (non-binding), the current tally on the > > >> > >[VOTE] for release 3.5.2-alpha candidate 1 is: > > >> > > > > >> > >1 +1 (binding) > > >> > >4 +1 (non-binding) > > >> > > > > >> > >Can we please have 2 more PMC members cast a binding vote to push > > this > > >> > >[VOTE] to completion? Thank you. > > >> > > > > >> > >--Chris Nauroth > > >> > > > >> > > > >> > > > > > > > > >
Re: Status: Apache ZooKeeper release 3.5.2-alpha candidate 1
It has been passing for me and I have a macbook too, but clearly doesn't mean there is nothing wrong with the test. You may want to upload logs so that we can have a look. -Flavio On 7 Jul 2016 4:40 p.m., "Camille Fournier" wrote: > NioNettySuiteTest also regularly fails with this release. Can anyone > confirm if this is an env issue? > > On Thu, Jul 7, 2016 at 11:36 AM, Camille Fournier > wrote: > > > The NettyNettySuiteTest fails regularly for me in this release and does > > not fail in 3.5.1. Is this macbook specific? > > > > On Thu, Jul 7, 2016 at 11:17 AM, Raúl Gutiérrez Segalés < > > r...@itevenworks.net> wrote: > > > >> I'll cast my vote today, after I see this behave for a while at a > staging > >> cluster at work. > >> > >> Sorry for the lag. > >> > >> -rgs > >> On Jul 7, 2016 12:58 AM, "Flavio P JUNQUEIRA" wrote: > >> > >> Hey PMC, > >> > >> Where are your votes? > >> > >> -Flavio > >> On 7 Jul 2016 5:51 a.m., "Chris Nauroth" > >> wrote: > >> > >> > I need to leave for vacation now. Unfortunately, the binding votes > have > >> > not rolled in, so I won't be able to complete the release process > >> before I > >> > leave. I'll be available again on Monday, 7/18. I can pick up the > work > >> > then. Alternatively, if the votes comes in during my absence and > >> someone > >> > else wants to complete the release, please feel free. If we go that > >> way, > >> > then I could potentially pick up 3.5.3 release manager duties from > >> Patrick > >> > to make up for it. > >> > > >> > --Chris Nauroth > >> > > >> > > >> > > >> > > >> > On 7/6/16, 8:51 AM, "Chris Nauroth" wrote: > >> > > >> > >With inclusion of my own +1 (non-binding), the current tally on the > >> > >[VOTE] for release 3.5.2-alpha candidate 1 is: > >> > > > >> > >1 +1 (binding) > >> > >4 +1 (non-binding) > >> > > > >> > >Can we please have 2 more PMC members cast a binding vote to push > this > >> > >[VOTE] to completion? Thank you. > >> > > > >> > >--Chris Nauroth > >> > > >> > > >> > > > > >
Re: Status: Apache ZooKeeper release 3.5.2-alpha candidate 1
NioNettySuiteTest failed on my dev box too. Edward Em 07/07/2016 12:40, "Camille Fournier" escreveu: > NioNettySuiteTest also regularly fails with this release. Can anyone > confirm if this is an env issue? > > On Thu, Jul 7, 2016 at 11:36 AM, Camille Fournier > wrote: > > > The NettyNettySuiteTest fails regularly for me in this release and does > > not fail in 3.5.1. Is this macbook specific? > > > > On Thu, Jul 7, 2016 at 11:17 AM, Raúl Gutiérrez Segalés < > > r...@itevenworks.net> wrote: > > > >> I'll cast my vote today, after I see this behave for a while at a > staging > >> cluster at work. > >> > >> Sorry for the lag. > >> > >> -rgs > >> On Jul 7, 2016 12:58 AM, "Flavio P JUNQUEIRA" wrote: > >> > >> Hey PMC, > >> > >> Where are your votes? > >> > >> -Flavio > >> On 7 Jul 2016 5:51 a.m., "Chris Nauroth" > >> wrote: > >> > >> > I need to leave for vacation now. Unfortunately, the binding votes > have > >> > not rolled in, so I won't be able to complete the release process > >> before I > >> > leave. I'll be available again on Monday, 7/18. I can pick up the > work > >> > then. Alternatively, if the votes comes in during my absence and > >> someone > >> > else wants to complete the release, please feel free. If we go that > >> way, > >> > then I could potentially pick up 3.5.3 release manager duties from > >> Patrick > >> > to make up for it. > >> > > >> > --Chris Nauroth > >> > > >> > > >> > > >> > > >> > On 7/6/16, 8:51 AM, "Chris Nauroth" wrote: > >> > > >> > >With inclusion of my own +1 (non-binding), the current tally on the > >> > >[VOTE] for release 3.5.2-alpha candidate 1 is: > >> > > > >> > >1 +1 (binding) > >> > >4 +1 (non-binding) > >> > > > >> > >Can we please have 2 more PMC members cast a binding vote to push > this > >> > >[VOTE] to completion? Thank you. > >> > > > >> > >--Chris Nauroth > >> > > >> > > >> > > > > >
Re: Status: Apache ZooKeeper release 3.5.2-alpha candidate 1
NioNettySuiteTest also regularly fails with this release. Can anyone confirm if this is an env issue? On Thu, Jul 7, 2016 at 11:36 AM, Camille Fournier wrote: > The NettyNettySuiteTest fails regularly for me in this release and does > not fail in 3.5.1. Is this macbook specific? > > On Thu, Jul 7, 2016 at 11:17 AM, Raúl Gutiérrez Segalés < > r...@itevenworks.net> wrote: > >> I'll cast my vote today, after I see this behave for a while at a staging >> cluster at work. >> >> Sorry for the lag. >> >> -rgs >> On Jul 7, 2016 12:58 AM, "Flavio P JUNQUEIRA" wrote: >> >> Hey PMC, >> >> Where are your votes? >> >> -Flavio >> On 7 Jul 2016 5:51 a.m., "Chris Nauroth" >> wrote: >> >> > I need to leave for vacation now. Unfortunately, the binding votes have >> > not rolled in, so I won't be able to complete the release process >> before I >> > leave. I'll be available again on Monday, 7/18. I can pick up the work >> > then. Alternatively, if the votes comes in during my absence and >> someone >> > else wants to complete the release, please feel free. If we go that >> way, >> > then I could potentially pick up 3.5.3 release manager duties from >> Patrick >> > to make up for it. >> > >> > --Chris Nauroth >> > >> > >> > >> > >> > On 7/6/16, 8:51 AM, "Chris Nauroth" wrote: >> > >> > >With inclusion of my own +1 (non-binding), the current tally on the >> > >[VOTE] for release 3.5.2-alpha candidate 1 is: >> > > >> > >1 +1 (binding) >> > >4 +1 (non-binding) >> > > >> > >Can we please have 2 more PMC members cast a binding vote to push this >> > >[VOTE] to completion? Thank you. >> > > >> > >--Chris Nauroth >> > >> > >> > >
Re: Status: Apache ZooKeeper release 3.5.2-alpha candidate 1
The NettyNettySuiteTest fails regularly for me in this release and does not fail in 3.5.1. Is this macbook specific? On Thu, Jul 7, 2016 at 11:17 AM, Raúl Gutiérrez Segalés wrote: > I'll cast my vote today, after I see this behave for a while at a staging > cluster at work. > > Sorry for the lag. > > -rgs > On Jul 7, 2016 12:58 AM, "Flavio P JUNQUEIRA" wrote: > > Hey PMC, > > Where are your votes? > > -Flavio > On 7 Jul 2016 5:51 a.m., "Chris Nauroth" wrote: > > > I need to leave for vacation now. Unfortunately, the binding votes have > > not rolled in, so I won't be able to complete the release process before > I > > leave. I'll be available again on Monday, 7/18. I can pick up the work > > then. Alternatively, if the votes comes in during my absence and someone > > else wants to complete the release, please feel free. If we go that way, > > then I could potentially pick up 3.5.3 release manager duties from > Patrick > > to make up for it. > > > > --Chris Nauroth > > > > > > > > > > On 7/6/16, 8:51 AM, "Chris Nauroth" wrote: > > > > >With inclusion of my own +1 (non-binding), the current tally on the > > >[VOTE] for release 3.5.2-alpha candidate 1 is: > > > > > >1 +1 (binding) > > >4 +1 (non-binding) > > > > > >Can we please have 2 more PMC members cast a binding vote to push this > > >[VOTE] to completion? Thank you. > > > > > >--Chris Nauroth > > > > >
ZooKeeper_branch34_openjdk7 - Build # 1130 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1130/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 206043 lines...] [junit] 2016-07-07 15:23:04,551 [myid:] - INFO [main:JMXEnv@246] - expect:StandaloneServer_port [junit] 2016-07-07 15:23:04,551 [myid:] - INFO [main:JMXEnv@250] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11221 [junit] 2016-07-07 15:23:04,551 [myid:] - INFO [main:ClientBase@490] - STOPPING server [junit] 2016-07-07 15:23:04,552 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@219] - NIOServerCnxn factory exited run method [junit] 2016-07-07 15:23:04,552 [myid:] - INFO [main:ZooKeeperServer@469] - shutting down [junit] 2016-07-07 15:23:04,552 [myid:] - INFO [main:SessionTrackerImpl@225] - Shutting down [junit] 2016-07-07 15:23:04,552 [myid:] - INFO [main:PrepRequestProcessor@765] - Shutting down [junit] 2016-07-07 15:23:04,553 [myid:] - INFO [main:SyncRequestProcessor@209] - Shutting down [junit] 2016-07-07 15:23:04,553 [myid:] - INFO [ProcessThread(sid:0 cport:11221)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop! [junit] 2016-07-07 15:23:04,553 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@187] - SyncRequestProcessor exited! [junit] 2016-07-07 15:23:04,553 [myid:] - INFO [main:FinalRequestProcessor@402] - shutdown of request processor complete [junit] 2016-07-07 15:23:04,554 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221 [junit] 2016-07-07 15:23:04,555 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2016-07-07 15:23:04,556 [myid:] - INFO [main:ClientBase@443] - STARTING server [junit] 2016-07-07 15:23:04,556 [myid:] - INFO [main:ClientBase@364] - CREATING server instance 127.0.0.1:11221 [junit] 2016-07-07 15:23:04,557 [myid:] - INFO [main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2016-07-07 15:23:04,557 [myid:] - INFO [main:ClientBase@339] - STARTING server instance 127.0.0.1:11221 [junit] 2016-07-07 15:23:04,558 [myid:] - INFO [main:ZooKeeperServer@170] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /x1/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/branch-3.4/build/test/tmp/test2002352367973711081.junit.dir/version-2 snapdir /x1/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/branch-3.4/build/test/tmp/test2002352367973711081.junit.dir/version-2 [junit] 2016-07-07 15:23:04,563 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221 [junit] 2016-07-07 15:23:04,563 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - Accepted socket connection from /127.0.0.1:54774 [junit] 2016-07-07 15:23:04,564 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing stat command from /127.0.0.1:54774 [junit] 2016-07-07 15:23:04,564 [myid:] - INFO [Thread-4:NIOServerCnxn$StatCommand@663] - Stat command output [junit] 2016-07-07 15:23:04,565 [myid:] - INFO [Thread-4:NIOServerCnxn@1008] - Closed socket connection for client /127.0.0.1:54774 (no session established for client) [junit] 2016-07-07 15:23:04,565 [myid:] - INFO [main:JMXEnv@229] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2016-07-07 15:23:04,567 [myid:] - INFO [main:JMXEnv@246] - expect:InMemoryDataTree [junit] 2016-07-07 15:23:04,568 [myid:] - INFO [main:JMXEnv@250] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree [junit] 2016-07-07 15:23:04,568 [myid:] - INFO [main:JMXEnv@246] - expect:StandaloneServer_port [junit] 2016-07-07 15:23:04,568 [myid:] - INFO [main:JMXEnv@250] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11221 [junit] 2016-07-07 15:23:04,569 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 26415 [junit] 2016-07-07 15:23:04,569 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20 [junit] 2016-07-07 15:23:04,569 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota [junit] 2016-07-07 15:23:04,569 [myid:] - INFO [main:ClientBase@520] - tearDown starting [junit] 2016-07-07 15:23:04,634 [myid:] - INFO [main:ZooKeeper@684] - Session: 0x155c5f484af closed [junit] 2016-07-07 15:23:04,634 [myid:] - INFO [main:ClientBase@490] - STOPPING server [junit] 2016-07-07 15:23:04,634 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@519] - EventThread shut down for session: 0x155c5f484af [junit] 2016-07-07 15:23:04,635 [myid:] - INFO [N
Re: Status: Apache ZooKeeper release 3.5.2-alpha candidate 1
I'll cast my vote today, after I see this behave for a while at a staging cluster at work. Sorry for the lag. -rgs On Jul 7, 2016 12:58 AM, "Flavio P JUNQUEIRA" wrote: Hey PMC, Where are your votes? -Flavio On 7 Jul 2016 5:51 a.m., "Chris Nauroth" wrote: > I need to leave for vacation now. Unfortunately, the binding votes have > not rolled in, so I won't be able to complete the release process before I > leave. I'll be available again on Monday, 7/18. I can pick up the work > then. Alternatively, if the votes comes in during my absence and someone > else wants to complete the release, please feel free. If we go that way, > then I could potentially pick up 3.5.3 release manager duties from Patrick > to make up for it. > > --Chris Nauroth > > > > > On 7/6/16, 8:51 AM, "Chris Nauroth" wrote: > > >With inclusion of my own +1 (non-binding), the current tally on the > >[VOTE] for release 3.5.2-alpha candidate 1 is: > > > >1 +1 (binding) > >4 +1 (non-binding) > > > >Can we please have 2 more PMC members cast a binding vote to push this > >[VOTE] to completion? Thank you. > > > >--Chris Nauroth > >
[jira] [Commented] (ZOOKEEPER-451) ZK should enforce quota
[ https://issues.apache.org/jira/browse/ZOOKEEPER-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366234#comment-15366234 ] Botond Hejj commented on ZOOKEEPER-451: --- Thanks for the comment Edward. I've made modifications based on your comment: - renamed the option to "enforceQuotaLimit" - fix the typo in zookeeper.c - Added documentation for the new option - Print the limit and stat in ZooKeeperMain on quota exceed > ZK should enforce quota > --- > > Key: ZOOKEEPER-451 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-451 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.2.0 >Reporter: Raghu S >Assignee: Botond Hejj > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-451.patch, ZOOKEEPER-451.patch > > > Email exchange with Mahadev: > Mahadev Konar wrote: > > Hi Raghu, > > We do have plans to enforce quota in future. Enforcing requires some more > > work then just reporting. Reporting is a good enough tool for operations to > > manage a zookeeper cluster but we would certainly like to enforce it in the > > near future. > > > > Thanks > > mahadev > > > > > > On 6/18/09 7:01 PM, "rag...@yahoo.com" wrote: > > > >> Is there a reason why node count/byte quota is not actually enforced but > >> rather ZK just warns? Are there any plans to enforce the quota in a future > >> release? > >> > >> Thanks > >> Raghu > >> > >> > >> > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-451) ZK should enforce quota
[ https://issues.apache.org/jira/browse/ZOOKEEPER-451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Botond Hejj updated ZOOKEEPER-451: -- Attachment: ZOOKEEPER-451.patch > ZK should enforce quota > --- > > Key: ZOOKEEPER-451 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-451 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.2.0 >Reporter: Raghu S >Assignee: Botond Hejj > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-451.patch, ZOOKEEPER-451.patch > > > Email exchange with Mahadev: > Mahadev Konar wrote: > > Hi Raghu, > > We do have plans to enforce quota in future. Enforcing requires some more > > work then just reporting. Reporting is a good enough tool for operations to > > manage a zookeeper cluster but we would certainly like to enforce it in the > > near future. > > > > Thanks > > mahadev > > > > > > On 6/18/09 7:01 PM, "rag...@yahoo.com" wrote: > > > >> Is there a reason why node count/byte quota is not actually enforced but > >> rather ZK just warns? Are there any plans to enforce the quota in a future > >> release? > >> > >> Thanks > >> Raghu > >> > >> > >> > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Status: Apache ZooKeeper release 3.5.2-alpha candidate 1
Yeah, the bind test also fails for me consistently, ZK-1256 did not solve it. I don't get any other junit test failures, though. -Flavio > On 07 Jul 2016, at 14:46, Camille Fournier wrote: > > I'm working on it, but I've got test failures here because we have so many > flaky tests, and I can't tell if this is just our standard level of fucked > up tests or something new, or something in my setup, or what. But beyond > the bind test which always fails when I run it on my macbook, the netty > suites are failing. I'm pretty close to giving this a -1 for that reason > alone. > > On Thu, Jul 7, 2016 at 3:58 AM, Flavio P JUNQUEIRA wrote: > >> Hey PMC, >> >> Where are your votes? >> >> -Flavio >> On 7 Jul 2016 5:51 a.m., "Chris Nauroth" wrote: >> >>> I need to leave for vacation now. Unfortunately, the binding votes have >>> not rolled in, so I won't be able to complete the release process before >> I >>> leave. I'll be available again on Monday, 7/18. I can pick up the work >>> then. Alternatively, if the votes comes in during my absence and someone >>> else wants to complete the release, please feel free. If we go that way, >>> then I could potentially pick up 3.5.3 release manager duties from >> Patrick >>> to make up for it. >>> >>> --Chris Nauroth >>> >>> >>> >>> >>> On 7/6/16, 8:51 AM, "Chris Nauroth" wrote: >>> With inclusion of my own +1 (non-binding), the current tally on the [VOTE] for release 3.5.2-alpha candidate 1 is: 1 +1 (binding) 4 +1 (non-binding) Can we please have 2 more PMC members cast a binding vote to push this [VOTE] to completion? Thank you. --Chris Nauroth >>> >>> >>
ZooKeeper_branch34_solaris - Build # 1210 - Failure
See https://builds.apache.org/job/ZooKeeper_branch34_solaris/1210/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 117406 lines...] [junit] 2016-07-07 13:54:29,308 [myid:] - INFO [main:FinalRequestProcessor@402] - shutdown of request processor complete [junit] 2016-07-07 13:54:29,309 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11291 [junit] 2016-07-07 13:54:29,310 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2016-07-07 13:54:29,411 [myid:] - INFO [main:ClientBase@443] - STARTING server [junit] 2016-07-07 13:54:29,412 [myid:] - INFO [main:ClientBase@364] - CREATING server instance 127.0.0.1:11291 [junit] 2016-07-07 13:54:29,419 [myid:] - INFO [main:ClientBase@339] - STARTING server instance 127.0.0.1:11291 [junit] 2016-07-07 13:54:29,440 [myid:] - INFO [main:ZooKeeperServer@170] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/trunk/build/test/tmp/test5352993225679641378.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/trunk/build/test/tmp/test5352993225679641378.junit.dir/version-2 [junit] 2016-07-07 13:54:29,440 [myid:] - INFO [main:NettyServerCnxnFactory@365] - binding to port 0.0.0.0/0.0.0.0:11291 [junit] 2016-07-07 13:54:29,443 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11291 [junit] 2016-07-07 13:54:29,451 [myid:] - INFO [New I/O worker #1548:NettyServerCnxn@632] - Processing stat command from /127.0.0.1:42462 [junit] 2016-07-07 13:54:29,451 [myid:] - INFO [New I/O worker #1548:NettyServerCnxn$StatCommand@469] - Stat command output [junit] 2016-07-07 13:54:29,451 [myid:] - INFO [main:JMXEnv@229] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2016-07-07 13:54:29,453 [myid:] - INFO [main:JMXEnv@246] - expect:InMemoryDataTree [junit] 2016-07-07 13:54:29,453 [myid:] - INFO [main:JMXEnv@250] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11291,name1=InMemoryDataTree [junit] 2016-07-07 13:54:29,453 [myid:] - INFO [main:JMXEnv@246] - expect:StandaloneServer_port [junit] 2016-07-07 13:54:29,453 [myid:] - INFO [main:JMXEnv@250] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11291 [junit] 2016-07-07 13:54:30,001 [myid:] - INFO [SessionTracker:SessionTrackerImpl@162] - SessionTrackerImpl exited loop! [junit] 2016-07-07 13:54:30,001 [myid:] - INFO [SessionTracker:SessionTrackerImpl@162] - SessionTrackerImpl exited loop! [junit] 2016-07-07 13:54:30,551 [myid:] - INFO [main-SendThread(127.0.0.1:11291):ClientCnxn$SendThread@1032] - Opening socket connection to server 127.0.0.1/127.0.0.1:11291. Will not attempt to authenticate using SASL (java.lang.SecurityException: Unable to locate a login configuration) [junit] 2016-07-07 13:54:30,551 [myid:] - INFO [main-SendThread(127.0.0.1:11291):ClientCnxn$SendThread@876] - Socket connection established to 127.0.0.1/127.0.0.1:11291, initiating session [junit] 2016-07-07 13:54:30,552 [myid:] - INFO [New I/O worker #1549:ZooKeeperServer@893] - Client attempting to renew session 0x155c5a36166 at /127.0.0.1:42463 [junit] 2016-07-07 13:54:30,552 [myid:] - INFO [New I/O worker #1549:ZooKeeperServer@645] - Established session 0x155c5a36166 with negotiated timeout 6000 for client /127.0.0.1:42463 [junit] 2016-07-07 13:54:30,553 [myid:] - INFO [main-SendThread(127.0.0.1:11291):ClientCnxn$SendThread@1299] - Session establishment complete on server 127.0.0.1/127.0.0.1:11291, sessionid = 0x155c5a36166, negotiated timeout = 6000 [junit] 2016-07-07 13:54:30,553 [myid:] - INFO [SyncThread:0:FileTxnLog@203] - Creating new log file: log.7 [junit] 2016-07-07 13:54:31,581 [myid:] - INFO [ProcessThread(sid:0 cport:11291)::PrepRequestProcessor@487] - Processed session termination for sessionid: 0x155c5a36166 [junit] 2016-07-07 13:54:31,583 [myid:] - INFO [main:ZooKeeper@684] - Session: 0x155c5a36166 closed [junit] 2016-07-07 13:54:31,583 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 18081 [junit] 2016-07-07 13:54:31,583 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 37 [junit] 2016-07-07 13:54:31,583 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testWatcherAutoResetDisabledWithLocal [junit] 2016-07-07 13:54:31,583 [myid:] - INFO [main:ClientBase@520] - tearDown starting [junit] 2016-07-07 13:54:31,583 [myid:] - INFO [main:ClientBase@490] - STOPPING server [junit] 2016-07-07 13:54:31,583 [m
Re: Status: Apache ZooKeeper release 3.5.2-alpha candidate 1
I'm working on it, but I've got test failures here because we have so many flaky tests, and I can't tell if this is just our standard level of fucked up tests or something new, or something in my setup, or what. But beyond the bind test which always fails when I run it on my macbook, the netty suites are failing. I'm pretty close to giving this a -1 for that reason alone. On Thu, Jul 7, 2016 at 3:58 AM, Flavio P JUNQUEIRA wrote: > Hey PMC, > > Where are your votes? > > -Flavio > On 7 Jul 2016 5:51 a.m., "Chris Nauroth" wrote: > > > I need to leave for vacation now. Unfortunately, the binding votes have > > not rolled in, so I won't be able to complete the release process before > I > > leave. I'll be available again on Monday, 7/18. I can pick up the work > > then. Alternatively, if the votes comes in during my absence and someone > > else wants to complete the release, please feel free. If we go that way, > > then I could potentially pick up 3.5.3 release manager duties from > Patrick > > to make up for it. > > > > --Chris Nauroth > > > > > > > > > > On 7/6/16, 8:51 AM, "Chris Nauroth" wrote: > > > > >With inclusion of my own +1 (non-binding), the current tally on the > > >[VOTE] for release 3.5.2-alpha candidate 1 is: > > > > > >1 +1 (binding) > > >4 +1 (non-binding) > > > > > >Can we please have 2 more PMC members cast a binding vote to push this > > >[VOTE] to completion? Thank you. > > > > > >--Chris Nauroth > > > > >
Re: ZooKeeper 3.4.9 release discussion
Thanks for bootstrapping the release process for 3.4.9. ZK-1045 is a major change and I suggest we give time for folks to try it out before cutting a release candidate. Ideally, we check it in and give a few weeks until we cut a release candidate. One of the blockers, ZK-2314 has only one remaining task which is to document missing SASL properties, so that should be easy. The other one, ZK-2383, needs work. Folks should check the remaining issues to determine if there is any other blocker that we missed in that list. -Flavio > On 07 Jul 2016, at 05:12, Rakesh Radhakrishnan wrote: > > Hi All, > > I am interested in going through the release process as the RM. > > I could see total 23 issues marked for 3.4.9 release as of now, which > includes 2 blockers, 6 critical, 12 major and 3 minor issues. I count 15 > issues fixed/committed already for 3.4.9 which includes 6 blockers and 2 > critical(security related) issues. I think it is a good time to initiate > the discussion of 3.4.9 release processes. > > Please find the open issues here, https://goo.gl/SEliwm > > Currently, I'm focusing on ZOOKEEPER-1045 sasl feature which I think is > much appreciated/awaited feature and I'd like to include this if everyone > agrees. Appreciate help in reviewing/testing the patch and making it stable > for release. Also, please feel free to push your favorite issues ahead of > 3.4.9 release. > > I hope we should be able to close all blockers and critical issues in a > month. Kindly requesting everyone to look at the issues marked for 3.4.9 > and push these asap or can be pushed out to 3.4.10. I will focus my code > review time on these. > > Please let me know your thoughts on the plan. > > Thanks, > Rakesh
ZooKeeper-trunk-solaris - Build # 1222 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1222/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 426924 lines...] [junit] 2016-07-07 08:39:29,003 [myid:] - INFO [main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 kB direct buffers. [junit] 2016-07-07 08:39:29,004 [myid:] - INFO [main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222 [junit] 2016-07-07 08:39:29,004 [myid:] - INFO [main:ClientBase@361] - STARTING server instance 127.0.0.1:11222 [junit] 2016-07-07 08:39:29,004 [myid:] - INFO [main:ZooKeeperServer@858] - minSessionTimeout set to 6000 [junit] 2016-07-07 08:39:29,005 [myid:] - INFO [main:ZooKeeperServer@867] - maxSessionTimeout set to 6 [junit] 2016-07-07 08:39:29,005 [myid:] - INFO [main:ZooKeeperServer@156] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test5972214294755801585.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test5972214294755801585.junit.dir/version-2 [junit] 2016-07-07 08:39:29,005 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test5972214294755801585.junit.dir/version-2/snapshot.b [junit] 2016-07-07 08:39:29,007 [myid:] - INFO [main:FileTxnSnapLog@298] - Snapshotting: 0xb to /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test5972214294755801585.junit.dir/version-2/snapshot.b [junit] 2016-07-07 08:39:29,009 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222 [junit] 2016-07-07 08:39:29,009 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:37531 [junit] 2016-07-07 08:39:29,010 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from /127.0.0.1:37531 [junit] 2016-07-07 08:39:29,011 [myid:] - INFO [NIOWorkerThread-1:StatCommand@49] - Stat command output [junit] 2016-07-07 08:39:29,011 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client /127.0.0.1:37531 (no session established for client) [junit] 2016-07-07 08:39:29,011 [myid:] - INFO [main:JMXEnv@228] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2016-07-07 08:39:29,013 [myid:] - INFO [main:JMXEnv@245] - expect:InMemoryDataTree [junit] 2016-07-07 08:39:29,013 [myid:] - INFO [main:JMXEnv@249] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree [junit] 2016-07-07 08:39:29,013 [myid:] - INFO [main:JMXEnv@245] - expect:StandaloneServer_port [junit] 2016-07-07 08:39:29,013 [myid:] - INFO [main:JMXEnv@249] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11222 [junit] 2016-07-07 08:39:29,013 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17717 [junit] 2016-07-07 08:39:29,014 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24 [junit] 2016-07-07 08:39:29,014 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testQuota [junit] 2016-07-07 08:39:29,014 [myid:] - INFO [main:ClientBase@543] - tearDown starting [junit] 2016-07-07 08:39:29,072 [myid:] - INFO [main:ZooKeeper@1313] - Session: 0x122417f6cae closed [junit] 2016-07-07 08:39:29,072 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x122417f6cae [junit] 2016-07-07 08:39:29,072 [myid:] - INFO [main:ClientBase@513] - STOPPING server [junit] 2016-07-07 08:39:29,073 [myid:] - INFO [ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - ConnnectionExpirerThread interrupted [junit] 2016-07-07 08:39:29,073 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2016-07-07 08:39:29,073 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2016-07-07 08:39:29,073 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219] - accept thread exitted run method [junit] 2016-07-07 08:39:29,074 [myid:] - INFO [main:ZooKeeperServer@498] - shut
Re: Status: Apache ZooKeeper release 3.5.2-alpha candidate 1
Hey PMC, Where are your votes? -Flavio On 7 Jul 2016 5:51 a.m., "Chris Nauroth" wrote: > I need to leave for vacation now. Unfortunately, the binding votes have > not rolled in, so I won't be able to complete the release process before I > leave. I'll be available again on Monday, 7/18. I can pick up the work > then. Alternatively, if the votes comes in during my absence and someone > else wants to complete the release, please feel free. If we go that way, > then I could potentially pick up 3.5.3 release manager duties from Patrick > to make up for it. > > --Chris Nauroth > > > > > On 7/6/16, 8:51 AM, "Chris Nauroth" wrote: > > >With inclusion of my own +1 (non-binding), the current tally on the > >[VOTE] for release 3.5.2-alpha candidate 1 is: > > > >1 +1 (binding) > >4 +1 (non-binding) > > > >Can we please have 2 more PMC members cast a binding vote to push this > >[VOTE] to completion? Thank you. > > > >--Chris Nauroth > >
[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15365708#comment-15365708
]
Rakesh R commented on ZOOKEEPER-1045:
-
[~hanm] Awesome!, overall the test report looks good. I'm adding few minor
comments, please take a look at it.
- *Review Comment-1)* Please add the git revision number of the {{branch3-4}},
you have taken for testing, that will be helpful for future references. Can add
something like,
{code}
Branch-3-4 version:
Time:July 01, 2016, UTC+09:00.
Git Information:
Revision: 6b6a63bbbda920315d3d24b61ed3344a78a981b6
{code}
- *Review Comment-2)* Rolling upgrade should be supported and all existing
features should continue work unconditionally, with or without this feature
being enabled (full backward compatibility), before, in the middle, and after
rolling upgrade.
*Comment:* Please mention, from which version of 3.4.x used for rolling upgrade
testing. For example, rolling upgrade from {{3.4.6}} version to
{{3.4.9-SNAPSHOT}} version.
- *Review Comment-3)* Rolling upgrade verification:
*Comment:* In this section, it would be good to add few more extra details. We
can say, rolling upgrade should do in three steps and after every step admin
has to {{"Ensure that all the servers has completed this step. Only after that,
move on to next step"}}. I'm adding the below sample for your information,
please refer this and update accordingly.
{code}
Rolling upgrade should do in three steps:
step-1) Stop the servers one by one, then set the following flags in the server
'zoo.cfg' and restart it back.
quorum.auth.enableSasl=true, quorum.auth.learnerRequireSasl=false and
quorum.auth.serverRequireSasl=false. Ensure that all the servers has completed
this step. Now, move on to next step.
step-2) Stop the servers one by one, then set
'quorum.auth.learnerRequireSasl=true' flag in the server 'zoo.cfg' and restart
it back. Ensure that all the servers has completed this step. Now, move on to
next step.
step-3) Stop the servers one by one, then set
'quorum.auth.serverRequireSasl=true' flag in the server 'zoo.cfg' and restart
it back. Now, all the servers are fully upgraded and running in secured mode.
Verified everything works after restarting each server and every step.
{code}
- *Review Comment-4)* If time permits, please add two more test scenarios:
*Scenario-1)* I hope you are adding servers as LearnerType.Participant. Please
add one server as LearnerType.OBSERVER with sasl. For example, you can
configure in zoo.cfg as "server.1:localhost:2181:3181:observer"
*Scenario-2)* Add a fourth server to a quorum of server which is already
upgraded to sasl. Probably you can perform this together with the above
scenario by adding fourth server as Observer.
I think, I need to update the feature document describing the internals. I will
give priority to that and update this week or next.
> Support Quorum Peer mutual authentication via SASL
> --
>
> Key: ZOOKEEPER-1045
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
>Reporter: Eugene Koontz
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.9, 3.5.3
>
> Attachments: 0001-ZOOKEEPER-1045-br-3-4.patch,
> 1045_failing_phunt.tar.gz, ZK-1045-test-case-failure-logs.zip,
> ZOOKEEPER-1045-00.patch, ZOOKEEPER-1045-Rolling Upgrade Design Proposal.pdf,
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch,
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch,
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045TestValidationDesign.pdf
>
>
> ZOOKEEPER-938 addresses mutual authentication between clients and servers.
> This bug, on the other hand, is for authentication among quorum peers.
> Hopefully much of the work done on SASL integration with Zookeeper for
> ZOOKEEPER-938 can be used as a foundation for this enhancement.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
