Re: [jira] [Comment Edited] (ZOOKEEPER-2169) Enable creation of nodes with TTLs
Hello Apache ZooKeeper developers, Thinking, for a use case like support temporary topics in Apache Kafka, which could be based on ZooKeeper TTL feature, might be useful to be able to register a ZooKeeper "trigger" once TTL expires for a node - e.g. in same transaction that deletes temporary node, create another persistent node (request to delete the topic). Of course one could workaround this, by creating persistent and TTL node, and check if there is persistent node without matching temporary node, but option with trigger would have been better/easier from consistency point of view. What do you think about the idea? Kind regards, Stevo Slavic. On Mon, Aug 1, 2016 at 3:31 AM, Raul Gutierrez Segales (JIRA) < j...@apache.org> wrote: > > [ > https://issues.apache.org/jira/browse/ZOOKEEPER-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401429#comment-15401429 > ] > > Raul Gutierrez Segales edited comment on ZOOKEEPER-2169 at 8/1/16 1:31 AM: > --- > > [~fpj]: it's here: https://reviews.apache.org/r/46983/. > > cc: [~randgalt] > > > was (Author: rgs): > [~fpj]: it's here. > > cc: [~randgalt] > > > Enable creation of nodes with TTLs > > -- > > > > Key: ZOOKEEPER-2169 > > URL: > https://issues.apache.org/jira/browse/ZOOKEEPER-2169 > > Project: ZooKeeper > > Issue Type: New Feature > > Components: c client, java client, jute, server > >Affects Versions: 3.6.0 > >Reporter: Camille Fournier > >Assignee: Jordan Zimmerman > > Fix For: 3.6.0 > > > > Attachments: ZOOKEEPER-2169-2.patch, ZOOKEEPER-2169-3.patch, > ZOOKEEPER-2169-4.patch, ZOOKEEPER-2169-5.patch, ZOOKEEPER-2169.patch > > > > > > As a user, I would like to be able to create a node that is NOT tied to > a session but that WILL expire automatically if action is not taken by some > client within a time window. > > I propose this to enable clients interacting with ZK via http or other > "thin clients" to create ephemeral-like nodes. > > Some ideas for the design, up for discussion: > > The node should support all normal ZK node operations including ACLs, > sequential key generation, etc, however, it should not support the > ephemeral flag. The node will be created with a TTL that is updated via a > refresh operation. > > The ZK quorum will watch this node similarly to the way that it watches > for session liveness; if the node is not refreshed within the TTL, it will > expire. > > QUESTIONS: > > 1) Should we let the refresh operation set the TTL to a different base > value? > > 2) If so, should the setting of the TTL to a new base value cause a > watch to fire? > > 3) Do we want to allow these nodes to have children or prevent this > similar to ephemeral nodes? > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) >
[jira] [Created] (ZOOKEEPER-2496) When inside a transaction, some exceptions do not have path information set.
Kazuaki Banzai created ZOOKEEPER-2496: - Summary: When inside a transaction, some exceptions do not have path information set. Key: ZOOKEEPER-2496 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2496 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.5.1, 3.4.8 Reporter: Kazuaki Banzai If a client tries to execute some illegal operations inside a transaction, ZooKeeper throws an exception. Some exceptions such as NodeExistsException should have a path to indicate where the exception occurred. ZooKeeper clients can get the path by calling method getPath. However, this method returns null if the exception occurs inside a transaction. For example, when a client calls create /a and create /a in a transaction, ZooKeeper throws NodeExistsException but getPath returns null. In normal operation (outside transactions), the path information is set correctly. The patch only shows this bug occurs with NoNode exception and NodeExists exception, but this bug seems to occur with any exception which needs a path information: When an error occurred in a transaction, ZooKeeper creates an ErrorResult instance to represent error result. However, the ErrorResult class doesn't have a field for a path where an error occurred(See src/java/main/org/apache/zookeeper/OpResult.java for more details). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2496) When inside a transaction, some exceptions do not have path information set.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kazuaki Banzai updated ZOOKEEPER-2496: -- Attachment: transactionException.patch This patch doesn't fix the bug. It includes a unit test only. > When inside a transaction, some exceptions do not have path information set. > > > Key: ZOOKEEPER-2496 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2496 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.4.8, 3.5.1 >Reporter: Kazuaki Banzai > Attachments: transactionException.patch > > > If a client tries to execute some illegal operations inside a transaction, > ZooKeeper throws an exception. > Some exceptions such as NodeExistsException should have a path to indicate > where the exception occurred. > ZooKeeper clients can get the path by calling method getPath. > However, this method returns null if the exception occurs inside a > transaction. > For example, when a client calls create /a and create /a in a transaction, > ZooKeeper throws NodeExistsException but getPath returns null. > In normal operation (outside transactions), the path information is set > correctly. > The patch only shows this bug occurs with NoNode exception and NodeExists > exception, > but this bug seems to occur with any exception which needs a path information: > When an error occurred in a transaction, ZooKeeper creates an ErrorResult > instance to represent error result. > However, the ErrorResult class doesn't have a field for a path where an error > occurred(See src/java/main/org/apache/zookeeper/OpResult.java for more > details). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
ZooKeeper-trunk-solaris - Build # 1252 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1252/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 421153 lines...] [junit] 2016-08-01 08:31:33,135 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2016-08-01 08:31:33,135 [myid:] - INFO [main:ClientBase@466] - STARTING server [junit] 2016-08-01 08:31:33,135 [myid:] - INFO [main:ClientBase@386] - CREATING server instance 127.0.0.1:11222 [junit] 2016-08-01 08:31:33,136 [myid:] - INFO [main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 kB direct buffers. [junit] 2016-08-01 08:31:33,137 [myid:] - INFO [main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222 [junit] 2016-08-01 08:31:33,137 [myid:] - INFO [main:ClientBase@361] - STARTING server instance 127.0.0.1:11222 [junit] 2016-08-01 08:31:33,138 [myid:] - INFO [main:ZooKeeperServer@858] - minSessionTimeout set to 6000 [junit] 2016-08-01 08:31:33,138 [myid:] - INFO [main:ZooKeeperServer@867] - maxSessionTimeout set to 6 [junit] 2016-08-01 08:31:33,138 [myid:] - INFO [main:ZooKeeperServer@156] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test6908041432423775985.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test6908041432423775985.junit.dir/version-2 [junit] 2016-08-01 08:31:33,139 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test6908041432423775985.junit.dir/version-2/snapshot.b [junit] 2016-08-01 08:31:33,141 [myid:] - INFO [main:FileTxnSnapLog@298] - Snapshotting: 0xb to /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test6908041432423775985.junit.dir/version-2/snapshot.b [junit] 2016-08-01 08:31:33,142 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222 [junit] 2016-08-01 08:31:33,143 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:39591 [junit] 2016-08-01 08:31:33,143 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from /127.0.0.1:39591 [junit] 2016-08-01 08:31:33,143 [myid:] - INFO [NIOWorkerThread-1:StatCommand@49] - Stat command output [junit] 2016-08-01 08:31:33,144 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client /127.0.0.1:39591 (no session established for client) [junit] 2016-08-01 08:31:33,144 [myid:] - INFO [main:JMXEnv@228] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2016-08-01 08:31:33,145 [myid:] - INFO [main:JMXEnv@245] - expect:InMemoryDataTree [junit] 2016-08-01 08:31:33,145 [myid:] - INFO [main:JMXEnv@249] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree [junit] 2016-08-01 08:31:33,145 [myid:] - INFO [main:JMXEnv@245] - expect:StandaloneServer_port [junit] 2016-08-01 08:31:33,146 [myid:] - INFO [main:JMXEnv@249] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11222 [junit] 2016-08-01 08:31:33,146 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17982 [junit] 2016-08-01 08:31:33,146 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24 [junit] 2016-08-01 08:31:33,146 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testQuota [junit] 2016-08-01 08:31:33,146 [myid:] - INFO [main:ClientBase@543] - tearDown starting [junit] 2016-08-01 08:31:33,222 [myid:] - INFO [main:ZooKeeper@1313] - Session: 0x122c236ca3d closed [junit] 2016-08-01 08:31:33,222 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x122c236ca3d [junit] 2016-08-01 08:31:33,222 [myid:] - INFO [main:ClientBase@513] - STOPPING server [junit] 2016-08-01 08:31:33,222 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219] - accept thread exitted run method [junit] 2016-08-01 08:31:33,222 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2016-08-01 08:31:33,222 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorT
[jira] [Commented] (ZOOKEEPER-2468) SetQuota and DelQuota
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401790#comment-15401790 ] SREENIVASULUDANDU commented on ZOOKEEPER-2468: -- Hi , can some one assign that issue for me? > SetQuota and DelQuota > - > > Key: ZOOKEEPER-2468 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2468 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.6, 3.4.8, 3.5.1 > Environment: Windows /Linux >Reporter: Joshi Shankar > > Setquota and delquota commands does not work > Steps to reproduce: > 1. Create Test Node 1 > create -c /TestZookeeperNodeNumber "testdata" > 2. Create Test Node 2 > create -c /TestZookeeperNodeBytes "testdatabytes" > > 3. Set Quota Using > setquota -n 1 /TestZookeeperNodeNumber > 4. Set Quota Using > setquota -b 10 /TestZookeeperNodeBytes > AlreadySelectedException is thrown by Apache CLI. It is bug in Apache > CLI (https://issues.apache.org/jira/browse/CLI-183) > >We can fix by upgrading Apache CLI From(*commons-cli-1.2.jar*) to > (*commons-cli-1.3.1.jar*) > Client Operation Log: > [zk: localhost:2181(CONNECTED) 2] create -c /TestZookeeperNodeNumber > "testdata" > Created /TestZookeeperNodeNumber > [zk: localhost:2181(CONNECTED) 3] create -c /TestZookeeperNodeBytes > "testdatabytes" > Created /TestZookeeperNodeBytes > [zk: localhost:2181(CONNECTED) 4] setquota -n 1 /TestZookeeperNodeNumber > [zk: localhost:2181(CONNECTED) 5] setquota -b 10 /TestZookeeperNodeBytes > The option 'b' was specified but an option from this group has already been > selected: 'n' > ZooKeeper -server host:port cmd args > addauth scheme auth > close > config [-c] [-w] [-s] > connect host:port > create [-s] [-e] [-c] path [data] [acl] > delete [-v version] path > deleteall path > delquota [-n|-b] path > get [-s] [-w] path > getAcl [-s] path > history > listquota path > ls [-s] [-w] path > ls2 path [watch] > printwatches on|off > quit > reconfig [-s] [-v version] [[-file path] | [-members > serverID=host:port1:port2;port3[,...]*] > ] | [-add serverId=host:port1:port2;port3[,...]]* [-remove serverId[,...]*] > redo cmdno > removewatches path [-c|-d|-a] [-l] > rmr path > set [-s] [-v version] path data > setAcl [-s] [-v version] path acl > setquota -n|-b val path > stat [-w] path > sync path -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2468) SetQuota and DelQuota
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Junqueira updated ZOOKEEPER-2468: Assignee: SREENIVASULUDANDU > SetQuota and DelQuota > - > > Key: ZOOKEEPER-2468 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2468 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.6, 3.4.8, 3.5.1 > Environment: Windows /Linux >Reporter: Joshi Shankar >Assignee: SREENIVASULUDANDU > > Setquota and delquota commands does not work > Steps to reproduce: > 1. Create Test Node 1 > create -c /TestZookeeperNodeNumber "testdata" > 2. Create Test Node 2 > create -c /TestZookeeperNodeBytes "testdatabytes" > > 3. Set Quota Using > setquota -n 1 /TestZookeeperNodeNumber > 4. Set Quota Using > setquota -b 10 /TestZookeeperNodeBytes > AlreadySelectedException is thrown by Apache CLI. It is bug in Apache > CLI (https://issues.apache.org/jira/browse/CLI-183) > >We can fix by upgrading Apache CLI From(*commons-cli-1.2.jar*) to > (*commons-cli-1.3.1.jar*) > Client Operation Log: > [zk: localhost:2181(CONNECTED) 2] create -c /TestZookeeperNodeNumber > "testdata" > Created /TestZookeeperNodeNumber > [zk: localhost:2181(CONNECTED) 3] create -c /TestZookeeperNodeBytes > "testdatabytes" > Created /TestZookeeperNodeBytes > [zk: localhost:2181(CONNECTED) 4] setquota -n 1 /TestZookeeperNodeNumber > [zk: localhost:2181(CONNECTED) 5] setquota -b 10 /TestZookeeperNodeBytes > The option 'b' was specified but an option from this group has already been > selected: 'n' > ZooKeeper -server host:port cmd args > addauth scheme auth > close > config [-c] [-w] [-s] > connect host:port > create [-s] [-e] [-c] path [data] [acl] > delete [-v version] path > deleteall path > delquota [-n|-b] path > get [-s] [-w] path > getAcl [-s] path > history > listquota path > ls [-s] [-w] path > ls2 path [watch] > printwatches on|off > quit > reconfig [-s] [-v version] [[-file path] | [-members > serverID=host:port1:port2;port3[,...]*] > ] | [-add serverId=host:port1:port2;port3[,...]]* [-remove serverId[,...]*] > redo cmdno > removewatches path [-c|-d|-a] [-l] > rmr path > set [-s] [-v version] path data > setAcl [-s] [-v version] path acl > setquota -n|-b val path > stat [-w] path > sync path -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2468) SetQuota and DelQuota
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401794#comment-15401794 ] Flavio Junqueira commented on ZOOKEEPER-2468: - Done, thanks [~dandusv91]. > SetQuota and DelQuota > - > > Key: ZOOKEEPER-2468 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2468 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.6, 3.4.8, 3.5.1 > Environment: Windows /Linux >Reporter: Joshi Shankar >Assignee: SREENIVASULUDANDU > > Setquota and delquota commands does not work > Steps to reproduce: > 1. Create Test Node 1 > create -c /TestZookeeperNodeNumber "testdata" > 2. Create Test Node 2 > create -c /TestZookeeperNodeBytes "testdatabytes" > > 3. Set Quota Using > setquota -n 1 /TestZookeeperNodeNumber > 4. Set Quota Using > setquota -b 10 /TestZookeeperNodeBytes > AlreadySelectedException is thrown by Apache CLI. It is bug in Apache > CLI (https://issues.apache.org/jira/browse/CLI-183) > >We can fix by upgrading Apache CLI From(*commons-cli-1.2.jar*) to > (*commons-cli-1.3.1.jar*) > Client Operation Log: > [zk: localhost:2181(CONNECTED) 2] create -c /TestZookeeperNodeNumber > "testdata" > Created /TestZookeeperNodeNumber > [zk: localhost:2181(CONNECTED) 3] create -c /TestZookeeperNodeBytes > "testdatabytes" > Created /TestZookeeperNodeBytes > [zk: localhost:2181(CONNECTED) 4] setquota -n 1 /TestZookeeperNodeNumber > [zk: localhost:2181(CONNECTED) 5] setquota -b 10 /TestZookeeperNodeBytes > The option 'b' was specified but an option from this group has already been > selected: 'n' > ZooKeeper -server host:port cmd args > addauth scheme auth > close > config [-c] [-w] [-s] > connect host:port > create [-s] [-e] [-c] path [data] [acl] > delete [-v version] path > deleteall path > delquota [-n|-b] path > get [-s] [-w] path > getAcl [-s] path > history > listquota path > ls [-s] [-w] path > ls2 path [watch] > printwatches on|off > quit > reconfig [-s] [-v version] [[-file path] | [-members > serverID=host:port1:port2;port3[,...]*] > ] | [-add serverId=host:port1:port2;port3[,...]]* [-remove serverId[,...]*] > redo cmdno > removewatches path [-c|-d|-a] [-l] > rmr path > set [-s] [-v version] path data > setAcl [-s] [-v version] path acl > setquota -n|-b val path > stat [-w] path > sync path -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2468) SetQuota and DelQuota
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401793#comment-15401793 ] Joshi Shankar commented on ZOOKEEPER-2468: -- will provide the fix by tomorrow > SetQuota and DelQuota > - > > Key: ZOOKEEPER-2468 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2468 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.6, 3.4.8, 3.5.1 > Environment: Windows /Linux >Reporter: Joshi Shankar >Assignee: SREENIVASULUDANDU > > Setquota and delquota commands does not work > Steps to reproduce: > 1. Create Test Node 1 > create -c /TestZookeeperNodeNumber "testdata" > 2. Create Test Node 2 > create -c /TestZookeeperNodeBytes "testdatabytes" > > 3. Set Quota Using > setquota -n 1 /TestZookeeperNodeNumber > 4. Set Quota Using > setquota -b 10 /TestZookeeperNodeBytes > AlreadySelectedException is thrown by Apache CLI. It is bug in Apache > CLI (https://issues.apache.org/jira/browse/CLI-183) > >We can fix by upgrading Apache CLI From(*commons-cli-1.2.jar*) to > (*commons-cli-1.3.1.jar*) > Client Operation Log: > [zk: localhost:2181(CONNECTED) 2] create -c /TestZookeeperNodeNumber > "testdata" > Created /TestZookeeperNodeNumber > [zk: localhost:2181(CONNECTED) 3] create -c /TestZookeeperNodeBytes > "testdatabytes" > Created /TestZookeeperNodeBytes > [zk: localhost:2181(CONNECTED) 4] setquota -n 1 /TestZookeeperNodeNumber > [zk: localhost:2181(CONNECTED) 5] setquota -b 10 /TestZookeeperNodeBytes > The option 'b' was specified but an option from this group has already been > selected: 'n' > ZooKeeper -server host:port cmd args > addauth scheme auth > close > config [-c] [-w] [-s] > connect host:port > create [-s] [-e] [-c] path [data] [acl] > delete [-v version] path > deleteall path > delquota [-n|-b] path > get [-s] [-w] path > getAcl [-s] path > history > listquota path > ls [-s] [-w] path > ls2 path [watch] > printwatches on|off > quit > reconfig [-s] [-v version] [[-file path] | [-members > serverID=host:port1:port2;port3[,...]*] > ] | [-add serverId=host:port1:port2;port3[,...]]* [-remove serverId[,...]*] > redo cmdno > removewatches path [-c|-d|-a] [-l] > rmr path > set [-s] [-v version] path data > setAcl [-s] [-v version] path acl > setquota -n|-b val path > stat [-w] path > sync path -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2468) SetQuota and DelQuota
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401795#comment-15401795 ] Flavio Junqueira commented on ZOOKEEPER-2468: - Could you guys agree, please? :-) > SetQuota and DelQuota > - > > Key: ZOOKEEPER-2468 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2468 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.6, 3.4.8, 3.5.1 > Environment: Windows /Linux >Reporter: Joshi Shankar >Assignee: SREENIVASULUDANDU > > Setquota and delquota commands does not work > Steps to reproduce: > 1. Create Test Node 1 > create -c /TestZookeeperNodeNumber "testdata" > 2. Create Test Node 2 > create -c /TestZookeeperNodeBytes "testdatabytes" > > 3. Set Quota Using > setquota -n 1 /TestZookeeperNodeNumber > 4. Set Quota Using > setquota -b 10 /TestZookeeperNodeBytes > AlreadySelectedException is thrown by Apache CLI. It is bug in Apache > CLI (https://issues.apache.org/jira/browse/CLI-183) > >We can fix by upgrading Apache CLI From(*commons-cli-1.2.jar*) to > (*commons-cli-1.3.1.jar*) > Client Operation Log: > [zk: localhost:2181(CONNECTED) 2] create -c /TestZookeeperNodeNumber > "testdata" > Created /TestZookeeperNodeNumber > [zk: localhost:2181(CONNECTED) 3] create -c /TestZookeeperNodeBytes > "testdatabytes" > Created /TestZookeeperNodeBytes > [zk: localhost:2181(CONNECTED) 4] setquota -n 1 /TestZookeeperNodeNumber > [zk: localhost:2181(CONNECTED) 5] setquota -b 10 /TestZookeeperNodeBytes > The option 'b' was specified but an option from this group has already been > selected: 'n' > ZooKeeper -server host:port cmd args > addauth scheme auth > close > config [-c] [-w] [-s] > connect host:port > create [-s] [-e] [-c] path [data] [acl] > delete [-v version] path > deleteall path > delquota [-n|-b] path > get [-s] [-w] path > getAcl [-s] path > history > listquota path > ls [-s] [-w] path > ls2 path [watch] > printwatches on|off > quit > reconfig [-s] [-v version] [[-file path] | [-members > serverID=host:port1:port2;port3[,...]*] > ] | [-add serverId=host:port1:port2;port3[,...]]* [-remove serverId[,...]*] > redo cmdno > removewatches path [-c|-d|-a] [-l] > rmr path > set [-s] [-v version] path data > setAcl [-s] [-v version] path acl > setquota -n|-b val path > stat [-w] path > sync path -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2467) NullPointerException when redo Command is passed negative value
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joshi Shankar updated ZOOKEEPER-2467: - Attachment: ZOOKEEPER-2467.patch > NullPointerException when redo Command is passed negative value > --- > > Key: ZOOKEEPER-2467 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2467 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.6, 3.5.1 > Environment: Linux , windows >Reporter: Joshi Shankar >Priority: Minor > Attachments: ZOOKEEPER-2467.patch, ZOOKEEPER-2467.patch > > > When negative value of argument is passed to redo command . > [zk: localhost:2181(CONNECTED) 0] redo -1 > Exception in thread "main" java.lang.NullPointerException > at java.util.StringTokenizer.(Unknown Source) > at java.util.StringTokenizer.(Unknown Source) > at > org.apache.zookeeper.ZooKeeperMain$MyCommandOptions.parseCommand(ZooKeeperMain.java:227) > at > org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain.java:645) > at > org.apache.zookeeper.ZooKeeperMain.processCmd(ZooKeeperMain.java:588) > at > org.apache.zookeeper.ZooKeeperMain.executeLine(ZooKeeperMain.java:360) > at org.apache.zookeeper.ZooKeeperMain.run(ZooKeeperMain.java:323) > at org.apache.zookeeper.ZooKeeperMain.main(ZooKeeperMain.java:282) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2467) NullPointerException when redo Command is passed negative value
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Junqueira updated ZOOKEEPER-2467: Assignee: Joshi Shankar > NullPointerException when redo Command is passed negative value > --- > > Key: ZOOKEEPER-2467 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2467 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.6, 3.5.1 > Environment: Linux , windows >Reporter: Joshi Shankar >Assignee: Joshi Shankar >Priority: Minor > Attachments: ZOOKEEPER-2467.patch, ZOOKEEPER-2467.patch > > > When negative value of argument is passed to redo command . > [zk: localhost:2181(CONNECTED) 0] redo -1 > Exception in thread "main" java.lang.NullPointerException > at java.util.StringTokenizer.(Unknown Source) > at java.util.StringTokenizer.(Unknown Source) > at > org.apache.zookeeper.ZooKeeperMain$MyCommandOptions.parseCommand(ZooKeeperMain.java:227) > at > org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain.java:645) > at > org.apache.zookeeper.ZooKeeperMain.processCmd(ZooKeeperMain.java:588) > at > org.apache.zookeeper.ZooKeeperMain.executeLine(ZooKeeperMain.java:360) > at org.apache.zookeeper.ZooKeeperMain.run(ZooKeeperMain.java:323) > at org.apache.zookeeper.ZooKeeperMain.main(ZooKeeperMain.java:282) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2467) NullPointerException when redo Command is passed negative value
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Junqueira updated ZOOKEEPER-2467: Affects Version/s: (was: 3.5.1) (was: 3.4.6) 3.4.8 3.5.2 > NullPointerException when redo Command is passed negative value > --- > > Key: ZOOKEEPER-2467 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2467 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.8, 3.5.2 > Environment: Linux , windows >Reporter: Joshi Shankar >Assignee: Joshi Shankar >Priority: Minor > Fix For: 3.4.9, 3.5.3 > > Attachments: ZOOKEEPER-2467.patch, ZOOKEEPER-2467.patch > > > When negative value of argument is passed to redo command . > [zk: localhost:2181(CONNECTED) 0] redo -1 > Exception in thread "main" java.lang.NullPointerException > at java.util.StringTokenizer.(Unknown Source) > at java.util.StringTokenizer.(Unknown Source) > at > org.apache.zookeeper.ZooKeeperMain$MyCommandOptions.parseCommand(ZooKeeperMain.java:227) > at > org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain.java:645) > at > org.apache.zookeeper.ZooKeeperMain.processCmd(ZooKeeperMain.java:588) > at > org.apache.zookeeper.ZooKeeperMain.executeLine(ZooKeeperMain.java:360) > at org.apache.zookeeper.ZooKeeperMain.run(ZooKeeperMain.java:323) > at org.apache.zookeeper.ZooKeeperMain.main(ZooKeeperMain.java:282) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2467) NullPointerException when redo Command is passed negative value
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Junqueira updated ZOOKEEPER-2467: Fix Version/s: 3.5.3 3.4.9 > NullPointerException when redo Command is passed negative value > --- > > Key: ZOOKEEPER-2467 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2467 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.8, 3.5.2 > Environment: Linux , windows >Reporter: Joshi Shankar >Assignee: Joshi Shankar >Priority: Minor > Fix For: 3.4.9, 3.5.3 > > Attachments: ZOOKEEPER-2467.patch, ZOOKEEPER-2467.patch > > > When negative value of argument is passed to redo command . > [zk: localhost:2181(CONNECTED) 0] redo -1 > Exception in thread "main" java.lang.NullPointerException > at java.util.StringTokenizer.(Unknown Source) > at java.util.StringTokenizer.(Unknown Source) > at > org.apache.zookeeper.ZooKeeperMain$MyCommandOptions.parseCommand(ZooKeeperMain.java:227) > at > org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain.java:645) > at > org.apache.zookeeper.ZooKeeperMain.processCmd(ZooKeeperMain.java:588) > at > org.apache.zookeeper.ZooKeeperMain.executeLine(ZooKeeperMain.java:360) > at org.apache.zookeeper.ZooKeeperMain.run(ZooKeeperMain.java:323) > at org.apache.zookeeper.ZooKeeperMain.main(ZooKeeperMain.java:282) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Failed: ZOOKEEPER-2467 PreCommit Build #3313
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2467 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3313/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 124 lines...] [exec] patching file src/java/test/org/apache/zookeeper/ZooKeeperTest.java [exec] Hunk #1 succeeded at 422 (offset 6 lines). [exec] PATCH APPLICATION FAILED [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12821299/ZOOKEEPER-2467.patch [exec] against trunk revision 1754582. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] -1 patch. The patch command could not apply the patch. [exec] [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3313//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 0ab6e61c6594756612f20d0cec2931c78fdce855 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1605: exec returned: 1 Total time: 45 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Recording test results Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error? Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 [description-setter] Description set: ZOOKEEPER-2467 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-2467) NullPointerException when redo Command is passed negative value
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401806#comment-15401806 ] Hadoop QA commented on ZOOKEEPER-2467: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12821299/ZOOKEEPER-2467.patch against trunk revision 1754582. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3313//console This message is automatically generated. > NullPointerException when redo Command is passed negative value > --- > > Key: ZOOKEEPER-2467 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2467 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.8, 3.5.2 > Environment: Linux , windows >Reporter: Joshi Shankar >Assignee: Joshi Shankar >Priority: Minor > Fix For: 3.4.9, 3.5.3 > > Attachments: ZOOKEEPER-2467.patch, ZOOKEEPER-2467.patch > > > When negative value of argument is passed to redo command . > [zk: localhost:2181(CONNECTED) 0] redo -1 > Exception in thread "main" java.lang.NullPointerException > at java.util.StringTokenizer.(Unknown Source) > at java.util.StringTokenizer.(Unknown Source) > at > org.apache.zookeeper.ZooKeeperMain$MyCommandOptions.parseCommand(ZooKeeperMain.java:227) > at > org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain.java:645) > at > org.apache.zookeeper.ZooKeeperMain.processCmd(ZooKeeperMain.java:588) > at > org.apache.zookeeper.ZooKeeperMain.executeLine(ZooKeeperMain.java:360) > at org.apache.zookeeper.ZooKeeperMain.run(ZooKeeperMain.java:323) > at org.apache.zookeeper.ZooKeeperMain.main(ZooKeeperMain.java:282) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Failed: ZOOKEEPER-2467 PreCommit Build #3314
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2467 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3314/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 97 lines...] [exec] patching file src/java/test/org/apache/zookeeper/ZooKeeperTest.java [exec] Hunk #1 succeeded at 422 (offset 6 lines). [exec] PATCH APPLICATION FAILED [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12821299/ZOOKEEPER-2467.patch [exec] against trunk revision 1754582. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] -1 patch. The patch command could not apply the patch. [exec] [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3314//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] e2ea22d09fa69de27af976f7a4a0fe671f007608 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1605: exec returned: 1 Total time: 45 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Recording test results Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error? Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 [description-setter] Description set: ZOOKEEPER-2467 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-2467) NullPointerException when redo Command is passed negative value
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401808#comment-15401808 ] Hadoop QA commented on ZOOKEEPER-2467: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12821299/ZOOKEEPER-2467.patch against trunk revision 1754582. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3314//console This message is automatically generated. > NullPointerException when redo Command is passed negative value > --- > > Key: ZOOKEEPER-2467 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2467 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.8, 3.5.2 > Environment: Linux , windows >Reporter: Joshi Shankar >Assignee: Joshi Shankar >Priority: Minor > Fix For: 3.4.9, 3.5.3 > > Attachments: ZOOKEEPER-2467.patch, ZOOKEEPER-2467.patch > > > When negative value of argument is passed to redo command . > [zk: localhost:2181(CONNECTED) 0] redo -1 > Exception in thread "main" java.lang.NullPointerException > at java.util.StringTokenizer.(Unknown Source) > at java.util.StringTokenizer.(Unknown Source) > at > org.apache.zookeeper.ZooKeeperMain$MyCommandOptions.parseCommand(ZooKeeperMain.java:227) > at > org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain.java:645) > at > org.apache.zookeeper.ZooKeeperMain.processCmd(ZooKeeperMain.java:588) > at > org.apache.zookeeper.ZooKeeperMain.executeLine(ZooKeeperMain.java:360) > at org.apache.zookeeper.ZooKeeperMain.run(ZooKeeperMain.java:323) > at org.apache.zookeeper.ZooKeeperMain.main(ZooKeeperMain.java:282) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2467) NullPointerException when redo Command is passed negative value
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401811#comment-15401811 ] Flavio Junqueira commented on ZOOKEEPER-2467: - Thanks [~joshi.shankar], the change makes sense. I'm wondering if in the test case would be better to try/catch any exception that comes across and fail the test rather than let the exception bubble up. > NullPointerException when redo Command is passed negative value > --- > > Key: ZOOKEEPER-2467 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2467 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.8, 3.5.2 > Environment: Linux , windows >Reporter: Joshi Shankar >Assignee: Joshi Shankar >Priority: Minor > Fix For: 3.4.9, 3.5.3 > > Attachments: ZOOKEEPER-2467.patch, ZOOKEEPER-2467.patch > > > When negative value of argument is passed to redo command . > [zk: localhost:2181(CONNECTED) 0] redo -1 > Exception in thread "main" java.lang.NullPointerException > at java.util.StringTokenizer.(Unknown Source) > at java.util.StringTokenizer.(Unknown Source) > at > org.apache.zookeeper.ZooKeeperMain$MyCommandOptions.parseCommand(ZooKeeperMain.java:227) > at > org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain.java:645) > at > org.apache.zookeeper.ZooKeeperMain.processCmd(ZooKeeperMain.java:588) > at > org.apache.zookeeper.ZooKeeperMain.executeLine(ZooKeeperMain.java:360) > at org.apache.zookeeper.ZooKeeperMain.run(ZooKeeperMain.java:323) > at org.apache.zookeeper.ZooKeeperMain.main(ZooKeeperMain.java:282) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2467) NullPointerException when redo Command is passed negative value
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401815#comment-15401815 ] Joshi Shankar commented on ZOOKEEPER-2467: -- will do it.. Thanks :) > NullPointerException when redo Command is passed negative value > --- > > Key: ZOOKEEPER-2467 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2467 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.8, 3.5.2 > Environment: Linux , windows >Reporter: Joshi Shankar >Assignee: Joshi Shankar >Priority: Minor > Fix For: 3.4.9, 3.5.3 > > Attachments: ZOOKEEPER-2467.patch, ZOOKEEPER-2467.patch > > > When negative value of argument is passed to redo command . > [zk: localhost:2181(CONNECTED) 0] redo -1 > Exception in thread "main" java.lang.NullPointerException > at java.util.StringTokenizer.(Unknown Source) > at java.util.StringTokenizer.(Unknown Source) > at > org.apache.zookeeper.ZooKeeperMain$MyCommandOptions.parseCommand(ZooKeeperMain.java:227) > at > org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain.java:645) > at > org.apache.zookeeper.ZooKeeperMain.processCmd(ZooKeeperMain.java:588) > at > org.apache.zookeeper.ZooKeeperMain.executeLine(ZooKeeperMain.java:360) > at org.apache.zookeeper.ZooKeeperMain.run(ZooKeeperMain.java:323) > at org.apache.zookeeper.ZooKeeperMain.main(ZooKeeperMain.java:282) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2468) SetQuota and DelQuota
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] SREENIVASULUDANDU updated ZOOKEEPER-2468: - Attachment: ZOOKEEPER-2468-0.1-patch Hi please review it... > SetQuota and DelQuota > - > > Key: ZOOKEEPER-2468 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2468 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.6, 3.4.8, 3.5.1 > Environment: Windows /Linux >Reporter: Joshi Shankar >Assignee: SREENIVASULUDANDU > Attachments: ZOOKEEPER-2468-0.1-patch > > > Setquota and delquota commands does not work > Steps to reproduce: > 1. Create Test Node 1 > create -c /TestZookeeperNodeNumber "testdata" > 2. Create Test Node 2 > create -c /TestZookeeperNodeBytes "testdatabytes" > > 3. Set Quota Using > setquota -n 1 /TestZookeeperNodeNumber > 4. Set Quota Using > setquota -b 10 /TestZookeeperNodeBytes > AlreadySelectedException is thrown by Apache CLI. It is bug in Apache > CLI (https://issues.apache.org/jira/browse/CLI-183) > >We can fix by upgrading Apache CLI From(*commons-cli-1.2.jar*) to > (*commons-cli-1.3.1.jar*) > Client Operation Log: > [zk: localhost:2181(CONNECTED) 2] create -c /TestZookeeperNodeNumber > "testdata" > Created /TestZookeeperNodeNumber > [zk: localhost:2181(CONNECTED) 3] create -c /TestZookeeperNodeBytes > "testdatabytes" > Created /TestZookeeperNodeBytes > [zk: localhost:2181(CONNECTED) 4] setquota -n 1 /TestZookeeperNodeNumber > [zk: localhost:2181(CONNECTED) 5] setquota -b 10 /TestZookeeperNodeBytes > The option 'b' was specified but an option from this group has already been > selected: 'n' > ZooKeeper -server host:port cmd args > addauth scheme auth > close > config [-c] [-w] [-s] > connect host:port > create [-s] [-e] [-c] path [data] [acl] > delete [-v version] path > deleteall path > delquota [-n|-b] path > get [-s] [-w] path > getAcl [-s] path > history > listquota path > ls [-s] [-w] path > ls2 path [watch] > printwatches on|off > quit > reconfig [-s] [-v version] [[-file path] | [-members > serverID=host:port1:port2;port3[,...]*] > ] | [-add serverId=host:port1:port2;port3[,...]]* [-remove serverId[,...]*] > redo cmdno > removewatches path [-c|-d|-a] [-l] > rmr path > set [-s] [-v version] path data > setAcl [-s] [-v version] path acl > setquota -n|-b val path > stat [-w] path > sync path -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Failed: ZOOKEEPER-2468 PreCommit Build #3315
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2468 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3315/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 105 lines...] [exec] PATCH APPLICATION FAILED [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12821305/ZOOKEEPER-2468-0.1-patch [exec] against trunk revision 1754582. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] -1 patch. The patch command could not apply the patch. [exec] [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3315//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 5ff5b677e66303d9b7e8bf1a40cff4d6a639fb4e logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1605: exec returned: 1 Total time: 46 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Recording test results Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error? Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 [description-setter] Description set: ZOOKEEPER-2468 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-2468) SetQuota and DelQuota
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401845#comment-15401845 ] Hadoop QA commented on ZOOKEEPER-2468: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12821305/ZOOKEEPER-2468-0.1-patch against trunk revision 1754582. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3315//console This message is automatically generated. > SetQuota and DelQuota > - > > Key: ZOOKEEPER-2468 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2468 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.6, 3.4.8, 3.5.1 > Environment: Windows /Linux >Reporter: Joshi Shankar >Assignee: SREENIVASULUDANDU > Fix For: 3.4.8 > > Attachments: ZOOKEEPER-2468-0.1-patch > > > Setquota and delquota commands does not work > Steps to reproduce: > 1. Create Test Node 1 > create -c /TestZookeeperNodeNumber "testdata" > 2. Create Test Node 2 > create -c /TestZookeeperNodeBytes "testdatabytes" > > 3. Set Quota Using > setquota -n 1 /TestZookeeperNodeNumber > 4. Set Quota Using > setquota -b 10 /TestZookeeperNodeBytes > AlreadySelectedException is thrown by Apache CLI. It is bug in Apache > CLI (https://issues.apache.org/jira/browse/CLI-183) > >We can fix by upgrading Apache CLI From(*commons-cli-1.2.jar*) to > (*commons-cli-1.3.1.jar*) > Client Operation Log: > [zk: localhost:2181(CONNECTED) 2] create -c /TestZookeeperNodeNumber > "testdata" > Created /TestZookeeperNodeNumber > [zk: localhost:2181(CONNECTED) 3] create -c /TestZookeeperNodeBytes > "testdatabytes" > Created /TestZookeeperNodeBytes > [zk: localhost:2181(CONNECTED) 4] setquota -n 1 /TestZookeeperNodeNumber > [zk: localhost:2181(CONNECTED) 5] setquota -b 10 /TestZookeeperNodeBytes > The option 'b' was specified but an option from this group has already been > selected: 'n' > ZooKeeper -server host:port cmd args > addauth scheme auth > close > config [-c] [-w] [-s] > connect host:port > create [-s] [-e] [-c] path [data] [acl] > delete [-v version] path > deleteall path > delquota [-n|-b] path > get [-s] [-w] path > getAcl [-s] path > history > listquota path > ls [-s] [-w] path > ls2 path [watch] > printwatches on|off > quit > reconfig [-s] [-v version] [[-file path] | [-members > serverID=host:port1:port2;port3[,...]*] > ] | [-add serverId=host:port1:port2;port3[,...]]* [-remove serverId[,...]*] > redo cmdno > removewatches path [-c|-d|-a] [-l] > rmr path > set [-s] [-v version] path data > setAcl [-s] [-v version] path acl > setquota -n|-b val path > stat [-w] path > sync path -- This message was sent by Atlassian JIRA (v6.3.4#6332)
ZooKeeper_branch34_openjdk7 - Build # 1156 - Failure
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1156/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 223338 lines...] [junit] 2016-08-01 15:16:18,046 [myid:] - INFO [main:JMXEnv@246] - expect:StandaloneServer_port [junit] 2016-08-01 15:16:18,046 [myid:] - INFO [main:JMXEnv@250] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11221 [junit] 2016-08-01 15:16:18,047 [myid:] - INFO [main:ClientBase@490] - STOPPING server [junit] 2016-08-01 15:16:18,047 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@219] - NIOServerCnxn factory exited run method [junit] 2016-08-01 15:16:18,047 [myid:] - INFO [main:ZooKeeperServer@469] - shutting down [junit] 2016-08-01 15:16:18,047 [myid:] - INFO [main:SessionTrackerImpl@225] - Shutting down [junit] 2016-08-01 15:16:18,047 [myid:] - INFO [main:PrepRequestProcessor@765] - Shutting down [junit] 2016-08-01 15:16:18,048 [myid:] - INFO [main:SyncRequestProcessor@209] - Shutting down [junit] 2016-08-01 15:16:18,048 [myid:] - INFO [ProcessThread(sid:0 cport:11221)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop! [junit] 2016-08-01 15:16:18,048 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@187] - SyncRequestProcessor exited! [junit] 2016-08-01 15:16:18,048 [myid:] - INFO [main:FinalRequestProcessor@402] - shutdown of request processor complete [junit] 2016-08-01 15:16:18,049 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221 [junit] 2016-08-01 15:16:18,049 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2016-08-01 15:16:18,050 [myid:] - INFO [main:ClientBase@443] - STARTING server [junit] 2016-08-01 15:16:18,051 [myid:] - INFO [main:ClientBase@364] - CREATING server instance 127.0.0.1:11221 [junit] 2016-08-01 15:16:18,051 [myid:] - INFO [main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2016-08-01 15:16:18,051 [myid:] - INFO [main:ClientBase@339] - STARTING server instance 127.0.0.1:11221 [junit] 2016-08-01 15:16:18,052 [myid:] - INFO [main:ZooKeeperServer@170] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/branch-3.4/build/test/tmp/test167917782397948591.junit.dir/version-2 snapdir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/branch-3.4/build/test/tmp/test167917782397948591.junit.dir/version-2 [junit] 2016-08-01 15:16:18,055 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221 [junit] 2016-08-01 15:16:18,055 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - Accepted socket connection from /127.0.0.1:37461 [junit] 2016-08-01 15:16:18,056 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing stat command from /127.0.0.1:37461 [junit] 2016-08-01 15:16:18,056 [myid:] - INFO [Thread-4:NIOServerCnxn$StatCommand@663] - Stat command output [junit] 2016-08-01 15:16:18,057 [myid:] - INFO [Thread-4:NIOServerCnxn@1008] - Closed socket connection for client /127.0.0.1:37461 (no session established for client) [junit] 2016-08-01 15:16:18,057 [myid:] - INFO [main:JMXEnv@229] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2016-08-01 15:16:18,059 [myid:] - INFO [main:JMXEnv@246] - expect:InMemoryDataTree [junit] 2016-08-01 15:16:18,059 [myid:] - INFO [main:JMXEnv@250] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree [junit] 2016-08-01 15:16:18,059 [myid:] - INFO [main:JMXEnv@246] - expect:StandaloneServer_port [junit] 2016-08-01 15:16:18,059 [myid:] - INFO [main:JMXEnv@250] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11221 [junit] 2016-08-01 15:16:18,060 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 32639 [junit] 2016-08-01 15:16:18,060 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20 [junit] 2016-08-01 15:16:18,060 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota [junit] 2016-08-01 15:16:18,060 [myid:] - INFO [main:ClientBase@520] - tearDown starting [junit] 2016-08-01 15:16:18,134 [myid:] - INFO [main:ZooKeeper@684] - Session: 0x15646ad4cec closed [junit] 2016-08-01 15:16:18,134 [myid:] - INFO [main:ClientBase@490] - STOPPING server [junit] 2016-08-01 15:16:18,135 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@519] - EventThread shut down for session: 0x15646ad4cec [junit] 2016-08-01 15:16:18,135 [myid:] - INFO
Re: [jira] [Comment Edited] (ZOOKEEPER-2169) Enable creation of nodes with TTLs
That’s an interesting idea - so a watcher for container expirations? -Jordan > On Aug 1, 2016, at 2:20 AM, Stevo Slavić wrote: > > Hello Apache ZooKeeper developers, > > Thinking, for a use case like support temporary topics in Apache Kafka, > which could be based on ZooKeeper TTL feature, might be useful to be able > to register a ZooKeeper "trigger" once TTL expires for a node - e.g. in > same transaction that deletes temporary node, create another persistent > node (request to delete the topic). Of course one could workaround this, by > creating persistent and TTL node, and check if there is persistent node > without matching temporary node, but option with trigger would have been > better/easier from consistency point of view. > > What do you think about the idea? > > Kind regards, > Stevo Slavic. > > > On Mon, Aug 1, 2016 at 3:31 AM, Raul Gutierrez Segales (JIRA) < > j...@apache.org> wrote: > >> >>[ >> https://issues.apache.org/jira/browse/ZOOKEEPER-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401429#comment-15401429 >> ] >> >> Raul Gutierrez Segales edited comment on ZOOKEEPER-2169 at 8/1/16 1:31 AM: >> --- >> >> [~fpj]: it's here: https://reviews.apache.org/r/46983/. >> >> cc: [~randgalt] >> >> >> was (Author: rgs): >> [~fpj]: it's here. >> >> cc: [~randgalt] >> >>> Enable creation of nodes with TTLs >>> -- >>> >>>Key: ZOOKEEPER-2169 >>>URL: >> https://issues.apache.org/jira/browse/ZOOKEEPER-2169 >>>Project: ZooKeeper >>> Issue Type: New Feature >>> Components: c client, java client, jute, server >>> Affects Versions: 3.6.0 >>> Reporter: Camille Fournier >>> Assignee: Jordan Zimmerman >>>Fix For: 3.6.0 >>> >>>Attachments: ZOOKEEPER-2169-2.patch, ZOOKEEPER-2169-3.patch, >> ZOOKEEPER-2169-4.patch, ZOOKEEPER-2169-5.patch, ZOOKEEPER-2169.patch >>> >>> >>> As a user, I would like to be able to create a node that is NOT tied to >> a session but that WILL expire automatically if action is not taken by some >> client within a time window. >>> I propose this to enable clients interacting with ZK via http or other >> "thin clients" to create ephemeral-like nodes. >>> Some ideas for the design, up for discussion: >>> The node should support all normal ZK node operations including ACLs, >> sequential key generation, etc, however, it should not support the >> ephemeral flag. The node will be created with a TTL that is updated via a >> refresh operation. >>> The ZK quorum will watch this node similarly to the way that it watches >> for session liveness; if the node is not refreshed within the TTL, it will >> expire. >>> QUESTIONS: >>> 1) Should we let the refresh operation set the TTL to a different base >> value? >>> 2) If so, should the setting of the TTL to a new base value cause a >> watch to fire? >>> 3) Do we want to allow these nodes to have children or prevent this >> similar to ephemeral nodes? >> >> >> >> -- >> This message was sent by Atlassian JIRA >> (v6.3.4#6332) >>
Re: [jira] [Comment Edited] (ZOOKEEPER-2169) Enable creation of nodes with TTLs
Yes, all server side. Client that successfully creates TTL node and registers such "trigger", could disconnect - trigger should fire on TTL node deletion and be handled on server side only. So server watching and handling event. It shouldn't happen that TTL node gets deleted and event does not get handled - both deletion of TTL node and handling of a trigger both should either succeed or fail. On Mon, Aug 1, 2016 at 5:37 PM, Jordan Zimmerman wrote: > That’s an interesting idea - so a watcher for container expirations? > > -Jordan > > > On Aug 1, 2016, at 2:20 AM, Stevo Slavić wrote: > > > > Hello Apache ZooKeeper developers, > > > > Thinking, for a use case like support temporary topics in Apache Kafka, > > which could be based on ZooKeeper TTL feature, might be useful to be able > > to register a ZooKeeper "trigger" once TTL expires for a node - e.g. in > > same transaction that deletes temporary node, create another persistent > > node (request to delete the topic). Of course one could workaround this, > by > > creating persistent and TTL node, and check if there is persistent node > > without matching temporary node, but option with trigger would have been > > better/easier from consistency point of view. > > > > What do you think about the idea? > > > > Kind regards, > > Stevo Slavic. > > > > > > On Mon, Aug 1, 2016 at 3:31 AM, Raul Gutierrez Segales (JIRA) < > > j...@apache.org> wrote: > > > >> > >>[ > >> > https://issues.apache.org/jira/browse/ZOOKEEPER-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401429#comment-15401429 > >> ] > >> > >> Raul Gutierrez Segales edited comment on ZOOKEEPER-2169 at 8/1/16 1:31 > AM: > >> > --- > >> > >> [~fpj]: it's here: https://reviews.apache.org/r/46983/. > >> > >> cc: [~randgalt] > >> > >> > >> was (Author: rgs): > >> [~fpj]: it's here. > >> > >> cc: [~randgalt] > >> > >>> Enable creation of nodes with TTLs > >>> -- > >>> > >>>Key: ZOOKEEPER-2169 > >>>URL: > >> https://issues.apache.org/jira/browse/ZOOKEEPER-2169 > >>>Project: ZooKeeper > >>> Issue Type: New Feature > >>> Components: c client, java client, jute, server > >>> Affects Versions: 3.6.0 > >>> Reporter: Camille Fournier > >>> Assignee: Jordan Zimmerman > >>>Fix For: 3.6.0 > >>> > >>>Attachments: ZOOKEEPER-2169-2.patch, ZOOKEEPER-2169-3.patch, > >> ZOOKEEPER-2169-4.patch, ZOOKEEPER-2169-5.patch, ZOOKEEPER-2169.patch > >>> > >>> > >>> As a user, I would like to be able to create a node that is NOT tied to > >> a session but that WILL expire automatically if action is not taken by > some > >> client within a time window. > >>> I propose this to enable clients interacting with ZK via http or other > >> "thin clients" to create ephemeral-like nodes. > >>> Some ideas for the design, up for discussion: > >>> The node should support all normal ZK node operations including ACLs, > >> sequential key generation, etc, however, it should not support the > >> ephemeral flag. The node will be created with a TTL that is updated via > a > >> refresh operation. > >>> The ZK quorum will watch this node similarly to the way that it watches > >> for session liveness; if the node is not refreshed within the TTL, it > will > >> expire. > >>> QUESTIONS: > >>> 1) Should we let the refresh operation set the TTL to a different base > >> value? > >>> 2) If so, should the setting of the TTL to a new base value cause a > >> watch to fire? > >>> 3) Do we want to allow these nodes to have children or prevent this > >> similar to ephemeral nodes? > >> > >> > >> > >> -- > >> This message was sent by Atlassian JIRA > >> (v6.3.4#6332) > >> > >
[jira] [Updated] (ZOOKEEPER-2467) NullPointerException when redo Command is passed negative value
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joshi Shankar updated ZOOKEEPER-2467: - Attachment: ZOOKEEPER-2467-1.patch > NullPointerException when redo Command is passed negative value > --- > > Key: ZOOKEEPER-2467 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2467 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.8, 3.5.2 > Environment: Linux , windows >Reporter: Joshi Shankar >Assignee: Joshi Shankar >Priority: Minor > Fix For: 3.4.9, 3.5.3 > > Attachments: ZOOKEEPER-2467-1.patch, ZOOKEEPER-2467.patch, > ZOOKEEPER-2467.patch > > > When negative value of argument is passed to redo command . > [zk: localhost:2181(CONNECTED) 0] redo -1 > Exception in thread "main" java.lang.NullPointerException > at java.util.StringTokenizer.(Unknown Source) > at java.util.StringTokenizer.(Unknown Source) > at > org.apache.zookeeper.ZooKeeperMain$MyCommandOptions.parseCommand(ZooKeeperMain.java:227) > at > org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain.java:645) > at > org.apache.zookeeper.ZooKeeperMain.processCmd(ZooKeeperMain.java:588) > at > org.apache.zookeeper.ZooKeeperMain.executeLine(ZooKeeperMain.java:360) > at org.apache.zookeeper.ZooKeeperMain.run(ZooKeeperMain.java:323) > at org.apache.zookeeper.ZooKeeperMain.main(ZooKeeperMain.java:282) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Failed: ZOOKEEPER-2467 PreCommit Build #3316
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2467 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3316/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 118 lines...] [exec] Skipping patch. [exec] 1 out of 1 hunk ignored [exec] PATCH APPLICATION FAILED [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12821348/ZOOKEEPER-2467-1.patch [exec] against trunk revision 1754582. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] -1 patch. The patch command could not apply the patch. [exec] [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3316//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 7f408ad1cc2d27168d7fa0c7f451926b2fae7197 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1605: exec returned: 1 Total time: 43 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Recording test results Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error? Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 [description-setter] Description set: ZOOKEEPER-2467 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-2467) NullPointerException when redo Command is passed negative value
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402313#comment-15402313 ] Hadoop QA commented on ZOOKEEPER-2467: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12821348/ZOOKEEPER-2467-1.patch against trunk revision 1754582. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3316//console This message is automatically generated. > NullPointerException when redo Command is passed negative value > --- > > Key: ZOOKEEPER-2467 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2467 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.8, 3.5.2 > Environment: Linux , windows >Reporter: Joshi Shankar >Assignee: Joshi Shankar >Priority: Minor > Fix For: 3.4.9, 3.5.3 > > Attachments: ZOOKEEPER-2467-1.patch, ZOOKEEPER-2467.patch, > ZOOKEEPER-2467.patch > > > When negative value of argument is passed to redo command . > [zk: localhost:2181(CONNECTED) 0] redo -1 > Exception in thread "main" java.lang.NullPointerException > at java.util.StringTokenizer.(Unknown Source) > at java.util.StringTokenizer.(Unknown Source) > at > org.apache.zookeeper.ZooKeeperMain$MyCommandOptions.parseCommand(ZooKeeperMain.java:227) > at > org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain.java:645) > at > org.apache.zookeeper.ZooKeeperMain.processCmd(ZooKeeperMain.java:588) > at > org.apache.zookeeper.ZooKeeperMain.executeLine(ZooKeeperMain.java:360) > at org.apache.zookeeper.ZooKeeperMain.run(ZooKeeperMain.java:323) > at org.apache.zookeeper.ZooKeeperMain.main(ZooKeeperMain.java:282) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2467) NullPointerException when redo Command is passed negative value
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joshi Shankar updated ZOOKEEPER-2467: - Attachment: ZOOKEEPER-2467-final.patch > NullPointerException when redo Command is passed negative value > --- > > Key: ZOOKEEPER-2467 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2467 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.8, 3.5.2 > Environment: Linux , windows >Reporter: Joshi Shankar >Assignee: Joshi Shankar >Priority: Minor > Fix For: 3.4.9, 3.5.3 > > Attachments: ZOOKEEPER-2467-1.patch, ZOOKEEPER-2467-final.patch, > ZOOKEEPER-2467.patch, ZOOKEEPER-2467.patch > > > When negative value of argument is passed to redo command . > [zk: localhost:2181(CONNECTED) 0] redo -1 > Exception in thread "main" java.lang.NullPointerException > at java.util.StringTokenizer.(Unknown Source) > at java.util.StringTokenizer.(Unknown Source) > at > org.apache.zookeeper.ZooKeeperMain$MyCommandOptions.parseCommand(ZooKeeperMain.java:227) > at > org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain.java:645) > at > org.apache.zookeeper.ZooKeeperMain.processCmd(ZooKeeperMain.java:588) > at > org.apache.zookeeper.ZooKeeperMain.executeLine(ZooKeeperMain.java:360) > at org.apache.zookeeper.ZooKeeperMain.run(ZooKeeperMain.java:323) > at org.apache.zookeeper.ZooKeeperMain.main(ZooKeeperMain.java:282) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2467) NullPointerException when redo Command is passed negative value
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402407#comment-15402407 ] Hadoop QA commented on ZOOKEEPER-2467: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12821354/ZOOKEEPER-2467-final.patch against trunk revision 1754582. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3317//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3317//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3317//console This message is automatically generated. > NullPointerException when redo Command is passed negative value > --- > > Key: ZOOKEEPER-2467 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2467 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.8, 3.5.2 > Environment: Linux , windows >Reporter: Joshi Shankar >Assignee: Joshi Shankar >Priority: Minor > Fix For: 3.4.9, 3.5.3 > > Attachments: ZOOKEEPER-2467-1.patch, ZOOKEEPER-2467-final.patch, > ZOOKEEPER-2467.patch, ZOOKEEPER-2467.patch > > > When negative value of argument is passed to redo command . > [zk: localhost:2181(CONNECTED) 0] redo -1 > Exception in thread "main" java.lang.NullPointerException > at java.util.StringTokenizer.(Unknown Source) > at java.util.StringTokenizer.(Unknown Source) > at > org.apache.zookeeper.ZooKeeperMain$MyCommandOptions.parseCommand(ZooKeeperMain.java:227) > at > org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain.java:645) > at > org.apache.zookeeper.ZooKeeperMain.processCmd(ZooKeeperMain.java:588) > at > org.apache.zookeeper.ZooKeeperMain.executeLine(ZooKeeperMain.java:360) > at org.apache.zookeeper.ZooKeeperMain.run(ZooKeeperMain.java:323) > at org.apache.zookeeper.ZooKeeperMain.main(ZooKeeperMain.java:282) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Success: ZOOKEEPER-2467 PreCommit Build #3317
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2467 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3317/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 438052 lines...] [exec] http://issues.apache.org/jira/secure/attachment/12821354/ZOOKEEPER-2467-final.patch [exec] against trunk revision 1754582. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3317//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3317//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3317//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] fc64ee6b45ed9d787d107d9f461b88625c8a2d55 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 19 minutes 57 seconds Archiving artifacts Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Recording test results Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 [description-setter] Description set: ZOOKEEPER-2467 Email was triggered for: Success Sending email for trigger: Success Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-2467) NullPointerException when redo Command is passed negative value
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402711#comment-15402711
]
Flavio Junqueira commented on ZOOKEEPER-2467:
-
Thanks for the updated patch, [~joshi.shankar]. I have a few comments, though:
# The format seems to be broken, the try/catch block doesn't have the right
indentation.
# {{testCliCommandsNotEchoingUsage}} is not the best method to include this
test. We aren't testing whether redo is echoing usage, but instead that it
isn't throwing an NPE with negative values. One suggestion is to have a test
case called {{testRedoNegativeCmdNumber}} in the same class and add the redo
test there.
# The test cases in the {{ZooKeeperTest}} class throw {{Exception}} so it is
actually better that we do it to follow the pattern here. We should still fail
in the case it throws an exception, but instead of swallowing it, I suggest we
rethrow.
# We might consider adding an implementation of {{RedoCommand}} that extends
{{CliCommand}} to be able to check the output, like in {{testSortedLs()}}.
Here is roughly how it should look like:
{noformat}
@Test
public void testRedoNegativeCmdNumber() throws Exception {
try {
String cmd = "redo -1";
zkMain.executeLine(cmd);
// check that the output matches
...
} (Exception e) {
fail("Failed to excute redo command with negative number");
throw e;
}
}
{noformat}
> NullPointerException when redo Command is passed negative value
> ---
>
> Key: ZOOKEEPER-2467
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2467
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
>Affects Versions: 3.4.8, 3.5.2
> Environment: Linux , windows
>Reporter: Joshi Shankar
>Assignee: Joshi Shankar
>Priority: Minor
> Fix For: 3.4.9, 3.5.3
>
> Attachments: ZOOKEEPER-2467-1.patch, ZOOKEEPER-2467-final.patch,
> ZOOKEEPER-2467.patch, ZOOKEEPER-2467.patch
>
>
> When negative value of argument is passed to redo command .
> [zk: localhost:2181(CONNECTED) 0] redo -1
> Exception in thread "main" java.lang.NullPointerException
> at java.util.StringTokenizer.(Unknown Source)
> at java.util.StringTokenizer.(Unknown Source)
> at
> org.apache.zookeeper.ZooKeeperMain$MyCommandOptions.parseCommand(ZooKeeperMain.java:227)
> at
> org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain.java:645)
> at
> org.apache.zookeeper.ZooKeeperMain.processCmd(ZooKeeperMain.java:588)
> at
> org.apache.zookeeper.ZooKeeperMain.executeLine(ZooKeeperMain.java:360)
> at org.apache.zookeeper.ZooKeeperMain.run(ZooKeeperMain.java:323)
> at org.apache.zookeeper.ZooKeeperMain.main(ZooKeeperMain.java:282)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [jira] [Comment Edited] (ZOOKEEPER-2169) Enable creation of nodes with TTLs
I think it would be simpler and less disruptive to use the existing Watcher mechanism. Treat it as a deleted node watcher. When the TTL/container node gets deleted the watcher triggers. Actually, come to think of it, wouldn’t that work already? Like any other node, after creating it you can call exists() to set a watcher. Do we really need new behavior here? -Jordan > On Aug 1, 2016, at 11:02 AM, Stevo Slavić wrote: > > Yes, all server side. Client that successfully creates TTL node and > registers such "trigger", could disconnect - trigger should fire on TTL > node deletion and be handled on server side only. So server watching and > handling event. It shouldn't happen that TTL node gets deleted and event > does not get handled - both deletion of TTL node and handling of a trigger > both should either succeed or fail. > > On Mon, Aug 1, 2016 at 5:37 PM, Jordan Zimmerman > wrote: > >> That’s an interesting idea - so a watcher for container expirations? >> >> -Jordan >> >>> On Aug 1, 2016, at 2:20 AM, Stevo Slavić wrote: >>> >>> Hello Apache ZooKeeper developers, >>> >>> Thinking, for a use case like support temporary topics in Apache Kafka, >>> which could be based on ZooKeeper TTL feature, might be useful to be able >>> to register a ZooKeeper "trigger" once TTL expires for a node - e.g. in >>> same transaction that deletes temporary node, create another persistent >>> node (request to delete the topic). Of course one could workaround this, >> by >>> creating persistent and TTL node, and check if there is persistent node >>> without matching temporary node, but option with trigger would have been >>> better/easier from consistency point of view. >>> >>> What do you think about the idea? >>> >>> Kind regards, >>> Stevo Slavic. >>> >>> >>> On Mon, Aug 1, 2016 at 3:31 AM, Raul Gutierrez Segales (JIRA) < >>> j...@apache.org> wrote: >>> [ >> https://issues.apache.org/jira/browse/ZOOKEEPER-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401429#comment-15401429 ] Raul Gutierrez Segales edited comment on ZOOKEEPER-2169 at 8/1/16 1:31 >> AM: >> --- [~fpj]: it's here: https://reviews.apache.org/r/46983/. cc: [~randgalt] was (Author: rgs): [~fpj]: it's here. cc: [~randgalt] > Enable creation of nodes with TTLs > -- > > Key: ZOOKEEPER-2169 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2169 > Project: ZooKeeper >Issue Type: New Feature >Components: c client, java client, jute, server > Affects Versions: 3.6.0 > Reporter: Camille Fournier > Assignee: Jordan Zimmerman > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-2169-2.patch, ZOOKEEPER-2169-3.patch, ZOOKEEPER-2169-4.patch, ZOOKEEPER-2169-5.patch, ZOOKEEPER-2169.patch > > > As a user, I would like to be able to create a node that is NOT tied to a session but that WILL expire automatically if action is not taken by >> some client within a time window. > I propose this to enable clients interacting with ZK via http or other "thin clients" to create ephemeral-like nodes. > Some ideas for the design, up for discussion: > The node should support all normal ZK node operations including ACLs, sequential key generation, etc, however, it should not support the ephemeral flag. The node will be created with a TTL that is updated via >> a refresh operation. > The ZK quorum will watch this node similarly to the way that it watches for session liveness; if the node is not refreshed within the TTL, it >> will expire. > QUESTIONS: > 1) Should we let the refresh operation set the TTL to a different base value? > 2) If so, should the setting of the TTL to a new base value cause a watch to fire? > 3) Do we want to allow these nodes to have children or prevent this similar to ephemeral nodes? -- This message was sent by Atlassian JIRA (v6.3.4#6332) >> >>
Re: [jira] [Comment Edited] (ZOOKEEPER-2169) Enable creation of nodes with TTLs
Imagine a stateless app in front of Kafka/ZooKeeper cluster. It handles request to create a temporary topic. It creates temporary topic, which results in TTL node in ZK, signals success to the caller. And then app crashes or gets restarted or gets relocated to run on different host. Starting it again, with no state, will have no idea about TTL node it created before, TTL node might have died in the meantime, so no on-TTL-node-deletion trigger gets handled and as result ZK has junk content wasting resources. On Mon, Aug 1, 2016 at 9:58 PM, Jordan Zimmerman wrote: > I think it would be simpler and less disruptive to use the existing > Watcher mechanism. Treat it as a deleted node watcher. When the > TTL/container node gets deleted the watcher triggers. Actually, come to > think of it, wouldn’t that work already? Like any other node, after > creating it you can call exists() to set a watcher. Do we really need new > behavior here? > > -Jordan > > > On Aug 1, 2016, at 11:02 AM, Stevo Slavić wrote: > > > > Yes, all server side. Client that successfully creates TTL node and > > registers such "trigger", could disconnect - trigger should fire on TTL > > node deletion and be handled on server side only. So server watching and > > handling event. It shouldn't happen that TTL node gets deleted and event > > does not get handled - both deletion of TTL node and handling of a > trigger > > both should either succeed or fail. > > > > On Mon, Aug 1, 2016 at 5:37 PM, Jordan Zimmerman < > jor...@jordanzimmerman.com > >> wrote: > > > >> That’s an interesting idea - so a watcher for container expirations? > >> > >> -Jordan > >> > >>> On Aug 1, 2016, at 2:20 AM, Stevo Slavić wrote: > >>> > >>> Hello Apache ZooKeeper developers, > >>> > >>> Thinking, for a use case like support temporary topics in Apache Kafka, > >>> which could be based on ZooKeeper TTL feature, might be useful to be > able > >>> to register a ZooKeeper "trigger" once TTL expires for a node - e.g. in > >>> same transaction that deletes temporary node, create another persistent > >>> node (request to delete the topic). Of course one could workaround > this, > >> by > >>> creating persistent and TTL node, and check if there is persistent node > >>> without matching temporary node, but option with trigger would have > been > >>> better/easier from consistency point of view. > >>> > >>> What do you think about the idea? > >>> > >>> Kind regards, > >>> Stevo Slavic. > >>> > >>> > >>> On Mon, Aug 1, 2016 at 3:31 AM, Raul Gutierrez Segales (JIRA) < > >>> j...@apache.org> wrote: > >>> > > [ > > >> > https://issues.apache.org/jira/browse/ZOOKEEPER-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401429#comment-15401429 > ] > > Raul Gutierrez Segales edited comment on ZOOKEEPER-2169 at 8/1/16 1:31 > >> AM: > > >> > --- > > [~fpj]: it's here: https://reviews.apache.org/r/46983/. > > cc: [~randgalt] > > > was (Author: rgs): > [~fpj]: it's here. > > cc: [~randgalt] > > > Enable creation of nodes with TTLs > > -- > > > > Key: ZOOKEEPER-2169 > > URL: > https://issues.apache.org/jira/browse/ZOOKEEPER-2169 > > Project: ZooKeeper > >Issue Type: New Feature > >Components: c client, java client, jute, server > > Affects Versions: 3.6.0 > > Reporter: Camille Fournier > > Assignee: Jordan Zimmerman > > Fix For: 3.6.0 > > > > Attachments: ZOOKEEPER-2169-2.patch, ZOOKEEPER-2169-3.patch, > ZOOKEEPER-2169-4.patch, ZOOKEEPER-2169-5.patch, ZOOKEEPER-2169.patch > > > > > > As a user, I would like to be able to create a node that is NOT tied > to > a session but that WILL expire automatically if action is not taken by > >> some > client within a time window. > > I propose this to enable clients interacting with ZK via http or > other > "thin clients" to create ephemeral-like nodes. > > Some ideas for the design, up for discussion: > > The node should support all normal ZK node operations including ACLs, > sequential key generation, etc, however, it should not support the > ephemeral flag. The node will be created with a TTL that is updated > via > >> a > refresh operation. > > The ZK quorum will watch this node similarly to the way that it > watches > for session liveness; if the node is not refreshed within the TTL, it > >> will > expire. > > QUESTIONS: > > 1) Should we let the refresh operation set the TTL to a different > base > value? > > 2) If so, should the setting of the TTL to a new base value cause a > watch to fire? > > 3) Do we want to allow these nodes to have children or prevent this >
Re: [jira] [Comment Edited] (ZOOKEEPER-2169) Enable creation of nodes with TTLs
But that’s a common pattern with ZooKeeper. Curator has PersistentEphemeralNode for just this type of use-case. > On Aug 1, 2016, at 3:41 PM, Stevo Slavić wrote: > > Imagine a stateless app in front of Kafka/ZooKeeper cluster. It handles > request to create a temporary topic. It creates temporary topic, which > results in TTL node in ZK, signals success to the caller. And then app > crashes or gets restarted or gets relocated to run on different host. > Starting it again, with no state, will have no idea about TTL node it > created before, TTL node might have died in the meantime, so no > on-TTL-node-deletion trigger gets handled and as result ZK has junk content > wasting resources. > > On Mon, Aug 1, 2016 at 9:58 PM, Jordan Zimmerman > wrote: > >> I think it would be simpler and less disruptive to use the existing >> Watcher mechanism. Treat it as a deleted node watcher. When the >> TTL/container node gets deleted the watcher triggers. Actually, come to >> think of it, wouldn’t that work already? Like any other node, after >> creating it you can call exists() to set a watcher. Do we really need new >> behavior here? >> >> -Jordan >> >>> On Aug 1, 2016, at 11:02 AM, Stevo Slavić wrote: >>> >>> Yes, all server side. Client that successfully creates TTL node and >>> registers such "trigger", could disconnect - trigger should fire on TTL >>> node deletion and be handled on server side only. So server watching and >>> handling event. It shouldn't happen that TTL node gets deleted and event >>> does not get handled - both deletion of TTL node and handling of a >> trigger >>> both should either succeed or fail. >>> >>> On Mon, Aug 1, 2016 at 5:37 PM, Jordan Zimmerman < >> jor...@jordanzimmerman.com wrote: >>> That’s an interesting idea - so a watcher for container expirations? -Jordan > On Aug 1, 2016, at 2:20 AM, Stevo Slavić wrote: > > Hello Apache ZooKeeper developers, > > Thinking, for a use case like support temporary topics in Apache Kafka, > which could be based on ZooKeeper TTL feature, might be useful to be >> able > to register a ZooKeeper "trigger" once TTL expires for a node - e.g. in > same transaction that deletes temporary node, create another persistent > node (request to delete the topic). Of course one could workaround >> this, by > creating persistent and TTL node, and check if there is persistent node > without matching temporary node, but option with trigger would have >> been > better/easier from consistency point of view. > > What do you think about the idea? > > Kind regards, > Stevo Slavic. > > > On Mon, Aug 1, 2016 at 3:31 AM, Raul Gutierrez Segales (JIRA) < > j...@apache.org> wrote: > >> >> [ >> >> https://issues.apache.org/jira/browse/ZOOKEEPER-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401429#comment-15401429 >> ] >> >> Raul Gutierrez Segales edited comment on ZOOKEEPER-2169 at 8/1/16 1:31 AM: >> >> --- >> >> [~fpj]: it's here: https://reviews.apache.org/r/46983/. >> >> cc: [~randgalt] >> >> >> was (Author: rgs): >> [~fpj]: it's here. >> >> cc: [~randgalt] >> >>> Enable creation of nodes with TTLs >>> -- >>> >>> Key: ZOOKEEPER-2169 >>> URL: >> https://issues.apache.org/jira/browse/ZOOKEEPER-2169 >>> Project: ZooKeeper >>> Issue Type: New Feature >>> Components: c client, java client, jute, server >>> Affects Versions: 3.6.0 >>> Reporter: Camille Fournier >>> Assignee: Jordan Zimmerman >>> Fix For: 3.6.0 >>> >>> Attachments: ZOOKEEPER-2169-2.patch, ZOOKEEPER-2169-3.patch, >> ZOOKEEPER-2169-4.patch, ZOOKEEPER-2169-5.patch, ZOOKEEPER-2169.patch >>> >>> >>> As a user, I would like to be able to create a node that is NOT tied >> to >> a session but that WILL expire automatically if action is not taken by some >> client within a time window. >>> I propose this to enable clients interacting with ZK via http or >> other >> "thin clients" to create ephemeral-like nodes. >>> Some ideas for the design, up for discussion: >>> The node should support all normal ZK node operations including ACLs, >> sequential key generation, etc, however, it should not support the >> ephemeral flag. The node will be created with a TTL that is updated >> via a >> refresh operation. >>> The ZK quorum will watch this node similarly to the way that it >> watches >> for session liveness; if the node is not refreshed within the TTL, it will >> expire. >>> QUESTIONS: >>> 1) Should we let the refresh operati
[jira] [Commented] (ZOOKEEPER-1863) Race condition in commit processor leading to out of order request completion, xid mismatch on client.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402819#comment-15402819
]
Artem Golotin commented on ZOOKEEPER-1863:
--
Hi! I was able to reproduce the same issue as mentioned in
[ZOOKEEPER-2151|https://issues.apache.org/jira/browse/ZOOKEEPER-2151]. Here is
the output from the stat command:
{noformat}
Zookeeper version: 3.5.1-alpha--1, built on 07/08/2016 17:08 GMT
Clients:
/0:0:0:0:0:0:0:1:59312[0](queued=0,recved=1,sent=0)
/10.2.29.7:34266[0](queued=0,recved=1,sent=0)
/10.2.29.7:55996[0](queued=0,recved=1,sent=0)
/10.2.81.3:48640[0](queued=0,recved=1,sent=0)
Latency min/avg/max: 0/1/826
Received: 2199007
Sent: 935511
Connections: 4
Outstanding: 48112
Zxid: 0x100011d4e
Mode: leader
Node count: 171
{noformat}
Notice the number of outstanding connections
After examining the code I found that the patch that have been submitted with
this issue was applied to the code. With my limited experience I do not believe
that I will be able to reproduce the issue, but I am saving the full stdout
zookeeper output and can provide it if needed. However, I cannot provide you
with a jstack dump, because when I try to do so (even with -F option), it
generates the following exception:
{noformat}
Error attaching to process: sun.jvm.hotspot.debugger.DebuggerException: Can't
attach to the process
{noformat}
Unfortunately, the issue seems to have happened on Sunday when I was not able
to check the health of my cluster or perform any immediate fixes. I do have
several Kazoo clients + Kafka + Secor that are using zookeeper, and as all
those are failing now with zookeeper outputting the following logs:
{noformat}
2016-08-01 20:45:51,828 - INFO
[NIOServerCxnFactory.AcceptThread:/0.0.0.0:2181:NIOServerCnxnFactory$AcceptThread@296]
- Accepted socket connection from /10.2.81.3:50656
2016-08-01 20:45:51,829 - INFO [NIOWorkerThread-4:ZooKeeperServer@931] -
Client attempting to establish new session at /10.2.81.3:50656
2016-08-01 20:45:53,723 - INFO
[NIOServerCxnFactory.AcceptThread:/0.0.0.0:2181:NIOServerCnxnFactory$AcceptThread@296]
- Accepted socket connection from /10.2.29.7:35862
2016-08-01 20:45:53,725 - INFO [NIOWorkerThread-3:ZooKeeperServer@931] -
Client attempting to establish new session at /10.2.29.7:35862
2016-08-01 20:45:59,171 - INFO
[NIOServerCxnFactory.AcceptThread:/0.0.0.0:2181:NIOServerCnxnFactory$AcceptThread@296]
- Accepted socket connection from /10.2.81.3:50658
2016-08-01 20:45:59,172 - INFO [NIOWorkerThread-1:ZooKeeperServer@931] -
Client attempting to establish new session at /10.2.81.3:50658
2016-08-01 20:46:00,223 - INFO [ConnnectionExpirer:NIOServerCnxn@1007] -
Closed socket connection for client /10.2.29.7:35828 which had sessionid
0x10044f682c45bdd
2016-08-01 20:46:00,223 - INFO [ConnnectionExpirer:NIOServerCnxn@1007] -
Closed socket connection for client /10.2.81.3:50656 which had sessionid
0x10044f682c45bdf
2016-08-01 20:46:05,013 - INFO
[NIOServerCxnFactory.AcceptThread:/0.0.0.0:2181:NIOServerCnxnFactory$AcceptThread@296]
- Accepted socket connection from /10.2.29.7:35898
2016-08-01 20:46:05,028 - INFO [NIOWorkerThread-2:NIOServerCnxn@836] -
Processing ruok command from /10.2.29.7:35898
2016-08-01 20:46:05,029 - INFO [NIOWorkerThread-2:NIOServerCnxn@1007] - Closed
socket connection for client /10.2.29.7:35898 (no session established for
client)
2016-08-01 20:46:05,146 - INFO
[NIOServerCxnFactory.AcceptThread:/0.0.0.0:2181:NIOServerCnxnFactory$AcceptThread@296]
- Accepted socket connection from /10.2.29.7:35900
2016-08-01 20:46:05,153 - INFO [NIOWorkerThread-4:NIOServerCnxn@836] -
Processing srvr command from /10.2.29.7:35900
2016-08-01 20:46:05,153 - INFO [NIOWorkerThread-4:NIOServerCnxn@1007] - Closed
socket connection for client /10.2.29.7:35900 (no session established for
client)
2016-08-01 20:46:05,617 - INFO
[NIOServerCxnFactory.AcceptThread:/0.0.0.0:2181:NIOServerCnxnFactory$AcceptThread@296]
- Accepted socket connection from /10.2.29.7:35904
2016-08-01 20:46:05,617 - INFO [NIOWorkerThread-3:NIOServerCnxn@836] -
Processing ruok command from /10.2.29.7:35904
2016-08-01 20:46:05,618 - INFO [NIOWorkerThread-3:NIOServerCnxn@1007] - Closed
socket connection for client /10.2.29.7:35904 (no session established for
client)
2016-08-01 20:46:05,634 - INFO
[NIOServerCxnFactory.AcceptThread:/0.0.0.0:2181:NIOServerCnxnFactory$AcceptThread@296]
- Accepted socket connection from /10.2.29.7:35906
2016-08-01 20:46:05,634 - INFO [NIOWorkerThread-1:NIOServerCnxn@836] -
Processing srvr command from /10.2.29.7:35906
2016-08-01 20:46:05,636 - INFO [NIOWorkerThread-1:NIOServerCnxn@1007] - Closed
socket connection for client /10.2.29.7:35906 (no session established for
client)
2016-08-01 20:46:05,644 - INFO
[NIOServerCxnFactory.AcceptThread:/0.0.0.0:2181:NIOServerCnxnFactory$AcceptThread@296]
- Accepte
[jira] [Comment Edited] (ZOOKEEPER-1863) Race condition in commit processor leading to out of order request completion, xid mismatch on client.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402819#comment-15402819
]
Artem Golotin edited comment on ZOOKEEPER-1863 at 8/1/16 10:26 PM:
---
Hi! I was able to reproduce the same issue as mentioned in
[ZOOKEEPER-2151|https://issues.apache.org/jira/browse/ZOOKEEPER-2151]. Here is
the output from the stat command:
{noformat}
Zookeeper version: 3.5.1-alpha--1, built on 07/08/2016 17:08 GMT
Clients:
/0:0:0:0:0:0:0:1:59312[0](queued=0,recved=1,sent=0)
/10.2.29.7:34266[0](queued=0,recved=1,sent=0)
/10.2.29.7:55996[0](queued=0,recved=1,sent=0)
/10.2.81.3:48640[0](queued=0,recved=1,sent=0)
Latency min/avg/max: 0/1/826
Received: 2199007
Sent: 935511
Connections: 4
Outstanding: 48112
Zxid: 0x100011d4e
Mode: leader
Node count: 171
{noformat}
Notice the number of outstanding connections
After examining the code I found that the patch that have been submitted with
this issue was applied to the code. With my limited experience I do not believe
that I will be able to reproduce the issue, but I am saving the full stdout
zookeeper output and can provide it if needed.
Here's jstack dump:
{noformat}
Full thread dump OpenJDK 64-Bit Server VM (24.95-b01 mixed mode):
"NIOWorkerThread-4" daemon prio=10 tid=0x7fbb9c007000 nid=0x1a7 waiting on
condition [0x7fbbd84ce000]
java.lang.Thread.State: WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for <0xc18ed460> (a
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2043)
at
java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
at
java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1068)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
"NIOWorkerThread-3" daemon prio=10 tid=0x7fbb9c005000 nid=0x1a6 waiting on
condition [0x7fbbd85cf000]
java.lang.Thread.State: WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for <0xc18ed460> (a
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2043)
at
java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
at
java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1068)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
"NIOWorkerThread-2" daemon prio=10 tid=0x7fbb9c003800 nid=0x1a4 waiting on
condition [0x7fbbd87d1000]
java.lang.Thread.State: WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for <0xc18ed460> (a
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2043)
at
java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
at
java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1068)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
"ContainerManagerTask" daemon prio=10 tid=0x7fbbb801b800 nid=0x1a3 in
Object.wait() [0x7fbbd88d2000]
java.lang.Thread.State: WAITING (on object monitor)
at java.lang.Object.wait(Native Method)
at java.lang.Object.wait(Object.java:503)
at java.util.TimerThread.mainLoop(Timer.java:526)
- locked <0xc190fa68> (a java.util.TaskQueue)
at java.util.TimerThread.run(Timer.java:505)
"SyncThread:1" prio=10 tid=0x7fbbb8016000 nid=0x1a1 in Object.wait()
[0x7fbbd8ad4000]
java.lang.Thread.State: WAITING (on object monitor)
at java.lang.Object.wait(Native Method)
at java.lang.Thread.join(Thread.java:1281)
- locked <0xc195c128> (a
org.apache.zookeeper.server.SyncRequestProcessor)
at java.lang.Thread.j
[jira] [Comment Edited] (ZOOKEEPER-1863) Race condition in commit processor leading to out of order request completion, xid mismatch on client.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402819#comment-15402819
]
Artem Golotin edited comment on ZOOKEEPER-1863 at 8/1/16 10:27 PM:
---
Hi! I was able to reproduce the same issue as mentioned in
[ZOOKEEPER-2151|https://issues.apache.org/jira/browse/ZOOKEEPER-2151]. Here is
the output from the stat command:
{noformat}
Zookeeper version: 3.5.1-alpha--1, built on 07/08/2016 17:08 GMT
Clients:
/0:0:0:0:0:0:0:1:59312[0](queued=0,recved=1,sent=0)
/10.2.29.7:34266[0](queued=0,recved=1,sent=0)
/10.2.29.7:55996[0](queued=0,recved=1,sent=0)
/10.2.81.3:48640[0](queued=0,recved=1,sent=0)
Latency min/avg/max: 0/1/826
Received: 2199007
Sent: 935511
Connections: 4
Outstanding: 48112
Zxid: 0x100011d4e
Mode: leader
Node count: 171
{noformat}
Notice the number of outstanding connections
After examining the code I found that the patch that have been submitted with
this issue was applied to the code. With my limited experience I do not believe
that I will be able to reproduce the issue, but I am saving the full stdout
zookeeper output and can provide it if needed.
Here's jstack dump:
{noformat}
Full thread dump OpenJDK 64-Bit Server VM (24.95-b01 mixed mode):
"NIOWorkerThread-4" daemon prio=10 tid=0x7fbb9c007000 nid=0x1a7 waiting on
condition [0x7fbbd84ce000]
java.lang.Thread.State: WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for <0xc18ed460> (a
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2043)
at
java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
at
java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1068)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
"NIOWorkerThread-3" daemon prio=10 tid=0x7fbb9c005000 nid=0x1a6 waiting on
condition [0x7fbbd85cf000]
java.lang.Thread.State: WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for <0xc18ed460> (a
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2043)
at
java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
at
java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1068)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
"NIOWorkerThread-2" daemon prio=10 tid=0x7fbb9c003800 nid=0x1a4 waiting on
condition [0x7fbbd87d1000]
java.lang.Thread.State: WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for <0xc18ed460> (a
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2043)
at
java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
at
java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1068)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
"ContainerManagerTask" daemon prio=10 tid=0x7fbbb801b800 nid=0x1a3 in
Object.wait() [0x7fbbd88d2000]
java.lang.Thread.State: WAITING (on object monitor)
at java.lang.Object.wait(Native Method)
at java.lang.Object.wait(Object.java:503)
at java.util.TimerThread.mainLoop(Timer.java:526)
- locked <0xc190fa68> (a java.util.TaskQueue)
at java.util.TimerThread.run(Timer.java:505)
"SyncThread:1" prio=10 tid=0x7fbbb8016000 nid=0x1a1 in Object.wait()
[0x7fbbd8ad4000]
java.lang.Thread.State: WAITING (on object monitor)
at java.lang.Object.wait(Native Method)
at java.lang.Thread.join(Thread.java:1281)
- locked <0xc195c128> (a
org.apache.zookeeper.server.SyncRequestProcessor)
at java.lang.Thread.j
[jira] [Updated] (ZOOKEEPER-2080) ReconfigRecoveryTest fails intermittently
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Han updated ZOOKEEPER-2080:
---
Attachment: ZOOKEEPER-2080.patch
> ReconfigRecoveryTest fails intermittently
> -
>
> Key: ZOOKEEPER-2080
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2080
> Project: ZooKeeper
> Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Michael Han
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2080.patch, ZOOKEEPER-2080.patch,
> ZOOKEEPER-2080.patch, jacoco-ZOOKEEPER-2080.unzip-grows-to-70MB.7z,
> repro-20150816.log, threaddump.log
>
>
> I got the following test failure on MacBook with trunk code:
> {code}
> Testcase: testCurrentObserverIsParticipantInNewConfig took 93.628 sec
> FAILED
> waiting for server 2 being up
> junit.framework.AssertionFailedError: waiting for server 2 being up
> at
> org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig(ReconfigRecoveryTest.java:529)
> at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2080) ReconfigRecoveryTest fails intermittently
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403146#comment-15403146
]
Michael Han commented on ZOOKEEPER-2080:
[~rgs] Thanks for your feedback :)
bq. Do we really need to synchronize around self for the first part
Good point, self.configFromString does not involve state changes and for
self.getQuorumVerifier, I can't find another place in code where a race could
be possibly introduced that require self.getQuorumVerifier and the subsequent
to be an atomic code block - so I moved them out of sync block and updated
patch. CC [~shralex] just to double check.
bq. could you maybe add a comment before the synchronize(self) block
Comments added in latest patch.
> ReconfigRecoveryTest fails intermittently
> -
>
> Key: ZOOKEEPER-2080
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2080
> Project: ZooKeeper
> Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Michael Han
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2080.patch, ZOOKEEPER-2080.patch,
> ZOOKEEPER-2080.patch, jacoco-ZOOKEEPER-2080.unzip-grows-to-70MB.7z,
> repro-20150816.log, threaddump.log
>
>
> I got the following test failure on MacBook with trunk code:
> {code}
> Testcase: testCurrentObserverIsParticipantInNewConfig took 93.628 sec
> FAILED
> waiting for server 2 being up
> junit.framework.AssertionFailedError: waiting for server 2 being up
> at
> org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig(ReconfigRecoveryTest.java:529)
> at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (ZOOKEEPER-2080) ReconfigRecoveryTest fails intermittently
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403146#comment-15403146
]
Michael Han edited comment on ZOOKEEPER-2080 at 8/2/16 1:02 AM:
[~rgs] Thanks for your feedback :). New patch uploaded based on your feedback.
bq. Do we really need to synchronize around self for the first part
Good point, self.configFromString does not involve state changes and for
self.getQuorumVerifier, I can't find another place in code where a race could
be possibly introduced that require self.getQuorumVerifier and the subsequent
to be an atomic code block - so I moved them out of sync block and updated
patch. CC [~shralex] just to double check.
bq. could you maybe add a comment before the synchronize(self) block
Comments added in latest patch.
was (Author: hanm):
[~rgs] Thanks for your feedback :)
bq. Do we really need to synchronize around self for the first part
Good point, self.configFromString does not involve state changes and for
self.getQuorumVerifier, I can't find another place in code where a race could
be possibly introduced that require self.getQuorumVerifier and the subsequent
to be an atomic code block - so I moved them out of sync block and updated
patch. CC [~shralex] just to double check.
bq. could you maybe add a comment before the synchronize(self) block
Comments added in latest patch.
> ReconfigRecoveryTest fails intermittently
> -
>
> Key: ZOOKEEPER-2080
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2080
> Project: ZooKeeper
> Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Michael Han
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2080.patch, ZOOKEEPER-2080.patch,
> ZOOKEEPER-2080.patch, jacoco-ZOOKEEPER-2080.unzip-grows-to-70MB.7z,
> repro-20150816.log, threaddump.log
>
>
> I got the following test failure on MacBook with trunk code:
> {code}
> Testcase: testCurrentObserverIsParticipantInNewConfig took 93.628 sec
> FAILED
> waiting for server 2 being up
> junit.framework.AssertionFailedError: waiting for server 2 being up
> at
> org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig(ReconfigRecoveryTest.java:529)
> at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Failed: ZOOKEEPER-2080 PreCommit Build #3318
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2080 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3318/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 957711 lines...] [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3318//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3318//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3318//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] f0c3fd23d13571f5f7c72a4dcda631dd115f6db0 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1605: exec returned: 2 Total time: 22 minutes 40 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Compressed 559.77 KB of artifacts by 45.7% relative to #3317 Recording test results Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 [description-setter] Description set: ZOOKEEPER-2080 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 ### ## FAILED TESTS (if any) ## 1 tests failed. FAILED: org.apache.zookeeper.test.QuorumTest.testMultipleWatcherObjs Error Message: Timeout occurred. Please note the time in the report does not reflect the time until the timeout. Stack Trace: junit.framework.AssertionFailedError: Timeout occurred. Please note the time in the report does not reflect the time until the timeout. at java.lang.Thread.run(Thread.java:745)
[jira] [Commented] (ZOOKEEPER-2080) ReconfigRecoveryTest fails intermittently
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403173#comment-15403173
]
Hadoop QA commented on ZOOKEEPER-2080:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12821475/ZOOKEEPER-2080.patch
against trunk revision 1754582.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3318//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3318//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3318//console
This message is automatically generated.
> ReconfigRecoveryTest fails intermittently
> -
>
> Key: ZOOKEEPER-2080
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2080
> Project: ZooKeeper
> Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Michael Han
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2080.patch, ZOOKEEPER-2080.patch,
> ZOOKEEPER-2080.patch, jacoco-ZOOKEEPER-2080.unzip-grows-to-70MB.7z,
> repro-20150816.log, threaddump.log
>
>
> I got the following test failure on MacBook with trunk code:
> {code}
> Testcase: testCurrentObserverIsParticipantInNewConfig took 93.628 sec
> FAILED
> waiting for server 2 being up
> junit.framework.AssertionFailedError: waiting for server 2 being up
> at
> org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig(ReconfigRecoveryTest.java:529)
> at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2247) Zookeeper service becomes unavailable when leader fails to write transaction log
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403413#comment-15403413
]
Raul Gutierrez Segales commented on ZOOKEEPER-2247:
---
[~rakeshr]: sorry for dropping the ball here. Lgtm, +1. One nit though:
{code}
+if ((state == State.ERROR) || (state == State.SHUTDOWN)) {
{code}
Drop the extra ()s around the state checks, it's readable enough without them.
I can merge this once we have a +1 from Flavio as well. Thanks!
> Zookeeper service becomes unavailable when leader fails to write transaction
> log
>
>
> Key: ZOOKEEPER-2247
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2247
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.9, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2247-01.patch, ZOOKEEPER-2247-02.patch,
> ZOOKEEPER-2247-03.patch, ZOOKEEPER-2247-04.patch, ZOOKEEPER-2247-05.patch,
> ZOOKEEPER-2247-06.patch, ZOOKEEPER-2247-07.patch, ZOOKEEPER-2247-09.patch,
> ZOOKEEPER-2247-10.patch, ZOOKEEPER-2247-11.patch, ZOOKEEPER-2247-12.patch,
> ZOOKEEPER-2247-13.patch, ZOOKEEPER-2247-14.patch, ZOOKEEPER-2247-15.patch,
> ZOOKEEPER-2247-16.patch, ZOOKEEPER-2247-17.patch, ZOOKEEPER-2247-18.patch,
> ZOOKEEPER-2247-19.patch, ZOOKEEPER-2247-b3.5.patch,
> ZOOKEEPER-2247-br-3.4.patch
>
>
> Zookeeper service becomes unavailable when leader fails to write transaction
> log. Bellow are the exceptions
> {code}
> 2015-08-14 15:41:18,556 [myid:100] - ERROR
> [SyncThread:100:ZooKeeperCriticalThread@48] - Severe unrecoverable error,
> from thread : SyncThread:100
> java.io.IOException: Input/output error
> at sun.nio.ch.FileDispatcherImpl.force0(Native Method)
> at sun.nio.ch.FileDispatcherImpl.force(FileDispatcherImpl.java:76)
> at sun.nio.ch.FileChannelImpl.force(FileChannelImpl.java:376)
> at
> org.apache.zookeeper.server.persistence.FileTxnLog.commit(FileTxnLog.java:331)
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.commit(FileTxnSnapLog.java:380)
> at org.apache.zookeeper.server.ZKDatabase.commit(ZKDatabase.java:563)
> at
> org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:178)
> at
> org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:113)
> 2015-08-14 15:41:18,559 [myid:100] - INFO
> [SyncThread:100:ZooKeeperServer$ZooKeeperServerListenerImpl@500] - Thread
> SyncThread:100 exits, error code 1
> 2015-08-14 15:41:18,559 [myid:100] - INFO
> [SyncThread:100:ZooKeeperServer@523] - shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO
> [SyncThread:100:SessionTrackerImpl@232] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO
> [SyncThread:100:LeaderRequestProcessor@77] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO
> [SyncThread:100:PrepRequestProcessor@1035] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO
> [SyncThread:100:ProposalRequestProcessor@88] - Shutting down
> 2015-08-14 15:41:18,561 [myid:100] - INFO
> [SyncThread:100:CommitProcessor@356] - Shutting down
> 2015-08-14 15:41:18,561 [myid:100] - INFO
> [CommitProcessor:100:CommitProcessor@191] - CommitProcessor exited loop!
> 2015-08-14 15:41:18,562 [myid:100] - INFO
> [SyncThread:100:Leader$ToBeAppliedRequestProcessor@915] - Shutting down
> 2015-08-14 15:41:18,562 [myid:100] - INFO
> [SyncThread:100:FinalRequestProcessor@646] - shutdown of request processor
> complete
> 2015-08-14 15:41:18,562 [myid:100] - INFO
> [SyncThread:100:SyncRequestProcessor@191] - Shutting down
> 2015-08-14 15:41:18,563 [myid:100] - INFO [ProcessThread(sid:100
> cport:-1)::PrepRequestProcessor@159] - PrepRequestProcessor exited loop!
> {code}
> After this exception Leader server still remains leader. After this non
> recoverable exception the leader should go down and let other followers
> become leader.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2247) Zookeeper service becomes unavailable when leader fails to write transaction log
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated ZOOKEEPER-2247:
Attachment: ZOOKEEPER-2247-20.patch
> Zookeeper service becomes unavailable when leader fails to write transaction
> log
>
>
> Key: ZOOKEEPER-2247
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2247
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.9, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2247-01.patch, ZOOKEEPER-2247-02.patch,
> ZOOKEEPER-2247-03.patch, ZOOKEEPER-2247-04.patch, ZOOKEEPER-2247-05.patch,
> ZOOKEEPER-2247-06.patch, ZOOKEEPER-2247-07.patch, ZOOKEEPER-2247-09.patch,
> ZOOKEEPER-2247-10.patch, ZOOKEEPER-2247-11.patch, ZOOKEEPER-2247-12.patch,
> ZOOKEEPER-2247-13.patch, ZOOKEEPER-2247-14.patch, ZOOKEEPER-2247-15.patch,
> ZOOKEEPER-2247-16.patch, ZOOKEEPER-2247-17.patch, ZOOKEEPER-2247-18.patch,
> ZOOKEEPER-2247-19.patch, ZOOKEEPER-2247-20.patch, ZOOKEEPER-2247-b3.5.patch,
> ZOOKEEPER-2247-br-3.4.patch
>
>
> Zookeeper service becomes unavailable when leader fails to write transaction
> log. Bellow are the exceptions
> {code}
> 2015-08-14 15:41:18,556 [myid:100] - ERROR
> [SyncThread:100:ZooKeeperCriticalThread@48] - Severe unrecoverable error,
> from thread : SyncThread:100
> java.io.IOException: Input/output error
> at sun.nio.ch.FileDispatcherImpl.force0(Native Method)
> at sun.nio.ch.FileDispatcherImpl.force(FileDispatcherImpl.java:76)
> at sun.nio.ch.FileChannelImpl.force(FileChannelImpl.java:376)
> at
> org.apache.zookeeper.server.persistence.FileTxnLog.commit(FileTxnLog.java:331)
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.commit(FileTxnSnapLog.java:380)
> at org.apache.zookeeper.server.ZKDatabase.commit(ZKDatabase.java:563)
> at
> org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:178)
> at
> org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:113)
> 2015-08-14 15:41:18,559 [myid:100] - INFO
> [SyncThread:100:ZooKeeperServer$ZooKeeperServerListenerImpl@500] - Thread
> SyncThread:100 exits, error code 1
> 2015-08-14 15:41:18,559 [myid:100] - INFO
> [SyncThread:100:ZooKeeperServer@523] - shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO
> [SyncThread:100:SessionTrackerImpl@232] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO
> [SyncThread:100:LeaderRequestProcessor@77] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO
> [SyncThread:100:PrepRequestProcessor@1035] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO
> [SyncThread:100:ProposalRequestProcessor@88] - Shutting down
> 2015-08-14 15:41:18,561 [myid:100] - INFO
> [SyncThread:100:CommitProcessor@356] - Shutting down
> 2015-08-14 15:41:18,561 [myid:100] - INFO
> [CommitProcessor:100:CommitProcessor@191] - CommitProcessor exited loop!
> 2015-08-14 15:41:18,562 [myid:100] - INFO
> [SyncThread:100:Leader$ToBeAppliedRequestProcessor@915] - Shutting down
> 2015-08-14 15:41:18,562 [myid:100] - INFO
> [SyncThread:100:FinalRequestProcessor@646] - shutdown of request processor
> complete
> 2015-08-14 15:41:18,562 [myid:100] - INFO
> [SyncThread:100:SyncRequestProcessor@191] - Shutting down
> 2015-08-14 15:41:18,563 [myid:100] - INFO [ProcessThread(sid:100
> cport:-1)::PrepRequestProcessor@159] - PrepRequestProcessor exited loop!
> {code}
> After this exception Leader server still remains leader. After this non
> recoverable exception the leader should go down and let other followers
> become leader.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2080) ReconfigRecoveryTest fails intermittently
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403431#comment-15403431
]
Raul Gutierrez Segales commented on ZOOKEEPER-2080:
---
[~hanm]: thanks for the updated patch! I think the failure with
org.apache.zookeeper.test.QuorumTest.testMultipleWatcherObjs is unrelated, have
you seen it fail before? Passes for me locally:
{code}
~/src/zookeeper-svn (master) ✔ function runt() { ant -Dtestcase=$1
test-core-java; }
~/src/zookeeper-svn (master) ✔ runt QuorumTest
()
junit.run-concurrent:
[echo] Running 1 concurrent JUnit processes.
[junit] WARNING: multiple versions of ant detected in path for junit
[junit]
jar:file:/usr/share/java/ant/ant.jar!/org/apache/tools/ant/Project.class
[junit] and
jar:file:/usr/share/ant/lib/ant.jar!/org/apache/tools/ant/Project.class
[junit] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf8
[junit] Running org.apache.zookeeper.test.QuorumTest
[junit] Tests run: 15, Failures: 0, Errors: 0, Skipped: 1, Time elapsed:
125.227 sec
junit.run:
test-core-java:
BUILD SUCCESSFUL
Total time: 2 minutes 52 seconds
{code}
Other than that, lgtm -- +1.
[~shralex]: what do you think?
Happy to merge this after Alex gets another look. Thanks!
> ReconfigRecoveryTest fails intermittently
> -
>
> Key: ZOOKEEPER-2080
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2080
> Project: ZooKeeper
> Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Michael Han
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2080.patch, ZOOKEEPER-2080.patch,
> ZOOKEEPER-2080.patch, jacoco-ZOOKEEPER-2080.unzip-grows-to-70MB.7z,
> repro-20150816.log, threaddump.log
>
>
> I got the following test failure on MacBook with trunk code:
> {code}
> Testcase: testCurrentObserverIsParticipantInNewConfig took 93.628 sec
> FAILED
> waiting for server 2 being up
> junit.framework.AssertionFailedError: waiting for server 2 being up
> at
> org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig(ReconfigRecoveryTest.java:529)
> at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2247) Zookeeper service becomes unavailable when leader fails to write transaction log
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403436#comment-15403436
]
Rakesh R commented on ZOOKEEPER-2247:
-
Thanks [~rgs] for the reviews, attached new patch addressing the same. It seems
separate patch for {{branch-3.4}} is needed, I'll upload once it is ready for
commit.
> Zookeeper service becomes unavailable when leader fails to write transaction
> log
>
>
> Key: ZOOKEEPER-2247
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2247
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.9, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2247-01.patch, ZOOKEEPER-2247-02.patch,
> ZOOKEEPER-2247-03.patch, ZOOKEEPER-2247-04.patch, ZOOKEEPER-2247-05.patch,
> ZOOKEEPER-2247-06.patch, ZOOKEEPER-2247-07.patch, ZOOKEEPER-2247-09.patch,
> ZOOKEEPER-2247-10.patch, ZOOKEEPER-2247-11.patch, ZOOKEEPER-2247-12.patch,
> ZOOKEEPER-2247-13.patch, ZOOKEEPER-2247-14.patch, ZOOKEEPER-2247-15.patch,
> ZOOKEEPER-2247-16.patch, ZOOKEEPER-2247-17.patch, ZOOKEEPER-2247-18.patch,
> ZOOKEEPER-2247-19.patch, ZOOKEEPER-2247-20.patch, ZOOKEEPER-2247-b3.5.patch,
> ZOOKEEPER-2247-br-3.4.patch
>
>
> Zookeeper service becomes unavailable when leader fails to write transaction
> log. Bellow are the exceptions
> {code}
> 2015-08-14 15:41:18,556 [myid:100] - ERROR
> [SyncThread:100:ZooKeeperCriticalThread@48] - Severe unrecoverable error,
> from thread : SyncThread:100
> java.io.IOException: Input/output error
> at sun.nio.ch.FileDispatcherImpl.force0(Native Method)
> at sun.nio.ch.FileDispatcherImpl.force(FileDispatcherImpl.java:76)
> at sun.nio.ch.FileChannelImpl.force(FileChannelImpl.java:376)
> at
> org.apache.zookeeper.server.persistence.FileTxnLog.commit(FileTxnLog.java:331)
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.commit(FileTxnSnapLog.java:380)
> at org.apache.zookeeper.server.ZKDatabase.commit(ZKDatabase.java:563)
> at
> org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:178)
> at
> org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:113)
> 2015-08-14 15:41:18,559 [myid:100] - INFO
> [SyncThread:100:ZooKeeperServer$ZooKeeperServerListenerImpl@500] - Thread
> SyncThread:100 exits, error code 1
> 2015-08-14 15:41:18,559 [myid:100] - INFO
> [SyncThread:100:ZooKeeperServer@523] - shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO
> [SyncThread:100:SessionTrackerImpl@232] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO
> [SyncThread:100:LeaderRequestProcessor@77] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO
> [SyncThread:100:PrepRequestProcessor@1035] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO
> [SyncThread:100:ProposalRequestProcessor@88] - Shutting down
> 2015-08-14 15:41:18,561 [myid:100] - INFO
> [SyncThread:100:CommitProcessor@356] - Shutting down
> 2015-08-14 15:41:18,561 [myid:100] - INFO
> [CommitProcessor:100:CommitProcessor@191] - CommitProcessor exited loop!
> 2015-08-14 15:41:18,562 [myid:100] - INFO
> [SyncThread:100:Leader$ToBeAppliedRequestProcessor@915] - Shutting down
> 2015-08-14 15:41:18,562 [myid:100] - INFO
> [SyncThread:100:FinalRequestProcessor@646] - shutdown of request processor
> complete
> 2015-08-14 15:41:18,562 [myid:100] - INFO
> [SyncThread:100:SyncRequestProcessor@191] - Shutting down
> 2015-08-14 15:41:18,563 [myid:100] - INFO [ProcessThread(sid:100
> cport:-1)::PrepRequestProcessor@159] - PrepRequestProcessor exited loop!
> {code}
> After this exception Leader server still remains leader. After this non
> recoverable exception the leader should go down and let other followers
> become leader.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Success: ZOOKEEPER-2247 PreCommit Build #3319
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2247 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3319/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 446893 lines...] [exec] http://issues.apache.org/jira/secure/attachment/12821512/ZOOKEEPER-2247-20.patch [exec] against trunk revision 1754582. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3319//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3319//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3319//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 1ab19447c057887404bd02e22db7d76bcc12d28f logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 20 minutes 20 seconds Archiving artifacts Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Recording test results Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 [description-setter] Description set: ZOOKEEPER-2247 Email was triggered for: Success Sending email for trigger: Success Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-2247) Zookeeper service becomes unavailable when leader fails to write transaction log
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403469#comment-15403469
]
Hadoop QA commented on ZOOKEEPER-2247:
--
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12821512/ZOOKEEPER-2247-20.patch
against trunk revision 1754582.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3319//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3319//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3319//console
This message is automatically generated.
> Zookeeper service becomes unavailable when leader fails to write transaction
> log
>
>
> Key: ZOOKEEPER-2247
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2247
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.9, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2247-01.patch, ZOOKEEPER-2247-02.patch,
> ZOOKEEPER-2247-03.patch, ZOOKEEPER-2247-04.patch, ZOOKEEPER-2247-05.patch,
> ZOOKEEPER-2247-06.patch, ZOOKEEPER-2247-07.patch, ZOOKEEPER-2247-09.patch,
> ZOOKEEPER-2247-10.patch, ZOOKEEPER-2247-11.patch, ZOOKEEPER-2247-12.patch,
> ZOOKEEPER-2247-13.patch, ZOOKEEPER-2247-14.patch, ZOOKEEPER-2247-15.patch,
> ZOOKEEPER-2247-16.patch, ZOOKEEPER-2247-17.patch, ZOOKEEPER-2247-18.patch,
> ZOOKEEPER-2247-19.patch, ZOOKEEPER-2247-20.patch, ZOOKEEPER-2247-b3.5.patch,
> ZOOKEEPER-2247-br-3.4.patch
>
>
> Zookeeper service becomes unavailable when leader fails to write transaction
> log. Bellow are the exceptions
> {code}
> 2015-08-14 15:41:18,556 [myid:100] - ERROR
> [SyncThread:100:ZooKeeperCriticalThread@48] - Severe unrecoverable error,
> from thread : SyncThread:100
> java.io.IOException: Input/output error
> at sun.nio.ch.FileDispatcherImpl.force0(Native Method)
> at sun.nio.ch.FileDispatcherImpl.force(FileDispatcherImpl.java:76)
> at sun.nio.ch.FileChannelImpl.force(FileChannelImpl.java:376)
> at
> org.apache.zookeeper.server.persistence.FileTxnLog.commit(FileTxnLog.java:331)
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.commit(FileTxnSnapLog.java:380)
> at org.apache.zookeeper.server.ZKDatabase.commit(ZKDatabase.java:563)
> at
> org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:178)
> at
> org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:113)
> 2015-08-14 15:41:18,559 [myid:100] - INFO
> [SyncThread:100:ZooKeeperServer$ZooKeeperServerListenerImpl@500] - Thread
> SyncThread:100 exits, error code 1
> 2015-08-14 15:41:18,559 [myid:100] - INFO
> [SyncThread:100:ZooKeeperServer@523] - shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO
> [SyncThread:100:SessionTrackerImpl@232] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO
> [SyncThread:100:LeaderRequestProcessor@77] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO
> [SyncThread:100:PrepRequestProcessor@1035] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO
> [SyncThread:100:ProposalRequestProcessor@88] - Shutting down
> 2015-08-14 15:41:18,561 [myid:100] - INFO
> [SyncThread:100:CommitProcessor@356] - Shutting down
> 2015-08-14 15:41:18,561 [myid:100] - INFO
> [CommitProcessor:100:CommitProcessor@191] - CommitProcessor exited loop!
> 2015-08-14 15:41:18,562 [myid:100] - INFO
> [SyncThread:100:Leader$ToBeAppliedRequestProcessor@915] - Shutting down
> 2015-08-14 15:41:18,562 [myid:100] - INFO
> [SyncThread:100:FinalRequestProcessor@646] - shutdown of request processor
> complete
> 2015-08-14 15:41:18,562 [myid:100] - INFO
> [SyncThread:100:SyncRequestProcessor@191] - Shutting down
> 2015-08-14 15:41:18,563 [myid:100] - INFO [ProcessThread(sid:100
> cport:-1)::PrepRequestProcessor@159] - PrepRequestProcessor exited loop!
> {code}
> After this exception Leader server stil
