[jira] [Commented] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410424#comment-15410424
 ] 

Hadoop QA commented on ZOOKEEPER-2383:
--

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12822349/ZOOKEEPER-2383.patch
  against trunk revision 1755379.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3328//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3328//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3328//console

This message is automatically generated.

> Startup race in ZooKeeperServer
> ---
>
> Key: ZOOKEEPER-2383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2383
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: jmx, server
>Affects Versions: 3.4.8
>Reporter: Steve Rowe
>Assignee: Rakesh R
>Priority: Blocker
> Fix For: 3.4.9, 3.5.3, 3.6.0
>
> Attachments: TestZkStandaloneJMXRegistrationRaceConcurrent.java, 
> ZOOKEEPER-2383-br-3-4.patch, ZOOKEEPER-2383.patch, ZOOKEEPER-2383.patch, 
> ZOOKEEPER-2383.patch, release-3.4.8-extra-logging.patch, 
> zk-3.4.8-MBeanRegistry.log, zk-3.4.8-NPE.log
>
>
> In attempting to upgrade Solr's ZooKeeper dependency from 3.4.6 to 3.4.8 
> (SOLR-8724) I ran into test failures where attempts to create a node in a 
> newly started standalone ZooKeeperServer were failing because of an assertion 
> in MBeanRegistry.
> ZooKeeperServer.startup() first sets up its request processor chain then 
> registers itself in JMX, but if a connection comes in before the server's JMX 
> registration happens, registration of the connection will fail because it 
> trips the assertion that (effectively) its parent (the server) has already 
> registered itself.
> {code:java|title=ZooKeeperServer.java}
> public synchronized void startup() {
> if (sessionTracker == null) {
> createSessionTracker();
> }
> startSessionTracker();
> setupRequestProcessors();
> registerJMX();
> state = State.RUNNING;
> notifyAll();
> }
> {code}
> {code:java|title=MBeanRegistry.java}
> public void register(ZKMBeanInfo bean, ZKMBeanInfo parent)
> throws JMException
> {
> assert bean != null;
> String path = null;
> if (parent != null) {
> path = mapBean2Path.get(parent);
> assert path != null;
> }
> {code}
> This problem appears to be new with ZK 3.4.8 - AFAIK Solr never had this 
> issue with ZK 3.4.6. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Success: ZOOKEEPER-2383 PreCommit Build #3328

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2383
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3328/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 424087 lines...]
 [exec]   
http://issues.apache.org/jira/secure/attachment/12822349/ZOOKEEPER-2383.patch
 [exec]   against trunk revision 1755379.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3328//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3328//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3328//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 5db0b753e5178be9832c692e66b5d4172bfeb31c logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 20 minutes 4 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2383
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

ZooKeeper_branch34_jdk7 - Build # 1176 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/1176/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 219108 lines...]
[junit] 2016-08-06 02:41:39,819 [myid:] - INFO  
[main:PrepRequestProcessor@765] - Shutting down
[junit] 2016-08-06 02:41:39,819 [myid:] - INFO  
[main:SyncRequestProcessor@209] - Shutting down
[junit] 2016-08-06 02:41:39,819 [myid:] - INFO  [ProcessThread(sid:0 
cport:11221)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop!
[junit] 2016-08-06 02:41:39,820 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@187] - SyncRequestProcessor exited!
[junit] 2016-08-06 02:41:39,820 [myid:] - INFO  
[main:FinalRequestProcessor@402] - shutdown of request processor complete
[junit] 2016-08-06 02:41:39,820 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2016-08-06 02:41:39,821 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-08-06 02:41:39,823 [myid:] - INFO  [main:ClientBase@443] - 
STARTING server
[junit] 2016-08-06 02:41:39,823 [myid:] - INFO  [main:ClientBase@364] - 
CREATING server instance 127.0.0.1:11221
[junit] 2016-08-06 02:41:39,823 [myid:] - INFO  
[main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2016-08-06 02:41:39,823 [myid:] - INFO  [main:ClientBase@339] - 
STARTING server instance 127.0.0.1:11221
[junit] 2016-08-06 02:41:39,824 [myid:] - INFO  [main:ZooKeeperServer@170] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk7/branch-3.4/build/test/tmp/test1785720951220465946.junit.dir/version-2
 snapdir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk7/branch-3.4/build/test/tmp/test1785720951220465946.junit.dir/version-2
[junit] 2016-08-06 02:41:39,829 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2016-08-06 02:41:39,829 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - 
Accepted socket connection from /127.0.0.1:44637
[junit] 2016-08-06 02:41:39,830 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing 
stat command from /127.0.0.1:44637
[junit] 2016-08-06 02:41:39,830 [myid:] - INFO  
[Thread-4:NIOServerCnxn$StatCommand@663] - Stat command output
[junit] 2016-08-06 02:41:39,831 [myid:] - INFO  
[Thread-4:NIOServerCnxn@1008] - Closed socket connection for client 
/127.0.0.1:44637 (no session established for client)
[junit] 2016-08-06 02:41:39,831 [myid:] - INFO  [main:JMXEnv@229] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-08-06 02:41:39,833 [myid:] - INFO  [main:JMXEnv@246] - 
expect:InMemoryDataTree
[junit] 2016-08-06 02:41:39,834 [myid:] - INFO  [main:JMXEnv@250] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree
[junit] 2016-08-06 02:41:39,834 [myid:] - INFO  [main:JMXEnv@246] - 
expect:StandaloneServer_port
[junit] 2016-08-06 02:41:39,834 [myid:] - INFO  [main:JMXEnv@250] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221
[junit] 2016-08-06 02:41:39,835 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 32616
[junit] 2016-08-06 02:41:39,835 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20
[junit] 2016-08-06 02:41:39,835 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota
[junit] 2016-08-06 02:41:39,835 [myid:] - INFO  [main:ClientBase@520] - 
tearDown starting
[junit] 2016-08-06 02:41:39,900 [myid:] - INFO  [main:ZooKeeper@684] - 
Session: 0x1565dba34ce closed
[junit] 2016-08-06 02:41:39,900 [myid:] - INFO  [main:ClientBase@490] - 
STOPPING server
[junit] 2016-08-06 02:41:39,900 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@519] - EventThread shut down for 
session: 0x1565dba34ce
[junit] 2016-08-06 02:41:39,900 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@219] - 
NIOServerCnxn factory exited run method
[junit] 2016-08-06 02:41:39,901 [myid:] - INFO  [main:ZooKeeperServer@469] 
- shutting down
[junit] 2016-08-06 02:41:39,901 [myid:] - INFO  
[main:SessionTrackerImpl@225] - Shutting down
[junit] 2016-08-06 02:41:39,901 [myid:] - INFO  
[main:PrepRequestProcessor@765] - Shutting down
[junit] 2016-08-06 02:41:39,901 [myid:] - INFO  
[main:SyncRequestProcessor@209] - Shutting down
[junit] 2016-08-06 02:41:39,901 [myid:] - INFO  [ProcessThread(sid:0 
cport:11221)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop!
[junit] 2016-08-06 02:41:39,902 [myid:] - INFO  

ZooKeeper_branch35_solaris - Build # 199 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_solaris/199/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 421614 lines...]
[junit] 2016-08-06 01:35:02,190 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-08-06 01:35:02,191 [myid:] - INFO  [main:ClientBase@466] - 
STARTING server
[junit] 2016-08-06 01:35:02,191 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-08-06 01:35:02,192 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-08-06 01:35:02,192 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-08-06 01:35:02,193 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-08-06 01:35:02,193 [myid:] - INFO  [main:ZooKeeperServer@858] 
- minSessionTimeout set to 6000
[junit] 2016-08-06 01:35:02,193 [myid:] - INFO  [main:ZooKeeperServer@867] 
- maxSessionTimeout set to 6
[junit] 2016-08-06 01:35:02,193 [myid:] - INFO  [main:ZooKeeperServer@156] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test6825513989575918520.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test6825513989575918520.junit.dir/version-2
[junit] 2016-08-06 01:35:02,194 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test6825513989575918520.junit.dir/version-2/snapshot.b
[junit] 2016-08-06 01:35:02,196 [myid:] - INFO  [main:FileTxnSnapLog@298] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test6825513989575918520.junit.dir/version-2/snapshot.b
[junit] 2016-08-06 01:35:02,197 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-08-06 01:35:02,198 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:57499
[junit] 2016-08-06 01:35:02,198 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:57499
[junit] 2016-08-06 01:35:02,199 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-08-06 01:35:02,199 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:57499 (no session established for client)
[junit] 2016-08-06 01:35:02,199 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-08-06 01:35:02,201 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-08-06 01:35:02,201 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-08-06 01:35:02,201 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-08-06 01:35:02,201 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-08-06 01:35:02,201 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17877
[junit] 2016-08-06 01:35:02,201 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-08-06 01:35:02,202 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-08-06 01:35:02,202 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-08-06 01:35:02,295 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x122da792830 closed
[junit] 2016-08-06 01:35:02,295 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x122da792830
[junit] 2016-08-06 01:35:02,295 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-08-06 01:35:02,295 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-08-06 01:35:02,295 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-08-06 01:35:02,295 [myid:] - INFO  

[jira] [Commented] (ZOOKEEPER-1742) "make check" doesn't work on macos

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410315#comment-15410315
 ] 

Michael Han commented on ZOOKEEPER-1742:


The latest patch attached here does not apply unfortunately...

One observation is the patch uses compile time interception which only works 
for source files we can instrument - so it is not semantically equivalent to 
the ld wrap option which also replaced calls from stand libraries (for 
functions such as calloc we are mocking in test.). Maybe that is why some of 
UTs were failing when we first tried the patch?

For OS X, there is standard practice to simulate ld wrap option as described in 
TR [1], section 'Macintosh OS X function wrapping', and I tested it work for me 
locally, so we can explore that approach. I'll give a stab on this if no one 
else is interested. This approach requires link to shared library so created 
ZOOKEEPER-2505 to track that. I think we can keep the ld wrap option as is and 
add wrap option simulator for OSX specifically - so we can run c test on mac 
and meanwhile have minimum impact on other platforms. 

[1]https://wwwold.cs.umd.edu/Library/TRs/CS-TR-4585/CS-TR-4585.pdf

> "make check" doesn't work on macos
> --
>
> Key: ZOOKEEPER-1742
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.5, 3.5.0
>Reporter: Flavio Junqueira
>Assignee: Germán Blanco
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, 
> ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, 
> ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, 
> ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch
>
>
> There are two problems I have spotted when running "make check" with the C 
> client. First, it complains that the sleep call is not defined in two test 
> files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. 
> Including unistd.h works. The second problem is with linker options. It 
> complains that "--wrap" is not a valid. I'm not sure how to deal with this 
> one yet, since I'm not sure why we are using it.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2505) Use shared library instead of static library in C client unit test

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han updated ZOOKEEPER-2505:
---
Attachment: ZOOKEEPER-2505.patch

Submit a patch for the proposed change.

> Use shared library instead of static library in C client unit test
> --
>
> Key: ZOOKEEPER-2505
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2505
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: c client
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
>Priority: Minor
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2505.patch
>
>
> Currently we are statically linking c unit tests to ZK client library - we 
> should use shared library instead as there seems no particular reason to 
> stick to static library, plus one benefit of using shared library is that 
> would allow us to use overrides function calls from standard libraries at 
> link time so we can simulate the wrap option for ld linker on os x. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZOOKEEPER-2505) Use shared library instead of static library in C client unit test

[Michael Han (JIRA)]

Michael Han created ZOOKEEPER-2505:
--

 Summary: Use shared library instead of static library in C client 
unit test
 Key: ZOOKEEPER-2505
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2505
 Project: ZooKeeper
  Issue Type: Improvement
  Components: c client
Affects Versions: 3.5.2
Reporter: Michael Han
Assignee: Michael Han
Priority: Minor
 Fix For: 3.5.3


Currently we are statically linking c unit tests to ZK client library - we 
should use shared library instead as there seems no particular reason to stick 
to static library, plus one benefit of using shared library is that would allow 
us to use overrides function calls from standard libraries at link time so we 
can simulate the wrap option for ld linker on os x. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk-openjdk7 - Build # 1117 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1117/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 445097 lines...]
[junit] 2016-08-05 23:04:05,926 [myid:127.0.0.1:27501] - WARN  
[main-SendThread(127.0.0.1:27501):ClientCnxn$SendThread@1235] - Session 
0x101623caa4c for server 127.0.0.1/127.0.0.1:27501, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-08-05 23:04:06,078 [myid:] - INFO  [ProcessThread(sid:0 
cport:27624)::PrepRequestProcessor@647] - Processed session termination for 
sessionid: 0x101623f991b
[junit] 2016-08-05 23:04:06,092 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port27624,name1=Connections,name2=127.0.0.1,name3=0x101623f991b]
[junit] 2016-08-05 23:04:06,093 [myid:] - WARN  [New I/O worker 
#6635:NettyServerCnxnFactory$CnxnChannelHandler@142] - Exception caught [id: 
0x69a44601, /127.0.0.1:42927 :> /127.0.0.1:27624] EXCEPTION: 
java.nio.channels.ClosedChannelException
[junit] java.nio.channels.ClosedChannelException
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioWorker.cleanUpWriteBuffer(AbstractNioWorker.java:433)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioWorker.close(AbstractNioWorker.java:373)
[junit] at 
org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.handleAcceptedSocket(NioServerSocketPipelineSink.java:81)
[junit] at 
org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.eventSunk(NioServerSocketPipelineSink.java:36)
[junit] at 
org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendDownstream(DefaultChannelPipeline.java:779)
[junit] at 
org.jboss.netty.channel.SimpleChannelHandler.closeRequested(SimpleChannelHandler.java:334)
[junit] at 
org.jboss.netty.channel.SimpleChannelHandler.handleDownstream(SimpleChannelHandler.java:260)
[junit] at 
org.jboss.netty.channel.DefaultChannelPipeline.sendDownstream(DefaultChannelPipeline.java:591)
[junit] at 
org.jboss.netty.channel.DefaultChannelPipeline.sendDownstream(DefaultChannelPipeline.java:582)
[junit] at org.jboss.netty.channel.Channels.close(Channels.java:812)
[junit] at 
org.jboss.netty.channel.AbstractChannel.close(AbstractChannel.java:206)
[junit] at 
org.apache.zookeeper.server.NettyServerCnxn.close(NettyServerCnxn.java:111)
[junit] at 
org.apache.zookeeper.server.NettyServerCnxn.sendBuffer(NettyServerCnxn.java:215)
[junit] at 
org.apache.zookeeper.server.NettyServerCnxn.sendCloseSession(NettyServerCnxn.java:441)
[junit] at 
org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:459)
[junit] at 
org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:182)
[junit] at 
org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:113)
[junit] 2016-08-05 23:04:06,193 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x101623f991b closed
[junit] 2016-08-05 23:04:06,193 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 205291
[junit] 2016-08-05 23:04:06,194 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 1641
[junit] 2016-08-05 23:04:06,194 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2016-08-05 23:04:06,194 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-08-05 23:04:06,194 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-08-05 23:04:06,194 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:27624
[junit] 2016-08-05 23:04:06,193 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x101623f991b
[junit] 2016-08-05 23:04:06,197 [myid:] - INFO  [main:ZooKeeperServer@498] 
- shutting down
[junit] 2016-08-05 23:04:06,199 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2016-08-05 23:04:06,199 [myid:] - INFO  
[main:PrepRequestProcessor@965] - Shutting down
[junit] 2016-08-05 23:04:06,199 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2016-08-05 23:04:06,199 [myid:] - INFO  

ZooKeeper_branch35_jdk8 - Build # 180 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/180/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 937351 lines...]
[junit] 2016-08-05 22:51:14,708 [myid:] - INFO  [main:JMXEnv@120] - 
found:name0=ReplicatedServer_id2,name1=replica.3 
org.apache.ZooKeeperService:name0=ReplicatedServer_id2,name1=replica.3
[junit] 2016-08-05 22:51:14,708 [myid:] - INFO  [main:JMXEnv@117] - 
expect:name0=ReplicatedServer_id2,name1=replica.4
[junit] 2016-08-05 22:51:14,708 [myid:] - INFO  [main:JMXEnv@120] - 
found:name0=ReplicatedServer_id2,name1=replica.4 
org.apache.ZooKeeperService:name0=ReplicatedServer_id2,name1=replica.4
[junit] 2016-08-05 22:51:14,708 [myid:] - INFO  [main:JMXEnv@117] - 
expect:name0=ReplicatedServer_id2,name1=replica.5
[junit] 2016-08-05 22:51:14,709 [myid:] - INFO  [main:JMXEnv@120] - 
found:name0=ReplicatedServer_id2,name1=replica.5 
org.apache.ZooKeeperService:name0=ReplicatedServer_id2,name1=replica.5
[junit] 2016-08-05 22:51:14,709 [myid:] - INFO  [main:JMXEnv@117] - 
expect:name0=ReplicatedServer_id3,name1=replica.1
[junit] 2016-08-05 22:51:14,709 [myid:] - INFO  [main:JMXEnv@120] - 
found:name0=ReplicatedServer_id3,name1=replica.1 
org.apache.ZooKeeperService:name0=ReplicatedServer_id3,name1=replica.1
[junit] 2016-08-05 22:51:14,709 [myid:] - INFO  [main:JMXEnv@117] - 
expect:name0=ReplicatedServer_id3,name1=replica.2
[junit] 2016-08-05 22:51:14,709 [myid:] - INFO  [main:JMXEnv@120] - 
found:name0=ReplicatedServer_id3,name1=replica.2 
org.apache.ZooKeeperService:name0=ReplicatedServer_id3,name1=replica.2
[junit] 2016-08-05 22:51:14,709 [myid:] - INFO  [main:JMXEnv@117] - 
expect:name0=ReplicatedServer_id3,name1=replica.3
[junit] 2016-08-05 22:51:14,709 [myid:] - INFO  [main:JMXEnv@120] - 
found:name0=ReplicatedServer_id3,name1=replica.3 
org.apache.ZooKeeperService:name0=ReplicatedServer_id3,name1=replica.3,name2=Follower,name3=InMemoryDataTree
[junit] 2016-08-05 22:51:14,709 [myid:] - INFO  [main:JMXEnv@117] - 
expect:name0=ReplicatedServer_id3,name1=replica.4
[junit] 2016-08-05 22:51:14,709 [myid:] - INFO  [main:JMXEnv@120] - 
found:name0=ReplicatedServer_id3,name1=replica.4 
org.apache.ZooKeeperService:name0=ReplicatedServer_id3,name1=replica.4
[junit] 2016-08-05 22:51:14,710 [myid:] - INFO  [main:JMXEnv@117] - 
expect:name0=ReplicatedServer_id3,name1=replica.5
[junit] 2016-08-05 22:51:14,710 [myid:] - INFO  [main:JMXEnv@120] - 
found:name0=ReplicatedServer_id3,name1=replica.5 
org.apache.ZooKeeperService:name0=ReplicatedServer_id3,name1=replica.5
[junit] 2016-08-05 22:51:14,710 [myid:] - INFO  [main:JMXEnv@117] - 
expect:name0=ReplicatedServer_id4,name1=replica.1
[junit] 2016-08-05 22:51:14,710 [myid:] - INFO  [main:JMXEnv@120] - 
found:name0=ReplicatedServer_id4,name1=replica.1 
org.apache.ZooKeeperService:name0=ReplicatedServer_id4,name1=replica.1
[junit] 2016-08-05 22:51:14,710 [myid:] - INFO  [main:JMXEnv@117] - 
expect:name0=ReplicatedServer_id4,name1=replica.2
[junit] 2016-08-05 22:51:14,710 [myid:] - INFO  [main:JMXEnv@120] - 
found:name0=ReplicatedServer_id4,name1=replica.2 
org.apache.ZooKeeperService:name0=ReplicatedServer_id4,name1=replica.2
[junit] 2016-08-05 22:51:14,710 [myid:] - INFO  [main:JMXEnv@117] - 
expect:name0=ReplicatedServer_id4,name1=replica.3
[junit] 2016-08-05 22:51:14,710 [myid:] - INFO  [main:JMXEnv@120] - 
found:name0=ReplicatedServer_id4,name1=replica.3 
org.apache.ZooKeeperService:name0=ReplicatedServer_id4,name1=replica.3
[junit] 2016-08-05 22:51:14,710 [myid:] - INFO  [main:JMXEnv@117] - 
expect:name0=ReplicatedServer_id4,name1=replica.4
[junit] 2016-08-05 22:51:14,710 [myid:] - INFO  [main:JMXEnv@120] - 
found:name0=ReplicatedServer_id4,name1=replica.4 
org.apache.ZooKeeperService:name0=ReplicatedServer_id4,name1=replica.4,name2=Follower
[junit] 2016-08-05 22:51:14,711 [myid:] - INFO  [main:JMXEnv@117] - 
expect:name0=ReplicatedServer_id4,name1=replica.5
[junit] 2016-08-05 22:51:14,711 [myid:] - INFO  [main:JMXEnv@120] - 
found:name0=ReplicatedServer_id4,name1=replica.5 
org.apache.ZooKeeperService:name0=ReplicatedServer_id4,name1=replica.5
[junit] 2016-08-05 22:51:14,711 [myid:] - INFO  [main:JMXEnv@117] - 
expect:name0=ReplicatedServer_id5,name1=replica.1
[junit] 2016-08-05 22:51:14,711 [myid:] - INFO  [main:JMXEnv@120] - 
found:name0=ReplicatedServer_id5,name1=replica.1 
org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.1
[junit] 2016-08-05 22:51:14,711 [myid:] - INFO  [main:JMXEnv@117] - 
expect:name0=ReplicatedServer_id5,name1=replica.2
[junit] 2016-08-05 22:51:14,711 [myid:] - INFO  [main:JMXEnv@120] - 
found:name0=ReplicatedServer_id5,name1=replica.2 
org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.2
[junit] 2016-08-05 22:51:14,711 [myid:] - 

[jira] [Created] (ZOOKEEPER-2504) Enforce that server ids are unique in a cluster

[Dan Benediktson (JIRA)]

Dan Benediktson created ZOOKEEPER-2504:
--

 Summary: Enforce that server ids are unique in a cluster
 Key: ZOOKEEPER-2504
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2504
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Dan Benediktson


The leader will happily accept connections from learners that have the same 
server id (i.e., due to misconfiguration). This can lead to various issues 
including non-unique session_ids being generated by these servers.

The leader can enforce that all learners come in with unique server IDs; if a 
learner attempts to connect with an id that is already in use, it should be 
denied.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2503) Inconsistency between myid documentation and implementation

[Dan Benediktson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410221#comment-15410221
 ] 

Dan Benediktson commented on ZOOKEEPER-2503:


Absolutely, I'd be delighted to. Will file the JIRA today, and will try to get 
a patch attached today, or latest on Monday.

> Inconsistency between myid documentation and implementation
> ---
>
> Key: ZOOKEEPER-2503
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2503
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.9, 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3, 3.4.10
>
>
> In ZK documentation, we have:
> "The myid file consists of a single line containing only the text of that 
> machine's id. So myid of server 1 would contain the text "1" and nothing 
> else. The id must be unique within the ensemble and should have a value 
> between 1 and 255."
> This however is not enforced in code, which should be fixed either in 
> documentation that we remove the restriction of the range 1-255 or in code we 
> enforce such constraint.
> Discussion thread:
> http://zookeeper-user.578899.n2.nabble.com/Is-myid-actually-limited-to-1-255-td7581270.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2503) Inconsistency between myid documentation and implementation

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410195#comment-15410195
 ] 

Patrick Hunt commented on ZOOKEEPER-2503:
-

Thanks for the feedback [~dbenediktson] - any chance you could contribute that 
patch back? (if so please create another jira for it linked to this).

Makes sense to close this hole, perhaps in 3.5+?

> Inconsistency between myid documentation and implementation
> ---
>
> Key: ZOOKEEPER-2503
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2503
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.9, 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3, 3.4.10
>
>
> In ZK documentation, we have:
> "The myid file consists of a single line containing only the text of that 
> machine's id. So myid of server 1 would contain the text "1" and nothing 
> else. The id must be unique within the ensemble and should have a value 
> between 1 and 255."
> This however is not enforced in code, which should be fixed either in 
> documentation that we remove the restriction of the range 1-255 or in code we 
> enforce such constraint.
> Discussion thread:
> http://zookeeper-user.578899.n2.nabble.com/Is-myid-actually-limited-to-1-255-td7581270.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk-solaris - Build # 1258 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1258/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 427218 lines...]
[junit] 2016-08-05 22:28:21,353 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-08-05 22:28:21,354 [myid:] - INFO  [main:ClientBase@466] - 
STARTING server
[junit] 2016-08-05 22:28:21,354 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-08-05 22:28:21,354 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-08-05 22:28:21,355 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-08-05 22:28:21,356 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-08-05 22:28:21,356 [myid:] - INFO  [main:ZooKeeperServer@858] 
- minSessionTimeout set to 6000
[junit] 2016-08-05 22:28:21,356 [myid:] - INFO  [main:ZooKeeperServer@867] 
- maxSessionTimeout set to 6
[junit] 2016-08-05 22:28:21,356 [myid:] - INFO  [main:ZooKeeperServer@156] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test8467974331194148891.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test8467974331194148891.junit.dir/version-2
[junit] 2016-08-05 22:28:21,357 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test8467974331194148891.junit.dir/version-2/snapshot.b
[junit] 2016-08-05 22:28:21,359 [myid:] - INFO  [main:FileTxnSnapLog@298] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test8467974331194148891.junit.dir/version-2/snapshot.b
[junit] 2016-08-05 22:28:21,360 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-08-05 22:28:21,361 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:40671
[junit] 2016-08-05 22:28:21,361 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:40671
[junit] 2016-08-05 22:28:21,361 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-08-05 22:28:21,362 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:40671 (no session established for client)
[junit] 2016-08-05 22:28:21,362 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-08-05 22:28:21,363 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-08-05 22:28:21,363 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-08-05 22:28:21,364 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-08-05 22:28:21,364 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-08-05 22:28:21,364 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17848
[junit] 2016-08-05 22:28:21,364 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-08-05 22:28:21,364 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-08-05 22:28:21,364 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-08-05 22:28:21,442 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x122d9ce3fa9 closed
[junit] 2016-08-05 22:28:21,442 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x122d9ce3fa9
[junit] 2016-08-05 22:28:21,442 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-08-05 22:28:21,442 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-08-05 22:28:21,443 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-08-05 22:28:21,443 [myid:] - INFO  

[jira] [Commented] (ZOOKEEPER-2500) Fix compilation warnings for CliException classes

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410113#comment-15410113
 ] 

Hudson commented on ZOOKEEPER-2500:
---

SUCCESS: Integrated in ZooKeeper-trunk #3024 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3024/])
ZOOKEEPER-2500: Fix compilation warnings for CliException classes (Abraham Fine 
via phunt) (phunt: 
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1755379])
* trunk/CHANGES.txt
* trunk/src/java/main/org/apache/zookeeper/cli/CliException.java
* trunk/src/java/main/org/apache/zookeeper/cli/CliParseException.java
* trunk/src/java/main/org/apache/zookeeper/cli/CliWrapperException.java
* trunk/src/java/main/org/apache/zookeeper/cli/CommandNotFoundException.java
* trunk/src/java/main/org/apache/zookeeper/cli/MalformedCommandException.java


> Fix compilation warnings for CliException classes
> -
>
> Key: ZOOKEEPER-2500
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2500
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Abraham Fine
>Assignee: Abraham Fine
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2500.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2503) Inconsistency between myid documentation and implementation

[Dan Benediktson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410083#comment-15410083
 ] 

Dan Benediktson commented on ZOOKEEPER-2503:


Honestly, it's probably for the best to break those hypothetical existing 
configurations, since in some ways they are already broken. It sounds like the 
behavior would result in truncation down to one byte of effective server ID, 
and from personal experience, I can say that if two servers are running with 
the same Server ID in an ensemble it can have weird results. We had a 
configuration issue in one of our ensembles at one point where two servers had 
been misconfigured to use the same ServerId, which the Leader happily allows, 
and which we think resulted in duplicate session IDs getting handed out to two 
different sessions, and then to strange side-effects down the line. We actually 
have a fix in our Zookeeper fork to make LearnerHandler block any server from 
being allowed in if the Learner is trying to claim a Server ID that's already 
in use by another Learner, to prevent this configuration problem from sneaking 
in again.

> Inconsistency between myid documentation and implementation
> ---
>
> Key: ZOOKEEPER-2503
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2503
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.9, 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3, 3.4.10
>
>
> In ZK documentation, we have:
> "The myid file consists of a single line containing only the text of that 
> machine's id. So myid of server 1 would contain the text "1" and nothing 
> else. The id must be unique within the ensemble and should have a value 
> between 1 and 255."
> This however is not enforced in code, which should be fixed either in 
> documentation that we remove the restriction of the range 1-255 or in code we 
> enforce such constraint.
> Discussion thread:
> http://zookeeper-user.578899.n2.nabble.com/Is-myid-actually-limited-to-1-255-td7581270.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2503) Inconsistency between myid documentation and implementation

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410054#comment-15410054
 ] 

Patrick Hunt commented on ZOOKEEPER-2503:
-

I believe that the myid is used as part of the server id, in order to get a 
unique value for quorum formation. iirc it's the top 8 bits of the server id. 
Hence the reason why we mention that in the docs. afaik we never "enforced" 
this at the code level. On the plus side it would be a good idea, on the minus 
side it might break existing configurations


> Inconsistency between myid documentation and implementation
> ---
>
> Key: ZOOKEEPER-2503
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2503
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.9, 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3, 3.4.10
>
>
> In ZK documentation, we have:
> "The myid file consists of a single line containing only the text of that 
> machine's id. So myid of server 1 would contain the text "1" and nothing 
> else. The id must be unique within the ensemble and should have a value 
> between 1 and 255."
> This however is not enforced in code, which should be fixed either in 
> documentation that we remove the restriction of the range 1-255 or in code we 
> enforce such constraint.
> Discussion thread:
> http://zookeeper-user.578899.n2.nabble.com/Is-myid-actually-limited-to-1-255-td7581270.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: myid documentation

[Patrick Hunt]

I believe that the myid is used as part of the server id, in order to get a
unique value for quorum formation. iirc it's the top 8 bits of the server
id. Hence the reason why we mention that in the docs. afaik we never
"enforced" this at the code level. On the plus side it would be a good
idea, on the minus side it might break existing configurations

Patrick

On Fri, Aug 5, 2016 at 7:07 AM, Flavio Junqueira  wrote:

> I noticed that the documentation says that the myid value needs to be
> between 0 and 255. The code currently does not impose such a limitation and
> I also found this thread briefly discussing it:
>
> https://mail-archives.apache.org/mod_mbox/zookeeper-user/
> 201507.mbox/%3CCABQ=58TqB3ntBY2oW0gDRvDb_XgZh8k99D11GeAf+CdfSJMOhA@
> mail.gmail.com%3E  org/mod_mbox/zookeeper-user/201507.mbox/%3CCABQ=58TqB3ntBY2oW0gDRvDb_
> xgzh8k99d11geaf+cdfsjm...@mail.gmail.com%3E>
>
> Is anyone aware of a jira for this? I couldn't find any
>
> -Flavio

[jira] [Commented] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409917#comment-15409917
 ] 

Michael Han commented on ZOOKEEPER-2383:


Thanks Rakesh for quick reply - looks good to me.

> Startup race in ZooKeeperServer
> ---
>
> Key: ZOOKEEPER-2383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2383
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: jmx, server
>Affects Versions: 3.4.8
>Reporter: Steve Rowe
>Assignee: Rakesh R
>Priority: Blocker
> Fix For: 3.4.9, 3.5.3, 3.6.0
>
> Attachments: TestZkStandaloneJMXRegistrationRaceConcurrent.java, 
> ZOOKEEPER-2383-br-3-4.patch, ZOOKEEPER-2383.patch, ZOOKEEPER-2383.patch, 
> ZOOKEEPER-2383.patch, release-3.4.8-extra-logging.patch, 
> zk-3.4.8-MBeanRegistry.log, zk-3.4.8-NPE.log
>
>
> In attempting to upgrade Solr's ZooKeeper dependency from 3.4.6 to 3.4.8 
> (SOLR-8724) I ran into test failures where attempts to create a node in a 
> newly started standalone ZooKeeperServer were failing because of an assertion 
> in MBeanRegistry.
> ZooKeeperServer.startup() first sets up its request processor chain then 
> registers itself in JMX, but if a connection comes in before the server's JMX 
> registration happens, registration of the connection will fail because it 
> trips the assertion that (effectively) its parent (the server) has already 
> registered itself.
> {code:java|title=ZooKeeperServer.java}
> public synchronized void startup() {
> if (sessionTracker == null) {
> createSessionTracker();
> }
> startSessionTracker();
> setupRequestProcessors();
> registerJMX();
> state = State.RUNNING;
> notifyAll();
> }
> {code}
> {code:java|title=MBeanRegistry.java}
> public void register(ZKMBeanInfo bean, ZKMBeanInfo parent)
> throws JMException
> {
> assert bean != null;
> String path = null;
> if (parent != null) {
> path = mapBean2Path.get(parent);
> assert path != null;
> }
> {code}
> This problem appears to be new with ZK 3.4.8 - AFAIK Solr never had this 
> issue with ZK 3.4.6. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2469) infinite loop in ZK re-login

[Arshad Mohammad (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409911#comment-15409911
 ] 

Arshad Mohammad commented on ZOOKEEPER-2469:


# immediateRetry  is not required if relogin is tried at least after 
MIN_TIME_BEFORE_RELOGIN, but here we are trying to relogin immediately after 
the first relogin failure
# bq.Shouldn't we keep retrying but making sure that it is sleeping in each 
iteration rather than run in a tight loop?
This would help in maintaining the cleaner code. But we will end up trying 
re-login forever intentionally and this JIRA would be just a code cleanup task, 
not a bug actually.
are you suggesting to replace code from line 236 to 260 with bellow code.
{code}
while (true) {
try {
reLogin();
break;
} catch (LoginException le) {
try {
Thread.sleep(MIN_TIME_BEFORE_RELOGIN + 1);
} catch (InterruptedException e) {
LOG.error("Interrupted during login retry after 
LoginException:", le);
break;
}
}
}
{code}






> infinite loop in ZK re-login
> 
>
> Key: ZOOKEEPER-2469
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2469
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: ZOOKEEPER-2469.01.patch, ZOOKEEPER-2469.02.patch, 
> ZOOKEEPER-2469.03.patch, ZOOKEEPER-2469.patch
>
>
> {noformat}
> int retry = 1;
> while (retry >= 0) {
> try {
> reLogin();
> break;
> } catch (LoginException le) {
> if (retry > 0) {
> --retry;
> // sleep for 10 seconds.
> try {
> Thread.sleep(10 * 1000);
> } catch (InterruptedException e) {
> LOG.error("Interrupted during login 
> retry after LoginException:", le);
> throw le;
> }
> } else {
> LOG.error("Could not refresh TGT for 
> principal: " + principal + ".", le);
> }
> }
> }
> {noformat}
> will retry forever. Should return like the one above



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-2383 PreCommit Build #3327

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2383
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3327/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 441446 lines...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3327//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3327//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3327//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] f9ffecb6ef4713023e2c7a2022906c3d95efd79e logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1605:
 exec returned: 1

Total time: 20 minutes 28 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2383
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409886#comment-15409886
 ] 

Hadoop QA commented on ZOOKEEPER-2383:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12822349/ZOOKEEPER-2383.patch
  against trunk revision 1755100.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3327//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3327//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3327//console

This message is automatically generated.

> Startup race in ZooKeeperServer
> ---
>
> Key: ZOOKEEPER-2383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2383
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: jmx, server
>Affects Versions: 3.4.8
>Reporter: Steve Rowe
>Assignee: Rakesh R
>Priority: Blocker
> Fix For: 3.4.9, 3.5.3, 3.6.0
>
> Attachments: TestZkStandaloneJMXRegistrationRaceConcurrent.java, 
> ZOOKEEPER-2383-br-3-4.patch, ZOOKEEPER-2383.patch, ZOOKEEPER-2383.patch, 
> ZOOKEEPER-2383.patch, release-3.4.8-extra-logging.patch, 
> zk-3.4.8-MBeanRegistry.log, zk-3.4.8-NPE.log
>
>
> In attempting to upgrade Solr's ZooKeeper dependency from 3.4.6 to 3.4.8 
> (SOLR-8724) I ran into test failures where attempts to create a node in a 
> newly started standalone ZooKeeperServer were failing because of an assertion 
> in MBeanRegistry.
> ZooKeeperServer.startup() first sets up its request processor chain then 
> registers itself in JMX, but if a connection comes in before the server's JMX 
> registration happens, registration of the connection will fail because it 
> trips the assertion that (effectively) its parent (the server) has already 
> registered itself.
> {code:java|title=ZooKeeperServer.java}
> public synchronized void startup() {
> if (sessionTracker == null) {
> createSessionTracker();
> }
> startSessionTracker();
> setupRequestProcessors();
> registerJMX();
> state = State.RUNNING;
> notifyAll();
> }
> {code}
> {code:java|title=MBeanRegistry.java}
> public void register(ZKMBeanInfo bean, ZKMBeanInfo parent)
> throws JMException
> {
> assert bean != null;
> String path = null;
> if (parent != null) {
> path = mapBean2Path.get(parent);
> assert path != null;
> }
> {code}
> This problem appears to be new with ZK 3.4.8 - AFAIK Solr never had this 
> issue with ZK 3.4.6. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409828#comment-15409828
 ] 

Rakesh R edited comment on ZOOKEEPER-2383 at 8/5/16 6:10 PM:
-

Thanks [~hanm] for the reviews. It looks like {{ZKUtil.java}} has ZooKeeper 
client related operations. Attached new patch, where I've tried keeping 
{{isZKServerRunning()}} in {{AbstractFourLetterCommand.java}}. Does this sound 
good to you?


was (Author: rakeshr):
Thanks [~hanm] for the reviews. Attached new patch, where I've tried keeping 
{{isZKServerRunning()}} in {{AbstractFourLetterCommand.java}}. Does this sound 
good to you?

> Startup race in ZooKeeperServer
> ---
>
> Key: ZOOKEEPER-2383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2383
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: jmx, server
>Affects Versions: 3.4.8
>Reporter: Steve Rowe
>Assignee: Rakesh R
>Priority: Blocker
> Fix For: 3.4.9, 3.5.3, 3.6.0
>
> Attachments: TestZkStandaloneJMXRegistrationRaceConcurrent.java, 
> ZOOKEEPER-2383-br-3-4.patch, ZOOKEEPER-2383.patch, ZOOKEEPER-2383.patch, 
> ZOOKEEPER-2383.patch, release-3.4.8-extra-logging.patch, 
> zk-3.4.8-MBeanRegistry.log, zk-3.4.8-NPE.log
>
>
> In attempting to upgrade Solr's ZooKeeper dependency from 3.4.6 to 3.4.8 
> (SOLR-8724) I ran into test failures where attempts to create a node in a 
> newly started standalone ZooKeeperServer were failing because of an assertion 
> in MBeanRegistry.
> ZooKeeperServer.startup() first sets up its request processor chain then 
> registers itself in JMX, but if a connection comes in before the server's JMX 
> registration happens, registration of the connection will fail because it 
> trips the assertion that (effectively) its parent (the server) has already 
> registered itself.
> {code:java|title=ZooKeeperServer.java}
> public synchronized void startup() {
> if (sessionTracker == null) {
> createSessionTracker();
> }
> startSessionTracker();
> setupRequestProcessors();
> registerJMX();
> state = State.RUNNING;
> notifyAll();
> }
> {code}
> {code:java|title=MBeanRegistry.java}
> public void register(ZKMBeanInfo bean, ZKMBeanInfo parent)
> throws JMException
> {
> assert bean != null;
> String path = null;
> if (parent != null) {
> path = mapBean2Path.get(parent);
> assert path != null;
> }
> {code}
> This problem appears to be new with ZK 3.4.8 - AFAIK Solr never had this 
> issue with ZK 3.4.6. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

[Rakesh R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh R updated ZOOKEEPER-2383:

Attachment: ZOOKEEPER-2383.patch

Thanks [~hanm] for the reviews. Attached new patch, where I've tried keeping 
{{isZKServerRunning()}} in {{AbstractFourLetterCommand.java}}. Does this sound 
good to you?

> Startup race in ZooKeeperServer
> ---
>
> Key: ZOOKEEPER-2383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2383
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: jmx, server
>Affects Versions: 3.4.8
>Reporter: Steve Rowe
>Assignee: Rakesh R
>Priority: Blocker
> Fix For: 3.4.9, 3.5.3, 3.6.0
>
> Attachments: TestZkStandaloneJMXRegistrationRaceConcurrent.java, 
> ZOOKEEPER-2383-br-3-4.patch, ZOOKEEPER-2383.patch, ZOOKEEPER-2383.patch, 
> ZOOKEEPER-2383.patch, release-3.4.8-extra-logging.patch, 
> zk-3.4.8-MBeanRegistry.log, zk-3.4.8-NPE.log
>
>
> In attempting to upgrade Solr's ZooKeeper dependency from 3.4.6 to 3.4.8 
> (SOLR-8724) I ran into test failures where attempts to create a node in a 
> newly started standalone ZooKeeperServer were failing because of an assertion 
> in MBeanRegistry.
> ZooKeeperServer.startup() first sets up its request processor chain then 
> registers itself in JMX, but if a connection comes in before the server's JMX 
> registration happens, registration of the connection will fail because it 
> trips the assertion that (effectively) its parent (the server) has already 
> registered itself.
> {code:java|title=ZooKeeperServer.java}
> public synchronized void startup() {
> if (sessionTracker == null) {
> createSessionTracker();
> }
> startSessionTracker();
> setupRequestProcessors();
> registerJMX();
> state = State.RUNNING;
> notifyAll();
> }
> {code}
> {code:java|title=MBeanRegistry.java}
> public void register(ZKMBeanInfo bean, ZKMBeanInfo parent)
> throws JMException
> {
> assert bean != null;
> String path = null;
> if (parent != null) {
> path = mapBean2Path.get(parent);
> assert path != null;
> }
> {code}
> This problem appears to be new with ZK 3.4.8 - AFAIK Solr never had this 
> issue with ZK 3.4.6. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Success: ZOOKEEPER-2247 PreCommit Build #3326

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2247
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3326/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 443987 lines...]
 [exec]   
http://issues.apache.org/jira/secure/attachment/12822331/ZOOKEEPER-2247-21.patch
 [exec]   against trunk revision 1755100.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 6 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3326//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3326//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3326//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] b6850735aabe3c7addb5396c6af35438ceab30d2 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 20 minutes 17 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2247
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

ZooKeeper_branch35_solaris - Build # 198 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_solaris/198/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 428398 lines...]
[junit] 2016-08-05 17:26:01,809 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-08-05 17:26:01,810 [myid:] - INFO  [main:ClientBase@466] - 
STARTING server
[junit] 2016-08-05 17:26:01,810 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-08-05 17:26:01,810 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-08-05 17:26:01,811 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-08-05 17:26:01,811 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-08-05 17:26:01,812 [myid:] - INFO  [main:ZooKeeperServer@858] 
- minSessionTimeout set to 6000
[junit] 2016-08-05 17:26:01,812 [myid:] - INFO  [main:ZooKeeperServer@867] 
- maxSessionTimeout set to 6
[junit] 2016-08-05 17:26:01,812 [myid:] - INFO  [main:ZooKeeperServer@156] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test6584505489851782670.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test6584505489851782670.junit.dir/version-2
[junit] 2016-08-05 17:26:01,813 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test6584505489851782670.junit.dir/version-2/snapshot.b
[junit] 2016-08-05 17:26:01,815 [myid:] - INFO  [main:FileTxnSnapLog@298] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test6584505489851782670.junit.dir/version-2/snapshot.b
[junit] 2016-08-05 17:26:01,816 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-08-05 17:26:01,817 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:56123
[junit] 2016-08-05 17:26:01,818 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:56123
[junit] 2016-08-05 17:26:01,818 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-08-05 17:26:01,818 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:56123 (no session established for client)
[junit] 2016-08-05 17:26:01,818 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-08-05 17:26:01,820 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-08-05 17:26:01,820 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-08-05 17:26:01,820 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-08-05 17:26:01,820 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-08-05 17:26:01,820 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17841
[junit] 2016-08-05 17:26:01,821 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-08-05 17:26:01,821 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-08-05 17:26:01,821 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-08-05 17:26:01,892 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x122d8b96e50 closed
[junit] 2016-08-05 17:26:01,892 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x122d8b96e50
[junit] 2016-08-05 17:26:01,892 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-08-05 17:26:01,893 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-08-05 17:26:01,893 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-08-05 17:26:01,901 [myid:] - INFO  

[jira] [Commented] (ZOOKEEPER-2247) Zookeeper service becomes unavailable when leader fails to write transaction log

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409759#comment-15409759
 ] 

Hadoop QA commented on ZOOKEEPER-2247:
--

+1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12822331/ZOOKEEPER-2247-21.patch
  against trunk revision 1755100.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 6 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3326//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3326//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3326//console

This message is automatically generated.

> Zookeeper service becomes unavailable when leader fails to write transaction 
> log
> 
>
> Key: ZOOKEEPER-2247
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2247
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.9, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2247-01.patch, ZOOKEEPER-2247-02.patch, 
> ZOOKEEPER-2247-03.patch, ZOOKEEPER-2247-04.patch, ZOOKEEPER-2247-05.patch, 
> ZOOKEEPER-2247-06.patch, ZOOKEEPER-2247-07.patch, ZOOKEEPER-2247-09.patch, 
> ZOOKEEPER-2247-10.patch, ZOOKEEPER-2247-11.patch, ZOOKEEPER-2247-12.patch, 
> ZOOKEEPER-2247-13.patch, ZOOKEEPER-2247-14.patch, ZOOKEEPER-2247-15.patch, 
> ZOOKEEPER-2247-16.patch, ZOOKEEPER-2247-17.patch, ZOOKEEPER-2247-18.patch, 
> ZOOKEEPER-2247-19.patch, ZOOKEEPER-2247-20.patch, ZOOKEEPER-2247-21.patch, 
> ZOOKEEPER-2247-b3.5.patch, ZOOKEEPER-2247-br-3.4.patch
>
>
> Zookeeper service becomes unavailable when leader fails to write transaction 
> log. Bellow are the exceptions
> {code}
> 2015-08-14 15:41:18,556 [myid:100] - ERROR 
> [SyncThread:100:ZooKeeperCriticalThread@48] - Severe unrecoverable error, 
> from thread : SyncThread:100
> java.io.IOException: Input/output error
>   at sun.nio.ch.FileDispatcherImpl.force0(Native Method)
>   at sun.nio.ch.FileDispatcherImpl.force(FileDispatcherImpl.java:76)
>   at sun.nio.ch.FileChannelImpl.force(FileChannelImpl.java:376)
>   at 
> org.apache.zookeeper.server.persistence.FileTxnLog.commit(FileTxnLog.java:331)
>   at 
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.commit(FileTxnSnapLog.java:380)
>   at org.apache.zookeeper.server.ZKDatabase.commit(ZKDatabase.java:563)
>   at 
> org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:178)
>   at 
> org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:113)
> 2015-08-14 15:41:18,559 [myid:100] - INFO  
> [SyncThread:100:ZooKeeperServer$ZooKeeperServerListenerImpl@500] - Thread 
> SyncThread:100 exits, error code 1
> 2015-08-14 15:41:18,559 [myid:100] - INFO  
> [SyncThread:100:ZooKeeperServer@523] - shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO  
> [SyncThread:100:SessionTrackerImpl@232] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO  
> [SyncThread:100:LeaderRequestProcessor@77] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO  
> [SyncThread:100:PrepRequestProcessor@1035] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO  
> [SyncThread:100:ProposalRequestProcessor@88] - Shutting down
> 2015-08-14 15:41:18,561 [myid:100] - INFO  
> [SyncThread:100:CommitProcessor@356] - Shutting down
> 2015-08-14 15:41:18,561 [myid:100] - INFO  
> [CommitProcessor:100:CommitProcessor@191] - CommitProcessor exited loop!
> 2015-08-14 15:41:18,562 [myid:100] - INFO  
> [SyncThread:100:Leader$ToBeAppliedRequestProcessor@915] - Shutting down
> 2015-08-14 15:41:18,562 [myid:100] - INFO  
> [SyncThread:100:FinalRequestProcessor@646] - shutdown of request processor 
> complete
> 2015-08-14 15:41:18,562 [myid:100] - INFO  
> [SyncThread:100:SyncRequestProcessor@191] - Shutting down
> 2015-08-14 15:41:18,563 [myid:100] - INFO  [ProcessThread(sid:100 
> cport:-1)::PrepRequestProcessor@159] - PrepRequestProcessor exited loop!
> {code}
> After this exception Leader 

Re: myid documentation

[Michael Han]

Thanks for pointing that out. Make sense to me don't enforce anything for
no particular reason (wondering why the doc was mentioning such constraint
in first place).

Updated jira descriptions as well. Let's discuss on JIRA on what the best
fix might be for this issue.





On Fri, Aug 5, 2016 at 9:51 AM, Arshad Mohammad  wrote:

> I think there is no benefit in restricting the myid range.  Also, in the
> code it is taken as long. Better we can updated the document and correct
> the ranger from "1-255" to 0-Long.MAX_VALUE
>
> -Arshad
>
> On Fri, Aug 5, 2016 at 9:48 PM, Flavio Junqueira  wrote:
>
> > Thanks, Michael.
> >
> > -Flavio
> >
> > > On 05 Aug 2016, at 17:01, Michael Han  wrote:
> > >
> > > I can't find any JIRA related to this either, so just created one
> > > https://issues.apache.org/jira/browse/ZOOKEEPER-2503
> > >
> > > On Fri, Aug 5, 2016 at 7:07 AM, Flavio Junqueira 
> wrote:
> > >
> > >> I noticed that the documentation says that the myid value needs to be
> > >> between 0 and 255. The code currently does not impose such a
> limitation
> > and
> > >> I also found this thread briefly discussing it:
> > >>
> > >> https://mail-archives.apache.org/mod_mbox/zookeeper-user/
> > >> 201507.mbox/%3CCABQ=58TqB3ntBY2oW0gDRvDb_XgZh8k99D11GeAf+CdfSJMOhA@
> > >> mail.gmail.com%3E  > >> org/mod_mbox/zookeeper-user/201507.mbox/%3CCABQ=58TqB3ntBY2oW0gDRvDb_
> > >> xgzh8k99d11geaf+cdfsjm...@mail.gmail.com%3E>
> > >>
> > >> Is anyone aware of a jira for this? I couldn't find any
> > >>
> > >> -Flavio
> > >
> > >
> > >
> > >
> > > --
> > > Cheers
> > > Michael.
> >
> >
>



-- 
Cheers
Michael.

[jira] [Updated] (ZOOKEEPER-2503) Inconsistency between myid documentation and implementation

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han updated ZOOKEEPER-2503:
---
Description: 
In ZK documentation, we have:

"The myid file consists of a single line containing only the text of that 
machine's id. So myid of server 1 would contain the text "1" and nothing else. 
The id must be unique within the ensemble and should have a value between 1 and 
255."

This however is not enforced in code, which should be fixed either in 
documentation that we remove the restriction of the range 1-255 or in code we 
enforce such constraint.
Discussion thread:
http://zookeeper-user.578899.n2.nabble.com/Is-myid-actually-limited-to-1-255-td7581270.html

  was:
In ZK documentation, we have:

"The myid file consists of a single line containing only the text of that 
machine's id. So myid of server 1 would contain the text "1" and nothing else. 
The id must be unique within the ensemble and should have a value between 1 and 
255."

This however is not enforced in code, which should be fixed.
Discussion thread:
http://zookeeper-user.578899.n2.nabble.com/Is-myid-actually-limited-to-1-255-td7581270.html


> Inconsistency between myid documentation and implementation
> ---
>
> Key: ZOOKEEPER-2503
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2503
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.9, 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3, 3.4.10
>
>
> In ZK documentation, we have:
> "The myid file consists of a single line containing only the text of that 
> machine's id. So myid of server 1 would contain the text "1" and nothing 
> else. The id must be unique within the ensemble and should have a value 
> between 1 and 255."
> This however is not enforced in code, which should be fixed either in 
> documentation that we remove the restriction of the range 1-255 or in code we 
> enforce such constraint.
> Discussion thread:
> http://zookeeper-user.578899.n2.nabble.com/Is-myid-actually-limited-to-1-255-td7581270.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2503) Inconsistency between myid documentation and implementation

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han updated ZOOKEEPER-2503:
---
Summary: Inconsistency between myid documentation and implementation  (was: 
Enforce myid has a value between [1, 255] inclusive.)

> Inconsistency between myid documentation and implementation
> ---
>
> Key: ZOOKEEPER-2503
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2503
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.9, 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3, 3.4.10
>
>
> In ZK documentation, we have:
> "The myid file consists of a single line containing only the text of that 
> machine's id. So myid of server 1 would contain the text "1" and nothing 
> else. The id must be unique within the ensemble and should have a value 
> between 1 and 255."
> This however is not enforced in code, which should be fixed.
> Discussion thread:
> http://zookeeper-user.578899.n2.nabble.com/Is-myid-actually-limited-to-1-255-td7581270.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2247) Zookeeper service becomes unavailable when leader fails to write transaction log

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409735#comment-15409735
 ] 

Rakesh R commented on ZOOKEEPER-2247:
-

Attached new patch addressing [~fpj]'s comments given in 
[Github_PR_65|https://github.com/apache/zookeeper/pull/65]. Thanks!

> Zookeeper service becomes unavailable when leader fails to write transaction 
> log
> 
>
> Key: ZOOKEEPER-2247
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2247
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.9, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2247-01.patch, ZOOKEEPER-2247-02.patch, 
> ZOOKEEPER-2247-03.patch, ZOOKEEPER-2247-04.patch, ZOOKEEPER-2247-05.patch, 
> ZOOKEEPER-2247-06.patch, ZOOKEEPER-2247-07.patch, ZOOKEEPER-2247-09.patch, 
> ZOOKEEPER-2247-10.patch, ZOOKEEPER-2247-11.patch, ZOOKEEPER-2247-12.patch, 
> ZOOKEEPER-2247-13.patch, ZOOKEEPER-2247-14.patch, ZOOKEEPER-2247-15.patch, 
> ZOOKEEPER-2247-16.patch, ZOOKEEPER-2247-17.patch, ZOOKEEPER-2247-18.patch, 
> ZOOKEEPER-2247-19.patch, ZOOKEEPER-2247-20.patch, ZOOKEEPER-2247-21.patch, 
> ZOOKEEPER-2247-b3.5.patch, ZOOKEEPER-2247-br-3.4.patch
>
>
> Zookeeper service becomes unavailable when leader fails to write transaction 
> log. Bellow are the exceptions
> {code}
> 2015-08-14 15:41:18,556 [myid:100] - ERROR 
> [SyncThread:100:ZooKeeperCriticalThread@48] - Severe unrecoverable error, 
> from thread : SyncThread:100
> java.io.IOException: Input/output error
>   at sun.nio.ch.FileDispatcherImpl.force0(Native Method)
>   at sun.nio.ch.FileDispatcherImpl.force(FileDispatcherImpl.java:76)
>   at sun.nio.ch.FileChannelImpl.force(FileChannelImpl.java:376)
>   at 
> org.apache.zookeeper.server.persistence.FileTxnLog.commit(FileTxnLog.java:331)
>   at 
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.commit(FileTxnSnapLog.java:380)
>   at org.apache.zookeeper.server.ZKDatabase.commit(ZKDatabase.java:563)
>   at 
> org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:178)
>   at 
> org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:113)
> 2015-08-14 15:41:18,559 [myid:100] - INFO  
> [SyncThread:100:ZooKeeperServer$ZooKeeperServerListenerImpl@500] - Thread 
> SyncThread:100 exits, error code 1
> 2015-08-14 15:41:18,559 [myid:100] - INFO  
> [SyncThread:100:ZooKeeperServer@523] - shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO  
> [SyncThread:100:SessionTrackerImpl@232] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO  
> [SyncThread:100:LeaderRequestProcessor@77] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO  
> [SyncThread:100:PrepRequestProcessor@1035] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO  
> [SyncThread:100:ProposalRequestProcessor@88] - Shutting down
> 2015-08-14 15:41:18,561 [myid:100] - INFO  
> [SyncThread:100:CommitProcessor@356] - Shutting down
> 2015-08-14 15:41:18,561 [myid:100] - INFO  
> [CommitProcessor:100:CommitProcessor@191] - CommitProcessor exited loop!
> 2015-08-14 15:41:18,562 [myid:100] - INFO  
> [SyncThread:100:Leader$ToBeAppliedRequestProcessor@915] - Shutting down
> 2015-08-14 15:41:18,562 [myid:100] - INFO  
> [SyncThread:100:FinalRequestProcessor@646] - shutdown of request processor 
> complete
> 2015-08-14 15:41:18,562 [myid:100] - INFO  
> [SyncThread:100:SyncRequestProcessor@191] - Shutting down
> 2015-08-14 15:41:18,563 [myid:100] - INFO  [ProcessThread(sid:100 
> cport:-1)::PrepRequestProcessor@159] - PrepRequestProcessor exited loop!
> {code}
> After this exception Leader server still remains leader. After this non 
> recoverable exception the leader should go down and let other followers 
> become leader.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2247) Zookeeper service becomes unavailable when leader fails to write transaction log

[Rakesh R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh R updated ZOOKEEPER-2247:

Attachment: ZOOKEEPER-2247-21.patch

> Zookeeper service becomes unavailable when leader fails to write transaction 
> log
> 
>
> Key: ZOOKEEPER-2247
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2247
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.9, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2247-01.patch, ZOOKEEPER-2247-02.patch, 
> ZOOKEEPER-2247-03.patch, ZOOKEEPER-2247-04.patch, ZOOKEEPER-2247-05.patch, 
> ZOOKEEPER-2247-06.patch, ZOOKEEPER-2247-07.patch, ZOOKEEPER-2247-09.patch, 
> ZOOKEEPER-2247-10.patch, ZOOKEEPER-2247-11.patch, ZOOKEEPER-2247-12.patch, 
> ZOOKEEPER-2247-13.patch, ZOOKEEPER-2247-14.patch, ZOOKEEPER-2247-15.patch, 
> ZOOKEEPER-2247-16.patch, ZOOKEEPER-2247-17.patch, ZOOKEEPER-2247-18.patch, 
> ZOOKEEPER-2247-19.patch, ZOOKEEPER-2247-20.patch, ZOOKEEPER-2247-21.patch, 
> ZOOKEEPER-2247-b3.5.patch, ZOOKEEPER-2247-br-3.4.patch
>
>
> Zookeeper service becomes unavailable when leader fails to write transaction 
> log. Bellow are the exceptions
> {code}
> 2015-08-14 15:41:18,556 [myid:100] - ERROR 
> [SyncThread:100:ZooKeeperCriticalThread@48] - Severe unrecoverable error, 
> from thread : SyncThread:100
> java.io.IOException: Input/output error
>   at sun.nio.ch.FileDispatcherImpl.force0(Native Method)
>   at sun.nio.ch.FileDispatcherImpl.force(FileDispatcherImpl.java:76)
>   at sun.nio.ch.FileChannelImpl.force(FileChannelImpl.java:376)
>   at 
> org.apache.zookeeper.server.persistence.FileTxnLog.commit(FileTxnLog.java:331)
>   at 
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.commit(FileTxnSnapLog.java:380)
>   at org.apache.zookeeper.server.ZKDatabase.commit(ZKDatabase.java:563)
>   at 
> org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:178)
>   at 
> org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:113)
> 2015-08-14 15:41:18,559 [myid:100] - INFO  
> [SyncThread:100:ZooKeeperServer$ZooKeeperServerListenerImpl@500] - Thread 
> SyncThread:100 exits, error code 1
> 2015-08-14 15:41:18,559 [myid:100] - INFO  
> [SyncThread:100:ZooKeeperServer@523] - shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO  
> [SyncThread:100:SessionTrackerImpl@232] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO  
> [SyncThread:100:LeaderRequestProcessor@77] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO  
> [SyncThread:100:PrepRequestProcessor@1035] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO  
> [SyncThread:100:ProposalRequestProcessor@88] - Shutting down
> 2015-08-14 15:41:18,561 [myid:100] - INFO  
> [SyncThread:100:CommitProcessor@356] - Shutting down
> 2015-08-14 15:41:18,561 [myid:100] - INFO  
> [CommitProcessor:100:CommitProcessor@191] - CommitProcessor exited loop!
> 2015-08-14 15:41:18,562 [myid:100] - INFO  
> [SyncThread:100:Leader$ToBeAppliedRequestProcessor@915] - Shutting down
> 2015-08-14 15:41:18,562 [myid:100] - INFO  
> [SyncThread:100:FinalRequestProcessor@646] - shutdown of request processor 
> complete
> 2015-08-14 15:41:18,562 [myid:100] - INFO  
> [SyncThread:100:SyncRequestProcessor@191] - Shutting down
> 2015-08-14 15:41:18,563 [myid:100] - INFO  [ProcessThread(sid:100 
> cport:-1)::PrepRequestProcessor@159] - PrepRequestProcessor exited loop!
> {code}
> After this exception Leader server still remains leader. After this non 
> recoverable exception the leader should go down and let other followers 
> become leader.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: myid documentation

[Arshad Mohammad]

I think there is no benefit in restricting the myid range.  Also, in the
code it is taken as long. Better we can updated the document and correct
the ranger from "1-255" to 0-Long.MAX_VALUE

-Arshad

On Fri, Aug 5, 2016 at 9:48 PM, Flavio Junqueira  wrote:

> Thanks, Michael.
>
> -Flavio
>
> > On 05 Aug 2016, at 17:01, Michael Han  wrote:
> >
> > I can't find any JIRA related to this either, so just created one
> > https://issues.apache.org/jira/browse/ZOOKEEPER-2503
> >
> > On Fri, Aug 5, 2016 at 7:07 AM, Flavio Junqueira  wrote:
> >
> >> I noticed that the documentation says that the myid value needs to be
> >> between 0 and 255. The code currently does not impose such a limitation
> and
> >> I also found this thread briefly discussing it:
> >>
> >> https://mail-archives.apache.org/mod_mbox/zookeeper-user/
> >> 201507.mbox/%3CCABQ=58TqB3ntBY2oW0gDRvDb_XgZh8k99D11GeAf+CdfSJMOhA@
> >> mail.gmail.com%3E  >> org/mod_mbox/zookeeper-user/201507.mbox/%3CCABQ=58TqB3ntBY2oW0gDRvDb_
> >> xgzh8k99d11geaf+cdfsjm...@mail.gmail.com%3E>
> >>
> >> Is anyone aware of a jira for this? I couldn't find any
> >>
> >> -Flavio
> >
> >
> >
> >
> > --
> > Cheers
> > Michael.
>
>

[jira] [Commented] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409673#comment-15409673
 ] 

Michael Han commented on ZOOKEEPER-2383:


One small suggestion - the condition of {code} zkServer == null || 
!zkServer.isRunning() {code} could be refactored into a dedicated method such 
as {code} boolean isZKServerRunning(ZooKeeperServer zkServer) { return zkServer 
!= null && zkServer.isRunning(); }{code}, which centralized such logic and make 
it reusable later. We could put it in Command.java or ZKUtil.java maybe?

> Startup race in ZooKeeperServer
> ---
>
> Key: ZOOKEEPER-2383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2383
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: jmx, server
>Affects Versions: 3.4.8
>Reporter: Steve Rowe
>Assignee: Rakesh R
>Priority: Blocker
> Fix For: 3.4.9, 3.5.3, 3.6.0
>
> Attachments: TestZkStandaloneJMXRegistrationRaceConcurrent.java, 
> ZOOKEEPER-2383-br-3-4.patch, ZOOKEEPER-2383.patch, ZOOKEEPER-2383.patch, 
> release-3.4.8-extra-logging.patch, zk-3.4.8-MBeanRegistry.log, 
> zk-3.4.8-NPE.log
>
>
> In attempting to upgrade Solr's ZooKeeper dependency from 3.4.6 to 3.4.8 
> (SOLR-8724) I ran into test failures where attempts to create a node in a 
> newly started standalone ZooKeeperServer were failing because of an assertion 
> in MBeanRegistry.
> ZooKeeperServer.startup() first sets up its request processor chain then 
> registers itself in JMX, but if a connection comes in before the server's JMX 
> registration happens, registration of the connection will fail because it 
> trips the assertion that (effectively) its parent (the server) has already 
> registered itself.
> {code:java|title=ZooKeeperServer.java}
> public synchronized void startup() {
> if (sessionTracker == null) {
> createSessionTracker();
> }
> startSessionTracker();
> setupRequestProcessors();
> registerJMX();
> state = State.RUNNING;
> notifyAll();
> }
> {code}
> {code:java|title=MBeanRegistry.java}
> public void register(ZKMBeanInfo bean, ZKMBeanInfo parent)
> throws JMException
> {
> assert bean != null;
> String path = null;
> if (parent != null) {
> path = mapBean2Path.get(parent);
> assert path != null;
> }
> {code}
> This problem appears to be new with ZK 3.4.8 - AFAIK Solr never had this 
> issue with ZK 3.4.6. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: myid documentation

[Flavio Junqueira]

Thanks, Michael.

-Flavio

> On 05 Aug 2016, at 17:01, Michael Han  wrote:
> 
> I can't find any JIRA related to this either, so just created one
> https://issues.apache.org/jira/browse/ZOOKEEPER-2503
> 
> On Fri, Aug 5, 2016 at 7:07 AM, Flavio Junqueira  wrote:
> 
>> I noticed that the documentation says that the myid value needs to be
>> between 0 and 255. The code currently does not impose such a limitation and
>> I also found this thread briefly discussing it:
>> 
>> https://mail-archives.apache.org/mod_mbox/zookeeper-user/
>> 201507.mbox/%3CCABQ=58TqB3ntBY2oW0gDRvDb_XgZh8k99D11GeAf+CdfSJMOhA@
>> mail.gmail.com%3E > org/mod_mbox/zookeeper-user/201507.mbox/%3CCABQ=58TqB3ntBY2oW0gDRvDb_
>> xgzh8k99d11geaf+cdfsjm...@mail.gmail.com%3E>
>> 
>> Is anyone aware of a jira for this? I couldn't find any
>> 
>> -Flavio
> 
> 
> 
> 
> -- 
> Cheers
> Michael.

[jira] [Commented] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409640#comment-15409640
 ] 

Michael Han commented on ZOOKEEPER-2383:


ZOOKEEPER-2383-br-3-4.patch may also be updated with this fix as well.

> Startup race in ZooKeeperServer
> ---
>
> Key: ZOOKEEPER-2383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2383
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: jmx, server
>Affects Versions: 3.4.8
>Reporter: Steve Rowe
>Assignee: Rakesh R
>Priority: Blocker
> Fix For: 3.4.9, 3.5.3, 3.6.0
>
> Attachments: TestZkStandaloneJMXRegistrationRaceConcurrent.java, 
> ZOOKEEPER-2383-br-3-4.patch, ZOOKEEPER-2383.patch, ZOOKEEPER-2383.patch, 
> release-3.4.8-extra-logging.patch, zk-3.4.8-MBeanRegistry.log, 
> zk-3.4.8-NPE.log
>
>
> In attempting to upgrade Solr's ZooKeeper dependency from 3.4.6 to 3.4.8 
> (SOLR-8724) I ran into test failures where attempts to create a node in a 
> newly started standalone ZooKeeperServer were failing because of an assertion 
> in MBeanRegistry.
> ZooKeeperServer.startup() first sets up its request processor chain then 
> registers itself in JMX, but if a connection comes in before the server's JMX 
> registration happens, registration of the connection will fail because it 
> trips the assertion that (effectively) its parent (the server) has already 
> registered itself.
> {code:java|title=ZooKeeperServer.java}
> public synchronized void startup() {
> if (sessionTracker == null) {
> createSessionTracker();
> }
> startSessionTracker();
> setupRequestProcessors();
> registerJMX();
> state = State.RUNNING;
> notifyAll();
> }
> {code}
> {code:java|title=MBeanRegistry.java}
> public void register(ZKMBeanInfo bean, ZKMBeanInfo parent)
> throws JMException
> {
> assert bean != null;
> String path = null;
> if (parent != null) {
> path = mapBean2Path.get(parent);
> assert path != null;
> }
> {code}
> This problem appears to be new with ZK 3.4.8 - AFAIK Solr never had this 
> issue with ZK 3.4.6. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: myid documentation

[Michael Han]

I can't find any JIRA related to this either, so just created one
https://issues.apache.org/jira/browse/ZOOKEEPER-2503

On Fri, Aug 5, 2016 at 7:07 AM, Flavio Junqueira  wrote:

> I noticed that the documentation says that the myid value needs to be
> between 0 and 255. The code currently does not impose such a limitation and
> I also found this thread briefly discussing it:
>
> https://mail-archives.apache.org/mod_mbox/zookeeper-user/
> 201507.mbox/%3CCABQ=58TqB3ntBY2oW0gDRvDb_XgZh8k99D11GeAf+CdfSJMOhA@
> mail.gmail.com%3E  org/mod_mbox/zookeeper-user/201507.mbox/%3CCABQ=58TqB3ntBY2oW0gDRvDb_
> xgzh8k99d11geaf+cdfsjm...@mail.gmail.com%3E>
>
> Is anyone aware of a jira for this? I couldn't find any
>
> -Flavio




-- 
Cheers
Michael.

[jira] [Created] (ZOOKEEPER-2503) Enforce myid has a value between [1, 255] inclusive.

[Michael Han (JIRA)]

Michael Han created ZOOKEEPER-2503:
--

 Summary: Enforce myid has a value between [1, 255] inclusive.
 Key: ZOOKEEPER-2503
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2503
 Project: ZooKeeper
  Issue Type: Bug
  Components: server
Affects Versions: 3.5.2, 3.4.9
Reporter: Michael Han
 Fix For: 3.5.3, 3.4.10


In ZK documentation, we have:

"The myid file consists of a single line containing only the text of that 
machine's id. So myid of server 1 would contain the text "1" and nothing else. 
The id must be unique within the ensemble and should have a value between 1 and 
255."

This however is not enforced in code, which should be fixed.
Discussion thread:
http://zookeeper-user.578899.n2.nabble.com/Is-myid-actually-limited-to-1-255-td7581270.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZOOKEEPER-2502) Flaky Test: org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion

[Michael Han (JIRA)]

Michael Han created ZOOKEEPER-2502:
--

 Summary: Flaky Test: 
org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion
 Key: ZOOKEEPER-2502
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2502
 Project: ZooKeeper
  Issue Type: Bug
  Components: tests
Affects Versions: 3.4.9
Reporter: Michael Han
 Fix For: 3.4.10


{noformat}
Error Message

Broken pipe
Stacktrace

java.io.IOException: Broken pipe
at sun.nio.ch.FileDispatcherImpl.write0(Native Method)
at sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:47)
at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93)
at sun.nio.ch.IOUtil.write(IOUtil.java:65)
at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:466)
at java.nio.channels.Channels.writeFullyImpl(Channels.java:78)
at java.nio.channels.Channels.writeFully(Channels.java:98)
at java.nio.channels.Channels.access$000(Channels.java:61)
at java.nio.channels.Channels$1.write(Channels.java:174)
at java.io.OutputStream.write(OutputStream.java:75)
at java.nio.channels.Channels$1.write(Channels.java:155)
at java.io.DataOutputStream.writeInt(DataOutputStream.java:198)
at 
org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion(CnxManagerTest.java:318)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55)
Standard Output

2016-07-12 22:34:46,623 [myid:] - INFO  [main:ZKTestCase$1@50] - STARTING 
testCnxFromFutureVersion
2016-07-12 22:34:46,627 [myid:] - INFO  [main:PortAssignment@32] - assigning 
port 11221
2016-07-12 22:34:46,630 [myid:] - INFO  [main:PortAssignment@32] - assigning 
port 11222
2016-07-12 22:34:46,631 [myid:] - INFO  [main:PortAssignment@32] - assigning 
port 11223
2016-07-12 22:34:46,643 [myid:] - INFO  [main:QuorumPeer$QuorumServer@149] - 
Resolved hostname: 0.0.0.0 to address: /0.0.0.0
2016-07-12 22:34:46,658 [myid:] - INFO  [main:PortAssignment@32] - assigning 
port 11224
2016-07-12 22:34:46,658 [myid:] - INFO  [main:PortAssignment@32] - assigning 
port 11225
2016-07-12 22:34:46,659 [myid:] - INFO  [main:PortAssignment@32] - assigning 
port 11226
2016-07-12 22:34:46,659 [myid:] - INFO  [main:QuorumPeer$QuorumServer@149] - 
Resolved hostname: 0.0.0.0 to address: /0.0.0.0
2016-07-12 22:34:46,659 [myid:] - INFO  [main:PortAssignment@32] - assigning 
port 11227
2016-07-12 22:34:46,659 [myid:] - INFO  [main:PortAssignment@32] - assigning 
port 11228
2016-07-12 22:34:46,659 [myid:] - INFO  [main:PortAssignment@32] - assigning 
port 11229
2016-07-12 22:34:46,660 [myid:] - INFO  [main:QuorumPeer$QuorumServer@149] - 
Resolved hostname: 0.0.0.0 to address: /0.0.0.0
2016-07-12 22:34:46,660 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@53] - RUNNING TEST METHOD 
testCnxFromFutureVersion
2016-07-12 22:34:46,672 [myid:] - INFO  [main:NIOServerCnxnFactory@89] - 
binding to port 0.0.0.0/0.0.0.0:11225
2016-07-12 22:34:46,692 [myid:] - INFO  [main:CnxManagerTest@301] - Election 
port: 11226
2016-07-12 22:34:46,692 [myid:] - INFO  
[ListenerThread:QuorumCnxManager$Listener@534] - My election bind port: 
/0.0.0.0:11226
2016-07-12 22:34:47,696 [myid:] - INFO  
[/0.0.0.0:11226:QuorumCnxManager$Listener@541] - Received connection request 
/140.211.11.27:48724
2016-07-12 22:34:49,700 [myid:] - WARN  [/0.0.0.0:11226:QuorumCnxManager@274] - 
Exception reading or writing challenge: java.net.SocketTimeoutException: Read 
timed out
2016-07-12 22:34:52,700 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@74] - TEST METHOD FAILED 
testCnxFromFutureVersion
java.io.IOException: Broken pipe
at sun.nio.ch.FileDispatcherImpl.write0(Native Method)
at sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:47)
at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93)
at sun.nio.ch.IOUtil.write(IOUtil.java:65)
at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:466)
at java.nio.channels.Channels.writeFullyImpl(Channels.java:78)
at java.nio.channels.Channels.writeFully(Channels.java:98)
at java.nio.channels.Channels.access$000(Channels.java:61)
at java.nio.channels.Channels$1.write(Channels.java:174)
at java.io.OutputStream.write(OutputStream.java:75)
at java.nio.channels.Channels$1.write(Channels.java:155)
at java.io.DataOutputStream.writeInt(DataOutputStream.java:198)
at 
org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion(CnxManagerTest.java:318)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at 

ZooKeeper_branch35_jdk8 - Build # 179 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/179/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 448467 lines...]
 [exec] Log Message Received: [2016-08-05 
14:03:39,808:17866(0x2abd54713540):ZOO_INFO@testLogCallbackInit@993: 
testLogCallbackInit #8]
 [exec] Log Message Received: [2016-08-05 
14:03:39,808:17866(0x2abd54713540):ZOO_INFO@testLogCallbackInit@993: 
testLogCallbackInit #9]
 [exec] Log Message Received: [2016-08-05 
14:03:39,808:17866(0x2abd54713540):ZOO_INFO@zookeeper_close@3258: Closing 
zookeeper sessionId=0x101b4a6a963000e to [127.0.0.1:22181]
 [exec] ]
 [exec]  : elapsed 1001 : OK
 [exec] Zookeeper_simpleSystem::testLogCallbackClearLog Message Received: 
[2016-08-05 14:03:39,808:17866(0x2abd54713540):ZOO_INFO@log_env@1027: Client 
environment:zookeeper.version=zookeeper C client 3.5.2]
 [exec] Log Message Received: [2016-08-05 
14:03:39,808:17866(0x2abd54713540):ZOO_INFO@log_env@1031: Client 
environment:host.name=penates.apache.org]
 [exec] Log Message Received: [2016-08-05 
14:03:39,808:17866(0x2abd54713540):ZOO_INFO@log_env@1038: Client 
environment:os.name=Linux]
 [exec] Log Message Received: [2016-08-05 
14:03:39,808:17866(0x2abd54713540):ZOO_INFO@log_env@1039: Client 
environment:os.arch=3.13.0-36-lowlatency]
 [exec] Log Message Received: [2016-08-05 
14:03:39,808:17866(0x2abd54713540):ZOO_INFO@log_env@1040: Client 
environment:os.version=#63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014]
 [exec] Log Message Received: [2016-08-05 
14:03:39,809:17866(0x2abd54713540):ZOO_INFO@log_env@1048: Client 
environment:user.name=jenkins]
 [exec] Log Message Received: [2016-08-05 
14:03:39,809:17866(0x2abd54713540):ZOO_INFO@log_env@1056: Client 
environment:user.home=/home/jenkins]
 [exec] Log Message Received: [2016-08-05 
14:03:39,809:17866(0x2abd54713540):ZOO_INFO@log_env@1068: Client 
environment:user.dir=/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk8/branch-3.5/build/test/test-cppunit]
 [exec] Log Message Received: [2016-08-05 
14:03:39,809:17866(0x2abd54713540):ZOO_INFO@zookeeper_init_internal@: 
Initiating client connection, host=127.0.0.1:22181 sessionTimeout=1 
watcher=0x45d2a0 sessionId=0 sessionPasswd= context=0x7fff72cbdc80 
flags=0]
 [exec] Log Message Received: [2016-08-05 
14:03:39,809:17866(0x2abd56770700):ZOO_INFO@check_events@2357: initiated 
connection to server [127.0.0.1:22181]]
 [exec] Log Message Received: [2016-08-05 
14:03:39,828:17866(0x2abd56770700):ZOO_INFO@check_events@2409: session 
establishment complete on server [127.0.0.1:22181], 
sessionId=0x101b4a6a963000f, negotiated timeout=1 ]
 [exec]  : elapsed 1000 : OK
 [exec] Zookeeper_simpleSystem::testAsyncWatcherAutoReset ZooKeeper server 
started : elapsed 9200 : OK
 [exec] Zookeeper_simpleSystem::testDeserializeString : elapsed 0 : OK
 [exec] Zookeeper_simpleSystem::testFirstServerDown : elapsed 1001 : OK
 [exec] Zookeeper_simpleSystem::testNullData : elapsed 1049 : OK
 [exec] Zookeeper_simpleSystem::testIPV6 : elapsed 1030 : OK
 [exec] Zookeeper_simpleSystem::testCreate : elapsed 1056 : OK
 [exec] Zookeeper_simpleSystem::testPath : elapsed 1231 : OK
 [exec] Zookeeper_simpleSystem::testPathValidation : elapsed 1460 : OK
 [exec] Zookeeper_simpleSystem::testPing : elapsed 18639 : OK
 [exec] Zookeeper_simpleSystem::testAcl : elapsed 1036 : OK
 [exec] Zookeeper_simpleSystem::testChroot : elapsed 4123 : OK
 [exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started ZooKeeper 
server started : elapsed 30107 : OK
 [exec] Zookeeper_simpleSystem::testHangingClient : elapsed 1077 : OK
 [exec] Zookeeper_simpleSystem::testWatcherAutoResetWithGlobal ZooKeeper 
server started ZooKeeper server started ZooKeeper server started : elapsed 
15311 : OK
 [exec] Zookeeper_simpleSystem::testWatcherAutoResetWithLocal ZooKeeper 
server started ZooKeeper server started ZooKeeper server started : elapsed 
13979 : OK
 [exec] Zookeeper_simpleSystem::testGetChildren2 : elapsed 1056 : OK
 [exec] Zookeeper_simpleSystem::testLastZxid : elapsed 4692 : OK
 [exec] Zookeeper_simpleSystem::testRemoveWatchers ZooKeeper server started 
: elapsed 3094 : OK
 [exec] Zookeeper_readOnly::testReadOnly : elapsed 4233 : OK
 [exec] 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk8/branch-3.5/src/c/tests/TestReconfig.cc:504:
 Assertion: equality assertion failed [Expected: 10.10.10.12:2012, Actual  : 
10.10.10.11:2011]
 [exec] Failures !!!
 [exec] Run: 72   Failure total: 1   Failures: 1   Errors: 0
 [exec] FAIL: zktest-mt
 [exec] ==
 [exec] 1 of 2 tests failed
 [exec] Please report to u...@zookeeper.apache.org
 [exec] 

myid documentation

[Flavio Junqueira]

I noticed that the documentation says that the myid value needs to be between 0 
and 255. The code currently does not impose such a limitation and I also found 
this thread briefly discussing it:

https://mail-archives.apache.org/mod_mbox/zookeeper-user/201507.mbox/%3CCABQ=58tqb3ntby2ow0gdrvdb_xgzh8k99d11geaf+cdfsjm...@mail.gmail.com%3E
 


Is anyone aware of a jira for this? I couldn't find any

-Flavio

ZooKeeper_branch35_openjdk7 - Build # 179 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/179/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 440113 lines...]
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2016-08-05 12:20:28,179 [myid:] - WARN  [New I/O boss 
#9405:ClientCnxnSocketNetty$ZKClientHandler@439] - Exception caught: [id: 
0x3e88061d] EXCEPTION: java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:16729
[junit] java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:16729
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2016-08-05 12:20:28,179 [myid:] - INFO  [New I/O boss 
#9405:ClientCnxnSocketNetty@208] - channel is told closing
[junit] 2016-08-05 12:20:28,179 [myid:127.0.0.1:16729] - INFO  
[main-SendThread(127.0.0.1:16729):ClientCnxn$SendThread@1231] - channel for 
sessionid 0x10469ff14d0 is lost, closing socket connection and attempting 
reconnect
[junit] 2016-08-05 12:20:28,266 [myid:] - INFO  [ProcessThread(sid:0 
cport:16852)::PrepRequestProcessor@647] - Processed session termination for 
sessionid: 0x1046a020250
[junit] 2016-08-05 12:20:28,282 [myid:] - INFO  
[main:ClientCnxnSocketNetty@208] - channel is told closing
[junit] 2016-08-05 12:20:28,282 [myid:] - INFO  [New I/O worker 
#14359:ClientCnxnSocketNetty$ZKClientHandler@384] - channel is disconnected: 
[id: 0x21377cb0, /127.0.0.1:57936 :> 127.0.0.1/127.0.0.1:16852]
[junit] 2016-08-05 12:20:28,282 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16852,name1=Connections,name2=127.0.0.1,name3=0x1046a020250]
[junit] 2016-08-05 12:20:28,283 [myid:] - INFO  [New I/O worker 
#14359:ClientCnxnSocketNetty@208] - channel is told closing
[junit] 2016-08-05 12:20:28,282 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1046a020250
[junit] 2016-08-05 12:20:28,282 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x1046a020250 closed
[junit] 2016-08-05 12:20:28,283 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 135380
[junit] 2016-08-05 12:20:28,283 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 1776
[junit] 2016-08-05 12:20:28,283 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2016-08-05 12:20:28,283 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-08-05 12:20:28,283 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-08-05 12:20:28,284 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:16852
[junit] 2016-08-05 12:20:28,305 [myid:] - INFO  [main:ZooKeeperServer@498] 
- shutting down
[junit] 2016-08-05 12:20:28,305 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2016-08-05 12:20:28,306 [myid:] - INFO  
[main:PrepRequestProcessor@965] - Shutting down
[junit] 2016-08-05 12:20:28,306 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2016-08-05 12:20:28,306 [myid:] - INFO  [ProcessThread(sid:0 
cport:16852)::PrepRequestProcessor@154] - PrepRequestProcessor exited loop!
[junit] 2016-08-05 12:20:28,306 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 

[jira] [Commented] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409316#comment-15409316
 ] 

Hadoop QA commented on ZOOKEEPER-2383:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12822237/ZOOKEEPER-2383.patch
  against trunk revision 1755100.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3325//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3325//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3325//console

This message is automatically generated.

> Startup race in ZooKeeperServer
> ---
>
> Key: ZOOKEEPER-2383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2383
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: jmx, server
>Affects Versions: 3.4.8
>Reporter: Steve Rowe
>Assignee: Rakesh R
>Priority: Blocker
> Fix For: 3.4.9, 3.5.3, 3.6.0
>
> Attachments: TestZkStandaloneJMXRegistrationRaceConcurrent.java, 
> ZOOKEEPER-2383-br-3-4.patch, ZOOKEEPER-2383.patch, ZOOKEEPER-2383.patch, 
> release-3.4.8-extra-logging.patch, zk-3.4.8-MBeanRegistry.log, 
> zk-3.4.8-NPE.log
>
>
> In attempting to upgrade Solr's ZooKeeper dependency from 3.4.6 to 3.4.8 
> (SOLR-8724) I ran into test failures where attempts to create a node in a 
> newly started standalone ZooKeeperServer were failing because of an assertion 
> in MBeanRegistry.
> ZooKeeperServer.startup() first sets up its request processor chain then 
> registers itself in JMX, but if a connection comes in before the server's JMX 
> registration happens, registration of the connection will fail because it 
> trips the assertion that (effectively) its parent (the server) has already 
> registered itself.
> {code:java|title=ZooKeeperServer.java}
> public synchronized void startup() {
> if (sessionTracker == null) {
> createSessionTracker();
> }
> startSessionTracker();
> setupRequestProcessors();
> registerJMX();
> state = State.RUNNING;
> notifyAll();
> }
> {code}
> {code:java|title=MBeanRegistry.java}
> public void register(ZKMBeanInfo bean, ZKMBeanInfo parent)
> throws JMException
> {
> assert bean != null;
> String path = null;
> if (parent != null) {
> path = mapBean2Path.get(parent);
> assert path != null;
> }
> {code}
> This problem appears to be new with ZK 3.4.8 - AFAIK Solr never had this 
> issue with ZK 3.4.6. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk-solaris - Build # 1257 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1257/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 410138 lines...]
[junit] 2016-08-05 08:33:12,343 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:64877
[junit] 2016-08-05 08:33:12,343 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:64877
[junit] 2016-08-05 08:33:12,344 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-08-05 08:33:12,344 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:64877 (no session established for client)
[junit] 2016-08-05 08:33:12,344 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-08-05 08:33:12,346 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-08-05 08:33:12,346 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-08-05 08:33:12,346 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-08-05 08:33:12,347 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-08-05 08:33:12,347 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17982
[junit] 2016-08-05 08:33:12,347 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-08-05 08:33:12,348 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-08-05 08:33:12,348 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-08-05 08:33:14,171 [myid:127.0.0.1:11222] - INFO  
[main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:11222. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-08-05 08:33:14,171 [myid:127.0.0.1:11222] - INFO  
[main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@948] - Socket 
connection established, initiating session, client: null, server: null
[junit] 2016-08-05 08:33:14,172 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:64878
[junit] 2016-08-05 08:33:14,173 [myid:] - INFO  
[NIOWorkerThread-2:ZooKeeperServer@969] - Client attempting to renew session 
0x122d6d1ac28 at /127.0.0.1:64878
[junit] 2016-08-05 08:33:14,173 [myid:] - INFO  
[NIOWorkerThread-2:ZooKeeperServer@678] - Established session 0x122d6d1ac28 
with negotiated timeout 3 for client /127.0.0.1:64878
[junit] 2016-08-05 08:33:14,174 [myid:127.0.0.1:11222] - INFO  
[main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@1381] - Session 
establishment complete on server null, sessionid = 0x122d6d1ac28, 
negotiated timeout = 3
[junit] 2016-08-05 08:33:14,175 [myid:] - INFO  [ProcessThread(sid:0 
cport:11222)::PrepRequestProcessor@647] - Processed session termination for 
sessionid: 0x122d6d1ac28
[junit] 2016-08-05 08:33:14,175 [myid:] - INFO  
[SyncThread:0:FileTxnLog@204] - Creating new log file: log.c
[junit] 2016-08-05 08:33:14,261 [myid:] - INFO  
[SessionTracker:SessionTrackerImpl@158] - SessionTrackerImpl exited loop!
[junit] 2016-08-05 08:33:14,261 [myid:] - INFO  
[SessionTracker:SessionTrackerImpl@158] - SessionTrackerImpl exited loop!
[junit] 2016-08-05 08:33:14,271 [myid:] - INFO  
[NIOWorkerThread-5:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=Connections,name2=127.0.0.1,name3=0x122d6d1ac28]
[junit] 2016-08-05 08:33:14,271 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x122d6d1ac28
[junit] 2016-08-05 08:33:14,271 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x122d6d1ac28 closed
[junit] 2016-08-05 08:33:14,271 [myid:] - INFO  
[NIOWorkerThread-5:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:64878 which had sessionid 0x122d6d1ac28
[junit] 2016-08-05 08:33:14,271 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-08-05 08:33:14,272 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-08-05 08:33:14,272 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-08-05 

[jira] [Commented] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408930#comment-15408930
 ] 

Hadoop QA commented on ZOOKEEPER-2383:
--

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12822237/ZOOKEEPER-2383.patch
  against trunk revision 1755100.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3324//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3324//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3324//console

This message is automatically generated.

> Startup race in ZooKeeperServer
> ---
>
> Key: ZOOKEEPER-2383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2383
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: jmx, server
>Affects Versions: 3.4.8
>Reporter: Steve Rowe
>Assignee: Rakesh R
>Priority: Blocker
> Fix For: 3.4.9, 3.5.3, 3.6.0
>
> Attachments: TestZkStandaloneJMXRegistrationRaceConcurrent.java, 
> ZOOKEEPER-2383-br-3-4.patch, ZOOKEEPER-2383.patch, ZOOKEEPER-2383.patch, 
> release-3.4.8-extra-logging.patch, zk-3.4.8-MBeanRegistry.log, 
> zk-3.4.8-NPE.log
>
>
> In attempting to upgrade Solr's ZooKeeper dependency from 3.4.6 to 3.4.8 
> (SOLR-8724) I ran into test failures where attempts to create a node in a 
> newly started standalone ZooKeeperServer were failing because of an assertion 
> in MBeanRegistry.
> ZooKeeperServer.startup() first sets up its request processor chain then 
> registers itself in JMX, but if a connection comes in before the server's JMX 
> registration happens, registration of the connection will fail because it 
> trips the assertion that (effectively) its parent (the server) has already 
> registered itself.
> {code:java|title=ZooKeeperServer.java}
> public synchronized void startup() {
> if (sessionTracker == null) {
> createSessionTracker();
> }
> startSessionTracker();
> setupRequestProcessors();
> registerJMX();
> state = State.RUNNING;
> notifyAll();
> }
> {code}
> {code:java|title=MBeanRegistry.java}
> public void register(ZKMBeanInfo bean, ZKMBeanInfo parent)
> throws JMException
> {
> assert bean != null;
> String path = null;
> if (parent != null) {
> path = mapBean2Path.get(parent);
> assert path != null;
> }
> {code}
> This problem appears to be new with ZK 3.4.8 - AFAIK Solr never had this 
> issue with ZK 3.4.6. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Success: ZOOKEEPER-2383 PreCommit Build #3324

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2383
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3324/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 441093 lines...]
 [exec]   
http://issues.apache.org/jira/secure/attachment/12822237/ZOOKEEPER-2383.patch
 [exec]   against trunk revision 1755100.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3324//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3324//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3324//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 67c0fa26cd80ad1c6aed3a31f792311ac6af7d1c logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 20 minutes 46 seconds
Archiving artifacts
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Recording test results
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
[description-setter] Description set: ZOOKEEPER-2383
Email was triggered for: Success
Sending email for trigger: Success
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7
Setting 
LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed