[jira] [Commented] (ZOOKEEPER-2505) Use shared library instead of static library in C client unit test
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429097#comment-15429097 ] Michael Han commented on ZOOKEEPER-2505: [~cnauroth] I think that is a good idea, thanks for brought it up. Created ZOOKEEPER-2518 for doc jira. > Use shared library instead of static library in C client unit test > -- > > Key: ZOOKEEPER-2505 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2505 > Project: ZooKeeper > Issue Type: Improvement > Components: c client >Affects Versions: 3.5.2 >Reporter: Michael Han >Assignee: Michael Han >Priority: Minor > Fix For: 3.5.3 > > Attachments: ZOOKEEPER-2505.patch > > > Currently we are statically linking c unit tests to ZK client library - we > should use shared library instead as there seems no particular reason to > stick to static library, plus one benefit of using shared library is that > would allow us to use overrides function calls from standard libraries at > link time so we can simulate the wrap option for ld linker on os x. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZOOKEEPER-2518) Document how to set up tool chains for build and test C client on all platforms
Michael Han created ZOOKEEPER-2518: -- Summary: Document how to set up tool chains for build and test C client on all platforms Key: ZOOKEEPER-2518 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2518 Project: ZooKeeper Issue Type: Improvement Components: documentation Reporter: Michael Han Priority: Minor Add documentations on how to set up ZooKeeper development environment for C client for all platforms. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2502) Flaky Test: org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429082#comment-15429082 ] Hadoop QA commented on ZOOKEEPER-2502: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12824669/ZOOKEEPER-2502.patch against trunk revision 1756262. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3370//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion > -- > > Key: ZOOKEEPER-2502 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2502 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.4.9 >Reporter: Michael Han >Assignee: Michael Han > Labels: flaky, flaky-test > Fix For: 3.4.10 > > Attachments: ZOOKEEPER-2502.patch > > > {noformat} > Error Message > Broken pipe > Stacktrace > java.io.IOException: Broken pipe > at sun.nio.ch.FileDispatcherImpl.write0(Native Method) > at sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:47) > at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93) > at sun.nio.ch.IOUtil.write(IOUtil.java:65) > at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:466) > at java.nio.channels.Channels.writeFullyImpl(Channels.java:78) > at java.nio.channels.Channels.writeFully(Channels.java:98) > at java.nio.channels.Channels.access$000(Channels.java:61) > at java.nio.channels.Channels$1.write(Channels.java:174) > at java.io.OutputStream.write(OutputStream.java:75) > at java.nio.channels.Channels$1.write(Channels.java:155) > at java.io.DataOutputStream.writeInt(DataOutputStream.java:198) > at > org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion(CnxManagerTest.java:318) > at > org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55) > Standard Output > 2016-07-12 22:34:46,623 [myid:] - INFO [main:ZKTestCase$1@50] - STARTING > testCnxFromFutureVersion > 2016-07-12 22:34:46,627 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11221 > 2016-07-12 22:34:46,630 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11222 > 2016-07-12 22:34:46,631 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11223 > 2016-07-12 22:34:46,643 [myid:] - INFO [main:QuorumPeer$QuorumServer@149] - > Resolved hostname: 0.0.0.0 to address: /0.0.0.0 > 2016-07-12 22:34:46,658 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11224 > 2016-07-12 22:34:46,658 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11225 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11226 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:QuorumPeer$QuorumServer@149] - > Resolved hostname: 0.0.0.0 to address: /0.0.0.0 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11227 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11228 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11229 > 2016-07-12 22:34:46,660 [myid:] - INFO [main:QuorumPeer$QuorumServer@149] - > Resolved hostname: 0.0.0.0 to address: /0.0.0.0 > 2016-07-12 22:34:46,660 [myid:] - INFO > [main:JUnit4ZKTestRunner$LoggedInvokeMethod@53] - RUNNING TEST METHOD > testCnxFromFutureVersion > 2016-07-12 22:34:46,672 [myid:] - INFO [main:NIOServerCnxnFactory@89] - > binding to port 0.0.0.0/0.0.0.0:11225 > 2016-07-12 22:34:46,692 [myid:] - INFO [main:CnxManagerTest@301] - Election > port: 11226 > 2016-07-12 22:34:46,692 [myid:] - INFO > [ListenerThread:QuorumCnxManager$Listener@534] - My election bind port: > /0.0.0.0:11226 > 2016-07-12 22:34:47,696 [myid:] - INFO > [/0.0.0.0:11226:QuorumCnxManager$Listener@541] - Received connection request > /140.211.11.27:48724 > 2016-07-12 22:34:49,700 [myid:] - WARN [/0.0.0.0:11226:QuorumCnxManager@274] > - Exception reading or writing challenge: java.net.SocketTimeoutException: > Read timed out > 2016-07-12 22:34:52,700 [myid:] - INFO > [main:JUnit4ZKTestRunner$LoggedInvokeMethod@74] - TEST METHOD FAILED > testCnxFromFutureVersion > java.io.IOException: Broken pipe > at sun.nio.ch.FileDispatcherImpl.write0(Native Method) > at sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:47) > at
Failed: ZOOKEEPER-2502 PreCommit Build #3370
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2502 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3370/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 104 lines...] [exec] 1 out of 1 hunk ignored [exec] PATCH APPLICATION FAILED [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12824669/ZOOKEEPER-2502.patch [exec] against trunk revision 1756262. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] -1 patch. The patch command could not apply the patch. [exec] [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3370//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 5974c48b2bbe06c662e477b90ea1bdf0c4686dc8 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1605: exec returned: 1 Total time: 49 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Recording test results Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error? Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 [description-setter] Description set: ZOOKEEPER-2502 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-2502) Flaky Test: org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429079#comment-15429079 ] Michael Han commented on ZOOKEEPER-2502: One side note is this flaky test contributes to 80% of the failure of branch-3.4 build on Apache build bots, so get this in can make the trend graph looks much better :) > Flaky Test: > org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion > -- > > Key: ZOOKEEPER-2502 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2502 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.4.9 >Reporter: Michael Han >Assignee: Michael Han > Labels: flaky, flaky-test > Fix For: 3.4.10 > > Attachments: ZOOKEEPER-2502.patch > > > {noformat} > Error Message > Broken pipe > Stacktrace > java.io.IOException: Broken pipe > at sun.nio.ch.FileDispatcherImpl.write0(Native Method) > at sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:47) > at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93) > at sun.nio.ch.IOUtil.write(IOUtil.java:65) > at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:466) > at java.nio.channels.Channels.writeFullyImpl(Channels.java:78) > at java.nio.channels.Channels.writeFully(Channels.java:98) > at java.nio.channels.Channels.access$000(Channels.java:61) > at java.nio.channels.Channels$1.write(Channels.java:174) > at java.io.OutputStream.write(OutputStream.java:75) > at java.nio.channels.Channels$1.write(Channels.java:155) > at java.io.DataOutputStream.writeInt(DataOutputStream.java:198) > at > org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion(CnxManagerTest.java:318) > at > org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55) > Standard Output > 2016-07-12 22:34:46,623 [myid:] - INFO [main:ZKTestCase$1@50] - STARTING > testCnxFromFutureVersion > 2016-07-12 22:34:46,627 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11221 > 2016-07-12 22:34:46,630 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11222 > 2016-07-12 22:34:46,631 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11223 > 2016-07-12 22:34:46,643 [myid:] - INFO [main:QuorumPeer$QuorumServer@149] - > Resolved hostname: 0.0.0.0 to address: /0.0.0.0 > 2016-07-12 22:34:46,658 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11224 > 2016-07-12 22:34:46,658 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11225 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11226 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:QuorumPeer$QuorumServer@149] - > Resolved hostname: 0.0.0.0 to address: /0.0.0.0 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11227 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11228 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11229 > 2016-07-12 22:34:46,660 [myid:] - INFO [main:QuorumPeer$QuorumServer@149] - > Resolved hostname: 0.0.0.0 to address: /0.0.0.0 > 2016-07-12 22:34:46,660 [myid:] - INFO > [main:JUnit4ZKTestRunner$LoggedInvokeMethod@53] - RUNNING TEST METHOD > testCnxFromFutureVersion > 2016-07-12 22:34:46,672 [myid:] - INFO [main:NIOServerCnxnFactory@89] - > binding to port 0.0.0.0/0.0.0.0:11225 > 2016-07-12 22:34:46,692 [myid:] - INFO [main:CnxManagerTest@301] - Election > port: 11226 > 2016-07-12 22:34:46,692 [myid:] - INFO > [ListenerThread:QuorumCnxManager$Listener@534] - My election bind port: > /0.0.0.0:11226 > 2016-07-12 22:34:47,696 [myid:] - INFO > [/0.0.0.0:11226:QuorumCnxManager$Listener@541] - Received connection request > /140.211.11.27:48724 > 2016-07-12 22:34:49,700 [myid:] - WARN [/0.0.0.0:11226:QuorumCnxManager@274] > - Exception reading or writing challenge: java.net.SocketTimeoutException: > Read timed out > 2016-07-12 22:34:52,700 [myid:] - INFO > [main:JUnit4ZKTestRunner$LoggedInvokeMethod@74] - TEST METHOD FAILED > testCnxFromFutureVersion > java.io.IOException: Broken pipe > at sun.nio.ch.FileDispatcherImpl.write0(Native Method) > at sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:47) > at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93) > at sun.nio.ch.IOUtil.write(IOUtil.java:65) > at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:466) > at java.nio.channels.Channels.writeFullyImpl(Channels.java:78) > at java.nio.channels.Channels.writeFully(Channels.java:98) > at java.nio.channels.Channels.access$000(Channels.java:61)
[jira] [Updated] (ZOOKEEPER-2502) Flaky Test: org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han updated ZOOKEEPER-2502: --- Attachment: ZOOKEEPER-2502.patch Submit the patch for fix. > Flaky Test: > org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion > -- > > Key: ZOOKEEPER-2502 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2502 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.4.9 >Reporter: Michael Han >Assignee: Michael Han > Labels: flaky, flaky-test > Fix For: 3.4.10 > > Attachments: ZOOKEEPER-2502.patch > > > {noformat} > Error Message > Broken pipe > Stacktrace > java.io.IOException: Broken pipe > at sun.nio.ch.FileDispatcherImpl.write0(Native Method) > at sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:47) > at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93) > at sun.nio.ch.IOUtil.write(IOUtil.java:65) > at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:466) > at java.nio.channels.Channels.writeFullyImpl(Channels.java:78) > at java.nio.channels.Channels.writeFully(Channels.java:98) > at java.nio.channels.Channels.access$000(Channels.java:61) > at java.nio.channels.Channels$1.write(Channels.java:174) > at java.io.OutputStream.write(OutputStream.java:75) > at java.nio.channels.Channels$1.write(Channels.java:155) > at java.io.DataOutputStream.writeInt(DataOutputStream.java:198) > at > org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion(CnxManagerTest.java:318) > at > org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55) > Standard Output > 2016-07-12 22:34:46,623 [myid:] - INFO [main:ZKTestCase$1@50] - STARTING > testCnxFromFutureVersion > 2016-07-12 22:34:46,627 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11221 > 2016-07-12 22:34:46,630 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11222 > 2016-07-12 22:34:46,631 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11223 > 2016-07-12 22:34:46,643 [myid:] - INFO [main:QuorumPeer$QuorumServer@149] - > Resolved hostname: 0.0.0.0 to address: /0.0.0.0 > 2016-07-12 22:34:46,658 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11224 > 2016-07-12 22:34:46,658 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11225 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11226 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:QuorumPeer$QuorumServer@149] - > Resolved hostname: 0.0.0.0 to address: /0.0.0.0 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11227 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11228 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11229 > 2016-07-12 22:34:46,660 [myid:] - INFO [main:QuorumPeer$QuorumServer@149] - > Resolved hostname: 0.0.0.0 to address: /0.0.0.0 > 2016-07-12 22:34:46,660 [myid:] - INFO > [main:JUnit4ZKTestRunner$LoggedInvokeMethod@53] - RUNNING TEST METHOD > testCnxFromFutureVersion > 2016-07-12 22:34:46,672 [myid:] - INFO [main:NIOServerCnxnFactory@89] - > binding to port 0.0.0.0/0.0.0.0:11225 > 2016-07-12 22:34:46,692 [myid:] - INFO [main:CnxManagerTest@301] - Election > port: 11226 > 2016-07-12 22:34:46,692 [myid:] - INFO > [ListenerThread:QuorumCnxManager$Listener@534] - My election bind port: > /0.0.0.0:11226 > 2016-07-12 22:34:47,696 [myid:] - INFO > [/0.0.0.0:11226:QuorumCnxManager$Listener@541] - Received connection request > /140.211.11.27:48724 > 2016-07-12 22:34:49,700 [myid:] - WARN [/0.0.0.0:11226:QuorumCnxManager@274] > - Exception reading or writing challenge: java.net.SocketTimeoutException: > Read timed out > 2016-07-12 22:34:52,700 [myid:] - INFO > [main:JUnit4ZKTestRunner$LoggedInvokeMethod@74] - TEST METHOD FAILED > testCnxFromFutureVersion > java.io.IOException: Broken pipe > at sun.nio.ch.FileDispatcherImpl.write0(Native Method) > at sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:47) > at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93) > at sun.nio.ch.IOUtil.write(IOUtil.java:65) > at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:466) > at java.nio.channels.Channels.writeFullyImpl(Channels.java:78) > at java.nio.channels.Channels.writeFully(Channels.java:98) > at java.nio.channels.Channels.access$000(Channels.java:61) > at java.nio.channels.Channels$1.write(Channels.java:174) > at java.io.OutputStream.write(OutputStream.java:75) > at
[jira] [Commented] (ZOOKEEPER-2502) Flaky Test: org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429074#comment-15429074 ] Michael Han commented on ZOOKEEPER-2502: The root cause of this flaky test is insufficient timeout value of server socket. The socket timeout is set to 2 second in [setSockOpts | https://github.com/apache/zookeeper/blob/branch-3.4/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L474], and this value is too small to satisfy the build bot (the value sounds also small for a real deployment as well). As a result, in [receiveConnection | https://github.com/apache/zookeeper/blob/branch-3.4/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L249] the read will time out on build bot 90% of times. Increase time out fixed the issue. Note this test is quite hard to reproduced locally - however it can be deterministically reproduced on our internal (not Apache) build bot. Might related to the latency introduced in virtualized environment. > Flaky Test: > org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion > -- > > Key: ZOOKEEPER-2502 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2502 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.4.9 >Reporter: Michael Han >Assignee: Michael Han > Labels: flaky, flaky-test > Fix For: 3.4.10 > > Attachments: ZOOKEEPER-2502.patch > > > {noformat} > Error Message > Broken pipe > Stacktrace > java.io.IOException: Broken pipe > at sun.nio.ch.FileDispatcherImpl.write0(Native Method) > at sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:47) > at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93) > at sun.nio.ch.IOUtil.write(IOUtil.java:65) > at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:466) > at java.nio.channels.Channels.writeFullyImpl(Channels.java:78) > at java.nio.channels.Channels.writeFully(Channels.java:98) > at java.nio.channels.Channels.access$000(Channels.java:61) > at java.nio.channels.Channels$1.write(Channels.java:174) > at java.io.OutputStream.write(OutputStream.java:75) > at java.nio.channels.Channels$1.write(Channels.java:155) > at java.io.DataOutputStream.writeInt(DataOutputStream.java:198) > at > org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion(CnxManagerTest.java:318) > at > org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55) > Standard Output > 2016-07-12 22:34:46,623 [myid:] - INFO [main:ZKTestCase$1@50] - STARTING > testCnxFromFutureVersion > 2016-07-12 22:34:46,627 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11221 > 2016-07-12 22:34:46,630 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11222 > 2016-07-12 22:34:46,631 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11223 > 2016-07-12 22:34:46,643 [myid:] - INFO [main:QuorumPeer$QuorumServer@149] - > Resolved hostname: 0.0.0.0 to address: /0.0.0.0 > 2016-07-12 22:34:46,658 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11224 > 2016-07-12 22:34:46,658 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11225 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11226 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:QuorumPeer$QuorumServer@149] - > Resolved hostname: 0.0.0.0 to address: /0.0.0.0 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11227 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11228 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11229 > 2016-07-12 22:34:46,660 [myid:] - INFO [main:QuorumPeer$QuorumServer@149] - > Resolved hostname: 0.0.0.0 to address: /0.0.0.0 > 2016-07-12 22:34:46,660 [myid:] - INFO > [main:JUnit4ZKTestRunner$LoggedInvokeMethod@53] - RUNNING TEST METHOD > testCnxFromFutureVersion > 2016-07-12 22:34:46,672 [myid:] - INFO [main:NIOServerCnxnFactory@89] - > binding to port 0.0.0.0/0.0.0.0:11225 > 2016-07-12 22:34:46,692 [myid:] - INFO [main:CnxManagerTest@301] - Election > port: 11226 > 2016-07-12 22:34:46,692 [myid:] - INFO > [ListenerThread:QuorumCnxManager$Listener@534] - My election bind port: > /0.0.0.0:11226 > 2016-07-12 22:34:47,696 [myid:] - INFO > [/0.0.0.0:11226:QuorumCnxManager$Listener@541] - Received connection request > /140.211.11.27:48724 > 2016-07-12 22:34:49,700 [myid:] - WARN [/0.0.0.0:11226:QuorumCnxManager@274] > - Exception reading or writing challenge: java.net.SocketTimeoutException: > Read timed out > 2016-07-12 22:34:52,700
[jira] [Assigned] (ZOOKEEPER-2502) Flaky Test: org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han reassigned ZOOKEEPER-2502: -- Assignee: Michael Han > Flaky Test: > org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion > -- > > Key: ZOOKEEPER-2502 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2502 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.4.9 >Reporter: Michael Han >Assignee: Michael Han > Labels: flaky, flaky-test > Fix For: 3.4.10 > > > {noformat} > Error Message > Broken pipe > Stacktrace > java.io.IOException: Broken pipe > at sun.nio.ch.FileDispatcherImpl.write0(Native Method) > at sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:47) > at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93) > at sun.nio.ch.IOUtil.write(IOUtil.java:65) > at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:466) > at java.nio.channels.Channels.writeFullyImpl(Channels.java:78) > at java.nio.channels.Channels.writeFully(Channels.java:98) > at java.nio.channels.Channels.access$000(Channels.java:61) > at java.nio.channels.Channels$1.write(Channels.java:174) > at java.io.OutputStream.write(OutputStream.java:75) > at java.nio.channels.Channels$1.write(Channels.java:155) > at java.io.DataOutputStream.writeInt(DataOutputStream.java:198) > at > org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion(CnxManagerTest.java:318) > at > org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55) > Standard Output > 2016-07-12 22:34:46,623 [myid:] - INFO [main:ZKTestCase$1@50] - STARTING > testCnxFromFutureVersion > 2016-07-12 22:34:46,627 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11221 > 2016-07-12 22:34:46,630 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11222 > 2016-07-12 22:34:46,631 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11223 > 2016-07-12 22:34:46,643 [myid:] - INFO [main:QuorumPeer$QuorumServer@149] - > Resolved hostname: 0.0.0.0 to address: /0.0.0.0 > 2016-07-12 22:34:46,658 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11224 > 2016-07-12 22:34:46,658 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11225 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11226 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:QuorumPeer$QuorumServer@149] - > Resolved hostname: 0.0.0.0 to address: /0.0.0.0 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11227 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11228 > 2016-07-12 22:34:46,659 [myid:] - INFO [main:PortAssignment@32] - assigning > port 11229 > 2016-07-12 22:34:46,660 [myid:] - INFO [main:QuorumPeer$QuorumServer@149] - > Resolved hostname: 0.0.0.0 to address: /0.0.0.0 > 2016-07-12 22:34:46,660 [myid:] - INFO > [main:JUnit4ZKTestRunner$LoggedInvokeMethod@53] - RUNNING TEST METHOD > testCnxFromFutureVersion > 2016-07-12 22:34:46,672 [myid:] - INFO [main:NIOServerCnxnFactory@89] - > binding to port 0.0.0.0/0.0.0.0:11225 > 2016-07-12 22:34:46,692 [myid:] - INFO [main:CnxManagerTest@301] - Election > port: 11226 > 2016-07-12 22:34:46,692 [myid:] - INFO > [ListenerThread:QuorumCnxManager$Listener@534] - My election bind port: > /0.0.0.0:11226 > 2016-07-12 22:34:47,696 [myid:] - INFO > [/0.0.0.0:11226:QuorumCnxManager$Listener@541] - Received connection request > /140.211.11.27:48724 > 2016-07-12 22:34:49,700 [myid:] - WARN [/0.0.0.0:11226:QuorumCnxManager@274] > - Exception reading or writing challenge: java.net.SocketTimeoutException: > Read timed out > 2016-07-12 22:34:52,700 [myid:] - INFO > [main:JUnit4ZKTestRunner$LoggedInvokeMethod@74] - TEST METHOD FAILED > testCnxFromFutureVersion > java.io.IOException: Broken pipe > at sun.nio.ch.FileDispatcherImpl.write0(Native Method) > at sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:47) > at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93) > at sun.nio.ch.IOUtil.write(IOUtil.java:65) > at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:466) > at java.nio.channels.Channels.writeFullyImpl(Channels.java:78) > at java.nio.channels.Channels.writeFully(Channels.java:98) > at java.nio.channels.Channels.access$000(Channels.java:61) > at java.nio.channels.Channels$1.write(Channels.java:174) > at java.io.OutputStream.write(OutputStream.java:75) > at java.nio.channels.Channels$1.write(Channels.java:155) > at
ZooKeeper-trunk - Build # 3042 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk/3042/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 445050 lines...] [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2016-08-19 23:30:39,585 [myid:127.0.0.1:19425] - INFO [main-SendThread(127.0.0.1:19425):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:19425. Will not attempt to authenticate using SASL (unknown error) [junit] 2016-08-19 23:30:39,586 [myid:127.0.0.1:19425] - WARN [main-SendThread(127.0.0.1:19425):ClientCnxn$SendThread@1235] - Session 0x201fe0b9375 for server 127.0.0.1/127.0.0.1:19425, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2016-08-19 23:30:40,035 [myid:] - INFO [ProcessThread(sid:0 cport:19545)::PrepRequestProcessor@647] - Processed session termination for sessionid: 0x101fe0e82d2 [junit] 2016-08-19 23:30:40,055 [myid:] - INFO [SyncThread:0:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port19545,name1=Connections,name2=127.0.0.1,name3=0x101fe0e82d2] [junit] 2016-08-19 23:30:40,055 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x101fe0e82d2 [junit] 2016-08-19 23:30:40,055 [myid:] - INFO [main:ZooKeeper@1313] - Session: 0x101fe0e82d2 closed [junit] 2016-08-19 23:30:40,056 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 189890 [junit] 2016-08-19 23:30:40,056 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 1641 [junit] 2016-08-19 23:30:40,056 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testWatcherAutoResetWithLocal [junit] 2016-08-19 23:30:40,056 [myid:] - INFO [main:ClientBase@543] - tearDown starting [junit] 2016-08-19 23:30:40,056 [myid:] - INFO [main:ClientBase@513] - STOPPING server [junit] 2016-08-19 23:30:40,056 [myid:] - INFO [main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:19545 [junit] 2016-08-19 23:30:40,062 [myid:] - INFO [main:ZooKeeperServer@529] - shutting down [junit] 2016-08-19 23:30:40,062 [myid:] - ERROR [main:ZooKeeperServer@501] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2016-08-19 23:30:40,062 [myid:] - INFO [main:SessionTrackerImpl@232] - Shutting down [junit] 2016-08-19 23:30:40,062 [myid:] - INFO [main:PrepRequestProcessor@965] - Shutting down [junit] 2016-08-19 23:30:40,062 [myid:] - INFO [main:SyncRequestProcessor@191] - Shutting down [junit] 2016-08-19 23:30:40,062 [myid:] - INFO [ProcessThread(sid:0 cport:19545)::PrepRequestProcessor@154] - PrepRequestProcessor exited loop! [junit] 2016-08-19 23:30:40,062 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited! [junit] 2016-08-19 23:30:40,063 [myid:] - INFO [main:FinalRequestProcessor@479] - shutdown of request processor complete [junit] 2016-08-19 23:30:40,063 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port19545,name1=InMemoryDataTree] [junit] 2016-08-19 23:30:40,063 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port19545] [junit] 2016-08-19 23:30:40,063 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 19545 [junit] 2016-08-19 23:30:40,064 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2016-08-19 23:30:40,068 [myid:] - INFO [main:ClientBase@568] - fdcount after test is: 4828 at start it was 4828 [junit] 2016-08-19 23:30:40,068 [myid:] - INFO [main:ZKTestCase$1@65] - SUCCEEDED testWatcherAutoResetWithLocal [junit] 2016-08-19 23:30:40,069 [myid:] - INFO [main:ZKTestCase$1@60] - FINISHED testWatcherAutoResetWithLocal [junit] Tests run: 101, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 518.658 sec, Thread: 4, Class:
[jira] [Commented] (ZOOKEEPER-2505) Use shared library instead of static library in C client unit test
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428930#comment-15428930 ] Chris Nauroth commented on ZOOKEEPER-2505: -- [~hanm], thank you for sharing your notes. Maybe we'd benefit from a documentation JIRA that goes into more detail about build pre-requisites on Solaris (and other platforms too). > Use shared library instead of static library in C client unit test > -- > > Key: ZOOKEEPER-2505 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2505 > Project: ZooKeeper > Issue Type: Improvement > Components: c client >Affects Versions: 3.5.2 >Reporter: Michael Han >Assignee: Michael Han >Priority: Minor > Fix For: 3.5.3 > > Attachments: ZOOKEEPER-2505.patch > > > Currently we are statically linking c unit tests to ZK client library - we > should use shared library instead as there seems no particular reason to > stick to static library, plus one benefit of using shared library is that > would allow us to use overrides function calls from standard libraries at > link time so we can simulate the wrap option for ld linker on os x. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
ZooKeeper_branch35_solaris - Build # 215 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch35_solaris/215/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 427088 lines...] [junit] 2016-08-19 17:23:03,327 [myid:] - INFO [main:ClientBase@386] - CREATING server instance 127.0.0.1:11222 [junit] 2016-08-19 17:23:03,327 [myid:] - INFO [main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 kB direct buffers. [junit] 2016-08-19 17:23:03,328 [myid:] - INFO [main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222 [junit] 2016-08-19 17:23:03,328 [myid:] - INFO [main:ClientBase@361] - STARTING server instance 127.0.0.1:11222 [junit] 2016-08-19 17:23:03,329 [myid:] - INFO [main:ZooKeeperServer@889] - minSessionTimeout set to 6000 [junit] 2016-08-19 17:23:03,329 [myid:] - INFO [main:ZooKeeperServer@898] - maxSessionTimeout set to 6 [junit] 2016-08-19 17:23:03,329 [myid:] - INFO [main:ZooKeeperServer@159] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test5053141155780035619.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test5053141155780035619.junit.dir/version-2 [junit] 2016-08-19 17:23:03,329 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test5053141155780035619.junit.dir/version-2/snapshot.b [junit] 2016-08-19 17:23:03,331 [myid:] - INFO [main:FileTxnSnapLog@298] - Snapshotting: 0xb to /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test5053141155780035619.junit.dir/version-2/snapshot.b [junit] 2016-08-19 17:23:03,333 [myid:] - ERROR [main:ZooKeeperServer@501] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2016-08-19 17:23:03,333 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222 [junit] 2016-08-19 17:23:03,333 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:60489 [junit] 2016-08-19 17:23:03,334 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from /127.0.0.1:60489 [junit] 2016-08-19 17:23:03,334 [myid:] - INFO [NIOWorkerThread-1:StatCommand@49] - Stat command output [junit] 2016-08-19 17:23:03,335 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client /127.0.0.1:60489 (no session established for client) [junit] 2016-08-19 17:23:03,335 [myid:] - INFO [main:JMXEnv@228] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2016-08-19 17:23:03,336 [myid:] - INFO [main:JMXEnv@245] - expect:InMemoryDataTree [junit] 2016-08-19 17:23:03,336 [myid:] - INFO [main:JMXEnv@249] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree [junit] 2016-08-19 17:23:03,337 [myid:] - INFO [main:JMXEnv@245] - expect:StandaloneServer_port [junit] 2016-08-19 17:23:03,337 [myid:] - INFO [main:JMXEnv@249] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11222 [junit] 2016-08-19 17:23:03,337 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17913 [junit] 2016-08-19 17:23:03,337 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24 [junit] 2016-08-19 17:23:03,337 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testQuota [junit] 2016-08-19 17:23:03,337 [myid:] - INFO [main:ClientBase@543] - tearDown starting [junit] 2016-08-19 17:23:03,402 [myid:] - INFO [main:ZooKeeper@1313] - Session: 0x12320cf8ce2 closed [junit] 2016-08-19 17:23:03,402 [myid:] - INFO [main:ClientBase@513] - STOPPING server [junit] 2016-08-19 17:23:03,402 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x12320cf8ce2 [junit] 2016-08-19 17:23:03,402 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219] - accept thread exitted run method [junit] 2016-08-19 17:23:03,402 [myid:] - INFO [ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - ConnnectionExpirerThread interrupted [junit] 2016-08-19 17:23:03,402 [myid:] - INFO
[jira] [Commented] (ZOOKEEPER-2169) Enable creation of nodes with TTLs
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428477#comment-15428477 ] Benjamin Reed commented on ZOOKEEPER-2169: -- this looks pretty cool. it doesn't look like you have test coverage for expiring nodes whose ttls are passed when you are bringing up the server. right? > Enable creation of nodes with TTLs > -- > > Key: ZOOKEEPER-2169 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2169 > Project: ZooKeeper > Issue Type: New Feature > Components: c client, java client, jute, server >Affects Versions: 3.6.0 >Reporter: Camille Fournier >Assignee: Jordan Zimmerman > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-2169-2.patch, ZOOKEEPER-2169-3.patch, > ZOOKEEPER-2169-4.patch, ZOOKEEPER-2169-5.patch, ZOOKEEPER-2169.patch > > > As a user, I would like to be able to create a node that is NOT tied to a > session but that WILL expire automatically if action is not taken by some > client within a time window. > I propose this to enable clients interacting with ZK via http or other "thin > clients" to create ephemeral-like nodes. > Some ideas for the design, up for discussion: > The node should support all normal ZK node operations including ACLs, > sequential key generation, etc, however, it should not support the ephemeral > flag. The node will be created with a TTL that is updated via a refresh > operation. > The ZK quorum will watch this node similarly to the way that it watches for > session liveness; if the node is not refreshed within the TTL, it will expire. > QUESTIONS: > 1) Should we let the refresh operation set the TTL to a different base value? > 2) If so, should the setting of the TTL to a new base value cause a watch to > fire? > 3) Do we want to allow these nodes to have children or prevent this similar > to ephemeral nodes? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2517) jute.maxbuffer is ignored
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428420#comment-15428420 ] Michael Han commented on ZOOKEEPER-2517: The issue is introduced in ZOOKEEPER-2139. Should we make packetLen testable and write a test case for this? > jute.maxbuffer is ignored > - > > Key: ZOOKEEPER-2517 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2517 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.5.2 >Reporter: Benjamin Jaton >Assignee: Benjamin Jaton >Priority: Critical > Attachments: ZOOKEEPER-2517.patch > > > In ClientCnxnSocket.java the parsing of the system property is erroneous: > {code}packetLen = Integer.getInteger( > clientConfig.getProperty(ZKConfig.JUTE_MAXBUFFER), > ZKClientConfig.CLIENT_MAX_PACKET_LENGTH_DEFAULT > );{code} > Javadoc of Integer.getInteger states "The first argument is treated as the > name of a system property", whereas here the value of the property is passed. > Instead I believe the author meant to write something like: > {code}packetLen = Integer.parseInt( > clientConfig.getProperty( > ZKConfig.JUTE_MAXBUFFER, > String.valueOf(ZKClientConfig.CLIENT_MAX_PACKET_LENGTH_DEFAULT) > ) > );{code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
ZooKeeper_branch34_openjdk7 - Build # 1179 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1179/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 224845 lines...] [junit] 2016-08-19 15:20:30,103 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@219] - NIOServerCnxn factory exited run method [junit] 2016-08-19 15:20:30,103 [myid:] - INFO [main:ZooKeeperServer@497] - shutting down [junit] 2016-08-19 15:20:30,103 [myid:] - ERROR [main:ZooKeeperServer@472] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2016-08-19 15:20:30,104 [myid:] - INFO [main:SessionTrackerImpl@225] - Shutting down [junit] 2016-08-19 15:20:30,104 [myid:] - INFO [main:PrepRequestProcessor@765] - Shutting down [junit] 2016-08-19 15:20:30,104 [myid:] - INFO [main:SyncRequestProcessor@208] - Shutting down [junit] 2016-08-19 15:20:30,104 [myid:] - INFO [ProcessThread(sid:0 cport:11221)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop! [junit] 2016-08-19 15:20:30,105 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@186] - SyncRequestProcessor exited! [junit] 2016-08-19 15:20:30,105 [myid:] - INFO [main:FinalRequestProcessor@402] - shutdown of request processor complete [junit] 2016-08-19 15:20:30,105 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221 [junit] 2016-08-19 15:20:30,106 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2016-08-19 15:20:30,108 [myid:] - INFO [main:ClientBase@445] - STARTING server [junit] 2016-08-19 15:20:30,108 [myid:] - INFO [main:ClientBase@366] - CREATING server instance 127.0.0.1:11221 [junit] 2016-08-19 15:20:30,108 [myid:] - INFO [main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2016-08-19 15:20:30,109 [myid:] - INFO [main:ClientBase@341] - STARTING server instance 127.0.0.1:11221 [junit] 2016-08-19 15:20:30,109 [myid:] - INFO [main:ZooKeeperServer@173] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/branch-3.4/build/test/tmp/test8385607397232802365.junit.dir/version-2 snapdir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/branch-3.4/build/test/tmp/test8385607397232802365.junit.dir/version-2 [junit] 2016-08-19 15:20:30,114 [myid:] - ERROR [main:ZooKeeperServer@472] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2016-08-19 15:20:30,114 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221 [junit] 2016-08-19 15:20:30,115 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - Accepted socket connection from /127.0.0.1:44356 [junit] 2016-08-19 15:20:30,115 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing stat command from /127.0.0.1:44356 [junit] 2016-08-19 15:20:30,116 [myid:] - INFO [Thread-4:NIOServerCnxn$StatCommand@663] - Stat command output [junit] 2016-08-19 15:20:30,116 [myid:] - INFO [Thread-4:NIOServerCnxn@1008] - Closed socket connection for client /127.0.0.1:44356 (no session established for client) [junit] 2016-08-19 15:20:30,116 [myid:] - INFO [main:JMXEnv@229] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2016-08-19 15:20:30,119 [myid:] - INFO [main:JMXEnv@246] - expect:InMemoryDataTree [junit] 2016-08-19 15:20:30,119 [myid:] - INFO [main:JMXEnv@250] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree [junit] 2016-08-19 15:20:30,119 [myid:] - INFO [main:JMXEnv@246] - expect:StandaloneServer_port [junit] 2016-08-19 15:20:30,119 [myid:] - INFO [main:JMXEnv@250] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11221 [junit] 2016-08-19 15:20:30,120 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 32638 [junit] 2016-08-19 15:20:30,120 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20 [junit] 2016-08-19 15:20:30,120 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota [junit] 2016-08-19 15:20:30,120 [myid:] - INFO [main:ClientBase@522] - tearDown starting [junit] 2016-08-19 15:20:30,186 [myid:] - INFO [main:ZooKeeper@684] - Session: 0x156a3639d26 closed [junit] 2016-08-19 15:20:30,186 [myid:] - INFO [main:ClientBase@492] - STOPPING server [junit] 2016-08-19 15:20:30,186 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@519] - EventThread shut down for session: 0x156a3639d26
ZooKeeper_branch34_solaris - Build # 1260 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch34_solaris/1260/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 11233 lines...] [junit] at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.init(FileTxnLog.java:552) [junit] at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.(FileTxnLog.java:531) [junit] at org.apache.zookeeper.server.persistence.FileTxnLog.read(FileTxnLog.java:358) [junit] at org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:132) [junit] at org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:223) [junit] at org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:510) [junit] at org.apache.zookeeper.server.quorum.QuorumPeer.getLastLoggedZxid(QuorumPeer.java:650) [junit] at org.apache.zookeeper.server.quorum.FastLeaderElection.getInitLastLoggedZxid(FastLeaderElection.java:768) [junit] at org.apache.zookeeper.server.quorum.FastLeaderElection.lookForLeader(FastLeaderElection.java:815) [junit] at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:822) [junit] 2016-08-19 13:30:55,605 [myid:] - WARN [QuorumPeer[myid=3]/0.0.0.0:11249:QuorumPeer@824] - Unexpected exception [junit] java.lang.RuntimeException: Unable to run quorum server [junit] at org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:558) [junit] at org.apache.zookeeper.server.quorum.QuorumPeer.getLastLoggedZxid(QuorumPeer.java:650) [junit] at org.apache.zookeeper.server.quorum.FastLeaderElection.getInitLastLoggedZxid(FastLeaderElection.java:768) [junit] at org.apache.zookeeper.server.quorum.FastLeaderElection.lookForLeader(FastLeaderElection.java:815) [junit] at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:822) [junit] Caused by: java.io.InterruptedIOException [junit] at java.io.FileInputStream.readBytes(Native Method) [junit] at java.io.FileInputStream.read(FileInputStream.java:220) [junit] at java.io.BufferedInputStream.fill(BufferedInputStream.java:218) [junit] at java.io.BufferedInputStream.read(BufferedInputStream.java:237) [junit] at java.io.FilterInputStream.read(FilterInputStream.java:66) [junit] at org.apache.zookeeper.server.persistence.FileTxnLog$PositionInputStream.read(FileTxnLog.java:452) [junit] at java.io.DataInputStream.readInt(DataInputStream.java:370) [junit] at org.apache.jute.BinaryInputArchive.readInt(BinaryInputArchive.java:63) [junit] at org.apache.zookeeper.server.persistence.FileHeader.deserialize(FileHeader.java:64) [junit] at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.inStreamCreated(FileTxnLog.java:585) [junit] at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.createInputArchive(FileTxnLog.java:604) [junit] at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.goToNextLog(FileTxnLog.java:570) [junit] at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.init(FileTxnLog.java:552) [junit] at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.(FileTxnLog.java:531) [junit] at org.apache.zookeeper.server.persistence.FileTxnLog.read(FileTxnLog.java:358) [junit] at org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:132) [junit] at org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:223) [junit] at org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:510) [junit] ... 4 more [junit] 2016-08-19 13:30:55,606 [myid:] - WARN [QuorumPeer[myid=3]/0.0.0.0:11249:QuorumPeer@874] - QuorumPeer main thread exited [junit] 2016-08-19 13:30:55,606 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11245 [junit] 2016-08-19 13:30:55,606 [myid:] - INFO [main:QuorumUtil@220] - 127.0.0.1:11245 is no longer accepting client connections [junit] 2016-08-19 13:30:55,606 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11247 [junit] 2016-08-19 13:30:55,607 [myid:] - INFO [main:QuorumUtil@220] - 127.0.0.1:11247 is no longer accepting client connections [junit] 2016-08-19 13:30:55,607 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11249 [junit] 2016-08-19 13:30:55,607 [myid:] - INFO [main:QuorumUtil@220] - 127.0.0.1:11249 is no longer accepting client connections [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 73.867 sec [junit] 2016-08-19 13:30:56,001 [myid:] - INFO [SessionTracker:SessionTrackerImpl@162] - SessionTrackerImpl exited loop!
ZooKeeper-trunk-jdk8 - Build # 713 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/713/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 454383 lines...] [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) [junit] at org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152) [junit] at org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105) [junit] at org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79) [junit] at org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337) [junit] at org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42) [junit] at org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108) [junit] at org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42) [junit] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [junit] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [junit] at java.lang.Thread.run(Thread.java:745) [junit] 2016-08-19 11:57:57,313 [myid:] - INFO [New I/O boss #9438:ClientCnxnSocketNetty@208] - channel is told closing [junit] 2016-08-19 11:57:57,313 [myid:127.0.0.1:24811] - INFO [main-SendThread(127.0.0.1:24811):ClientCnxn$SendThread@1231] - channel for sessionid 0x201a7f3649b is lost, closing socket connection and attempting reconnect [junit] 2016-08-19 11:57:57,640 [myid:] - INFO [ProcessThread(sid:0 cport:24931)::PrepRequestProcessor@647] - Processed session termination for sessionid: 0x101a7f6c3b9 [junit] 2016-08-19 11:57:57,652 [myid:] - INFO [main:ClientCnxnSocketNetty@208] - channel is told closing [junit] 2016-08-19 11:57:57,652 [myid:] - INFO [SyncThread:0:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port24931,name1=Connections,name2=127.0.0.1,name3=0x101a7f6c3b9] [junit] 2016-08-19 11:57:57,652 [myid:] - INFO [New I/O worker #14359:ClientCnxnSocketNetty$ZKClientHandler@384] - channel is disconnected: [id: 0x44cc7320, /127.0.0.1:53614 :> 127.0.0.1/127.0.0.1:24931] [junit] 2016-08-19 11:57:57,652 [myid:] - INFO [New I/O worker #14359:ClientCnxnSocketNetty@208] - channel is told closing [junit] 2016-08-19 11:57:57,652 [myid:] - INFO [main:ZooKeeper@1313] - Session: 0x101a7f6c3b9 closed [junit] 2016-08-19 11:57:57,652 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x101a7f6c3b9 [junit] 2016-08-19 11:57:57,652 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 156715 [junit] 2016-08-19 11:57:57,653 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 1778 [junit] 2016-08-19 11:57:57,653 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testWatcherAutoResetWithLocal [junit] 2016-08-19 11:57:57,653 [myid:] - INFO [main:ClientBase@543] - tearDown starting [junit] 2016-08-19 11:57:57,653 [myid:] - INFO [main:ClientBase@513] - STOPPING server [junit] 2016-08-19 11:57:57,653 [myid:] - INFO [main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:24931 [junit] 2016-08-19 11:57:57,658 [myid:] - INFO [main:ZooKeeperServer@529] - shutting down [junit] 2016-08-19 11:57:57,658 [myid:] - ERROR [main:ZooKeeperServer@501] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2016-08-19 11:57:57,659 [myid:] - INFO [main:SessionTrackerImpl@232] - Shutting down [junit] 2016-08-19 11:57:57,659 [myid:] - INFO [main:PrepRequestProcessor@965] - Shutting down [junit] 2016-08-19 11:57:57,659 [myid:] - INFO [main:SyncRequestProcessor@191] - Shutting down [junit] 2016-08-19 11:57:57,659 [myid:] - INFO [ProcessThread(sid:0 cport:24931)::PrepRequestProcessor@154] - PrepRequestProcessor exited loop! [junit] 2016-08-19 11:57:57,659 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited! [junit] 2016-08-19 11:57:57,659 [myid:] - INFO [main:FinalRequestProcessor@479] - shutdown of request processor complete [junit] 2016-08-19 11:57:57,659 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port24931,name1=InMemoryDataTree] [junit] 2016-08-19 11:57:57,660 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port24931] [junit] 2016-08-19 11:57:57,660 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 24931
ZooKeeper-trunk-solaris - Build # 1275 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1275/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 108927 lines...] [junit] at org.apache.zookeeper.server.quorum.LearnerHandler.run(LearnerHandler.java:622) [junit] 2016-08-19 07:51:44,037 [myid:] - INFO [Thread-18:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=Leader] [junit] 2016-08-19 07:51:44,037 [myid:] - INFO [Thread-18:Zab1_0Test$LeadThread@97] - Leader thread interrupted [junit] java.lang.InterruptedException [junit] at java.lang.Object.wait(Native Method) [junit] at org.apache.zookeeper.server.quorum.Leader.lead(Leader.java:561) [junit] at org.apache.zookeeper.server.quorum.Zab1_0Test$LeadThread.run(Zab1_0Test.java:95) [junit] 2016-08-19 07:51:44,037 [myid:] - INFO [Thread-18:Leader@623] - Shutting down [junit] 2016-08-19 07:51:44,059 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 16084 [junit] 2016-08-19 07:51:44,059 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 5 [junit] 2016-08-19 07:51:44,060 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testNormalRun [junit] 2016-08-19 07:51:44,060 [myid:] - INFO [main:ZKTestCase$1@65] - SUCCEEDED testNormalRun [junit] 2016-08-19 07:51:44,060 [myid:] - INFO [main:ZKTestCase$1@60] - FINISHED testNormalRun [junit] Tests run: 12, Failures: 0, Errors: 0, Time elapsed: 48.613 sec [junit] 2016-08-19 07:51:44,261 [myid:] - INFO [SessionTracker:SessionTrackerImpl@158] - SessionTrackerImpl exited loop! [junit] 2016-08-19 07:51:54,680 [myid:] - INFO [main:JUnit4ZKTestRunner@47] - No test.method specified. using default methods. [junit] Running org.apache.zookeeper.server.util.VerifyingFileFactoryTest [junit] 2016-08-19 07:51:56,047 [myid:] - INFO [main:JUnit4ZKTestRunner@47] - No test.method specified. using default methods. [junit] 2016-08-19 07:51:56,200 [myid:] - INFO [main:ZKTestCase$1@55] - STARTING testFileHasCorrectPath [junit] 2016-08-19 07:51:56,217 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@77] - RUNNING TEST METHOD testFileHasCorrectPath [junit] 2016-08-19 07:51:56,352 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 9514 [junit] 2016-08-19 07:51:56,355 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 4 [junit] 2016-08-19 07:51:56,355 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testFileHasCorrectPath [junit] 2016-08-19 07:51:56,355 [myid:] - INFO [main:ZKTestCase$1@65] - SUCCEEDED testFileHasCorrectPath [junit] 2016-08-19 07:51:56,355 [myid:] - INFO [main:ZKTestCase$1@60] - FINISHED testFileHasCorrectPath [junit] 2016-08-19 07:51:56,384 [myid:] - INFO [main:ZKTestCase$1@55] - STARTING testForNoWarningOnIntendedRelativePath [junit] 2016-08-19 07:51:56,384 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@77] - RUNNING TEST METHOD testForNoWarningOnIntendedRelativePath [junit] 2016-08-19 07:51:56,385 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 9853 [junit] 2016-08-19 07:51:56,385 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 4 [junit] 2016-08-19 07:51:56,385 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testForNoWarningOnIntendedRelativePath [junit] 2016-08-19 07:51:56,385 [myid:] - INFO [main:ZKTestCase$1@65] - SUCCEEDED testForNoWarningOnIntendedRelativePath [junit] 2016-08-19 07:51:56,385 [myid:] - INFO [main:ZKTestCase$1@60] - FINISHED testForNoWarningOnIntendedRelativePath [junit] 2016-08-19 07:51:56,387 [myid:] - INFO [main:ZKTestCase$1@55] - STARTING testForWarningOnRelativePath [junit] 2016-08-19 07:51:56,388 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@77] - RUNNING TEST METHOD testForWarningOnRelativePath [junit] 2016-08-19 07:51:56,388 [myid:] - WARN [main:VerifyingFileFactory@59] - a/relative/path is relative. Prepend ./ to indicate that you're sure! [junit] 2016-08-19 07:51:56,388 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 9853 [junit] 2016-08-19 07:51:56,388 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 4 [junit] 2016-08-19 07:51:56,388 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testForWarningOnRelativePath [junit] 2016-08-19 07:51:56,388 [myid:] - INFO [main:ZKTestCase$1@65] - SUCCEEDED testForWarningOnRelativePath [junit] 2016-08-19 07:51:56,388 [myid:] - INFO [main:ZKTestCase$1@60] - FINISHED
[jira] [Updated] (ZOOKEEPER-2517) jute.maxbuffer is ignored
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arshad Mohammad updated ZOOKEEPER-2517: --- Assignee: Benjamin Jaton > jute.maxbuffer is ignored > - > > Key: ZOOKEEPER-2517 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2517 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.5.2 >Reporter: Benjamin Jaton >Assignee: Benjamin Jaton >Priority: Critical > Attachments: ZOOKEEPER-2517.patch > > > In ClientCnxnSocket.java the parsing of the system property is erroneous: > {code}packetLen = Integer.getInteger( > clientConfig.getProperty(ZKConfig.JUTE_MAXBUFFER), > ZKClientConfig.CLIENT_MAX_PACKET_LENGTH_DEFAULT > );{code} > Javadoc of Integer.getInteger states "The first argument is treated as the > name of a system property", whereas here the value of the property is passed. > Instead I believe the author meant to write something like: > {code}packetLen = Integer.parseInt( > clientConfig.getProperty( > ZKConfig.JUTE_MAXBUFFER, > String.valueOf(ZKClientConfig.CLIENT_MAX_PACKET_LENGTH_DEFAULT) > ) > );{code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2517) jute.maxbuffer is ignored
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427669#comment-15427669 ] Arshad Mohammad commented on ZOOKEEPER-2517: Thanks [~benjamin.jaton] for reporting and submitting a patch. One review comment on the patch. Can we handled NumberFormatException and use default in case of NumberFormatException. > jute.maxbuffer is ignored > - > > Key: ZOOKEEPER-2517 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2517 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.5.2 >Reporter: Benjamin Jaton >Priority: Critical > Attachments: ZOOKEEPER-2517.patch > > > In ClientCnxnSocket.java the parsing of the system property is erroneous: > {code}packetLen = Integer.getInteger( > clientConfig.getProperty(ZKConfig.JUTE_MAXBUFFER), > ZKClientConfig.CLIENT_MAX_PACKET_LENGTH_DEFAULT > );{code} > Javadoc of Integer.getInteger states "The first argument is treated as the > name of a system property", whereas here the value of the property is passed. > Instead I believe the author meant to write something like: > {code}packetLen = Integer.parseInt( > clientConfig.getProperty( > ZKConfig.JUTE_MAXBUFFER, > String.valueOf(ZKClientConfig.CLIENT_MAX_PACKET_LENGTH_DEFAULT) > ) > );{code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)