[jira] [Commented] (ZOOKEEPER-1962) Add a CLI command to recursively list a znode and children

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15440398#comment-15440398
 ] 

Patrick Hunt commented on ZOOKEEPER-1962:
-

bq. fail intelligently

+1 on that

bq. add a comment to the code/command output 

sounds sensible, but pretty unusual for command output. Perhaps we can put it 
into the code comment and the cli help text instead? (and while we are at it 
add it ensure the deleteall command highlights this as well)

> Add a CLI command to recursively list a znode and children
> --
>
> Key: ZOOKEEPER-1962
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1962
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: java client
>Affects Versions: 3.4.6
>Reporter: Gautam Gopalakrishnan
>Assignee: Gautam Gopalakrishnan
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-1962.diff, ZOOKEEPER-1962_v2.patch, 
> ZOOKEEPER-1962_v3.patch, ZOOKEEPER-1962_v4.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When troubleshooting applications where znodes can be multiple levels deep  
> (eg. HBase replication), it is handy to see all child znodes recursively 
> rather than run an ls for each node manually.
> So I propose adding an option to the "ls" command (-r) which will list all 
> child nodes under a given znode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: switching to git?

[Patrick Hunt]

I really love it when the new guy shows up and immediately requests tool
changes. ;-)

afaik given we have a git mirror already, moving to git from an infra
perspective is pretty straightforward. Definitely some impact in some other
areas (like cutting a release) but we should be able to chase those down.

+1 from me.

Patrick

On Fri, Aug 26, 2016 at 11:36 AM, Michael Han  wrote:

> +1!
>
> On Fri, Aug 26, 2016 at 11:34 AM, Edward Ribeiro  >
> wrote:
>
> > +1 :+D
> >
> > Em 26 de ago de 2016 2:37 PM, "Raúl Gutiérrez Segalés" <
> > r...@itevenworks.net>
> > escreveu:
> >
> > > On 26 August 2016 at 10:35, Benjamin Reed  wrote:
> > >
> > > > i'm starting to get back into zk development :) i'm a bit distressed
> > that
> > > > we are still using svn and patches managed by jiras. i've gotten
> > > extremely
> > > > spoiled by gerritt and phabricator over the years!
> > > >
> > > > as a first step to more efficient workflows for contributors and
> > > committers
> > > > can we move to git? i had an offline conversation with pat and he
> knows
> > > how
> > > > to flip the switch.
> > > >
> > >
> > > big +1
> > >
> > >
> > > -rgs
> > >
> >
>
>
>
> --
> Cheers
> Michael.
>

Re: [VOTE] Apache ZooKeeper release 3.4.9 candidate 2

[Michael Han]

Looking at release notes:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12334700


   - [ZOOKEEPER-2396 ]
   - Login object in ZooKeeperSaslClient is static

  There is no bits related to this JIRA went to 3.4.9. Maybe there
was a mistake on marking the target version as 3.4.9? Should we keep this
in relesae note or remove it?

   - [ZOOKEEPER-1676 ]
   - C client zookeeper_interest returning ZOK on Connection Loss

  There is no bits related to this JIRA went to 3.4.9 either, as
this is closed as 'not a bug'. I'd expect such not a bug issue be excluded
in release notes, as it does not provide any useful information, though I
am not sure what's the standard practice in previous releases.

On Wed, Aug 24, 2016 at 8:06 PM, Abraham Fine  wrote:

> +1 (non-binding)
>
> shasum and md5sum are valid. PGP signature is valid.
>
> Java unit tests pass and was able to successfully test against a 3 server
> ensemble.
>
> Abe
>
> > On Aug 23, 2016, at 4:20 PM, Patrick Hunt  wrote:
> >
> > +1 xsum/sig are valid. RAT ran clean. I was able to compile the code and
> > successfully put a few ensemble sizes through their paces.
> >
> > fwiw I also did a "diff" btw 3.4.8 release artifact and this rc. There
> were
> > a number of changed files, obviously. However I did not notice any
> missing
> > files, as we've seen with the previous rcs in this release candidate
> line.
> > afaict this artifact has all the right contents - i.e. similar to
> previous
> > releases.
> >
> > Patrick
> >
> > On Tue, Aug 23, 2016 at 2:24 AM, Rakesh Radhakrishnan <
> rake...@apache.org>
> > wrote:
> >
> >> This is the third release candidate for 3.4.9. This candidate removes
> the
> >> extra *.asc files found in the
> >> second candidate.
> >>
> >> This is a bugfix release candidate for 3.4.9. It fixes 21 issues,
> including
> >> issues that affect ACL cache
> >> in DataTree never removes entries, prevent multiple init of login
> object in
> >> each ZKSaslClient instance,
> >> ZK service becomes unavailable when leader fails to write transaction
> log,
> >> upgrade netty version due
> >> to security vulnerability (CVE-2014-3488) and others.
> >>
> >> The full release notes are available at:
> >>
> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> >> projectId=12310801=12334700
> >>
> >> *** Please download, test and vote by August 30th 2016, 23:59 UTC+0. ***
> >>
> >> Source files:
> >> http://people.apache.org/~rakeshr/zookeeper-3.4.9-candidate-2
> >>
> >> Maven staging repo:
> >> https://repository.apache.org/content/groups/staging/org/
> >> apache/zookeeper/zookeeper/3.4.9
> >>
> >> The tag to be voted upon:
> >> https://svn.apache.org/repos/asf/zookeeper/tags/release-3.4.9-rc2
> >>
> >> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> >> http://www.apache.org/dist/zookeeper/KEYS
> >>
> >> Should we release this candidate?
> >>
> >> Thanks,
> >> Rakesh
> >>
>
>


-- 
Cheers
Michael.

[jira] [Commented] (ZOOKEEPER-2519) zh->state should not be 0 while handle is active

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15440114#comment-15440114
 ] 

Michael Han commented on ZOOKEEPER-2519:


The patch looks like malformatted, can't be applied to branch-3.4. [Reference 
on generating 
patch|https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute]

{code}
  zh->fd = -1;
  zh->connect_index++;
  if (!is_unrecoverable(zh)) {
 -|zh->state = 0;
+|zh->state = ZOO_CONNECTING_STATE;
  }
  if (process_async(zh->outstanding_sync)) {
  process_completions(zh);
  }
{code}

Instead of using {{ZOO_CONNECTING_STATE}}, why not using 
{{ZOO_NOTCONNECTED_STATE}}, given the reconnect attempt hasn't been made at 
this point yet? Later, in zookeeper_interest when reconnecting attempt being 
made the state will be set to {{ZOO_CONNECTING_STATE}}.


> zh->state should not be 0 while handle is active
> 
>
> Key: ZOOKEEPER-2519
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2519
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.4.6
>Reporter: Andrew Grasso
> Attachments: ZOOKEEPER-2519.patch
>
>
> 0 does not correspond to any of the defined states for the zookeeper handle, 
> so a client should not expect to see this value. But in the function 
> {{handle_error}}, we set {{zh->state = 0}}, which a client may then see. 
> Instead, we should set our state to be {{ZOO_CONNECTING_STATE}}. 
> At some point the code moved away from 0 as a valid state and introduced the 
> defined states. This broke the fix to ZOOKEEPER-800, which checks if state is 
> 0 to know if the handle has been created but has not yet connected. We now 
> use {{ZOO_NOTCONNECTED_STATE}} to mean this, so the check for this in 
> {{zoo_add_auth}} must be changed.
> We saw this error in 3.4.6, but I believe it remains present in trunk.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (ZOOKEEPER-1962) Add a CLI command to recursively list a znode and children

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15440041#comment-15440041
 ] 

Michael Han edited comment on ZOOKEEPER-1962 at 8/26/16 10:33 PM:
--

+1 on the idea of reusing existing code.

However, {{listSubTreeBFS}} would buffer entire tree starting from the pathRoot 
passed in, so it's likely running into memory issues for large snapshot. I 
think what's mentioned earlier by Enis would work, and it preserves both the 
order properties (we buffer children of each node while doing dfs), and the 
memory constraint (we don't buffer all nodes, and we increase depth iteratively 
after each layer is printed.). This technique is formally known as [Iterative 
deepening depth-first 
search|https://en.wikipedia.org/wiki/Iterative_deepening_depth-first_search]. 
We could either update {{listSubTreeBFS}} or add a ID dfs version of same 
function in ZKUtil and use that instead.


was (Author: hanm):
+1 on the idea of reusing existing code.

However, {{listSubTreeBFS}} would buffer full tree, so it's likely running into 
memory issues for large snapshot. I think what's mentioned earlier by Enis 
would work, and it preserves both the order properties (we buffer children of 
each node while doing dfs), and the memory constraint (we don't buffer all 
nodes, and we increase depth iteratively after each layer is printed.). This 
technique is formally known as [Iterative deepening depth-first 
search|https://en.wikipedia.org/wiki/Iterative_deepening_depth-first_search]. 
We could either update {{listSubTreeBFS}} or add a ID dfs version of same 
function in ZKUtil and use that instead.

> Add a CLI command to recursively list a znode and children
> --
>
> Key: ZOOKEEPER-1962
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1962
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: java client
>Affects Versions: 3.4.6
>Reporter: Gautam Gopalakrishnan
>Assignee: Gautam Gopalakrishnan
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-1962.diff, ZOOKEEPER-1962_v2.patch, 
> ZOOKEEPER-1962_v3.patch, ZOOKEEPER-1962_v4.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When troubleshooting applications where znodes can be multiple levels deep  
> (eg. HBase replication), it is handy to see all child znodes recursively 
> rather than run an ls for each node manually.
> So I propose adding an option to the "ls" command (-r) which will list all 
> child nodes under a given znode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1962) Add a CLI command to recursively list a znode and children

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15440041#comment-15440041
 ] 

Michael Han commented on ZOOKEEPER-1962:


+1 on the idea of reusing existing code.

However, {{listSubTreeBFS}} would buffer full tree, so it's likely running into 
memory issues for large snapshot. I think what's mentioned earlier by Enis 
would work, and it preserves both the order properties (we buffer children of 
each node while doing dfs), and the memory constraint (we don't buffer all 
nodes, and we increase depth iteratively after each layer is printed.). This 
technique is formally known as [Iterative deepening depth-first 
search|https://en.wikipedia.org/wiki/Iterative_deepening_depth-first_search]. 
We could either update {{listSubTreeBFS}} or add a ID dfs version of same 
function in ZKUtil and use that instead.

> Add a CLI command to recursively list a znode and children
> --
>
> Key: ZOOKEEPER-1962
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1962
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: java client
>Affects Versions: 3.4.6
>Reporter: Gautam Gopalakrishnan
>Assignee: Gautam Gopalakrishnan
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-1962.diff, ZOOKEEPER-1962_v2.patch, 
> ZOOKEEPER-1962_v3.patch, ZOOKEEPER-1962_v4.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When troubleshooting applications where znodes can be multiple levels deep  
> (eg. HBase replication), it is handy to see all child znodes recursively 
> rather than run an ls for each node manually.
> So I propose adding an option to the "ls" command (-r) which will list all 
> child nodes under a given znode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZOOKEEPER-2538) Flaky Test: org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalObserverRun

[Michael Han (JIRA)]

Michael Han created ZOOKEEPER-2538:
--

 Summary: Flaky Test: 
org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalObserverRun
 Key: ZOOKEEPER-2538
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2538
 Project: ZooKeeper
  Issue Type: Bug
  Components: quorum, server, tests
Affects Versions: 3.5.2
Reporter: Michael Han
 Fix For: 3.5.3


The failure of this test is fairly often. Might relate to ZOOKEEPER-1798.

{noformat}
org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalObserverRun

Failing for the past 1 build (Since Failed#1143 )
Took 0 ms.
Error Message

Timeout occurred. Please note the time in the report does not reflect the time 
until the timeout.
Stacktrace

junit.framework.AssertionFailedError: Timeout occurred. Please note the time in 
the report does not reflect the time until the timeout.
at java.lang.Thread.run(Thread.java:745)
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: ZOOKEEPER-2169

[Jordan Zimmerman]

---\▔\
))
---//▂▂▂
▂▂╱┈ ▕▂▂▂▏
▉┈-┈┈ ▕▂▂▂▏
▉┈-┈┈▕▂▂▂▏
▔▔╲▂▕▂▂▏

> On Aug 26, 2016, at 3:49 PM, Camille Fournier  wrote:
> 
> OK I'm the slacker that proposed us doing this in the first place and I'm
> THRILLED that you have done it Jordan, thank you so much.
> Pat, I can review and merge, unless you are concerned with interference on
> other issues. LMK.
> 
> C
> 
> On Fri, Aug 26, 2016 at 10:42 AM, Patrick Hunt  wrote:
> 
>> Hi Jordan. This looks like a great new feature, but I'm afraid I'm focused
>> on other things atm. I don't have much time after work/home currently, as
>> such I've been focused on other priorities; 1) supporting existing
>> users/issues in 3.4, and 2) trying to get 3.5 branch to production ready.
>> There are already a number of features queued up in that branch (3.5) which
>> we need to get out to folks. Thanks for your patience.
>> 
>> Regards,
>> 
>> Patrick
>> 
>> On Thu, Aug 25, 2016 at 9:00 PM, Jordan Zimmerman <
>> jor...@jordanzimmerman.com> wrote:
>> 
>>> So - what’s a guy got to do to get this merged?
>>> 
>>> -Jordan
>>> 
 On Aug 18, 2016, at 11:27 AM, Andrew Purtell 
>>> wrote:
 
 Please
 This looks really handy for implementing transient data structures.
 
 On Thu, Aug 18, 2016 at 5:53 AM, Jordan Zimmerman <
 jor...@jordanzimmerman.com> wrote:
 
> Any chance of getting https://issues.apache.org/
>>> jira/browse/ZOOKEEPER-2169
> merged? It has:
> 
> * A patch that’s been reviewed
> * 7 Votes
> * 15 Watchers
> * Will help ZooKeeper compete against etcd/consul
> 
> -Jordan
 
 
 
 
 --
 Best regards,
 
  - Andy
 
 Problems worthy of attack prove their worth by hitting back. - Piet
>> Hein
 (via Tom White)
>>> 
>>> 
>> 

[jira] [Comment Edited] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384994#comment-15384994
 ] 

Michael Han edited comment on ZOOKEEPER-2014 at 8/26/16 8:52 PM:
-

Had an offline discussion with [~phunt], [~fpj] yesterday regarding this issue, 
the conversation is captured as following points (with some of my thoughts as 
well):

* We can't fix security issue unless we enforce authentication and 
authorization. Just by moving client APIs around is not enough because at 
protocol level the server still open to reconfiguration and someone can exploit 
this easily (by writing their own ZK client instead of using ZooKeeper client 
for example.). 

* That said though, the ZooKeeper::reconfig API should be moved out of 
ZooKeeper class (for Java client) anyway, because it's more about an admin 
feature rather than a client API. Moving reconfig out of ZooKeeper will also 
remove constraints we possibly put on normal ZooKeeper clients (such as having 
to use zookeeper.DigestAuthenticationProvider.superDigest), which is a bonus. 
Due to API backward compatibility concerns, this refactoring should happen 
before we move to beta.

* We'd like to introduce a new configuration option in zoo.cfg to turn off 
reconfig feature by default. ZK users who needs use this feature need turn it 
on explicitly. Because dynamic reconfig feature brings something new (e.g. 
cfg.dynamic file), have this feature off is good for 'the principal of least 
surprise'. Having the feature off by default will also buy us sometime to 
fortify and stabilize the feature without having it being a blocker issue.

The action items / plans I am thinking in the time frame of 3.5.3:
* Fix Security:
#* Enforce an ACL on /zookeeper/config, such that only users that have write 
permission to it can reconfig the cluster. /zookeeper/config is by default 
readable to anyone so zookeeper (none-admin) clients can load balancing on 
client side either manually (current behavior) or automatically 
(ZOOKEEPER-2016). 
#* ZooKeeper users are responsible for properly configure the ACL such that 
only a limited set of admin users are part of the ACL with write access. The 
authentication of these users will be delegated to existing mechanisms 
ZooKeeper already supports, such as SASL client login, so not much work here 
except documentation on such a requirement to use reconfig feature.
#* The default behavior is such that if /zookeeper/config node has no 
associated ACLs, then no one is allowed write access except super user. 
* Fix API:
#* For Java client, create a new class ZooKeeperAdmin that inherits ZooKeeper 
class and move reconfig API into ZooKeeperAdmin class.
#* For C client, there is no namespace and the existing zhandle is coupled with 
reconfig state so it is not as simple as Java client to isolate admin part of 
the API from rest of APIs. Working on a proposal.

* Introduce a new zoo.cfg option to switch reconfiguration feature on or off. 
The new configuration option will be set as 'disable reconfig' by default when 
3.5.3 shipped, and user who wants reconfig has to enable reconfig option 
explicitly.

Are these good enough for now to address all security concerns or we still miss 
something?
Comments?

CC [~shralex], [~rgs]


was (Author: hanm):
Had an offline discussion with [~phunt], [~fpj] yesterday regarding this issue, 
the conversation is captured as following points (with some of my thoughts as 
well):

* We can't fix security issue unless we enforce authentication and 
authorization. Just by moving client APIs around is not enough because at 
protocol level the server still open to reconfiguration and someone can exploit 
this easily (by writing their own ZK client instead of using ZooKeeper client 
for example.). 

* That said though, the ZooKeeper::reconfig API should be moved out of 
ZooKeeper class (for Java client) anyway, because it's more about an admin 
feature rather than a client API. Moving reconfig out of ZooKeeper will also 
remove constraints we possibly put on normal ZooKeeper clients (such as having 
to use zookeeper.DigestAuthenticationProvider.superDigest), which is a bonus. 
Due to API backward compatibility concerns, this refactoring should happen 
before we move to beta.

* We'd like to introduce a new configuration option in zoo.cfg to turn off 
reconfig feature by default. ZK users who needs use this feature need turn it 
on explicitly. Because dynamic reconfig feature brings something new (e.g. 
cfg.dynamic file), have this feature off is good for 'the principal of least 
surprise'. Having the feature off by default will also buy us sometime to 
fortify and stabilize the feature without having it being a blocker issue.

The action items / plans I am thinking in the time frame of 3.5.3:
* Fix Security:
#* Enforce an ACL on /zookeeper/config, such that only users that have write 
permission 

Re: ZOOKEEPER-2169

[Camille Fournier]

OK I'm the slacker that proposed us doing this in the first place and I'm
THRILLED that you have done it Jordan, thank you so much.
Pat, I can review and merge, unless you are concerned with interference on
other issues. LMK.

C

On Fri, Aug 26, 2016 at 10:42 AM, Patrick Hunt  wrote:

> Hi Jordan. This looks like a great new feature, but I'm afraid I'm focused
> on other things atm. I don't have much time after work/home currently, as
> such I've been focused on other priorities; 1) supporting existing
> users/issues in 3.4, and 2) trying to get 3.5 branch to production ready.
> There are already a number of features queued up in that branch (3.5) which
> we need to get out to folks. Thanks for your patience.
>
> Regards,
>
> Patrick
>
> On Thu, Aug 25, 2016 at 9:00 PM, Jordan Zimmerman <
> jor...@jordanzimmerman.com> wrote:
>
> > So - what’s a guy got to do to get this merged?
> >
> > -Jordan
> >
> > > On Aug 18, 2016, at 11:27 AM, Andrew Purtell 
> > wrote:
> > >
> > > Please
> > > This looks really handy for implementing transient data structures.
> > >
> > > On Thu, Aug 18, 2016 at 5:53 AM, Jordan Zimmerman <
> > > jor...@jordanzimmerman.com> wrote:
> > >
> > >> Any chance of getting https://issues.apache.org/
> > jira/browse/ZOOKEEPER-2169
> > >> merged? It has:
> > >>
> > >> * A patch that’s been reviewed
> > >> * 7 Votes
> > >> * 15 Watchers
> > >> * Will help ZooKeeper compete against etcd/consul
> > >>
> > >> -Jordan
> > >
> > >
> > >
> > >
> > > --
> > > Best regards,
> > >
> > >   - Andy
> > >
> > > Problems worthy of attack prove their worth by hitting back. - Piet
> Hein
> > > (via Tom White)
> >
> >
>

ZooKeeper-trunk-openjdk7 - Build # 1143 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1143/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 453973 lines...]
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioWorker.run(AbstractNioWorker.java:89)
[junit] at 
org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:178)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2016-08-26 20:02:39,679 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port11466,name1=Connections,name2=127.0.0.1,name3=0x1a557ce]
[junit] 2016-08-26 20:02:39,696 [myid:] - INFO  
[SessionTracker:SessionTrackerImpl@158] - SessionTrackerImpl exited loop!
[junit] 2016-08-26 20:02:39,779 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x1a557ce closed
[junit] 2016-08-26 20:02:39,779 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1a557ce
[junit] 2016-08-26 20:02:39,779 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 60638
[junit] 2016-08-26 20:02:39,780 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 467
[junit] 2016-08-26 20:02:39,780 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2016-08-26 20:02:39,780 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-08-26 20:02:39,780 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-08-26 20:02:39,780 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:11466
[junit] 2016-08-26 20:02:39,782 [myid:] - INFO  [main:ZooKeeperServer@529] 
- shutting down
[junit] 2016-08-26 20:02:39,782 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-08-26 20:02:39,782 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2016-08-26 20:02:39,782 [myid:] - INFO  
[main:PrepRequestProcessor@965] - Shutting down
[junit] 2016-08-26 20:02:39,782 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2016-08-26 20:02:39,783 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2016-08-26 20:02:39,782 [myid:] - INFO  [ProcessThread(sid:0 
cport:11466)::PrepRequestProcessor@154] - PrepRequestProcessor exited loop!
[junit] 2016-08-26 20:02:39,783 [myid:] - INFO  
[main:FinalRequestProcessor@479] - shutdown of request processor complete
[junit] 2016-08-26 20:02:39,783 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port11466,name1=InMemoryDataTree]
[junit] 2016-08-26 20:02:39,783 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port11466]
[junit] 2016-08-26 20:02:39,784 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11466
[junit] 2016-08-26 20:02:39,784 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-08-26 20:02:39,788 [myid:] - INFO  [main:ClientBase@568] - 
fdcount after test is: 1374 at start it was 1374
[junit] 2016-08-26 20:02:39,788 [myid:] - INFO  [main:ZKTestCase$1@65] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2016-08-26 20:02:39,788 [myid:] - INFO  [main:ZKTestCase$1@60] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 101, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
432.981 sec, Thread: 1, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2016-08-26 20:02:39,984 [myid:127.0.0.1:11222] - INFO  
[main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:11222. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-08-26 20:02:39,984 [myid:127.0.0.1:11222] - WARN  
[main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@1235] - Session 
0x19ed64d for server 127.0.0.1/127.0.0.1:11222, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 

[jira] [Updated] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han updated ZOOKEEPER-2014:
---
Attachment: ZOOKEEPER-2014.patch

First stab on implementing basics outlined in the design. Patch is not ready 
(pending docs update, more tests, and C client work), upload here for preview 
and feedback only. 

> Only admin should be allowed to reconfig a cluster
> --
>
> Key: ZOOKEEPER-2014
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2014
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.0
>Reporter: Raul Gutierrez Segales
>Assignee: Michael Han
>Priority: Blocker
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch
>
>
> ZOOKEEPER-107 introduces reconfiguration support via the reconfig() call. We 
> should, at the very least, ensure that only the Admin can reconfigure a 
> cluster. Perhaps restricting access to /zookeeper/config as well, though this 
> is debatable. Surely one could ensure Admin only access via an ACL, but that 
> would leave everyone who doesn't use ACLs unprotected. We could also force a 
> default ACL to make it a bit more consistent (maybe).
> Finally, making reconfig() only available to Admins means they have to run 
> with zookeeper.DigestAuthenticationProvider.superDigest (which I am not sure 
> if everyone does, or how would it work with other authentication providers). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (ZOOKEEPER-1962) Add a CLI command to recursively list a znode and children

[Abraham Fine (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439531#comment-15439531
 ] 

Abraham Fine edited comment on ZOOKEEPER-1962 at 8/26/16 6:41 PM:
--

I agree with [~phunt] that reusing the logic from deleteall (listSubTreeBFS) is 
likely a good idea

It also may be valuable to add a comment to the code/command output that 
explains that modifications can occur to the tree while the ls -R command is 
running and it may be the case that the output does not necessarily represent 
the actual state of zookeeper at any given point in time.

In other words, the race condition noted above can occur with the creation of 
nodes, which will not cause any of the listing operations to fail so we would 
have no way to fail intelligently.


was (Author: abrahamfine):
I agree with [~phunt] that reusing the logic from deleteall (listSubTreeBFS) is 
likely a good idea

It also may be valuable to add a comment to the code/command output that 
explains that modifications can occur to the tree while the ls -R command is 
running and it may be the case that the output does not necessarily represent 
the actual state of zookeeper at any given point in time.

> Add a CLI command to recursively list a znode and children
> --
>
> Key: ZOOKEEPER-1962
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1962
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: java client
>Affects Versions: 3.4.6
>Reporter: Gautam Gopalakrishnan
>Assignee: Gautam Gopalakrishnan
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-1962.diff, ZOOKEEPER-1962_v2.patch, 
> ZOOKEEPER-1962_v3.patch, ZOOKEEPER-1962_v4.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When troubleshooting applications where znodes can be multiple levels deep  
> (eg. HBase replication), it is handy to see all child znodes recursively 
> rather than run an ls for each node manually.
> So I propose adding an option to the "ls" command (-r) which will list all 
> child nodes under a given znode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: switching to git?

[Michael Han]

+1!

On Fri, Aug 26, 2016 at 11:34 AM, Edward Ribeiro 
wrote:

> +1 :+D
>
> Em 26 de ago de 2016 2:37 PM, "Raúl Gutiérrez Segalés" <
> r...@itevenworks.net>
> escreveu:
>
> > On 26 August 2016 at 10:35, Benjamin Reed  wrote:
> >
> > > i'm starting to get back into zk development :) i'm a bit distressed
> that
> > > we are still using svn and patches managed by jiras. i've gotten
> > extremely
> > > spoiled by gerritt and phabricator over the years!
> > >
> > > as a first step to more efficient workflows for contributors and
> > committers
> > > can we move to git? i had an offline conversation with pat and he knows
> > how
> > > to flip the switch.
> > >
> >
> > big +1
> >
> >
> > -rgs
> >
>



-- 
Cheers
Michael.

Re: switching to git?

[Edward Ribeiro]

+1 :+D

Em 26 de ago de 2016 2:37 PM, "Raúl Gutiérrez Segalés" 
escreveu:

> On 26 August 2016 at 10:35, Benjamin Reed  wrote:
>
> > i'm starting to get back into zk development :) i'm a bit distressed that
> > we are still using svn and patches managed by jiras. i've gotten
> extremely
> > spoiled by gerritt and phabricator over the years!
> >
> > as a first step to more efficient workflows for contributors and
> committers
> > can we move to git? i had an offline conversation with pat and he knows
> how
> > to flip the switch.
> >
>
> big +1
>
>
> -rgs
>

[jira] [Commented] (ZOOKEEPER-1962) Add a CLI command to recursively list a znode and children

[Abraham Fine (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439531#comment-15439531
 ] 

Abraham Fine commented on ZOOKEEPER-1962:
-

I agree with [~phunt] that reusing the logic from deleteall (listSubTreeBFS) is 
likely a good idea

It also may be valuable to add a comment to the code/command output that 
explains that modifications can occur to the tree while the ls -R command is 
running and it may be the case that the output does not necessarily represent 
the actual state of zookeeper at any given point in time.

> Add a CLI command to recursively list a znode and children
> --
>
> Key: ZOOKEEPER-1962
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1962
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: java client
>Affects Versions: 3.4.6
>Reporter: Gautam Gopalakrishnan
>Assignee: Gautam Gopalakrishnan
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-1962.diff, ZOOKEEPER-1962_v2.patch, 
> ZOOKEEPER-1962_v3.patch, ZOOKEEPER-1962_v4.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When troubleshooting applications where znodes can be multiple levels deep  
> (eg. HBase replication), it is handy to see all child znodes recursively 
> rather than run an ls for each node manually.
> So I propose adding an option to the "ls" command (-r) which will list all 
> child nodes under a given znode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: switching to git?

[Raúl Gutiérrez Segalés]

On 26 August 2016 at 10:35, Benjamin Reed  wrote:

> i'm starting to get back into zk development :) i'm a bit distressed that
> we are still using svn and patches managed by jiras. i've gotten extremely
> spoiled by gerritt and phabricator over the years!
>
> as a first step to more efficient workflows for contributors and committers
> can we move to git? i had an offline conversation with pat and he knows how
> to flip the switch.
>

big +1


-rgs

switching to git?

[Benjamin Reed]

i'm starting to get back into zk development :) i'm a bit distressed that
we are still using svn and patches managed by jiras. i've gotten extremely
spoiled by gerritt and phabricator over the years!

as a first step to more efficient workflows for contributors and committers
can we move to git? i had an offline conversation with pat and he knows how
to flip the switch.

thanx
ben

ZooKeeper_branch35_solaris - Build # 225 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_solaris/225/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 435384 lines...]
[junit] 2016-08-26 17:15:12,524 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-08-26 17:15:12,525 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-08-26 17:15:12,525 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-08-26 17:15:12,526 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-08-26 17:15:12,526 [myid:] - INFO  [main:ZooKeeperServer@889] 
- minSessionTimeout set to 6000
[junit] 2016-08-26 17:15:12,526 [myid:] - INFO  [main:ZooKeeperServer@898] 
- maxSessionTimeout set to 6
[junit] 2016-08-26 17:15:12,527 [myid:] - INFO  [main:ZooKeeperServer@159] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test5755437813889532060.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test5755437813889532060.junit.dir/version-2
[junit] 2016-08-26 17:15:12,527 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test5755437813889532060.junit.dir/version-2/snapshot.b
[junit] 2016-08-26 17:15:12,529 [myid:] - INFO  [main:FileTxnSnapLog@298] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test5755437813889532060.junit.dir/version-2/snapshot.b
[junit] 2016-08-26 17:15:12,531 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-08-26 17:15:12,531 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-08-26 17:15:12,531 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:58202
[junit] 2016-08-26 17:15:12,532 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:58202
[junit] 2016-08-26 17:15:12,532 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-08-26 17:15:12,532 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:58202 (no session established for client)
[junit] 2016-08-26 17:15:12,533 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-08-26 17:15:12,534 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-08-26 17:15:12,534 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-08-26 17:15:12,534 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-08-26 17:15:12,534 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-08-26 17:15:12,535 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17938
[junit] 2016-08-26 17:15:12,535 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-08-26 17:15:12,535 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-08-26 17:15:12,535 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-08-26 17:15:12,592 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x12344d4c86a closed
[junit] 2016-08-26 17:15:12,592 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x12344d4c86a
[junit] 2016-08-26 17:15:12,592 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-08-26 17:15:12,593 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-08-26 17:15:12,593 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-08-26 17:15:12,593 [myid:] - INFO  

[jira] [Commented] (ZOOKEEPER-2511) Implement AutoCloseable in ZooKeeper.java

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439195#comment-15439195
 ] 

Patrick Hunt commented on ZOOKEEPER-2511:
-

Third solution makes the most sense to me as well. I like that we are taking 
advantage of the new language features to make user's lives easier!

> Implement AutoCloseable in ZooKeeper.java
> -
>
> Key: ZOOKEEPER-2511
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2511
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Abraham Fine
>Assignee: Abraham Fine
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2511.patch
>
>
> As a java developer I would like to be able to use try-with-resource blocks 
> with ZooKeeper objects in order to make closing sessions easier.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: ZOOKEEPER-2169

[Patrick Hunt]

Hi Jordan. This looks like a great new feature, but I'm afraid I'm focused
on other things atm. I don't have much time after work/home currently, as
such I've been focused on other priorities; 1) supporting existing
users/issues in 3.4, and 2) trying to get 3.5 branch to production ready.
There are already a number of features queued up in that branch (3.5) which
we need to get out to folks. Thanks for your patience.

Regards,

Patrick

On Thu, Aug 25, 2016 at 9:00 PM, Jordan Zimmerman <
jor...@jordanzimmerman.com> wrote:

> So - what’s a guy got to do to get this merged?
>
> -Jordan
>
> > On Aug 18, 2016, at 11:27 AM, Andrew Purtell 
> wrote:
> >
> > Please
> > This looks really handy for implementing transient data structures.
> >
> > On Thu, Aug 18, 2016 at 5:53 AM, Jordan Zimmerman <
> > jor...@jordanzimmerman.com> wrote:
> >
> >> Any chance of getting https://issues.apache.org/
> jira/browse/ZOOKEEPER-2169
> >> merged? It has:
> >>
> >> * A patch that’s been reviewed
> >> * 7 Votes
> >> * 15 Watchers
> >> * Will help ZooKeeper compete against etcd/consul
> >>
> >> -Jordan
> >
> >
> >
> >
> > --
> > Best regards,
> >
> >   - Andy
> >
> > Problems worthy of attack prove their worth by hitting back. - Piet Hein
> > (via Tom White)
>
>

ZooKeeper_branch35_jdk8 - Build # 207 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/207/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 456609 lines...]
[junit] 2016-08-26 13:07:38,155 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:24931
[junit] 2016-08-26 13:07:38,156 [myid:] - INFO  [main:ZooKeeperServer@529] 
- shutting down
[junit] 2016-08-26 13:07:38,156 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-08-26 13:07:38,156 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2016-08-26 13:07:38,156 [myid:] - INFO  
[main:PrepRequestProcessor@965] - Shutting down
[junit] 2016-08-26 13:07:38,157 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2016-08-26 13:07:38,157 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2016-08-26 13:07:38,157 [myid:] - INFO  
[main:FinalRequestProcessor@479] - shutdown of request processor complete
[junit] 2016-08-26 13:07:38,157 [myid:] - INFO  [ProcessThread(sid:0 
cport:24931)::PrepRequestProcessor@154] - PrepRequestProcessor exited loop!
[junit] 2016-08-26 13:07:38,157 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port24931,name1=InMemoryDataTree]
[junit] 2016-08-26 13:07:38,159 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port24931]
[junit] 2016-08-26 13:07:38,166 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 24931
[junit] 2016-08-26 13:07:38,167 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-08-26 13:07:38,171 [myid:] - INFO  [main:ClientBase@568] - 
fdcount after test is: 1459 at start it was 1459
[junit] 2016-08-26 13:07:38,171 [myid:] - INFO  [main:ZKTestCase$1@65] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2016-08-26 13:07:38,171 [myid:] - INFO  [main:ZKTestCase$1@60] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 101, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
444.661 sec, Thread: 6, Class: org.apache.zookeeper.test.NettyNettySuiteTest
[junit] 2016-08-26 13:07:38,502 [myid:127.0.0.1:24687] - INFO  
[main-SendThread(127.0.0.1:24687):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:24687. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-08-26 13:07:38,503 [myid:] - INFO  [New I/O boss 
#18:ClientCnxnSocketNetty$1@127] - future isn't success, cause: {}
[junit] java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:24687
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2016-08-26 13:07:38,503 [myid:] - WARN  [New I/O boss 
#18:ClientCnxnSocketNetty$ZKClientHandler@439] - Exception caught: [id: 
0x264f0c89] EXCEPTION: java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:24687
[junit] java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:24687
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)

ZooKeeper-trunk-jdk8 - Build # 723 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/723/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 454882 lines...]
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.processTaskQueue(AbstractNioSelector.java:391)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:315)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioWorker.run(AbstractNioWorker.java:89)
[junit] at 
org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:178)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2016-08-26 12:50:49,244 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16852,name1=Connections,name2=127.0.0.1,name3=0x10001fb9b73]
[junit] 2016-08-26 12:50:49,344 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x10001fb9b73 closed
[junit] 2016-08-26 12:50:49,344 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x10001fb9b73
[junit] 2016-08-26 12:50:49,344 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 48536
[junit] 2016-08-26 12:50:49,344 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 466
[junit] 2016-08-26 12:50:49,344 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2016-08-26 12:50:49,345 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-08-26 12:50:49,345 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-08-26 12:50:49,345 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:16852
[junit] 2016-08-26 12:50:49,346 [myid:] - INFO  [main:ZooKeeperServer@529] 
- shutting down
[junit] 2016-08-26 12:50:49,346 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-08-26 12:50:49,346 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2016-08-26 12:50:49,346 [myid:] - INFO  
[main:PrepRequestProcessor@965] - Shutting down
[junit] 2016-08-26 12:50:49,346 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2016-08-26 12:50:49,346 [myid:] - INFO  [ProcessThread(sid:0 
cport:16852)::PrepRequestProcessor@154] - PrepRequestProcessor exited loop!
[junit] 2016-08-26 12:50:49,346 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2016-08-26 12:50:49,347 [myid:] - INFO  
[main:FinalRequestProcessor@479] - shutdown of request processor complete
[junit] 2016-08-26 12:50:49,347 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16852,name1=InMemoryDataTree]
[junit] 2016-08-26 12:50:49,347 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16852]
[junit] 2016-08-26 12:50:49,347 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 16852
[junit] 2016-08-26 12:50:49,348 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-08-26 12:50:49,352 [myid:] - INFO  [main:ClientBase@568] - 
fdcount after test is: 1365 at start it was 1365
[junit] 2016-08-26 12:50:49,353 [myid:] - INFO  [main:ZKTestCase$1@65] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2016-08-26 12:50:49,353 [myid:] - INFO  [main:ZKTestCase$1@60] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 101, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
429.521 sec, Thread: 3, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2016-08-26 12:50:49,403 [myid:127.0.0.1:16735] - INFO  
[main-SendThread(127.0.0.1:16735):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:16735. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-08-26 12:50:49,403 [myid:127.0.0.1:16735] - WARN  
[main-SendThread(127.0.0.1:16735):ClientCnxn$SendThread@1235] - Session 
0x30001f8bc12 for server 127.0.0.1/127.0.0.1:16735, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection 

ZooKeeper_branch35_openjdk7 - Build # 205 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/205/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 437838 lines...]
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-08-26 11:43:13,421 [myid:127.0.0.1:16735] - INFO  
[main-SendThread(127.0.0.1:16735):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:16735. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-08-26 11:43:13,422 [myid:127.0.0.1:16735] - WARN  
[main-SendThread(127.0.0.1:16735):ClientCnxn$SendThread@1235] - Session 
0x30059210e30 for server 127.0.0.1/127.0.0.1:16735, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-08-26 11:43:13,429 [myid:] - INFO  [ProcessThread(sid:0 
cport:16852)::PrepRequestProcessor@647] - Processed session termination for 
sessionid: 0x1005924a0ed
[junit] 2016-08-26 11:43:13,447 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16852,name1=Connections,name2=127.0.0.1,name3=0x1005924a0ed]
[junit] 2016-08-26 11:43:13,447 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1005924a0ed
[junit] 2016-08-26 11:43:13,447 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x1005924a0ed closed
[junit] 2016-08-26 11:43:13,448 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 177600
[junit] 2016-08-26 11:43:13,448 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 1643
[junit] 2016-08-26 11:43:13,448 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2016-08-26 11:43:13,448 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-08-26 11:43:13,448 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-08-26 11:43:13,449 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:16852
[junit] 2016-08-26 11:43:13,452 [myid:] - INFO  [main:ZooKeeperServer@529] 
- shutting down
[junit] 2016-08-26 11:43:13,452 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-08-26 11:43:13,452 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2016-08-26 11:43:13,452 [myid:] - INFO  
[main:PrepRequestProcessor@965] - Shutting down
[junit] 2016-08-26 11:43:13,452 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2016-08-26 11:43:13,452 [myid:] - INFO  [ProcessThread(sid:0 
cport:16852)::PrepRequestProcessor@154] - PrepRequestProcessor exited loop!
[junit] 2016-08-26 11:43:13,453 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2016-08-26 11:43:13,453 [myid:] - INFO  
[main:FinalRequestProcessor@479] - shutdown of request processor complete
[junit] 2016-08-26 11:43:13,453 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16852,name1=InMemoryDataTree]
[junit] 2016-08-26 11:43:13,453 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16852]
[junit] 2016-08-26 11:43:13,463 [myid:127.0.0.1:16608] - INFO  
[main-SendThread(127.0.0.1:16608):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:16608. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-08-26 11:43:13,483 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 16852
[junit] 2016-08-26 11:43:13,483 [myid:127.0.0.1:16608] - WARN  
[main-SendThread(127.0.0.1:16608):ClientCnxn$SendThread@1235] - Session 
0x100591ab262 for server 127.0.0.1/127.0.0.1:16608, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection 

ZooKeeper_branch35_jdk7 - Build # 639 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/639/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 434963 lines...]
[junit] 2016-08-26 10:35:39,555 [myid:127.0.0.1:30127] - INFO  
[main-SendThread(127.0.0.1:30127):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:30127. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-08-26 10:35:39,556 [myid:127.0.0.1:30127] - WARN  
[main-SendThread(127.0.0.1:30127):ClientCnxn$SendThread@1235] - Session 
0x30058db6986 for server 127.0.0.1/127.0.0.1:30127, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-08-26 10:35:39,874 [myid:127.0.0.1:30145] - INFO  
[main-SendThread(127.0.0.1:30145):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:30145. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-08-26 10:35:39,874 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:/127.0.0.1:30145:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:58459
[junit] 2016-08-26 10:35:39,874 [myid:127.0.0.1:30145] - INFO  
[main-SendThread(127.0.0.1:30145):ClientCnxn$SendThread@948] - Socket 
connection established, initiating session, client: /127.0.0.1:58459, server: 
127.0.0.1/127.0.0.1:30145
[junit] 2016-08-26 10:35:39,875 [myid:] - WARN  
[NIOWorkerThread-6:NIOServerCnxn@369] - Exception causing close of session 0x0: 
ZooKeeperServer not running
[junit] 2016-08-26 10:35:39,875 [myid:] - INFO  
[NIOWorkerThread-6:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:58459 (no session established for client)
[junit] 2016-08-26 10:35:39,875 [myid:127.0.0.1:30145] - INFO  
[main-SendThread(127.0.0.1:30145):ClientCnxn$SendThread@1231] - Unable to read 
additional data from server sessionid 0x0, likely server has closed socket, 
closing socket connection and attempting reconnect
[junit] 2016-08-26 10:35:40,578 [myid:127.0.0.1:30121] - INFO  
[main-SendThread(127.0.0.1:30121):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:30121. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-08-26 10:35:40,579 [myid:127.0.0.1:30121] - WARN  
[main-SendThread(127.0.0.1:30121):ClientCnxn$SendThread@1235] - Session 
0x10058db6848 for server 127.0.0.1/127.0.0.1:30121, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-08-26 10:35:40,945 [myid:127.0.0.1:30127] - INFO  
[main-SendThread(127.0.0.1:30127):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:30127. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-08-26 10:35:40,946 [myid:127.0.0.1:30127] - WARN  
[main-SendThread(127.0.0.1:30127):ClientCnxn$SendThread@1235] - Session 
0x30058db6986 for server 127.0.0.1/127.0.0.1:30127, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-08-26 10:35:41,378 [myid:127.0.0.1:30124] - INFO  
[main-SendThread(127.0.0.1:30124):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:30124. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-08-26 10:35:41,379 [myid:127.0.0.1:30124] - WARN  
[main-SendThread(127.0.0.1:30124):ClientCnxn$SendThread@1235] - Session 
0x20058db6ace for server 127.0.0.1/127.0.0.1:30124, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit]  

[GitHub] zookeeper pull request #79: do negative check on tickTime

[qingmo]

GitHub user qingmo opened a pull request:

https://github.com/apache/zookeeper/pull/79

do negative check on tickTime

add negative check on tickTime parser. and throw a clear Exception output

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/qingmo/zookeeper trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #79


commit 428a1fdb3561cb5bc48f16a076081ff0cf8cf7c8
Author: chaos 
Date:   2016-08-26T09:32:38Z

do negative check on tickTime




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (ZOOKEEPER-2536) When provide path for "dataDir" with trailing space, it is taking correct path (by trucating space) for snapshot but creating temporary file with some junk folder nam

[Rakesh Kumar Singh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh Kumar Singh updated ZOOKEEPER-2536:
--
Description: 
Scenario 1:-
When provide path for "dataDir" with trailing space, it is taking correct path 
(by trucating space) for snapshot but creating temporary file with some junk 
folder name for zookeeper_server.pid

Steps to reproduce:-
1. Configure the dataDir
dataDir=/home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data 
Here there is a space after /data 
2. Start Zookeeper Server
3. The snapshot is getting created at location mentioned above by truncating 
the trailing space but
one temp folder with junk name (like -> D29D4X~J) is getting created for 
zookeeper_server.pid

Scenario 2:-
When configure the heading and trailing space in above mentioned scenario. the 
temp folder is getting created in zookeeper/bin folder

  was:
When provide path for "dataDir" with trailing space, it is taking correct path 
(by trucating space) for snapshot but creating temporary file with some junk 
folder name for zookeeper_server.pid

Steps to reproduce:-
1. Configure the dataDir
dataDir=/home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data 
Here there is a space after /data 
2. Start Zookeeper Server
3. The snapshot is getting created at location mentioned above by truncating 
the trailing space but
one temp folder with junk name (like -> D29D4X~J) is getting created for 
zookeeper_server.pid




> When provide path for "dataDir" with trailing space, it is taking correct 
> path (by trucating space) for snapshot but creating temporary file with some 
> junk folder name for zookeeper_server.pid
> 
>
> Key: ZOOKEEPER-2536
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2536
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Rakesh Kumar Singh
>
> Scenario 1:-
> When provide path for "dataDir" with trailing space, it is taking correct 
> path (by trucating space) for snapshot but creating temporary file with some 
> junk folder name for zookeeper_server.pid
> Steps to reproduce:-
> 1. Configure the dataDir
> dataDir=/home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data 
> Here there is a space after /data 
> 2. Start Zookeeper Server
> 3. The snapshot is getting created at location mentioned above by truncating 
> the trailing space but
> one temp folder with junk name (like -> D29D4X~J) is getting created for 
> zookeeper_server.pid
> Scenario 2:-
> When configure the heading and trailing space in above mentioned scenario. 
> the temp folder is getting created in zookeeper/bin folder



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2537) When provide path for "dataDir" with heading space, it is taking correct path (by trucating space) for snapshot but zookeeper_server.pid is getting created in root (/

[Rakesh Kumar Singh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh Kumar Singh updated ZOOKEEPER-2537:
--
Description: 
Scenario 1 :-
When provide path for "dataDir" with heading space, it is taking correct path 
(by trucating space) for snapshot but zookeeper_server.pid is getting created 
in root (/) folder
Steps to reproduce:-
1. Configure the dataDir
dataDir= /home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data
Here there is a space after dataDir=
2. Start Zookeeper Server
3. The snapshot is getting created at location mentioned above by truncating 
the heading space but
zookeeper_server.pid is getting created at root (/) folder


  was:
When provide path for "dataDir" with heading space, it is taking correct path 
(by trucating space) for snapshot but zookeeper_server.pid is getting created 
in root (/) folder
Steps to reproduce:-
1. Configure the dataDir
dataDir= /home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data
Here there is a space after dataDir=
2. Start Zookeeper Server
3. The snapshot is getting created at location mentioned above by truncating 
the heading space but
zookeeper_server.pid is getting created at root (/) folder


> When provide path for "dataDir" with heading space, it is taking correct path 
> (by trucating space) for snapshot but zookeeper_server.pid is getting created 
> in root (/) folder
> --
>
> Key: ZOOKEEPER-2537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2537
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Rakesh Kumar Singh
>
> Scenario 1 :-
> When provide path for "dataDir" with heading space, it is taking correct path 
> (by trucating space) for snapshot but zookeeper_server.pid is getting created 
> in root (/) folder
> Steps to reproduce:-
> 1. Configure the dataDir
> dataDir= /home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data
> Here there is a space after dataDir=
> 2. Start Zookeeper Server
> 3. The snapshot is getting created at location mentioned above by truncating 
> the heading space but
> zookeeper_server.pid is getting created at root (/) folder



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2537) When provide path for "dataDir" with heading space, it is taking correct path (by trucating space) for snapshot but zookeeper_server.pid is getting created in root (/

[Rakesh Kumar Singh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh Kumar Singh updated ZOOKEEPER-2537:
--
Priority: Major  (was: Minor)

> When provide path for "dataDir" with heading space, it is taking correct path 
> (by trucating space) for snapshot but zookeeper_server.pid is getting created 
> in root (/) folder
> --
>
> Key: ZOOKEEPER-2537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2537
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Rakesh Kumar Singh
>
> When provide path for "dataDir" with heading space, it is taking correct path 
> (by trucating space) for snapshot but zookeeper_server.pid is getting created 
> in root (/) folder
> Steps to reproduce:-
> 1. Configure the dataDir
> dataDir= /home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data
> Here there is a space after dataDir=
> 2. Start Zookeeper Server
> 3. The snapshot is getting created at location mentioned above by truncating 
> the heading space but
> zookeeper_server.pid is getting created at root (/) folder



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZOOKEEPER-2537) When provide path for "dataDir" with heading space, it is taking correct path (by trucating space) for snapshot but zookeeper_server.pid is getting created in root (/

[Rakesh Kumar Singh (JIRA)]

Rakesh Kumar Singh created ZOOKEEPER-2537:
-

 Summary: When provide path for "dataDir" with heading space, it is 
taking correct path (by trucating space) for snapshot but zookeeper_server.pid 
is getting created in root (/) folder
 Key: ZOOKEEPER-2537
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2537
 Project: ZooKeeper
  Issue Type: Bug
  Components: server
Affects Versions: 3.5.2, 3.5.1
Reporter: Rakesh Kumar Singh
Priority: Minor


When provide path for "dataDir" with heading space, it is taking correct path 
(by trucating space) for snapshot but zookeeper_server.pid is getting created 
in root (/) folder
Steps to reproduce:-
1. Configure the dataDir
dataDir= /home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data
Here there is a space after dataDir=
2. Start Zookeeper Server
3. The snapshot is getting created at location mentioned above by truncating 
the heading space but
zookeeper_server.pid is getting created at root (/) folder



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZOOKEEPER-2536) When provide path for "dataDir" with trailing space, it is taking correct path (by trucating space) for snapshot but creating temporary file with some junk folder nam

[Rakesh Kumar Singh (JIRA)]

Rakesh Kumar Singh created ZOOKEEPER-2536:
-

 Summary: When provide path for "dataDir" with trailing space, it 
is taking correct path (by trucating space) for snapshot but creating temporary 
file with some junk folder name for zookeeper_server.pid
 Key: ZOOKEEPER-2536
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2536
 Project: ZooKeeper
  Issue Type: Bug
  Components: server
Affects Versions: 3.5.2, 3.5.1
Reporter: Rakesh Kumar Singh


When provide path for "dataDir" with trailing space, it is taking correct path 
(by trucating space) for snapshot but creating temporary file with some junk 
folder name for zookeeper_server.pid

Steps to reproduce:-
1. Configure the dataDir
dataDir=/home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data 
Here there is a space after /data 
2. Start Zookeeper Server
3. The snapshot is getting created at location mentioned above by truncating 
the trailing space but
one temp folder with junk name (like -> D29D4X~J) is getting created for 
zookeeper_server.pid





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk-solaris - Build # 1286 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1286/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 486527 lines...]
[junit] 2016-08-26 08:29:10,305 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-08-26 08:29:10,305 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-08-26 08:29:10,306 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-08-26 08:29:10,306 [myid:] - INFO  [main:ZooKeeperServer@889] 
- minSessionTimeout set to 6000
[junit] 2016-08-26 08:29:10,306 [myid:] - INFO  [main:ZooKeeperServer@898] 
- maxSessionTimeout set to 6
[junit] 2016-08-26 08:29:10,306 [myid:] - INFO  [main:ZooKeeperServer@159] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test5525838290939674092.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test5525838290939674092.junit.dir/version-2
[junit] 2016-08-26 08:29:10,307 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test5525838290939674092.junit.dir/version-2/snapshot.b
[junit] 2016-08-26 08:29:10,308 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-08-26 08:29:10,309 [myid:] - INFO  [main:FileTxnSnapLog@298] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test5525838290939674092.junit.dir/version-2/snapshot.b
[junit] 2016-08-26 08:29:10,310 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-08-26 08:29:10,310 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-08-26 08:29:10,311 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:33505
[junit] 2016-08-26 08:29:10,311 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:33505
[junit] 2016-08-26 08:29:10,312 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-08-26 08:29:10,312 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:33505 (no session established for client)
[junit] 2016-08-26 08:29:10,312 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-08-26 08:29:10,314 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-08-26 08:29:10,314 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-08-26 08:29:10,314 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-08-26 08:29:10,314 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-08-26 08:29:10,314 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17662
[junit] 2016-08-26 08:29:10,315 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-08-26 08:29:10,315 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-08-26 08:29:10,315 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-08-26 08:29:10,392 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x12342f33287 closed
[junit] 2016-08-26 08:29:10,392 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x12342f33287
[junit] 2016-08-26 08:29:10,392 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-08-26 08:29:10,393 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-08-26 08:29:10,393 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-08-26 08:29:10,393 [myid:] - INFO  

[jira] [Updated] (ZOOKEEPER-2535) zookeeper_server's pid should be created once server is started completely and not before, problem with current approach

[Rakesh Kumar Singh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh Kumar Singh updated ZOOKEEPER-2535:
--
Description: 
zookeeper_server's pid should be created once server is started completely and 
not before, problem with current approach :-
Scenario:-
1. Configure below in zoo.cfg
dataDir=/home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data
2. Start zookeeper server
3. Change the dataDir to suppose
dataDir=/home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data1
4. Again start zookeeper without stopping zookeeper.

Though it will fail to start the server as port is already bind, it will create 
"zookeeper_server.pid" file with different PID inside and "version-2" folder

Now again revertback the dataDir path and stop the server, the new created 
folder and file at step 4 remained


  was:
zookeeper_server's pid should be created once server is started and not before, 
problem with current approach :-
Scenario:-
1. Configure below in zoo.cfg
dataDir=/home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data
2. Start zookeeper server
3. Change the dataDir to suppose
dataDir=/home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data1
4. Again start zookeeper without stopping zookeeper.

Though it will fail to start the server as port is already bind, it will create 
"zookeeper_server.pid" file with different PID inside and "version-2" folder

Now again revertback the dataDir path and stop the server, the new created 
folder and file at step 4 remained



> zookeeper_server's pid should be created once server is started completely 
> and not before, problem with current approach
> 
>
> Key: ZOOKEEPER-2535
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2535
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.1
>Reporter: Rakesh Kumar Singh
>
> zookeeper_server's pid should be created once server is started completely 
> and not before, problem with current approach :-
> Scenario:-
> 1. Configure below in zoo.cfg
> dataDir=/home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data
> 2. Start zookeeper server
> 3. Change the dataDir to suppose
> dataDir=/home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data1
> 4. Again start zookeeper without stopping zookeeper.
> Though it will fail to start the server as port is already bind, it will 
> create "zookeeper_server.pid" file with different PID inside and "version-2" 
> folder
> Now again revertback the dataDir path and stop the server, the new created 
> folder and file at step 4 remained



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2535) zookeeper_server's pid should be created once server is started completely and not before, problem with current approach

[Rakesh Kumar Singh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh Kumar Singh updated ZOOKEEPER-2535:
--
Summary: zookeeper_server's pid should be created once server is started 
completely and not before, problem with current approach  (was: 
zookeeper_server's pid should be created once server is started and not before, 
problem with current approach)

> zookeeper_server's pid should be created once server is started completely 
> and not before, problem with current approach
> 
>
> Key: ZOOKEEPER-2535
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2535
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.1
>Reporter: Rakesh Kumar Singh
>
> zookeeper_server's pid should be created once server is started and not 
> before, problem with current approach :-
> Scenario:-
> 1. Configure below in zoo.cfg
> dataDir=/home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data
> 2. Start zookeeper server
> 3. Change the dataDir to suppose
> dataDir=/home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data1
> 4. Again start zookeeper without stopping zookeeper.
> Though it will fail to start the server as port is already bind, it will 
> create "zookeeper_server.pid" file with different PID inside and "version-2" 
> folder
> Now again revertback the dataDir path and stop the server, the new created 
> folder and file at step 4 remained



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZOOKEEPER-2535) zookeeper_server's pid should be created once server is started and not before, problem with current approach

[Rakesh Kumar Singh (JIRA)]

Rakesh Kumar Singh created ZOOKEEPER-2535:
-

 Summary: zookeeper_server's pid should be created once server is 
started and not before, problem with current approach
 Key: ZOOKEEPER-2535
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2535
 Project: ZooKeeper
  Issue Type: Bug
  Components: server
Affects Versions: 3.5.1
Reporter: Rakesh Kumar Singh


zookeeper_server's pid should be created once server is started and not before, 
problem with current approach :-
Scenario:-
1. Configure below in zoo.cfg
dataDir=/home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data
2. Start zookeeper server
3. Change the dataDir to suppose
dataDir=/home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data1
4. Again start zookeeper without stopping zookeeper.

Though it will fail to start the server as port is already bind, it will create 
"zookeeper_server.pid" file with different PID inside and "version-2" folder

Now again revertback the dataDir path and stop the server, the new created 
folder and file at step 4 remained




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)