ZooKeeper_branch35_jdk7 - Build # 653 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/653/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 458269 lines...]
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioWorker.writeFromTaskLoop(AbstractNioWorker.java:151)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioChannel$WriteTask.run(AbstractNioChannel.java:315)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.processTaskQueue(AbstractNioSelector.java:391)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:315)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioWorker.run(AbstractNioWorker.java:89)
[junit] at 
org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:178)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2016-09-08 05:53:25,270 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port22238,name1=Connections,name2=127.0.0.1,name3=0x1020da8313d]
[junit] 2016-09-08 05:53:25,370 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x1020da8313d closed
[junit] 2016-09-08 05:53:25,370 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1020da8313d
[junit] 2016-09-08 05:53:25,370 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 136363
[junit] 2016-09-08 05:53:25,370 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 1642
[junit] 2016-09-08 05:53:25,370 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2016-09-08 05:53:25,371 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-09-08 05:53:25,371 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-09-08 05:53:25,371 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:22238
[junit] 2016-09-08 05:53:25,374 [myid:] - INFO  [main:ZooKeeperServer@529] 
- shutting down
[junit] 2016-09-08 05:53:25,375 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-09-08 05:53:25,375 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2016-09-08 05:53:25,375 [myid:] - INFO  
[main:PrepRequestProcessor@965] - Shutting down
[junit] 2016-09-08 05:53:25,375 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2016-09-08 05:53:25,377 [myid:] - INFO  [ProcessThread(sid:0 
cport:22238)::PrepRequestProcessor@154] - PrepRequestProcessor exited loop!
[junit] 2016-09-08 05:53:25,377 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2016-09-08 05:53:25,377 [myid:] - INFO  
[main:FinalRequestProcessor@479] - shutdown of request processor complete
[junit] 2016-09-08 05:53:25,377 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port22238,name1=InMemoryDataTree]
[junit] 2016-09-08 05:53:25,378 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port22238]
[junit] 2016-09-08 05:53:25,378 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 22238
[junit] 2016-09-08 05:53:25,378 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-09-08 05:53:25,385 [myid:] - INFO  [main:ClientBase@568] - 
fdcount after test is: 4827 at start it was 4832
[junit] 2016-09-08 05:53:25,385 [myid:] - INFO  [main:ZKTestCase$1@65] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2016-09-08 05:53:25,385 [myid:] - INFO  [main:ZKTestCase$1@60] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 101, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
542.484 sec, Thread: 5, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2016-09-08 05:53:25,489 [myid:127.0.0.1:21994] - INFO  
[main-SendThread(127.0.0.1:21994):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:21994. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-09-08 05:53:25,490 [myid:127.0.0.1:21994] - WARN  

[jira] [Commented] (ZOOKEEPER-2539) Throwing nullpointerException when run the command "config -c" when client port is mentioned as separate and not like new style

[Rakesh Kumar Singh (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472859#comment-15472859
 ] 

Rakesh Kumar Singh commented on ZOOKEEPER-2539:
---

Thank you for feedback !!!

> Throwing nullpointerException when run the command "config -c" when client 
> port is mentioned as separate and not like new style
> ---
>
> Key: ZOOKEEPER-2539
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2539
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Rakesh Kumar Singh
>Assignee: Rakesh Kumar Singh
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ConfigUtils.java.patch, ConfigUtils.java.patch, 
> ZOOKEEPER-2539.patch
>
>
> Throwing nullpointerException when run the command "config -c" when client 
> port is mentioned as separate and not like new style
> 1. Configure the zookeeper to start in cluster mode like below-
> clientPort=2181
> server.1=10.18.101.80:2888:3888
> server.2=10.18.219.50:2888:3888
> server.3=10.18.221.194:2888:3888
> and not like below:-
> server.1=10.18.101.80:2888:3888:participant;2181
> server.2=10.18.219.50:2888:3888:participant;2181
> server.3=10.18.221.194:2888:3888:participant;2181
> 2. Start the cluster and one client using >zkCli.sh
> 3. execute command "config -c"
> It is throwing nullpointerException:-
> root@BLR110865:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin#
>  ./zkCli.sh 
> Connecting to localhost:2181
> 2016-08-29 21:45:19,558 [myid:] - INFO  [main:Environment@109] - Client 
> environment:zookeeper.version=3.5.1-alpha--1, built on 08/18/2016 08:20 GMT
> 2016-08-29 21:45:19,561 [myid:] - INFO  [main:Environment@109] - Client 
> environment:host.name=BLR110865
> 2016-08-29 21:45:19,562 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.version=1.7.0_17
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.vendor=Oracle Corporation
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.home=/usr/lib/jvm/oracle_jdk7/jre
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.class.path=/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../build/classes:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../build/lib/*.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/slf4j-log4j12-1.7.5.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/slf4j-api-1.7.5.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/servlet-api-2.5-20081211.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/netty-3.7.0.Final.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/log4j-1.2.16.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jline-2.11.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jetty-util-6.1.26.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jetty-6.1.26.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/javacc.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jackson-mapper-asl-1.9.11.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jackson-core-asl-1.9.11.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/commons-cli-1.2.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/ant-eclipse-1.0-jvm1.2.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../zookeeper-3.5.1-alpha.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../src/java/lib/ant-eclipse-1.0-jvm1.2.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../conf:
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.library.path=/usr/java/packages/lib/amd64:/usr/lib64:/lib64:/lib:/usr/lib
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.io.tmpdir=/tmp
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.compiler=
> 2016-08-29 21:45:19,565 [myid:] - INFO  [main:Environment@109] - Client 
> environment:os.name=Linux
> 2016-08-29 21:45:19,565 [myid:] - INFO  [main:Environment@109] - Client 
> environment:os.arch=amd64
> 2016-08-29 21:45:19,565 [myid:] - INFO  [main:Environment@109] - Client 
> environment:os.version=4.4.0-31-generic
> 2016-08-29 21:45:19,565 [myid:] - INFO  [main:Environment@109] - Client 
> environment:user.name=root
> 2016-08-29 

[jira] [Commented] (ZOOKEEPER-2536) When provide path for "dataDir" with trailing space, it is taking correct path (by trucating space) for snapshot but creating temporary file with some junk folder n

[Rakesh Kumar Singh (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472858#comment-15472858
 ] 

Rakesh Kumar Singh commented on ZOOKEEPER-2536:
---

Thank you for feedback and commit !!!

> When provide path for "dataDir" with trailing space, it is taking correct 
> path (by trucating space) for snapshot but creating temporary file with some 
> junk folder name for zookeeper_server.pid
> 
>
> Key: ZOOKEEPER-2536
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2536
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Rakesh Kumar Singh
>Assignee: Rakesh Kumar Singh
> Fix For: 3.5.3, 3.6.0
>
> Attachments: zkServer.sh.patch, zkServer.sh.patch
>
>
> Scenario 1:-
> When provide path for "dataDir" with trailing space, it is taking correct 
> path (by trucating space) for snapshot but creating temporary file with some 
> junk folder name for zookeeper_server.pid
> Steps to reproduce:-
> 1. Configure the dataDir
> dataDir=/home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data 
> Here there is a space after /data 
> 2. Start Zookeeper Server
> 3. The snapshot is getting created at location mentioned above by truncating 
> the trailing space but
> one temp folder with junk name (like -> D29D4X~J) is getting created for 
> zookeeper_server.pid
> Scenario 2:-
> When configure the heading and trailing space in above mentioned scenario. 
> the temp folder is getting created in zookeeper/bin folder



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk-solaris - Build # 1300 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1300/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 440231 lines...]
[junit] 2016-09-08 05:39:33,892 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-09-08 05:39:33,892 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-09-08 05:39:33,893 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-09-08 05:39:33,893 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-09-08 05:39:33,894 [myid:] - INFO  [main:ZooKeeperServer@889] 
- minSessionTimeout set to 6000
[junit] 2016-09-08 05:39:33,894 [myid:] - INFO  [main:ZooKeeperServer@898] 
- maxSessionTimeout set to 6
[junit] 2016-09-08 05:39:33,894 [myid:] - INFO  [main:ZooKeeperServer@159] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test186246505682328.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test186246505682328.junit.dir/version-2
[junit] 2016-09-08 05:39:33,895 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test186246505682328.junit.dir/version-2/snapshot.b
[junit] 2016-09-08 05:39:33,897 [myid:] - INFO  [main:FileTxnSnapLog@298] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test186246505682328.junit.dir/version-2/snapshot.b
[junit] 2016-09-08 05:39:33,898 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-09-08 05:39:33,898 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-09-08 05:39:33,899 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:62095
[junit] 2016-09-08 05:39:33,899 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:62095
[junit] 2016-09-08 05:39:33,900 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-09-08 05:39:33,900 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:62095 (no session established for client)
[junit] 2016-09-08 05:39:33,900 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-09-08 05:39:33,902 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-09-08 05:39:33,902 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-09-08 05:39:33,902 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-09-08 05:39:33,902 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-09-08 05:39:33,902 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17809
[junit] 2016-09-08 05:39:33,902 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-09-08 05:39:33,903 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-09-08 05:39:33,903 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-09-08 05:39:33,982 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x123854a67f1 closed
[junit] 2016-09-08 05:39:33,982 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x123854a67f1
[junit] 2016-09-08 05:39:33,982 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-09-08 05:39:33,983 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-09-08 05:39:33,983 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-09-08 05:39:33,983 [myid:] - INFO  

[jira] [Comment Edited] (ZOOKEEPER-2550) FollowerResyncConcurrencyTest failed in ZooKeeper 3.3.3

[KangYin (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472847#comment-15472847
 ] 

KangYin edited comment on ZOOKEEPER-2550 at 9/8/16 5:36 AM:


Thanks Patrick.
I have checked ZOOKEEPER-1264. But the reason that the 
_FollowerResyncConcurrencyTest_ failed in this issue is not the same as 
ZOOKEEPER-1264. It appears both in 3.3.3 and 3.4+ .
As I mentioned in the issue's description, the reason happened is 
_FollowerResyncConcurrencyTest.java_ at line 92.

{code:title=FollowerResyncConcurrencyTest.java|borderStyle=solid}
QuorumUtil qu = new QuorumUtil(1);
qu.startAll();
CountdownWatcher watcher1 = new CountdownWatcher();
CountdownWatcher watcher2 = new CountdownWatcher();
CountdownWatcher watcher3 = new CountdownWatcher();

int index = 1;
while(qu.getPeer(index).peer.leader == null)
index++;

Leader leader = qu.getPeer(index).peer.leader;

assertNotNull(leader);
/*
 * Reusing the index variable to select a follower to connect to
 */
index = (index == 1) ? 2 : 1;
qu.shutdown(index);
final ZooKeeper zk3 = new DisconnectableZooKeeper("127.0.0.1:" + 
qu.getPeer(3).peer.getClientPort(), 1000,watcher3);
watcher3.waitForConnected(CONNECTION_TIMEOUT);  // Failed here
zk3.create("/mybar", null, ZooDefs.Ids.OPEN_ACL_UNSAFE, 
CreateMode.EPHEMERAL_SEQUENTIAL);
{code}

Hope I can describe the trace clearly:
(1) initialize 3 quorum peers and start all (peer 3 is the leader in my case)
(2) shutdown peer 1
(3) new a DisconnectableZooKeeper connect to peer 3' clientport with watcher3
(4) watcher3 wait for connected, but failed after CONNECTION_TIMEOUT

I'm confusing about the connect failed. After checked the log messages, I got 
the following logs that probably related:

{noformat}
2016-09-05 13:56:55,000 - INFO [SyncThread:3:FileTxnLog@197] - Creating new log 
file: log.10001
2016-09-05 13:56:55,000 - WARN [QuorumPeer:/0:0:0:0:0:0:0:0:11235:Follower@116] 
- Got zxid 0x10001 expected 0x1
2016-09-05 13:56:55,000 - INFO [SyncThread:2:FileTxnLog@197] - Creating new log 
file: log.10001
2016-09-05 13:56:55,078 - ERROR [CommitProcessor:3:CommitProcessor@146] - 
Unexpected exception causing CommitProcessor to exit
java.lang.AssertionError
at org.apache.zookeeper.jmx.MBeanRegistry.register(MBeanRegistry.java:66)
at 
org.apache.zookeeper.server.NIOServerCnxn.finishSessionInit(NIOServerCnxn.java:1552)
at 
org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:183)
at 
org.apache.zookeeper.server.quorum.Leader$ToBeAppliedRequestProcessor.processRequest(Leader.java:540)
at 
org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:73)
2016-09-05 13:56:55,078 - INFO [CommitProcessor:3:CommitProcessor@148] - 
CommitProcessor exited loop!
{noformat}


was (Author: yinkang):
Thanks Patrick.
I have checked ZOOKEEPER-1264. But the reason that the 
__FollowerResyncConcurrencyTest__ failed in this issue is not the same as 
ZOOKEEPER-1264. It appears both in 3.3.3 and 3.4+ .
As I mentioned in the issue's description, the reason happened is 
__FollowerResyncConcurrencyTest.java__ at line 92.

{code:title=FollowerResyncConcurrencyTest.java|borderStyle=solid}

QuorumUtil qu = new QuorumUtil(1);
qu.startAll();
CountdownWatcher watcher1 = new CountdownWatcher();
CountdownWatcher watcher2 = new CountdownWatcher();
CountdownWatcher watcher3 = new CountdownWatcher();

int index = 1;
while(qu.getPeer(index).peer.leader == null)
index++;

Leader leader = qu.getPeer(index).peer.leader;

assertNotNull(leader);
/*
 * Reusing the index variable to select a follower to connect to
 */
index = (index == 1) ? 2 : 1;
qu.shutdown(index);
final ZooKeeper zk3 = new DisconnectableZooKeeper("127.0.0.1:" + 
qu.getPeer(3).peer.getClientPort(), 1000,watcher3);
watcher3.waitForConnected(CONNECTION_TIMEOUT);  // Failed here
zk3.create("/mybar", null, ZooDefs.Ids.OPEN_ACL_UNSAFE, 
CreateMode.EPHEMERAL_SEQUENTIAL);

{code}

Hope I can describe the trace clearly:
(1) initialize 3 quorum peers and start all (peer 3 is the leader in my case)
(2) shutdown peer 1
(3) new a DisconnectableZooKeeper connect to peer 3' clientport with watcher3
(4) watcher3 wait for connected, but failed after CONNECTION_TIMEOUT

I'm confusing about the connect failed. After checked the log messages, I got 
the following logs that probably related:

{noformat}
2016-09-05 13:56:55,000 - INFO [SyncThread:3:FileTxnLog@197] - Creating new log 
file: log.10001
2016-09-05 13:56:55,000 - WARN [QuorumPeer:/0:0:0:0:0:0:0:0:11235:Follower@116] 
- Got zxid 0x10001 expected 0x1
2016-09-05 13:56:55,000 - INFO 

[jira] [Commented] (ZOOKEEPER-2550) FollowerResyncConcurrencyTest failed in ZooKeeper 3.3.3

[KangYin (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472847#comment-15472847
 ] 

KangYin commented on ZOOKEEPER-2550:


Thanks Patrick.
I have checked ZOOKEEPER-1264. But the reason that the 
__FollowerResyncConcurrencyTest__ failed in this issue is not the same as 
ZOOKEEPER-1264. It appears both in 3.3.3 and 3.4+ .
As I mentioned in the issue's description, the reason happened is 
__FollowerResyncConcurrencyTest.java__ at line 92.

{code:title=FollowerResyncConcurrencyTest.java|borderStyle=solid}

QuorumUtil qu = new QuorumUtil(1);
qu.startAll();
CountdownWatcher watcher1 = new CountdownWatcher();
CountdownWatcher watcher2 = new CountdownWatcher();
CountdownWatcher watcher3 = new CountdownWatcher();

int index = 1;
while(qu.getPeer(index).peer.leader == null)
index++;

Leader leader = qu.getPeer(index).peer.leader;

assertNotNull(leader);
/*
 * Reusing the index variable to select a follower to connect to
 */
index = (index == 1) ? 2 : 1;
qu.shutdown(index);
final ZooKeeper zk3 = new DisconnectableZooKeeper("127.0.0.1:" + 
qu.getPeer(3).peer.getClientPort(), 1000,watcher3);
watcher3.waitForConnected(CONNECTION_TIMEOUT);  // Failed here
zk3.create("/mybar", null, ZooDefs.Ids.OPEN_ACL_UNSAFE, 
CreateMode.EPHEMERAL_SEQUENTIAL);

{code}

Hope I can describe the trace clearly:
(1) initialize 3 quorum peers and start all (peer 3 is the leader in my case)
(2) shutdown peer 1
(3) new a DisconnectableZooKeeper connect to peer 3' clientport with watcher3
(4) watcher3 wait for connected, but failed after CONNECTION_TIMEOUT

I'm confusing about the connect failed. After checked the log messages, I got 
the following logs that probably related:

{noformat}
2016-09-05 13:56:55,000 - INFO [SyncThread:3:FileTxnLog@197] - Creating new log 
file: log.10001
2016-09-05 13:56:55,000 - WARN [QuorumPeer:/0:0:0:0:0:0:0:0:11235:Follower@116] 
- Got zxid 0x10001 expected 0x1
2016-09-05 13:56:55,000 - INFO [SyncThread:2:FileTxnLog@197] - Creating new log 
file: log.10001
2016-09-05 13:56:55,078 - ERROR [CommitProcessor:3:CommitProcessor@146] - 
Unexpected exception causing CommitProcessor to exit
java.lang.AssertionError
at org.apache.zookeeper.jmx.MBeanRegistry.register(MBeanRegistry.java:66)
at 
org.apache.zookeeper.server.NIOServerCnxn.finishSessionInit(NIOServerCnxn.java:1552)
at 
org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:183)
at 
org.apache.zookeeper.server.quorum.Leader$ToBeAppliedRequestProcessor.processRequest(Leader.java:540)
at 
org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:73)
2016-09-05 13:56:55,078 - INFO [CommitProcessor:3:CommitProcessor@148] - 
CommitProcessor exited loop!
{noformat}

> FollowerResyncConcurrencyTest failed in ZooKeeper 3.3.3
> ---
>
> Key: ZOOKEEPER-2550
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2550
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: leaderElection, quorum, server, tests
>Affects Versions: 3.3.3
> Environment: Windows 10,
> Java 1.8.0,
> IDEA 2016.1.4,
> JUnit 4.8.1
>Reporter: KangYin
>Priority: Blocker
>  Labels: test
>
>  I'm studying on the Test of ZooKeeper 3.3.3 but got a test failure when I 
> run  _testResyncBySnapThenDiffAfterFollowerCrashes_ in 
> _FollowerResyncConcurrencyTest.java_.
> {quote}
> 2016-09-05 13:57:35,072 - INFO  [main:QuorumBase@307] - FINISHED 
> testResyncBySnapThenDiffAfterFollowerCrashes
> java.util.concurrent.TimeoutException: Did not connect
>   at 
> org.apache.zookeeper.test.ClientBase$CountdownWatcher.waitForConnected(ClientBase.java:119)
>   at 
> org.apache.zookeeper.test.FollowerResyncConcurrencyTest.testResyncBySnapThenDiffAfterFollowerCrashes(FollowerResyncConcurrencyTest.java:95)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at junit.framework.TestCase.runTest(TestCase.java:168)
>   at junit.framework.TestCase.runBare(TestCase.java:134)
>   at junit.framework.TestResult$1.protect(TestResult.java:110)
>   at junit.framework.TestResult.runProtected(TestResult.java:128)
>   at junit.framework.TestResult.run(TestResult.java:113)
>   at junit.framework.TestCase.run(TestCase.java:124)
>   at junit.framework.TestSuite.runTest(TestSuite.java:232)
>   at junit.framework.TestSuite.run(TestSuite.java:227)
>   

[jira] [Commented] (ZOOKEEPER-2536) When provide path for "dataDir" with trailing space, it is taking correct path (by trucating space) for snapshot but creating temporary file with some junk folder n

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472727#comment-15472727
 ] 

Hudson commented on ZOOKEEPER-2536:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3068 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3068/])
ZOOKEEPER-2536: When provide path for 'dataDir' with trailing space, it is 
taking correct path (by trucating space) for snapshot but creating temporary 
file with some junk folder name for zookeeper_server.pid (Rakesh Kumar Singh 
via phunt) (phunt: 
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1759739])
* (edit) trunk/CHANGES.txt
* (edit) trunk/bin/zkServer.sh


> When provide path for "dataDir" with trailing space, it is taking correct 
> path (by trucating space) for snapshot but creating temporary file with some 
> junk folder name for zookeeper_server.pid
> 
>
> Key: ZOOKEEPER-2536
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2536
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Rakesh Kumar Singh
>Assignee: Rakesh Kumar Singh
> Fix For: 3.5.3, 3.6.0
>
> Attachments: zkServer.sh.patch, zkServer.sh.patch
>
>
> Scenario 1:-
> When provide path for "dataDir" with trailing space, it is taking correct 
> path (by trucating space) for snapshot but creating temporary file with some 
> junk folder name for zookeeper_server.pid
> Steps to reproduce:-
> 1. Configure the dataDir
> dataDir=/home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data 
> Here there is a space after /data 
> 2. Start Zookeeper Server
> 3. The snapshot is getting created at location mentioned above by truncating 
> the trailing space but
> one temp folder with junk name (like -> D29D4X~J) is getting created for 
> zookeeper_server.pid
> Scenario 2:-
> When configure the heading and trailing space in above mentioned scenario. 
> the temp folder is getting created in zookeeper/bin folder



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch35_solaris - Build # 239 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_solaris/239/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 485212 lines...]
[junit] 2016-09-08 04:30:11,761 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-09-08 04:30:11,761 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-09-08 04:30:11,762 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-09-08 04:30:11,763 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-09-08 04:30:11,763 [myid:] - INFO  [main:ZooKeeperServer@889] 
- minSessionTimeout set to 6000
[junit] 2016-09-08 04:30:11,763 [myid:] - INFO  [main:ZooKeeperServer@898] 
- maxSessionTimeout set to 6
[junit] 2016-09-08 04:30:11,763 [myid:] - INFO  [main:ZooKeeperServer@159] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test3619808492391792431.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test3619808492391792431.junit.dir/version-2
[junit] 2016-09-08 04:30:11,764 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test3619808492391792431.junit.dir/version-2/snapshot.b
[junit] 2016-09-08 04:30:11,766 [myid:] - INFO  [main:FileTxnSnapLog@298] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test3619808492391792431.junit.dir/version-2/snapshot.b
[junit] 2016-09-08 04:30:11,767 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-09-08 04:30:11,767 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-09-08 04:30:11,768 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:44643
[junit] 2016-09-08 04:30:11,768 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:44643
[junit] 2016-09-08 04:30:11,769 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-09-08 04:30:11,769 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:44643 (no session established for client)
[junit] 2016-09-08 04:30:11,769 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-09-08 04:30:11,771 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-09-08 04:30:11,771 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-09-08 04:30:11,771 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-09-08 04:30:11,771 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-09-08 04:30:11,771 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17780
[junit] 2016-09-08 04:30:11,772 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-09-08 04:30:11,772 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-09-08 04:30:11,772 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-09-08 04:30:11,852 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x123850ae5bf closed
[junit] 2016-09-08 04:30:11,852 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-09-08 04:30:11,852 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x123850ae5bf
[junit] 2016-09-08 04:30:11,852 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-09-08 04:30:11,852 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-09-08 04:30:11,852 [myid:] - INFO  

[jira] [Commented] (ZOOKEEPER-2539) Throwing nullpointerException when run the command "config -c" when client port is mentioned as separate and not like new style

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472712#comment-15472712
 ] 

Hadoop QA commented on ZOOKEEPER-2539:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12827491/ZOOKEEPER-2539.patch
  against trunk revision 1759739.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3401//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3401//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3401//console

This message is automatically generated.

> Throwing nullpointerException when run the command "config -c" when client 
> port is mentioned as separate and not like new style
> ---
>
> Key: ZOOKEEPER-2539
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2539
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Rakesh Kumar Singh
>Assignee: Rakesh Kumar Singh
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ConfigUtils.java.patch, ConfigUtils.java.patch, 
> ZOOKEEPER-2539.patch
>
>
> Throwing nullpointerException when run the command "config -c" when client 
> port is mentioned as separate and not like new style
> 1. Configure the zookeeper to start in cluster mode like below-
> clientPort=2181
> server.1=10.18.101.80:2888:3888
> server.2=10.18.219.50:2888:3888
> server.3=10.18.221.194:2888:3888
> and not like below:-
> server.1=10.18.101.80:2888:3888:participant;2181
> server.2=10.18.219.50:2888:3888:participant;2181
> server.3=10.18.221.194:2888:3888:participant;2181
> 2. Start the cluster and one client using >zkCli.sh
> 3. execute command "config -c"
> It is throwing nullpointerException:-
> root@BLR110865:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin#
>  ./zkCli.sh 
> Connecting to localhost:2181
> 2016-08-29 21:45:19,558 [myid:] - INFO  [main:Environment@109] - Client 
> environment:zookeeper.version=3.5.1-alpha--1, built on 08/18/2016 08:20 GMT
> 2016-08-29 21:45:19,561 [myid:] - INFO  [main:Environment@109] - Client 
> environment:host.name=BLR110865
> 2016-08-29 21:45:19,562 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.version=1.7.0_17
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.vendor=Oracle Corporation
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.home=/usr/lib/jvm/oracle_jdk7/jre
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> 

Failed: ZOOKEEPER-2539 PreCommit Build #3401

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2539
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3401/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 452113 lines...]
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3401//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3401//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3401//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] e772fd30f608835ae8f404035eadb85548729503 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1605:
 exec returned: 1

Total time: 17 minutes 43 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2539
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Updated] (ZOOKEEPER-1927) zkServer.sh fails to read dataDir (and others) from zoo.cfg on Solaris 10 (grep issue, manifests as FAILED TO WRITE PID).

[Raul Gutierrez Segales (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raul Gutierrez Segales updated ZOOKEEPER-1927:
--
Fix Version/s: (was: 3.5.2)
   3.5.3

> zkServer.sh fails to read dataDir (and others) from zoo.cfg on Solaris 10 
> (grep issue, manifests as FAILED TO WRITE PID).  
> ---
>
> Key: ZOOKEEPER-1927
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1927
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: scripts
>Affects Versions: 3.4.6
> Environment: Solaris 5.10 
>Reporter: Ed Schmed
>Assignee: Chris Nauroth
> Fix For: 3.4.7, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-1927-branch-3.4.002.patch, 
> ZOOKEEPER-1927.001.patch, ZOOKEEPER-1927.002.patch
>
>
> Fails to write PID file with a permissions error, because the startup script 
> fails to read the dataDir variable from zoo.cfg, and then tries to use the 
> drive root ( / ) as the data dir.
> Tracked the problem down to line 84 of zkServer.sh:
> ZOO_DATADIR="$(grep "^[[:space:]]*dataDir" "$ZOOCFG" | sed -e 's/.*=//')"
> If i run just that line and point it right at the config file, ZOO_DATADIR is 
> empty.
> If I remove [[:space:]]* from the grep:
> ZOO_DATADIR="$(grep "^dataDir" "$ZOOCFG" | sed -e 's/.*=//')"
> Then it works fine. (If I also make the same change on line 164 and 169)
> My regex skills are pretty bad, so I'm afraid to comment on why [[space]]* 
> needs to be in there?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Missing patch ZOOKEEPER-1927 in 3.5 branch

[Raúl Gutiérrez Segalés]

On 7 September 2016 at 20:53, Patrick Hunt  wrote:

> No worries. I would have committed myself but it wasn't clear if that

was the right thing to do or not. Thanks for resolving.
>

Merged:

https://github.com/apache/zookeeper/commit/ac26b96b61e116937239a15fb4dbcc4f17a4f818


-rgs



> Patrick
>
> On Wed, Sep 7, 2016 at 8:50 PM, Raúl Gutiérrez Segalés
>  wrote:
> > On 7 September 2016 at 20:44, Patrick Hunt  wrote:
> >>
> >> Hi Chris, Raul, it looks like ZOOKEEPER-1927 is in 3.4 and trunk,
> >> however it did not land in 3.5.2 as recorded in the jira.
> >>
> >> https://issues.apache.org/jira/browse/ZOOKEEPER-1927
> >>
> >> I noticed this when attempting to commit
> >> https://issues.apache.org/jira/browse/ZOOKEEPER-2536 as it applied
> >> cleanly to trunk but not to 3.5 branch.
> >>
> >> I looked at the logs and afaict it's in 3.4 and trunk, but not in 3.5
> >> branch.
> >>
> >> Do you guys know what happened here? Just an oversight or on purpose?
> >
> >
> > Definitely oversight -- sorry. I'll go ahead and merge now. Thanks!
> >
> >
> > -rgs
> >
>

[jira] [Commented] (ZOOKEEPER-1927) zkServer.sh fails to read dataDir (and others) from zoo.cfg on Solaris 10 (grep issue, manifests as FAILED TO WRITE PID).

[Raul Gutierrez Segales (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472652#comment-15472652
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-1927:
---

Oops -- forgot to merge for 3.5 (literally a year ago!):

https://github.com/apache/zookeeper/commit/ac26b96b61e116937239a15fb4dbcc4f17a4f818

(thanks [~phunt] for the heads-up) 


> zkServer.sh fails to read dataDir (and others) from zoo.cfg on Solaris 10 
> (grep issue, manifests as FAILED TO WRITE PID).  
> ---
>
> Key: ZOOKEEPER-1927
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1927
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: scripts
>Affects Versions: 3.4.6
> Environment: Solaris 5.10 
>Reporter: Ed Schmed
>Assignee: Chris Nauroth
> Fix For: 3.4.7, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-1927-branch-3.4.002.patch, 
> ZOOKEEPER-1927.001.patch, ZOOKEEPER-1927.002.patch
>
>
> Fails to write PID file with a permissions error, because the startup script 
> fails to read the dataDir variable from zoo.cfg, and then tries to use the 
> drive root ( / ) as the data dir.
> Tracked the problem down to line 84 of zkServer.sh:
> ZOO_DATADIR="$(grep "^[[:space:]]*dataDir" "$ZOOCFG" | sed -e 's/.*=//')"
> If i run just that line and point it right at the config file, ZOO_DATADIR is 
> empty.
> If I remove [[:space:]]* from the grep:
> ZOO_DATADIR="$(grep "^dataDir" "$ZOOCFG" | sed -e 's/.*=//')"
> Then it works fine. (If I also make the same change on line 164 and 169)
> My regex skills are pretty bad, so I'm afraid to comment on why [[space]]* 
> needs to be in there?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Missing patch ZOOKEEPER-1927 in 3.5 branch

[Patrick Hunt]

No worries. I would have committed myself but it wasn't clear if that
was the right thing to do or not. Thanks for resolving.

Patrick

On Wed, Sep 7, 2016 at 8:50 PM, Raúl Gutiérrez Segalés
 wrote:
> On 7 September 2016 at 20:44, Patrick Hunt  wrote:
>>
>> Hi Chris, Raul, it looks like ZOOKEEPER-1927 is in 3.4 and trunk,
>> however it did not land in 3.5.2 as recorded in the jira.
>>
>> https://issues.apache.org/jira/browse/ZOOKEEPER-1927
>>
>> I noticed this when attempting to commit
>> https://issues.apache.org/jira/browse/ZOOKEEPER-2536 as it applied
>> cleanly to trunk but not to 3.5 branch.
>>
>> I looked at the logs and afaict it's in 3.4 and trunk, but not in 3.5
>> branch.
>>
>> Do you guys know what happened here? Just an oversight or on purpose?
>
>
> Definitely oversight -- sorry. I'll go ahead and merge now. Thanks!
>
>
> -rgs
>

Re: Missing patch ZOOKEEPER-1927 in 3.5 branch

[Raúl Gutiérrez Segalés]

On 7 September 2016 at 20:44, Patrick Hunt  wrote:

> Hi Chris, Raul, it looks like ZOOKEEPER-1927 is in 3.4 and trunk,
> however it did not land in 3.5.2 as recorded in the jira.
>
> https://issues.apache.org/jira/browse/ZOOKEEPER-1927
>
> I noticed this when attempting to commit
> https://issues.apache.org/jira/browse/ZOOKEEPER-2536 as it applied
> cleanly to trunk but not to 3.5 branch.
>
> I looked at the logs and afaict it's in 3.4 and trunk, but not in 3.5
> branch.
>
> Do you guys know what happened here? Just an oversight or on purpose?
>

Definitely oversight -- sorry. I'll go ahead and merge now. Thanks!


-rgs

[jira] [Commented] (ZOOKEEPER-2539) Throwing nullpointerException when run the command "config -c" when client port is mentioned as separate and not like new style

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472634#comment-15472634
 ] 

Hadoop QA commented on ZOOKEEPER-2539:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12827491/ZOOKEEPER-2539.patch
  against trunk revision 1759735.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3400//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3400//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3400//console

This message is automatically generated.

> Throwing nullpointerException when run the command "config -c" when client 
> port is mentioned as separate and not like new style
> ---
>
> Key: ZOOKEEPER-2539
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2539
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Rakesh Kumar Singh
>Assignee: Rakesh Kumar Singh
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ConfigUtils.java.patch, ConfigUtils.java.patch, 
> ZOOKEEPER-2539.patch
>
>
> Throwing nullpointerException when run the command "config -c" when client 
> port is mentioned as separate and not like new style
> 1. Configure the zookeeper to start in cluster mode like below-
> clientPort=2181
> server.1=10.18.101.80:2888:3888
> server.2=10.18.219.50:2888:3888
> server.3=10.18.221.194:2888:3888
> and not like below:-
> server.1=10.18.101.80:2888:3888:participant;2181
> server.2=10.18.219.50:2888:3888:participant;2181
> server.3=10.18.221.194:2888:3888:participant;2181
> 2. Start the cluster and one client using >zkCli.sh
> 3. execute command "config -c"
> It is throwing nullpointerException:-
> root@BLR110865:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin#
>  ./zkCli.sh 
> Connecting to localhost:2181
> 2016-08-29 21:45:19,558 [myid:] - INFO  [main:Environment@109] - Client 
> environment:zookeeper.version=3.5.1-alpha--1, built on 08/18/2016 08:20 GMT
> 2016-08-29 21:45:19,561 [myid:] - INFO  [main:Environment@109] - Client 
> environment:host.name=BLR110865
> 2016-08-29 21:45:19,562 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.version=1.7.0_17
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.vendor=Oracle Corporation
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.home=/usr/lib/jvm/oracle_jdk7/jre
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> 

Failed: ZOOKEEPER-2539 PreCommit Build #3400

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2539
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3400/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 452868 lines...]
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3400//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3400//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3400//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] ae0bdc59ebe17218c28a00313e7a4e6ffeec8531 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1605:
 exec returned: 2

Total time: 16 minutes 54 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2539
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

Missing patch ZOOKEEPER-1927 in 3.5 branch

[Patrick Hunt]

Hi Chris, Raul, it looks like ZOOKEEPER-1927 is in 3.4 and trunk,
however it did not land in 3.5.2 as recorded in the jira.

https://issues.apache.org/jira/browse/ZOOKEEPER-1927

I noticed this when attempting to commit
https://issues.apache.org/jira/browse/ZOOKEEPER-2536 as it applied
cleanly to trunk but not to 3.5 branch.

I looked at the logs and afaict it's in 3.4 and trunk, but not in 3.5 branch.

Do you guys know what happened here? Just an oversight or on purpose?

Patrick

[jira] [Commented] (ZOOKEEPER-2558) Potential memory leak in recordio.c

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472620#comment-15472620
 ] 

Hudson commented on ZOOKEEPER-2558:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3067 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3067/])
ZOOKEEPER-2558: Potential memory leak in recordio.c (Michael Han via phunt) 
(phunt: 
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1759735])
* (edit) trunk/CHANGES.txt
* (edit) trunk/src/c/src/recordio.c


> Potential memory leak in recordio.c
> ---
>
> Key: ZOOKEEPER-2558
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2558
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.4.9, 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
>Priority: Minor
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2558.patch
>
>
> We have code like this in {{create_buffer_iarchive}} and 
> {{create_buffer_oarchive}}:
> {code}
> struct iarchive *ia = malloc(sizeof(*ia));
> struct buff_struct *buff = malloc(sizeof(struct buff_struct));
> if (!ia) return 0;
> if (!buff) {
> free(ia);
> return 0;
> }
> {code}
> If first malloc failed but second succeeds, then the memory allocated with 
> second malloc will not get freed when the function returned. One could argue 
> that if first malloc failed the second will also fail (i.e. when system run 
> out of memory), but I could also see the possibility of the opposite (the 
> first malloc failed because heap fragmentation but the second succeeds).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2539) Throwing nullpointerException when run the command "config -c" when client port is mentioned as separate and not like new style

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472591#comment-15472591
 ] 

Patrick Hunt commented on ZOOKEEPER-2539:
-

Also renamed the patch - [~rakeshsingh] - please look at this document for 
details on patch submission
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
It's a minor thing, but correct naming of the patch (for example) helps 
committers when processing the queues. Thanks!

> Throwing nullpointerException when run the command "config -c" when client 
> port is mentioned as separate and not like new style
> ---
>
> Key: ZOOKEEPER-2539
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2539
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Rakesh Kumar Singh
>Assignee: Rakesh Kumar Singh
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ConfigUtils.java.patch, ConfigUtils.java.patch, 
> ZOOKEEPER-2539.patch
>
>
> Throwing nullpointerException when run the command "config -c" when client 
> port is mentioned as separate and not like new style
> 1. Configure the zookeeper to start in cluster mode like below-
> clientPort=2181
> server.1=10.18.101.80:2888:3888
> server.2=10.18.219.50:2888:3888
> server.3=10.18.221.194:2888:3888
> and not like below:-
> server.1=10.18.101.80:2888:3888:participant;2181
> server.2=10.18.219.50:2888:3888:participant;2181
> server.3=10.18.221.194:2888:3888:participant;2181
> 2. Start the cluster and one client using >zkCli.sh
> 3. execute command "config -c"
> It is throwing nullpointerException:-
> root@BLR110865:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin#
>  ./zkCli.sh 
> Connecting to localhost:2181
> 2016-08-29 21:45:19,558 [myid:] - INFO  [main:Environment@109] - Client 
> environment:zookeeper.version=3.5.1-alpha--1, built on 08/18/2016 08:20 GMT
> 2016-08-29 21:45:19,561 [myid:] - INFO  [main:Environment@109] - Client 
> environment:host.name=BLR110865
> 2016-08-29 21:45:19,562 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.version=1.7.0_17
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.vendor=Oracle Corporation
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.home=/usr/lib/jvm/oracle_jdk7/jre
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.class.path=/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../build/classes:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../build/lib/*.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/slf4j-log4j12-1.7.5.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/slf4j-api-1.7.5.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/servlet-api-2.5-20081211.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/netty-3.7.0.Final.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/log4j-1.2.16.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jline-2.11.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jetty-util-6.1.26.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jetty-6.1.26.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/javacc.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jackson-mapper-asl-1.9.11.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jackson-core-asl-1.9.11.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/commons-cli-1.2.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/ant-eclipse-1.0-jvm1.2.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../zookeeper-3.5.1-alpha.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../src/java/lib/ant-eclipse-1.0-jvm1.2.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../conf:
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.library.path=/usr/java/packages/lib/amd64:/usr/lib64:/lib64:/lib:/usr/lib
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.io.tmpdir=/tmp
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.compiler=
> 2016-08-29 21:45:19,565 [myid:] - INFO  [main:Environment@109] - Client 
> environment:os.name=Linux
> 2016-08-29 21:45:19,565 [myid:] - INFO  [main:Environment@109] - Client 
> 

[jira] [Updated] (ZOOKEEPER-2539) Throwing nullpointerException when run the command "config -c" when client port is mentioned as separate and not like new style

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2539:

Attachment: ZOOKEEPER-2539.patch

Cleaned up the formatting a bit. Otherwise lgtm.

> Throwing nullpointerException when run the command "config -c" when client 
> port is mentioned as separate and not like new style
> ---
>
> Key: ZOOKEEPER-2539
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2539
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Rakesh Kumar Singh
>Assignee: Rakesh Kumar Singh
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ConfigUtils.java.patch, ConfigUtils.java.patch, 
> ZOOKEEPER-2539.patch
>
>
> Throwing nullpointerException when run the command "config -c" when client 
> port is mentioned as separate and not like new style
> 1. Configure the zookeeper to start in cluster mode like below-
> clientPort=2181
> server.1=10.18.101.80:2888:3888
> server.2=10.18.219.50:2888:3888
> server.3=10.18.221.194:2888:3888
> and not like below:-
> server.1=10.18.101.80:2888:3888:participant;2181
> server.2=10.18.219.50:2888:3888:participant;2181
> server.3=10.18.221.194:2888:3888:participant;2181
> 2. Start the cluster and one client using >zkCli.sh
> 3. execute command "config -c"
> It is throwing nullpointerException:-
> root@BLR110865:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin#
>  ./zkCli.sh 
> Connecting to localhost:2181
> 2016-08-29 21:45:19,558 [myid:] - INFO  [main:Environment@109] - Client 
> environment:zookeeper.version=3.5.1-alpha--1, built on 08/18/2016 08:20 GMT
> 2016-08-29 21:45:19,561 [myid:] - INFO  [main:Environment@109] - Client 
> environment:host.name=BLR110865
> 2016-08-29 21:45:19,562 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.version=1.7.0_17
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.vendor=Oracle Corporation
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.home=/usr/lib/jvm/oracle_jdk7/jre
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.class.path=/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../build/classes:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../build/lib/*.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/slf4j-log4j12-1.7.5.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/slf4j-api-1.7.5.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/servlet-api-2.5-20081211.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/netty-3.7.0.Final.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/log4j-1.2.16.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jline-2.11.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jetty-util-6.1.26.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jetty-6.1.26.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/javacc.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jackson-mapper-asl-1.9.11.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jackson-core-asl-1.9.11.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/commons-cli-1.2.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/ant-eclipse-1.0-jvm1.2.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../zookeeper-3.5.1-alpha.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../src/java/lib/ant-eclipse-1.0-jvm1.2.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../conf:
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.library.path=/usr/java/packages/lib/amd64:/usr/lib64:/lib64:/lib:/usr/lib
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.io.tmpdir=/tmp
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.compiler=
> 2016-08-29 21:45:19,565 [myid:] - INFO  [main:Environment@109] - Client 
> environment:os.name=Linux
> 2016-08-29 21:45:19,565 [myid:] - INFO  [main:Environment@109] - Client 
> environment:os.arch=amd64
> 2016-08-29 21:45:19,565 [myid:] - INFO  [main:Environment@109] - Client 
> environment:os.version=4.4.0-31-generic
> 2016-08-29 21:45:19,565 [myid:] - INFO  [main:Environment@109] - Client 
> environment:user.name=root
> 

[jira] [Commented] (ZOOKEEPER-1962) Add a CLI command to recursively list a znode and children

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472582#comment-15472582
 ] 

Hadoop QA commented on ZOOKEEPER-1962:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12827484/ZOOKEEPER-1962.patch
  against trunk revision 1759735.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 4 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3398//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3398//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3398//console

This message is automatically generated.

> Add a CLI command to recursively list a znode and children
> --
>
> Key: ZOOKEEPER-1962
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1962
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: java client
>Affects Versions: 3.4.6
>Reporter: Gautam Gopalakrishnan
>Assignee: Gautam Gopalakrishnan
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-1962.diff, ZOOKEEPER-1962.patch, 
> ZOOKEEPER-1962.patch, ZOOKEEPER-1962_v2.patch, ZOOKEEPER-1962_v3.patch, 
> ZOOKEEPER-1962_v4.patch, zookeeper-1962_v5.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When troubleshooting applications where znodes can be multiple levels deep  
> (eg. HBase replication), it is handy to see all child znodes recursively 
> rather than run an ls for each node manually.
> So I propose adding an option to the "ls" command (-r) which will list all 
> child nodes under a given znode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-1962 PreCommit Build #3398

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1962
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3398/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 416081 lines...]
 [exec] 
 [exec] +1 tests included.  The patch appears to include 4 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3398//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3398//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3398//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 542ac90477b43b40a865ca366a6f8d7033239c76 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1605:
 exec returned: 1

Total time: 17 minutes 53 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-1962
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472573#comment-15472573
 ] 

Hadoop QA commented on ZOOKEEPER-2218:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12742761/ZOOKEEPER-2218.patch
  against trunk revision 1759735.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3399//console

This message is automatically generated.

> Close IO Streams in finally block
> -
>
> Key: ZOOKEEPER-2218
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2218
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Tang Xinye
>Assignee: Tang Xinye
>Priority: Critical
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2218.patch, ZOOKEEPER-2218.patch
>
>
> The problem here is that if an exception is thrown during the read process 
> the method will exit without closing the stream and hence without releasing 
> the file system resources, it may run out of resources before it does run.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-2218 PreCommit Build #3399

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2218
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3399/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 97 lines...]
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12742761/ZOOKEEPER-2218.patch
 [exec]   against trunk revision 1759735.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3399//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 451e8ad6238ba6c4551bd2ec9de4998c95e4add8 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1605:
 exec returned: 1

Total time: 44 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2218
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Updated] (ZOOKEEPER-2218) Close IO Streams in finally block

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2218:

Assignee: Tang Xinye

> Close IO Streams in finally block
> -
>
> Key: ZOOKEEPER-2218
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2218
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Tang Xinye
>Assignee: Tang Xinye
>Priority: Critical
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2218.patch, ZOOKEEPER-2218.patch
>
>
> The problem here is that if an exception is thrown during the read process 
> the method will exit without closing the stream and hence without releasing 
> the file system resources, it may run out of resources before it does run.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2368) Client watches are not disconnected on close

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2368:

Fix Version/s: 3.6.0

> Client watches are not disconnected on close
> 
>
> Key: ZOOKEEPER-2368
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2368
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.0, 3.5.0
>Reporter: Timothy Ward
>Assignee: Timothy Ward
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2368.patch
>
>
> If I have a ZooKeeper client connected to an ensemble then obviously I can 
> register watches. 
> If the client is disconnected (for example by a failing ensemble member) then 
> I get a disconnection event for all of my watches. If, on the other hand, my 
> client is closed then I *do not* get a disconnection event. This asymmetry 
> makes it really hard to clear up properly when using the asynchronous API, as 
> there is no way to "fail" data reads/updates when the client is closed.
> I believe that the correct behaviour should be for all watchers to receive a 
> disconnection event when the client is closed. The watchers can then respond 
> as appropriate, and can differentiate between a "server disconnect" and a 
> "client disconnect" by checking the ZooKeeper#getState() method. 
> This would not be a breaking behaviour change as Watchers are already 
> required to handle disconnection events.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2368) Client watches are not disconnected on close

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2368:

Assignee: Timothy Ward

> Client watches are not disconnected on close
> 
>
> Key: ZOOKEEPER-2368
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2368
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.0, 3.5.0
>Reporter: Timothy Ward
>Assignee: Timothy Ward
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2368.patch
>
>
> If I have a ZooKeeper client connected to an ensemble then obviously I can 
> register watches. 
> If the client is disconnected (for example by a failing ensemble member) then 
> I get a disconnection event for all of my watches. If, on the other hand, my 
> client is closed then I *do not* get a disconnection event. This asymmetry 
> makes it really hard to clear up properly when using the asynchronous API, as 
> there is no way to "fail" data reads/updates when the client is closed.
> I believe that the correct behaviour should be for all watchers to receive a 
> disconnection event when the client is closed. The watchers can then respond 
> as appropriate, and can differentiate between a "server disconnect" and a 
> "client disconnect" by checking the ZooKeeper#getState() method. 
> This would not be a breaking behaviour change as Watchers are already 
> required to handle disconnection events.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2537) When provide path for "dataDir" with heading space, it is taking correct path (by trucating space) for snapshot but zookeeper_server.pid is getting created in root (/

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2537:

Fix Version/s: (was: 3.5.2)
   (was: 3.5.1)
   3.6.0
   3.5.3

> When provide path for "dataDir" with heading space, it is taking correct path 
> (by trucating space) for snapshot but zookeeper_server.pid is getting created 
> in root (/) folder
> --
>
> Key: ZOOKEEPER-2537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2537
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Rakesh Kumar Singh
>Assignee: Rakesh Kumar Singh
> Fix For: 3.5.3, 3.6.0
>
> Attachments: zkServer.sh.patch
>
>
> Scenario 1 :-
> When provide path for "dataDir" with heading space, it is taking correct path 
> (by trucating space) for snapshot but zookeeper_server.pid is getting created 
> in root (/) folder
> Steps to reproduce:-
> 1. Configure the dataDir
> dataDir= /home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data
> Here there is a space after dataDir=
> 2. Start Zookeeper Server
> 3. The snapshot is getting created at location mentioned above by truncating 
> the heading space but
> zookeeper_server.pid is getting created at root (/) folder



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2536) When provide path for "dataDir" with trailing space, it is taking correct path (by trucating space) for snapshot but creating temporary file with some junk folder nam

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2536:

Fix Version/s: (was: 3.5.2)
   (was: 3.5.1)
   3.6.0
   3.5.3

> When provide path for "dataDir" with trailing space, it is taking correct 
> path (by trucating space) for snapshot but creating temporary file with some 
> junk folder name for zookeeper_server.pid
> 
>
> Key: ZOOKEEPER-2536
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2536
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Rakesh Kumar Singh
>Assignee: Rakesh Kumar Singh
> Fix For: 3.5.3, 3.6.0
>
> Attachments: zkServer.sh.patch, zkServer.sh.patch
>
>
> Scenario 1:-
> When provide path for "dataDir" with trailing space, it is taking correct 
> path (by trucating space) for snapshot but creating temporary file with some 
> junk folder name for zookeeper_server.pid
> Steps to reproduce:-
> 1. Configure the dataDir
> dataDir=/home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data 
> Here there is a space after /data 
> 2. Start Zookeeper Server
> 3. The snapshot is getting created at location mentioned above by truncating 
> the trailing space but
> one temp folder with junk name (like -> D29D4X~J) is getting created for 
> zookeeper_server.pid
> Scenario 2:-
> When configure the heading and trailing space in above mentioned scenario. 
> the temp folder is getting created in zookeeper/bin folder



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2537) When provide path for "dataDir" with heading space, it is taking correct path (by trucating space) for snapshot but zookeeper_server.pid is getting created in root (/

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2537:

Assignee: Rakesh Kumar Singh

> When provide path for "dataDir" with heading space, it is taking correct path 
> (by trucating space) for snapshot but zookeeper_server.pid is getting created 
> in root (/) folder
> --
>
> Key: ZOOKEEPER-2537
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2537
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Rakesh Kumar Singh
>Assignee: Rakesh Kumar Singh
> Fix For: 3.5.3, 3.6.0
>
> Attachments: zkServer.sh.patch
>
>
> Scenario 1 :-
> When provide path for "dataDir" with heading space, it is taking correct path 
> (by trucating space) for snapshot but zookeeper_server.pid is getting created 
> in root (/) folder
> Steps to reproduce:-
> 1. Configure the dataDir
> dataDir= /home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data
> Here there is a space after dataDir=
> 2. Start Zookeeper Server
> 3. The snapshot is getting created at location mentioned above by truncating 
> the heading space but
> zookeeper_server.pid is getting created at root (/) folder



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2539) Throwing nullpointerException when run the command "config -c" when client port is mentioned as separate and not like new style

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2539:

Fix Version/s: (was: 3.5.2)
   (was: 3.5.1)
   3.6.0
   3.5.3

> Throwing nullpointerException when run the command "config -c" when client 
> port is mentioned as separate and not like new style
> ---
>
> Key: ZOOKEEPER-2539
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2539
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Rakesh Kumar Singh
>Assignee: Rakesh Kumar Singh
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ConfigUtils.java.patch, ConfigUtils.java.patch
>
>
> Throwing nullpointerException when run the command "config -c" when client 
> port is mentioned as separate and not like new style
> 1. Configure the zookeeper to start in cluster mode like below-
> clientPort=2181
> server.1=10.18.101.80:2888:3888
> server.2=10.18.219.50:2888:3888
> server.3=10.18.221.194:2888:3888
> and not like below:-
> server.1=10.18.101.80:2888:3888:participant;2181
> server.2=10.18.219.50:2888:3888:participant;2181
> server.3=10.18.221.194:2888:3888:participant;2181
> 2. Start the cluster and one client using >zkCli.sh
> 3. execute command "config -c"
> It is throwing nullpointerException:-
> root@BLR110865:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin#
>  ./zkCli.sh 
> Connecting to localhost:2181
> 2016-08-29 21:45:19,558 [myid:] - INFO  [main:Environment@109] - Client 
> environment:zookeeper.version=3.5.1-alpha--1, built on 08/18/2016 08:20 GMT
> 2016-08-29 21:45:19,561 [myid:] - INFO  [main:Environment@109] - Client 
> environment:host.name=BLR110865
> 2016-08-29 21:45:19,562 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.version=1.7.0_17
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.vendor=Oracle Corporation
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.home=/usr/lib/jvm/oracle_jdk7/jre
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.class.path=/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../build/classes:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../build/lib/*.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/slf4j-log4j12-1.7.5.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/slf4j-api-1.7.5.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/servlet-api-2.5-20081211.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/netty-3.7.0.Final.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/log4j-1.2.16.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jline-2.11.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jetty-util-6.1.26.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jetty-6.1.26.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/javacc.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jackson-mapper-asl-1.9.11.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jackson-core-asl-1.9.11.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/commons-cli-1.2.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/ant-eclipse-1.0-jvm1.2.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../zookeeper-3.5.1-alpha.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../src/java/lib/ant-eclipse-1.0-jvm1.2.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../conf:
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.library.path=/usr/java/packages/lib/amd64:/usr/lib64:/lib64:/lib:/usr/lib
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.io.tmpdir=/tmp
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.compiler=
> 2016-08-29 21:45:19,565 [myid:] - INFO  [main:Environment@109] - Client 
> environment:os.name=Linux
> 2016-08-29 21:45:19,565 [myid:] - INFO  [main:Environment@109] - Client 
> environment:os.arch=amd64
> 2016-08-29 21:45:19,565 [myid:] - INFO  [main:Environment@109] - Client 
> environment:os.version=4.4.0-31-generic
> 2016-08-29 21:45:19,565 [myid:] - INFO  [main:Environment@109] - Client 
> 

[jira] [Updated] (ZOOKEEPER-2536) When provide path for "dataDir" with trailing space, it is taking correct path (by trucating space) for snapshot but creating temporary file with some junk folder nam

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2536:

Assignee: Rakesh Kumar Singh  (was: Patrick Hunt)

> When provide path for "dataDir" with trailing space, it is taking correct 
> path (by trucating space) for snapshot but creating temporary file with some 
> junk folder name for zookeeper_server.pid
> 
>
> Key: ZOOKEEPER-2536
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2536
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Rakesh Kumar Singh
>Assignee: Rakesh Kumar Singh
> Fix For: 3.5.1, 3.5.2
>
> Attachments: zkServer.sh.patch, zkServer.sh.patch
>
>
> Scenario 1:-
> When provide path for "dataDir" with trailing space, it is taking correct 
> path (by trucating space) for snapshot but creating temporary file with some 
> junk folder name for zookeeper_server.pid
> Steps to reproduce:-
> 1. Configure the dataDir
> dataDir=/home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data 
> Here there is a space after /data 
> 2. Start Zookeeper Server
> 3. The snapshot is getting created at location mentioned above by truncating 
> the trailing space but
> one temp folder with junk name (like -> D29D4X~J) is getting created for 
> zookeeper_server.pid
> Scenario 2:-
> When configure the heading and trailing space in above mentioned scenario. 
> the temp folder is getting created in zookeeper/bin folder



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2536) When provide path for "dataDir" with trailing space, it is taking correct path (by trucating space) for snapshot but creating temporary file with some junk folder nam

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2536:

Assignee: Patrick Hunt

> When provide path for "dataDir" with trailing space, it is taking correct 
> path (by trucating space) for snapshot but creating temporary file with some 
> junk folder name for zookeeper_server.pid
> 
>
> Key: ZOOKEEPER-2536
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2536
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Rakesh Kumar Singh
>Assignee: Patrick Hunt
> Fix For: 3.5.1, 3.5.2
>
> Attachments: zkServer.sh.patch, zkServer.sh.patch
>
>
> Scenario 1:-
> When provide path for "dataDir" with trailing space, it is taking correct 
> path (by trucating space) for snapshot but creating temporary file with some 
> junk folder name for zookeeper_server.pid
> Steps to reproduce:-
> 1. Configure the dataDir
> dataDir=/home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/data 
> Here there is a space after /data 
> 2. Start Zookeeper Server
> 3. The snapshot is getting created at location mentioned above by truncating 
> the trailing space but
> one temp folder with junk name (like -> D29D4X~J) is getting created for 
> zookeeper_server.pid
> Scenario 2:-
> When configure the heading and trailing space in above mentioned scenario. 
> the temp folder is getting created in zookeeper/bin folder



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2539) Throwing nullpointerException when run the command "config -c" when client port is mentioned as separate and not like new style

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2539:

Assignee: Rakesh Kumar Singh

> Throwing nullpointerException when run the command "config -c" when client 
> port is mentioned as separate and not like new style
> ---
>
> Key: ZOOKEEPER-2539
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2539
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Rakesh Kumar Singh
>Assignee: Rakesh Kumar Singh
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ConfigUtils.java.patch, ConfigUtils.java.patch
>
>
> Throwing nullpointerException when run the command "config -c" when client 
> port is mentioned as separate and not like new style
> 1. Configure the zookeeper to start in cluster mode like below-
> clientPort=2181
> server.1=10.18.101.80:2888:3888
> server.2=10.18.219.50:2888:3888
> server.3=10.18.221.194:2888:3888
> and not like below:-
> server.1=10.18.101.80:2888:3888:participant;2181
> server.2=10.18.219.50:2888:3888:participant;2181
> server.3=10.18.221.194:2888:3888:participant;2181
> 2. Start the cluster and one client using >zkCli.sh
> 3. execute command "config -c"
> It is throwing nullpointerException:-
> root@BLR110865:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin#
>  ./zkCli.sh 
> Connecting to localhost:2181
> 2016-08-29 21:45:19,558 [myid:] - INFO  [main:Environment@109] - Client 
> environment:zookeeper.version=3.5.1-alpha--1, built on 08/18/2016 08:20 GMT
> 2016-08-29 21:45:19,561 [myid:] - INFO  [main:Environment@109] - Client 
> environment:host.name=BLR110865
> 2016-08-29 21:45:19,562 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.version=1.7.0_17
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.vendor=Oracle Corporation
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.home=/usr/lib/jvm/oracle_jdk7/jre
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.class.path=/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../build/classes:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../build/lib/*.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/slf4j-log4j12-1.7.5.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/slf4j-api-1.7.5.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/servlet-api-2.5-20081211.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/netty-3.7.0.Final.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/log4j-1.2.16.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jline-2.11.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jetty-util-6.1.26.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jetty-6.1.26.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/javacc.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jackson-mapper-asl-1.9.11.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/jackson-core-asl-1.9.11.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/commons-cli-1.2.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../lib/ant-eclipse-1.0-jvm1.2.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../zookeeper-3.5.1-alpha.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../src/java/lib/ant-eclipse-1.0-jvm1.2.jar:/home/Rakesh/Zookeeper/18_Aug/cluster/zookeeper-3.5.1-alpha/bin/../conf:
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.library.path=/usr/java/packages/lib/amd64:/usr/lib64:/lib64:/lib:/usr/lib
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.io.tmpdir=/tmp
> 2016-08-29 21:45:19,564 [myid:] - INFO  [main:Environment@109] - Client 
> environment:java.compiler=
> 2016-08-29 21:45:19,565 [myid:] - INFO  [main:Environment@109] - Client 
> environment:os.name=Linux
> 2016-08-29 21:45:19,565 [myid:] - INFO  [main:Environment@109] - Client 
> environment:os.arch=amd64
> 2016-08-29 21:45:19,565 [myid:] - INFO  [main:Environment@109] - Client 
> environment:os.version=4.4.0-31-generic
> 2016-08-29 21:45:19,565 [myid:] - INFO  [main:Environment@109] - Client 
> environment:user.name=root
> 2016-08-29 21:45:19,565 [myid:] - INFO  [main:Environment@109] - Client 
> 

[jira] [Updated] (ZOOKEEPER-1962) Add a CLI command to recursively list a znode and children

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-1962:

Attachment: ZOOKEEPER-1962.patch

Handle the nonode case. Added test.

> Add a CLI command to recursively list a znode and children
> --
>
> Key: ZOOKEEPER-1962
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1962
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: java client
>Affects Versions: 3.4.6
>Reporter: Gautam Gopalakrishnan
>Assignee: Gautam Gopalakrishnan
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-1962.diff, ZOOKEEPER-1962.patch, 
> ZOOKEEPER-1962.patch, ZOOKEEPER-1962_v2.patch, ZOOKEEPER-1962_v3.patch, 
> ZOOKEEPER-1962_v4.patch, zookeeper-1962_v5.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When troubleshooting applications where znodes can be multiple levels deep  
> (eg. HBase replication), it is handy to see all child znodes recursively 
> rather than run an ls for each node manually.
> So I propose adding an option to the "ls" command (-r) which will list all 
> child nodes under a given znode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch35_solaris - Build # 238 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_solaris/238/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 436932 lines...]
[junit] 2016-09-08 02:37:41,910 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-09-08 02:37:41,910 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-09-08 02:37:41,911 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-09-08 02:37:41,912 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-09-08 02:37:41,912 [myid:] - INFO  [main:ZooKeeperServer@889] 
- minSessionTimeout set to 6000
[junit] 2016-09-08 02:37:41,912 [myid:] - INFO  [main:ZooKeeperServer@898] 
- maxSessionTimeout set to 6
[junit] 2016-09-08 02:37:41,912 [myid:] - INFO  [main:ZooKeeperServer@159] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test1637389904088749490.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test1637389904088749490.junit.dir/version-2
[junit] 2016-09-08 02:37:41,913 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test1637389904088749490.junit.dir/version-2/snapshot.b
[junit] 2016-09-08 02:37:41,915 [myid:] - INFO  [main:FileTxnSnapLog@298] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test1637389904088749490.junit.dir/version-2/snapshot.b
[junit] 2016-09-08 02:37:41,917 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-09-08 02:37:41,917 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-09-08 02:37:41,917 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:58047
[junit] 2016-09-08 02:37:41,918 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:58047
[junit] 2016-09-08 02:37:41,918 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-09-08 02:37:41,918 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:58047 (no session established for client)
[junit] 2016-09-08 02:37:41,919 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-09-08 02:37:41,920 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-09-08 02:37:41,920 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-09-08 02:37:41,920 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-09-08 02:37:41,921 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-09-08 02:37:41,921 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 18130
[junit] 2016-09-08 02:37:41,921 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-09-08 02:37:41,921 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-09-08 02:37:41,921 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-09-08 02:37:41,992 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x12384a3e73c
[junit] 2016-09-08 02:37:41,992 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x12384a3e73c closed
[junit] 2016-09-08 02:37:41,992 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-09-08 02:37:41,993 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-09-08 02:37:41,993 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-09-08 02:37:41,993 [myid:] - INFO  

[jira] [Commented] (ZOOKEEPER-1962) Add a CLI command to recursively list a znode and children

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472479#comment-15472479
 ] 

Hadoop QA commented on ZOOKEEPER-1962:
--

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12827478/ZOOKEEPER-1962.patch
  against trunk revision 1759719.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 4 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3397//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3397//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3397//console

This message is automatically generated.

> Add a CLI command to recursively list a znode and children
> --
>
> Key: ZOOKEEPER-1962
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1962
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: java client
>Affects Versions: 3.4.6
>Reporter: Gautam Gopalakrishnan
>Assignee: Gautam Gopalakrishnan
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-1962.diff, ZOOKEEPER-1962.patch, 
> ZOOKEEPER-1962_v2.patch, ZOOKEEPER-1962_v3.patch, ZOOKEEPER-1962_v4.patch, 
> zookeeper-1962_v5.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When troubleshooting applications where znodes can be multiple levels deep  
> (eg. HBase replication), it is handy to see all child znodes recursively 
> rather than run an ls for each node manually.
> So I propose adding an option to the "ls" command (-r) which will list all 
> child nodes under a given znode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Success: ZOOKEEPER-1962 PreCommit Build #3397

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1962
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3397/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 447173 lines...]
 [exec]   against trunk revision 1759719.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 4 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3397//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3397//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3397//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 717a0a78e7df28373f3a67d41a8ebe5022432908 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 17 minutes 33 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-1962
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-1962) Add a CLI command to recursively list a znode and children

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472455#comment-15472455
 ] 

Patrick Hunt commented on ZOOKEEPER-1962:
-

Hm. Playing around I noticed another issue:

{noformat}
[zk: localhost:2181(CONNECTED) 17] ls -R /a/b/c/d
/a/b/c/d
[zk: localhost:2181(CONNECTED) 18] ls /a/b/c/d
Node does not exist: /a/b/c/d
{noformat}

> Add a CLI command to recursively list a znode and children
> --
>
> Key: ZOOKEEPER-1962
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1962
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: java client
>Affects Versions: 3.4.6
>Reporter: Gautam Gopalakrishnan
>Assignee: Gautam Gopalakrishnan
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-1962.diff, ZOOKEEPER-1962.patch, 
> ZOOKEEPER-1962_v2.patch, ZOOKEEPER-1962_v3.patch, ZOOKEEPER-1962_v4.patch, 
> zookeeper-1962_v5.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When troubleshooting applications where znodes can be multiple levels deep  
> (eg. HBase replication), it is handy to see all child znodes recursively 
> rather than run an ls for each node manually.
> So I propose adding an option to the "ls" command (-r) which will list all 
> child nodes under a given znode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-1962) Add a CLI command to recursively list a znode and children

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-1962:

Attachment: ZOOKEEPER-1962.patch

I went ahead and updated the patch. Added tests and fixed the issues I now 
about.

> Add a CLI command to recursively list a znode and children
> --
>
> Key: ZOOKEEPER-1962
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1962
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: java client
>Affects Versions: 3.4.6
>Reporter: Gautam Gopalakrishnan
>Assignee: Gautam Gopalakrishnan
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-1962.diff, ZOOKEEPER-1962.patch, 
> ZOOKEEPER-1962_v2.patch, ZOOKEEPER-1962_v3.patch, ZOOKEEPER-1962_v4.patch, 
> zookeeper-1962_v5.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When troubleshooting applications where znodes can be multiple levels deep  
> (eg. HBase replication), it is handy to see all child znodes recursively 
> rather than run an ls for each node manually.
> So I propose adding an option to the "ls" command (-r) which will list all 
> child nodes under a given znode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk-solaris - Build # 1299 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1299/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 440826 lines...]
[junit] 2016-09-08 00:48:12,946 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-09-08 00:48:12,946 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-09-08 00:48:12,947 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-09-08 00:48:12,947 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-09-08 00:48:12,948 [myid:] - INFO  [main:ZooKeeperServer@889] 
- minSessionTimeout set to 6000
[junit] 2016-09-08 00:48:12,948 [myid:] - INFO  [main:ZooKeeperServer@898] 
- maxSessionTimeout set to 6
[junit] 2016-09-08 00:48:12,948 [myid:] - INFO  [main:ZooKeeperServer@159] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test7603026852736207576.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test7603026852736207576.junit.dir/version-2
[junit] 2016-09-08 00:48:12,949 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test7603026852736207576.junit.dir/version-2/snapshot.b
[junit] 2016-09-08 00:48:12,950 [myid:] - INFO  [main:FileTxnSnapLog@298] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test7603026852736207576.junit.dir/version-2/snapshot.b
[junit] 2016-09-08 00:48:12,952 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-09-08 00:48:12,952 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-09-08 00:48:12,952 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:40650
[junit] 2016-09-08 00:48:12,953 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:40650
[junit] 2016-09-08 00:48:12,953 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-09-08 00:48:12,954 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:40650 (no session established for client)
[junit] 2016-09-08 00:48:12,954 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-09-08 00:48:12,955 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-09-08 00:48:12,955 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-09-08 00:48:12,955 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-09-08 00:48:12,956 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-09-08 00:48:12,956 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17855
[junit] 2016-09-08 00:48:12,956 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-09-08 00:48:12,956 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-09-08 00:48:12,956 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-09-08 00:48:13,032 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x123843faa6b closed
[junit] 2016-09-08 00:48:13,032 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-09-08 00:48:13,033 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x123843faa6b
[junit] 2016-09-08 00:48:13,033 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-09-08 00:48:13,033 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-09-08 00:48:13,033 [myid:] - INFO  

ZooKeeper-trunk-openjdk7 - Build # 1155 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1155/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 439249 lines...]
[junit] 2016-09-08 00:38:28,138 [myid:] - INFO  [main:ZooKeeperServer@529] 
- shutting down
[junit] 2016-09-08 00:38:28,138 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-09-08 00:38:28,138 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2016-09-08 00:38:28,138 [myid:] - INFO  
[main:PrepRequestProcessor@965] - Shutting down
[junit] 2016-09-08 00:38:28,138 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2016-09-08 00:38:28,138 [myid:] - INFO  [ProcessThread(sid:0 
cport:13918)::PrepRequestProcessor@154] - PrepRequestProcessor exited loop!
[junit] 2016-09-08 00:38:28,138 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2016-09-08 00:38:28,139 [myid:] - INFO  
[main:FinalRequestProcessor@479] - shutdown of request processor complete
[junit] 2016-09-08 00:38:28,139 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port13918,name1=InMemoryDataTree]
[junit] 2016-09-08 00:38:28,140 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port13918]
[junit] 2016-09-08 00:38:28,140 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 13918
[junit] 2016-09-08 00:38:28,141 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-09-08 00:38:28,262 [myid:] - INFO  [main:ClientBase@466] - 
STARTING server
[junit] 2016-09-08 00:38:28,263 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:13918
[junit] 2016-09-08 00:38:28,263 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 32 worker threads, and 64 
kB direct buffers.
[junit] 2016-09-08 00:38:28,263 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:13918
[junit] 2016-09-08 00:38:28,264 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:13918
[junit] 2016-09-08 00:38:28,264 [myid:] - INFO  [main:ZooKeeperServer@889] 
- minSessionTimeout set to 6000
[junit] 2016-09-08 00:38:28,264 [myid:] - INFO  [main:ZooKeeperServer@898] 
- maxSessionTimeout set to 6
[junit] 2016-09-08 00:38:28,264 [myid:] - INFO  [main:ZooKeeperServer@159] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/trunk/build/test/tmp/test6717241217497672163.junit.dir/version-2
 snapdir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/trunk/build/test/tmp/test6717241217497672163.junit.dir/version-2
[junit] 2016-09-08 00:38:28,265 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/trunk/build/test/tmp/test6717241217497672163.junit.dir/version-2/snapshot.0
[junit] 2016-09-08 00:38:28,668 [myid:] - INFO  [main:FileTxnSnapLog@298] - 
Snapshotting: 0x2713 to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/trunk/build/test/tmp/test6717241217497672163.junit.dir/version-2/snapshot.2713
[junit] 2016-09-08 00:38:28,865 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-09-08 00:38:28,865 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 13918
[junit] 2016-09-08 00:38:28,866 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:13918:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:53913
[junit] 2016-09-08 00:38:28,867 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:53913
[junit] 2016-09-08 00:38:28,867 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-09-08 00:38:28,868 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:53913 (no session established for client)
[junit] 2016-09-08 00:38:28,869 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-09-08 00:38:28,870 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-09-08 00:38:28,870 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port13918,name1=InMemoryDataTree

[jira] [Commented] (ZOOKEEPER-1962) Add a CLI command to recursively list a znode and children

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472242#comment-15472242
 ] 

Patrick Hunt commented on ZOOKEEPER-1962:
-

I noticed another issue - the default behavior changed. Without this patch 
applied

{noformat}
[zk: localhost:2181(CONNECTED) 0] ls /
[zookeeper]
[zk: localhost:2181(CONNECTED) 1]
{noformat}

however with this patch applied

{noformat}
[zk: localhost:2181(CONNECTED) 0] ls /
[zookeeper][zk: localhost:2181(CONNECTED) 1]
{noformat}



> Add a CLI command to recursively list a znode and children
> --
>
> Key: ZOOKEEPER-1962
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1962
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: java client
>Affects Versions: 3.4.6
>Reporter: Gautam Gopalakrishnan
>Assignee: Gautam Gopalakrishnan
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-1962.diff, ZOOKEEPER-1962_v2.patch, 
> ZOOKEEPER-1962_v3.patch, ZOOKEEPER-1962_v4.patch, zookeeper-1962_v5.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When troubleshooting applications where znodes can be multiple levels deep  
> (eg. HBase replication), it is handy to see all child znodes recursively 
> rather than run an ls for each node manually.
> So I propose adding an option to the "ls" command (-r) which will list all 
> child nodes under a given znode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1962) Add a CLI command to recursively list a znode and children

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472234#comment-15472234
 ] 

Patrick Hunt commented on ZOOKEEPER-1962:
-

bq. Could add one or two more test cases (i.e. list a/f which contains no 
children, and so on) to get more coverage.

agree with that - top level ls for sure, also the leafs, etc... would be good.

> Add a CLI command to recursively list a znode and children
> --
>
> Key: ZOOKEEPER-1962
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1962
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: java client
>Affects Versions: 3.4.6
>Reporter: Gautam Gopalakrishnan
>Assignee: Gautam Gopalakrishnan
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-1962.diff, ZOOKEEPER-1962_v2.patch, 
> ZOOKEEPER-1962_v3.patch, ZOOKEEPER-1962_v4.patch, zookeeper-1962_v5.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When troubleshooting applications where znodes can be multiple levels deep  
> (eg. HBase replication), it is handy to see all child znodes recursively 
> rather than run an ls for each node manually.
> So I propose adding an option to the "ls" command (-r) which will list all 
> child nodes under a given znode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1962) Add a CLI command to recursively list a znode and children

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472228#comment-15472228
 ] 

Patrick Hunt commented on ZOOKEEPER-1962:
-

Hm, doesn't work for me:

{noformat}
[zk: localhost:2181(CONNECTED) 1] ls -R /
/
//zookeeper
Exception in thread "main" java.lang.IllegalArgumentException: Invalid path 
string "//zookeeper" caused by empty node name specified @1
at org.apache.zookeeper.common.PathUtils.validatePath(PathUtils.java:99)
{noformat}


> Add a CLI command to recursively list a znode and children
> --
>
> Key: ZOOKEEPER-1962
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1962
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: java client
>Affects Versions: 3.4.6
>Reporter: Gautam Gopalakrishnan
>Assignee: Gautam Gopalakrishnan
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-1962.diff, ZOOKEEPER-1962_v2.patch, 
> ZOOKEEPER-1962_v3.patch, ZOOKEEPER-1962_v4.patch, zookeeper-1962_v5.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When troubleshooting applications where znodes can be multiple levels deep  
> (eg. HBase replication), it is handy to see all child znodes recursively 
> rather than run an ls for each node manually.
> So I propose adding an option to the "ls" command (-r) which will list all 
> child nodes under a given znode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk-jdk8 - Build # 736 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/736/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 509859 lines...]
[junit] 2016-09-07 23:54:50,464 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2016-09-07 23:54:50,464 [myid:] - INFO  
[main:PrepRequestProcessor@965] - Shutting down
[junit] 2016-09-07 23:54:50,464 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2016-09-07 23:54:50,464 [myid:] - INFO  [ProcessThread(sid:0 
cport:19545)::PrepRequestProcessor@154] - PrepRequestProcessor exited loop!
[junit] 2016-09-07 23:54:50,464 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2016-09-07 23:54:50,465 [myid:] - INFO  
[main:FinalRequestProcessor@479] - shutdown of request processor complete
[junit] 2016-09-07 23:54:50,465 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port19545,name1=InMemoryDataTree]
[junit] 2016-09-07 23:54:50,465 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port19545]
[junit] 2016-09-07 23:54:50,465 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 19545
[junit] 2016-09-07 23:54:50,466 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-09-07 23:54:50,500 [myid:] - INFO  [main:ClientBase@568] - 
fdcount after test is: 4828 at start it was 4832
[junit] 2016-09-07 23:54:50,500 [myid:] - INFO  [main:ZKTestCase$1@65] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2016-09-07 23:54:50,500 [myid:] - INFO  [main:ZKTestCase$1@60] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 101, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
580.677 sec, Thread: 4, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2016-09-07 23:54:50,801 [myid:127.0.0.1:19425] - INFO  
[main-SendThread(127.0.0.1:19425):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:19425. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-09-07 23:54:50,801 [myid:127.0.0.1:19425] - WARN  
[main-SendThread(127.0.0.1:19425):ClientCnxn$SendThread@1235] - Session 
0x200b0e4a687 for server 127.0.0.1/127.0.0.1:19425, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-09-07 23:54:50,870 [myid:127.0.0.1:19301] - INFO  
[main-SendThread(127.0.0.1:19301):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:19301. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-09-07 23:54:50,870 [myid:127.0.0.1:19301] - WARN  
[main-SendThread(127.0.0.1:19301):ClientCnxn$SendThread@1235] - Session 
0x100b0df0ed1 for server 127.0.0.1/127.0.0.1:19301, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-09-07 23:54:50,946 [myid:127.0.0.1:19428] - INFO  
[main-SendThread(127.0.0.1:19428):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:19428. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-09-07 23:54:50,947 [myid:127.0.0.1:19428] - WARN  
[main-SendThread(127.0.0.1:19428):ClientCnxn$SendThread@1235] - Session 
0x300b0e4a5b2 for server 127.0.0.1/127.0.0.1:19428, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-09-07 23:54:50,997 [myid:127.0.0.1:19422] - INFO  
[main-SendThread(127.0.0.1:19422):ClientCnxn$SendThread@1113] - Opening socket 

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[Chris Nauroth (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472171#comment-15472171
 ] 

Chris Nauroth commented on ZOOKEEPER-1045:
--

bq. Recently I find out a feature of KDC that it will treat repeated attempts 
to log in with the same Kerberos principal within a short period of time as 
replay attacks and will reject such login requests.

Yes, excellent point.  FWIW, Hadoop's RPC framework handles this case with a 
brief backoff and retry to work around the case of getting flagged as a replay 
attack.

> Support Quorum Peer mutual authentication via SASL
> --
>
> Key: ZOOKEEPER-1045
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Eugene Koontz
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.10, 3.5.3
>
> Attachments: 0001-ZOOKEEPER-1045-br-3-4.patch, 
> 1045_failing_phunt.tar.gz, HOST_RESOLVER-ZK-1045.patch, 
> TEST-org.apache.zookeeper.server.quorum.auth.QuorumAuthUpgradeTest.txt, 
> ZK-1045-test-case-failure-logs.zip, ZOOKEEPER-1045-00.patch, 
> ZOOKEEPER-1045-Rolling Upgrade Design Proposal.pdf, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045TestValidationDesign.pdf
>
>
> ZOOKEEPER-938 addresses mutual authentication between clients and servers. 
> This bug, on the other hand, is for authentication among quorum peers. 
> Hopefully much of the work done on SASL integration with Zookeeper for 
> ZOOKEEPER-938 can be used as a foundation for this enhancement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[Alexander Shraer (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472023#comment-15472023
 ] 

Alexander Shraer commented on ZOOKEEPER-1045:
-

I personally don't know if there's any issue, I mainly would like to see a 
description of how new servers can be added/removed in terms of authentication. 

> Support Quorum Peer mutual authentication via SASL
> --
>
> Key: ZOOKEEPER-1045
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Eugene Koontz
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.10, 3.5.3
>
> Attachments: 0001-ZOOKEEPER-1045-br-3-4.patch, 
> 1045_failing_phunt.tar.gz, HOST_RESOLVER-ZK-1045.patch, 
> TEST-org.apache.zookeeper.server.quorum.auth.QuorumAuthUpgradeTest.txt, 
> ZK-1045-test-case-failure-logs.zip, ZOOKEEPER-1045-00.patch, 
> ZOOKEEPER-1045-Rolling Upgrade Design Proposal.pdf, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045TestValidationDesign.pdf
>
>
> ZOOKEEPER-938 addresses mutual authentication between clients and servers. 
> This bug, on the other hand, is for authentication among quorum peers. 
> Hopefully much of the work done on SASL integration with Zookeeper for 
> ZOOKEEPER-938 can be used as a foundation for this enhancement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472013#comment-15472013
 ] 

Patrick Hunt commented on ZOOKEEPER-1045:
-

re reconfig that's a great catch. But what are you saying, further weight to 
not use zoo.cfg? Or is there a specific issue you think needs to be addressed 
directly.

> Support Quorum Peer mutual authentication via SASL
> --
>
> Key: ZOOKEEPER-1045
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Eugene Koontz
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.10, 3.5.3
>
> Attachments: 0001-ZOOKEEPER-1045-br-3-4.patch, 
> 1045_failing_phunt.tar.gz, HOST_RESOLVER-ZK-1045.patch, 
> TEST-org.apache.zookeeper.server.quorum.auth.QuorumAuthUpgradeTest.txt, 
> ZK-1045-test-case-failure-logs.zip, ZOOKEEPER-1045-00.patch, 
> ZOOKEEPER-1045-Rolling Upgrade Design Proposal.pdf, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045TestValidationDesign.pdf
>
>
> ZOOKEEPER-938 addresses mutual authentication between clients and servers. 
> This bug, on the other hand, is for authentication among quorum peers. 
> Hopefully much of the work done on SASL integration with Zookeeper for 
> ZOOKEEPER-938 can be used as a foundation for this enhancement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2548) zooInspector does not start on Windows

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472010#comment-15472010
 ] 

Hudson commented on ZOOKEEPER-2548:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3065 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3065/])
ZOOKEEPER-2548: zooInspector does not start on Windows (Arshad Mohammad via 
phunt) (phunt: 
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1759719])
* (edit) trunk/CHANGES.txt
* (edit) trunk/src/contrib/zooinspector/zooInspector.cmd


> zooInspector does not start on Windows
> --
>
> Key: ZOOKEEPER-2548
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2548
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: contrib
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2548-01.patch
>
>
> ZooInspector is very usefully tool but seems its windows scripts are not 
> maintained. 
> zooInspector.cmd commands fails with bellow error:
> {noformat}
> D:\workspace\ZooInspector>zooInspector.cmd
> D:\workspace\ZooInspector>#!/bin/sh
> '#!' is not recognized as an internal or external command,
> operable program or batch file.
> D:\workspace\ZooInspector># Licensed to the Apache Software Foundation (ASF) 
> under one or more
> '#' is not recognized as an internal or external command,
> operable program or batch file.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[Alexander Shraer (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471975#comment-15471975
 ] 

Alexander Shraer commented on ZOOKEEPER-1045:
-

I haven't followed this closely, so I apologize if this was already discussed. 
I'd like to add to what Michael is saying - it would actually be better if we
do support dynamic server addition and removal in this feature, otherwise we're 
introducing two new features in 3.5 and asking the users to choose 
between them. It would be better if new features are compatible with existing 
ones unless there's a very good reason.

> Support Quorum Peer mutual authentication via SASL
> --
>
> Key: ZOOKEEPER-1045
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Eugene Koontz
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.10, 3.5.3
>
> Attachments: 0001-ZOOKEEPER-1045-br-3-4.patch, 
> 1045_failing_phunt.tar.gz, HOST_RESOLVER-ZK-1045.patch, 
> TEST-org.apache.zookeeper.server.quorum.auth.QuorumAuthUpgradeTest.txt, 
> ZK-1045-test-case-failure-logs.zip, ZOOKEEPER-1045-00.patch, 
> ZOOKEEPER-1045-Rolling Upgrade Design Proposal.pdf, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045TestValidationDesign.pdf
>
>
> ZOOKEEPER-938 addresses mutual authentication between clients and servers. 
> This bug, on the other hand, is for authentication among quorum peers. 
> Hopefully much of the work done on SASL integration with Zookeeper for 
> ZOOKEEPER-938 can be used as a foundation for this enhancement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2517) jute.maxbuffer is ignored

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2517:

Priority: Blocker  (was: Critical)

> jute.maxbuffer is ignored
> -
>
> Key: ZOOKEEPER-2517
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2517
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Benjamin Jaton
>Assignee: Arshad Mohammad
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2517-01.patch, ZOOKEEPER-2517.patch
>
>
> In ClientCnxnSocket.java the parsing of the system property is erroneous:
> {code}packetLen = Integer.getInteger(
>   clientConfig.getProperty(ZKConfig.JUTE_MAXBUFFER),
>   ZKClientConfig.CLIENT_MAX_PACKET_LENGTH_DEFAULT
> );{code}
> Javadoc of Integer.getInteger states "The first argument is treated as the 
> name of a system property", whereas here the value of the property is passed.
> Instead I believe the author meant to write something like:
> {code}packetLen = Integer.parseInt(
>   clientConfig.getProperty(
> ZKConfig.JUTE_MAXBUFFER,
> String.valueOf(ZKClientConfig.CLIENT_MAX_PACKET_LENGTH_DEFAULT)
>   )
> );{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2517) jute.maxbuffer is ignored

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471957#comment-15471957
 ] 

Patrick Hunt commented on ZOOKEEPER-2517:
-

[~arshad.mohammad] - do you want to update the patch with Edward's comments?

> jute.maxbuffer is ignored
> -
>
> Key: ZOOKEEPER-2517
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2517
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Benjamin Jaton
>Assignee: Arshad Mohammad
>Priority: Critical
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2517-01.patch, ZOOKEEPER-2517.patch
>
>
> In ClientCnxnSocket.java the parsing of the system property is erroneous:
> {code}packetLen = Integer.getInteger(
>   clientConfig.getProperty(ZKConfig.JUTE_MAXBUFFER),
>   ZKClientConfig.CLIENT_MAX_PACKET_LENGTH_DEFAULT
> );{code}
> Javadoc of Integer.getInteger states "The first argument is treated as the 
> name of a system property", whereas here the value of the property is passed.
> Instead I believe the author meant to write something like:
> {code}packetLen = Integer.parseInt(
>   clientConfig.getProperty(
> ZKConfig.JUTE_MAXBUFFER,
> String.valueOf(ZKClientConfig.CLIENT_MAX_PACKET_LENGTH_DEFAULT)
>   )
> );{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471952#comment-15471952
 ] 

Michael Han commented on ZOOKEEPER-1045:


One more comment regarding authorization part - it seems to me that all the 
information we authorize against is pretty static but with dynamic 
reconfiguration that is not the case. How would we authorize against something 
that is not pre-configured? This is not an immediate issue, though I want to 
raise awareness of this so we can have a solution that is extensible that makes 
it easier to port this to 3.6.

> Support Quorum Peer mutual authentication via SASL
> --
>
> Key: ZOOKEEPER-1045
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Eugene Koontz
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.10, 3.5.3
>
> Attachments: 0001-ZOOKEEPER-1045-br-3-4.patch, 
> 1045_failing_phunt.tar.gz, HOST_RESOLVER-ZK-1045.patch, 
> TEST-org.apache.zookeeper.server.quorum.auth.QuorumAuthUpgradeTest.txt, 
> ZK-1045-test-case-failure-logs.zip, ZOOKEEPER-1045-00.patch, 
> ZOOKEEPER-1045-Rolling Upgrade Design Proposal.pdf, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045TestValidationDesign.pdf
>
>
> ZOOKEEPER-938 addresses mutual authentication between clients and servers. 
> This bug, on the other hand, is for authentication among quorum peers. 
> Hopefully much of the work done on SASL integration with Zookeeper for 
> ZOOKEEPER-938 can be used as a foundation for this enhancement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2517) jute.maxbuffer is ignored

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2517:

Fix Version/s: 3.6.0

> jute.maxbuffer is ignored
> -
>
> Key: ZOOKEEPER-2517
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2517
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Benjamin Jaton
>Assignee: Arshad Mohammad
>Priority: Critical
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2517-01.patch, ZOOKEEPER-2517.patch
>
>
> In ClientCnxnSocket.java the parsing of the system property is erroneous:
> {code}packetLen = Integer.getInteger(
>   clientConfig.getProperty(ZKConfig.JUTE_MAXBUFFER),
>   ZKClientConfig.CLIENT_MAX_PACKET_LENGTH_DEFAULT
> );{code}
> Javadoc of Integer.getInteger states "The first argument is treated as the 
> name of a system property", whereas here the value of the property is passed.
> Instead I believe the author meant to write something like:
> {code}packetLen = Integer.parseInt(
>   clientConfig.getProperty(
> ZKConfig.JUTE_MAXBUFFER,
> String.valueOf(ZKClientConfig.CLIENT_MAX_PACKET_LENGTH_DEFAULT)
>   )
> );{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471930#comment-15471930
 ] 

Michael Han commented on ZOOKEEPER-1045:


bq. This is kind of a side comment on this topic, but please make sure you 
support the case where all the ZK hosts run as the same Kerberos principal. You 
don't have to support only that case, of course, but it's definitely how I 
would be deploying ZK when using Kerb auth.

Recently I find out a feature of KDC that it will treat repeated attempts to 
log in with the same Kerberos principal within a short period of time as replay 
attacks and will reject such login requests. Since we plan to support shared 
Kerberos credential, we might hit this issue. Not sure how likely we will get 
shot but it would be good to have some retry with backup code in login if we 
don't have now in case this happen.

> Support Quorum Peer mutual authentication via SASL
> --
>
> Key: ZOOKEEPER-1045
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Eugene Koontz
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.10, 3.5.3
>
> Attachments: 0001-ZOOKEEPER-1045-br-3-4.patch, 
> 1045_failing_phunt.tar.gz, HOST_RESOLVER-ZK-1045.patch, 
> TEST-org.apache.zookeeper.server.quorum.auth.QuorumAuthUpgradeTest.txt, 
> ZK-1045-test-case-failure-logs.zip, ZOOKEEPER-1045-00.patch, 
> ZOOKEEPER-1045-Rolling Upgrade Design Proposal.pdf, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045TestValidationDesign.pdf
>
>
> ZOOKEEPER-938 addresses mutual authentication between clients and servers. 
> This bug, on the other hand, is for authentication among quorum peers. 
> Hopefully much of the work done on SASL integration with Zookeeper for 
> ZOOKEEPER-938 can be used as a foundation for this enhancement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2548) zooInspector does not start on Windows

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2548:

Fix Version/s: 3.6.0

> zooInspector does not start on Windows
> --
>
> Key: ZOOKEEPER-2548
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2548
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: contrib
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2548-01.patch
>
>
> ZooInspector is very usefully tool but seems its windows scripts are not 
> maintained. 
> zooInspector.cmd commands fails with bellow error:
> {noformat}
> D:\workspace\ZooInspector>zooInspector.cmd
> D:\workspace\ZooInspector>#!/bin/sh
> '#!' is not recognized as an internal or external command,
> operable program or batch file.
> D:\workspace\ZooInspector># Licensed to the Apache Software Foundation (ASF) 
> under one or more
> '#' is not recognized as an internal or external command,
> operable program or batch file.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions

[Edward Ribeiro (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471695#comment-15471695
 ] 

Edward Ribeiro commented on ZOOKEEPER-2557:
---

Chris and Patrick, totally agree with the superset approach across 
3.4->3.5->trunk. Gonna work on that and check inconsistences before uploading 
the new patch asap. Thanks for the feedback! :)

> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
>  Labels: easyfix
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2557-3.4.patch, ZOOKEEPER-2557-3.5.patch, 
> ZOOKEEPER-2557.2.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that 
> the current ZK's {{gitignore}} doesn't account for many spurious types of 
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse, 
> Intellij and NetBeans), among other file extensions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471656#comment-15471656
 ] 

Patrick Hunt commented on ZOOKEEPER-2557:
-

Superset makes sense to me.

> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
>  Labels: easyfix
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2557-3.4.patch, ZOOKEEPER-2557-3.5.patch, 
> ZOOKEEPER-2557.2.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that 
> the current ZK's {{gitignore}} doesn't account for many spurious types of 
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse, 
> Intellij and NetBeans), among other file extensions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions

[Chris Nauroth (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471618#comment-15471618
 ] 

Chris Nauroth commented on ZOOKEEPER-2557:
--

[~eribeiro], I was not able to apply ZOOKEEPER-2557-3.5.patch on branch-3.5.  
However, ZOOKEEPER-2557.2.patch did apply cleanly.  Does it make sense to 
proceed with this, or did you want something specific for branch-3.5?

For the difference on branch-3.4, I noticed that ".idea/" is missing there.  
Would you please add that?

Actually, for ease of maintenance, I think the ideal situation is to make 
.gitignore identical across trunk, branch-3.5 and branch-3.4, containing the 
full superset of all these entries.  That way, future patches won't run into 
merge conflicts.  Let me know your thoughts on this.

> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
>  Labels: easyfix
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2557-3.4.patch, ZOOKEEPER-2557-3.5.patch, 
> ZOOKEEPER-2557.2.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that 
> the current ZK's {{gitignore}} doesn't account for many spurious types of 
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse, 
> Intellij and NetBeans), among other file extensions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (ZOOKEEPER-2080) ReconfigRecoveryTest fails intermittently

[Flavio Junqueira (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471541#comment-15471541
 ] 

Flavio Junqueira edited comment on ZOOKEEPER-2080 at 9/7/16 7:15 PM:
-

[~hanm] [~shralex] [~phunt]

I gave it a look and had a look at the patch, and I'm wondering the following:

# Is it the case that the {{synchronized(self) }} block only needs to cover up 
to {{self.processReconfig}}? If so, perhaps we should end the block there and 
process the following outside. I'm saying this because of a couple of things. 
First, it is in general better to keep such synchronized blocks as short as 
possible. Second, {{shuttingDownLE}} is being used without synchronization in 
other parts of the code, so either that is broken or we don't need it in the 
block.
# Should we invert the order between {{shuttingDownLE}} and {{shutdown()}} to 
avoid a new election being created concurrently? I'd really rather avoid having 
multiple concurrent election objects to avoid confusion about connections and 
such.



was (Author: fpj):
[~hanm] [~shralex] [~phunt]

I gave it a look and had a look at the patch, and I'm wondering the following:

# Is it the case that the {{synchronized(self) }} block only needs to cover up 
to {{self.processReconfig}}? If so, perhaps we should end the block there and 
process the following outside. I'm saying this because of a couple of things. 
First, it is in general better to keep such synchronized blocks as short as 
possible. Second, {{shuttingDownLE}} is being used without synchronization in 
other parts of the code, so either that is broken or we don't need it in the 
block.

# Should we invert the order between {{shuttingDownLE}} and {{shutdown()}} to 
avoid a new election being created concurrently? I'd really rather avoid having 
multiple concurrent election objects to avoid confusion about connections and 
such.


> ReconfigRecoveryTest fails intermittently
> -
>
> Key: ZOOKEEPER-2080
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2080
> Project: ZooKeeper
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Michael Han
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2080.patch, ZOOKEEPER-2080.patch, 
> ZOOKEEPER-2080.patch, ZOOKEEPER-2080.patch, 
> jacoco-ZOOKEEPER-2080.unzip-grows-to-70MB.7z, repro-20150816.log, 
> threaddump.log
>
>
> I got the following test failure on MacBook with trunk code:
> {code}
> Testcase: testCurrentObserverIsParticipantInNewConfig took 93.628 sec
>   FAILED
> waiting for server 2 being up
> junit.framework.AssertionFailedError: waiting for server 2 being up
>   at 
> org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig(ReconfigRecoveryTest.java:529)
>   at 
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2080) ReconfigRecoveryTest fails intermittently

[Flavio Junqueira (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471541#comment-15471541
 ] 

Flavio Junqueira commented on ZOOKEEPER-2080:
-

[~hanm] [~shralex] [~phunt]

I gave it a look and had a look at the patch, and I'm wondering the following:

# Is it the case that the {{synchronized(self) }} block only needs to cover up 
to {{self.processReconfig}}? If so, perhaps we should end the block there and 
process the following outside. I'm saying this because of a couple of things. 
First, it is in general better to keep such synchronized blocks as short as 
possible. Second, {{shuttingDownLE}} is being used without synchronization in 
other parts of the code, so either that is broken or we don't need it in the 
block.
# Should we invert the order between {{shuttingDownLE}} and {{shutdown()}} to 
avoid a new election being created concurrently? I'd really rather avoid having 
multiple concurrent election objects to avoid confusion about connections and 
such.


> ReconfigRecoveryTest fails intermittently
> -
>
> Key: ZOOKEEPER-2080
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2080
> Project: ZooKeeper
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Michael Han
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2080.patch, ZOOKEEPER-2080.patch, 
> ZOOKEEPER-2080.patch, ZOOKEEPER-2080.patch, 
> jacoco-ZOOKEEPER-2080.unzip-grows-to-70MB.7z, repro-20150816.log, 
> threaddump.log
>
>
> I got the following test failure on MacBook with trunk code:
> {code}
> Testcase: testCurrentObserverIsParticipantInNewConfig took 93.628 sec
>   FAILED
> waiting for server 2 being up
> junit.framework.AssertionFailedError: waiting for server 2 being up
>   at 
> org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig(ReconfigRecoveryTest.java:529)
>   at 
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (ZOOKEEPER-2080) ReconfigRecoveryTest fails intermittently

[Flavio Junqueira (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471541#comment-15471541
 ] 

Flavio Junqueira edited comment on ZOOKEEPER-2080 at 9/7/16 7:15 PM:
-

[~hanm] [~shralex] [~phunt]

I gave it a look and had a look at the patch, and I'm wondering the following:

# Is it the case that the {{synchronized(self) }} block only needs to cover up 
to {{self.processReconfig}}? If so, perhaps we should end the block there and 
process the following outside. I'm saying this because of a couple of things. 
First, it is in general better to keep such synchronized blocks as short as 
possible. Second, {{shuttingDownLE}} is being used without synchronization in 
other parts of the code, so either that is broken or we don't need it in the 
block.

# Should we invert the order between {{shuttingDownLE}} and {{shutdown()}} to 
avoid a new election being created concurrently? I'd really rather avoid having 
multiple concurrent election objects to avoid confusion about connections and 
such.



was (Author: fpj):
[~hanm] [~shralex] [~phunt]

I gave it a look and had a look at the patch, and I'm wondering the following:

# Is it the case that the {{synchronized(self) }} block only needs to cover up 
to {{self.processReconfig}}? If so, perhaps we should end the block there and 
process the following outside. I'm saying this because of a couple of things. 
First, it is in general better to keep such synchronized blocks as short as 
possible. Second, {{shuttingDownLE}} is being used without synchronization in 
other parts of the code, so either that is broken or we don't need it in the 
block.
# Should we invert the order between {{shuttingDownLE}} and {{shutdown()}} to 
avoid a new election being created concurrently? I'd really rather avoid having 
multiple concurrent election objects to avoid confusion about connections and 
such.


> ReconfigRecoveryTest fails intermittently
> -
>
> Key: ZOOKEEPER-2080
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2080
> Project: ZooKeeper
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Michael Han
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2080.patch, ZOOKEEPER-2080.patch, 
> ZOOKEEPER-2080.patch, ZOOKEEPER-2080.patch, 
> jacoco-ZOOKEEPER-2080.unzip-grows-to-70MB.7z, repro-20150816.log, 
> threaddump.log
>
>
> I got the following test failure on MacBook with trunk code:
> {code}
> Testcase: testCurrentObserverIsParticipantInNewConfig took 93.628 sec
>   FAILED
> waiting for server 2 being up
> junit.framework.AssertionFailedError: waiting for server 2 being up
>   at 
> org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig(ReconfigRecoveryTest.java:529)
>   at 
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471508#comment-15471508
 ] 

Patrick Hunt commented on ZOOKEEPER-1045:
-

bq. if somebody else owns host2.example.com they can get principals for those 
same service types on their host. At least in our environment

I see. That's very useful information that I wasn't aware of. Thanks Jason.

bq. Kerberos clients typically compute the credential name they expect the 
server to use based on the hostname that the client is connecting to, so folks 
in a Kerberos environment will typically have a functioning name service like 
DNS.

so in this case we'd expect the host names to all match? zoo.cfg/kerberos/dns. 
I think that's reasonable.

[~rakeshr] - is that what you found when looking at the Hadoop code? Your 
comment earlier about "InetAddress.getLocalHost().getCanonicalHostName()" being 
used.

> Support Quorum Peer mutual authentication via SASL
> --
>
> Key: ZOOKEEPER-1045
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Eugene Koontz
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.10, 3.5.3
>
> Attachments: 0001-ZOOKEEPER-1045-br-3-4.patch, 
> 1045_failing_phunt.tar.gz, HOST_RESOLVER-ZK-1045.patch, 
> TEST-org.apache.zookeeper.server.quorum.auth.QuorumAuthUpgradeTest.txt, 
> ZK-1045-test-case-failure-logs.zip, ZOOKEEPER-1045-00.patch, 
> ZOOKEEPER-1045-Rolling Upgrade Design Proposal.pdf, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045TestValidationDesign.pdf
>
>
> ZOOKEEPER-938 addresses mutual authentication between clients and servers. 
> This bug, on the other hand, is for authentication among quorum peers. 
> Hopefully much of the work done on SASL integration with Zookeeper for 
> ZOOKEEPER-938 can be used as a foundation for this enhancement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZOOKEEPER-2562) Safely persist renames of *epoch.tmp to *epoch by issuing fsync on parent directory -- Possible cluster unavailability otherwise

[Ramnatthan Alagappan (JIRA)]

Ramnatthan Alagappan created ZOOKEEPER-2562:
---

 Summary: Safely persist renames of *epoch.tmp to *epoch by issuing 
fsync on parent directory -- Possible cluster unavailability otherwise
 Key: ZOOKEEPER-2562
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2562
 Project: ZooKeeper
  Issue Type: Bug
 Environment: Three node linux cluster
Reporter: Ramnatthan Alagappan
 Fix For: 3.4.7


I am running a three node ZooKeeper cluster. 

Renames of acceptedEpoch.tmp to acceptedEpoch and currentEpoch.tmp to 
currentEpoch have to persisted to disk by explicitly issuing fsync on the 
parent directory. If not, the rename might not hit the disk immediately and if 
a crash occurs at this point, then the server would fail to start with the 
following error in the log. If this happens on two more or nodes, then the 
cluster can become unavailable.   

[myid:] - INFO  [main:QuorumPeerConfig@103] - Reading configuration from: 
/tmp/zoo2.cfg
[myid:] - INFO  [main:QuorumPeer$QuorumServer@149] - Resolved hostname: 
127.0.0.2 to address: /127.0.0.2
[myid:] - INFO  [main:QuorumPeer$QuorumServer@149] - Resolved hostname: 
127.0.0.4 to address: /127.0.0.4
[myid:] - INFO  [main:QuorumPeer$QuorumServer@149] - Resolved hostname: 
127.0.0.3 to address: /127.0.0.3
[myid:] - INFO  [main:QuorumPeerConfig@331] - Defaulting to majority quorums
[myid:1] - INFO  [main:DatadirCleanupManager@78] - autopurge.snapRetainCount 
set to 3
[myid:1] - INFO  [main:DatadirCleanupManager@79] - autopurge.purgeInterval set 
to 0
[myid:1] - INFO  [main:DatadirCleanupManager@101] - Purge task is not scheduled.
[myid:1] - INFO  [main:QuorumPeerMain@127] - Starting quorum peer
[myid:1] - INFO  [main:NIOServerCnxnFactory@89] - binding to port 
0.0.0.0/0.0.0.0:2182
[myid:1] - INFO  [main:QuorumPeer@1019] - tickTime set to 2000
[myid:1] - INFO  [main:QuorumPeer@1039] - minSessionTimeout set to -1
[myid:1] - INFO  [main:QuorumPeer@1050] - maxSessionTimeout set to -1
[myid:1] - INFO  [main:QuorumPeer@1065] - initLimit set to 5
[myid:1] - INFO  [main:FileSnap@83] - Reading snapshot 
/run/shm/dice-4636/113-98-129-z_majority_RO_OM_0=60_1=55/rdir-0/version-2/snapshot.10002
[myid:1] - ERROR [main:QuorumPeer@557] - Unable to load database on disk
java.io.IOException: The accepted epoch, 1 is less than the current epoch, 2
at 
org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:554)
at 
org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:500)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:153)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:111)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:78)
2016-04-15 03:24:57,144 [myid:1] - ERROR [main:QuorumPeerMain@89] - Unexpected 
exception, exiting abnormally
java.lang.RuntimeException: Unable to run quorum server 
at 
org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:558)
at 
org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:500)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:153)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:111)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:78)
Caused by: java.io.IOException: The accepted epoch, 1 is less than the current 
epoch, 2
at 
org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:554)
... 4 more

Similarly, when new log file is created, the parent directory needs be 
explicitly fsynced to persist the log file. Otherwise a data loss might be 
possible (We have reproduced the above issues).  Please see this: 
https://www.quora.com/Linux/When-should-you-fsync-the-containing-directory-in-addition-to-the-file-itself
 and http://research.cs.wisc.edu/wind/Publications/alice-osdi14.pdf. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[Jason Heiss (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471487#comment-15471487
 ] 

Jason Heiss commented on ZOOKEEPER-1045:


Typically with Kerberos principals the bit in front of the slash identifies the 
type of service rather than a specific user. E.g. HTTP/host.example.com is a 
typical principal that would be used for a web server. So the fact that I can 
get credentials for HTTP/host1.example.com does not typically imply that I have 
any control over who gets credentials for HTTP/host2.example.com. Where I work 
we have many thousands of hosts controlled by many different teams, and 
self-service tooling for getting Kerberos credentials. If I own 
host1.example.com I can control who can get HTTP/host1.example.com or 
zookeeper/host1.example.com or whatnot. But if somebody else owns 
host2.example.com they can get principals for those same service types on their 
host. At least in our environment, even if I make up a unique service type like 
"zk1" there is no way for me to limit the ability of others to get 
zk1/ credentials on their hosts.

I think it is reasonable to require that people use hostnames rather than IP 
addresses in zoo.cfg when using Kerberos and to use that as an authorization 
list. Kerberos clients typically compute the credential name they expect the 
server to use based on the hostname that the client is connecting to, so folks 
in a Kerberos environment will typically have a functioning name service like 
DNS.

> Support Quorum Peer mutual authentication via SASL
> --
>
> Key: ZOOKEEPER-1045
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Eugene Koontz
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.10, 3.5.3
>
> Attachments: 0001-ZOOKEEPER-1045-br-3-4.patch, 
> 1045_failing_phunt.tar.gz, HOST_RESOLVER-ZK-1045.patch, 
> TEST-org.apache.zookeeper.server.quorum.auth.QuorumAuthUpgradeTest.txt, 
> ZK-1045-test-case-failure-logs.zip, ZOOKEEPER-1045-00.patch, 
> ZOOKEEPER-1045-Rolling Upgrade Design Proposal.pdf, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045TestValidationDesign.pdf
>
>
> ZOOKEEPER-938 addresses mutual authentication between clients and servers. 
> This bug, on the other hand, is for authentication among quorum peers. 
> Hopefully much of the work done on SASL integration with Zookeeper for 
> ZOOKEEPER-938 can be used as a foundation for this enhancement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471461#comment-15471461
 ] 

Hadoop QA commented on ZOOKEEPER-2557:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12827422/ZOOKEEPER-2557-3.5.patch
  against trunk revision 1757584.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 1 new or modified tests.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3396//console

This message is automatically generated.

> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
>  Labels: easyfix
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2557-3.4.patch, ZOOKEEPER-2557-3.5.patch, 
> ZOOKEEPER-2557.2.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that 
> the current ZK's {{gitignore}} doesn't account for many spurious types of 
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse, 
> Intellij and NetBeans), among other file extensions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-2557 PreCommit Build #3396

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3396/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 94 lines...]
 [exec] 1 out of 1 hunk FAILED -- saving rejects to file .gitignore.rej
 [exec] PATCH APPLICATION FAILED
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12827422/ZOOKEEPER-2557-3.5.patch
 [exec]   against trunk revision 1757584.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 1 new or 
modified tests.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3396//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] c019727aa4e335a3801b77892af4ad6a3cd01280 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1605:
 exec returned: 1

Total time: 51 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2557
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2550) FollowerResyncConcurrencyTest failed in ZooKeeper 3.3.3

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471454#comment-15471454
 ] 

Patrick Hunt commented on ZOOKEEPER-2550:
-

There were a couple of comments on the mailing list:

On Thu, Sep 1, 2016 at 9:35 AM, Michael Han  wrote:
>
> Hi Kang,
>
> Have you checked https://issues.apache.org/jira/browse/ZOOKEEPER-1264 ?
> Could this be related to the errors you saw?


Also

On Sat, Sep 3, 2016 at 9:26 PM, Patrick Hunt  wrote:
> Also there were a number of patches that went into 3.4+ in order to support
> newer versions of Java - given you are on 3.3 you will not be seeing the
> benefit of this.


> FollowerResyncConcurrencyTest failed in ZooKeeper 3.3.3
> ---
>
> Key: ZOOKEEPER-2550
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2550
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: leaderElection, quorum, server, tests
>Affects Versions: 3.3.3
> Environment: Windows 10,
> Java 1.8.0,
> IDEA 2016.1.4,
> JUnit 4.8.1
>Reporter: KangYin
>Priority: Blocker
>  Labels: test
>
>  I'm studying on the Test of ZooKeeper 3.3.3 but got a test failure when I 
> run  _testResyncBySnapThenDiffAfterFollowerCrashes_ in 
> _FollowerResyncConcurrencyTest.java_.
> {quote}
> 2016-09-05 13:57:35,072 - INFO  [main:QuorumBase@307] - FINISHED 
> testResyncBySnapThenDiffAfterFollowerCrashes
> java.util.concurrent.TimeoutException: Did not connect
>   at 
> org.apache.zookeeper.test.ClientBase$CountdownWatcher.waitForConnected(ClientBase.java:119)
>   at 
> org.apache.zookeeper.test.FollowerResyncConcurrencyTest.testResyncBySnapThenDiffAfterFollowerCrashes(FollowerResyncConcurrencyTest.java:95)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at junit.framework.TestCase.runTest(TestCase.java:168)
>   at junit.framework.TestCase.runBare(TestCase.java:134)
>   at junit.framework.TestResult$1.protect(TestResult.java:110)
>   at junit.framework.TestResult.runProtected(TestResult.java:128)
>   at junit.framework.TestResult.run(TestResult.java:113)
>   at junit.framework.TestCase.run(TestCase.java:124)
>   at junit.framework.TestSuite.runTest(TestSuite.java:232)
>   at junit.framework.TestSuite.run(TestSuite.java:227)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
>   at org.junit.runner.JUnitCore.run(JUnitCore.java:157)
>   at 
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:119)
>   at 
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:42)
>   at 
> com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:234)
>   at 
> com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:74)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)
> {quote}
> Which happened in _FollowerResyncConcurrencyTest.java_ at line 92.
> {quote}
> index = (index == 1) ? 2 : 1;
> qu.shutdown(index);
> final ZooKeeper zk3 = new DisconnectableZooKeeper("127.0.0.1:" + 
> qu.getPeer(3).peer.getClientPort(), 1000,watcher3);
> {color:red}watcher3.waitForConnected(CONNECTION_TIMEOUT);{color}
> zk3.create("/mybar", null, ZooDefs.Ids.OPEN_ACL_UNSAFE, 
> CreateMode.EPHEMERAL_SEQUENTIAL);
> {quote}
> I checked the Log Message, and I guess it is probably because of the 
> following ERROR (marked as blue):
> {quote}
> 2016-09-05 13:56:54,928 - INFO  
> [main-SendThread():ClientCnxn$SendThread@1041] - Opening socket connection to 
> server /127.0.0.1:11237
> 2016-09-05 13:56:54,930 - INFO  
> [main-SendThread(127.0.0.1:11237):ClientCnxn$SendThread@949] - Socket 
> connection established to 127.0.0.1/127.0.0.1:11237, initiating session
> 2016-09-05 13:56:54,930 - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11237:NIOServerCnxn$Factory@251] - 
> Accepted socket connection from /127.0.0.1:33566
> 2016-09-05 13:56:54,957 - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11237:NIOServerCnxn@777] - Client 
> attempting to establish new session at /127.0.0.1:33566
>  {color:blue}
> 

[jira] [Updated] (ZOOKEEPER-2557) Update gitignore to account for other file extensions

[Edward Ribeiro (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edward Ribeiro updated ZOOKEEPER-2557:
--
Attachment: ZOOKEEPER-2557-3.5.patch
ZOOKEEPER-2557-3.4.patch

I am attaching additional patches for 3.4 and 3.5 because they were conflicting 
with trunk (ZOOKEEPER-2557.2.patch) and had additional files that are absent 
from gitignore at trunk.

> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
>  Labels: easyfix
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2557-3.4.patch, ZOOKEEPER-2557-3.5.patch, 
> ZOOKEEPER-2557.2.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that 
> the current ZK's {{gitignore}} doesn't account for many spurious types of 
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse, 
> Intellij and NetBeans), among other file extensions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Success: ZOOKEEPER-2557 PreCommit Build #3395

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3395/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 447626 lines...]
 [exec]   against trunk revision 1757584.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 1 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3395//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3395//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3395//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 55bed5b0bbbfdcd7bd50e4079bca44d6e8fa0677 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 17 minutes 35 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2557
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471426#comment-15471426
 ] 

Hadoop QA commented on ZOOKEEPER-2557:
--

+1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12827411/ZOOKEEPER-2557.2.patch
  against trunk revision 1757584.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 1 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3395//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3395//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3395//console

This message is automatically generated.

> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
>  Labels: easyfix
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2557.2.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that 
> the current ZK's {{gitignore}} doesn't account for many spurious types of 
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse, 
> Intellij and NetBeans), among other file extensions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471400#comment-15471400
 ] 

Patrick Hunt commented on ZOOKEEPER-2557:
-

Seems fine to me. I'd recommend committing to the active branches - 
3.4/3.5/trunk. Chris feel free to commit.

> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
>  Labels: easyfix
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2557.2.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that 
> the current ZK's {{gitignore}} doesn't account for many spurious types of 
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse, 
> Intellij and NetBeans), among other file extensions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2557) Update gitignore to account for other file extensions

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2557:

Fix Version/s: 3.6.0
   3.5.3
   3.4.10

> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
>  Labels: easyfix
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2557.2.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that 
> the current ZK's {{gitignore}} doesn't account for many spurious types of 
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse, 
> Intellij and NetBeans), among other file extensions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471390#comment-15471390
 ] 

Patrick Hunt commented on ZOOKEEPER-1045:
-

bq. I have no way to prevent another user from getting Kerberos credentials for 
zk1/badhost.example.com

Hi Jason. Wouldn't you just not provide credentials to anyone (other than 
yourself) for the user zk1 within your realm?

> Support Quorum Peer mutual authentication via SASL
> --
>
> Key: ZOOKEEPER-1045
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Eugene Koontz
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.10, 3.5.3
>
> Attachments: 0001-ZOOKEEPER-1045-br-3-4.patch, 
> 1045_failing_phunt.tar.gz, HOST_RESOLVER-ZK-1045.patch, 
> TEST-org.apache.zookeeper.server.quorum.auth.QuorumAuthUpgradeTest.txt, 
> ZK-1045-test-case-failure-logs.zip, ZOOKEEPER-1045-00.patch, 
> ZOOKEEPER-1045-Rolling Upgrade Design Proposal.pdf, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045TestValidationDesign.pdf
>
>
> ZOOKEEPER-938 addresses mutual authentication between clients and servers. 
> This bug, on the other hand, is for authentication among quorum peers. 
> Hopefully much of the work done on SASL integration with Zookeeper for 
> ZOOKEEPER-938 can be used as a foundation for this enhancement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471378#comment-15471378
 ] 

Patrick Hunt commented on ZOOKEEPER-1045:
-

That's reasonable. How do other systems typically ensure that the code doing 
the authz has knows the  then? They specify the principals on every 
process doing authz? In our case every zk server would need to know the 
principals of all ensemble members? We have the list of servers already in the 
zoo.cfg for example, however the server address can be anything - e.g. ip 
address. Would it make sense to require that the server addresses in zoo.cfg 
match the host used in the principal?

> Support Quorum Peer mutual authentication via SASL
> --
>
> Key: ZOOKEEPER-1045
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Eugene Koontz
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.10, 3.5.3
>
> Attachments: 0001-ZOOKEEPER-1045-br-3-4.patch, 
> 1045_failing_phunt.tar.gz, HOST_RESOLVER-ZK-1045.patch, 
> TEST-org.apache.zookeeper.server.quorum.auth.QuorumAuthUpgradeTest.txt, 
> ZK-1045-test-case-failure-logs.zip, ZOOKEEPER-1045-00.patch, 
> ZOOKEEPER-1045-Rolling Upgrade Design Proposal.pdf, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045TestValidationDesign.pdf
>
>
> ZOOKEEPER-938 addresses mutual authentication between clients and servers. 
> This bug, on the other hand, is for authentication among quorum peers. 
> Hopefully much of the work done on SASL integration with Zookeeper for 
> ZOOKEEPER-938 can be used as a foundation for this enhancement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Issue Comment Deleted] (ZOOKEEPER-2557) Update gitignore to account for other file extensions

[Edward Ribeiro (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edward Ribeiro updated ZOOKEEPER-2557:
--
Comment: was deleted

(was: Forgot --no-prefix.)

> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
>  Labels: easyfix
> Attachments: ZOOKEEPER-2557.2.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that 
> the current ZK's {{gitignore}} doesn't account for many spurious types of 
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse, 
> Intellij and NetBeans), among other file extensions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions

[Chris Nauroth (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471362#comment-15471362
 ] 

Chris Nauroth commented on ZOOKEEPER-2557:
--

[~eribeiro], thank you for the update.  +1 for patch revision 2.  I'll hold off 
committing in case Patrick wants to review again.

> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
>  Labels: easyfix
> Attachments: ZOOKEEPER-2557.2.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that 
> the current ZK's {{gitignore}} doesn't account for many spurious types of 
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse, 
> Intellij and NetBeans), among other file extensions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2557) Update gitignore to account for other file extensions

[Edward Ribeiro (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edward Ribeiro updated ZOOKEEPER-2557:
--
Attachment: ZOOKEEPER-2557.2.patch

Forgot --no-prefix.

> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
>  Labels: easyfix
> Attachments: ZOOKEEPER-2557.2.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that 
> the current ZK's {{gitignore}} doesn't account for many spurious types of 
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse, 
> Intellij and NetBeans), among other file extensions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2557) Update gitignore to account for other file extensions

[Edward Ribeiro (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edward Ribeiro updated ZOOKEEPER-2557:
--
Attachment: (was: ZOOKEEPER-2557.2.patch)

> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
>  Labels: easyfix
> Attachments: ZOOKEEPER-2557.2.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that 
> the current ZK's {{gitignore}} doesn't account for many spurious types of 
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse, 
> Intellij and NetBeans), among other file extensions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2557) Update gitignore to account for other file extensions

[Edward Ribeiro (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edward Ribeiro updated ZOOKEEPER-2557:
--
Attachment: ZOOKEEPER-2557.2.patch

[~phunt], I have double checked svn ignore file list. Most are already in the 
patch, but I have included a few that are not. Please, let me know if there is 
any absence. I will check again later today.

[~cnauroth], I have included the orig and rej files as requested.

Currently the patch applies to trunk only, but the procedure in this project is 
to apply to the early affected version and merge it to the newer ones? If so, 
which one? Thanks!



> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
>  Labels: easyfix
> Attachments: ZOOKEEPER-2557.2.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that 
> the current ZK's {{gitignore}} doesn't account for many spurious types of 
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse, 
> Intellij and NetBeans), among other file extensions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[Jason Heiss (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471350#comment-15471350
 ] 

Jason Heiss commented on ZOOKEEPER-1045:


What [~yoderme] describes would also be a problem in our environment. Let's say 
I decide to use the "user" zk1 for my cluster and thus set up Kerberos 
credentials for zk1/host1.example.com and zk1/host2.example.com. I have no way 
to prevent another user from getting Kerberos credentials for 
zk1/badhost.example.com, and I don't want them to be able to join my cluster. I 
would prefer a way to specify the full credential names for participants that I 
want to allow in my cluster.


> Support Quorum Peer mutual authentication via SASL
> --
>
> Key: ZOOKEEPER-1045
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Eugene Koontz
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.10, 3.5.3
>
> Attachments: 0001-ZOOKEEPER-1045-br-3-4.patch, 
> 1045_failing_phunt.tar.gz, HOST_RESOLVER-ZK-1045.patch, 
> TEST-org.apache.zookeeper.server.quorum.auth.QuorumAuthUpgradeTest.txt, 
> ZK-1045-test-case-failure-logs.zip, ZOOKEEPER-1045-00.patch, 
> ZOOKEEPER-1045-Rolling Upgrade Design Proposal.pdf, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045TestValidationDesign.pdf
>
>
> ZOOKEEPER-938 addresses mutual authentication between clients and servers. 
> This bug, on the other hand, is for authentication among quorum peers. 
> Hopefully much of the work done on SASL integration with Zookeeper for 
> ZOOKEEPER-938 can be used as a foundation for this enhancement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[Mike Yoder (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471331#comment-15471331
 ] 

Mike Yoder commented on ZOOKEEPER-1045:
---

Sorry to be vague, I just meant a principal zookeeper/@realm where 
you didn't intend that principal from the  to be able to join.  There 
is a small hole where if an attacker can somehow get credentials with a 
principal for the desired user but for a different or unintended host, then 
they can talk to the zk servers. But you know this already, and like I said 
this is not a bad tradeoff especially for a first cut.

> Support Quorum Peer mutual authentication via SASL
> --
>
> Key: ZOOKEEPER-1045
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Eugene Koontz
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.10, 3.5.3
>
> Attachments: 0001-ZOOKEEPER-1045-br-3-4.patch, 
> 1045_failing_phunt.tar.gz, HOST_RESOLVER-ZK-1045.patch, 
> TEST-org.apache.zookeeper.server.quorum.auth.QuorumAuthUpgradeTest.txt, 
> ZK-1045-test-case-failure-logs.zip, ZOOKEEPER-1045-00.patch, 
> ZOOKEEPER-1045-Rolling Upgrade Design Proposal.pdf, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045TestValidationDesign.pdf
>
>
> ZOOKEEPER-938 addresses mutual authentication between clients and servers. 
> This bug, on the other hand, is for authentication among quorum peers. 
> Hopefully much of the work done on SASL integration with Zookeeper for 
> ZOOKEEPER-938 can be used as a foundation for this enhancement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471320#comment-15471320
 ] 

Rakesh R commented on ZOOKEEPER-1045:
-

Thanks for the useful discussion and proposal. Comparing only the user and 
realm parts sounds good to me. I'm preparing another patch incorporating the 
same. I hope I will be able to upload new patch by tomorrow(IST).

> Support Quorum Peer mutual authentication via SASL
> --
>
> Key: ZOOKEEPER-1045
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Eugene Koontz
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.10, 3.5.3
>
> Attachments: 0001-ZOOKEEPER-1045-br-3-4.patch, 
> 1045_failing_phunt.tar.gz, HOST_RESOLVER-ZK-1045.patch, 
> TEST-org.apache.zookeeper.server.quorum.auth.QuorumAuthUpgradeTest.txt, 
> ZK-1045-test-case-failure-logs.zip, ZOOKEEPER-1045-00.patch, 
> ZOOKEEPER-1045-Rolling Upgrade Design Proposal.pdf, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045TestValidationDesign.pdf
>
>
> ZOOKEEPER-938 addresses mutual authentication between clients and servers. 
> This bug, on the other hand, is for authentication among quorum peers. 
> Hopefully much of the work done on SASL integration with Zookeeper for 
> ZOOKEEPER-938 can be used as a foundation for this enhancement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZOOKEEPER-2561) CLONE - Possible Cluster Unavailability

[Athyab Ameer (JIRA)]

Athyab Ameer created ZOOKEEPER-2561:
---

 Summary: CLONE - Possible Cluster Unavailability
 Key: ZOOKEEPER-2561
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2561
 Project: ZooKeeper
  Issue Type: Bug
  Components: server
 Environment: Three node linux cluster
Reporter: Athyab Ameer
 Fix For: 3.4.8


Possible Cluster Unvailability

I am running a three node ZooKeeper cluster. Each node runs Linux. 

I see the below sequence of system calls when ZooKeeper appends a user data 
item to the log file.

1 write("/data/version-2/log.20001", offset=65, count=12)
2 write("/data/version-2/log.20001", offset=77, count=16323)
3 write("/data/version-2/log.20001", offset=16400, count=4209)
4 write("/data/version-2/log.20001", offset=20609, count=1)
5 fdatasync("/data//version-2/log.20001")

Now, a crash could happen just after operation 4 but before the final 
fdatasync. In this situation, the file system could persist the 4th operation 
and fail to persist the 3rd operation because of the crash and there is fsync 
in between them. In such cases, ZooKeeper server fails to start with the 
following messages in its log file:

[myid:] - INFO  [main:QuorumPeerConfig@103] - Reading configuration from: 
/tmp/zoo2.cfg
[myid:] - INFO  [main:QuorumPeer$QuorumServer@149] - Resolved hostname: 
127.0.0.2 to address: /127.0.0.2
[myid:] - INFO  [main:QuorumPeer$QuorumServer@149] - Resolved hostname: 
127.0.0.4 to address: /127.0.0.4
[myid:] - INFO  [main:QuorumPeer$QuorumServer@149] - Resolved hostname: 
127.0.0.3 to address: /127.0.0.3
[myid:] - INFO  [main:QuorumPeerConfig@331] - Defaulting to majority quorums
[myid:1] - INFO  [main:DatadirCleanupManager@78] - autopurge.snapRetainCount 
set to 3
[myid:1] - INFO  [main:DatadirCleanupManager@79] - autopurge.purgeInterval set 
to 0
[myid:1] - INFO  [main:DatadirCleanupManager@101] - Purge task is not scheduled.
[myid:1] - INFO  [main:QuorumPeerMain@127] - Starting quorum peer
[myid:1] - INFO  [main:NIOServerCnxnFactory@89] - binding to port 
0.0.0.0/0.0.0.0:2182
[myid:1] - INFO  [main:QuorumPeer@1019] - tickTime set to 2000
[myid:1] - INFO  [main:QuorumPeer@1039] - minSessionTimeout set to -1
[myid:1] - INFO  [main:QuorumPeer@1050] - maxSessionTimeout set to -1
[myid:1] - INFO  [main:QuorumPeer@1065] - initLimit set to 5
[myid:1] - INFO  [main:FileSnap@83] - Reading snapshot 
/data/version-2/snapshot.10002
[myid:1] - ERROR [main:QuorumPeer@557] - Unable to load database on disk
java.io.IOException: CRC check failed
at 
org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.next(FileTxnLog.java:635)
at 
org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:158)
at 
org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:223)
at 
org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:510)
at 
org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:500)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:153)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:111)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:78)
2016-04-15 04:00:32,795 [myid:1] - ERROR [main:QuorumPeerMain@89] - Unexpected 
exception, exiting abnormally
java.lang.RuntimeException: Unable to run quorum server 
at 
org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:558)
at 
org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:500)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:153)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:111)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:78)
Caused by: java.io.IOException: CRC check failed
at 
org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.next(FileTxnLog.java:635)
at 
org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:158)
at 
org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:223)
at 
org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:510)
... 4 more

The same happens when the 3rd and 4th writes hit the disk but the 2nd operation 
does not. 

Now, two nodes of a three node cluster can easily reach this state, rendering 
the entire cluster unavailable. ZooKeeper, on recovery should be able to handle 
such checksum mismatches gracefully to maintain cluster availability.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2552) Revisit release note doc and remove the items which are not related to the released version

[Edward Ribeiro (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edward Ribeiro updated ZOOKEEPER-2552:
--
Attachment: ZOOKEEPER-2552.patch

The patch is up, thanks.

> Revisit release note doc and remove the items which are not related to the 
> released version
> ---
>
> Key: ZOOKEEPER-2552
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2552
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Rakesh R
>Assignee: Edward Ribeiro
> Fix For: 3.4.10
>
> Attachments: ZOOKEEPER-2552.patch, closed.py
>
>
> Couple of issues listed on http://zookeeper.apache.org/
> doc/r3.4.9/releasenotes.html that are either 'Open' or 'Patch available'. For 
> example, issues were wrongly marked as "3.4.8" fix version in jira and has 
> caused the trouble.
> This jira to cross check all the jira issues present in the release note and 
> check the correctness.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch35_solaris - Build # 237 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_solaris/237/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 498690 lines...]
[junit] 2016-09-07 17:26:52,231 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-09-07 17:26:52,231 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-09-07 17:26:52,231 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-09-07 17:26:52,232 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-09-07 17:26:52,232 [myid:] - INFO  [main:ZooKeeperServer@889] 
- minSessionTimeout set to 6000
[junit] 2016-09-07 17:26:52,232 [myid:] - INFO  [main:ZooKeeperServer@898] 
- maxSessionTimeout set to 6
[junit] 2016-09-07 17:26:52,232 [myid:] - INFO  [main:ZooKeeperServer@159] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test8235908172023867882.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test8235908172023867882.junit.dir/version-2
[junit] 2016-09-07 17:26:52,233 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test8235908172023867882.junit.dir/version-2/snapshot.b
[junit] 2016-09-07 17:26:52,234 [myid:] - INFO  [main:FileTxnSnapLog@298] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test8235908172023867882.junit.dir/version-2/snapshot.b
[junit] 2016-09-07 17:26:52,235 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-09-07 17:26:52,236 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-09-07 17:26:52,236 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:55909
[junit] 2016-09-07 17:26:52,236 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:55909
[junit] 2016-09-07 17:26:52,237 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-09-07 17:26:52,237 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:55909 (no session established for client)
[junit] 2016-09-07 17:26:52,237 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-09-07 17:26:52,238 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-09-07 17:26:52,238 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-09-07 17:26:52,239 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-09-07 17:26:52,239 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-09-07 17:26:52,239 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 15826
[junit] 2016-09-07 17:26:52,239 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-09-07 17:26:52,239 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-09-07 17:26:52,239 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-09-07 17:26:52,322 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x12382ab96c0 closed
[junit] 2016-09-07 17:26:52,322 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x12382ab96c0
[junit] 2016-09-07 17:26:52,322 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-09-07 17:26:52,322 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-09-07 17:26:52,322 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-09-07 17:26:52,322 [myid:] - INFO  

[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions

[Edward Ribeiro (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471193#comment-15471193
 ] 

Edward Ribeiro commented on ZOOKEEPER-2557:
---

Thanks for the feedback! :) I am gonna incorporate both suggestions of you 
(nope, I didn't check SVN ignore list, but gonna do this now). If you come up 
with any other inclusion/exclusion I am more than happy to change it. 

> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
>  Labels: easyfix
> Attachments: ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that 
> the current ZK's {{gitignore}} doesn't account for many spurious types of 
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse, 
> Intellij and NetBeans), among other file extensions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471154#comment-15471154
 ] 

Patrick Hunt commented on ZOOKEEPER-1045:
-

[~yoderme] can you expand on "rogue" comment? The ZK server process will have 
to have access to a valid "zookeeper ensemble X participant in the specified 
realm" credential regardless. (where X can be a specific ensemble)

> Support Quorum Peer mutual authentication via SASL
> --
>
> Key: ZOOKEEPER-1045
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Eugene Koontz
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.10, 3.5.3
>
> Attachments: 0001-ZOOKEEPER-1045-br-3-4.patch, 
> 1045_failing_phunt.tar.gz, HOST_RESOLVER-ZK-1045.patch, 
> TEST-org.apache.zookeeper.server.quorum.auth.QuorumAuthUpgradeTest.txt, 
> ZK-1045-test-case-failure-logs.zip, ZOOKEEPER-1045-00.patch, 
> ZOOKEEPER-1045-Rolling Upgrade Design Proposal.pdf, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045TestValidationDesign.pdf
>
>
> ZOOKEEPER-938 addresses mutual authentication between clients and servers. 
> This bug, on the other hand, is for authentication among quorum peers. 
> Hopefully much of the work done on SASL integration with Zookeeper for 
> ZOOKEEPER-938 can be used as a foundation for this enhancement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471142#comment-15471142
 ] 

Patrick Hunt commented on ZOOKEEPER-2557:
-

Hi Edward, this makes sense. Thanks. One question though, did you compare what 
we have ignored in svn to your new list? Perhaps you could review and ensure 
that everything we have in svn is replicated in git? I see the following:


svn propget -R svn:ignore .
. - build
.revision
.settings
.eclipse
.classpath
.project

src/c - *generated*
.cproject
.project

src/c/src - .dirstamp

src/java - .classpath
.project
generated
bin

src/java/lib - ivy-*.jar
ant-eclipse-*.jar

src/java/test - .classpath
.project

> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
>  Labels: easyfix
> Attachments: ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that 
> the current ZK's {{gitignore}} doesn't account for many spurious types of 
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse, 
> Intellij and NetBeans), among other file extensions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (ZOOKEEPER-2557) Update gitignore to account for other file extensions

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471142#comment-15471142
 ] 

Patrick Hunt edited comment on ZOOKEEPER-2557 at 9/7/16 5:00 PM:
-

Hi Edward, this makes sense. Thanks. One question though, did you compare what 
we have ignored in svn to your new list? Perhaps you could review and ensure 
that everything we have in svn is replicated in git? I see the following:


{noformat}
svn propget -R svn:ignore .
. - build
.revision
.settings
.eclipse
.classpath
.project

src/c - *generated*
.cproject
.project

src/c/src - .dirstamp

src/java - .classpath
.project
generated
bin

src/java/lib - ivy-*.jar
ant-eclipse-*.jar

src/java/test - .classpath
.project
{noformat}



was (Author: phunt):
Hi Edward, this makes sense. Thanks. One question though, did you compare what 
we have ignored in svn to your new list? Perhaps you could review and ensure 
that everything we have in svn is replicated in git? I see the following:


svn propget -R svn:ignore .
. - build
.revision
.settings
.eclipse
.classpath
.project

src/c - *generated*
.cproject
.project

src/c/src - .dirstamp

src/java - .classpath
.project
generated
bin

src/java/lib - ivy-*.jar
ant-eclipse-*.jar

src/java/test - .classpath
.project

> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
>  Labels: easyfix
> Attachments: ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that 
> the current ZK's {{gitignore}} doesn't account for many spurious types of 
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse, 
> Intellij and NetBeans), among other file extensions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions

[Chris Nauroth (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471138#comment-15471138
 ] 

Chris Nauroth commented on ZOOKEEPER-2557:
--

[~eribeiro], thank you for doing this.  As an emacs user, thanks very much for 
adding "*~"!  :-)

While we're editing this, how about also adding "*.orig" and "*.rej"?  These 
are the files left behind by the patch command when it fails to apply the patch 
file cleanly.

bq. My only concern here is if .class, .ear, .war and .jar files should be 
included or not in the gitignore file.

I'd prefer to leave those out.  We do have a couple of jars checked in:

{code}
> find . -name '*.jar'
./src/contrib/zooinspector/lib/jtoaster-1.0.4.jar
./src/java/lib/ivy-2.4.0.jar
{code}

I'd expect built binary artifacts to be fully covered by one of the other 
rules, like "build/".

> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
>  Labels: easyfix
> Attachments: ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that 
> the current ZK's {{gitignore}} doesn't account for many spurious types of 
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse, 
> Intellij and NetBeans), among other file extensions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [VOTE] move Apache Zookeeper to git

[Chris Nauroth]

Thank you for doing this, Eddie.  I just picked up the code review.

--Chris Nauroth

On 9/7/16, 9:49 AM, "Edward Ribeiro"  wrote:

Hey folks, as part of this major change, I took a look at the gitignore and
it already lacks a lot of file extensions for a modern Java project.
Therefore, I created a trivial patch (shameless plug) that updates for more
commonly extensions:  https://issues.apache.org/jira/browse/ZOOKEEPER-2557

Could you please review it and (the committers) this incorporated into
branches before the transition if everything is alright, whenever you have
time? The final gitignore doesn't look particularly big and cover only
mostly the common IDE extensions and temporary files.

Cheers,
Eddie


On Wed, Sep 7, 2016 at 7:31 AM, Flavio Junqueira  wrote:

> +1
>
> > On 07 Sep 2016, at 06:10, Patrick Hunt  wrote:
> >
> > Quick update (more details on the INFRA jira). It might take upwards of
> 24
> > hours to do the svn->git migration although our repo isn't that large,
> > likely less. INFRA can do it, for example, on Saturday around 18:00 UTC.
> > Any concerns with such an approach?
> >
> > Patrick
> >
> > On Sun, Sep 4, 2016 at 9:20 PM, Patrick Hunt  wrote:
> >
> >> Follow along here: https://issues.apache.org/jira/browse/INFRA-12573
> >>
> >> Patrick
> >>
> >> On Sun, Sep 4, 2016 at 8:33 AM, Benjamin Reed  wrote:
> >>
> >>> with 10 votes for (5 of which are from the PMC) on no votes against.
> the
> >>> vote passes.
> >>>
> >>> pat please make git happen! :)
> >>>
> >>> thanx for voting!
> >>>
> >>> On Thu, Sep 1, 2016 at 9:25 AM, Michael Han  wrote:
> >>>
>  +1
> 
>  On Thu, Sep 1, 2016 at 6:08 AM, Michelle Tan 
> >>> wrote:
> 
> > +1
> >
> > On Thu, Sep 1, 2016 at 2:01 PM, Flavio Junqueira 
> >>> wrote:
> >
> >> +1
> >>
> >>> On 01 Sep 2016, at 13:28, Edward Ribeiro <
> >>> edward.ribe...@gmail.com>
> >> wrote:
> >>>
> >>> +1 (non binding)
> >>>
> >>> On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman <
> >> jor...@jordanzimmerman.com
>  wrote:
> >>>
>  +1 (non binding)
> 
> > On Aug 31, 2016, at 8:29 PM, Benjamin Reed 
>  wrote:
> >
> > flip the switch to git and update the relevant scripts and docs.
> >
> > i couldn't figure out which timeframe this falls under in the
>  voting
> > procedure table, but i think it's safe to go with 3 days, so the
>  vote
>  will
> > close on Saturday, September 3 at 6:30pm pdt.
> >
> > +1 from me
> 
> 
> >>
> >>
> >
> 
> 
> 
>  --
>  Cheers
>  Michael.
> 
> >>>
> >>
> >>
>
>

Re: ZooKeeper Sync API path parameter does not have any impact.

[Chris Nauroth]

Yes, the sync operation really applies to the client’s entire view of ZooKeeper 
state, not a specific path or sub-tree, so I would not expect to see any 
significant difference in time for sync(/path1) vs. sync(/path2).  The presence 
of the path is only a client API convenience.

Expanding a bit on what Flavio already said, the reason a client calls sync is 
often because it wants to read up-to-date state for a specific path.  If an 
application is doing this kind of logic for multiple paths, then it can check 
the path in AsyncCallback.VoidCallback#processResult and know that this is a 
completed sync in preparation for reading /path1 vs. /path2.

I woudn’t expect any of this to influence execution time of the sync operation 
though.  If you do see a difference in execution time, then that’s likely just 
a coincidence.  (Maybe it’s just a coincidence that there was more write 
activity at the time of calling sync(/path1) vs. sync(/path2), and therefore 
one of those sync calls needed to do more work to catch up with all of the 
transactions.)

--Chris Nauroth

On 9/7/16, 8:47 AM, "Mohammad arshad"  wrote:

So path is completely for ZooKeeper client. It has nothing to do with 
server. Therefore whether I execute sync /path1 or sync /path2, sync request 
will complete in the same time. right?

-Arshad
-Original Message-
From: Flavio Junqueira [mailto:f...@apache.org] 
Sent: 07 September 2016 16:45
To: u...@zookeeper.apache.org
Cc: dev@zookeeper.apache.org
Subject: Re: ZooKeeper Sync API path parameter does not have any impact.

The path parameter helps the app determine the path that the response is 
referring to. A sync call is typically associated to a read request to a given 
path, so the path in the sync call helps the application make the association 
to that path.

-Flavio

> On 07 Sep 2016, at 11:35, Mohammad arshad  
wrote:
> 
> Hello Everyone
> ZooKeeper sync API takes a path argument.
> But it seems this path is no where used in the server code. Same path is 
returned from the server to client again in SyncResponse.
> Is the any other purpose of sync API path parameter.
> Will there be any different impact for below sync commands form zk Cli?
> sync /path1
> sync /path2
> 
> Thanks
> -Arshad

Re: [VOTE] move Apache Zookeeper to git

[Edward Ribeiro]

Hey folks, as part of this major change, I took a look at the gitignore and
it already lacks a lot of file extensions for a modern Java project.
Therefore, I created a trivial patch (shameless plug) that updates for more
commonly extensions:  https://issues.apache.org/jira/browse/ZOOKEEPER-2557

Could you please review it and (the committers) this incorporated into
branches before the transition if everything is alright, whenever you have
time? The final gitignore doesn't look particularly big and cover only
mostly the common IDE extensions and temporary files.

Cheers,
Eddie


On Wed, Sep 7, 2016 at 7:31 AM, Flavio Junqueira  wrote:

> +1
>
> > On 07 Sep 2016, at 06:10, Patrick Hunt  wrote:
> >
> > Quick update (more details on the INFRA jira). It might take upwards of
> 24
> > hours to do the svn->git migration although our repo isn't that large,
> > likely less. INFRA can do it, for example, on Saturday around 18:00 UTC.
> > Any concerns with such an approach?
> >
> > Patrick
> >
> > On Sun, Sep 4, 2016 at 9:20 PM, Patrick Hunt  wrote:
> >
> >> Follow along here: https://issues.apache.org/jira/browse/INFRA-12573
> >>
> >> Patrick
> >>
> >> On Sun, Sep 4, 2016 at 8:33 AM, Benjamin Reed  wrote:
> >>
> >>> with 10 votes for (5 of which are from the PMC) on no votes against.
> the
> >>> vote passes.
> >>>
> >>> pat please make git happen! :)
> >>>
> >>> thanx for voting!
> >>>
> >>> On Thu, Sep 1, 2016 at 9:25 AM, Michael Han  wrote:
> >>>
>  +1
> 
>  On Thu, Sep 1, 2016 at 6:08 AM, Michelle Tan 
> >>> wrote:
> 
> > +1
> >
> > On Thu, Sep 1, 2016 at 2:01 PM, Flavio Junqueira 
> >>> wrote:
> >
> >> +1
> >>
> >>> On 01 Sep 2016, at 13:28, Edward Ribeiro <
> >>> edward.ribe...@gmail.com>
> >> wrote:
> >>>
> >>> +1 (non binding)
> >>>
> >>> On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman <
> >> jor...@jordanzimmerman.com
>  wrote:
> >>>
>  +1 (non binding)
> 
> > On Aug 31, 2016, at 8:29 PM, Benjamin Reed 
>  wrote:
> >
> > flip the switch to git and update the relevant scripts and docs.
> >
> > i couldn't figure out which timeframe this falls under in the
>  voting
> > procedure table, but i think it's safe to go with 3 days, so the
>  vote
>  will
> > close on Saturday, September 3 at 6:30pm pdt.
> >
> > +1 from me
> 
> 
> >>
> >>
> >
> 
> 
> 
>  --
>  Cheers
>  Michael.
> 
> >>>
> >>
> >>
>
>

[jira] [Commented] (ZOOKEEPER-2355) Ephemeral node is never deleted if follower fails while reading the proposal packet

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471012#comment-15471012
 ] 

Rakesh R commented on ZOOKEEPER-2355:
-

sure, while committing will target branches {{3.4}}, {{3.5}} and trunk.

> Ephemeral node is never deleted if follower fails while reading the proposal 
> packet
> ---
>
> Key: ZOOKEEPER-2355
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2355
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: quorum, server
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Critical
> Fix For: 3.4.10, 3.5.3
>
> Attachments: ZOOKEEPER-2355-01.patch, ZOOKEEPER-2355-02.patch, 
> ZOOKEEPER-2355-03.patch, ZOOKEEPER-2355-04.patch
>
>
> ZooKeeper ephemeral node is never deleted if follower fail while reading the 
> proposal packet
> The scenario is as follows:
> # Configure three node ZooKeeper cluster, lets say nodes are A, B and C, 
> start all, assume A is leader, B and C are follower
> # Connect to any of the server and create ephemeral node /e1
> # Close the session, ephemeral node /e1 will go for deletion
> # While receiving delete proposal make Follower B to fail with 
> {{SocketTimeoutException}}. This we need to do to reproduce the scenario 
> otherwise in production environment it happens because of network fault.
> # Remove the fault, just check that faulted Follower is now connected with 
> quorum
> # Connect to any of the server, create the same ephemeral node /e1, created 
> is success.
> # Close the session,  ephemeral node /e1 will go for deletion
> # {color:red}/e1 is not deleted from the faulted Follower B, It should have 
> been deleted as it was again created with another session{color}
> # {color:green}/e1 is deleted from Leader A and other Follower C{color}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

RE: ZooKeeper Sync API path parameter does not have any impact.

[Mohammad arshad]

So path is completely for ZooKeeper client. It has nothing to do with server. 
Therefore whether I execute sync /path1 or sync /path2, sync request will 
complete in the same time. right?

-Arshad
-Original Message-
From: Flavio Junqueira [mailto:f...@apache.org] 
Sent: 07 September 2016 16:45
To: u...@zookeeper.apache.org
Cc: dev@zookeeper.apache.org
Subject: Re: ZooKeeper Sync API path parameter does not have any impact.

The path parameter helps the app determine the path that the response is 
referring to. A sync call is typically associated to a read request to a given 
path, so the path in the sync call helps the application make the association 
to that path.

-Flavio

> On 07 Sep 2016, at 11:35, Mohammad arshad  wrote:
> 
> Hello Everyone
> ZooKeeper sync API takes a path argument.
> But it seems this path is no where used in the server code. Same path is 
> returned from the server to client again in SyncResponse.
> Is the any other purpose of sync API path parameter.
> Will there be any different impact for below sync commands form zk Cli?
> sync /path1
> sync /path2
> 
> Thanks
> -Arshad

[jira] [Commented] (ZOOKEEPER-2355) Ephemeral node is never deleted if follower fails while reading the proposal packet

[Jordan Zimmerman (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470968#comment-15470968
 ] 

Jordan Zimmerman commented on ZOOKEEPER-2355:
-

FYI - We're on 3.5.x so that's needed as well

> Ephemeral node is never deleted if follower fails while reading the proposal 
> packet
> ---
>
> Key: ZOOKEEPER-2355
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2355
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: quorum, server
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Critical
> Fix For: 3.4.10, 3.5.3
>
> Attachments: ZOOKEEPER-2355-01.patch, ZOOKEEPER-2355-02.patch, 
> ZOOKEEPER-2355-03.patch, ZOOKEEPER-2355-04.patch
>
>
> ZooKeeper ephemeral node is never deleted if follower fail while reading the 
> proposal packet
> The scenario is as follows:
> # Configure three node ZooKeeper cluster, lets say nodes are A, B and C, 
> start all, assume A is leader, B and C are follower
> # Connect to any of the server and create ephemeral node /e1
> # Close the session, ephemeral node /e1 will go for deletion
> # While receiving delete proposal make Follower B to fail with 
> {{SocketTimeoutException}}. This we need to do to reproduce the scenario 
> otherwise in production environment it happens because of network fault.
> # Remove the fault, just check that faulted Follower is now connected with 
> quorum
> # Connect to any of the server, create the same ephemeral node /e1, created 
> is success.
> # Close the session,  ephemeral node /e1 will go for deletion
> # {color:red}/e1 is not deleted from the faulted Follower B, It should have 
> been deleted as it was again created with another session{color}
> # {color:green}/e1 is deleted from Leader A and other Follower C{color}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[Mike Yoder (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470921#comment-15470921
 ] 

Mike Yoder commented on ZOOKEEPER-1045:
---

I'm a little bit concerned about rogue zookeepers... but this is way better 
than nothing, and good enough for a first cut. +1.


> Support Quorum Peer mutual authentication via SASL
> --
>
> Key: ZOOKEEPER-1045
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Eugene Koontz
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.10, 3.5.3
>
> Attachments: 0001-ZOOKEEPER-1045-br-3-4.patch, 
> 1045_failing_phunt.tar.gz, HOST_RESOLVER-ZK-1045.patch, 
> TEST-org.apache.zookeeper.server.quorum.auth.QuorumAuthUpgradeTest.txt, 
> ZK-1045-test-case-failure-logs.zip, ZOOKEEPER-1045-00.patch, 
> ZOOKEEPER-1045-Rolling Upgrade Design Proposal.pdf, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, 
> ZOOKEEPER-1045TestValidationDesign.pdf
>
>
> ZOOKEEPER-938 addresses mutual authentication between clients and servers. 
> This bug, on the other hand, is for authentication among quorum peers. 
> Hopefully much of the work done on SASL integration with Zookeeper for 
> ZOOKEEPER-938 can be used as a foundation for this enhancement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)