[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

[Edward Ribeiro (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567572#comment-15567572
 ] 

Edward Ribeiro commented on ZOOKEEPER-2597:
---

FIY, I have found the message that alludes to the disabled comments: 
http://mail-archives.apache.org/mod_mbox/zookeeper-dev/201610.mbox/%3C3B936EF9-0695-45A9-AA65-8F7347AD0AC1%40apache.org%3E

> Add script to merge PR from Apache git repo to Github
> -
>
> Key: ZOOKEEPER-2597
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2597
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Edward Ribeiro
>Priority: Minor
> Attachments: ZOOKEEPER-2597.patch
>
>
> A port of kafka-merge-pr.py to workon on ZooKeeper repo.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

[Edward Ribeiro (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567544#comment-15567544
 ] 

Edward Ribeiro commented on ZOOKEEPER-2597:
---

[~breed], I left a couple of comments in the PR to guide us. Still grokking 
this script too.

> Add script to merge PR from Apache git repo to Github
> -
>
> Key: ZOOKEEPER-2597
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2597
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Edward Ribeiro
>Priority: Minor
> Attachments: ZOOKEEPER-2597.patch
>
>
> A port of kafka-merge-pr.py to workon on ZooKeeper repo.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

[Benjamin Reed (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567516#comment-15567516
 ] 

Benjamin Reed commented on ZOOKEEPER-2597:
--

cool i opened an infra jira to see if they can turn on the bridging: INFRA-12752

> Add script to merge PR from Apache git repo to Github
> -
>
> Key: ZOOKEEPER-2597
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2597
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Edward Ribeiro
>Priority: Minor
> Attachments: ZOOKEEPER-2597.patch
>
>
> A port of kafka-merge-pr.py to workon on ZooKeeper repo.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

[Edward Ribeiro (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567399#comment-15567399
 ] 

Edward Ribeiro commented on ZOOKEEPER-2597:
---

*AFAIK*, the bridge of GH review comments to JIRA is disabled (by default?). At 
least I remember someone linking a Kafka discussion about that...

> Add script to merge PR from Apache git repo to Github
> -
>
> Key: ZOOKEEPER-2597
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2597
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Edward Ribeiro
>Priority: Minor
> Attachments: ZOOKEEPER-2597.patch
>
>
> A port of kafka-merge-pr.py to workon on ZooKeeper repo.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

[Edward Ribeiro (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edward Ribeiro updated ZOOKEEPER-2597:
--
Assignee: (was: Edward Ribeiro)

> Add script to merge PR from Apache git repo to Github
> -
>
> Key: ZOOKEEPER-2597
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2597
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Edward Ribeiro
>Priority: Minor
> Attachments: ZOOKEEPER-2597.patch
>
>
> A port of kafka-merge-pr.py to workon on ZooKeeper repo.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

[Edward Ribeiro (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567369#comment-15567369
 ] 

Edward Ribeiro edited comment on ZOOKEEPER-2597 at 10/12/16 3:07 AM:
-

Hi Ben, I have been unable to work on this and other issues  lately (few 
weeks). I was hoping to resume work on it today... but... not yet. :(

And I know this script is important to define git based workflow, so feel free 
to take a work on it. :) if you don't mind, I can help you (will start by 
answering the questions on my previous PR).

PS: see that it is a port of *kafka-merge-pr.py* (that, by its turn, is lifted 
off *spark_merge_pr.py*) as so you may want to reference it.

https://github.com/apache/kafka/blob/trunk/kafka-merge-pr.py

https://github.com/apache/spark/blob/master/dev/merge_spark_pr.py



was (Author: eribeiro):
Hi Ben, I have been unable to work on this and other issues  lately (few 
weeks). I was hoping to resume work on it today... but... not yet. :(

And I know this script is important to define git based workflow, so feel free 
to take a stab at it. :)

PS: see that it is a port of kafka-merge.py so you may want to reference it.



> Add script to merge PR from Apache git repo to Github
> -
>
> Key: ZOOKEEPER-2597
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2597
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Minor
> Attachments: ZOOKEEPER-2597.patch
>
>
> A port of kafka-merge-pr.py to workon on ZooKeeper repo.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

[Edward Ribeiro (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567369#comment-15567369
 ] 

Edward Ribeiro commented on ZOOKEEPER-2597:
---

Hi Ben, I have been unable to work on this and other issues  lately (few 
weeks). I was hoping to resume work on it today... but... not yet. :(

And I know this script is important to define git based workflow, so feel free 
to take a stab at it. :)

PS: see that it is a port of kafka-merge.py so you may want to reference it.



> Add script to merge PR from Apache git repo to Github
> -
>
> Key: ZOOKEEPER-2597
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2597
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Minor
> Attachments: ZOOKEEPER-2597.patch
>
>
> A port of kafka-merge-pr.py to workon on ZooKeeper repo.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

[Benjamin Reed (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567338#comment-15567338
 ] 

Benjamin Reed commented on ZOOKEEPER-2597:
--

are you still working on this edward? do you want me to try and implement the 
changes i suggested?

> Add script to merge PR from Apache git repo to Github
> -
>
> Key: ZOOKEEPER-2597
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2597
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Minor
> Attachments: ZOOKEEPER-2597.patch
>
>
> A port of kafka-merge-pr.py to workon on ZooKeeper repo.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch34 - Build # 1684 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34/1684/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 226655 lines...]
[junit] 2016-10-12 00:13:03,973 [myid:] - INFO  [main:ZooKeeperServer@497] 
- shutting down
[junit] 2016-10-12 00:13:03,973 [myid:] - ERROR [main:ZooKeeperServer@472] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-10-12 00:13:03,973 [myid:] - INFO  
[main:SessionTrackerImpl@225] - Shutting down
[junit] 2016-10-12 00:13:03,974 [myid:] - INFO  
[main:PrepRequestProcessor@765] - Shutting down
[junit] 2016-10-12 00:13:03,974 [myid:] - INFO  
[main:SyncRequestProcessor@208] - Shutting down
[junit] 2016-10-12 00:13:03,974 [myid:] - INFO  [ProcessThread(sid:0 
cport:11221)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop!
[junit] 2016-10-12 00:13:03,974 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@186] - SyncRequestProcessor exited!
[junit] 2016-10-12 00:13:03,975 [myid:] - INFO  
[main:FinalRequestProcessor@402] - shutdown of request processor complete
[junit] 2016-10-12 00:13:03,975 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2016-10-12 00:13:03,976 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-10-12 00:13:03,977 [myid:] - INFO  [main:ClientBase@445] - 
STARTING server
[junit] 2016-10-12 00:13:03,977 [myid:] - INFO  [main:ClientBase@366] - 
CREATING server instance 127.0.0.1:11221
[junit] 2016-10-12 00:13:03,978 [myid:] - INFO  
[main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2016-10-12 00:13:03,978 [myid:] - INFO  [main:ClientBase@341] - 
STARTING server instance 127.0.0.1:11221
[junit] 2016-10-12 00:13:03,978 [myid:] - INFO  [main:ZooKeeperServer@173] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/test/tmp/test6532235607435625099.junit.dir/version-2
 snapdir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/test/tmp/test6532235607435625099.junit.dir/version-2
[junit] 2016-10-12 00:13:03,982 [myid:] - ERROR [main:ZooKeeperServer@472] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-10-12 00:13:03,983 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2016-10-12 00:13:03,983 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - 
Accepted socket connection from /127.0.0.1:50280
[junit] 2016-10-12 00:13:03,984 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing 
stat command from /127.0.0.1:50280
[junit] 2016-10-12 00:13:03,984 [myid:] - INFO  
[Thread-5:NIOServerCnxn$StatCommand@663] - Stat command output
[junit] 2016-10-12 00:13:03,984 [myid:] - INFO  
[Thread-5:NIOServerCnxn@1008] - Closed socket connection for client 
/127.0.0.1:50280 (no session established for client)
[junit] 2016-10-12 00:13:03,985 [myid:] - INFO  [main:JMXEnv@229] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-10-12 00:13:03,986 [myid:] - INFO  [main:JMXEnv@246] - 
expect:InMemoryDataTree
[junit] 2016-10-12 00:13:03,986 [myid:] - INFO  [main:JMXEnv@250] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree
[junit] 2016-10-12 00:13:03,987 [myid:] - INFO  [main:JMXEnv@246] - 
expect:StandaloneServer_port
[junit] 2016-10-12 00:13:03,987 [myid:] - INFO  [main:JMXEnv@250] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221
[junit] 2016-10-12 00:13:03,987 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 31167
[junit] 2016-10-12 00:13:03,987 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20
[junit] 2016-10-12 00:13:03,988 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota
[junit] 2016-10-12 00:13:03,988 [myid:] - INFO  [main:ClientBase@522] - 
tearDown starting
[junit] 2016-10-12 00:13:04,056 [myid:] - INFO  [main:ZooKeeper@684] - 
Session: 0x157b63c3dc2 closed
[junit] 2016-10-12 00:13:04,056 [myid:] - INFO  [main:ClientBase@492] - 
STOPPING server
[junit] 2016-10-12 00:13:04,057 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@519] - EventThread shut down for 
session: 0x157b63c3dc2
[junit] 2016-10-12 00:13:04,057 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@219] - 
NIOServerCnxn factory exited run method
[junit] 2016-10-12 00:13:04,057 [myid:] - 

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566912#comment-15566912
 ] 

Michael Han commented on ZOOKEEPER-2014:


Failed tests are known flaky..

> Only admin should be allowed to reconfig a cluster
> --
>
> Key: ZOOKEEPER-2014
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2014
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.0
>Reporter: Raul Gutierrez Segales
>Assignee: Michael Han
>Priority: Blocker
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch
>
>
> ZOOKEEPER-107 introduces reconfiguration support via the reconfig() call. We 
> should, at the very least, ensure that only the Admin can reconfigure a 
> cluster. Perhaps restricting access to /zookeeper/config as well, though this 
> is debatable. Surely one could ensure Admin only access via an ACL, but that 
> would leave everyone who doesn't use ACLs unprotected. We could also force a 
> default ACL to make it a bit more consistent (maybe).
> Finally, making reconfig() only available to Admins means they have to run 
> with zookeeper.DigestAuthenticationProvider.superDigest (which I am not sure 
> if everyone does, or how would it work with other authentication providers). 
> Review board https://reviews.apache.org/r/51546/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566907#comment-15566907
 ] 

Hadoop QA commented on ZOOKEEPER-2014:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12832782/ZOOKEEPER-2014.patch
  against trunk revision f78061aafb19b102c37cb6d744ec6258d5f5b66e.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 45 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3483//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3483//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3483//console

This message is automatically generated.

> Only admin should be allowed to reconfig a cluster
> --
>
> Key: ZOOKEEPER-2014
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2014
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.0
>Reporter: Raul Gutierrez Segales
>Assignee: Michael Han
>Priority: Blocker
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch
>
>
> ZOOKEEPER-107 introduces reconfiguration support via the reconfig() call. We 
> should, at the very least, ensure that only the Admin can reconfigure a 
> cluster. Perhaps restricting access to /zookeeper/config as well, though this 
> is debatable. Surely one could ensure Admin only access via an ACL, but that 
> would leave everyone who doesn't use ACLs unprotected. We could also force a 
> default ACL to make it a bit more consistent (maybe).
> Finally, making reconfig() only available to Admins means they have to run 
> with zookeeper.DigestAuthenticationProvider.superDigest (which I am not sure 
> if everyone does, or how would it work with other authentication providers). 
> Review board https://reviews.apache.org/r/51546/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-2014 PreCommit Build #3483

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2014
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3483/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 491476 lines...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3483//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3483//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3483//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 53af4996fc8bf92373b114502d6de8f07fe6b9f1 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1605: 
exec returned: 1

Total time: 19 minutes 14 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Compressed 552.71 KB of artifacts by 28.9% relative to #3480
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2014
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
2 tests failed.
FAILED:  org.apache.zookeeper.server.ZxidRolloverTest.testRolloverThenRestart

Error Message:
Timeout occurred. Please note the time in the report does not reflect the time 
until the timeout.

Stack Trace:
junit.framework.AssertionFailedError: Timeout occurred. Please note the time in 
the report does not reflect the time until the timeout.
at java.lang.Thread.run(Thread.java:745)


FAILED:  
org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig

Error Message:
waiting for server 4 being up

Stack Trace:
junit.framework.AssertionFailedError: waiting for server 4 being up
at 
org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig(ReconfigRecoveryTest.java:217)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)

Failed: ZOOKEEPER-1932 PreCommit Build #3482

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1932
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3482/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 1108645 lines...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] -1 findbugs.  The patch appears to introduce 1 new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3482//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3482//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3482//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 2856d1eaa43ca0df2d4d1f41a7c397c79c80d4e9 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1605: 
exec returned: 2

Total time: 16 minutes 3 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Compressed 553.86 KB of artifacts by 28.9% relative to #3480
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-1932
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
2 tests failed.
FAILED:  
org.apache.zookeeper.test.ObserverHierarchicalQuorumTest.testHierarchicalQuorum

Error Message:
waiting for server up

Stack Trace:
junit.framework.AssertionFailedError: waiting for server up
at 
org.apache.zookeeper.test.HierarchicalQuorumTest.startServers(HierarchicalQuorumTest.java:233)
at 
org.apache.zookeeper.test.ObserverHierarchicalQuorumTest.startServers(ObserverHierarchicalQuorumTest.java:28)
at 
org.apache.zookeeper.test.HierarchicalQuorumTest.setUp(HierarchicalQuorumTest.java:121)


FAILED:  org.apache.zookeeper.test.TruncateTest.testTruncate

Error Message:
ZooKeeper client can not connect to 127.0.0.1:21996

Stack Trace:
junit.framework.AssertionFailedError: ZooKeeper client can not connect to 
127.0.0.1:21996
at 
org.apache.zookeeper.test.ClientBase.createZKClient(ClientBase.java:703)
at 
org.apache.zookeeper.test.TruncateTest.testTruncate(TruncateTest.java:207)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)

[jira] [Updated] (ZOOKEEPER-1932) org.apache.zookeeper.test.LETest.testLE fails once in a while

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han updated ZOOKEEPER-1932:
---
Attachment: ZOOKEEPER-1932.patch

Patch to remove both deprecated LeaderElection class and associated tests.

> org.apache.zookeeper.test.LETest.testLE fails once in a while
> -
>
> Key: ZOOKEEPER-1932
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1932
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: leaderElection
>Affects Versions: 3.5.0
>Reporter: Michi Mutsuzaki
>Assignee: Flavio Junqueira
> Fix For: 3.6.0
>
> Attachments: TEST-org.apache.zookeeper.test.LETest.txt, 
> ZOOKEEPER-1932.patch, ZOOKEEPER-1932.patch
>
>
> org.apache.zookeeper.test.LETest.testLE is failing on trunk once in a while. 
> I'm not able to reproduce the failure on my box. I looked at the log, but I 
> couldn't quite figure out what's going on. 
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk/2315/testReport/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

[Michael Han]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51546/
---

(Updated Oct. 11, 2016, 10:33 p.m.)


Review request for zookeeper, fpj, Patrick Hunt, Raul Gutierrez Segales, and 
Alexander Shraer.


Changes
---

Fix findbug warnings.


Bugs: ZOOKEEPER-2014
https://issues.apache.org/jira/browse/ZOOKEEPER-2014


Repository: zookeeper-git


Description
---

Address various security concerns around reconfig feature (ZOOKEEPER-2014) to 
unblock 3.5.3 release.


Diffs (updated)
-

  build.xml 5328035 
  src/c/include/zookeeper.h 18a203d 
  src/c/tests/TestReconfigServer.cc 6a429ac 
  src/c/tests/ZooKeeperQuorumServer.h aa8b7cc 
  src/c/tests/ZooKeeperQuorumServer.cc 23392cd 
  src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 5a30da8 
  src/docs/src/documentation/content/xdocs/zookeeperReconfig.xml 7168a01 
  src/java/main/org/apache/zookeeper/ClientCnxn.java 12dd51c 
  src/java/main/org/apache/zookeeper/KeeperException.java a05f1ab 
  src/java/main/org/apache/zookeeper/ZooKeeper.java 1c9ed4e 
  src/java/main/org/apache/zookeeper/ZooKeeperMain.java 25d61a4 
  src/java/main/org/apache/zookeeper/admin/ZooKeeperAdmin.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/cli/CliCommand.java 3d0a90b 
  src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java deb7914 
  src/java/main/org/apache/zookeeper/server/DataTree.java 4666578 
  src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java e275f9c 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 
e772fa8 
  src/java/test/org/apache/zookeeper/TestableZooKeeper.java 4d46fdf 
  src/java/test/org/apache/zookeeper/server/DataTreeTest.java d726643 
  src/java/test/org/apache/zookeeper/server/quorum/ReconfigBackupTest.java 
241af52 
  
src/java/test/org/apache/zookeeper/server/quorum/ReconfigDuringLeaderSyncTest.java
 301837d 
  
src/java/test/org/apache/zookeeper/server/quorum/ReconfigFailureCasesTest.java 
e7147b3 
  src/java/test/org/apache/zookeeper/server/quorum/ReconfigLegacyTest.java 
ee9f2e2 
  src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java 
1f6ce1f 
  src/java/test/org/apache/zookeeper/test/ACLTest.java 9920fc4 
  src/java/test/org/apache/zookeeper/test/ReconfigExceptionTest.java 
PRE-CREATION 
  src/java/test/org/apache/zookeeper/test/ReconfigMisconfigTest.java 
PRE-CREATION 
  src/java/test/org/apache/zookeeper/test/ReconfigTest.java 248a754 
  src/java/test/org/apache/zookeeper/test/StandaloneTest.java 5c95280 

Diff: https://reviews.apache.org/r/51546/diff/


Testing
---

Added new Java unit tests that cover various exception cases of using reconfig 
API without proper set up. 
All existing tests (Java and C) passed under stress tests (minors those known 
flaky tests.).
Manuelly tested reconfig commands using ZooKeeper command line tool.


Thanks,

Michael Han

[jira] [Updated] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han updated ZOOKEEPER-2014:
---
Attachment: ZOOKEEPER-2014.patch

Fix findbug warnings.

> Only admin should be allowed to reconfig a cluster
> --
>
> Key: ZOOKEEPER-2014
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2014
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.0
>Reporter: Raul Gutierrez Segales
>Assignee: Michael Han
>Priority: Blocker
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch
>
>
> ZOOKEEPER-107 introduces reconfiguration support via the reconfig() call. We 
> should, at the very least, ensure that only the Admin can reconfigure a 
> cluster. Perhaps restricting access to /zookeeper/config as well, though this 
> is debatable. Surely one could ensure Admin only access via an ACL, but that 
> would leave everyone who doesn't use ACLs unprotected. We could also force a 
> default ACL to make it a bit more consistent (maybe).
> Finally, making reconfig() only available to Admins means they have to run 
> with zookeeper.DigestAuthenticationProvider.superDigest (which I am not sure 
> if everyone does, or how would it work with other authentication providers). 
> Review board https://reviews.apache.org/r/51546/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-2014 PreCommit Build #3481

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2014
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3481/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 486029 lines...]
 [exec] +1 tests included.  The patch appears to include 45 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] -1 findbugs.  The patch appears to introduce 2 new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3481//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3481//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3481//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] b7e80c9b79f30088818a86f341545a0b7cb07e6e logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1605: 
exec returned: 1

Total time: 21 minutes 42 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2014
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566745#comment-15566745
 ] 

Hadoop QA commented on ZOOKEEPER-2014:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12832770/ZOOKEEPER-2014.patch
  against trunk revision f78061aafb19b102c37cb6d744ec6258d5f5b66e.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 45 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 2 new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3481//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3481//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3481//console

This message is automatically generated.

> Only admin should be allowed to reconfig a cluster
> --
>
> Key: ZOOKEEPER-2014
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2014
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.0
>Reporter: Raul Gutierrez Segales
>Assignee: Michael Han
>Priority: Blocker
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch
>
>
> ZOOKEEPER-107 introduces reconfiguration support via the reconfig() call. We 
> should, at the very least, ensure that only the Admin can reconfigure a 
> cluster. Perhaps restricting access to /zookeeper/config as well, though this 
> is debatable. Surely one could ensure Admin only access via an ACL, but that 
> would leave everyone who doesn't use ACLs unprotected. We could also force a 
> default ACL to make it a bit more consistent (maybe).
> Finally, making reconfig() only available to Admins means they have to run 
> with zookeeper.DigestAuthenticationProvider.superDigest (which I am not sure 
> if everyone does, or how would it work with other authentication providers). 
> Review board https://reviews.apache.org/r/51546/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-1932) org.apache.zookeeper.test.LETest.testLE fails once in a while

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han updated ZOOKEEPER-1932:
---
Fix Version/s: (was: 3.5.3)

> org.apache.zookeeper.test.LETest.testLE fails once in a while
> -
>
> Key: ZOOKEEPER-1932
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1932
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: leaderElection
>Affects Versions: 3.5.0
>Reporter: Michi Mutsuzaki
>Assignee: Flavio Junqueira
> Fix For: 3.6.0
>
> Attachments: TEST-org.apache.zookeeper.test.LETest.txt, 
> ZOOKEEPER-1932.patch
>
>
> org.apache.zookeeper.test.LETest.testLE is failing on trunk once in a while. 
> I'm not able to reproduce the failure on my box. I looked at the log, but I 
> couldn't quite figure out what's going on. 
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk/2315/testReport/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1932) org.apache.zookeeper.test.LETest.testLE fails once in a while

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566695#comment-15566695
 ] 

Michael Han commented on ZOOKEEPER-1932:


[~fpj] Yes removing the class on master branch only sounds good.

> org.apache.zookeeper.test.LETest.testLE fails once in a while
> -
>
> Key: ZOOKEEPER-1932
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1932
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: leaderElection
>Affects Versions: 3.5.0
>Reporter: Michi Mutsuzaki
>Assignee: Flavio Junqueira
> Fix For: 3.6.0
>
> Attachments: TEST-org.apache.zookeeper.test.LETest.txt, 
> ZOOKEEPER-1932.patch
>
>
> org.apache.zookeeper.test.LETest.testLE is failing on trunk once in a while. 
> I'm not able to reproduce the failure on my box. I looked at the log, but I 
> couldn't quite figure out what's going on. 
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk/2315/testReport/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

[Michael Han]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51546/#review152214
---




src/java/main/org/apache/zookeeper/ZooKeeper.java (line 224)


I have to make these public so they can be accessed in ZooKeeperAdmin 
(which is in a different package than ZooKeeper.).

If not doing this, then we can't reuse the existing test infrastructure 
(the TestableZooKeeper and createClient and so on), and the change would be a 
lot more intrusive and tedious.


- Michael Han


On Oct. 11, 2016, 9:32 p.m., Michael Han wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51546/
> ---
> 
> (Updated Oct. 11, 2016, 9:32 p.m.)
> 
> 
> Review request for zookeeper, fpj, Patrick Hunt, Raul Gutierrez Segales, and 
> Alexander Shraer.
> 
> 
> Bugs: ZOOKEEPER-2014
> https://issues.apache.org/jira/browse/ZOOKEEPER-2014
> 
> 
> Repository: zookeeper-git
> 
> 
> Description
> ---
> 
> Address various security concerns around reconfig feature (ZOOKEEPER-2014) to 
> unblock 3.5.3 release.
> 
> 
> Diffs
> -
> 
>   build.xml 5328035 
>   src/c/include/zookeeper.h 18a203d 
>   src/c/tests/TestReconfigServer.cc 6a429ac 
>   src/c/tests/ZooKeeperQuorumServer.h aa8b7cc 
>   src/c/tests/ZooKeeperQuorumServer.cc 23392cd 
>   src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 5a30da8 
>   src/docs/src/documentation/content/xdocs/zookeeperReconfig.xml 7168a01 
>   src/java/main/org/apache/zookeeper/ClientCnxn.java 12dd51c 
>   src/java/main/org/apache/zookeeper/KeeperException.java a05f1ab 
>   src/java/main/org/apache/zookeeper/ZooKeeper.java 1c9ed4e 
>   src/java/main/org/apache/zookeeper/ZooKeeperMain.java 25d61a4 
>   src/java/main/org/apache/zookeeper/admin/ZooKeeperAdmin.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/cli/CliCommand.java 3d0a90b 
>   src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java deb7914 
>   src/java/main/org/apache/zookeeper/server/DataTree.java 4666578 
>   src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java e275f9c 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 
> e772fa8 
>   src/java/test/org/apache/zookeeper/TestableZooKeeper.java 4d46fdf 
>   src/java/test/org/apache/zookeeper/server/DataTreeTest.java d726643 
>   src/java/test/org/apache/zookeeper/server/quorum/ReconfigBackupTest.java 
> 241af52 
>   
> src/java/test/org/apache/zookeeper/server/quorum/ReconfigDuringLeaderSyncTest.java
>  301837d 
>   
> src/java/test/org/apache/zookeeper/server/quorum/ReconfigFailureCasesTest.java
>  e7147b3 
>   src/java/test/org/apache/zookeeper/server/quorum/ReconfigLegacyTest.java 
> ee9f2e2 
>   
> src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java 
> 1f6ce1f 
>   src/java/test/org/apache/zookeeper/test/ACLTest.java 9920fc4 
>   src/java/test/org/apache/zookeeper/test/ReconfigExceptionTest.java 
> PRE-CREATION 
>   src/java/test/org/apache/zookeeper/test/ReconfigMisconfigTest.java 
> PRE-CREATION 
>   src/java/test/org/apache/zookeeper/test/ReconfigTest.java 248a754 
>   src/java/test/org/apache/zookeeper/test/StandaloneTest.java 5c95280 
> 
> Diff: https://reviews.apache.org/r/51546/diff/
> 
> 
> Testing
> ---
> 
> Added new Java unit tests that cover various exception cases of using 
> reconfig API without proper set up. 
> All existing tests (Java and C) passed under stress tests (minors those known 
> flaky tests.).
> Manuelly tested reconfig commands using ZooKeeper command line tool.
> 
> 
> Thanks,
> 
> Michael Han
> 
>

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

[Michael Han]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51546/
---

(Updated Oct. 11, 2016, 9:32 p.m.)


Review request for zookeeper, fpj, Patrick Hunt, Raul Gutierrez Segales, and 
Alexander Shraer.


Changes
---

Patch updated:

1. Consolidate ZooKeeper and ZooKeeperAdmin object usage in CliCommand stack.
2. Fix confusing KeeperException error message when path is set as empty.
3. More documentation on having a consistent setting for the reconfigEnabled 
option across ensemble.


Bugs: ZOOKEEPER-2014
https://issues.apache.org/jira/browse/ZOOKEEPER-2014


Repository: zookeeper-git


Description
---

Address various security concerns around reconfig feature (ZOOKEEPER-2014) to 
unblock 3.5.3 release.


Diffs (updated)
-

  build.xml 5328035 
  src/c/include/zookeeper.h 18a203d 
  src/c/tests/TestReconfigServer.cc 6a429ac 
  src/c/tests/ZooKeeperQuorumServer.h aa8b7cc 
  src/c/tests/ZooKeeperQuorumServer.cc 23392cd 
  src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 5a30da8 
  src/docs/src/documentation/content/xdocs/zookeeperReconfig.xml 7168a01 
  src/java/main/org/apache/zookeeper/ClientCnxn.java 12dd51c 
  src/java/main/org/apache/zookeeper/KeeperException.java a05f1ab 
  src/java/main/org/apache/zookeeper/ZooKeeper.java 1c9ed4e 
  src/java/main/org/apache/zookeeper/ZooKeeperMain.java 25d61a4 
  src/java/main/org/apache/zookeeper/admin/ZooKeeperAdmin.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/cli/CliCommand.java 3d0a90b 
  src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java deb7914 
  src/java/main/org/apache/zookeeper/server/DataTree.java 4666578 
  src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java e275f9c 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 
e772fa8 
  src/java/test/org/apache/zookeeper/TestableZooKeeper.java 4d46fdf 
  src/java/test/org/apache/zookeeper/server/DataTreeTest.java d726643 
  src/java/test/org/apache/zookeeper/server/quorum/ReconfigBackupTest.java 
241af52 
  
src/java/test/org/apache/zookeeper/server/quorum/ReconfigDuringLeaderSyncTest.java
 301837d 
  
src/java/test/org/apache/zookeeper/server/quorum/ReconfigFailureCasesTest.java 
e7147b3 
  src/java/test/org/apache/zookeeper/server/quorum/ReconfigLegacyTest.java 
ee9f2e2 
  src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java 
1f6ce1f 
  src/java/test/org/apache/zookeeper/test/ACLTest.java 9920fc4 
  src/java/test/org/apache/zookeeper/test/ReconfigExceptionTest.java 
PRE-CREATION 
  src/java/test/org/apache/zookeeper/test/ReconfigMisconfigTest.java 
PRE-CREATION 
  src/java/test/org/apache/zookeeper/test/ReconfigTest.java 248a754 
  src/java/test/org/apache/zookeeper/test/StandaloneTest.java 5c95280 

Diff: https://reviews.apache.org/r/51546/diff/


Testing
---

Added new Java unit tests that cover various exception cases of using reconfig 
API without proper set up. 
All existing tests (Java and C) passed under stress tests (minors those known 
flaky tests.).
Manuelly tested reconfig commands using ZooKeeper command line tool.


Thanks,

Michael Han

[jira] [Updated] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han updated ZOOKEEPER-2014:
---
Attachment: ZOOKEEPER-2014.patch

Patch updates:
* Consolidate ZooKeeper and ZooKeeperAdmin object usage in CliCommand stack. 
* Fix confusing KeeperException error message when path is set as empty.
* More documentation on having a consistent setting for the reconfigEnabled 
option across ensemble.

> Only admin should be allowed to reconfig a cluster
> --
>
> Key: ZOOKEEPER-2014
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2014
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.0
>Reporter: Raul Gutierrez Segales
>Assignee: Michael Han
>Priority: Blocker
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch
>
>
> ZOOKEEPER-107 introduces reconfiguration support via the reconfig() call. We 
> should, at the very least, ensure that only the Admin can reconfigure a 
> cluster. Perhaps restricting access to /zookeeper/config as well, though this 
> is debatable. Surely one could ensure Admin only access via an ACL, but that 
> would leave everyone who doesn't use ACLs unprotected. We could also force a 
> default ACL to make it a bit more consistent (maybe).
> Finally, making reconfig() only available to Admins means they have to run 
> with zookeeper.DigestAuthenticationProvider.superDigest (which I am not sure 
> if everyone does, or how would it work with other authentication providers). 
> Review board https://reviews.apache.org/r/51546/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566674#comment-15566674
 ] 

Michael Han commented on ZOOKEEPER-2014:


Yes keeping a single connection is right thing to do. Patch on the way.

> Only admin should be allowed to reconfig a cluster
> --
>
> Key: ZOOKEEPER-2014
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2014
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.0
>Reporter: Raul Gutierrez Segales
>Assignee: Michael Han
>Priority: Blocker
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch
>
>
> ZOOKEEPER-107 introduces reconfiguration support via the reconfig() call. We 
> should, at the very least, ensure that only the Admin can reconfigure a 
> cluster. Perhaps restricting access to /zookeeper/config as well, though this 
> is debatable. Surely one could ensure Admin only access via an ACL, but that 
> would leave everyone who doesn't use ACLs unprotected. We could also force a 
> default ACL to make it a bit more consistent (maybe).
> Finally, making reconfig() only available to Admins means they have to run 
> with zookeeper.DigestAuthenticationProvider.superDigest (which I am not sure 
> if everyone does, or how would it work with other authentication providers). 
> Review board https://reviews.apache.org/r/51546/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk-openjdk7 - Build # 1199 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1199/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 459674 lines...]
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2016-10-11 20:46:45,176 [myid:] - INFO  [New I/O boss 
#18:ClientCnxnSocketNetty@208] - channel is told closing
[junit] 2016-10-11 20:46:45,176 [myid:127.0.0.1:19301] - INFO  
[main-SendThread(127.0.0.1:19301):ClientCnxn$SendThread@1231] - channel for 
sessionid 0x1d38631 is lost, closing socket connection and attempting 
reconnect
[junit] 2016-10-11 20:46:45,346 [myid:] - INFO  [ProcessThread(sid:0 
cport:19545)::PrepRequestProcessor@605] - Processed session termination for 
sessionid: 0x1d9efe4
[junit] 2016-10-11 20:46:45,347 [myid:] - WARN  [New I/O worker 
#3953:NettyServerCnxnFactory$CnxnChannelHandler@142] - Exception caught [id: 
0x0116d95d, /127.0.0.1:59696 :> /127.0.0.1:19545] EXCEPTION: 
java.nio.channels.ClosedChannelException
[junit] java.nio.channels.ClosedChannelException
[junit] at 
sun.nio.ch.SocketChannelImpl.ensureWriteOpen(SocketChannelImpl.java:270)
[junit] at 
sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:479)
[junit] at 
org.jboss.netty.channel.socket.nio.SocketSendBufferPool$UnpooledSendBuffer.transferTo(SocketSendBufferPool.java:203)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioWorker.write0(AbstractNioWorker.java:201)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioWorker.writeFromTaskLoop(AbstractNioWorker.java:151)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioChannel$WriteTask.run(AbstractNioChannel.java:315)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.processTaskQueue(AbstractNioSelector.java:391)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:315)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioWorker.run(AbstractNioWorker.java:89)
[junit] at 
org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:178)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2016-10-11 20:46:45,347 [myid:] - INFO  [New I/O worker 
#3928:ClientCnxnSocketNetty$ZKClientHandler@384] - channel is disconnected: 
[id: 0x2cb96b07, /127.0.0.1:59696 :> 127.0.0.1/127.0.0.1:19545]
[junit] 2016-10-11 20:46:45,347 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port19545,name1=Connections,name2=127.0.0.1,name3=0x1d9efe4]
[junit] 2016-10-11 20:46:45,347 [myid:] - INFO  [New I/O worker 
#3928:ClientCnxnSocketNetty@208] - channel is told closing
[junit] 2016-10-11 20:46:45,348 [myid:] - INFO  
[main:ClientCnxnSocketNetty@208] - channel is told closing
[junit] 2016-10-11 20:46:45,348 [myid:] - INFO  [main:ZooKeeper@1315] - 
Session: 0x1d9efe4 closed
[junit] 2016-10-11 20:46:45,348 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1d9efe4
[junit] 2016-10-11 20:46:45,348 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 48290
[junit] 2016-10-11 20:46:45,348 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 516
[junit] 2016-10-11 20:46:45,348 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2016-10-11 20:46:45,348 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-10-11 20:46:45,348 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-10-11 20:46:45,348 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:19545
[junit] 2016-10-11 20:46:45,350 [myid:] - INFO  [main:ZooKeeperServer@529] 
- shutting down
[junit] 2016-10-11 20:46:45,350 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-10-11 20:46:45,350 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2016-10-11 20:46:45,350 [myid:] - INFO  
[main:PrepRequestProcessor@996] - Shutting down
[junit] 2016-10-11 

[jira] [Issue Comment Deleted] (ZOOKEEPER-1655) Make jline dependency optional in maven pom

[Daniel Takamori (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Takamori updated ZOOKEEPER-1655:
---
Comment: was deleted

(was: I think leaking the jline dependency is not desirable because it is only
needed to run the ZK command line tools while most projects would only use
the client API. For example, jline made its way into the
Hadoopdistribution until it was excluded explicitly.

As for upgrading jlline, that's a good idea as it would make features such
as reverse history search available in the ZK CLI.



)

> Make jline dependency optional in maven pom
> ---
>
> Key: ZOOKEEPER-1655
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1655
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.4.2
>Reporter: Thomas Weise
>Assignee: Thomas Weise
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1655.patch, ZOOKEEPER-1655.patch
>
>
> Old JLine version used in ZK CLI should not be pulled into downstream 
> projects. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1655) Make jline dependency optional in maven pom

[Daniel Takamori (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566146#comment-15566146
 ] 

Daniel Takamori commented on ZOOKEEPER-1655:


Adding deleted comment:

Thomas Weise (duplicate account) added a comment - 02/Sep/13 09:19

I think leaking the jline dependency is not desirable because it is only
needed to run the ZK command line tools while most projects would only use
the client API. For example, jline made its way into the
Hadoopdistribution until it was excluded explicitly.

As for upgrading jlline, that's a good idea as it would make features such
as reverse history search available in the ZK CLI.

> Make jline dependency optional in maven pom
> ---
>
> Key: ZOOKEEPER-1655
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1655
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.4.2
>Reporter: Thomas Weise
>Assignee: Thomas Weise
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1655.patch, ZOOKEEPER-1655.patch
>
>
> Old JLine version used in ZK CLI should not be pulled into downstream 
> projects. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZOOKEEPER-2612) user-level KeeperException

[venkata puvvada (JIRA)]

venkata puvvada created ZOOKEEPER-2612:
--

 Summary: user-level KeeperException
 Key: ZOOKEEPER-2612
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2612
 Project: ZooKeeper
  Issue Type: Bug
 Environment: Apache SOLR 4.10 in Zookeeper
Reporter: venkata puvvada


We are facing very big problem in production in Zookeeper. Its been working 
perfectly from many months, but suddenly without done any change in config. We 
had below problem. Because of the below problem, we are unable to do anything 
on this collection.

2016-10-11 09:54:56,448 [myid:2] - INFO  [ProcessThread(sid:2 
cport:-1)::PrepRequestProcessor@651] - Got user-level KeeperException when 
processing sessionid:0x156f39ec13e00b9 type:setData cxid:0x4728359 
zxid:0xa00560776 txntype:-1 reqpath:n/a Error 
Path:/solr/configs/constants/managed-schema Error:KeeperErrorCode = BadVersion 
for /solr/configs/constants/managed-schema
^C




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZOOKEEPER-2613) user-level KeeperException

[venkata puvvada (JIRA)]

venkata puvvada created ZOOKEEPER-2613:
--

 Summary: user-level KeeperException
 Key: ZOOKEEPER-2613
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2613
 Project: ZooKeeper
  Issue Type: Bug
 Environment: Apache SOLR 4.10 in Zookeeper
Reporter: venkata puvvada


We are facing very big problem in production in Zookeeper. Its been working 
perfectly from many months, but suddenly without done any change in config. We 
had below problem. Because of the below problem, we are unable to do anything 
on this collection.

2016-10-11 09:54:56,448 [myid:2] - INFO  [ProcessThread(sid:2 
cport:-1)::PrepRequestProcessor@651] - Got user-level KeeperException when 
processing sessionid:0x156f39ec13e00b9 type:setData cxid:0x4728359 
zxid:0xa00560776 txntype:-1 reqpath:n/a Error 
Path:/solr/configs/constants/managed-schema Error:KeeperErrorCode = BadVersion 
for /solr/configs/constants/managed-schema
^C




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch35_solaris - Build # 280 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_solaris/280/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 136497 lines...]
[junit] 2016-10-11 16:51:50,266 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x12431a33bcf closed
[junit] 2016-10-11 16:51:50,266 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@77] - RUNNING TEST METHOD 
testMutipleWatcherObjs
[junit] 2016-10-11 16:51:50,267 [myid:] - INFO  [main:ZooKeeper@855] - 
Initiating client connection, connectString=127.0.0.1:11235/chrootclienttest 
sessionTimeout=3 
watcher=org.apache.zookeeper.test.ClientBase$CountdownWatcher@12875ac
[junit] 2016-10-11 16:51:50,267 [myid:127.0.0.1:11235] - INFO  
[main-SendThread(127.0.0.1:11235):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:11235. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-10-11 16:51:50,267 [myid:127.0.0.1:11235] - INFO  
[main-SendThread(127.0.0.1:11235):ClientCnxn$SendThread@948] - Socket 
connection established, initiating session, client: null, server: null
[junit] 2016-10-11 16:51:50,267 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11235:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:51073
[junit] 2016-10-11 16:51:50,268 [myid:] - INFO  
[NIOWorkerThread-8:ZooKeeperServer@995] - Client attempting to establish new 
session at /127.0.0.1:51073
[junit] 2016-10-11 16:51:50,269 [myid:] - INFO  
[SyncThread:0:ZooKeeperServer@709] - Established session 0x12431a33bcf0001 with 
negotiated timeout 3 for client /127.0.0.1:51073
[junit] 2016-10-11 16:51:50,270 [myid:127.0.0.1:11235] - INFO  
[main-SendThread(127.0.0.1:11235):ClientCnxn$SendThread@1381] - Session 
establishment complete on server null, sessionid = 0x12431a33bcf0001, 
negotiated timeout = 3
[junit] 2016-10-11 16:51:50,271 [myid:] - INFO  [main:JMXEnv@117] - 
expect:0x12431a33bcf0001
[junit] 2016-10-11 16:51:50,271 [myid:] - INFO  [main:JMXEnv@120] - 
found:0x12431a33bcf0001 
org.apache.ZooKeeperService:name0=StandaloneServer_port11235,name1=Connections,name2=127.0.0.1,name3=0x12431a33bcf0001
[junit] 2016-10-11 16:51:51,921 [myid:] - INFO  [ProcessThread(sid:0 
cport:11235)::PrepRequestProcessor@647] - Processed session termination for 
sessionid: 0x12431a33bcf0001
[junit] 2016-10-11 16:51:51,922 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x12431a33bcf0001
[junit] 2016-10-11 16:51:51,922 [myid:] - INFO  
[NIOWorkerThread-7:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port11235,name1=Connections,name2=127.0.0.1,name3=0x12431a33bcf0001]
[junit] 2016-10-11 16:51:51,922 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x12431a33bcf0001 closed
[junit] 2016-10-11 16:51:51,922 [myid:] - INFO  
[NIOWorkerThread-7:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:51073 which had sessionid 0x12431a33bcf0001
[junit] 2016-10-11 16:51:51,922 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 13620
[junit] 2016-10-11 16:51:51,922 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 41
[junit] 2016-10-11 16:51:51,923 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testMutipleWatcherObjs
[junit] 2016-10-11 16:51:51,923 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-10-11 16:51:51,923 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-10-11 16:51:51,923 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-10-11 16:51:51,924 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11235:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-10-11 16:51:51,925 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-10-11 16:51:51,925 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-10-11 16:51:51,926 [myid:] - INFO  [main:ZooKeeperServer@529] 
- shutting down
[junit] 2016-10-11 16:51:51,926 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-10-11 16:51:51,926 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2016-10-11 16:51:51,926 [myid:] - INFO  
[main:PrepRequestProcessor@965] - Shutting down
[junit] 2016-10-11 

ZooKeeper_branch34_openjdk7 - Build # 1240 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1240/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 14 lines...]
java.io.IOException: Failed to mkdirs: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
at hudson.FilePath.mkdirs(FilePath.java:1191)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1267)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:604)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529)
at hudson.model.Run.execute(Run.java:1741)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:410)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
at hudson.FilePath.mkdirs(FilePath.java:1191)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1267)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:604)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529)
at hudson.model.Run.execute(Run.java:1741)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:410)
Recording test results
ERROR: Build step failed with exception
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7 does not 
exist.
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:483)
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:460)
at 
hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:127)
at 
hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:107)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2772)
at hudson.remoting.UserRequest.perform(UserRequest.java:153)
at hudson.remoting.UserRequest.perform(UserRequest.java:50)
at hudson.remoting.Request$2.run(Request.java:332)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
at ..remote call to ubuntu-eu2(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1416)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:253)
at hudson.remoting.Channel.call(Channel.java:781)
at hudson.FilePath.act(FilePath.java:1007)
at hudson.FilePath.act(FilePath.java:996)
at hudson.tasks.junit.JUnitParser.parseResult(JUnitParser.java:103)
at 
hudson.tasks.junit.JUnitResultArchiver.parse(JUnitResultArchiver.java:128)
at 
hudson.tasks.junit.JUnitResultArchiver.perform(JUnitResultArchiver.java:149)
at 
hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:78)
at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:779)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:720)
at hudson.model.Build$BuildExecution.post2(Build.java:185)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:665)
at hudson.model.Run.execute(Run.java:1766)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:410)
Build step 'Publish JUnit test result report' marked build as failure
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

[Flavio Junqueira (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565419#comment-15565419
 ] 

Flavio Junqueira commented on ZOOKEEPER-2014:
-

I checked that it works for me when reconfig is enabled. I have a couple of 
other things I wanted to raise:

# When I tried with reconfig disabled, I got this message:
{noformat}
reconfig -add server.5=127.0.0.1:1234:1235;1236
KeeperErrorCode = Reconfig is disabled for
{noformat}
And it should be only {{Reconfig disabled}}, unless we want to convey some 
other information.

# I have also verified that to get the reconfig command to go through we only 
need the leader to have {{reconfigEnabled = true}}. There is no way around it 
unless the replicas coordinate to use the same value. We need it well 
documented, though.

> Only admin should be allowed to reconfig a cluster
> --
>
> Key: ZOOKEEPER-2014
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2014
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.0
>Reporter: Raul Gutierrez Segales
>Assignee: Michael Han
>Priority: Blocker
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch
>
>
> ZOOKEEPER-107 introduces reconfiguration support via the reconfig() call. We 
> should, at the very least, ensure that only the Admin can reconfigure a 
> cluster. Perhaps restricting access to /zookeeper/config as well, though this 
> is debatable. Surely one could ensure Admin only access via an ACL, but that 
> would leave everyone who doesn't use ACLs unprotected. We could also force a 
> default ACL to make it a bit more consistent (maybe).
> Finally, making reconfig() only available to Admins means they have to run 
> with zookeeper.DigestAuthenticationProvider.superDigest (which I am not sure 
> if everyone does, or how would it work with other authentication providers). 
> Review board https://reviews.apache.org/r/51546/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch34_solaris - Build # 1322 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_solaris/1322/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 15048 lines...]
[junit] at 
org.apache.zookeeper.server.quorum.QuorumCnxManager.pollSendQueue(QuorumCnxManager.java:879)
[junit] at 
org.apache.zookeeper.server.quorum.QuorumCnxManager.access$500(QuorumCnxManager.java:65)
[junit] at 
org.apache.zookeeper.server.quorum.QuorumCnxManager$SendWorker.run(QuorumCnxManager.java:715)
[junit] 2016-10-11 13:36:12,347 [myid:] - WARN  
[RecvWorker:2:QuorumCnxManager$RecvWorker@813] - Interrupting SendWorker
[junit] 2016-10-11 13:36:12,345 [myid:] - INFO  
[QuorumPeer[myid=2]/0.0.0.0:11275:SyncRequestProcessor@208] - Shutting down
[junit] 2016-10-11 13:36:12,345 [myid:] - WARN  
[RecvWorker:1:QuorumCnxManager$RecvWorker@810] - Connection broken for id 1, my 
id = 2, error = 
[junit] java.io.EOFException
[junit] at java.io.DataInputStream.readInt(DataInputStream.java:375)
[junit] at 
org.apache.zookeeper.server.quorum.QuorumCnxManager$RecvWorker.run(QuorumCnxManager.java:795)
[junit] 2016-10-11 13:36:12,348 [myid:] - WARN  
[RecvWorker:1:QuorumCnxManager$RecvWorker@813] - Interrupting SendWorker
[junit] 2016-10-11 13:36:12,345 [myid:] - WARN  
[QuorumPeer[myid=1]/0.0.0.0:11272:QuorumPeer@862] - Unexpected exception
[junit] java.lang.InterruptedException: sleep interrupted
[junit] at java.lang.Thread.sleep(Native Method)
[junit] at 
org.apache.zookeeper.server.quorum.Leader.lead(Leader.java:456)
[junit] at 
org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:859)
[junit] 2016-10-11 13:36:12,348 [myid:] - WARN  
[SendWorker:1:QuorumCnxManager$SendWorker@727] - Interrupted while waiting for 
message on queue
[junit] java.lang.InterruptedException
[junit] at 
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.reportInterruptAfterWait(AbstractQueuedSynchronizer.java:1961)
[junit] at 
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2038)
[junit] at 
java.util.concurrent.ArrayBlockingQueue.poll(ArrayBlockingQueue.java:342)
[junit] at 
org.apache.zookeeper.server.quorum.QuorumCnxManager.pollSendQueue(QuorumCnxManager.java:879)
[junit] at 
org.apache.zookeeper.server.quorum.QuorumCnxManager.access$500(QuorumCnxManager.java:65)
[junit] at 
org.apache.zookeeper.server.quorum.QuorumCnxManager$SendWorker.run(QuorumCnxManager.java:715)
[junit] 2016-10-11 13:36:12,348 [myid:] - WARN  
[SendWorker:1:QuorumCnxManager$SendWorker@736] - Send worker leaving thread
[junit] 2016-10-11 13:36:12,348 [myid:] - INFO  
[SyncThread:2:SyncRequestProcessor@186] - SyncRequestProcessor exited!
[junit] 2016-10-11 13:36:12,347 [myid:] - WARN  
[SendWorker:2:QuorumCnxManager$SendWorker@736] - Send worker leaving thread
[junit] 2016-10-11 13:36:12,346 [myid:] - INFO  
[main:FollowerZooKeeperServer@140] - Shutting down
[junit] 2016-10-11 13:36:12,349 [myid:] - WARN  
[QuorumPeer[myid=2]/0.0.0.0:11275:QuorumPeer@874] - QuorumPeer main thread 
exited
[junit] 2016-10-11 13:36:12,348 [myid:] - INFO  
[QuorumPeer[myid=1]/0.0.0.0:11272:Leader@502] - Shutting down
[junit] 2016-10-11 13:36:12,349 [myid:] - INFO  
[main:SyncRequestProcessor@208] - Shutting down
[junit] 2016-10-11 13:36:12,349 [myid:] - WARN  
[QuorumPeer[myid=1]/0.0.0.0:11272:QuorumPeer@874] - QuorumPeer main thread 
exited
[junit] 2016-10-11 13:36:12,350 [myid:] - ERROR 
[/0.0.0.0:11276:QuorumCnxManager$Listener@547] - Exception while listening
[junit] java.net.SocketException: Socket closed
[junit] at java.net.PlainSocketImpl.socketAccept(Native Method)
[junit] at java.net.PlainSocketImpl.accept(PlainSocketImpl.java:408)
[junit] at java.net.ServerSocket.implAccept(ServerSocket.java:462)
[junit] at java.net.ServerSocket.accept(ServerSocket.java:430)
[junit] at 
org.apache.zookeeper.server.quorum.QuorumCnxManager$Listener.run(QuorumCnxManager.java:539)
[junit] 2016-10-11 13:36:12,350 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 14266
[junit] 2016-10-11 13:36:12,351 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 26
[junit] 2016-10-11 13:36:12,351 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD 
testWorkerThreads
[junit] 2016-10-11 13:36:12,351 [myid:] - INFO  [main:ZKTestCase$1@65] - 
SUCCEEDED testWorkerThreads
[junit] 2016-10-11 13:36:12,351 [myid:] - INFO  [main:ZKTestCase$1@60] - 
FINISHED testWorkerThreads
[junit] 2016-10-11 13:36:12,371 [myid:] - INFO  
[WorkerReceiver[myid=2]:FastLeaderElection$Messenger$WorkerReceiver@407] - 
WorkerReceiver 

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

[Flavio Junqueira (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565322#comment-15565322
 ] 

Flavio Junqueira commented on ZOOKEEPER-2014:
-

Thanks for fixing it. I see the point of stability, but I don't think it is 
much of a concern in this case. You're just building on top of the ZooKeeper, 
you won't be re-wiring the existing ZooKeeper client code, I think. If I'm 
right, then it is better to have a single connection to the service rather than 
two, one for the ZooKeeper object and another for ZooKeeperAdmin. In any case, 
it might be worth giving it a shot to get a sense of whether it'd cause trouble.

> Only admin should be allowed to reconfig a cluster
> --
>
> Key: ZOOKEEPER-2014
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2014
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.0
>Reporter: Raul Gutierrez Segales
>Assignee: Michael Han
>Priority: Blocker
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch
>
>
> ZOOKEEPER-107 introduces reconfiguration support via the reconfig() call. We 
> should, at the very least, ensure that only the Admin can reconfigure a 
> cluster. Perhaps restricting access to /zookeeper/config as well, though this 
> is debatable. Surely one could ensure Admin only access via an ACL, but that 
> would leave everyone who doesn't use ACLs unprotected. We could also force a 
> default ACL to make it a bit more consistent (maybe).
> Finally, making reconfig() only available to Admins means they have to run 
> with zookeeper.DigestAuthenticationProvider.superDigest (which I am not sure 
> if everyone does, or how would it work with other authentication providers). 
> Review board https://reviews.apache.org/r/51546/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch35_jdk8 - Build # 262 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/262/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 471802 lines...]
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2016-10-11 12:17:41,090 [myid:] - INFO  [New I/O boss 
#66:ClientCnxnSocketNetty@208] - channel is told closing
[junit] 2016-10-11 12:17:41,091 [myid:127.0.0.1:30073] - INFO  
[main-SendThread(127.0.0.1:30073):ClientCnxn$SendThread@1231] - channel for 
sessionid 0x1014726fc33 is lost, closing socket connection and attempting 
reconnect
[junit] Running org.apache.zookeeper.server.ZxidRolloverTest in thread 4
[junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 
sec, Thread: 4, Class: org.apache.zookeeper.server.ZxidRolloverTest
[junit] Test org.apache.zookeeper.server.ZxidRolloverTest FAILED (timeout)
[junit] 2016-10-11 12:18:46,417 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 134434
[junit] 2016-10-11 12:18:46,418 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 55
[junit] 2016-10-11 12:18:46,418 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testManyChildWatchersAutoReset
[junit] 2016-10-11 12:18:46,418 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-10-11 12:18:46,420 [myid:] - INFO  [ProcessThread(sid:0 
cport:27383)::PrepRequestProcessor@647] - Processed session termination for 
sessionid: 0x1014725a00a
[junit] 2016-10-11 12:18:46,443 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x1014725a00a closed
[junit] 2016-10-11 12:18:46,443 [myid:] - INFO  
[NIOWorkerThread-30:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port27383,name1=Connections,name2=127.0.0.1,name3=0x1014725a00a]
[junit] 2016-10-11 12:18:46,443 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1014725a00a
[junit] 2016-10-11 12:18:46,444 [myid:] - INFO  [ProcessThread(sid:0 
cport:27383)::PrepRequestProcessor@647] - Processed session termination for 
sessionid: 0x1014725a00a0001
[junit] 2016-10-11 12:18:46,445 [myid:] - INFO  
[NIOWorkerThread-30:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:58996 which had sessionid 0x1014725a00a
[junit] 2016-10-11 12:18:46,475 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x1014725a00a0001 closed
[junit] 2016-10-11 12:18:46,475 [myid:] - INFO  
[NIOWorkerThread-11:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port27383,name1=Connections,name2=127.0.0.1,name3=0x1014725a00a0001]
[junit] 2016-10-11 12:18:46,475 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-10-11 12:18:46,475 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1014725a00a0001
[junit] 2016-10-11 12:18:46,475 [myid:] - INFO  
[NIOWorkerThread-11:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:59017 which had sessionid 0x1014725a00a0001
[junit] 2016-10-11 12:18:46,475 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-10-11 12:18:46,478 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-10-11 12:18:46,480 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:27383:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-10-11 12:18:46,480 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-10-11 12:18:46,481 [myid:] - INFO  [main:ZooKeeperServer@529] 
- shutting down
[junit] 2016-10-11 12:18:46,482 [myid:] - ERROR [main:ZooKeeperServer@501] 
- 

[jira] [Commented] (ZOOKEEPER-1932) org.apache.zookeeper.test.LETest.testLE fails once in a while

[Flavio Junqueira (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15564972#comment-15564972
 ] 

Flavio Junqueira commented on ZOOKEEPER-1932:
-

I'm +1 on this patch and on removing the LeaderElection class, although it 
might be better to remove the LeaderElection class on trunk only because 
earlier versions of 3.5 already contain it. What do you think?

cc [~hanm]

> org.apache.zookeeper.test.LETest.testLE fails once in a while
> -
>
> Key: ZOOKEEPER-1932
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1932
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: leaderElection
>Affects Versions: 3.5.0
>Reporter: Michi Mutsuzaki
>Assignee: Flavio Junqueira
> Fix For: 3.5.3, 3.6.0
>
> Attachments: TEST-org.apache.zookeeper.test.LETest.txt, 
> ZOOKEEPER-1932.patch
>
>
> org.apache.zookeeper.test.LETest.testLE is failing on trunk once in a while. 
> I'm not able to reproduce the failure on my box. I looked at the log, but I 
> couldn't quite figure out what's going on. 
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk/2315/testReport/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch35_jdk7 - Build # 694 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/694/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 449964 lines...]
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-10-11 08:48:09,512 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x101456bd75d closed
[junit] 2016-10-11 08:48:09,513 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 207095
[junit] 2016-10-11 08:48:09,512 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x101456bd75d
[junit] 2016-10-11 08:48:09,513 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 1643
[junit] 2016-10-11 08:48:09,513 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2016-10-11 08:48:09,513 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-10-11 08:48:09,513 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-10-11 08:48:09,514 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:19545
[junit] 2016-10-11 08:48:09,519 [myid:] - INFO  [main:ZooKeeperServer@529] 
- shutting down
[junit] 2016-10-11 08:48:09,522 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-10-11 08:48:09,523 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2016-10-11 08:48:09,523 [myid:] - INFO  
[main:PrepRequestProcessor@965] - Shutting down
[junit] 2016-10-11 08:48:09,523 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2016-10-11 08:48:09,523 [myid:] - INFO  [ProcessThread(sid:0 
cport:19545)::PrepRequestProcessor@154] - PrepRequestProcessor exited loop!
[junit] 2016-10-11 08:48:09,523 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2016-10-11 08:48:09,523 [myid:] - INFO  
[main:FinalRequestProcessor@479] - shutdown of request processor complete
[junit] 2016-10-11 08:48:09,524 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port19545,name1=InMemoryDataTree]
[junit] 2016-10-11 08:48:09,524 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port19545]
[junit] 2016-10-11 08:48:09,524 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 19545
[junit] 2016-10-11 08:48:09,525 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-10-11 08:48:09,530 [myid:] - INFO  [main:ClientBase@568] - 
fdcount after test is: 4829 at start it was 4833
[junit] 2016-10-11 08:48:09,530 [myid:] - INFO  [main:ZKTestCase$1@65] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2016-10-11 08:48:09,531 [myid:] - INFO  [main:ZKTestCase$1@60] - 
FINISHED testWatcherAutoResetWithLocal
[junit] 2016-10-11 08:48:10,344 [myid:127.0.0.1:19422] - INFO  
[main-SendThread(127.0.0.1:19422):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:19422. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-10-11 08:48:10,411 [myid:127.0.0.1:19425] - INFO  
[main-SendThread(127.0.0.1:19425):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:19425. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-10-11 08:48:10,412 [myid:127.0.0.1:19425] - WARN  
[main-SendThread(127.0.0.1:19425):ClientCnxn$SendThread@1235] - Session 
0x2014568b94e for server 127.0.0.1/127.0.0.1:19425, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-10-11 08:48:10,416 [myid:127.0.0.1:19422] - WARN  
[main-SendThread(127.0.0.1:19422):ClientCnxn$SendThread@1235] - Session 
0x1014568b901 for server 127.0.0.1/127.0.0.1:19422, unexpected error, 
closing socket connection and attempting reconnect
[junit] 

ZooKeeper-trunk-solaris - Build # 1344 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1344/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 439779 lines...]
[junit] 2016-10-11 08:31:35,583 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-10-11 08:31:35,583 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-10-11 08:31:35,584 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-10-11 08:31:35,584 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-10-11 08:31:35,585 [myid:] - INFO  [main:ZooKeeperServer@889] 
- minSessionTimeout set to 6000
[junit] 2016-10-11 08:31:35,585 [myid:] - INFO  [main:ZooKeeperServer@898] 
- maxSessionTimeout set to 6
[junit] 2016-10-11 08:31:35,585 [myid:] - INFO  [main:ZooKeeperServer@159] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test6909550507392566300.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test6909550507392566300.junit.dir/version-2
[junit] 2016-10-11 08:31:35,586 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test6909550507392566300.junit.dir/version-2/snapshot.b
[junit] 2016-10-11 08:31:35,587 [myid:] - INFO  [main:FileTxnSnapLog@306] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test6909550507392566300.junit.dir/version-2/snapshot.b
[junit] 2016-10-11 08:31:35,589 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-10-11 08:31:35,589 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-10-11 08:31:35,589 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:44428
[junit] 2016-10-11 08:31:35,590 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:44428
[junit] 2016-10-11 08:31:35,590 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-10-11 08:31:35,591 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:44428 (no session established for client)
[junit] 2016-10-11 08:31:35,591 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-10-11 08:31:35,592 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-10-11 08:31:35,592 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-10-11 08:31:35,592 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-10-11 08:31:35,593 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-10-11 08:31:35,593 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17665
[junit] 2016-10-11 08:31:35,593 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-10-11 08:31:35,593 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-10-11 08:31:35,593 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-10-11 08:31:35,672 [myid:] - INFO  [main:ZooKeeper@1315] - 
Session: 0x1242fd936cb closed
[junit] 2016-10-11 08:31:35,672 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1242fd936cb
[junit] 2016-10-11 08:31:35,673 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-10-11 08:31:35,673 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-10-11 08:31:35,673 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-10-11 08:31:35,673 [myid:] - INFO