Re: Newbie

[Vineet G H]

Thanks Michael. I can definitely help out there. Looks like this is
the only one without any takers. Is that right?

https://issues.apache.org/jira/browse/ZOOKEEPER-2637#

On Tue, Jan 17, 2017 at 10:45 PM, Michael Han  wrote:
> There are lots of unresolved issues that either get stale due to no one
> driving it despite having an assignee; or simply unassigned. You should be
> easily find an issue that fall in your interest area to work on - also if
> you are interested, we could use some help to fix flaky tests
> https://issues.apache.org/jira/browse/ZOOKEEPER-2135, which is a good way
> to get used to the code base, and more importantly, have an immediate
> impact to the project :-)
>
> On Tue, Jan 17, 2017 at 10:33 PM, Vineet G H  wrote:
>
>> Hello All,
>>
>> My Name is Vineet and I looking ways to contribute to Zookeeper project.
>>
>> I looked up existing bugs on JIRA, but most of unassigned bug have
>> either been engaged or is work in progress.
>>
>> I have already looked at :
>> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
>>
>> I would like to get familiar with code base by working with a bug,
>> before picking up a feature or
>>
>> Also, if there anything else that I can help out, please let me know.
>>
>> Regards,
>> Vineet
>>
>
>
>
> --
> Cheers
> Michael.

Re: Willing to Contribute to this Project

[Michael Han]

My shameless plug here again - we could use some help on fixing flaky tests
if you are interested :-)
https://issues.apache.org/jira/browse/ZOOKEEPER-2135

Also, as other pointed out, doing code reviews on existing pull requests /
patches is a great way to engage with the community and learn the system.

On Tue, Jan 17, 2017 at 6:33 PM, Rakesh Radhakrishnan 
wrote:

> Thank you for your interest in ZooKeeper!
>
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute wiki
> page is a good resource for new folks interested in participating.
>
> Please feel free to post patches on ZooKeeper JIRA issues that interest
> you. If there is any question about how to proceed on an issue, then please
> either discuss directly on the JIRA or send an e-mail to ZooKeeper dev
> list.
>
> Helper links:-
> Issue Tracker: https://issues.apache.org/jira/browse/ZOOKEEPER
> Mailing list: http://zookeeper.apache.org/lists.html
> Docs: https://zookeeper.apache.org/doc/r3.5.2-alpha/
>
> Cheers,
> Rakesh
>
> On Tue, Jan 17, 2017 at 10:20 PM, Amol Kulkarni  wrote:
>
> > Hi there,
> >
> > This is Amol Kulkarni here,i'm looking forward to contribute to open
> source
> > projects in Java technologies and came across the zookeeper project.
> > I'm willing to contribute to make any changes/issues available.
> > I have been working Java technologies for the last 5 year's,looking
> forward
> > to contribute in projects.
> >
> > Would be very greatful,if get assistance  to get an idea how to start
> with
> > it.
> > Awaiting your response.
> >
> > --
> > *Thanks & Regards*
> > *Amol Kulkarni *
> >
>



-- 
Cheers
Michael.

Re: Newbie

[Michael Han]

There are lots of unresolved issues that either get stale due to no one
driving it despite having an assignee; or simply unassigned. You should be
easily find an issue that fall in your interest area to work on - also if
you are interested, we could use some help to fix flaky tests
https://issues.apache.org/jira/browse/ZOOKEEPER-2135, which is a good way
to get used to the code base, and more importantly, have an immediate
impact to the project :-)

On Tue, Jan 17, 2017 at 10:33 PM, Vineet G H  wrote:

> Hello All,
>
> My Name is Vineet and I looking ways to contribute to Zookeeper project.
>
> I looked up existing bugs on JIRA, but most of unassigned bug have
> either been engaged or is work in progress.
>
> I have already looked at :
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
>
> I would like to get familiar with code base by working with a bug,
> before picking up a feature or
>
> Also, if there anything else that I can help out, please let me know.
>
> Regards,
> Vineet
>



-- 
Cheers
Michael.

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827499#comment-15827499
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2184:
---

Github user hanm commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96574629
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
+ * string representation of the IP address.
+ *
+ * @param addr
+ * @return Hostname string of address parameter
+ */
+private String getHostString(InetSocketAddress addr) {
+String hostString;
+InetAddress ia = addr.getAddress();
+
+if (ia != null) {
+// If the string starts with '/', then it has no hostname
+// and we want to avoid the reverse lookup, so we return
+// the string representation of the address.
+if (ia.toString().startsWith("/")) {
+hostString = ia.getHostAddress();
+} else {
+hostString = addr.getHostName();
+}
+} else {
+// According to the Java 6 documentation, if the hostname is
+// unresolved, then the string before the colon is the 
hostname.
+String addrString = addr.toString();
+hostString = addrString.substring(0, 
addrString.lastIndexOf(':'));
+}
+
+return hostString;
+}
+
 public int size() {
 return serverAddresses.size();
 }
 
 public InetSocketAddress next(long spinDelay) {
-++currentIndex;
-if (currentIndex == serverAddresses.size()) {
-currentIndex = 0;
+// Handle possible connection error by re-resolving hostname if 
possible
+if (!connectedSinceNext) {
+InetSocketAddress curAddr = serverAddresses.get(currentIndex);
+if 
(!curAddr.getHostString().equals(curAddr.getAddress().getHostAddress())) {
+try {
+int thePort = curAddr.getPort();
+InetAddress resolvedAddresses[] = 
InetAddress.getAllByName(getHostString(curAddr));
+if (resolvedAddresses.length == 1) {
+serverAddresses.set(currentIndex, new 
InetSocketAddress(resolvedAddresses[0], thePort));
+} else {
+serverAddresses.remove(currentIndex);
+for (InetAddress resolvedAddress : 
resolvedAddresses) {
+InetSocketAddress newAddr = new 
InetSocketAddress(resolvedAddress, thePort);
+if (!serverAddresses.contains(newAddr)) {
+serverAddresses.add(newAddr);
+}
+}
+}
+} catch (UnknownHostException e) {
+LOG.warn("Cannot re-resolve server: " + curAddr + " 
UnknownHostException: " + e);
--- End diff --

OK.


> Zookeeper Client should re-resolve hosts when connection attempts fail
> --
>
> Key: ZOOKEEPER-2184
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2184
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6, 3.5.0
> Environment: Ubuntu 14.04 host, Docker containers for Zookeeper & 
> Kafka
>Reporter: Robert P. Thille
>Assignee: Flavio Junqueira
>  Labels: easyfix, patch
> Fix For: 3.4.10, 3.5.3
>
> Attachments: ZOOKEEPER-2184.patch
>
>
> Testing in a Docker environment with a single Kafka instance using a single 
> Zookeeper instance. Restarting the Zookeeper container will cause it to 
> receive a new IP address. Kafka will never be able to reconnect to Zookeeper 
> and will hang indefinitely. Updating DNS or /etc/hosts with the new IP 
> address will not help the client to reconnect as the 
> zookeeper/client/StaticHostProvider resolves the connection string hosts at 
> creation time and never re-resolves.
> A solution would be for the client to notice that connection attempts fail 

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827498#comment-15827498
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2184:
---

Github user hanm commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96574584
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
+ * string representation of the IP address.
+ *
+ * @param addr
+ * @return Hostname string of address parameter
+ */
+private String getHostString(InetSocketAddress addr) {
--- End diff --

OK, it is a reasonable concern of using package private API via reflection 
and I honestly don't know the implementation difference between Java 6 / 7 
regarding getHostString - let's stick to explicit implementation in this file.


> Zookeeper Client should re-resolve hosts when connection attempts fail
> --
>
> Key: ZOOKEEPER-2184
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2184
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6, 3.5.0
> Environment: Ubuntu 14.04 host, Docker containers for Zookeeper & 
> Kafka
>Reporter: Robert P. Thille
>Assignee: Flavio Junqueira
>  Labels: easyfix, patch
> Fix For: 3.4.10, 3.5.3
>
> Attachments: ZOOKEEPER-2184.patch
>
>
> Testing in a Docker environment with a single Kafka instance using a single 
> Zookeeper instance. Restarting the Zookeeper container will cause it to 
> receive a new IP address. Kafka will never be able to reconnect to Zookeeper 
> and will hang indefinitely. Updating DNS or /etc/hosts with the new IP 
> address will not help the client to reconnect as the 
> zookeeper/client/StaticHostProvider resolves the connection string hosts at 
> creation time and never re-resolves.
> A solution would be for the client to notice that connection attempts fail 
> and attempt to re-resolve the hostnames in the connectString.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #150: ZOOKEEPER-2184: Zookeeper Client should re-reso...

[hanm]

Github user hanm commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96574629
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
+ * string representation of the IP address.
+ *
+ * @param addr
+ * @return Hostname string of address parameter
+ */
+private String getHostString(InetSocketAddress addr) {
+String hostString;
+InetAddress ia = addr.getAddress();
+
+if (ia != null) {
+// If the string starts with '/', then it has no hostname
+// and we want to avoid the reverse lookup, so we return
+// the string representation of the address.
+if (ia.toString().startsWith("/")) {
+hostString = ia.getHostAddress();
+} else {
+hostString = addr.getHostName();
+}
+} else {
+// According to the Java 6 documentation, if the hostname is
+// unresolved, then the string before the colon is the 
hostname.
+String addrString = addr.toString();
+hostString = addrString.substring(0, 
addrString.lastIndexOf(':'));
+}
+
+return hostString;
+}
+
 public int size() {
 return serverAddresses.size();
 }
 
 public InetSocketAddress next(long spinDelay) {
-++currentIndex;
-if (currentIndex == serverAddresses.size()) {
-currentIndex = 0;
+// Handle possible connection error by re-resolving hostname if 
possible
+if (!connectedSinceNext) {
+InetSocketAddress curAddr = serverAddresses.get(currentIndex);
+if 
(!curAddr.getHostString().equals(curAddr.getAddress().getHostAddress())) {
+try {
+int thePort = curAddr.getPort();
+InetAddress resolvedAddresses[] = 
InetAddress.getAllByName(getHostString(curAddr));
+if (resolvedAddresses.length == 1) {
+serverAddresses.set(currentIndex, new 
InetSocketAddress(resolvedAddresses[0], thePort));
+} else {
+serverAddresses.remove(currentIndex);
+for (InetAddress resolvedAddress : 
resolvedAddresses) {
+InetSocketAddress newAddr = new 
InetSocketAddress(resolvedAddress, thePort);
+if (!serverAddresses.contains(newAddr)) {
+serverAddresses.add(newAddr);
+}
+}
+}
+} catch (UnknownHostException e) {
+LOG.warn("Cannot re-resolve server: " + curAddr + " 
UnknownHostException: " + e);
--- End diff --

OK.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #150: ZOOKEEPER-2184: Zookeeper Client should re-reso...

[hanm]

Github user hanm commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96574584
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
+ * string representation of the IP address.
+ *
+ * @param addr
+ * @return Hostname string of address parameter
+ */
+private String getHostString(InetSocketAddress addr) {
--- End diff --

OK, it is a reasonable concern of using package private API via reflection 
and I honestly don't know the implementation difference between Java 6 / 7 
regarding getHostString - let's stick to explicit implementation in this file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Newbie

[Vineet G H]

Hello All,

My Name is Vineet and I looking ways to contribute to Zookeeper project.

I looked up existing bugs on JIRA, but most of unassigned bug have
either been engaged or is work in progress.

I have already looked at :
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute

I would like to get familiar with code base by working with a bug,
before picking up a feature or

Also, if there anything else that I can help out, please let me know.

Regards,
Vineet

[jira] [Commented] (ZOOKEEPER-2325) Data inconsistency if all snapshots empty or missing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827431#comment-15827431
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2325:
---

Github user rakeshadr commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/144#discussion_r96568373
  
--- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 
---
@@ -37,6 +37,8 @@
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.Map;
--- End diff --

Good catch, @afine. This test is related to ZOOKEEPER-1558. Perhaps, we 
need to re-look the fix to see any chance of creating snapshot with uncommitted 
state.


> Data inconsistency if all snapshots empty or missing
> 
>
> Key: ZOOKEEPER-2325
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2325
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6
>Reporter: Andrew Grasso
>Priority: Critical
> Fix For: 3.5.3, 3.6.0
>
> Attachments: zk.patch, ZOOKEEPER-2325.001.patch, 
> ZOOKEEPER-2325-test.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When loading state from snapshots on startup, FileTxnSnapLog.java ignores the 
> result of FileSnap.deserialize, which is -1L if no valid snapshots are found. 
> Recovery proceeds with dt.lastProcessed == 0, its initial value.
> The result is that Zookeeper will process the transaction logs and then begin 
> serving requests with a different state than the rest of the ensemble.
> To reproduce:
> In a healthy zookeeper cluster of size >= 3, shut down one node.
> Either delete all snapshots for this node or change all to be empty files.
> Restart the node.
> We believe this can happen organically if a node runs out of disk space.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #144: ZOOKEEPER-2325 for branch-3.4.

[rakeshadr]

Github user rakeshadr commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/144#discussion_r96568373
  
--- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 
---
@@ -37,6 +37,8 @@
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.Map;
--- End diff --

Good catch, @afine. This test is related to ZOOKEEPER-1558. Perhaps, we 
need to re-look the fix to see any chance of creating snapshot with uncommitted 
state.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Failed: ZOOKEEPER- PreCommit Build #219

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/219/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 25 lines...]
  Getting sizes
Done: 4
  Compressing objects
Done: 1868
  Writing objects
Done: 5
  remote: Updating references
Merging refs/tags/changes/219
 > git rev-parse refs/tags/changes/219^{commit} # timeout=10
 > git merge 2d25ea2bb0641e440adb05fd983445a428e8e77b # timeout=10
 > git rev-parse branch-3.4^{commit} # timeout=10
Checking out Revision ea761530f0a548c5fd4bad3bbe3f03fe2d0af69d (branch-3.4)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f ea761530f0a548c5fd4bad3bbe3f03fe2d0af69d
 > git rev-parse origin/branch-3.4^{commit} # timeout=10
 > git rev-list cded802708fac417369affbd25bf9ad2016a904d # timeout=10
No emails were triggered.
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[PreCommit-ZOOKEEPER-github-pr-build] $ /bin/bash 
/tmp/hudson1617196953842665143.sh
/home/jenkins/tools/java/latest1.7/bin/java
java version "1.7.0_80"
Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
core file size  (blocks, -c) 0
data seg size   (kbytes, -d) unlimited
scheduling priority (-e) 0
file size   (blocks, -f) unlimited
pending signals (-i) 386178
max locked memory   (kbytes, -l) 64
max memory size (kbytes, -m) unlimited
open files  (-n) 6
pipe size(512 bytes, -p) 8
POSIX message queues (bytes, -q) 819200
real-time priority  (-r) 0
stack size  (kbytes, -s) 8192
cpu time   (seconds, -t) unlimited
max user processes  (-u) 10240
virtual memory  (kbytes, -v) unlimited
file locks  (-x) unlimited
Buildfile: 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml

BUILD FAILED
Target "qa-test-pullrequest" does not exist in the project "ZooKeeper". 

Total time: 0 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
[description-setter] Could not determine description.
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

Failed: ZOOKEEPER- PreCommit Build #218

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/218/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 26 lines...]
Done: 22
  Compressing objects
Done: 5618
  Writing objects
Done: 25
  remote: Resolving deltas
  remote: Updating references
Merging refs/tags/changes/218
 > git rev-parse refs/tags/changes/218^{commit} # timeout=10
 > git merge 6b39eb12a9c343888f2d71d669e02dec57a74ab1 # timeout=10
 > git rev-parse branch-3.4^{commit} # timeout=10
Checking out Revision 79f755f35dba58dd96b9fd0ee45d8c9cf3a6813b (branch-3.4)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 79f755f35dba58dd96b9fd0ee45d8c9cf3a6813b
 > git rev-parse origin/branch-3.4^{commit} # timeout=10
 > git rev-list cded802708fac417369affbd25bf9ad2016a904d # timeout=10
No emails were triggered.
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[PreCommit-ZOOKEEPER-github-pr-build] $ /bin/bash 
/tmp/hudson5794930296829267477.sh
/home/jenkins/tools/java/latest1.7/bin/java
java version "1.7.0_80"
Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
core file size  (blocks, -c) 0
data seg size   (kbytes, -d) unlimited
scheduling priority (-e) 0
file size   (blocks, -f) unlimited
pending signals (-i) 386178
max locked memory   (kbytes, -l) 64
max memory size (kbytes, -m) unlimited
open files  (-n) 6
pipe size(512 bytes, -p) 8
POSIX message queues (bytes, -q) 819200
real-time priority  (-r) 0
stack size  (kbytes, -s) 8192
cpu time   (seconds, -t) unlimited
max user processes  (-u) 10240
virtual memory  (kbytes, -v) unlimited
file locks  (-x) unlimited
Buildfile: 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml

BUILD FAILED
Target "qa-test-pullrequest" does not exist in the project "ZooKeeper". 

Total time: 0 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
[description-setter] Could not determine description.
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2573) Modify Info.REVISION to adapt git repo

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827362#comment-15827362
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2573:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/137#discussion_r96560786
  
--- Diff: src/lastRevision.sh ---
@@ -16,6 +16,6 @@
 
 # Find the current revision, store it in a file
 FILE=$1
-LASTREV=`svn info | grep '^Revision' | sed -e 's/Revision: *//'`
+LASTREV=`git rev-parse HEAD | cut -c1-8`
--- End diff --

Done.


> Modify Info.REVISION to adapt git repo
> --
>
> Key: ZOOKEEPER-2573
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2573
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build, server
>Affects Versions: 3.4.9, 3.5.2
>Reporter: Arshad Mohammad
>Assignee: Edward Ribeiro
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> Modify {{org.apache.zookeeper.version.Info.REVISION}} to store git repo 
> revision
> Currently {{org.apache.zookeeper.version.Info.REVISION}} stores the svn repo 
> revision which is of type int
> But after migrating to git repo the git repo's revision(commit 
> 63f5132716c08b3d8f18993bf98eb46eb42f80fb) can not be stored in this variable.
> So either we should modify this variable to string to introduce new variable 
> to store the git revision and leave the svn revision variable unchanged.
> build.xml, and org.apache.zookeeper.version.util.VerGen also need to be 
> modified. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #137: ZOOKEEPER-2573: Modify Info.REVISION to adapt g...

[rakeshadr]

Github user rakeshadr commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/137#discussion_r96560053
  
--- Diff: src/lastRevision.sh ---
@@ -16,6 +16,6 @@
 
 # Find the current revision, store it in a file
 FILE=$1
-LASTREV=`svn info | grep '^Revision' | sed -e 's/Revision: *//'`
+LASTREV=`git rev-parse HEAD | cut -c1-8`
--- End diff --

@eribeiro, could you please update the patch accordingly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2573) Modify Info.REVISION to adapt git repo

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827356#comment-15827356
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2573:
---

Github user rakeshadr commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/137#discussion_r96560053
  
--- Diff: src/lastRevision.sh ---
@@ -16,6 +16,6 @@
 
 # Find the current revision, store it in a file
 FILE=$1
-LASTREV=`svn info | grep '^Revision' | sed -e 's/Revision: *//'`
+LASTREV=`git rev-parse HEAD | cut -c1-8`
--- End diff --

@eribeiro, could you please update the patch accordingly.


> Modify Info.REVISION to adapt git repo
> --
>
> Key: ZOOKEEPER-2573
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2573
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build, server
>Affects Versions: 3.4.9, 3.5.2
>Reporter: Arshad Mohammad
>Assignee: Edward Ribeiro
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> Modify {{org.apache.zookeeper.version.Info.REVISION}} to store git repo 
> revision
> Currently {{org.apache.zookeeper.version.Info.REVISION}} stores the svn repo 
> revision which is of type int
> But after migrating to git repo the git repo's revision(commit 
> 63f5132716c08b3d8f18993bf98eb46eb42f80fb) can not be stored in this variable.
> So either we should modify this variable to string to introduce new variable 
> to store the git revision and leave the svn revision variable unchanged.
> build.xml, and org.apache.zookeeper.version.util.VerGen also need to be 
> modified. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Willing to Contribute to this Project

[Rakesh Radhakrishnan]

Thank you for your interest in ZooKeeper!

https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute wiki
page is a good resource for new folks interested in participating.

Please feel free to post patches on ZooKeeper JIRA issues that interest
you. If there is any question about how to proceed on an issue, then please
either discuss directly on the JIRA or send an e-mail to ZooKeeper dev list.

Helper links:-
Issue Tracker: https://issues.apache.org/jira/browse/ZOOKEEPER
Mailing list: http://zookeeper.apache.org/lists.html
Docs: https://zookeeper.apache.org/doc/r3.5.2-alpha/

Cheers,
Rakesh

On Tue, Jan 17, 2017 at 10:20 PM, Amol Kulkarni  wrote:

> Hi there,
>
> This is Amol Kulkarni here,i'm looking forward to contribute to open source
> projects in Java technologies and came across the zookeeper project.
> I'm willing to contribute to make any changes/issues available.
> I have been working Java technologies for the last 5 year's,looking forward
> to contribute in projects.
>
> Would be very greatful,if get assistance  to get an idea how to start with
> it.
> Awaiting your response.
>
> --
> *Thanks & Regards*
> *Amol Kulkarni *
>

Re: ZooKeeper cwiki - Updated ZooKeeper and SASL auth 1045 work

[Patrick Hunt]

Rakesh, send me your cwiki ID and I'll add the proper permissions for you.

Patrick

On Tue, Jan 17, 2017 at 5:58 PM, Rakesh Radhakrishnan 
wrote:

> Hi PMCs,
>
> I don't have permission to delete cwiki page. Presently, I have renamed our
> old sasl page to "https://cwiki.apache.org/confluence/display/ZOOKEEPER/
> Zookeeper+and+SASL-Backup". Could you please delete this page from
> ZooKeeper project cwiki pages. Thanks!
>
> Thanks,
> Rakesh
>
> On Mon, Jan 16, 2017 at 10:31 PM, Rakesh Radhakrishnan  >
> wrote:
>
> > Hi All,
> >
> > FYI, I'm planning to delete our existing "https://cwiki.apache.org/conf
> > luence/display/ZOOKEEPER/Zookeeper+and+SASL" web page by tomorrow (IST).
> >
> > Then rename https://cwiki.apache.org/confluence/display/
> > ZOOKEEPER/ZooKeeper+and+SASL+authentication web page to "
> > https://cwiki.apache.org/confluence/display/ZOOKEEPER/Zookeeper+and+SASL
> "
> > in place of the deleted page.
> >
> > Please let me know if you have any comments. Thanks!
> >
> > Regards,
> > Rakesh
> >
> > On Tue, Dec 20, 2016 at 6:03 PM, Rakesh Radhakrishnan <
> rake...@apache.org>
> > wrote:
> >
> >> Like I mentioned at the beginning of this mail thread, presently I've
> >> maintained this original page as a history. How about deleting this old
> >> page now and rename the newly added "https://cwiki.apache.org/conf
> >> luence/display/ZOOKEEPER/ZooKeeper+and+SASL+authentication" in place of
> >> the old page? I think, that will help the existing webpages to continue
> >> referring to a valid cwiki ZK sasl page. Otw those links becomes stale.
> >>
> >> I could see many blogs, wiki already have a reference link to our
> >> existing "https://cwiki.apache.org/confluence/display/ZOOKEEPER/Zooke
> >> eper+and+SASL" page.
> >>
> >> Following are few blogs/sites which has a reference to the ZK SASL
> page:-
> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-38%3A+
> >> ZooKeeper+Authentication
> >> http://blog.intelligencecomputing.io/security/12409/repost-z
> >> ookeeper-and-sasl
> >>
> >> Thanks,
> >> Rakesh
> >>
> >>
> >> On Tue, Dec 20, 2016 at 7:02 AM, Patrick Hunt  wrote:
> >>
> >>> LGTM. Those changes are very helpful, thanks Rakesh!
> >>>
> >>> Patrick
> >>>
> >>> On Mon, Dec 19, 2016 at 12:04 PM, Rakesh Radhakrishnan <
> >>> rake...@apache.org>
> >>> wrote:
> >>>
> >>> > Thanks a lot Patrick Hunt for the review comments. Please take
> another
> >>> look
> >>> > at the wiki page when you get a chance.
> >>> >
> >>> > I've updated the wiki page addressing these,.
> >>> >
> >>> > 1) ===> DONE. Added JCE encryption part.
> >>> > 2) ===> DONE. Corrected case.
> >>> > 3) ===> DONE. Included version.
> >>> > 4) ===> DONE. Corrected numbering format.
> >>> > 5) ===> DONE. Added an example case to understand the tuning
> mechanism.
> >>> > 6) ===> DONE. I've removed this part because it can be discussed
> >>> separately
> >>> > and added if someone has a use case.
> >>> > 7) ===> DONE. Rephrased upgrade feature section
> >>> >
> >>> > Thanks,
> >>> > Rakesh
> >>> >
> >>> > On Wed, Dec 14, 2016 at 9:03 AM, Patrick Hunt 
> >>> wrote:
> >>> >
> >>> > > Nice job Rakesh, some comments:
> >>> > >
> >>> > > 1) the appendix is a great idea, should be useful for many people.
> >>> One
> >>> > > thing I noticed
> >>> > > "There is no additional dependencies needed to use SASL with Java
> >>> since
> >>> > it
> >>> > > is part of the the Java Standard Edition." - you might want to
> >>> > mention/link
> >>> > > the JCE? The JVM doesn't come with very modern encryption - some of
> >>> the
> >>> > > distros use more strong encryption out of the box with kerberos.
> >>> I've run
> >>> > > into this a number of times (need to also install JCE).
> >>> > >
> >>> > > 2) consistently use "ZooKeeper" rather than "Zookeeper". Only
> noticed
> >>> > this
> >>> > > in a few places...
> >>> > >
> >>> > > 3) on client-server it would be good to mention when it was added
> >>> > (3.4.0+),
> >>> > > similar to what you did with 1045.
> >>> > >
> >>> > > 4) on "ZooKeeper SASL configurations" the numbering of the bullets
> >>> starts
> >>> > > at 2.1. and finishes at 2.4. I suspect the formatting didn't copy
> >>> over
> >>> > > quite right?
> >>> > >
> >>> > > 5) similar formatting issue for "# Defaulting to
> >>> > > 20quorum.cnxn.threads.size=20"
> >>> > >
> >>> > > Can we give any insight into how this value should be set? i.e. why
> >>> is 20
> >>> > > the default and when should it be raised/lowered?
> >>> > >
> >>> > > 6) can the doc shed any light on why we are recommending
> >>> > > "javax.security.auth.useSubjectCredsOnly=false" ? I'm not familiar
> >>> with
> >>> > > this myself.
> >>> > >
> >>> > > 7) "This feature is supported in 3.4 branch" is ambiguous - perhaps
> >>> > > rephrase. What "feature" are you referring to, 1045 or to rolling
> >>> > upgrade?
> >>> > > Also the ref to 3.4 itself is ambiguous - perhaps change to
> 3.4.10+?
> 

Re: ZooKeeper cwiki - Updated ZooKeeper and SASL auth 1045 work

[Rakesh Radhakrishnan]

Hi PMCs,

I don't have permission to delete cwiki page. Presently, I have renamed our
old sasl page to "https://cwiki.apache.org/confluence/display/ZOOKEEPER/
Zookeeper+and+SASL-Backup". Could you please delete this page from
ZooKeeper project cwiki pages. Thanks!

Thanks,
Rakesh

On Mon, Jan 16, 2017 at 10:31 PM, Rakesh Radhakrishnan 
wrote:

> Hi All,
>
> FYI, I'm planning to delete our existing "https://cwiki.apache.org/conf
> luence/display/ZOOKEEPER/Zookeeper+and+SASL" web page by tomorrow (IST).
>
> Then rename https://cwiki.apache.org/confluence/display/
> ZOOKEEPER/ZooKeeper+and+SASL+authentication web page to "
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/Zookeeper+and+SASL;
> in place of the deleted page.
>
> Please let me know if you have any comments. Thanks!
>
> Regards,
> Rakesh
>
> On Tue, Dec 20, 2016 at 6:03 PM, Rakesh Radhakrishnan 
> wrote:
>
>> Like I mentioned at the beginning of this mail thread, presently I've
>> maintained this original page as a history. How about deleting this old
>> page now and rename the newly added "https://cwiki.apache.org/conf
>> luence/display/ZOOKEEPER/ZooKeeper+and+SASL+authentication" in place of
>> the old page? I think, that will help the existing webpages to continue
>> referring to a valid cwiki ZK sasl page. Otw those links becomes stale.
>>
>> I could see many blogs, wiki already have a reference link to our
>> existing "https://cwiki.apache.org/confluence/display/ZOOKEEPER/Zooke
>> eper+and+SASL" page.
>>
>> Following are few blogs/sites which has a reference to the ZK SASL page:-
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-38%3A+
>> ZooKeeper+Authentication
>> http://blog.intelligencecomputing.io/security/12409/repost-z
>> ookeeper-and-sasl
>>
>> Thanks,
>> Rakesh
>>
>>
>> On Tue, Dec 20, 2016 at 7:02 AM, Patrick Hunt  wrote:
>>
>>> LGTM. Those changes are very helpful, thanks Rakesh!
>>>
>>> Patrick
>>>
>>> On Mon, Dec 19, 2016 at 12:04 PM, Rakesh Radhakrishnan <
>>> rake...@apache.org>
>>> wrote:
>>>
>>> > Thanks a lot Patrick Hunt for the review comments. Please take another
>>> look
>>> > at the wiki page when you get a chance.
>>> >
>>> > I've updated the wiki page addressing these,.
>>> >
>>> > 1) ===> DONE. Added JCE encryption part.
>>> > 2) ===> DONE. Corrected case.
>>> > 3) ===> DONE. Included version.
>>> > 4) ===> DONE. Corrected numbering format.
>>> > 5) ===> DONE. Added an example case to understand the tuning mechanism.
>>> > 6) ===> DONE. I've removed this part because it can be discussed
>>> separately
>>> > and added if someone has a use case.
>>> > 7) ===> DONE. Rephrased upgrade feature section
>>> >
>>> > Thanks,
>>> > Rakesh
>>> >
>>> > On Wed, Dec 14, 2016 at 9:03 AM, Patrick Hunt 
>>> wrote:
>>> >
>>> > > Nice job Rakesh, some comments:
>>> > >
>>> > > 1) the appendix is a great idea, should be useful for many people.
>>> One
>>> > > thing I noticed
>>> > > "There is no additional dependencies needed to use SASL with Java
>>> since
>>> > it
>>> > > is part of the the Java Standard Edition." - you might want to
>>> > mention/link
>>> > > the JCE? The JVM doesn't come with very modern encryption - some of
>>> the
>>> > > distros use more strong encryption out of the box with kerberos.
>>> I've run
>>> > > into this a number of times (need to also install JCE).
>>> > >
>>> > > 2) consistently use "ZooKeeper" rather than "Zookeeper". Only noticed
>>> > this
>>> > > in a few places...
>>> > >
>>> > > 3) on client-server it would be good to mention when it was added
>>> > (3.4.0+),
>>> > > similar to what you did with 1045.
>>> > >
>>> > > 4) on "ZooKeeper SASL configurations" the numbering of the bullets
>>> starts
>>> > > at 2.1. and finishes at 2.4. I suspect the formatting didn't copy
>>> over
>>> > > quite right?
>>> > >
>>> > > 5) similar formatting issue for "# Defaulting to
>>> > > 20quorum.cnxn.threads.size=20"
>>> > >
>>> > > Can we give any insight into how this value should be set? i.e. why
>>> is 20
>>> > > the default and when should it be raised/lowered?
>>> > >
>>> > > 6) can the doc shed any light on why we are recommending
>>> > > "javax.security.auth.useSubjectCredsOnly=false" ? I'm not familiar
>>> with
>>> > > this myself.
>>> > >
>>> > > 7) "This feature is supported in 3.4 branch" is ambiguous - perhaps
>>> > > rephrase. What "feature" are you referring to, 1045 or to rolling
>>> > upgrade?
>>> > > Also the ref to 3.4 itself is ambiguous - perhaps change to 3.4.10+?
>>> > >
>>> > > These are some minor nits, overall impressive effort -- thanks again
>>> > > Rakesh!
>>> > >
>>> > > Patrick
>>> > >
>>> > >
>>> > >
>>> > > On Tue, Dec 13, 2016 at 6:56 PM, Rakesh Radhakrishnan <
>>> > rake...@apache.org>
>>> > > wrote:
>>> > >
>>> > > > Hi All,
>>> > > >
>>> > > > I've incorporated ZK-1045 feature details into the Apache ZooKeeper
>>> > > project
>>> > > > cwiki. Since "ZooKeeper and SASL" section is quite 

[jira] [Comment Edited] (ZOOKEEPER-2139) Support multiple ZooKeeper client, with different configurations, in a single JVM

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827233#comment-15827233
 ] 

Rakesh R edited comment on ZOOKEEPER-2139 at 1/18/17 1:50 AM:
--

bq. I just found that the bug exists in our patch but not in the original 
attached to this issue. It looks like there was a mistake while applying the 
patch.
[~haridsv], do you meant ZOOKEEPER-2667 is not a problem. If so, shall we close 
this?


was (Author: rakeshr):
bq. I just found that the bug exists in our patch but not in the original 
attached to this issue. It looks like there was a mistake while applying the 
patch.
Do you meant ZOOKEEPER-2667 is an invalid issue. If so, shall we close this?

> Support multiple ZooKeeper client, with different configurations, in a single 
> JVM
> -
>
> Key: ZOOKEEPER-2139
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client
>Affects Versions: 3.5.0
>Reporter: Surendra Singh Lilhore
>Assignee: Arshad Mohammad
>Priority: Blocker
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139-06.patch, 
> ZOOKEEPER-2139-07.patch, ZOOKEEPER-2139-08.patch, ZOOKEEPER-2139-09.patch, 
> ZOOKEEPER-2139-10.patch, ZOOKEEPER-2139-11.patch, ZOOKEEPER-2139-12.patch, 
> ZOOKEEPER-2139-13.patch, ZOOKEEPER-2139-14.patch, ZOOKEEPER-2139_1.patch, 
> ZOOKEEPER-2139_2.patch, ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch
>
>
> I have two ZK client in one JVM, one is secure client and second is normal 
> client (For non secure cluster).
> "zookeeper.sasl.client" system property is "true" by default, because of this 
> my second client connection is failing.
> We should pass all client configurations in client constructor like HDFS 
> client.
> For example :
> {code}
> public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, 
> Configuration conf) throws IOException
>   {
>   ..
>   ..
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2139) Support multiple ZooKeeper client, with different configurations, in a single JVM

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827233#comment-15827233
 ] 

Rakesh R commented on ZOOKEEPER-2139:
-

bq. I just found that the bug exists in our patch but not in the original 
attached to this issue. It looks like there was a mistake while applying the 
patch.
Do you meant ZOOKEEPER-2667 is an invalid issue. If so, shall we close this?

> Support multiple ZooKeeper client, with different configurations, in a single 
> JVM
> -
>
> Key: ZOOKEEPER-2139
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client
>Affects Versions: 3.5.0
>Reporter: Surendra Singh Lilhore
>Assignee: Arshad Mohammad
>Priority: Blocker
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139-06.patch, 
> ZOOKEEPER-2139-07.patch, ZOOKEEPER-2139-08.patch, ZOOKEEPER-2139-09.patch, 
> ZOOKEEPER-2139-10.patch, ZOOKEEPER-2139-11.patch, ZOOKEEPER-2139-12.patch, 
> ZOOKEEPER-2139-13.patch, ZOOKEEPER-2139-14.patch, ZOOKEEPER-2139_1.patch, 
> ZOOKEEPER-2139_2.patch, ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch
>
>
> I have two ZK client in one JVM, one is secure client and second is normal 
> client (For non secure cluster).
> "zookeeper.sasl.client" system property is "true" by default, because of this 
> my second client connection is failing.
> We should pass all client configurations in client constructor like HDFS 
> client.
> For example :
> {code}
> public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, 
> Configuration conf) throws IOException
>   {
>   ..
>   ..
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk - Build # 3241 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/3241/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 488294 lines...]
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-01-18 00:24:14,016 [myid:127.0.0.1:30199] - INFO  
[main-SendThread(127.0.0.1:30199):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:30199. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-01-18 00:24:14,016 [myid:127.0.0.1:30199] - WARN  
[main-SendThread(127.0.0.1:30199):ClientCnxn$SendThread@1235] - Session 
0x2023f6399b3 for server 127.0.0.1/127.0.0.1:30199, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-01-18 00:24:14,036 [myid:] - INFO  [ProcessThread(sid:0 
cport:30319)::PrepRequestProcessor@618] - Processed session termination for 
sessionid: 0x1023f66f00d
[junit] 2017-01-18 00:24:14,047 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port30319,name1=Connections,name2=127.0.0.1,name3=0x1023f66f00d]
[junit] 2017-01-18 00:24:14,047 [myid:] - INFO  [main:ZooKeeper@1324] - 
Session: 0x1023f66f00d closed
[junit] 2017-01-18 00:24:14,047 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 146389
[junit] 2017-01-18 00:24:14,050 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 1644
[junit] 2017-01-18 00:24:14,050 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2017-01-18 00:24:14,050 [myid:] - INFO  [main:ClientBase@558] - 
tearDown starting
[junit] 2017-01-18 00:24:14,050 [myid:] - INFO  [main:ClientBase@528] - 
STOPPING server
[junit] 2017-01-18 00:24:14,050 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:30319
[junit] 2017-01-18 00:24:14,047 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1023f66f00d
[junit] 2017-01-18 00:24:14,056 [myid:] - INFO  [main:ZooKeeperServer@534] 
- shutting down
[junit] 2017-01-18 00:24:14,057 [myid:] - ERROR [main:ZooKeeperServer@506] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-01-18 00:24:14,057 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-01-18 00:24:14,057 [myid:] - INFO  
[main:PrepRequestProcessor@1009] - Shutting down
[junit] 2017-01-18 00:24:14,057 [myid:] - INFO  [ProcessThread(sid:0 
cport:30319)::PrepRequestProcessor@157] - PrepRequestProcessor exited loop!
[junit] 2017-01-18 00:24:14,057 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-01-18 00:24:14,057 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-01-18 00:24:14,058 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-01-18 00:24:14,058 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port30319,name1=InMemoryDataTree]
[junit] 2017-01-18 00:24:14,058 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port30319]
[junit] 2017-01-18 00:24:14,058 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 30319
[junit] 2017-01-18 00:24:14,059 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2017-01-18 00:24:14,065 [myid:] - INFO  [main:ClientBase@583] - 
fdcount after test is: 4831 at start it was 4831
[junit] 2017-01-18 00:24:14,066 [myid:] - INFO  [main:ZKTestCase$1@65] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2017-01-18 00:24:14,066 [myid:] - INFO  [main:ZKTestCase$1@60] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 103, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
566.189 sec, Thread: 8, Class: 

[jira] [Commented] (ZOOKEEPER-2325) Data inconsistency if all snapshots empty or missing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827051#comment-15827051
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2325:
---

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/144#discussion_r96525078
  
--- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 
---
@@ -37,6 +37,8 @@
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.Map;
--- End diff --

nit: i don't think that this import is needed


> Data inconsistency if all snapshots empty or missing
> 
>
> Key: ZOOKEEPER-2325
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2325
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6
>Reporter: Andrew Grasso
>Priority: Critical
> Fix For: 3.5.3, 3.6.0
>
> Attachments: zk.patch, ZOOKEEPER-2325.001.patch, 
> ZOOKEEPER-2325-test.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When loading state from snapshots on startup, FileTxnSnapLog.java ignores the 
> result of FileSnap.deserialize, which is -1L if no valid snapshots are found. 
> Recovery proceeds with dt.lastProcessed == 0, its initial value.
> The result is that Zookeeper will process the transaction logs and then begin 
> serving requests with a different state than the rest of the ensemble.
> To reproduce:
> In a healthy zookeeper cluster of size >= 3, shut down one node.
> Either delete all snapshots for this node or change all to be empty files.
> Restart the node.
> We believe this can happen organically if a node runs out of disk space.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2325) Data inconsistency if all snapshots empty or missing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827050#comment-15827050
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2325:
---

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/144#discussion_r96534854
  
--- Diff: 
src/java/test/org/apache/zookeeper/test/EmptiedSnapshotRecoveryTest.java ---
@@ -0,0 +1,133 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.test;
+
+import java.io.IOException;
+import java.io.File;
+import java.io.PrintWriter;
+import java.util.List;
+import java.util.LinkedList;
--- End diff --

a couple unneeded imports here as well


> Data inconsistency if all snapshots empty or missing
> 
>
> Key: ZOOKEEPER-2325
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2325
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6
>Reporter: Andrew Grasso
>Priority: Critical
> Fix For: 3.5.3, 3.6.0
>
> Attachments: zk.patch, ZOOKEEPER-2325.001.patch, 
> ZOOKEEPER-2325-test.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When loading state from snapshots on startup, FileTxnSnapLog.java ignores the 
> result of FileSnap.deserialize, which is -1L if no valid snapshots are found. 
> Recovery proceeds with dt.lastProcessed == 0, its initial value.
> The result is that Zookeeper will process the transaction logs and then begin 
> serving requests with a different state than the rest of the ensemble.
> To reproduce:
> In a healthy zookeeper cluster of size >= 3, shut down one node.
> Either delete all snapshots for this node or change all to be empty files.
> Restart the node.
> We believe this can happen organically if a node runs out of disk space.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2325) Data inconsistency if all snapshots empty or missing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827048#comment-15827048
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2325:
---

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/144#discussion_r96526559
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -135,8 +135,22 @@ public File getSnapDir() {
  */
 public long restore(DataTree dt, Map sessions, 
 PlayBackListener listener) throws IOException {
-snapLog.deserialize(dt, sessions);
+long deserializeResult = snapLog.deserialize(dt, sessions);
 FileTxnLog txnLog = new FileTxnLog(dataDir);
+if (-1L == deserializeResult) {
+/* this means that we couldn't find any snapshot, so we need to
+ * initialize an empty database (reported in ZOOKEEPER-2325) */
+if (txnLog.getLastLoggedZxid() != -1) {
--- End diff --

would it be worth adding the -1 case to the javadoc for deserialize?


> Data inconsistency if all snapshots empty or missing
> 
>
> Key: ZOOKEEPER-2325
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2325
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6
>Reporter: Andrew Grasso
>Priority: Critical
> Fix For: 3.5.3, 3.6.0
>
> Attachments: zk.patch, ZOOKEEPER-2325.001.patch, 
> ZOOKEEPER-2325-test.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When loading state from snapshots on startup, FileTxnSnapLog.java ignores the 
> result of FileSnap.deserialize, which is -1L if no valid snapshots are found. 
> Recovery proceeds with dt.lastProcessed == 0, its initial value.
> The result is that Zookeeper will process the transaction logs and then begin 
> serving requests with a different state than the rest of the ensemble.
> To reproduce:
> In a healthy zookeeper cluster of size >= 3, shut down one node.
> Either delete all snapshots for this node or change all to be empty files.
> Restart the node.
> We believe this can happen organically if a node runs out of disk space.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2325) Data inconsistency if all snapshots empty or missing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827049#comment-15827049
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2325:
---

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/144#discussion_r96534436
  
--- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 
---
@@ -37,6 +37,8 @@
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.Map;
--- End diff --

this change appears to break `testDirtySnapshot`


> Data inconsistency if all snapshots empty or missing
> 
>
> Key: ZOOKEEPER-2325
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2325
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6
>Reporter: Andrew Grasso
>Priority: Critical
> Fix For: 3.5.3, 3.6.0
>
> Attachments: zk.patch, ZOOKEEPER-2325.001.patch, 
> ZOOKEEPER-2325-test.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When loading state from snapshots on startup, FileTxnSnapLog.java ignores the 
> result of FileSnap.deserialize, which is -1L if no valid snapshots are found. 
> Recovery proceeds with dt.lastProcessed == 0, its initial value.
> The result is that Zookeeper will process the transaction logs and then begin 
> serving requests with a different state than the rest of the ensemble.
> To reproduce:
> In a healthy zookeeper cluster of size >= 3, shut down one node.
> Either delete all snapshots for this node or change all to be empty files.
> Restart the node.
> We believe this can happen organically if a node runs out of disk space.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #144: ZOOKEEPER-2325 for branch-3.4.

[afine]

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/144#discussion_r96534436
  
--- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 
---
@@ -37,6 +37,8 @@
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.Map;
--- End diff --

this change appears to break `testDirtySnapshot`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #144: ZOOKEEPER-2325 for branch-3.4.

[afine]

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/144#discussion_r96525078
  
--- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 
---
@@ -37,6 +37,8 @@
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.Map;
--- End diff --

nit: i don't think that this import is needed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #144: ZOOKEEPER-2325 for branch-3.4.

[afine]

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/144#discussion_r96526559
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -135,8 +135,22 @@ public File getSnapDir() {
  */
 public long restore(DataTree dt, Map sessions, 
 PlayBackListener listener) throws IOException {
-snapLog.deserialize(dt, sessions);
+long deserializeResult = snapLog.deserialize(dt, sessions);
 FileTxnLog txnLog = new FileTxnLog(dataDir);
+if (-1L == deserializeResult) {
+/* this means that we couldn't find any snapshot, so we need to
+ * initialize an empty database (reported in ZOOKEEPER-2325) */
+if (txnLog.getLastLoggedZxid() != -1) {
--- End diff --

would it be worth adding the -1 case to the javadoc for deserialize?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #144: ZOOKEEPER-2325 for branch-3.4.

[afine]

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/144#discussion_r96534854
  
--- Diff: 
src/java/test/org/apache/zookeeper/test/EmptiedSnapshotRecoveryTest.java ---
@@ -0,0 +1,133 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.test;
+
+import java.io.IOException;
+import java.io.File;
+import java.io.PrintWriter;
+import java.util.List;
+import java.util.LinkedList;
--- End diff --

a couple unneeded imports here as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826940#comment-15826940
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/122
  
Just to close the loop here:

The PR for master branch is now: 
https://github.com/apache/zookeeper/pull/152
The PR for branch-3.5 is now: https://github.com/apache/zookeeper/pull/151


> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2642-3.5.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826937#comment-15826937
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/152
  
+1, thanks @Randgalt. 
@fpj Shall I merge this in (along with 
https://github.com/apache/zookeeper/pull/151)?


> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2642-3.5.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826938#comment-15826938
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/152
  
>> Do I need to create a new patch file or is that no longer necessary?

No need to create a patch file separately - a pull request is enough.


> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2642-3.5.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper issue #152: [ZOOKEEPER-2642] reconfig() is now named reconfigure()...

[hanm]

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/152
  
>> Do I need to create a new patch file or is that no longer necessary?

No need to create a patch file separately - a pull request is enough.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper issue #152: [ZOOKEEPER-2642] reconfig() is now named reconfigure()...

[hanm]

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/152
  
+1, thanks @Randgalt. 
@fpj Shall I merge this in (along with 
https://github.com/apache/zookeeper/pull/151)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826845#comment-15826845
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2184:
---

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96512625
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
+ * string representation of the IP address.
+ *
+ * @param addr
+ * @return Hostname string of address parameter
+ */
+private String getHostString(InetSocketAddress addr) {
+String hostString;
+InetAddress ia = addr.getAddress();
+
+if (ia != null) {
+// If the string starts with '/', then it has no hostname
+// and we want to avoid the reverse lookup, so we return
+// the string representation of the address.
+if (ia.toString().startsWith("/")) {
+hostString = ia.getHostAddress();
+} else {
+hostString = addr.getHostName();
+}
+} else {
+// According to the Java 6 documentation, if the hostname is
+// unresolved, then the string before the colon is the 
hostname.
+String addrString = addr.toString();
+hostString = addrString.substring(0, 
addrString.lastIndexOf(':'));
+}
+
+return hostString;
+}
+
 public int size() {
 return serverAddresses.size();
 }
 
 public InetSocketAddress next(long spinDelay) {
-++currentIndex;
-if (currentIndex == serverAddresses.size()) {
-currentIndex = 0;
+// Handle possible connection error by re-resolving hostname if 
possible
+if (!connectedSinceNext) {
+InetSocketAddress curAddr = serverAddresses.get(currentIndex);
+if 
(!curAddr.getHostString().equals(curAddr.getAddress().getHostAddress())) {
+try {
+int thePort = curAddr.getPort();
+InetAddress resolvedAddresses[] = 
InetAddress.getAllByName(getHostString(curAddr));
+if (resolvedAddresses.length == 1) {
+serverAddresses.set(currentIndex, new 
InetSocketAddress(resolvedAddresses[0], thePort));
+} else {
+serverAddresses.remove(currentIndex);
--- End diff --

In the case where during the construction of the `StaticHostProvider` we 
add a host H1 which resolves to addresses A,B,C. Then at some point in the 
future A goes offline and the DNS system has changed H1 to resolve to hosts 
D,E,F. With the current code wouldn't `serverAddresses` now contain hosts 
B,C,D,E,F instead of only hosts D,E,F?

Is this something even worth fixing?


> Zookeeper Client should re-resolve hosts when connection attempts fail
> --
>
> Key: ZOOKEEPER-2184
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2184
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6, 3.5.0
> Environment: Ubuntu 14.04 host, Docker containers for Zookeeper & 
> Kafka
>Reporter: Robert P. Thille
>Assignee: Flavio Junqueira
>  Labels: easyfix, patch
> Fix For: 3.4.10, 3.5.3
>
> Attachments: ZOOKEEPER-2184.patch
>
>
> Testing in a Docker environment with a single Kafka instance using a single 
> Zookeeper instance. Restarting the Zookeeper container will cause it to 
> receive a new IP address. Kafka will never be able to reconnect to Zookeeper 
> and will hang indefinitely. Updating DNS or /etc/hosts with the new IP 
> address will not help the client to reconnect as the 
> zookeeper/client/StaticHostProvider resolves the connection string hosts at 
> creation time and never re-resolves.
> A solution would be for the client to notice that connection attempts fail 
> and attempt to re-resolve the hostnames in the connectString.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826844#comment-15826844
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2184:
---

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96509432
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
+ * string representation of the IP address.
+ *
+ * @param addr
+ * @return Hostname string of address parameter
+ */
+private String getHostString(InetSocketAddress addr) {
+String hostString;
+InetAddress ia = addr.getAddress();
+
+if (ia != null) {
--- End diff --

instead of `null` checking `ia` couldn't we use `addr.isUnresolved()`?


> Zookeeper Client should re-resolve hosts when connection attempts fail
> --
>
> Key: ZOOKEEPER-2184
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2184
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6, 3.5.0
> Environment: Ubuntu 14.04 host, Docker containers for Zookeeper & 
> Kafka
>Reporter: Robert P. Thille
>Assignee: Flavio Junqueira
>  Labels: easyfix, patch
> Fix For: 3.4.10, 3.5.3
>
> Attachments: ZOOKEEPER-2184.patch
>
>
> Testing in a Docker environment with a single Kafka instance using a single 
> Zookeeper instance. Restarting the Zookeeper container will cause it to 
> receive a new IP address. Kafka will never be able to reconnect to Zookeeper 
> and will hang indefinitely. Updating DNS or /etc/hosts with the new IP 
> address will not help the client to reconnect as the 
> zookeeper/client/StaticHostProvider resolves the connection string hosts at 
> creation time and never re-resolves.
> A solution would be for the client to notice that connection attempts fail 
> and attempt to re-resolve the hostnames in the connectString.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826846#comment-15826846
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2184:
---

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96509843
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,12 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
--- End diff --

nit: Can we swap the first two lines of this comment, as the reader does 
not know what class getHostString belongs to until he/she reaches line 2?


> Zookeeper Client should re-resolve hosts when connection attempts fail
> --
>
> Key: ZOOKEEPER-2184
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2184
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6, 3.5.0
> Environment: Ubuntu 14.04 host, Docker containers for Zookeeper & 
> Kafka
>Reporter: Robert P. Thille
>Assignee: Flavio Junqueira
>  Labels: easyfix, patch
> Fix For: 3.4.10, 3.5.3
>
> Attachments: ZOOKEEPER-2184.patch
>
>
> Testing in a Docker environment with a single Kafka instance using a single 
> Zookeeper instance. Restarting the Zookeeper container will cause it to 
> receive a new IP address. Kafka will never be able to reconnect to Zookeeper 
> and will hang indefinitely. Updating DNS or /etc/hosts with the new IP 
> address will not help the client to reconnect as the 
> zookeeper/client/StaticHostProvider resolves the connection string hosts at 
> creation time and never re-resolves.
> A solution would be for the client to notice that connection attempts fail 
> and attempt to re-resolve the hostnames in the connectString.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #150: ZOOKEEPER-2184: Zookeeper Client should re-reso...

[afine]

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96509843
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,12 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
--- End diff --

nit: Can we swap the first two lines of this comment, as the reader does 
not know what class getHostString belongs to until he/she reaches line 2?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #150: ZOOKEEPER-2184: Zookeeper Client should re-reso...

[afine]

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96512625
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
+ * string representation of the IP address.
+ *
+ * @param addr
+ * @return Hostname string of address parameter
+ */
+private String getHostString(InetSocketAddress addr) {
+String hostString;
+InetAddress ia = addr.getAddress();
+
+if (ia != null) {
+// If the string starts with '/', then it has no hostname
+// and we want to avoid the reverse lookup, so we return
+// the string representation of the address.
+if (ia.toString().startsWith("/")) {
+hostString = ia.getHostAddress();
+} else {
+hostString = addr.getHostName();
+}
+} else {
+// According to the Java 6 documentation, if the hostname is
+// unresolved, then the string before the colon is the 
hostname.
+String addrString = addr.toString();
+hostString = addrString.substring(0, 
addrString.lastIndexOf(':'));
+}
+
+return hostString;
+}
+
 public int size() {
 return serverAddresses.size();
 }
 
 public InetSocketAddress next(long spinDelay) {
-++currentIndex;
-if (currentIndex == serverAddresses.size()) {
-currentIndex = 0;
+// Handle possible connection error by re-resolving hostname if 
possible
+if (!connectedSinceNext) {
+InetSocketAddress curAddr = serverAddresses.get(currentIndex);
+if 
(!curAddr.getHostString().equals(curAddr.getAddress().getHostAddress())) {
+try {
+int thePort = curAddr.getPort();
+InetAddress resolvedAddresses[] = 
InetAddress.getAllByName(getHostString(curAddr));
+if (resolvedAddresses.length == 1) {
+serverAddresses.set(currentIndex, new 
InetSocketAddress(resolvedAddresses[0], thePort));
+} else {
+serverAddresses.remove(currentIndex);
--- End diff --

In the case where during the construction of the `StaticHostProvider` we 
add a host H1 which resolves to addresses A,B,C. Then at some point in the 
future A goes offline and the DNS system has changed H1 to resolve to hosts 
D,E,F. With the current code wouldn't `serverAddresses` now contain hosts 
B,C,D,E,F instead of only hosts D,E,F?

Is this something even worth fixing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #150: ZOOKEEPER-2184: Zookeeper Client should re-reso...

[afine]

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96509432
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
+ * string representation of the IP address.
+ *
+ * @param addr
+ * @return Hostname string of address parameter
+ */
+private String getHostString(InetSocketAddress addr) {
+String hostString;
+InetAddress ia = addr.getAddress();
+
+if (ia != null) {
--- End diff --

instead of `null` checking `ia` couldn't we use `addr.isUnresolved()`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Failed: ZOOKEEPER- PreCommit Build #217

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/217/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 486184 lines...]
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/217//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/217//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/217//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Unable to log in to server: 
https://issues.apache.org/jira/rpc/soap/jirasoapservice-v2 with user: hadoopqa.
 [exec]  Cause: ; nested exception is: 
 [exec] javax.net.ssl.SSLHandshakeException: 
sun.security.validator.ValidatorException: PKIX path building failed: 
sun.security.provider.certpath.SunCertPathBuilderException: unable to find 
valid certification path to requested target
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1630:
 exec returned: 1

Total time: 18 minutes 43 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Compressed 575.87 KB of artifacts by 38.9% relative to #210
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2642
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
2 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig

Error Message:
waiting for server 2 being up

Stack Trace:
junit.framework.AssertionFailedError: waiting for server 2 being up
at 
org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig(ReconfigRecoveryTest.java:529)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)


FAILED:  org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalObserverRun

Error Message:
Timeout occurred. Please note the time in the report does not reflect the time 
until the timeout.

Stack Trace:
junit.framework.AssertionFailedError: Timeout occurred. Please note the time in 
the report does not reflect the time until the timeout.
at java.lang.Thread.run(Thread.java:745)

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826580#comment-15826580
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
---

GitHub user Randgalt opened a pull request:

https://github.com/apache/zookeeper/pull/152

[ZOOKEEPER-2642] reconfig() is now named reconfigure() due to ZOOKEEPER-2642

Was #122

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Randgalt/zookeeper ZOOKEEPER-2642

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/152.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #152


commit 75932efb1099d8364149b12d808fc975b541c073
Author: randgalt 
Date:   2017-01-17T18:41:56Z

reconfig() is now named reconfigure() due to ZOOKEEPER-2642




> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2642-3.5.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826582#comment-15826582
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
---

Github user Randgalt commented on the issue:

https://github.com/apache/zookeeper/pull/152
  
Do I need to create a new patch file or is that no longer necessary?


> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2642-3.5.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper issue #152: [ZOOKEEPER-2642] reconfig() is now named reconfigure()...

[Randgalt]

Github user Randgalt commented on the issue:

https://github.com/apache/zookeeper/pull/152
  
Do I need to create a new patch file or is that no longer necessary?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #152: [ZOOKEEPER-2642] reconfig() is now named reconf...

[Randgalt]

GitHub user Randgalt opened a pull request:

https://github.com/apache/zookeeper/pull/152

[ZOOKEEPER-2642] reconfig() is now named reconfigure() due to ZOOKEEPER-2642

Was #122

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Randgalt/zookeeper ZOOKEEPER-2642

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/152.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #152


commit 75932efb1099d8364149b12d808fc975b541c073
Author: randgalt 
Date:   2017-01-17T18:41:56Z

reconfig() is now named reconfigure() due to ZOOKEEPER-2642




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826575#comment-15826575
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
---

Github user Randgalt closed the pull request at:

https://github.com/apache/zookeeper/pull/122


> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2642-3.5.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #122: [ZOOKEEPER-2642] Resurrect the reconfig() metho...

[Randgalt]

Github user Randgalt closed the pull request at:

https://github.com/apache/zookeeper/pull/122


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826569#comment-15826569
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/122
  
@Randgalt Exactly. Thanks!


> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2642-3.5.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper issue #122: [ZOOKEEPER-2642] Resurrect the reconfig() methods that...

[hanm]

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/122
  
@Randgalt Exactly. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Willing to Contribute to this Project

[Jordan Zimmerman]

we have many Pull Requests that could use review: 
https://github.com/apache/curator/pulls 


Also, have a look at our Issues database. Look first at issues that have the 
most votes or have the highest priority: 
https://issues.apache.org/jira/browse/CURATOR 


-Jordan

> On Jan 17, 2017, at 11:50 AM, Amol Kulkarni  wrote:
> 
> Hi there,
> 
> This is Amol Kulkarni here,i'm looking forward to contribute to open source
> projects in Java technologies and came across the zookeeper project.
> I'm willing to contribute to make any changes/issues available.
> I have been working Java technologies for the last 5 year's,looking forward
> to contribute in projects.
> 
> Would be very greatful,if get assistance  to get an idea how to start with
> it.
> Awaiting your response.
> 
> -- 
> *Thanks & Regards*
> *Amol Kulkarni *

[GitHub] zookeeper issue #122: [ZOOKEEPER-2642] Resurrect the reconfig() methods that...

[Randgalt]

Github user Randgalt commented on the issue:

https://github.com/apache/zookeeper/pull/122
  
OK - to be clear, I have PR #151 which applies the legacy API to 
branch-3.5. Then, I'll rework _this_ PR (against master) to only have the Admin 
API, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826552#comment-15826552
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
---

Github user Randgalt commented on the issue:

https://github.com/apache/zookeeper/pull/122
  
OK - to be clear, I have PR #151 which applies the legacy API to 
branch-3.5. Then, I'll rework _this_ PR (against master) to only have the Admin 
API, right?


> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2642-3.5.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826463#comment-15826463
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/122
  
>> Do we need a separate issue for the 3.6 change?

No we don't (what @fpj prefers wrapping both PR in one shot under 
ZOOKEEPER-2642). 

@Randgalt Do you mind update the current PR 
(https://github.com/apache/zookeeper/pull/122) so it apply to master, by 
removing the old reconfig APIs? 


> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2642-3.5.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper issue #122: [ZOOKEEPER-2642] Resurrect the reconfig() methods that...

[hanm]

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/122
  
>> Do we need a separate issue for the 3.6 change?

No we don't (what @fpj prefers wrapping both PR in one shot under 
ZOOKEEPER-2642). 

@Randgalt Do you mind update the current PR 
(https://github.com/apache/zookeeper/pull/122) so it apply to master, by 
removing the old reconfig APIs? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

ZooKeeper_branch35_solaris - Build # 399 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_solaris/399/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 464459 lines...]
[junit] 2017-01-17 17:14:46,533 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2017-01-17 17:14:46,534 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2017-01-17 17:14:46,534 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2017-01-17 17:14:46,535 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2017-01-17 17:14:46,535 [myid:] - INFO  [main:ZooKeeperServer@893] 
- minSessionTimeout set to 6000
[junit] 2017-01-17 17:14:46,535 [myid:] - INFO  [main:ZooKeeperServer@902] 
- maxSessionTimeout set to 6
[junit] 2017-01-17 17:14:46,536 [myid:] - INFO  [main:ZooKeeperServer@159] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test2685608969991430421.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test2685608969991430421.junit.dir/version-2
[junit] 2017-01-17 17:14:46,536 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test2685608969991430421.junit.dir/version-2/snapshot.b
[junit] 2017-01-17 17:14:46,538 [myid:] - INFO  [main:FileTxnSnapLog@320] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test2685608969991430421.junit.dir/version-2/snapshot.b
[junit] 2017-01-17 17:14:46,539 [myid:] - ERROR [main:ZooKeeperServer@505] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-01-17 17:14:46,540 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2017-01-17 17:14:46,540 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:62898
[junit] 2017-01-17 17:14:46,541 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:62898
[junit] 2017-01-17 17:14:46,541 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2017-01-17 17:14:46,541 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@614] - Closed socket connection for client 
/127.0.0.1:62898 (no session established for client)
[junit] 2017-01-17 17:14:46,541 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2017-01-17 17:14:46,542 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2017-01-17 17:14:46,543 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2017-01-17 17:14:46,543 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2017-01-17 17:14:46,543 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2017-01-17 17:14:46,543 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17890
[junit] 2017-01-17 17:14:46,543 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2017-01-17 17:14:46,544 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2017-01-17 17:14:46,544 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2017-01-17 17:14:46,622 [myid:] - INFO  [main:ZooKeeper@1322] - 
Session: 0x1262a65dbe0 closed
[junit] 2017-01-17 17:14:46,622 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1262a65dbe0
[junit] 2017-01-17 17:14:46,622 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2017-01-17 17:14:46,622 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2017-01-17 17:14:46,622 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2017-01-17 17:14:46,622 [myid:] - INFO  

[jira] [Commented] (ZOOKEEPER-2139) Support multiple ZooKeeper client, with different configurations, in a single JVM

[Hari Krishna Dara (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826402#comment-15826402
 ] 

Hari Krishna Dara commented on ZOOKEEPER-2139:
--

I just found that the bug exists in our patch but not in the original attached 
to this issue. It looks like there was a mistake while applying the patch.

> Support multiple ZooKeeper client, with different configurations, in a single 
> JVM
> -
>
> Key: ZOOKEEPER-2139
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client
>Affects Versions: 3.5.0
>Reporter: Surendra Singh Lilhore
>Assignee: Arshad Mohammad
>Priority: Blocker
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139-06.patch, 
> ZOOKEEPER-2139-07.patch, ZOOKEEPER-2139-08.patch, ZOOKEEPER-2139-09.patch, 
> ZOOKEEPER-2139-10.patch, ZOOKEEPER-2139-11.patch, ZOOKEEPER-2139-12.patch, 
> ZOOKEEPER-2139-13.patch, ZOOKEEPER-2139-14.patch, ZOOKEEPER-2139_1.patch, 
> ZOOKEEPER-2139_2.patch, ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch
>
>
> I have two ZK client in one JVM, one is secure client and second is normal 
> client (For non secure cluster).
> "zookeeper.sasl.client" system property is "true" by default, because of this 
> my second client connection is failing.
> We should pass all client configurations in client constructor like HDFS 
> client.
> For example :
> {code}
> public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, 
> Configuration conf) throws IOException
>   {
>   ..
>   ..
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Willing to Contribute to this Project

[Amol Kulkarni]

Hi there,

This is Amol Kulkarni here,i'm looking forward to contribute to open source
projects in Java technologies and came across the zookeeper project.
I'm willing to contribute to make any changes/issues available.
I have been working Java technologies for the last 5 year's,looking forward
to contribute in projects.

Would be very greatful,if get assistance  to get an idea how to start with
it.
Awaiting your response.

-- 
*Thanks & Regards*
*Amol Kulkarni *

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826375#comment-15826375
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
---

Github user Randgalt commented on the issue:

https://github.com/apache/zookeeper/pull/122
  
Do we need a separate issue for the 3.6 change?


> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2642-3.5.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper issue #122: [ZOOKEEPER-2642] Resurrect the reconfig() methods that...

[Randgalt]

Github user Randgalt commented on the issue:

https://github.com/apache/zookeeper/pull/122
  
Do we need a separate issue for the 3.6 change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826359#comment-15826359
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2184:
---

Github user rakeshadr commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96453176
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
+ * string representation of the IP address.
+ *
+ * @param addr
+ * @return Hostname string of address parameter
+ */
+private String getHostString(InetSocketAddress addr) {
+String hostString;
+InetAddress ia = addr.getAddress();
+
+if (ia != null) {
+// If the string starts with '/', then it has no hostname
+// and we want to avoid the reverse lookup, so we return
+// the string representation of the address.
+if (ia.toString().startsWith("/")) {
+hostString = ia.getHostAddress();
+} else {
+hostString = addr.getHostName();
+}
+} else {
+// According to the Java 6 documentation, if the hostname is
+// unresolved, then the string before the colon is the 
hostname.
+String addrString = addr.toString();
+hostString = addrString.substring(0, 
addrString.lastIndexOf(':'));
+}
+
+return hostString;
+}
+
 public int size() {
 return serverAddresses.size();
 }
 
 public InetSocketAddress next(long spinDelay) {
-++currentIndex;
-if (currentIndex == serverAddresses.size()) {
-currentIndex = 0;
+// Handle possible connection error by re-resolving hostname if 
possible
+if (!connectedSinceNext) {
+InetSocketAddress curAddr = serverAddresses.get(currentIndex);
+if 
(!curAddr.getHostString().equals(curAddr.getAddress().getHostAddress())) {
+try {
+int thePort = curAddr.getPort();
+InetAddress resolvedAddresses[] = 
InetAddress.getAllByName(getHostString(curAddr));
+if (resolvedAddresses.length == 1) {
+serverAddresses.set(currentIndex, new 
InetSocketAddress(resolvedAddresses[0], thePort));
+} else {
+serverAddresses.remove(currentIndex);
+for (InetAddress resolvedAddress : 
resolvedAddresses) {
+InetSocketAddress newAddr = new 
InetSocketAddress(resolvedAddress, thePort);
+if (!serverAddresses.contains(newAddr)) {
+serverAddresses.add(newAddr);
+}
+}
+}
+} catch (UnknownHostException e) {
+LOG.warn("Cannot re-resolve server: " + curAddr + " 
UnknownHostException: " + e);
--- End diff --

https://www.slf4j.org/api/org/slf4j/Logger.html#warn(org.slf4j.Marker, 
java.lang.String, java.lang.Throwable)

Can we do like,
LOG.warn("Cannot re-resolve server: {}, exception: ", curAddr, e);


> Zookeeper Client should re-resolve hosts when connection attempts fail
> --
>
> Key: ZOOKEEPER-2184
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2184
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6, 3.5.0
> Environment: Ubuntu 14.04 host, Docker containers for Zookeeper & 
> Kafka
>Reporter: Robert P. Thille
>Assignee: Flavio Junqueira
>  Labels: easyfix, patch
> Fix For: 3.4.10, 3.5.3
>
> Attachments: ZOOKEEPER-2184.patch
>
>
> Testing in a Docker environment with a single Kafka instance using a single 
> Zookeeper instance. Restarting the Zookeeper container will cause it to 
> receive a new IP address. Kafka will never be able to reconnect to Zookeeper 
> and will hang indefinitely. Updating DNS or /etc/hosts with the new IP 
> address will not help the client to 

[GitHub] zookeeper pull request #150: ZOOKEEPER-2184: Zookeeper Client should re-reso...

[rakeshadr]

Github user rakeshadr commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96453176
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
+ * string representation of the IP address.
+ *
+ * @param addr
+ * @return Hostname string of address parameter
+ */
+private String getHostString(InetSocketAddress addr) {
+String hostString;
+InetAddress ia = addr.getAddress();
+
+if (ia != null) {
+// If the string starts with '/', then it has no hostname
+// and we want to avoid the reverse lookup, so we return
+// the string representation of the address.
+if (ia.toString().startsWith("/")) {
+hostString = ia.getHostAddress();
+} else {
+hostString = addr.getHostName();
+}
+} else {
+// According to the Java 6 documentation, if the hostname is
+// unresolved, then the string before the colon is the 
hostname.
+String addrString = addr.toString();
+hostString = addrString.substring(0, 
addrString.lastIndexOf(':'));
+}
+
+return hostString;
+}
+
 public int size() {
 return serverAddresses.size();
 }
 
 public InetSocketAddress next(long spinDelay) {
-++currentIndex;
-if (currentIndex == serverAddresses.size()) {
-currentIndex = 0;
+// Handle possible connection error by re-resolving hostname if 
possible
+if (!connectedSinceNext) {
+InetSocketAddress curAddr = serverAddresses.get(currentIndex);
+if 
(!curAddr.getHostString().equals(curAddr.getAddress().getHostAddress())) {
+try {
+int thePort = curAddr.getPort();
+InetAddress resolvedAddresses[] = 
InetAddress.getAllByName(getHostString(curAddr));
+if (resolvedAddresses.length == 1) {
+serverAddresses.set(currentIndex, new 
InetSocketAddress(resolvedAddresses[0], thePort));
+} else {
+serverAddresses.remove(currentIndex);
+for (InetAddress resolvedAddress : 
resolvedAddresses) {
+InetSocketAddress newAddr = new 
InetSocketAddress(resolvedAddress, thePort);
+if (!serverAddresses.contains(newAddr)) {
+serverAddresses.add(newAddr);
+}
+}
+}
+} catch (UnknownHostException e) {
+LOG.warn("Cannot re-resolve server: " + curAddr + " 
UnknownHostException: " + e);
--- End diff --

https://www.slf4j.org/api/org/slf4j/Logger.html#warn(org.slf4j.Marker, 
java.lang.String, java.lang.Throwable)

Can we do like,
LOG.warn("Cannot re-resolve server: {}, exception: ", curAddr, e);


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826356#comment-15826356
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user praste commented on the issue:

https://github.com/apache/zookeeper/pull/148
  
I have made all the suggested  changes except for using List appender,  
which I will look into tonight


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper issue #148: ZOOKEEPER-2659 Log4j 2 migration

[praste]

Github user praste commented on the issue:

https://github.com/apache/zookeeper/pull/148
  
I have made all the suggested  changes except for using List appender,  
which I will look into tonight


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826295#comment-15826295
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2184:
---

Github user fpj commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96442215
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
+ * string representation of the IP address.
+ *
+ * @param addr
+ * @return Hostname string of address parameter
+ */
+private String getHostString(InetSocketAddress addr) {
+String hostString;
+InetAddress ia = addr.getAddress();
+
+if (ia != null) {
+// If the string starts with '/', then it has no hostname
+// and we want to avoid the reverse lookup, so we return
+// the string representation of the address.
+if (ia.toString().startsWith("/")) {
+hostString = ia.getHostAddress();
+} else {
+hostString = addr.getHostName();
+}
+} else {
+// According to the Java 6 documentation, if the hostname is
+// unresolved, then the string before the colon is the 
hostname.
+String addrString = addr.toString();
+hostString = addrString.substring(0, 
addrString.lastIndexOf(':'));
+}
+
+return hostString;
+}
+
 public int size() {
 return serverAddresses.size();
 }
 
 public InetSocketAddress next(long spinDelay) {
-++currentIndex;
-if (currentIndex == serverAddresses.size()) {
-currentIndex = 0;
+// Handle possible connection error by re-resolving hostname if 
possible
+if (!connectedSinceNext) {
+InetSocketAddress curAddr = serverAddresses.get(currentIndex);
+if 
(!curAddr.getHostString().equals(curAddr.getAddress().getHostAddress())) {
+try {
+int thePort = curAddr.getPort();
+InetAddress resolvedAddresses[] = 
InetAddress.getAllByName(getHostString(curAddr));
+if (resolvedAddresses.length == 1) {
+serverAddresses.set(currentIndex, new 
InetSocketAddress(resolvedAddresses[0], thePort));
+} else {
+serverAddresses.remove(currentIndex);
+for (InetAddress resolvedAddress : 
resolvedAddresses) {
+InetSocketAddress newAddr = new 
InetSocketAddress(resolvedAddress, thePort);
+if (!serverAddresses.contains(newAddr)) {
+serverAddresses.add(newAddr);
+}
+}
+}
+} catch (UnknownHostException e) {
+LOG.warn("Cannot re-resolve server: " + curAddr + " 
UnknownHostException: " + e);
--- End diff --

If the `StaticHostProvider` constructor didn't throw an 
`UnknownHostException`, then I'd think that all names and addresses we have are 
good. I'm not sure what could cause an `UnknownHostException` in `next()` other 
than some transient error. If that's right, then I'm not sure we should be 
adding or removing anything.


> Zookeeper Client should re-resolve hosts when connection attempts fail
> --
>
> Key: ZOOKEEPER-2184
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2184
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6, 3.5.0
> Environment: Ubuntu 14.04 host, Docker containers for Zookeeper & 
> Kafka
>Reporter: Robert P. Thille
>Assignee: Flavio Junqueira
>  Labels: easyfix, patch
> Fix For: 3.4.10, 3.5.3
>
> Attachments: ZOOKEEPER-2184.patch
>
>
> Testing in a Docker environment with a single Kafka instance using a single 
> Zookeeper instance. Restarting the Zookeeper container will cause it to 
> receive a new IP address. Kafka will never be able to reconnect to Zookeeper 
> and 

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826291#comment-15826291
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user jvz commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96442072
  
--- Diff: ivy.xml ---
@@ -41,13 +41,20 @@
 
   
 
-
+
+
+
+
+
+
+
--- End diff --

At first I read that it was version 3.0.0, sorry. Anyways, log4j 2 tends to 
stick with the latest versions of dependencies, so I'd recommend 3.3.6.


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #150: ZOOKEEPER-2184: Zookeeper Client should re-reso...

[fpj]

Github user fpj commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96442215
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
+ * string representation of the IP address.
+ *
+ * @param addr
+ * @return Hostname string of address parameter
+ */
+private String getHostString(InetSocketAddress addr) {
+String hostString;
+InetAddress ia = addr.getAddress();
+
+if (ia != null) {
+// If the string starts with '/', then it has no hostname
+// and we want to avoid the reverse lookup, so we return
+// the string representation of the address.
+if (ia.toString().startsWith("/")) {
+hostString = ia.getHostAddress();
+} else {
+hostString = addr.getHostName();
+}
+} else {
+// According to the Java 6 documentation, if the hostname is
+// unresolved, then the string before the colon is the 
hostname.
+String addrString = addr.toString();
+hostString = addrString.substring(0, 
addrString.lastIndexOf(':'));
+}
+
+return hostString;
+}
+
 public int size() {
 return serverAddresses.size();
 }
 
 public InetSocketAddress next(long spinDelay) {
-++currentIndex;
-if (currentIndex == serverAddresses.size()) {
-currentIndex = 0;
+// Handle possible connection error by re-resolving hostname if 
possible
+if (!connectedSinceNext) {
+InetSocketAddress curAddr = serverAddresses.get(currentIndex);
+if 
(!curAddr.getHostString().equals(curAddr.getAddress().getHostAddress())) {
+try {
+int thePort = curAddr.getPort();
+InetAddress resolvedAddresses[] = 
InetAddress.getAllByName(getHostString(curAddr));
+if (resolvedAddresses.length == 1) {
+serverAddresses.set(currentIndex, new 
InetSocketAddress(resolvedAddresses[0], thePort));
+} else {
+serverAddresses.remove(currentIndex);
+for (InetAddress resolvedAddress : 
resolvedAddresses) {
+InetSocketAddress newAddr = new 
InetSocketAddress(resolvedAddress, thePort);
+if (!serverAddresses.contains(newAddr)) {
+serverAddresses.add(newAddr);
+}
+}
+}
+} catch (UnknownHostException e) {
+LOG.warn("Cannot re-resolve server: " + curAddr + " 
UnknownHostException: " + e);
--- End diff --

If the `StaticHostProvider` constructor didn't throw an 
`UnknownHostException`, then I'd think that all names and addresses we have are 
good. I'm not sure what could cause an `UnknownHostException` in `next()` other 
than some transient error. If that's right, then I'm not sure we should be 
adding or removing anything.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #148: ZOOKEEPER-2659 Log4j 2 migration

[jvz]

Github user jvz commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96442072
  
--- Diff: ivy.xml ---
@@ -41,13 +41,20 @@
 
   
 
-
+
+
+
+
+
+
+
--- End diff --

At first I read that it was version 3.0.0, sorry. Anyways, log4j 2 tends to 
stick with the latest versions of dependencies, so I'd recommend 3.3.6.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826277#comment-15826277
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2184:
---

Github user fpj commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96439377
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
+ * string representation of the IP address.
+ *
+ * @param addr
+ * @return Hostname string of address parameter
+ */
+private String getHostString(InetSocketAddress addr) {
--- End diff --

We can do it, but I'm not super convinced we should because we are 
essentially using a method with undocumented API. Perhaps it does the same as 
the one in Java 7, with the difference that it is public, but I'm worried that 
there could be some correctness issue involved. Do you know more about it?

In any case, I'm going to push the changes so that we see how it looks like.


> Zookeeper Client should re-resolve hosts when connection attempts fail
> --
>
> Key: ZOOKEEPER-2184
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2184
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6, 3.5.0
> Environment: Ubuntu 14.04 host, Docker containers for Zookeeper & 
> Kafka
>Reporter: Robert P. Thille
>Assignee: Flavio Junqueira
>  Labels: easyfix, patch
> Fix For: 3.4.10, 3.5.3
>
> Attachments: ZOOKEEPER-2184.patch
>
>
> Testing in a Docker environment with a single Kafka instance using a single 
> Zookeeper instance. Restarting the Zookeeper container will cause it to 
> receive a new IP address. Kafka will never be able to reconnect to Zookeeper 
> and will hang indefinitely. Updating DNS or /etc/hosts with the new IP 
> address will not help the client to reconnect as the 
> zookeeper/client/StaticHostProvider resolves the connection string hosts at 
> creation time and never re-resolves.
> A solution would be for the client to notice that connection attempts fail 
> and attempt to re-resolve the hostnames in the connectString.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #150: ZOOKEEPER-2184: Zookeeper Client should re-reso...

[fpj]

Github user fpj commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96439377
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
+ * string representation of the IP address.
+ *
+ * @param addr
+ * @return Hostname string of address parameter
+ */
+private String getHostString(InetSocketAddress addr) {
--- End diff --

We can do it, but I'm not super convinced we should because we are 
essentially using a method with undocumented API. Perhaps it does the same as 
the one in Java 7, with the difference that it is public, but I'm worried that 
there could be some correctness issue involved. Do you know more about it?

In any case, I'm going to push the changes so that we see how it looks like.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826211#comment-15826211
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user revans2 commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96435980
  
--- Diff: ivy.xml ---
@@ -41,13 +41,20 @@
 
   
 
-
+
+
+
+
+
+
+
--- End diff --

This is the version that log4j 2 uses itself, when you enable async logging.


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #148: ZOOKEEPER-2659 Log4j 2 migration

[revans2]

Github user revans2 commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96435980
  
--- Diff: ivy.xml ---
@@ -41,13 +41,20 @@
 
   
 
-
+
+
+
+
+
+
+
--- End diff --

This is the version that log4j 2 uses itself, when you enable async logging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826196#comment-15826196
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2184:
---

Github user fpj commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96433850
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
+ * string representation of the IP address.
+ *
+ * @param addr
+ * @return Hostname string of address parameter
+ */
+private String getHostString(InetSocketAddress addr) {
+String hostString;
+InetAddress ia = addr.getAddress();
+
+if (ia != null) {
+// If the string starts with '/', then it has no hostname
+// and we want to avoid the reverse lookup, so we return
+// the string representation of the address.
+if (ia.toString().startsWith("/")) {
+hostString = ia.getHostAddress();
+} else {
+hostString = addr.getHostName();
+}
+} else {
+// According to the Java 6 documentation, if the hostname is
+// unresolved, then the string before the colon is the 
hostname.
+String addrString = addr.toString();
+hostString = addrString.substring(0, 
addrString.lastIndexOf(':'));
+}
+
+return hostString;
+}
+
 public int size() {
 return serverAddresses.size();
 }
 
 public InetSocketAddress next(long spinDelay) {
-++currentIndex;
-if (currentIndex == serverAddresses.size()) {
-currentIndex = 0;
+// Handle possible connection error by re-resolving hostname if 
possible
+if (!connectedSinceNext) {
+InetSocketAddress curAddr = serverAddresses.get(currentIndex);
+if 
(!curAddr.getHostString().equals(curAddr.getAddress().getHostAddress())) {
+try {
+int thePort = curAddr.getPort();
+InetAddress resolvedAddresses[] = 
InetAddress.getAllByName(getHostString(curAddr));
+if (resolvedAddresses.length == 1) {
+serverAddresses.set(currentIndex, new 
InetSocketAddress(resolvedAddresses[0], thePort));
+} else {
+serverAddresses.remove(currentIndex);
+for (InetAddress resolvedAddress : 
resolvedAddresses) {
+InetSocketAddress newAddr = new 
InetSocketAddress(resolvedAddress, thePort);
+if (!serverAddresses.contains(newAddr)) {
+serverAddresses.add(newAddr);
+}
+}
+}
+} catch (UnknownHostException e) {
+LOG.warn("Cannot re-resolve server: " + curAddr + " 
UnknownHostException: " + e);
--- End diff --

I don't think I can do both, see the API docs of slf4j:

https://www.slf4j.org/api/org/slf4j/Logger.html

In the case you are, tell me which one is your favorite. I'd say the curly 
braces.


> Zookeeper Client should re-resolve hosts when connection attempts fail
> --
>
> Key: ZOOKEEPER-2184
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2184
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6, 3.5.0
> Environment: Ubuntu 14.04 host, Docker containers for Zookeeper & 
> Kafka
>Reporter: Robert P. Thille
>Assignee: Flavio Junqueira
>  Labels: easyfix, patch
> Fix For: 3.4.10, 3.5.3
>
> Attachments: ZOOKEEPER-2184.patch
>
>
> Testing in a Docker environment with a single Kafka instance using a single 
> Zookeeper instance. Restarting the Zookeeper container will cause it to 
> receive a new IP address. Kafka will never be able to reconnect to Zookeeper 
> and will hang indefinitely. Updating DNS or /etc/hosts with the new IP 
> address will not help the client to reconnect as 

[GitHub] zookeeper pull request #150: ZOOKEEPER-2184: Zookeeper Client should re-reso...

[fpj]

Github user fpj commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96433850
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
+ * string representation of the IP address.
+ *
+ * @param addr
+ * @return Hostname string of address parameter
+ */
+private String getHostString(InetSocketAddress addr) {
+String hostString;
+InetAddress ia = addr.getAddress();
+
+if (ia != null) {
+// If the string starts with '/', then it has no hostname
+// and we want to avoid the reverse lookup, so we return
+// the string representation of the address.
+if (ia.toString().startsWith("/")) {
+hostString = ia.getHostAddress();
+} else {
+hostString = addr.getHostName();
+}
+} else {
+// According to the Java 6 documentation, if the hostname is
+// unresolved, then the string before the colon is the 
hostname.
+String addrString = addr.toString();
+hostString = addrString.substring(0, 
addrString.lastIndexOf(':'));
+}
+
+return hostString;
+}
+
 public int size() {
 return serverAddresses.size();
 }
 
 public InetSocketAddress next(long spinDelay) {
-++currentIndex;
-if (currentIndex == serverAddresses.size()) {
-currentIndex = 0;
+// Handle possible connection error by re-resolving hostname if 
possible
+if (!connectedSinceNext) {
+InetSocketAddress curAddr = serverAddresses.get(currentIndex);
+if 
(!curAddr.getHostString().equals(curAddr.getAddress().getHostAddress())) {
+try {
+int thePort = curAddr.getPort();
+InetAddress resolvedAddresses[] = 
InetAddress.getAllByName(getHostString(curAddr));
+if (resolvedAddresses.length == 1) {
+serverAddresses.set(currentIndex, new 
InetSocketAddress(resolvedAddresses[0], thePort));
+} else {
+serverAddresses.remove(currentIndex);
+for (InetAddress resolvedAddress : 
resolvedAddresses) {
+InetSocketAddress newAddr = new 
InetSocketAddress(resolvedAddress, thePort);
+if (!serverAddresses.contains(newAddr)) {
+serverAddresses.add(newAddr);
+}
+}
+}
+} catch (UnknownHostException e) {
+LOG.warn("Cannot re-resolve server: " + curAddr + " 
UnknownHostException: " + e);
--- End diff --

I don't think I can do both, see the API docs of slf4j:

https://www.slf4j.org/api/org/slf4j/Logger.html

In the case you are, tell me which one is your favorite. I'd say the curly 
braces.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826190#comment-15826190
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2184:
---

Github user fpj commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96431605
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,12 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
--- End diff --

I've added a phrase to the return tag.


> Zookeeper Client should re-resolve hosts when connection attempts fail
> --
>
> Key: ZOOKEEPER-2184
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2184
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6, 3.5.0
> Environment: Ubuntu 14.04 host, Docker containers for Zookeeper & 
> Kafka
>Reporter: Robert P. Thille
>Assignee: Flavio Junqueira
>  Labels: easyfix, patch
> Fix For: 3.4.10, 3.5.3
>
> Attachments: ZOOKEEPER-2184.patch
>
>
> Testing in a Docker environment with a single Kafka instance using a single 
> Zookeeper instance. Restarting the Zookeeper container will cause it to 
> receive a new IP address. Kafka will never be able to reconnect to Zookeeper 
> and will hang indefinitely. Updating DNS or /etc/hosts with the new IP 
> address will not help the client to reconnect as the 
> zookeeper/client/StaticHostProvider resolves the connection string hosts at 
> creation time and never re-resolves.
> A solution would be for the client to notice that connection attempts fail 
> and attempt to re-resolve the hostnames in the connectString.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #150: ZOOKEEPER-2184: Zookeeper Client should re-reso...

[fpj]

Github user fpj commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96431605
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,12 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
--- End diff --

I've added a phrase to the return tag.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[Flavio Junqueira (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826184#comment-15826184
 ] 

Flavio Junqueira commented on ZOOKEEPER-2659:
-

I'm not sure, I need to revisit along with ZOOKEEPER-1371, which we had to 
revert. Perhaps [~arshad.mohammad] can chime in here, since he worked on 
ZOOKEEPER-1371?

> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Success: ZOOKEEPER-2642 PreCommit Build #3562

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3562/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 480043 lines...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3562//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3562//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3562//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Unable to log in to server: 
https://issues.apache.org/jira/rpc/soap/jirasoapservice-v2 with user: hadoopqa.
 [exec]  Cause: ; nested exception is: 
 [exec] javax.net.ssl.SSLHandshakeException: 
sun.security.validator.ValidatorException: PKIX path building failed: 
sun.security.provider.certpath.SunCertPathBuilderException: unable to find 
valid certification path to requested target
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Unable to log in to server: 
https://issues.apache.org/jira/rpc/soap/jirasoapservice-v2 with user: hadoopqa.
 [exec]  Cause: ; nested exception is: 
 [exec] javax.net.ssl.SSLHandshakeException: 
sun.security.validator.ValidatorException: PKIX path building failed: 
sun.security.provider.certpath.SunCertPathBuilderException: unable to find 
valid certification path to requested target
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess’ 
and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess’ 
are the same file

BUILD SUCCESSFUL
Total time: 18 minutes 47 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2642
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

ZooKeeper_branch34_openjdk7 - Build # 1351 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1351/

###
## LAST 60 LINES OF THE CONSOLE 
###
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H13 (ubuntu) in workspace 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.apache.org/zookeeper.git # timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.apache.org/zookeeper.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > git://git.apache.org/zookeeper.git +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/branch-3.4^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/branch-3.4^{commit} # timeout=10
Checking out Revision cded802708fac417369affbd25bf9ad2016a904d 
(refs/remotes/origin/branch-3.4)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f cded802708fac417369affbd25bf9ad2016a904d
 > git rev-list cded802708fac417369affbd25bf9ad2016a904d # timeout=10
No emails were triggered.
[ZooKeeper_branch34_openjdk7] $ /home/jenkins/tools/ant/latest/bin/ant 
-Dtest.output=yes -Dtest.junit.threads=8 -Dtest.junit.output.format=xml 
-Djavac.target=1.7 clean test-core-java
Error: JAVA_HOME is not defined correctly.
  We cannot execute /usr/lib/jvm/java-7-openjdk-amd64//bin/java
Build step 'Invoke Ant' marked build as failure
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Updated] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[Jordan Zimmerman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jordan Zimmerman updated ZOOKEEPER-2642:

Attachment: ZOOKEEPER-2642-3.5.patch

same patch but based off of {{branch-3.5}}

> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2642-3.5.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826128#comment-15826128
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
---

GitHub user Randgalt opened a pull request:

https://github.com/apache/zookeeper/pull/151

Applying ZOOKEEPER-2642 patch to a 3.5 base

New PR that applies ZOOKEEPER-2642 to `branch-3.5`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Randgalt/zookeeper ZOOKEEPER-2642-3.5

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/151.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #151


commit d92dc5869269e041e4246428946455fb7d404ff4
Author: randgalt 
Date:   2017-01-17T14:35:39Z

Applying ZOOKEEPER-2642 patch to a 3.5 base




> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826130#comment-15826130
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
---

Github user Randgalt commented on the issue:

https://github.com/apache/zookeeper/pull/122
  
See #151


> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER- PreCommit Build #216

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/216/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 26 lines...]
Done: 31
  Compressing objects
Done: 9734
  Writing objects
Done: 33
  remote: Resolving deltas
  remote: Updating references
Merging refs/tags/changes/216
 > git rev-parse refs/tags/changes/216^{commit} # timeout=10
 > git merge d92dc5869269e041e4246428946455fb7d404ff4 # timeout=10
 > git rev-parse branch-3.5^{commit} # timeout=10
Checking out Revision d92dc5869269e041e4246428946455fb7d404ff4 (branch-3.5)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f d92dc5869269e041e4246428946455fb7d404ff4
 > git rev-parse origin/branch-3.5^{commit} # timeout=10
 > git rev-list 68b7dca59cd717ba7bf798b29e33131b2973ebf0 # timeout=10
No emails were triggered.
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[PreCommit-ZOOKEEPER-github-pr-build] $ /bin/bash 
/tmp/hudson6790348350373664214.sh
/home/jenkins/tools/java/latest1.7/bin/java
java version "1.7.0_80"
Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
core file size  (blocks, -c) 0
data seg size   (kbytes, -d) unlimited
scheduling priority (-e) 0
file size   (blocks, -f) unlimited
pending signals (-i) 386178
max locked memory   (kbytes, -l) 64
max memory size (kbytes, -m) unlimited
open files  (-n) 6
pipe size(512 bytes, -p) 8
POSIX message queues (bytes, -q) 819200
real-time priority  (-r) 0
stack size  (kbytes, -s) 8192
cpu time   (seconds, -t) unlimited
max user processes  (-u) 10240
virtual memory  (kbytes, -v) unlimited
file locks  (-x) unlimited
Buildfile: 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml

BUILD FAILED
Target "qa-test-pullrequest" does not exist in the project "ZooKeeper". 

Total time: 0 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
[description-setter] Could not determine description.
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

[GitHub] zookeeper issue #122: [ZOOKEEPER-2642] Resurrect the reconfig() methods that...

[Randgalt]

Github user Randgalt commented on the issue:

https://github.com/apache/zookeeper/pull/122
  
See #151


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #151: Applying ZOOKEEPER-2642 patch to a 3.5 base

[Randgalt]

GitHub user Randgalt opened a pull request:

https://github.com/apache/zookeeper/pull/151

Applying ZOOKEEPER-2642 patch to a 3.5 base

New PR that applies ZOOKEEPER-2642 to `branch-3.5`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Randgalt/zookeeper ZOOKEEPER-2642-3.5

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/151.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #151


commit d92dc5869269e041e4246428946455fb7d404ff4
Author: randgalt 
Date:   2017-01-17T14:35:39Z

Applying ZOOKEEPER-2642 patch to a 3.5 base




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2139) Support multiple ZooKeeper client, with different configurations, in a single JVM

[Hari Krishna Dara (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826120#comment-15826120
 ] 

Hari Krishna Dara commented on ZOOKEEPER-2139:
--

[~rakesh_r] I already filed ZOOKEEPER-2667 and linked it to this jira.

> Support multiple ZooKeeper client, with different configurations, in a single 
> JVM
> -
>
> Key: ZOOKEEPER-2139
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client
>Affects Versions: 3.5.0
>Reporter: Surendra Singh Lilhore
>Assignee: Arshad Mohammad
>Priority: Blocker
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139-06.patch, 
> ZOOKEEPER-2139-07.patch, ZOOKEEPER-2139-08.patch, ZOOKEEPER-2139-09.patch, 
> ZOOKEEPER-2139-10.patch, ZOOKEEPER-2139-11.patch, ZOOKEEPER-2139-12.patch, 
> ZOOKEEPER-2139-13.patch, ZOOKEEPER-2139-14.patch, ZOOKEEPER-2139_1.patch, 
> ZOOKEEPER-2139_2.patch, ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch
>
>
> I have two ZK client in one JVM, one is secure client and second is normal 
> client (For non secure cluster).
> "zookeeper.sasl.client" system property is "true" by default, because of this 
> my second client connection is failing.
> We should pass all client configurations in client constructor like HDFS 
> client.
> For example :
> {code}
> public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, 
> Configuration conf) throws IOException
>   {
>   ..
>   ..
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch34_solaris - Build # 1434 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_solaris/1434/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 189982 lines...]
[junit] 2017-01-17 13:54:12,549 [myid:] - INFO  [main:ZooKeeperServer@497] 
- shutting down
[junit] 2017-01-17 13:54:12,550 [myid:] - ERROR [main:ZooKeeperServer@472] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-01-17 13:54:12,550 [myid:] - INFO  
[main:SessionTrackerImpl@225] - Shutting down
[junit] 2017-01-17 13:54:12,550 [myid:] - INFO  
[main:PrepRequestProcessor@765] - Shutting down
[junit] 2017-01-17 13:54:12,550 [myid:] - INFO  
[main:SyncRequestProcessor@208] - Shutting down
[junit] 2017-01-17 13:54:12,550 [myid:] - INFO  [ProcessThread(sid:0 
cport:11221)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop!
[junit] 2017-01-17 13:54:12,550 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@186] - SyncRequestProcessor exited!
[junit] 2017-01-17 13:54:12,550 [myid:] - INFO  
[main:FinalRequestProcessor@402] - shutdown of request processor complete
[junit] 2017-01-17 13:54:12,551 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2017-01-17 13:54:12,551 [myid:] - INFO  [main:JMXEnv@147] - 
ensureOnly:[]
[junit] 2017-01-17 13:54:12,552 [myid:] - INFO  [main:ClientBase@445] - 
STARTING server
[junit] 2017-01-17 13:54:12,552 [myid:] - INFO  [main:ClientBase@366] - 
CREATING server instance 127.0.0.1:11221
[junit] 2017-01-17 13:54:12,552 [myid:] - INFO  
[main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2017-01-17 13:54:12,553 [myid:] - INFO  [main:ClientBase@341] - 
STARTING server instance 127.0.0.1:11221
[junit] 2017-01-17 13:54:12,553 [myid:] - INFO  [main:ZooKeeperServer@173] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/build/test/tmp/test4353589081991286869.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/build/test/tmp/test4353589081991286869.junit.dir/version-2
[junit] 2017-01-17 13:54:12,555 [myid:] - ERROR [main:ZooKeeperServer@472] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-01-17 13:54:12,556 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2017-01-17 13:54:12,556 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - 
Accepted socket connection from /127.0.0.1:44061
[junit] 2017-01-17 13:54:12,556 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing 
stat command from /127.0.0.1:44061
[junit] 2017-01-17 13:54:12,556 [myid:] - INFO  
[Thread-5:NIOServerCnxn$StatCommand@663] - Stat command output
[junit] 2017-01-17 13:54:12,557 [myid:] - INFO  
[Thread-5:NIOServerCnxn@1008] - Closed socket connection for client 
/127.0.0.1:44061 (no session established for client)
[junit] 2017-01-17 13:54:12,557 [myid:] - INFO  [main:JMXEnv@230] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2017-01-17 13:54:12,558 [myid:] - INFO  [main:JMXEnv@247] - 
expect:InMemoryDataTree
[junit] 2017-01-17 13:54:12,558 [myid:] - INFO  [main:JMXEnv@251] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree
[junit] 2017-01-17 13:54:12,558 [myid:] - INFO  [main:JMXEnv@247] - 
expect:StandaloneServer_port
[junit] 2017-01-17 13:54:12,558 [myid:] - INFO  [main:JMXEnv@251] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221
[junit] 2017-01-17 13:54:12,559 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 8995
[junit] 2017-01-17 13:54:12,559 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20
[junit] 2017-01-17 13:54:12,559 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota
[junit] 2017-01-17 13:54:12,559 [myid:] - INFO  [main:ClientBase@522] - 
tearDown starting
[junit] 2017-01-17 13:54:12,642 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@519] - EventThread shut down for 
session: 0x159acb4e126
[junit] 2017-01-17 13:54:12,642 [myid:] - INFO  [main:ZooKeeper@684] - 
Session: 0x159acb4e126 closed
[junit] 2017-01-17 13:54:12,643 [myid:] - INFO  [main:ClientBase@492] - 
STOPPING server
[junit] 2017-01-17 13:54:12,644 [myid:] - INFO  [main:ZooKeeperServer@497] 
- shutting down
[junit] 2017-01-17 13:54:12,644 [myid:] - 

[GitHub] zookeeper issue #122: [ZOOKEEPER-2642] Resurrect the reconfig() methods that...

[Randgalt]

Github user Randgalt commented on the issue:

https://github.com/apache/zookeeper/pull/122
  
Will do


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826070#comment-15826070
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
---

Github user Randgalt commented on the issue:

https://github.com/apache/zookeeper/pull/122
  
Will do


> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[Pushkar Raste (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826059#comment-15826059
 ] 

Pushkar Raste commented on ZOOKEEPER-2659:
--

[~fpj] - log4j 1.X is EOL and will not work with JDK1.9, we have to bite the 
bullet at some point. I do understand concerns about making sure changes are as 
smooth as possible (or at the least well document any backwards incompatible 
changes). 

I have chosen to to use xml configuration instead of using properties style 
config. I like structured xml configs but if people have strong opinions on 
using properties style config,  I will definitely look into making required 
changes.

To summarize except for the fact that custom log configs made by the system 
admins, would need to updated with 'log4j 2'  equivalents, are there any other 
concerns?



> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2139) Support multiple ZooKeeper client, with different configurations, in a single JVM

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825994#comment-15825994
 ] 

Rakesh R commented on ZOOKEEPER-2139:
-

[~haridsv], could you please share the exception trace and the scenario to 
understand NPE in detail. Please feel free to file a jira to discuss and fix 
this.

> Support multiple ZooKeeper client, with different configurations, in a single 
> JVM
> -
>
> Key: ZOOKEEPER-2139
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client
>Affects Versions: 3.5.0
>Reporter: Surendra Singh Lilhore
>Assignee: Arshad Mohammad
>Priority: Blocker
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139-06.patch, 
> ZOOKEEPER-2139-07.patch, ZOOKEEPER-2139-08.patch, ZOOKEEPER-2139-09.patch, 
> ZOOKEEPER-2139-10.patch, ZOOKEEPER-2139-11.patch, ZOOKEEPER-2139-12.patch, 
> ZOOKEEPER-2139-13.patch, ZOOKEEPER-2139-14.patch, ZOOKEEPER-2139_1.patch, 
> ZOOKEEPER-2139_2.patch, ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch
>
>
> I have two ZK client in one JVM, one is secure client and second is normal 
> client (For non secure cluster).
> "zookeeper.sasl.client" system property is "true" by default, because of this 
> my second client connection is failing.
> We should pass all client configurations in client constructor like HDFS 
> client.
> For example :
> {code}
> public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, 
> Configuration conf) throws IOException
>   {
>   ..
>   ..
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk-jdk8 - Build # 904 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/904/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 459848 lines...]
[junit] 2017-01-17 12:07:49,913 [myid:127.0.0.1:30148] - INFO  
[main-SendThread(127.0.0.1:30148):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:30148. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-01-17 12:07:49,913 [myid:127.0.0.1:30148] - INFO  
[main-SendThread(127.0.0.1:30148):ClientCnxn$SendThread@948] - Socket 
connection established, initiating session, client: /127.0.0.1:42311, server: 
127.0.0.1/127.0.0.1:30148
[junit] 2017-01-17 12:07:49,913 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:/127.0.0.1:30148:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:42311
[junit] 2017-01-17 12:07:49,913 [myid:] - WARN  
[NIOWorkerThread-26:NIOServerCnxn@369] - Exception causing close of session 
0x0: ZooKeeperServer not running
[junit] 2017-01-17 12:07:49,913 [myid:] - INFO  
[NIOWorkerThread-26:NIOServerCnxn@614] - Closed socket connection for client 
/127.0.0.1:42311 (no session established for client)
[junit] 2017-01-17 12:07:49,914 [myid:127.0.0.1:30148] - INFO  
[main-SendThread(127.0.0.1:30148):ClientCnxn$SendThread@1231] - Unable to read 
additional data from server sessionid 0x4023ffe8661, likely server has 
closed socket, closing socket connection and attempting reconnect
[junit] 2017-01-17 12:07:50,766 [myid:127.0.0.1:30127] - INFO  
[main-SendThread(127.0.0.1:30127):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:30127. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-01-17 12:07:50,767 [myid:127.0.0.1:30127] - WARN  
[main-SendThread(127.0.0.1:30127):ClientCnxn$SendThread@1235] - Session 
0x3023ffe5534 for server 127.0.0.1/127.0.0.1:30127, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-01-17 12:07:51,305 [myid:127.0.0.1:30148] - INFO  
[main-SendThread(127.0.0.1:30148):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:30148. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-01-17 12:07:51,305 [myid:127.0.0.1:30148] - INFO  
[main-SendThread(127.0.0.1:30148):ClientCnxn$SendThread@948] - Socket 
connection established, initiating session, client: /127.0.0.1:42355, server: 
127.0.0.1/127.0.0.1:30148
[junit] 2017-01-17 12:07:51,305 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:/127.0.0.1:30148:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:42355
[junit] 2017-01-17 12:07:51,306 [myid:] - WARN  
[NIOWorkerThread-27:NIOServerCnxn@369] - Exception causing close of session 
0x0: ZooKeeperServer not running
[junit] 2017-01-17 12:07:51,306 [myid:] - INFO  
[NIOWorkerThread-27:NIOServerCnxn@614] - Closed socket connection for client 
/127.0.0.1:42355 (no session established for client)
[junit] 2017-01-17 12:07:51,306 [myid:127.0.0.1:30148] - INFO  
[main-SendThread(127.0.0.1:30148):ClientCnxn$SendThread@1231] - Unable to read 
additional data from server sessionid 0x4023ffe8661, likely server has 
closed socket, closing socket connection and attempting reconnect
[junit] 2017-01-17 12:07:51,310 [myid:127.0.0.1:30121] - INFO  
[main-SendThread(127.0.0.1:30121):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:30121. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-01-17 12:07:51,310 [myid:127.0.0.1:30121] - WARN  
[main-SendThread(127.0.0.1:30121):ClientCnxn$SendThread@1235] - Session 
0x1023ffe5444 for server 127.0.0.1/127.0.0.1:30121, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-01-17 12:07:51,342 [myid:127.0.0.1:30124] - INFO  
[main-SendThread(127.0.0.1:30124):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 

[jira] [Commented] (ZOOKEEPER-2139) Support multiple ZooKeeper client, with different configurations, in a single JVM

[Hari Krishna Dara (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825909#comment-15825909
 ] 

Hari Krishna Dara commented on ZOOKEEPER-2139:
--

This patch introduces an NPE that breaks multiple connections.

> Support multiple ZooKeeper client, with different configurations, in a single 
> JVM
> -
>
> Key: ZOOKEEPER-2139
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client
>Affects Versions: 3.5.0
>Reporter: Surendra Singh Lilhore
>Assignee: Arshad Mohammad
>Priority: Blocker
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139-06.patch, 
> ZOOKEEPER-2139-07.patch, ZOOKEEPER-2139-08.patch, ZOOKEEPER-2139-09.patch, 
> ZOOKEEPER-2139-10.patch, ZOOKEEPER-2139-11.patch, ZOOKEEPER-2139-12.patch, 
> ZOOKEEPER-2139-13.patch, ZOOKEEPER-2139-14.patch, ZOOKEEPER-2139_1.patch, 
> ZOOKEEPER-2139_2.patch, ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch
>
>
> I have two ZK client in one JVM, one is secure client and second is normal 
> client (For non secure cluster).
> "zookeeper.sasl.client" system property is "true" by default, because of this 
> my second client connection is failing.
> We should pass all client configurations in client constructor like HDFS 
> client.
> For example :
> {code}
> public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, 
> Configuration conf) throws IOException
>   {
>   ..
>   ..
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZOOKEEPER-2667) NPE in the patch for ZOOKEEPER-2139 when multiple connections are made

[Hari Krishna Dara (JIRA)]

Hari Krishna Dara created ZOOKEEPER-2667:


 Summary: NPE in the patch for ZOOKEEPER-2139 when multiple 
connections are made
 Key: ZOOKEEPER-2667
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2667
 Project: ZooKeeper
  Issue Type: Bug
  Components: java client
Affects Versions: 3.5.2, 3.6.0
Reporter: Hari Krishna Dara


ZOOKEEPER-2139 added support for connecting to multiple ZK services, but this 
also introduced a bug that causes a cryptic NPE. The client sees the below sort 
of error messages:

{noformat}
Exception while trying to create SASL client: java.lang.NullPointerException
SASL authentication with Zookeeper Quorum member failed: 
javax.security.sasl.SaslException: saslClient failed to initialize properly: 
it's null.
Error while calling watcher
java.lang.NullPointerException
at 
org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.connectionEvent(ZooKeeperWatcher.java:581)
at 
org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.process(ZooKeeperWatcher.java:532)
at 
org.apache.hadoop.hbase.zookeeper.PendingWatcher.process(PendingWatcher.java:40)
at 
org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:579)
at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:554)
{noformat}

The line at {{ZooKeeperWatcher.connectionEvent(ZooKeeperWatcher.java:581)}} 
points to the middle line below, where {{event.getState()}} is {{null}}:

{noformat}
private void connectionEvent(WatchedEvent event) {
switch(event.getState()) {
   case SyncConnected:
{noformat}

However, the event's state is {{null}} because of a couple of other bugs, 
particularly an NPE that gets a mention in the log without a stacktrace. This 
first NPE causes an incorrect initialization of the event and results in the 
second NPE with the stacktrace.

The reason for the first NPE comes from this code in {{ZookeeperSaslClient}}:

{noformat}
if (!initializedLogin) {
...
}
Subject subject = login.getSubject();
{noformat}

Before the patch for ZOOKEEPER-2139, both the {{login}} and 
{{initializedLogin}} were {{static}} fields of {{ZookeeperSaslClient}}. To 
support multiple ZK clients, the {{login}} field was changed from {{static}} to 
instance field, however the {{initializedLogin}} field was left as {{static}} 
field. Because of this, the subsequent attempts to connect to ZK think that the 
login doesn't need to be done and go ahead and blindly use the {{login}} 
variable which causes the NPE.

At the core, the fix is simply to change {{initializedLogin}} to instance 
variable, but we have made a few additional changes to improve the logging and 
handle state. I will attach a patch soon. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[Flavio Junqueira (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Junqueira updated ZOOKEEPER-2659:

Assignee: Pushkar Raste

> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[Flavio Junqueira (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825797#comment-15825797
 ] 

Flavio Junqueira commented on ZOOKEEPER-2659:
-

Has anyone done due diligence to make sure that the issues reported in 
ZOOKEEPER-2342 have cleared? We have discussed that issue some time back and we 
need to revisit it before we go forward with this one.

Until we clear that issue, I'm -1 here.

> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825791#comment-15825791
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
---

Github user fpj commented on the issue:

https://github.com/apache/zookeeper/pull/122
  
@hanm @Randgalt sounds like a plan, let's follow the steps that Michael 
lined up above.


> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper issue #122: [ZOOKEEPER-2642] Resurrect the reconfig() methods that...

[fpj]

Github user fpj commented on the issue:

https://github.com/apache/zookeeper/pull/122
  
@hanm @Randgalt sounds like a plan, let's follow the steps that Michael 
lined up above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

ZooKeeper-trunk-solaris - Build # 1469 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1469/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 466132 lines...]
[junit] 2017-01-17 08:26:09,712 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:35919
[junit] 2017-01-17 08:26:09,713 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2017-01-17 08:26:09,713 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@614] - Closed socket connection for client 
/127.0.0.1:35919 (no session established for client)
[junit] 2017-01-17 08:26:09,713 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2017-01-17 08:26:09,716 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2017-01-17 08:26:09,716 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2017-01-17 08:26:09,716 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2017-01-17 08:26:09,716 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2017-01-17 08:26:09,717 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17907
[junit] 2017-01-17 08:26:09,717 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2017-01-17 08:26:09,717 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2017-01-17 08:26:09,718 [myid:] - INFO  [main:ClientBase@558] - 
tearDown starting
[junit] 2017-01-17 08:26:10,261 [myid:] - INFO  
[SessionTracker:SessionTrackerImpl@158] - SessionTrackerImpl exited loop!
[junit] 2017-01-17 08:26:10,261 [myid:] - INFO  
[SessionTracker:SessionTrackerImpl@158] - SessionTrackerImpl exited loop!
[junit] 2017-01-17 08:26:10,681 [myid:127.0.0.1:11222] - INFO  
[main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:11222. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-01-17 08:26:10,681 [myid:127.0.0.1:11222] - INFO  
[main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@948] - Socket 
connection established, initiating session, client: null, server: null
[junit] 2017-01-17 08:26:10,681 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:35920
[junit] 2017-01-17 08:26:10,682 [myid:] - INFO  
[NIOWorkerThread-2:ZooKeeperServer@1005] - Client attempting to renew session 
0x1262881ee2e at /127.0.0.1:35920
[junit] 2017-01-17 08:26:10,683 [myid:] - INFO  
[NIOWorkerThread-2:ZooKeeperServer@714] - Established session 0x1262881ee2e 
with negotiated timeout 3 for client /127.0.0.1:35920
[junit] 2017-01-17 08:26:10,684 [myid:127.0.0.1:11222] - INFO  
[main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@1381] - Session 
establishment complete on server null, sessionid = 0x1262881ee2e, 
negotiated timeout = 3
[junit] 2017-01-17 08:26:10,684 [myid:] - INFO  [ProcessThread(sid:0 
cport:11222)::PrepRequestProcessor@618] - Processed session termination for 
sessionid: 0x1262881ee2e
[junit] 2017-01-17 08:26:10,685 [myid:] - INFO  
[SyncThread:0:FileTxnLog@204] - Creating new log file: log.c
[junit] 2017-01-17 08:26:10,687 [myid:] - INFO  [main:ZooKeeper@1324] - 
Session: 0x1262881ee2e closed
[junit] 2017-01-17 08:26:10,687 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1262881ee2e
[junit] 2017-01-17 08:26:10,687 [myid:] - INFO  
[NIOWorkerThread-5:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=Connections,name2=127.0.0.1,name3=0x1262881ee2e]
[junit] 2017-01-17 08:26:10,688 [myid:] - INFO  [main:ClientBase@528] - 
STOPPING server
[junit] 2017-01-17 08:26:10,688 [myid:] - INFO  
[NIOWorkerThread-5:NIOServerCnxn@614] - Closed socket connection for client 
/127.0.0.1:35920 which had sessionid 0x1262881ee2e
[junit] 2017-01-17 08:26:10,688 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2017-01-17 08:26:10,688 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2017-01-17 08:26:10,688 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2017-01-17 08:26:10,689 [myid:] - INFO