[jira] [Created] (ZOOKEEPER-2687) Deadlock while shutting down the Leader server.
Mohammad Arshad created ZOOKEEPER-2687:
--
Summary: Deadlock while shutting down the Leader server.
Key: ZOOKEEPER-2687
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2687
Project: ZooKeeper
Issue Type: Bug
Components: server
Affects Versions: 3.5.2, 3.6.0
Reporter: Mohammad Arshad
Assignee: Mohammad Arshad
Leader server enters into deadlock while shutting down. This happens some time
only.
The reason and deadlock flow is same as ZOOKEEPER-2380.
shutdown was removed from synchronized block in ZOOKEEPER-2380
Now shutdown is called from synchronized block from another place.
{code}
// check leader running status
if (!this.isRunning()) {
shutdown("Unexpected internal error");
return;
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2684) Fix a crashing bug in the mixed workloads commit processor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857531#comment-15857531 ] Ryan Zhang commented on ZOOKEEPER-2684: --- Hi, Kfir, I have a unit case and it's not bad. The problem is to come up with a quorum based test. > Fix a crashing bug in the mixed workloads commit processor > -- > > Key: ZOOKEEPER-2684 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2684 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.6.0 > Environment: with pretty heavy load on a real cluster >Reporter: Ryan Zhang >Assignee: Ryan Zhang >Priority: Blocker > > We deployed our build with ZOOKEEPER-2024 and it quickly started to crash > with the following error > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:24:42,305 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x119fa expected 0x11fc5 for client session id 1009079ba470055 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:32:04,746 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x698 expected 0x928 for client session id 4002eeb3fd0009d > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:34:46,648 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x8904 expected 0x8f34 for client session id 51b8905c90251 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:43:46,834 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x3a8d expected 0x3ebc for client session id 2051af11af900cc > clearly something is not right in the new commit processor per session queue > implementation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2684) Fix a crashing bug in the mixed workloads commit processor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857529#comment-15857529 ] Ryan Zhang commented on ZOOKEEPER-2684: --- Hi, Michael, the link you and Alex gave me has the "git clone https://git-wip-us.apache.org/repos/asf/zookeeper.git"; as the first command, that's why I was confused, I guess I will go through the github route. Thanks for the clarification. > Fix a crashing bug in the mixed workloads commit processor > -- > > Key: ZOOKEEPER-2684 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2684 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.6.0 > Environment: with pretty heavy load on a real cluster >Reporter: Ryan Zhang >Assignee: Ryan Zhang >Priority: Blocker > > We deployed our build with ZOOKEEPER-2024 and it quickly started to crash > with the following error > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:24:42,305 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x119fa expected 0x11fc5 for client session id 1009079ba470055 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:32:04,746 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x698 expected 0x928 for client session id 4002eeb3fd0009d > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:34:46,648 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x8904 expected 0x8f34 for client session id 51b8905c90251 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:43:46,834 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x3a8d expected 0x3ebc for client session id 2051af11af900cc > clearly something is not right in the new commit processor per session queue > implementation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2684) Fix a crashing bug in the mixed workloads commit processor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857496#comment-15857496 ] Kfir Lev-Ari commented on ZOOKEEPER-2684: - Ryan, sorry for the mess I wrote, I'll write it again as a patch so that we'll see we're on the same page (I'll try to write a unit test that cover the case you identified). > Fix a crashing bug in the mixed workloads commit processor > -- > > Key: ZOOKEEPER-2684 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2684 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.6.0 > Environment: with pretty heavy load on a real cluster >Reporter: Ryan Zhang >Assignee: Ryan Zhang >Priority: Blocker > > We deployed our build with ZOOKEEPER-2024 and it quickly started to crash > with the following error > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:24:42,305 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x119fa expected 0x11fc5 for client session id 1009079ba470055 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:32:04,746 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x698 expected 0x928 for client session id 4002eeb3fd0009d > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:34:46,648 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x8904 expected 0x8f34 for client session id 51b8905c90251 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:43:46,834 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x3a8d expected 0x3ebc for client session id 2051af11af900cc > clearly something is not right in the new commit processor per session queue > implementation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2684) Fix a crashing bug in the mixed workloads commit processor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857469#comment-15857469 ] Michael Han commented on ZOOKEEPER-2684: btw more info on https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute (section Pull requests via github) > Fix a crashing bug in the mixed workloads commit processor > -- > > Key: ZOOKEEPER-2684 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2684 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.6.0 > Environment: with pretty heavy load on a real cluster >Reporter: Ryan Zhang >Assignee: Ryan Zhang >Priority: Blocker > > We deployed our build with ZOOKEEPER-2024 and it quickly started to crash > with the following error > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:24:42,305 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x119fa expected 0x11fc5 for client session id 1009079ba470055 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:32:04,746 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x698 expected 0x928 for client session id 4002eeb3fd0009d > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:34:46,648 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x8904 expected 0x8f34 for client session id 51b8905c90251 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:43:46,834 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x3a8d expected 0x3ebc for client session id 2051af11af900cc > clearly something is not right in the new commit processor per session queue > implementation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2684) Fix a crashing bug in the mixed workloads commit processor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857467#comment-15857467 ] Michael Han commented on ZOOKEEPER-2684: Please use https://github.com/apache/zookeeper - fork it and you can create pull request. branch master is for 3.6 so yes, patch on top of master. > Fix a crashing bug in the mixed workloads commit processor > -- > > Key: ZOOKEEPER-2684 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2684 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.6.0 > Environment: with pretty heavy load on a real cluster >Reporter: Ryan Zhang >Assignee: Ryan Zhang >Priority: Blocker > > We deployed our build with ZOOKEEPER-2024 and it quickly started to crash > with the following error > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:24:42,305 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x119fa expected 0x11fc5 for client session id 1009079ba470055 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:32:04,746 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x698 expected 0x928 for client session id 4002eeb3fd0009d > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:34:46,648 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x8904 expected 0x8f34 for client session id 51b8905c90251 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:43:46,834 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x3a8d expected 0x3ebc for client session id 2051af11af900cc > clearly something is not right in the new commit processor per session queue > implementation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2684) Fix a crashing bug in the mixed workloads commit processor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857465#comment-15857465 ] Ryan Zhang commented on ZOOKEEPER-2684: --- newbie questions, there seems to be two git remote ( https://github.com/apache/zookeeper.git and https://git-wip-us.apache.org/repos/asf/zookeeper.git), which one should I pick? Which branch should I base on? My understanding is that this is in 3.6 but there is no 3.6 branch, does this mean I will patch it on top of master? > Fix a crashing bug in the mixed workloads commit processor > -- > > Key: ZOOKEEPER-2684 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2684 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.6.0 > Environment: with pretty heavy load on a real cluster >Reporter: Ryan Zhang >Assignee: Ryan Zhang >Priority: Blocker > > We deployed our build with ZOOKEEPER-2024 and it quickly started to crash > with the following error > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:24:42,305 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x119fa expected 0x11fc5 for client session id 1009079ba470055 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:32:04,746 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x698 expected 0x928 for client session id 4002eeb3fd0009d > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:34:46,648 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x8904 expected 0x8f34 for client session id 51b8905c90251 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:43:46,834 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x3a8d expected 0x3ebc for client session id 2051af11af900cc > clearly something is not right in the new commit processor per session queue > implementation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2684) Fix a crashing bug in the mixed workloads commit processor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857452#comment-15857452 ] Ryan Zhang commented on ZOOKEEPER-2684: --- Alex, yes, I think the solution is pretty much along this line after we know what leads to this crash. Kfir, I am sorry that I can't really make out exactly what those "this" links point to, can you put a line number somewhere? In any case, I have a fix along the line of knowing the first CXid of the session this server sees and only does the comparison to queue head when it's larger than that. I am testing it internally and also trying to figure out how to do that github and "pull request" thing if I am happy with the result. I am still working on a test case that can repro this reliably and being unsuccessful so far. > Fix a crashing bug in the mixed workloads commit processor > -- > > Key: ZOOKEEPER-2684 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2684 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.6.0 > Environment: with pretty heavy load on a real cluster >Reporter: Ryan Zhang >Assignee: Ryan Zhang >Priority: Blocker > > We deployed our build with ZOOKEEPER-2024 and it quickly started to crash > with the following error > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:24:42,305 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x119fa expected 0x11fc5 for client session id 1009079ba470055 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:32:04,746 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x698 expected 0x928 for client session id 4002eeb3fd0009d > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:34:46,648 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x8904 expected 0x8f34 for client session id 51b8905c90251 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:43:46,834 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x3a8d expected 0x3ebc for client session id 2051af11af900cc > clearly something is not right in the new commit processor per session queue > implementation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: ZooKeeper 3.4.10 release discussion
Thank you Michael for the useful comments. I've updated the wiki page, kindly review it again. Rakesh On Wed, Feb 8, 2017 at 4:17 AM, Michael Han wrote: > Hi Rakesh, > > My super late feedback for > https://cwiki.apache.org/confluence/display/ZOOKEEPER/ > HowToRelease+using+git > with two minor comments: > > * In Branching section, it said: > # create new branch-X.Y from master branch > git checkout -b branch-X.Y master > > # commit and push the changes to remote repo > git commit -m "Preparing for release X.Y.Z" > git push branch-X.Y > > I believe the "git commit" step is redundant, because all we do here is to > create a branch from master, and there is nothing to commit (no staged > files.). We could just remove the commit step. > > * In Updating release branch section, 2 - it mentions merge patch. I think > the recommended approach (or best practice?) which Edward also pointed out > earlier is to use 'git cherry-pick', so we can have a consistent revision > history between branches. > > Thanks for putting up the wiki page! > > On Tue, Feb 7, 2017 at 8:02 AM, Rakesh Radhakrishnan > wrote: > > > Hi PMCs/committers, > > > > It would be great to see feedback on the updated branching release > > procedure mentioned in the cwiki page. How about publishing an initial > > release candidate by following the new procedure, probably you all can > > verify the RC-0 and do voting? > > > > Thanks, > > Rakesh > > > > On Thu, Feb 2, 2017 at 9:43 PM, Rakesh Radhakrishnan > > > wrote: > > > > > Hi All, > > > > > > I've tried an attempt by converting all the applicable svn commands to > > git > > > commands in "HowToRelease using git" cwiki page. Welcome comments, > > thanks! > > > > > > https://cwiki.apache.org/confluence/display/ZOOKEEPER/ > > > HowToRelease+using+git > > > > > > Thanks, > > > Rakesh > > > > > > On Fri, Jan 27, 2017 at 11:54 PM, Edward Ribeiro < > > edward.ribe...@gmail.com > > > > wrote: > > > > > >> > > >> Hi Rakesh, > > >> > > >> I have comment on ZK-2622. > > >> > > >> Took a look at the 'HowToRelease' using git page and have one minor > > >> comment: > > >> > > >> 2. "If not already done, merge desired patches from master into the > > branch > > >> and commit these changes. > > >> (...) > > >> " > > >> > > >> AFAIK merging from master to branch-3.4 would bring all those changes > in > > >> master and try to apply them to branch-3.4. This usuallys leads to > lots > > of > > >> conflicts and is not desirable. What I usually see in Cassandra commit > > >> history is merging upwards: 2.2 -> 3.0 -> 3.1 -> master so that > changes > > in > > >> previous versions are > > >> ported to > > >> further releases > > >> : https://github.com/apache/cassandra/commits/trunk > > >> > > >> > > >> So > > >> , > > >> I would rephrase the "merge desired patches from master into branch > and > > >> commit those changes" to "cherry-pick desired commits from master into > > >> branch". The act of merging/rebasing/cherry-picking auto commit the > > >> changes > > >> on the target branch. If you want to avoid doing that then have to > > resort > > >> to things like this: > > >> http://stackoverflow.com/questions/8640887/git-merge- > > without-auto-commit > > >> > > >> BUT I AM NOT GIT EXPERT, so I feel free to ignore this suggestion. > > >> Further info > > >> here: > > >> http://stackoverflow.com/questions/1241720/git-cherry-pick- > > >> vs-merge-workflow > > >> > > >> Best regards, > > >> Eddie > > >> > > >> > > >> On Fri, Jan 27, 2017 at 9:30 AM, Rakesh Radhakrishnan < > > rake...@apache.org > > >> > > > >> wrote: > > >> > > >> > Thanks Edward for the interest. I hope you are watching > 'HowToRelease' > > >> > using git page discussion, which is still in progress. I'd like to > > give > > >> > some more time to the folks to push their interesting issues(I'd > > prefer > > >> > issues with low risk) until the release procedure is finalized. > > >> > > > >> > I've marked ZOOKEEPER-2622's fix version to 3.4.10, appreciate your > > >> > feedback on the attached pull request so that some of our committers > > >> will > > >> > help in pushing it upstream. > > >> > > > >> > Thanks, > > >> > Rakesh > > >> > > > >> > On Thu, Jan 26, 2017 at 5:35 PM, Edward Ribeiro < > > >> edward.ribe...@gmail.com> > > >> > wrote: > > >> > > > >> > > Hi, > > >> > > > > >> > > Rakesh and Flavio, what do you think about merging ZOOKEEPER-2622 > to > > >> > > branch-3.4 and include it in 3.4.10 besides branch-3.5 and master? > > >> > > > > >> > > Edward > > >> > > > > >> > > On Thu, Jan 26, 2017 at 8:20 AM, Flavio Junqueira > > > >> > wrote: > > >> > > > > >> > > > Here are a few comments on the proposal of changes to the > release > > >> > > process: > > >> > > > > > >> > > > - It might be a better idea to preserve the HowToRelease > document > > >> for > > >> > > > future reference, clone the document, and change the cloned > > >> document to > > >> > > > reflect the git commands rather than svn. > > >> > > > - We still ne
[jira] [Comment Edited] (ZOOKEEPER-2684) Fix a crashing bug in the mixed workloads commit processor
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857357#comment-15857357
]
Kfir Lev-Ari edited comment on ZOOKEEPER-2684 at 2/8/17 4:21 AM:
-
+ to what Alex wrote - handle the case of < as a remote session commit.
I.e., something like these changes:
[here|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java#L256]
change the "!=" to ">".
and
[here|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java#L255]
need to "peek" instead of "poll".
and
[here|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java#L271]
need to add
"if (request.cxid == topPending.cxid) {
sessionQueue.poll();"
and the rest of the local request processing up until
[this|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java#L274]
line.
was (Author: kfirlevari):
+ to what Alex wrote - handle the case of < as a remote session commit, I.e.,
the "else" case.
> Fix a crashing bug in the mixed workloads commit processor
> --
>
> Key: ZOOKEEPER-2684
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2684
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.6.0
> Environment: with pretty heavy load on a real cluster
>Reporter: Ryan Zhang
>Assignee: Ryan Zhang
>Priority: Blocker
>
> We deployed our build with ZOOKEEPER-2024 and it quickly started to crash
> with the following error
> atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:24:42,305 - ERROR
> [CommitProcessor:2]
> -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268)
> – Got cxid 0x119fa expected 0x11fc5 for client session id 1009079ba470055
> atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:32:04,746 - ERROR
> [CommitProcessor:2]
> -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268)
> – Got cxid 0x698 expected 0x928 for client session id 4002eeb3fd0009d
> atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:34:46,648 - ERROR
> [CommitProcessor:2]
> -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268)
> – Got cxid 0x8904 expected 0x8f34 for client session id 51b8905c90251
> atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:43:46,834 - ERROR
> [CommitProcessor:2]
> -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268)
> – Got cxid 0x3a8d expected 0x3ebc for client session id 2051af11af900cc
> clearly something is not right in the new commit processor per session queue
> implementation.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (ZOOKEEPER-2685) How to implement SSL in zookeeper-3.4.5-3
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-2685. Resolution: Won't Fix > How to implement SSL in zookeeper-3.4.5-3 > - > > Key: ZOOKEEPER-2685 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2685 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.5 >Reporter: shamim khan > > want to implement SSL in zookeeeper. But not able to implement as version > issue. So how can we implement in zookeeper-3.4.5-3. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2685) How to implement SSL in zookeeper-3.4.5-3
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857364#comment-15857364 ] Michael Han commented on ZOOKEEPER-2685: [~shamim_er] There is no patch that could be directly applied on branch-3.4 to get SSL feature. Technically it might be possible but no one (at least publicly) is working on this. > How to implement SSL in zookeeper-3.4.5-3 > - > > Key: ZOOKEEPER-2685 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2685 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.5 >Reporter: shamim khan > > want to implement SSL in zookeeeper. But not able to implement as version > issue. So how can we implement in zookeeper-3.4.5-3. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2684) Fix a crashing bug in the mixed workloads commit processor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857357#comment-15857357 ] Kfir Lev-Ari commented on ZOOKEEPER-2684: - + to what Alex wrote - handle the case of < as a remote session commit, I.e., the "else" case. > Fix a crashing bug in the mixed workloads commit processor > -- > > Key: ZOOKEEPER-2684 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2684 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.6.0 > Environment: with pretty heavy load on a real cluster >Reporter: Ryan Zhang >Assignee: Ryan Zhang >Priority: Blocker > > We deployed our build with ZOOKEEPER-2024 and it quickly started to crash > with the following error > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:24:42,305 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x119fa expected 0x11fc5 for client session id 1009079ba470055 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:32:04,746 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x698 expected 0x928 for client session id 4002eeb3fd0009d > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:34:46,648 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x8904 expected 0x8f34 for client session id 51b8905c90251 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:43:46,834 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x3a8d expected 0x3ebc for client session id 2051af11af900cc > clearly something is not right in the new commit processor per session queue > implementation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2684) Fix a crashing bug in the mixed workloads commit processor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857354#comment-15857354 ] Alexander Shraer commented on ZOOKEEPER-2684: - Hi Ryan, Thanks for the analysis! How about throwing an exception only in case we see a cxid > what we expected, and only logging if we see something smaller than expected ? Thanks, Alex > Fix a crashing bug in the mixed workloads commit processor > -- > > Key: ZOOKEEPER-2684 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2684 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.6.0 > Environment: with pretty heavy load on a real cluster >Reporter: Ryan Zhang >Assignee: Ryan Zhang >Priority: Blocker > > We deployed our build with ZOOKEEPER-2024 and it quickly started to crash > with the following error > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:24:42,305 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x119fa expected 0x11fc5 for client session id 1009079ba470055 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:32:04,746 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x698 expected 0x928 for client session id 4002eeb3fd0009d > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:34:46,648 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x8904 expected 0x8f34 for client session id 51b8905c90251 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:43:46,834 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x3a8d expected 0x3ebc for client session id 2051af11af900cc > clearly something is not right in the new commit processor per session queue > implementation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2685) How to implement SSL in zookeeper-3.4.5-3
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857320#comment-15857320 ] shamim khan commented on ZOOKEEPER-2685: We are not in position to upgrade zookeeper version. so want to to know is there any patch which can be applied on 3.4.x so that we can achieve SSL. > How to implement SSL in zookeeper-3.4.5-3 > - > > Key: ZOOKEEPER-2685 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2685 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.5 >Reporter: shamim khan > > want to implement SSL in zookeeeper. But not able to implement as version > issue. So how can we implement in zookeeper-3.4.5-3. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (ZOOKEEPER-2686) Flaky Test: org.apache.zookeeper.test.WatcherTest.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abraham Fine reassigned ZOOKEEPER-2686:
---
Assignee: Abraham Fine
> Flaky Test: org.apache.zookeeper.test.WatcherTest.
> --
>
> Key: ZOOKEEPER-2686
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2686
> Project: ZooKeeper
> Issue Type: Test
> Components: tests
>Affects Versions: 3.4.9, 3.5.2, 3.6.0
>Reporter: Michael Han
>Assignee: Abraham Fine
> Labels: flaky-test
>
> Once in a while, these tests failed.
> {noformat}
> org.apache.zookeeper.test.WatcherTest.testWatchAutoResetWithPending
> org.apache.zookeeper.test.WatcherTest.testWatcherCorrectness
> org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetDisabledWithLocal
> org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetWithGlobal
> org.apache.zookeeper.test.WatcherTest.testWatcherCount
> org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetDisabledWithGlobal
> org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetWithLocal
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2684) Fix a crashing bug in the mixed workloads commit processor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857018#comment-15857018 ] Ryan Zhang commented on ZOOKEEPER-2684: --- While I am at it, let me paste the enhanced log of a repo. The problem was created when there is a session move. When a session just moved, the new processor starts to get requests from the session so it will crash when a commit coming from previous session handler comes. Here are the logs from on repro Learner A got the session 0x100186ea825fa45 starting from cxid 0xfb6 /var/log/zookeeper/zookeeper-info.log.65:2017-02-06 20:56:03,635 - INFO [FollowerRequestProcessor:0] - Processing request:: sessionid:0x100186ea825fa45 type:create cxid:0xfb6 zxi d:0xfffe txntype:unknown reqpath:/loadgen/load_ /var/log/zookeeper/zookeeper-info.log.65:2017-02-06 20:56:03,636 - INFO [FollowerRequestProcessor:0] - Processing request:: sessionid:0x100186ea825fa45 type:delete cxid:0xfb7 zxi d:0xfffe txntype:unknown reqpath:/loadgen/load_1301965514 /var/log/zookeeper/zookeeper-info.log.65:2017-02-06 20:56:03,636 - INFO [FollowerRequestProcessor:0] - Processing request:: sessionid:0x100186ea825fa45 type:create cxid:0xfb8 zxi d:0xfffe txntype:unknown reqpath:/loadgen/load_ /var/log/zookeeper/zookeeper-info.log.65:2017-02-06 20:56:04,123 - INFO [QuorumPeer[myid=0](plain=/0:0:0:0:0:0:0:0:2181)(secure=disabled)] - Committing request:: sessionid:0x100186ea825fa45 type:error cxid:0xfb5 zxid:0x8e06e60288 txntype:-1 reqpath:n/a /var/log/zookeeper/zookeeper-info.log.65:2017-02-06 20:56:04,123 - ERROR [CommitProcessor:0] - Got request sessionid:0x100186ea825fa45 type:error cxid:0xfb5 zxid:0x8e06e60288 txntype:-1 reqpath:n/a /var/log/zookeeper/zookeeper-info.log.65: expected request sessionid:0x100186ea825fa45 type:create cxid:0xfb6 zxid:0xfffe txntype:unknown reqpath:/loadgen/load_ /var/log/zookeeper/zookeeper-info.log.65: for client session id 0x100186ea825fa45 follower B that processed 0xfb5 and got session 0x100186ea825fa45 closed after 0Xfb5 /var/log/zookeeper/zookeeper-info.log.67:2017-02-06 20:55:34,234 - INFO [FollowerRequestProcessor:4] - Processing request:: sessionid:0x100186ea825fa45 type:delete cxid:0xfb0 zxi d:0xfffe txntype:unknown reqpath:/loadgen/load_1301965515 /var/log/zookeeper/zookeeper-info.log.67:2017-02-06 20:55:34,345 - INFO [FollowerRequestProcessor:4] - Processing request:: sessionid:0x100186ea825fa45 type:create cxid:0xfb1 zxi d:0xfffe txntype:unknown reqpath:/loadgen/load_ /var/log/zookeeper/zookeeper-info.log.67:2017-02-06 20:55:34,659 - INFO [QuorumPeer[myid=4](plain=/0:0:0:0:0:0:0:0:2181)(secure=disabled)] - Committing request:: sessionid:0x1001 86ea825fa45 type:delete cxid:0xfae zxid:0x8e06e3c727 txntype:2 reqpath:n/a /var/log/zookeeper/zookeeper-info.log.67:2017-02-06 20:55:34,659 - INFO [QuorumPeer[myid=4](plain=/0:0:0:0:0:0:0:0:2181)(secure=disabled)] - Committing request:: sessionid:0x1001 86ea825fa45 type:create cxid:0xfaf zxid:0x8e06e3c728 txntype:1 reqpath:n/a /var/log/zookeeper/zookeeper-info.log.67:2017-02-06 20:55:34,664 - INFO [FollowerRequestProcessor:4] - Processing request:: sessionid:0x100186ea825fa45 type:delete cxid:0xfb2 zxi d:0xfffe txntype:unknown reqpath:/loadgen/load_1301965516 /var/log/zookeeper/zookeeper-info.log.67:2017-02-06 20:55:34,764 - INFO [FollowerRequestProcessor:4] - Processing request:: sessionid:0x100186ea825fa45 type:create cxid:0xfb3 zxi d:0xfffe txntype:unknown reqpath:/loadgen/load_ /var/log/zookeeper/zookeeper-info.log.67:2017-02-06 20:55:35,056 - INFO [FollowerRequestProcessor:4] - Processing request:: sessionid:0x100186ea825fa45 type:delete cxid:0xfb4 zxi d:0xfffe txntype:unknown reqpath:/loadgen/load_1301965517 /var/log/zookeeper/zookeeper-info.log.67:2017-02-06 20:55:35,363 - INFO [QuorumPeer[myid=4](plain=/0:0:0:0:0:0:0:0:2181)(secure=disabled)] - Committing request:: sessionid:0x1001 86ea825fa45 type:delete cxid:0xfb0 zxid:0x8e06e3d4bc txntype:2 reqpath:n/a /var/log/zookeeper/zookeeper-info.log.67:2017-02-06 20:55:35,465 - INFO [QuorumPeer[myid=4](plain=/0:0:0:0:0:0:0:0:2181)(secure=disabled)] - Committing request:: sessionid:0x1001 86ea825fa45 type:create cxid:0xfb1 zxid:0x8e06e3d718 txntype:1 reqpath:n/a /var/log/zookeeper/zookeeper-info.log.67:2017-02-06 20:55:35,804 - INFO [QuorumPeer[myid=4](plain=/0:0:0:0:0:0:0:0:2181)(secure=disabled)] - Committing request:: sessionid:0x1001 86ea825fa45 type:delete cxid:0xfb2 zxid:0x8e06e3de59 txntype:2 reqpath:n/a /var/log/zookeeper/zookeeper-info.log.67:2017-02-06 20:55:35,882 - INFO [QuorumPeer[myid=4](plain=/0:0:0:0:0:0:0:0:2181)(secure=disabled)] - Committing request:: sessionid:0x1001 86ea825fa45 type:create cxid:0xfb3 zxid:0x8e06e3dfe6 txntype:1 reqpath:n/a /var/log/zookeeper/zookeeper-info.lo
[jira] [Comment Edited] (ZOOKEEPER-2684) Fix a crashing bug in the mixed workloads commit processor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857009#comment-15857009 ] Ryan Zhang edited comment on ZOOKEEPER-2684 at 2/7/17 11:20 PM: Hi, Kfir, I think you are getting to the point. (I don't need to add the log, I knew what happened) The unpatched version just pass that request to the next processor while this patch throw an exception. I am pasting the exact reason below to save you more guess time :) was (Author: nerdyyatrice): Hi, Kfir, I think you get the point. (I don't need to add the log, I knew what happened) The unpatched version just pass that request to the next processor while this patch throw an exception. > Fix a crashing bug in the mixed workloads commit processor > -- > > Key: ZOOKEEPER-2684 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2684 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.6.0 > Environment: with pretty heavy load on a real cluster >Reporter: Ryan Zhang >Assignee: Ryan Zhang >Priority: Blocker > > We deployed our build with ZOOKEEPER-2024 and it quickly started to crash > with the following error > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:24:42,305 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x119fa expected 0x11fc5 for client session id 1009079ba470055 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:32:04,746 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x698 expected 0x928 for client session id 4002eeb3fd0009d > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:34:46,648 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x8904 expected 0x8f34 for client session id 51b8905c90251 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:43:46,834 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x3a8d expected 0x3ebc for client session id 2051af11af900cc > clearly something is not right in the new commit processor per session queue > implementation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (ZOOKEEPER-2684) Fix a crashing bug in the mixed workloads commit processor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857009#comment-15857009 ] Ryan Zhang edited comment on ZOOKEEPER-2684 at 2/7/17 11:18 PM: Hi, Kfir, I think you get the point. (I don't need to add the log, I knew what happened) The unpatched version just pass that request to the next processor while this patch throw an exception. was (Author: nerdyyatrice): Hi, Kfir, I think you get the point. (I don't need to add the log, I knew what happened) The unpatched version just pass that request to the next processor while this patch throw an exception. > Fix a crashing bug in the mixed workloads commit processor > -- > > Key: ZOOKEEPER-2684 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2684 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.6.0 > Environment: with pretty heavy load on a real cluster >Reporter: Ryan Zhang >Assignee: Ryan Zhang >Priority: Blocker > > We deployed our build with ZOOKEEPER-2024 and it quickly started to crash > with the following error > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:24:42,305 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x119fa expected 0x11fc5 for client session id 1009079ba470055 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:32:04,746 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x698 expected 0x928 for client session id 4002eeb3fd0009d > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:34:46,648 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x8904 expected 0x8f34 for client session id 51b8905c90251 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:43:46,834 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x3a8d expected 0x3ebc for client session id 2051af11af900cc > clearly something is not right in the new commit processor per session queue > implementation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2684) Fix a crashing bug in the mixed workloads commit processor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857009#comment-15857009 ] Ryan Zhang commented on ZOOKEEPER-2684: --- Hi, Kfir, I think you get the point. (I don't need to add the log, I knew what happened) The unpatched version just pass that request to the next processor while this patch throw an exception. > Fix a crashing bug in the mixed workloads commit processor > -- > > Key: ZOOKEEPER-2684 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2684 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.6.0 > Environment: with pretty heavy load on a real cluster >Reporter: Ryan Zhang >Assignee: Ryan Zhang >Priority: Blocker > > We deployed our build with ZOOKEEPER-2024 and it quickly started to crash > with the following error > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:24:42,305 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x119fa expected 0x11fc5 for client session id 1009079ba470055 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:32:04,746 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x698 expected 0x928 for client session id 4002eeb3fd0009d > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:34:46,648 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x8904 expected 0x8f34 for client session id 51b8905c90251 > atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:43:46,834 - ERROR > [CommitProcessor:2] > -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268) > – Got cxid 0x3a8d expected 0x3ebc for client session id 2051af11af900cc > clearly something is not right in the new commit processor per session queue > implementation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: ZooKeeper 3.4.10 release discussion
Hi Rakesh, My super late feedback for https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease+using+git with two minor comments: * In Branching section, it said: # create new branch-X.Y from master branch git checkout -b branch-X.Y master # commit and push the changes to remote repo git commit -m "Preparing for release X.Y.Z" git push branch-X.Y I believe the "git commit" step is redundant, because all we do here is to create a branch from master, and there is nothing to commit (no staged files.). We could just remove the commit step. * In Updating release branch section, 2 - it mentions merge patch. I think the recommended approach (or best practice?) which Edward also pointed out earlier is to use 'git cherry-pick', so we can have a consistent revision history between branches. Thanks for putting up the wiki page! On Tue, Feb 7, 2017 at 8:02 AM, Rakesh Radhakrishnan wrote: > Hi PMCs/committers, > > It would be great to see feedback on the updated branching release > procedure mentioned in the cwiki page. How about publishing an initial > release candidate by following the new procedure, probably you all can > verify the RC-0 and do voting? > > Thanks, > Rakesh > > On Thu, Feb 2, 2017 at 9:43 PM, Rakesh Radhakrishnan > wrote: > > > Hi All, > > > > I've tried an attempt by converting all the applicable svn commands to > git > > commands in "HowToRelease using git" cwiki page. Welcome comments, > thanks! > > > > https://cwiki.apache.org/confluence/display/ZOOKEEPER/ > > HowToRelease+using+git > > > > Thanks, > > Rakesh > > > > On Fri, Jan 27, 2017 at 11:54 PM, Edward Ribeiro < > edward.ribe...@gmail.com > > > wrote: > > > >> > >> Hi Rakesh, > >> > >> I have comment on ZK-2622. > >> > >> Took a look at the 'HowToRelease' using git page and have one minor > >> comment: > >> > >> 2. "If not already done, merge desired patches from master into the > branch > >> and commit these changes. > >> (...) > >> " > >> > >> AFAIK merging from master to branch-3.4 would bring all those changes in > >> master and try to apply them to branch-3.4. This usuallys leads to lots > of > >> conflicts and is not desirable. What I usually see in Cassandra commit > >> history is merging upwards: 2.2 -> 3.0 -> 3.1 -> master so that changes > in > >> previous versions are > >> ported to > >> further releases > >> : https://github.com/apache/cassandra/commits/trunk > >> > >> > >> So > >> , > >> I would rephrase the "merge desired patches from master into branch and > >> commit those changes" to "cherry-pick desired commits from master into > >> branch". The act of merging/rebasing/cherry-picking auto commit the > >> changes > >> on the target branch. If you want to avoid doing that then have to > resort > >> to things like this: > >> http://stackoverflow.com/questions/8640887/git-merge- > without-auto-commit > >> > >> BUT I AM NOT GIT EXPERT, so I feel free to ignore this suggestion. > >> Further info > >> here: > >> http://stackoverflow.com/questions/1241720/git-cherry-pick- > >> vs-merge-workflow > >> > >> Best regards, > >> Eddie > >> > >> > >> On Fri, Jan 27, 2017 at 9:30 AM, Rakesh Radhakrishnan < > rake...@apache.org > >> > > >> wrote: > >> > >> > Thanks Edward for the interest. I hope you are watching 'HowToRelease' > >> > using git page discussion, which is still in progress. I'd like to > give > >> > some more time to the folks to push their interesting issues(I'd > prefer > >> > issues with low risk) until the release procedure is finalized. > >> > > >> > I've marked ZOOKEEPER-2622's fix version to 3.4.10, appreciate your > >> > feedback on the attached pull request so that some of our committers > >> will > >> > help in pushing it upstream. > >> > > >> > Thanks, > >> > Rakesh > >> > > >> > On Thu, Jan 26, 2017 at 5:35 PM, Edward Ribeiro < > >> edward.ribe...@gmail.com> > >> > wrote: > >> > > >> > > Hi, > >> > > > >> > > Rakesh and Flavio, what do you think about merging ZOOKEEPER-2622 to > >> > > branch-3.4 and include it in 3.4.10 besides branch-3.5 and master? > >> > > > >> > > Edward > >> > > > >> > > On Thu, Jan 26, 2017 at 8:20 AM, Flavio Junqueira > >> > wrote: > >> > > > >> > > > Here are a few comments on the proposal of changes to the release > >> > > process: > >> > > > > >> > > > - It might be a better idea to preserve the HowToRelease document > >> for > >> > > > future reference, clone the document, and change the cloned > >> document to > >> > > > reflect the git commands rather than svn. > >> > > > - We still need to modify Step 2 to be git oriented, otherwise it > >> will > >> > > > look odd that we have svn there. > >> > > > - In Step 4, I thought that we had informally agreed to rely on > the > >> git > >> > > > log rather than maintain the CHANGES.txt file. If we aren't all > >> onboard > >> > > > with the idea of stopping to use CHANGES.txt, then we need to > >> discuss > >> > > this > >> > > > separately. > >> > > > - Steps 5 and 6: I'm not sure why the steps to produ
[jira] [Commented] (ZOOKEEPER-2685) How to implement SSL in zookeeper-3.4.5-3
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856910#comment-15856910 ] Michael Han commented on ZOOKEEPER-2685: [~shamim_er] Do you mind clarify what you are trying to achieve here? In particular, what is the "version issue" you referred to? Please note that ZooKeeper already supports client/server SSL which is implemented in ZOOKEEPER-2125 for 3.5.x, and there is currently no plan to port this feature to 3.4 branch (see the recent comments in ZOOKEEPER-2125.). > How to implement SSL in zookeeper-3.4.5-3 > - > > Key: ZOOKEEPER-2685 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2685 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.5 >Reporter: shamim khan > > want to implement SSL in zookeeeper. But not able to implement as version > issue. So how can we implement in zookeeper-3.4.5-3. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (ZOOKEEPER-2686) Flaky Test: org.apache.zookeeper.test.WatcherTest.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Han updated ZOOKEEPER-2686:
---
Issue Type: Test (was: Bug)
> Flaky Test: org.apache.zookeeper.test.WatcherTest.
> --
>
> Key: ZOOKEEPER-2686
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2686
> Project: ZooKeeper
> Issue Type: Test
> Components: tests
>Affects Versions: 3.4.9, 3.5.2, 3.6.0
>Reporter: Michael Han
> Labels: flaky-test
>
> Once in a while, these tests failed.
> {noformat}
> org.apache.zookeeper.test.WatcherTest.testWatchAutoResetWithPending
> org.apache.zookeeper.test.WatcherTest.testWatcherCorrectness
> org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetDisabledWithLocal
> org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetWithGlobal
> org.apache.zookeeper.test.WatcherTest.testWatcherCount
> org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetDisabledWithGlobal
> org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetWithLocal
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (ZOOKEEPER-2686) Flaky Test: org.apache.zookeeper.test.WatcherTest.
Michael Han created ZOOKEEPER-2686:
--
Summary: Flaky Test: org.apache.zookeeper.test.WatcherTest.
Key: ZOOKEEPER-2686
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2686
Project: ZooKeeper
Issue Type: Bug
Components: tests
Affects Versions: 3.5.2, 3.4.9, 3.6.0
Reporter: Michael Han
Once in a while, these tests failed.
{noformat}
org.apache.zookeeper.test.WatcherTest.testWatchAutoResetWithPending
org.apache.zookeeper.test.WatcherTest.testWatcherCorrectness
org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetDisabledWithLocal
org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetWithGlobal
org.apache.zookeeper.test.WatcherTest.testWatcherCount
org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetDisabledWithGlobal
org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetWithLocal
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2684) Fix a crashing bug in the mixed workloads commit processor
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856615#comment-15856615
]
Kfir Lev-Ari commented on ZOOKEEPER-2684:
-
Hi Ryan, is it possible that the reason you see this type of bad behavior is
because it wasn't examined before in the commit processor? i.e., it's a new
error message that we added in order to notify that commit messages don't
follow their client order.
I wonder, can you to add to an un-patched version the same error message? (and
see if you get that error)
e.g., before
[this|https://github.com/apache/zookeeper/commit/9fc632c4f0a340b0a00ec6dff39c7b454c802822?diff=split#diff-5cc688a027068714af01b0ad4d292fe5L223]
point, add something like
if (pending != null && pending.sessionId == request.sessionId && pending.cxid >
request.cxid)
LOG.error("Got cxid 0x " + Long.toHexString(request.cxid) + " expected 0x" +
Long.toHexString(pending.cxid) + " for client session id " +
Long.toHexString(request.sessionId));
throw new IOException("Error: unexpected cxid for" + "client session");
> Fix a crashing bug in the mixed workloads commit processor
> --
>
> Key: ZOOKEEPER-2684
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2684
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.6.0
> Environment: with pretty heavy load on a real cluster
>Reporter: Ryan Zhang
>Assignee: Ryan Zhang
>Priority: Blocker
>
> We deployed our build with ZOOKEEPER-2024 and it quickly started to crash
> with the following error
> atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:24:42,305 - ERROR
> [CommitProcessor:2]
> -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268)
> – Got cxid 0x119fa expected 0x11fc5 for client session id 1009079ba470055
> atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:32:04,746 - ERROR
> [CommitProcessor:2]
> -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268)
> – Got cxid 0x698 expected 0x928 for client session id 4002eeb3fd0009d
> atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:34:46,648 - ERROR
> [CommitProcessor:2]
> -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268)
> – Got cxid 0x8904 expected 0x8f34 for client session id 51b8905c90251
> atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:43:46,834 - ERROR
> [CommitProcessor:2]
> -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:268)
> – Got cxid 0x3a8d expected 0x3ebc for client session id 2051af11af900cc
> clearly something is not right in the new commit processor per session queue
> implementation.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2680) Correct DataNode.getChildren() inconsistent behaviour.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856528#comment-15856528
]
Mohammad Arshad commented on ZOOKEEPER-2680:
Thanks [~rakeshr].
branch-3.5 all tests are passing.
branch-3.4 has following failures which are not related to this patch.
{noformat}
org.apache.zookeeper.server.quorum.auth.MiniKdcTest
org.apache.zookeeper.server.quorum.auth.QuorumKerberosAuthTest
org.apache.zookeeper.server.quorum.auth.QuorumKerberosHostBasedAuthTest
{noformat}
with error message
{noformat}
org/apache/kerby/kerberos/kerb/KrbException : Unsupported major.minor version
51.0
{noformat}
I have run branch-3.5 on jdk1.7.0_80 branch-3.4 on jdk1.6.0_45
> Correct DataNode.getChildren() inconsistent behaviour.
> --
>
> Key: ZOOKEEPER-2680
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2680
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.4.9, 3.5.1
>Reporter: Mohammad Arshad
>Assignee: Mohammad Arshad
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2680-01.patch
>
>
> DataNode.getChildren() API returns null and empty set if there are no
> children in it depending on when the API is called. DataNode.getChildren()
> API behavior should be changed and it should always return empty set if the
> node does not have any child
> *DataNode.getChildren() API Current Behavior:*
> # returns null initially
> When DataNode is created and no children are added yet,
> DataNode.getChildren() returns null
> # returns empty set after all the children are deleted:
> created a Node
> add a child
> delete the child
> DataNode.getChildren() returns empty set.
> After fix DataNode.getChildren() should return empty set in all the above
> cases.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
ZooKeeper_branch35_solaris - Build # 425 - Failure
See https://builds.apache.org/job/ZooKeeper_branch35_solaris/425/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 499081 lines...] [junit] 2017-02-07 17:23:18,550 [myid:] - INFO [main:ClientBase@361] - STARTING server instance 127.0.0.1:11222 [junit] 2017-02-07 17:23:18,551 [myid:] - INFO [main:ZooKeeperServer@893] - minSessionTimeout set to 6000 [junit] 2017-02-07 17:23:18,551 [myid:] - INFO [main:ZooKeeperServer@902] - maxSessionTimeout set to 6 [junit] 2017-02-07 17:23:18,551 [myid:] - INFO [main:ZooKeeperServer@159] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test5919820248575434103.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test5919820248575434103.junit.dir/version-2 [junit] 2017-02-07 17:23:18,552 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test5919820248575434103.junit.dir/version-2/snapshot.b [junit] 2017-02-07 17:23:18,554 [myid:] - INFO [main:FileTxnSnapLog@320] - Snapshotting: 0xb to /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test5919820248575434103.junit.dir/version-2/snapshot.b [junit] 2017-02-07 17:23:18,556 [myid:] - ERROR [main:ZooKeeperServer@505] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2017-02-07 17:23:18,556 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222 [junit] 2017-02-07 17:23:18,556 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:59287 [junit] 2017-02-07 17:23:18,557 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from /127.0.0.1:59287 [junit] 2017-02-07 17:23:18,557 [myid:] - INFO [NIOWorkerThread-1:StatCommand@49] - Stat command output [junit] 2017-02-07 17:23:18,558 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@614] - Closed socket connection for client /127.0.0.1:59287 (no session established for client) [junit] 2017-02-07 17:23:18,558 [myid:] - INFO [main:JMXEnv@228] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2017-02-07 17:23:18,559 [myid:] - INFO [main:JMXEnv@245] - expect:InMemoryDataTree [junit] 2017-02-07 17:23:18,559 [myid:] - INFO [main:JMXEnv@249] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree [junit] 2017-02-07 17:23:18,560 [myid:] - INFO [main:JMXEnv@245] - expect:StandaloneServer_port [junit] 2017-02-07 17:23:18,560 [myid:] - INFO [main:JMXEnv@249] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11222 [junit] 2017-02-07 17:23:18,560 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 18008 [junit] 2017-02-07 17:23:18,560 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24 [junit] 2017-02-07 17:23:18,560 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testQuota [junit] 2017-02-07 17:23:18,561 [myid:] - INFO [main:ClientBase@543] - tearDown starting [junit] 2017-02-07 17:23:18,632 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x1269692eaaf [junit] 2017-02-07 17:23:18,632 [myid:] - INFO [main:ZooKeeper@1322] - Session: 0x1269692eaaf closed [junit] 2017-02-07 17:23:18,632 [myid:] - INFO [main:ClientBase@513] - STOPPING server [junit] 2017-02-07 17:23:18,633 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219] - accept thread exitted run method [junit] 2017-02-07 17:23:18,633 [myid:] - INFO [ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - ConnnectionExpirerThread interrupted [junit] 2017-02-07 17:23:18,633 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2017-02-07 17:23:18,633 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2017-02-07 17:23:18,633 [myid:] - INFO [main:ZooKeeperServer@533] - shutting down [junit] 2017-02-07 17:23:18,634 [myid:] - ERROR [main:ZooKeeperServer@505] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any
[jira] [Commented] (ZOOKEEPER-2250) Support client connections using a SOCKS proxy
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856269#comment-15856269 ] David Phillips commented on ZOOKEEPER-2250: --- [~takeseem], that is correct, due to the nature of NIO, applications must add SOCKS support themselves. The protocol itself is quite simple: after connecting, the client sends a few bytes to the server indicating where to connect, then the server replies with a few bytes indicating success or failure. See https://en.wikipedia.org/wiki/SOCKS > Support client connections using a SOCKS proxy > -- > > Key: ZOOKEEPER-2250 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2250 > Project: ZooKeeper > Issue Type: New Feature > Components: java client >Reporter: David Phillips > > Connecting to ZooKeeper via a SOCKS proxy is often useful for debugging > systems over an SSH dynamic port forward. > It is possible to do this today with some hacking by setting > "zookeeper.clientCnxnSocket", but that is difficult because ClientCnxnSocket > is package-private and is quite low-level. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: ZooKeeper 3.4.10 release discussion
Hi PMCs/committers, It would be great to see feedback on the updated branching release procedure mentioned in the cwiki page. How about publishing an initial release candidate by following the new procedure, probably you all can verify the RC-0 and do voting? Thanks, Rakesh On Thu, Feb 2, 2017 at 9:43 PM, Rakesh Radhakrishnan wrote: > Hi All, > > I've tried an attempt by converting all the applicable svn commands to git > commands in "HowToRelease using git" cwiki page. Welcome comments, thanks! > > https://cwiki.apache.org/confluence/display/ZOOKEEPER/ > HowToRelease+using+git > > Thanks, > Rakesh > > On Fri, Jan 27, 2017 at 11:54 PM, Edward Ribeiro > wrote: > >> >> Hi Rakesh, >> >> I have comment on ZK-2622. >> >> Took a look at the 'HowToRelease' using git page and have one minor >> comment: >> >> 2. "If not already done, merge desired patches from master into the branch >> and commit these changes. >> (...) >> " >> >> AFAIK merging from master to branch-3.4 would bring all those changes in >> master and try to apply them to branch-3.4. This usuallys leads to lots of >> conflicts and is not desirable. What I usually see in Cassandra commit >> history is merging upwards: 2.2 -> 3.0 -> 3.1 -> master so that changes in >> previous versions are >> ported to >> further releases >> : https://github.com/apache/cassandra/commits/trunk >> >> >> So >> , >> I would rephrase the "merge desired patches from master into branch and >> commit those changes" to "cherry-pick desired commits from master into >> branch". The act of merging/rebasing/cherry-picking auto commit the >> changes >> on the target branch. If you want to avoid doing that then have to resort >> to things like this: >> http://stackoverflow.com/questions/8640887/git-merge-without-auto-commit >> >> BUT I AM NOT GIT EXPERT, so I feel free to ignore this suggestion. >> Further info >> here: >> http://stackoverflow.com/questions/1241720/git-cherry-pick- >> vs-merge-workflow >> >> Best regards, >> Eddie >> >> >> On Fri, Jan 27, 2017 at 9:30 AM, Rakesh Radhakrishnan > > >> wrote: >> >> > Thanks Edward for the interest. I hope you are watching 'HowToRelease' >> > using git page discussion, which is still in progress. I'd like to give >> > some more time to the folks to push their interesting issues(I'd prefer >> > issues with low risk) until the release procedure is finalized. >> > >> > I've marked ZOOKEEPER-2622's fix version to 3.4.10, appreciate your >> > feedback on the attached pull request so that some of our committers >> will >> > help in pushing it upstream. >> > >> > Thanks, >> > Rakesh >> > >> > On Thu, Jan 26, 2017 at 5:35 PM, Edward Ribeiro < >> edward.ribe...@gmail.com> >> > wrote: >> > >> > > Hi, >> > > >> > > Rakesh and Flavio, what do you think about merging ZOOKEEPER-2622 to >> > > branch-3.4 and include it in 3.4.10 besides branch-3.5 and master? >> > > >> > > Edward >> > > >> > > On Thu, Jan 26, 2017 at 8:20 AM, Flavio Junqueira >> > wrote: >> > > >> > > > Here are a few comments on the proposal of changes to the release >> > > process: >> > > > >> > > > - It might be a better idea to preserve the HowToRelease document >> for >> > > > future reference, clone the document, and change the cloned >> document to >> > > > reflect the git commands rather than svn. >> > > > - We still need to modify Step 2 to be git oriented, otherwise it >> will >> > > > look odd that we have svn there. >> > > > - In Step 4, I thought that we had informally agreed to rely on the >> git >> > > > log rather than maintain the CHANGES.txt file. If we aren't all >> onboard >> > > > with the idea of stopping to use CHANGES.txt, then we need to >> discuss >> > > this >> > > > separately. >> > > > - Steps 5 and 6: I'm not sure why the steps to produce the release >> > notes >> > > > changes. We still resolve issues on jira which is pretty much the >> > source >> > > of >> > > > data for the release notes. >> > > > - Step 10: I personally don't like using "git commit -a" unless >> you're >> > > > pretty sure that it is what you want. A much safer approach is to >> run >> > > "git >> > > > status" and "git add" to the individual files/directories. >> > > > - Step 11: Why are we tagging with -s? Is that standard practice in >> > other >> > > > projects? >> > > > >> > > > -Flavio >> > > > >> > > > > On 26 Jan 2017, at 03:30, Rakesh Radhakrishnan < >> rake...@apache.org> >> > > > wrote: >> > > > > >> > > > > Agreed, will try to resolve ZK-2184. I have included this to >> 3.4.10 >> > > > > releasing. I could see few open review comments in the PR, >> probably >> > > will >> > > > > push once this is concluded. >> > > > > >> > > > > Thanks, >> > > > > Rakesh >> > > > > >> > > > > On Thu, Jan 26, 2017 at 2:01 AM, Flavio Junqueira > > >> > > > wrote: >> > > > > >> > > > >> I'd like to have ZK-2184 in as well. I have seen many cases in >> which >> > > > >> applications are affected by that problem. If folks can help me >> push >> > > it >> > > > >> through,
[jira] [Comment Edited] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856218#comment-15856218
]
Enrico Olivelli edited comment on ZOOKEEPER-2665 at 2/7/17 3:42 PM:
[~fpj] [~eribeiro]
I have filed a PR for the 3.4 branch, IHMO it is working as expected
{quote}
-1 @author. The patch appears to contain 6 @author tags which the Zookeeper
community has agreed to not allow in code contribution
{quote}
the patch contains the "@author" keywork in self-code, I think it is OK
If for you it is OK I can file a PR for the 3.5 branch as well
was (Author: eolivelli):
[~fpj] [~eribeiro]
I have filed a PR for the 3.4 branch, IHMO it is workng well
{quote}
-1 @author. The patch appears to contain 6 @author tags which the Zookeeper
community has agreed to not allow in code contribution
{quote}
the patch contains the "@author" keywork in self-code, I think it is OK
If for you it is OK I can file a PR for the 3.5 branch as well
> Port QA github pull request build to branch 3.4 and 3.5
> ---
>
> Key: ZOOKEEPER-2665
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665
> Project: ZooKeeper
> Issue Type: Test
> Components: build
>Reporter: Flavio Junqueira
> Fix For: 3.5.3, 3.4.11
>
>
> We have QA build for pull requests against master but not against branches
> 3.4 and 3.5. We need to port the necessary wiring to do it, it shouldn't be
> difficult.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856218#comment-15856218
]
Enrico Olivelli commented on ZOOKEEPER-2665:
[~fpj] [~eribeiro]
I have filed a PR for the 3.4 branch, IHMO it is workng well
{quote}
-1 @author. The patch appears to contain 6 @author tags which the Zookeeper
community has agreed to not allow in code contribution
{quote}
the patch contains the "@author" keywork in self-code, I think it is OK
If for you it is OK I can file a PR for the 3.5 branch as well
> Port QA github pull request build to branch 3.4 and 3.5
> ---
>
> Key: ZOOKEEPER-2665
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665
> Project: ZooKeeper
> Issue Type: Test
> Components: build
>Reporter: Flavio Junqueira
> Fix For: 3.5.3, 3.4.11
>
>
> We have QA build for pull requests against master but not against branches
> 3.4 and 3.5. We need to port the necessary wiring to do it, it shouldn't be
> difficult.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856206#comment-15856206 ] Hadoop QA commented on ZOOKEEPER-2665: -- -1 overall. GitHub Pull Request Build -1 @author. The patch appears to contain 6 @author tags which the Zookeeper community has agreed to not allow in code contributions. +1 tests included. The patch appears to include 15 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 97 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/286//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/286//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/286//console This message is automatically generated. > Port QA github pull request build to branch 3.4 and 3.5 > --- > > Key: ZOOKEEPER-2665 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665 > Project: ZooKeeper > Issue Type: Test > Components: build >Reporter: Flavio Junqueira > Fix For: 3.5.3, 3.4.11 > > > We have QA build for pull requests against master but not against branches > 3.4 and 3.5. We need to port the necessary wiring to do it, it shouldn't be > difficult. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Failed: ZOOKEEPER- PreCommit Build #286
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/286/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 241021 lines...] [exec] +1 tests included. The patch appears to include 15 new or modified tests. [exec] [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 97 new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/286//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/286//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/286//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 8627fd584c7fd532804a2b07a60d88a14638cbb3 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1714: exec returned: 3 Total time: 35 minutes 23 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Recording test results Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 [description-setter] Description set: ZOOKEEPER-2665 Putting comment on the pull request Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 ### ## FAILED TESTS (if any) ## All tests passed
Failed: ZOOKEEPER- PreCommit Build #285
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/285/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 34 lines...]
> git merge fbae2e57715fe89f522e2477f775dd76e1131d93 # timeout=10
> git rev-parse branch-3.4^{commit} # timeout=10
Checking out Revision fbae2e57715fe89f522e2477f775dd76e1131d93 (branch-3.4)
> git config core.sparsecheckout # timeout=10
> git checkout -f fbae2e57715fe89f522e2477f775dd76e1131d93
> git rev-parse origin/branch-3.4^{commit} # timeout=10
> git rev-list 053a9d29973a22ca60a02614911fc6e164d52244 # timeout=10
No emails were triggered.
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[PreCommit-ZOOKEEPER-github-pr-build] $ /bin/bash
/tmp/hudson6805022571689766401.sh
/home/jenkins/tools/java/latest1.7/bin/java
java version "1.7.0_80"
Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
core file size (blocks, -c) 0
data seg size (kbytes, -d) unlimited
scheduling priority (-e) 0
file size (blocks, -f) unlimited
pending signals (-i) 386177
max locked memory (kbytes, -l) 64
max memory size (kbytes, -m) unlimited
open files (-n) 6
pipe size(512 bytes, -p) 8
POSIX message queues (bytes, -q) 819200
real-time priority (-r) 0
stack size (kbytes, -s) 8192
cpu time (seconds, -t) unlimited
max user processes (-u) 10240
virtual memory (kbytes, -v) unlimited
file locks (-x) unlimited
Buildfile:
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml
check-for-findbugs:
findbugs.check:
forrest.check:
qa-test-pullrequest:
[exec] bash: ${test_pullrequest_sh}: No such file or directory
BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1713:
exec returned: 127
Total time: 0 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files
were found. Configuration error?
[description-setter] Could not determine description.
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
###
## FAILED TESTS (if any)
##
No tests ran.
ZooKeeper_branch34_openjdk7 - Build # 1380 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1380/
###
## LAST 60 LINES OF THE CONSOLE
###
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H12 (ubuntu) in workspace
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url git://git.apache.org/zookeeper.git # timeout=10
Cleaning workspace
> git rev-parse --verify HEAD # timeout=10
Resetting working tree
> git reset --hard # timeout=10
> git clean -fdx # timeout=10
Fetching upstream changes from git://git.apache.org/zookeeper.git
> git --version # timeout=10
> git -c core.askpass=true fetch --tags --progress
> git://git.apache.org/zookeeper.git +refs/heads/*:refs/remotes/origin/*
> git rev-parse refs/remotes/origin/branch-3.4^{commit} # timeout=10
> git rev-parse refs/remotes/origin/origin/branch-3.4^{commit} # timeout=10
Checking out Revision 053a9d29973a22ca60a02614911fc6e164d52244
(refs/remotes/origin/branch-3.4)
> git config core.sparsecheckout # timeout=10
> git checkout -f 053a9d29973a22ca60a02614911fc6e164d52244
> git rev-list 053a9d29973a22ca60a02614911fc6e164d52244 # timeout=10
No emails were triggered.
[ZooKeeper_branch34_openjdk7] $ /home/jenkins/tools/ant/latest/bin/ant
-Dtest.output=yes -Dtest.junit.threads=8 -Dtest.junit.output.format=xml
-Djavac.target=1.7 clean test-core-java
Error: JAVA_HOME is not defined correctly.
We cannot execute /usr/lib/jvm/java-7-openjdk-amd64//bin/java
Build step 'Invoke Ant' marked build as failure
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
###
## FAILED TESTS (if any)
##
No tests ran.
Failed: ZOOKEEPER- PreCommit Build #284
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/284/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 25 lines...]
Getting sizes
Done: 6
Compressing objects
Done: 0
Writing objects
Done: 7
remote: Updating references
Merging refs/tags/changes/284
> git rev-parse refs/tags/changes/284^{commit} # timeout=10
> git merge a194d418828bda663e034cecc392a14e98325a1d # timeout=10
> git rev-parse branch-3.4^{commit} # timeout=10
Checking out Revision a194d418828bda663e034cecc392a14e98325a1d (branch-3.4)
> git config core.sparsecheckout # timeout=10
> git checkout -f a194d418828bda663e034cecc392a14e98325a1d
> git rev-parse origin/branch-3.4^{commit} # timeout=10
> git rev-list 053a9d29973a22ca60a02614911fc6e164d52244 # timeout=10
No emails were triggered.
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[PreCommit-ZOOKEEPER-github-pr-build] $ /bin/bash
/tmp/hudson509517589081928335.sh
/home/jenkins/tools/java/latest1.7/bin/java
java version "1.7.0_80"
Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
core file size (blocks, -c) 0
data seg size (kbytes, -d) unlimited
scheduling priority (-e) 0
file size (blocks, -f) unlimited
pending signals (-i) 386178
max locked memory (kbytes, -l) 64
max memory size (kbytes, -m) unlimited
open files (-n) 6
pipe size(512 bytes, -p) 8
POSIX message queues (bytes, -q) 819200
real-time priority (-r) 0
stack size (kbytes, -s) 8192
cpu time (seconds, -t) unlimited
max user processes (-u) 10240
virtual memory (kbytes, -v) unlimited
file locks (-x) unlimited
Buildfile:
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml
BUILD FAILED
Target "qa-test-pullrequest" does not exist in the project "ZooKeeper".
Total time: 0 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files
were found. Configuration error?
[description-setter] Could not determine description.
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
###
## FAILED TESTS (if any)
##
No tests ran.
[jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856061#comment-15856061 ] ASF GitHub Bot commented on ZOOKEEPER-2665: --- GitHub user eolivelli opened a pull request: https://github.com/apache/zookeeper/pull/165 ZOOKEEPER-2665 Port QA github pull request build to branch 3.4 and 3.5 You can merge this pull request into a Git repository by running: $ git pull https://github.com/eolivelli/zookeeper ZOOKEEPER-2665 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/165.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #165 commit a194d418828bda663e034cecc392a14e98325a1d Author: eolivelli Date: 2017-02-07T14:17:24Z ZOOKEEPER-2665 Port QA github pull request build to branch 3.4 and 3.5 > Port QA github pull request build to branch 3.4 and 3.5 > --- > > Key: ZOOKEEPER-2665 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665 > Project: ZooKeeper > Issue Type: Test > Components: build >Reporter: Flavio Junqueira > Fix For: 3.5.3, 3.4.11 > > > We have QA build for pull requests against master but not against branches > 3.4 and 3.5. We need to port the necessary wiring to do it, it shouldn't be > difficult. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] zookeeper pull request #165: ZOOKEEPER-2665 Port QA github pull request buil...
GitHub user eolivelli opened a pull request: https://github.com/apache/zookeeper/pull/165 ZOOKEEPER-2665 Port QA github pull request build to branch 3.4 and 3.5 You can merge this pull request into a Git repository by running: $ git pull https://github.com/eolivelli/zookeeper ZOOKEEPER-2665 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/165.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #165 commit a194d418828bda663e034cecc392a14e98325a1d Author: eolivelli Date: 2017-02-07T14:17:24Z ZOOKEEPER-2665 Port QA github pull request build to branch 3.4 and 3.5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
ZooKeeper_branch34_solaris - Build # 1461 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch34_solaris/1461/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 193712 lines...] [junit] 2017-02-07 13:56:56,663 [myid:] - INFO [main:PrepRequestProcessor@765] - Shutting down [junit] 2017-02-07 13:56:56,664 [myid:] - INFO [main:SyncRequestProcessor@208] - Shutting down [junit] 2017-02-07 13:56:56,664 [myid:] - INFO [ProcessThread(sid:0 cport:11221)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop! [junit] 2017-02-07 13:56:56,664 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@186] - SyncRequestProcessor exited! [junit] 2017-02-07 13:56:56,664 [myid:] - INFO [main:FinalRequestProcessor@402] - shutdown of request processor complete [junit] 2017-02-07 13:56:56,664 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221 [junit] 2017-02-07 13:56:56,665 [myid:] - INFO [main:JMXEnv@147] - ensureOnly:[] [junit] 2017-02-07 13:56:56,666 [myid:] - INFO [main:ClientBase@445] - STARTING server [junit] 2017-02-07 13:56:56,666 [myid:] - INFO [main:ClientBase@366] - CREATING server instance 127.0.0.1:11221 [junit] 2017-02-07 13:56:56,666 [myid:] - INFO [main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2017-02-07 13:56:56,666 [myid:] - INFO [main:ClientBase@341] - STARTING server instance 127.0.0.1:11221 [junit] 2017-02-07 13:56:56,667 [myid:] - INFO [main:ZooKeeperServer@173] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/build/test/tmp/test9216569330909505103.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/build/test/tmp/test9216569330909505103.junit.dir/version-2 [junit] 2017-02-07 13:56:56,669 [myid:] - ERROR [main:ZooKeeperServer@472] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2017-02-07 13:56:56,669 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221 [junit] 2017-02-07 13:56:56,670 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - Accepted socket connection from /127.0.0.1:37226 [junit] 2017-02-07 13:56:56,670 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@838] - Processing stat command from /127.0.0.1:37226 [junit] 2017-02-07 13:56:56,670 [myid:] - INFO [Thread-5:NIOServerCnxn$StatCommand@674] - Stat command output [junit] 2017-02-07 13:56:56,670 [myid:] - INFO [Thread-5:NIOServerCnxn@1019] - Closed socket connection for client /127.0.0.1:37226 (no session established for client) [junit] 2017-02-07 13:56:56,671 [myid:] - INFO [main:JMXEnv@230] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2017-02-07 13:56:56,672 [myid:] - INFO [main:JMXEnv@247] - expect:InMemoryDataTree [junit] 2017-02-07 13:56:56,672 [myid:] - INFO [main:JMXEnv@251] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree [junit] 2017-02-07 13:56:56,672 [myid:] - INFO [main:JMXEnv@247] - expect:StandaloneServer_port [junit] 2017-02-07 13:56:56,672 [myid:] - INFO [main:JMXEnv@251] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11221 [junit] 2017-02-07 13:56:56,672 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 8952 [junit] 2017-02-07 13:56:56,673 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20 [junit] 2017-02-07 13:56:56,673 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota [junit] 2017-02-07 13:56:56,673 [myid:] - INFO [main:ClientBase@522] - tearDown starting [junit] 2017-02-07 13:56:56,751 [myid:] - INFO [main:ZooKeeper@684] - Session: 0x15a18dceddc closed [junit] 2017-02-07 13:56:56,751 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@519] - EventThread shut down for session: 0x15a18dceddc [junit] 2017-02-07 13:56:56,751 [myid:] - INFO [main:ClientBase@492] - STOPPING server [junit] 2017-02-07 13:56:56,752 [myid:] - INFO [main:ZooKeeperServer@497] - shutting down [junit] 2017-02-07 13:56:56,752 [myid:] - ERROR [main:ZooKeeperServer@472] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2017-02-07 13:56:56,753 [myid:] - INFO [main:SessionTrackerImpl@225] - Shutting down [junit] 2017-02-07 13:56:56,753 [myid:] - INFO [main:PrepRequestProcessor@765] - Shutting down [junit] 2017-02-07 13:56:56,753 [myid:
[jira] [Commented] (ZOOKEEPER-2683) RaceConditionTest is flaky
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855651#comment-15855651
]
Hadoop QA commented on ZOOKEEPER-2683:
--
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12851322/ZOOKEEPER-2683-01.patch
against trunk revision ee5615d31ff4da2b2111f5a3b5d5b650f60bf936.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3575//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3575//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3575//console
This message is automatically generated.
> RaceConditionTest is flaky
> --
>
> Key: ZOOKEEPER-2683
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2683
> Project: ZooKeeper
> Issue Type: Bug
>Reporter: Mohammad Arshad
>Assignee: Mohammad Arshad
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2683-01.patch
>
>
> *Error Message*
> {noformat}
> Leader failed to transition to LOOKING or FOLLOWING state
> {noformat}
> *Stacktrace*
> {noformat}
> junit.framework.AssertionFailedError: Leader failed to transition to LOOKING
> or FOLLOWING state
> at
> org.apache.zookeeper.server.quorum.RaceConditionTest.testRaceConditionBetweenLeaderAndAckRequestProcessor(RaceConditionTest.java:74)
> at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> [CI Failures
> Reference|https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/279//testReport/org.apache.zookeeper.server.quorum/RaceConditionTest/testRaceConditionBetweenLeaderAndAckRequestProcessor/]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Success: ZOOKEEPER-2683 PreCommit Build #3575
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2683 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3575/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 485050 lines...] [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3575//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3575//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3575//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 440b7890071845f5551917123a869260c417ecc8 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' are the same file BUILD SUCCESSFUL Total time: 19 minutes 14 seconds Archiving artifacts Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Recording test results Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 [description-setter] Description set: ZOOKEEPER-2683 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Email was triggered for: Success Sending email for trigger: Success Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Created] (ZOOKEEPER-2685) How to implement SSL in zookeeper-3.4.5-3
shamim khan created ZOOKEEPER-2685: -- Summary: How to implement SSL in zookeeper-3.4.5-3 Key: ZOOKEEPER-2685 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2685 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.4.5 Reporter: shamim khan want to implement SSL in zookeeeper. But not able to implement as version issue. So how can we implement in zookeeper-3.4.5-3. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
ZooKeeper-trunk-solaris - Build # 1494 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1494/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 474888 lines...] [junit] 2017-02-07 08:38:24,417 [myid:] - INFO [NIOWorkerThread-1:StatCommand@49] - Stat command output [junit] 2017-02-07 08:38:24,417 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@614] - Closed socket connection for client /127.0.0.1:61683 (no session established for client) [junit] 2017-02-07 08:38:24,417 [myid:] - INFO [main:JMXEnv@228] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2017-02-07 08:38:24,419 [myid:] - INFO [main:JMXEnv@245] - expect:InMemoryDataTree [junit] 2017-02-07 08:38:24,419 [myid:] - INFO [main:JMXEnv@249] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree [junit] 2017-02-07 08:38:24,419 [myid:] - INFO [main:JMXEnv@245] - expect:StandaloneServer_port [junit] 2017-02-07 08:38:24,419 [myid:] - INFO [main:JMXEnv@249] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11222 [junit] 2017-02-07 08:38:24,419 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17908 [junit] 2017-02-07 08:38:24,420 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24 [junit] 2017-02-07 08:38:24,420 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testQuota [junit] 2017-02-07 08:38:24,420 [myid:] - INFO [main:ClientBase@558] - tearDown starting [junit] 2017-02-07 08:38:25,351 [myid:127.0.0.1:11222] - INFO [main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:11222. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-02-07 08:38:25,352 [myid:127.0.0.1:11222] - INFO [main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@948] - Socket connection established, initiating session, client: null, server: null [junit] 2017-02-07 08:38:25,352 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:61684 [junit] 2017-02-07 08:38:25,354 [myid:] - INFO [NIOWorkerThread-2:ZooKeeperServer@1005] - Client attempting to renew session 0x12694b25a7e at /127.0.0.1:61684 [junit] 2017-02-07 08:38:25,355 [myid:] - INFO [NIOWorkerThread-2:ZooKeeperServer@714] - Established session 0x12694b25a7e with negotiated timeout 3 for client /127.0.0.1:61684 [junit] 2017-02-07 08:38:25,356 [myid:127.0.0.1:11222] - INFO [main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@1381] - Session establishment complete on server null, sessionid = 0x12694b25a7e, negotiated timeout = 3 [junit] 2017-02-07 08:38:25,357 [myid:] - INFO [ProcessThread(sid:0 cport:11222)::PrepRequestProcessor@617] - Processed session termination for sessionid: 0x12694b25a7e [junit] 2017-02-07 08:38:25,357 [myid:] - INFO [SyncThread:0:FileTxnLog@204] - Creating new log file: log.c [junit] 2017-02-07 08:38:25,359 [myid:] - INFO [main:ZooKeeper@1324] - Session: 0x12694b25a7e closed [junit] 2017-02-07 08:38:25,360 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x12694b25a7e [junit] 2017-02-07 08:38:25,360 [myid:] - INFO [main:ClientBase@528] - STOPPING server [junit] 2017-02-07 08:38:25,359 [myid:] - INFO [NIOWorkerThread-5:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=Connections,name2=127.0.0.1,name3=0x12694b25a7e] [junit] 2017-02-07 08:38:25,360 [myid:] - INFO [NIOWorkerThread-5:NIOServerCnxn@614] - Closed socket connection for client /127.0.0.1:61684 which had sessionid 0x12694b25a7e [junit] 2017-02-07 08:38:25,360 [myid:] - INFO [ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - ConnnectionExpirerThread interrupted [junit] 2017-02-07 08:38:25,361 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2017-02-07 08:38:25,361 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219] - accept thread exitted run method [junit] 2017-02-07 08:38:25,361 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2017-02-07 08:38:25,362 [myid:] - INFO [main:ZooKeeperServer@534] - shutting down [junit] 2017-02-07 08:38:25,362 [myid:] - ERROR [main:ZooKeeperServer@506] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or
