date:20171109

ZooKeeper_branch34_jdk7 - Build # 1719 - Failure

2017-11-09 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/1719/

###
## LAST 60 LINES OF THE CONSOLE 
###
Started by timer
ERROR: Issue with creating launcher for agent H9. The agent is being 
disconnected
[EnvInject] - Loading node environment variables.
ERROR: SEVERE ERROR occurs
org.jenkinsci.lib.envinject.EnvInjectException: 
hudson.remoting.ChannelClosedException: channel is already closed
at 
org.jenkinsci.plugins.envinject.service.EnvironmentVariablesNodeLoader.gatherEnvVarsForNode(EnvironmentVariablesNodeLoader.java:95)
at 
org.jenkinsci.plugins.envinject.EnvInjectListener.loadEnvironmentVariablesNode(EnvInjectListener.java:80)
at 
org.jenkinsci.plugins.envinject.EnvInjectListener.setUpEnvironment(EnvInjectListener.java:44)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.createLauncher(AbstractBuild.java:534)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:454)
at hudson.model.Run.execute(Run.java:1737)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:419)
Caused by: hudson.remoting.ChannelClosedException: channel is already closed
at hudson.remoting.Channel.send(Channel.java:613)
at hudson.remoting.Request.call(Request.java:130)
at hudson.remoting.Channel.call(Channel.java:838)
at hudson.FilePath.act(FilePath.java:1082)
at 
org.jenkinsci.plugins.envinject.service.EnvironmentVariablesNodeLoader.gatherEnvVarsForNode(EnvironmentVariablesNodeLoader.java:64)
... 8 more
Caused by: java.io.IOException
at hudson.remoting.Channel.close(Channel.java:1301)
at hudson.slaves.ChannelPinger$1.onDead(ChannelPinger.java:180)
at hudson.remoting.PingThread.ping(PingThread.java:130)
at hudson.remoting.PingThread.run(PingThread.java:86)
Caused by: java.util.concurrent.TimeoutException: Ping started at 1510269865744 
hasn't completed by 1510270105745
... 2 more
ERROR: Step ?Publish JUnit test result report? failed: no workspace for 
ZooKeeper_branch34_jdk7 #1719
[EnvInject] - [ERROR] - SEVERE ERROR occurs: channel is already closed
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2935) [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk

2017-11-09 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246881#comment-16246881
 ] 

Hadoop QA commented on ZOOKEEPER-2935:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 57 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1187//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1187//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1187//console

This message is automatically generated.

> [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk
> 
>
> Key: ZOOKEEPER-2935
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2935
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: quorum, security
>Reporter: Abraham Fine
>Assignee: Abraham Fine
> Fix For: 3.5.4, 3.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Success: ZOOKEEPER- PreCommit Build #1187

2017-11-09 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1187/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 75.51 MB...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 57 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1187//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1187//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1187//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 7038abb38355693fea4ebe94c252a0c4e247f63f logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 18 minutes 10 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2935
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2935) [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk

2017-11-09 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246865#comment-16246865
 ] 

Hadoop QA commented on ZOOKEEPER-2935:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 57 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1186//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1186//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1186//console

This message is automatically generated.

> [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk
> 
>
> Key: ZOOKEEPER-2935
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2935
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: quorum, security
>Reporter: Abraham Fine
>Assignee: Abraham Fine
> Fix For: 3.5.4, 3.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Success: ZOOKEEPER- PreCommit Build #1186

2017-11-09 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1186/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 66.60 MB...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 57 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1186//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1186//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1186//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 087af984d02b843ff6375a9e3c0857bd67bddbf3 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 17 minutes 12 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2935
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

Success: ZOOKEEPER- PreCommit Build #1185

2017-11-09 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1185/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 71.97 MB...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +0 tests included.  The patch appears to be a documentation 
patch that doesn't require tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1185//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1185//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1185//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 5e506a12ad44e40244b782534697f3cd984ef042 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 17 minutes 12 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2934
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2934) c versions of election and queue recipes do not compile

2017-11-09 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246830#comment-16246830
 ] 

Hadoop QA commented on ZOOKEEPER-2934:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1185//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1185//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1185//console

This message is automatically generated.

> c versions of election and queue recipes do not compile
> ---
>
> Key: ZOOKEEPER-2934
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2934
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: recipes
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Abraham Fine
>Assignee: Andor Molnar
>
> I see errors like: 
> {code}
> /var/zookeeper/src/recipes/queue/src/c/../../../../../src/c/include/zookeeper_log.h:39:74:
>  error: expected expression before ')' token
>  log_message(_cb, ZOO_LOG_LEVEL_DEBUG, __LINE__, __func__, __VA_ARGS__)
>   ^
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2935) [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk

2017-11-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246732#comment-16246732
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2935:
---

GitHub user afine opened a pull request:

https://github.com/apache/zookeeper/pull/417

ZOOKEEPER-2935: [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from 
branch-3.5 to trunk



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2935

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/417.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #417


commit f211a512566b43375d76443392157b231e6ba9a1
Author: Abraham Fine 
Date:   2017-11-06T22:48:36Z

init




> [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk
> 
>
> Key: ZOOKEEPER-2935
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2935
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: quorum, security
>Reporter: Abraham Fine
>Assignee: Abraham Fine
> Fix For: 3.5.4, 3.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #417: ZOOKEEPER-2935: [QP MutualAuth]: Port ZOOKEEPER...

2017-11-09 Thread afine

GitHub user afine opened a pull request:

https://github.com/apache/zookeeper/pull/417

ZOOKEEPER-2935: [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from 
branch-3.5 to trunk



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2935

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/417.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #417


commit f211a512566b43375d76443392157b231e6ba9a1
Author: Abraham Fine 
Date:   2017-11-06T22:48:36Z

init




---

Update on 3.4.11 release activities - blocked

2017-11-09 Thread Patrick Hunt

Hi folks, just an FYI that i've nearly completed the release mechanics for
publishing 3.4.11, however I'm currently blocked on an INFRA issue (afaict):
https://issues.apache.org/jira/browse/INFRA-15474

If anyone has seen this issue please let me know. Otw I'm expecting INFRA
to clear it and we should be ok to finalize the remaining steps.

Patrick

[jira] [Commented] (ZOOKEEPER-2934) c versions of election and queue recipes do not compile

2017-11-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246664#comment-16246664
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2934:
---

GitHub user anmolnar opened a pull request:

https://github.com/apache/zookeeper/pull/416

ZOOKEEPER-2934: Updated usage of LOG_DEBUG in recipes to follow changes in 
ZK client

LOG_DEBUG macro has been changed recently in 
https://issues.apache.org/jira/browse/ZOOKEEPER-1400

This patch updates 'lock' and 'queue' recipes to follow the changes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-2934

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/416.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #416


commit 86dc7190aeda82ffb3cf32aaa45426294ab7395b
Author: Andor Molnár 
Date:   2017-11-07T12:09:02Z

ZOOKEEPER-2934: Updated usage of LOG_DEBUG in recipes to follow changes in 
ZK client




> c versions of election and queue recipes do not compile
> ---
>
> Key: ZOOKEEPER-2934
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2934
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: recipes
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Abraham Fine
>Assignee: Andor Molnar
>
> I see errors like: 
> {code}
> /var/zookeeper/src/recipes/queue/src/c/../../../../../src/c/include/zookeeper_log.h:39:74:
>  error: expected expression before ')' token
>  log_message(_cb, ZOO_LOG_LEVEL_DEBUG, __LINE__, __func__, __VA_ARGS__)
>   ^
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #416: ZOOKEEPER-2934: Updated usage of LOG_DEBUG in r...

2017-11-09 Thread anmolnar

GitHub user anmolnar opened a pull request:

https://github.com/apache/zookeeper/pull/416

ZOOKEEPER-2934: Updated usage of LOG_DEBUG in recipes to follow changes in 
ZK client

LOG_DEBUG macro has been changed recently in 
https://issues.apache.org/jira/browse/ZOOKEEPER-1400

This patch updates 'lock' and 'queue' recipes to follow the changes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-2934

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/416.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #416


commit 86dc7190aeda82ffb3cf32aaa45426294ab7395b
Author: Andor MolnÃ¡r 
Date:   2017-11-07T12:09:02Z

ZOOKEEPER-2934: Updated usage of LOG_DEBUG in recipes to follow changes in 
ZK client




---

[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

2017-11-09 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246471#comment-16246471
 ] 

Hadoop QA commented on ZOOKEEPER-2939:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 4 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1184//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1184//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1184//console

This message is automatically generated.

> Deal with maxbuffer as it relates to proposals
> --
>
> Key: ZOOKEEPER-2939
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
> Fix For: 3.5.4, 3.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Success: ZOOKEEPER- PreCommit Build #1184

2017-11-09 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1184/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 72.37 MB...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 4 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1184//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1184//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1184//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] ed2d282ee6106bb091888c119ebaccae21236731 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 21 minutes 13 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2939
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

ZooKeeper-trunk-openjdk7 - Build # 1693 - Still Failing

2017-11-09 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1693/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 65.90 MB...]
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-11-09 20:02:12,592 [myid:127.0.0.1:27509] - INFO  
[main-SendThread(127.0.0.1:27509):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:27509. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-11-09 20:02:12,592 [myid:127.0.0.1:27509] - WARN  
[main-SendThread(127.0.0.1:27509):ClientCnxn$SendThread@1235] - Session 
0x3055eb9b328 for server 127.0.0.1/127.0.0.1:27509, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-11-09 20:02:12,642 [myid:] - INFO  [ProcessThread(sid:0 
cport:27626)::PrepRequestProcessor@614] - Processed session termination for 
sessionid: 0x1055ebce2f6
[junit] 2017-11-09 20:02:12,646 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port27626,name1=Connections,name2=127.0.0.1,name3=0x1055ebce2f6]
[junit] 2017-11-09 20:02:12,646 [myid:] - INFO  [main:ZooKeeper@1332] - 
Session: 0x1055ebce2f6 closed
[junit] 2017-11-09 20:02:12,646 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 110433
[junit] 2017-11-09 20:02:12,646 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 472
[junit] 2017-11-09 20:02:12,646 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2017-11-09 20:02:12,646 [myid:] - INFO  [main:ClientBase@601] - 
tearDown starting
[junit] 2017-11-09 20:02:12,646 [myid:] - INFO  [main:ClientBase@571] - 
STOPPING server
[junit] 2017-11-09 20:02:12,646 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:27626
[junit] 2017-11-09 20:02:12,647 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1055ebce2f6
[junit] 2017-11-09 20:02:12,649 [myid:] - INFO  [main:ZooKeeperServer@545] 
- shutting down
[junit] 2017-11-09 20:02:12,649 [myid:] - ERROR [main:ZooKeeperServer@509] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-11-09 20:02:12,649 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-11-09 20:02:12,654 [myid:] - INFO  
[main:PrepRequestProcessor@1010] - Shutting down
[junit] 2017-11-09 20:02:12,654 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-11-09 20:02:12,654 [myid:] - INFO  [ProcessThread(sid:0 
cport:27626)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop!
[junit] 2017-11-09 20:02:12,654 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-11-09 20:02:12,654 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-11-09 20:02:12,654 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port27626,name1=InMemoryDataTree]
[junit] 2017-11-09 20:02:12,654 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port27626]
[junit] 2017-11-09 20:02:12,654 [myid:] - INFO  
[main:FourLetterWordMain@87] - connecting to 127.0.0.1 27626
[junit] 2017-11-09 20:02:12,655 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2017-11-09 20:02:12,658 [myid:] - INFO  [main:ClientBase@626] - 
fdcount after test is: 1400 at start it was 1400
[junit] 2017-11-09 20:02:12,658 [myid:] - INFO  [main:ZKTestCase$1@68] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2017-11-09 20:02:12,658 [myid:] - INFO  [main:ZKTestCase$1@63] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 105, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
396.525 sec, Thread: 7, Class:

[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

2017-11-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246342#comment-16246342
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2939:
---

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/415
  
@afine Take a look at please the latest commit, I've added verification of 
the byte array itself to serializeRequest() unit test. I'm not 100% sure it's 
needed, but it might makes sense this way.


> Deal with maxbuffer as it relates to proposals
> --
>
> Key: ZOOKEEPER-2939
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
> Fix For: 3.5.4, 3.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper issue #415: ZOOKEEPER-2939: Added last/min/max proposal size JMX b...

2017-11-09 Thread anmolnar

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/415
  
@afine Take a look at please the latest commit, I've added verification of 
the byte array itself to serializeRequest() unit test. I'm not 100% sure it's 
needed, but it might makes sense this way.


---

[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

2017-11-09 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245680#comment-16245680
 ] 

Hadoop QA commented on ZOOKEEPER-2939:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 4 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1183//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1183//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1183//console

This message is automatically generated.

> Deal with maxbuffer as it relates to proposals
> --
>
> Key: ZOOKEEPER-2939
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
> Fix For: 3.5.4, 3.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Success: ZOOKEEPER- PreCommit Build #1183

2017-11-09 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1183/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 69.05 MB...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 4 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1183//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1183//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1183//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] f532d9e0a3f2844d3a09a14828bdbad2e2d78a43 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD SUCCESSFUL
Total time: 17 minutes 44 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2939
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

Success: ZOOKEEPER- PreCommit Build #1181

2017-11-09 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1181/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 71.69 MB...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 4 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1181//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1181//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1181//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 81c7e4906fba3e12b2858f0cef4dc29ab8b947c0 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 18 minutes 14 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2939
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

2017-11-09 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245670#comment-16245670
 ] 

Hadoop QA commented on ZOOKEEPER-2939:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 4 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1181//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1181//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1181//console

This message is automatically generated.

> Deal with maxbuffer as it relates to proposals
> --
>
> Key: ZOOKEEPER-2939
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
> Fix For: 3.5.4, 3.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

2017-11-09 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245660#comment-16245660
 ] 

Hadoop QA commented on ZOOKEEPER-2939:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 4 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1179//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1179//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1179//console

This message is automatically generated.

> Deal with maxbuffer as it relates to proposals
> --
>
> Key: ZOOKEEPER-2939
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
> Fix For: 3.5.4, 3.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Failed: ZOOKEEPER- PreCommit Build #1179

2017-11-09 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1179/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 68.71 MB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1179//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1179//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1179//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] a9165d1e6a07c956be9fb874149fdbb65db4bb36 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1713:
 exec returned: 1

Total time: 20 minutes 40 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[Fast Archiver] Compressed 578.06 KB of artifacts by 44.3% relative to #1177
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2939
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
3 tests failed.
FAILED:  org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalObserverRun

Error Message:
Timeout occurred. Please note the time in the report does not reflect the time 
until the timeout.

Stack Trace:
junit.framework.AssertionFailedError: Timeout occurred. Please note the time in 
the report does not reflect the time until the timeout.
at java.lang.Thread.run(Thread.java:745)


FAILED:  org.apache.zookeeper.test.QuorumTest.testNoLogBeforeLeaderEstablishment

Error Message:
Not following

Stack Trace:
junit.framework.AssertionFailedError: Not following
at 
org.apache.zookeeper.test.QuorumTest.testNoLogBeforeLeaderEstablishment(QuorumTest.java:411)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)


FAILED:  
org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged

Error Message:
expected: but was:

Stack Trace:
junit.framework.AssertionFailedError: expected: but 
was:
at 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest$EventsWatcher.assertEvent(WatchEventWhenAutoResetTest.java:67)
at 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged(WatchEventWhenAutoResetTest.java:126)
at

[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

2017-11-09 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245651#comment-16245651
 ] 

Hadoop QA commented on ZOOKEEPER-2939:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 4 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1180//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1180//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1180//console

This message is automatically generated.

> Deal with maxbuffer as it relates to proposals
> --
>
> Key: ZOOKEEPER-2939
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
> Fix For: 3.5.4, 3.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Failed: ZOOKEEPER- PreCommit Build #1180

2017-11-09 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1180/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 67.61 MB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1180//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1180//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1180//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] e61f529d9914015e846e4c03baee4ef9cc092dd7 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1713:
 exec returned: 1

Total time: 12 minutes 48 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[Fast Archiver] Compressed 578.02 KB of artifacts by 44.3% relative to #1177
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2939
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
28 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig

Error Message:
waiting for server 0 being up

Stack Trace:
junit.framework.AssertionFailedError: waiting for server 0 being up
at 
org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig(ReconfigRecoveryTest.java:224)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)


FAILED:  org.apache.zookeeper.test.ReconfigTest.testPortChange

Error Message:
Couldn't instantiate org.apache.zookeeper.ClientCnxnSocketNetty

Stack Trace:
java.io.IOException: Couldn't instantiate 
org.apache.zookeeper.ClientCnxnSocketNetty
at 
org.apache.zookeeper.ZooKeeper.getClientCnxnSocket(ZooKeeper.java:2936)
at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:879)
at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:799)
at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:939)
at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:686)
at 
org.apache.zookeeper.test.ReconfigTest.createHandles(ReconfigTest.java:212)
at 
org.apache.zookeeper.test.ReconfigTest.testPortChange(ReconfigTest.java:592)
at

[jira] [Commented] (ZOOKEEPER-2933) Ability to monitor the jute.maxBuffer usage in real-time

2017-11-09 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245648#comment-16245648
 ] 

Hadoop QA commented on ZOOKEEPER-2933:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 4 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

-1 contrib tests.  The patch failed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1178//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1178//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1178//console

This message is automatically generated.

> Ability to monitor the jute.maxBuffer usage in real-time
> 
>
> Key: ZOOKEEPER-2933
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2933
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>  Labels: buffer, buffer-length
> Fix For: 3.5.4, 3.6.0
>
>
> This is related to jute.maxbuffer problems on the server side when Leader 
> generates a proposal that doesn't fit into Follower's Jute buffer causing the 
> quorum to be broken.
> Proposed solution is to add the following new JMX Beans:
> 1. Add getJuteMaxBuffer to ZookeeperServerBean which monitors the current 
> jute.maxbuffer setting,
> 2. Add get last/min/max ProposalSize to LeaderBean which monitors the size of 
> the latest/min/max proposal.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

2017-11-09 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245649#comment-16245649
 ] 

Hadoop QA commented on ZOOKEEPER-2939:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 4 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1182//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1182//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1182//console

This message is automatically generated.

> Deal with maxbuffer as it relates to proposals
> --
>
> Key: ZOOKEEPER-2939
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
> Fix For: 3.5.4, 3.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Failed: ZOOKEEPER- PreCommit Build #1182

2017-11-09 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1182/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 34.31 KB...]
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1182//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1182//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1182//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 7e03b2fc728fcd8e604b5dbb0e9949afc7abed23 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess’
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1713:
 exec returned: 1

Total time: 2 minutes 54 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[Fast Archiver] Compressed 581.61 KB of artifacts by 22.0% relative to #1177
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2939
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

Failed: ZOOKEEPER- PreCommit Build #1178

2017-11-09 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1178/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 71.07 MB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] -1 contrib tests.  The patch failed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1178//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1178//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1178//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 87d00d810334947e8cad391307fede76eb7c084c logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1713:
 exec returned: 2

Total time: 13 minutes 2 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[Fast Archiver] Compressed 578.05 KB of artifacts by 44.3% relative to #1177
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2939
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2933) Ability to monitor the jute.maxBuffer usage in real-time

2017-11-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245626#comment-16245626
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2933:
---

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/415
  
@afine I've created 2 subtasks for the Jira as you suggested and changed 
this PR to refer to the right one.


> Ability to monitor the jute.maxBuffer usage in real-time
> 
>
> Key: ZOOKEEPER-2933
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2933
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>  Labels: buffer, buffer-length
> Fix For: 3.5.4, 3.6.0
>
>
> This is related to jute.maxbuffer problems on the server side when Leader 
> generates a proposal that doesn't fit into Follower's Jute buffer causing the 
> quorum to be broken.
> Proposed solution is to add the following new JMX Beans:
> 1. Add getJuteMaxBuffer to ZookeeperServerBean which monitors the current 
> jute.maxbuffer setting,
> 2. Add get last/min/max ProposalSize to LeaderBean which monitors the size of 
> the latest/min/max proposal.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper issue #415: ZOOKEEPER-2933: Added last/min/max proposal size JMX b...

2017-11-09 Thread anmolnar

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/415
  
@afine I've created 2 subtasks for the Jira as you suggested and changed 
this PR to refer to the right one.


---

[jira] [Commented] (ZOOKEEPER-2933) Ability to monitor the jute.maxBuffer usage in real-time

2017-11-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245566#comment-16245566
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2933:
---

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/415#discussion_r149948702
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/util/SerializeUtilsTest.java ---
@@ -0,0 +1,73 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server.util;
+
+import org.apache.jute.OutputArchive;
+import org.apache.jute.Record;
+import org.apache.zookeeper.server.Request;
+import org.apache.zookeeper.txn.TxnHeader;
+import org.junit.Test;
+import org.mockito.InOrder;
+
+import java.io.IOException;
+
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+import static org.mockito.Matchers.any;
+import static org.mockito.Matchers.eq;
+import static org.mockito.Mockito.inOrder;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
+
+public class SerializeUtilsTest {
+
+@Test
+public void testSerializeRequest_RequestIsNull() {
+byte[] data = SerializeUtils.serializeRequest(null);
+assertNull(data);
+}
+
+@Test
+public void testSerializeRequest_RequestHeaderIsNull() {
+Request request = new Request(0, 0, 0, null, null, 0);
+byte[] data = SerializeUtils.serializeRequest(request);
+assertNull(data);
+}
+
+@Test
+public void testSerializeRequest_WithoutTxn() throws IOException {
+TxnHeader header = mock(TxnHeader.class);
+Request request = new Request(1, 2, 3, header, null, 4);
+byte[] data = SerializeUtils.serializeRequest(request);
+assertNotNull(data);
+verify(header).serialize(any(OutputArchive.class), eq("hdr"));
+}
+
+@Test
+public void testSerializeRequest_WithTxn() throws IOException {
+Record txn = mock(Record.class);
+TxnHeader header = mock(TxnHeader.class);
+Request request = new Request(1, 2, 3, header, txn, 4);
+byte[] data = SerializeUtils.serializeRequest(request);
+assertNotNull(data);
+InOrder inOrder = inOrder(header, txn);
--- End diff --

Very good question, I'd been thinking about it for a while. The reason why 
I eventually left it out is that this unit test verifies the behaviour of 
serializeRequest() method and _not_ the serialization itself. So basically we 
have to verify that the right serialize() methods get called in the right order 
instead of what they actually do. 

On the other hand, you're right, because if we mock the serialize() 
methods, they won't have sideeffect on our test.

What do you think?



> Ability to monitor the jute.maxBuffer usage in real-time
> 
>
> Key: ZOOKEEPER-2933
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2933
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>  Labels: buffer, buffer-length
> Fix For: 3.5.4, 3.6.0
>
>
> This is related to jute.maxbuffer problems on the server side when Leader 
> generates a proposal that doesn't fit into Follower's Jute buffer causing the 
> quorum to be broken.
> Proposed solution is to add the following new JMX Beans:
> 1. Add getJuteMaxBuffer to ZookeeperServerBean which monitors the current 
> jute.maxbuffer setting,
> 2. Add get last/min/max ProposalSize to LeaderBean which monitors the size of 
> the latest/min/max proposal.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #415: ZOOKEEPER-2933: Added last/min/max proposal siz...

2017-11-09 Thread anmolnar

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/415#discussion_r149948702
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/util/SerializeUtilsTest.java ---
@@ -0,0 +1,73 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server.util;
+
+import org.apache.jute.OutputArchive;
+import org.apache.jute.Record;
+import org.apache.zookeeper.server.Request;
+import org.apache.zookeeper.txn.TxnHeader;
+import org.junit.Test;
+import org.mockito.InOrder;
+
+import java.io.IOException;
+
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+import static org.mockito.Matchers.any;
+import static org.mockito.Matchers.eq;
+import static org.mockito.Mockito.inOrder;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
+
+public class SerializeUtilsTest {
+
+@Test
+public void testSerializeRequest_RequestIsNull() {
+byte[] data = SerializeUtils.serializeRequest(null);
+assertNull(data);
+}
+
+@Test
+public void testSerializeRequest_RequestHeaderIsNull() {
+Request request = new Request(0, 0, 0, null, null, 0);
+byte[] data = SerializeUtils.serializeRequest(request);
+assertNull(data);
+}
+
+@Test
+public void testSerializeRequest_WithoutTxn() throws IOException {
+TxnHeader header = mock(TxnHeader.class);
+Request request = new Request(1, 2, 3, header, null, 4);
+byte[] data = SerializeUtils.serializeRequest(request);
+assertNotNull(data);
+verify(header).serialize(any(OutputArchive.class), eq("hdr"));
+}
+
+@Test
+public void testSerializeRequest_WithTxn() throws IOException {
+Record txn = mock(Record.class);
+TxnHeader header = mock(TxnHeader.class);
+Request request = new Request(1, 2, 3, header, txn, 4);
+byte[] data = SerializeUtils.serializeRequest(request);
+assertNotNull(data);
+InOrder inOrder = inOrder(header, txn);
--- End diff --

Very good question, I'd been thinking about it for a while. The reason why 
I eventually left it out is that this unit test verifies the behaviour of 
serializeRequest() method and _not_ the serialization itself. So basically we 
have to verify that the right serialize() methods get called in the right order 
instead of what they actually do. 

On the other hand, you're right, because if we mock the serialize() 
methods, they won't have sideeffect on our test.

What do you think?



---

[jira] [Commented] (ZOOKEEPER-2933) Ability to monitor the jute.maxBuffer usage in real-time

2017-11-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245559#comment-16245559
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2933:
---

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/415#discussion_r149947085
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/LeaderStatsTest.java ---
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server.quorum;
+
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+
+public class LeaderStatsTest {
+@Test
+public void testSetProposalSize_SetMinMax() {
+LeaderStats stats = new LeaderStats();
--- End diff --

Good point. I've also added checking the lastProposalSize size value 
besides min/max.


> Ability to monitor the jute.maxBuffer usage in real-time
> 
>
> Key: ZOOKEEPER-2933
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2933
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>  Labels: buffer, buffer-length
> Fix For: 3.5.4, 3.6.0
>
>
> This is related to jute.maxbuffer problems on the server side when Leader 
> generates a proposal that doesn't fit into Follower's Jute buffer causing the 
> quorum to be broken.
> Proposed solution is to add the following new JMX Beans:
> 1. Add getJuteMaxBuffer to ZookeeperServerBean which monitors the current 
> jute.maxbuffer setting,
> 2. Add get last/min/max ProposalSize to LeaderBean which monitors the size of 
> the latest/min/max proposal.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #415: ZOOKEEPER-2933: Added last/min/max proposal siz...

2017-11-09 Thread anmolnar

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/415#discussion_r149947085
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/LeaderStatsTest.java ---
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server.quorum;
+
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+
+public class LeaderStatsTest {
+@Test
+public void testSetProposalSize_SetMinMax() {
+LeaderStats stats = new LeaderStats();
--- End diff --

Good point. I've also added checking the lastProposalSize size value 
besides min/max.


---

[GitHub] zookeeper pull request #415: ZOOKEEPER-2933: Added last/min/max proposal siz...

2017-11-09 Thread anmolnar

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/415#discussion_r149946634
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/LeaderStatsTest.java ---
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server.quorum;
+
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+
+public class LeaderStatsTest {
+@Test
+public void testSetProposalSize_SetMinMax() {
--- End diff --

Removed.


---

[jira] [Commented] (ZOOKEEPER-2933) Ability to monitor the jute.maxBuffer usage in real-time

2017-11-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245551#comment-16245551
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2933:
---

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/415#discussion_r149946634
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/LeaderStatsTest.java ---
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server.quorum;
+
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+
+public class LeaderStatsTest {
+@Test
+public void testSetProposalSize_SetMinMax() {
--- End diff --

Removed.


> Ability to monitor the jute.maxBuffer usage in real-time
> 
>
> Key: ZOOKEEPER-2933
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2933
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>  Labels: buffer, buffer-length
> Fix For: 3.5.4, 3.6.0
>
>
> This is related to jute.maxbuffer problems on the server side when Leader 
> generates a proposal that doesn't fit into Follower's Jute buffer causing the 
> quorum to be broken.
> Proposed solution is to add the following new JMX Beans:
> 1. Add getJuteMaxBuffer to ZookeeperServerBean which monitors the current 
> jute.maxbuffer setting,
> 2. Add get last/min/max ProposalSize to LeaderBean which monitors the size of 
> the latest/min/max proposal.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2933) Ability to monitor the jute.maxBuffer usage in real-time

2017-11-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245549#comment-16245549
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2933:
---

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/415#discussion_r149946468
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/LeaderStats.java 
---
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server.quorum;
+
+/**
+ * Provides live statistics about a running Leader.
+ */
+class LeaderStats {
+/**
+ * Size of the last generated proposal. This should fit into server's 
jute.maxbuffer setting.
+ */
+private int lastProposalSize = 0;
+
+/**
+ * Size of the smallest proposal which has been generated since the 
server was started.
+ */
+private int minProposalSize = -1;
+
+/**
+ * Size of the largest proposal which has been generated since the 
server was started.
+ */
+private int maxProposalSize = 0;
--- End diff --

Done.


> Ability to monitor the jute.maxBuffer usage in real-time
> 
>
> Key: ZOOKEEPER-2933
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2933
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>  Labels: buffer, buffer-length
> Fix For: 3.5.4, 3.6.0
>
>
> This is related to jute.maxbuffer problems on the server side when Leader 
> generates a proposal that doesn't fit into Follower's Jute buffer causing the 
> quorum to be broken.
> Proposed solution is to add the following new JMX Beans:
> 1. Add getJuteMaxBuffer to ZookeeperServerBean which monitors the current 
> jute.maxbuffer setting,
> 2. Add get last/min/max ProposalSize to LeaderBean which monitors the size of 
> the latest/min/max proposal.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2933) Ability to monitor the jute.maxBuffer usage in real-time

2017-11-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245548#comment-16245548
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2933:
---

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/415#discussion_r149946413
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/LeaderStats.java 
---
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server.quorum;
+
+/**
+ * Provides live statistics about a running Leader.
+ */
+class LeaderStats {
--- End diff --

Done.


> Ability to monitor the jute.maxBuffer usage in real-time
> 
>
> Key: ZOOKEEPER-2933
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2933
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>  Labels: buffer, buffer-length
> Fix For: 3.5.4, 3.6.0
>
>
> This is related to jute.maxbuffer problems on the server side when Leader 
> generates a proposal that doesn't fit into Follower's Jute buffer causing the 
> quorum to be broken.
> Proposed solution is to add the following new JMX Beans:
> 1. Add getJuteMaxBuffer to ZookeeperServerBean which monitors the current 
> jute.maxbuffer setting,
> 2. Add get last/min/max ProposalSize to LeaderBean which monitors the size of 
> the latest/min/max proposal.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #415: ZOOKEEPER-2933: Added last/min/max proposal siz...

2017-11-09 Thread anmolnar

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/415#discussion_r149946468
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/LeaderStats.java 
---
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server.quorum;
+
+/**
+ * Provides live statistics about a running Leader.
+ */
+class LeaderStats {
+/**
+ * Size of the last generated proposal. This should fit into server's 
jute.maxbuffer setting.
+ */
+private int lastProposalSize = 0;
+
+/**
+ * Size of the smallest proposal which has been generated since the 
server was started.
+ */
+private int minProposalSize = -1;
+
+/**
+ * Size of the largest proposal which has been generated since the 
server was started.
+ */
+private int maxProposalSize = 0;
--- End diff --

Done.


---

[GitHub] zookeeper pull request #415: ZOOKEEPER-2933: Added last/min/max proposal siz...

2017-11-09 Thread anmolnar

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/415#discussion_r149946413
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/LeaderStats.java 
---
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server.quorum;
+
+/**
+ * Provides live statistics about a running Leader.
+ */
+class LeaderStats {
--- End diff --

Done.


---

[GitHub] zookeeper pull request #415: ZOOKEEPER-2933: Added last/min/max proposal siz...

2017-11-09 Thread anmolnar

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/415#discussion_r149946142
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -984,8 +990,6 @@ public void commitAndActivate(long zxid, long 
designatedLeader) {
 
 /**
  * Create an inform packet and send it to all observers.
- * @param zxid
- * @param proposal
--- End diff --

Intellij keep notifying me about these comments not referring to valid 
parameters in the method definition anymore. I thought it'd be nice to do some 
cleanup together with the patch.


---

[jira] [Commented] (ZOOKEEPER-2933) Ability to monitor the jute.maxBuffer usage in real-time

2017-11-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245546#comment-16245546
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2933:
---

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/415#discussion_r149946142
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -984,8 +990,6 @@ public void commitAndActivate(long zxid, long 
designatedLeader) {
 
 /**
  * Create an inform packet and send it to all observers.
- * @param zxid
- * @param proposal
--- End diff --

Intellij keep notifying me about these comments not referring to valid 
parameters in the method definition anymore. I thought it'd be nice to do some 
cleanup together with the patch.


> Ability to monitor the jute.maxBuffer usage in real-time
> 
>
> Key: ZOOKEEPER-2933
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2933
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>  Labels: buffer, buffer-length
> Fix For: 3.5.4, 3.6.0
>
>
> This is related to jute.maxbuffer problems on the server side when Leader 
> generates a proposal that doesn't fit into Follower's Jute buffer causing the 
> quorum to be broken.
> Proposed solution is to add the following new JMX Beans:
> 1. Add getJuteMaxBuffer to ZookeeperServerBean which monitors the current 
> jute.maxbuffer setting,
> 2. Add get last/min/max ProposalSize to LeaderBean which monitors the size of 
> the latest/min/max proposal.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2933) Ability to monitor the jute.maxBuffer usage in real-time

2017-11-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245545#comment-16245545
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2933:
---

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/415#discussion_r149945916
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -34,12 +33,12 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
+import java.util.concurrent.atomic.AtomicInteger;
--- End diff --

Good catch, thanks.


> Ability to monitor the jute.maxBuffer usage in real-time
> 
>
> Key: ZOOKEEPER-2933
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2933
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>  Labels: buffer, buffer-length
> Fix For: 3.5.4, 3.6.0
>
>
> This is related to jute.maxbuffer problems on the server side when Leader 
> generates a proposal that doesn't fit into Follower's Jute buffer causing the 
> quorum to be broken.
> Proposed solution is to add the following new JMX Beans:
> 1. Add getJuteMaxBuffer to ZookeeperServerBean which monitors the current 
> jute.maxbuffer setting,
> 2. Add get last/min/max ProposalSize to LeaderBean which monitors the size of 
> the latest/min/max proposal.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #415: ZOOKEEPER-2933: Added last/min/max proposal siz...

2017-11-09 Thread anmolnar

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/415#discussion_r149945916
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -34,12 +33,12 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
+import java.util.concurrent.atomic.AtomicInteger;
--- End diff --

Good catch, thanks.


---

[GitHub] zookeeper pull request #415: ZOOKEEPER-2933: Added last/min/max proposal siz...

2017-11-09 Thread anmolnar

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/415#discussion_r149945747
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/ZooKeeperServerBean.java ---
@@ -167,4 +167,9 @@ public String getSecureClientAddress() {
 public long getTxnLogElapsedSyncTime() {
 return zks.getTxnLogElapsedSyncTime();
 }
+
+@Override
+public int getJuteMaxBufferSize() {
+return Integer.getInteger("jute.maxbuffer", 0xf);
--- End diff --

I deal with it in the other way around. Directly access 
BinaryInputArchive.maxBuffer from here.


---

[jira] [Commented] (ZOOKEEPER-2933) Ability to monitor the jute.maxBuffer usage in real-time

2017-11-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245543#comment-16245543
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2933:
---

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/415#discussion_r149945747
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/ZooKeeperServerBean.java ---
@@ -167,4 +167,9 @@ public String getSecureClientAddress() {
 public long getTxnLogElapsedSyncTime() {
 return zks.getTxnLogElapsedSyncTime();
 }
+
+@Override
+public int getJuteMaxBufferSize() {
+return Integer.getInteger("jute.maxbuffer", 0xf);
--- End diff --

I deal with it in the other way around. Directly access 
BinaryInputArchive.maxBuffer from here.


> Ability to monitor the jute.maxBuffer usage in real-time
> 
>
> Key: ZOOKEEPER-2933
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2933
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>  Labels: buffer, buffer-length
> Fix For: 3.5.4, 3.6.0
>
>
> This is related to jute.maxbuffer problems on the server side when Leader 
> generates a proposal that doesn't fit into Follower's Jute buffer causing the 
> quorum to be broken.
> Proposed solution is to add the following new JMX Beans:
> 1. Add getJuteMaxBuffer to ZookeeperServerBean which monitors the current 
> jute.maxbuffer setting,
> 2. Add get last/min/max ProposalSize to LeaderBean which monitors the size of 
> the latest/min/max proposal.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

2017-11-09 Thread Andor Molnar (JIRA)

Andor Molnar created ZOOKEEPER-2939:
---

 Summary: Deal with maxbuffer as it relates to proposals
 Key: ZOOKEEPER-2939
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939
 Project: ZooKeeper
  Issue Type: Sub-task
Reporter: Andor Molnar
Assignee: Andor Molnar






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ZOOKEEPER-2940) Deal with maxbuffer as it relates to large requests from clients

2017-11-09 Thread Andor Molnar (JIRA)

Andor Molnar created ZOOKEEPER-2940:
---

 Summary: Deal with maxbuffer as it relates to large requests from 
clients
 Key: ZOOKEEPER-2940
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2940
 Project: ZooKeeper
  Issue Type: Sub-task
Reporter: Andor Molnar
Assignee: Andor Molnar






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ZooKeeper-trunk-jdk8 - Build # 1269 - Failure

2017-11-09 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1269/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 66.23 MB...]
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-11-09 11:53:56,585 [myid:] - INFO  [ProcessThread(sid:0 
cport:16854)::PrepRequestProcessor@614] - Processed session termination for 
sessionid: 0x107ca854508
[junit] 2017-11-09 11:53:56,586 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16854,name1=Connections,name2=127.0.0.1,name3=0x107ca854508]
[junit] 2017-11-09 11:53:56,586 [myid:] - INFO  [main:ZooKeeper@1332] - 
Session: 0x107ca854508 closed
[junit] 2017-11-09 11:53:56,586 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x107ca854508
[junit] 2017-11-09 11:53:56,587 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 250385
[junit] 2017-11-09 11:53:56,587 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 2431
[junit] 2017-11-09 11:53:56,587 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2017-11-09 11:53:56,587 [myid:] - INFO  [main:ClientBase@601] - 
tearDown starting
[junit] 2017-11-09 11:53:56,587 [myid:] - INFO  [main:ClientBase@571] - 
STOPPING server
[junit] 2017-11-09 11:53:56,587 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:16854
[junit] 2017-11-09 11:53:56,594 [myid:] - INFO  [main:ZooKeeperServer@545] 
- shutting down
[junit] 2017-11-09 11:53:56,594 [myid:] - ERROR [main:ZooKeeperServer@509] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-11-09 11:53:56,594 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-11-09 11:53:56,595 [myid:] - INFO  
[main:PrepRequestProcessor@1010] - Shutting down
[junit] 2017-11-09 11:53:56,595 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-11-09 11:53:56,595 [myid:] - INFO  [ProcessThread(sid:0 
cport:16854)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop!
[junit] 2017-11-09 11:53:56,596 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-11-09 11:53:56,596 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-11-09 11:53:56,596 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16854,name1=InMemoryDataTree]
[junit] 2017-11-09 11:53:56,596 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16854]
[junit] 2017-11-09 11:53:56,597 [myid:] - INFO  
[main:FourLetterWordMain@87] - connecting to 127.0.0.1 16854
[junit] 2017-11-09 11:53:56,597 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2017-11-09 11:53:56,606 [myid:] - INFO  [main:ClientBase@626] - 
fdcount after test is: 7151 at start it was 7151
[junit] 2017-11-09 11:53:56,606 [myid:] - INFO  [main:ZKTestCase$1@68] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2017-11-09 11:53:56,606 [myid:] - INFO  [main:ZKTestCase$1@63] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 105, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
405.577 sec, Thread: 3, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2017-11-09 11:53:56,762 [myid:127.0.0.1:16657] - INFO  
[main-SendThread(127.0.0.1:16657):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:16657. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-11-09 11:53:56,762 [myid:127.0.0.1:16657] - WARN  
[main-SendThread(127.0.0.1:16657):ClientCnxn$SendThread@1235] - Session 
0x107ca7f79d70001 for server 127.0.0.1/127.0.0.1:16657, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-11-09 11:53:56,809 [myid:127.0.0.1:16731] -

ZooKeeper_branch35_jdk7 - Build # 1179 - Failure

2017-11-09 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/1179/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 71.03 MB...]
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-11-09 08:48:44,646 [myid:] - INFO  [ProcessThread(sid:0 
cport:11468)::PrepRequestProcessor@611] - Processed session termination for 
sessionid: 0x107cb2a13ac
[junit] 2017-11-09 08:48:44,648 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port11468,name1=Connections,name2=127.0.0.1,name3=0x107cb2a13ac]
[junit] 2017-11-09 08:48:44,648 [myid:] - INFO  [main:ZooKeeper@1334] - 
Session: 0x107cb2a13ac closed
[junit] 2017-11-09 08:48:44,648 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x107cb2a13ac
[junit] 2017-11-09 08:48:44,648 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 230460
[junit] 2017-11-09 08:48:44,649 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 2433
[junit] 2017-11-09 08:48:44,649 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2017-11-09 08:48:44,649 [myid:] - INFO  [main:ClientBase@586] - 
tearDown starting
[junit] 2017-11-09 08:48:44,649 [myid:] - INFO  [main:ClientBase@556] - 
STOPPING server
[junit] 2017-11-09 08:48:44,649 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:11468
[junit] 2017-11-09 08:48:44,656 [myid:] - INFO  [main:ZooKeeperServer@541] 
- shutting down
[junit] 2017-11-09 08:48:44,656 [myid:] - ERROR [main:ZooKeeperServer@505] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-11-09 08:48:44,656 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-11-09 08:48:44,657 [myid:] - INFO  
[main:PrepRequestProcessor@1005] - Shutting down
[junit] 2017-11-09 08:48:44,657 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-11-09 08:48:44,657 [myid:] - INFO  [ProcessThread(sid:0 
cport:11468)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop!
[junit] 2017-11-09 08:48:44,657 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-11-09 08:48:44,657 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-11-09 08:48:44,658 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port11468,name1=InMemoryDataTree]
[junit] 2017-11-09 08:48:44,658 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port11468]
[junit] 2017-11-09 08:48:44,658 [myid:] - INFO  
[main:FourLetterWordMain@87] - connecting to 127.0.0.1 11468
[junit] 2017-11-09 08:48:44,663 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2017-11-09 08:48:44,674 [myid:127.0.0.1:11348] - INFO  
[main-SendThread(127.0.0.1:11348):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:11348. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-11-09 08:48:44,674 [myid:127.0.0.1:11348] - WARN  
[main-SendThread(127.0.0.1:11348):ClientCnxn$SendThread@1235] - Session 
0x207cb26d27a for server 127.0.0.1/127.0.0.1:11348, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-11-09 08:48:44,676 [myid:] - INFO  [main:ClientBase@611] - 
fdcount after test is: 7161 at start it was 7162
[junit] 2017-11-09 08:48:44,676 [myid:] - INFO  [main:ZKTestCase$1@68] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2017-11-09 08:48:44,677 [myid:] - INFO  [main:ZKTestCase$1@63] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 103, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 
410.339 sec, Thread: 1, Class:

51 matches

Mail list logo