Proposal for reworked ZK web site generation: CMS -> jekyll
Hi folks. After the issues a few weeks ago during the 3.4.11 release trying to get the site published and INFRA no longer supporting CMS I've gone through the effort to look at what other options are available. I reviewed a number of other ASF sites and it looks like jekyll with markdown is very popular. Additionally INFRA is currently supporting gitpubsub - which means that if we can generate a static site and commit the results to git INFRA will take that and update the live production site. Basic workflow would then be: 1) manually edit the markdown pages which are the source of the website (similar to what we do today) 2) generate the static website using jekyll, review this as the "staged" site (locally) 3) once we're happy with it commit/push the changes to the markdown source 4) commit/push the changes to the generated/static site content - gitpubsub will then push those live to zookeeper.apache.org. This is pretty close to what we are doing today as part of a release but it's streamlined and takes CMS out of the equation (the old content management which is no longer supported by INFRA). I've converted the current website over to this new model and staged the change in my personal github repo. Please take a look as I'd like to move over to this new model soon - let's say about a week from today for feedback. Any committers out there please give this a +1 if you're on board - otw let me know your concerns. This would be the source of the website, markdown/jekyll based: https://github.com/phunt/zookeeper/tree/website This is the generated site (html) - pushing this branch would cause asf INFRA to re-publish the site (gitpubsub): https://github.com/phunt/zookeeper/tree/asf-site Notice these are orphan branches (no history aside from the recent docs changes) and both of these branches would live within the existing/current zookeeper git repo. So if you clone the zookeeper repo you'll have the website as well - no longer necessary to checkout multiple repos in order to update the website. Patrick
Success: ZOOKEEPER- PreCommit Build #1323
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1323/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 73.93 MB...] [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 34 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1323//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1323//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1323//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 9cc91f7e6bc6f017fc7b8955fed2099172abea57 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD SUCCESSFUL Total time: 18 minutes 21 seconds Archiving artifacts Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Recording test results Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 [description-setter] Description set: ZOOKEEPER-2924 Putting comment on the pull request Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Email was triggered for: Success Sending email for trigger: Success Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272252#comment-16272252 ] Hadoop QA commented on ZOOKEEPER-2924: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 34 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1323//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1323//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1323//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[GitHub] zookeeper issue #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTest.java
Github user afine commented on the issue: https://github.com/apache/zookeeper/pull/420 @phunt I think it's fine to always modify the `snapCount`. My concern was primarily modifying it once the zookeeper server was running created nondeterministic behavior. In addition, I don't think most of these tests make any assertions that could be impacted by the `snapCount`. So I think the current iteration of the tests is fine. Also, +1 on removing the lines instead of commenting them out and using a smaller snapCount. Otherwise lgtm. ---
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272186#comment-16272186 ] ASF GitHub Bot commented on ZOOKEEPER-2924: --- Github user afine commented on the issue: https://github.com/apache/zookeeper/pull/420 @phunt I think it's fine to always modify the `snapCount`. My concern was primarily modifying it once the zookeeper server was running created nondeterministic behavior. In addition, I don't think most of these tests make any assertions that could be impacted by the `snapCount`. So I think the current iteration of the tests is fine. Also, +1 on removing the lines instead of commenting them out and using a smaller snapCount. Otherwise lgtm. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@376] - Unable to > read additional data from client sessionid 0x104cd7b190c, likely client > has closed socket > [junit] 2017-10-12 15:05:33,067 [myid:] - INFO > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1040] - Closed > socket connection for client /127.0.0.1:45735 which had sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 >
ZooKeeper_branch34_jdk8 - Build # 1213 - Failure
See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/1213/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 31.55 MB...] [junit] 2017-11-29 23:10:02,211 [myid:] - INFO [main:ZooKeeperServer@501] - shutting down [junit] 2017-11-29 23:10:02,211 [myid:] - INFO [main:SessionTrackerImpl@226] - Shutting down [junit] 2017-11-29 23:10:02,211 [myid:] - INFO [main:PrepRequestProcessor@769] - Shutting down [junit] 2017-11-29 23:10:02,211 [myid:] - INFO [main:SyncRequestProcessor@208] - Shutting down [junit] 2017-11-29 23:10:02,211 [myid:] - INFO [ProcessThread(sid:0 cport:11221)::PrepRequestProcessor@144] - PrepRequestProcessor exited loop! [junit] 2017-11-29 23:10:02,211 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@186] - SyncRequestProcessor exited! [junit] 2017-11-29 23:10:02,212 [myid:] - INFO [main:FinalRequestProcessor@403] - shutdown of request processor complete [junit] 2017-11-29 23:10:02,212 [myid:] - INFO [main:FourLetterWordMain@65] - connecting to 127.0.0.1 11221 [junit] 2017-11-29 23:10:02,213 [myid:] - INFO [main:JMXEnv@147] - ensureOnly:[] [junit] 2017-11-29 23:10:02,214 [myid:] - INFO [main:ClientBase@489] - STARTING server [junit] 2017-11-29 23:10:02,215 [myid:] - INFO [main:ClientBase@410] - CREATING server instance 127.0.0.1:11221 [junit] 2017-11-29 23:10:02,215 [myid:] - INFO [main:ServerCnxnFactory@117] - Using org.apache.zookeeper.server.NIOServerCnxnFactory as server connection factory [junit] 2017-11-29 23:10:02,215 [myid:] - INFO [main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2017-11-29 23:10:02,216 [myid:] - INFO [main:ClientBase@385] - STARTING server instance 127.0.0.1:11221 [junit] 2017-11-29 23:10:02,216 [myid:] - INFO [main:ZooKeeperServer@173] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build/test/tmp/test4516033308566521543.junit.dir/version-2 snapdir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build/test/tmp/test4516033308566521543.junit.dir/version-2 [junit] 2017-11-29 23:10:02,219 [myid:] - INFO [main:FourLetterWordMain@65] - connecting to 127.0.0.1 11221 [junit] 2017-11-29 23:10:02,220 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@215] - Accepted socket connection from /127.0.0.1:54103 [junit] 2017-11-29 23:10:02,220 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@892] - Processing stat command from /127.0.0.1:54103 [junit] 2017-11-29 23:10:02,221 [myid:] - INFO [Thread-4:NIOServerCnxn$StatCommand@683] - Stat command output [junit] 2017-11-29 23:10:02,221 [myid:] - INFO [Thread-4:NIOServerCnxn@1040] - Closed socket connection for client /127.0.0.1:54103 (no session established for client) [junit] 2017-11-29 23:10:02,221 [myid:] - INFO [main:JMXEnv@230] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2017-11-29 23:10:02,223 [myid:] - INFO [main:JMXEnv@247] - expect:InMemoryDataTree [junit] 2017-11-29 23:10:02,223 [myid:] - INFO [main:JMXEnv@251] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree [junit] 2017-11-29 23:10:02,224 [myid:] - INFO [main:JMXEnv@247] - expect:StandaloneServer_port [junit] 2017-11-29 23:10:02,224 [myid:] - INFO [main:JMXEnv@251] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11221 [junit] 2017-11-29 23:10:02,224 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 31627 [junit] 2017-11-29 23:10:02,225 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20 [junit] 2017-11-29 23:10:02,225 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota [junit] 2017-11-29 23:10:02,225 [myid:] - INFO [main:ClientBase@566] - tearDown starting [junit] 2017-11-29 23:10:02,296 [myid:] - INFO [main:ZooKeeper@687] - Session: 0x10061bf7d8b closed [junit] 2017-11-29 23:10:02,296 [myid:] - INFO [main:ClientBase@536] - STOPPING server [junit] 2017-11-29 23:10:02,296 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@520] - EventThread shut down for session: 0x10061bf7d8b [junit] 2017-11-29 23:10:02,296 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@242] - NIOServerCnxn factory exited run method [junit] 2017-11-29 23:10:02,297 [myid:] - INFO [main:ZooKeeperServer@501] - shutting down [junit] 2017-11-29 23:10:02,297 [myid:] - INFO [main:SessionTrackerImpl@226] - Shutting down [junit] 2017-11-29 23:10:02,297 [myid:] - INFO
[GitHub] zookeeper issue #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTest.java
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/420 I thought @afine 's comment was that only the two tests that actually need the snapcount to be set should have it set. The other two tests should not have it set. Am I mistaken? My concern (remaining) is that we've effectively changed the parameters of the tests if we change these values. I'm assuming the original author verified that the tests failed before submitting the fix (incl tests). However unless we do that ourselves I'd be concerned that the test no longer recreates the environment that originally caused the problem. As such that's why I was suggesting we ensure the original values are used. Unless you both looked at what the tests are doing and are confident? (I didn't look that deep) I do see that num messages is 300. If we do go this route perhaps we should use the smaller of the two original values? (50 iiuc). And please remove the lines themselves (rather than just commenting them out). Thanks! ---
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271592#comment-16271592 ] ASF GitHub Bot commented on ZOOKEEPER-2924: --- Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/420 I thought @afine 's comment was that only the two tests that actually need the snapcount to be set should have it set. The other two tests should not have it set. Am I mistaken? My concern (remaining) is that we've effectively changed the parameters of the tests if we change these values. I'm assuming the original author verified that the tests failed before submitting the fix (incl tests). However unless we do that ourselves I'd be concerned that the test no longer recreates the environment that originally caused the problem. As such that's why I was suggesting we ensure the original values are used. Unless you both looked at what the tests are doing and are confident? (I didn't look that deep) I do see that num messages is 300. If we do go this route perhaps we should use the smaller of the two original values? (50 iiuc). And please remove the lines themselves (rather than just commenting them out). Thanks! > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
ZooKeeper-trunk-openjdk7 - Build # 1715 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1715/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 67.48 MB...] [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-11-29 20:01:40,278 [myid:127.0.0.1:14038] - INFO [main-SendThread(127.0.0.1:14038):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:14038. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-11-29 20:01:40,278 [myid:127.0.0.1:14038] - WARN [main-SendThread(127.0.0.1:14038):ClientCnxn$SendThread@1235] - Session 0x105c5b89648 for server 127.0.0.1/127.0.0.1:14038, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-11-29 20:01:40,473 [myid:] - INFO [ProcessThread(sid:0 cport:14161)::PrepRequestProcessor@614] - Processed session termination for sessionid: 0x105c5bb958c [junit] 2017-11-29 20:01:40,476 [myid:] - INFO [SyncThread:0:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port14161,name1=Connections,name2=127.0.0.1,name3=0x105c5bb958c] [junit] 2017-11-29 20:01:40,477 [myid:] - INFO [main:ZooKeeper@1332] - Session: 0x105c5bb958c closed [junit] 2017-11-29 20:01:40,477 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 2 [junit] 2017-11-29 20:01:40,477 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x105c5bb958c [junit] 2017-11-29 20:01:40,477 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 473 [junit] 2017-11-29 20:01:40,477 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testWatcherAutoResetWithLocal [junit] 2017-11-29 20:01:40,477 [myid:] - INFO [main:ClientBase@601] - tearDown starting [junit] 2017-11-29 20:01:40,477 [myid:] - INFO [main:ClientBase@571] - STOPPING server [junit] 2017-11-29 20:01:40,477 [myid:] - INFO [main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:14161 [junit] 2017-11-29 20:01:40,478 [myid:] - INFO [main:ZooKeeperServer@546] - shutting down [junit] 2017-11-29 20:01:40,478 [myid:] - INFO [main:SessionTrackerImpl@232] - Shutting down [junit] 2017-11-29 20:01:40,478 [myid:] - INFO [main:PrepRequestProcessor@1010] - Shutting down [junit] 2017-11-29 20:01:40,479 [myid:] - INFO [main:SyncRequestProcessor@191] - Shutting down [junit] 2017-11-29 20:01:40,479 [myid:] - INFO [ProcessThread(sid:0 cport:14161)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop! [junit] 2017-11-29 20:01:40,479 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited! [junit] 2017-11-29 20:01:40,479 [myid:] - INFO [main:FinalRequestProcessor@481] - shutdown of request processor complete [junit] 2017-11-29 20:01:40,479 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port14161,name1=InMemoryDataTree] [junit] 2017-11-29 20:01:40,479 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port14161] [junit] 2017-11-29 20:01:40,479 [myid:] - INFO [main:FourLetterWordMain@87] - connecting to 127.0.0.1 14161 [junit] 2017-11-29 20:01:40,480 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2017-11-29 20:01:40,483 [myid:] - INFO [main:ClientBase@626] - fdcount after test is: 1411 at start it was 1411 [junit] 2017-11-29 20:01:40,483 [myid:] - INFO [main:ZKTestCase$1@68] - SUCCEEDED testWatcherAutoResetWithLocal [junit] 2017-11-29 20:01:40,483 [myid:] - INFO [main:ZKTestCase$1@63] - FINISHED testWatcherAutoResetWithLocal [junit] Tests run: 105, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 392.889 sec, Thread: 2, Class: org.apache.zookeeper.test.NioNettySuiteTest [junit] 2017-11-29 20:01:40,569 [myid:127.0.0.1:14044] - INFO [main-SendThread(127.0.0.1:14044):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:14044. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-11-29 20:01:40,570 [myid:127.0.0.1:14044] - WARN [main-SendThread(127.0.0.1:14044):ClientCnxn$SendThread@1235] - Session 0x305c5b8964f for server 127.0.0.1/127.0.0.1:14044,
[GitHub] zookeeper pull request #425: Add keys for the Zxid from the stat command
GitHub user alexbb opened a pull request: https://github.com/apache/zookeeper/pull/425 Add keys for the Zxid from the stat command Add keys for the zxid and its component pieces: epoch and transaction counter. These are not reported by the 'mntr' command so they must be obtained from 'stat'. The counter is useful for tracking transaction rates, and epoch is useful for tracking leader churn. zk_zxid - the 64bit zxid from ZK zk_zxid_counter - the lower 32 bits, AKA the counter zk_zxid_epoch - the upper 32 bits, AKA the epoch You can merge this pull request into a Git repository by running: $ git pull https://github.com/alexbb/zookeeper add_zxid_stats Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/425.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #425 commit 874628db69ea59b7f3856007a9b1fb377ff86a4d Author: Alex BameDate: 2017-11-29T16:59:32Z add keys for the Zxid from the stat command: zk_zxid - the 64bit zxid from ZK zk_zxid_counter - the lower 32 bits, AKA the counter zk_zxid_epoch - the upper 32 bits, AKA the epoch ---
[jira] [Commented] (ZOOKEEPER-2949) SSL ServerName not set when using hostname, some proxies may failed to proxy the request.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271069#comment-16271069 ] ASF GitHub Bot commented on ZOOKEEPER-2949: --- Github user mfenes commented on the issue: https://github.com/apache/zookeeper/pull/423 Could you please provide a description of your change > SSL ServerName not set when using hostname, some proxies may failed to proxy > the request. > - > > Key: ZOOKEEPER-2949 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2949 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.5.3 > Environment: In our environment, the zk clusters are all behind a > proxy, the proxy decide to transfer the request from client based on the > "ServerName" field in SSL Hello packet(the proxy served on SSL only). but the > Hello packets that zk client sended do proxy do not contain the "ServerName" > field in it. after inspect the codes, we have found that it is because that > zk client did not specify the peerHost when initializing the SSLContext. >Reporter: Feng Shaobao > Fix For: 3.6.0 > > Original Estimate: 12h > Remaining Estimate: 12h > > In our environment, the zk clusters are all behind a proxy, the proxy decide > to transfer the request from client based on the "ServerName" field in SSL > Hello packet(the proxy served on SSL only). but the Hello packets that zk > client sended do proxy do not contain the "ServerName" field in it. after > inspect the codes, we have found that it is because that zk client did not > specify the peerHost when initializing the SSLContext. > In the method initSSL of class ZKClientPipelineFactory, it initialize the > SSLEngine like below: > sslEngine = sslContext.createSSLEngine(); > Actually the sslContext provide another factory method that receives the > hostName and port parameter. > public final SSLEngine createSSLEngine(String hostName, int port) > If we call this method to create the SSLEngine, then the proxy will know > which zk cluster it really want to access. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] zookeeper issue #423: ZOOKEEPER-2949: using hostname and port to create SSLE...
Github user mfenes commented on the issue: https://github.com/apache/zookeeper/pull/423 Could you please provide a description of your change ---
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270928#comment-16270928 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 13 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1322//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1322//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1322//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Failed: ZOOKEEPER- PreCommit Build #1322
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1322/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 73.17 MB...] [exec] +1 tests included. The patch appears to include 13 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1322//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1322//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1322//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 08197e6cfae87a355bf33c6808615063e2011865 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: ‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’ and ‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’ are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1722: exec returned: 1 Total time: 17 minutes 5 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Recording test results Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 [description-setter] Description set: ZOOKEEPER-2939 Putting comment on the pull request Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270764#comment-16270764 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 13 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1321//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1321//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1321//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Failed: ZOOKEEPER- PreCommit Build #1321
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1321/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 67.79 MB...] [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1321//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1321//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1321//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 90952faac3c2535a2caed2a65c1a9a3e59f3b6f6 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1722: exec returned: 2 Total time: 19 minutes 40 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 [Fast Archiver] Compressed 596.42 KB of artifacts by 26.8% relative to #1320 Recording test results Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 [description-setter] Description set: ZOOKEEPER-2939 Putting comment on the pull request Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 ### ## FAILED TESTS (if any) ## 1 tests failed. FAILED: org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalObserverRun Error Message: Timeout occurred. Please note the time in the report does not reflect the time until the timeout. Stack Trace: junit.framework.AssertionFailedError: Timeout occurred. Please note the time in the report does not reflect the time until the timeout. at java.lang.Thread.run(Thread.java:745)
Success: ZOOKEEPER- PreCommit Build #1320
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1320/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 75.33 MB...] [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 34 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1320//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1320//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1320//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 52413d4038d928be88646709d3dbaeb7a5e37c0b logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD SUCCESSFUL Total time: 23 minutes 51 seconds Archiving artifacts Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Recording test results Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 [description-setter] Description set: ZOOKEEPER-2924 Putting comment on the pull request Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Email was triggered for: Success Sending email for trigger: Success Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270704#comment-16270704 ] Hadoop QA commented on ZOOKEEPER-2924: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 34 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1320//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1320//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1320//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270681#comment-16270681 ] ASF GitHub Bot commented on ZOOKEEPER-2924: --- Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/420 @phunt @afine thanks for the detail comments. I think @afine made a good point, I've removed setting the SnapCount explicitly in each test, leaving only a common setting in the setUp method. Only those 2 tests really care about the setting and with a little modification, they can share the same setting. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@376] - Unable to > read additional data from client sessionid 0x104cd7b190c, likely client > has closed socket > [junit] 2017-10-12 15:05:33,067 [myid:] - INFO > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1040] - Closed > socket connection for client /127.0.0.1:45735 which had sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@487] - Processed session termination for > sessionid: 0x104cd7b190c > [junit] 2017-10-12 15:05:33,889 [myid:] - INFO [main:ZooKeeper@687] - >
[GitHub] zookeeper issue #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTest.java
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/420 @phunt @afine thanks for the detail comments. I think @afine made a good point, I've removed setting the SnapCount explicitly in each test, leaving only a common setting in the setUp method. Only those 2 tests really care about the setting and with a little modification, they can share the same setting. ---
ZooKeeper_branch35_jdk8 - Build # 761 - Failure
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/761/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 70.34 MB...] [junit] 2017-11-29 12:18:08,843 [myid:] - INFO [main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:16854 [junit] 2017-11-29 12:18:08,849 [myid:] - INFO [main:ZooKeeperServer@541] - shutting down [junit] 2017-11-29 12:18:08,849 [myid:] - INFO [main:SessionTrackerImpl@232] - Shutting down [junit] 2017-11-29 12:18:08,849 [myid:] - INFO [main:PrepRequestProcessor@1005] - Shutting down [junit] 2017-11-29 12:18:08,849 [myid:] - INFO [main:SyncRequestProcessor@191] - Shutting down [junit] 2017-11-29 12:18:08,849 [myid:] - INFO [ProcessThread(sid:0 cport:16854)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop! [junit] 2017-11-29 12:18:08,850 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited! [junit] 2017-11-29 12:18:08,850 [myid:] - INFO [main:FinalRequestProcessor@481] - shutdown of request processor complete [junit] 2017-11-29 12:18:08,850 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16854,name1=InMemoryDataTree] [junit] 2017-11-29 12:18:08,850 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16854] [junit] 2017-11-29 12:18:08,851 [myid:] - INFO [main:FourLetterWordMain@87] - connecting to 127.0.0.1 16854 [junit] 2017-11-29 12:18:08,851 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2017-11-29 12:18:08,861 [myid:] - INFO [main:ClientBase@611] - fdcount after test is: 7171 at start it was 7171 [junit] 2017-11-29 12:18:08,861 [myid:] - INFO [main:ZKTestCase$1@68] - SUCCEEDED testWatcherAutoResetWithLocal [junit] 2017-11-29 12:18:08,861 [myid:] - INFO [main:ZKTestCase$1@63] - FINISHED testWatcherAutoResetWithLocal [junit] Tests run: 103, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 562.669 sec, Thread: 3, Class: org.apache.zookeeper.test.NioNettySuiteTest [junit] 2017-11-29 12:18:08,922 [myid:127.0.0.1:16657] - INFO [main-SendThread(127.0.0.1:16657):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:16657. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-11-29 12:18:08,923 [myid:127.0.0.1:16657] - WARN [main-SendThread(127.0.0.1:16657):ClientCnxn$SendThread@1235] - Session 0x1005f0c4d320001 for server 127.0.0.1/127.0.0.1:16657, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-11-29 12:18:09,063 [myid:127.0.0.1:16608] - INFO [main-SendThread(127.0.0.1:16608):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:16608. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-11-29 12:18:09,063 [myid:127.0.0.1:16608] - WARN [main-SendThread(127.0.0.1:16608):ClientCnxn$SendThread@1235] - Session 0x1005f0b86bc for server 127.0.0.1/127.0.0.1:16608, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-11-29 12:18:09,246 [myid:127.0.0.1:16737] - INFO [main-SendThread(127.0.0.1:16737):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:16737. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-11-29 12:18:09,247 [myid:127.0.0.1:16737] - WARN [main-SendThread(127.0.0.1:16737):ClientCnxn$SendThread@1235] - Session 0x3005f10d1b2 for server 127.0.0.1/127.0.0.1:16737, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at
ZooKeeper_branch35_jdk7 - Build # 1201 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/1201/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 62.97 MB...] [junit] at org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108) [junit] at org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42) [junit] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [junit] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [junit] at java.lang.Thread.run(Thread.java:745) [junit] 2017-11-29 09:14:26,339 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 216536 [junit] 2017-11-29 09:14:26,340 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 2431 [junit] 2017-11-29 09:14:26,340 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testWatcherAutoResetWithLocal [junit] 2017-11-29 09:14:26,340 [myid:] - INFO [main:ClientBase@586] - tearDown starting [junit] 2017-11-29 09:14:26,340 [myid:] - INFO [main:ClientBase@556] - STOPPING server [junit] 2017-11-29 09:14:26,341 [myid:] - INFO [main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:11468 [junit] 2017-11-29 09:14:26,346 [myid:] - INFO [main:ZooKeeperServer@541] - shutting down [junit] 2017-11-29 09:14:26,346 [myid:] - INFO [main:SessionTrackerImpl@232] - Shutting down [junit] 2017-11-29 09:14:26,346 [myid:] - INFO [main:PrepRequestProcessor@1005] - Shutting down [junit] 2017-11-29 09:14:26,347 [myid:] - INFO [main:SyncRequestProcessor@191] - Shutting down [junit] 2017-11-29 09:14:26,347 [myid:] - INFO [ProcessThread(sid:0 cport:11468)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop! [junit] 2017-11-29 09:14:26,347 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited! [junit] 2017-11-29 09:14:26,347 [myid:] - INFO [main:FinalRequestProcessor@481] - shutdown of request processor complete [junit] 2017-11-29 09:14:26,347 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port11468,name1=InMemoryDataTree] [junit] 2017-11-29 09:14:26,348 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port11468] [junit] 2017-11-29 09:14:26,348 [myid:] - INFO [main:FourLetterWordMain@87] - connecting to 127.0.0.1 11468 [junit] 2017-11-29 09:14:26,348 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2017-11-29 09:14:26,357 [myid:] - INFO [main:ClientBase@611] - fdcount after test is: 7169 at start it was 7169 [junit] 2017-11-29 09:14:26,357 [myid:] - INFO [main:ZKTestCase$1@68] - SUCCEEDED testWatcherAutoResetWithLocal [junit] 2017-11-29 09:14:26,357 [myid:] - INFO [main:ZKTestCase$1@63] - FINISHED testWatcherAutoResetWithLocal [junit] Tests run: 103, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 746.167 sec, Thread: 1, Class: org.apache.zookeeper.test.NioNettySuiteTest [junit] 2017-11-29 09:14:26,476 [myid:127.0.0.1:11271] - INFO [main-SendThread(127.0.0.1:11271):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:11271. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-11-29 09:14:26,477 [myid:127.0.0.1:11271] - WARN [main-SendThread(127.0.0.1:11271):ClientCnxn$SendThread@1235] - Session 0x1005e6198c10001 for server 127.0.0.1/127.0.0.1:11271, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-11-29 09:14:26,556 [myid:127.0.0.1:11348] - INFO [main-SendThread(127.0.0.1:11348):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:11348. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-11-29 09:14:26,556 [myid:127.0.0.1:11348] - WARN [main-SendThread(127.0.0.1:11348):ClientCnxn$SendThread@1235] - Session 0x2005e685f17 for server 127.0.0.1/127.0.0.1:11348, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)