[jira] [Updated] (ZOOKEEPER-2964) dataDir and dataLogDir are printed opposingly

2018-01-07 Thread Qihong Xu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qihong Xu updated ZOOKEEPER-2964:
-
Attachment: ZOOKEEPER-2964.patch

> dataDir and dataLogDir are printed opposingly
> -
>
> Key: ZOOKEEPER-2964
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2964
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.3
>Reporter: Qihong Xu
>Priority: Minor
> Attachments: ZOOKEEPER-2964.patch
>
>
> I foung a bug that "conf" command would return dataDir and dataLogDir 
> opposingly.
> This bug only exists in versions newer than 3.5. I only found dumpConf in 
> [ZookeeperServer.java|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java#L188]
>  prints these two paths opposingly. Unlike ZOOKEEPER-2960, the actual paths 
> are not affected and server function is ok.
> I made a small patch to fix this bug. Any review is appreciated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ZOOKEEPER-2964) dataDir and dataLogDir are printed opposingly

2018-01-07 Thread Qihong Xu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qihong Xu updated ZOOKEEPER-2964:
-
Description: 
I foung a bug that "conf" command would return dataDir and dataLogDir 
opposingly.

This bug only exists in versions newer than 3.5. I only found dumpConf in 
[ZookeeperServer.java|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java#L188]
 prints these two paths opposingly. Unlike ZOOKEEPER-2960, the actual paths are 
not affected and server function is ok.

I made a small patch to fix this bug. Any review is appreciated.

  was:
I foung a bug that "conf" command would return dataDir and dataLogDir 
opposingly.

This bug only exists in versions newer than 3.5. I only found dumpConf in 
[ZookeeperServer.java|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java#L188]
 print these two paths opposingly. Unlike ZOOKEEPER-2960, the actual paths are 
not affected and server function is ok.


> dataDir and dataLogDir are printed opposingly
> -
>
> Key: ZOOKEEPER-2964
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2964
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.3
>Reporter: Qihong Xu
>Priority: Minor
>
> I foung a bug that "conf" command would return dataDir and dataLogDir 
> opposingly.
> This bug only exists in versions newer than 3.5. I only found dumpConf in 
> [ZookeeperServer.java|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java#L188]
>  prints these two paths opposingly. Unlike ZOOKEEPER-2960, the actual paths 
> are not affected and server function is ok.
> I made a small patch to fix this bug. Any review is appreciated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ZOOKEEPER-2964) dataDir and dataLogDir are printed opposingly

2018-01-07 Thread Qihong Xu (JIRA) 
Qihong Xu created ZOOKEEPER-2964:


 Summary: dataDir and dataLogDir are printed opposingly
 Key: ZOOKEEPER-2964
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2964
 Project: ZooKeeper
  Issue Type: Bug
  Components: server
Affects Versions: 3.5.3
Reporter: Qihong Xu
Priority: Minor


I foung a bug that "conf" command would return dataDir and dataLogDir 
opposingly.

This bug only exists in versions newer than 3.5. I only found dumpConf in 
[ZookeeperServer.java|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java#L188]
 print these two paths opposingly. Unlike ZOOKEEPER-2960, the actual paths are 
not affected and server function is ok.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Bug in Zookeeper 3.4.11 release

2018-01-07 Thread Camille Fournier 
Yeah, this is bad. I reviewed and merged the PR to get this process started.

On Fri, Jan 5, 2018 at 5:25 PM, Abraham Fine  wrote:

> I left a comment on the JIRA and I'm not sure what the conventional way to
> proceed would be either.
>
> I think we should work to get a release out as quickly as possible with
> this fix. In addition, I think we may want to add a check on startup that
> forces a failure if snapshots/logs are where they shouldn't be. That way we
> prevent people that are running 3.4.11 from experiencing data loss.
>
> Abe
>
> On Wed, Jan 3, 2018, at 03:07, Andor Molnar wrote:
> > Hi all,
> >
> > Looks like we've a pretty serious bug in 3.4.11:
> > https://issues.apache.org/jira/browse/ZOOKEEPER-2960
> >
> > In a nutshell: ZK uses dataDir and dataLogDir parameters in the wrong
> > order, meaning it tries to access logs in the snapshot folder and vica
> > versa.
> >
> > Not sure what's the process in such case, but I believe we've to
> deprecate
> > 3.4.11 and release a maintenance/hotfix/etc release asap.
> >
> > Please advise.
> >
> > In the meantime I'm creating a patch to address the issue on branch-3.4.
> > (other branches are not affected)
> >
> > Thanks,
> > Andor
>

[jira] [Commented] (ZOOKEEPER-2960) The dataDir and dataLogDir are used opposingly

2018-01-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315553#comment-16315553
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2960:
---

Github user skamille commented on the issue:

https://github.com/apache/zookeeper/pull/441
  
+1 gonna attempt to commit this


> The dataDir and dataLogDir are used opposingly
> --
>
> Key: ZOOKEEPER-2960
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2960
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.11
> Environment: Not relevant.
>Reporter: Dan Milon
>Assignee: Andor Molnar
>Priority: Critical
>
> _emphasized text_After upgrading from zookeeper 3.4.5, to 3.4.11, without 
> editing {{zoo.cfg}}, the new version of the server tries to use the 
> {{dataDir}} as the {{dataLogDir}}, and the {{dataLogDir}} as the {{dataDir}}. 
> Or at least some parts of the server.
> Configuration file has:
> {noformat}
> $ grep -i data /etc/zookeeper/zoo.cfg 
> dataLogDir=/var/lib/zookeeper/datalog
> dataDir=/var/lib/zookeeper/data
> {noformat}
> But runtime configuration has:
> {noformat}
> $ echo conf | nc localhost 2181 | grep -i data
> dataDir=/var/lib/zookeeper/datalog/version-2
> dataLogDir=/var/lib/zookeeper/data/version-2
> {noformat}
> Also, I got this in the debug logs, so clearly some parts of the server 
> confuse things.
> {noformat}
> [PurgeTask:FileTxnSnapLog@79] - Opening datadir:/var/lib/zookeeper/datalog 
> snapDir:/var/lib/zookeeper/data
> [main:FileTxnSnapLog@79] - Opening datadir:/var/lib/zookeeper/data 
> snapDir:/var/lib/zookeeper/datalog
> {noformat}
> I tried to look in the code for wrong uses of the directories. I only found 
> [ZookeeperServer.java|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java#L227]
>  is passing the arguments to {{FileTxnSnapLog}} in the wrong order, but the 
> code comment says that this is legacy only for tests, so I assume it isn't 
> the cause for my case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper issue #441: ZOOKEEPER-2960. The dataDir and dataLogDir are used op...

2018-01-07 Thread skamille 
Github user skamille commented on the issue:

https://github.com/apache/zookeeper/pull/441
  
+1 gonna attempt to commit this


---

[GitHub] zookeeper pull request #442: Update zookeeperOver.html

2018-01-07 Thread MichaelYgZhang 
Github user MichaelYgZhang closed the pull request at:

https://github.com/apache/zookeeper/pull/442


---

ZooKeeper_branch35_jdk8 - Build # 802 - Failure

2018-01-07 Thread Apache Jenkins Server 
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/802/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 59.08 KB...]
[junit] Running org.apache.zookeeper.test.SaslClientTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.101 sec, Thread: 3, Class: org.apache.zookeeper.test.SaslClientTest
[junit] Running org.apache.zookeeper.test.SaslSuperUserTest in thread 3
[junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 8
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.104 sec, Thread: 3, Class: org.apache.zookeeper.test.SaslSuperUserTest
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.266 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.564 sec, Thread: 8, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 3
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
8
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.089 sec, Thread: 8, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 8
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
128.748 sec, Thread: 2, Class: org.apache.zookeeper.test.RecoveryTest
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 2
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.733 sec, Thread: 2, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 2
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.812 sec, Thread: 2, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 2
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.482 sec, Thread: 2, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
85.602 sec, Thread: 5, Class: org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.096 sec, Thread: 2, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 5
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.004 sec, Thread: 5, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 5
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
22.657 sec, Thread: 8, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 8
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.124 sec, Thread: 8, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 8
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.372 sec, Thread: 8, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 8
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
14.801 sec, Thread: 2, Class: org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
35.319 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 2
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.136 sec, Thread: 2, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 3
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.498 sec, Thread: 2, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
21.676 sec, Thread: 5, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
11.131 sec, Thread: 3, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:

ZooKeeper_branch35_openjdk7 - Build # 803 - Failure

2018-01-07 Thread Apache Jenkins Server 
See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/803/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 59.33 KB...]
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.601 sec, Thread: 2, Class: org.apache.zookeeper.test.SaslSuperUserTest
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
3
[junit] Running org.apache.zookeeper.test.SessionTest in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.575 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
3
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.099 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 3
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
67.792 sec, Thread: 8, Class: org.apache.zookeeper.test.QuorumZxidSyncTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.435 sec, Thread: 6, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 6
[junit] Running org.apache.zookeeper.test.StatTest in thread 8
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.753 sec, Thread: 8, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 8
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.499 sec, Thread: 6, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 6
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.086 sec, Thread: 6, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 6
[junit] Tests run: 14, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 
81.169 sec, Thread: 4, Class: org.apache.zookeeper.test.QuorumTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.681 sec, Thread: 6, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.576 sec, Thread: 8, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 4
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 8
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 6
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.105 sec, Thread: 6, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 6
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.997 sec, Thread: 6, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 6
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
7.126 sec, Thread: 4, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 4
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.096 sec, Thread: 4, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 4
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
20.699 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
7.147 sec, Thread: 4, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.681 sec, Thread: 3, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
22.657 sec, Thread: 8, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
34.728 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
29.03 sec, Thread: 6, Class: org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 103, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
354.857 sec, Thread: 5, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] Tests run: 103, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
360.482 sec, Thread: 7, Class: