[jira] [Commented] (ZOOKEEPER-2338) c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on fork/exec

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331511#comment-16331511
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2338:
---

Github user phunt commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/427#discussion_r162510701
  
--- Diff: src/c/configure.ac ---
@@ -130,18 +130,66 @@ main()
  else
exit(0);
 }
-], AC_MSG_RESULT(yes) 
-   ipv6=yes, 
-   AC_MSG_RESULT(no) 
-   ipv6=no, 
-   AC_MSG_RESULT(no) 
+], AC_MSG_RESULT(yes)
+   ipv6=yes,
+   AC_MSG_RESULT(no)
+   ipv6=no,
+   AC_MSG_RESULT(no)
ipv6=no)
 
 if test x"$ipv6" = xyes; then
   USEIPV6="-DZOO_IPV6_ENABLED"
   AC_SUBST(USEIPV6)
 fi
 
+# use SOCK_CLOEXEC if available and wanted
+AC_ARG_WITH([sock_cloexec],
+[AS_HELP_STRING([--with-sock-cloexec],[build with SOCK_CLOEXEC flag set on 
the connections])],
+[],[with_sock_cloexec=no])
+
+AC_MSG_CHECKING([whether SOCK_CLOEXEC is available])
+
+AC_TRY_RUN([ /* is SOCK_CLOEXEC available ? */
+#include 
+#include 
+#include 
+main()
+{
+#ifdef SOCK_CLOEXEC
+  exit(0);
+#else
+  exit(1);
+#endif
+}
+], AC_MSG_RESULT(yes)
+   has_sock_cloexec=yes,
+   AC_MSG_RESULT(no)
+   has_sock_cloexec=no,
+   AC_MSG_RESULT(no)
+   has_sock_cloexec=no)
+
+if test "x$with_sock_cloexec" != xno && test "x$has_sock_cloexec" = xno; 
then
+  AC_MSG_WARN([cannot use SOCK_CLOEXEC -- SOCK_CLOEXEC undefined on this 
platform])
+  with_sock_cloexec=no
+fi
+
+if test "x$with_sock_cloexec" != xno; then
+AC_MSG_NOTICE([building with SOCK_CLOEXEC])
+else
+AC_MSG_NOTICE([building without SOCK_CLOEXEC])
+fi
+
+AS_IF([test x"$with_sock_cloexec" != xno], 
[AC_DEFINE([SOCK_CLOEXEC_ENABLED], [1], [Define to 1, if SOCK_CLOEXEC is 
defined and wanted])])
+AM_CONDITIONAL([SOCK_CLOEXEC_ENABLED],[test "x$with_sock_cloexec" != xno])
+
+# Determine which libraries we need to use clock_gettime
--- End diff --

@fr0stbyte I'd still like to get this committed - does my most recent 
comment make sense or am I missing something?


> c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on 
> fork/exec
> --
>
> Key: ZOOKEEPER-2338
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2338
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: James DeFelice
>Assignee: Radu Brumariu
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> I've observed socket FD leaks in Apache Mesos when using ZK to coordinate 
> master leadership: https://issues.apache.org/jira/browse/MESOS-4065



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #427: [ZOOKEEPER-2338] - set SOCK_CLOEXEC on socket i...

[phunt]

Github user phunt commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/427#discussion_r162510701
  
--- Diff: src/c/configure.ac ---
@@ -130,18 +130,66 @@ main()
  else
exit(0);
 }
-], AC_MSG_RESULT(yes) 
-   ipv6=yes, 
-   AC_MSG_RESULT(no) 
-   ipv6=no, 
-   AC_MSG_RESULT(no) 
+], AC_MSG_RESULT(yes)
+   ipv6=yes,
+   AC_MSG_RESULT(no)
+   ipv6=no,
+   AC_MSG_RESULT(no)
ipv6=no)
 
 if test x"$ipv6" = xyes; then
   USEIPV6="-DZOO_IPV6_ENABLED"
   AC_SUBST(USEIPV6)
 fi
 
+# use SOCK_CLOEXEC if available and wanted
+AC_ARG_WITH([sock_cloexec],
+[AS_HELP_STRING([--with-sock-cloexec],[build with SOCK_CLOEXEC flag set on 
the connections])],
+[],[with_sock_cloexec=no])
+
+AC_MSG_CHECKING([whether SOCK_CLOEXEC is available])
+
+AC_TRY_RUN([ /* is SOCK_CLOEXEC available ? */
+#include 
+#include 
+#include 
+main()
+{
+#ifdef SOCK_CLOEXEC
+  exit(0);
+#else
+  exit(1);
+#endif
+}
+], AC_MSG_RESULT(yes)
+   has_sock_cloexec=yes,
+   AC_MSG_RESULT(no)
+   has_sock_cloexec=no,
+   AC_MSG_RESULT(no)
+   has_sock_cloexec=no)
+
+if test "x$with_sock_cloexec" != xno && test "x$has_sock_cloexec" = xno; 
then
+  AC_MSG_WARN([cannot use SOCK_CLOEXEC -- SOCK_CLOEXEC undefined on this 
platform])
+  with_sock_cloexec=no
+fi
+
+if test "x$with_sock_cloexec" != xno; then
+AC_MSG_NOTICE([building with SOCK_CLOEXEC])
+else
+AC_MSG_NOTICE([building without SOCK_CLOEXEC])
+fi
+
+AS_IF([test x"$with_sock_cloexec" != xno], 
[AC_DEFINE([SOCK_CLOEXEC_ENABLED], [1], [Define to 1, if SOCK_CLOEXEC is 
defined and wanted])])
+AM_CONDITIONAL([SOCK_CLOEXEC_ENABLED],[test "x$with_sock_cloexec" != xno])
+
+# Determine which libraries we need to use clock_gettime
--- End diff --

@fr0stbyte I'd still like to get this committed - does my most recent 
comment make sense or am I missing something?


---

[jira] [Commented] (ZOOKEEPER-2824) `FileChannel#size` info should be added to `FileTxnLog#commit` to solve the confuse that reason is too large log or too busy disk I/O

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331505#comment-16331505
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2824:
---

Github user phunt commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/296#discussion_r162510193
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -332,11 +333,13 @@ public synchronized void commit() throws IOException {
 if (forceSync) {
 long startSyncNS = System.nanoTime();
 
-log.getChannel().force(false);
+FileChannel channel = log.getChannel();
+channel.force(false);
 
 syncElapsedMS = 
TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startSyncNS);
 if (syncElapsedMS > fsyncWarningThresholdMS) {
-LOG.warn("fsync-ing the write ahead log in "
+LOG.warn("fsync-ing the write ahead log ("
++ channel.size() + " bytes) in "
--- End diff --

@asdf2014 can you move the changed text after the first sentence?

... latency. File size is ### bytes. See ...

The reason being that I know a number of users who have log triggers on 
this log message and I'd like to minimize the impact as much as possible.


> `FileChannel#size` info should be added to `FileTxnLog#commit` to solve the 
> confuse that reason is too large log or too busy disk I/O
> -
>
> Key: ZOOKEEPER-2824
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2824
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.5.3
>Reporter: Benedict Jin
>Assignee: Benedict Jin
>Priority: Minor
>  Labels: logging
> Fix For: 3.5.4, 3.6.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> `FileChannel#size` info should be added to `FileTxnLog#commit` to solve the 
> confuse that reason is too large log or too busy disk I/O



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #296: ZOOKEEPER-2824: `FileChannel#size` info should ...

[phunt]

Github user phunt commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/296#discussion_r162510193
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -332,11 +333,13 @@ public synchronized void commit() throws IOException {
 if (forceSync) {
 long startSyncNS = System.nanoTime();
 
-log.getChannel().force(false);
+FileChannel channel = log.getChannel();
+channel.force(false);
 
 syncElapsedMS = 
TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startSyncNS);
 if (syncElapsedMS > fsyncWarningThresholdMS) {
-LOG.warn("fsync-ing the write ahead log in "
+LOG.warn("fsync-ing the write ahead log ("
++ channel.size() + " bytes) in "
--- End diff --

@asdf2014 can you move the changed text after the first sentence?

... latency. File size is ### bytes. See ...

The reason being that I know a number of users who have log triggers on 
this log message and I'd like to minimize the impact as much as possible.


---

[jira] [Commented] (ZOOKEEPER-2961) Fix testElectionFraud Flakyness

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331502#comment-16331502
 ] 

Hudson commented on ZOOKEEPER-2961:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3697 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3697/])
ZOOKEEPER-2961: Fix testElectionFraud Flakyness (phunt: rev 
77d6b763a7772553ecfa81e3d3ef177452ad16a7)
* (edit) 
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java


> Fix testElectionFraud Flakyness
> ---
>
> Key: ZOOKEEPER-2961
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2961
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Abraham Fine
>Assignee: Abraham Fine
>Priority: Major
> Fix For: 3.5.4, 3.6.0, 3.4.12
>
>
> This test relies on hooking into our logging system and creates a new 
> appender using a PatternLayout object shared with the CONSOLE appender. 
> PatternLayout has some synchronization issues 
> (https://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayout.html)
>  so we should create a new instance of it. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2964) "Conf" command returns dataDir and dataLogDir opposingly

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331503#comment-16331503
 ] 

Hudson commented on ZOOKEEPER-2964:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3697 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3697/])
ZOOKEEPER-2964: Conf" command returns dataDir and dataLogDir opposingly (phunt: 
rev 78708a8587841ccdcb3d07f33d3114e0c8cfc380)
* (edit) src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java


> "Conf" command returns dataDir and dataLogDir opposingly
> 
>
> Key: ZOOKEEPER-2964
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2964
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.3, 3.6.0
>Reporter: Qihong Xu
>Priority: Minor
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2964.patch
>
>
> I foung a bug that "conf" command would return dataDir and dataLogDir 
> opposingly.
> This bug only exists in versions newer than 3.5. I only found dumpConf in 
> [ZookeeperServer.java|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java#L188]
>  prints these two paths opposingly. Unlike ZOOKEEPER-2960, the actual paths 
> are not affected and server function is ok.
> I made a small patch to fix this bug. Any review is appreciated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2249) CRC check failed when preAllocSize smaller than node data

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331501#comment-16331501
 ] 

Hudson commented on ZOOKEEPER-2249:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3697 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3697/])
ZOOKEEPER-2249: CRC check failed when preAllocSize smaller than node (phunt: 
rev 4d629d289fc4b1079fff2244b92a337e4068e240)
* (add) 
src/java/test/org/apache/zookeeper/server/persistence/FileTxnLogTest.java
* (edit) src/java/main/org/apache/zookeeper/server/persistence/Util.java
* (edit) src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java


> CRC check failed when preAllocSize smaller than node data
> -
>
> Key: ZOOKEEPER-2249
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2249
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Benjamin Jaton
>Assignee: Abraham Fine
>Priority: Major
>  Labels: server
> Fix For: 3.5.4, 3.6.0, 3.4.12
>
>
> Unexpected exception, exiting abnormally 
> java.io.IOException: CRC check failed 
> org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.next(FileTxnLog.java:612)
>  
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:157)
>  
> org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:223) 
> org.apache.zookeeper.server.ZooKeeperServer.loadData(ZooKeeperServer.java:272)
>  
> org.apache.zookeeper.server.ZooKeeperServer.startdata(ZooKeeperServer.java:399)
> To reproduce, set the preAllocSize to 8MB, the jute.maxbuffer to 20MB and try 
> saving a 15MB node several times.
> In my case the erroneous CRC appears after the second save. I use the 
> LogFormatter class to detect it.
> I suspect that the CRC error happens when the new transaction log is created, 
> the code probably expects to have enough room to save the transaction when 
> creating a new file, but it's too small.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2955) Enable Clover code coverage report

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331484#comment-16331484
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2955:
---

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/443
  
OK. Can you address the other f/b then? (ivy.xml). @afine any thoughts on 
this wrt the classpath issues we've been facing. I assume the ivy.xml change 
would be sufficient? Please help verify.


> Enable Clover code coverage report
> --
>
> Key: ZOOKEEPER-2955
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2955
> Project: ZooKeeper
>  Issue Type: Test
>  Components: tests
>Affects Versions: 3.5.3, 3.4.11
>Reporter: Mark Fenes
>Assignee: Mark Fenes
>Priority: Major
>
> We have limited code coverage support in ZK. Clover for Java was running in 
> the past but was turned off. 
> Enable Clover code coverage report to make us more confident on the quality, 
> stability and compatibility of future ZK releases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #443: ZOOKEEPER-2955: Enable Clover code coverage report

[phunt]

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/443
  
OK. Can you address the other f/b then? (ivy.xml). @afine any thoughts on 
this wrt the classpath issues we've been facing. I assume the ivy.xml change 
would be sufficient? Please help verify.


---

[jira] [Resolved] (ZOOKEEPER-2964) "Conf" command returns dataDir and dataLogDir opposingly

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt resolved ZOOKEEPER-2964.
-
   Resolution: Fixed
Fix Version/s: 3.5.4
   3.6.0

Issue resolved by pull request 449
[https://github.com/apache/zookeeper/pull/449]

> "Conf" command returns dataDir and dataLogDir opposingly
> 
>
> Key: ZOOKEEPER-2964
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2964
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.3, 3.6.0
>Reporter: Qihong Xu
>Priority: Minor
> Fix For: 3.6.0, 3.5.4
>
> Attachments: ZOOKEEPER-2964.patch
>
>
> I foung a bug that "conf" command would return dataDir and dataLogDir 
> opposingly.
> This bug only exists in versions newer than 3.5. I only found dumpConf in 
> [ZookeeperServer.java|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java#L188]
>  prints these two paths opposingly. Unlike ZOOKEEPER-2960, the actual paths 
> are not affected and server function is ok.
> I made a small patch to fix this bug. Any review is appreciated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #449: ZOOKEEPER-2964: "Conf" command returns dataDir ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/449


---

[jira] [Updated] (ZOOKEEPER-2964) "Conf" command returns dataDir and dataLogDir opposingly

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2964:

Affects Version/s: 3.6.0

> "Conf" command returns dataDir and dataLogDir opposingly
> 
>
> Key: ZOOKEEPER-2964
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2964
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.3, 3.6.0
>Reporter: Qihong Xu
>Priority: Minor
> Attachments: ZOOKEEPER-2964.patch
>
>
> I foung a bug that "conf" command would return dataDir and dataLogDir 
> opposingly.
> This bug only exists in versions newer than 3.5. I only found dumpConf in 
> [ZookeeperServer.java|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java#L188]
>  prints these two paths opposingly. Unlike ZOOKEEPER-2960, the actual paths 
> are not affected and server function is ok.
> I made a small patch to fix this bug. Any review is appreciated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2964) "Conf" command returns dataDir and dataLogDir opposingly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331474#comment-16331474
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2964:
---

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/449


> "Conf" command returns dataDir and dataLogDir opposingly
> 
>
> Key: ZOOKEEPER-2964
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2964
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.3, 3.6.0
>Reporter: Qihong Xu
>Priority: Minor
> Attachments: ZOOKEEPER-2964.patch
>
>
> I foung a bug that "conf" command would return dataDir and dataLogDir 
> opposingly.
> This bug only exists in versions newer than 3.5. I only found dumpConf in 
> [ZookeeperServer.java|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java#L188]
>  prints these two paths opposingly. Unlike ZOOKEEPER-2960, the actual paths 
> are not affected and server function is ok.
> I made a small patch to fix this bug. Any review is appreciated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331472#comment-16331472
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2184:
---

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/150
  
I suspect folks were out on vacation. I was. :-)

It doesn't seem like @fpj has time to look at this - can someone else pick 
it up and address the recent comments?


> Zookeeper Client should re-resolve hosts when connection attempts fail
> --
>
> Key: ZOOKEEPER-2184
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2184
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6, 3.4.7, 3.4.8, 3.4.9, 3.4.10, 3.5.0, 3.5.1, 3.5.2, 
> 3.5.3, 3.4.11
> Environment: Ubuntu 14.04 host, Docker containers for Zookeeper & 
> Kafka
>Reporter: Robert P. Thille
>Assignee: Flavio Junqueira
>Priority: Blocker
>  Labels: easyfix, patch
> Fix For: 3.5.4, 3.4.12
>
> Attachments: ZOOKEEPER-2184.patch
>
>
> Testing in a Docker environment with a single Kafka instance using a single 
> Zookeeper instance. Restarting the Zookeeper container will cause it to 
> receive a new IP address. Kafka will never be able to reconnect to Zookeeper 
> and will hang indefinitely. Updating DNS or /etc/hosts with the new IP 
> address will not help the client to reconnect as the 
> zookeeper/client/StaticHostProvider resolves the connection string hosts at 
> creation time and never re-resolves.
> A solution would be for the client to notice that connection attempts fail 
> and attempt to re-resolve the hostnames in the connectString.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #150: ZOOKEEPER-2184: Zookeeper Client should re-resolve hos...

[phunt]

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/150
  
I suspect folks were out on vacation. I was. :-)

It doesn't seem like @fpj has time to look at this - can someone else pick 
it up and address the recent comments?


---

[jira] [Commented] (ZOOKEEPER-1580) QuorumPeer.setRunning is not used

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331470#comment-16331470
 ] 

ASF GitHub Bot commented on ZOOKEEPER-1580:
---

Github user phunt commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/446#discussion_r162506685
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
---
@@ -1751,7 +1751,7 @@ public synchronized void initConfigInZKDatabase() {
 if (zkDb != null) zkDb.initConfigInZKDatabase(getQuorumVerifier());
 }
 
-public void setRunning(boolean running) {
+private void setRunning(boolean running) {
--- End diff --

Where are we with this @maoling @anmolnar ?


> QuorumPeer.setRunning is not used
> -
>
> Key: ZOOKEEPER-1580
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1580
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>Priority: Minor
>
> setRunning is a public method and a search did not indicate that it is used 
> anywhere, not even in tests. In fact, I believe we should not change 
> "running" freely and we should only do it when calling shutdown. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #446: ZOOKEEPER-1580:QuorumPeer.setRunning is not use...

[phunt]

Github user phunt commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/446#discussion_r162506685
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
---
@@ -1751,7 +1751,7 @@ public synchronized void initConfigInZKDatabase() {
 if (zkDb != null) zkDb.initConfigInZKDatabase(getQuorumVerifier());
 }
 
-public void setRunning(boolean running) {
+private void setRunning(boolean running) {
--- End diff --

Where are we with this @maoling @anmolnar ?


---

[jira] [Resolved] (ZOOKEEPER-2961) Fix testElectionFraud Flakyness

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt resolved ZOOKEEPER-2961.
-
   Resolution: Fixed
Fix Version/s: 3.5.4
   3.6.0
   3.4.12

Issue resolved by pull request 437
[https://github.com/apache/zookeeper/pull/437]

> Fix testElectionFraud Flakyness
> ---
>
> Key: ZOOKEEPER-2961
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2961
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Abraham Fine
>Assignee: Abraham Fine
>Priority: Major
> Fix For: 3.4.12, 3.6.0, 3.5.4
>
>
> This test relies on hooking into our logging system and creates a new 
> appender using a PatternLayout object shared with the CONSOLE appender. 
> PatternLayout has some synchronization issues 
> (https://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayout.html)
>  so we should create a new instance of it. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2961) Fix testElectionFraud Flakyness

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331467#comment-16331467
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2961:
---

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/437
  
LGTM +1. Thanks @afine 


> Fix testElectionFraud Flakyness
> ---
>
> Key: ZOOKEEPER-2961
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2961
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Abraham Fine
>Assignee: Abraham Fine
>Priority: Major
> Fix For: 3.5.4, 3.6.0, 3.4.12
>
>
> This test relies on hooking into our logging system and creates a new 
> appender using a PatternLayout object shared with the CONSOLE appender. 
> PatternLayout has some synchronization issues 
> (https://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayout.html)
>  so we should create a new instance of it. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #437: ZOOKEEPER-2961: Fix testElectionFraud Flakyness

[phunt]

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/437
  
LGTM +1. Thanks @afine 


---

[jira] [Commented] (ZOOKEEPER-2961) Fix testElectionFraud Flakyness

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331455#comment-16331455
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2961:
---

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/437


> Fix testElectionFraud Flakyness
> ---
>
> Key: ZOOKEEPER-2961
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2961
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Abraham Fine
>Assignee: Abraham Fine
>Priority: Major
>
> This test relies on hooking into our logging system and creates a new 
> appender using a PatternLayout object shared with the CONSOLE appender. 
> PatternLayout has some synchronization issues 
> (https://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayout.html)
>  so we should create a new instance of it. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #437: ZOOKEEPER-2961: Fix testElectionFraud Flakyness

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/437


---

[jira] [Commented] (ZOOKEEPER-2249) CRC check failed when preAllocSize smaller than node data

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331450#comment-16331450
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2249:
---

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/436
  
LGTM +1. Thanks @afine . Committed to 3.4/3.5/trunk.


> CRC check failed when preAllocSize smaller than node data
> -
>
> Key: ZOOKEEPER-2249
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2249
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Benjamin Jaton
>Assignee: Abraham Fine
>Priority: Major
>  Labels: server
> Fix For: 3.5.4, 3.6.0, 3.4.12
>
>
> Unexpected exception, exiting abnormally 
> java.io.IOException: CRC check failed 
> org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.next(FileTxnLog.java:612)
>  
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:157)
>  
> org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:223) 
> org.apache.zookeeper.server.ZooKeeperServer.loadData(ZooKeeperServer.java:272)
>  
> org.apache.zookeeper.server.ZooKeeperServer.startdata(ZooKeeperServer.java:399)
> To reproduce, set the preAllocSize to 8MB, the jute.maxbuffer to 20MB and try 
> saving a 15MB node several times.
> In my case the erroneous CRC appears after the second save. I use the 
> LogFormatter class to detect it.
> I suspect that the CRC error happens when the new transaction log is created, 
> the code probably expects to have enough room to save the transaction when 
> creating a new file, but it's too small.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #436: ZOOKEEPER-2249: CRC check failed when preAllocSize sma...

[phunt]

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/436
  
LGTM +1. Thanks @afine . Committed to 3.4/3.5/trunk.


---

[jira] [Resolved] (ZOOKEEPER-2249) CRC check failed when preAllocSize smaller than node data

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt resolved ZOOKEEPER-2249.
-
   Resolution: Fixed
Fix Version/s: 3.5.4
   3.6.0
   3.4.12

Issue resolved by pull request 436
[https://github.com/apache/zookeeper/pull/436]

> CRC check failed when preAllocSize smaller than node data
> -
>
> Key: ZOOKEEPER-2249
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2249
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Benjamin Jaton
>Assignee: Abraham Fine
>Priority: Major
>  Labels: server
> Fix For: 3.4.12, 3.6.0, 3.5.4
>
>
> Unexpected exception, exiting abnormally 
> java.io.IOException: CRC check failed 
> org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.next(FileTxnLog.java:612)
>  
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:157)
>  
> org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:223) 
> org.apache.zookeeper.server.ZooKeeperServer.loadData(ZooKeeperServer.java:272)
>  
> org.apache.zookeeper.server.ZooKeeperServer.startdata(ZooKeeperServer.java:399)
> To reproduce, set the preAllocSize to 8MB, the jute.maxbuffer to 20MB and try 
> saving a 15MB node several times.
> In my case the erroneous CRC appears after the second save. I use the 
> LogFormatter class to detect it.
> I suspect that the CRC error happens when the new transaction log is created, 
> the code probably expects to have enough room to save the transaction when 
> creating a new file, but it's too small.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2249) CRC check failed when preAllocSize smaller than node data

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331437#comment-16331437
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2249:
---

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/436


> CRC check failed when preAllocSize smaller than node data
> -
>
> Key: ZOOKEEPER-2249
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2249
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Benjamin Jaton
>Assignee: Abraham Fine
>Priority: Major
>  Labels: server
>
> Unexpected exception, exiting abnormally 
> java.io.IOException: CRC check failed 
> org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.next(FileTxnLog.java:612)
>  
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:157)
>  
> org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:223) 
> org.apache.zookeeper.server.ZooKeeperServer.loadData(ZooKeeperServer.java:272)
>  
> org.apache.zookeeper.server.ZooKeeperServer.startdata(ZooKeeperServer.java:399)
> To reproduce, set the preAllocSize to 8MB, the jute.maxbuffer to 20MB and try 
> saving a 15MB node several times.
> In my case the erroneous CRC appears after the second save. I use the 
> LogFormatter class to detect it.
> I suspect that the CRC error happens when the new transaction log is created, 
> the code probably expects to have enough room to save the transaction when 
> creating a new file, but it's too small.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #436: ZOOKEEPER-2249: CRC check failed when preAllocS...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/436


---

ZooKeeper-trunk-openjdk7 - Build # 1771 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1771/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 60.67 KB...]
[junit] Running org.apache.zookeeper.test.SaslClientTest in thread 1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.104 sec, Thread: 1, Class: org.apache.zookeeper.test.SaslClientTest
[junit] Running org.apache.zookeeper.test.SaslSuperUserTest in thread 4
[junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 1
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.752 sec, Thread: 4, Class: org.apache.zookeeper.test.SaslSuperUserTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.68 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 4
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
3
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.121 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.503 sec, Thread: 1, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.514 sec, Thread: 1, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.012 sec, Thread: 1, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 1
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
4.209 sec, Thread: 1, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.098 sec, Thread: 1, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 1
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
70.848 sec, Thread: 2, Class: org.apache.zookeeper.test.QuorumZxidSyncTest
[junit] Tests run: 14, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 
82.524 sec, Thread: 7, Class: org.apache.zookeeper.test.QuorumTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.761 sec, Thread: 1, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 1
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 7
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 2
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.095 sec, Thread: 2, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 2
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.996 sec, Thread: 2, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 2
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
4.938 sec, Thread: 1, Class: org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
19.841 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 1
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.11 sec, Thread: 1, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 1
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.864 sec, Thread: 3, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
7.001 sec, Thread: 1, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
34.774 sec, Thread: 4, Class: org.apache.zookeeper.test.SessionTest
[junit] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 
20.314 sec, Thread: 7, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Test org.apache.zookeeper.test.WatchEventWhenAutoResetTest FAILED

[GitHub] zookeeper issue #443: ZOOKEEPER-2955: Enable Clover code coverage report

[mfenes]

Github user mfenes commented on the issue:

https://github.com/apache/zookeeper/pull/443
  
@anmolnar Yes, OpenClover's Intellectual property protection page 
http://openclover.org/doc/manual/4.2.0/developer-guide--intellectual-property-protection.html
 says that
- Clover Core is licensed under Apache 2.0 License
- Most of Clover plugins are licensed under Apache 2.0 License
- Bamboo Clover Plugin is proprietary software, see Bamboo Clover Plugin 
Developer Guide
- Clover documentation on confluence.atlassian.com is under Creative 
Commons License, see Contributing to the Clover Documentation



---

[GitHub] zookeeper issue #443: ZOOKEEPER-2955: Enable Clover code coverage report

[mfenes]

Github user mfenes commented on the issue:

https://github.com/apache/zookeeper/pull/443
  
@phunt According to OpenClover 4.2.0 Release Notes at 
http://openclover.org/doc/openclover-4.2.0-release-notes.html
_"No license key required
OpenClover requires no license key, in some places you may see a "Clover 
free edition" message. You no longer need any external license key to run it. 
In case you still pass the license key issued by Atlassian in your builds (e.g. 
via -Dclover.license.path JVM property), it will be ignored and the built-in 
one will be used."_

Regarding being able to run OpenClover on Apache Jenkins: I think we can 
configure a Jenkins job to generate code coverage reports since OpenClover does 
not need any installation, it's just a clover-4.2.1.jar file in 
/build/test/lib. However we would need a storage space to store the generated 
coverage reports as otherwise it would be deleted when the /build directory is 
cleaned. Also I would mention that OpenClover needs ZK to be compiled using the 
-Drun.clover=true option in order to use source code instrumentation and ZK 
compiled with source code instrumentation should not be used for production, 
only just for testing and generating coverage reports.


---

Re: Bug in Zookeeper 3.4.11 release

[Andor Molnar]

I created the jira and started to work on it.

https://issues.apache.org/jira/browse/ZOOKEEPER-2967

Andor



On Thu, Jan 18, 2018 at 6:15 AM, Andor Molnar  wrote:

> Perhaps we should introduce a check of some kind? If datalogdir is
> different that datadir and snapshots exist in datalogdir we throw an
> exception and quit. What do you think?
>
> That definitely makes sense.
>
> Andor
>
>
> On Thu, Jan 18, 2018 at 12:58 AM, Patrick Hunt  wrote:
>
>> Abe mentioned the following on the jira "Perhaps we should introduce a
>> check of some kind?"
>>
>> I agree with Abe on this - if you're new to ZK in 3.4.11 and you split the
>> directories this commit is going to result in unexpected, and likely very
>> bad, situation.
>>
>> Abe - is there a jira to add this check? I'd like to resolve this and the
>> crc issue and push out a 3.4.12 ASAP.
>>
>> Patrick
>>
>>
>> On Mon, Jan 8, 2018 at 1:44 AM, Andor Molnar  wrote:
>>
>> > Thanks Camille. I closed the pull request.
>> >
>> > Andor
>> >
>> >
>> > On Mon, Jan 8, 2018 at 2:32 AM, Camille Fournier 
>> > wrote:
>> >
>> > > Yeah, this is bad. I reviewed and merged the PR to get this process
>> > > started.
>> > >
>> > > On Fri, Jan 5, 2018 at 5:25 PM, Abraham Fine 
>> wrote:
>> > >
>> > > > I left a comment on the JIRA and I'm not sure what the conventional
>> way
>> > > to
>> > > > proceed would be either.
>> > > >
>> > > > I think we should work to get a release out as quickly as possible
>> with
>> > > > this fix. In addition, I think we may want to add a check on startup
>> > that
>> > > > forces a failure if snapshots/logs are where they shouldn't be. That
>> > way
>> > > we
>> > > > prevent people that are running 3.4.11 from experiencing data loss.
>> > > >
>> > > > Abe
>> > > >
>> > > > On Wed, Jan 3, 2018, at 03:07, Andor Molnar wrote:
>> > > > > Hi all,
>> > > > >
>> > > > > Looks like we've a pretty serious bug in 3.4.11:
>> > > > > https://issues.apache.org/jira/browse/ZOOKEEPER-2960
>> > > > >
>> > > > > In a nutshell: ZK uses dataDir and dataLogDir parameters in the
>> wrong
>> > > > > order, meaning it tries to access logs in the snapshot folder and
>> > vica
>> > > > > versa.
>> > > > >
>> > > > > Not sure what's the process in such case, but I believe we've to
>> > > > deprecate
>> > > > > 3.4.11 and release a maintenance/hotfix/etc release asap.
>> > > > >
>> > > > > Please advise.
>> > > > >
>> > > > > In the meantime I'm creating a patch to address the issue on
>> > > branch-3.4.
>> > > > > (other branches are not affected)
>> > > > >
>> > > > > Thanks,
>> > > > > Andor
>> > > >
>> > >
>> >
>>
>
>

ZooKeeper_branch35_jdk8 - Build # 813 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/813/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 62.08 KB...]
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.094 sec, Thread: 8, Class: org.apache.zookeeper.test.SaslClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.307 sec, Thread: 6, Class: 
org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest
[junit] Running org.apache.zookeeper.test.SaslSuperUserTest in thread 3
[junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 8
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
1
[junit] Running org.apache.zookeeper.test.SessionTest in thread 6
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.424 sec, Thread: 3, Class: org.apache.zookeeper.test.SaslSuperUserTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.367 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
3
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.151 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 1
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.976 sec, Thread: 8, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 8
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.168 sec, Thread: 3, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.62 sec, Thread: 8, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 3
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 8
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.105 sec, Thread: 8, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Tests run: 14, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 
90.99 sec, Thread: 7, Class: org.apache.zookeeper.test.QuorumTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 8
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 7
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.277 sec, Thread: 8, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.373 sec, Thread: 3, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 8
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 3
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.175 sec, Thread: 3, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 3
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.17 sec, Thread: 3, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 3
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
7.104 sec, Thread: 7, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 7
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.093 sec, Thread: 7, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 7
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
21.914 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
8.536 sec, Thread: 7, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.002 sec, Thread: 1, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
24.726 sec, Thread: 8, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
35.357 sec, Thread: 6, Class: org.apache.zookeeper.test.SessionTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
31.062 sec, Thread: 3, Class: org.apache.zookeeper.test.WatcherTest

[GitHub] zookeeper issue #443: ZOOKEEPER-2955: Enable Clover code coverage report

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/443
  
@phunt This one is OpenClover which the open source version of Clover. 
Afaik it's under Apache 2.0 license, but @mfenes please correct me if I'm wrong.


---

Failed: ZOOKEEPER- PreCommit Build #1413

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1413/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 77.43 MB...]
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1413//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1413//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1413//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Unable to log in to server: 
https://issues.apache.org/jira/rpc/soap/jirasoapservice-v2 with user: hadoopqa.
 [exec]  Cause: ; nested exception is: 
 [exec] javax.net.ssl.SSLException: Received fatal alert: 
protocol_version
 [exec] Unable to log in to server: 
https://issues.apache.org/jira/rpc/soap/jirasoapservice-v2 with user: hadoopqa.
 [exec]  Cause: ; nested exception is: 
 [exec] javax.net.ssl.SSLException: Received fatal alert: 
protocol_version
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1722:
 exec returned: 1

Total time: 13 minutes 40 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2964
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.ZooKeeperServerMainTest.testMinMaxSessionTimeOut

Error Message:
Failed to establish zkclient connection!

Stack Trace:
junit.framework.AssertionFailedError: Failed to establish zkclient connection!
at 
org.apache.zookeeper.server.ZooKeeperServerMainTest.verifySessionTimeOut(ZooKeeperServerMainTest.java:420)
at 
org.apache.zookeeper.server.ZooKeeperServerMainTest.testMinMaxSessionTimeOut(ZooKeeperServerMainTest.java:403)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)