[GitHub] zookeeper issue #528: ZOOKEEPER-3034 Facing issues while building from sourc...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/528
  
@phunt @afine @hanm You guys might want to take a quick look at this in 
@rgs1 absence. It's kind of an infrastructural change only and would be useful 
in the long term.


---

[GitHub] zookeeper issue #522: ZOOKEEPER-1919 Update the C implementation of removeWa...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/522
  
@phunt You might want to commit this as @rgs1 already reviewed it and you 
were also involved.


---

ZooKeeper_branch34 - Build # 2361 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34/2361/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 206.47 KB...]
 [exec] Zookeeper_init::testOutOfMemory_getaddrs1 : elapsed 0 : OK
 [exec] Zookeeper_init::testOutOfMemory_getaddrs2 : elapsed 0 : OK
 [exec] Zookeeper_init::testPermuteAddrsList : elapsed 0 : OK
 [exec] Zookeeper_close::testIOThreadStoppedOnExpire : elapsed 286 : OK
 [exec] Zookeeper_close::testCloseUnconnected : elapsed 0 : OK
 [exec] Zookeeper_close::testCloseUnconnected1 : elapsed 69 : OK
 [exec] Zookeeper_close::testCloseConnected1 : elapsed 290 : OK
 [exec] Zookeeper_close::testCloseFromWatcher1 : elapsed 269 : OK
 [exec] Zookeeper_simpleSystem::testAsyncWatcherAutoReset ZooKeeper server 
started : elapsed 12279 : OK
 [exec] Zookeeper_simpleSystem::testDeserializeString : elapsed 0 : OK
 [exec] Zookeeper_simpleSystem::testFirstServerDown : elapsed 1001 : OK
 [exec] Zookeeper_simpleSystem::testNullData : elapsed 1037 : OK
 [exec] Zookeeper_simpleSystem::testIPV6 : elapsed 1006 : OK
 [exec] Zookeeper_simpleSystem::testPath : elapsed 1066 : OK
 [exec] Zookeeper_simpleSystem::testPathValidation : elapsed 1150 : OK
 [exec] Zookeeper_simpleSystem::testPing : elapsed 17643 : OK
 [exec] Zookeeper_simpleSystem::testAcl : elapsed 1033 : OK
 [exec] Zookeeper_simpleSystem::testChroot : elapsed 3081 : OK
 [exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started ZooKeeper 
server started : elapsed 34140 : OK
 [exec] Zookeeper_simpleSystem::testHangingClient : elapsed 1032 : OK
 [exec] Zookeeper_simpleSystem::testWatcherAutoResetWithGlobal ZooKeeper 
server started ZooKeeper server started ZooKeeper server started : elapsed 
20974 : OK
 [exec] Zookeeper_simpleSystem::testWatcherAutoResetWithLocal ZooKeeper 
server started ZooKeeper server started ZooKeeper server started : elapsed 
19816 : OK
 [exec] Zookeeper_simpleSystem::testGetChildren2 : elapsed 1063 : OK
 [exec] Zookeeper_multi::testCreate : elapsed 1029 : OK
 [exec] Zookeeper_multi::testCreateDelete : elapsed 1017 : OK
 [exec] Zookeeper_multi::testInvalidVersion : elapsed 1015 : OK
 [exec] Zookeeper_multi::testNestedCreate : elapsed 1010 : OK
 [exec] Zookeeper_multi::testSetData : elapsed 6035 : OK
 [exec] Zookeeper_multi::testUpdateConflict : elapsed 1029 : OK
 [exec] Zookeeper_multi::testDeleteUpdateConflict : elapsed 1007 : OK
 [exec] Zookeeper_multi::testAsyncMulti : elapsed 2001 : OK
 [exec] Zookeeper_multi::testMultiFail : elapsed 1014 : OK
 [exec] Zookeeper_multi::testCheck : elapsed 1025 : OK
 [exec] Zookeeper_multi::testWatch : elapsed 2036 : OK
 [exec] Zookeeper_multi::testSequentialNodeCreateInAsyncMulti : elapsed 
2001 : OK
 [exec] Zookeeper_watchers::testDefaultSessionWatcher1 : elapsed 52 : OK
 [exec] Zookeeper_watchers::testDefaultSessionWatcher2 : elapsed 4 : OK
 [exec] Zookeeper_watchers::testObjectSessionWatcher1 : elapsed 54 : OK
 [exec] Zookeeper_watchers::testObjectSessionWatcher2 : elapsed 57 : OK
 [exec] Zookeeper_watchers::testNodeWatcher1 : elapsed 57 : OK
 [exec] Zookeeper_watchers::testChildWatcher1 : elapsed 104 : OK
 [exec] Zookeeper_watchers::testChildWatcher2 : elapsed 105 : OK
 [exec] 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/src/c/tests/TestOperations.cc:625:
 Assertion: equality assertion failed [Expected: -4, Actual  : 0, 
ZCONNECTIONLOSS != rc]
 [exec] Failures !!!
 [exec] Run: 59   Failure total: 1   Failures: 1   Errors: 0
 [exec] Makefile:1902: recipe for target 'run-check' failed
 [exec] make: *** [run-check] Error 1

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build.xml:1478: The 
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build.xml:1438: The 
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build.xml:1448: exec 
returned: 2

Total time: 46 minutes 40 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
All tests passed

ZooKeeper-trunk - Build # 42 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/42/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 141.01 KB...]
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.486 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.464 sec, Thread: 3, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 2
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 3
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.591 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTimeoutTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
3
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.108 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
136.944 sec, Thread: 1, Class: org.apache.zookeeper.test.RecoveryTest
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 1
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
12.429 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 2
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.788 sec, Thread: 1, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.865 sec, Thread: 2, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.068 sec, Thread: 2, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 2
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.474 sec, Thread: 1, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.988 sec, Thread: 2, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 1
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
98.112 sec, Thread: 8, Class: org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 8
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.122 sec, Thread: 8, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 8
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.732 sec, Thread: 8, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 8
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
22.976 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 3
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.102 sec, Thread: 3, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 3
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
16.933 sec, Thread: 1, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.93 sec, Thread: 1, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
24.628 sec, Thread: 2, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
21.588 sec, Thread: 3, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
33.865 sec, Thread: 8, Class: org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
281.324 sec, Thread: 5, Class: org.apache.zookeeper.test.ReconfigTest
[junit] Tests run: 104, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
531.137 sec, Thread: 7, Class: org.apache.zookeeper.test.NettyNettySuiteTest
[junit] 

[GitHub] zookeeper pull request #451: ZOOKEEPER-2184: Zookeeper Client should re-reso...

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/451#discussion_r191252989
  
--- Diff: src/java/test/org/apache/zookeeper/test/ClientPortBindTest.java 
---
@@ -102,9 +102,9 @@ public void testBindByAddress() throws Exception {
 startSignal = new CountDownLatch(1);
 ZooKeeper zk = new ZooKeeper(HOSTPORT, CONNECTION_TIMEOUT, this);
 try {
-startSignal.await(CONNECTION_TIMEOUT,
--- End diff --

Sure, I agree. I think that was a suggestion from @afine and it's 
completely reasonable.


---

[GitHub] zookeeper pull request #451: ZOOKEEPER-2184: Zookeeper Client should re-reso...

[anmolnar]

Github user anmolnar closed the pull request at:

https://github.com/apache/zookeeper/pull/451


---

[GitHub] zookeeper issue #451: ZOOKEEPER-2184: Zookeeper Client should re-resolve hos...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/451
  
Thanks @hanm 


---

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492825#comment-16492825
 ] 

Michael Han commented on ZOOKEEPER-2184:


Patch committed to branch-3.4 as 
[https://github.com/apache/zookeeper/commit/2e26c8836edc800c60b204a1d3da0285edb415d6]

This Jira will be resolved after the patch is ported to branch-3.5 and master.

> Zookeeper Client should re-resolve hosts when connection attempts fail
> --
>
> Key: ZOOKEEPER-2184
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2184
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6, 3.4.7, 3.4.8, 3.4.9, 3.4.10, 3.5.0, 3.5.1, 3.5.2, 
> 3.5.3, 3.4.11
> Environment: Ubuntu 14.04 host, Docker containers for Zookeeper & 
> Kafka
>Reporter: Robert P. Thille
>Assignee: Andor Molnar
>Priority: Blocker
>  Labels: easyfix, patch, pull-request-available
> Attachments: ZOOKEEPER-2184.patch
>
>  Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> Testing in a Docker environment with a single Kafka instance using a single 
> Zookeeper instance. Restarting the Zookeeper container will cause it to 
> receive a new IP address. Kafka will never be able to reconnect to Zookeeper 
> and will hang indefinitely. Updating DNS or /etc/hosts with the new IP 
> address will not help the client to reconnect as the 
> zookeeper/client/StaticHostProvider resolves the connection string hosts at 
> creation time and never re-resolves.
> A solution would be for the client to notice that connection attempts fail 
> and attempt to re-resolve the hostnames in the connectString.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #451: ZOOKEEPER-2184: Zookeeper Client should re-resolve hos...

[hanm]

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/451
  
Committed to branch-3.4. Please close the pull request @anmolnar.

Please port it to branch-3.5 and master (if you like :-), and create 
necessary JIRAs for auxiliary tasks (documentation update, etc). 


---

[jira] [Updated] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han updated ZOOKEEPER-2184:
---
Fix Version/s: (was: 3.5.5)
   (was: 3.4.13)

> Zookeeper Client should re-resolve hosts when connection attempts fail
> --
>
> Key: ZOOKEEPER-2184
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2184
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6, 3.4.7, 3.4.8, 3.4.9, 3.4.10, 3.5.0, 3.5.1, 3.5.2, 
> 3.5.3, 3.4.11
> Environment: Ubuntu 14.04 host, Docker containers for Zookeeper & 
> Kafka
>Reporter: Robert P. Thille
>Assignee: Andor Molnar
>Priority: Blocker
>  Labels: easyfix, patch, pull-request-available
> Attachments: ZOOKEEPER-2184.patch
>
>  Time Spent: 4h
>  Remaining Estimate: 0h
>
> Testing in a Docker environment with a single Kafka instance using a single 
> Zookeeper instance. Restarting the Zookeeper container will cause it to 
> receive a new IP address. Kafka will never be able to reconnect to Zookeeper 
> and will hang indefinitely. Updating DNS or /etc/hosts with the new IP 
> address will not help the client to reconnect as the 
> zookeeper/client/StaticHostProvider resolves the connection string hosts at 
> creation time and never re-resolves.
> A solution would be for the client to notice that connection attempts fail 
> and attempt to re-resolve the hostnames in the connectString.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #451: ZOOKEEPER-2184: Zookeeper Client should re-reso...

[hanm]

Github user hanm commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/451#discussion_r191243666
  
--- Diff: src/java/test/org/apache/zookeeper/test/ClientPortBindTest.java 
---
@@ -102,9 +102,9 @@ public void testBindByAddress() throws Exception {
 startSignal = new CountDownLatch(1);
 ZooKeeper zk = new ZooKeeper(HOSTPORT, CONNECTION_TIMEOUT, this);
 try {
-startSignal.await(CONNECTION_TIMEOUT,
--- End diff --

The change in this file sounds not related to this patch. Usually we tend 
to limit changes only relevant to a patch. Similar for the change in 
ReadOnlyModeTest file. It's fine in this case as both changes are small and are 
good improvements.


---

[GitHub] zookeeper pull request #451: ZOOKEEPER-2184: Zookeeper Client should re-reso...

[hanm]

Github user hanm commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/451#discussion_r191242849
  
--- Diff: src/java/main/org/apache/zookeeper/client/HostProvider.java ---
@@ -21,6 +21,7 @@
 import org.apache.yetus.audience.InterfaceAudience;
 
 import java.net.InetSocketAddress;
+import java.net.UnknownHostException;
--- End diff --

This import is not used, we can remove it.


---

Success: ZOOKEEPER- PreCommit Build #1764

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1764/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 40.34 MB...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 15 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1764//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1764//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1764//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16492734 added to ZOOKEEPER-3019.
 [exec] Session logged out. Session was 
JSESSIONID=E5E0E55602B43A25C700F610C0A3D0FC.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 46 minutes 45 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3019
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492734#comment-16492734
 ] 

Hadoop QA commented on ZOOKEEPER-3019:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 15 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1764//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1764//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1764//console

This message is automatically generated.

> Add a metric to track number of slow fsyncs
> ---
>
> Key: ZOOKEEPER-3019
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3019
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: jmx, server
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
> Fix For: 3.6.0, 3.4.13, 3.5.5
>
>
> Add jmx bean and Command to ZooKeeper server to expose the the number of slow 
> fsyncs as a metric.
> FileTxnLog.commit() should count the number of times fsync exceeds 
> fsyncWarningThresholdMS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/307#discussion_r191213617
  
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -21,17 +21,33 @@
 
 
 import org.apache.zookeeper.common.Time;
+import org.apache.zookeeper.server.quorum.QuorumPeerConfig;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Timer;
+import java.util.TimerTask;
+import java.util.concurrent.atomic.AtomicReference;
 
 /**
  * Basic Server Statistics
  */
 public class ServerStats {
+private static final Logger LOG = 
LoggerFactory.getLogger(ServerStats.class);
+
 private long packetsSent;
 private long packetsReceived;
 private long maxLatency;
 private long minLatency = Long.MAX_VALUE;
 private long totalLatency = 0;
 private long count = 0;
+private long numRequestsAboveThresholdTime = 0;
+
+final static long requestWarnThresholdMs = 
QuorumPeerConfig.getRequestWarnResponseThresholdMs();
+final static Timer timer = new Timer();
--- End diff --

And this field should be `private` too.


---

[GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/307#discussion_r191202289
  
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -117,6 +138,11 @@ public String toString(){
 sb.append("Mode: " + getServerState() + "\n");
 return sb.toString();
 }
+
+synchronized void incNumRequestsAboveThresholdTime() {
+numRequestsAboveThresholdTime++;
--- End diff --

Again, change the field to `AtomicLong` and you don't need to sync here.


---

[GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/307#discussion_r191204646
  
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -148,9 +174,46 @@ synchronized public void resetRequestCounters(){
 packetsReceived = 0;
 packetsSent = 0;
 }
+synchronized public void resetNumRequestsAboveThresholdTime() {
+numRequestsAboveThresholdTime = 0;
+}
 synchronized public void reset() {
 resetLatency();
 resetRequestCounters();
+resetNumRequestsAboveThresholdTime();
+}
+
+public void checkLatency(final ZooKeeperServer zks, Request request) {
+long requestLatency = Time.currentElapsedTime() - 
request.createTime;
+boolean enabledAndAboveThreshold = (requestWarnThresholdMs == 0) ||
+(requestWarnThresholdMs > -1 && requestLatency > 
requestWarnThresholdMs);
+if (enabledAndAboveThreshold) {
+zks.serverStats().incNumRequestsAboveThresholdTime();
+
+// Try acquiring lock only if not waiting
+boolean success = 
waitForLoggingWarnThresholdMsg.compareAndSet(Boolean.FALSE, Boolean.TRUE);
+if (success) {
+LOG.warn("Request {} exceeded threshold. Took {} ms", 
request, requestLatency);
+startCount = 
zks.serverStats().getNumRequestsAboveThresholdTime();
+timer.schedule(new TimerTask() {
+@Override
+public void run() {
+long count = 
zks.serverStats().getNumRequestsAboveThresholdTime() - startCount;
--- End diff --

> it is fine to say that 0 requests had longer times since the last bad 
request was logged. The total count can be seen using stat at any point of 
time. What do you suggest?

Makes sense to me. What do you think of _not_ logging anything in the task 
if actual counter equals to `startCount`?

As I stated above, please use `ScheduledExecutorService` here.


---

[GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/307#discussion_r191202605
  
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -148,9 +174,46 @@ synchronized public void resetRequestCounters(){
 packetsReceived = 0;
 packetsSent = 0;
 }
+synchronized public void resetNumRequestsAboveThresholdTime() {
+numRequestsAboveThresholdTime = 0;
+}
 synchronized public void reset() {
 resetLatency();
 resetRequestCounters();
+resetNumRequestsAboveThresholdTime();
+}
+
+public void checkLatency(final ZooKeeperServer zks, Request request) {
--- End diff --

IMO, this method could be private and called from `updateLatency()`. 
Basically you don't want to miss any latency update calls, hence it makes sense 
to put the call there. Any objections?


---

[GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/307#discussion_r191199501
  
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -21,17 +21,33 @@
 
 
 import org.apache.zookeeper.common.Time;
+import org.apache.zookeeper.server.quorum.QuorumPeerConfig;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Timer;
+import java.util.TimerTask;
+import java.util.concurrent.atomic.AtomicReference;
 
 /**
  * Basic Server Statistics
  */
 public class ServerStats {
+private static final Logger LOG = 
LoggerFactory.getLogger(ServerStats.class);
+
 private long packetsSent;
 private long packetsReceived;
 private long maxLatency;
 private long minLatency = Long.MAX_VALUE;
 private long totalLatency = 0;
 private long count = 0;
+private long numRequestsAboveThresholdTime = 0;
--- End diff --

You can use `AtomicLong` instead of acquiring class-level lock to access 
this.


---

[GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/307#discussion_r191215183
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/HighLatencyRequestLoggingTest.java ---
@@ -0,0 +1,285 @@
+package org.apache.zookeeper.server;
+
+import org.apache.log4j.AppenderSkeleton;
+import org.apache.log4j.LogManager;
+import org.apache.log4j.spi.LoggingEvent;
+import org.apache.zookeeper.CreateMode;
+import org.apache.zookeeper.KeeperException;
+import org.apache.zookeeper.PortAssignment;
+import org.apache.zookeeper.WatchedEvent;
+import org.apache.zookeeper.Watcher;
+import org.apache.zookeeper.ZKTestCase;
+import org.apache.zookeeper.ZooDefs;
+import org.apache.zookeeper.ZooKeeper;
+import org.apache.zookeeper.test.ClientBase;
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.runners.MockitoJUnitRunner;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import static org.apache.zookeeper.test.ClientBase.CONNECTION_TIMEOUT;
+
+@RunWith(MockitoJUnitRunner.class)
+public class HighLatencyRequestLoggingTest extends ZKTestCase implements 
Watcher {
+
+private TestAppender testAppender = new TestAppender();
+
+@Before
+public void setup() {
+LogManager.getLogger(ServerStats.class).addAppender(testAppender);
+}
+
+@After
+public void tearDown() {
+
LogManager.getLogger(ServerStats.class).removeAppender(testAppender);
+}
+
+class TestAppender extends AppenderSkeleton {
+private List messages = new ArrayList();
+
+@Override
+protected void append(LoggingEvent loggingEvent) {
+
+}
+
+@Override
+public void close() {
+
+}
+
+public void doAppend(LoggingEvent event) {
+synchronized (messages) {
+messages.add(event.getMessage().toString());
+}
+}
+
+@Override
+public boolean requiresLayout() {
+return false;
+}
+
+public List getMessages() {
+return messages;
+}
+}
+
+// Test Class to create ZNodes at the specified path and check them
+class ZNodeCreator implements Runnable {
+
+ZooKeeper zk;
+int startNum;
+int totalNum;
+
+ZNodeCreator(ZooKeeper zk, int startNum, int totalNum) {
+this.zk = zk;
+this.startNum = startNum;
+this.totalNum = totalNum;
+}
+
+@Override
+public void run() {
+for(int i = startNum; i < startNum + totalNum; i++) {
+try {
+zk.create("/foo" + i, ("foobar" +  i).getBytes(), 
ZooDefs.Ids.OPEN_ACL_UNSAFE,
+CreateMode.PERSISTENT);
+Assert.assertEquals(new String(zk.getData("/foo" + i, 
null, null)), "foobar" + i);
+} catch (Exception e) {
+Assert.fail("Failed to create ZNode. Exiting test.");
+}
+}
+}
+}
+
+// Basic test that verifies total number of requests above threshold 
time
+@Test
+public void testRequestWarningThreshold() throws IOException, 
KeeperException, InterruptedException {
+ClientBase.setupTestEnv();
+
+final int CLIENT_PORT = PortAssignment.unique();
+
+ZooKeeperServerMainTest.MainThread main =
+new ZooKeeperServerMainTest.MainThread(CLIENT_PORT, true, 
null, 0);
+main.start();
+
+Assert.assertTrue("waiting for server being up",
+ClientBase.waitForServerUp("127.0.0.1:" + CLIENT_PORT,
+CONNECTION_TIMEOUT));
+// Get the stats object from the ZooKeeperServer to keep track of 
high latency requests.
+ServerStats stats = main.main.getServerStats();
+stats.setWaitForLoggingWarnThresholdMsgToFalse();
+stats.setDelayTimeForLoggingWarnThresholdMsg(1000);
+
+ZooKeeper zk = new ZooKeeper("127.0.0.1:" + CLIENT_PORT,
+ClientBase.CONNECTION_TIMEOUT, (Watcher) this);
+
+zk.create("/foo1", "fb".getBytes(), ZooDefs.Ids.OPEN_ACL_UNSAFE,
+CreateMode.PERSISTENT);
+
+Assert.assertEquals(new String(zk.getData("/foo1", null, null)), 
"fb");
+
+

[GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/307#discussion_r191204982
  
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -148,9 +174,46 @@ synchronized public void resetRequestCounters(){
 packetsReceived = 0;
 packetsSent = 0;
 }
+synchronized public void resetNumRequestsAboveThresholdTime() {
+numRequestsAboveThresholdTime = 0;
+}
 synchronized public void reset() {
 resetLatency();
 resetRequestCounters();
+resetNumRequestsAboveThresholdTime();
+}
+
+public void checkLatency(final ZooKeeperServer zks, Request request) {
+long requestLatency = Time.currentElapsedTime() - 
request.createTime;
+boolean enabledAndAboveThreshold = (requestWarnThresholdMs == 0) ||
+(requestWarnThresholdMs > -1 && requestLatency > 
requestWarnThresholdMs);
+if (enabledAndAboveThreshold) {
+zks.serverStats().incNumRequestsAboveThresholdTime();
+
+// Try acquiring lock only if not waiting
+boolean success = 
waitForLoggingWarnThresholdMsg.compareAndSet(Boolean.FALSE, Boolean.TRUE);
+if (success) {
+LOG.warn("Request {} exceeded threshold. Took {} ms", 
request, requestLatency);
+startCount = 
zks.serverStats().getNumRequestsAboveThresholdTime();
+timer.schedule(new TimerTask() {
+@Override
+public void run() {
+long count = 
zks.serverStats().getNumRequestsAboveThresholdTime() - startCount;
+LOG.warn("Number of requests that exceeded {} ms 
in past {} ms: {}",
+requestWarnThresholdMs, 
delayTimeForLoggingWarnThresholdMsg, count);
+waitForLoggingWarnThresholdMsg.set(Boolean.FALSE);
+}
+}, delayTimeForLoggingWarnThresholdMsg);
+}
+}
+}
+
+public void setDelayTimeForLoggingWarnThresholdMsg(int delay) {
+this.delayTimeForLoggingWarnThresholdMsg = delay;
+}
+
+public void setWaitForLoggingWarnThresholdMsgToFalse() {
--- End diff --

This one should be `package-private` too. Same comment applies here too.


---

[GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/307#discussion_r191199674
  
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -21,17 +21,33 @@
 
 
 import org.apache.zookeeper.common.Time;
+import org.apache.zookeeper.server.quorum.QuorumPeerConfig;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Timer;
+import java.util.TimerTask;
+import java.util.concurrent.atomic.AtomicReference;
 
 /**
  * Basic Server Statistics
  */
 public class ServerStats {
+private static final Logger LOG = 
LoggerFactory.getLogger(ServerStats.class);
+
 private long packetsSent;
 private long packetsReceived;
 private long maxLatency;
 private long minLatency = Long.MAX_VALUE;
 private long totalLatency = 0;
 private long count = 0;
+private long numRequestsAboveThresholdTime = 0;
+
+final static long requestWarnThresholdMs = 
QuorumPeerConfig.getRequestWarnResponseThresholdMs();
+final static Timer timer = new Timer();
--- End diff --

Have you considered using `ScheduledExecutorService` instead?

https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ScheduledExecutorService.html


---

[GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/307#discussion_r191213705
  
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -21,17 +21,33 @@
 
 
 import org.apache.zookeeper.common.Time;
+import org.apache.zookeeper.server.quorum.QuorumPeerConfig;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Timer;
+import java.util.TimerTask;
+import java.util.concurrent.atomic.AtomicReference;
 
 /**
  * Basic Server Statistics
  */
 public class ServerStats {
+private static final Logger LOG = 
LoggerFactory.getLogger(ServerStats.class);
+
 private long packetsSent;
 private long packetsReceived;
 private long maxLatency;
 private long minLatency = Long.MAX_VALUE;
 private long totalLatency = 0;
 private long count = 0;
+private long numRequestsAboveThresholdTime = 0;
+
+final static long requestWarnThresholdMs = 
QuorumPeerConfig.getRequestWarnResponseThresholdMs();
--- End diff --

Would you please make it `private`?


---

[GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/307#discussion_r191203530
  
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -148,9 +174,46 @@ synchronized public void resetRequestCounters(){
 packetsReceived = 0;
 packetsSent = 0;
 }
+synchronized public void resetNumRequestsAboveThresholdTime() {
+numRequestsAboveThresholdTime = 0;
+}
 synchronized public void reset() {
 resetLatency();
 resetRequestCounters();
+resetNumRequestsAboveThresholdTime();
+}
+
+public void checkLatency(final ZooKeeperServer zks, Request request) {
+long requestLatency = Time.currentElapsedTime() - 
request.createTime;
+boolean enabledAndAboveThreshold = (requestWarnThresholdMs == 0) ||
+(requestWarnThresholdMs > -1 && requestLatency > 
requestWarnThresholdMs);
--- End diff --

I think that makes sense.


---

[GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/307#discussion_r191201829
  
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -106,6 +126,7 @@ public String toString(){
 StringBuilder sb = new StringBuilder();
 sb.append("Latency min/avg/max: " + getMinLatency() + "/"
 + getAvgLatency() + "/" + getMaxLatency() + "\n");
+sb.append("Num Requests that exceeded threshold latency: " + 
getNumRequestsAboveThresholdTime() + "\n");
--- End diff --

This is going to be printed in `stat` 4lw command which makes things a 
little bit complicated.

- what's the target branch/version of this patch? As we're in the middle of 
3.5 stabilisation, I would suggest to target this trunk/3.6-only. Please let me 
know if you've concerns and please update the Jira fix version accordingly.
- Output of 4lw commands are parsed by machines occasionally, so adding new 
fields in the middle of the ouput would potentially brake backward 
compatibility. Adding them to the end of the output could be cumbersome in this 
case, but:
- 4LWs have some security flaws and we should decommission them in the 
upcoming ZooKeeper versions in favour of JMX and Jetty interfaces,
- I recommend not adding the new metric here, but expose it via JMX and 
Jetty `stat` and `monitor` commands.



---

[GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/307#discussion_r191213569
  
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -21,17 +21,33 @@
 
 
 import org.apache.zookeeper.common.Time;
+import org.apache.zookeeper.server.quorum.QuorumPeerConfig;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Timer;
+import java.util.TimerTask;
+import java.util.concurrent.atomic.AtomicReference;
 
 /**
  * Basic Server Statistics
  */
 public class ServerStats {
+private static final Logger LOG = 
LoggerFactory.getLogger(ServerStats.class);
+
 private long packetsSent;
 private long packetsReceived;
 private long maxLatency;
 private long minLatency = Long.MAX_VALUE;
 private long totalLatency = 0;
 private long count = 0;
+private long numRequestsAboveThresholdTime = 0;
--- End diff --

Also make it `private` please.


---

[GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/307#discussion_r191204931
  
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -148,9 +174,46 @@ synchronized public void resetRequestCounters(){
 packetsReceived = 0;
 packetsSent = 0;
 }
+synchronized public void resetNumRequestsAboveThresholdTime() {
+numRequestsAboveThresholdTime = 0;
+}
 synchronized public void reset() {
 resetLatency();
 resetRequestCounters();
+resetNumRequestsAboveThresholdTime();
+}
+
+public void checkLatency(final ZooKeeperServer zks, Request request) {
+long requestLatency = Time.currentElapsedTime() - 
request.createTime;
+boolean enabledAndAboveThreshold = (requestWarnThresholdMs == 0) ||
+(requestWarnThresholdMs > -1 && requestLatency > 
requestWarnThresholdMs);
+if (enabledAndAboveThreshold) {
+zks.serverStats().incNumRequestsAboveThresholdTime();
+
+// Try acquiring lock only if not waiting
+boolean success = 
waitForLoggingWarnThresholdMsg.compareAndSet(Boolean.FALSE, Boolean.TRUE);
+if (success) {
+LOG.warn("Request {} exceeded threshold. Took {} ms", 
request, requestLatency);
+startCount = 
zks.serverStats().getNumRequestsAboveThresholdTime();
+timer.schedule(new TimerTask() {
+@Override
+public void run() {
+long count = 
zks.serverStats().getNumRequestsAboveThresholdTime() - startCount;
+LOG.warn("Number of requests that exceeded {} ms 
in past {} ms: {}",
+requestWarnThresholdMs, 
delayTimeForLoggingWarnThresholdMsg, count);
+waitForLoggingWarnThresholdMsg.set(Boolean.FALSE);
+}
+}, delayTimeForLoggingWarnThresholdMsg);
+}
+}
+}
+
+public void setDelayTimeForLoggingWarnThresholdMsg(int delay) {
+this.delayTimeForLoggingWarnThresholdMsg = delay;
--- End diff --

Please make this method `package-private`.
Also it would be great to have a javadoc comment that the method is for 
testing purposes only.


---

[GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/307#discussion_r191205970
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
@@ -61,6 +61,7 @@
 
 private static boolean standaloneEnabled = true;
 private static boolean reconfigEnabled = false;
+private static int requestWarnThresholdMs = 1;
--- End diff --

@karanmehta93 This feature sounds to me some kind of debugging / verbose 
monitoring feature which should generally be turned off by default. If @hanm 
feels the same, I'll second that.

However, if you want to implement a feature switch to this - which I think 
would be awesome - use a dedicated bool config instead of some extraordinary 
threshold value. 


---

Failed: ZOOKEEPER- PreCommit Build #1761

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1761/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 40.61 MB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1761//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1761//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1761//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16492718 added to ZOOKEEPER-3019.
 [exec] Session logged out. Session was 
JSESSIONID=22FB73957C7B3143D05F9C49983C3E92.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1826:
 exec returned: 1

Total time: 40 minutes 59 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3019
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderOutOfView

Error Message:
null

Stack Trace:
junit.framework.AssertionFailedError
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderOutOfView(QuorumPeerMainTest.java:1305)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55)

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492718#comment-16492718
 ] 

Hadoop QA commented on ZOOKEEPER-3019:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 15 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1761//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1761//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1761//console

This message is automatically generated.

> Add a metric to track number of slow fsyncs
> ---
>
> Key: ZOOKEEPER-3019
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3019
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: jmx, server
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
> Fix For: 3.6.0, 3.4.13, 3.5.5
>
>
> Add jmx bean and Command to ZooKeeper server to expose the the number of slow 
> fsyncs as a metric.
> FileTxnLog.commit() should count the number of times fsync exceeds 
> fsyncWarningThresholdMS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Success: ZOOKEEPER- PreCommit Build #1760

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1760/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 85.48 MB...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 9 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1760//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1760//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1760//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16492684 added to ZOOKEEPER-3019.
 [exec] Session logged out. Session was 
JSESSIONID=DB2374364698E5E06BAA1C9E234393D1.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 20 minutes 28 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3019
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492684#comment-16492684
 ] 

Hadoop QA commented on ZOOKEEPER-3019:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 9 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1760//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1760//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1760//console

This message is automatically generated.

> Add a metric to track number of slow fsyncs
> ---
>
> Key: ZOOKEEPER-3019
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3019
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: jmx, server
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
> Fix For: 3.6.0, 3.4.13, 3.5.5
>
>
> Add jmx bean and Command to ZooKeeper server to expose the the number of slow 
> fsyncs as a metric.
> FileTxnLog.commit() should count the number of times fsync exceeds 
> fsyncWarningThresholdMS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: ZOOKEEPER- PreCommit Build #1763

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1763/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 6.56 KB...]
 [exec] 
 [exec] Pull request title: ZOOKEEPER-3019 add metric for slow fsyncs count
 [exec] Defect number: ZOOKEEPER-3019
 [exec] - Parsed args, going to checkout -
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec]  Dload  Upload   Total   Spent
Left  SpeedTesting patch for pull request 510.
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec]   0 00 00 0  0  0 --:--:-- --:--:-- 
--:--:-- 0100   1410   1410 0375  0 --:--:-- --:--:-- 
--:--:--   376
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec]  Pre-build trunk to verify trunk stability and javac warnings
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] /home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant  
-Djavac.args=-Xlint -Xmaxwarns 1000 
-Djava5.home=/home/jenkins/tools/java5/latest/ 
-Dforrest.home=/home/jenkins/tools/forrest/latest/ -DZookeeperPatchProcess= 
clean tar > 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess/trunkJavacWarnings.txt
 2>&1
 [exec] Trunk compilation is broken?
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 100 254100 254100 0  30542  0 --:--:-- --:--:-- 
--:--:-- 30542mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1794:
 exec returned: 1

Total time: 15 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3019
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

Failed: ZOOKEEPER- PreCommit Build #1762

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1762/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 6.56 KB...]
 [exec] 
 [exec] Pull request title: ZOOKEEPER-3019 add metric for slow fsyncs count
 [exec]  Dload  Upload   Total   Spent
Left  SpeedDefect number: ZOOKEEPER-3019
 [exec] 
 [exec] 
 [exec] - Parsed args, going to checkout -
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Testing patch for pull request 510.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec]   0 00 00 0  0  0 --:--:-- --:--:-- 
--:--:-- 0  0 00 00 0  0  0 --:--:-- --:--:-- 
--:--:-- 0100   1410   1410 0410  0 --:--:-- --:--:-- 
--:--:--   409
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec]  Pre-build trunk to verify trunk stability and javac warnings
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] /home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant  
-Djavac.args=-Xlint -Xmaxwarns 1000 
-Djava5.home=/home/jenkins/tools/java5/latest/ 
-Dforrest.home=/home/jenkins/tools/forrest/latest/ -DZookeeperPatchProcess= 
clean tar > 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess/trunkJavacWarnings.txt
 2>&1
 [exec] Trunk compilation is broken?
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 100 282730 282730 0  31049  0 --:--:-- --:--:-- 
--:--:-- 31049mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1794:
 exec returned: 1

Total time: 17 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3019
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

ZooKeeper_branch35_jdk8 - Build # 982 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/982/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 61.28 KB...]
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.529 sec, Thread: 6, Class: 
org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Running org.apache.zookeeper.test.SaslSuperUserTest in thread 7
[junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 2
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
6
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.651 sec, Thread: 7, Class: org.apache.zookeeper.test.SaslSuperUserTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.593 sec, Thread: 6, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 7
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 6
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.873 sec, Thread: 6, Class: org.apache.zookeeper.test.SessionTimeoutTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
6
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.39 sec, Thread: 2, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.08 sec, Thread: 6, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 6
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 2
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.575 sec, Thread: 2, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 2
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.381 sec, Thread: 2, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 2
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.816 sec, Thread: 2, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.072 sec, Thread: 2, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 2
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
12.972 sec, Thread: 7, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 7
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.656 sec, Thread: 2, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 2
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
71.038 sec, Thread: 3, Class: org.apache.zookeeper.test.QuorumZxidSyncTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
6.222 sec, Thread: 7, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 7
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.073 sec, Thread: 7, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 3
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 7
[junit] Tests run: 14, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 
81.422 sec, Thread: 4, Class: org.apache.zookeeper.test.QuorumTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.099 sec, Thread: 3, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 4
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 3
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.083 sec, Thread: 4, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
19.789 sec, Thread: 6, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 4
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.713 sec, Thread: 4, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
13.142 sec, Thread: 3, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492555#comment-16492555
 ] 

Hadoop QA commented on ZOOKEEPER-2184:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 9 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1759//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1759//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1759//console

This message is automatically generated.

> Zookeeper Client should re-resolve hosts when connection attempts fail
> --
>
> Key: ZOOKEEPER-2184
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2184
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6, 3.4.7, 3.4.8, 3.4.9, 3.4.10, 3.5.0, 3.5.1, 3.5.2, 
> 3.5.3, 3.4.11
> Environment: Ubuntu 14.04 host, Docker containers for Zookeeper & 
> Kafka
>Reporter: Robert P. Thille
>Assignee: Andor Molnar
>Priority: Blocker
>  Labels: easyfix, patch, pull-request-available
> Fix For: 3.4.13, 3.5.5
>
> Attachments: ZOOKEEPER-2184.patch
>
>  Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> Testing in a Docker environment with a single Kafka instance using a single 
> Zookeeper instance. Restarting the Zookeeper container will cause it to 
> receive a new IP address. Kafka will never be able to reconnect to Zookeeper 
> and will hang indefinitely. Updating DNS or /etc/hosts with the new IP 
> address will not help the client to reconnect as the 
> zookeeper/client/StaticHostProvider resolves the connection string hosts at 
> creation time and never re-resolves.
> A solution would be for the client to notice that connection attempts fail 
> and attempt to re-resolve the hostnames in the connectString.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #451: ZOOKEEPER-2184: Zookeeper Client should re-resolve hos...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/451
  
@hanm I updated the pull request according to your suggestions. Please take 
a look.
I also updated javadoc accordingly. ZooKeeper docs could be updated in a 
separate PR as suggested.


---

Re: Maven migration doc - thoughts and suggestions

[Andor Molnar]

Excellent job Norbert, this doc will be very useful to discuss all kinds of
aspects of the migration.
I've left some comments already.

Thanks,
Andor



On Fri, May 25, 2018 at 3:14 PM, Norbert Kalmar 
wrote:

> Hi,
>
> After doing some proof of work and had some discussion, I have created a
> google docs about the maven migration.
>
> Please read through, and comment your thoughts and suggestions.
>
> https://docs.google.com/document/d/1WXqhaPlCwchcWc8RCEzbCmVa4WbBD
> lfR3GQngikGjqc/edit?usp=sharing
>
>
> Thanks!
> Norbert
>