[GitHub] zookeeper issue #590: [ZOOKEEPER-1177] Add the memory optimized watch manage...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/590 This is going to be a huge improvement for Accumulo for example that is a heavy user of watchers. I'm going to allocate some capacity to review these new patches. ---
[GitHub] zookeeper pull request #592: ZOOKEEPER-3112: fix fd leak due to UnresolvedAd...
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/592#discussion_r208814126
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java ---
@@ -280,10 +281,14 @@ void registerAndConnect(SocketChannel sock,
InetSocketAddress addr)
@Override
void connect(InetSocketAddress addr) throws IOException {
+// if UnresolvedAddressException throw on connect and it would
leak a SocketChannelImpl in cancelledKeys EVERY time.
+// it's hard to deal all situations on socks.cancel,
+// while an easy way is, ensure DNS resolve successful before
register channel.
+InetAddress.getByName(addr.getHostName());
--- End diff --
Can you help me understand why sock.close won't clean up the fd?
If we have to check before register, I would suggest to use explicit check
here, like:
if (addr.isUnresolved()) {
throw new UnresolvedAddressException();
}
---
[jira] [Commented] (ZOOKEEPER-3116) Make the DataTree.approximateDataSize more efficient
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574305#comment-16574305 ] Hadoop QA commented on ZOOKEEPER-3116: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2040//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2040//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2040//console This message is automatically generated. > Make the DataTree.approximateDataSize more efficient > > > Key: ZOOKEEPER-3116 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3116 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The approximateDataSize is a nice metric to show what's the total size stored > in ZooKeeper ensemble over time, but it's expensive to query too often, since > each query will go through all the nodes to calculate the total size. > It's better to use a counter to record the total data size when txns applied > to the DataTree, which is cheaper. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Failed: ZOOKEEPER- PreCommit Build #2040
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2040/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 84.79 MB...] [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2040//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2040//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2040//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment with id 16574305 added to ZOOKEEPER-3116. [exec] Session logged out. Session was JSESSIONID=CEEE02876E1954722FC0D9E48350A36A. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1822: exec returned: 1 Total time: 23 minutes 23 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-3116 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## All tests passed
[GitHub] zookeeper issue #582: ZOOKEEPER-3103 Pluggable metrics system for ZooKeeper ...
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/582 +1 Thanks @eolivelli. The new change looks good to me. ---
[jira] [Updated] (ZOOKEEPER-3116) Make the DataTree.approximateDataSize more efficient
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3116: -- Labels: pull-request-available (was: ) > Make the DataTree.approximateDataSize more efficient > > > Key: ZOOKEEPER-3116 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3116 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > > The approximateDataSize is a nice metric to show what's the total size stored > in ZooKeeper ensemble over time, but it's expensive to query too often, since > each query will go through all the nodes to calculate the total size. > It's better to use a counter to record the total data size when txns applied > to the DataTree, which is cheaper. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper pull request #594: [ZOOKEEPER-3116] Make the DataTree.approximateD...
GitHub user lvfangmin opened a pull request: https://github.com/apache/zookeeper/pull/594 [ZOOKEEPER-3116] Make the DataTree.approximateDataSize more efficient Cache the approximate data tree size, and update it when txns applied to data tree, this could make this query not that expensive. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lvfangmin/zookeeper ZOOKEEPER-3116 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/594.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #594 commit 21243f5effc23e68c57f9be93558ddb006e5f504 Author: Fangmin Lyu Date: 2018-08-09T04:51:55Z cache the approximate data size in DataTree ---
[jira] [Created] (ZOOKEEPER-3116) Make the DataTree.approximateDataSize more efficient
Fangmin Lv created ZOOKEEPER-3116: - Summary: Make the DataTree.approximateDataSize more efficient Key: ZOOKEEPER-3116 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3116 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: Fangmin Lv Assignee: Fangmin Lv Fix For: 3.6.0 The approximateDataSize is a nice metric to show what's the total size stored in ZooKeeper ensemble over time, but it's expensive to query too often, since each query will go through all the nodes to calculate the total size. It's better to use a counter to record the total data size when txns applied to the DataTree, which is cheaper. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper issue #584: ZOOKEEPER-3102: Potential race condition when create e...
Github user MichaelScofield commented on the issue:
https://github.com/apache/zookeeper/pull/584
@anmolnar Sorry for the late response. I think what @lvfangmin wants to put
here, is that `createNode()` is called in single thread, so the race condition
does not exist. **IF** there were multi-threaded call, a lot of codes would
have broken, including the `killSession()`.
However, the original code might have synchronized on a wrong `list`:
```
HashSet list = ephemerals.get(ephemeralOwner);
if (list == null) {
list = new HashSet();
ephemerals.put(ephemeralOwner, list);
}
// the "list" here is assumed to be contented, if it's created or altered
elsewhere
// (not bounded by the single-threaded guarantee), we might have
synchronized
// on a wrong object (that we just created).
synchronized (list) {
list.add(path);
}
```
I'm just trying to make the codes look more robust.
---
[GitHub] zookeeper pull request #560: ZOOKEEPER-3082: Fix server snapshot behavior wh...
Github user enixon commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/560#discussion_r208781421
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -399,8 +399,30 @@ public void save(DataTree dataTree,
File snapshotFile = new File(snapDir,
Util.makeSnapshotName(lastZxid));
LOG.info("Snapshotting: 0x{} to {}", Long.toHexString(lastZxid),
snapshotFile);
-snapLog.serialize(dataTree, sessionsWithTimeouts, snapshotFile,
syncSnap);
-
+try {
+snapLog.serialize(dataTree, sessionsWithTimeouts,
snapshotFile, syncSnap);
+} catch (IOException e) {
+if (snapshotFile.length() == 0) {
--- End diff --
Created https://issues.apache.org/jira/browse/ZOOKEEPER-3115 to record this
idea of deleting the snapshot file on general IOException's and we can continue
the conversation there.
---
[jira] [Created] (ZOOKEEPER-3115) Delete snapshot file on error
Brian Nixon created ZOOKEEPER-3115: -- Summary: Delete snapshot file on error Key: ZOOKEEPER-3115 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3115 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.6.0 Reporter: Brian Nixon ZOOKEEPER-3082 guards against one particular failure mode that can cause a corrupt snapshot, when a empty file is created with a valid snapshot file name. All other instances of IOException when writing the snapshot are simply allowed to propagate up the stack. One idea that came up during review ([https://github.com/apache/zookeeper/pull/560)] was whether we would ever want to leave a snapshot file on disk when an IOException is thrown. Clearly something has gone wrong at this point and rather than leave a potentially corrupt file, we can delete it and trust the transaction log when restoring the necessary transactions. It would be great to modify FileTxnSnapLog::save to delete snapshot files more often on exceptions - provided that there's a way to identify when the file in that case is needed or corrupt. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
ZooKeeper_branch34_jdk8 - Build # 1490 - Failure
See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/1490/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 40.42 KB...] [junit] Running org.apache.zookeeper.test.RepeatStartupTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.822 sec [junit] Running org.apache.zookeeper.test.RestoreCommittedLogTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.447 sec [junit] Running org.apache.zookeeper.test.SaslAuthDesignatedClientTest [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.73 sec [junit] Running org.apache.zookeeper.test.SaslAuthDesignatedServerTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.682 sec [junit] Running org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.129 sec [junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.665 sec [junit] Running org.apache.zookeeper.test.SaslAuthFailTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.771 sec [junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.623 sec [junit] Running org.apache.zookeeper.test.SaslClientTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.075 sec [junit] Running org.apache.zookeeper.test.SessionInvalidationTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.611 sec [junit] Running org.apache.zookeeper.test.SessionTest [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.871 sec [junit] Running org.apache.zookeeper.test.SessionTimeoutTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.742 sec [junit] Running org.apache.zookeeper.test.StandaloneTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.956 sec [junit] Running org.apache.zookeeper.test.StatTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.719 sec [junit] Running org.apache.zookeeper.test.StaticHostProviderTest [junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.741 sec [junit] Running org.apache.zookeeper.test.SyncCallTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.602 sec [junit] Running org.apache.zookeeper.test.TruncateTest [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.183 sec [junit] Running org.apache.zookeeper.test.UpgradeTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.948 sec [junit] Running org.apache.zookeeper.test.WatchedEventTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.094 sec [junit] Running org.apache.zookeeper.test.WatcherFuncTest [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.872 sec [junit] Running org.apache.zookeeper.test.WatcherTest [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 27.716 sec [junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.064 sec [junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.688 sec fail.build.on.test.failure: BUILD FAILED /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build.xml:1398: The following error occurred while executing this line: /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build.xml:1401: Tests failed! Total time: 29 minutes 10 seconds Build step 'Invoke Ant' marked build as failure Archiving artifacts Recording test results Email was triggered for: Failure - Any Sending email for trigger: Failure - Any ### ## FAILED TESTS (if any) ## 1 tests failed. FAILED: org.apache.zookeeper.SaslAuthTest.testZKOperationsAfterClientSaslAuthFailure Error Message: Did not connect Stack Trace: java.util.concurrent.TimeoutException: Did not connect at org.apache.zookeeper.test.ClientBase$CountdownWatcher.waitForConnected(ClientBase.java:152) at org.apache.zookeeper.SaslAuthTest.testZKOperationsAfterClientSaslAuthFailure(SaslAuthTest.java:174) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55)
[GitHub] zookeeper issue #590: [ZOOKEEPER-1177] Add the memory optimized watch manage...
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/590 There is a PR in the Jira few years ago, which uses BitMap as well, but it sacrificed the performance on triggering watches, this patch improved that and uses lazy clean up for cleaning those watchers who has closed the session. ---
[GitHub] zookeeper issue #590: [ZOOKEEPER-1177] Add the memory optimized watch manage...
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/590 Based on internal benchmark, this may save more than 95% memory usage on concentrate watches scenario. I'm working on adding some micro benchmark. In the original Jira, @phunt also added some basic test, which could show you some ideas about how much memory it's going to save. The current HashMap based watch manager uses lots of memory due to the overhead of storing each entry (32 Bytes for each entry), the object reference and the duplicated path strings. Use BitSet without revert index could reduce those overhead and make it more memory efficient. ---
[GitHub] zookeeper issue #567: ZOOKEEPER-3071: Add a config parameter to control tran...
Github user suyogmapara commented on the issue: https://github.com/apache/zookeeper/pull/567 @anmholnar Sorry I got caught up in other work, I will update this PR with the documents today. ---
[GitHub] zookeeper issue #581: ZOOKEEPER-3101: add reminder to ZOO_ERRORS
Github user sl4mmy commented on the issue: https://github.com/apache/zookeeper/pull/581 @anmolnar Done, and it passed. Thanks! ---
Success: ZOOKEEPER- PreCommit Build #2039
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2039/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.09 MB...] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +0 tests included. The patch appears to be a documentation patch that doesn't require tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2039//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2039//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2039//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment with id 16573504 added to ZOOKEEPER-3101. [exec] Session logged out. Session was JSESSIONID=9BC2868ADD56CFDF72E2E2E7D039C8E2. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD SUCCESSFUL Total time: 17 minutes 44 seconds Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-3101 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Success Sending email for trigger: Success Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-3101) Add comment reminding users to add cases to zerror when adding values to ZOO_ERRORS
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573504#comment-16573504 ] Hadoop QA commented on ZOOKEEPER-3101: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2039//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2039//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2039//console This message is automatically generated. > Add comment reminding users to add cases to zerror when adding values to > ZOO_ERRORS > --- > > Key: ZOOKEEPER-3101 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3101 > Project: ZooKeeper > Issue Type: Improvement >Reporter: Kent R. Spillner >Assignee: Kent R. Spillner >Priority: Trivial > Labels: pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > > Add a comment at the bottom of ZOO_ERRORS reminding people to add cases to > zerror when adding new error values (via > https://github.com/apache/zookeeper/pull/575#issuecomment-406356144) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper issue #590: [ZOOKEEPER-1177] Add the memory optimized watch manage...
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/590 @lvfangmin interesting.where can we find a benchmark which shows how this pr improves the memory? ---
[GitHub] zookeeper issue #584: ZOOKEEPER-3102: Potential race condition when create e...
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/584 sorry ,too embarrassed.I was wrong about my previous opinion. look at my thread-pool [unit test](https://github.com/maoling/zookeeper/blob/ZOOKEEPER-3102/src/java/test/org/apache/zookeeper/server/DataTreeTest.java#L326) ---
[GitHub] zookeeper issue #590: [ZOOKEEPER-1177] Add the memory optimized watch manage...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/590 @lvfangmin In which case you need to add exceptions to `config/findbugsExcludeFile.xml`. ---
zookeeper 3.4.12 c client doesnot work on solaris 11 machine
Hi team,
I compiled zookeeper 3.4.12 c client on solaris 11 machine and trying to test
it through cli.sh. Here is the sample code that I changed in cli.c. Whenever I
run the ./cli_mt file it always throws below error
2018-08-08 09:49:44,437:18000(0x2):ZOO_ERROR@handle_socket_error_msg@1670:
Socket [10.272.80.184:4831] zk retcode=-4, errno=0(Error 0): connect() call
failed. Anybody facing same issue?.
---
cli.c file
int main(int argc, char **argv) {
#ifndef THREADED
fd_set rfds, wfds, efds;
int processed=0;
#endif
char p[2048];
#ifdef YCA
char *cert=0;
char appId[64];
#endif
char buffer[4096];
int bufoff;
//FILE *fh;
struct Stat stat;
int buflen= sizeof(buffer);
int rc;
verbose = 0;
zoo_set_debug_level(ZOO_LOG_LEVEL_WARN);
zoo_deterministic_conn_order(1); // enable deterministic order
hostPort = argv[1];
printf("\n%s\n", "Lets connect");
zh = zookeeper_init("sld06hzt:4831", watcher, 3, &myid, 0, 0);
if (!zh) {
printf("\n%d\n", errno);
return errno;
}
strcpy(p,"sadmin:ldap");
zoo_add_auth(zh,"digest",p,strlen(p),0,0);
rc = zoo_get(zh, "/test", 0, buffer, &buflen, &stat);
if (rc)
{
printf("\n%s\n", buffer);
}
zookeeper_close(zh);
return 2;
}
Regards,
Ashwini.
[GitHub] zookeeper issue #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuthLearner...
Github user brettKK commented on the issue: https://github.com/apache/zookeeper/pull/496 @anmolnar , thanks for your attention, I will work on it on this weekend ---
Failed: ZOOKEEPER- PreCommit Build #2038
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2038/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 81.80 MB...] [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2038//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2038//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2038//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment with id 16573271 added to ZOOKEEPER-236. [exec] Session logged out. Session was JSESSIONID=63CF5D2753162491A439E6F0DD1A435F. [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1826: exec returned: 1 Total time: 14 minutes 54 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-236 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## 1 tests failed. FAILED: org.apache.zookeeper.ClientRequestTimeoutTest.testClientRequestTimeout Error Message: KeeperErrorCode = ConnectionLoss for /clientHang3 Stack Trace: org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /clientHang3 at org.apache.zookeeper.KeeperException.create(KeeperException.java:102) at org.apache.zookeeper.KeeperException.create(KeeperException.java:54) at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:1459) at org.apache.zookeeper.ClientRequestTimeoutTest.testClientRequestTimeout(ClientRequestTimeoutTest.java:100) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.lang.Thread.run(Thread.java:748)
[jira] [Commented] (ZOOKEEPER-236) SSL Support for Atomic Broadcast protocol
[ https://issues.apache.org/jira/browse/ZOOKEEPER-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573271#comment-16573271 ] Hadoop QA commented on ZOOKEEPER-236: - -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 48 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2038//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2038//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2038//console This message is automatically generated. > SSL Support for Atomic Broadcast protocol > - > > Key: ZOOKEEPER-236 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-236 > Project: ZooKeeper > Issue Type: New Feature > Components: quorum, security, server >Reporter: Benjamin Reed >Assignee: Andor Molnar >Priority: Major > Labels: pull-request-available, ssl > Time Spent: 11h 50m > Remaining Estimate: 0h > > We should have the ability to use SSL to authenticate and encrypt the traffic > between ZooKeeper servers. For the most part this is a very easy change. We > would probably only want to support this for TCP based leader elections. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper issue #528: ZOOKEEPER-3034 Facing issues while building from sourc...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/528 Btw. I think it's perfectly fine to choose option 2. I was able to build ZooKeeper C client and run the tests on Ubuntu 18.04 with CMake. ---
[GitHub] zookeeper issue #567: ZOOKEEPER-3071: Add a config parameter to control tran...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/567 I still miss the documentation change here and I think it would be better to commit it together with the code change, but I'm happy to approve it if you create a separate Jira for that. ---
[GitHub] zookeeper issue #567: ZOOKEEPER-3071: Add a config parameter to control tran...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/567 @suyogmapara Would you please trigger the Jenkins build? @maoling @breed Do approve this commit? ---
[GitHub] zookeeper issue #584: ZOOKEEPER-3102: Potential race condition when create e...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/584 @MichaelScofield Would you please respond to @lvfangmin 's comment? If this change doesn't make creating ephemerals thread-safe, there's no value in committing it. ---
[GitHub] zookeeper issue #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuthLearner...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/496 @brettKK Can we move on? @phunt Do you approve this change? ---
[GitHub] zookeeper issue #581: ZOOKEEPER-3101: add reminder to ZOO_ERRORS
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/581 @sl4mmy Would you please trigger another Jenkins build, so that we get a green one and I can commit. ---
[GitHub] zookeeper issue #528: ZOOKEEPER-3034 Facing issues while building from sourc...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/528 @phunt I ran a few cycles with the curl commit that you linked and here're my results: - there's no such thing with autotools that "check for a macro existence and use it if present", because macros must always be extracted even if they behind an if condition, - Curl circumvents this behaviour by directly calling commands like `pkg-config --libs MYLIB` instead of using the macro that package maintainer provides, - as a consequence we either can use the old AM_PATH_CPPUNIT macro or the new pkg-config macro, but not both. I'm not a fan of Curl approach: it runs custom code essentially which seems to me fragile. To make an end to this conversion I think we have 2 options. 1. Replace the old macro with the new one and commit it to trunk only --> we stop supporting the old way from 3.6.0 and pkg-config will be required. Reward: ZK builds on new systems like Ubuntu 18.04. 2. Don't do anything. ---
ZooKeeper_branch35_jdk8 - Build # 1076 - Failure
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1076/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 62.57 KB...] [junit] Running org.apache.zookeeper.test.SaslSuperUserTest in thread 7 [junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 5 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.337 sec, Thread: 7, Class: org.apache.zookeeper.test.SaslSuperUserTest [junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 7 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.392 sec, Thread: 5, Class: org.apache.zookeeper.test.ServerCnxnTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.683 sec, Thread: 7, Class: org.apache.zookeeper.test.SessionInvalidationTest [junit] Running org.apache.zookeeper.test.SessionTest in thread 5 [junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 7 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.91 sec, Thread: 7, Class: org.apache.zookeeper.test.SessionTimeoutTest [junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 7 [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.119 sec, Thread: 7, Class: org.apache.zookeeper.test.SessionTrackerCheckTest [junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 7 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 149.375 sec, Thread: 2, Class: org.apache.zookeeper.test.RecoveryTest [junit] Running org.apache.zookeeper.test.StandaloneTest in thread 2 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.694 sec, Thread: 2, Class: org.apache.zookeeper.test.StandaloneTest [junit] Running org.apache.zookeeper.test.StatTest in thread 2 [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.216 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.2 sec, Thread: 2, Class: org.apache.zookeeper.test.StatTest [junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 5 [junit] Running org.apache.zookeeper.test.StringUtilTest in thread 2 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.068 sec, Thread: 2, Class: org.apache.zookeeper.test.StringUtilTest [junit] Running org.apache.zookeeper.test.SyncCallTest in thread 2 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 96.634 sec, Thread: 6, Class: org.apache.zookeeper.test.RestoreCommittedLogTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.754 sec, Thread: 2, Class: org.apache.zookeeper.test.SyncCallTest [junit] Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.026 sec, Thread: 5, Class: org.apache.zookeeper.test.StaticHostProviderTest [junit] Running org.apache.zookeeper.test.TruncateTest in thread 6 [junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in thread 5 [junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 2 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.127 sec, Thread: 2, Class: org.apache.zookeeper.test.WatchedEventTest [junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 2 [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.88 sec, Thread: 2, Class: org.apache.zookeeper.test.WatcherFuncTest [junit] Running org.apache.zookeeper.test.WatcherTest in thread 2 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.347 sec, Thread: 7, Class: org.apache.zookeeper.test.SessionUpgradeTest [junit] Running org.apache.zookeeper.test.X509AuthTest in thread 7 [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.107 sec, Thread: 7, Class: org.apache.zookeeper.test.X509AuthTest [junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in thread 7 [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.205 sec, Thread: 6, Class: org.apache.zookeeper.test.TruncateTest [junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 6 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.095 sec, Thread: 6, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.468 sec, Thread: 5, Class: org.apache.zookeeper.test.WatchEventWhenAutoResetTest [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.306 sec, Thread: 7, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest [junit] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapse
[jira] [Commented] (ZOOKEEPER-3112) fd leak due to UnresolvedAddressException on connect.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572926#comment-16572926 ] Hadoop QA commented on ZOOKEEPER-3112: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2037//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2037//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2037//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2037//console This message is automatically generated. > fd leak due to UnresolvedAddressException on connect. > - > > Key: ZOOKEEPER-3112 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3112 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.5.4, 3.4.13 >Reporter: Tianzhou Wang >Priority: Critical > Labels: pull-request-available > Attachments: patch.diff > > Original Estimate: 10m > Time Spent: 0.5h > Remaining Estimate: 0h > > if connecting domain fail to resolve and lead an UnresolvedAddressException, > it would leak the fd. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Failed: ZOOKEEPER- PreCommit Build #2037
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2037/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.90 MB...] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings). [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2037//testReport/ [exec] Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2037//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2037//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2037//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment with id 16572926 added to ZOOKEEPER-3112. [exec] Session logged out. Session was JSESSIONID=21EDC4A8A6F38317D0B649C51F5E8638. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1822: exec returned: 1 Total time: 18 minutes 54 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-3112 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## All tests passed
[GitHub] zookeeper issue #545: ZOOKEEPER-2261 When only secureClientPort is configure...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/545 @hanm If you approve the change, please commit it. I don't want to commit my PR. Thanks! ---
[GitHub] zookeeper pull request #545: ZOOKEEPER-2261 When only secureClientPort is co...
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/545#discussion_r208507660 --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java --- @@ -122,8 +122,8 @@ final Map outstandingChangesForPath = new HashMap(); -protected ServerCnxnFactory serverCnxnFactory; -protected ServerCnxnFactory secureServerCnxnFactory; +ServerCnxnFactory serverCnxnFactory; --- End diff -- Intellij suggested. I think because it's more restrictive. ---
[jira] [Commented] (ZOOKEEPER-2926) Data inconsistency issue due to the flaw in the session management
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572791#comment-16572791 ] Hudson commented on ZOOKEEPER-2926: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #143 (See [https://builds.apache.org/job/ZooKeeper-trunk/143/]) ZOOKEEPER-2926: Fix potential data consistency issue due to the session (hanm: rev cd209456b67cde5aba771b1a240ebe5607398459) * (edit) src/java/test/org/apache/zookeeper/test/ClientBase.java * (edit) src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java * (edit) src/java/test/org/apache/zookeeper/server/MockServerCnxn.java * (edit) src/java/main/org/apache/zookeeper/server/SessionTracker.java * (edit) src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java * (edit) src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java * (add) src/java/test/org/apache/zookeeper/server/quorum/SessionUpgradeQuorumTest.java * (edit) src/java/test/org/apache/zookeeper/test/QuorumBase.java * (edit) src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java * (edit) src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java * (edit) src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java * (edit) src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java * (edit) src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java * (edit) src/java/main/org/apache/zookeeper/server/ServerCnxn.java * (edit) src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java * (edit) src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java > Data inconsistency issue due to the flaw in the session management > -- > > Key: ZOOKEEPER-2926 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2926 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.3, 3.6.0 >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Critical > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > The local session upgrading feature will upgrade the session locally before > receving a quorum commit of creating global session. It's possible that the > server shutdown before the creating session request being sent to leader, if > we retained the ZKDatabase or there is Snapshot happened just before > shutdown, then only this server will have the global session. > If that server didn't become leader, then it will have more global sessions > than others, and those global sessions won't expire as the leader doesn't > know it's existence. If the server became leader, it will accept the client > renew session request and the client is allowed to create ephemeral nodes, > which means other servers only have ephemeral nodes but not that global > session. If there is follower going to have SNAP sync with it, then it will > also have the global session. If the server without that global session > becomes new leader, it will check and delete those dangling ephemeral node > before serving traffic. These could introduce the issues that the ephemeral > node being exist on some servers but not others. > There is dangling global session issue even without local session feature, > because on leader it will update the ZKDatabase when processing > ConnectionRequest and in the PrepRequestProcessor before it's quorum > committed, which also has this risk. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3110) Improve the closeSession throughput in PrepRequestProcessor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572792#comment-16572792 ] Hudson commented on ZOOKEEPER-3110: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #143 (See [https://builds.apache.org/job/ZooKeeper-trunk/143/]) ZOOKEEPER-3110: Improve the closeSession throughput in (hanm: rev df2b3f4fd9944f0dd544b808ea3bad702534625d) * (edit) src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java > Improve the closeSession throughput in PrepRequestProcessor > --- > > Key: ZOOKEEPER-3110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3110 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Time Spent: 0.5h > Remaining Estimate: 0h > > On leader every expired global session will add 3 lines of logs, which is > pretty heavy and if the log file is more than a few GB, the log for the > closeSession in PrepRequestProcessor will slow down the whole ensemble's > throughput. > From some use case, we found the prep request processor will be a bottleneck > when there are constantly high number of expired session or closing session > explicitly. > This JIra is going to remove one of the useless log when prepare close > session txns, which should give us higher throughput during processing large > number of expire sessions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper issue #592: ZOOKEEPER-3112: fix fd leak due to UnresolvedAddressEx...
Github user PhantomThief commented on the issue: https://github.com/apache/zookeeper/pull/592 @anmolnar a bad news is, after my test case, it won't fix the fd leak...so I'm adding an another patch. ---
