[jira] [Commented] (ZOOKEEPER-3141) testLeaderElectionWithDisloyalVoter is flaky
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610124#comment-16610124
]
Michael Han commented on ZOOKEEPER-3141:
The address `fee.fii.foo.fum` was from another test case in same file:
[testBadPeerAddressInQuorum|
https://github.com/apache/zookeeper/blob/master/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java#L597].
One possibility is apache Jenkins was running multiple test cases and for some
reasons, one test case (testBadPeerAddressInQuorum) interferes the other
(testLeaderElectionWithDisloyalVoter_stillHasMajority). I've seen some flaky
tests caused by interference between test cases, but this one is new to me.
I set up a stress test on apache jenkins just to run
testLeaderElectionWithDisloyalVoter_stillHasMajority alone and if the failure
does not reproduce then it's likely the interferences between test cases are
the cause.
> testLeaderElectionWithDisloyalVoter is flaky
>
>
> Key: ZOOKEEPER-3141
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3141
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection, server, tests
>Affects Versions: 3.6.0
>Reporter: Michael Han
>Priority: Major
>
> The unit test added in ZOOKEEPER-3109 turns out to be quite flaky.
> See
> [https://builds.apache.org/job/zOOkeeper-Find-Flaky-Tests/511/artifact/report.html]
> Recent failure builds:
> [https://builds.apache.org/job/ZooKeeper-trunk//181]
> [https://builds.apache.org/job/ZooKeeper-trunk//179]
> [https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2123/testReport/junit/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testLeaderElectionWithDisloyalVoter_stillHasMajority/]
>
>
> Snapshot of the failure:
> {code:java}
> org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter_stillHasMajority
> Error Message
> Server 0 should have joined quorum by now
> Stacktrace
> junit.framework.AssertionFailedError: Server 0 should have joined quorum by
> now
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderElection(QuorumPeerMainTest.java:1482)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter_stillHasMajority(QuorumPeerMainTest.java:1431)
> at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Failed: ZOOKEEPER- PreCommit Build #2150
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2150/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.53 MB...] [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2150//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2150//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2150//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment with id 16610005 added to ZOOKEEPER-2847. [exec] Session logged out. Session was JSESSIONID=4703A27116826BB15D4A37A313F559FC. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1842: exec returned: 1 Total time: 13 minutes 20 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-2847 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## 1 tests failed. FAILED: org.apache.zookeeper.server.quorum.ReconfigLegacyTest.testReconfigRemoveClientFromStatic Error Message: null Stack Trace: junit.framework.AssertionFailedError at org.apache.zookeeper.server.quorum.ReconfigLegacyTest.testReconfigRemoveClientFromStatic(ReconfigLegacyTest.java:206) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
[jira] [Commented] (ZOOKEEPER-2847) Cannot bind to client port when reconfig based on old static config
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610005#comment-16610005
]
Hadoop QA commented on ZOOKEEPER-2847:
--
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2150//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2150//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2150//console
This message is automatically generated.
> Cannot bind to client port when reconfig based on old static config
> ---
>
> Key: ZOOKEEPER-2847
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2847
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.5.3, 3.6.0
>Reporter: Fangmin Lv
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When started the ensemble with old static config that the server string
> doesn't have client port, dynamically remove and add the same server from the
> ensemble will cause that server cannot bind to client port, and the ZooKeeper
> server cannot serve client requests anymore.
> From the code, we'll set the clientAddr to null when start up with old static
> config, and dynamic config forces to have part, which will
> trigger the following rebind code in QuorumPeer#processReconfig, and cause
> the address already in used issue.
> public boolean processReconfig(QuorumVerifier qv, Long suggestedLeaderId,
> Long zxid, boolean restartLE) {
> ...
> if (myNewQS != null && myNewQS.clientAddr != null
> && !myNewQS.clientAddr.equals(oldClientAddr)) {
> cnxnFactory.reconfigure(myNewQS.clientAddr);
> updateThreadName();
> }
> ...
> }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-2847) Cannot bind to client port when reconfig based on old static config
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-2847:
--
Labels: pull-request-available (was: )
> Cannot bind to client port when reconfig based on old static config
> ---
>
> Key: ZOOKEEPER-2847
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2847
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.5.3, 3.6.0
>Reporter: Fangmin Lv
>Priority: Major
> Labels: pull-request-available
>
> When started the ensemble with old static config that the server string
> doesn't have client port, dynamically remove and add the same server from the
> ensemble will cause that server cannot bind to client port, and the ZooKeeper
> server cannot serve client requests anymore.
> From the code, we'll set the clientAddr to null when start up with old static
> config, and dynamic config forces to have part, which will
> trigger the following rebind code in QuorumPeer#processReconfig, and cause
> the address already in used issue.
> public boolean processReconfig(QuorumVerifier qv, Long suggestedLeaderId,
> Long zxid, boolean restartLE) {
> ...
> if (myNewQS != null && myNewQS.clientAddr != null
> && !myNewQS.clientAddr.equals(oldClientAddr)) {
> cnxnFactory.reconfigure(myNewQS.clientAddr);
> updateThreadName();
> }
> ...
> }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] zookeeper pull request #620: ZOOKEEPER-2847: Cannot bind to client port when...
GitHub user yisong-yue opened a pull request: https://github.com/apache/zookeeper/pull/620 ZOOKEEPER-2847: Cannot bind to client port when reconfig based on old static config Fixed the issue where clientPortAddress in the static config is not correctly saved in QuorumVerifier. This can cause zookeeper attempting to re-bind to a port already in use during dynamic reconfiguration, failing to recognize that the new port and the current port are identical. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yisong-yue/zookeeper ZOOKEEPER-2847 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/620.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #620 commit a2bb8e084801391eec63cf3f1e91b79a5189ce48 Author: Yisong Yue Date: 2018-09-11T01:16:38Z ZOOKEEPER-2847: Cannot bind to client port when reconfig based on old static config ---
ZooKeeper-trunk - Build # 185 - Failure
See https://builds.apache.org/job/ZooKeeper-trunk/185/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 282.43 KB...]
[exec] Zookeeper_simpleSystem::testLogCallbackClearLog Message Received:
[2018-09-11 00:44:07,878:22532(0x2b41aa764f40):ZOO_INFO@log_env@1080: Client
environment:zookeeper.version=zookeeper C client 3.6.0]
[exec] Log Message Received: [2018-09-11
00:44:07,878:22532(0x2b41aa764f40):ZOO_INFO@log_env@1084: Client
environment:host.name=asf911.gq1.ygridcore.net]
[exec] Log Message Received: [2018-09-11
00:44:07,878:22532(0x2b41aa764f40):ZOO_INFO@log_env@1091: Client
environment:os.name=Linux]
[exec] Log Message Received: [2018-09-11
00:44:07,878:22532(0x2b41aa764f40):ZOO_INFO@log_env@1092: Client
environment:os.arch=3.13.0-143-generic]
[exec] Log Message Received: [2018-09-11
00:44:07,878:22532(0x2b41aa764f40):ZOO_INFO@log_env@1093: Client
environment:os.version=#192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018]
[exec] Log Message Received: [2018-09-11
00:44:07,878:22532(0x2b41aa764f40):ZOO_INFO@log_env@1101: Client
environment:user.name=jenkins]
[exec] Log Message Received: [2018-09-11
00:44:07,878:22532(0x2b41aa764f40):ZOO_INFO@log_env@1109: Client
environment:user.home=/home/jenkins]
[exec] Log Message Received: [2018-09-11
00:44:07,878:22532(0x2b41aa764f40):ZOO_INFO@log_env@1121: Client
environment:user.dir=/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build/test/test-cppunit]
[exec] Log Message Received: [2018-09-11
00:44:07,878:22532(0x2b41aa764f40):ZOO_INFO@zookeeper_init_internal@1167:
Initiating client connection, host=127.0.0.1:22181 sessionTimeout=1
watcher=0x4639e0 sessionId=0 sessionPasswd= context=0x7ffd4c3cd960
flags=0]
[exec] Log Message Received: [2018-09-11
00:44:07,878:22532(0x2b41ac7c7700):ZOO_INFO@check_events@2454: initiated
connection to server 127.0.0.1:22181]
[exec] Log Message Received: [2018-09-11
00:44:07,895:22532(0x2b41ac7c7700):ZOO_INFO@check_events@2506: session
establishment complete on server 127.0.0.1:22181, sessionId=0x10148071a8e000f,
negotiated timeout=1 ]
[exec] : elapsed 1001 : OK
[exec] Zookeeper_simpleSystem::testAsyncWatcherAutoReset ZooKeeper server
started : elapsed 10510 : OK
[exec] Zookeeper_simpleSystem::testDeserializeString : elapsed 0 : OK
[exec] Zookeeper_simpleSystem::testFirstServerDown : elapsed 1002 : OK
[exec] Zookeeper_simpleSystem::testNonexistentHost : elapsed 1034 : OK
[exec] Zookeeper_simpleSystem::testNullData : elapsed 1062 : OK
[exec] Zookeeper_simpleSystem::testIPV6 : elapsed 1007 : OK
[exec] Zookeeper_simpleSystem::testCreate : elapsed 1015 : OK
[exec] Zookeeper_simpleSystem::testPath : elapsed 1049 : OK
[exec] Zookeeper_simpleSystem::testPathValidation : elapsed 1166 : OK
[exec] Zookeeper_simpleSystem::testPing : elapsed 17613 : OK
[exec] Zookeeper_simpleSystem::testAcl : elapsed 1021 : OK
[exec] Zookeeper_simpleSystem::testChroot : elapsed 3081 : OK
[exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started ZooKeeper
server started : elapsed 31073 : OK
[exec] Zookeeper_simpleSystem::testHangingClient : elapsed 1034 : OK
[exec] Zookeeper_simpleSystem::testWatcherAutoResetWithGlobal ZooKeeper
server started ZooKeeper server started ZooKeeper server started : elapsed
15639 : OK
[exec] Zookeeper_simpleSystem::testWatcherAutoResetWithLocal ZooKeeper
server started ZooKeeper server started ZooKeeper server started : elapsed
15547 : OK
[exec] Zookeeper_simpleSystem::testGetChildren2 : elapsed 1079 : OK
[exec] Zookeeper_simpleSystem::testLastZxid : elapsed 4546 : OK
[exec] Zookeeper_simpleSystem::testRemoveWatchers ZooKeeper server started
: elapsed 4608 : OK
[exec] Zookeeper_readOnly::testReadOnly : elapsed 4130 : OK
[exec] Zookeeper_logClientEnv::testLogClientEnv : elapsed 1 : OK
[exec] OK (76)
[exec] FAIL: zktest-mt
[exec] ==
[exec] 1 of 2 tests failed
[exec] Please report to u...@zookeeper.apache.org
[exec] ==
[exec] make[1]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build/test/test-cppunit'
[exec] *** Error in `./zktest-mt': free(): invalid pointer:
0x2b41aa75 ***
[exec] /bin/bash: line 5: 22532 Aborted
ZKROOT=/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/zookeeper-client/zookeeper-client-c/../..
CLASSPATH=$CLASSPATH:$CLOVER_HOME/lib/clover.jar ${dir}$tst
[exec] make[1]: *** [check-TESTS] Error 1
[exec] make: *** [check-am] Error 2
BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build.xml:1472: The
following error occurred while executing this line:
[jira] [Commented] (ZOOKEEPER-2261) When only secureClientPort is configured connections, configuration, connection_stat_reset, and stats admin commands throw NullPointerException
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609954#comment-16609954
]
Hudson commented on ZOOKEEPER-2261:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #185 (See
[https://builds.apache.org/job/ZooKeeper-trunk/185/])
ZOOKEEPER-2261: When only secureClientPort is configured connections, (hanm:
rev 4ad2341c18020ecb08e7e26b79cacc3569b9d31e)
* (edit) src/java/main/org/apache/zookeeper/server/admin/Commands.java
* (edit) src/java/test/org/apache/zookeeper/server/admin/CommandsTest.java
* (edit) src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
> When only secureClientPort is configured connections, configuration,
> connection_stat_reset, and stats admin commands throw NullPointerException
> ---
>
> Key: ZOOKEEPER-2261
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2261
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Mohammad Arshad
>Assignee: Andor Molnar
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> When only secureClientPort is configured connections, configuration,
> connection_stat_reset and stats admin commands throw NullPointerException.
> Here is stack trace one of the connections command.
> {code}
> java.lang.NullPointerException
> at
> org.apache.zookeeper.server.admin.Commands$ConsCommand.run(Commands.java:177)
> at
> org.apache.zookeeper.server.admin.Commands.runCommand(Commands.java:92)
> at
> org.apache.zookeeper.server.admin.JettyAdminServer$CommandServlet.doGet(JettyAdminServer.java:166)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3141) testLeaderElectionWithDisloyalVoter is flaky
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609948#comment-16609948
]
Fangmin Lv commented on ZOOKEEPER-3141:
---
[~hanm] I checked out internal continuous build, and didn't see it's flaky,
also tried to continuously running this test on my MAC, haven't seen any
failure so far.
Checked the log, since it's failing because we cannot resolve the address:
{quote}2018-09-07 23:22:18,195 [myid:1] - WARN
[QuorumPeer[myid=1](plain=[0:0:0:0:0:0:0:0]:19436)(secure=disabled):QuorumPeer$QuorumServer@179]
- Failed to resolve address: fee.fii.foo.fum java.net.UnknownHostException:
fee.fii.foo.fum: Name or service not known at
java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method) at
java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928) at
java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323) at
java.net.InetAddress.getAllByName0(InetAddress.java:1276) at
java.net.InetAddress.getAllByName(InetAddress.java:1192) at
java.net.InetAddress.getAllByName(InetAddress.java:1126) at
java.net.InetAddress.getByName(InetAddress.java:1076) at
org.apache.zookeeper.server.quorum.QuorumPeer$QuorumServer.recreateSocketAddresses(QuorumPeer.java:177)
at
org.apache.zookeeper.server.quorum.QuorumPeer.recreateSocketAddresses(QuorumPeer.java:711)
at
org.apache.zookeeper.server.quorum.QuorumCnxManager.connectOne(QuorumCnxManager.java:697)
at
org.apache.zookeeper.server.quorum.QuorumCnxManager.connectAll(QuorumCnxManager.java:731)
at
org.apache.zookeeper.server.quorum.FastLeaderElection.lookForLeader(FastLeaderElection.java:943)
at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:1167)
{quote}
Looks like an environment issue, did we see this kind of issue before?
> testLeaderElectionWithDisloyalVoter is flaky
>
>
> Key: ZOOKEEPER-3141
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3141
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection, server, tests
>Affects Versions: 3.6.0
>Reporter: Michael Han
>Priority: Major
>
> The unit test added in ZOOKEEPER-3109 turns out to be quite flaky.
> See
> [https://builds.apache.org/job/zOOkeeper-Find-Flaky-Tests/511/artifact/report.html]
> Recent failure builds:
> [https://builds.apache.org/job/ZooKeeper-trunk//181]
> [https://builds.apache.org/job/ZooKeeper-trunk//179]
> [https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2123/testReport/junit/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testLeaderElectionWithDisloyalVoter_stillHasMajority/]
>
>
> Snapshot of the failure:
> {code:java}
> org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter_stillHasMajority
> Error Message
> Server 0 should have joined quorum by now
> Stacktrace
> junit.framework.AssertionFailedError: Server 0 should have joined quorum by
> now
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderElection(QuorumPeerMainTest.java:1482)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter_stillHasMajority(QuorumPeerMainTest.java:1431)
> at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3141) testLeaderElectionWithDisloyalVoter is flaky
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609945#comment-16609945
]
Fangmin Lv commented on ZOOKEEPER-3141:
---
Thanks [~hanm] for reporting the issue, I'll take a look today.
> testLeaderElectionWithDisloyalVoter is flaky
>
>
> Key: ZOOKEEPER-3141
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3141
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection, server, tests
>Affects Versions: 3.6.0
>Reporter: Michael Han
>Priority: Major
>
> The unit test added in ZOOKEEPER-3109 turns out to be quite flaky.
> See
> [https://builds.apache.org/job/zOOkeeper-Find-Flaky-Tests/511/artifact/report.html]
> Recent failure builds:
> [https://builds.apache.org/job/ZooKeeper-trunk//181]
> [https://builds.apache.org/job/ZooKeeper-trunk//179]
> [https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2123/testReport/junit/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testLeaderElectionWithDisloyalVoter_stillHasMajority/]
>
>
> Snapshot of the failure:
> {code:java}
> org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter_stillHasMajority
> Error Message
> Server 0 should have joined quorum by now
> Stacktrace
> junit.framework.AssertionFailedError: Server 0 should have joined quorum by
> now
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderElection(QuorumPeerMainTest.java:1482)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter_stillHasMajority(QuorumPeerMainTest.java:1431)
> at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] zookeeper issue #615: ZOOKEEPER-3137: add a utility to truncate logs to a zx...
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/615 @enixon Do you plan to update this PR with your trial integration branch, or you prefer the patch land as is? ---
Failed: ZOOKEEPER- PreCommit Build #2149
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2149/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.14 MB...] [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2149//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2149//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2149//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment with id 16609894 added to ZOOKEEPER-3142. [exec] Session logged out. Session was JSESSIONID=1C39C3FFB3A2A1A5F1DD793F5D16A4FD. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1842: exec returned: 2 Total time: 18 minutes 39 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-3142 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-3142) Extend SnapshotFormatter to dump data in json format
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609894#comment-16609894 ] Hadoop QA commented on ZOOKEEPER-3142: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2149//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2149//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2149//console This message is automatically generated. > Extend SnapshotFormatter to dump data in json format > > > Key: ZOOKEEPER-3142 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3142 > Project: ZooKeeper > Issue Type: Improvement >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Priority: Trivial > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Json format can be chained into other tools such as ncdu. Extend the > SnapshotFormatter functionality to dump json. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
ZooKeeper-trunk-windows-cmake - Build # 2929 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2929/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 9.79 KB...] [ivy:retrieve] confs: [javacc] [ivy:retrieve] found net.java.dev.javacc#javacc;5.0 in maven2 [ivy:retrieve] :: resolution report :: resolve 40ms :: artifacts dl 1ms - | |modules|| artifacts | | conf | number| search|dwnlded|evicted|| number|dwnlded| - | javacc | 1 | 0 | 0 | 0 || 1 | 0 | - [ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper [ivy:retrieve] confs: [javacc] [ivy:retrieve] 1 artifacts copied, 0 already retrieved (291kB/14ms) generate_jute_parser: [mkdir] Created dir: f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\build\jute_compiler\org\apache\jute\compiler\generated [ivy:artifactproperty] DEPRECATED: 'ivy.conf.file' is deprecated, use 'ivy.settings.file' instead [ivy:artifactproperty] :: loading settings :: file = f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\ivysettings.xml [move] Moving 1 file to f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\build\javacc\lib [javacc] Java Compiler Compiler Version 5.0 (Parser Generator) [javacc] (type "javacc" with no arguments for help) [javacc] Reading from file f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\zookeeper-jute\src\main\java\org\apache\jute\compiler\generated\rcc.jj . . . [javacc] File "TokenMgrError.java" does not exist. Will create one. [javacc] File "ParseException.java" does not exist. Will create one. [javacc] File "Token.java" does not exist. Will create one. [javacc] File "SimpleCharStream.java" does not exist. Will create one. [javacc] Parser generated successfully. jute: [javac] Compiling 39 source files to f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\build\classes [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.8 [javac] 1 warning compile_jute_uptodate: compile_jute: [mkdir] Created dir: f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\java\generated [mkdir] Created dir: f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\zookeeper-client\zookeeper-client-c\generated [java] ../../../zookeeper-jute/src/main/resources/zookeeper.jute Parsed Successfully [java] ../../../zookeeper-jute/src/main/resources/zookeeper.jute Parsed Successfully [touch] Creating f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\java\generated\.generated BUILD SUCCESSFUL Total time: 6 seconds [ZooKeeper-trunk-windows-cmake] $ cmd /c call F:\jenkins\jenkins-slave\temp\jenkins6528804253028828024.bat f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake>cd src/c The system cannot find the path specified. f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake>cmake . CMake Error: The source directory "F:/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-windows-cmake" does not appear to contain CMakeLists.txt. Specify --help for usage, or press the help button on the CMake GUI. f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake>cmake --build . Error: could not load cache f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake>exit 1 Build step 'Execute Windows batch command' marked build as failure Email was triggered for: Failure - Any Sending email for trigger: Failure - Any ### ## FAILED TESTS (if any) ## No tests ran.
[GitHub] zookeeper pull request #619: ZOOKEEPER-3142: Extend SnapshotFormatter to dum...
GitHub user enixon opened a pull request: https://github.com/apache/zookeeper/pull/619 ZOOKEEPER-3142: Extend SnapshotFormatter to dump data in json format You can merge this pull request into a Git repository by running: $ git pull https://github.com/enixon/zookeeper extend-sf Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/619.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #619 commit 0068b02aca8c9b6b36cf254bfc66a9ff5ae0d0dc Author: Brian Nixon Date: 2018-09-10T22:42:25Z ZOOKEEPER-3142: Extend SnapshotFormatter to dump data in json format ---
[jira] [Updated] (ZOOKEEPER-3142) Extend SnapshotFormatter to dump data in json format
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3142: -- Labels: pull-request-available (was: ) > Extend SnapshotFormatter to dump data in json format > > > Key: ZOOKEEPER-3142 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3142 > Project: ZooKeeper > Issue Type: Improvement >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Priority: Trivial > Labels: pull-request-available > > Json format can be chained into other tools such as ncdu. Extend the > SnapshotFormatter functionality to dump json. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3142) Extend SnapshotFormatter to dump data in json format
Brian Nixon created ZOOKEEPER-3142: -- Summary: Extend SnapshotFormatter to dump data in json format Key: ZOOKEEPER-3142 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3142 Project: ZooKeeper Issue Type: Improvement Affects Versions: 3.6.0 Reporter: Brian Nixon Json format can be chained into other tools such as ncdu. Extend the SnapshotFormatter functionality to dump json. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Success: ZOOKEEPER- PreCommit Build #2148
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2148/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.11 MB...] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +0 tests included. The patch appears to be a documentation patch that doesn't require tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2148//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2148//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2148//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] [exec] Error: No value specified for option "issue" [exec] Session logged out. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD SUCCESSFUL Total time: 18 minutes 6 seconds Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-2261 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Success Sending email for trigger: Success Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-3141) testLeaderElectionWithDisloyalVoter is flaky
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609863#comment-16609863
]
Michael Han commented on ZOOKEEPER-3141:
[~lvfangmin] Do you want to take a look at this flaky test introduced by your
patch in ZOOKEEPER-3109?
> testLeaderElectionWithDisloyalVoter is flaky
>
>
> Key: ZOOKEEPER-3141
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3141
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection, server, tests
>Affects Versions: 3.6.0
>Reporter: Michael Han
>Priority: Major
>
> The unit test added in ZOOKEEPER-3109 turns out to be quite flaky.
> See
> [https://builds.apache.org/job/zOOkeeper-Find-Flaky-Tests/511/artifact/report.html]
> Recent failure builds:
> [https://builds.apache.org/job/ZooKeeper-trunk//181]
> [https://builds.apache.org/job/ZooKeeper-trunk//179]
> [https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2123/testReport/junit/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testLeaderElectionWithDisloyalVoter_stillHasMajority/]
>
>
> Snapshot of the failure:
> {code:java}
> org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter_stillHasMajority
> Error Message
> Server 0 should have joined quorum by now
> Stacktrace
> junit.framework.AssertionFailedError: Server 0 should have joined quorum by
> now
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderElection(QuorumPeerMainTest.java:1482)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter_stillHasMajority(QuorumPeerMainTest.java:1431)
> at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3141) testLeaderElectionWithDisloyalVoter is flaky
Michael Han created ZOOKEEPER-3141:
--
Summary: testLeaderElectionWithDisloyalVoter is flaky
Key: ZOOKEEPER-3141
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3141
Project: ZooKeeper
Issue Type: Bug
Components: leaderElection, server, tests
Affects Versions: 3.6.0
Reporter: Michael Han
The unit test added in ZOOKEEPER-3109 turns out to be quite flaky.
See
[https://builds.apache.org/job/zOOkeeper-Find-Flaky-Tests/511/artifact/report.html]
Recent failure builds:
[https://builds.apache.org/job/ZooKeeper-trunk//181]
[https://builds.apache.org/job/ZooKeeper-trunk//179]
[https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2123/testReport/junit/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testLeaderElectionWithDisloyalVoter_stillHasMajority/]
Snapshot of the failure:
{code:java}
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter_stillHasMajority
Error Message
Server 0 should have joined quorum by now
Stacktrace
junit.framework.AssertionFailedError: Server 0 should have joined quorum by now
at
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderElection(QuorumPeerMainTest.java:1482)
at
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter_stillHasMajority(QuorumPeerMainTest.java:1431)
at
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] zookeeper issue #545: ZOOKEEPER-2261 When only secureClientPort is configure...
Github user enixon commented on the issue: https://github.com/apache/zookeeper/pull/545 lgtm :) ---
[GitHub] zookeeper issue #545: ZOOKEEPER-2261 When only secureClientPort is configure...
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/545 thanks @anmolnar , merged to master. ---
[GitHub] zookeeper pull request #545: ZOOKEEPER-2261 When only secureClientPort is co...
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/545 ---
[GitHub] zookeeper pull request #580: ZOOKEEPER-3098: Add additional server metrics
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/580#discussion_r216487862
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Follower.java ---
@@ -86,7 +89,13 @@ void followLeader() throws InterruptedException {
+ " is less than our accepted epoch " +
ZxidUtils.zxidToString(self.getAcceptedEpoch()));
throw new IOException("Error: Epoch of leader is
lower");
}
-syncWithLeader(newEpochZxid);
+long startTime = Time.currentElapsedTime();
+try {
+syncWithLeader(newEpochZxid);
+} finally {
+long syncTime = Time.currentElapsedTime() - startTime;
+ServerMetrics.FOLLOWER_SYNC_TIME.add(syncTime);
--- End diff --
This will execute regardless of `syncWithLeader` succeeded or not. Should
we only collect `syncTime` for the syncs that were successful?
---
[GitHub] zookeeper pull request #580: ZOOKEEPER-3098: Add additional server metrics
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/580#discussion_r216489582
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -33,17 +34,17 @@
public class ServerStats {
private static final Logger LOG =
LoggerFactory.getLogger(ServerStats.class);
-private long packetsSent;
-private long packetsReceived;
-private long maxLatency;
-private long minLatency = Long.MAX_VALUE;
-private long totalLatency = 0;
-private long count = 0;
+private final AtomicLong packetsSent = new AtomicLong();
--- End diff --
Since `ServerMetrics` is a superset of `ServerStats` in terms of scope, we
probably want to keep `ServerStats` as is and ultimately deprecate it in favor
of `ServerMetrics`. I don't think there is a need to duplicate metrics in two
places, which would be both a burden to maintain and a potential source of
confusion.
Regarding reporting to `mntr`, we decided deprecate 4lw last year due to
the limitation of its design, in particular around security, in favor of admin
server endpoints (`/metrics` in this case), so I don't there is a need to
report newly added metrics to `mntr`. This also encourages users to migrate
away from 4lw to admin end points.
Overall the state in current patch w.r.t this looks good to me.
---
Re: ZooKeeper 3.5 blocker issues
Thanks Andor for compiling this. Should we be ignoring ZOOKEEPER-2418 as well? This exists in 3.4 as well and the feature can be disabled. We are working on a longer term fix for it in 3.6. Regards, Jeelani On 9/10/18, 5:19 AM, "Andor Molnar" wrote: Fine. I'm happy to ignore 1549, 2846 and 2930. Still we have the list of: - ZOOKEEPER-236 (SSL/TLS support for Atomic Broadcast protocol) - ZOOKEEPER-1818 (Fix don't care for trunk) - ZOOKEEPER-2418 (txnlog diff sync can skip sending some transactions to followers) - ZOOKEEPER-2778 (Potential server deadlock between follower sync with leader and follower receiving external connection requests.) SSL (ZK-236) is a feature which essential for the 3.5 release, hence I wouldn't leave it out or postpone it for the next stable release. PR has been out for a long time, get on reviewing please. The rest are also long outstanding issues which have been found in the 3.5 branch. ZK-1818 is something which was found in 3.4 and fixed in 3.4, but never has been fixed in 3.5. Quite a serious issue if still present. I think we should at least run some manual testing and see if we could repro any of these issues before going ahead with a stable release. Regards, Andor On Fri, Sep 7, 2018 at 3:24 AM, Michael Han wrote: > I haven't went through the entire list, but looks like lots of the JIRA > issues listed in this thread, such as ZOOKEEPER-1549, 2846, also affects > 3.4 releases. Should we scope these issues out? > > I think historically the single outstanding blocking issue for a stable 3.5 > release is the reconfig feature and security concerns around it (somehow > addressed in ZOOKEEPER-2014), and the alpha and beta releases were created > to stabilize that feature. > > https://urldefense.proofpoint.com/v2/url?u=http-3A__zookeeper-2Duser.578899.n2.nabble.com_Zookeeper-2Dwith-2D=DwIBaQ=5VD0RTtNlTh3ycd41b3MUw=Vl4oKanLQehvaulUvoKg8A=wqlhnot9c-pQLdkGkccSGNpELUNUnB-wy_h0iA3PRqI=_tGtL3nMWtuPrXKXDx27AIWOzyyT7W-CjIVLDFZwT0E= > SSL-release-date-tt7581744.html > > So it looks like we are in good shape to release. Something might worth > doing to claim the quality of 3.5 is on par with 3.4 > > * Run Jepsen on 3.5 - 3.4 passed the test for the record > https://urldefense.proofpoint.com/v2/url?u=https-3A__aphyr.com_posts_291-2Djepsen-2Dzookeeper=DwIBaQ=5VD0RTtNlTh3ycd41b3MUw=Vl4oKanLQehvaulUvoKg8A=wqlhnot9c-pQLdkGkccSGNpELUNUnB-wy_h0iA3PRqI=VjORkX5s7hrJyl8mW9Q4cfeSWF4qfTdyRjcuAiBt0y4= > * Fix all flaky tests on 3.5 - 3.4 has little or no flaky tests at all. > > > On Tue, Sep 4, 2018 at 1:48 AM, Andor Molnar > wrote: > > > Thanks Maoling! That would be huge help, I appreciate it. > > > > Andor > > >
ZooKeeper-trunk-windows-cmake - Build # 2928 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2928/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 9.65 KB...] [ivy:retrieve] confs: [javacc] [ivy:retrieve] found net.java.dev.javacc#javacc;5.0 in maven2 [ivy:retrieve] :: resolution report :: resolve 103ms :: artifacts dl 2ms - | |modules|| artifacts | | conf | number| search|dwnlded|evicted|| number|dwnlded| - | javacc | 1 | 0 | 0 | 0 || 1 | 0 | - [ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper [ivy:retrieve] confs: [javacc] [ivy:retrieve] 1 artifacts copied, 0 already retrieved (291kB/29ms) generate_jute_parser: [mkdir] Created dir: f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\build\jute_compiler\org\apache\jute\compiler\generated [ivy:artifactproperty] DEPRECATED: 'ivy.conf.file' is deprecated, use 'ivy.settings.file' instead [ivy:artifactproperty] :: loading settings :: file = f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\ivysettings.xml [move] Moving 1 file to f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\build\javacc\lib [javacc] Java Compiler Compiler Version 5.0 (Parser Generator) [javacc] (type "javacc" with no arguments for help) [javacc] Reading from file f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\zookeeper-jute\src\main\java\org\apache\jute\compiler\generated\rcc.jj . . . [javacc] File "TokenMgrError.java" does not exist. Will create one. [javacc] File "ParseException.java" does not exist. Will create one. [javacc] File "Token.java" does not exist. Will create one. [javacc] File "SimpleCharStream.java" does not exist. Will create one. [javacc] Parser generated successfully. jute: [javac] Compiling 39 source files to f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\build\classes [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.8 [javac] 1 warning compile_jute_uptodate: compile_jute: [mkdir] Created dir: f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\java\generated [mkdir] Created dir: f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\zookeeper-client\zookeeper-client-c\generated [java] ../../../zookeeper-jute/src/main/resources/zookeeper.jute Parsed Successfully [java] ../../../zookeeper-jute/src/main/resources/zookeeper.jute Parsed Successfully [touch] Creating f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\java\generated\.generated BUILD SUCCESSFUL Total time: 13 seconds [ZooKeeper-trunk-windows-cmake] $ cmd /c call F:\jenkins\jenkins-slave\temp\jenkins4893295057172188462.bat f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake>cd src/c The system cannot find the path specified. f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake>cmake . CMake Error: The source directory "F:/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-windows-cmake" does not appear to contain CMakeLists.txt. Specify --help for usage, or press the help button on the CMake GUI. f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake>cmake --build . Error: could not load cache f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake>exit 1 Build step 'Execute Windows batch command' marked build as failure Email was triggered for: Failure - Any Sending email for trigger: Failure - Any ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-2261) When only secureClientPort is configured connections, configuration, connection_stat_reset, and stats admin commands throw NullPointerException
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609255#comment-16609255
]
Hadoop QA commented on ZOOKEEPER-2261:
--
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2146//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2146//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2146//console
This message is automatically generated.
> When only secureClientPort is configured connections, configuration,
> connection_stat_reset, and stats admin commands throw NullPointerException
> ---
>
> Key: ZOOKEEPER-2261
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2261
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Mohammad Arshad
>Assignee: Andor Molnar
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> When only secureClientPort is configured connections, configuration,
> connection_stat_reset and stats admin commands throw NullPointerException.
> Here is stack trace one of the connections command.
> {code}
> java.lang.NullPointerException
> at
> org.apache.zookeeper.server.admin.Commands$ConsCommand.run(Commands.java:177)
> at
> org.apache.zookeeper.server.admin.Commands.runCommand(Commands.java:92)
> at
> org.apache.zookeeper.server.admin.JettyAdminServer$CommandServlet.doGet(JettyAdminServer.java:166)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Success: ZOOKEEPER- PreCommit Build #2146
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2146/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.26 MB...] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2146//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2146//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2146//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment with id 16609255 added to ZOOKEEPER-2261. [exec] Session logged out. Session was JSESSIONID=924BC0D57710361EC23FFBF536263459. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD SUCCESSFUL Total time: 17 minutes 57 seconds Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-2261 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Success Sending email for trigger: Success Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## All tests passed
Failed: ZOOKEEPER- PreCommit Build #2147
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2147/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 5.66 KB...]
[exec] Pull request id:
[exec] % Total% Received % Xferd Average Speed TimeTime
Time CurrentPull request title:
[exec] Dload Upload Total Spent
Left Speed
[exec]
[exec]
[exec] Defect number:
[exec] - Parsed args, going to checkout -
[exec]
[exec]
[exec]
==
[exec]
==
[exec] Testing patch for pull request .
[exec]
==
[exec]
==
[exec]
[exec]
[exec]
[exec]
[exec]
[exec]
==
[exec]
==
[exec] Pre-build trunk to verify trunk stability and javac warnings
[exec]
==
[exec]
==
[exec]
[exec]
[exec] /home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant
-Djavac.args=-Xlint -Xmaxwarns 1000
-Djava5.home=/home/jenkins/tools/java5/latest/
-Dforrest.home=/home/jenkins/tools/forrest/latest/ -DZookeeperPatchProcess=
clean tar >
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess/trunkJavacWarnings.txt
2>&1
[exec] Trunk compilation is broken?
[exec]
[exec]
[exec]
==
[exec]
==
[exec] Finished build.
[exec]
==
[exec]
==
[exec]
[exec]
[exec] 0 00 00 0 0 0 --:--:-- --:--:--
--:--:-- 0curl: (6) Could not resolve host:
.diff/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/src/java/test/bin/test-github-pr.sh:
line 153: 15184 Killed $ANT_HOME/bin/ant -Djavac.args="-Xlint
-Xmaxwarns 1000" -Djava5.home=${JAVA5_HOME} -Dforrest.home=${FORREST_HOME}
-DZookeeperPatchProcess= clean tar > $PATCH_DIR/trunkJavacWarnings.txt 2>&1
[exec] mv:
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
and
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
are the same file
BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1842:
exec returned: 1
Total time: 31 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ?Publish JUnit test result report? failed: No test report files
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-1990
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
###
## FAILED TESTS (if any)
##
No tests ran.
ZooKeeper_branch35_jdk8 - Build # 1113 - Failure
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1113/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 62.72 KB...] [junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 4 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.63 sec, Thread: 4, Class: org.apache.zookeeper.test.SessionInvalidationTest [junit] Running org.apache.zookeeper.test.SessionTest in thread 4 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.384 sec, Thread: 7, Class: org.apache.zookeeper.test.ServerCnxnTest [junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 7 [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 71.558 sec, Thread: 8, Class: org.apache.zookeeper.test.QuorumZxidSyncTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.495 sec, Thread: 7, Class: org.apache.zookeeper.test.SessionTimeoutTest [junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 8 [junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 7 [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.143 sec, Thread: 8, Class: org.apache.zookeeper.test.SessionTrackerCheckTest [junit] Running org.apache.zookeeper.test.StandaloneTest in thread 8 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.614 sec, Thread: 8, Class: org.apache.zookeeper.test.StandaloneTest [junit] Running org.apache.zookeeper.test.StatTest in thread 8 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.272 sec, Thread: 8, Class: org.apache.zookeeper.test.StatTest [junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 8 [junit] Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.814 sec, Thread: 8, Class: org.apache.zookeeper.test.StaticHostProviderTest [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.125 sec, Thread: 4, Class: org.apache.zookeeper.test.SessionTest [junit] Running org.apache.zookeeper.test.StringUtilTest in thread 8 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.065 sec, Thread: 8, Class: org.apache.zookeeper.test.StringUtilTest [junit] Running org.apache.zookeeper.test.SyncCallTest in thread 4 [junit] Running org.apache.zookeeper.test.TruncateTest in thread 8 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.822 sec, Thread: 4, Class: org.apache.zookeeper.test.SyncCallTest [junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in thread 4 [junit] Tests run: 14, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 91.11 sec, Thread: 5, Class: org.apache.zookeeper.test.QuorumTest [junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 5 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.077 sec, Thread: 5, Class: org.apache.zookeeper.test.WatchedEventTest [junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 5 [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.61 sec, Thread: 8, Class: org.apache.zookeeper.test.TruncateTest [junit] Running org.apache.zookeeper.test.WatcherTest in thread 8 [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.224 sec, Thread: 5, Class: org.apache.zookeeper.test.WatcherFuncTest [junit] Running org.apache.zookeeper.test.X509AuthTest in thread 5 [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.092 sec, Thread: 5, Class: org.apache.zookeeper.test.X509AuthTest [junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in thread 5 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 23.367 sec, Thread: 7, Class: org.apache.zookeeper.test.SessionUpgradeTest [junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 7 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.823 sec, Thread: 7, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest [junit] Running org.apache.jute.BinaryInputArchiveTest in thread 7 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.126 sec, Thread: 7, Class: org.apache.jute.BinaryInputArchiveTest [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.039 sec, Thread: 5, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.894 sec, Thread: 4, Class: org.apache.zookeeper.test.WatchEventWhenAutoResetTest [junit] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 28.78 sec, Thread: 8, Class: org.apache.zookeeper.test.WatcherTest [junit] Tests
Failed: ZOOKEEPER- PreCommit Build #2145
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2145/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.93 MB...] [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2145//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2145//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2145//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] [exec] Error: No value specified for option "issue" [exec] Session logged out. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: ‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’ and ‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’ are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1842: exec returned: 1 Total time: 16 minutes 1 second Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-1990 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## 2 tests failed. FAILED: org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig Error Message: waiting for server 3 being up Stack Trace: junit.framework.AssertionFailedError: waiting for server 3 being up at org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig(ReconfigRecoveryTest.java:224) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79) FAILED: org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged Error Message: expected: but was: Stack Trace: junit.framework.AssertionFailedError: expected: but was: at org.apache.zookeeper.test.WatchEventWhenAutoResetTest$EventsWatcher.assertEvent(WatchEventWhenAutoResetTest.java:67) at org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged(WatchEventWhenAutoResetTest.java:117) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
Re: Re: ZooKeeper 3.5 blocker issues
Fine. I'm happy to ignore 1549, 2846 and 2930. Still we have the list of: - ZOOKEEPER-236 (SSL/TLS support for Atomic Broadcast protocol) - ZOOKEEPER-1818 (Fix don't care for trunk) - ZOOKEEPER-2418 (txnlog diff sync can skip sending some transactions to followers) - ZOOKEEPER-2778 (Potential server deadlock between follower sync with leader and follower receiving external connection requests.) SSL (ZK-236) is a feature which essential for the 3.5 release, hence I wouldn't leave it out or postpone it for the next stable release. PR has been out for a long time, get on reviewing please. The rest are also long outstanding issues which have been found in the 3.5 branch. ZK-1818 is something which was found in 3.4 and fixed in 3.4, but never has been fixed in 3.5. Quite a serious issue if still present. I think we should at least run some manual testing and see if we could repro any of these issues before going ahead with a stable release. Regards, Andor On Fri, Sep 7, 2018 at 3:24 AM, Michael Han wrote: > I haven't went through the entire list, but looks like lots of the JIRA > issues listed in this thread, such as ZOOKEEPER-1549, 2846, also affects > 3.4 releases. Should we scope these issues out? > > I think historically the single outstanding blocking issue for a stable 3.5 > release is the reconfig feature and security concerns around it (somehow > addressed in ZOOKEEPER-2014), and the alpha and beta releases were created > to stabilize that feature. > > http://zookeeper-user.578899.n2.nabble.com/Zookeeper-with- > SSL-release-date-tt7581744.html > > So it looks like we are in good shape to release. Something might worth > doing to claim the quality of 3.5 is on par with 3.4 > > * Run Jepsen on 3.5 - 3.4 passed the test for the record > https://aphyr.com/posts/291-jepsen-zookeeper > * Fix all flaky tests on 3.5 - 3.4 has little or no flaky tests at all. > > > On Tue, Sep 4, 2018 at 1:48 AM, Andor Molnar > wrote: > > > Thanks Maoling! That would be huge help, I appreciate it. > > > > Andor > > >
[jira] [Updated] (ZOOKEEPER-236) SSL Support for Atomic Broadcast protocol
[ https://issues.apache.org/jira/browse/ZOOKEEPER-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar updated ZOOKEEPER-236: --- Fix Version/s: 3.5.5 3.6.0 > SSL Support for Atomic Broadcast protocol > - > > Key: ZOOKEEPER-236 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-236 > Project: ZooKeeper > Issue Type: New Feature > Components: quorum, security, server >Reporter: Benjamin Reed >Assignee: Andor Molnar >Priority: Major > Labels: pull-request-available, ssl > Fix For: 3.6.0, 3.5.5 > > Time Spent: 12.5h > Remaining Estimate: 0h > > We should have the ability to use SSL to authenticate and encrypt the traffic > between ZooKeeper servers. For the most part this is a very easy change. We > would probably only want to support this for TCP based leader elections. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-2261) When only secureClientPort is configured connections, configuration, connection_stat_reset, and stats admin commands throw NullPointerException
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609053#comment-16609053
]
Hadoop QA commented on ZOOKEEPER-2261:
--
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2144//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2144//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2144//console
This message is automatically generated.
> When only secureClientPort is configured connections, configuration,
> connection_stat_reset, and stats admin commands throw NullPointerException
> ---
>
> Key: ZOOKEEPER-2261
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2261
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Mohammad Arshad
>Assignee: Andor Molnar
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> When only secureClientPort is configured connections, configuration,
> connection_stat_reset and stats admin commands throw NullPointerException.
> Here is stack trace one of the connections command.
> {code}
> java.lang.NullPointerException
> at
> org.apache.zookeeper.server.admin.Commands$ConsCommand.run(Commands.java:177)
> at
> org.apache.zookeeper.server.admin.Commands.runCommand(Commands.java:92)
> at
> org.apache.zookeeper.server.admin.JettyAdminServer$CommandServlet.doGet(JettyAdminServer.java:166)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Failed: ZOOKEEPER- PreCommit Build #2144
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2144/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 79.85 MB...]
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
(version 3.0.1) warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
[exec]
[exec] -1 core tests. The patch failed core unit tests.
[exec]
[exec] +1 contrib tests. The patch passed contrib unit tests.
[exec]
[exec] Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2144//testReport/
[exec] Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2144//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
[exec] Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2144//console
[exec]
[exec] This message is automatically generated.
[exec]
[exec]
[exec]
==
[exec]
==
[exec] Adding comment to Jira.
[exec]
==
[exec]
==
[exec]
[exec]
[exec] Comment with id 16609053 added to ZOOKEEPER-2261.
[exec] Session logged out. Session was
JSESSIONID=C594C552954D5CF3ED9E556DD2C40A97.
[exec]
[exec]
[exec]
==
[exec]
==
[exec] Finished build.
[exec]
==
[exec]
==
[exec]
[exec]
[exec] mv:
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
and
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
are the same file
BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1842:
exec returned: 1
Total time: 17 minutes 24 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-2261
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
###
## FAILED TESTS (if any)
##
1 tests failed.
FAILED: org.apache.zookeeper.server.admin.CommandsTest.testConnections
Error Message:
Result from command connections contains extra fields:
{secure_connections=[Ljava.lang.Object;@548a102f}
Stack Trace:
junit.framework.AssertionFailedError: Result from command connections contains
extra fields: {secure_connections=[Ljava.lang.Object;@548a102f}
at
org.apache.zookeeper.server.admin.CommandsTest.testCommand(CommandsTest.java:81)
at
org.apache.zookeeper.server.admin.CommandsTest.testCommand(CommandsTest.java:87)
at
org.apache.zookeeper.server.admin.CommandsTest.testConnections(CommandsTest.java:114)
at
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
[GitHub] zookeeper issue #545: ZOOKEEPER-2261 When only secureClientPort is configure...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/545 @hanm One more addition: I extended the output of cons command to display non-secure and secure connections separately. I think the interface is more obvious this way. ---
[jira] [Commented] (ZOOKEEPER-1990) suspicious instantiation of java Random instances
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609022#comment-16609022
]
Hudson commented on ZOOKEEPER-1990:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #184 (See
[https://builds.apache.org/job/ZooKeeper-trunk/184/])
ZOOKEEPER-1990: fix Random instances (andor: rev
181de25c0dc703eaff77dd6415b676f09564277a)
* (edit) src/java/main/org/apache/zookeeper/ClientCnxn.java
* (edit) src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
> suspicious instantiation of java Random instances
> -
>
> Key: ZOOKEEPER-1990
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1990
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Patrick Hunt
>Assignee: Norbert Kalmar
>Priority: Critical
> Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> It's not clear to me why we are doing this, but it looks very suspicious. Why
> aren't we just calling "new Random()" in these cases? (even for the tests I
> don't really see it - typically that would just be for repeatability)
> {noformat}
> ag "new Random[ \t]*\(" .
> src/java/main/org/apache/zookeeper/ClientCnxn.java
> 817:private Random r = new Random(System.nanoTime());
> src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
> 75: sourceOfRandomness = new Random(System.currentTimeMillis() ^
> this.hashCode());
> 98:sourceOfRandomness = new Random(randomnessSeed);
> src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java
> 420:rand = new Random(java.lang.Thread.currentThread().getId()
> src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
> 64:private final Random r = new Random(System.nanoTime());
> src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
> 537:Random r = new Random(id ^ superSecret);
> 554:Random r = new Random(sessionId ^ superSecret);
> src/java/test/org/apache/zookeeper/server/quorum/WatchLeakTest.java
> 271:Random r = new Random(SESSION_ID ^ superSecret);
> src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java
> 151:Random rand = new Random(Thread.currentThread().getId());
> 258:Random rand = new Random(Thread.currentThread().getId());
> 288:Random rand = new Random(Thread.currentThread().getId());
> src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java
> 40:private Random r = new Random(1);
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
ZooKeeper-trunk-windows-cmake - Build # 2927 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2927/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 9.67 KB...] [ivy:retrieve] confs: [javacc] [ivy:retrieve] found net.java.dev.javacc#javacc;5.0 in maven2 [ivy:retrieve] :: resolution report :: resolve 41ms :: artifacts dl 1ms - | |modules|| artifacts | | conf | number| search|dwnlded|evicted|| number|dwnlded| - | javacc | 1 | 0 | 0 | 0 || 1 | 0 | - [ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper [ivy:retrieve] confs: [javacc] [ivy:retrieve] 1 artifacts copied, 0 already retrieved (291kB/13ms) generate_jute_parser: [mkdir] Created dir: f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\build\jute_compiler\org\apache\jute\compiler\generated [ivy:artifactproperty] DEPRECATED: 'ivy.conf.file' is deprecated, use 'ivy.settings.file' instead [ivy:artifactproperty] :: loading settings :: file = f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\ivysettings.xml [move] Moving 1 file to f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\build\javacc\lib [javacc] Java Compiler Compiler Version 5.0 (Parser Generator) [javacc] (type "javacc" with no arguments for help) [javacc] Reading from file f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\zookeeper-jute\src\main\java\org\apache\jute\compiler\generated\rcc.jj . . . [javacc] File "TokenMgrError.java" does not exist. Will create one. [javacc] File "ParseException.java" does not exist. Will create one. [javacc] File "Token.java" does not exist. Will create one. [javacc] File "SimpleCharStream.java" does not exist. Will create one. [javacc] Parser generated successfully. jute: [javac] Compiling 39 source files to f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\build\classes [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.8 [javac] 1 warning compile_jute_uptodate: compile_jute: [mkdir] Created dir: f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\java\generated [mkdir] Created dir: f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\zookeeper-client\zookeeper-client-c\generated [java] ../../../zookeeper-jute/src/main/resources/zookeeper.jute Parsed Successfully [java] ../../../zookeeper-jute/src/main/resources/zookeeper.jute Parsed Successfully [touch] Creating f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\java\generated\.generated BUILD SUCCESSFUL Total time: 6 seconds [ZooKeeper-trunk-windows-cmake] $ cmd /c call F:\jenkins\jenkins-slave\temp\jenkins131783982586447747.bat f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake>cd src/c The system cannot find the path specified. f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake>cmake . CMake Error: The source directory "F:/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-windows-cmake" does not appear to contain CMakeLists.txt. Specify --help for usage, or press the help button on the CMake GUI. f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake>cmake --build . Error: could not load cache f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake>exit 1 Build step 'Execute Windows batch command' marked build as failure Email was triggered for: Failure - Any Sending email for trigger: Failure - Any ### ## FAILED TESTS (if any) ## No tests ran.
[GitHub] zookeeper issue #617: ZOOKEEPER-1990 - fix Random instances
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/617 Committed to branch-3.5 and master. Thanks @nkalmar ! ---
[GitHub] zookeeper pull request #617: ZOOKEEPER-1990 - fix Random instances
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/617 ---
[GitHub] zookeeper issue #567: ZOOKEEPER-3071: Add a config parameter to control tran...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/567 @suyogmapara I tend to accept this patch and understand that the new configuration setting has to be carefully set and should be consistent with `preAllocSize`, otherwise all kind of issues could happen to ZooKeeper. For that very good reason I'd like to ask you to extend the documentation with a lot more information about it. Everything that you mentioned here including the examples should be added to doc with highlighting how careful the user should be when touching it. @breed Do you accept the patch? ---
[GitHub] zookeeper pull request #613: ZOOKEEPER-1823:zkTxnLogToolkit -dump should sup...
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/613#discussion_r216257398 --- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -2273,7 +2273,7 @@ server.3=zoo3:2888:3888 $ bin/zkTxnLogToolkit.sh usage: TxnLogToolkit [-dhrv] txn_log_file_name - -d,--dump Dump mode. Dump all entries of the log file. (this is the default) + -d,--dump Dump mode. Dump all entries of the log file with printing the content of a nodepath (default) --- End diff -- This change is documentation only. Please update the help message as well. ---
