date:20181015

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/669
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2444/



---

[GitHub] zookeeper issue #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/669
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2445/



---

Failed: ZOOKEEPER- PreCommit Build #2444

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2444/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 22.82 MB...]
 [exec] /bin/kill -9 7667 
 [exec] /bin/kill -9 7697 
 [exec] 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/zookeeper-common/src/test/resources/test-github-pr.sh:
 line 471:  7719 Killed  $ANT_HOME/bin/ant 
-DZookeeperPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes 
test-contrib
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=4DEA35D8C3A4C9F3DF0B1A4BABD7C257.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1958:
 exec returned: 3

Total time: 14 minutes 30 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3152
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Adding one-line test results to commit status...
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of ff0e6cd35cd2a3df29f209c23d37c82cde0423e4 to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2444/ and 
message: 'FAILURE
 527 tests run, 1 skipped, 46 failed.'
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2444/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
46 tests failed.
FAILED:  
org.apache.zookeeper.test.FollowerResyncConcurrencyTest.testResyncBySnapThenDiffAfterFollowerCrashes

Error Message:
unable to create new native thread

Stack Trace:
java.lang.OutOfMemoryError: unable to create new native thread
at java.lang.Thread.start0(Native Method)
at java.lang.Thread.start(Thread.java:717)
at 
org.apache.zookeeper.test.FollowerResyncConcurrencyTest.followerResyncCrashTest(FollowerResyncConcurrencyTest.java:311)
at 
org.apache.zookeeper.test.FollowerResyncConcurrencyTest.testResyncBySnapThenDiffAfterFollowerCrashes(FollowerResyncConcurrencyTest.java:176)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)


FAILED:  
org.apache.zookeeper.test.FollowerResyncConcurrencyTest.testFollowerWatcherResync

Error Message:
java.rmi.ServerError: Error occurred in server thread; nested exception is: 
java.lang.OutOfMemoryError: unable to create new native thread

Stack Trace:

Failed: ZOOKEEPER- PreCommit Build #2445

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2445/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 37.66 KB...]
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=C8BBD58DCC07B4A11BBF62B09FC148F8.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1958:
 exec returned: 2

Total time: 2 minutes 28 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3152
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Adding one-line test results to commit status...
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of dbc73792d4ad3ed25c427fadfec399aa38841df9 to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2445/ and 
message: 'FAILURE
 No test results found.'
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2445/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Created] (ZOOKEEPER-3176) Quorum TLS - add config options

Ilya Maykov created ZOOKEEPER-3176:
--

 Summary: Quorum TLS - add config options
 Key: ZOOKEEPER-3176
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3176
 Project: ZooKeeper
  Issue Type: Improvement
Affects Versions: 3.6.0, 3.5.5
Reporter: Ilya Maykov


Some parameters of Quorum TLS connections are not currently configurable. Let's 
add configuration properties for them with reasonable defaults. In particular, 
these are:
 * enabled protocols
 * client auth behavior (want / need / none)
 * a timeout for TLS handshake detection in a UnifiedServerSocket



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #627: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

Github user ivmaykov commented on the issue:

https://github.com/apache/zookeeper/pull/627
  
I'm creating separate JIRAs for the different issues fixed in this PR. I 
will break it up into multiple PRs, one for each JIRA.

Fix port unification: https://jira.apache.org/jira/browse/ZOOKEEPER-3172
Add PEM support: https://jira.apache.org/jira/browse/ZOOKEEPER-3173
Reload certs when file changes: 
https://jira.apache.org/jira/browse/ZOOKEEPER-3174
Test improvements: https://jira.apache.org/jira/browse/ZOOKEEPER-3175
More config options: https://jira.apache.org/jira/browse/ZOOKEEPER-3176



---

[jira] [Commented] (ZOOKEEPER-3176) Quorum TLS - add config options



[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650918#comment-16650918
 ] 

Ilya Maykov commented on ZOOKEEPER-3176:


I have a fix for this that's part of a larger pull request right now 
([https://github.com/apache/zookeeper/pull/627),] however I will be breaking 
the fix out into a separate PR specifically for this issue.

> Quorum TLS - add config options
> ---
>
> Key: ZOOKEEPER-3176
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3176
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.6.0, 3.5.5
>Reporter: Ilya Maykov
>Priority: Major
>
> Some parameters of Quorum TLS connections are not currently configurable. 
> Let's add configuration properties for them with reasonable defaults. In 
> particular, these are:
>  * enabled protocols
>  * client auth behavior (want / need / none)
>  * a timeout for TLS handshake detection in a UnifiedServerSocket



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3175) Quorum TLS - test improvements



[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650917#comment-16650917
 ] 

Ilya Maykov commented on ZOOKEEPER-3175:


I have a fix for this that's part of a larger pull request right now 
([https://github.com/apache/zookeeper/pull/627),] however I will be breaking 
the fix out into a separate PR specifically for this issue.

> Quorum TLS - test improvements
> --
>
> Key: ZOOKEEPER-3175
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3175
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.6.0, 3.5.5
>Reporter: Ilya Maykov
>Priority: Major
>
> To simplify testing of Quorum TLS features, let's encapsulate the 
> functionality of creating test trust/key stores in some helper classes so it 
> can be easily shared between different unit tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ZOOKEEPER-3175) Quorum TLS - test improvements

Ilya Maykov created ZOOKEEPER-3175:
--

 Summary: Quorum TLS - test improvements
 Key: ZOOKEEPER-3175
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3175
 Project: ZooKeeper
  Issue Type: Improvement
Affects Versions: 3.6.0, 3.5.5
Reporter: Ilya Maykov


To simplify testing of Quorum TLS features, let's encapsulate the functionality 
of creating test trust/key stores in some helper classes so it can be easily 
shared between different unit tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3174) Quorum TLS - support reloading trust/key store



[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650914#comment-16650914
 ] 

Ilya Maykov commented on ZOOKEEPER-3174:


I have a fix for this that's part of a larger pull request right now 
([https://github.com/apache/zookeeper/pull/627),] however I will be breaking 
the fix out into a separate PR specifically for this issue.

> Quorum TLS - support reloading trust/key store
> --
>
> Key: ZOOKEEPER-3174
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3174
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.6.0, 3.5.5
>Reporter: Ilya Maykov
>Priority: Major
>
> The Quorum TLS feature recently added in ZOOKEEPER-236 doesn't support 
> reloading a trust/key store from disk when it changes. In an environment 
> where short-lived certificates are used and are refreshed by some background 
> daemon / cron job, this is a problem. Let's support reloading a trust/key 
> store from disk when the file on disk changes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ZOOKEEPER-3174) Quorum TLS - support reloading trust/key store

Ilya Maykov created ZOOKEEPER-3174:
--

 Summary: Quorum TLS - support reloading trust/key store
 Key: ZOOKEEPER-3174
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3174
 Project: ZooKeeper
  Issue Type: Improvement
Affects Versions: 3.6.0, 3.5.5
Reporter: Ilya Maykov


The Quorum TLS feature recently added in ZOOKEEPER-236 doesn't support 
reloading a trust/key store from disk when it changes. In an environment where 
short-lived certificates are used and are refreshed by some background daemon / 
cron job, this is a problem. Let's support reloading a trust/key store from 
disk when the file on disk changes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/669
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2443/



---

Failed: ZOOKEEPER- PreCommit Build #2443

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2443/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 75.46 MB...]
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=22E0C2548CA3D87A7052C3481FFC019C.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1958:
 exec returned: 2

Total time: 20 minutes 21 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3152
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Adding one-line test results to commit status...
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of 6394a94e3a047010718c7b7fdcbf9e2e6d5ba40e to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2443/ and 
message: 'FAILURE
 1686 tests run, 1 skipped, 9 failed.'
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2443/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
9 tests failed.
FAILED:  org.apache.zookeeper.test.NettyNettySuiteTest.testQuorumSystemChange

Error Message:
Timeout occurred. Please note the time in the report does not reflect the time 
until the timeout.

Stack Trace:
junit.framework.AssertionFailedError: Timeout occurred. Please note the time in 
the report does not reflect the time until the timeout.
at java.lang.Thread.run(Thread.java:748)


FAILED:  org.apache.zookeeper.test.FourLetterWordsTest.testFourLetterWords[3]

Error Message:
test timed out after 3 milliseconds

Stack Trace:
org.junit.runners.model.TestTimedOutException: test timed out after 3 
milliseconds
at java.io.FileOutputStream.writeBytes(Native Method)
at java.io.FileOutputStream.write(FileOutputStream.java:326)
at java.io.BufferedOutputStream.write(BufferedOutputStream.java:122)
at java.io.PrintStream.write(PrintStream.java:480)
at java.io.PrintStream.write(PrintStream.java:480)
at sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:221)
at sun.nio.cs.StreamEncoder.implFlushBuffer(StreamEncoder.java:291)
at sun.nio.cs.StreamEncoder.implFlush(StreamEncoder.java:295)
at sun.nio.cs.StreamEncoder.flush(StreamEncoder.java:141)
at

[GitHub] zookeeper issue #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

2018-10-15 Thread enixon

Github user enixon commented on the issue:

https://github.com/apache/zookeeper/pull/669
  
@ivmaykov (or anyone with a stack overflow account, really), do you want to 
tag a pointer to this PR with 'netty' on stack overflow (as per 
https://netty.io/community.html) and see if any of the project experts want to 
weigh in on this port?



---

[jira] [Commented] (ZOOKEEPER-3173) Quorum TLS - support PEM trust/key stores



[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650909#comment-16650909
 ] 

Ilya Maykov commented on ZOOKEEPER-3173:


I have a fix for this that's part of a larger pull request right now 
([https://github.com/apache/zookeeper/pull/627),] however I will be breaking 
the fix out into a separate PR specifically for this issue.

> Quorum TLS - support PEM trust/key stores
> -
>
> Key: ZOOKEEPER-3173
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3173
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.6.0, 3.5.5
>Reporter: Ilya Maykov
>Priority: Major
>
> ZOOKEEPER-236 is landed so there is some TLS support in Zookeeper now, but 
> only JKS trust stores are supported. JKS is not really used by non-Java 
> software, where PKCS12 and PEM are more standard. Let's add support for PEM 
> trust / key stores to make Quorum TLS easier to use.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ZOOKEEPER-3173) Quorum TLS - support PEM trust/key stores

Ilya Maykov created ZOOKEEPER-3173:
--

 Summary: Quorum TLS - support PEM trust/key stores
 Key: ZOOKEEPER-3173
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3173
 Project: ZooKeeper
  Issue Type: Improvement
Affects Versions: 3.6.0, 3.5.5
Reporter: Ilya Maykov


ZOOKEEPER-236 is landed so there is some TLS support in Zookeeper now, but only 
JKS trust stores are supported. JKS is not really used by non-Java software, 
where PKCS12 and PEM are more standard. Let's add support for PEM trust / key 
stores to make Quorum TLS easier to use.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3172) Quorum TLS - fix port unification to allow rolling upgrades



[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650904#comment-16650904
 ] 

Ilya Maykov commented on ZOOKEEPER-3172:


I have a fix for this that's part of a larger pull request right now 
([https://github.com/apache/zookeeper/pull/627),] however I will be breaking 
the fix out into a separate PR specifically for this issue.

> Quorum TLS - fix port unification to allow rolling upgrades
> ---
>
> Key: ZOOKEEPER-3172
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3172
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: security, server
>Affects Versions: 3.6.0, 3.5.5
>Reporter: Ilya Maykov
>Priority: Major
>
> ZOOKEEPER-236 was committed with port unification support disabled, because 
> of various issues with the implementation. These issues should be fixed so 
> port unification can be enabled again. Port unification is necessary to 
> upgrade an ensemble from plaintext to TLS quorum connections without downtime.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-3172) Quorum TLS - fix port unification to allow rolling upgrades



 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ilya Maykov updated ZOOKEEPER-3172:
---
Affects Version/s: 3.5.5

> Quorum TLS - fix port unification to allow rolling upgrades
> ---
>
> Key: ZOOKEEPER-3172
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3172
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: security, server
>Affects Versions: 3.6.0, 3.5.5
>Reporter: Ilya Maykov
>Priority: Major
>
> ZOOKEEPER-236 was committed with port unification support disabled, because 
> of various issues with the implementation. These issues should be fixed so 
> port unification can be enabled again. Port unification is necessary to 
> upgrade an ensemble from plaintext to TLS quorum connections without downtime.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ZOOKEEPER-3172) Quorum TLS - fix port unification to allow rolling upgrades

Ilya Maykov created ZOOKEEPER-3172:
--

 Summary: Quorum TLS - fix port unification to allow rolling 
upgrades
 Key: ZOOKEEPER-3172
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3172
 Project: ZooKeeper
  Issue Type: Improvement
  Components: security, server
Affects Versions: 3.6.0
Reporter: Ilya Maykov


ZOOKEEPER-236 was committed with port unification support disabled, because of 
various issues with the implementation. These issues should be fixed so port 
unification can be enabled again. Port unification is necessary to upgrade an 
ensemble from plaintext to TLS quorum connections without downtime.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #627: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

2018-10-15 Thread anmolnar

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/627
  
@ivmaykov Sure. I hate committing my own patches, rather wait for others to 
review and merge. Anyway, if no one shows up tomorrow, I'll commit it myself.


---

[GitHub] zookeeper issue #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/669
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2442/



---

Failed: ZOOKEEPER- PreCommit Build #2442

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2442/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 93.11 MB...]
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=C433B8349AF16EA4FEF5117317E1F103.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1958:
 exec returned: 2

Total time: 19 minutes 0 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3152
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Adding one-line test results to commit status...
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of ed07ad40388440aab824c42246d32c68ada3e728 to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2442/ and 
message: 'FAILURE
 1566 tests run, 1 skipped, 6 failed.'
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2442/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
6 tests failed.
FAILED:  
org.apache.zookeeper.test.NettyNettySuiteTest.testPortChangeToBlockedPortLeader

Error Message:
Timeout occurred. Please note the time in the report does not reflect the time 
until the timeout.

Stack Trace:
junit.framework.AssertionFailedError: Timeout occurred. Please note the time in 
the report does not reflect the time until the timeout.
at java.lang.Thread.run(Thread.java:748)


FAILED:  org.apache.zookeeper.test.NioNettySuiteTest.testBulkReconfig

Error Message:
Timeout occurred. Please note the time in the report does not reflect the time 
until the timeout.

Stack Trace:
junit.framework.AssertionFailedError: Timeout occurred. Please note the time in 
the report does not reflect the time until the timeout.
at java.lang.Thread.run(Thread.java:748)


FAILED:  org.apache.zookeeper.test.FourLetterWordsTest.testSetTraceMask[3]

Error Message:
test timed out after 3 milliseconds

Stack Trace:
org.junit.runners.model.TestTimedOutException: test timed out after 3 
milliseconds
at java.lang.Thread.sleep(Native Method)
at 
org.apache.zookeeper.test.ClientBase.waitForServerUp(ClientBase.java:305)
at 
org.apache.zookeeper.test.ClientBase.startServerInstance(ClientBase.java:428)
at

[GitHub] zookeeper pull request #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

2018-10-15 Thread dain

Github user dain commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/669#discussion_r225332620
  
--- Diff: 
zookeeper-common/src/test/java/org/apache/zookeeper/common/TestByteBufAllocator.java
 ---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.common;
+
+import io.netty.buffer.ByteBuf;
+import io.netty.buffer.CompositeByteBuf;
+import io.netty.buffer.PooledByteBufAllocator;
+import io.netty.util.ResourceLeakDetector;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicReference;
+
+/**
+ * This is a custom ByteBufAllocator that tracks outstanding allocations 
and
+ * crashes the program if any of them are leaked.
+ *
+ * Never use this class in production, it will cause your server to run out
+ * of memory! This is because it holds strong references to all allocated
+ * buffers and doesn't release them until checkForLeaks() is called at the
+ * end of a unit test.
+ *
+ * Note: the original code was copied from 
https://github.com/airlift/drift,
+ * with the permission and encouragement of airlift's author (dain). 
Airlift
+ * uses the same apache 2.0 license as Zookeeper so this should be ok.
+ *
+ * However, the code was modified to take advantage of Netty's built-in
+ * leak tracking and make a best effort to print details about buffer 
leaks.
+ */
+public class TestByteBufAllocator extends PooledByteBufAllocator {
+private static AtomicReference INSTANCE =
+new AtomicReference<>(null);
+
+/**
+ * Get the singleton testing allocator.
+ * @return the singleton allocator, creating it if one does not exist.
+ */
+public static TestByteBufAllocator getInstance() {
+TestByteBufAllocator result = INSTANCE.get();
+if (result == null) {
+// Note: the leak detector level never gets reset after this,
+// but that's probably ok since this is only used by test code.
+
ResourceLeakDetector.setLevel(ResourceLeakDetector.Level.PARANOID);
+INSTANCE.compareAndSet(null, new TestByteBufAllocator());
+result = INSTANCE.get();
+}
+return result;
+}
+
+/**
+ * Destroys the singleton testing allocator and throws an error if any 
of the
+ * buffers allocated by it have been leaked. Attempts to print leak 
details to
+ * standard error before throwing, by using netty's built-in leak 
tracking.
+ * Note that this might not always work, since it only triggers when a 
buffer
+ * is garbage-collected and calling System.gc() does not guarantee 
that a buffer
+ * will actually be GC'ed.
+ *
+ * This should be called at the end of a unit test's tearDown() method.
+ */
+public static void checkForLeaks() {
+TestByteBufAllocator result = INSTANCE.getAndSet(null);
+if (result != null) {
+result.checkInstanceForLeaks();
+}
+
+}
+
+private final List trackedBuffers = new ArrayList<>();
+
+public TestByteBufAllocator()
+{
+super(false);
+}
+
+@Override
+protected ByteBuf newHeapBuffer(int initialCapacity, int maxCapacity)
+{
+return track(super.newHeapBuffer(initialCapacity, maxCapacity));
+}
+
+@Override
+protected ByteBuf newDirectBuffer(int initialCapacity, int maxCapacity)
+{
+return track(super.newDirectBuffer(initialCapacity, maxCapacity));
+}
+
+@Override
+public CompositeByteBuf compositeHeapBuffer(int maxNumComponents)
+{
+return track(super.compositeHeapBuffer(maxNumComponents));
+}
+
+@Override
+public CompositeByteBuf compositeDirectBuffer(int maxNumComponents)
+{
+

Re: [VOTE] Maven migration - separation of java files to server and client project?

2018-10-15 Thread Norbert Kalmar

Sorry, I linked the document instead of the PR. I wanted to link the
document at the beginning of the letter after "It was said here"

The PR:
https://github.com/apache/zookeeper/pull/670

Norbert

On Mon, Oct 15, 2018 at 11:49 PM Norbert Kalmar 
wrote:

> Hi community!
>
> As outlined in the start document, it was planned to separate the java
> files to server and client, with common files in a separate common module.
> It was said here:
>
> "Fifth iteration - move src/java/main to zk-server, which will be further
> separated in Phase 2."
>
> But in order to save rebase for the contributors, I merged this into one
> step. (I had a letter about it)
> So I already created zookeeper-server, zookeeper-client and
> zookeeper-common.
>
> But after doing the separation, I have to say... this just hardly makes
> any sense.
> Without breaking backward compatibility by making changes in the package
> structure, it just makes the code more unreadable than before. Multiple
> packages has to be present in all 3 modules (as it was never an intention
> to separate it, so many classes are just not in their logical package, and
> even inner classes used when top level would be required for the
> separation). Client and server code can not be divided to only depend on
> common. Either server depends on client - which makes more sense than the
> other option - or client depend on server.
> (Or make common so fat, only literally a few class remains in server and
> client - which again, makes no sense).
>
> I created a pull request to illustrate what needs to be done, and this is
> not even half complete:
>
> https://docs.google.com/document/d/1WXqhaPlCwchcWc8RCEzbCmVa4WbBDlfR3GQngikGjqc/edit?usp=sharing
>
> Some more detail in the description.
>
> My suggestion:
> forget about zookeeper-client-java and zookeeper-common, and just leave
> zookeeper-server.
>
> It just doesn't make any sense looking at the result, only makes the
> project much more complicated. The java code is too much tangled together.
>
> What would this mean if I just create zookeeper-common? All the files had
> to be renamed anyway, so some now would have 2 renames (fortunately most of
> the files are in zookeeper-server anyway), and possible another rebase for
> some PR's.
>
> Any input is appreciated.
>
> Regards,
> Norbert
>
>
>
>

[VOTE] Maven migration - separation of java files to server and client project?

2018-10-15 Thread Norbert Kalmar

Hi community!

As outlined in the start document, it was planned to separate the java
files to server and client, with common files in a separate common module.
It was said here:

"Fifth iteration - move src/java/main to zk-server, which will be further
separated in Phase 2."

But in order to save rebase for the contributors, I merged this into one
step. (I had a letter about it)
So I already created zookeeper-server, zookeeper-client and
zookeeper-common.

But after doing the separation, I have to say... this just hardly makes any
sense.
Without breaking backward compatibility by making changes in the package
structure, it just makes the code more unreadable than before. Multiple
packages has to be present in all 3 modules (as it was never an intention
to separate it, so many classes are just not in their logical package, and
even inner classes used when top level would be required for the
separation). Client and server code can not be divided to only depend on
common. Either server depends on client - which makes more sense than the
other option - or client depend on server.
(Or make common so fat, only literally a few class remains in server and
client - which again, makes no sense).

I created a pull request to illustrate what needs to be done, and this is
not even half complete:
https://docs.google.com/document/d/1WXqhaPlCwchcWc8RCEzbCmVa4WbBDlfR3GQngikGjqc/edit?usp=sharing

Some more detail in the description.

My suggestion:
forget about zookeeper-client-java and zookeeper-common, and just leave
zookeeper-server.

It just doesn't make any sense looking at the result, only makes the
project much more complicated. The java code is too much tangled together.

What would this mean if I just create zookeeper-common? All the files had
to be renamed anyway, so some now would have 2 renames (fortunately most of
the files are in zookeeper-server anyway), and possible another rebase for
some PR's.

Any input is appreciated.

Regards,
Norbert

[GitHub] zookeeper issue #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/669
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2441/



---

Failed: ZOOKEEPER- PreCommit Build #2441

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2441/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 93.92 MB...]
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1958:
 exec returned: 2

Total time: 19 minutes 10 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3152
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Adding one-line test results to commit status...
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of e0bfb1426250ae7eb7aaeed52885c2e6375f86a8 to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2441/ and 
message: 'FAILURE
 1566 tests run, 1 skipped, 6 failed.'
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2441/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
6 tests failed.
FAILED:  org.apache.zookeeper.test.NettyNettySuiteTest.testRemoveAddOne

Error Message:
Timeout occurred. Please note the time in the report does not reflect the time 
until the timeout.

Stack Trace:
junit.framework.AssertionFailedError: Timeout occurred. Please note the time in 
the report does not reflect the time until the timeout.
at java.lang.Thread.run(Thread.java:748)


FAILED:  org.apache.zookeeper.test.NioNettySuiteTest.testBulkReconfig

Error Message:
Timeout occurred. Please note the time in the report does not reflect the time 
until the timeout.

Stack Trace:
junit.framework.AssertionFailedError: Timeout occurred. Please note the time in 
the report does not reflect the time until the timeout.
at java.lang.Thread.run(Thread.java:748)


FAILED:  org.apache.zookeeper.test.FourLetterWordsTest.testSetTraceMask[3]

Error Message:
test timed out after 3 milliseconds

Stack Trace:
org.junit.runners.model.TestTimedOutException: test timed out after 3 
milliseconds
at java.lang.Thread.sleep(Native Method)
at 
org.apache.zookeeper.test.ClientBase.waitForServerUp(ClientBase.java:305)
at 
org.apache.zookeeper.test.ClientBase.startServerInstance(ClientBase.java:428)
at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:541)
at

Failed: ZOOKEEPER- PreCommit Build #2439

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2439/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 79.35 MB...]
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=07413BE6DA814031C220E99C60FBCE76.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1958:
 exec returned: 2

Total time: 23 minutes 4 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3152
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Adding one-line test results to commit status...
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of 98c210e98ebba527e0f4ac097ad2d37f6ad929c8 to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2439/ and 
message: 'FAILURE
 1565 tests run, 1 skipped, 8 failed.'
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2439/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
8 tests failed.
FAILED:  
org.apache.zookeeper.test.DisconnectedWatcherTest.testManyChildWatchersAutoReset

Error Message:
test timed out after 84 milliseconds

Stack Trace:
org.junit.runners.model.TestTimedOutException: test timed out after 84 
milliseconds
at java.lang.Object.wait(Native Method)
at java.lang.Object.wait(Object.java:502)
at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1524)
at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1507)
at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:1453)
at 
org.apache.zookeeper.test.DisconnectedWatcherTest.testManyChildWatchersAutoReset(DisconnectedWatcherTest.java:236)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:748)


FAILED:  org.apache.zookeeper.test.NettyNettySuiteHammerTest.testObserversHammer

Error Message:
Timeout occurred. Please note the time in the report does not reflect the time 
until the timeout.

Stack Trace:
junit.framework.AssertionFailedError: Timeout occurred. Please note the time in 
the report does not reflect the time until the

[GitHub] zookeeper issue #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/669
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2439/



---

[GitHub] zookeeper issue #668: ZOOKEEPER-3165. Java 9: X509UtilTest.testCreateSSLCont...

Github user ivmaykov commented on the issue:

https://github.com/apache/zookeeper/pull/668
  
Your fix looks fine to me. It's fixed in my stack of FB internal diffs too 
(#627 for the time being), where I am explicit about JKS or PEM format. Didn't 
realize that Java 9 supports PKCS12 key/trust stores now, cool.


---

[GitHub] zookeeper issue #627: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

Github user ivmaykov commented on the issue:

https://github.com/apache/zookeeper/pull/627
  
@anmolnar it doesn't look like #184 is in master branch yet. Do you have 
any ETA on that?


---

[GitHub] zookeeper issue #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

Github user ivmaykov commented on the issue:

https://github.com/apache/zookeeper/pull/184
  
@anmolnar any ETA on merging this to master? I'd like to break up #627 into 
several parts with associated JIRAs and start the process on getting that code 
upstream, but need this code in master first.


---

[jira] [Commented] (ZOOKEEPER-3152) Port ZK netty stack to netty 4



[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650821#comment-16650821
 ] 

Ilya Maykov commented on ZOOKEEPER-3152:


Pull request is up, see https://github.com/apache/zookeeper/pull/669

> Port ZK netty stack to netty 4
> --
>
> Key: ZOOKEEPER-3152
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3152
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client, server
>Affects Versions: 3.6.0
>Reporter: Ilya Maykov
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Netty 3 is super old. Let's port ZK's netty stack to netty 4. I'm working on 
> a patch that I will put up as a pull request on github once we finish testing 
> it internally at Facebook, just getting the Jira ticket ready ahead of time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/669
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2438/



---

Failed: ZOOKEEPER- PreCommit Build #2438

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2438/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 93.41 MB...]
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=1F8C73AA0F085BCB9AE0D6B371DB823E.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1958:
 exec returned: 2

Total time: 18 minutes 55 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3152
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Adding one-line test results to commit status...
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of 34c3e275d012bd14c243633a638c85f1ca4a36c4 to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2438/ and 
message: 'FAILURE
 1566 tests run, 1 skipped, 6 failed.'
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2438/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
6 tests failed.
FAILED:  org.apache.zookeeper.test.FourLetterWordsTest.testSetTraceMask[3]

Error Message:
test timed out after 3 milliseconds

Stack Trace:
org.junit.runners.model.TestTimedOutException: test timed out after 3 
milliseconds
at java.lang.Thread.sleep(Native Method)
at 
org.apache.zookeeper.test.ClientBase.waitForServerUp(ClientBase.java:305)
at 
org.apache.zookeeper.test.ClientBase.startServerInstance(ClientBase.java:428)
at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:541)
at 
org.apache.zookeeper.test.ClientBase.setUpWithServerId(ClientBase.java:528)
at org.apache.zookeeper.test.ClientBase.setUp(ClientBase.java:504)
at 
org.apache.zookeeper.test.FourLetterWordsTest.setUp(FourLetterWordsTest.java:92)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:748)


FAILED:  org.apache.zookeeper.test.FourLetterWordsTest.testValidateConsOutput[3]

Error Message:
test timed out after 3 milliseconds

Stack Trace:
org.junit.runners.model.TestTimedOutException: test timed out after 3 
milliseconds
at java.lang.Thread.sleep(Native Method)
at

Failed: ZOOKEEPER- PreCommit Build #2440

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2440/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 8.80 KB...]
 [exec] 
==
 [exec] 
 [exec] 
 [exec] /home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant  
-Djavac.args=-Xlint -Xmaxwarns 1000 
-Djava5.home=/home/jenkins/tools/java5/latest/ 
-Dforrest.home=/home/jenkins/tools/forrest/latest/ -DZookeeperPatchProcess= 
clean tar > 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess/trunkJavacWarnings.txt
 2>&1
 [exec] Trunk compilation is broken?
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec]   0 00 00 0  0  0 --:--:-- --:--:-- 
--:--:-- 0curl: (6) Could not resolve host: .diffmv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1974:
 exec returned: 1

Total time: 19 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3029
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Adding one-line test results to commit status...
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of 0ba918a53d8204bdb5bdf7d5967d3f3382ca4a70 to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2440/ and 
message: 'FAILURE
 No test results found.'
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2440/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
No tests ran.

[GitHub] zookeeper issue #670: DO_NOT_MERGE - MAVEN MIGRATION - Separation of server ...

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/670
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2440/



---

[GitHub] zookeeper pull request #670: DO_NOT_MERGE - MAVEN MIGRATION - Separation of ...

2018-10-15 Thread nkalmar

GitHub user nkalmar opened a pull request:

https://github.com/apache/zookeeper/pull/670

DO_NOT_MERGE - MAVEN MIGRATION - Separation of server and client

This is to show that unlike I thought at the start of maven migration, 
separating java client and server code is too much of a refactor, and even 
introduces package change (like ConfigException needs to be removed from 
QuorumPeerConfig.ConfigException as both client and server related classes 
throws it. Moving QuorumPeerConfig would bring too much file in common.) 

Also, zookeeper-common, zookeeper-client and zookeeper-server would have 
similar packages, sometimes tripling the package names.

Dependency hierarchy wise server would depend on client, there's no way to 
make the two depend only on common. 

And I didn't even start looking at the tests. Most of them depend on 
ZooKeeper.java and other "main" classes.

My suggestion: just leave zookeeper-server, or just zookeeper. 

An email has been sent to the dev list to start the discussion on this.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nkalmar/zookeeper ZOOKEEPER-3029

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/670.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #670


commit dae0114a829d3f33198c76bf732b35961d5c26b7
Author: Norbert Kalmar 
Date:   2018-10-15T13:51:52Z

ZOOKEEPER-3029 - MAVEN MIGRATION - create pom for core modules

commit 9c0e82fe37f27910daaf20248b3253e2aacef129
Author: Norbert Kalmar 
Date:   2018-10-15T19:34:50Z

common-build-works

commit 0ba918a53d8204bdb5bdf7d5967d3f3382ca4a70
Author: Norbert Kalmar 
Date:   2018-10-15T21:12:25Z

client in progress




---

[GitHub] zookeeper issue #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

Github user ivmaykov commented on the issue:

https://github.com/apache/zookeeper/pull/669
  
@dain take a look at the changes I made to airlift's test ByteBuf 
allocator. With these changes, we (sometimes) get leak details printed to 
stderr if a ByteBuf leaks, before the test crashes. Feel free to incorporate 
the approach into airlift if you want.


---

[jira] [Updated] (ZOOKEEPER-3152) Port ZK netty stack to netty 4

2018-10-15 Thread ASF GitHub Bot (JIRA)



 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-3152:
--
Labels: pull-request-available  (was: )

> Port ZK netty stack to netty 4
> --
>
> Key: ZOOKEEPER-3152
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3152
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client, server
>Affects Versions: 3.6.0
>Reporter: Ilya Maykov
>Priority: Minor
>  Labels: pull-request-available
>
> Netty 3 is super old. Let's port ZK's netty stack to netty 4. I'm working on 
> a patch that I will put up as a pull request on github once we finish testing 
> it internally at Facebook, just getting the Jira ticket ready ahead of time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

GitHub user ivmaykov opened a pull request:

https://github.com/apache/zookeeper/pull/669

ZOOKEEPER-3152: Port ZK netty stack to netty4

Summary: Ported the client connection netty stack from netty3 to netty4. 
This includes both the server side (NettyServerCnxn and friends) and the client 
side (ClientCnxnSocketNetty).

Test Plan: Modified `FourLetterWordsTest` and `NettyServerCnxnTest`, plus 
manual testing on a regional ensemble.

FB Reviewers: nixon

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ivmaykov/zookeeper ZOOKEEPER-3152

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/669.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #669


commit 34c3e275d012bd14c243633a638c85f1ca4a36c4
Author: Ilya Maykov 
Date:   2018-08-31T23:26:55Z

port ZK netty stack from netty3 to netty4

Summary:
Ported the client connection netty stack from netty3 to netty4. This 
includes both the server side
(NettyServerCnxn and friends) and the client side (ClientCnxnSocketNetty).

Test Plan: Modified `FourLetterWordsTest` and `NettyServerCnxnTest`, plus 
manual testing on a regional ensemble.

Reviewers: nixon, nwolchko, nedelchev

Subscribers:

Differential Revision: https://phabricator.intern.facebook.com/D9646262

Tasks:

Tags:

Blame Revision:




---

[jira] [Commented] (ZOOKEEPER-3154) Update release process to use the MarkDown solution

2018-10-15 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650640#comment-16650640
 ] 

Hudson commented on ZOOKEEPER-3154:
---

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #233 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/233/])
ZOOKEEPER-3154: Update release process to use the MarkDown solution (andor: rev 
e92fdfefb86df24d9ef6e68be827e21f55b1c971)
* (edit) zookeeper-docs/src/main/resources/markdown/index.md
* (edit) zookeeper-docs/src/main/resources/markdown/recipes.md
* (edit) zookeeper-docs/src/main/resources/markdown/javaExample.md
* (edit) pom.xml
* (add) zookeeper-docs/src/main/resources/markdown/releasenotes.md
* (edit) build.xml
* (edit) zookeeper-docs/pom.xml


> Update release process to use the MarkDown solution
> ---
>
> Key: ZOOKEEPER-3154
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3154
> Project: ZooKeeper
>  Issue Type: Sub-task
>Reporter: Tamas Penzes
>Assignee: Tamas Penzes
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5, 3.4.14
>
>  Time Spent: 5h 20m
>  Remaining Estimate: 0h
>
> We have to update the release process to use the MarkDown solution.
> We have to add the zookeeper-docs/src/main/resources/markdown and the 
> zookeeper-docs/target/html directories and their content to the tarball.
> We also have to remove the old mechanism of adding PDFs and old generated 
> HTML files to the tarball in the same time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ZooKeeper-trunk - Build # 233 - Failure

See https://builds.apache.org/job/ZooKeeper-trunk/233/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 196.09 KB...]
[junit] Running org.apache.zookeeper.server.quorum.Zab1_0Test in thread 1
[junit] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
37.547 sec, Thread: 1, Class: org.apache.zookeeper.server.quorum.Zab1_0Test
[junit] Running org.apache.zookeeper.server.quorum.auth.MiniKdcTest in 
thread 1
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.921 sec, Thread: 1, Class: org.apache.zookeeper.server.quorum.auth.MiniKdcTest
[junit] Running 
org.apache.zookeeper.server.quorum.auth.QuorumAuthUpgradeTest in thread 1
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
37.071 sec, Thread: 1, Class: 
org.apache.zookeeper.server.quorum.auth.QuorumAuthUpgradeTest
[junit] Running 
org.apache.zookeeper.server.quorum.auth.QuorumDigestAuthTest in thread 1
[junit] Tests run: 24, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 
262.095 sec, Thread: 3, Class: 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest
[junit] Test org.apache.zookeeper.server.quorum.QuorumPeerMainTest FAILED
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
99.434 sec, Thread: 2, Class: 
org.apache.zookeeper.server.quorum.StandaloneDisabledTest
[junit] Running 
org.apache.zookeeper.server.quorum.auth.QuorumKerberosAuthTest in thread 3
[junit] Running 
org.apache.zookeeper.server.quorum.auth.QuorumKerberosHostBasedAuthTest in 
thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
7.053 sec, Thread: 3, Class: 
org.apache.zookeeper.server.quorum.auth.QuorumKerberosAuthTest
[junit] Running org.apache.zookeeper.server.util.BitHashSetTest in thread 3
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.12 sec, Thread: 3, Class: org.apache.zookeeper.server.util.BitHashSetTest
[junit] Running org.apache.zookeeper.server.util.BitMapTest in thread 3
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.149 sec, Thread: 3, Class: org.apache.zookeeper.server.util.BitMapTest
[junit] Running org.apache.zookeeper.server.util.ConfigUtilsTest in thread 3
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.167 sec, Thread: 3, Class: org.apache.zookeeper.server.util.ConfigUtilsTest
[junit] Running org.apache.zookeeper.server.util.SerializeUtilsTest in 
thread 3
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.468 sec, Thread: 3, Class: org.apache.zookeeper.server.util.SerializeUtilsTest
[junit] Running org.apache.zookeeper.server.util.VerifyingFileFactoryTest 
in thread 3
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.165 sec, Thread: 3, Class: 
org.apache.zookeeper.server.util.VerifyingFileFactoryTest
[junit] Running org.apache.zookeeper.server.watch.WatchManagerTest in 
thread 3
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
21.302 sec, Thread: 1, Class: 
org.apache.zookeeper.server.quorum.auth.QuorumDigestAuthTest
[junit] Running org.apache.zookeeper.server.watch.WatcherCleanerTest in 
thread 1
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
5.119 sec, Thread: 1, Class: 
org.apache.zookeeper.server.watch.WatcherCleanerTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
7.752 sec, Thread: 3, Class: org.apache.zookeeper.server.watch.WatchManagerTest
[junit] Running org.apache.zookeeper.server.watch.WatcherOrBitSetTest in 
thread 1
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.102 sec, Thread: 1, Class: 
org.apache.zookeeper.server.watch.WatcherOrBitSetTest
[junit] Running org.apache.zookeeper.server.watch.WatchesPathReportTest in 
thread 3
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.081 sec, Thread: 3, Class: 
org.apache.zookeeper.server.watch.WatchesPathReportTest
[junit] Running org.apache.zookeeper.server.watch.WatchesReportTest in 
thread 1
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.112 sec, Thread: 1, Class: org.apache.zookeeper.server.watch.WatchesReportTest
[junit] Running org.apache.zookeeper.server.watch.WatchesSummaryTest in 
thread 3
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.079 sec, Thread: 3, Class: 
org.apache.zookeeper.server.watch.WatchesSummaryTest
[junit] Running org.apache.zookeeper.client.ZKClientConfigTest in thread 1
[junit] Running org.apache.jute.BinaryInputArchiveTest in thread 3
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.245 sec, Thread: 1, Class:

[GitHub] zookeeper issue #662: ZOOKEEPER-3162. Broken lock semantics in C client lock...

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/662
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2437/



---

Success: ZOOKEEPER- PreCommit Build #2437

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2437/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 77.64 MB...]
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 16 minutes 54 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3162
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Adding one-line test results to commit status...
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of 09f7ff4ed14053c50a05168d621b3c3a70a4ef43 to SUCCESS with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2437/ and 
message: 'SUCCESS 
 1760 tests run, 1 skipped, 0 failed.'
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2437/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
All tests passed

Failed: ZOOKEEPER- PreCommit Build #2436

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2436/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 40.37 MB...]
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=02D796F0F4C718482B16220432F687B8.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1966:
 exec returned: 1

Total time: 33 minutes 16 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3154
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Adding one-line test results to commit status...
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of f0c868346a308a60927dca0c1c1fd6382651dbd1 to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2436/ and 
message: 'FAILURE
 657 tests run, 3 skipped, 2 failed.'
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2436/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
2 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderOutOfView

Error Message:
null

Stack Trace:
junit.framework.AssertionFailedError
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderOutOfView(QuorumPeerMainTest.java:1321)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55)


FAILED:  
org.apache.zookeeper.test.RestoreCommittedLogTest.testRestoreCommittedLog

Error Message:
log size != 0

Stack Trace:
junit.framework.AssertionFailedError: log size != 0
at 
org.apache.zookeeper.test.RestoreCommittedLogTest.testRestoreCommittedLog(RestoreCommittedLogTest.java:83)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55)

[GitHub] zookeeper issue #540: Branch 3.4