[GitHub] anmolnar closed pull request #185: Branch 3.5 FLE and ZAB SSL socket support [DO NOT MERGE]
anmolnar closed pull request #185: Branch 3.5 FLE and ZAB SSL socket support [DO NOT MERGE] URL: https://github.com/apache/zookeeper/pull/185 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-2700) Force ZooKeeper to generate snapshot
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2700: -- Labels: pull-request-available (was: ) > Force ZooKeeper to generate snapshot > > > Key: ZOOKEEPER-2700 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2700 > Project: ZooKeeper > Issue Type: Improvement >Reporter: Flier Lu >Priority: Minor > Labels: pull-request-available > > When cold backup or remote offline sync Zookeeper instances, we need the > latest snapshot. > Add a four letter `snap` command to force Zookeeper to generate snapshot. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-2624) Add test script for pull requests
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-2624:
--
Labels: pull-request-available (was: )
> Add test script for pull requests
> -
>
> Key: ZOOKEEPER-2624
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2624
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>Priority: Major
> Labels: pull-request-available
>
> We need a script similar to {{test-patch.sh}} to handle QA builds for pull
> requests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-1364) Add orthogonal fault injection mechanism/framework
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-1364: -- Labels: pull-request-available (was: ) > Add orthogonal fault injection mechanism/framework > -- > > Key: ZOOKEEPER-1364 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1364 > Project: ZooKeeper > Issue Type: Test > Components: tests >Reporter: Andrei Savu >Assignee: Andrei Savu >Priority: Major > Labels: pull-request-available > > Hadoop has a mechanism for doing fault injection (HDFS-435). I think it would > be useful if something similar would be available for ZooKeeper. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] anmolnar closed pull request #188: ZOOKEEPER-236: SSL support for ZAB and FLE [DO NOT MERGE]
anmolnar closed pull request #188: ZOOKEEPER-236: SSL support for ZAB and FLE [DO NOT MERGE] URL: https://github.com/apache/zookeeper/pull/188 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar commented on issue #186: ZOOKEEPER-2711 Avoid synchronization on NettyServerCnxn in Factory
anmolnar commented on issue #186: ZOOKEEPER-2711 Avoid synchronization on NettyServerCnxn in Factory URL: https://github.com/apache/zookeeper/pull/186#issuecomment-458941884 @joshelser Given that we've already upgraded to Netty 4 on master, do you think this patch is still relevant? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-2711) Deadlock between concurrent 4LW commands that iterate over connections with Netty server
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-2711:
--
Labels: pull-request-available (was: )
> Deadlock between concurrent 4LW commands that iterate over connections with
> Netty server
>
>
> Key: ZOOKEEPER-2711
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2711
> Project: ZooKeeper
> Issue Type: Bug
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Labels: pull-request-available
>
> Observed the following issue in some $dayjob testing environments. Line
> numbers are a little off compared to master/branch-3.5, but I did confirm the
> same issue exists there.
> With the NettyServerCnxnFactory, before a request is dispatched, the code
> synchronizes on the {{NettyServerCnxn}} object. However, with some 4LW
> commands (like {{stat}}), each {{ServerCnxn}} object is also synchronized to
> (safely) iterate over the internal contents of the object to generate the
> necessary debug message. As such, multiple concurrent {{stat}} commands can
> both lock their own {{NettyServerCnxn}} objects, and then be blocked waiting
> to lock each others' {{ServerCnxn}} in the {{StatCommand}}, deadlocked.
> {noformat}
> "New I/O worker #55":
> at
> org.apache.zookeeper.server.ServerCnxn.dumpConnectionInfo(ServerCnxn.java:407)
> - waiting to lock <0xfabc01b8> (a
> org.apache.zookeeper.server.NettyServerCnxn)
> at
> org.apache.zookeeper.server.NettyServerCnxn$StatCommand.commandRun(NettyServerCnxn.java:478)
> at
> org.apache.zookeeper.server.NettyServerCnxn$CommandThread.run(NettyServerCnxn.java:311)
> at
> org.apache.zookeeper.server.NettyServerCnxn$CommandThread.start(NettyServerCnxn.java:306)
> at
> org.apache.zookeeper.server.NettyServerCnxn.checkFourLetterWord(NettyServerCnxn.java:677)
> at
> org.apache.zookeeper.server.NettyServerCnxn.receiveMessage(NettyServerCnxn.java:790)
> at
> org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.processMessage(NettyServerCnxnFactory.java:211)
> at
> org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.messageReceived(NettyServerCnxnFactory.java:135)
> - locked <0xfab68178> (a
> org.apache.zookeeper.server.NettyServerCnxn)
> at
> org.jboss.netty.channel.SimpleChannelHandler.handleUpstream(SimpleChannelHandler.java:88)
> at
> org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
> at
> org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:559)
> at
> org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:268)
> at
> org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:255)
> at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:88)
> at
> org.jboss.netty.channel.socket.nio.AbstractNioWorker.process(AbstractNioWorker.java:109)
> at
> org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:312)
> at
> org.jboss.netty.channel.socket.nio.AbstractNioWorker.run(AbstractNioWorker.java:90)
> at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:178)
> at
> org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
> at
> org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> "New I/O worker #51":
> at
> org.apache.zookeeper.server.ServerCnxn.dumpConnectionInfo(ServerCnxn.java:407)
> - waiting to lock <0xfab68178> (a
> org.apache.zookeeper.server.NettyServerCnxn)
> at
> org.apache.zookeeper.server.NettyServerCnxn$StatCommand.commandRun(NettyServerCnxn.java:478)
> at
> org.apache.zookeeper.server.NettyServerCnxn$CommandThread.run(NettyServerCnxn.java:311)
> at
> org.apache.zookeeper.server.NettyServerCnxn$CommandThread.start(NettyServerCnxn.java:306)
> at
> org.apache.zookeeper.server.NettyServerCnxn.checkFourLetterWord(NettyServerCnxn.java:677)
> at
> org.apache.zookeeper.server.NettyServerCnxn.receiveMessage(NettyServerCnxn.java:790)
> at
> org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.processMessage(NettyServerCnxnFactory.java:211)
> at
> org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.messageReceived(NettyServerCnxnFactory.java:135)
> - locked <0xfab
Failed: ZOOKEEPER-2238 PreCommit Build #3725
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2238 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3725/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 8.72 KB...] at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:888) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186) at hudson.scm.SCM.checkout(SCM.java:504) at hudson.model.AbstractProject.checkout(AbstractProject.java:1208) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1810) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --progress git://git.apache.org/zookeeper.git +refs/heads/*:refs/remotes/origin/*" returned status code 128: stdout: stderr: fatal: remote error: access denied or repository not exported: /zookeeper.git at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2038) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1757) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:438) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146) at hudson.remoting.UserRequest.perform(UserRequest.java:212) at hudson.remoting.UserRequest.perform(UserRequest.java:54) at hudson.remoting.Request$2.run(Request.java:369) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:748) Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to H19 at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741) at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357) at hudson.remoting.Channel.call(Channel.java:955) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146) at sun.reflect.GeneratedMethodAccessor499.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132) at com.sun.proxy.$Proxy115.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:886) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186) at hudson.scm.SCM.checkout(SCM.java:504) at hudson.model.AbstractProject.checkout(AbstractProject.java:1208) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1810) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) ERROR: Error fetching remote repo 'origin' Archiving artifacts Recording test results ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error? [description-setter] Could not determine description. Email was triggered for: Failure - Any Sending email for trigger: Failure - Any ### ## FAILED TESTS (if any) #
Failed: ZOOKEEPER-2255 PreCommit Build #3726
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2255 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3726/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 8.74 KB...] at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:888) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186) at hudson.scm.SCM.checkout(SCM.java:504) at hudson.model.AbstractProject.checkout(AbstractProject.java:1208) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1810) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --progress git://git.apache.org/zookeeper.git +refs/heads/*:refs/remotes/origin/*" returned status code 128: stdout: stderr: fatal: remote error: access denied or repository not exported: /zookeeper.git at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2038) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1757) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:438) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146) at hudson.remoting.UserRequest.perform(UserRequest.java:212) at hudson.remoting.UserRequest.perform(UserRequest.java:54) at hudson.remoting.Request$2.run(Request.java:369) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:748) Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to H19 at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741) at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357) at hudson.remoting.Channel.call(Channel.java:955) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146) at sun.reflect.GeneratedMethodAccessor499.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132) at com.sun.proxy.$Proxy115.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:886) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186) at hudson.scm.SCM.checkout(SCM.java:504) at hudson.model.AbstractProject.checkout(AbstractProject.java:1208) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1810) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) ERROR: Error fetching remote repo 'origin' Archiving artifacts Recording test results ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error? [description-setter] Could not determine description. Email was triggered for: Failure - Any Sending email for trigger: Failure - Any ### ## FAILED TESTS (if any) #
[GitHub] anmolnar commented on issue #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't implement maxClientCnxns
anmolnar commented on issue #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't implement maxClientCnxns URL: https://github.com/apache/zookeeper/pull/208#issuecomment-458944328 @eribeiro Do you think this patch is still worth to commit? Would you mind driving this forward? @lvfangmin I think you worked on something similar, didn't you? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar closed pull request #209: ZOOKEEPER-2738 maxClientCnxns not limiting concurrent connections pro…
anmolnar closed pull request #209: ZOOKEEPER-2738 maxClientCnxns not limiting concurrent connections pro… URL: https://github.com/apache/zookeeper/pull/209 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't honor maxClientCnxns param
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2280: -- Labels: pull-request-available (was: ) > NettyServerCnxnFactory doesn't honor maxClientCnxns param > - > > Key: ZOOKEEPER-2280 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.4.6, 3.5.0, 3.5.1 >Reporter: Edward Ribeiro >Assignee: Edward Ribeiro >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch > > > Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it > doesn't enforce this limit in the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-2738) maxClientCnxns not limiting concurrent connections properly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2738: -- Labels: pull-request-available (was: ) > maxClientCnxns not limiting concurrent connections properly > --- > > Key: ZOOKEEPER-2738 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2738 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.5.2, 3.6.0 >Reporter: Vincent Poon >Priority: Major > Labels: pull-request-available > Attachments: MaxCnxnsTest.patch > > > The test MaxCnxnsTest is incorrect as it only creates up the maxCnxns number > of threads, whereas it should create more. See attached patch > When the test is fixed, it fails on master and 3.5, where ZOOKEEPER-1504 > removed some synchronization. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-2736) Add a connection rate limiter
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2736: -- Labels: pull-request-available (was: ) > Add a connection rate limiter > - > > Key: ZOOKEEPER-2736 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2736 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.9, 3.5.2 >Reporter: Vincent Poon >Priority: Major > Labels: pull-request-available > Attachments: ZOOKEEPER-2736.v1.patch > > > Currently the maxClientCnxns property only limits the aggregate number of > connections from a client, but not the rate at which connections can be > created. > This patch adds a configurable connection rate limiter which limits the rate > as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] anmolnar commented on issue #205: ZOOKEEPER-2736 Add a connection rate limiter
anmolnar commented on issue #205: ZOOKEEPER-2736 Add a connection rate limiter URL: https://github.com/apache/zookeeper/pull/205#issuecomment-458945451 @jhuan31 @eribeiro I think this PR can be closed, because #769 has already been merged. What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar closed pull request #148: ZOOKEEPER-2659 Log4j 2 migration
anmolnar closed pull request #148: ZOOKEEPER-2659 Log4j 2 migration URL: https://github.com/apache/zookeeper/pull/148 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar closed pull request #215: ZOOKEEPER-2748: Admin command to voluntarily drop client connections
anmolnar closed pull request #215: ZOOKEEPER-2748: Admin command to voluntarily drop client connections URL: https://github.com/apache/zookeeper/pull/215 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-2748) Admin command to voluntarily drop client connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2748: -- Labels: pull-request-available (was: ) > Admin command to voluntarily drop client connections > > > Key: ZOOKEEPER-2748 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2748 > Project: ZooKeeper > Issue Type: New Feature > Components: server >Reporter: Marco P. >Assignee: Marco P. >Priority: Minor > Labels: pull-request-available > > In certain circumstances, it would be useful to be able to move clients from > one server to another. > One example: a quorum that consists of 3 servers (A,B,C) with 1000 active > client session, where 900 clients are connected to server A, and the > remaining 100 are split over B and C (see example below for an example of how > this can happen). > A will do a lot more work than B, C. > Overall throughput will benefit by having the clients more evenly divided. > In case of A failure, all its client will create an avalanche by migrating en > masse to a different server. > There are other possible use cases for a mechanism to move clients: > - Migrate away all clients before a server restart > - Migrate away part of clients in response to runtime metrics (CPU/Memory > usage, ...) > - Shuffle clients after adding more server capacity (i.e. adding Observer > nodes) > The simplest form of rebalancing which does not require major changes of > protocol or client code consists of requesting a server to voluntarily drop > some number of connections. > Clients should be able to transparently move to a different server. > Patch introducing 4-letter commands to shed clients: > https://github.com/apache/zookeeper/pull/215 > -- -- -- > How client imbalance happens in the first place, an example. > Imagine servers A, B, C and 1000 clients connected. > Initially clients are spread evenly (i.e. 333 clients per server). > A: 333 (restarts: 0) > B: 333 (restarts: 0) > C: 334 (restarts: 0) > Now restart servers a few times, always in A, B, C order (e.g. to pick up a > software upgrades or configuration changes). > Restart A: > A: 0 (restarts: 1) > B: 499 (restarts: 0) > C: 500 (restarts: 0) > Restart B: > A: 250 (restarts: 1) > B: 0 (restarts: 1) > C: 750 (restarts: 0) > Restart C: > A: 625 (restarts: 1) > B: 375 (restarts: 1) > C: 0 (restarts: 1) > The imbalance is pretty bad already. C is idle while A has a lot of work. > A second round of restarts makes the situation even worse: > Restart A: > A: 0 (restarts: 2) > B: 688 (restarts: 1) > C: 313 (restarts: 1) > Restart B: > A: 344 (restarts: 2) > B: 657 (restarts: 1) > C: 0 (restarts: 1) > Restart C: > A: 673 (restarts: 2) > B: 328 (restarts: 1) > C: 0 (restarts: 1) > Large cluster (5, 7, 9 servers) make the imbalance even more evident. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] anmolnar closed pull request #50: ZOOKEEPER-2260: Paginated getChildren call
anmolnar closed pull request #50: ZOOKEEPER-2260: Paginated getChildren call URL: https://github.com/apache/zookeeper/pull/50 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-2260) Paginated getChildren call
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2260: -- Labels: api features pull-request-available (was: api features) > Paginated getChildren call > -- > > Key: ZOOKEEPER-2260 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2260 > Project: ZooKeeper > Issue Type: New Feature >Affects Versions: 3.4.6, 3.5.0 >Reporter: Marco P. >Assignee: Marco P. >Priority: Major > Labels: api, features, pull-request-available > Fix For: 3.6.0, 3.5.5 > > Attachments: ZOOKEEPER-2260.patch, ZOOKEEPER-2260.patch > > > Add pagination support to the getChildren() call, allowing clients to iterate > over children N at the time. > Motivations for this include: > - Getting out of a situation where so many children were created that > listing them exceeded the network buffer sizes (making it impossible to > recover by deleting)[1] > - More efficient traversal of nodes with large number of children [2] > I do have a patch (for 3.4.6) we've been using successfully for a while, but > I suspect much more work is needed for this to be accepted. > [1] https://issues.apache.org/jira/browse/ZOOKEEPER-272 > [2] https://issues.apache.org/jira/browse/ZOOKEEPER-282 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-2659:
--
Labels: pull-request-available (was: )
> Use log4j2 as a logging framework as log4j 1.X is now deprecated
>
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
> Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Labels: pull-request-available
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework.
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-2549) As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main ZK requests processing thread
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2549: -- Labels: pull-request-available (was: ) > As NettyServerCnxn.sendResponse() allows all the exception to bubble up it > can stop main ZK requests processing thread > -- > > Key: ZOOKEEPER-2549 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2549 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.1 >Reporter: Yuliya Feldman >Assignee: Yuliya Feldman >Priority: Major > Labels: pull-request-available > Attachments: ZOOKEEPER-2549-2.patch, ZOOKEEPER-2549-3.patch, > ZOOKEEPER-2549-3.patch, ZOOKEEPER-2549-4.patch, ZOOKEEPER-2549-5.patch, > ZOOKEEPER-2549.patch, ZOOKEEPER-2549.patch, zookeeper-2549-1.patch > > > As NettyServerCnxn.sendResponse() allows all the exception to bubble up it > can stop main ZK requests processing thread and make Zookeeper server look > like it is hanging, while it just can not process any request anymore. > Idea is to catch all the exceptions in NettyServerCnxn.sendResponse() , > convert them to IOException and allow it propagating up -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] anmolnar closed pull request #144: ZOOKEEPER-2325 for branch-3.4.
anmolnar closed pull request #144: ZOOKEEPER-2325 for branch-3.4. URL: https://github.com/apache/zookeeper/pull/144 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar closed pull request #32: Correctly purge log and snapshot files in different directories.
anmolnar closed pull request #32: Correctly purge log and snapshot files in different directories. URL: https://github.com/apache/zookeeper/pull/32 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-2325) Data inconsistency if all snapshots empty or missing
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2325: -- Labels: pull-request-available (was: ) > Data inconsistency if all snapshots empty or missing > > > Key: ZOOKEEPER-2325 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2325 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.4.6 >Reporter: Andrew Grasso >Assignee: Andrew Grasso >Priority: Critical > Labels: pull-request-available > Fix For: 3.5.4, 3.6.0 > > Attachments: ZOOKEEPER-2325-test.patch, ZOOKEEPER-2325.001.patch, > zk.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > When loading state from snapshots on startup, FileTxnSnapLog.java ignores the > result of FileSnap.deserialize, which is -1L if no valid snapshots are found. > Recovery proceeds with dt.lastProcessed == 0, its initial value. > The result is that Zookeeper will process the transaction logs and then begin > serving requests with a different state than the rest of the ensemble. > To reproduce: > In a healthy zookeeper cluster of size >= 3, shut down one node. > Either delete all snapshots for this node or change all to be empty files. > Restart the node. > We believe this can happen organically if a node runs out of disk space. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] anmolnar closed pull request #481: c++ zookeeper based java zookeeper v3.4.11 (re pr)
anmolnar closed pull request #481: c++ zookeeper based java zookeeper v3.4.11 (re pr) URL: https://github.com/apache/zookeeper/pull/481 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar closed pull request #480: c++ zookeeper base java zookeeper v3.4.11
anmolnar closed pull request #480: c++ zookeeper base java zookeeper v3.4.11 URL: https://github.com/apache/zookeeper/pull/480 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Failed: ZOOKEEPER-2549 PreCommit Build #3727
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2549 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3727/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 8.73 KB...] at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:888) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186) at hudson.scm.SCM.checkout(SCM.java:504) at hudson.model.AbstractProject.checkout(AbstractProject.java:1208) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1810) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --progress git://git.apache.org/zookeeper.git +refs/heads/*:refs/remotes/origin/*" returned status code 128: stdout: stderr: fatal: remote error: access denied or repository not exported: /zookeeper.git at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2038) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1757) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:438) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146) at hudson.remoting.UserRequest.perform(UserRequest.java:212) at hudson.remoting.UserRequest.perform(UserRequest.java:54) at hudson.remoting.Request$2.run(Request.java:369) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:748) Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to H6 at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741) at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357) at hudson.remoting.Channel.call(Channel.java:955) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146) at sun.reflect.GeneratedMethodAccessor499.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132) at com.sun.proxy.$Proxy115.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:886) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186) at hudson.scm.SCM.checkout(SCM.java:504) at hudson.model.AbstractProject.checkout(AbstractProject.java:1208) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1810) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) ERROR: Error fetching remote repo 'origin' Archiving artifacts Recording test results ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error? [description-setter] Could not determine description. Email was triggered for: Failure - Any Sending email for trigger: Failure - Any ### ## FAILED TESTS (if any) ##
[GitHub] anmolnar closed pull request #386: Cmake fixes
anmolnar closed pull request #386: Cmake fixes URL: https://github.com/apache/zookeeper/pull/386 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar closed pull request #13: Make JMX registration optional
anmolnar closed pull request #13: Make JMX registration optional URL: https://github.com/apache/zookeeper/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar closed pull request #70: Fix NULL handling for getlogin() call
anmolnar closed pull request #70: Fix NULL handling for getlogin() call URL: https://github.com/apache/zookeeper/pull/70 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar closed pull request #83: enable TCP keepalive for the leadership election/quorum socket
anmolnar closed pull request #83: enable TCP keepalive for the leadership election/quorum socket URL: https://github.com/apache/zookeeper/pull/83 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Failed: ZOOKEEPER-2738 PreCommit Build #3728
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2738 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3728/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 8.73 KB...] at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:888) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186) at hudson.scm.SCM.checkout(SCM.java:504) at hudson.model.AbstractProject.checkout(AbstractProject.java:1208) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1810) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --progress git://git.apache.org/zookeeper.git +refs/heads/*:refs/remotes/origin/*" returned status code 128: stdout: stderr: fatal: remote error: access denied or repository not exported: /zookeeper.git at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2038) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1757) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:438) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146) at hudson.remoting.UserRequest.perform(UserRequest.java:212) at hudson.remoting.UserRequest.perform(UserRequest.java:54) at hudson.remoting.Request$2.run(Request.java:369) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:748) Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to H13 at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741) at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357) at hudson.remoting.Channel.call(Channel.java:955) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146) at sun.reflect.GeneratedMethodAccessor499.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132) at com.sun.proxy.$Proxy115.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:886) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186) at hudson.scm.SCM.checkout(SCM.java:504) at hudson.model.AbstractProject.checkout(AbstractProject.java:1208) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1810) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) ERROR: Error fetching remote repo 'origin' Archiving artifacts Recording test results ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error? [description-setter] Could not determine description. Email was triggered for: Failure - Any Sending email for trigger: Failure - Any ### ## FAILED TESTS (if any) #
[GitHub] anmolnar commented on issue #234: [ZOOKEEPER-2765] add C++ client library under contrib
anmolnar commented on issue #234: [ZOOKEEPER-2765] add C++ client library under contrib URL: https://github.com/apache/zookeeper/pull/234#issuecomment-458951454 @lvfangmin @ivmaykov @jtuple @enixon Is this your C++ client? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-2765) modern C++ client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2765: -- Labels: pull-request-available (was: ) > modern C++ client > - > > Key: ZOOKEEPER-2765 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2765 > Project: ZooKeeper > Issue Type: New Feature > Components: c client >Reporter: Edward Carter >Assignee: Edward Carter >Priority: Major > Labels: pull-request-available > > We should add a modern C++ (i.e. C++14, C++17, etc.) client library that > wraps the existing C client. A future issue may replace the C client itself. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] anmolnar closed pull request #775: get update
anmolnar closed pull request #775: get update URL: https://github.com/apache/zookeeper/pull/775 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar closed pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast protocol
anmolnar closed pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast protocol URL: https://github.com/apache/zookeeper/pull/184 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar closed pull request #15: Fix spelling errors
anmolnar closed pull request #15: Fix spelling errors URL: https://github.com/apache/zookeeper/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar closed pull request #51: fix typo of java docs in OutputArchive.java
anmolnar closed pull request #51: fix typo of java docs in OutputArchive.java URL: https://github.com/apache/zookeeper/pull/51 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar closed pull request #71: fix typo of comment in PathTrie
anmolnar closed pull request #71: fix typo of comment in PathTrie URL: https://github.com/apache/zookeeper/pull/71 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar closed pull request #65: ZOOKEEPER-2247
anmolnar closed pull request #65: ZOOKEEPER-2247 URL: https://github.com/apache/zookeeper/pull/65 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-2247) Zookeeper service becomes unavailable when leader fails to write transaction log
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-2247:
--
Labels: pull-request-available (was: )
> Zookeeper service becomes unavailable when leader fails to write transaction
> log
>
>
> Key: ZOOKEEPER-2247
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2247
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Mohammad Arshad
>Assignee: Rakesh R
>Priority: Critical
> Labels: pull-request-available
> Fix For: 3.4.9, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2247-01.patch, ZOOKEEPER-2247-02.patch,
> ZOOKEEPER-2247-03.patch, ZOOKEEPER-2247-04.patch, ZOOKEEPER-2247-05.patch,
> ZOOKEEPER-2247-06.patch, ZOOKEEPER-2247-07.patch, ZOOKEEPER-2247-09.patch,
> ZOOKEEPER-2247-10.patch, ZOOKEEPER-2247-11.patch, ZOOKEEPER-2247-12.patch,
> ZOOKEEPER-2247-13.patch, ZOOKEEPER-2247-14.patch, ZOOKEEPER-2247-15.patch,
> ZOOKEEPER-2247-16.patch, ZOOKEEPER-2247-17.patch, ZOOKEEPER-2247-18.patch,
> ZOOKEEPER-2247-19.patch, ZOOKEEPER-2247-20.patch, ZOOKEEPER-2247-21.patch,
> ZOOKEEPER-2247-22.patch, ZOOKEEPER-2247-23.patch, ZOOKEEPER-2247-b3.5.patch,
> ZOOKEEPER-2247-br-3.4.patch, ZOOKEEPER-2247-br-3.4.patch
>
>
> Zookeeper service becomes unavailable when leader fails to write transaction
> log. Bellow are the exceptions
> {code}
> 2015-08-14 15:41:18,556 [myid:100] - ERROR
> [SyncThread:100:ZooKeeperCriticalThread@48] - Severe unrecoverable error,
> from thread : SyncThread:100
> java.io.IOException: Input/output error
> at sun.nio.ch.FileDispatcherImpl.force0(Native Method)
> at sun.nio.ch.FileDispatcherImpl.force(FileDispatcherImpl.java:76)
> at sun.nio.ch.FileChannelImpl.force(FileChannelImpl.java:376)
> at
> org.apache.zookeeper.server.persistence.FileTxnLog.commit(FileTxnLog.java:331)
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.commit(FileTxnSnapLog.java:380)
> at org.apache.zookeeper.server.ZKDatabase.commit(ZKDatabase.java:563)
> at
> org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:178)
> at
> org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:113)
> 2015-08-14 15:41:18,559 [myid:100] - INFO
> [SyncThread:100:ZooKeeperServer$ZooKeeperServerListenerImpl@500] - Thread
> SyncThread:100 exits, error code 1
> 2015-08-14 15:41:18,559 [myid:100] - INFO
> [SyncThread:100:ZooKeeperServer@523] - shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO
> [SyncThread:100:SessionTrackerImpl@232] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO
> [SyncThread:100:LeaderRequestProcessor@77] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO
> [SyncThread:100:PrepRequestProcessor@1035] - Shutting down
> 2015-08-14 15:41:18,560 [myid:100] - INFO
> [SyncThread:100:ProposalRequestProcessor@88] - Shutting down
> 2015-08-14 15:41:18,561 [myid:100] - INFO
> [SyncThread:100:CommitProcessor@356] - Shutting down
> 2015-08-14 15:41:18,561 [myid:100] - INFO
> [CommitProcessor:100:CommitProcessor@191] - CommitProcessor exited loop!
> 2015-08-14 15:41:18,562 [myid:100] - INFO
> [SyncThread:100:Leader$ToBeAppliedRequestProcessor@915] - Shutting down
> 2015-08-14 15:41:18,562 [myid:100] - INFO
> [SyncThread:100:FinalRequestProcessor@646] - shutdown of request processor
> complete
> 2015-08-14 15:41:18,562 [myid:100] - INFO
> [SyncThread:100:SyncRequestProcessor@191] - Shutting down
> 2015-08-14 15:41:18,563 [myid:100] - INFO [ProcessThread(sid:100
> cport:-1)::PrepRequestProcessor@159] - PrepRequestProcessor exited loop!
> {code}
> After this exception Leader server still remains leader. After this non
> recoverable exception the leader should go down and let other followers
> become leader.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] anmolnar closed pull request #275: ZOOKEEPER-2801: address spelling errors/typos
anmolnar closed pull request #275: ZOOKEEPER-2801: address spelling errors/typos URL: https://github.com/apache/zookeeper/pull/275 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-2801) address spelling errors/typos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2801: -- Labels: pull-request-available (was: ) > address spelling errors/typos > - > > Key: ZOOKEEPER-2801 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2801 > Project: ZooKeeper > Issue Type: Improvement >Affects Versions: 3.5.3 >Reporter: tony mancill >Assignee: tony mancill >Priority: Trivial > Labels: pull-request-available > > This is a follow-on for ZOOKEEPER-2617 (for which I only supplied a patch for > branch-3.4), that addresses minor typos in master. With a slight > modification, the patch also applies against the branch-3.5 branch. > If folks are curious, the typos are spotted with the "spellintian" shipped > with Debian's lintian package. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] anmolnar commented on issue #248: [ZOOKEEPER-2779] Provide a means to disable setting of the Read Only ACL for the reconfig node
anmolnar commented on issue #248: [ZOOKEEPER-2779] Provide a means to disable setting of the Read Only ACL for the reconfig node URL: https://github.com/apache/zookeeper/pull/248#issuecomment-458968967 @Randgalt Are u still working on this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-2779) Add option to not set ACL for reconfig node
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-2779:
--
Labels: pull-request-available (was: )
> Add option to not set ACL for reconfig node
> ---
>
> Key: ZOOKEEPER-2779
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2779
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.5.3
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5
>
>
> ZOOKEEPER-2014 changed the behavior of the /zookeeper/config node by setting
> the ACL to {{ZooDefs.Ids.READ_ACL_UNSAFE}}. This change makes it very
> cumbersome to use the reconfig APIs. It also, perversely, makes security
> worse as the entire ZooKeeper instance must be opened to "super" user while
> enabled reconfig (per {{ReconfigExceptionTest.java}}). Provide a mechanism
> for savvy users to disable this ACL so that an application-specific custom
> ACL can be set.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] anmolnar closed pull request #299: ZOOKEEPER-2827: Code refactoring for `JUTE` module
anmolnar closed pull request #299: ZOOKEEPER-2827: Code refactoring for `JUTE` module URL: https://github.com/apache/zookeeper/pull/299 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Randgalt commented on issue #248: [ZOOKEEPER-2779] Provide a means to disable setting of the Read Only ACL for the reconfig node
Randgalt commented on issue #248: [ZOOKEEPER-2779] Provide a means to disable setting of the Read Only ACL for the reconfig node URL: https://github.com/apache/zookeeper/pull/248#issuecomment-458969630 I've given up trying to get changes into ZooKeeper This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar closed pull request #309: ZOOKEEPER-2490: infinitely connect on windows
anmolnar closed pull request #309: ZOOKEEPER-2490: infinitely connect on windows URL: https://github.com/apache/zookeeper/pull/309 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-2827) Code refactoring for `JUTE` module
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-2827:
--
Labels: pull-request-available (was: )
> Code refactoring for `JUTE` module
> --
>
> Key: ZOOKEEPER-2827
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2827
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jute
>Affects Versions: 3.5.3
>Reporter: Benedict Jin
>Assignee: Benedict Jin
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> * Fix spell issues
> * Simplify `return` clause
> * Using enhanced `for` loop
> * Using `try` clause to release the resource of stream
> * Remove unnecessary `new Class[]{...}` boxing
> * Remove unnecessary `return` clause
> * Remove unnecessary `import`
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] anmolnar closed pull request #199: ZOOKEEPER-2184: Resolve address only on demand.
anmolnar closed pull request #199: ZOOKEEPER-2184: Resolve address only on demand. URL: https://github.com/apache/zookeeper/pull/199 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-2490) infinitely connect on windows
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-2490:
--
Labels: pull-request-available (was: )
> infinitely connect on windows
> -
>
> Key: ZOOKEEPER-2490
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2490
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
>Affects Versions: 3.5.2
> Environment: Windows
>Reporter: spooky000
>Assignee: spooky000
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5
>
> Attachments: ZOOKEEPER-2490.patch, ZOOKEEPER-2490.patch,
> ZOOKEEPER-2490.patch
>
>
> in addrvec_contains function
> this memcmp always return false on windows release build.
> for (i = 0; i < avec->count; i++)
> {
> if(memcmp(&avec->data[i], addr, INET_ADDRSTRLEN) == 0)
> return 1;
> }
> because..
> #define INET_ADDRSTRLEN 16 on linux.
> #define INET_ADDRSTRLEN 22 on windows.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] anmolnar closed pull request #166: ZOOKEEPER-2230: fix ever-increasing auth times when using jgss native Kerberos lib
anmolnar closed pull request #166: ZOOKEEPER-2230: fix ever-increasing auth times when using jgss native Kerberos lib URL: https://github.com/apache/zookeeper/pull/166 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-2230) Connections fo ZooKeeper server becomes slow over time with native GSSAPI
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-2230:
--
Labels: patch pull-request-available (was: patch)
> Connections fo ZooKeeper server becomes slow over time with native GSSAPI
> -
>
> Key: ZOOKEEPER-2230
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2230
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.4.6, 3.4.7, 3.4.8, 3.5.0
> Environment: OS: RHEL6
> Java: 1.8.0_40
> Configuration:
> java.env:
> {noformat}
> SERVER_JVMFLAGS="$SERVER_JVMFLAGS -Xmx5120m"
> SERVER_JVMFLAGS="$SERVER_JVMFLAGS
> -Djava.security.auth.login.config=/local/apps/zookeeper-test1/conf/jaas-server.conf"
> SERVER_JVMFLAGS="$SERVER_JVMFLAGS -Dsun.security.jgss.native=true"
> {noformat}
> jaas-server.conf:
> {noformat}
> Server {
> com.sun.security.auth.module.Krb5LoginModule required
> useKeyTab=true
> isInitiator=false
> principal="zookeeper/@";
> };
> {noformat}
> Process environment:
> {noformat}
> KRB5_KTNAME=/local/apps/zookeeper-test1/conf/keytab
> ZOO_LOG_DIR=/local/apps/zookeeper-test1/log
> ZOOCFGDIR=/local/apps/zookeeper-test1/conf
> {noformat}
>Reporter: Deepesh Reja
>Assignee: Enis Soztutar
>Priority: Major
> Labels: patch, pull-request-available
> Fix For: 3.4.6, 3.4.7, 3.4.8, 3.5.2
>
> Attachments: ZOOKEEPER-2230.patch
>
>
> ZooKeeper server becomes slow over time when native GSSAPI is used. The
> connection to the server starts taking upto 10 seconds.
> This is happening with ZooKeeper-3.4.6 and is fairly reproducible.
> Debug logs:
> {noformat}
> 2015-07-02 00:58:49,318 [myid:] - INFO
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:NIOServerCnxnFactory@197] -
> Accepted socket connection from /:47942
> 2015-07-02 00:58:49,318 [myid:] - DEBUG
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperSaslServer@78] -
> serviceHostname is ''
> 2015-07-02 00:58:49,318 [myid:] - DEBUG
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperSaslServer@79] -
> servicePrincipalName is 'zookeeper'
> 2015-07-02 00:58:49,318 [myid:] - DEBUG
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperSaslServer@80] - SASL
> mechanism(mech) is 'GSSAPI'
> 2015-07-02 00:58:49,324 [myid:] - DEBUG
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperSaslServer@106] - Added
> private credential to subject: [GSSCredential:
> zookeeper@ 1.2.840.113554.1.2.2 Accept [class
> sun.security.jgss.wrapper.GSSCredElement]]
> 2015-07-02 00:58:59,441 [myid:] - DEBUG
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperServer@810] - Session
> establishment request from client /:47942 client's lastZxid is 0x0
> 2015-07-02 00:58:59,441 [myid:] - INFO
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperServer@868] - Client
> attempting to establish new session at /:47942
> 2015-07-02 00:58:59,448 [myid:] - DEBUG
> [SyncThread:0:FinalRequestProcessor@88] - Processing request::
> sessionid:0x14e486028785c81 type:createSession cxid:0x0 zxid:0x110e79
> txntype:-10 reqpath:n/a
> 2015-07-02 00:58:59,448 [myid:] - DEBUG
> [SyncThread:0:FinalRequestProcessor@160] - sessionid:0x14e486028785c81
> type:createSession cxid:0x0 zxid:0x110e79 txntype:-10 reqpath:n/a
> 2015-07-02 00:58:59,448 [myid:] - INFO [SyncThread:0:ZooKeeperServer@617] -
> Established session 0x14e486028785c81 with negotiated timeout 1 for
> client /:47942
> 2015-07-02 00:58:59,452 [myid:] - DEBUG
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperServer@949] - Responding
> to client SASL token.
> 2015-07-02 00:58:59,452 [myid:] - DEBUG
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperServer@953] - Size of
> client SASL token: 706
> 2015-07-02 00:58:59,460 [myid:] - DEBUG
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperServer@984] - Size of
> server SASL response: 161
> 2015-07-02 00:58:59,462 [myid:] - DEBUG
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperServer@949] - Responding
> to client SASL token.
> 2015-07-02 00:58:59,462 [myid:] - DEBUG
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperServer@953] - Size of
> client SASL token: 0
> 2015-07-02 00:58:59,462 [myid:] - DEBUG
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperServer@984] - Size of
> server SASL response: 32
> 2015-07-02 00:58:59,463 [myid:] - DEBUG
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperServer@949] - Responding
> to client SASL token.
> 2015-07-02 00:58:59,463 [myid:] - DEBUG
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperServer@953] - Size of
> client SASL token: 32
> 2015-07-02 00:58:59,464 [myid:] - INFO
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:SaslServerCallbackHandler@118] -
> Succes
Failed: ZOOKEEPER-2490 PreCommit Build #3730
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2490 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3730/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 8.75 KB...] at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:888) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186) at hudson.scm.SCM.checkout(SCM.java:504) at hudson.model.AbstractProject.checkout(AbstractProject.java:1208) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1810) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --progress git://git.apache.org/zookeeper.git +refs/heads/*:refs/remotes/origin/*" returned status code 128: stdout: stderr: fatal: remote error: access denied or repository not exported: /zookeeper.git at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2038) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1757) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:438) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146) at hudson.remoting.UserRequest.perform(UserRequest.java:212) at hudson.remoting.UserRequest.perform(UserRequest.java:54) at hudson.remoting.Request$2.run(Request.java:369) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:748) Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to H15 at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741) at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357) at hudson.remoting.Channel.call(Channel.java:955) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146) at sun.reflect.GeneratedMethodAccessor499.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132) at com.sun.proxy.$Proxy115.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:886) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186) at hudson.scm.SCM.checkout(SCM.java:504) at hudson.model.AbstractProject.checkout(AbstractProject.java:1208) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1810) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) ERROR: Error fetching remote repo 'origin' Archiving artifacts Recording test results ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error? [description-setter] Could not determine description. Email was triggered for: Failure - Any Sending email for trigger: Failure - Any ### ## FAILED TESTS (if any) #
[GitHub] anmolnar closed pull request #302: ZOOKEEPER-2837: Add a special START_SERVER_JVMFLAGS option only for `start` command to distinguish JVMFLAGS and SERVER_JVMFLAGS
anmolnar closed pull request #302: ZOOKEEPER-2837: Add a special START_SERVER_JVMFLAGS option only for `start` command to distinguish JVMFLAGS and SERVER_JVMFLAGS URL: https://github.com/apache/zookeeper/pull/302 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Failed: ZOOKEEPER-2230 PreCommit Build #3729
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2230 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3729/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 8.74 KB...] at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:888) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186) at hudson.scm.SCM.checkout(SCM.java:504) at hudson.model.AbstractProject.checkout(AbstractProject.java:1208) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1810) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --progress git://git.apache.org/zookeeper.git +refs/heads/*:refs/remotes/origin/*" returned status code 128: stdout: stderr: fatal: remote error: access denied or repository not exported: /zookeeper.git at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2038) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1757) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:438) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146) at hudson.remoting.UserRequest.perform(UserRequest.java:212) at hudson.remoting.UserRequest.perform(UserRequest.java:54) at hudson.remoting.Request$2.run(Request.java:369) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:748) Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to H15 at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741) at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357) at hudson.remoting.Channel.call(Channel.java:955) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146) at sun.reflect.GeneratedMethodAccessor499.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132) at com.sun.proxy.$Proxy115.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:886) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186) at hudson.scm.SCM.checkout(SCM.java:504) at hudson.model.AbstractProject.checkout(AbstractProject.java:1208) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1810) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) ERROR: Error fetching remote repo 'origin' Archiving artifacts Recording test results ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error? [description-setter] Could not determine description. Email was triggered for: Failure - Any Sending email for trigger: Failure - Any ### ## FAILED TESTS (if any) #
[jira] [Updated] (ZOOKEEPER-2837) Add a special START_SERVER_JVMFLAGS option only for `start` command to distinguish JVMFLAGS and SERVER_JVMFLAGS
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2837: -- Labels: pull-request-available (was: ) > Add a special START_SERVER_JVMFLAGS option only for `start` command to > distinguish JVMFLAGS and SERVER_JVMFLAGS > --- > > Key: ZOOKEEPER-2837 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2837 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.3 >Reporter: Benedict Jin >Assignee: Benedict Jin >Priority: Major > Labels: pull-request-available > Original Estimate: 72h > Remaining Estimate: 72h > > Add a special START_SERVER_JVMFLAGS option only for `start` command to > distinguish JVMFLAGS and SERVER_JVMFLAGS. > If we use the normal way to add JVM options with `JVMFLAGS` in > `conf/java.env`, then it will effect almost all shell scripts under `bin` > directory. Even if using `SERVER_JVMFLAGS` will effect some commands like > `zkServer.sh status`, include four-letters commands. > For example, if the JVMFLAGS is > ```bash > export JVMFLAGS="-Xms3G -Xmx3G -Xmn1G -XX:+AlwaysPreTouch > -XX:CMSInitiatingOccupancyFraction=70 -XX:+UseParNewGC > -XX:+UseConcMarkSweepGC -XX:+PrintGCDetails -XX:-PrintGCTimeStamps > -Xloggc:/home/zookeeper/logs/zookeeper_`date '+%Y%m%d%H%M%S'`.gc > -XX:-UseGCLogFileRotation -XX:NumberOfGCLogFiles=10 -XX:GCLogFileSize=64M" > ``` > then we will get too many GC log files due to using the `mntr` four-letters > command regularly in some monitor situation. > ```bash > $ ls ~/logs > zookeeper_20170704175942.gc > zookeeper_20170704180101.gc > zookeeper_20170704180201.gc > zookeeper_20170704180301.gc > zookeeper_20170704180401.gc > ... > ``` -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ZOOKEEPER-2837) Add a special START_SERVER_JVMFLAGS option only for `start` command to distinguish JVMFLAGS and SERVER_JVMFLAGS
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-2837. - Resolution: Won't Fix > Add a special START_SERVER_JVMFLAGS option only for `start` command to > distinguish JVMFLAGS and SERVER_JVMFLAGS > --- > > Key: ZOOKEEPER-2837 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2837 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.3 >Reporter: Benedict Jin >Assignee: Benedict Jin >Priority: Major > Labels: pull-request-available > Original Estimate: 72h > Time Spent: 10m > Remaining Estimate: 71h 50m > > Add a special START_SERVER_JVMFLAGS option only for `start` command to > distinguish JVMFLAGS and SERVER_JVMFLAGS. > If we use the normal way to add JVM options with `JVMFLAGS` in > `conf/java.env`, then it will effect almost all shell scripts under `bin` > directory. Even if using `SERVER_JVMFLAGS` will effect some commands like > `zkServer.sh status`, include four-letters commands. > For example, if the JVMFLAGS is > ```bash > export JVMFLAGS="-Xms3G -Xmx3G -Xmn1G -XX:+AlwaysPreTouch > -XX:CMSInitiatingOccupancyFraction=70 -XX:+UseParNewGC > -XX:+UseConcMarkSweepGC -XX:+PrintGCDetails -XX:-PrintGCTimeStamps > -Xloggc:/home/zookeeper/logs/zookeeper_`date '+%Y%m%d%H%M%S'`.gc > -XX:-UseGCLogFileRotation -XX:NumberOfGCLogFiles=10 -XX:GCLogFileSize=64M" > ``` > then we will get too many GC log files due to using the `mntr` four-letters > command regularly in some monitor situation. > ```bash > $ ls ~/logs > zookeeper_20170704175942.gc > zookeeper_20170704180101.gc > zookeeper_20170704180201.gc > zookeeper_20170704180301.gc > zookeeper_20170704180401.gc > ... > ``` -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] lvfangmin commented on issue #780: [ZOOKEEPER-3249] Avoid reverting the cversion and pzxid during replaying txns with fuzzy snapshot
lvfangmin commented on issue #780: [ZOOKEEPER-3249] Avoid reverting the cversion and pzxid during replaying txns with fuzzy snapshot URL: https://github.com/apache/zookeeper/pull/780#issuecomment-458976009 @anmolnar yes, I'll provide another patch to remove the old tricky logic when I confirmed with the metric that those code are dead. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lvfangmin commented on issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot
lvfangmin commented on issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot URL: https://github.com/apache/zookeeper/pull/622#issuecomment-458976267 @anmolnar forgot that part, will post soon. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: GitHub "god" mode
Wow thanks Andor! On Wed, Jan 30, 2019, 6:45 AM Enrico Olivelli Awesome > > Enrico > > Il giorno mer 30 gen 2019, 12:15 Andor Molnar > ha scritto: > > > Hi all, > > > > Because we're running on GitBox now, committers are able to link their > > Apache and GitHub accounts in order to gain write access to GitHub pull > > requests. > > > > With this great new power (and great responsibility) I will start > reviewing > > ancient pull requests and close them if it makes sense. > > > > First good example for that: > > https://github.com/apache/zookeeper/pull/11 > > > > I'll close the obvious ones right on and comment if I'm uncertain. > > > > Best, > > Andor > > >
[jira] [Commented] (ZOOKEEPER-3240) Close socket on Learner shutdown to avoid dangling socket
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756224#comment-16756224
]
Hudson commented on ZOOKEEPER-3240:
---
SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #211 (See
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/211/])
Revert "ZOOKEEPER-3240: Close socket on Learner shutdown to avoid (andor: rev
bcbf64884f2ee3e8a150b0b3c20a8fa03a05162e)
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Follower.java
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Observer.java
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java
> Close socket on Learner shutdown to avoid dangling socket
> -
>
> Key: ZOOKEEPER-3240
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3240
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.6.0
>Reporter: Brian Nixon
>Assignee: Brian Nixon
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> There was a Learner that had two connections to the Leader after that Learner
> hit an unexpected exception during flush txn to disk, which will shutdown
> previous follower instance and restart a new one.
>
> {quote}2018-10-26 02:31:35,568 ERROR
> [SyncThread:3:ZooKeeperCriticalThread@48] - Severe unrecoverable error, from
> thread : SyncThread:3
> java.io.IOException: Input/output error
> at java.base/sun.nio.ch.FileDispatcherImpl.force0(Native Method)
> at
> java.base/sun.nio.ch.FileDispatcherImpl.force(FileDispatcherImpl.java:72)
> at
> java.base/sun.nio.ch.FileChannelImpl.force(FileChannelImpl.java:395)
> at
> org.apache.zookeeper.server.persistence.FileTxnLog.commit(FileTxnLog.java:457)
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.commit(FileTxnSnapLog.java:548)
> at org.apache.zookeeper.server.ZKDatabase.commit(ZKDatabase.java:769)
> at
> org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:246)
> at
> org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:172)
> 2018-10-26 02:31:35,568 INFO [SyncThread:3:ZooKeeperServerListenerImpl@42] -
> Thread SyncThread:3 exits, error code 1
> 2018-10-26 02:31:35,568 INFO [SyncThread:3:SyncRequestProcessor@234] -
> SyncRequestProcessor exited!{quote}
>
> It is supposed to close the previous socket, but it doesn't seem to be done
> anywhere in the code. This leaves the socket open with no one reading from
> it, and caused the queue full and blocked on sender.
>
> Since the LearnerHandler didn't shutdown gracefully, the learner queue size
> keeps growing, the JVM heap size on leader keeps growing and added pressure
> to the GC, and cause high GC time and latency in the quorum.
>
> The simple fix is to gracefully shutdown the socket.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] anmolnar commented on issue #248: [ZOOKEEPER-2779] Provide a means to disable setting of the Read Only ACL for the reconfig node
anmolnar commented on issue #248: [ZOOKEEPER-2779] Provide a means to disable setting of the Read Only ACL for the reconfig node URL: https://github.com/apache/zookeeper/pull/248#issuecomment-458984816 @Randgalt I'd happy to review and commit if you could have rebased it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit closed pull request #780: [ZOOKEEPER-3249] Avoid reverting the cversion and pzxid during replaying txns with fuzzy snapshot
asfgit closed pull request #780: [ZOOKEEPER-3249] Avoid reverting the cversion and pzxid during replaying txns with fuzzy snapshot URL: https://github.com/apache/zookeeper/pull/780 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar commented on issue #780: [ZOOKEEPER-3249] Avoid reverting the cversion and pzxid during replaying txns with fuzzy snapshot
anmolnar commented on issue #780: [ZOOKEEPER-3249] Avoid reverting the cversion and pzxid during replaying txns with fuzzy snapshot URL: https://github.com/apache/zookeeper/pull/780#issuecomment-458986383 Committed to master branch. Thanks @lvfangmin ! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar commented on issue #781: ZOOKEEPER-3251: Add new server metric types: percentile counter and c…
anmolnar commented on issue #781: ZOOKEEPER-3251: Add new server metric types: percentile counter and c… URL: https://github.com/apache/zookeeper/pull/781#issuecomment-458992179 Committed to master branch. Thanks @jhuan31 ! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit closed pull request #781: ZOOKEEPER-3251: Add new server metric types: percentile counter and c…
asfgit closed pull request #781: ZOOKEEPER-3251: Add new server metric types: percentile counter and c… URL: https://github.com/apache/zookeeper/pull/781 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (ZOOKEEPER-3251) Add new server metric types: percentile counter and counter set
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3251. - Resolution: Fixed Issue resolved by pull request 781 [https://github.com/apache/zookeeper/pull/781] > Add new server metric types: percentile counter and counter set > --- > > Key: ZOOKEEPER-3251 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3251 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h > Remaining Estimate: 0h > > This will add three metric types: > AvgMinMaxCounterSet > AvgMinMaxPercentileCounter > AvgMinMaxPercentileCounterSet > The percentile metrics allow us to get a better sense of the latency > distribution. They are more expensive than AvgMinMax counters and are > restricted to latency measurements for now. > The counter set allows the grouping of metrics such as write per namespace, > read per namespace. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
ZooKeeper-trunk - Build # 374 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk/374/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 181.76 KB...] [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.342 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionTimeoutTest [junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 2 [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.089 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionTrackerCheckTest [junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 2 [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.961 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTest [junit] Running org.apache.zookeeper.test.StandaloneTest in thread 3 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.657 sec, Thread: 3, Class: org.apache.zookeeper.test.StandaloneTest [junit] Running org.apache.zookeeper.test.StatTest in thread 3 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.111 sec, Thread: 3, Class: org.apache.zookeeper.test.StatTest [junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 3 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.967 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionUpgradeTest [junit] Running org.apache.zookeeper.test.StringUtilTest in thread 2 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.066 sec, Thread: 2, Class: org.apache.zookeeper.test.StringUtilTest [junit] Running org.apache.zookeeper.test.SyncCallTest in thread 2 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.809 sec, Thread: 2, Class: org.apache.zookeeper.test.SyncCallTest [junit] Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.685 sec, Thread: 3, Class: org.apache.zookeeper.test.StaticHostProviderTest [junit] Running org.apache.zookeeper.test.TruncateTest in thread 3 [junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in thread 2 [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.047 sec, Thread: 3, Class: org.apache.zookeeper.test.TruncateTest [junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 3 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.074 sec, Thread: 3, Class: org.apache.zookeeper.test.WatchedEventTest [junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 3 [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.185 sec, Thread: 3, Class: org.apache.zookeeper.test.WatcherFuncTest [junit] Running org.apache.zookeeper.test.WatcherTest in thread 3 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.917 sec, Thread: 2, Class: org.apache.zookeeper.test.WatchEventWhenAutoResetTest [junit] Running org.apache.zookeeper.test.X509AuthTest in thread 2 [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.082 sec, Thread: 2, Class: org.apache.zookeeper.test.X509AuthTest [junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in thread 2 [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.19 sec, Thread: 2, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest [junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 2 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.767 sec, Thread: 2, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest [junit] Running org.apache.zookeeper.util.PemReaderTest in thread 2 [junit] Tests run: 64, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.225 sec, Thread: 2, Class: org.apache.zookeeper.util.PemReaderTest [junit] Running org.apache.jute.BinaryInputArchiveTest in thread 2 [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.136 sec, Thread: 2, Class: org.apache.jute.BinaryInputArchiveTest [junit] Running org.apache.jute.UtilsTest in thread 2 [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.074 sec, Thread: 2, Class: org.apache.jute.UtilsTest [junit] Running org.apache.jute.XmlInputArchiveTest in thread 2 [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.177 sec, Thread: 2, Class: org.apache.jute.XmlInputArchiveTest [junit] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 30.306 sec, Thread: 3, Class: org.apache.zookeeper.test.WatcherTest [junit] Tests run: 106, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 397.152 sec, Thread: 1, Class: org.apache.zookeeper.test.NioNettySuiteTest [junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 290.
[jira] [Resolved] (ZOOKEEPER-3249) Avoid reverting the cversion and pzxid during replaying txns with fuzzy snapshot
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3249. - Resolution: Fixed Issue resolved by pull request 780 [https://github.com/apache/zookeeper/pull/780] > Avoid reverting the cversion and pzxid during replaying txns with fuzzy > snapshot > > > Key: ZOOKEEPER-3249 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3249 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The only case we need to have [the tricky hack > code|https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java#L1036-L1065] > , is because of the scenario below: > If the child is deleted due to session close and re-created in a different > global session after that the parent is serialized, then when replay the txn > because the node is belonging to a different session, replay the closeSession > txn won't delete it anymore, and we'll get NODEEXISTS error when replay the > createNode txn. In this case, we need to update the cversion and pzxid to the > new value with this tricky code here. > This could be solved in ZOOKEEPER-3145 with explicit CloseSessionTxn. In > theory, with that code, we don't need this kind of hack code anymore, but > there is another case, which could cause the cversion and pzxid being > reverted, and we still need to patch it, here is the scenario: > 1. Start to take snapshot at T0 > 2. Txn T1 create /P/N1, set P's cversion and pzxid to (1, 1) > 3. Txn T2 create /P/N2, set P's cversion and pzxid to (2, 2) > 4. Txn T3 delete /P/N1, set P's pzxid to 3, which is (2, 3) > Those state are in the fuzzy snapshot. > When loading the snapshot and txns during start up based on the current code: > 1. replay T1, since /P/N1 is not exist, we'll overwrite P's cversion and > pzxid to (1, 1) > 2. replay T2, node already exist, so go through the hack code to patch > cversion and pzxid, and it became (2, 2) > 3. replay T3, set P's pzxid to 3, which is now (2, 3) > The state is consistent with the tricky patch code, but it's error-prone and > hacky, we should remove that. To be able to remove that, in this patch, we're > going to check the cversion first and avoid reverting the cversion and pzxid > when replaying txns. > We've also added metrics to verify that logic is not active on prod anymore, > after that I'll open another Jira to remove it to make the logic cleaner. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3240) Close socket on Learner shutdown to avoid dangling socket
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756244#comment-16756244
]
Hudson commented on ZOOKEEPER-3240:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #374 (See
[https://builds.apache.org/job/ZooKeeper-trunk/374/])
Revert "ZOOKEEPER-3240: Close socket on Learner shutdown to avoid (andor: rev
bcbf64884f2ee3e8a150b0b3c20a8fa03a05162e)
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Observer.java
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Follower.java
> Close socket on Learner shutdown to avoid dangling socket
> -
>
> Key: ZOOKEEPER-3240
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3240
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.6.0
>Reporter: Brian Nixon
>Assignee: Brian Nixon
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> There was a Learner that had two connections to the Leader after that Learner
> hit an unexpected exception during flush txn to disk, which will shutdown
> previous follower instance and restart a new one.
>
> {quote}2018-10-26 02:31:35,568 ERROR
> [SyncThread:3:ZooKeeperCriticalThread@48] - Severe unrecoverable error, from
> thread : SyncThread:3
> java.io.IOException: Input/output error
> at java.base/sun.nio.ch.FileDispatcherImpl.force0(Native Method)
> at
> java.base/sun.nio.ch.FileDispatcherImpl.force(FileDispatcherImpl.java:72)
> at
> java.base/sun.nio.ch.FileChannelImpl.force(FileChannelImpl.java:395)
> at
> org.apache.zookeeper.server.persistence.FileTxnLog.commit(FileTxnLog.java:457)
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.commit(FileTxnSnapLog.java:548)
> at org.apache.zookeeper.server.ZKDatabase.commit(ZKDatabase.java:769)
> at
> org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:246)
> at
> org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:172)
> 2018-10-26 02:31:35,568 INFO [SyncThread:3:ZooKeeperServerListenerImpl@42] -
> Thread SyncThread:3 exits, error code 1
> 2018-10-26 02:31:35,568 INFO [SyncThread:3:SyncRequestProcessor@234] -
> SyncRequestProcessor exited!{quote}
>
> It is supposed to close the previous socket, but it doesn't seem to be done
> anywhere in the code. This leaves the socket open with no one reading from
> it, and caused the queue full and blocked on sender.
>
> Since the LearnerHandler didn't shutdown gracefully, the learner queue size
> keeps growing, the JVM heap size on leader keeps growing and added pressure
> to the GC, and cause high GC time and latency in the quorum.
>
> The simple fix is to gracefully shutdown the socket.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: Broken build
This doesn't look good yet. Let's give it some time (til tomorrow) to recover. Andor On Wed, Jan 30, 2019 at 12:08 PM Andor Molnar wrote: > Done. I reverted the patch on 3.5 and master branches. > Hopefully builds will soon become green again. > > Andor > > > > On Wed, Jan 30, 2019 at 11:45 AM Andor Molnar wrote: > >> 2 tests are failing constantly: >> >> >> org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss >> >> org.apache.zookeeper.server.quorum.ReconfigFailureCasesTest.testLeaderTimesoutOnNewQuorum >> >> I reverted "ZOOKEEPER-3240: Close socket on Learner shutdown to avoid >> dangling socket" and now it works. >> >> Andor >> >> >> >> On Wed, Jan 30, 2019 at 11:43 AM Enrico Olivelli >> wrote: >> >>> Do you have failing tests or code does not compile at all? (I don't have >>> my >>> laptop at the moment) >>> >>> Enrico >>> >>> Il giorno mer 30 gen 2019, 11:31 Andor Molnar >> > >>> ha scritto: >>> >>> > Hi team, >>> > >>> > Looks like one of these changes have broken the build: >>> > >>> > >>> >1. ZOOKEEPER-3250 < >>> https://issues.apache.org/jira/browse/ZOOKEEPER-3250 >>> > >: >>> >typo in doc - zookeeperInternals (detail >>> >< >>> > >>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch35_jdk8/1285/changes#detail0 >>> > > >>> >) >>> >2. ZOOKEEPER-3256 < >>> https://issues.apache.org/jira/browse/ZOOKEEPER-3256 >>> > >: >>> >Enable OWASP checks to Maven build (detail >>> >< >>> > >>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch35_jdk8/1285/changes#detail1 >>> > > >>> >) >>> >3. Fix typos (detail >>> >< >>> > >>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch35_jdk8/1285/changes#detail2 >>> > > >>> >) >>> >4. ZOOKEEPER-3236 < >>> https://issues.apache.org/jira/browse/ZOOKEEPER-3236 >>> > >: >>> >Upgrade BouncyCastle (detail >>> >< >>> > >>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch35_jdk8/1285/changes#detail3 >>> > > >>> >) >>> >5. ZOOKEEPER-3240 < >>> https://issues.apache.org/jira/browse/ZOOKEEPER-3240 >>> > >: >>> >Close socket on Learner shutdown to avoid dangling so… (detail >>> >< >>> > >>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch35_jdk8/1285/changes#detail4 >>> > > >>> >) >>> > >>> > I'm trying to revert them one-by-one and see which one is the bad guy. >>> > >>> > Regards, >>> > Andor >>> > >>> >>
[jira] [Resolved] (ZOOKEEPER-3257) Merge count and byte update of Stat
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3257. - Resolution: Fixed Fix Version/s: 3.6.0 Issue resolved by pull request 789 [https://github.com/apache/zookeeper/pull/789] > Merge count and byte update of Stat > --- > > Key: ZOOKEEPER-3257 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3257 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Priority: Trivial > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > There is duplication of effort when updating the stats. Merge the count > update and the byte update into one call and simplify the logic. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] asfgit closed pull request #789: ZOOKEEPER-3257: Merge count and byte update of Stat
asfgit closed pull request #789: ZOOKEEPER-3257: Merge count and byte update of Stat URL: https://github.com/apache/zookeeper/pull/789 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar commented on issue #789: ZOOKEEPER-3257: Merge count and byte update of Stat
anmolnar commented on issue #789: ZOOKEEPER-3257: Merge count and byte update of Stat URL: https://github.com/apache/zookeeper/pull/789#issuecomment-459000210 Committed to master branch. Thanks @enixon ! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (ZOOKEEPER-3257) Merge count and byte update of Stat
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar reassigned ZOOKEEPER-3257: --- Assignee: Brian Nixon > Merge count and byte update of Stat > --- > > Key: ZOOKEEPER-3257 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3257 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Assignee: Brian Nixon >Priority: Trivial > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 40m > Remaining Estimate: 0h > > There is duplication of effort when updating the stats. Merge the count > update and the byte update into one call and simplify the logic. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] anmolnar closed pull request #47: Update zookeeperOver.html
anmolnar closed pull request #47: Update zookeeperOver.html URL: https://github.com/apache/zookeeper/pull/47 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar closed pull request #251: ZOOKEEPER-2781 Flaky test: testClientAuthAgainstNoAuthServerWithLowerSid
anmolnar closed pull request #251: ZOOKEEPER-2781 Flaky test: testClientAuthAgainstNoAuthServerWithLowerSid URL: https://github.com/apache/zookeeper/pull/251 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar commented on issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch
anmolnar commented on issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch URL: https://github.com/apache/zookeeper/pull/136#issuecomment-459004064 @Randgalt Sounds like a great new feature for 3.6 Would you mind rebasing it on master? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (ZOOKEEPER-2765) modern C++ client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756267#comment-16756267 ] Andor Molnar commented on ZOOKEEPER-2765: - I totally support the idea of having an official C++ client, but not in the ZooKeeper repo. It should have its own separate project with a release cycle independent from core ZK. > modern C++ client > - > > Key: ZOOKEEPER-2765 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2765 > Project: ZooKeeper > Issue Type: New Feature > Components: c client >Reporter: Edward Carter >Assignee: Edward Carter >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > We should add a modern C++ (i.e. C++14, C++17, etc.) client library that > wraps the existing C client. A future issue may replace the C client itself. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] anmolnar closed pull request #234: [ZOOKEEPER-2765] add C++ client library under contrib
anmolnar closed pull request #234: [ZOOKEEPER-2765] add C++ client library under contrib URL: https://github.com/apache/zookeeper/pull/234 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar closed pull request #151: Applying ZOOKEEPER-2642 patch to a 3.5 base
anmolnar closed pull request #151: Applying ZOOKEEPER-2642 patch to a 3.5 base URL: https://github.com/apache/zookeeper/pull/151 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: GitHub "god" mode
We're down to 4 pages of open PRs (from 7). Sorry for the huge number of "closed pull request" emails. Andor On Wed, Jan 30, 2019 at 4:08 PM Camille Fournier wrote: > Wow thanks Andor! > > On Wed, Jan 30, 2019, 6:45 AM Enrico Olivelli > > Awesome > > > > Enrico > > > > Il giorno mer 30 gen 2019, 12:15 Andor Molnar > > > ha scritto: > > > > > Hi all, > > > > > > Because we're running on GitBox now, committers are able to link their > > > Apache and GitHub accounts in order to gain write access to GitHub pull > > > requests. > > > > > > With this great new power (and great responsibility) I will start > > reviewing > > > ancient pull requests and close them if it makes sense. > > > > > > First good example for that: > > > https://github.com/apache/zookeeper/pull/11 > > > > > > I'll close the obvious ones right on and comment if I'm uncertain. > > > > > > Best, > > > Andor > > > > > >
Failed: ZOOKEEPER-1416 PreCommit Build #3731
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1416 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3731/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 8.74 KB...] at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:888) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186) at hudson.scm.SCM.checkout(SCM.java:504) at hudson.model.AbstractProject.checkout(AbstractProject.java:1208) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1810) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --progress git://git.apache.org/zookeeper.git +refs/heads/*:refs/remotes/origin/*" returned status code 128: stdout: stderr: fatal: remote error: access denied or repository not exported: /zookeeper.git at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2038) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1757) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:438) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146) at hudson.remoting.UserRequest.perform(UserRequest.java:212) at hudson.remoting.UserRequest.perform(UserRequest.java:54) at hudson.remoting.Request$2.run(Request.java:369) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:748) Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to H15 at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741) at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357) at hudson.remoting.Channel.call(Channel.java:955) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146) at sun.reflect.GeneratedMethodAccessor499.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132) at com.sun.proxy.$Proxy115.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:886) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186) at hudson.scm.SCM.checkout(SCM.java:504) at hudson.model.AbstractProject.checkout(AbstractProject.java:1208) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1810) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) ERROR: Error fetching remote repo 'origin' Archiving artifacts Recording test results ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error? [description-setter] Could not determine description. Email was triggered for: Failure - Any Sending email for trigger: Failure - Any ### ## FAILED TESTS (if any) #
[GitHub] anmolnar commented on issue #395: ZOOKEEPER-2630: Use interface type instead of implementation type whe…
anmolnar commented on issue #395: ZOOKEEPER-2630: Use interface type instead of implementation type whe… URL: https://github.com/apache/zookeeper/pull/395#issuecomment-459007707 @tamaashu @phunt Looks like this patch has been abandoned for a while and the Jira has already been closed. Can we say that this improvement is now trunk-only and close the other PRs? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (ZOOKEEPER-2765) modern C++ client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-2765. - Resolution: Won't Fix > modern C++ client > - > > Key: ZOOKEEPER-2765 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2765 > Project: ZooKeeper > Issue Type: New Feature > Components: c client >Reporter: Edward Carter >Assignee: Edward Carter >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > We should add a modern C++ (i.e. C++14, C++17, etc.) client library that > wraps the existing C client. A future issue may replace the C client itself. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] anmolnar closed pull request #371: ZOOKEEPER-2814: Ignore space after comma in connection string
anmolnar closed pull request #371: ZOOKEEPER-2814: Ignore space after comma in connection string URL: https://github.com/apache/zookeeper/pull/371 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar commented on issue #363: branch-3.4 -- bugfix -- ZOOKEEPER-2894
anmolnar commented on issue #363: branch-3.4 -- bugfix -- ZOOKEEPER-2894 URL: https://github.com/apache/zookeeper/pull/363#issuecomment-459009863 @xoiss Looks like a very nice catch. Would you mind creating a separate pull request for the master branch that we can commit first and backport to other branches? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-2894) Memory and completions leak on zookeeper_close.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2894: -- Labels: easyfix pull-request-available (was: easyfix) > Memory and completions leak on zookeeper_close. > --- > > Key: ZOOKEEPER-2894 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2894 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.10 > Environment: Linux ubuntu 4.4.0-87-generic > gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609 > https://github.com/apache/zookeeper.git > branch-3.4 >Reporter: Alexander A. Strelets >Assignee: Alexander A. Strelets >Priority: Critical > Labels: easyfix, pull-request-available > Fix For: 3.4.10 > > Attachments: zk-will-free-zh-and-lose-completions.png > > > ZooKeeper C Client *+single thread+* build > First of all, ZooKeeper C Client design allows calling _zookeeper_close()_ in > two ways: > a) from a ZooKeeper callback handler (completion or watcher) which in turn is > called through _zookeeper_process()_ > b) and from other places -- i.e., when the call-stack does not pass through > any of zookeeper mechanics prior to enter into mentioned _zookeeper_close()_ > The issue described here below is +specific only to the case (b)+. So, it's > Ok with the case (a). > When _zookeeper_close()_ is called in the (b) way, the following happens: > 1. +If there are requests waiting for responses in _zh.sent_requests_ queue+, > they all are removed from this queue and each of them is "completed" with > personal fake response having status ZCLOSING. Such fake responses are put > into _zh.completions_to_process_ queue. It's Ok > 2. But then, _zh.completions_to_process_ queue is left unhandled. +Neither > completion callbacks are called, nor dynamic memory allocated for fake > responses is freed+ > 3. Different structures within _zh_ are dismissed and finally _zh_ is freed > This is illustrated on the screenshot attached to this ticket: you may see > that the next instruction to execute will be _free(zh)_ while > _zh.completions_to_process_ queue is not empty (see the "Variables" tab to > the right). > Alternatively, the same situation but in the case (a) is handled properly -- > i.e., all completion callback handlers are truly called with ZCLOSING and the > memory is freed, both for subcases (a.1) when there is a failure like > connection-timeout, connection-closed, etc., or (a.2) there is not failure. > The reason is that any callback handler (completion or watcher) in the case > (a) is called from the _process_completions()_ function which runs in the > loop until _zh.completions_to_process_ queue gets empty. So, this function > guarantees this queue to be completely processed even if new completions > occur during reaction on previously queued completions. > *Consequently:* > 1. At least there is definitely the +memory leak+ in the case (b) -- all the > fake responses put into _zh.completions_to_process_ queue are lost after > _free(zh)_ > 2. And it looks like a great misbehavior not to call completions on sent > requests in the case (b) while they are called with ZCLOSING in the case (a) > -- so, I think it's not "by design" but a +completions leak+ > +To reproduce the case (b) do the following:+ > - open ZooKeeper session, connect to a server, receive and process > connected-watch, etc. > - then somewhere +from the main events loop+ call for example _zoo_acreate()_ > with valid arguments -- it shall return ZOK > - then, +immediately after it returned+, call _zookeeper_close()_ > - note that completion callback handler for _zoo_acreate()_ *will not be > called* > +To reproduce the case (a) do the following:+ > - the same as above, open ZooKeeper session, connect to a server, receive and > process connected-watch, etc. > - the same as above, somewhere from the main events loop call for example > _zoo_acreate()_ with valid arguments -- it shall return ZOK > - but now don't call _zookeeper_close()_ immediately -- wait for completion > callback on the commenced request > - when _zoo_acreate()_ completes, +from within its completion callback > handler+, call another _zoo_acreate()_ and immediately after it returned call > _zookeeper_close()_ > - note that completion callback handler for the second _zoo_acreate()_ *will > be called with ZCLOSING, unlike the case (b) described above* > To fix this I propose calling to _process_completions()_ from > _destroy(zhandle_t *zh)_ as it is done in _handle_error(zhandle_t *zh,int > rc)_. > This is a proposed fix: https://github.com/apache/zookeeper/pull/363 > [upd] > There are another tickets with about the same problem: ZOOKEEPER-1493, > ZOOKEEPER-2073 (the "same" just a
[jira] [Updated] (ZOOKEEPER-2630) Use interface type instead of implementation type when appropriate.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2630: -- Labels: newbie pull-request-available refactoring (was: newbie refactoring) > Use interface type instead of implementation type when appropriate. > --- > > Key: ZOOKEEPER-2630 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2630 > Project: ZooKeeper > Issue Type: Improvement >Reporter: Michael Han >Assignee: Tamas Penzes >Priority: Trivial > Labels: newbie, pull-request-available, refactoring > Fix For: 3.6.0 > > > There are a couple of places in code base where we declare a field / variable > as implementation type (i.e. HashMap, HashSet) instead of interface type > (i.e. Map, Set), while in other places we do the opposite by declaring as > interface type. A quick check indicates that most if not all of these places > could be updated so we have a consistent style over the code base (prefer > using interface type), which is also a good coding style to stick per best > practice. > See more info on https://github.com/apache/zookeeper/pull/102 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-2814) Ignore space after comma in connection string
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-2814:
--
Labels: pull-request-available (was: )
> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Assignee: Nikhil Bhide
>Priority: Minor
> Labels: pull-request-available
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space
> optional or produce error on it, as this is a real pain to spot. Using the
> space also makes the connect string more readable. Spaces are not allowed in
> domain names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] anmolnar commented on issue #344: ZOOKEEPER-2836: Fix SocketTimeoutException
anmolnar commented on issue #344: ZOOKEEPER-2836: Fix SocketTimeoutException URL: https://github.com/apache/zookeeper/pull/344#issuecomment-459011290 @bitgaoshu This patch should be committed. Would you please rebase? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-2836) QuorumCnxManager.Listener Thread Better handling of SocketTimeoutException
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2836: -- Labels: pull-request-available (was: ) > QuorumCnxManager.Listener Thread Better handling of SocketTimeoutException > -- > > Key: ZOOKEEPER-2836 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2836 > Project: ZooKeeper > Issue Type: Bug > Components: leaderElection, quorum >Affects Versions: 3.4.6 > Environment: Machine: Linux 3.2.0-4-amd64 #1 SMP Debian 3.2.78-1 > x86_64 GNU/Linux > Java Version: jdk64/jdk1.8.0_40 > zookeeper version: 3.4.6.2.3.2.0-2950 >Reporter: Amarjeet Singh >Assignee: gaoshu >Priority: Critical > Labels: pull-request-available > > QuorumCnxManager Listener thread blocks SocketServer on accept but we are > getting SocketTimeoutException on our boxes after 49days 17 hours . As per > current code there is a 3 times retry and after that it says "_As I'm leaving > the listener thread, I won't be able to participate in leader election any > longer: $/$:3888__" , Once server nodes reache this state and > we restart or add a new node ,it fails to join cluster and logs 'WARN > QuorumPeer/0:0:0:0:0:0:0:0:2181:QuorumCnxManager@383 - Cannot open > channel to 3 at election address $/$:3888' . > As there is no timeout specified for ServerSocket it should never > timeout but there are some already discussed issues where people have seen > this issue and added checks for SocketTimeoutException explicitly like > https://issues.apache.org/jira/browse/KARAF-3325 . > I think we need to handle SocketTimeoutException on similar lines for > zookeeper as well -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] anmolnar commented on issue #298: ZOOKEEPER-2826: Code refactoring for `CLI` module
anmolnar commented on issue #298: ZOOKEEPER-2826: Code refactoring for `CLI` module URL: https://github.com/apache/zookeeper/pull/298#issuecomment-459012057 @asdf2014 Are u still willing to work on this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-2826) Code refactoring for `CLI` module
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2826: -- Labels: pull-request-available (was: ) > Code refactoring for `CLI` module > - > > Key: ZOOKEEPER-2826 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2826 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.5.3 >Reporter: Benedict Jin >Assignee: Benedict Jin >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Original Estimate: 72h > Remaining Estimate: 72h > > * Fix spell issues > * Remove unnecessary `import` > * Make initialization block that related with `options.addOption` into static > * Standardize `StringBuilder#append` usage > * Using `try` clause to release the resource of stream -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-2781) Flaky test: testClientAuthAgainstNoAuthServerWithLowerSid
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2781: -- Labels: pull-request-available (was: ) > Flaky test: testClientAuthAgainstNoAuthServerWithLowerSid > - > > Key: ZOOKEEPER-2781 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2781 > Project: ZooKeeper > Issue Type: Sub-task >Affects Versions: 3.4.10 >Reporter: Abraham Fine >Assignee: Andor Molnar >Priority: Major > Labels: pull-request-available > > Here is an example failing job: > https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1489/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] anmolnar closed pull request #257: ZOOKEEPER-2784: Add same `sid` config problem check
anmolnar closed pull request #257: ZOOKEEPER-2784: Add same `sid` config problem check URL: https://github.com/apache/zookeeper/pull/257 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar closed pull request #293: ZOOKEEPER-2821: 1. Fix spell issues; 2. Remove unnecessary boxing / unboxing; 3. Simplify `return` clause; 4. Remove `final` qualifier from `private` method
anmolnar closed pull request #293: ZOOKEEPER-2821: 1. Fix spell issues; 2. Remove unnecessary boxing / unboxing; 3. Simplify `return` clause; 4. Remove `final` qualifier from `private` method URL: https://github.com/apache/zookeeper/pull/293 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2784: -- Labels: pull-request-available (was: ) > Add some limitations on code level for `SID` to avoid configuration problem > --- > > Key: ZOOKEEPER-2784 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2784 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Affects Versions: 3.5.2 >Reporter: Benedict Jin >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Original Estimate: 168h > Remaining Estimate: 168h > > As so far, `QuorumCnxManager#receiveConnection` cannot find out the same > `SID` problem, then the Zookeeper cluster will start successfully. But the > cluster is not health, and it will throw some problem like `not > synchronized`. So, i thought we should add some limitations on code level for > `SID` to find those configuration problem more early. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
