[GitHub] [zookeeper] lvfangmin commented on issue #843: ZOOKEEPER-3296: Explicitly closing the sslsocket when it failed handshake to prevent issue where peers cannot join quorum

[GitBox]

lvfangmin commented on issue #843: ZOOKEEPER-3296: Explicitly closing the 
sslsocket when it failed handshake to prevent issue where peers cannot join 
quorum
URL: https://github.com/apache/zookeeper/pull/843#issuecomment-494248492
 
 
   @anmolnar the latest code moved the test to the same package.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [ANNOUNCE] Apache ZooKeeper 3.5.5

[Zili Chen]

Congratulations!

rammohan ganapavarapu  于2019年5月21日周二 上午7:25写道：

> Congratulations, finally it's out 😊
>
> On Mon, May 20, 2019, 11:59 AM Enrico Olivelli 
> wrote:
>
> > Congratulations!
> >
> > Enrico
> >
> > Il lun 20 mag 2019, 19:28 Lars Francke  ha
> > scritto:
> >
> > > Congratulations on this release! It looks great and I'm looking forward
> > to
> > > using all those new features.
> > >
> > > Thank you, everyone, for your work on this.
> > >
> > > On Mon, May 20, 2019 at 7:06 PM Andor Molnar  wrote:
> > >
> > > > The Apache ZooKeeper team is proud to announce Apache ZooKeeper
> version
> > > > 3.5.5
> > > >
> > > > ZooKeeper is a high-performance coordination service for distributed
> > > > applications. It exposes common services - such as naming,
> > > > configuration management, synchronization, and group services - in a
> > > > simple interface so you don't have to write them from scratch. You
> can
> > > > use it off-the-shelf to implement consensus, group management, leader
> > > > election, and presence protocols. And you can build on it for your
> > > > own, specific needs.
> > > >
> > > > For ZooKeeper release details and downloads, visit:
> > > > https://zookeeper.apache.org/releases.html
> > > >
> > > > ZooKeeper 3.5.5 Release Notes are at:
> > > > https://zookeeper.apache.org/doc/r3.5.5/releasenotes.html
> > > >
> > > > We would like to thank the contributors that made the release
> possible.
> > > >
> > > > Regards,
> > > >
> > > > The ZooKeeper Team
> > > >
> > > >
> > > >
> > >
> >
>

[GitHub] [zookeeper] vladimirivic commented on issue #953: ZOOKEEPER-3398

[GitBox]

vladimirivic commented on issue #953: ZOOKEEPER-3398
URL: https://github.com/apache/zookeeper/pull/953#issuecomment-494219276
 
 
   Looking into build errors


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (ZOOKEEPER-1425) add version command to the zookeeper client shell

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844453#comment-16844453
 ] 

Hudson commented on ZOOKEEPER-1425:
---

SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #365 (See 
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/365/])
ZOOKEEPER-1425: add version command to the zookeeper client shell (eolivelli: 
rev af59be25c564d34c6620cd931cd84ef5200aa1b3)
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeperMain.java
* (add) 
zookeeper-server/src/main/java/org/apache/zookeeper/cli/VersionCommand.java


> add version command to the zookeeper client shell
> -
>
> Key: ZOOKEEPER-1425
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1425
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client, scripts
>Reporter: Patrick Hunt
>Assignee: maoling
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-1425.patch
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> the client shell is missing a version command. Should return the version e.g. 
> "3.5.0"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3378) Set the quorum cnxn timeout independently from syncLimit

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844454#comment-16844454
 ] 

Hudson commented on ZOOKEEPER-3378:
---

SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #365 (See 
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/365/])
ZOOKEEPER-3378: Set the quorum cnxn timeout independently from syncLimit 
(eolivelli: rev 6e9802b440b0c706a035a25aafe40b28d25dfadc)
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
* (edit) zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md


> Set the quorum cnxn timeout independently from syncLimit
> 
>
> Key: ZOOKEEPER-3378
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3378
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Brian Nixon
>Assignee: Brian Nixon
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> If an ensemble requires a high sync limit to support a large data tree or 
> transaction rate, it can cause the QuorumCxnManager to hang over-long in 
> response to quorum events. Using the sync limit for this timeout is a 
> convenience in terms of keeping all failure detection mechanisms in sync but 
> it is not strictly required for correct behavior.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-3398) Learner.connectToLeader() may take too long to time-out

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-3398:
--
Labels: pull-request-available  (was: )

> Learner.connectToLeader() may take too long to time-out 
> 
>
> Key: ZOOKEEPER-3398
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3398
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: leaderElection, quorum
>Reporter: Vladimir Ivić
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>
> After leader election happens, the followers will connect to the leader which 
> is facilitated by the Learner.connectToLeader() method. 
> Learner.connectToLeader() is relying on the initLimit configuration value to 
> time-out in case the network connection is unreliable. This config may have a 
> high value that could leave the ensemble retrying and waiting in the state of 
> not having quorum for too long. The follower will retry up to 5 times. 
> This patch introduces a new configuration directive that will allow Zookeeper 
> to use different time-out value `connectToLeaderLimit` which then could be 
> set to lower value than `initLimit`.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [zookeeper] vladimirivic opened a new pull request #953: ZOOKEEPER-3398

[GitBox]

vladimirivic opened a new pull request #953: ZOOKEEPER-3398
URL: https://github.com/apache/zookeeper/pull/953
 
 
   After leader election happens, the followers will connect to the leader 
which is facilitated by the Learner.connectToLeader() method. 
   
   Learner.connectToLeader() is relying on the initLimit configuration value to 
time-out in case the network connection is unreliable. This config may have a 
high value that could leave the ensemble retrying and waiting in the state of 
not having quorum for too long. The follower will retry up to 5 times. 
   
   This patch introduces a new configuration directive that will allow 
Zookeeper to use different time-out value `connectToLeaderLimit` which then 
could be set to lower value than `initLimit`.
   
   Test plan:
   - ant clean 
   - ant test-core-java
   
   NOTE: Lots of whitespace changes, hope it helps.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] maoling commented on issue #930: ZOOKEEPER-1425:add version command to the zookeeper client shell

[GitBox]

maoling commented on issue #930: ZOOKEEPER-1425:add version command to the 
zookeeper client shell
URL: https://github.com/apache/zookeeper/pull/930#issuecomment-494215873
 
 
   @eolivelli   Congratulations! :D


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (ZOOKEEPER-3398) Learner.connectToLeader() may take too long to time-out

[JIRA]

Vladimir Ivić created ZOOKEEPER-3398:


 Summary: Learner.connectToLeader() may take too long to time-out 
 Key: ZOOKEEPER-3398
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3398
 Project: ZooKeeper
  Issue Type: Improvement
  Components: leaderElection, quorum
Reporter: Vladimir Ivić
 Fix For: 3.6.0


After leader election happens, the followers will connect to the leader which 
is facilitated by the Learner.connectToLeader() method. 

Learner.connectToLeader() is relying on the initLimit configuration value to 
time-out in case the network connection is unreliable. This config may have a 
high value that could leave the ensemble retrying and waiting in the state of 
not having quorum for too long. The follower will retry up to 5 times. 

This patch introduces a new configuration directive that will allow Zookeeper 
to use different time-out value `connectToLeaderLimit` which then could be set 
to lower value than `initLimit`.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3378) Set the quorum cnxn timeout independently from syncLimit

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844392#comment-16844392
 ] 

Hudson commented on ZOOKEEPER-3378:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #530 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/530/])
ZOOKEEPER-3378: Set the quorum cnxn timeout independently from syncLimit 
(eolivelli: rev 6e9802b440b0c706a035a25aafe40b28d25dfadc)
* (edit) zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java


> Set the quorum cnxn timeout independently from syncLimit
> 
>
> Key: ZOOKEEPER-3378
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3378
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Brian Nixon
>Assignee: Brian Nixon
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> If an ensemble requires a high sync limit to support a large data tree or 
> transaction rate, it can cause the QuorumCxnManager to hang over-long in 
> response to quorum events. Using the sync limit for this timeout is a 
> convenience in terms of keeping all failure detection mechanisms in sync but 
> it is not strictly required for correct behavior.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-1425) add version command to the zookeeper client shell

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844391#comment-16844391
 ] 

Hudson commented on ZOOKEEPER-1425:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #530 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/530/])
ZOOKEEPER-1425: add version command to the zookeeper client shell (eolivelli: 
rev af59be25c564d34c6620cd931cd84ef5200aa1b3)
* (add) 
zookeeper-server/src/main/java/org/apache/zookeeper/cli/VersionCommand.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeperMain.java


> add version command to the zookeeper client shell
> -
>
> Key: ZOOKEEPER-1425
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1425
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client, scripts
>Reporter: Patrick Hunt
>Assignee: maoling
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-1425.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> the client shell is missing a version command. Should return the version e.g. 
> "3.5.0"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3263) Illegal reflective access in zookeer's kerberosUtil

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844390#comment-16844390
 ] 

Hudson commented on ZOOKEEPER-3263:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #530 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/530/])
ZOOKEEPER-3263: JAVA9/11 Warnings: Illegal reflective access in (eolivelli: rev 
777f0c15e73a8401a648c3cff93d20b3d3e4ee17)
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerHandlerMetricsTest.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/util/SerializeUtilsTest.java
* (edit) ivy.xml
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/ClientReconnectTest.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LeaderBeanTest.java
* (edit) zookeeper-server/pom.xml
* (edit) build.xml
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/PrepRequestProcessorMetricsTest.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/ConnectionMetricsTest.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/FinalRequestProcessorTest.java
* (edit) zookeeper-docs/pom.xml
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/util/KerberosUtil.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerHandlerTest.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/RemotePeerBeanTest.java
* (edit) pom.xml
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LocalPeerBeanTest.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/WatchLeakTest.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java


> Illegal reflective access in zookeer's kerberosUtil
> ---
>
> Key: ZOOKEEPER-3263
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3263
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.13
>Reporter: Pradeep Bansal
>Assignee: Andor Molnar
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> I am using kafka 2.11-2.1.0 with Java 11. Kafka is using zookeeper-3.4.13.jar 
> and when am running kafka-acl script to maange ACLs, I am getting below 
> warning. Is there a way to resolve this?
> {{WARNING: An illegal reflective access operation has occurred WARNING: 
> Illegal reflective access by org.apache.zookeeper.server.util.KerberosUtil 
> (file://apache/kafka/kafka_2.11-2.1.0/libs/zookeeper-3.4.13.jar) to method 
> sun.security.krb5.Config.getInstance() WARNING: Please consider reporting 
> this to the maintainers of org.apache.zookeeper.server.util.KerberosUtil 
> WARNING: Use --illegal-access=warn to enable warnings of further illegal 
> reflective access operations WARNING: All illegal access operations will be 
> denied in a future release}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-1147) Add support for local sessions

[Brian Nixon (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844382#comment-16844382
 ] 

Brian Nixon commented on ZOOKEEPER-1147:


Checking the usual places, I don't see any good documentation. The only good 
description of the feature is on this ticket.

 

Seems like an obvious oversight - a new ticket should be created 
([https://zookeeper.apache.org/doc/r3.5.5/zookeeperProgrammers.html#ch_zkSessions]
 seems like a reasonable place to land the feature description).

> Add support for local sessions
> --
>
> Key: ZOOKEEPER-1147
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1147
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.3.3
>Reporter: Vishal Kathuria
>Assignee: Thawan Kooburat
>Priority: Major
>  Labels: api-change, scaling
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1147.patch, ZOOKEEPER-1147.patch, 
> ZOOKEEPER-1147.patch, ZOOKEEPER-1147.patch, ZOOKEEPER-1147.patch, 
> ZOOKEEPER-1147.patch, ZOOKEEPER-1147.patch, ZOOKEEPER-1147.patch, 
> ZOOKEEPER-1147.patch
>
>   Original Estimate: 840h
>  Remaining Estimate: 840h
>
> This improvement is in the bucket of making ZooKeeper work at a large scale. 
> We are planning on having about a 1 million clients connect to a ZooKeeper 
> ensemble through a set of 50-100 observers. Majority of these clients are 
> read only - ie they do not do any updates or create ephemeral nodes.
> In ZooKeeper today, the client creates a session and the session creation is 
> handled like any other update. In the above use case, the session create/drop 
> workload can easily overwhelm an ensemble. The following is a proposal for a 
> "local session", to support a larger number of connections.
> 1.   The idea is to introduce a new type of session - "local" session. A 
> "local" session doesn't have a full functionality of a normal session.
> 2.   Local sessions cannot create ephemeral nodes.
> 3.   Once a local session is lost, you cannot re-establish it using the 
> session-id/password. The session and its watches are gone for good.
> 4.   When a local session connects, the session info is only maintained 
> on the zookeeper server (in this case, an observer) that it is connected to. 
> The leader is not aware of the creation of such a session and there is no 
> state written to disk.
> 5.   The pings and expiration is handled by the server that the session 
> is connected to.
> With the above changes, we can make ZooKeeper scale to a much larger number 
> of clients without making the core ensemble a bottleneck.
> In terms of API, there are two options that are being considered
> 1. Let the client specify at the connect time which kind of session do they 
> want.
> 2. All sessions connect as local sessions and automatically get promoted to 
> global sessions when they do an operation that requires a global session 
> (e.g. creating an ephemeral node)
> Chubby took the approach of lazily promoting all sessions to global, but I 
> don't think that would work in our case, where we want to keep sessions which 
> never create ephemeral nodes as always local. Option 2 would make it more 
> broadly usable but option 1 would be easier to implement.
> We are thinking of implementing option 1 as the first cut. There would be a 
> client flag, IsLocalSession (much like the current readOnly flag) that would 
> be used to determine whether to create a local session or a global session.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [ANNOUNCE] Apache ZooKeeper 3.5.5

[rammohan ganapavarapu]

Congratulations, finally it's out 😊

On Mon, May 20, 2019, 11:59 AM Enrico Olivelli  wrote:

> Congratulations!
>
> Enrico
>
> Il lun 20 mag 2019, 19:28 Lars Francke  ha
> scritto:
>
> > Congratulations on this release! It looks great and I'm looking forward
> to
> > using all those new features.
> >
> > Thank you, everyone, for your work on this.
> >
> > On Mon, May 20, 2019 at 7:06 PM Andor Molnar  wrote:
> >
> > > The Apache ZooKeeper team is proud to announce Apache ZooKeeper version
> > > 3.5.5
> > >
> > > ZooKeeper is a high-performance coordination service for distributed
> > > applications. It exposes common services - such as naming,
> > > configuration management, synchronization, and group services - in a
> > > simple interface so you don't have to write them from scratch. You can
> > > use it off-the-shelf to implement consensus, group management, leader
> > > election, and presence protocols. And you can build on it for your
> > > own, specific needs.
> > >
> > > For ZooKeeper release details and downloads, visit:
> > > https://zookeeper.apache.org/releases.html
> > >
> > > ZooKeeper 3.5.5 Release Notes are at:
> > > https://zookeeper.apache.org/doc/r3.5.5/releasenotes.html
> > >
> > > We would like to thank the contributors that made the release possible.
> > >
> > > Regards,
> > >
> > > The ZooKeeper Team
> > >
> > >
> > >
> >
>

[jira] [Resolved] (ZOOKEEPER-3349) QuorumCnxManager socketTimeout unused

[Brian Nixon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Nixon resolved ZOOKEEPER-3349.

   Resolution: Not A Problem
Fix Version/s: 3.6.0

> QuorumCnxManager socketTimeout unused
> -
>
> Key: ZOOKEEPER-3349
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3349
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: quorum
>Affects Versions: 3.6.0
>Reporter: Brian Nixon
>Priority: Trivial
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> QuorumCnxManager member variable 'socketTimeout' is not used anywhere in the 
> class. It's clear from the context that it should either be removed entirely 
> or invoked in QuorumCnxManager::setSockOpts. Since the QuorumPeer syncLimit 
> can be changed by jmx, I'm thinking that the former is the better solution.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (ZOOKEEPER-3349) QuorumCnxManager socketTimeout unused

[Brian Nixon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Nixon reassigned ZOOKEEPER-3349:
--

Assignee: Brian Nixon

> QuorumCnxManager socketTimeout unused
> -
>
> Key: ZOOKEEPER-3349
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3349
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: quorum
>Affects Versions: 3.6.0
>Reporter: Brian Nixon
>Assignee: Brian Nixon
>Priority: Trivial
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> QuorumCnxManager member variable 'socketTimeout' is not used anywhere in the 
> class. It's clear from the context that it should either be removed entirely 
> or invoked in QuorumCnxManager::setSockOpts. Since the QuorumPeer syncLimit 
> can be changed by jmx, I'm thinking that the former is the better solution.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3349) QuorumCnxManager socketTimeout unused

[Brian Nixon (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844371#comment-16844371
 ] 

Brian Nixon commented on ZOOKEEPER-3349:


This parameter is being used again as of ZOOKEEPER-3378. Nothing to do here.

> QuorumCnxManager socketTimeout unused
> -
>
> Key: ZOOKEEPER-3349
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3349
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: quorum
>Affects Versions: 3.6.0
>Reporter: Brian Nixon
>Priority: Trivial
>  Labels: pull-request-available
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> QuorumCnxManager member variable 'socketTimeout' is not used anywhere in the 
> class. It's clear from the context that it should either be removed entirely 
> or invoked in QuorumCnxManager::setSockOpts. Since the QuorumPeer syncLimit 
> can be changed by jmx, I'm thinking that the former is the better solution.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [zookeeper] enixon closed pull request #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused

[GitBox]

enixon closed pull request #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout 
unused
URL: https://github.com/apache/zookeeper/pull/895
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] enixon commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused

[GitBox]

enixon commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout 
unused
URL: https://github.com/apache/zookeeper/pull/895#issuecomment-494180419
 
 
   Closing as obviated by #932. I'll close the backing ticket as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (ZOOKEEPER-1000) Provide SSL in zookeeper to be able to run cross colos.

[Brian Nixon (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844370#comment-16844370
 ] 

Brian Nixon commented on ZOOKEEPER-1000:


That's my take as well. Not sure what else there would be to do here.

> Provide SSL in zookeeper to be able to run cross colos.
> ---
>
> Key: ZOOKEEPER-1000
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1000
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Mahadev konar
>Assignee: Mahadev konar
>Priority: Major
> Fix For: 3.6.0, 3.5.6
>
>
> This jira is to track SSL for zookeeper. The inter zookeeper server 
> communication and the client to server communication should be over ssl so 
> that zookeeper can be deployed over WAN's. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-1000) Provide SSL in zookeeper to be able to run cross colos.

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844348#comment-16844348
 ] 

Andrew Purtell commented on ZOOKEEPER-1000:
---

This is a dup of ZOOKEEPER-236 ? Should it be closed?

> Provide SSL in zookeeper to be able to run cross colos.
> ---
>
> Key: ZOOKEEPER-1000
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1000
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Mahadev konar
>Assignee: Mahadev konar
>Priority: Major
> Fix For: 3.6.0, 3.5.6
>
>
> This jira is to track SSL for zookeeper. The inter zookeeper server 
> communication and the client to server communication should be over ssl so 
> that zookeeper can be deployed over WAN's. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ZOOKEEPER-3378) Set the quorum cnxn timeout independently from syncLimit

[Enrico Olivelli (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Enrico Olivelli resolved ZOOKEEPER-3378.

   Resolution: Fixed
Fix Version/s: 3.6.0

> Set the quorum cnxn timeout independently from syncLimit
> 
>
> Key: ZOOKEEPER-3378
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3378
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Brian Nixon
>Assignee: Brian Nixon
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> If an ensemble requires a high sync limit to support a large data tree or 
> transaction rate, it can cause the QuorumCxnManager to hang over-long in 
> response to quorum events. Using the sync limit for this timeout is a 
> convenience in terms of keeping all failure detection mechanisms in sync but 
> it is not strictly required for correct behavior.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [zookeeper] eolivelli commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused

[GitBox]

eolivelli commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager 
socketTimeout unused
URL: https://github.com/apache/zookeeper/pull/895#issuecomment-494153929
 
 
   @enixon #932 is in


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (ZOOKEEPER-3263) Illegal reflective access in zookeer's kerberosUtil

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844304#comment-16844304
 ] 

Hudson commented on ZOOKEEPER-3263:
---

SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #364 (See 
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/364/])
ZOOKEEPER-3263: JAVA9/11 Warnings: Illegal reflective access in (eolivelli: rev 
777f0c15e73a8401a648c3cff93d20b3d3e4ee17)
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerHandlerTest.java
* (edit) zookeeper-docs/pom.xml
* (edit) ivy.xml
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/PrepRequestProcessorMetricsTest.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LeaderBeanTest.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/util/SerializeUtilsTest.java
* (edit) zookeeper-server/pom.xml
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/FinalRequestProcessorTest.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/util/KerberosUtil.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/WatchLeakTest.java
* (edit) pom.xml
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerHandlerMetricsTest.java
* (edit) build.xml
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/ClientReconnectTest.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/ConnectionMetricsTest.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LocalPeerBeanTest.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/RemotePeerBeanTest.java


> Illegal reflective access in zookeer's kerberosUtil
> ---
>
> Key: ZOOKEEPER-3263
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3263
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.13
>Reporter: Pradeep Bansal
>Assignee: Andor Molnar
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> I am using kafka 2.11-2.1.0 with Java 11. Kafka is using zookeeper-3.4.13.jar 
> and when am running kafka-acl script to maange ACLs, I am getting below 
> warning. Is there a way to resolve this?
> {{WARNING: An illegal reflective access operation has occurred WARNING: 
> Illegal reflective access by org.apache.zookeeper.server.util.KerberosUtil 
> (file://apache/kafka/kafka_2.11-2.1.0/libs/zookeeper-3.4.13.jar) to method 
> sun.security.krb5.Config.getInstance() WARNING: Please consider reporting 
> this to the maintainers of org.apache.zookeeper.server.util.KerberosUtil 
> WARNING: Use --illegal-access=warn to enable warnings of further illegal 
> reflective access operations WARNING: All illegal access operations will be 
> denied in a future release}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [zookeeper] asfgit closed pull request #932: ZOOKEEPER-3378: Set the quorum cnxn timeout independently from syncLimit

[GitBox]

asfgit closed pull request #932: ZOOKEEPER-3378: Set the quorum cnxn timeout 
independently from syncLimit
URL: https://github.com/apache/zookeeper/pull/932
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Failed: ZOOKEEPER-1416 PreCommit Build #3780

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1416
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3780/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 8.80 KB...]
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:894)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1161)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1192)
at hudson.scm.SCM.checkout(SCM.java:504)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1810)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags 
--progress git://git.apache.org/zookeeper.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: fatal: remote error: access denied or repository not exported: 
/zookeeper.git

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2042)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1761)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$400(CliGitAPIImpl.java:72)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:442)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146)
at hudson.remoting.UserRequest.perform(UserRequest.java:212)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to 
H15
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)
at 
hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)
at hudson.remoting.Channel.call(Channel.java:955)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)
at sun.reflect.GeneratedMethodAccessor927.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)
at com.sun.proxy.$Proxy115.execute(Unknown Source)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:892)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1161)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1192)
at hudson.scm.SCM.checkout(SCM.java:504)
at 
hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at 
jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1810)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
ERROR: Error fetching remote repo 'origin'
Archiving artifacts
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
[description-setter] Could not determine description.
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
#

[GitHub] [zookeeper] eolivelli commented on issue #118: ZOOKEEPER-1634: hardening security by teaching server to enforce client authentication.

[GitBox]

eolivelli commented on issue #118: ZOOKEEPER-1634: hardening security by 
teaching server to enforce client authentication.
URL: https://github.com/apache/zookeeper/pull/118#issuecomment-494152116
 
 
   @hanm @anmolnar I agree that this patch will be very useful.
   We could try to split it in parts and commit one change at a time.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] eolivelli commented on issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

[GitBox]

eolivelli commented on issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch
URL: https://github.com/apache/zookeeper/pull/136#issuecomment-494151273
 
 
   @anmolnar did you have time to review this patch ?
   Honestly I would like to see something like these new features in ZooKeeper
   
   cc @lvfangmin 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] ericlee123 closed pull request #924: ZOOKEEPER-3371: Port unification for Jetty admin server

[GitBox]

ericlee123 closed pull request #924: ZOOKEEPER-3371: Port unification for Jetty 
admin server
URL: https://github.com/apache/zookeeper/pull/924
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] ericlee123 opened a new pull request #924: ZOOKEEPER-3371: Port unification for Jetty admin server

[GitBox]

ericlee123 opened a new pull request #924: ZOOKEEPER-3371: Port unification for 
Jetty admin server
URL: https://github.com/apache/zookeeper/pull/924
 
 
   Summary:
   Jetty does not have support for port unification. Subclassing
   of some Java networking libraries is necessary for ZooKeeper to serve
   both HTTP and HTTPS traffic on the same port.
   
   Note: The traffic is encrypted, but the authentication isn't right because 
the certificates are not set up correctly for HTTP requests. This will be fixed 
soon.
   
   Test Plan:
   ```
   [ericlee123 @ ~/zookeeper] (admin-PU) > ant -Dtestcase=JettyAdminServerTest 
test-core-java
   ...
   junit.run-concurrent:
[echo] Running 1 concurrent JUnit processes.
   [junit] Running org.apache.zookeeper.server.admin.JettyAdminServerTest
   [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.394 sec
   
   fail.build.on.test.failure:
   
   junit.run:
   
   test-core-java:
   
   BUILD SUCCESSFUL
   Total time: 9 seconds
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] eolivelli commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory

[GitBox]

eolivelli commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with 
Counter in NettyServerCnxnFactory
URL: https://github.com/apache/zookeeper/pull/912#issuecomment-494148318
 
 
   @anmolnar PTAL


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] asfgit closed pull request #930: ZOOKEEPER-1425:add version command to the zookeeper client shell

[GitBox]

asfgit closed pull request #930: ZOOKEEPER-1425:add version command to the 
zookeeper client shell
URL: https://github.com/apache/zookeeper/pull/930
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (ZOOKEEPER-1425) add version command to the zookeeper client shell

[Enrico Olivelli (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Enrico Olivelli resolved ZOOKEEPER-1425.

   Resolution: Fixed
Fix Version/s: 3.6.0

Issue resolved by pull request 930
[https://github.com/apache/zookeeper/pull/930]

> add version command to the zookeeper client shell
> -
>
> Key: ZOOKEEPER-1425
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1425
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client, scripts
>Reporter: Patrick Hunt
>Assignee: maoling
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-1425.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> the client shell is missing a version command. Should return the version e.g. 
> "3.5.0"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [zookeeper] lvfangmin commented on a change in pull request #924: ZOOKEEPER-3371: Port unification for Jetty admin server

[GitBox]

lvfangmin commented on a change in pull request #924: ZOOKEEPER-3371: Port 
unification for Jetty admin server
URL: https://github.com/apache/zookeeper/pull/924#discussion_r285746448
 
 

 ##
 File path: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/UnifiedConnectionFactory.java
 ##
 @@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server.admin;
+
+import org.eclipse.jetty.io.Connection;
+import org.eclipse.jetty.io.EndPoint;
+import org.eclipse.jetty.io.ssl.SslConnection;
+import org.eclipse.jetty.server.Connector;
+import org.eclipse.jetty.server.ConnectionFactory;
+import org.eclipse.jetty.server.AbstractConnectionFactory;
+import org.eclipse.jetty.http.HttpVersion;
+import org.eclipse.jetty.util.ssl.SslContextFactory;
+import org.eclipse.jetty.util.annotation.Name;
+
+import javax.net.ssl.SSLEngine;
+import javax.net.ssl.SSLSession;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * The purpose of this class is to dynamically determine whether to create
+ * a plaintext or SSL connection whenever newConnection() is called. It works
+ * in conjunction with ReadAheadEnpoint to inspect bytes on the incoming
+ * connection.
+ */
+public class UnifiedConnectionFactory extends AbstractConnectionFactory {
+private static final Logger LOG = 
LoggerFactory.getLogger(UnifiedConnectionFactory.class);
+
+private final SslContextFactory sslContextFactory;
+private final String nextProtocol;
+
+public UnifiedConnectionFactory() { this(HttpVersion.HTTP_1_1.asString()); 
}
+
+public UnifiedConnectionFactory(String nextProtocol) { this(null, 
nextProtocol); }
+
+public UnifiedConnectionFactory(SslContextFactory factory, String 
nextProtocol) {
+super("SSL");
+this.sslContextFactory = (factory == null) ? new SslContextFactory() : 
factory;
+this.nextProtocol = nextProtocol;
+this.addBean(this.sslContextFactory);
+}
+
+public SslContextFactory getSslContextFactory() { return 
this.sslContextFactory; }
+
+@Override
+protected void doStart() throws Exception {
+super.doStart();
+SSLEngine engine = this.sslContextFactory.newSSLEngine();
+SSLSession session = engine.getSession();
+engine.setUseClientMode(false);
+if(session.getPacketBufferSize() > this.getInputBufferSize()) {
 
 Review comment:
   nit: space after if.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] lvfangmin commented on a change in pull request #924: ZOOKEEPER-3371: Port unification for Jetty admin server

[GitBox]

lvfangmin commented on a change in pull request #924: ZOOKEEPER-3371: Port 
unification for Jetty admin server
URL: https://github.com/apache/zookeeper/pull/924#discussion_r285746634
 
 

 ##
 File path: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/JettyAdminServer.java
 ##
 @@ -67,24 +80,75 @@
 private final String commandUrl;
 private ZooKeeperServer zkServer;
 
-public JettyAdminServer() throws AdminServerException {
+public JettyAdminServer() throws AdminServerException, IOException, 
GeneralSecurityException {
 this(System.getProperty("zookeeper.admin.serverAddress", 
DEFAULT_ADDRESS),
  Integer.getInteger("zookeeper.admin.serverPort", DEFAULT_PORT),
  Integer.getInteger("zookeeper.admin.idleTimeout", 
DEFAULT_IDLE_TIMEOUT),
- System.getProperty("zookeeper.admin.commandURL", 
DEFAULT_COMMAND_URL));
+ System.getProperty("zookeeper.admin.commandURL", 
DEFAULT_COMMAND_URL),
+ Integer.getInteger("zookeeper.admin.httpVersion", 
DEFAULT_HTTP_VERSION),
+ Boolean.getBoolean("zookeeper.admin.portUnification"));
 }
 
-public JettyAdminServer(String address, int port, int timeout, String 
commandUrl) {
+public JettyAdminServer(String address,
+int port,
+int timeout,
+String commandUrl,
+int httpVersion,
+boolean portUnification) throws IOException, 
GeneralSecurityException {
 this.port = port;
 this.idleTimeout = timeout;
 this.commandUrl = commandUrl;
 this.address = address;
 
 server = new Server();
-ServerConnector connector = new ServerConnector(server);
+ServerConnector connector = null;
+
+if (!portUnification) {
+connector = new ServerConnector(server);
+} else {
+SecureRequestCustomizer customizer = new SecureRequestCustomizer();
+customizer.setStsMaxAge(DEFAULT_STS_MAX_AGE);
+customizer.setStsIncludeSubDomains(true);
+
+HttpConfiguration config = new HttpConfiguration();
+config.setSecureScheme("https");
+config.addCustomizer(customizer);
+
+try(QuorumX509Util x509Util = new QuorumX509Util()) {
 
 Review comment:
   nit: space after try


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Maven release findings

[Andor Molnár]

Answers inline.


On 5/20/19 20:15, Enrico Olivelli wrote:
> Il lun 20 mag 2019, 19:59 Andor Molnar  ha
> scritto:
>
>> Hi team,
>>
>> We're looking pretty good, I've updated the Maven release page with
>> experiences of this release:
>>
>> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease+using+maven
>>
>> This should be the latest and greatest release doc now.
>>
>> Unfortunately I've run into a pretty major issue which affects the release
>> artifact too. The generated API docs are incorrectly linked during
>> generation. Details are here:
>> https://issues.apache.org/jira/browse/ZOOKEEPER-3397
>>
>> The main issue is basically that we now have separated -jute and -server
>> API docs. As a quick fix, I've updated the website and copied over
>> zookeeper-server docs (jute is not included), but we need to fix this in
>> the long run.
>>
> I am not sure how much jute javadocs are useful.


I'm happy to drop it.

Probably that would be the easiest to resolve this.


>
>> Other than that the process was pretty neat.
>> Jira has been updated, 3.5.5 version is now released and 3.5.6 is available
>> for new issues.
>>
>> Happy coding everyone!
>>
>
> Thanks
> I think a new era begins for the project now that we dropped that nasty
> -beta qualifier.
>
> I hope we will be able to start cutting releases more often


Agreed. As a first step maybe we could cut 3.6.0 and change master to 4.0.0.


Andor

Re: [ANNOUNCE] Apache ZooKeeper 3.5.5

[Enrico Olivelli]

Congratulations!

Enrico

Il lun 20 mag 2019, 19:28 Lars Francke  ha scritto:

> Congratulations on this release! It looks great and I'm looking forward to
> using all those new features.
>
> Thank you, everyone, for your work on this.
>
> On Mon, May 20, 2019 at 7:06 PM Andor Molnar  wrote:
>
> > The Apache ZooKeeper team is proud to announce Apache ZooKeeper version
> > 3.5.5
> >
> > ZooKeeper is a high-performance coordination service for distributed
> > applications. It exposes common services - such as naming,
> > configuration management, synchronization, and group services - in a
> > simple interface so you don't have to write them from scratch. You can
> > use it off-the-shelf to implement consensus, group management, leader
> > election, and presence protocols. And you can build on it for your
> > own, specific needs.
> >
> > For ZooKeeper release details and downloads, visit:
> > https://zookeeper.apache.org/releases.html
> >
> > ZooKeeper 3.5.5 Release Notes are at:
> > https://zookeeper.apache.org/doc/r3.5.5/releasenotes.html
> >
> > We would like to thank the contributors that made the release possible.
> >
> > Regards,
> >
> > The ZooKeeper Team
> >
> >
> >
>

[GitHub] [zookeeper] jhuan31 opened a new pull request #850: ZOOKEEPER-3309: Add sync processor metrics

[GitBox]

jhuan31 opened a new pull request #850: ZOOKEEPER-3309: Add sync processor 
metrics
URL: https://github.com/apache/zookeeper/pull/850
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] jhuan31 closed pull request #850: ZOOKEEPER-3309: Add sync processor metrics

[GitBox]

jhuan31 closed pull request #850: ZOOKEEPER-3309: Add sync processor metrics
URL: https://github.com/apache/zookeeper/pull/850
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Maven release findings

[Enrico Olivelli]

Il lun 20 mag 2019, 19:59 Andor Molnar  ha
scritto:

> Hi team,
>
> We're looking pretty good, I've updated the Maven release page with
> experiences of this release:
>
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease+using+maven
>
> This should be the latest and greatest release doc now.
>
> Unfortunately I've run into a pretty major issue which affects the release
> artifact too. The generated API docs are incorrectly linked during
> generation. Details are here:
> https://issues.apache.org/jira/browse/ZOOKEEPER-3397
>
> The main issue is basically that we now have separated -jute and -server
> API docs. As a quick fix, I've updated the website and copied over
> zookeeper-server docs (jute is not included), but we need to fix this in
> the long run.
>

I am not sure how much jute javadocs are useful.

>
> Other than that the process was pretty neat.
> Jira has been updated, 3.5.5 version is now released and 3.5.6 is available
> for new issues.
>
> Happy coding everyone!
>


Thanks
I think a new era begins for the project now that we dropped that nasty
-beta qualifier.

I hope we will be able to start cutting releases more often

Enrico

>
> Andor
>

Maven release findings

[Andor Molnar]

Hi team,

We're looking pretty good, I've updated the Maven release page with
experiences of this release:
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease+using+maven

This should be the latest and greatest release doc now.

Unfortunately I've run into a pretty major issue which affects the release
artifact too. The generated API docs are incorrectly linked during
generation. Details are here:
https://issues.apache.org/jira/browse/ZOOKEEPER-3397

The main issue is basically that we now have separated -jute and -server
API docs. As a quick fix, I've updated the website and copied over
zookeeper-server docs (jute is not included), but we need to fix this in
the long run.

Other than that the process was pretty neat.
Jira has been updated, 3.5.5 version is now released and 3.5.6 is available
for new issues.

Happy coding everyone!

Andor

[jira] [Updated] (ZOOKEEPER-3355) Remove 'tbd' From Docs

[Andor Molnar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andor Molnar updated ZOOKEEPER-3355:

Fix Version/s: (was: 3.5.5)
   3.5.6

> Remove 'tbd' From Docs
> --
>
> Key: ZOOKEEPER-3355
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3355
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.5.4, 3.6.0
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Trivial
>  Labels: pull-request-available
> Fix For: 3.6.0, 3.5.6
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> For years, there have been lots of 'tbd' recorded in the documentation.  It 
> does not look very polished and there is no one working on these.  I think 
> it's time to finally remove them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-3357) Remove Dead Link from ZooKeeper Programmer's Guide

[Andor Molnar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andor Molnar updated ZOOKEEPER-3357:

Fix Version/s: (was: 3.5.5)
   3.5.6

> Remove Dead Link from ZooKeeper Programmer's Guide
> --
>
> Key: ZOOKEEPER-3357
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3357
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.5.4, 3.6.0
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Trivial
>  Labels: pull-request-available
> Fix For: 3.6.0, 3.5.6
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Remove dead link to _ZooKeeper Talk at the Hadoup Summit 2008_



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-3397) API docs are incorrectly linked in release artifacts

[Andor Molnar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andor Molnar updated ZOOKEEPER-3397:

Summary: API docs are incorrectly linked in release artifacts  (was: API 
docs are not linked properly in release artifacts)

> API docs are incorrectly linked in release artifacts
> 
>
> Key: ZOOKEEPER-3397
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3397
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 3.5.5
>Reporter: Andor Molnar
>Priority: Major
>
> The generated API docs are now located in 2 different folders:
>  * zookeeper-server
>  * zookeeper-jute
> But the navbar is still pointing to api/index.html which link is broken and 
> needs to be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [ANNOUNCE] Apache ZooKeeper 3.5.5

[Jeff Widman]

Congrats on dropping the "beta" tag, that's a major milestone!

Thanks to the team for all your hard work!

On Mon, May 20, 2019 at 10:06 AM Andor Molnar  wrote:

> The Apache ZooKeeper team is proud to announce Apache ZooKeeper version
> 3.5.5
>
> ZooKeeper is a high-performance coordination service for distributed
> applications. It exposes common services - such as naming,
> configuration management, synchronization, and group services - in a
> simple interface so you don't have to write them from scratch. You can
> use it off-the-shelf to implement consensus, group management, leader
> election, and presence protocols. And you can build on it for your
> own, specific needs.
>
> For ZooKeeper release details and downloads, visit:
> https://zookeeper.apache.org/releases.html
>
> ZooKeeper 3.5.5 Release Notes are at:
> https://zookeeper.apache.org/doc/r3.5.5/releasenotes.html
>
> We would like to thank the contributors that made the release possible.
>
> Regards,
>
> The ZooKeeper Team
>
>
>

-- 

*Jeff Widman*
jeffwidman.com  | 740-WIDMAN-J (943-6265)
<><

[jira] [Created] (ZOOKEEPER-3397) API docs are not linked properly in release artifacts

[Andor Molnar (JIRA)]

Andor Molnar created ZOOKEEPER-3397:
---

 Summary: API docs are not linked properly in release artifacts
 Key: ZOOKEEPER-3397
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3397
 Project: ZooKeeper
  Issue Type: Bug
  Components: documentation
Affects Versions: 3.5.5
Reporter: Andor Molnar


The generated API docs are now located in 2 different folders:
 * zookeeper-server
 * zookeeper-jute

But the navbar is still pointing to api/index.html which link is broken and 
needs to be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [ANNOUNCE] Apache ZooKeeper 3.5.5

[Lars Francke]

Congratulations on this release! It looks great and I'm looking forward to
using all those new features.

Thank you, everyone, for your work on this.

On Mon, May 20, 2019 at 7:06 PM Andor Molnar  wrote:

> The Apache ZooKeeper team is proud to announce Apache ZooKeeper version
> 3.5.5
>
> ZooKeeper is a high-performance coordination service for distributed
> applications. It exposes common services - such as naming,
> configuration management, synchronization, and group services - in a
> simple interface so you don't have to write them from scratch. You can
> use it off-the-shelf to implement consensus, group management, leader
> election, and presence protocols. And you can build on it for your
> own, specific needs.
>
> For ZooKeeper release details and downloads, visit:
> https://zookeeper.apache.org/releases.html
>
> ZooKeeper 3.5.5 Release Notes are at:
> https://zookeeper.apache.org/doc/r3.5.5/releasenotes.html
>
> We would like to thank the contributors that made the release possible.
>
> Regards,
>
> The ZooKeeper Team
>
>
>

Re: [ANNOUNCE] Apache ZooKeeper 3.5.5

[Jordan Zimmerman]

Maven Central shows the first version of 3.5.x as Aug 2014. Here's to a five 
year dev cycle :D But, of course, congrats. 

-JZ

> On May 20, 2019, at 12:25 PM, Jeff Widman  wrote:
> 
> Congrats on dropping the "beta" tag, that's a major milestone!
> 
> Thanks to the team for all your hard work!
> 
> On Mon, May 20, 2019 at 10:06 AM Andor Molnar  wrote:
> 
>> The Apache ZooKeeper team is proud to announce Apache ZooKeeper version
>> 3.5.5
>> 
>> ZooKeeper is a high-performance coordination service for distributed
>> applications. It exposes common services - such as naming,
>> configuration management, synchronization, and group services - in a
>> simple interface so you don't have to write them from scratch. You can
>> use it off-the-shelf to implement consensus, group management, leader
>> election, and presence protocols. And you can build on it for your
>> own, specific needs.
>> 
>> For ZooKeeper release details and downloads, visit:
>> https://zookeeper.apache.org/releases.html
>> 
>> ZooKeeper 3.5.5 Release Notes are at:
>> https://zookeeper.apache.org/doc/r3.5.5/releasenotes.html
>> 
>> We would like to thank the contributors that made the release possible.
>> 
>> Regards,
>> 
>> The ZooKeeper Team
>> 
>> 
>> 
> 
> -- 
> 
> *Jeff Widman*
> jeffwidman.com  | 740-WIDMAN-J (943-6265)
> <><

[jira] [Commented] (ZOOKEEPER-1147) Add support for local sessions

[Lars Francke (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844139#comment-16844139
 ] 

Lars Francke commented on ZOOKEEPER-1147:
-

I just saw this in the release announcement for 3.5: Is there any documentation 
on this available?

> Add support for local sessions
> --
>
> Key: ZOOKEEPER-1147
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1147
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.3.3
>Reporter: Vishal Kathuria
>Assignee: Thawan Kooburat
>Priority: Major
>  Labels: api-change, scaling
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1147.patch, ZOOKEEPER-1147.patch, 
> ZOOKEEPER-1147.patch, ZOOKEEPER-1147.patch, ZOOKEEPER-1147.patch, 
> ZOOKEEPER-1147.patch, ZOOKEEPER-1147.patch, ZOOKEEPER-1147.patch, 
> ZOOKEEPER-1147.patch
>
>   Original Estimate: 840h
>  Remaining Estimate: 840h
>
> This improvement is in the bucket of making ZooKeeper work at a large scale. 
> We are planning on having about a 1 million clients connect to a ZooKeeper 
> ensemble through a set of 50-100 observers. Majority of these clients are 
> read only - ie they do not do any updates or create ephemeral nodes.
> In ZooKeeper today, the client creates a session and the session creation is 
> handled like any other update. In the above use case, the session create/drop 
> workload can easily overwhelm an ensemble. The following is a proposal for a 
> "local session", to support a larger number of connections.
> 1.   The idea is to introduce a new type of session - "local" session. A 
> "local" session doesn't have a full functionality of a normal session.
> 2.   Local sessions cannot create ephemeral nodes.
> 3.   Once a local session is lost, you cannot re-establish it using the 
> session-id/password. The session and its watches are gone for good.
> 4.   When a local session connects, the session info is only maintained 
> on the zookeeper server (in this case, an observer) that it is connected to. 
> The leader is not aware of the creation of such a session and there is no 
> state written to disk.
> 5.   The pings and expiration is handled by the server that the session 
> is connected to.
> With the above changes, we can make ZooKeeper scale to a much larger number 
> of clients without making the core ensemble a bottleneck.
> In terms of API, there are two options that are being considered
> 1. Let the client specify at the connect time which kind of session do they 
> want.
> 2. All sessions connect as local sessions and automatically get promoted to 
> global sessions when they do an operation that requires a global session 
> (e.g. creating an ephemeral node)
> Chubby took the approach of lazily promoting all sessions to global, but I 
> don't think that would work in our case, where we want to keep sessions which 
> never create ephemeral nodes as always local. Option 2 would make it more 
> broadly usable but option 1 would be easier to implement.
> We are thinking of implementing option 1 as the first cut. There would be a 
> client flag, IsLocalSession (much like the current readOnly flag) that would 
> be used to determine whether to create a local session or a global session.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[CVE-2019-0201] Information disclosure vulnerability in Apache ZooKeeper

[Andor Molnar]

CVE-2019-0201: Information disclosure vulnerability in Apache ZooKeeper
 
Severity: Critical
 
Vendor: The Apache Software Foundation
 
Versions Affected: ZooKeeper prior to 3.4.14, ZooKeeper 3.5.0-alpha through 
3.5.4-beta. The unsupported ZooKeeper 1.x through 3.3.x versions may be also 
affected.
 
Description: ZooKeeper’s getACL() command doesn’t check any permission when 
retrieves the ACLs of the requested node and returns all information contained 
in the ACL Id field as plaintext string. DigestAuthenticationProvider overloads 
the Id field with the hash value that is used for user authentication. As a 
consequence, if Digest Authentication is in use, the unsalted hash value will 
be disclosed by getACL() request for unauthenticated or unprivileged users.
 
Mitigation: Use an authentication method other than Digest (e.g. Kerberos) or 
upgrade to 3.4.14 or later (3.5.5 or later if on the 3.5 branch).
 
Credit: This issue was identified by Harrison Neal  
PatchAdvisor, Inc.
 
References: https://issues.apache.org/jira/browse/ZOOKEEPER-1392
 

[GitHub] [zookeeper] enixon commented on issue #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand

[GitBox]

enixon commented on issue #899: ZOOKEEPER-3354: Improve efficiency of 
DeleteAllCommand
URL: https://github.com/apache/zookeeper/pull/899#issuecomment-494073668
 
 
   retest ant build


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[ANNOUNCE] Apache ZooKeeper 3.5.5

[Andor Molnar]

The Apache ZooKeeper team is proud to announce Apache ZooKeeper version 3.5.5

ZooKeeper is a high-performance coordination service for distributed
applications. It exposes common services - such as naming,
configuration management, synchronization, and group services - in a
simple interface so you don't have to write them from scratch. You can
use it off-the-shelf to implement consensus, group management, leader
election, and presence protocols. And you can build on it for your
own, specific needs.

For ZooKeeper release details and downloads, visit:
https://zookeeper.apache.org/releases.html

ZooKeeper 3.5.5 Release Notes are at:
https://zookeeper.apache.org/doc/r3.5.5/releasenotes.html

We would like to thank the contributors that made the release possible.

Regards,

The ZooKeeper Team

[GitHub] [zookeeper] eolivelli commented on a change in pull request #850: ZOOKEEPER-3309: Add sync processor metrics

[GitBox]

eolivelli commented on a change in pull request #850: ZOOKEEPER-3309: Add sync 
processor metrics
URL: https://github.com/apache/zookeeper/pull/850#discussion_r285684971
 
 

 ##
 File path: 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/SyncRequestProcessorMetricTest.java
 ##
 @@ -0,0 +1,102 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server.quorum;
+
+import org.apache.zookeeper.ZooDefs;
+import org.apache.zookeeper.metrics.MetricsUtils;
+import org.apache.zookeeper.server.*;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.nio.ByteBuffer;
+import java.util.Map;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import static org.hamcrest.number.OrderingComparison.greaterThan;
+import static org.hamcrest.number.OrderingComparison.greaterThanOrEqualTo;
+import static org.mockito.Matchers.any;
+import static org.mockito.Mockito.doAnswer;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class SyncRequestProcessorMetricTest {
+ZooKeeperServer zks;
+RequestProcessor nextProcessor;
+CountDownLatch allRequestsFlushed;
+
+@Before
+public void setup() throws Exception {
+ZKDatabase db = mock(ZKDatabase.class);
+when(db.append(any(Request.class))).thenReturn(true);
+doAnswer(invocation->{
+Thread.sleep(100);
+return null;
+}).when(db).commit();
+zks = mock(ZooKeeperServer.class);
+when(zks.getZKDatabase()).thenReturn(db);
+
+nextProcessor = mock(RequestProcessor.class);
+doAnswer(invocationOnMock -> {
+allRequestsFlushed.countDown();
+return null;
+}).when(nextProcessor).processRequest(any(Request.class));
+}
+
+private Request createRquest(long sessionId, int xid) {
+return new Request(null, sessionId, xid, ZooDefs.OpCode.setData,
+ByteBuffer.wrap(new byte[10]), null);
+}
+
+@Test
+public void testSyncProcessorMetrics() throws  Exception{
+SyncRequestProcessor syncProcessor = new SyncRequestProcessor(zks, 
nextProcessor);
+for (int i=0; i<500; i++) {
+syncProcessor.processRequest(createRquest(1, i));
+}
+
+Map values = MetricsUtils.currentServerMetrics();
+Assert.assertEquals(500L, values.get("sync_processor_request_queued"));
+
+allRequestsFlushed = new CountDownLatch(500);
+syncProcessor.start();
+
+allRequestsFlushed.await(500, TimeUnit.MILLISECONDS);
 
 Review comment:
   We can use a greater timeout, in order to deal with temporary overloaded 
test machines.
   I suggest 5000


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] eolivelli commented on a change in pull request #850: ZOOKEEPER-3309: Add sync processor metrics

[GitBox]

eolivelli commented on a change in pull request #850: ZOOKEEPER-3309: Add sync 
processor metrics
URL: https://github.com/apache/zookeeper/pull/850#discussion_r285684635
 
 

 ##
 File path: 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/SyncRequestProcessorMetricTest.java
 ##
 @@ -0,0 +1,102 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server.quorum;
+
+import org.apache.zookeeper.ZooDefs;
+import org.apache.zookeeper.metrics.MetricsUtils;
+import org.apache.zookeeper.server.*;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.nio.ByteBuffer;
+import java.util.Map;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import static org.hamcrest.number.OrderingComparison.greaterThan;
+import static org.hamcrest.number.OrderingComparison.greaterThanOrEqualTo;
+import static org.mockito.Matchers.any;
+import static org.mockito.Mockito.doAnswer;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class SyncRequestProcessorMetricTest {
+ZooKeeperServer zks;
+RequestProcessor nextProcessor;
+CountDownLatch allRequestsFlushed;
+
+@Before
+public void setup() throws Exception {
+ZKDatabase db = mock(ZKDatabase.class);
+when(db.append(any(Request.class))).thenReturn(true);
+doAnswer(invocation->{
+Thread.sleep(100);
+return null;
+}).when(db).commit();
+zks = mock(ZooKeeperServer.class);
+when(zks.getZKDatabase()).thenReturn(db);
+
+nextProcessor = mock(RequestProcessor.class);
+doAnswer(invocationOnMock -> {
+allRequestsFlushed.countDown();
+return null;
+}).when(nextProcessor).processRequest(any(Request.class));
+}
+
+private Request createRquest(long sessionId, int xid) {
+return new Request(null, sessionId, xid, ZooDefs.OpCode.setData,
+ByteBuffer.wrap(new byte[10]), null);
+}
+
+@Test
+public void testSyncProcessorMetrics() throws  Exception{
+SyncRequestProcessor syncProcessor = new SyncRequestProcessor(zks, 
nextProcessor);
+for (int i=0; i<500; i++) {
+syncProcessor.processRequest(createRquest(1, i));
+}
+
+Map values = MetricsUtils.currentServerMetrics();
+Assert.assertEquals(500L, values.get("sync_processor_request_queued"));
+
+allRequestsFlushed = new CountDownLatch(500);
+syncProcessor.start();
 
 Review comment:
   Very last nit: we are not closing/stopping it. 
   So we will leak a few test resources.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics

[GitBox]

jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics
URL: https://github.com/apache/zookeeper/pull/850#issuecomment-494063586
 
 
   Added a metric SYNC_PROCESSOR_QUEUE_AND_FLUSH_TIME, which is the end to end 
time a request stays in the SyncRequestProcessor.  Also changed sleep to 
CountDownLatch in the unit test.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] jhuan31 commented on a change in pull request #850: ZOOKEEPER-3309: Add sync processor metrics

[GitBox]

jhuan31 commented on a change in pull request #850: ZOOKEEPER-3309: Add sync 
processor metrics
URL: https://github.com/apache/zookeeper/pull/850#discussion_r285678243
 
 

 ##
 File path: 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/SyncRequestProcessorMetricTest.java
 ##
 @@ -0,0 +1,90 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server.quorum;
+
+import org.apache.zookeeper.ZooDefs;
+import org.apache.zookeeper.metrics.MetricsUtils;
+import org.apache.zookeeper.server.*;
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.nio.ByteBuffer;
+import java.util.Map;
+
+import static org.hamcrest.number.OrderingComparison.greaterThan;
+import static org.hamcrest.number.OrderingComparison.greaterThanOrEqualTo;
+import static org.mockito.Matchers.any;
+import static org.mockito.Mockito.doAnswer;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class SyncRequestProcessorMetricTest {
+ZooKeeperServer zks;
+
+@Before
+public void setup() throws Exception {
+ZKDatabase db = mock(ZKDatabase.class);
+when(db.append(any(Request.class))).thenReturn(true);
+doAnswer(invocation->{
+Thread.sleep(100);
+return null;
+}).when(db).commit();
+zks = mock(ZooKeeperServer.class);
+when(zks.getZKDatabase()).thenReturn(db);
+}
+
+private Request createRquest(long sessionId, int xid) {
+return new Request(null, sessionId, xid, ZooDefs.OpCode.setData,
+ByteBuffer.wrap(new byte[10]), null);
+}
+
+@Test
+public void testSyncProcessorMetrics() throws  Exception{
+SyncRequestProcessor syncProcessor = new SyncRequestProcessor(zks, 
null);
+for (int i=0; i<500; i++) {
+syncProcessor.processRequest(createRquest(1, i));
+}
+
+Map values = MetricsUtils.currentServerMetrics();
+Assert.assertEquals(500L, values.get("sync_processor_request_queued"));
+
+syncProcessor.start();
+
+
+Thread.sleep(500);
 
 Review comment:
   Changed to use a countDown latch. Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] enixon commented on issue #939: ZOOKEEPER-3385: Add admin command to display leader

[GitBox]

enixon commented on issue #939: ZOOKEEPER-3385: Add admin command to display 
leader
URL: https://github.com/apache/zookeeper/pull/939#issuecomment-494040350
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Assigned] (ZOOKEEPER-3311) Allow a delay to the transaction log flush

[Brian Nixon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Nixon reassigned ZOOKEEPER-3311:
--

Assignee: Brian Nixon

> Allow a delay to the transaction log flush 
> ---
>
> Key: ZOOKEEPER-3311
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3311
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Affects Versions: 3.6.0
>Reporter: Brian Nixon
>Assignee: Brian Nixon
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> The SyncRequestProcessor flushes writes to disk either when 1000 writes are 
> pending to be flushed or when the processor fails to retrieve another write 
> from its incoming queue. The "flush when queue empty" condition operates 
> poorly under many workloads as it can quickly degrade into flushing after 
> every write -- losing all benefits of batching and leading to a continuous 
> stream of flushes + fsyncs which overwhelm the underlying disk.
>  
> A configurable flush delay would ensure flushes do not happen more frequently 
> than once every X milliseconds. This can be used in-place of or jointly with 
> batch size triggered flushes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (ZOOKEEPER-3378) Set the quorum cnxn timeout independently from syncLimit

[Brian Nixon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Nixon reassigned ZOOKEEPER-3378:
--

Assignee: Brian Nixon

> Set the quorum cnxn timeout independently from syncLimit
> 
>
> Key: ZOOKEEPER-3378
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3378
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Brian Nixon
>Assignee: Brian Nixon
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> If an ensemble requires a high sync limit to support a large data tree or 
> transaction rate, it can cause the QuorumCxnManager to hang over-long in 
> response to quorum events. Using the sync limit for this timeout is a 
> convenience in terms of keeping all failure detection mechanisms in sync but 
> it is not strictly required for correct behavior.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [zookeeper] enixon commented on issue #949: ZOOKEEPER-3396: Flaky test in RestoreCommittedLogTest

[GitBox]

enixon commented on issue #949: ZOOKEEPER-3396: Flaky test in 
RestoreCommittedLogTest
URL: https://github.com/apache/zookeeper/pull/949#issuecomment-494038998
 
 
   @anmolnar , honestly I've never tried. It just did not occur to me as a 
thing to do. Will let you know if I discover I don't have permission. :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] eolivelli commented on issue #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal reflective access in zookeer's kerberosUtil

[GitBox]

eolivelli commented on issue #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal 
reflective access in zookeer's kerberosUtil
URL: https://github.com/apache/zookeeper/pull/950#issuecomment-494034342
 
 
   @anmolnar the cherry pick fails against branch-3.5, please create a new PR


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (ZOOKEEPER-3263) Illegal reflective access in zookeer's kerberosUtil

[Enrico Olivelli (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Enrico Olivelli resolved ZOOKEEPER-3263.

   Resolution: Fixed
Fix Version/s: 3.6.0

Issue resolved by pull request 950
[https://github.com/apache/zookeeper/pull/950]

> Illegal reflective access in zookeer's kerberosUtil
> ---
>
> Key: ZOOKEEPER-3263
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3263
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.13
>Reporter: Pradeep Bansal
>Assignee: Andor Molnar
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> I am using kafka 2.11-2.1.0 with Java 11. Kafka is using zookeeper-3.4.13.jar 
> and when am running kafka-acl script to maange ACLs, I am getting below 
> warning. Is there a way to resolve this?
> {{WARNING: An illegal reflective access operation has occurred WARNING: 
> Illegal reflective access by org.apache.zookeeper.server.util.KerberosUtil 
> (file://apache/kafka/kafka_2.11-2.1.0/libs/zookeeper-3.4.13.jar) to method 
> sun.security.krb5.Config.getInstance() WARNING: Please consider reporting 
> this to the maintainers of org.apache.zookeeper.server.util.KerberosUtil 
> WARNING: Use --illegal-access=warn to enable warnings of further illegal 
> reflective access operations WARNING: All illegal access operations will be 
> denied in a future release}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [zookeeper] asfgit closed pull request #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal reflective access in zookeer's kerberosUtil

[GitBox]

asfgit closed pull request #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal 
reflective access in zookeer's kerberosUtil
URL: https://github.com/apache/zookeeper/pull/950
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (ZOOKEEPER-3396) Flaky test in RestoreCommittedLogTest

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844016#comment-16844016
 ] 

Hudson commented on ZOOKEEPER-3396:
---

SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #363 (See 
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/363/])
ZOOKEEPER-3396: Flaky test in RestoreCommittedLogTest (andor: rev 
1264e9f2ba8e8724a9352387b22e784716816722)
* (edit) zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/test/RestoreCommittedLogTest.java


> Flaky test in RestoreCommittedLogTest
> -
>
> Key: ZOOKEEPER-3396
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3396
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: tests
>Affects Versions: 3.6.0
>Reporter: Brian Nixon
>Assignee: Brian Nixon
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> The patch for ZOOKEEPER-3244 ([https://github.com/apache/zookeeper/pull/770)] 
> introduced a flaky test 
> RestoreCommittedLogTest::testRestoreCommittedLogWithSnapSize.
>  
> Get it running consistently.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3396) Flaky test in RestoreCommittedLogTest

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843927#comment-16843927
 ] 

Hudson commented on ZOOKEEPER-3396:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #529 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/529/])
ZOOKEEPER-3396: Flaky test in RestoreCommittedLogTest (andor: rev 
1264e9f2ba8e8724a9352387b22e784716816722)
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/test/RestoreCommittedLogTest.java
* (edit) zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md


> Flaky test in RestoreCommittedLogTest
> -
>
> Key: ZOOKEEPER-3396
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3396
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: tests
>Affects Versions: 3.6.0
>Reporter: Brian Nixon
>Assignee: Brian Nixon
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> The patch for ZOOKEEPER-3244 ([https://github.com/apache/zookeeper/pull/770)] 
> introduced a flaky test 
> RestoreCommittedLogTest::testRestoreCommittedLogWithSnapSize.
>  
> Get it running consistently.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [zookeeper] nkalmar commented on issue #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal reflective access in zookeer's kerberosUtil

[GitBox]

nkalmar commented on issue #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal 
reflective access in zookeer's kerberosUtil
URL: https://github.com/apache/zookeeper/pull/950#issuecomment-493960198
 
 
   retest ant build


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] eolivelli commented on issue #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal reflective access in zookeer's kerberosUtil

[GitBox]

eolivelli commented on issue #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal 
reflective access in zookeer's kerberosUtil
URL: https://github.com/apache/zookeeper/pull/950#issuecomment-493946111
 
 
   retest ant build


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Github & Jira notifications

[Andor Molnar]

I’m not sure whether we have convinced Patrick entirely.
Before casting my vote, I’d be happy if we could reach consensus in the 
community with this change, not just majority.

Reason is that I rather feel it a nice-to-have improvement, not critical.

Andor



> On 2019. May 17., at 17:05, Flavio Junqueira  wrote:
> 
> To add to this conversation, we have 5 mailing lists as of today:
> 
> dev@z.a.o
> commits@z.a.o
> private@z.a.o
> security@z.a.o
> user@z.a.o
> 
> The commits@ one was historically supposed to be for notifications.
> 
> -Flavio 
> 
> 
>> On 17 May 2019, at 16:50, Lars Francke  wrote:
>> 
>> Alright, I will do so, thank you
>> 
>> On Fri, May 17, 2019 at 11:46 AM Norbert Kalmar
>>  wrote:
>> 
>>> I think we should start a vote.
>>> 
>>> Lars, feel free to start it, as it is your initiative, you can place your
>>> argument in the initial email.
>>> Thanks for bringing this up!
>>> 
>>> Regards,
>>> Norbert
>>> 
>>> 
>>> On Fri, May 17, 2019 at 11:38 AM Lars Francke 
>>> wrote:
>>> 
 I don't really have anything else to add to this conversation. I agree
>>> with
 Norbert & Andor.
 Separating the lists is (slowly) becoming the standard at the ASF in the
 projects I participate in and it makes it easier for newcomers.
 
 Do we want to put this to a vote or abandon this?
 
 On Mon, May 13, 2019 at 5:33 PM Andor Molnar  wrote:
 
> Without responding to this, let’s clarify what emails are we talking
 about:
> 
> - Jenkins build notifications: failures / successes,
> - Jira notifications: Created, Updated, Status change, Commented, etc.
> - Github notifications: opened/closed pull request, commented on pull
> request, etc.
> 
> Researching a bit around it seems like that issues@ mailing list is a
> common pattern across some Hadoop projects:
> https://hbase.apache.org/mailing-lists.html <
> https://hbase.apache.org/mailing-lists.html>
> https://hadoop.apache.org/mailing_lists.html <
> https://hadoop.apache.org/mailing_lists.html>
> https://kafka.apache.org/contact 
> 
> But not on:
> https://hive.apache.org/mailing_lists.html <
> https://hive.apache.org/mailing_lists.html>
> https://oozie.apache.org/mail-lists.html <
> https://oozie.apache.org/mail-lists.html>
> 
> Regards,
> Andor
> 
> 
> 
>> On 2019. May 13., at 16:43, Patrick Hunt  wrote:
>> 
>> I seem to remember that in the early days of apache the intent was
>>> for
> all
>> developers to participate in development of the project. MLs were
>>> used
> for
>> this initially and there has been concern in the past about the move
>>> to
>> JIRA as it removes critical discussions from the general dev flow.
>>> JIRA
>> discussions are cc'd to an ML for just this reason. Granted another
> aspect
>> of this mirroring is for archival purposes.
>> 
>> As such the intent is for developers to participate in development
>> discussion. It sounds like you're turning this on it's head.
>> 
>> Isn't this why we have a user list? For folks that are only casually
>> interested in project activity?
>> 
>> Patrick
>> 
>> On Mon, May 13, 2019 at 3:31 AM Andor Molnar 
>>> wrote:
>> 
>>> Hi,
>>> 
>>> Sorry for starting the vote too early, for some reason I thought
>>> it’s
 a
>>> straightforward thing, but the concerns are valid.
>>> 
>>> I believe this is a good thing to do now, because the activity in
>>> ZooKeeper community has reached a level which the dev list with all
>>> notifications included hasn’t been prepared for. I see emails every
 now
> and
>>> then from people who fed up with the flood of notification emails
>>> and
>>> decide to unsubscribe instead of taking the hassle of dealing with
 email
>>> filters.
>>> 
>>> *Filters*
>>> Pretty much everything which can be done with separate mailing
>>> lists,
> can
>>> be achieved by some clever email filters too. Though I think having
>>> multiple mailing lists is technologically a better distinction for
> emails:
>>> separate archives, different retention policies, less email to be
> delivered
>>> (filters working on client side) and more convenient for new
> subscribers.
>>> 
>>> *Markmail*
>>> I’m a power user of markmail too, but I’m not sure how it works.
>>> Tbh I
>>> cannot see the benefits of searching for automated emails from
>>> Gitbox,
> but
>>> I’m sure we can set it up properly, if needed.
>>> 
>>> *Existing users*
>>> It’s completely valid that on the flip side we’ll mess up the config
 of
>>> existing users. I don’t we can avoid that or do this in a backward
>>> compatible way, but I think it’s worth to pay this price. What will
> happen
>>> to them?
>>> - Stop receiving 

Re: Problem with pushing the website - binaries on asf-site branch ?

[Andor Molnar]

Oh, I think I got it now.
I removed them from the ‘website’ branch, but haven’t published the changes to 
‘asf-site’.

Pat, if you go ahead with your changes, remove them from the site. Otherwise 
I’ll do it anyway with the 3.5 release today/tomorrow.

Andor



> On 2019. May 20., at 13:06, Enrico Olivelli  wrote:
> 
> Andor,
> my links are from "current" asf-site on github, so files are there
> https://github.com/apache/zookeeper/tree/asf-site/content/doc/r3.4.13
> 
> Enrico
> 
> Il giorno lun 20 mag 2019 alle ore 13:04 Andor Molnar  ha
> scritto:
> 
>> Hi Pat,
>> 
>> Are you at latest commit on ‘website’ branch?
>> I removed these files in commit 98472b8b793d10f011ecb79b9acc9b6b07574f5c.
>> 
>> I agree that binaries probably have been added to the repo by mistake.
>> 
>> Regards,
>> Andor
>> 
>> 
>> 
>>> On 2019. May 19., at 21:12, Enrico Olivelli  wrote:
>>> 
>>> Il dom 19 mag 2019, 20:41 Patrick Hunt  ha scritto:
>>> 
 In looking at the older versions under content they don't include that
 file. Probably an un-intended side effect of the recent
 changes/improvements around the docs/site. I'd say we should remove
>> them.
 Can you check, I assume there are no links to that file (locally)?
 
>>> 
>>> Sure.
>>> Anyway we are on git so we can always use 'git revert' :)
>>> 
>>> Enrico
>>> 
>>> 
>>> 
 Patrick
 
 On Sat, May 18, 2019 at 11:58 PM Enrico Olivelli 
 wrote:
 
> Hi,
> While trying to push a new version of the website
> I was following the guide here [1]
> 
> But if I build the website locally I get this report from git status
> 
> deleted:content/doc/r3.4.12/zookeeper-3.4.12.tar.gz
> deleted:content/doc/r3.4.13/zookeeper-3.4.13.tar.gz
> 
> It seems that if I commit the whole image of the built website I would
 drop
> these tgz files. (you can see those files at [2] and [3])
> IMHO those binaries shouldn't be hosted on the website and we should
 remove
> them.
> I will remove them if we agree
> 
> Cheers
> Enrico
> 
> [1] https://cwiki.apache.org/confluence/display/ZOOKEEPER/WebSiteSetup
> [2]
 https://github.com/apache/zookeeper/tree/asf-site/content/doc/r3.4.13
> [3]
 https://github.com/apache/zookeeper/tree/asf-site/content/doc/r3.4.12
> 
 
>> 
>> 

Re: Problem with pushing the website - binaries on asf-site branch ?

[Enrico Olivelli]

Andor,
my links are from "current" asf-site on github, so files are there
https://github.com/apache/zookeeper/tree/asf-site/content/doc/r3.4.13

Enrico

Il giorno lun 20 mag 2019 alle ore 13:04 Andor Molnar  ha
scritto:

> Hi Pat,
>
> Are you at latest commit on ‘website’ branch?
> I removed these files in commit 98472b8b793d10f011ecb79b9acc9b6b07574f5c.
>
> I agree that binaries probably have been added to the repo by mistake.
>
> Regards,
> Andor
>
>
>
> > On 2019. May 19., at 21:12, Enrico Olivelli  wrote:
> >
> > Il dom 19 mag 2019, 20:41 Patrick Hunt  ha scritto:
> >
> >> In looking at the older versions under content they don't include that
> >> file. Probably an un-intended side effect of the recent
> >> changes/improvements around the docs/site. I'd say we should remove
> them.
> >> Can you check, I assume there are no links to that file (locally)?
> >>
> >
> > Sure.
> > Anyway we are on git so we can always use 'git revert' :)
> >
> > Enrico
> >
> >
> >
> >> Patrick
> >>
> >> On Sat, May 18, 2019 at 11:58 PM Enrico Olivelli 
> >> wrote:
> >>
> >>> Hi,
> >>> While trying to push a new version of the website
> >>> I was following the guide here [1]
> >>>
> >>> But if I build the website locally I get this report from git status
> >>>
> >>> deleted:content/doc/r3.4.12/zookeeper-3.4.12.tar.gz
> >>> deleted:content/doc/r3.4.13/zookeeper-3.4.13.tar.gz
> >>>
> >>> It seems that if I commit the whole image of the built website I would
> >> drop
> >>> these tgz files. (you can see those files at [2] and [3])
> >>> IMHO those binaries shouldn't be hosted on the website and we should
> >> remove
> >>> them.
> >>> I will remove them if we agree
> >>>
> >>> Cheers
> >>> Enrico
> >>>
> >>> [1] https://cwiki.apache.org/confluence/display/ZOOKEEPER/WebSiteSetup
> >>> [2]
> >> https://github.com/apache/zookeeper/tree/asf-site/content/doc/r3.4.13
> >>> [3]
> >> https://github.com/apache/zookeeper/tree/asf-site/content/doc/r3.4.12
> >>>
> >>
>
>

Re: Problem with pushing the website - binaries on asf-site branch ?

[Andor Molnar]

Hi Pat,

Are you at latest commit on ‘website’ branch?
I removed these files in commit 98472b8b793d10f011ecb79b9acc9b6b07574f5c.

I agree that binaries probably have been added to the repo by mistake.

Regards,
Andor



> On 2019. May 19., at 21:12, Enrico Olivelli  wrote:
> 
> Il dom 19 mag 2019, 20:41 Patrick Hunt  ha scritto:
> 
>> In looking at the older versions under content they don't include that
>> file. Probably an un-intended side effect of the recent
>> changes/improvements around the docs/site. I'd say we should remove them.
>> Can you check, I assume there are no links to that file (locally)?
>> 
> 
> Sure.
> Anyway we are on git so we can always use 'git revert' :)
> 
> Enrico
> 
> 
> 
>> Patrick
>> 
>> On Sat, May 18, 2019 at 11:58 PM Enrico Olivelli 
>> wrote:
>> 
>>> Hi,
>>> While trying to push a new version of the website
>>> I was following the guide here [1]
>>> 
>>> But if I build the website locally I get this report from git status
>>> 
>>> deleted:content/doc/r3.4.12/zookeeper-3.4.12.tar.gz
>>> deleted:content/doc/r3.4.13/zookeeper-3.4.13.tar.gz
>>> 
>>> It seems that if I commit the whole image of the built website I would
>> drop
>>> these tgz files. (you can see those files at [2] and [3])
>>> IMHO those binaries shouldn't be hosted on the website and we should
>> remove
>>> them.
>>> I will remove them if we agree
>>> 
>>> Cheers
>>> Enrico
>>> 
>>> [1] https://cwiki.apache.org/confluence/display/ZOOKEEPER/WebSiteSetup
>>> [2]
>> https://github.com/apache/zookeeper/tree/asf-site/content/doc/r3.4.13
>>> [3]
>> https://github.com/apache/zookeeper/tree/asf-site/content/doc/r3.4.12
>>> 
>> 

[GitHub] [zookeeper] anmolnar commented on issue #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal reflective access in zookeer's kerberosUtil

[GitBox]

anmolnar commented on issue #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal 
reflective access in zookeer's kerberosUtil
URL: https://github.com/apache/zookeeper/pull/950#issuecomment-493930232
 
 
   @eolivelli Thanks for validating. BouncyCastle might not have been fixed 
Java 9 warnings, I haven't found anything in their release docs.
   Rebased on latest master to see if tests are failing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] anmolnar commented on issue #949: ZOOKEEPER-3396: Flaky test in RestoreCommittedLogTest

[GitBox]

anmolnar commented on issue #949: ZOOKEEPER-3396: Flaky test in 
RestoreCommittedLogTest
URL: https://github.com/apache/zookeeper/pull/949#issuecomment-493928910
 
 
   Committed to master branch. Thanks @enixon !
   Btw @enixon you don't assign Jiras to yourself. Is that because you don't 
have permission?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (ZOOKEEPER-3396) Flaky test in RestoreCommittedLogTest

[Andor Molnar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andor Molnar resolved ZOOKEEPER-3396.
-
   Resolution: Fixed
Fix Version/s: 3.6.0

Issue resolved by pull request 949
[https://github.com/apache/zookeeper/pull/949]

> Flaky test in RestoreCommittedLogTest
> -
>
> Key: ZOOKEEPER-3396
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3396
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: tests
>Affects Versions: 3.6.0
>Reporter: Brian Nixon
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The patch for ZOOKEEPER-3244 ([https://github.com/apache/zookeeper/pull/770)] 
> introduced a flaky test 
> RestoreCommittedLogTest::testRestoreCommittedLogWithSnapSize.
>  
> Get it running consistently.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [zookeeper] asfgit closed pull request #949: ZOOKEEPER-3396: Flaky test in RestoreCommittedLogTest

[GitBox]

asfgit closed pull request #949: ZOOKEEPER-3396: Flaky test in 
RestoreCommittedLogTest
URL: https://github.com/apache/zookeeper/pull/949
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Assigned] (ZOOKEEPER-3396) Flaky test in RestoreCommittedLogTest

[Andor Molnar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andor Molnar reassigned ZOOKEEPER-3396:
---

Assignee: Brian Nixon

> Flaky test in RestoreCommittedLogTest
> -
>
> Key: ZOOKEEPER-3396
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3396
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: tests
>Affects Versions: 3.6.0
>Reporter: Brian Nixon
>Assignee: Brian Nixon
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> The patch for ZOOKEEPER-3244 ([https://github.com/apache/zookeeper/pull/770)] 
> introduced a flaky test 
> RestoreCommittedLogTest::testRestoreCommittedLogWithSnapSize.
>  
> Get it running consistently.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 6

[Andor Molnar]

Hi,

With 3 binding +1 votes (Patrick, Michael, Rakesh) without -1, this vote passes.

Thanks everyone for participation.

Andor



> On 2019. May 17., at 19:40, Gracia, Raul  wrote:
> 
> +1
> 
> - Built Zookeeper 3.5.5-rc6 from source correctly.
> - Exercised ZooKeeper standalone + zkCli with/without SSL configured.
> - Pravega branch with ZooKeeper 3.5.5 (used by Curator 4.0.1) passed the 
> build tests.
> - All distributed tests of Pravega in a Kubernetes cluster with ZooKeeper 
> 3.5.5 (used by Curator 4.0.1) passed (running ZooKeeper 3.5.4-beta in the 
> server side).
> 
> Thanks to all of you for your efforts making ZooKeeper such a great project 😊
> 
> Thanks,
> Raúl.
> 
> -Original Message-
> From: Rakesh Radhakrishnan  
> Sent: Friday, May 17, 2019 5:23 PM
> To: DevZooKeeper
> Subject: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 6
> 
> 
> [EXTERNAL EMAIL] 
> 
> +1
> 
> - built ZooKeeper jar from source
> - tested using 3 node cluster, ran smoke test scenarios, ran command line 
> client, checked jmx beans and LGTM.
> - verified sig/xsum, release notes looks fine.
> 
> Thanks Andor and others who have worked on making this release happen!
> 
> Rakesh
> 
> On Fri, May 3, 2019 at 6:04 PM Andor Molnar  wrote:
> 
>> This is the first stable release of 3.5 branch: 3.5.5. It resolves 117 
>> issues, including Maven migration, Quorum TLS, TTL nodes and lots of 
>> other performance and stability improvements.
>> 
>> The full release notes is available at:
>> 
>> 
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310
>> 801&version=12343268
>> 
>> *** Please download, test and vote by May 10th 2019, 23:59 UTC+0. ***
>> 
>> Source files:
>> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.5.5-rc6/
>> 
>> Maven staging repos:
>> 
>> https://repository.apache.org/content/groups/staging/org/apache/zookee
>> per/parent/3.5.5/
>> 
>> https://repository.apache.org/content/groups/staging/org/apache/zookee
>> per/zookeeper-jute/3.5.5/
>> 
>> https://repository.apache.org/content/groups/staging/org/apache/zookee
>> per/zookeeper/3.5.5/
>> 
>> The release candidate tag in git to be voted upon: release-3.5.5-rc6
>> 
>> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>> http://www.apache.org/dist/zookeeper/KEYS
>> 
>> Should we release this candidate?
>> 
>>