[GitHub] [zookeeper] vladimirivic commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out

2019-05-21 Thread GitBox
vladimirivic commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() 
may take too long to time-out 
URL: https://github.com/apache/zookeeper/pull/953#issuecomment-494673203
 
 
   @lvfangmin @eolivelli @anmolnar - what I am thinking is that it may be worth 
going through the code and see if this config could be generalized to be used 
exclusively for socket connection timeout wherever else we have similar logic. 
   
   In that way we keep initLimit and syncLimit tied to quorum semantics where 
as this could be called socketTimeout (or some better name) which is somewhat 
on a lower level and belongs to the networking layer of Zookeeper.
   
   Not sure if this is a good idea, just had this thought. I would need to do 
some homework on my end but let me know what you think first.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] eolivelli closed pull request #952: ZOOKEEPER-3364: Compile with strict options in order to check code quality

2019-05-21 Thread GitBox
eolivelli closed pull request #952: ZOOKEEPER-3364: Compile with strict options 
in order to check code quality
URL: https://github.com/apache/zookeeper/pull/952
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (ZOOKEEPER-3323) Add TxnSnapLog metrics

2019-05-21 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845516#comment-16845516
 ] 

Hudson commented on ZOOKEEPER-3323:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #532 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/532/])
ZOOKEEPER-3323: Add TxnSnapLog metrics (fangmin: rev 
d08f51ad1514bfa512597b1ce4bbc2e8144be576)
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/persistence/FileTxnSnapLogMetricsTest.java


> Add TxnSnapLog metrics
> --
>
> Key: ZOOKEEPER-3323
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3323
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: metric system
>Reporter: Jie Huang
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 4h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[3.4.12] Missing OVERSEER doc. solr-user@lucene....

2019-05-21 Thread Will Martin
Cross-posting this for a sound reporter. He is a top technical resource on 
the list. Not given to hyperbole in bug reports.

Is there a acl'd JIRA for zookeeper?


to solr-user

We have a 6.6.2 cluster in prod that appears to have no overseer. In 
/overseer_elect on ZK, there is an election folder, but no leader document. An 
OVERSEERSTATUS request fails with a timeout.

I'm going to try ADDROLE, but I'd be delighted to hear any other ideas. We've 
diverted all the traffic to the backing cluster, so we can blow this one away 
and rebuild.

Looking at the Zookeeper logs, I see a few instances of network failures across 
all three nodes.


I *have the logs* from each of the Zookeepers.

We are running 3.4.12.




[jira] [Commented] (ZOOKEEPER-715) add better reporting for initLimit being reached

2019-05-21 Thread Richard Yu (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845459#comment-16845459
 ] 

Richard Yu commented on ZOOKEEPER-715:
--

Seeing that this is pretty old, would it still be relevant to the current 
version of zookeeper?

 

> add better reporting for initLimit being reached
> 
>
> Key: ZOOKEEPER-715
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-715
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.2.2
>Reporter: Patrick Hunt
>Priority: Major
> Fix For: 3.6.0, 3.5.6
>
>
> when the initLimit is reached (sending zk database to follower) we don't 
> print out very useful log information.
> we need to add details on when the snap is read, when the new snap is 
> written, and the start/end of the transfer to follower. start/end should 
> include useful logging in the case that initLimit is reached and the 
> operation fails.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ZOOKEEPER-1523) Better logging during instance loading/syncing

2019-05-21 Thread Richard Yu (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845455#comment-16845455
 ] 

Richard Yu commented on ZOOKEEPER-1523:
---

Is this issue still necessary? If yes, I'm interested in taking a hack at it. 
[~randgalt] [~mahadev]

> Better logging during instance loading/syncing
> --
>
> Key: ZOOKEEPER-1523
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1523
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum, server
>Affects Versions: 3.3.5
>Reporter: Jordan Zimmerman
>Priority: Critical
>
> When an instance is coming up and loading from snapshot, better logging is 
> needed so an operator knows how long until completion. Also, when syncing 
> with the leader, better logging is needed to know how long until success.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ZOOKEEPER-1000) Provide SSL in zookeeper to be able to run cross colos.

2019-05-21 Thread Michael Han (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han resolved ZOOKEEPER-1000.

Resolution: Duplicate

> Provide SSL in zookeeper to be able to run cross colos.
> ---
>
> Key: ZOOKEEPER-1000
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1000
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Mahadev konar
>Assignee: Mahadev konar
>Priority: Major
> Fix For: 3.6.0, 3.5.6
>
>
> This jira is to track SSL for zookeeper. The inter zookeeper server 
> communication and the client to server communication should be over ssl so 
> that zookeeper can be deployed over WAN's. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ZOOKEEPER-1000) Provide SSL in zookeeper to be able to run cross colos.

2019-05-21 Thread Michael Han (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845426#comment-16845426
 ] 

Michael Han commented on ZOOKEEPER-1000:


Agreed, this sounds like a dup we can close for now. If one day we find the 
current plain socket based solution is not good enough feature / performance 
wise, we can revisit this issue which is based on SSL on top of Netty.

> Provide SSL in zookeeper to be able to run cross colos.
> ---
>
> Key: ZOOKEEPER-1000
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1000
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Mahadev konar
>Assignee: Mahadev konar
>Priority: Major
> Fix For: 3.6.0, 3.5.6
>
>
> This jira is to track SSL for zookeeper. The inter zookeeper server 
> communication and the client to server communication should be over ssl so 
> that zookeeper can be deployed over WAN's. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [zookeeper] hanm commented on issue #118: ZOOKEEPER-1634: hardening security by teaching server to enforce client authentication.

2019-05-21 Thread GitBox
hanm commented on issue #118: ZOOKEEPER-1634: hardening security by teaching 
server to enforce client authentication.
URL: https://github.com/apache/zookeeper/pull/118#issuecomment-494622306
 
 
   Yes - this becomes more important with some of our internal use cases as 
well. Give me a few days to rehash and rebase the patch and we can go from 
there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (ZOOKEEPER-3399) Remove logging in getGlobalOutstandingLimit for optimal performance.

2019-05-21 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-3399:
--
Labels: pull-request-available  (was: )

> Remove logging in getGlobalOutstandingLimit for optimal performance.
> 
>
> Key: ZOOKEEPER-3399
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3399
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.6.0
>Reporter: Michael Han
>Assignee: Michael Han
>Priority: Major
>  Labels: pull-request-available
>
> Recently we have moved some of our production clusters to the top of the 
> trunk. One issue we found is a performance regression on read and write 
> latency on the clusters where the quorum is also serving traffic. The average 
> read latency increased by 50x, p99 read latency increased by 300x. 
> The root cause is a log statement introduced in ZOOKEEPER-3177 (PR711), where 
> we added a LOG.info statement in getGlobalOutstandingLimit. 
> getGlobalOutstandingLimit is on the critical code path for request processing 
> and for each request, it will be called twice (one at processing the packet, 
> one at finalizing the request response). This not only degrades performance 
> of the server, but also bloated the log file, when the QPS of a server is 
> high.
> This only impacts clusters when the quorum (leader + follower) is serving 
> traffic. For clusters where only observers are serving traffic no impact is 
> observed.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [zookeeper] hanm opened a new pull request #956: ZOOKEEPER-3399: Remove logging in getGlobalOutstandingLimit for optimal performance.

2019-05-21 Thread GitBox
hanm opened a new pull request #956: ZOOKEEPER-3399: Remove logging in 
getGlobalOutstandingLimit for optimal performance.
URL: https://github.com/apache/zookeeper/pull/956
 
 
   Please refer https://issues.apache.org/jira/browse/ZOOKEEPER-3399 for 
detailed description. This PR removes the LOG statement which was the state of 
the code path before ZOOKEEPER-3177. The original patch of ZOOKEEPER-3177 had 
the LOG statement in right place, but that was changed in the second pull 
request (711) that reverted part of the original patch due to a find bug 
warning.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (ZOOKEEPER-3399) Remove logging in getGlobalOutstandingLimit for optimal performance.

2019-05-21 Thread Michael Han (JIRA)
Michael Han created ZOOKEEPER-3399:
--

 Summary: Remove logging in getGlobalOutstandingLimit for optimal 
performance.
 Key: ZOOKEEPER-3399
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3399
 Project: ZooKeeper
  Issue Type: Bug
  Components: server
Affects Versions: 3.6.0
Reporter: Michael Han
Assignee: Michael Han


Recently we have moved some of our production clusters to the top of the trunk. 
One issue we found is a performance regression on read and write latency on the 
clusters where the quorum is also serving traffic. The average read latency 
increased by 50x, p99 read latency increased by 300x. 

The root cause is a log statement introduced in ZOOKEEPER-3177 (PR711), where 
we added a LOG.info statement in getGlobalOutstandingLimit. 
getGlobalOutstandingLimit is on the critical code path for request processing 
and for each request, it will be called twice (one at processing the packet, 
one at finalizing the request response). This not only degrades performance of 
the server, but also bloated the log file, when the QPS of a server is high.

This only impacts clusters when the quorum (leader + follower) is serving 
traffic. For clusters where only observers are serving traffic no impact is 
observed.

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Why does ZooKeeper follower shutdown itself when it can not read from leader

2019-05-21 Thread Qian Zhang
Anyone has any ideas?

Regards,
Qian Zhang


On Sun, May 19, 2019 at 6:15 PM Qian Zhang  wrote:

> Hi,
>
> I have a ZooKeeper cluster which has 5 nodes. Today the leader cannot be
> connected due to a hardware issue, and then I found the 4 followers just
> shutdown, here is the logs:
>
>> May 18 15:34:28 MD001076 java[29148]: [myid:1] WARN
>> [QuorumPeer[myid=1]/0:0:0:0:0:0:0:0:2181:Follower@89] - Exception when
>> following the leader
>>   java.net.SocketTimeoutException:
>> Read timed out
>> at
>> java.net.SocketInputStream.socketRead0(Native Method)
>> at
>> java.net.SocketInputStream.socketRead(SocketInputStream.java:116)
>> at
>> java.net.SocketInputStream.read(SocketInputStream.java:171)
>> at
>> java.net.SocketInputStream.read(SocketInputStream.java:141)
>> at
>> java.io.BufferedInputStream.fill(BufferedInputStream.java:246)
>> at
>> java.io.BufferedInputStream.read(BufferedInputStream.java:265)
>> at
>> java.io.DataInputStream.readInt(DataInputStream.java:387)
>> at
>> org.apache.jute.BinaryInputArchive.readInt(BinaryInputArchive.java:63)
>> at
>> org.apache.zookeeper.server.quorum.QuorumPacket.deserialize(QuorumPacket.java:83)
>> at
>> org.apache.jute.BinaryInputArchive.readRecord(BinaryInputArchive.java:99)
>> at
>> org.apache.zookeeper.server.quorum.Learner.readPacket(Learner.java:153)
>> at
>> org.apache.zookeeper.server.quorum.Follower.followLeader(Follower.java:85)
>> at
>> org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:937)
>> May 18 15:34:28 MD001076 java[29148]: [myid:1] INFO
>> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxnFactory@192] -
>> Accepted socket connectio
>> n from /10.249.255.10:42306
>> May 18 15:34:28 MD001076 java[29148]: [myid:1] WARN
>> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:ZooKeeperServer@896] -
>> Connection request from old cl
>> ient /10.249.255.10:42306; will be dropped if server is in r-o mode
>> May 18 15:34:28 MD001076 java[29148]: [myid:1] INFO
>> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:ZooKeeperServer@942] - Client
>> attempting to establish
>>  new session at /10.249.255.10:42306
>> May 18 15:34:28 MD001076 java[29148]: [myid:1] ERROR
>> [FollowerRequestProcessor:1:ZooKeeperCriticalThread@49] - Severe
>> unrecoverable error, from threa
>> d : FollowerRequestProcessor:1
>>   java.net.SocketException: Socket
>> closed
>> at
>> java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:118)
>> at
>> java.net.SocketOutputStream.write(SocketOutputStream.java:155)
>> at
>> java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:82)
>> at
>> java.io.BufferedOutputStream.flush(BufferedOutputStream.java:140)
>> at
>> org.apache.zookeeper.server.quorum.Learner.writePacket(Learner.java:139)
>> at
>> org.apache.zookeeper.server.quorum.Learner.request(Learner.java:188)
>> at
>> org.apache.zookeeper.server.quorum.FollowerRequestProcessor.run(FollowerRequestProcessor.java:90)
>> May 18 15:34:28 MD001076 java[29148]: [myid:1] INFO
>> [QuorumPeer[myid=1]/0:0:0:0:0:0:0:0:2181:Follower@166] - shutdown called
>>   java.lang.Exception: shutdown
>> Follower
>> at
>> org.apache.zookeeper.server.quorum.Follower.shutdown(Follower.java:166)
>> at
>> org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:941)
>
>
> I am confused why all followers shutdown in this case which makes the
> whole ZooKeeper unusable for a short period, shouldn't they elect a new
> leader instead? Thanks!
>
>
> Regards,
> Qian Zhang
>


[GitHub] [zookeeper] lvfangmin commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out

2019-05-21 Thread GitBox
lvfangmin commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() may 
take too long to time-out 
URL: https://github.com/apache/zookeeper/pull/953#issuecomment-494610638
 
 
   What @vladimirvic mentioned is valid point, but the main interest conflict 
is the larger initLimit requirement on ensemble with large data and high 
traffic to finish syncing, and the smaller timeout to avoid quorum down for a 
long time because of leader being partitioned away just after leader election.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] vladimirivic commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out

2019-05-21 Thread GitBox
vladimirivic commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() 
may take too long to time-out 
URL: https://github.com/apache/zookeeper/pull/953#issuecomment-494582370
 
 
   > Thanks for you contribution @vladimirivic .
   > 
   > I don't fully understand what's the reasoning behind this change. It looks 
like you're replacing `initLimit` with a new config value which doesn't make 
sense to me. Why not setting `initLimit` to a lower value?
   
   That's a great question. Let me try to elaborate why this config option. 
   
   In the case of Learner.connectToLeader(), initLimit is used to timeout 
solely the socket connect operation. Because this method retries up to 5 times, 
it may leave an ensemble without quorum for too long. Let's say I was using 
initLimit=20. In case of network issues, this value would leave ensemble 
without a quorum for almost 2 minutes.
   
   The problem can be remediated with use of smaller initLimit value. And I can 
set it to initLimit=10, or even initLimit=5 so when there are network issues 
and if we wait for all 5 reties we don't spend to much time without having the 
quorum. 
   
   That would solve the problem for the socket but then it may cause issues 
inside Leader.lead() because initLimit is used by these three methods after the 
leader gets elected and starts leading:
 - Leader.getEpochToPropose()
 - Leader.waitForEpochAck()
 - Leader.waitForNewLeaderAck()
   
   If we go with initLimit smaller than what we tolerate, then that will 
increase the number of the Exceptions when using ensembles that are not in the 
same region which will cause quorum issues. Particularly these three from 
Leader.java: 
 - Timeout while waiting for NEWLEADER to be acked by quorum
 - Timeout while waiting for epoch from quorum 
 - Timeout while waiting for epoch to be acked by quorum
   
   I think it would be good to have a separate config to control socket 
connection timeout without affecting the quorum timeout so they don't hinder 
each other.
   
   Hopefully this helps shed some light with this pull request. Also, if this 
sounds like a good idea, maybe we should take into consideration other socket 
connect calls and use unified config name to address this. Let me know what you 
think. 
   
   You can also touch base with @lvfangmin for more specific details about the 
problems we have seen in production.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Resolved] (ZOOKEEPER-3394) Delay observer reconnect when all learner masters have been tried

2019-05-21 Thread Fangmin Lv (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fangmin Lv resolved ZOOKEEPER-3394.
---
   Resolution: Fixed
Fix Version/s: 3.6.0

Issue resolved by pull request 948
[https://github.com/apache/zookeeper/pull/948]

> Delay observer reconnect when all learner masters have been tried
> -
>
> Key: ZOOKEEPER-3394
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3394
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Affects Versions: 3.6.0
>Reporter: Brian Nixon
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Observers will disconnect when the voting peers perform a leader election and 
> reconnect after. The delay zookeeper.observer.reconnectDelayMs was added to 
> insulate the voting peers from the observers returning. With a large number 
> of peers and the observerMaster feature active, this delay is mostly 
> detrimental as it means that the observer is more likely to get hung up on 
> connecting to a bad (down/corrupt) peer and it would be better off switching 
> to a new one quickly.
> To retain the protective virtue of the delay, it makes sense to add a delay 
> that after all observer master's in the list have been tried before iterating 
> through the list again. In the case where observer master's are not active, 
> this degenerates to a delay between connection attempts on the leader.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ZOOKEEPER-3394) Delay observer reconnect when all learner masters have been tried

2019-05-21 Thread Fangmin Lv (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fangmin Lv reassigned ZOOKEEPER-3394:
-

Assignee: Brian Nixon

> Delay observer reconnect when all learner masters have been tried
> -
>
> Key: ZOOKEEPER-3394
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3394
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Affects Versions: 3.6.0
>Reporter: Brian Nixon
>Assignee: Brian Nixon
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Observers will disconnect when the voting peers perform a leader election and 
> reconnect after. The delay zookeeper.observer.reconnectDelayMs was added to 
> insulate the voting peers from the observers returning. With a large number 
> of peers and the observerMaster feature active, this delay is mostly 
> detrimental as it means that the observer is more likely to get hung up on 
> connecting to a bad (down/corrupt) peer and it would be better off switching 
> to a new one quickly.
> To retain the protective virtue of the delay, it makes sense to add a delay 
> that after all observer master's in the list have been tried before iterating 
> through the list again. In the case where observer master's are not active, 
> this degenerates to a delay between connection attempts on the leader.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [zookeeper] lvfangmin commented on issue #851: ZOOKEEPER-3311: Allow a delay to the transaction log flush

2019-05-21 Thread GitBox
lvfangmin commented on issue #851: ZOOKEEPER-3311: Allow a delay to the 
transaction log flush
URL: https://github.com/apache/zookeeper/pull/851#issuecomment-494569981
 
 
   @eolivelli is the latest version look good to you?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] asfgit closed pull request #948: ZOOKEEPER-3394: Delay observer reconnect when all learner masters hav…

2019-05-21 Thread GitBox
asfgit closed pull request #948: ZOOKEEPER-3394: Delay observer reconnect when 
all learner masters hav…
URL: https://github.com/apache/zookeeper/pull/948
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] lvfangmin commented on issue #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand

2019-05-21 Thread GitBox
lvfangmin commented on issue #899: ZOOKEEPER-3354: Improve efficiency of 
DeleteAllCommand
URL: https://github.com/apache/zookeeper/pull/899#issuecomment-494569580
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Resolved] (ZOOKEEPER-3323) Add TxnSnapLog metrics

2019-05-21 Thread Fangmin Lv (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fangmin Lv resolved ZOOKEEPER-3323.
---
Resolution: Fixed

Issue resolved by pull request 859
[https://github.com/apache/zookeeper/pull/859]

> Add TxnSnapLog metrics
> --
>
> Key: ZOOKEEPER-3323
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3323
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: metric system
>Reporter: Jie Huang
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 4h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [zookeeper] asfgit closed pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics

2019-05-21 Thread GitBox
asfgit closed pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics
URL: https://github.com/apache/zookeeper/pull/859
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] lvfangmin commented on issue #859: ZOOKEEPER-3323: Add TxnSnapLog metrics

2019-05-21 Thread GitBox
lvfangmin commented on issue #859: ZOOKEEPER-3323: Add TxnSnapLog metrics
URL: https://github.com/apache/zookeeper/pull/859#issuecomment-494566751
 
 
   It addressed @anmolnar's comment, I'll merge it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: [ANNOUNCE] Apache ZooKeeper 3.5.5

2019-05-21 Thread rammohan ganapavarapu
Hi Jordan,

Thank you, will do let you know.

Ram

On Tue, May 21, 2019 at 8:58 AM Jordan Zimmerman 
wrote:

> AFAIK, the version of ZooKeeper 3.5.5 being released is fully compatible
> with Curator. Please let us know if you find any issues.
>
> -Jordan
>
> > On May 21, 2019, at 10:44 AM, rammohan ganapavarapu <
> rammohanga...@gmail.com> wrote:
> >
> > I am curious to know what are the compatible "Apache Curator" client
> > version for 3.5.5 version.
> > Also is there any upgrade path from 3.4.5 to 3.5.5. Can i add a 3.5.5
> > follower/observer for a 3.4.5 leader and vice versa?
> >
> > Thanks,
> > Ram
> >
> > On Tue, May 21, 2019 at 1:34 AM Tamas Penzes  >
> > wrote:
> >
> >> Congratulations!
> >>
> >> We waited for this release for a really long time. I'm looking forward
> to
> >> use it.
> >> ZooKeeper arrived to a new Era.
> >>
> >> Regards, Tamaas
> >>
> >> On Tue, May 21, 2019 at 4:18 AM Zili Chen  wrote:
> >>
> >>> Congratulations!
> >>>
> >>> rammohan ganapavarapu  于2019年5月21日周二
> 上午7:25写道:
> >>>
>  Congratulations, finally it's out 😊
> 
>  On Mon, May 20, 2019, 11:59 AM Enrico Olivelli 
>  wrote:
> 
> > Congratulations!
> >
> > Enrico
> >
> > Il lun 20 mag 2019, 19:28 Lars Francke  ha
> > scritto:
> >
> >> Congratulations on this release! It looks great and I'm looking
> >>> forward
> > to
> >> using all those new features.
> >>
> >> Thank you, everyone, for your work on this.
> >>
> >> On Mon, May 20, 2019 at 7:06 PM Andor Molnar 
> >>> wrote:
> >>
> >>> The Apache ZooKeeper team is proud to announce Apache ZooKeeper
>  version
> >>> 3.5.5
> >>>
> >>> ZooKeeper is a high-performance coordination service for
> >>> distributed
> >>> applications. It exposes common services - such as naming,
> >>> configuration management, synchronization, and group services -
> >> in
> >>> a
> >>> simple interface so you don't have to write them from scratch.
> >> You
>  can
> >>> use it off-the-shelf to implement consensus, group management,
> >>> leader
> >>> election, and presence protocols. And you can build on it for
> >> your
> >>> own, specific needs.
> >>>
> >>> For ZooKeeper release details and downloads, visit:
> >>> https://zookeeper.apache.org/releases.html
> >>>
> >>> ZooKeeper 3.5.5 Release Notes are at:
> >>> https://zookeeper.apache.org/doc/r3.5.5/releasenotes.html
> >>>
> >>> We would like to thank the contributors that made the release
>  possible.
> >>>
> >>> Regards,
> >>>
> >>> The ZooKeeper Team
> >>>
> >>>
> >>>
> >>
> >
> 
> >>>
> >>
>
>


[GitHub] [zookeeper] eolivelli commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server

2019-05-21 Thread GitBox
eolivelli commented on issue #923: ZOOKEEPER-1426: add version command to the 
zookeeper server
URL: https://github.com/apache/zookeeper/pull/923#issuecomment-494466684
 
 
   @anmolnar this script won't work if you build zk wiith maven


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: [ANNOUNCE] Apache ZooKeeper 3.5.5

2019-05-21 Thread Jordan Zimmerman
AFAIK, the version of ZooKeeper 3.5.5 being released is fully compatible with 
Curator. Please let us know if you find any issues.

-Jordan

> On May 21, 2019, at 10:44 AM, rammohan ganapavarapu  
> wrote:
> 
> I am curious to know what are the compatible "Apache Curator" client
> version for 3.5.5 version.
> Also is there any upgrade path from 3.4.5 to 3.5.5. Can i add a 3.5.5
> follower/observer for a 3.4.5 leader and vice versa?
> 
> Thanks,
> Ram
> 
> On Tue, May 21, 2019 at 1:34 AM Tamas Penzes 
> wrote:
> 
>> Congratulations!
>> 
>> We waited for this release for a really long time. I'm looking forward to
>> use it.
>> ZooKeeper arrived to a new Era.
>> 
>> Regards, Tamaas
>> 
>> On Tue, May 21, 2019 at 4:18 AM Zili Chen  wrote:
>> 
>>> Congratulations!
>>> 
>>> rammohan ganapavarapu  于2019年5月21日周二 上午7:25写道:
>>> 
 Congratulations, finally it's out 😊
 
 On Mon, May 20, 2019, 11:59 AM Enrico Olivelli 
 wrote:
 
> Congratulations!
> 
> Enrico
> 
> Il lun 20 mag 2019, 19:28 Lars Francke  ha
> scritto:
> 
>> Congratulations on this release! It looks great and I'm looking
>>> forward
> to
>> using all those new features.
>> 
>> Thank you, everyone, for your work on this.
>> 
>> On Mon, May 20, 2019 at 7:06 PM Andor Molnar 
>>> wrote:
>> 
>>> The Apache ZooKeeper team is proud to announce Apache ZooKeeper
 version
>>> 3.5.5
>>> 
>>> ZooKeeper is a high-performance coordination service for
>>> distributed
>>> applications. It exposes common services - such as naming,
>>> configuration management, synchronization, and group services -
>> in
>>> a
>>> simple interface so you don't have to write them from scratch.
>> You
 can
>>> use it off-the-shelf to implement consensus, group management,
>>> leader
>>> election, and presence protocols. And you can build on it for
>> your
>>> own, specific needs.
>>> 
>>> For ZooKeeper release details and downloads, visit:
>>> https://zookeeper.apache.org/releases.html
>>> 
>>> ZooKeeper 3.5.5 Release Notes are at:
>>> https://zookeeper.apache.org/doc/r3.5.5/releasenotes.html
>>> 
>>> We would like to thank the contributors that made the release
 possible.
>>> 
>>> Regards,
>>> 
>>> The ZooKeeper Team
>>> 
>>> 
>>> 
>> 
> 
 
>>> 
>> 



Re: [ANNOUNCE] Apache ZooKeeper 3.5.5

2019-05-21 Thread rammohan ganapavarapu
I am curious to know what are the compatible "Apache Curator" client
version for 3.5.5 version.
Also is there any upgrade path from 3.4.5 to 3.5.5. Can i add a 3.5.5
follower/observer for a 3.4.5 leader and vice versa?

Thanks,
Ram

On Tue, May 21, 2019 at 1:34 AM Tamas Penzes 
wrote:

> Congratulations!
>
> We waited for this release for a really long time. I'm looking forward to
> use it.
> ZooKeeper arrived to a new Era.
>
> Regards, Tamaas
>
> On Tue, May 21, 2019 at 4:18 AM Zili Chen  wrote:
>
> > Congratulations!
> >
> > rammohan ganapavarapu  于2019年5月21日周二 上午7:25写道:
> >
> > > Congratulations, finally it's out 😊
> > >
> > > On Mon, May 20, 2019, 11:59 AM Enrico Olivelli 
> > > wrote:
> > >
> > > > Congratulations!
> > > >
> > > > Enrico
> > > >
> > > > Il lun 20 mag 2019, 19:28 Lars Francke  ha
> > > > scritto:
> > > >
> > > > > Congratulations on this release! It looks great and I'm looking
> > forward
> > > > to
> > > > > using all those new features.
> > > > >
> > > > > Thank you, everyone, for your work on this.
> > > > >
> > > > > On Mon, May 20, 2019 at 7:06 PM Andor Molnar 
> > wrote:
> > > > >
> > > > > > The Apache ZooKeeper team is proud to announce Apache ZooKeeper
> > > version
> > > > > > 3.5.5
> > > > > >
> > > > > > ZooKeeper is a high-performance coordination service for
> > distributed
> > > > > > applications. It exposes common services - such as naming,
> > > > > > configuration management, synchronization, and group services -
> in
> > a
> > > > > > simple interface so you don't have to write them from scratch.
> You
> > > can
> > > > > > use it off-the-shelf to implement consensus, group management,
> > leader
> > > > > > election, and presence protocols. And you can build on it for
> your
> > > > > > own, specific needs.
> > > > > >
> > > > > > For ZooKeeper release details and downloads, visit:
> > > > > > https://zookeeper.apache.org/releases.html
> > > > > >
> > > > > > ZooKeeper 3.5.5 Release Notes are at:
> > > > > > https://zookeeper.apache.org/doc/r3.5.5/releasenotes.html
> > > > > >
> > > > > > We would like to thank the contributors that made the release
> > > possible.
> > > > > >
> > > > > > Regards,
> > > > > >
> > > > > > The ZooKeeper Team
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>


[GitHub] [zookeeper] eolivelli commented on issue #955: ZOOKEEPER-3362: Create a simple checkstyle file

2019-05-21 Thread GitBox
eolivelli commented on issue #955: ZOOKEEPER-3362: Create a simple checkstyle 
file
URL: https://github.com/apache/zookeeper/pull/955#issuecomment-494428573
 
 
   @anmolnar this is the port for #909 to branch-3.5
   we should cherry pick to branch-3.4 as well


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] nkalmar removed a comment on issue #954: ZOOKEEPER-3263: JAVA9/11 Warnings: Illegal reflective access in zookeeper's kerberosUtil (3.5)

2019-05-21 Thread GitBox
nkalmar removed a comment on issue #954: ZOOKEEPER-3263: JAVA9/11 Warnings: 
Illegal reflective access in zookeeper's kerberosUtil (3.5)
URL: https://github.com/apache/zookeeper/pull/954#issuecomment-494428184
 
 
   Sorry guys, disregard this message, I have some issues with notifications, 
this is a test.
   
   @nkalmar 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] nkalmar commented on issue #954: ZOOKEEPER-3263: JAVA9/11 Warnings: Illegal reflective access in zookeeper's kerberosUtil (3.5)

2019-05-21 Thread GitBox
nkalmar commented on issue #954: ZOOKEEPER-3263: JAVA9/11 Warnings: Illegal 
reflective access in zookeeper's kerberosUtil (3.5)
URL: https://github.com/apache/zookeeper/pull/954#issuecomment-494428184
 
 
   Sorry guys, disregard this message, I have some issues with notifications, 
this is a test.
   
   @nkalmar 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] eolivelli opened a new pull request #955: ZOOKEEPER-3362: Create a simple checkstyle file

2019-05-21 Thread GitBox
eolivelli opened a new pull request #955: ZOOKEEPER-3362: Create a simple 
checkstyle file
URL: https://github.com/apache/zookeeper/pull/955
 
 
   Create a basic checkstyle file, in order to cover the minimal check on 
author tags.
   
   This is needed in order to drop old ANT based precommit job (see 
ZOOKEEPER-3351)
   
   We will not remove legacy checkstyle configuration file in 
zookeeper-server/src/test/resources/checkstyle.xml because it is referred by 
ANT build.xml files (even if we are not actually using that target).
   
   This task won't add a complete checkstyle configuration with usual checks 
because it would imply almost a change at every .java in the codebase.
   
   Author: Enrico Olivelli 
   
   Reviewers: an...@apache.org
   
   Closes #909 from eolivelli/fix/checkstyle and squashes the following commits:
   
   fdda1571c [Enrico Olivelli] use a property in order to define checkstyle 
version
   92192981f [Enrico Olivelli] Skip CPP tests when using -DskipTests
   b816e563e [Enrico Olivelli] Add cppunit for Travis
   faf37bb37 [Enrico Olivelli] ZOOKEEPER-3362 Create a simple checkstyle file


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] anmolnar commented on issue #954: ZOOKEEPER-3263: JAVA9/11 Warnings: Illegal reflective access in zookeeper's kerberosUtil (3.5)

2019-05-21 Thread GitBox
anmolnar commented on issue #954: ZOOKEEPER-3263: JAVA9/11 Warnings: Illegal 
reflective access in zookeeper's kerberosUtil (3.5)
URL: https://github.com/apache/zookeeper/pull/954#issuecomment-494415902
 
 
   retest ant build


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


ZooKeeper_branch35_jdk8 - Build # 1414 - Failure

2019-05-21 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1414/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 67.16 KB...]
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.655 sec, Thread: 1, Class: org.apache.zookeeper.test.SaslSuperUserTest
[junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.348 sec, Thread: 1, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.56 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 1
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
13.011 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.259 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionTimeoutTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
1
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.11 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 1
[junit] Tests run: 105, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
363.157 sec, Thread: 3, Class: org.apache.zookeeper.test.NettyNettySuiteTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
19.684 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 3
[junit] Running org.apache.zookeeper.test.StatTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.011 sec, Thread: 1, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.589 sec, Thread: 3, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.071 sec, Thread: 3, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.677 sec, Thread: 1, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 3
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.657 sec, Thread: 3, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 3
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
6.179 sec, Thread: 1, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.075 sec, Thread: 1, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 1
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.994 sec, Thread: 1, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
19.461 sec, Thread: 3, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 3
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.086 sec, Thread: 3, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 3
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
6.596 sec, Thread: 3, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.695 sec, Thread: 3, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Running org.apache.zookeeper.util.PemReaderTest in thread 3
[junit] Tests run: 64, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.836 sec, Thread: 3, Class: org.apache.zookeeper.util.PemReaderTest
[junit] Running org.apache.jute.BinaryInputArchiveTest in thread 3
[ju

ZooKeeper_branch34_openjdk8 - Build # 332 - Failure

2019-05-21 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/332/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 44.21 KB...]
[junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.789 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.914 sec
[junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.758 sec
[junit] Running org.apache.zookeeper.test.SaslClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.189 sec
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.921 sec
[junit] Running org.apache.zookeeper.test.SessionTest
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
12.676 sec
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.414 sec
[junit] Running org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.144 sec
[junit] Running org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.848 sec
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.109 sec
[junit] Running org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.859 sec
[junit] Running org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
9.963 sec
[junit] Running org.apache.zookeeper.test.UpgradeTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
4.211 sec
[junit] Running org.apache.zookeeper.test.WatchedEventTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.158 sec
[junit] Running org.apache.zookeeper.test.WatcherFuncTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
5.505 sec
[junit] Running org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
33.915 sec
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
19.755 sec
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.497 sec
[junit] Running org.apache.jute.BinaryInputArchiveTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.136 sec

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk8/build.xml:1425:
 The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk8/build.xml:1428:
 Tests failed!

Total time: 42 minutes 48 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/
Recording test results
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  org.apache.zookeeper.test.QuorumHammerTest.testHammerBasic

Error Message:
expected:<1000> but was:<362>

Stack Trace:
junit.framework.AssertionFailedError: expected:<1000> but was:<362>
at 
org.apache.zookeeper.test.ClientHammerTest.verifyHammer(ClientHammerTest.java:231)
at 
org.apache.zookeeper.test.ClientHammerTest.runHammer(ClientHammerTest.java:142)
at 
org.apache.zookeeper.test.ClientHammerTest.testHammerBasic(ClientHammerTest.java:120)
at 
org.apache.zookeeper.test.QuorumHammerTest.testHammerBasic(QuorumHammerTest.java:49)
at 
org.apache.zookeeper

[GitHub] [zookeeper] anmolnar opened a new pull request #954: ZOOKEEPER-3263: JAVA9/11 Warnings: Illegal reflective access in zookeeper's kerberosUtil (3.5)

2019-05-21 Thread GitBox
anmolnar opened a new pull request #954: ZOOKEEPER-3263: JAVA9/11 Warnings: 
Illegal reflective access in zookeeper's kerberosUtil (3.5)
URL: https://github.com/apache/zookeeper/pull/954
 
 
   Fixes warning messages of JDK 9/11 by upgrading libraries and refactoring 
`KerberosUtils` based on experiences of 
[HADOOP-10848](https://issues.apache.org/jira/browse/HADOOP-10848)
   
   Reviewers please run unit tests with various JDK versions including 9 and 
11, because CI only runs on JDK 8. Thanks.
   
   Target branches are master and 3.5
   
   Author: Andor Molnar 
   
   Reviewers: Enrico Olivelli 
   
   Closes #950 from anmolnar/ZOOKEEPER-3263


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] anmolnar commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server

2019-05-21 Thread GitBox
anmolnar commented on issue #923: ZOOKEEPER-1426: add version command to the 
zookeeper server
URL: https://github.com/apache/zookeeper/pull/923#issuecomment-494338711
 
 
   @szepet @eolivelli How are you getting on with this patch?
   I'm willing to commit, but seeing -1 from @eolivelli .


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: [ANNOUNCE] Apache ZooKeeper 3.5.5

2019-05-21 Thread Tamas Penzes
Congratulations!

We waited for this release for a really long time. I'm looking forward to
use it.
ZooKeeper arrived to a new Era.

Regards, Tamaas

On Tue, May 21, 2019 at 4:18 AM Zili Chen  wrote:

> Congratulations!
>
> rammohan ganapavarapu  于2019年5月21日周二 上午7:25写道:
>
> > Congratulations, finally it's out 😊
> >
> > On Mon, May 20, 2019, 11:59 AM Enrico Olivelli 
> > wrote:
> >
> > > Congratulations!
> > >
> > > Enrico
> > >
> > > Il lun 20 mag 2019, 19:28 Lars Francke  ha
> > > scritto:
> > >
> > > > Congratulations on this release! It looks great and I'm looking
> forward
> > > to
> > > > using all those new features.
> > > >
> > > > Thank you, everyone, for your work on this.
> > > >
> > > > On Mon, May 20, 2019 at 7:06 PM Andor Molnar 
> wrote:
> > > >
> > > > > The Apache ZooKeeper team is proud to announce Apache ZooKeeper
> > version
> > > > > 3.5.5
> > > > >
> > > > > ZooKeeper is a high-performance coordination service for
> distributed
> > > > > applications. It exposes common services - such as naming,
> > > > > configuration management, synchronization, and group services - in
> a
> > > > > simple interface so you don't have to write them from scratch. You
> > can
> > > > > use it off-the-shelf to implement consensus, group management,
> leader
> > > > > election, and presence protocols. And you can build on it for your
> > > > > own, specific needs.
> > > > >
> > > > > For ZooKeeper release details and downloads, visit:
> > > > > https://zookeeper.apache.org/releases.html
> > > > >
> > > > > ZooKeeper 3.5.5 Release Notes are at:
> > > > > https://zookeeper.apache.org/doc/r3.5.5/releasenotes.html
> > > > >
> > > > > We would like to thank the contributors that made the release
> > possible.
> > > > >
> > > > > Regards,
> > > > >
> > > > > The ZooKeeper Team
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
>


Re: Maven release findings

2019-05-21 Thread Norbert Kalmar
We can drop jute apidocs, I commented this on the PR, that for now it will
be separate, as merging the 2 apidocs is kind of pain in the...

If 4.0.0 is coming than perhaps we will drop jute anyway :)

Regards,
Norbert

On Mon, May 20, 2019 at 9:55 PM Andor Molnár  wrote:

> Answers inline.
>
>
> On 5/20/19 20:15, Enrico Olivelli wrote:
> > Il lun 20 mag 2019, 19:59 Andor Molnar  ha
> > scritto:
> >
> >> Hi team,
> >>
> >> We're looking pretty good, I've updated the Maven release page with
> >> experiences of this release:
> >>
> >>
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease+using+maven
> >>
> >> This should be the latest and greatest release doc now.
> >>
> >> Unfortunately I've run into a pretty major issue which affects the
> release
> >> artifact too. The generated API docs are incorrectly linked during
> >> generation. Details are here:
> >> https://issues.apache.org/jira/browse/ZOOKEEPER-3397
> >>
> >> The main issue is basically that we now have separated -jute and -server
> >> API docs. As a quick fix, I've updated the website and copied over
> >> zookeeper-server docs (jute is not included), but we need to fix this in
> >> the long run.
> >>
> > I am not sure how much jute javadocs are useful.
>
>
> I'm happy to drop it.
>
> Probably that would be the easiest to resolve this.
>
>
> >
> >> Other than that the process was pretty neat.
> >> Jira has been updated, 3.5.5 version is now released and 3.5.6 is
> available
> >> for new issues.
> >>
> >> Happy coding everyone!
> >>
> >
> > Thanks
> > I think a new era begins for the project now that we dropped that nasty
> > -beta qualifier.
> >
> > I hope we will be able to start cutting releases more often
>
>
> Agreed. As a first step maybe we could cut 3.6.0 and change master to
> 4.0.0.
>
>
> Andor
>
>
>
>


[jira] [Commented] (ZOOKEEPER-1147) Add support for local sessions

2019-05-21 Thread Lars Francke (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844602#comment-16844602
 ] 

Lars Francke commented on ZOOKEEPER-1147:
-

Thanks for checking. Did you already create a follow-up ticket? If not I can do 
so.

> Add support for local sessions
> --
>
> Key: ZOOKEEPER-1147
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1147
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.3.3
>Reporter: Vishal Kathuria
>Assignee: Thawan Kooburat
>Priority: Major
>  Labels: api-change, scaling
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1147.patch, ZOOKEEPER-1147.patch, 
> ZOOKEEPER-1147.patch, ZOOKEEPER-1147.patch, ZOOKEEPER-1147.patch, 
> ZOOKEEPER-1147.patch, ZOOKEEPER-1147.patch, ZOOKEEPER-1147.patch, 
> ZOOKEEPER-1147.patch
>
>   Original Estimate: 840h
>  Remaining Estimate: 840h
>
> This improvement is in the bucket of making ZooKeeper work at a large scale. 
> We are planning on having about a 1 million clients connect to a ZooKeeper 
> ensemble through a set of 50-100 observers. Majority of these clients are 
> read only - ie they do not do any updates or create ephemeral nodes.
> In ZooKeeper today, the client creates a session and the session creation is 
> handled like any other update. In the above use case, the session create/drop 
> workload can easily overwhelm an ensemble. The following is a proposal for a 
> "local session", to support a larger number of connections.
> 1.   The idea is to introduce a new type of session - "local" session. A 
> "local" session doesn't have a full functionality of a normal session.
> 2.   Local sessions cannot create ephemeral nodes.
> 3.   Once a local session is lost, you cannot re-establish it using the 
> session-id/password. The session and its watches are gone for good.
> 4.   When a local session connects, the session info is only maintained 
> on the zookeeper server (in this case, an observer) that it is connected to. 
> The leader is not aware of the creation of such a session and there is no 
> state written to disk.
> 5.   The pings and expiration is handled by the server that the session 
> is connected to.
> With the above changes, we can make ZooKeeper scale to a much larger number 
> of clients without making the core ensemble a bottleneck.
> In terms of API, there are two options that are being considered
> 1. Let the client specify at the connect time which kind of session do they 
> want.
> 2. All sessions connect as local sessions and automatically get promoted to 
> global sessions when they do an operation that requires a global session 
> (e.g. creating an ephemeral node)
> Chubby took the approach of lazily promoting all sessions to global, but I 
> don't think that would work in our case, where we want to keep sessions which 
> never create ephemeral nodes as always local. Option 2 would make it more 
> broadly usable but option 1 would be easier to implement.
> We are thinking of implementing option 1 as the first cut. There would be a 
> client flag, IsLocalSession (much like the current readOnly flag) that would 
> be used to determine whether to create a local session or a global session.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)