Re: [VOTE] Separate mailing lists for Jira and Github/Gitbox notifications - Take 2

[Lars Francke]

Can anyone tell me where the site source lives?

I assumed  but that
was updated 18 months ago but the site has information on release 3.5.5 so
there must be something else somewhere.

On Wed, May 29, 2019 at 8:30 AM Lars Francke  wrote:

> Alright, I'm closing this.
>
> I've requested both issues@ and notifications@ and will file the
> necessary tickets once that's done.
> You should get a mail to private@ but I'll also check the status.
>
> On Mon, May 27, 2019 at 11:54 PM Lars Francke 
> wrote:
>
>> I'd like to close the vote but forgot to state the "rules" in the initial
>> mail. I would think that this change requires lazy consensus which we have
>> achieved already. But because I forgot I'll wait another day before I close
>> this.
>>
>> 2 binding (both Enrico & Norbert are now committers, congratulations!)
>> 1 non-binding
>>
>> If there are no more objections until tomorrow I'll file the necessary
>> Jira tasks for INFRA (referring to this thread) and will request the
>> mailing lists (using the same moderators as dev@).
>>
>> Cheers,
>> Lars
>>
>> On Fri, May 17, 2019 at 7:06 PM Enrico Olivelli 
>> wrote:
>>
>>> +1
>>>
>>> Enrico
>>>
>>> Il ven 17 mag 2019, 17:11 Norbert Kalmar 
>>> ha
>>> scritto:
>>>
>>> > +1 (non-binding)
>>> >
>>> > Whoever will do the change (if voted), needs to make sure stuff like
>>> > markmail are updated/checked.
>>> > I see Apache projects going for separate mailing lists for automated
>>> > notifications (I subscribed to HBase and Thrift for example, they have
>>> this
>>> > separation).
>>> >
>>> > My +1 is to separate the automated messages from the dev list, we can
>>> > discuss the details. For example, we already have a commit list [1].
>>> Also,
>>> > some automated messages might stay on this list, like creating a new
>>> jira
>>> > (as mentioned on the DISCUSS thread).
>>> >
>>> > Regards,
>>> > Norbert
>>> >
>>> > [1] https://zookeeper.apache.org/lists.html
>>> >
>>> > On Fri, May 17, 2019 at 5:00 PM Lars Francke 
>>> > wrote:
>>> >
>>> > > And here is my +1 (non-binding)
>>> > >
>>> > > On Fri, May 17, 2019 at 4:55 PM Lars Francke >> >
>>> > > wrote:
>>> > >
>>> > > > Hi ZooKeeper devs,
>>> > > >
>>> > > > I'd like to call a vote on whether we want to have separate mailing
>>> > lists
>>> > > > for dev chatter (mostly humans) and automated notifications
>>> > > >
>>> > > > Andor summarized this in another thread:
>>> > > > - Jenkins build notifications: failures / successes,
>>> > > > - Jira notifications: Created, Updated, Status change, Commented,
>>> etc.
>>> > > > - Github notifications: opened/closed pull request, commented on
>>> pull
>>> > > > request, etc.
>>> > > >
>>> > > > This was previously discussed in two threads[1][2]
>>> > > >
>>> > > > This is the suggestion:
>>> > > > Jira
>>> > > > 
>>> > > > Issue created -> dev@zookeeper.apache.org + issues@
>>> > > > Everything else -> iss...@zookeeper.apache.org
>>> > > >
>>> > > > Github/Gitbox
>>> > > > --
>>> > > > All notifications sent to notificati...@zookeeper.apache.org
>>> > > >
>>> > > > issues@ and notifications@ mailing lists have to be created first.
>>> > > >
>>> > > >
>>> > > > Please vote on the issue. I'll leave the vote running for at least
>>> 72
>>> > > > hours considering we have a weekend ahead of us probably a bit
>>> longer.
>>> > > >
>>> > > > Cheers,
>>> > > > Lars
>>> > > >
>>> > > > [1] <
>>> > > >
>>> > >
>>> >
>>> https://lists.apache.org/thread.html/ae530b1c7dae8b83740d83243f18b76d6e0e6572ff1bfb6189e6e0d6@%3Cdev.zookeeper.apache.org%3E
>>> > > > >
>>> > > > [2] <
>>> > > >
>>> > >
>>> >
>>> https://lists.apache.org/thread.html/bd7bdae9da67145dcde636219c6d3bd8429565cd864abc55358eb67f@
>>> > > 
>>> > > > >
>>> > > >
>>> > >
>>> >
>>>
>>

Re: [VOTE] Separate mailing lists for Jira and Github/Gitbox notifications - Take 2

[Lars Francke]

Alright, I'm closing this.

I've requested both issues@ and notifications@ and will file the necessary
tickets once that's done.
You should get a mail to private@ but I'll also check the status.

On Mon, May 27, 2019 at 11:54 PM Lars Francke 
wrote:

> I'd like to close the vote but forgot to state the "rules" in the initial
> mail. I would think that this change requires lazy consensus which we have
> achieved already. But because I forgot I'll wait another day before I close
> this.
>
> 2 binding (both Enrico & Norbert are now committers, congratulations!)
> 1 non-binding
>
> If there are no more objections until tomorrow I'll file the necessary
> Jira tasks for INFRA (referring to this thread) and will request the
> mailing lists (using the same moderators as dev@).
>
> Cheers,
> Lars
>
> On Fri, May 17, 2019 at 7:06 PM Enrico Olivelli 
> wrote:
>
>> +1
>>
>> Enrico
>>
>> Il ven 17 mag 2019, 17:11 Norbert Kalmar 
>> ha
>> scritto:
>>
>> > +1 (non-binding)
>> >
>> > Whoever will do the change (if voted), needs to make sure stuff like
>> > markmail are updated/checked.
>> > I see Apache projects going for separate mailing lists for automated
>> > notifications (I subscribed to HBase and Thrift for example, they have
>> this
>> > separation).
>> >
>> > My +1 is to separate the automated messages from the dev list, we can
>> > discuss the details. For example, we already have a commit list [1].
>> Also,
>> > some automated messages might stay on this list, like creating a new
>> jira
>> > (as mentioned on the DISCUSS thread).
>> >
>> > Regards,
>> > Norbert
>> >
>> > [1] https://zookeeper.apache.org/lists.html
>> >
>> > On Fri, May 17, 2019 at 5:00 PM Lars Francke 
>> > wrote:
>> >
>> > > And here is my +1 (non-binding)
>> > >
>> > > On Fri, May 17, 2019 at 4:55 PM Lars Francke 
>> > > wrote:
>> > >
>> > > > Hi ZooKeeper devs,
>> > > >
>> > > > I'd like to call a vote on whether we want to have separate mailing
>> > lists
>> > > > for dev chatter (mostly humans) and automated notifications
>> > > >
>> > > > Andor summarized this in another thread:
>> > > > - Jenkins build notifications: failures / successes,
>> > > > - Jira notifications: Created, Updated, Status change, Commented,
>> etc.
>> > > > - Github notifications: opened/closed pull request, commented on
>> pull
>> > > > request, etc.
>> > > >
>> > > > This was previously discussed in two threads[1][2]
>> > > >
>> > > > This is the suggestion:
>> > > > Jira
>> > > > 
>> > > > Issue created -> dev@zookeeper.apache.org + issues@
>> > > > Everything else -> iss...@zookeeper.apache.org
>> > > >
>> > > > Github/Gitbox
>> > > > --
>> > > > All notifications sent to notificati...@zookeeper.apache.org
>> > > >
>> > > > issues@ and notifications@ mailing lists have to be created first.
>> > > >
>> > > >
>> > > > Please vote on the issue. I'll leave the vote running for at least
>> 72
>> > > > hours considering we have a weekend ahead of us probably a bit
>> longer.
>> > > >
>> > > > Cheers,
>> > > > Lars
>> > > >
>> > > > [1] <
>> > > >
>> > >
>> >
>> https://lists.apache.org/thread.html/ae530b1c7dae8b83740d83243f18b76d6e0e6572ff1bfb6189e6e0d6@%3Cdev.zookeeper.apache.org%3E
>> > > > >
>> > > > [2] <
>> > > >
>> > >
>> >
>> https://lists.apache.org/thread.html/bd7bdae9da67145dcde636219c6d3bd8429565cd864abc55358eb67f@
>> > > 
>> > > > >
>> > > >
>> > >
>> >
>>
>

[GitHub] [zookeeper] eolivelli commented on issue #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE

[GitBox]

eolivelli commented on issue #962: ZOOKEEPER-3405: Upgrade the version of 
Jackson-databind to address OWASP CVE
URL: https://github.com/apache/zookeeper/pull/962#issuecomment-496789395
 
 
   retest maven buiild


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] hanm commented on issue #118: ZOOKEEPER-1634: hardening security by teaching server to enforce client authentication.

[GitBox]

hanm commented on issue #118: ZOOKEEPER-1634: hardening security by teaching 
server to enforce client authentication.
URL: https://github.com/apache/zookeeper/pull/118#issuecomment-496771839
 
 
   @enixon Thank you for feedback, I'll keep this in mind.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (ZOOKEEPER-3401) Fix metric PROPOSAL_ACK_CREATION_LATENCY

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850298#comment-16850298
 ] 

Hudson commented on ZOOKEEPER-3401:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #543 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/543/])
ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY (nkalmar: rev 
bb94aa44de61bfb2ecd5bbd12b4eb390c2cf39c1)
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/AckRequestProcessor.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerMetricsTest.java


> Fix metric PROPOSAL_ACK_CREATION_LATENCY
> 
>
> Key: ZOOKEEPER-3401
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3401
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: metric system
>Reporter: Jie Huang
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3404) BouncyCastle upgrade to 1.61 might cause flaky test issues

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850299#comment-16850299
 ] 

Hudson commented on ZOOKEEPER-3404:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #543 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/543/])
ZOOKEEPER-3404: Downgrade BouncyCastle to 1.60 (nkalmar: rev 
78b3d1a8c1ea8453423682ad09675dfb1df04384)
* (edit) build.xml
* (edit) pom.xml


> BouncyCastle upgrade to 1.61 might cause flaky test issues
> --
>
> Key: ZOOKEEPER-3404
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3404
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 3.6.0
>Reporter: Andor Molnar
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0, 3.5.6
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> I've seen a lot of test timeout errors with QuorumSSL tests since I upgraded 
> master to BouncyCastle 1.61 due to a Java 9 warning. The warning has been 
> reported by [~eolivelli] which we tried to solve by the upgrade, but the 
> warning message is still present so I don't see any harm in downgrading to 
> the previous version. 
> The timeout errors are very frequent with recent Java versions (11+) and 
> quite rare with Java 8.
> I think it's worth a try to downgrade and see if tests will be in a better 
> shape.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [zookeeper] jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics

[GitBox]

jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics
URL: https://github.com/apache/zookeeper/pull/850#issuecomment-496750615
 
 
   retest maven build


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (ZOOKEEPER-3405) owasp flagging jackson-databind

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-3405:
--
Labels: pull-request-available  (was: )

> owasp flagging jackson-databind
> ---
>
> Key: ZOOKEEPER-3405
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3405
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.6.0, 3.5.5
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
>Priority: Critical
>  Labels: pull-request-available
> Fix For: 3.6.0, 3.5.6
>
>
> Owasp job is flagging jackson-databind for update:
> CVE-2019-12086CWE-200 Information ExposureMedium(5.0) 
> jackson-databind-2.9.8.jar



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [ANNOUNCE] New ZooKeeper committer: Norbert Kalmar

[Dinesh Appavoo]

Awesome. Congrats Norbert!

On Tue, May 28, 2019 at 10:51 AM Brian Nixon 
wrote:

> Congrats, Norbert! Well earned.
>
> On Mon, May 27, 2019 at 3:49 AM Andor Molnar 
> wrote:
>
> > Congratulations Norbert!
> >
> > Andor
> >
> >
> >
> > On Mon, May 27, 2019 at 11:52 AM Flavio Junqueira 
> wrote:
> >
> > > Congrats, Norbert!
> > >
> > > -Flavio
> > >
> > > > On 27 May 2019, at 11:01, Tamas Penzes 
> > > wrote:
> > > >
> > > > Congrats Norbert!
> > > >
> > > > On Sun, May 26, 2019 at 11:21 PM Patrick Hunt 
> > wrote:
> > > >
> > > >> The Apache ZooKeeper PMC recently extended committer karma to
> Norbert
> > > >> and he has accepted. Norbert has made some great contributions and
> we
> > > >> are looking forward to even more :)
> > > >>
> > > >> Congratulations and welcome aboard, Norbert!
> > > >>
> > >
> > >
> >
>

[GitHub] [zookeeper] phunt opened a new pull request #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE

[GitBox]

phunt opened a new pull request #962: ZOOKEEPER-3405: Upgrade the version of 
Jackson-databind to address OWASP CVE
URL: https://github.com/apache/zookeeper/pull/962
 
 
   Upgraded the library to the latest version.
   
   Change-Id: I94743e7f7817202fff25c757730ba05fe0a9cc17


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (ZOOKEEPER-3405) owasp flagging jackson-databind

[Patrick Hunt (JIRA)]

Patrick Hunt created ZOOKEEPER-3405:
---

 Summary: owasp flagging jackson-databind
 Key: ZOOKEEPER-3405
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3405
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.6.0, 3.5.6


Owasp job is flagging jackson-databind for update:

CVE-2019-12086  CWE-200 Information ExposureMedium(5.0) 
jackson-databind-2.9.8.jar



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-3405) owasp flagging jackson-databind

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-3405:

Affects Version/s: 3.6.0
   3.5.5

> owasp flagging jackson-databind
> ---
>
> Key: ZOOKEEPER-3405
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3405
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.6.0, 3.5.5
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
>Priority: Critical
> Fix For: 3.6.0, 3.5.6
>
>
> Owasp job is flagging jackson-databind for update:
> CVE-2019-12086CWE-200 Information ExposureMedium(5.0) 
> jackson-databind-2.9.8.jar



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [ANNOUNCE] New ZooKeeper committer: Enrico Olivelli

[Dinesh Appavoo]

Great news. Congrats Enrico!

On Tue, May 28, 2019 at 10:51 AM Brian Nixon 
wrote:

> Awesome! Congrats, Enrico!
>
> On Mon, May 27, 2019 at 3:56 AM Andor Molnar 
> wrote:
>
> > Congratulations Enrico.
> >
> > Andor
> >
> >
> >
> > On Mon, May 27, 2019 at 11:04 AM Tamas Penzes
>  > >
> > wrote:
> >
> > > Congrats Enrico!
> > >
> > > On Sun, May 26, 2019 at 11:19 PM Patrick Hunt 
> wrote:
> > >
> > > > The Apache ZooKeeper PMC recently extended committer karma to Enrico
> > > > and he has accepted. Enrico has made some great contributions and we
> > > > are looking forward to even more :)
> > > >
> > > > Congratulations and welcome aboard, Enrico!
> > > >
> > >
> >
>

[GitHub] [zookeeper] enixon commented on issue #960: Fix typos and grammar in zookeeper docs

[GitBox]

enixon commented on issue #960: Fix typos and grammar in zookeeper docs
URL: https://github.com/apache/zookeeper/pull/960#issuecomment-496686220
 
 
   retest ant build


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] enixon commented on issue #960: Fix typos and grammar in zookeeper docs

[GitBox]

enixon commented on issue #960: Fix typos and grammar in zookeeper docs
URL: https://github.com/apache/zookeeper/pull/960#issuecomment-496685882
 
 
   looks good to me


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] szepet edited a comment on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server

[GitBox]

szepet edited a comment on issue #923: ZOOKEEPER-1426: add version command to 
the zookeeper server
URL: https://github.com/apache/zookeeper/pull/923#issuecomment-496678387
 
 
   Yes, it the condition at the beginning was unnecessary since @nkalmar has 
done ZOOKEEPER-3029. In 05b774a the maven generated files are added to the 
zkEnv as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] szepet commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server

[GitBox]

szepet commented on issue #923: ZOOKEEPER-1426: add version command to the 
zookeeper server
URL: https://github.com/apache/zookeeper/pull/923#issuecomment-496678387
 
 
   Yes, it the condition at the beginning was unnecessary since @nkalmar has 
done ZOOKEEPER-3029. In #05b774 the maven generated files are added to the 
zkEnv as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Failed: ZOOKEEPER-2282 PreCommit Build #3782

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2282
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3782/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 8.80 KB...]
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:894)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1161)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1192)
at hudson.scm.SCM.checkout(SCM.java:504)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1810)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags 
--progress git://git.apache.org/zookeeper.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: fatal: remote error: access denied or repository not exported: 
/zookeeper.git

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2042)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1761)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$400(CliGitAPIImpl.java:72)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:442)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146)
at hudson.remoting.UserRequest.perform(UserRequest.java:212)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to 
H13
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)
at 
hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)
at hudson.remoting.Channel.call(Channel.java:955)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)
at sun.reflect.GeneratedMethodAccessor927.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)
at com.sun.proxy.$Proxy115.execute(Unknown Source)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:892)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1161)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1192)
at hudson.scm.SCM.checkout(SCM.java:504)
at 
hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at 
jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1810)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
ERROR: Error fetching remote repo 'origin'
Archiving artifacts
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
[description-setter] Could not determine description.
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
#

[jira] [Commented] (ZOOKEEPER-2282) chroot not stripped from path in asynchronous callbacks

[Peter da Silva (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850070#comment-16850070
 ] 

Peter da Silva commented on ZOOKEEPER-2282:
---

What version will this fix be available in? Applying the patch is not 
straightforward.

> chroot not stripped from path in asynchronous callbacks
> ---
>
> Key: ZOOKEEPER-2282
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2282
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.4.6, 3.5.0
> Environment: Centos 6.6
>Reporter: Andrew Grasso
>Assignee: Andrew Grasso
>Priority: Critical
> Attachments: ZOOKEEPER-2282.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Callbacks passed to [zoo_acreate], [zoo_async], and [zoo_amulti] (for create 
> ops) are called on paths that include the chroot. This is analagous to issue 
> 1027, which fixed this bug for synchronous calls.
> I've created a patch to fix this in trunk



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [zookeeper] jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics

[GitBox]

jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics
URL: https://github.com/apache/zookeeper/pull/850#issuecomment-496648615
 
 
   retest maven build


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics

[GitBox]

jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics
URL: https://github.com/apache/zookeeper/pull/850#issuecomment-496648163
 
 
   reset maven build


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [ANNOUNCE] New ZooKeeper committer: Enrico Olivelli

[Brian Nixon]

Awesome! Congrats, Enrico!

On Mon, May 27, 2019 at 3:56 AM Andor Molnar 
wrote:

> Congratulations Enrico.
>
> Andor
>
>
>
> On Mon, May 27, 2019 at 11:04 AM Tamas Penzes  >
> wrote:
>
> > Congrats Enrico!
> >
> > On Sun, May 26, 2019 at 11:19 PM Patrick Hunt  wrote:
> >
> > > The Apache ZooKeeper PMC recently extended committer karma to Enrico
> > > and he has accepted. Enrico has made some great contributions and we
> > > are looking forward to even more :)
> > >
> > > Congratulations and welcome aboard, Enrico!
> > >
> >
>

Re: [ANNOUNCE] New ZooKeeper committer: Norbert Kalmar

[Brian Nixon]

Congrats, Norbert! Well earned.

On Mon, May 27, 2019 at 3:49 AM Andor Molnar 
wrote:

> Congratulations Norbert!
>
> Andor
>
>
>
> On Mon, May 27, 2019 at 11:52 AM Flavio Junqueira  wrote:
>
> > Congrats, Norbert!
> >
> > -Flavio
> >
> > > On 27 May 2019, at 11:01, Tamas Penzes 
> > wrote:
> > >
> > > Congrats Norbert!
> > >
> > > On Sun, May 26, 2019 at 11:21 PM Patrick Hunt 
> wrote:
> > >
> > >> The Apache ZooKeeper PMC recently extended committer karma to Norbert
> > >> and he has accepted. Norbert has made some great contributions and we
> > >> are looking forward to even more :)
> > >>
> > >> Congratulations and welcome aboard, Norbert!
> > >>
> >
> >
>

[GitHub] [zookeeper] jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics

[GitBox]

jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics
URL: https://github.com/apache/zookeeper/pull/850#issuecomment-496606096
 
 
   > Did you see my last comments?
   
   Sorry! Was on vacation. Just made the changes. Thank you @eolivelli 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] jhuan31 commented on issue #858: ZOOKEEPER-3321: Add metrics for Leader

[GitBox]

jhuan31 commented on issue #858: ZOOKEEPER-3321: Add metrics for Leader
URL: https://github.com/apache/zookeeper/pull/858#issuecomment-496601707
 
 
   Thank you @eolivelli 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] eolivelli commented on issue #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted …

[GitBox]

eolivelli commented on issue #944: ZOOKEEPER-3388: Allow client port to support 
plaintext and encrypted …
URL: https://github.com/apache/zookeeper/pull/944#issuecomment-496587533
 
 
   I wasn't aware of OptionalSSLHandler.
   This is very interesting.
   
   What do you think @enixon?
   
   I want this feature because I have cases on which from a jvm I have to 
connect to different zk clusters but the customer cannot upgrade to ssl every 
cluster .
   So having a client that is able to connect to a secure and an unsecured 
cluster will be great.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (ZOOKEEPER-3404) BouncyCastle upgrade to 1.61 might cause flaky test issues

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849883#comment-16849883
 ] 

Hudson commented on ZOOKEEPER-3404:
---

SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #377 (See 
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/377/])
ZOOKEEPER-3404: Downgrade BouncyCastle to 1.60 (nkalmar: rev 
78b3d1a8c1ea8453423682ad09675dfb1df04384)
* (edit) pom.xml
* (edit) build.xml


> BouncyCastle upgrade to 1.61 might cause flaky test issues
> --
>
> Key: ZOOKEEPER-3404
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3404
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 3.6.0
>Reporter: Andor Molnar
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0, 3.5.6
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> I've seen a lot of test timeout errors with QuorumSSL tests since I upgraded 
> master to BouncyCastle 1.61 due to a Java 9 warning. The warning has been 
> reported by [~eolivelli] which we tried to solve by the upgrade, but the 
> warning message is still present so I don't see any harm in downgrading to 
> the previous version. 
> The timeout errors are very frequent with recent Java versions (11+) and 
> quite rare with Java 8.
> I think it's worth a try to downgrade and see if tests will be in a better 
> shape.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3401) Fix metric PROPOSAL_ACK_CREATION_LATENCY

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849882#comment-16849882
 ] 

Hudson commented on ZOOKEEPER-3401:
---

SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #377 (See 
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/377/])
ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY (nkalmar: rev 
bb94aa44de61bfb2ecd5bbd12b4eb390c2cf39c1)
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/AckRequestProcessor.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerMetricsTest.java


> Fix metric PROPOSAL_ACK_CREATION_LATENCY
> 
>
> Key: ZOOKEEPER-3401
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3401
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: metric system
>Reporter: Jie Huang
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ZOOKEEPER-3404) BouncyCastle upgrade to 1.61 might cause flaky test issues

[Norbert Kalmar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Norbert Kalmar resolved ZOOKEEPER-3404.
---
   Resolution: Fixed
Fix Version/s: 3.6.0
   3.5.6

Issue resolved by pull request 961
[https://github.com/apache/zookeeper/pull/961]

> BouncyCastle upgrade to 1.61 might cause flaky test issues
> --
>
> Key: ZOOKEEPER-3404
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3404
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 3.6.0
>Reporter: Andor Molnar
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.5.6, 3.6.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> I've seen a lot of test timeout errors with QuorumSSL tests since I upgraded 
> master to BouncyCastle 1.61 due to a Java 9 warning. The warning has been 
> reported by [~eolivelli] which we tried to solve by the upgrade, but the 
> warning message is still present so I don't see any harm in downgrading to 
> the previous version. 
> The timeout errors are very frequent with recent Java versions (11+) and 
> quite rare with Java 8.
> I think it's worth a try to downgrade and see if tests will be in a better 
> shape.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [zookeeper] nkalmar commented on issue #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60

[GitBox]

nkalmar commented on issue #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60
URL: https://github.com/apache/zookeeper/pull/961#issuecomment-496532806
 
 
   Thanks @anmolnar , merged to master and 3.5


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] asfgit closed pull request #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60

[GitBox]

asfgit closed pull request #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60
URL: https://github.com/apache/zookeeper/pull/961
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] nkalmar commented on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY

[GitBox]

nkalmar commented on issue #957: ZOOKEEPER-3401: Fix metric 
PROPOSAL_ACK_CREATION_LATENCY
URL: https://github.com/apache/zookeeper/pull/957#issuecomment-496527666
 
 
   Thanks @jhuan31 , merged to master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (ZOOKEEPER-3401) Fix metric PROPOSAL_ACK_CREATION_LATENCY

[Norbert Kalmar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Norbert Kalmar resolved ZOOKEEPER-3401.
---
Resolution: Fixed

Issue resolved by pull request 957
[https://github.com/apache/zookeeper/pull/957]

> Fix metric PROPOSAL_ACK_CREATION_LATENCY
> 
>
> Key: ZOOKEEPER-3401
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3401
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: metric system
>Reporter: Jie Huang
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [zookeeper] asfgit closed pull request #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY

[GitBox]

asfgit closed pull request #957: ZOOKEEPER-3401: Fix metric 
PROPOSAL_ACK_CREATION_LATENCY
URL: https://github.com/apache/zookeeper/pull/957
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] nkalmar commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider

[GitBox]

nkalmar commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for 
ZooKeeper - move remaining metrics to MetricsProvider
URL: https://github.com/apache/zookeeper/pull/918#issuecomment-496521330
 
 
   retest ant build


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] anmolnar commented on issue #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted …

[GitBox]

anmolnar commented on issue #944: ZOOKEEPER-3388: Allow client port to support 
plaintext and encrypted …
URL: https://github.com/apache/zookeeper/pull/944#issuecomment-496507605
 
 
   @enixon Quite an impressive new feature gets little attention.
   
   Let's clarify one thing. We already have this feature implemented for quorum 
communication with `UnifiedServerSocket`, but we don't want to use it here, 
because we have Netty for client communication and Netty already has a built-in 
feature, `OptionalSSLHandler` for exactly this purpose.
   
   Is that the reason why you upgraded to the latest version?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Comment Edited] (ZOOKEEPER-2584) when setquota for a znode and set ip/user ACL on /zookeeper/quota, still able to delete the quota from client with another ip though it says "Authentication is

[maoling (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849598#comment-16849598
 ] 

maoling edited comment on ZOOKEEPER-2584 at 5/28/19 11:03 AM:
--

I got it.

1. the scope of d(delete) of *crdwa* is only the child nodes(first level) under 
the path you input.

If one user do this: *setAcl /zookeeper/quota auth:user:pass:crdwa*

ohters cannot have the permission to operate the first level nodes under 
*/zookeeper/quota*, but still have the delete permission to delete the 
*/zookeeper/quota/test/zookeeper_limits* under */zookeeper/quota/test*

*ACL has no Inheritance relationship.*

2.To solve this issue, users can do this:

*setAcl /zookeeper/quota/test auth:user1:12345:crwad*

or

*setAcl -R /zookeeper/quota auth:user1:12345:crwad*  (availble in the master 
branch)


was (Author: maoling):
I got it.

1. the scope of d(delete) of *crdwa* is only the child nodes(first level) under 
the path you input.

If one user do this: *setAcl /zookeeper/quota auth:user:pass:crdwa*

ohters cannot have the permission to operate the nodes under 
*/zookeeper/quota*, but still have the delete permission to delete the 
*/zookeeper/quota/test/zookeeper_limits* under */zookeeper/quota/test*

*ACL has no Inheritance relationship.*

2.To solve this issue, users can do this:

*setAcl /zookeeper/quota/test auth:user1:12345:crwad*

or

*setAcl -R /zookeeper/quota auth:user1:12345:crwad*  (availble in the master 
branch)

> when setquota for a znode and set ip/user ACL on /zookeeper/quota, still able 
> to delete the quota from client with another ip though it says 
> "Authentication is not valid"
> --
>
> Key: ZOOKEEPER-2584
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2584
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.1
>Reporter: Rakesh Kumar Singh
>Assignee: Rakesh Kumar Singh
>Priority: Major
>
> when setquota for a znode and set ip/user ACL on /zookeeper/quota, still able 
> to delete the quota from client with another ip though it says 
> "Authentication is not valid"
> >> Set quota and ip ACL from one client (with IP 10.18.101.80)
> [zk: 10.18.101.80:2181(CONNECTED) 9] setquota -n 10 /test
> [zk: 10.18.101.80:2181(CONNECTED) 10] setAcl /zookeeper/quota 
> ip:10.18.101.80:crdwa
> [zk: 10.18.101.80:2181(CONNECTED) 11] 
> >> Try to delete the set quota using different client(with ip 10.18.219.50)
> [zk: 10.18.219.50:2181(CONNECTED) 22] listquota /test
> absolute path is /zookeeper/quota/test/zookeeper_limits
> Output quota for /test count=10,bytes=-1
> Output stat for /test count=1,bytes=5
> [zk: 10.18.219.50:2181(CONNECTED) 23] delquota /test
> Authentication is not valid : /zookeeper/quota/test
> [zk: 10.18.219.50:2181(CONNECTED) 24] listquota /test
> absolute path is /zookeeper/quota/test/zookeeper_limits
> quota for /test does not exist.
> >> Here quota has been deleted though it is saying "Authentication is not 
> >> valid.." which is not correct.
> Now try to set the quota from another ip itself, it fails which is as expected
> [zk: 10.18.219.50:2181(CONNECTED) 25] setquota -n 10 /test
> Authentication is not valid : /zookeeper/quota/test
> [zk: 10.18.219.50:2181(CONNECTED) 26] listquota /test
> absolute path is /zookeeper/quota/test/zookeeper_limits
> quota for /test does not exist.
> >> Sameway when we set user ACL...
> [zk: 10.18.101.80:2181(CONNECTED) 26] addauth digest user:pass
> [zk: 10.18.101.80:2181(CONNECTED) 27] create /test hello
> Node already exists: /test
> [zk: 10.18.101.80:2181(CONNECTED) 28] delete /test
> [zk: 10.18.101.80:2181(CONNECTED) 29] create /test hello
> Created /test
> [zk: 10.18.101.80:2181(CONNECTED) 30] 
> [zk: 10.18.101.80:2181(CONNECTED) 30] setquota -n 10 /test
> [zk: 10.18.101.80:2181(CONNECTED) 31] setAcl /zookeeper/quota 
> auth:user:pass:crdwa
> [zk: 10.18.101.80:2181(CONNECTED) 32] 
> [zk: 10.18.219.50:2181(CONNECTED) 27] listquota /test
> absolute path is /zookeeper/quota/test/zookeeper_limits
> Output quota for /test count=10,bytes=-1
> Output stat for /test count=1,bytes=5
> [zk: 10.18.219.50:2181(CONNECTED) 28] delquota /test
> Authentication is not valid : /zookeeper/quota/test
> [zk: 10.18.219.50:2181(CONNECTED) 29] listquota /test
> absolute path is /zookeeper/quota/test/zookeeper_limits
> quota for /test does not exist.
> [zk: 10.18.219.50:2181(CONNECTED) 30]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2584) when setquota for a znode and set ip/user ACL on /zookeeper/quota, still able to delete the quota from client with another ip though it says "Authentication is not

[maoling (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849598#comment-16849598
 ] 

maoling commented on ZOOKEEPER-2584:


I got it.

1. the scope of d(delete) of *crdwa* is only the child nodes(first level) under 
the path you input.

If one user do this: *setAcl /zookeeper/quota auth:user:pass:crdwa*

ohters cannot have the permission to operate the nodes under 
*/zookeeper/quota*, but still have the delete permission to delete the 
*/zookeeper/quota/test/zookeeper_limits* under */zookeeper/quota/test*

*ACL has no Inheritance relationship.*

2.To solve this issue, users can do this:

*setAcl /zookeeper/quota/test auth:user1:12345:crwad*

or

*setAcl -R /zookeeper/quota auth:user1:12345:crwad*  (availble in the master 
branch)

> when setquota for a znode and set ip/user ACL on /zookeeper/quota, still able 
> to delete the quota from client with another ip though it says 
> "Authentication is not valid"
> --
>
> Key: ZOOKEEPER-2584
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2584
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.1
>Reporter: Rakesh Kumar Singh
>Assignee: Rakesh Kumar Singh
>Priority: Major
>
> when setquota for a znode and set ip/user ACL on /zookeeper/quota, still able 
> to delete the quota from client with another ip though it says 
> "Authentication is not valid"
> >> Set quota and ip ACL from one client (with IP 10.18.101.80)
> [zk: 10.18.101.80:2181(CONNECTED) 9] setquota -n 10 /test
> [zk: 10.18.101.80:2181(CONNECTED) 10] setAcl /zookeeper/quota 
> ip:10.18.101.80:crdwa
> [zk: 10.18.101.80:2181(CONNECTED) 11] 
> >> Try to delete the set quota using different client(with ip 10.18.219.50)
> [zk: 10.18.219.50:2181(CONNECTED) 22] listquota /test
> absolute path is /zookeeper/quota/test/zookeeper_limits
> Output quota for /test count=10,bytes=-1
> Output stat for /test count=1,bytes=5
> [zk: 10.18.219.50:2181(CONNECTED) 23] delquota /test
> Authentication is not valid : /zookeeper/quota/test
> [zk: 10.18.219.50:2181(CONNECTED) 24] listquota /test
> absolute path is /zookeeper/quota/test/zookeeper_limits
> quota for /test does not exist.
> >> Here quota has been deleted though it is saying "Authentication is not 
> >> valid.." which is not correct.
> Now try to set the quota from another ip itself, it fails which is as expected
> [zk: 10.18.219.50:2181(CONNECTED) 25] setquota -n 10 /test
> Authentication is not valid : /zookeeper/quota/test
> [zk: 10.18.219.50:2181(CONNECTED) 26] listquota /test
> absolute path is /zookeeper/quota/test/zookeeper_limits
> quota for /test does not exist.
> >> Sameway when we set user ACL...
> [zk: 10.18.101.80:2181(CONNECTED) 26] addauth digest user:pass
> [zk: 10.18.101.80:2181(CONNECTED) 27] create /test hello
> Node already exists: /test
> [zk: 10.18.101.80:2181(CONNECTED) 28] delete /test
> [zk: 10.18.101.80:2181(CONNECTED) 29] create /test hello
> Created /test
> [zk: 10.18.101.80:2181(CONNECTED) 30] 
> [zk: 10.18.101.80:2181(CONNECTED) 30] setquota -n 10 /test
> [zk: 10.18.101.80:2181(CONNECTED) 31] setAcl /zookeeper/quota 
> auth:user:pass:crdwa
> [zk: 10.18.101.80:2181(CONNECTED) 32] 
> [zk: 10.18.219.50:2181(CONNECTED) 27] listquota /test
> absolute path is /zookeeper/quota/test/zookeeper_limits
> Output quota for /test count=10,bytes=-1
> Output stat for /test count=1,bytes=5
> [zk: 10.18.219.50:2181(CONNECTED) 28] delquota /test
> Authentication is not valid : /zookeeper/quota/test
> [zk: 10.18.219.50:2181(CONNECTED) 29] listquota /test
> absolute path is /zookeeper/quota/test/zookeeper_limits
> quota for /test does not exist.
> [zk: 10.18.219.50:2181(CONNECTED) 30]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2564) No message is prompted when trying to delete quota with different quota option

[maoling (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849562#comment-16849562
 ] 

maoling commented on ZOOKEEPER-2564:


very trival.

No message is prompted is also ok for me.

> No message is prompted when trying to delete quota with different quota option
> --
>
> Key: ZOOKEEPER-2564
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2564
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.1
>Reporter: Rakesh Kumar Singh
>Assignee: Rakesh Kumar Singh
>Priority: Minor
>
> No message is prompted when trying to delete quota with different quota 
> option.
> Steps to reproduce:-
> 1. Start zookeeper in cluster mode 
> 2. Create some node and set quota like
> setquota -n 10 /test
> 3. Now try to delete as below:-
> delquota -b /test
> Here no message/exception is prompted. We should prompt message like 
> "Byte Quota does not exist for /test"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Build failed in Jenkins: ZooKeeper-trunk-owasp #377

[Apache Jenkins Server]

See 


Changes:

[andor] ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

--
[...truncated 22.76 KB...]

compile:
[javac] Compiling 316 source files to 

[javac] warning: [options] bootstrap class path not set in conjunction with 
-source 8
[javac] 
:26:
 warning: [serial] serializable class ClientCnxnLimitException has no 
definition of serialVersionUID
[javac] public class ClientCnxnLimitException extends Exception {
[javac]^
[javac] 
:44:
 warning: [dep-ann] deprecated item is not annotated with @Deprecated
[javac] public class LogFormatter {
[javac]^
[javac] 
:247:
 warning: [cast] redundant cast to ByteBuffer
[javac] b = (ByteBuffer) b.slice().limit(
[javac] ^
[javac] 
:78:
 warning: [cast] redundant cast to ByteBuffer
[javac] fileChannel.write((ByteBuffer) fill.position(0), 
newFileSize - fill.remaining());
[javac]   ^
[javac] 5 warnings

compile-test:
[mkdir] Created dir: 

[javac] Compiling 289 source files to 

[javac] warning: [options] bootstrap class path not set in conjunction with 
-source 8
[javac] 1 warning
[javac] Compiling 11 source files to 

[javac] warning: [options] bootstrap class path not set in conjunction with 
-source 8
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] 1 warning
[javac] Compiling 2 source files to 

[javac] warning: [options] bootstrap class path not set in conjunction with 
-source 8
[javac] Note: 

 uses or overrides a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] 1 warning

init:

ivy-download:

ivy-taskdef:

ivy-init:

ivy-retrieve-owasp:
[ivy:retrieve] :: loading settings :: file = 

[ivy:retrieve] :: resolving dependencies :: 
org.apache.zookeeper#zookeeper;3.6.0-SNAPSHOT
[ivy:retrieve]  confs: [owasp]
[ivy:retrieve]  found org.owasp#dependency-check-ant;4.0.2 in maven2
[ivy:retrieve]  found org.owasp#dependency-check-core;4.0.2 in maven2
[ivy:retrieve]  found com.vdurmont#semver4j;2.2.0 in maven2
[ivy:retrieve]  found joda-time#joda-time;1.6 in maven2
[ivy:retrieve]  found org.slf4j#slf4j-api;1.7.25 in maven2
[ivy:retrieve]  found org.owasp#dependency-check-utils;4.0.2 in maven2
[ivy:retrieve]  found commons-io#commons-io;2.6 in maven2
[ivy:retrieve]  found org.apache.commons#commons-lang3;3.4 in maven2
[ivy:retrieve]  found com.google.code.gson#gson;2.8.5 in maven2
[ivy:retrieve]  found commons-collections#commons-collections;3.2.2 in maven2
[ivy:retrieve]  found org.apache.commons#commons-compress;1.18 in maven2
[ivy:retrieve]  found org.apache.commons#commons-text;1.3 in maven2
[ivy:retrieve]  found org.apache.lucene#lucene-core;7.6.0 in maven2
[ivy:retrieve]  found org.apache.lucene#lucene-analyzers-common;7.6.0 in maven2
[ivy:retrieve]  found org.apache.lucene#lucene-queryparser;7.6.0 in maven2
[ivy:retrieve]  found org.apache.lucene#lucene-queries;7.6.0 in maven2
[ivy:retrieve]  found org.apache.lucene#lucene-sandbox;7.6.0 in maven2
[ivy:retrieve]  found org.apache.velocity#velocity;1.7 in maven2
[ivy:retrieve]  found commons-lang#commons-lang;2.4 in maven2
[ivy:retrieve]  found org.glassfish#javax.json;1.0.4 in maven2
[ivy:retrieve]  found org.jsoup#jsoup;1.11.3 in maven2
[ivy:retrieve]  found com.sun.mail#mailapi;1.6.3 in maven2
[ivy:retrieve]  found com.google.guava#guava;27.0.1-jre in maven2
[ivy:retrieve]  found com.google.guava#failureaccess;1.0.1 in maven2
[ivy:retrieve]  found 
com.google.guava#listenablefuture;.0-empty-to-avoid-conflict-with-guava in 
maven2
[ivy:

[jira] [Issue Comment Deleted] (ZOOKEEPER-2564) No message is prompted when trying to delete quota with different quota option

[maoling (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-2564:
---
Comment: was deleted

(was: [~rakeshsingh]，[~chenyuyun-emc]， [~hanm]

For my test, It seems that we cannot both setquota for count(-n) and size(-b) 
for one specified nodePath.
when want to delete quota,*delquota /path*
Is it a design flaw?)

> No message is prompted when trying to delete quota with different quota option
> --
>
> Key: ZOOKEEPER-2564
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2564
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.1
>Reporter: Rakesh Kumar Singh
>Assignee: Rakesh Kumar Singh
>Priority: Minor
>
> No message is prompted when trying to delete quota with different quota 
> option.
> Steps to reproduce:-
> 1. Start zookeeper in cluster mode 
> 2. Create some node and set quota like
> setquota -n 10 /test
> 3. Now try to delete as below:-
> delquota -b /test
> Here no message/exception is prompted. We should prompt message like 
> "Byte Quota does not exist for /test"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)