[jira] [Commented] (ZOOKEEPER-1745) Wrong Import-Package in the META-INF/MANIFEST.MF of zookeeper 3.4.5 bundle

2013-10-28 Thread Arnoud Glimmerveen (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13807264#comment-13807264
 ] 

Arnoud Glimmerveen commented on ZOOKEEPER-1745:
---

Are you still experiencing these OSGi issues with trunk/3.4 branch [~xldai]? I 
think the issue described was already addressed by ZOOKEEPER-1334

 Wrong Import-Package in the META-INF/MANIFEST.MF of zookeeper 3.4.5 bundle
 --

 Key: ZOOKEEPER-1745
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1745
 Project: ZooKeeper
  Issue Type: Bug
  Components: server
Affects Versions: 3.4.5
 Environment: Java 7
Reporter: Xilai Dai
Assignee: Jean-Baptiste Onofré
 Fix For: 3.4.6, 3.5.0


 Import-Package: javax.management,org.apache.log4j,org.osgi.framework;v
  ersion=[1.4,2.0),org.osgi.util.tracker;version=[1.1,2.0)
 the org.apache.log4j should be replaced by org.slf4j, because from the 
 source codes, zookeeper server classes import org.slf4j.* for logging.
 currently will get: 
 Caused by: java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory
   at 
 org.apache.zookeeper.server.quorum.QuorumPeerConfig.clinit(QuorumPeerConfig.java:46)
 when try to create instance for some of its classes in OSGi container (e.g. 
 apache karaf)



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1627) Add org.apache.zookeeper.common to exported packages in OSGi MANIFEST headers

2013-10-09 Thread Arnoud Glimmerveen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arnoud Glimmerveen updated ZOOKEEPER-1627:
--

Attachment: ZOOKEEPER-1627-trunk.patch

I re-created the patch based on the current trunk. 

This patch adds the {{org.apache.zookeeper.common}} package to Export-Package 
OSGi manifest header (both the source jar and the bin-jar), making it visible 
to other bundles in an OSGi environment.

This patch can also be applied to the 3.4 branch.

 Add org.apache.zookeeper.common to exported packages in OSGi MANIFEST headers
 -

 Key: ZOOKEEPER-1627
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1627
 Project: ZooKeeper
  Issue Type: Improvement
Affects Versions: 3.4.5
 Environment: Java: 1.6.0_31
 OSGi environment: Karaf 2.3.0
Reporter: Arnoud Glimmerveen
Assignee: Arnoud Glimmerveen
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1627.patch, ZOOKEEPER-1627-trunk.patch


 The utilities contained in the org.apache.zookeeper.common package are not 
 part of the exported packages in an OSGi environment, thus making them not 
 available to other bundles using ZooKeeper.
 Propose to add the org.apache.zookeeper.common package to the Export-Package 
 MANIFEST header.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Created] (ZOOKEEPER-1647) OSGi package import/export changes not applied to bin-jar

2013-02-17 Thread Arnoud Glimmerveen (JIRA) 
Arnoud Glimmerveen created ZOOKEEPER-1647:
-

 Summary: OSGi package import/export changes not applied to bin-jar
 Key: ZOOKEEPER-1647
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1647
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.5.0, 3.4.6
Reporter: Arnoud Glimmerveen


Two recent changes related to the OSGi headers Import-Package and 
Export-Package (ZOOKEEPER-1334 and ZOOKEEPER-1645) were only applied to the JAR 
created in ant target *jar*, leaving the JAR created in target *bin-jar* (to be 
uploaded to Maven central) with the old (incorrect) OSGi headers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ZOOKEEPER-1647) OSGi package import/export changes not applied to bin-jar

2013-02-17 Thread Arnoud Glimmerveen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arnoud Glimmerveen updated ZOOKEEPER-1647:
--

Attachment: ZOOKEEPER-1647.patch

This patch sets the same OSGi Import-Package and Export-Package MANIFEST 
headers on the jar created in the ant target *bin-jar*.

 OSGi package import/export changes not applied to bin-jar
 -

 Key: ZOOKEEPER-1647
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1647
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.5.0, 3.4.6
Reporter: Arnoud Glimmerveen
 Attachments: ZOOKEEPER-1647.patch


 Two recent changes related to the OSGi headers Import-Package and 
 Export-Package (ZOOKEEPER-1334 and ZOOKEEPER-1645) were only applied to the 
 JAR created in ant target *jar*, leaving the JAR created in target *bin-jar* 
 (to be uploaded to Maven central) with the old (incorrect) OSGi headers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1645) ZooKeeper OSGi package imports not complete

2013-02-16 Thread Arnoud Glimmerveen (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13579810#comment-13579810
 ] 

Arnoud Glimmerveen commented on ZOOKEEPER-1645:
---

Great that the patch is applied, but while reviewing the changes myself I 
realized something: the build.xml creates two jar files. The attached patch 
only fixed the headers for the jar created in the *jar* target and not the one 
in *bin-jar*. Not sure if I understand the build.xml correctly, but it appears 
the latter is to be uploaded to maven. In any case, the headers should be 
consistent in both jar files.
I think the patch provided for ZOOKEEPER-1334 may have the same issue!

Should I create a new issue for this?

 ZooKeeper OSGi package imports not complete
 ---

 Key: ZOOKEEPER-1645
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1645
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.5.0, 3.4.6
Reporter: Arnoud Glimmerveen
Assignee: Arnoud Glimmerveen
 Fix For: 3.5.0, 3.4.6

 Attachments: ZOOKEEPER-1645.patch


 The ZooKeeper bundle relies on three packages it currently does not declare 
 in the Import-Package MANIFEST header: {{javax.security.auth.callback}} , 
 {{javax.security.auth.login}} and {{javax.security.sasl}} . By adding these 
 the ZooKeeper jar will be a valid OSGi bundle.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1334) Zookeeper 3.4.x is not OSGi compliant - MANIFEST.MF is flawed

2013-02-11 Thread Arnoud Glimmerveen (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576413#comment-13576413
 ] 

Arnoud Glimmerveen commented on ZOOKEEPER-1334:
---

I've tested this patch on a locally build zookeeper (3.4.5 + patch from 
ZOOKEEPER-1334) using Karaf 2.2.8 and 2.3.0 (both Equinox and Felix) with a 
simple test bundle that creates a ZooKeeper connection upon the bundle being 
started. 
In my tests this patch only works for the combination Karaf 2.2.8 + Equinox. In 
the other scenario's I ran into some NoClassDefFoundErrors on classes located 
in the packages {{javax.security.auth.callback}} , 
{{javax.security.auth.login}} and {{javax.security.sasl}} . I resolved this by 
adding these packages to the Import-Package section of the ZooKeeper bundle.

@Claus: should these packages be added to the Import-Package section of the 
MANIFEST of the ZooKeeper bundle or are users expected to expose these packages 
to ZooKeeper bundle through OSGi framework configuration?

 Zookeeper 3.4.x is not OSGi compliant - MANIFEST.MF is flawed
 -

 Key: ZOOKEEPER-1334
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1334
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.4.0
Reporter: Claus Ibsen
Assignee: Claus Ibsen
 Fix For: 3.5.0, 3.4.6

 Attachments: zookeeper-1334-osgi.patch, zookeeper-1334-osgi.patch, 
 ZOOKEEPER-1334.patch


 In Zookeeper 3.3.x you use log4j for logging, and the maven dep is
 eg from 3.3.4
 {code}
 dependency
   groupIdlog4j/groupId
   artifactIdlog4j/artifactId
   version1.2.15/version
   scopecompile/scope
 /dependency
 {code}
 Now in 3.4.0 or better you changed to use slf4j also/instead. The maven 
 pom.xml now includes:
 {code}
   dependency
   groupIdorg.slf4j/groupId
   artifactIdslf4j-api/artifactId
   version1.6.1/version
   scopecompile/scope
 /dependency
 dependency
   groupIdorg.slf4j/groupId
   artifactIdslf4j-log4j12/artifactId
   version1.6.1/version
   scopecompile/scope
 /dependency
 dependency
   groupIdlog4j/groupId
   artifactIdlog4j/artifactId
   version1.2.15/version
   scopecompile/scope
 /dependency
 {code}
 But the META-INF/MANIFEST.MF file in the distribution did not change to 
 reflect this.
 The 3.3.4 MANIFEST.MF, import packages
 {code}
 Import-Package: javax.management,org.apache.log4j,org.osgi.framework;v
  ersion=[1.4,2.0),org.osgi.util.tracker;version=[1.1,2.0)
 {code}
 And the 3.4.1 MANIFEST.MF, import packages:
 {code}
 Import-Package: javax.management,org.apache.log4j,org.osgi.framework;v
  ersion=[1.4,2.0),org.osgi.util.tracker;version=[1.1,2.0)
 {code}
 This makes using zookeeper 3.4.x in OSGi environments not possible, as we get 
 NoClassDefFoundException for slf4j classes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (ZOOKEEPER-1645) ZooKeeper OSGi package imports not complete

2013-02-11 Thread Arnoud Glimmerveen (JIRA) 
Arnoud Glimmerveen created ZOOKEEPER-1645:
-

 Summary: ZooKeeper OSGi package imports not complete
 Key: ZOOKEEPER-1645
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1645
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.5.0, 3.4.6
Reporter: Arnoud Glimmerveen


The ZooKeeper bundle relies on three packages it currently does not declare in 
the Import-Package MANIFEST header: {{javax.security.auth.callback}} , 
{{javax.security.auth.login}} and {{javax.security.sasl}} . By adding these the 
ZooKeeper jar will be a valid OSGi bundle.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1334) Zookeeper 3.4.x is not OSGi compliant - MANIFEST.MF is flawed

2013-02-11 Thread Arnoud Glimmerveen (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576443#comment-13576443
 ] 

Arnoud Glimmerveen commented on ZOOKEEPER-1334:
---

Okay, I've created a new issue for this: ZOOKEEPER-1645

 Zookeeper 3.4.x is not OSGi compliant - MANIFEST.MF is flawed
 -

 Key: ZOOKEEPER-1334
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1334
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.4.0
Reporter: Claus Ibsen
Assignee: Claus Ibsen
 Fix For: 3.5.0, 3.4.6

 Attachments: zookeeper-1334-osgi.patch, zookeeper-1334-osgi.patch, 
 ZOOKEEPER-1334.patch


 In Zookeeper 3.3.x you use log4j for logging, and the maven dep is
 eg from 3.3.4
 {code}
 dependency
   groupIdlog4j/groupId
   artifactIdlog4j/artifactId
   version1.2.15/version
   scopecompile/scope
 /dependency
 {code}
 Now in 3.4.0 or better you changed to use slf4j also/instead. The maven 
 pom.xml now includes:
 {code}
   dependency
   groupIdorg.slf4j/groupId
   artifactIdslf4j-api/artifactId
   version1.6.1/version
   scopecompile/scope
 /dependency
 dependency
   groupIdorg.slf4j/groupId
   artifactIdslf4j-log4j12/artifactId
   version1.6.1/version
   scopecompile/scope
 /dependency
 dependency
   groupIdlog4j/groupId
   artifactIdlog4j/artifactId
   version1.2.15/version
   scopecompile/scope
 /dependency
 {code}
 But the META-INF/MANIFEST.MF file in the distribution did not change to 
 reflect this.
 The 3.3.4 MANIFEST.MF, import packages
 {code}
 Import-Package: javax.management,org.apache.log4j,org.osgi.framework;v
  ersion=[1.4,2.0),org.osgi.util.tracker;version=[1.1,2.0)
 {code}
 And the 3.4.1 MANIFEST.MF, import packages:
 {code}
 Import-Package: javax.management,org.apache.log4j,org.osgi.framework;v
  ersion=[1.4,2.0),org.osgi.util.tracker;version=[1.1,2.0)
 {code}
 This makes using zookeeper 3.4.x in OSGi environments not possible, as we get 
 NoClassDefFoundException for slf4j classes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ZOOKEEPER-1627) Add org.apache.zookeeper.common to exported packages in OSGi MANIFEST headers

2013-01-24 Thread Arnoud Glimmerveen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arnoud Glimmerveen updated ZOOKEEPER-1627:
--

Issue Type: Improvement  (was: Bug)

 Add org.apache.zookeeper.common to exported packages in OSGi MANIFEST headers
 -

 Key: ZOOKEEPER-1627
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1627
 Project: ZooKeeper
  Issue Type: Improvement
Affects Versions: 3.4.5
 Environment: Java: 1.6.0_31
 OSGi environment: Karaf 2.3.0
Reporter: Arnoud Glimmerveen
 Attachments: ZOOKEEPER-1627.patch


 The utilities contained in the org.apache.zookeeper.common package are not 
 part of the exported packages in an OSGi environment, thus making them not 
 available to other bundles using ZooKeeper.
 Propose to add the org.apache.zookeeper.common package to the Export-Package 
 MANIFEST header.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (ZOOKEEPER-1627) Add org.apache.zookeeper.common to exported packages in OSGi MANIFEST headers

2013-01-23 Thread Arnoud Glimmerveen (JIRA) 
Arnoud Glimmerveen created ZOOKEEPER-1627:
-

 Summary: Add org.apache.zookeeper.common to exported packages in 
OSGi MANIFEST headers
 Key: ZOOKEEPER-1627
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1627
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.4.5
 Environment: Java: 1.6.0_31
OSGi environment: Karaf 2.3.0
Reporter: Arnoud Glimmerveen


The utilities contained in the org.apache.zookeeper.common package are not part 
of the exported packages in an OSGi environment, thus making them not available 
to other bundles using ZooKeeper.
Propose to add the org.apache.zookeeper.common package to the Export-Package 
MANIFEST header.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ZOOKEEPER-1627) Add org.apache.zookeeper.common to exported packages in OSGi MANIFEST headers

2013-01-23 Thread Arnoud Glimmerveen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arnoud Glimmerveen updated ZOOKEEPER-1627:
--

Attachment: ZOOKEEPER-1627.patch

Adds org.apache.zookeeper.common package to Export-Package MANIFEST header.

 Add org.apache.zookeeper.common to exported packages in OSGi MANIFEST headers
 -

 Key: ZOOKEEPER-1627
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1627
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.4.5
 Environment: Java: 1.6.0_31
 OSGi environment: Karaf 2.3.0
Reporter: Arnoud Glimmerveen
 Attachments: ZOOKEEPER-1627.patch


 The utilities contained in the org.apache.zookeeper.common package are not 
 part of the exported packages in an OSGi environment, thus making them not 
 available to other bundles using ZooKeeper.
 Propose to add the org.apache.zookeeper.common package to the Export-Package 
 MANIFEST header.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira