[jira] [Commented] (ZOOKEEPER-1440) Spurious log error messages when QuorumCnxManager is shutting down
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13276010#comment-13276010 ] Jordan Zimmerman commented on ZOOKEEPER-1440: - I see it - I'll work on a new patch Spurious log error messages when QuorumCnxManager is shutting down -- Key: ZOOKEEPER-1440 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1440 Project: ZooKeeper Issue Type: Bug Components: quorum, server Affects Versions: 3.4.3 Reporter: Jordan Zimmerman Assignee: Jordan Zimmerman Priority: Minor Fix For: 3.5.0 Attachments: patch.txt When shutting down the QuroumPeer, ZK server logs unnecessary errors. See QuorumCnxManager.Listener.run() - ss.accept() will throw an exception when it is closed. The catch (IOException e) will log errors. It should first check the shutdown field to see if the Listener is being shutdown. If it is, the exception is correct and no errors should be logged. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1440) Spurious log error messages when QuorumCnxManager is shutting down
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman updated ZOOKEEPER-1440: Attachment: patch.txt Previous patch introduced socket leaks. This patch should be better. Spurious log error messages when QuorumCnxManager is shutting down -- Key: ZOOKEEPER-1440 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1440 Project: ZooKeeper Issue Type: Bug Components: quorum, server Affects Versions: 3.4.3 Reporter: Jordan Zimmerman Assignee: Jordan Zimmerman Priority: Minor Fix For: 3.5.0 Attachments: patch.txt, patch.txt When shutting down the QuroumPeer, ZK server logs unnecessary errors. See QuorumCnxManager.Listener.run() - ss.accept() will throw an exception when it is closed. The catch (IOException e) will log errors. It should first check the shutdown field to see if the Listener is being shutdown. If it is, the exception is correct and no errors should be logged. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
