[jira] [Updated] (ZOOKEEPER-2180) quota do not take effect in version 3.4.6

2016-08-02 Thread Surendra Singh Lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Surendra Singh Lilhore updated ZOOKEEPER-2180:
--
Assignee: (was: Surendra Singh Lilhore)

> quota do not take effect in version 3.4.6
> -
>
> Key: ZOOKEEPER-2180
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2180
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: zookeeper version 3.4.6
>Reporter: seekerak
>
> [zk: localhost:2181(CONNECTED) 18] listquota /mynode
> absolute path is /zookeeper/quota/mynode/zookeeper_limits
> Output quota for /mynode count=-1,bytes=100
> Output stat for /mynode count=6,bytes=484
> [zk: localhost:2181(CONNECTED) 19] listquota /mynode_n
> absolute path is /zookeeper/quota/mynode_n/zookeeper_limits
> Output quota for /mynode_n count=2,bytes=-1
> Output stat for /mynode_n count=5,bytes=5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2154) NPE in KeeperException

2016-08-02 Thread Surendra Singh Lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Surendra Singh Lilhore updated ZOOKEEPER-2154:
--
Assignee: (was: Surendra Singh Lilhore)

> NPE in KeeperException
> --
>
> Key: ZOOKEEPER-2154
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2154
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6
>Reporter: Surendra Singh Lilhore
> Fix For: 3.4.9, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2154.patch
>
>
> KeeperException should handle exception is code is null...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2375) The synchronize method of createSaslClient in ZooKeeperSaslClient can't be synchronize

2016-02-28 Thread Surendra Singh Lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171318#comment-15171318
 ] 

Surendra Singh Lilhore commented on ZOOKEEPER-2375:
---

Thanks [~yuemeng] for the patch, its good catch.

[~rakeshr] and [~arshad.mohammad], can you review ..

> The synchronize method of createSaslClient in ZooKeeperSaslClient can't be 
> synchronize
> --
>
> Key: ZOOKEEPER-2375
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2375
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6, 3.4.8, 3.5.0, 3.5.1
>Reporter: yuemeng
>Priority: Blocker
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2375.patch, ZOOKEEPER-2375_01.patch
>
>
> If there are exist many ZooKeeperSaslClient instance in one process,each 
> ZooKeeperSaslClient instance will be call synchronize method( 
> createSaslClient),But each ZooKeeperSaslClient instance will be lock the 
> current object(that is say ,the synchronize only for lock it's own object) 
> ,but many instances can access the static variable login,the synchronize 
> can't prevent other threads access the static login object,it will be cause 
> more than one ZooKeeperSaslClient  instances use the same login object,and 
> login.startThreadIfNeeded() will be called more than one times for same login 
> object。
> it wll cause problem:
>  ERROR | [Executor task launch worker-1-SendThread(fi1:24002)] | Exception 
> while trying to create SASL client: java.lang.IllegalThreadStateException | 
> org.apache.zookeeper.client.ZooKeeperSaslClient.createSaslClient(ZooKeeperSaslClient.java:305)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property

2015-11-09 Thread Surendra Singh Lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996989#comment-14996989
 ] 

Surendra Singh Lilhore commented on ZOOKEEPER-2139:
---

[~arshad.mohammad] offline discussed with me few days back. I will confirm with 
him and assign accordingly.

> Zookeeper client configuration should not be java system property
> -
>
> Key: ZOOKEEPER-2139
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client
>Affects Versions: 3.5.0
>Reporter: Surendra Singh Lilhore
>Assignee: Surendra Singh Lilhore
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, 
> ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch
>
>
> I have two ZK client in one JVM, one is secure client and second is normal 
> client (For non secure cluster).
> "zookeeper.sasl.client" system property is "true" by default, because of this 
> my second client connection is failing.
> We should pass all client configurations in client constructor like HDFS 
> client.
> For example :
> {code}
> public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, 
> Configuration conf) throws IOException
>   {
>   ..
>   ..
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property

2015-11-09 Thread Surendra Singh Lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997047#comment-14997047
 ] 

Surendra Singh Lilhore commented on ZOOKEEPER-2139:
---

Thanks [~ghelmling]. Appreciate your interests. It would be good if we can test 
this and will try to push this in. I tested in my env and please let me know 
your feedback as well.

> Zookeeper client configuration should not be java system property
> -
>
> Key: ZOOKEEPER-2139
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client
>Affects Versions: 3.5.0
>Reporter: Surendra Singh Lilhore
>Assignee: Surendra Singh Lilhore
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, 
> ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch
>
>
> I have two ZK client in one JVM, one is secure client and second is normal 
> client (For non secure cluster).
> "zookeeper.sasl.client" system property is "true" by default, because of this 
> my second client connection is failing.
> We should pass all client configurations in client constructor like HDFS 
> client.
> For example :
> {code}
> public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, 
> Configuration conf) throws IOException
>   {
>   ..
>   ..
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property

2015-06-30 Thread Surendra Singh Lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608105#comment-14608105
 ] 

Surendra Singh Lilhore commented on ZOOKEEPER-2139:
---

[~rakeshr] and [~rgs]

I have attached new updated patch, Please review

 Zookeeper client configuration should not be java system property
 -

 Key: ZOOKEEPER-2139
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
 Project: ZooKeeper
  Issue Type: Improvement
  Components: java client
Affects Versions: 3.5.0
Reporter: Surendra Singh Lilhore
Assignee: Surendra Singh Lilhore
 Fix For: 3.5.2, 3.6.0

 Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, 
 ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch


 I have two ZK client in one JVM, one is secure client and second is normal 
 client (For non secure cluster).
 zookeeper.sasl.client system property is true by default, because of this 
 my second client connection is failing.
 We should pass all client configurations in client constructor like HDFS 
 client.
 For example :
 {code}
 public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, 
 Configuration conf) throws IOException
   {
   ..
   ..
   }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2221) Zookeeper JettyAdminServer server should start on configured IP.

2015-06-30 Thread Surendra Singh Lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Surendra Singh Lilhore updated ZOOKEEPER-2221:
--
Attachment: ZOOKEEPER-2221.patch

Thanks [~cnauroth] for reviewing.

Attached new patch , Please review.. 

 Zookeeper JettyAdminServer server should start on configured IP.
 

 Key: ZOOKEEPER-2221
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2221
 Project: ZooKeeper
  Issue Type: Bug
  Components: quorum
Affects Versions: 3.5.0
Reporter: Surendra Singh Lilhore
Assignee: Surendra Singh Lilhore
 Attachments: ZOOKEEPER-2221.patch, ZOOKEEPER-2221.patch, 
 ZOOKEEPER-2221.patch, ZOOKEEPER-2221.patch, ZOOKEEPER-2221_1.patch


 Currently JettyAdminServer starting on 0.0.0.0 IP. 0.0.0.0 means all IP 
 addresses on the local machine. So, if your webserver machine has two ip 
 addresses, 192.168.1.1(private) and 10.1.2.1(public), and you allow a 
 webserver daemon like apache to listen on 0.0.0.0, it will be reachable at 
 both of those IPs.
 This is security issue. webserver should be accessible from only configured IP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property

2015-06-30 Thread Surendra Singh Lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Surendra Singh Lilhore updated ZOOKEEPER-2139:
--
Attachment: ZOOKEEPER-2139.patch

 Zookeeper client configuration should not be java system property
 -

 Key: ZOOKEEPER-2139
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
 Project: ZooKeeper
  Issue Type: Improvement
  Components: java client
Affects Versions: 3.5.0
Reporter: Surendra Singh Lilhore
Assignee: Surendra Singh Lilhore
 Fix For: 3.5.2, 3.6.0

 Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139.patch, 
 ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch


 I have two ZK client in one JVM, one is secure client and second is normal 
 client (For non secure cluster).
 zookeeper.sasl.client system property is true by default, because of this 
 my second client connection is failing.
 We should pass all client configurations in client constructor like HDFS 
 client.
 For example :
 {code}
 public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, 
 Configuration conf) throws IOException
   {
   ..
   ..
   }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2221) Zookeeper JettyAdminServer server should start on configured IP.

2015-06-29 Thread Surendra Singh Lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Surendra Singh Lilhore updated ZOOKEEPER-2221:
--
Attachment: ZOOKEEPER-2221.patch

Thanks [~rakeshr].. I attached new patch , Please review 

 Zookeeper JettyAdminServer server should start on configured IP.
 

 Key: ZOOKEEPER-2221
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2221
 Project: ZooKeeper
  Issue Type: Bug
  Components: quorum
Affects Versions: 3.5.0
Reporter: Surendra Singh Lilhore
Assignee: Surendra Singh Lilhore
 Attachments: ZOOKEEPER-2221.patch, ZOOKEEPER-2221.patch, 
 ZOOKEEPER-2221_1.patch


 Currently JettyAdminServer starting on 0.0.0.0 IP. 0.0.0.0 means all IP 
 addresses on the local machine. So, if your webserver machine has two ip 
 addresses, 192.168.1.1(private) and 10.1.2.1(public), and you allow a 
 webserver daemon like apache to listen on 0.0.0.0, it will be reachable at 
 both of those IPs.
 This is security issue. webserver should be accessible from only configured IP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2221) Zookeeper JettyAdminServer server should start on configured IP.

2015-06-29 Thread Surendra Singh Lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Surendra Singh Lilhore updated ZOOKEEPER-2221:
--
Attachment: ZOOKEEPER-2221.patch

 Zookeeper JettyAdminServer server should start on configured IP.
 

 Key: ZOOKEEPER-2221
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2221
 Project: ZooKeeper
  Issue Type: Bug
  Components: quorum
Affects Versions: 3.5.0
Reporter: Surendra Singh Lilhore
Assignee: Surendra Singh Lilhore
 Attachments: ZOOKEEPER-2221.patch, ZOOKEEPER-2221.patch, 
 ZOOKEEPER-2221.patch, ZOOKEEPER-2221_1.patch


 Currently JettyAdminServer starting on 0.0.0.0 IP. 0.0.0.0 means all IP 
 addresses on the local machine. So, if your webserver machine has two ip 
 addresses, 192.168.1.1(private) and 10.1.2.1(public), and you allow a 
 webserver daemon like apache to listen on 0.0.0.0, it will be reachable at 
 both of those IPs.
 This is security issue. webserver should be accessible from only configured IP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2221) Zookeeper JettyAdminServer server should start on configured IP.

2015-06-29 Thread Surendra Singh Lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14607539#comment-14607539
 ] 

Surendra Singh Lilhore commented on ZOOKEEPER-2221:
---

Thanks [~rakeshr] and [~cnauroth] for comments.

Attached new patch, Please review...

 Zookeeper JettyAdminServer server should start on configured IP.
 

 Key: ZOOKEEPER-2221
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2221
 Project: ZooKeeper
  Issue Type: Bug
  Components: quorum
Affects Versions: 3.5.0
Reporter: Surendra Singh Lilhore
Assignee: Surendra Singh Lilhore
 Attachments: ZOOKEEPER-2221.patch, ZOOKEEPER-2221.patch, 
 ZOOKEEPER-2221.patch, ZOOKEEPER-2221_1.patch


 Currently JettyAdminServer starting on 0.0.0.0 IP. 0.0.0.0 means all IP 
 addresses on the local machine. So, if your webserver machine has two ip 
 addresses, 192.168.1.1(private) and 10.1.2.1(public), and you allow a 
 webserver daemon like apache to listen on 0.0.0.0, it will be reachable at 
 both of those IPs.
 This is security issue. webserver should be accessible from only configured IP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2221) Zookeeper JettyAdminServer server should start on configured IP.

2015-06-28 Thread Surendra Singh Lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14604572#comment-14604572
 ] 

Surendra Singh Lilhore commented on ZOOKEEPER-2221:
---

Failed test case not related to this patch...

 Zookeeper JettyAdminServer server should start on configured IP.
 

 Key: ZOOKEEPER-2221
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2221
 Project: ZooKeeper
  Issue Type: Bug
  Components: quorum
Affects Versions: 3.5.0
Reporter: Surendra Singh Lilhore
Assignee: Surendra Singh Lilhore
 Attachments: ZOOKEEPER-2221.patch, ZOOKEEPER-2221_1.patch


 Currently JettyAdminServer starting on 0.0.0.0 IP. 0.0.0.0 means all IP 
 addresses on the local machine. So, if your webserver machine has two ip 
 addresses, 192.168.1.1(private) and 10.1.2.1(public), and you allow a 
 webserver daemon like apache to listen on 0.0.0.0, it will be reachable at 
 both of those IPs.
 This is security issue. webserver should be accessible from only configured IP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2221) Zookeeper JettyAdminServer server should start on configured IP.

2015-06-27 Thread Surendra Singh Lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Surendra Singh Lilhore updated ZOOKEEPER-2221:
--
Attachment: (was: ZOOKEEPER-2221_1.patch)

 Zookeeper JettyAdminServer server should start on configured IP.
 

 Key: ZOOKEEPER-2221
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2221
 Project: ZooKeeper
  Issue Type: Bug
  Components: quorum
Affects Versions: 3.5.0
Reporter: Surendra Singh Lilhore
Assignee: Surendra Singh Lilhore
 Attachments: ZOOKEEPER-2221.patch


 Currently JettyAdminServer starting on 0.0.0.0 IP. 0.0.0.0 means all IP 
 addresses on the local machine. So, if your webserver machine has two ip 
 addresses, 192.168.1.1(private) and 10.1.2.1(public), and you allow a 
 webserver daemon like apache to listen on 0.0.0.0, it will be reachable at 
 both of those IPs.
 This is security issue. webserver should be accessible from only configured IP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2221) Zookeeper JettyAdminServer server should start on configured IP.

2015-06-27 Thread Surendra Singh Lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Surendra Singh Lilhore updated ZOOKEEPER-2221:
--
Attachment: ZOOKEEPER-2221_1.patch

 Zookeeper JettyAdminServer server should start on configured IP.
 

 Key: ZOOKEEPER-2221
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2221
 Project: ZooKeeper
  Issue Type: Bug
  Components: quorum
Affects Versions: 3.5.0
Reporter: Surendra Singh Lilhore
Assignee: Surendra Singh Lilhore
 Attachments: ZOOKEEPER-2221.patch, ZOOKEEPER-2221_1.patch


 Currently JettyAdminServer starting on 0.0.0.0 IP. 0.0.0.0 means all IP 
 addresses on the local machine. So, if your webserver machine has two ip 
 addresses, 192.168.1.1(private) and 10.1.2.1(public), and you allow a 
 webserver daemon like apache to listen on 0.0.0.0, it will be reachable at 
 both of those IPs.
 This is security issue. webserver should be accessible from only configured IP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2221) Zookeeper JettyAdminServer server should start on configured IP.

2015-06-27 Thread Surendra Singh Lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Surendra Singh Lilhore updated ZOOKEEPER-2221:
--
Attachment: ZOOKEEPER-2221_1.patch

Thanks [~rgs] and [~rakeshr] for looking in to this issue.

I fixed all the comments and attached new patch. please review.

 Zookeeper JettyAdminServer server should start on configured IP.
 

 Key: ZOOKEEPER-2221
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2221
 Project: ZooKeeper
  Issue Type: Bug
  Components: quorum
Affects Versions: 3.5.0
Reporter: Surendra Singh Lilhore
Assignee: Surendra Singh Lilhore
 Attachments: ZOOKEEPER-2221.patch, ZOOKEEPER-2221_1.patch


 Currently JettyAdminServer starting on 0.0.0.0 IP. 0.0.0.0 means all IP 
 addresses on the local machine. So, if your webserver machine has two ip 
 addresses, 192.168.1.1(private) and 10.1.2.1(public), and you allow a 
 webserver daemon like apache to listen on 0.0.0.0, it will be reachable at 
 both of those IPs.
 This is security issue. webserver should be accessible from only configured IP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2221) Zookeeper JettyAdminServer server should start on configured IP.

2015-06-25 Thread Surendra Singh Lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Surendra Singh Lilhore updated ZOOKEEPER-2221:
--
Attachment: ZOOKEEPER-2221.patch

Attached patch, please review ..

 Zookeeper JettyAdminServer server should start on configured IP.
 

 Key: ZOOKEEPER-2221
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2221
 Project: ZooKeeper
  Issue Type: Bug
  Components: quorum
Affects Versions: 3.5.0
Reporter: Surendra Singh Lilhore
Assignee: Surendra Singh Lilhore
 Attachments: ZOOKEEPER-2221.patch


 Currently JettyAdminServer starting on 0.0.0.0 IP. 0.0.0.0 means all IP 
 addresses on the local machine. So, if your webserver machine has two ip 
 addresses, 192.168.1.1(private) and 10.1.2.1(public), and you allow a 
 webserver daemon like apache to listen on 0.0.0.0, it will be reachable at 
 both of those IPs.
 This is security issue. webserver should be accessible from only configured IP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (ZOOKEEPER-2221) Zookeeper JettyAdminServer server should start on configured IP.

2015-06-25 Thread Surendra Singh Lilhore (JIRA)
Surendra Singh Lilhore created ZOOKEEPER-2221:
-

 Summary: Zookeeper JettyAdminServer server should start on 
configured IP.
 Key: ZOOKEEPER-2221
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2221
 Project: ZooKeeper
  Issue Type: Bug
  Components: quorum
Affects Versions: 3.5.0
Reporter: Surendra Singh Lilhore
Assignee: Surendra Singh Lilhore


Currently JettyAdminServer starting on 0.0.0.0 IP. 0.0.0.0 means all IP 
addresses on the local machine. So, if your webserver machine has two ip 
addresses, 192.168.1.1(private) and 10.1.2.1(public), and you allow a webserver 
daemon like apache to listen on 0.0.0.0, it will be reachable at both of those 
IPs.

This is security issue. webserver should be accessible from only configured IP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (ZOOKEEPER-2215) Four letter command don't have kerberos authentication

2015-06-12 Thread surendra singh lilhore (JIRA)
surendra singh lilhore created ZOOKEEPER-2215:
-

 Summary: Four letter command don't have kerberos authentication 
 Key: ZOOKEEPER-2215
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2215
 Project: ZooKeeper
  Issue Type: Bug
Reporter: surendra singh lilhore


 echo dump | netcat IP port



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2116) zkCli.sh doesn't honor host:port parameter

2015-05-28 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564158#comment-14564158
 ] 

surendra singh lilhore commented on ZOOKEEPER-2116:
---

Its fixed very long back ...May here we need to change the fixed version..

It fixed as part of ZOOKEEPER-437. Pls check the check-in history for revision 
783162

=
Revision: 783162
Author: mahadev
Date: AM 4:33:38, 10 June 2009
Message:
ZOOKEEPER-437. Variety of Documentation Updates (grant via mahadev)


 zkCli.sh doesn't honor host:port parameter
 --

 Key: ZOOKEEPER-2116
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2116
 Project: ZooKeeper
  Issue Type: Bug
  Components: java client, scripts
Affects Versions: 3.4.6
 Environment: Ubuntu 12
Reporter: Maxim Novikov
Assignee: surendra singh lilhore
Priority: Critical
 Fix For: 3.6.0


 This doc http://zookeeper.apache.org/doc/r3.1.2/zookeeperStarted.html 
 (Connecting to ZooKeeper section) says:
 Once ZooKeeper is running, you have several options for connection to it:
 Java: Use
 bin/zkCli.sh 127.0.0.1:2181
 In fact, it doesn't work that way. I am running ZooKeeper with a different 
 port to listen to client connections (2888), and this command
 {code}
 bin/zkCli.sh 127.0.0.1:2888
 {code}
 is still trying to connect to 2181.
 {code:title=output|borderStyle=solid}
 Connecting to localhost:2181
 2015-02-11 15:38:14,415 [myid:] - INFO  [main:Environment@100] - Client 
 environment:zookeeper.version=3.4.6-1569965, built on 02/20/2014 09:09 GMT
 2015-02-11 15:38:14,421 [myid:] - INFO  [main:Environment@100] - Client 
 environment:host.name=localhost
 2015-02-11 15:38:14,421 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.version=1.7.0_17
 2015-02-11 15:38:14,424 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.vendor=Oracle Corporation
 2015-02-11 15:38:14,424 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.home=/usr/java/jdk1.7.0_17/jre
 2015-02-11 15:38:14,424 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.class.path=/opt/zookeeper-3.4.6/bin/../build/classes:/opt/zookeeper-3.4.6/bin/../build/lib/*.jar:/opt/zookeeper-3.4.6/bin/../lib/slf4j-log4j12-1.6.1.jar:/opt/zookeeper-3.4.6/bin/../lib/slf4j-api-1.6.1.jar:/opt/zookeeper-3.4.6/bin/../lib/netty-3.7.0.Final.jar:/opt/zookeeper-3.4.6/bin/../lib/log4j-1.2.16.jar:/opt/zookeeper-3.4.6/bin/../lib/jline-0.9.94.jar:/opt/zookeeper-3.4.6/bin/../zookeeper-3.4.6.jar:/opt/zookeeper-3.4.6/bin/../src/java/lib/*.jar:../conf::/usr/share/antlr3/lib/antlr-3.5-complete-no-st3.jar
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.library.path=/usr/java/packages/lib/amd64:/usr/lib64:/lib64:/lib:/usr/lib
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.io.tmpdir=/tmp
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.compiler=NA
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:os.name=Linux
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:os.arch=amd64
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:os.version=3.8.0-41-generic
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:user.name=mnovikov
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:user.home=/home/mnovikov
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:user.dir=/opt/zookeeper-3.4.6/bin
 2015-02-11 15:38:14,428 [myid:] - INFO  [main:ZooKeeper@438] - Initiating 
 client connection, connectString=localhost:2181 sessionTimeout=3 
 watcher=org.apache.zookeeper.ZooKeeperMain$MyWatcher@3107eafc
 Welcome to ZooKeeper!
 2015-02-11 15:38:14,471 [myid:] - INFO  
 [main-SendThread(localhost:2181):ClientCnxn$SendThread@975] - Opening socket 
 connection to server localhost/127.0.0.1:2181. Will not attempt to 
 authenticate using SASL (unknown error)
 2015-02-11 15:38:14,479 [myid:] - WARN  
 [main-SendThread(localhost:2181):ClientCnxn$SendThread@1102] - Session 0x0 
 for server null, unexpected error, closing socket connection and attempting 
 reconnect
 java.net.ConnectException: Connection refused
   at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
   at 
 sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:692)
   at 
 org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361)
   at 

[jira] [Updated] (ZOOKEEPER-2179) Typo in Watcher.java

2015-05-28 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore updated ZOOKEEPER-2179:
--
Assignee: (was: surendra singh lilhore)

 Typo in Watcher.java
 

 Key: ZOOKEEPER-2179
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2179
 Project: ZooKeeper
  Issue Type: Bug
  Components: server
Affects Versions: 3.4.5, 3.5.0
Reporter: Eunchan Kim
Priority: Trivial
 Fix For: 3.4.5, 3.5.0


 at zookeeper/src/java/main/org/apache/zookeeper/Watcher.java,
  * implement. A ZooKeeper client will get various events from the ZooKeepr
 should be fixed to 
  * implement. A ZooKeeper client will get various events from the ZooKeeper.
 (Zookeepr - Zookeeper)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (ZOOKEEPER-2116) zkCli.sh doesn't honor host:port parameter

2015-05-28 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore resolved ZOOKEEPER-2116.
---
   Resolution: Implemented
Fix Version/s: 3.6.0

Closing, because it is already fixed, Please feel free to reopen If any doubt. 

 zkCli.sh doesn't honor host:port parameter
 --

 Key: ZOOKEEPER-2116
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2116
 Project: ZooKeeper
  Issue Type: Bug
  Components: java client, scripts
Affects Versions: 3.4.6
 Environment: Ubuntu 12
Reporter: Maxim Novikov
Assignee: surendra singh lilhore
Priority: Critical
 Fix For: 3.6.0


 This doc http://zookeeper.apache.org/doc/r3.1.2/zookeeperStarted.html 
 (Connecting to ZooKeeper section) says:
 Once ZooKeeper is running, you have several options for connection to it:
 Java: Use
 bin/zkCli.sh 127.0.0.1:2181
 In fact, it doesn't work that way. I am running ZooKeeper with a different 
 port to listen to client connections (2888), and this command
 {code}
 bin/zkCli.sh 127.0.0.1:2888
 {code}
 is still trying to connect to 2181.
 {code:title=output|borderStyle=solid}
 Connecting to localhost:2181
 2015-02-11 15:38:14,415 [myid:] - INFO  [main:Environment@100] - Client 
 environment:zookeeper.version=3.4.6-1569965, built on 02/20/2014 09:09 GMT
 2015-02-11 15:38:14,421 [myid:] - INFO  [main:Environment@100] - Client 
 environment:host.name=localhost
 2015-02-11 15:38:14,421 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.version=1.7.0_17
 2015-02-11 15:38:14,424 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.vendor=Oracle Corporation
 2015-02-11 15:38:14,424 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.home=/usr/java/jdk1.7.0_17/jre
 2015-02-11 15:38:14,424 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.class.path=/opt/zookeeper-3.4.6/bin/../build/classes:/opt/zookeeper-3.4.6/bin/../build/lib/*.jar:/opt/zookeeper-3.4.6/bin/../lib/slf4j-log4j12-1.6.1.jar:/opt/zookeeper-3.4.6/bin/../lib/slf4j-api-1.6.1.jar:/opt/zookeeper-3.4.6/bin/../lib/netty-3.7.0.Final.jar:/opt/zookeeper-3.4.6/bin/../lib/log4j-1.2.16.jar:/opt/zookeeper-3.4.6/bin/../lib/jline-0.9.94.jar:/opt/zookeeper-3.4.6/bin/../zookeeper-3.4.6.jar:/opt/zookeeper-3.4.6/bin/../src/java/lib/*.jar:../conf::/usr/share/antlr3/lib/antlr-3.5-complete-no-st3.jar
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.library.path=/usr/java/packages/lib/amd64:/usr/lib64:/lib64:/lib:/usr/lib
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.io.tmpdir=/tmp
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.compiler=NA
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:os.name=Linux
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:os.arch=amd64
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:os.version=3.8.0-41-generic
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:user.name=mnovikov
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:user.home=/home/mnovikov
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:user.dir=/opt/zookeeper-3.4.6/bin
 2015-02-11 15:38:14,428 [myid:] - INFO  [main:ZooKeeper@438] - Initiating 
 client connection, connectString=localhost:2181 sessionTimeout=3 
 watcher=org.apache.zookeeper.ZooKeeperMain$MyWatcher@3107eafc
 Welcome to ZooKeeper!
 2015-02-11 15:38:14,471 [myid:] - INFO  
 [main-SendThread(localhost:2181):ClientCnxn$SendThread@975] - Opening socket 
 connection to server localhost/127.0.0.1:2181. Will not attempt to 
 authenticate using SASL (unknown error)
 2015-02-11 15:38:14,479 [myid:] - WARN  
 [main-SendThread(localhost:2181):ClientCnxn$SendThread@1102] - Session 0x0 
 for server null, unexpected error, closing socket connection and attempting 
 reconnect
 java.net.ConnectException: Connection refused
   at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
   at 
 sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:692)
   at 
 org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361)
   at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1081)
 {code}
 PS1 I can connect to ZK at 2888 using ZK Java client from code specifying the 
 correct port with no issues. But CLI seems just to ignore the provided 
 host:port parameter.
 PS2 Tried to run it with the pre-defined ZOOCFGDIR environment variable (to 
 point to the path with the config file where the client 

[jira] [Commented] (ZOOKEEPER-2116) zkCli.sh doesn't honor host:port parameter

2015-05-28 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562587#comment-14562587
 ] 

surendra singh lilhore commented on ZOOKEEPER-2116:
---

[~csbubbles] This is fixed in new version, Please check link

 zkCli.sh doesn't honor host:port parameter
 --

 Key: ZOOKEEPER-2116
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2116
 Project: ZooKeeper
  Issue Type: Bug
  Components: java client, scripts
Affects Versions: 3.4.6
 Environment: Ubuntu 12
Reporter: Maxim Novikov
Assignee: surendra singh lilhore
Priority: Critical

 This doc http://zookeeper.apache.org/doc/r3.1.2/zookeeperStarted.html 
 (Connecting to ZooKeeper section) says:
 Once ZooKeeper is running, you have several options for connection to it:
 Java: Use
 bin/zkCli.sh 127.0.0.1:2181
 In fact, it doesn't work that way. I am running ZooKeeper with a different 
 port to listen to client connections (2888), and this command
 {code}
 bin/zkCli.sh 127.0.0.1:2888
 {code}
 is still trying to connect to 2181.
 {code:title=output|borderStyle=solid}
 Connecting to localhost:2181
 2015-02-11 15:38:14,415 [myid:] - INFO  [main:Environment@100] - Client 
 environment:zookeeper.version=3.4.6-1569965, built on 02/20/2014 09:09 GMT
 2015-02-11 15:38:14,421 [myid:] - INFO  [main:Environment@100] - Client 
 environment:host.name=localhost
 2015-02-11 15:38:14,421 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.version=1.7.0_17
 2015-02-11 15:38:14,424 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.vendor=Oracle Corporation
 2015-02-11 15:38:14,424 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.home=/usr/java/jdk1.7.0_17/jre
 2015-02-11 15:38:14,424 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.class.path=/opt/zookeeper-3.4.6/bin/../build/classes:/opt/zookeeper-3.4.6/bin/../build/lib/*.jar:/opt/zookeeper-3.4.6/bin/../lib/slf4j-log4j12-1.6.1.jar:/opt/zookeeper-3.4.6/bin/../lib/slf4j-api-1.6.1.jar:/opt/zookeeper-3.4.6/bin/../lib/netty-3.7.0.Final.jar:/opt/zookeeper-3.4.6/bin/../lib/log4j-1.2.16.jar:/opt/zookeeper-3.4.6/bin/../lib/jline-0.9.94.jar:/opt/zookeeper-3.4.6/bin/../zookeeper-3.4.6.jar:/opt/zookeeper-3.4.6/bin/../src/java/lib/*.jar:../conf::/usr/share/antlr3/lib/antlr-3.5-complete-no-st3.jar
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.library.path=/usr/java/packages/lib/amd64:/usr/lib64:/lib64:/lib:/usr/lib
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.io.tmpdir=/tmp
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.compiler=NA
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:os.name=Linux
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:os.arch=amd64
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:os.version=3.8.0-41-generic
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:user.name=mnovikov
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:user.home=/home/mnovikov
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:user.dir=/opt/zookeeper-3.4.6/bin
 2015-02-11 15:38:14,428 [myid:] - INFO  [main:ZooKeeper@438] - Initiating 
 client connection, connectString=localhost:2181 sessionTimeout=3 
 watcher=org.apache.zookeeper.ZooKeeperMain$MyWatcher@3107eafc
 Welcome to ZooKeeper!
 2015-02-11 15:38:14,471 [myid:] - INFO  
 [main-SendThread(localhost:2181):ClientCnxn$SendThread@975] - Opening socket 
 connection to server localhost/127.0.0.1:2181. Will not attempt to 
 authenticate using SASL (unknown error)
 2015-02-11 15:38:14,479 [myid:] - WARN  
 [main-SendThread(localhost:2181):ClientCnxn$SendThread@1102] - Session 0x0 
 for server null, unexpected error, closing socket connection and attempting 
 reconnect
 java.net.ConnectException: Connection refused
   at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
   at 
 sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:692)
   at 
 org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361)
   at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1081)
 {code}
 PS1 I can connect to ZK at 2888 using ZK Java client from code specifying the 
 correct port with no issues. But CLI seems just to ignore the provided 
 host:port parameter.
 PS2 Tried to run it with the pre-defined ZOOCFGDIR environment variable (to 
 point to the path with the config file where the client port is set to 2888). 
 No luck, same results as 

[jira] [Commented] (ZOOKEEPER-2116) zkCli.sh doesn't honor host:port parameter

2015-05-28 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562589#comment-14562589
 ] 

surendra singh lilhore commented on ZOOKEEPER-2116:
---

http://zookeeper.apache.org/doc/r3.4.6/zookeeperStarted.html

 zkCli.sh doesn't honor host:port parameter
 --

 Key: ZOOKEEPER-2116
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2116
 Project: ZooKeeper
  Issue Type: Bug
  Components: java client, scripts
Affects Versions: 3.4.6
 Environment: Ubuntu 12
Reporter: Maxim Novikov
Assignee: surendra singh lilhore
Priority: Critical

 This doc http://zookeeper.apache.org/doc/r3.1.2/zookeeperStarted.html 
 (Connecting to ZooKeeper section) says:
 Once ZooKeeper is running, you have several options for connection to it:
 Java: Use
 bin/zkCli.sh 127.0.0.1:2181
 In fact, it doesn't work that way. I am running ZooKeeper with a different 
 port to listen to client connections (2888), and this command
 {code}
 bin/zkCli.sh 127.0.0.1:2888
 {code}
 is still trying to connect to 2181.
 {code:title=output|borderStyle=solid}
 Connecting to localhost:2181
 2015-02-11 15:38:14,415 [myid:] - INFO  [main:Environment@100] - Client 
 environment:zookeeper.version=3.4.6-1569965, built on 02/20/2014 09:09 GMT
 2015-02-11 15:38:14,421 [myid:] - INFO  [main:Environment@100] - Client 
 environment:host.name=localhost
 2015-02-11 15:38:14,421 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.version=1.7.0_17
 2015-02-11 15:38:14,424 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.vendor=Oracle Corporation
 2015-02-11 15:38:14,424 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.home=/usr/java/jdk1.7.0_17/jre
 2015-02-11 15:38:14,424 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.class.path=/opt/zookeeper-3.4.6/bin/../build/classes:/opt/zookeeper-3.4.6/bin/../build/lib/*.jar:/opt/zookeeper-3.4.6/bin/../lib/slf4j-log4j12-1.6.1.jar:/opt/zookeeper-3.4.6/bin/../lib/slf4j-api-1.6.1.jar:/opt/zookeeper-3.4.6/bin/../lib/netty-3.7.0.Final.jar:/opt/zookeeper-3.4.6/bin/../lib/log4j-1.2.16.jar:/opt/zookeeper-3.4.6/bin/../lib/jline-0.9.94.jar:/opt/zookeeper-3.4.6/bin/../zookeeper-3.4.6.jar:/opt/zookeeper-3.4.6/bin/../src/java/lib/*.jar:../conf::/usr/share/antlr3/lib/antlr-3.5-complete-no-st3.jar
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.library.path=/usr/java/packages/lib/amd64:/usr/lib64:/lib64:/lib:/usr/lib
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.io.tmpdir=/tmp
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.compiler=NA
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:os.name=Linux
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:os.arch=amd64
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:os.version=3.8.0-41-generic
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:user.name=mnovikov
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:user.home=/home/mnovikov
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:user.dir=/opt/zookeeper-3.4.6/bin
 2015-02-11 15:38:14,428 [myid:] - INFO  [main:ZooKeeper@438] - Initiating 
 client connection, connectString=localhost:2181 sessionTimeout=3 
 watcher=org.apache.zookeeper.ZooKeeperMain$MyWatcher@3107eafc
 Welcome to ZooKeeper!
 2015-02-11 15:38:14,471 [myid:] - INFO  
 [main-SendThread(localhost:2181):ClientCnxn$SendThread@975] - Opening socket 
 connection to server localhost/127.0.0.1:2181. Will not attempt to 
 authenticate using SASL (unknown error)
 2015-02-11 15:38:14,479 [myid:] - WARN  
 [main-SendThread(localhost:2181):ClientCnxn$SendThread@1102] - Session 0x0 
 for server null, unexpected error, closing socket connection and attempting 
 reconnect
 java.net.ConnectException: Connection refused
   at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
   at 
 sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:692)
   at 
 org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361)
   at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1081)
 {code}
 PS1 I can connect to ZK at 2888 using ZK Java client from code specifying the 
 correct port with no issues. But CLI seems just to ignore the provided 
 host:port parameter.
 PS2 Tried to run it with the pre-defined ZOOCFGDIR environment variable (to 
 point to the path with the config file where the client port is set to 2888). 
 No luck, same results as 

[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property

2015-05-28 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562616#comment-14562616
 ] 

surendra singh lilhore commented on ZOOKEEPER-2139:
---

Thanks [~rakeshr] for comments and suggestion.. 

 Zookeeper client configuration should not be java system property
 -

 Key: ZOOKEEPER-2139
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
 Project: ZooKeeper
  Issue Type: Improvement
  Components: java client
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore
 Fix For: 3.5.2, 3.6.0

 Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, 
 ZOOKEEPER-2139_2.patch


 I have two ZK client in one JVM, one is secure client and second is normal 
 client (For non secure cluster).
 zookeeper.sasl.client system property is true by default, because of this 
 my second client connection is failing.
 We should pass all client configurations in client constructor like HDFS 
 client.
 For example :
 {code}
 public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, 
 Configuration conf) throws IOException
   {
   ..
   ..
   }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property

2015-05-28 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562615#comment-14562615
 ] 

surendra singh lilhore commented on ZOOKEEPER-2139:
---

Thanks [~rakeshr] for comments and suggestion.. 

 Zookeeper client configuration should not be java system property
 -

 Key: ZOOKEEPER-2139
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
 Project: ZooKeeper
  Issue Type: Improvement
  Components: java client
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore
 Fix For: 3.5.2, 3.6.0

 Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, 
 ZOOKEEPER-2139_2.patch


 I have two ZK client in one JVM, one is secure client and second is normal 
 client (For non secure cluster).
 zookeeper.sasl.client system property is true by default, because of this 
 my second client connection is failing.
 We should pass all client configurations in client constructor like HDFS 
 client.
 For example :
 {code}
 public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, 
 Configuration conf) throws IOException
   {
   ..
   ..
   }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (ZOOKEEPER-2179) Typo in Watcher.java

2015-05-04 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore reassigned ZOOKEEPER-2179:
-

Assignee: surendra singh lilhore

 Typo in Watcher.java
 

 Key: ZOOKEEPER-2179
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2179
 Project: ZooKeeper
  Issue Type: Bug
  Components: server
Affects Versions: 3.4.5, 3.5.0
Reporter: Eunchan Kim
Assignee: surendra singh lilhore
Priority: Trivial
 Fix For: 3.4.5, 3.5.0


 at zookeeper/src/java/main/org/apache/zookeeper/Watcher.java,
  * implement. A ZooKeeper client will get various events from the ZooKeepr
 should be fixed to 
  * implement. A ZooKeeper client will get various events from the ZooKeeper.
 (Zookeepr - Zookeeper)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2126) ClientCnxn.close doesn't wait for eventThread exit which cause out of order log when close Zookeeper client session.

2015-05-02 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore updated ZOOKEEPER-2126:
--
Attachment: ZOOKEEPER-2126_1.patch

Thanks [~rakeshr] for review and suggestion..

Attached new patch.. Please review..

 ClientCnxn.close doesn't wait for eventThread exit which cause out of order 
 log when close Zookeeper client session.
 

 Key: ZOOKEEPER-2126
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2126
 Project: ZooKeeper
  Issue Type: Improvement
Affects Versions: 3.6.0
Reporter: zhihai xu
Assignee: surendra singh lilhore
 Attachments: ZOOKEEPER-2126.patch, ZOOKEEPER-2126_1.patch


 We saw the following out of order log when close Zookeeper client session.
 {code}
 2015-02-16 06:01:12,985 INFO org.apache.zookeeper.ZooKeeper: Session: 
 0x24b8df4044005d4 closed
 .
 2015-02-16 06:01:12,995 INFO org.apache.zookeeper.ClientCnxn: EventThread 
 shut down
 {code}
 This logs are very confusing if a new Zookeeper client session is created 
 between these two logs. We may think new Zookeeper client session shutdown it 
 EventThread instead of the old closed Zookeeper client session.
 Should we wait for sendThread and eventThread died in the ClientCnxn.close?
 We can add the following code in ClientCnxn.close.
 {code}
 sendThread.join(timeout);
 eventThread.join(timeout);
 {code}
 with the change, we won't interleave old closed session with new session.
 We can also create a new close API to support this so we won't affect the old 
 code if people use old close API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property

2015-04-27 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14514109#comment-14514109
 ] 

surendra singh lilhore commented on ZOOKEEPER-2139:
---

Thanks [~rakeshr] for reviewing.. I have one doubt for first comment. If I want 
to extend {{AbstractConfiguration}} then I need to add one new dependency for 
{{commons-configuration-*.jar}} and it will create compatibility issue. Please 
correct if I am wrong.

 Zookeeper client configuration should not be java system property
 -

 Key: ZOOKEEPER-2139
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
 Project: ZooKeeper
  Issue Type: Improvement
  Components: java client
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore
 Fix For: 3.5.2, 3.6.0

 Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, 
 ZOOKEEPER-2139_2.patch


 I have two ZK client in one JVM, one is secure client and second is normal 
 client (For non secure cluster).
 zookeeper.sasl.client system property is true by default, because of this 
 my second client connection is failing.
 We should pass all client configurations in client constructor like HDFS 
 client.
 For example :
 {code}
 public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, 
 Configuration conf) throws IOException
   {
   ..
   ..
   }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2154) NPE in KeeperException

2015-03-31 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore updated ZOOKEEPER-2154:
--
Attachment: ZOOKEEPER-2154.patch

 NPE in KeeperException
 --

 Key: ZOOKEEPER-2154
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2154
 Project: ZooKeeper
  Issue Type: Bug
  Components: java client
Affects Versions: 3.4.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore
 Attachments: ZOOKEEPER-2154.patch


 KeeperException should handle exception is code is null...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2154) NPE in KeeperException

2015-03-30 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388075#comment-14388075
 ] 

surendra singh lilhore commented on ZOOKEEPER-2154:
---

2015-03-27 15:28:50,966 | ERROR | regionserver21302-EventThread | Error while 
calling watcher  | 
org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:527)
java.lang.NullPointerException
at org.apache.zookeeper.KeeperException.create(KeeperException.java:91)
at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
at org.apache.zookeeper.ZooKeeper.getChildren(ZooKeeper.java:1476)
at 
org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.getChildren(RecoverableZooKeeper.java:273)


 NPE in KeeperException
 --

 Key: ZOOKEEPER-2154
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2154
 Project: ZooKeeper
  Issue Type: Bug
  Components: java client
Affects Versions: 3.4.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore

 KeeperException should handle exception is code is null...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (ZOOKEEPER-2154) NPE in KeeperException

2015-03-30 Thread surendra singh lilhore (JIRA)
surendra singh lilhore created ZOOKEEPER-2154:
-

 Summary: NPE in KeeperException
 Key: ZOOKEEPER-2154
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2154
 Project: ZooKeeper
  Issue Type: Bug
  Components: java client
Affects Versions: 3.4.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore


KeeperException should handle exception is code is null...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property

2015-03-29 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385671#comment-14385671
 ] 

surendra singh lilhore commented on ZOOKEEPER-2139:
---

Failed test case is not related to this patch and its passing locally.
Please review.


 Zookeeper client configuration should not be java system property
 -

 Key: ZOOKEEPER-2139
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
 Project: ZooKeeper
  Issue Type: Improvement
  Components: java client
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, 
 ZOOKEEPER-2139_2.patch


 I have two ZK client in one JVM, one is secure client and second is normal 
 client (For non secure cluster).
 zookeeper.sasl.client system property is true by default, because of this 
 my second client connection is failing.
 We should pass all client configurations in client constructor like HDFS 
 client.
 For example :
 {code}
 public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, 
 Configuration conf) throws IOException
   {
   ..
   ..
   }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2126) ClientCnxn.close doesn't wait for eventThread exit which cause out of order log when close Zookeeper client session.

2015-03-29 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385674#comment-14385674
 ] 

surendra singh lilhore commented on ZOOKEEPER-2126:
---

Build result is showing core test cases are failed but actually in test results 
all the test cases are passed.
Please review.


 ClientCnxn.close doesn't wait for eventThread exit which cause out of order 
 log when close Zookeeper client session.
 

 Key: ZOOKEEPER-2126
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2126
 Project: ZooKeeper
  Issue Type: Improvement
Affects Versions: 3.6.0
Reporter: zhihai xu
Assignee: surendra singh lilhore
 Attachments: ZOOKEEPER-2126.patch


 We saw the following out of order log when close Zookeeper client session.
 {code}
 2015-02-16 06:01:12,985 INFO org.apache.zookeeper.ZooKeeper: Session: 
 0x24b8df4044005d4 closed
 .
 2015-02-16 06:01:12,995 INFO org.apache.zookeeper.ClientCnxn: EventThread 
 shut down
 {code}
 This logs are very confusing if a new Zookeeper client session is created 
 between these two logs. We may think new Zookeeper client session shutdown it 
 EventThread instead of the old closed Zookeeper client session.
 Should we wait for sendThread and eventThread died in the ClientCnxn.close?
 We can add the following code in ClientCnxn.close.
 {code}
 sendThread.join(timeout);
 eventThread.join(timeout);
 {code}
 with the change, we won't interleave old closed session with new session.
 We can also create a new close API to support this so we won't affect the old 
 code if people use old close API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property

2015-03-28 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore updated ZOOKEEPER-2139:
--
Attachment: ZOOKEEPER-2139_2.patch

 Zookeeper client configuration should not be java system property
 -

 Key: ZOOKEEPER-2139
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
 Project: ZooKeeper
  Issue Type: Improvement
  Components: java client
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, 
 ZOOKEEPER-2139_2.patch


 I have two ZK client in one JVM, one is secure client and second is normal 
 client (For non secure cluster).
 zookeeper.sasl.client system property is true by default, because of this 
 my second client connection is failing.
 We should pass all client configurations in client constructor like HDFS 
 client.
 For example :
 {code}
 public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, 
 Configuration conf) throws IOException
   {
   ..
   ..
   }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2074) Incorrect exit codes for ./zkCli.sh cmd arg

2015-03-28 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385471#comment-14385471
 ] 

surendra singh lilhore commented on ZOOKEEPER-2074:
---

[~michim] I have attached new patch. Please can you review..

 Incorrect exit codes for ./zkCli.sh cmd arg
 -

 Key: ZOOKEEPER-2074
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2074
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore
Priority: Minor
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-2074_1.patch, ZOOKEEPER-2074_2.patch, 
 ZOOKEEPER-2074_3.patch


 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Created /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Node already exists: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Node does not exist: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Here for failed command it should return exit code 1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property

2015-03-26 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore updated ZOOKEEPER-2139:
--
Attachment: ZOOKEEPER-2139_1.patch

 Zookeeper client configuration should not be java system property
 -

 Key: ZOOKEEPER-2139
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
 Project: ZooKeeper
  Issue Type: Improvement
  Components: java client
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch


 I have two ZK client in one JVM, one is secure client and second is normal 
 client (For non secure cluster).
 zookeeper.sasl.client system property is true by default, because of this 
 my second client connection is failing.
 We should pass all client configurations in client constructor like HDFS 
 client.
 For example :
 {code}
 public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, 
 Configuration conf) throws IOException
   {
   ..
   ..
   }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2074) Incorrect exit codes for ./zkCli.sh cmd arg

2015-03-26 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore updated ZOOKEEPER-2074:
--
Attachment: ZOOKEEPER-2074_3.patch

Attached new patch, please review 

 Incorrect exit codes for ./zkCli.sh cmd arg
 -

 Key: ZOOKEEPER-2074
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2074
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore
Priority: Minor
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-2074_1.patch, ZOOKEEPER-2074_2.patch, 
 ZOOKEEPER-2074_3.patch


 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Created /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Node already exists: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Node does not exist: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Here for failed command it should return exit code 1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property

2015-03-24 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore updated ZOOKEEPER-2139:
--
Attachment: ZOOKEEPER-2139.patch

In this patch I have moved following configuration in ClientConfiguration.java 
class
{code}
zookeeper.sasl.client.username
zookeeper.sasl.clientconfig
zookeeper.sasl.client
zookeeper.server.realm
{code}
User can override the system property by passing these configuration in 
zookeeper constructor

Please review and give your comments .


 Zookeeper client configuration should not be java system property
 -

 Key: ZOOKEEPER-2139
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
 Project: ZooKeeper
  Issue Type: Improvement
  Components: java client
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore
 Attachments: ZOOKEEPER-2139.patch


 I have two ZK client in one JVM, one is secure client and second is normal 
 client (For non secure cluster).
 zookeeper.sasl.client system property is true by default, because of this 
 my second client connection is failing.
 We should pass all client configurations in client constructor like HDFS 
 client.
 For example :
 {code}
 public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, 
 Configuration conf) throws IOException
   {
   ..
   ..
   }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2126) ClientCnxn.close doesn't wait for eventThread exit which cause out of order log when close Zookeeper client session.

2015-03-22 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore updated ZOOKEEPER-2126:
--
Attachment: ZOOKEEPER-2126.patch

 ClientCnxn.close doesn't wait for eventThread exit which cause out of order 
 log when close Zookeeper client session.
 

 Key: ZOOKEEPER-2126
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2126
 Project: ZooKeeper
  Issue Type: Improvement
Reporter: zhihai xu
Assignee: surendra singh lilhore
 Attachments: ZOOKEEPER-2126.patch


 We saw the following out of order log when close Zookeeper client session.
 {code}
 2015-02-16 06:01:12,985 INFO org.apache.zookeeper.ZooKeeper: Session: 
 0x24b8df4044005d4 closed
 .
 2015-02-16 06:01:12,995 INFO org.apache.zookeeper.ClientCnxn: EventThread 
 shut down
 {code}
 This logs are very confusing if a new Zookeeper client session is created 
 between these two logs. We may think new Zookeeper client session shutdown it 
 EventThread instead of the old closed Zookeeper client session.
 Should we wait for sendThread and eventThread died in the ClientCnxn.close?
 We can add the following code in ClientCnxn.close.
 {code}
 sendThread.join(timeout);
 eventThread.join(timeout);
 {code}
 with the change, we won't interleave old closed session with new session.
 We can also create a new close API to support this so we won't affect the old 
 code if people use old close API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property

2015-03-20 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370938#comment-14370938
 ] 

surendra singh lilhore commented on ZOOKEEPER-2139:
---

I will attach patch soon...

 Zookeeper client configuration should not be java system property
 -

 Key: ZOOKEEPER-2139
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
 Project: ZooKeeper
  Issue Type: Improvement
  Components: java client
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore

 I have two ZK client in one JVM, one is secure client and second is normal 
 client (For non secure cluster).
 zookeeper.sasl.client system property is true by default, because of this 
 my second client connection is failing.
 We should pass all client configurations in client constructor like HDFS 
 client.
 For example :
 {code}
 public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, 
 Configuration conf) throws IOException
   {
   ..
   ..
   }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property

2015-03-20 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370934#comment-14370934
 ] 

surendra singh lilhore commented on ZOOKEEPER-2139:
---

Thanks [~rakeshr] and [~Jobo] looking in to this issue..

 Zookeeper client configuration should not be java system property
 -

 Key: ZOOKEEPER-2139
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
 Project: ZooKeeper
  Issue Type: Improvement
  Components: java client
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore

 I have two ZK client in one JVM, one is secure client and second is normal 
 client (For non secure cluster).
 zookeeper.sasl.client system property is true by default, because of this 
 my second client connection is failing.
 We should pass all client configurations in client constructor like HDFS 
 client.
 For example :
 {code}
 public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, 
 Configuration conf) throws IOException
   {
   ..
   ..
   }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2074) Incorrect exit codes for ./zkCli.sh cmd arg

2015-03-15 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362695#comment-14362695
 ] 

surendra singh lilhore commented on ZOOKEEPER-2074:
---

Thanks [~michim] , [~rakeshr] Yes I will check it..

But I have one doubt, why processZKCmd() will return false if command is 
success.

when watch is false ??

{code}
 // execute from commandMap
CliCommand cliCmd = commandMapCli.get(cmd);
if(cliCmd != null) {
cliCmd.setZk(zk);
watch = cliCmd.parse(args).exec();
} else if (!commandMap.containsKey(cmd)) {
 usage();
}
{code}

I saw some command like getAcl which prints the command output on console, it 
will always return false 

{code}
@Override
public boolean exec() throws KeeperException, InterruptedException {
String path = args[1];
Stat stat = new Stat();
ListACL acl = zk.getACL(path, stat);
for (ACL a : acl) {
out.println(a.getId() + : 
+ getPermString(a.getPerms()));
}

if (cl.hasOption(s)) {
new StatPrinter(out).print(stat);
}
return false;
}
{code}

 Incorrect exit codes for ./zkCli.sh cmd arg
 -

 Key: ZOOKEEPER-2074
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2074
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore
Priority: Minor
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-2074_1.patch, ZOOKEEPER-2074_2.patch


 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Created /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Node already exists: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Node does not exist: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Here for failed command it should return exit code 1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2116) zkCli.sh doesn't honor host:port parameter

2015-03-15 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362708#comment-14362708
 ] 

surendra singh lilhore commented on ZOOKEEPER-2116:
---

Here no code issue, By default zkCli.sh will connect to localhost:2181.

{code}
connectToZK(cl.getOption(server));
{code}

{code}
  public MyCommandOptions() {
  options.put(server, localhost:2181);
  options.put(timeout, 3);
}
{code}

If you want to connect on some other port you need to pass it with -server 
option.

{code}
./zkCli.sh -server IP:Port
{code}

 zkCli.sh doesn't honor host:port parameter
 --

 Key: ZOOKEEPER-2116
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2116
 Project: ZooKeeper
  Issue Type: Bug
  Components: java client, scripts
Affects Versions: 3.4.6
 Environment: Ubuntu 12
Reporter: Maxim Novikov
Assignee: surendra singh lilhore
Priority: Critical

 This doc http://zookeeper.apache.org/doc/r3.1.2/zookeeperStarted.html 
 (Connecting to ZooKeeper section) says:
 Once ZooKeeper is running, you have several options for connection to it:
 Java: Use
 bin/zkCli.sh 127.0.0.1:2181
 In fact, it doesn't work that way. I am running ZooKeeper with a different 
 port to listen to client connections (2888), and this command
 {code}
 bin/zkCli.sh 127.0.0.1:2888
 {code}
 is still trying to connect to 2181.
 {code:title=output|borderStyle=solid}
 Connecting to localhost:2181
 2015-02-11 15:38:14,415 [myid:] - INFO  [main:Environment@100] - Client 
 environment:zookeeper.version=3.4.6-1569965, built on 02/20/2014 09:09 GMT
 2015-02-11 15:38:14,421 [myid:] - INFO  [main:Environment@100] - Client 
 environment:host.name=localhost
 2015-02-11 15:38:14,421 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.version=1.7.0_17
 2015-02-11 15:38:14,424 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.vendor=Oracle Corporation
 2015-02-11 15:38:14,424 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.home=/usr/java/jdk1.7.0_17/jre
 2015-02-11 15:38:14,424 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.class.path=/opt/zookeeper-3.4.6/bin/../build/classes:/opt/zookeeper-3.4.6/bin/../build/lib/*.jar:/opt/zookeeper-3.4.6/bin/../lib/slf4j-log4j12-1.6.1.jar:/opt/zookeeper-3.4.6/bin/../lib/slf4j-api-1.6.1.jar:/opt/zookeeper-3.4.6/bin/../lib/netty-3.7.0.Final.jar:/opt/zookeeper-3.4.6/bin/../lib/log4j-1.2.16.jar:/opt/zookeeper-3.4.6/bin/../lib/jline-0.9.94.jar:/opt/zookeeper-3.4.6/bin/../zookeeper-3.4.6.jar:/opt/zookeeper-3.4.6/bin/../src/java/lib/*.jar:../conf::/usr/share/antlr3/lib/antlr-3.5-complete-no-st3.jar
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.library.path=/usr/java/packages/lib/amd64:/usr/lib64:/lib64:/lib:/usr/lib
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.io.tmpdir=/tmp
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.compiler=NA
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:os.name=Linux
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:os.arch=amd64
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:os.version=3.8.0-41-generic
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:user.name=mnovikov
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:user.home=/home/mnovikov
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:user.dir=/opt/zookeeper-3.4.6/bin
 2015-02-11 15:38:14,428 [myid:] - INFO  [main:ZooKeeper@438] - Initiating 
 client connection, connectString=localhost:2181 sessionTimeout=3 
 watcher=org.apache.zookeeper.ZooKeeperMain$MyWatcher@3107eafc
 Welcome to ZooKeeper!
 2015-02-11 15:38:14,471 [myid:] - INFO  
 [main-SendThread(localhost:2181):ClientCnxn$SendThread@975] - Opening socket 
 connection to server localhost/127.0.0.1:2181. Will not attempt to 
 authenticate using SASL (unknown error)
 2015-02-11 15:38:14,479 [myid:] - WARN  
 [main-SendThread(localhost:2181):ClientCnxn$SendThread@1102] - Session 0x0 
 for server null, unexpected error, closing socket connection and attempting 
 reconnect
 java.net.ConnectException: Connection refused
   at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
   at 
 sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:692)
   at 
 org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361)
   at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1081)
 {code}
 PS1 I can connect to ZK at 2888 

[jira] [Created] (ZOOKEEPER-2139) Zookeeper client configuration should not be java system property

2015-03-12 Thread surendra singh lilhore (JIRA)
surendra singh lilhore created ZOOKEEPER-2139:
-

 Summary: Zookeeper client configuration should not be java system 
property
 Key: ZOOKEEPER-2139
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
 Project: ZooKeeper
  Issue Type: Improvement
  Components: java client
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore


I have two ZK client in one JVM, one is secure client and second is normal 
client (For non secure cluster).

zookeeper.sasl.client system property is true by default, because of this 
my second client connection is failing.

We should pass all client configurations in client constructor like HDFS client.

For example :
{code}
public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, 
Configuration conf) throws IOException
{
..
..
}
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (ZOOKEEPER-2126) ClientCnxn.close doesn't wait for eventThread exit which cause out of order log when close Zookeeper client session.

2015-03-12 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore reassigned ZOOKEEPER-2126:
-

Assignee: surendra singh lilhore

 ClientCnxn.close doesn't wait for eventThread exit which cause out of order 
 log when close Zookeeper client session.
 

 Key: ZOOKEEPER-2126
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2126
 Project: ZooKeeper
  Issue Type: Improvement
Reporter: zhihai xu
Assignee: surendra singh lilhore

 We saw the following out of order log when close Zookeeper client session.
 {code}
 2015-02-16 06:01:12,985 INFO org.apache.zookeeper.ZooKeeper: Session: 
 0x24b8df4044005d4 closed
 .
 2015-02-16 06:01:12,995 INFO org.apache.zookeeper.ClientCnxn: EventThread 
 shut down
 {code}
 This logs are very confusing if a new Zookeeper client session is created 
 between these two logs. We may think new Zookeeper client session shutdown it 
 EventThread instead of the old closed Zookeeper client session.
 Should we wait for sendThread and eventThread died in the ClientCnxn.close?
 We can add the following code in ClientCnxn.close.
 {code}
 sendThread.join(timeout);
 eventThread.join(timeout);
 {code}
 with the change, we won't interleave old closed session with new session.
 We can also create a new close API to support this so we won't affect the old 
 code if people use old close API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (ZOOKEEPER-2109) Typo in src/c/src/load_gen.c

2015-02-18 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore reassigned ZOOKEEPER-2109:
-

Assignee: surendra singh lilhore

 Typo in src/c/src/load_gen.c
 

 Key: ZOOKEEPER-2109
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2109
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Emmanuel Bourg
Assignee: surendra singh lilhore
Priority: Trivial

 There is a minor typo in {{src/c/src/load_gen.c}}, Succesfully should be 
 spelled Successfully



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (ZOOKEEPER-2116) zkCli.sh doesn't honor host:port parameter

2015-02-18 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore reassigned ZOOKEEPER-2116:
-

Assignee: surendra singh lilhore

 zkCli.sh doesn't honor host:port parameter
 --

 Key: ZOOKEEPER-2116
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2116
 Project: ZooKeeper
  Issue Type: Bug
  Components: java client, scripts
Affects Versions: 3.4.6
 Environment: Ubuntu 12
Reporter: Maxim Novikov
Assignee: surendra singh lilhore
Priority: Critical

 This doc http://zookeeper.apache.org/doc/r3.1.2/zookeeperStarted.html 
 (Connecting to ZooKeeper section) says:
 Once ZooKeeper is running, you have several options for connection to it:
 Java: Use
 bin/zkCli.sh 127.0.0.1:2181
 In fact, it doesn't work that way. I am running ZooKeeper with a different 
 port to listen to client connections (2888), and this command
 {code}
 bin/zkCli.sh 127.0.0.1:2888
 {code}
 is still trying to connect to 2181.
 {code:title=output|borderStyle=solid}
 Connecting to localhost:2181
 2015-02-11 15:38:14,415 [myid:] - INFO  [main:Environment@100] - Client 
 environment:zookeeper.version=3.4.6-1569965, built on 02/20/2014 09:09 GMT
 2015-02-11 15:38:14,421 [myid:] - INFO  [main:Environment@100] - Client 
 environment:host.name=localhost
 2015-02-11 15:38:14,421 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.version=1.7.0_17
 2015-02-11 15:38:14,424 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.vendor=Oracle Corporation
 2015-02-11 15:38:14,424 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.home=/usr/java/jdk1.7.0_17/jre
 2015-02-11 15:38:14,424 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.class.path=/opt/zookeeper-3.4.6/bin/../build/classes:/opt/zookeeper-3.4.6/bin/../build/lib/*.jar:/opt/zookeeper-3.4.6/bin/../lib/slf4j-log4j12-1.6.1.jar:/opt/zookeeper-3.4.6/bin/../lib/slf4j-api-1.6.1.jar:/opt/zookeeper-3.4.6/bin/../lib/netty-3.7.0.Final.jar:/opt/zookeeper-3.4.6/bin/../lib/log4j-1.2.16.jar:/opt/zookeeper-3.4.6/bin/../lib/jline-0.9.94.jar:/opt/zookeeper-3.4.6/bin/../zookeeper-3.4.6.jar:/opt/zookeeper-3.4.6/bin/../src/java/lib/*.jar:../conf::/usr/share/antlr3/lib/antlr-3.5-complete-no-st3.jar
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.library.path=/usr/java/packages/lib/amd64:/usr/lib64:/lib64:/lib:/usr/lib
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.io.tmpdir=/tmp
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:java.compiler=NA
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:os.name=Linux
 2015-02-11 15:38:14,425 [myid:] - INFO  [main:Environment@100] - Client 
 environment:os.arch=amd64
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:os.version=3.8.0-41-generic
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:user.name=mnovikov
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:user.home=/home/mnovikov
 2015-02-11 15:38:14,426 [myid:] - INFO  [main:Environment@100] - Client 
 environment:user.dir=/opt/zookeeper-3.4.6/bin
 2015-02-11 15:38:14,428 [myid:] - INFO  [main:ZooKeeper@438] - Initiating 
 client connection, connectString=localhost:2181 sessionTimeout=3 
 watcher=org.apache.zookeeper.ZooKeeperMain$MyWatcher@3107eafc
 Welcome to ZooKeeper!
 2015-02-11 15:38:14,471 [myid:] - INFO  
 [main-SendThread(localhost:2181):ClientCnxn$SendThread@975] - Opening socket 
 connection to server localhost/127.0.0.1:2181. Will not attempt to 
 authenticate using SASL (unknown error)
 2015-02-11 15:38:14,479 [myid:] - WARN  
 [main-SendThread(localhost:2181):ClientCnxn$SendThread@1102] - Session 0x0 
 for server null, unexpected error, closing socket connection and attempting 
 reconnect
 java.net.ConnectException: Connection refused
   at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
   at 
 sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:692)
   at 
 org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361)
   at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1081)
 {code}
 PS1 I can connect to ZK at 2888 using ZK Java client from code specifying the 
 correct port with no issues. But CLI seems just to ignore the provided 
 host:port parameter.
 PS2 Tried to run it with the pre-defined ZOOCFGDIR environment variable (to 
 point to the path with the config file where the client port is set to 2888). 
 No luck, same results as shown above.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2109) Typo in src/c/src/load_gen.c

2015-02-18 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore updated ZOOKEEPER-2109:
--
Attachment: ZOOKEEPER-2109.patch

Attached patch, Please review.

 Typo in src/c/src/load_gen.c
 

 Key: ZOOKEEPER-2109
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2109
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Emmanuel Bourg
Assignee: surendra singh lilhore
Priority: Trivial
 Attachments: ZOOKEEPER-2109.patch


 There is a minor typo in {{src/c/src/load_gen.c}}, Succesfully should be 
 spelled Successfully



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2074) Incorrect exit codes for ./zkCli.sh cmd arg

2015-02-05 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308322#comment-14308322
 ] 

surendra singh lilhore commented on ZOOKEEPER-2074:
---

@Rakesh 

Thanks for review

 Incorrect exit codes for ./zkCli.sh cmd arg
 -

 Key: ZOOKEEPER-2074
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2074
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore
Priority: Minor
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-2074_1.patch, ZOOKEEPER-2074_2.patch


 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Created /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Node already exists: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Node does not exist: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Here for failed command it should return exit code 1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2074) Incorrect exit codes for ./zkCli.sh cmd arg

2015-02-01 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14300918#comment-14300918
 ] 

surendra singh lilhore commented on ZOOKEEPER-2074:
---

Thanks [~rakeshr] .

Yes you are correct , I will change the patch and upload soon..

 Incorrect exit codes for ./zkCli.sh cmd arg
 -

 Key: ZOOKEEPER-2074
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2074
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Priority: Minor
 Attachments: ZOOKEEPER-2074_1.patch


 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Created /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Node already exists: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Node does not exist: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Here for failed command it should return exit code 1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2074) Incorrect exit codes for ./zkCli.sh cmd arg

2015-01-21 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285393#comment-14285393
 ] 

surendra singh lilhore commented on ZOOKEEPER-2074:
---

Please can someone review my patch and assign this issue to me..Thank in advance

 Incorrect exit codes for ./zkCli.sh cmd arg
 -

 Key: ZOOKEEPER-2074
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2074
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Priority: Minor
 Attachments: ZOOKEEPER-2074_1.patch


 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Created /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Node already exists: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Node does not exist: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Here for failed command it should return exit code 1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2074) Incorrect exit codes for ./zkCli.sh cmd arg

2014-12-01 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14229575#comment-14229575
 ] 

surendra singh lilhore commented on ZOOKEEPER-2074:
---

Hi Simon, 

 Incorrect exit codes for ./zkCli.sh cmd arg
 -

 Key: ZOOKEEPER-2074
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2074
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Priority: Minor
 Attachments: ZOOKEEPER-2074_1.patch


 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Created /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Node already exists: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Node does not exist: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Here for failed command it should return exit code 1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2074) Incorrect exit codes for ./zkCli.sh cmd arg

2014-12-01 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14229581#comment-14229581
 ] 

surendra singh lilhore commented on ZOOKEEPER-2074:
---

I don’t think it is duplicate, In that jira they are not checking command 
result.
But I want, we should check command result and then do exit with 1 if command 
result is false.


 Incorrect exit codes for ./zkCli.sh cmd arg
 -

 Key: ZOOKEEPER-2074
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2074
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Priority: Minor
 Attachments: ZOOKEEPER-2074_1.patch


 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Created /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Node already exists: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Node does not exist: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Here for failed command it should return exit code 1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (ZOOKEEPER-2074) Incorrect exit codes for ./zkCli.sh cmd arg

2014-11-07 Thread surendra singh lilhore (JIRA)
surendra singh lilhore created ZOOKEEPER-2074:
-

 Summary: Incorrect exit codes for ./zkCli.sh cmd arg
 Key: ZOOKEEPER-2074
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2074
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Priority: Minor


Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
Created /test1
Linux@hghoulaslx406:/ echo $?
0
Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
Node already exists: /test1
Linux@hghoulaslx406:/ echo $?
0
Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
Linux@hghoulaslx406:/ echo $?
0
Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
Node does not exist: /test1
Linux@hghoulaslx406:/ echo $?
0


Here for failed command it should return exit code 1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ZOOKEEPER-2074) Incorrect exit codes for ./zkCli.sh cmd arg

2014-11-07 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201830#comment-14201830
 ] 

surendra singh lilhore commented on ZOOKEEPER-2074:
---

Please assign this Jira to me, I will upload patch soon

 Incorrect exit codes for ./zkCli.sh cmd arg
 -

 Key: ZOOKEEPER-2074
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2074
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Priority: Minor

 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Created /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Node already exists: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Node does not exist: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Here for failed command it should return exit code 1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ZOOKEEPER-2074) Incorrect exit codes for ./zkCli.sh cmd arg

2014-11-07 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore updated ZOOKEEPER-2074:
--
Attachment: ZOOKEEPER-2074_1.patch

I have attached patch , Please review it.

 Incorrect exit codes for ./zkCli.sh cmd arg
 -

 Key: ZOOKEEPER-2074
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2074
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Priority: Minor
 Attachments: ZOOKEEPER-2074_1.patch


 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Created /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Node already exists: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Node does not exist: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Here for failed command it should return exit code 1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (BOOKKEEPER-282) When BK Cluster is not available then also BK Client able to create Ledger in zookeeper.

2012-09-27 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464567#comment-13464567
 ] 

surendra singh lilhore commented on BOOKKEEPER-282:
---

@Uma

yes, this is not a major issue and fixed is available in new versions then we 
can close it.

 When BK Cluster is not available then also BK Client able to create Ledger in 
 zookeeper.
 

 Key: BOOKKEEPER-282
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-282
 Project: Bookkeeper
  Issue Type: Bug
  Components: bookkeeper-client
Affects Versions: 4.0.0
Reporter: surendra singh lilhore
Priority: Minor

 When bookie cluster is not available then also BK client able to create 
 ledger znode in zookeeper. Means this ledger is not useful for Bookkeeper 
 server.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (BOOKKEEPER-387) BookKeeper Upgrade is not working.

2012-09-06 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13450348#comment-13450348
 ] 

surendra singh lilhore commented on BOOKKEEPER-387:
---

@Sijie

Thanks

+1, it’s good.

This test case is able reproduce issue w/o my changes.


 BookKeeper Upgrade is not working.
 --

 Key: BOOKKEEPER-387
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-387
 Project: Bookkeeper
  Issue Type: Bug
  Components: bookkeeper-server
Affects Versions: 4.1.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore
 Fix For: 4.1.0, 4.2.0

 Attachments: BOOKKEEPER-387_1.patch, BOOKKEEPER-387.diff, 
 BOOKKEEPER-387.patch


 I am trying to upgrade BK from 4.1.0 to 4.2.0, but it will log as Directory 
 is current, no need to upgrade” even then it will continue and fail.
 and throwing following exception.
 {code}
 2012-09-03 17:25:12,468 - ERROR - [main:FileSystemUpgrade@229] - Error moving 
 upgraded directories into place 
 /home/BK4.1/bookkeeper1/ledger/upgradeTmp.2433718456734190 - 
 /home/BK4.1/bookkeeper1/ledger/current
 org.apache.commons.io.FileExistsException: Destination 
 '/home/BK4.1/bookkeeper1/ledger/current' already exists
 at org.apache.commons.io.FileUtils.moveDirectory(FileUtils.java:2304)
 at 
 org.apache.bookkeeper.bookie.FileSystemUpgrade.upgrade(FileSystemUpgrade.java:225)
 at 
 org.apache.bookkeeper.bookie.FileSystemUpgrade.main(FileSystemUpgrade.java:367)
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (BOOKKEEPER-387) BookKeeper Upgrade is not working.

2012-09-05 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448660#comment-13448660
 ] 

surendra singh lilhore commented on BOOKKEEPER-387:
---

@sijie
 
Thanks

yes, you are rite.

i will generate new path and attach here.

 BookKeeper Upgrade is not working.
 --

 Key: BOOKKEEPER-387
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-387
 Project: Bookkeeper
  Issue Type: Bug
  Components: bookkeeper-server
Reporter: surendra singh lilhore
 Attachments: BOOKKEEPER-387.patch


 I am trying to upgrade BK from 4.1.0 to 4.2.0, but it will log as Directory 
 is current, no need to upgrade” even then it will continue and fail.
 and throwing following exception.
 {code}
 2012-09-03 17:25:12,468 - ERROR - [main:FileSystemUpgrade@229] - Error moving 
 upgraded directories into place 
 /home/BK4.1/bookkeeper1/ledger/upgradeTmp.2433718456734190 - 
 /home/BK4.1/bookkeeper1/ledger/current
 org.apache.commons.io.FileExistsException: Destination 
 '/home/BK4.1/bookkeeper1/ledger/current' already exists
 at org.apache.commons.io.FileUtils.moveDirectory(FileUtils.java:2304)
 at 
 org.apache.bookkeeper.bookie.FileSystemUpgrade.upgrade(FileSystemUpgrade.java:225)
 at 
 org.apache.bookkeeper.bookie.FileSystemUpgrade.main(FileSystemUpgrade.java:367)
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (BOOKKEEPER-387) BookKeeper Upgrade is not working.

2012-09-05 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448741#comment-13448741
 ] 

surendra singh lilhore commented on BOOKKEEPER-387:
---

I have attached updated patch.

 BookKeeper Upgrade is not working.
 --

 Key: BOOKKEEPER-387
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-387
 Project: Bookkeeper
  Issue Type: Bug
  Components: bookkeeper-server
Reporter: surendra singh lilhore
 Attachments: BOOKKEEPER-387_1.patch, BOOKKEEPER-387.patch


 I am trying to upgrade BK from 4.1.0 to 4.2.0, but it will log as Directory 
 is current, no need to upgrade” even then it will continue and fail.
 and throwing following exception.
 {code}
 2012-09-03 17:25:12,468 - ERROR - [main:FileSystemUpgrade@229] - Error moving 
 upgraded directories into place 
 /home/BK4.1/bookkeeper1/ledger/upgradeTmp.2433718456734190 - 
 /home/BK4.1/bookkeeper1/ledger/current
 org.apache.commons.io.FileExistsException: Destination 
 '/home/BK4.1/bookkeeper1/ledger/current' already exists
 at org.apache.commons.io.FileUtils.moveDirectory(FileUtils.java:2304)
 at 
 org.apache.bookkeeper.bookie.FileSystemUpgrade.upgrade(FileSystemUpgrade.java:225)
 at 
 org.apache.bookkeeper.bookie.FileSystemUpgrade.main(FileSystemUpgrade.java:367)
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (BOOKKEEPER-387) BookKeeper Upgrade is not working.

2012-09-04 Thread surendra singh lilhore (JIRA)
surendra singh lilhore created BOOKKEEPER-387:
-

 Summary: BookKeeper Upgrade is not working.
 Key: BOOKKEEPER-387
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-387
 Project: Bookkeeper
  Issue Type: Bug
  Components: bookkeeper-server
Reporter: surendra singh lilhore


I am trying to upgrade BK from 4.1.0 to 4.2.0, but it will log as Directory is 
current, no need to upgrade” even then it will continue and fail.
and throwing following exception.
{code}
2012-09-03 17:25:12,468 - ERROR - [main:FileSystemUpgrade@229] - Error moving 
upgraded directories into place 
/home/BK4.1/bookkeeper1/ledger/upgradeTmp.2433718456734190 - 
/home/BK4.1/bookkeeper1/ledger/current
org.apache.commons.io.FileExistsException: Destination 
'/home/BK4.1/bookkeeper1/ledger/current' already exists
at org.apache.commons.io.FileUtils.moveDirectory(FileUtils.java:2304)
at 
org.apache.bookkeeper.bookie.FileSystemUpgrade.upgrade(FileSystemUpgrade.java:225)
at 
org.apache.bookkeeper.bookie.FileSystemUpgrade.main(FileSystemUpgrade.java:367)
{code}


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (BOOKKEEPER-387) BookKeeper Upgrade is not working.

2012-09-04 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447642#comment-13447642
 ] 

surendra singh lilhore commented on BOOKKEEPER-387:
---

@sijie
Thanks for looking this issue.
But I have one question.

If in 4.1 and 4.2 directory layout same then after logging this log upgrade 
process should stop but it will continue and fail when UpgradeTemp Dir move to 
Current Dir.


{code}
 if (version == Cookie.CURRENT_COOKIE_LAYOUT_VERSION){
LOG.info(Directory is current, no need to upgrade);
 }
{code}

 BookKeeper Upgrade is not working.
 --

 Key: BOOKKEEPER-387
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-387
 Project: Bookkeeper
  Issue Type: Bug
  Components: bookkeeper-server
Reporter: surendra singh lilhore

 I am trying to upgrade BK from 4.1.0 to 4.2.0, but it will log as Directory 
 is current, no need to upgrade” even then it will continue and fail.
 and throwing following exception.
 {code}
 2012-09-03 17:25:12,468 - ERROR - [main:FileSystemUpgrade@229] - Error moving 
 upgraded directories into place 
 /home/BK4.1/bookkeeper1/ledger/upgradeTmp.2433718456734190 - 
 /home/BK4.1/bookkeeper1/ledger/current
 org.apache.commons.io.FileExistsException: Destination 
 '/home/BK4.1/bookkeeper1/ledger/current' already exists
 at org.apache.commons.io.FileUtils.moveDirectory(FileUtils.java:2304)
 at 
 org.apache.bookkeeper.bookie.FileSystemUpgrade.upgrade(FileSystemUpgrade.java:225)
 at 
 org.apache.bookkeeper.bookie.FileSystemUpgrade.main(FileSystemUpgrade.java:367)
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (BOOKKEEPER-387) BookKeeper Upgrade is not working.

2012-09-04 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/BOOKKEEPER-387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore updated BOOKKEEPER-387:
--

Attachment: BOOKKEEPER-387.patch

Attached patch for issue

 BookKeeper Upgrade is not working.
 --

 Key: BOOKKEEPER-387
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-387
 Project: Bookkeeper
  Issue Type: Bug
  Components: bookkeeper-server
Reporter: surendra singh lilhore
 Attachments: BOOKKEEPER-387.patch


 I am trying to upgrade BK from 4.1.0 to 4.2.0, but it will log as Directory 
 is current, no need to upgrade” even then it will continue and fail.
 and throwing following exception.
 {code}
 2012-09-03 17:25:12,468 - ERROR - [main:FileSystemUpgrade@229] - Error moving 
 upgraded directories into place 
 /home/BK4.1/bookkeeper1/ledger/upgradeTmp.2433718456734190 - 
 /home/BK4.1/bookkeeper1/ledger/current
 org.apache.commons.io.FileExistsException: Destination 
 '/home/BK4.1/bookkeeper1/ledger/current' already exists
 at org.apache.commons.io.FileUtils.moveDirectory(FileUtils.java:2304)
 at 
 org.apache.bookkeeper.bookie.FileSystemUpgrade.upgrade(FileSystemUpgrade.java:225)
 at 
 org.apache.bookkeeper.bookie.FileSystemUpgrade.main(FileSystemUpgrade.java:367)
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (BOOKKEEPER-326) DeadLock during ledger recovery

2012-08-13 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/BOOKKEEPER-326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore updated BOOKKEEPER-326:
--

Attachment: BK326.png

 DeadLock during ledger recovery 
 

 Key: BOOKKEEPER-326
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-326
 Project: Bookkeeper
  Issue Type: Bug
Affects Versions: 4.1.0
Reporter: Vinay
Assignee: Rakesh R
Priority: Blocker
 Fix For: 4.2.0

 Attachments: BK326.png, BK_DeadLock.log, BOOKKEEPER-326.1.patch, 
 BOOKKEEPER-326.2.patch, BOOKKEEPER-326.3.patch, BOOKKEEPER-326.part2.diff, 
 BOOKKEEPER-326.patch


 Deadlock found during ledger recovery. please find the attached thread dump.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (BOOKKEEPER-326) DeadLock during ledger recovery

2012-08-13 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13433041#comment-13433041
 ] 

surendra singh lilhore commented on BOOKKEEPER-326:
---

@Ivan

Jcarder Report without applying the patch : 


Opening for reading: D:\out\jcarder_contexts.db
Opening for reading: D:\out\jcarder_events.db

Loaded from database files:
   Nodes: 843
   Edges: 774 (excluding 10449 duplicated)

Cycle analysis result:
   Cycles:  1
   Edges in cycles: 2
   Nodes in cycles: 2
   Max cycle depth: 2
   Max graph depth: 3

Ignoring 0 gated cycle(s).
Ignoring 0 almost identical cycle(s).

===

Here one cycle is found.
I have attached one BK326.PNG file which show the graphically Deadlock cycle.

 DeadLock during ledger recovery 
 

 Key: BOOKKEEPER-326
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-326
 Project: Bookkeeper
  Issue Type: Bug
Affects Versions: 4.1.0
Reporter: Vinay
Assignee: Rakesh R
Priority: Blocker
 Fix For: 4.2.0

 Attachments: BK326.png, BK_DeadLock.log, BOOKKEEPER-326.1.patch, 
 BOOKKEEPER-326.2.patch, BOOKKEEPER-326.3.patch, BOOKKEEPER-326.part2.diff, 
 BOOKKEEPER-326.patch


 Deadlock found during ledger recovery. please find the attached thread dump.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (BOOKKEEPER-326) DeadLock during ledger recovery

2012-08-10 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13432698#comment-13432698
 ] 

surendra singh lilhore commented on BOOKKEEPER-326:
---

@Ivan
{quote}
I think it's near impossible to automatically and reliably trigger this 
deadlock, as it's reliant on a delay occurring between bootstrap.connect, and 
adding the FutureListener. I think I could get it to trigger fairly reliably 
with some hacks in the code (no suitable for putting into production), so you 
you submit a patch with the fix, forgetting about the test case, run with the 
hack to ensure it hits, apply your patch, and then run with the hack again to 
verify the deadlock does not occur.
{quote}

The following scenario was tested by applying the patch and JCarder agent 
enabled (for deadlock detection).

1.Ledger is created and entries are writter to 3 bookies.
2.one of bookie is killed. (say this bookie is not the first bookie in the 
ensemble)
3.New bookie started.
4.now openLedger() call is made to recover the ledger. as part of this 
readLastConfirmed request will be added each of the bookies with callback 
ReadLastConfirmedOp.readEntryComplete which is synchronized.
5.First callback came from first bookie which is alive in separate thread and 
entered ReadLastConfirmedOp.readEntryComplete() and processing.
6.Another Callback came for the failed bookie from connect() method by holding 
the lock of PerChannelBookieClient instance of failed bookie, and trying to 
invoke the same callback, but BLOCKED. ( Here to invoke the listener in same 
thread, need to wait before future.addListener(..) by putting debug point)
7.As part of first call back, doRecoveryRead() will put one PendingReadOp 
request for asyncread. If this PendingReadOp selects same 
PerChannelBookieClient of failed bookie for read, then it will enter to 
deadlock. (To reproduce, bookieIndex variable can be changed to index of the 
failed bookie in PendingReadOp.sendRead(..))

JCarder Output:
==
Loaded from database files:
   Nodes: 4112
   Edges: 5946 (excluding 5786 duplicated)

Cycle analysis result:
   Cycles:  0
   Edges in cycles: 0
   Nodes in cycles: 0
   Max cycle depth: 0
   Max graph depth: 2

Ignoring 0 gated cycle(s).
No cycles found!



 DeadLock during ledger recovery 
 

 Key: BOOKKEEPER-326
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-326
 Project: Bookkeeper
  Issue Type: Bug
Affects Versions: 4.1.0
Reporter: Vinay
Assignee: Rakesh R
Priority: Blocker
 Fix For: 4.2.0

 Attachments: BK_DeadLock.log, BOOKKEEPER-326.1.patch, 
 BOOKKEEPER-326.2.patch, BOOKKEEPER-326.3.patch, BOOKKEEPER-326.part2.diff, 
 BOOKKEEPER-326.patch


 Deadlock found during ledger recovery. please find the attached thread dump.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (BOOKKEEPER-318) Spelling mistake in MultiCallback log message.

2012-07-26 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422947#comment-13422947
 ] 

surendra singh lilhore commented on BOOKKEEPER-318:
---

Thanks Sijie

 Spelling mistake in MultiCallback log message.
 --

 Key: BOOKKEEPER-318
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-318
 Project: Bookkeeper
  Issue Type: Improvement
  Components: bookkeeper-server
Affects Versions: 4.2.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore
Priority: Trivial
 Fix For: 4.2.0

 Attachments: BOOKKEEPER-318.patch


 {code}
 @Override
 public void processResult(int rc, String path, Object ctx) {
 if (rc != successRc) {
 LOG.error(Error in multi callback :  + rc);
 exceptions.add(rc);
 }
 tick();
 }
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (BOOKKEEPER-318) Spelling mistake in MultiCallback log message.

2012-06-26 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/BOOKKEEPER-318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore updated BOOKKEEPER-318:
--

Attachment: BOOKKEEPER-318.patch

Attaching patch for issue

 Spelling mistake in MultiCallback log message.
 --

 Key: BOOKKEEPER-318
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-318
 Project: Bookkeeper
  Issue Type: Improvement
  Components: bookkeeper-server
Affects Versions: 4.2.0
Reporter: surendra singh lilhore
Priority: Trivial
 Attachments: BOOKKEEPER-318.patch


 {code}
 @Override
 public void processResult(int rc, String path, Object ctx) {
 if (rc != successRc) {
 LOG.error(Error in multi callback :  + rc);
 exceptions.add(rc);
 }
 tick();
 }
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Resolved] (ZOOKEEPER-1487) if log4j.properties configuration parameters is not override by system properties then zookeeper not able to create log file.

2012-06-18 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore resolved ZOOKEEPER-1487.
---

Resolution: Invalid

Invalid

 if log4j.properties configuration parameters is not override  by system 
 properties then zookeeper not able to  create log file.
 ---

 Key: ZOOKEEPER-1487
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1487
 Project: ZooKeeper
  Issue Type: Bug
  Components: server
Reporter: surendra singh lilhore

 In [ZOOKEEPER-980|https://issues.apache.org/jira/browse/ZOOKEEPER-980] for 
 log4j.properties provide some  properties that may be overridden using system 
 properties. 
 For example
 JVMFLAGS=-Dzookeeper.root.logger=DEBUG,CONSOLE,ROLLINGFILE 
 -Dzookeeper.console.threshold=DEBUG bin/zkServer.sh start
 But if we not override these property using system properties then zookeeper 
 not able to create log file means these property not taking default value.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Created] (ZOOKEEPER-1487) if log4j.properties configuration parameters is not override by system properties then zookeeper not able to create log file.

2012-06-14 Thread surendra singh lilhore (JIRA)
surendra singh lilhore created ZOOKEEPER-1487:
-

 Summary: if log4j.properties configuration parameters is not 
override  by system properties then zookeeper not able to  create log file.
 Key: ZOOKEEPER-1487
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1487
 Project: ZooKeeper
  Issue Type: Bug
  Components: server
Reporter: surendra singh lilhore


In [ZOOKEEPER-980|https://issues.apache.org/jira/browse/ZOOKEEPER-980] for 
log4j.properties provide some  properties that may be overridden using system 
properties. 
For example
JVMFLAGS=-Dzookeeper.root.logger=DEBUG,CONSOLE,ROLLINGFILE 
-Dzookeeper.console.threshold=DEBUG bin/zkServer.sh start
But if we not override these property using system properties then zookeeper 
not able to create log file means these property not taking default value.  


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (BOOKKEEPER-282) When BK Cluster is not available then also BK Client able to create Ledger in zookeeper.

2012-06-04 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/BOOKKEEPER-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore updated BOOKKEEPER-282:
--

Affects Version/s: 4.0.0

 When BK Cluster is not available then also BK Client able to create Ledger in 
 zookeeper.
 

 Key: BOOKKEEPER-282
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-282
 Project: Bookkeeper
  Issue Type: Bug
  Components: bookkeeper-client
Affects Versions: 4.0.0
Reporter: surendra singh lilhore
Priority: Minor

 When bookie cluster is not available then also BK client able to create 
 ledger znode in zookeeper. Means this ledger is not useful for Bookkeeper 
 server.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (BOOKKEEPER-282) When BK Cluster is not available then also BK Client able to create Ledger in zookeeper.

2012-06-04 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13289135#comment-13289135
 ] 

surendra singh lilhore commented on BOOKKEEPER-282:
---

yes, i am using BK 4.0.0 version. i will update the affected version.

 When BK Cluster is not available then also BK Client able to create Ledger in 
 zookeeper.
 

 Key: BOOKKEEPER-282
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-282
 Project: Bookkeeper
  Issue Type: Bug
  Components: bookkeeper-client
Affects Versions: 4.0.0
Reporter: surendra singh lilhore
Priority: Minor

 When bookie cluster is not available then also BK client able to create 
 ledger znode in zookeeper. Means this ledger is not useful for Bookkeeper 
 server.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Created] (BOOKKEEPER-282) When BK Cluster is not available then also BK Client able to create Ledger in zookeeper.

2012-06-01 Thread surendra singh lilhore (JIRA)
surendra singh lilhore created BOOKKEEPER-282:
-

 Summary: When BK Cluster is not available then also BK Client able 
to create Ledger in zookeeper.
 Key: BOOKKEEPER-282
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-282
 Project: Bookkeeper
  Issue Type: Bug
  Components: bookkeeper-client
Reporter: surendra singh lilhore
Priority: Minor


When bookie cluster is not available then also BK client able to create ledger 
znode in zookeeper. Means this ledger is not useful for Bookkeeper server.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (BOOKKEEPER-244) BookKeeperJournalManager: NN startup is failing, when tries to recoverUnfinalizedSegments() a bad inProgress_ ZNodes

2012-05-14 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13274526#comment-13274526
 ] 

surendra singh lilhore commented on BOOKKEEPER-244:
---

In one more scenario BKJM fail to recover bad inProgress_ZNodes and throwing 
following Exception:

Say, NN has successfully done finalizeLogSegment() and unfortunately (kill the 
namenode or ZK cluster down) before deleting the inprogress  Znode. The 
inProgress_zNode would be left in the ZooKeeper. On next NN start up, it will 
again tries to perform recovery and throwing the following exception.
{noformat}
java.io.IOException: Node 
/NN/ledgers/edits_39_76 already exists but data 
doesn't match
at 
org.apache.hadoop.contrib.bkjournal.BookKeeperJournalManager.finalizeLogSegment(BookKeeperJournalManager.java:306)
at 
org.apache.hadoop.contrib.bkjournal.BookKeeperJournalManager.recoverUnfinalizedSegments(BookKeeperJournalManager.java:426)
at 
org.apache.hadoop.hdfs.server.namenode.JournalSet$6.apply(JournalSet.java:551)
at 
org.apache.hadoop.hdfs.server.namenode.JournalSet.mapJournalsAndReportErrors(JournalSet.java:322)
at 
org.apache.hadoop.hdfs.server.namenode.JournalSet.recoverUnfinalizedSegments(JournalSet.java:548)
at 
org.apache.hadoop.hdfs.server.namenode.FSEditLog.recoverUnclosedStreams(FSEditLog.java:1134)
at 
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.startActiveServices(FSNamesystem.java:598)
at 
org.apache.hadoop.hdfs.server.namenode.NameNode$NameNodeHAContext.startActiveServices(NameNode.java:1287)
at 
org.apache.hadoop.hdfs.server.namenode.ha.ActiveState.enterState(ActiveState.java:61)
at 
org.apache.hadoop.hdfs.server.namenode.ha.HAState.setStateInternal(HAState.java:63)
at 
org.apache.hadoop.hdfs.server.namenode.ha.StandbyState.setState(StandbyState.java:49)
at 
org.apache.hadoop.hdfs.server.namenode.NameNode.transitionToActive(NameNode.java:1219)
at 
org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.transitionToActive(NameNodeRpcServer.java:978)
at 
org.apache.hadoop.ha.protocolPB.HAServiceProtocolServerSideTranslatorPB.transitionToActive(HAServiceProtocolServerSideTranslatorPB.java:107)
at 
org.apache.hadoop.ha.proto.HAServiceProtocolProtos$HAServiceProtocolService$2.callBlockingMethod(HAServiceProtocolProtos.java:3633)
at 
org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:427)
at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:916)
at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:1692)
at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:1688)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:396)
at 
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1232)
at org.apache.hadoop.ipc.Server$Handler.run(Server.java:1686)
{noformat}

Here, I feel throw exception and will delete the old inprogress file because I 
have seen after restart the namenode /NamenodeNode/ledgers 
contain two inprogress znode.

 BookKeeperJournalManager: NN startup is failing, when tries to 
 recoverUnfinalizedSegments() a bad inProgress_ ZNodes
 

 Key: BOOKKEEPER-244
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-244
 Project: Bookkeeper
  Issue Type: Bug
Reporter: Rakesh R
Assignee: Ivan Kelly

 Say, the InProgress_000X node is corrupted due to not writing the 
 data(version, ledgerId, firstTxId) to this inProgress_000X znode. Namenode 
 startup has the logic to recover all the unfinalized segments, here will try 
 to read the segment and getting shutdown.
 {noformat}
 EditLogLedgerMetadata.java:
 static EditLogLedgerMetadata read(ZooKeeper zkc, String path)
   throws IOException, KeeperException.NoNodeException  {
   byte[] data = zkc.getData(path, false, null);
   String[] parts = new String(data).split(;);
   if (parts.length == 3)
  reading inprogress metadata
   else if (parts.length == 4)
  reading inprogress metadata
   else
 throw new IOException(Invalid ledger entry, 
   + new String(data));
   }
 {noformat}
 Scenario:- Leaving bad inProgress_000X node ?
 Assume BKJM has created the inProgress_000X zNode and ZK is not available 
 when trying to add the metadata. Now, inProgress_000X ends up with partial 
 information.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 

[jira] [Created] (BOOKKEEPER-242) Bookkeeper not able to connect other zookeeper when shutdown the zookeeper server where the BK has connected.

2012-05-08 Thread surendra singh lilhore (JIRA)
surendra singh lilhore created BOOKKEEPER-242:
-

 Summary: Bookkeeper not able to connect other zookeeper when 
shutdown the zookeeper server where the BK has connected.
 Key: BOOKKEEPER-242
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-242
 Project: Bookkeeper
  Issue Type: Bug
  Components: bookkeeper-server
Affects Versions: 4.0.0
Reporter: surendra singh lilhore


Scenario : 
1. Start three zookeeper cluster.
2. start three bookKeeper.
3. shutdown zookeeper server where bookkeeper has connected.

Expected Result:
bookkeeper should be able to connect other zookeeper

Actual Result :
All three bookkeepers retry to connect zookeeper node which has been shutdown.



BookKeeper log for Retry :
{noformat)
2012-04-25 13:35:15,319 - WARN  [main-EventThread:Bookie$2@456] - ZK client has 
been disconnected to the ZK server!
2012-04-25 13:35:17,194 - INFO  
[main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@933] - Opening 
socket connection to server HOST-10-18-40-91/10.18.40.91:2181
2012-04-25 13:35:17,196 - WARN  
[main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@1063] - Session 
0x136e87b50ce0002 for server null, unexpected error, closing socket connection 
and attempting reconnect
java.net.ConnectException: Connection refused
at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:567)
at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:264)
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1041)
2012-04-25 13:35:19,125 - INFO  
[main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@933] - Opening 
socket connection to server HOST-10-18-40-91/10.18.40.91:2181
2012-04-25 13:35:19,126 - WARN  
[main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@1063] - Session 
0x136e87b50ce0002 for server null, unexpected error, closing socket connection 
and attempting reconnect
java.net.ConnectException: Connection refused
at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:567)
at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:264)
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1041)
2012-04-25 13:35:20,276 - INFO  
[main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@933] - Opening 
socket connection to server HOST-10-18-40-91/10.18.40.91:2181
2012-04-25 13:35:20,277 - WARN  
[main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@1063] - Session 
0x136e87b50ce0002 for server null, unexpected error, closing socket connection 
and attempting reconnect
java.net.ConnectException: Connection refused
at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:567)
at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:264)
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1041)

{noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (BOOKKEEPER-242) Bookkeeper not able to connect other zookeeper when shutdown the zookeeper server where the BK has connected.

2012-05-08 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/BOOKKEEPER-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore updated BOOKKEEPER-242:
--

Description: 
Scenario : 
1. Start three zookeeper cluster.
2. start three bookKeeper.
3. shutdown zookeeper server where bookkeeper has connected.

Expected Result:
bookkeeper should be able to connect other zookeeper

Actual Result :
All three bookkeepers retry to connect zookeeper node which has been shutdown.



BookKeeper log for Retry :

{noformat} 
2012-04-25 13:35:15,319 - WARN  [main-EventThread:Bookie$2@456] - ZK client has 
been disconnected to the ZK server!
2012-04-25 13:35:17,194 - INFO  
[main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@933] - Opening 
socket connection to server HOST-10-18-40-91/10.18.40.91:2181
2012-04-25 13:35:17,196 - WARN  
[main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@1063] - Session 
0x136e87b50ce0002 for server null, unexpected error, closing socket connection 
and attempting reconnect
java.net.ConnectException: Connection refused
at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:567)
at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:264)
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1041)
2012-04-25 13:35:19,125 - INFO  
[main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@933] - Opening 
socket connection to server HOST-10-18-40-91/10.18.40.91:2181
2012-04-25 13:35:19,126 - WARN  
[main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@1063] - Session 
0x136e87b50ce0002 for server null, unexpected error, closing socket connection 
and attempting reconnect
java.net.ConnectException: Connection refused
at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:567)
at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:264)
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1041)
2012-04-25 13:35:20,276 - INFO  
[main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@933] - Opening 
socket connection to server HOST-10-18-40-91/10.18.40.91:2181
2012-04-25 13:35:20,277 - WARN  
[main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@1063] - Session 
0x136e87b50ce0002 for server null, unexpected error, closing socket connection 
and attempting reconnect
java.net.ConnectException: Connection refused
at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:567)
at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:264)
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1041)

{noformat} 

  was:
Scenario : 
1. Start three zookeeper cluster.
2. start three bookKeeper.
3. shutdown zookeeper server where bookkeeper has connected.

Expected Result:
bookkeeper should be able to connect other zookeeper

Actual Result :
All three bookkeepers retry to connect zookeeper node which has been shutdown.



BookKeeper log for Retry :
{noformat)
2012-04-25 13:35:15,319 - WARN  [main-EventThread:Bookie$2@456] - ZK client has 
been disconnected to the ZK server!
2012-04-25 13:35:17,194 - INFO  
[main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@933] - Opening 
socket connection to server HOST-10-18-40-91/10.18.40.91:2181
2012-04-25 13:35:17,196 - WARN  
[main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@1063] - Session 
0x136e87b50ce0002 for server null, unexpected error, closing socket connection 
and attempting reconnect
java.net.ConnectException: Connection refused
at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:567)
at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:264)
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1041)
2012-04-25 13:35:19,125 - INFO  
[main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@933] - Opening 
socket connection to server HOST-10-18-40-91/10.18.40.91:2181
2012-04-25 13:35:19,126 - WARN  
[main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@1063] - Session 
0x136e87b50ce0002 for server null, unexpected error, closing socket connection 
and attempting reconnect
java.net.ConnectException: Connection refused
at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:567)
at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:264)
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1041)

[jira] [Commented] (BOOKKEEPER-242) Bookkeeper not able to connect other zookeeper when shutdown the zookeeper server where the BK has connected.

2012-05-08 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270376#comment-13270376
 ] 

surendra singh lilhore commented on BOOKKEEPER-242:
---

Thanks for looking into this.

@Sijie
I have 3 ZK servers and configured like:
zkServers=10.18.40.155:2181,10.18.40.155:2182,10.18.40.155:2183

-Surendra

 Bookkeeper not able to connect other zookeeper when shutdown the zookeeper 
 server where the BK has connected.
 -

 Key: BOOKKEEPER-242
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-242
 Project: Bookkeeper
  Issue Type: Bug
  Components: bookkeeper-server
Affects Versions: 4.0.0
Reporter: surendra singh lilhore

 Scenario : 
 1. Start three zookeeper cluster.
 2. start three bookKeeper.
 3. shutdown zookeeper server where bookkeeper has connected.
 Expected Result:
 bookkeeper should be able to connect other zookeeper
 Actual Result :
 All three bookkeepers retry to connect zookeeper node which has been shutdown.
 BookKeeper log for Retry :
 {noformat} 
 2012-04-25 13:35:15,319 - WARN  [main-EventThread:Bookie$2@456] - ZK client 
 has been disconnected to the ZK server!
 2012-04-25 13:35:17,194 - INFO  
 [main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@933] - Opening 
 socket connection to server HOST-10-18-40-91/10.18.40.91:2181
 2012-04-25 13:35:17,196 - WARN  
 [main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@1063] - Session 
 0x136e87b50ce0002 for server null, unexpected error, closing socket 
 connection and attempting reconnect
 java.net.ConnectException: Connection refused
   at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
   at 
 sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:567)
   at 
 org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:264)
   at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1041)
 2012-04-25 13:35:19,125 - INFO  
 [main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@933] - Opening 
 socket connection to server HOST-10-18-40-91/10.18.40.91:2181
 2012-04-25 13:35:19,126 - WARN  
 [main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@1063] - Session 
 0x136e87b50ce0002 for server null, unexpected error, closing socket 
 connection and attempting reconnect
 java.net.ConnectException: Connection refused
   at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
   at 
 sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:567)
   at 
 org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:264)
   at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1041)
 2012-04-25 13:35:20,276 - INFO  
 [main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@933] - Opening 
 socket connection to server HOST-10-18-40-91/10.18.40.91:2181
 2012-04-25 13:35:20,277 - WARN  
 [main-SendThread(HOST-10-18-40-91:2181):ClientCnxn$SendThread@1063] - Session 
 0x136e87b50ce0002 for server null, unexpected error, closing socket 
 connection and attempting reconnect
 java.net.ConnectException: Connection refused
   at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
   at 
 sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:567)
   at 
 org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:264)
   at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1041)
 {noformat} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (BOOKKEEPER-219) Active Namenode shutdown after throwing java.io.IOException: BookKeeper error during close error.

2012-05-03 Thread surendra singh lilhore (JIRA)

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13267425#comment-13267425
 ] 

surendra singh lilhore commented on BOOKKEEPER-219:
---

@uma : yes why not.

Thanks uma.

you spend your valuable time for see this issue and link with HDFS-3058.

 Active Namenode shutdown after throwing java.io.IOException: BookKeeper error 
 during close error.
 -

 Key: BOOKKEEPER-219
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-219
 Project: Bookkeeper
  Issue Type: Bug
  Components: bookkeeper-client
Affects Versions: 4.0.0
 Environment: 10.18.40.45: Active namenode
 10.18.40.91: Backup namenode
 10.18.52.157 : one zookeeper, three bookkeeper
Reporter: surendra singh lilhore

 scenario:
 1. I am started Active namenode and backup namenode. 
 2. write some file. 
 Result:
 ANN throwing following Error
 {noformat} 
 2012-04-18 10:46:04,001 WARN org.apache.bookkeeper.client.LedgerHandle: 
 Conditional write failed: BADVERSION
 2012-04-18 10:46:04,001 FATAL 
 org.apache.hadoop.hdfs.server.namenode.FSEditLog: Error: finalize log segment 
 1, 8 failed for required journal 
 (JournalAndStream(mgr=org.apache.hadoop.contrib.bkjournal.BookKeeperJournalManager@1ec3362f,
  
 stream=org.apache.hadoop.contrib.bkjournal.BookKeeperEditLogOutputStream@221a5770))
 java.io.IOException: BookKeeper error during close
   at 
 org.apache.hadoop.contrib.bkjournal.BookKeeperEditLogOutputStream.close(BookKeeperEditLogOutputStream.java:90)
   at 
 org.apache.hadoop.hdfs.server.namenode.JournalSet$JournalAndStream.closeStream(JournalSet.java:79)
   at 
 org.apache.hadoop.hdfs.server.namenode.JournalSet$2.apply(JournalSet.java:180)
   at 
 org.apache.hadoop.hdfs.server.namenode.JournalSet.mapJournalsAndReportErrors(JournalSet.java:322)
   at 
 org.apache.hadoop.hdfs.server.namenode.JournalSet.finalizeLogSegment(JournalSet.java:176)
   at 
 org.apache.hadoop.hdfs.server.namenode.FSEditLog.endCurrentLogSegment(FSEditLog.java:925)
   at 
 org.apache.hadoop.hdfs.server.namenode.FSEditLog.rollEditLog(FSEditLog.java:855)
   at 
 org.apache.hadoop.hdfs.server.namenode.FSImage.rollEditLog(FSImage.java:971)
   at 
 org.apache.hadoop.hdfs.server.namenode.FSNamesystem.rollEditLog(FSNamesystem.java:4092)
   at 
 org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.rollEditLog(NameNodeRpcServer.java:714)
   at 
 org.apache.hadoop.hdfs.protocolPB.NamenodeProtocolServerSideTranslatorPB.rollEditLog(NamenodeProtocolServerSideTranslatorPB.java:113)
   at 
 org.apache.hadoop.hdfs.protocol.proto.NamenodeProtocolProtos$NamenodeProtocolService$2.callBlockingMethod(NamenodeProtocolProtos.java:8068)
   at 
 org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:417)
   at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:891)
   at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:1661)
   at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:1657)
   at java.security.AccessController.doPrivileged(Native Method)
   at javax.security.auth.Subject.doAs(Subject.java:396)
   at 
 org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1205)
   at org.apache.hadoop.ipc.Server$Handler.run(Server.java:1655)
 Caused by: org.apache.bookkeeper.client.BKException$ZKException
   at org.apache.bookkeeper.client.BKException.create(BKException.java:64)
   at 
 org.apache.bookkeeper.client.LedgerHandle.close(LedgerHandle.java:216)
   at 
 org.apache.hadoop.contrib.bkjournal.BookKeeperEditLogOutputStream.close(BookKeeperEditLogOutputStream.java:86)
   ... 19 more
 {noformat} 
 BNN throwing following Error
 {noformat} 
 2012-04-18 10:39:09,421 ERROR org.apache.bookkeeper.client.PendingReadOp: 
 Error: No such entry while reading entry: 1 ledgerId: 5 from bookie: 
 /10.18.52.157:3183
 2012-04-18 10:39:09,423 ERROR org.apache.bookkeeper.client.PendingReadOp: 
 Error: No such entry while reading entry: 1 ledgerId: 5 from bookie: 
 /10.18.52.157:3181
 2012-04-18 10:39:09,457 WARN 
 org.apache.hadoop.hdfs.server.namenode.ha.EditLogTailer: Edits tailer failed 
 to find any streams. Will try again later.
 java.io.IOException: No ledger for fromTxnId -12344 found.
   at 
 org.apache.hadoop.contrib.bkjournal.BookKeeperJournalManager.getInputStream(BookKeeperJournalManager.java:329)
   at 
 org.apache.hadoop.hdfs.server.namenode.JournalSet.getInputStream(JournalSet.java:246)
   at 
 org.apache.hadoop.hdfs.server.namenode.FSEditLog.selectInputStreams(FSEditLog.java:1100)
   at 
 org.apache.hadoop.hdfs.server.namenode.ha.EditLogTailer.doTailEdits(EditLogTailer.java:206)