[GitHub] [zookeeper] anmolnar commented on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config

2019-05-16 Thread GitBox 
anmolnar commented on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address 
in peer config
URL: https://github.com/apache/zookeeper/pull/761#issuecomment-493090307
 
 
   Committed to master branch. Thanks @enixon !


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] anmolnar commented on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config

2019-04-26 Thread GitBox 
anmolnar commented on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address 
in peer config
URL: https://github.com/apache/zookeeper/pull/761#issuecomment-487087839
 
 
   @enixon You don't necessarily write an integration test like this via 
Reconfig functionality.
   Just create a mocked `QuorumServer` and call `excludedSpecialAddresses()` 
via the constructor or via `checkAddressDuplicate()`. It would be more 
unit-test like and stable.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] anmolnar commented on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config

2019-03-15 Thread GitBox 
anmolnar commented on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address 
in peer config
URL: https://github.com/apache/zookeeper/pull/761#issuecomment-473381316
 
 
   @enixon Did you have a chance to try writing unit test?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services