hanm commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() may take
too long to time-out
URL: https://github.com/apache/zookeeper/pull/953#issuecomment-497156627
>> if this config could be generalized to be used exclusively for socket
connection timeout
I am not sure if all socket connection timeouts can be generalized. It seems
to me the timeout configuration is case by case. But, an improvement regardless
if we can generalize this or not, is to have a timeout provisioning class that
provides a set of interfaces so we can query different timeouts with different
semantics and have the actual timeout implementation in a single place, then we
can get rid of all the `self.tickTime * self.initLimit` or `self.tickTime *
self.syncLimit` scattered through code base. We could even consider teaching
this class to be adaptive of network conditions instead of relying on static
timeout values.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
