[GitHub] [zookeeper] jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics

2019-05-28 Thread GitBox
jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics
URL: https://github.com/apache/zookeeper/pull/850#issuecomment-496750615
 
 
   retest maven build


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics

2019-05-28 Thread GitBox
jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics
URL: https://github.com/apache/zookeeper/pull/850#issuecomment-496648615
 
 
   retest maven build


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics

2019-05-28 Thread GitBox
jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics
URL: https://github.com/apache/zookeeper/pull/850#issuecomment-496648163
 
 
   reset maven build


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics

2019-05-28 Thread GitBox
jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics
URL: https://github.com/apache/zookeeper/pull/850#issuecomment-496606096
 
 
   > Did you see my last comments?
   
   Sorry! Was on vacation. Just made the changes. Thank you @eolivelli 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics

2019-05-20 Thread GitBox
jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics
URL: https://github.com/apache/zookeeper/pull/850#issuecomment-494063586
 
 
   Added a metric SYNC_PROCESSOR_QUEUE_AND_FLUSH_TIME, which is the end to end 
time a request stays in the SyncRequestProcessor.  Also changed sleep to 
CountDownLatch in the unit test.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics

2019-03-16 Thread GitBox
jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics
URL: https://github.com/apache/zookeeper/pull/850#issuecomment-473536630
 
 
   There are no failing tests. The failure in Jenkins is the findbugs issue 
"redundant null check" and "unreachable code", which was fixed then reverted 
according to Fangmin's comment and is now addressed in PR 853  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services