[GitHub] anmolnar commented on issue #630: ZOOKEEPER-2284:LogFormatter and SnapshotFormatter does not handle FileNotFoundException gracefully

2019-01-14 Thread GitBox
anmolnar commented on issue #630: ZOOKEEPER-2284:LogFormatter and 
SnapshotFormatter does not handle FileNotFoundException gracefully
URL: https://github.com/apache/zookeeper/pull/630#issuecomment-454115244
 
 
   Committed to master branch, but cannot be cherry-picked to 3.5
   Please create separate PR. Thanks @maoling !


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] anmolnar commented on issue #630: ZOOKEEPER-2284:LogFormatter and SnapshotFormatter does not handle FileNotFoundException gracefully

2019-01-09 Thread GitBox
anmolnar commented on issue #630: ZOOKEEPER-2284:LogFormatter and 
SnapshotFormatter does not handle FileNotFoundException gracefully
URL: https://github.com/apache/zookeeper/pull/630#issuecomment-452650187
 
 
   Thanks for the heads-up @maoling .
   Please move the test file to 
`zookeeper-server/src/test/java/org/apache/zookeeper/common/`.
   We reverted the change to separate the common project, because the refactor 
wasn't possible.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services