[GitHub] vivekpatani commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions of covariant return types …

2019-01-16 Thread GitBox 
vivekpatani commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions 
of covariant return types …
URL: https://github.com/apache/zookeeper/pull/760#issuecomment-454982760
 
 
   @anmolnar looks like it works for me. We can close this PR out and just 
comment on the issue if anyone comes across the same problem, they can use 
```--release``` flag as a solution. Thank you.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] vivekpatani commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions of covariant return types …

2019-01-09 Thread GitBox 
vivekpatani commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions 
of covariant return types …
URL: https://github.com/apache/zookeeper/pull/760#issuecomment-452933177
 
 
   @anmolnar it builds just fine, passes tests, it's more about return types 
discrepancy post JDK9. Were you able to spin up a server/client and talk to 
each other? I'll give it a try as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services