[GitHub] zookeeper issue #148: ZOOKEEPER-2659 Log4j 2 migration
Github user praste commented on the issue: https://github.com/apache/zookeeper/pull/148 Reopening as multiple people are interested in it. However, I have switched jobs and may not be able to make further changes until I get approval from my new employer. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #148: ZOOKEEPER-2659 Log4j 2 migration
Github user 12hys commented on the issue: https://github.com/apache/zookeeper/pull/148 Would also like to see this merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #148: ZOOKEEPER-2659 Log4j 2 migration
Github user jvz commented on the issue: https://github.com/apache/zookeeper/pull/148 I'm still interested in it, though I'm not a Zookeeper committer, so I can't do anything about it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #148: ZOOKEEPER-2659 Log4j 2 migration
Github user praste commented on the issue: https://github.com/apache/zookeeper/pull/148 Looks like no one is really interested in this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #148: ZOOKEEPER-2659 Log4j 2 migration
Github user praste commented on the issue: https://github.com/apache/zookeeper/pull/148 can this be merged ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #148: ZOOKEEPER-2659 Log4j 2 migration
Github user nerdyyatrice commented on the issue: https://github.com/apache/zookeeper/pull/148 Thanks, the second one worked. I wonder how do I apply this to other pull requests? I can't seem to find where to get "praste/zookeeper/" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #148: ZOOKEEPER-2659 Log4j 2 migration
Github user praste commented on the issue: https://github.com/apache/zookeeper/pull/148 Two options 1. Use patch * Use link https://patch-diff.githubusercontent.com/raw/apache/zookeeper/pull/148.diff and save it as patch. Then use `git apply-patch` 2. Pull from my fork (I have not really tested following steps, jut relying on my muscle memory) * `git remote add praste https://github.com/praste/zookeeper/` * `git fetch praste` * `git pull praste/log4j2-migration` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #148: ZOOKEEPER-2659 Log4j 2 migration
Github user nerdyyatrice commented on the issue: https://github.com/apache/zookeeper/pull/148 Another stupid question, how can I git pull this request to my local machine and play with it? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #148: ZOOKEEPER-2659 Log4j 2 migration
Github user jvz commented on the issue: https://github.com/apache/zookeeper/pull/148 If any transitive dependencies rely on the log4j 1.x API itself (not SLF4J or Commons Log or java.util.logging or an obscure bridge I didn't mention), then they can be replaced with log4j-1.2-api from Log4j2 in general unless they're defining custom appenders or other plugins. I'm not too familiar with Ivy, but here's what Gradle generates in its embedded ivy.xml for something similar: ```xml ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #148: ZOOKEEPER-2659 Log4j 2 migration
Github user praste commented on the issue: https://github.com/apache/zookeeper/pull/148 Are sure you removed reference to `slf4j-log4j12` from all the `ivy.xml` files? I am not an ivy expert but you can take a look at http://stackoverflow.com/questions/5405310/find-hidden-dependencies-in-ivy and http://ant.apache.org/ivy/history/latest-milestone/use/dependencytree.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #148: ZOOKEEPER-2659 Log4j 2 migration
Github user nerdyyatrice commented on the issue: https://github.com/apache/zookeeper/pull/148 Hi, I tried the same approach and I got a bin place conflict as some of the dependencies in my ivy.xml is still using log4j1.2. I wonder how can I find out which dependency bin placed that or is that a way to override that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #148: ZOOKEEPER-2659 Log4j 2 migration
Github user praste commented on the issue: https://github.com/apache/zookeeper/pull/148 I have made all the suggested changes except for using List appender, which I will look into tonight --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
