[GitHub] zookeeper issue #165: ZOOKEEPER-2665 Port QA github pull request build to br...
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/165 @eribeiro that you for reviewing this. IMHO it it just a variable name. The script is basically the same as in the trunk version. I think it would be better to leave all versions as much similar as possible. Eventually I can change this and file a pr against trunk too but I don't know the impact. @fpj what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #165: ZOOKEEPER-2665 Port QA github pull request build to br...
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/165 I think it is fine to leave the names as they are for now and later update scripts for all branches all together. @eolivelli - are there any specific changes you made on top of ZOOKEEPER-2624 while porting the script to branch-3.5 and 3.4? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #165: ZOOKEEPER-2665 Port QA github pull request build to br...
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/165 @hanm the patch is almost the same as for trunk, just a work of "copy and paste" Eventually you can compare the diff with #97 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #165: ZOOKEEPER-2665 Port QA github pull request build to br...
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/165 Thanks @eolivelli, this is merged in 3.4. and 3.5. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #165: ZOOKEEPER-2665 Port QA github pull request build to br...
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/165 @eolivelli - can you please also closing this pull request? On a side note, this patch works, I see my PR to branch 3.5 is now kicking build bots. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
