[GitHub] zookeeper issue #319: ZOOKEEPER-2859: Fix CMake build on OS X.
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/319 The precommit job failured was fixed separately, and irrelevant to this patch. LGTM, merged to master: https://github.com/apache/zookeeper/commit/5bcffe9bc242d825ad97ff4f9d2dea6476983a9a 3.5: https://github.com/apache/zookeeper/commit/1bcf57dc775c5cec00f1f54414cf5a0e5f18e2f4 3.4: https://github.com/apache/zookeeper/commit/1f811a6281090e1b24152dc51507aa6a2bdeafe3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #319: ZOOKEEPER-2859: Fix CMake build on OS X.
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/319 I have cppunit.m4 under this path: /usr/local/Cellar/cppunit/1.13.2/share/aclocal. It was brew installed. Also I am able to build C client on mac. I can't remember how I did it, but checkout this link which might help: http://wiki.wsmoak.net/cgi-bin/wiki.pl?action=browse=1=ZooKeeperBuild --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #319: ZOOKEEPER-2859: Fix CMake build on OS X.
Github user andschwa commented on the issue: https://github.com/apache/zookeeper/pull/319 Also, I'd like to test `Autotools` on OS X, because I believe it has the same problem (unconditionally adds `libm` and `librt`), but I can't get past `autoconf -if` since I don't have `cppunit.m4`. I'm looking high and low for it: it's not in `/usr/local/` nor `/opt`, the brew CppUnit didn't come with it, and none of the Autotools directories has it. I found [ZOOKEEPER-1454](https://issues.apache.org/jira/browse/ZOOKEEPER-1454), and it showed me how to specify where `cppunit.m4` is, but that's not much use if I don't have it. Do you know, does anyone have this building on OS X? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #319: ZOOKEEPER-2859: Fix CMake build on OS X.
Github user andschwa commented on the issue: https://github.com/apache/zookeeper/pull/319 @hanm That's bizzare. The [log](https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/906/artifact/patchprocess/patchJavadocWarnings.txt/*view*/) it provides says this: ``` build@2/src/java/main/org/apache/zookeeper/client/StaticHostProvider.java:153: warning - Tag @link:illegal character: "58" in "https://issues.apache.org/jira/browse/ZOOKEEPER-1355; [javadoc] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/src/java/main/org/apache/zookeeper/client/StaticHostProvider.java:153: warning - Tag @link:illegal character: "47" in "https://issues.apache.org/jira/browse/ZOOKEEPER-1355; [javadoc] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/src/java/main/org/apache/zookeeper/client/StaticHostProvider.java:153: warning - Tag @link:illegal character: "47" in "https://issues.apache.org/jira/browse/ZOOKEEPER-1355; [javadoc] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/src/java/main/org/apache/zookeeper/client/StaticHostProvider.java:153: warning - Tag @link:illegal character: "47" in "https://issues.apache.org/jira/browse/ZOOKEEPER-1355; [javadoc] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/src/java/main/org/apache/zookeeper/client/StaticHostProvider.java:153: warning - Tag @link:illegal character: "47" in "https://issues.apache.org/jira/browse/ZOOKEEPER-1355; [javadoc] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/src/java/main/org/apache/zookeeper/client/StaticHostProvider.java:153: warning - Tag @link:illegal character: "47" in "https://issues.apache.org/jira/browse/ZOOKEEPER-1355; [javadoc] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/src/java/main/org/apache/zookeeper/client/StaticHostProvider.java:153: warning - Tag @link:illegal character: "45" in "https://issues.apache.org/jira/browse/ZOOKEEPER-1355; [javadoc] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/src/java/main/org/apache/zookeeper/client/StaticHostProvider.java:153: warning - Tag @link: reference not found: https://issues.apache.org/jira/browse/ZOOKEEPER-1355 ``` And that issue it's referencing is [ancient](https://issues.apache.org/jira/browse/ZOOKEEPER-1355). That really is weird. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #319: ZOOKEEPER-2859: Fix CMake build on OS X.
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/319 Any idea why precommit job generates java doc warnings? Seems not related to the patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #319: ZOOKEEPER-2859: Fix CMake build on OS X.
Github user andschwa commented on the issue: https://github.com/apache/zookeeper/pull/319 @hanm This has a few fixes for the CMake build for OS X. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
