[GitHub] zookeeper issue #325: Fix typos in zookeeperAdmin.html
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/325 merged to master. In the future, please create a JIRA issue before sending a pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #325: Fix typos in zookeeperAdmin.html
Github user makubi commented on the issue: https://github.com/apache/zookeeper/pull/325 Thank you for the information. @eribeiro The branch can not be merged to `branch-3.4` or `branch-3.5` as it's originated from `master`. You can cherry-pick the commit if the branches are never going to be merged back into `master` or I can use an earlier, common commit for the PR. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #325: Fix typos in zookeeperAdmin.html
Github user eribeiro commented on the issue: https://github.com/apache/zookeeper/pull/325 +1. :+1: @makubi could you confirm that this patch can be applied on branch-3.4 and branch-3.5 too, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #325: Fix typos in zookeeperAdmin.html
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/325 The doc artifacts (html, pdf, etc) were added to repo because there was a tale that without them in trunk, the documentation on [zookeeper web site](https://zookeeper.apache.org/doc/trunk/) would not work. However I doubt that's the case and there was a discussion on dev list about removing the doc artifacts from repo but the discussion does not conclude yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #325: Fix typos in zookeeperAdmin.html
Github user makubi commented on the issue: https://github.com/apache/zookeeper/pull/325 Alright, so is there a reason the generated doc is added to the repository? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #325: Fix typos in zookeeperAdmin.html
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/325 Doc change should be done on doc source file instead of on the html file directly - see my comment here: https://github.com/apache/zookeeper/pull/275#issuecomment-307161978 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
