[GitHub] zookeeper issue #375: ZOOKEEPER-1363: Categorise unit tests by 'test-commit'...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/375
  
Hi,
This patch would be extremely useful for analysing flaky tests.
Any plans for merging it?


---

[GitHub] zookeeper issue #375: ZOOKEEPER-1363: Categorise unit tests by 'test-commit'...

[mfenes]

Github user mfenes commented on the issue:

https://github.com/apache/zookeeper/pull/375
  
The reason why I've created a test category for "slow" and not for "fast" 
is because this way one can specify a test category by ant test 
-Dtest.category=... and can exclude the "slow" tests from any category by using 
the -Dtest.quick=yes option. 
The special logic for "slow" is also needed for backwards compatibility 
with the current ant test options.


---

[GitHub] zookeeper issue #375: ZOOKEEPER-1363: Categorise unit tests by 'test-commit'...

[afine]

Github user afine commented on the issue:

https://github.com/apache/zookeeper/pull/375
  
verified that jenkins is running the same number of tests with this patch 
as it did before. The list of slow tests also appears to be reasonable. 

small nitpick, wouldn't it make more sense to have a test category called 
"fast" and use an exclusion list rather than include special logic for "slow"?


---