[GitHub] zookeeper issue #574: ZOOKEEPER-3030 - MAVEN MIGRATION - Step 1.3 - move con...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/574 Committed to branch-3.5 and master. Thanks @nkalmar ! Please close this PR and create another one for 3.4 ---
[GitHub] zookeeper issue #574: ZOOKEEPER-3030 - MAVEN MIGRATION - Step 1.3 - move con...
Github user nkalmar commented on the issue: https://github.com/apache/zookeeper/pull/574 @anmolnar I did an amend commit, it doesn't seem to trigger the build. I also did a normal commit yesterday on my other PR, which also didn't trigger the build. Strange. Maybe I'll closing and re-opening the PR ---
[GitHub] zookeeper issue #574: ZOOKEEPER-3030 - MAVEN MIGRATION - Step 1.3 - move con...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/574 @nkalmar I think this is good to go as it. Would you please trigger a build, because it looks hasn't been started for the last commit. ---
[GitHub] zookeeper issue #574: ZOOKEEPER-3030 - MAVEN MIGRATION - Step 1.3 - move con...
Github user nkalmar commented on the issue: https://github.com/apache/zookeeper/pull/574 So... The problem was that by moving directories from src, ant did not copy them to build/zookeeper-[version]/src/ - now I don't know why it is required here, as it won't be in the jars. I made a script to dif all the filenames in build directory and to diff all the jars (with jar tf output), and the jars do not differ, but the files do. For example, used to be: build/zookeeper-3.6.0-SNAPSHOT/src/recipes/lock/build.xml now: build/zookeeper-3.6.0-SNAPSHOT/src/zookeeper-recipes/zookeeper-recipes-lock/build.xml Again the jar's did not change as packages remained the same! ---
[GitHub] zookeeper issue #574: ZOOKEEPER-3030 - MAVEN MIGRATION - Step 1.3 - move con...
Github user nkalmar commented on the issue: https://github.com/apache/zookeeper/pull/574 The problem with that is that it requires a lot of ant change and the final artifact could change. I agree @tamaashu , that was the plan. I will try to do this with the contrib directory (this PR), and carefully check the end artifacts. ---
[GitHub] zookeeper issue #574: ZOOKEEPER-3030 - MAVEN MIGRATION - Step 1.3 - move con...
Github user nkalmar commented on the issue: https://github.com/apache/zookeeper/pull/574 Found the problem, fixed it with a quick amend commit. The problem was in .gitignore we have build/ and that matched the new directory, and I had to explicitly add them. ---
