[GitHub] zookeeper issue #583: [ZOOKEEPER-3104] Fix data inconsistency due to NEWLEAD...
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/583 Thanks @breed, the conflict is resolved. ---
[GitHub] zookeeper issue #583: [ZOOKEEPER-3104] Fix data inconsistency due to NEWLEAD...
Github user breed commented on the issue: https://github.com/apache/zookeeper/pull/583 ok @lvfangmin i'll commit this once the conflict is resolved. ---
[GitHub] zookeeper issue #583: [ZOOKEEPER-3104] Fix data inconsistency due to NEWLEAD...
Github user nkalmar commented on the issue: https://github.com/apache/zookeeper/pull/583 It's not a blocker for me, I agree it would be nice to have a unified format, but that's pretty hard to achieve on an Apache I think :( Anyway, that's why I wrote a "comment" review, not a request for change. Thanks for the fix @lvfangmin ! :) ---
[GitHub] zookeeper issue #583: [ZOOKEEPER-3104] Fix data inconsistency due to NEWLEAD...
Github user breed commented on the issue: https://github.com/apache/zookeeper/pull/583 @nkalmar i think fixing whitespace is good if it is in proximity of the code you are changing, which i think is the case in this diff. the logic looks good to me! thanx @lvfangmin ! +1 ---
[GitHub] zookeeper issue #583: [ZOOKEEPER-3104] Fix data inconsistency due to NEWLEAD...
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/583 @lvfangmin discard your vim,embrace IEDA(smirk) ---
[GitHub] zookeeper issue #583: [ZOOKEEPER-3104] Fix data inconsistency due to NEWLEAD...
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/583 @nkalmar I can remove the white space in this diff, it do looks much cleaner after we remove the space though. Do you know how often we need to ask people to format their code (remove the extra white space change, etc), maybe we should unify the format of coding and have a one time format to avoid this issue in the future. Please use "Hide whitespace changes" when reviewing the code before I removed those white space change. ---
