[GitHub] zookeeper issue #601: ZOOKEEPER-3123 MetricsProvider Lifecycle in ZooKeeper ...

2018-08-31 Thread eolivelli 
Github user eolivelli commented on the issue:

https://github.com/apache/zookeeper/pull/601
  
@lvfangmin I have pushed a bunch of tests for the QuorumPeerMain case.

As already said for the ZooKeeperServerMain there is much "copy and paste" 
for test cases, but this is current "style" of QuorumPeerMainTest.
In the future we should clean up.

The last commit is only about new testcases, I did not touch the core 
change you had already reviewed.


---

[GitHub] zookeeper issue #601: ZOOKEEPER-3123 MetricsProvider Lifecycle in ZooKeeper ...

2018-09-01 Thread eolivelli 
Github user eolivelli commented on the issue:

https://github.com/apache/zookeeper/pull/601
  
Seems there is an error on CI related to the patch.


---

[GitHub] zookeeper issue #601: ZOOKEEPER-3123 MetricsProvider Lifecycle in ZooKeeper ...

2018-09-07 Thread lvfangmin 
Github user lvfangmin commented on the issue:

https://github.com/apache/zookeeper/pull/601
  
Thanks for adding the test, please trigger Jenkins again to see if those 
failed tests are due to flaky or not.


---

[GitHub] zookeeper issue #601: ZOOKEEPER-3123 MetricsProvider Lifecycle in ZooKeeper ...

2018-09-07 Thread eolivelli 
Github user eolivelli commented on the issue:

https://github.com/apache/zookeeper/pull/601
  
@lvfangmin 
CI  failed on  
org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig
and it seems unrelated to the change

I will re-run tests again




---

[GitHub] zookeeper issue #601: ZOOKEEPER-3123 MetricsProvider Lifecycle in ZooKeeper ...

2018-09-07 Thread eolivelli 
Github user eolivelli commented on the issue:

https://github.com/apache/zookeeper/pull/601
  
@lvfangmin  on my laptop ReconfigRecoveryTest always passes it should 
be a flaky test


---

[GitHub] zookeeper issue #601: ZOOKEEPER-3123 MetricsProvider Lifecycle in ZooKeeper ...

2018-09-07 Thread anmolnar 
Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/601
  
Manually triggered Jenkins.


---

[GitHub] zookeeper issue #601: ZOOKEEPER-3123 MetricsProvider Lifecycle in ZooKeeper ...

2018-09-11 Thread eolivelli 
Github user eolivelli commented on the issue:

https://github.com/apache/zookeeper/pull/601
  
@anmolnar @lvfangmin I think this is good to go


---

[GitHub] zookeeper issue #601: ZOOKEEPER-3123 MetricsProvider Lifecycle in ZooKeeper ...

2018-09-11 Thread anmolnar 
Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/601
  
Latest build is green. I'll commit this one.



---

[GitHub] zookeeper issue #601: ZOOKEEPER-3123 MetricsProvider Lifecycle in ZooKeeper ...

2018-09-11 Thread anmolnar 
Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/601
  
Merged. Thanks @eolivelli !


---