[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-05 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2360/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-05 Thread nkalmar
Github user nkalmar commented on the issue:

https://github.com/apache/zookeeper/pull/633
  
retest this please


---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-05 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2359/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-05 Thread nkalmar
Github user nkalmar commented on the issue:

https://github.com/apache/zookeeper/pull/633
  
retest this please


---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-05 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2358/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-05 Thread nkalmar
Github user nkalmar commented on the issue:

https://github.com/apache/zookeeper/pull/633
  
retest this please


---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-04 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2357/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-04 Thread nkalmar
Github user nkalmar commented on the issue:

https://github.com/apache/zookeeper/pull/633
  
retest this please


---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-04 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2356/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-04 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2355/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-04 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2354/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-04 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2353/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-04 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2352/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-04 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2351/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-04 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2350/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-04 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2345/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-04 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2344/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-04 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2343/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-03 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2341/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-03 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2340/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-03 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2339/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-03 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2337/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-03 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2338/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-03 Thread nkalmar
Github user nkalmar commented on the issue:

https://github.com/apache/zookeeper/pull/633
  
I'm starting to think Jenkins hates me.
I did multiple tests on a Linux server. Although it did fail sometime, 
after adding more memory, as much as the Jenkins job does, it passes all the 
time.
I run it with: ant test -Dtest.junit.threads=8 -Dtest.junit.maxmem=2g
(Oh, on 1 thread it never fails).

First I thought there is a bug in PortAssignment, but I debugged that, 
looks fine.
I'm still investigating, and also re-running Jenkins job maybe I get a 
green build... but this is extremely flaky, so I hope I find something...


---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-03 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2332/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2330/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2319/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2318/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread nkalmar
Github user nkalmar commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter_stillHasMajority
 seems pretty flaky, bu it runs without a problem on my local machine. 
Anyway, one time it was like 10 failure, the next run had only the 
mentioned test fail. 

Hopefully I will get a green build, looks OK on local build...


---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2317/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2316/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2315/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread anmolnar
Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/633
  
retest this please


---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2314/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread anmolnar
Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/633
  
retest this please


---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2313/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2312/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2311/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2310/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread nkalmar
Github user nkalmar commented on the issue:

https://github.com/apache/zookeeper/pull/633
  
A green build would be nice. I rebased, as it seems not perfectly, as there 
are build errors. Fixing them right now.


---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2309/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread eolivelli
Github user eolivelli commented on the issue:

https://github.com/apache/zookeeper/pull/633
  
Any plan for merging this ?
Are we waiting for current patches under review for branch-3.5 
stabilization ?


---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2307/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2308/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-09-26 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2270/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-09-26 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2269/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-09-26 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2268/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-09-26 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2267/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-09-26 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2265/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-09-24 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2256/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-09-24 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2255/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-09-24 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2252/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-09-24 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2251/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-09-24 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2250/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-09-24 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2249/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-09-21 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/633
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2233/



---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-09-20 Thread nkalmar
Github user nkalmar commented on the issue:

https://github.com/apache/zookeeper/pull/633
  
It is preserved, I double checked that. I also read multiple articles on 
the topic, there was a good one, which I can't find anymore...

The points was the ones I wrote - mainly, github web client can't be set to 
use --follow which is very unfortunate. And this is how git works. It doesn't 
really care about files, rather than content.

But for example, as I mentioned, in my Idea, it does the --follow 
automatically, at least I can see the logs just like before. So it depends on 
the Git client too.

There are some workarounds, but those actually rewrite the history, which 
is a huge NO in my opinion.


---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-09-19 Thread hanm
Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/633
  
I think github web interface does not support `--follow` at the moment, 
unfortunately, but there is a chrome extension that seems working 
https://chrome.google.com/webstore/detail/follow-for-github/agalokjhnhheienloigiaoohgmjdpned

In any case, as long as the history is preserved in git we should be fine - 
just a little bit inconvenient to look it up on github...


---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-09-19 Thread nkalmar
Github user nkalmar commented on the issue:

https://github.com/apache/zookeeper/pull/633
  
How can I do that? I tried a few things like git mv, but didn't work either.

As far as I know, this is how git works unfortunately. But it did not loose 
the history, it's just that git is tracking content, not files. It is a matter 
of git client how it displays.

git log will make it look like the history is lost, but using git log 
--follow displays the history fine.

Unfortunately, github web interface does not have this feature.

Do you know a workaround @hanm ?


---


[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-09-19 Thread hanm
Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/633
  
Can we make sure to preserve the file commit history while moving these 
files around? I noticed recently after `src/c` was moved the entire commit 
history was lost. The commit history is a priceless treasure we probably want 
to preserve here, and I think there is ways in git to do that..



---