[GitHub] zookeeper issue #74: ServerConfig#parse(String[]) parse params has problems
Github user eribeiro commented on the issue: https://github.com/apache/zookeeper/pull/74 @hanm I didn't tested on a git repo. The guy who told me about this trick mentioned the Spark project guys use it (even though they don't use it on the Kafka project). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #74: ServerConfig#parse(String[]) parse params has problems
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/74 @eribeiro You mentioned in a dev mailing thread that a PR can be closed by a "dummy commit" - to quote what you said: > The 'dummy commit' is a Github trick. In any commit message you can write "closes #", like "closes #84" (by my own experience you can also write "fixes #". You can put as many of those messages as you like in the commit message even if the commit doesn't have relation with the PRs. Then GH will close those PRs. Have you tested this on a git repo? If it works, maybe we can use this technique to close many stale zookeeper PRs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #74: ServerConfig#parse(String[]) parse params has problems
Github user eribeiro commented on the issue: https://github.com/apache/zookeeper/pull/74 This issue was solved by https://github.com/apache/zookeeper/pull/125 so this PR can be closed PS: @hanm and @fpj and @phunt, afaik, you have to ask INFRA to close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
