[GitHub] zookeeper pull request #417: ZOOKEEPER-2935: [QP MutualAuth]: Port ZOOKEEPER...
GitHub user afine opened a pull request: https://github.com/apache/zookeeper/pull/417 ZOOKEEPER-2935: [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk You can merge this pull request into a Git repository by running: $ git pull https://github.com/afine/zookeeper ZOOKEEPER-2935 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/417.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #417 commit f211a512566b43375d76443392157b231e6ba9a1 Author: Abraham Fine Date: 2017-11-06T22:48:36Z init ---
[GitHub] zookeeper pull request #417: ZOOKEEPER-2935: [QP MutualAuth]: Port ZOOKEEPER...
Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/417#discussion_r153161187 --- Diff: ivy.xml --- @@ -90,6 +90,69 @@ + + + + --- End diff -- Good work! Thanks @afine for your efforts. Apart from @phunt comment, I've below observation. Should we need to exclude 'slf4j-api' and 'slf4j-log4j12' from all the kerb dependency, which is missing in branch-3.5. If needed then could you please raise a minor imprv task to correct in branch-3.5 and push it in together, that would syncup the code between branches. ---
[GitHub] zookeeper pull request #417: ZOOKEEPER-2935: [QP MutualAuth]: Port ZOOKEEPER...
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/417#discussion_r153334347 --- Diff: ivy.xml --- @@ -90,6 +90,69 @@ + + + + --- End diff -- I reduced the number of excludes to the minimum that I think is necessary. Not sure why the ivy "stict" resolution change is not in 3.5. I'll investigate ---
[GitHub] zookeeper pull request #417: ZOOKEEPER-2935: [QP MutualAuth]: Port ZOOKEEPER...
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/417#discussion_r153334506 --- Diff: ivy.xml --- @@ -90,6 +90,69 @@ + + + + --- End diff -- And create a jira to make the branches the same if necessary ---
[GitHub] zookeeper pull request #417: ZOOKEEPER-2935: [QP MutualAuth]: Port ZOOKEEPER...
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/417 ---
