[GitHub] zookeeper pull request #555: ZOOKEEPER-3061: add more details to 'Unhandled ...
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/555 ---
[GitHub] zookeeper pull request #555: ZOOKEEPER-3061: add more details to 'Unhandled ...
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/555#discussion_r205669958 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java --- @@ -792,7 +792,14 @@ public boolean syncFollower(long peerLastZxid, ZKDatabase db, Leader leader) { txnProposalItr.close(); } } else { -LOG.warn("Unhandled scenario for peer sid: " + getSid()); +LOG.warn("Unhandled scenario for peer sid: {} maxCommittedLog=0x{}" --- End diff -- the logging levels are different, and it is nice to have the evaluation information with weird corner case scenario. i think it's worth surfacing the information here as well. ---
[GitHub] zookeeper pull request #555: ZOOKEEPER-3061: add more details to 'Unhandled ...
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/555#discussion_r202508110 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java --- @@ -792,7 +792,14 @@ public boolean syncFollower(long peerLastZxid, ZKDatabase db, Leader leader) { txnProposalItr.close(); } } else { -LOG.warn("Unhandled scenario for peer sid: " + getSid()); +LOG.warn("Unhandled scenario for peer sid: {} maxCommittedLog=0x{}" --- End diff -- The same context is also provided at line 703 except the txnLogSyncEnabled, looks like nothing changed between these lines, any reason we added this extra logging here? ---
[GitHub] zookeeper pull request #555: ZOOKEEPER-3061: add more details to 'Unhandled ...
GitHub user cpoerschke opened a pull request: https://github.com/apache/zookeeper/pull/555 ZOOKEEPER-3061: add more details to 'Unhandled scenario for peer' log.warn message You can merge this pull request into a Git repository by running: $ git pull https://github.com/cpoerschke/zookeeper master-ZOOKEEPER-3061 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/555.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #555 commit 1d3e7bc0bc18c350e5385a3acae38f979a90dd92 Author: Christine Poerschke Date: 2018-06-29T15:58:40Z ZOOKEEPER-3061: add more details to 'Unhandled scenario for peer' log.warn message ---