[jira] [Commented] (BOOKKEEPER-431) Duplicate definition of COOKIES_NODE
[ https://issues.apache.org/jira/browse/BOOKKEEPER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475101#comment-13475101 ] Uma Maheswara Rao G commented on BOOKKEEPER-431: How about having a constants file and maintaining all such consts at place? If we maintain the constants inside specific files, it is very easy to duplicate the consts. > Duplicate definition of COOKIES_NODE > > > Key: BOOKKEEPER-431 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-431 > Project: Bookkeeper > Issue Type: Improvement >Affects Versions: 4.1.0 >Reporter: Flavio Junqueira >Assignee: Uma Maheswara Rao G >Priority: Minor > Fix For: 4.2.0 > > > Is it necessary two definitions of COOKIES_NODE, one in cookie.java and one > in AbstractZkLedgerManager? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-431) Duplicate definition of COOKIES_NODE
[ https://issues.apache.org/jira/browse/BOOKKEEPER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475099#comment-13475099 ] Flavio Junqueira commented on BOOKKEEPER-431: - Actually, Cookie.java defines COOKIE_NODE while AbstractZkLedgerManager defines COOKIES_NODE. I also noticed that AVAILABLE_NODE is duplicated. Is it for readability reasons? Shouldn't we have that in a single place? > Duplicate definition of COOKIES_NODE > > > Key: BOOKKEEPER-431 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-431 > Project: Bookkeeper > Issue Type: Improvement >Affects Versions: 4.1.0 >Reporter: Flavio Junqueira >Priority: Minor > Fix For: 4.2.0 > > > Is it necessary two definitions of COOKIES_NODE, one in cookie.java and one > in AbstractZkLedgerManager? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
