[jira] [Commented] (ZOOKEEPER-1077) C client lib doesn't build on Solaris
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14548179#comment-14548179 ] Chris Nauroth commented on ZOOKEEPER-1077: -- Thanks for the commit, Raul. No worries about slowness. I know committers are busy. :-) C client lib doesn't build on Solaris - Key: ZOOKEEPER-1077 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1077 Project: ZooKeeper Issue Type: Bug Components: build, c client Affects Versions: 3.3.4 Environment: uname -a: SunOS [redacted] 5.10 Generic_142910-17 i86pc i386 i86pc GNU toolchain (gcc 3.4.3, GNU Make etc.) Reporter: Tadeusz Andrzej Kadłubowski Assignee: Chris Nauroth Priority: Critical Fix For: 3.4.7, 3.5.2, 3.6.0 Attachments: ZOOKEEPER-1077-branch-3.4.002.patch, ZOOKEEPER-1077.001.patch, ZOOKEEPER-1077.002.patch, zookeeper.patch Hello, Some minor trouble with building ZooKeeper C client library on Sun^H^H^HOracle Solaris 5.10. 1. You need to link against -lnsl -lsocket 2. ctime_r needs a buffer size. The signature is: char *ctime_r(const time_t *clock, char *buf, int buflen) 3. In zk_log.c you need to manually cast pid_t to int (-Werror can be cumbersome ;) ) 4. getpwuid_r()returns pointer to struct passwd, which works as the last parameter on Linux. Solaris signature: struct passwd *getpwuid_r(uid_t uid, struct passwd *pwd, char *buffer, int buflen); Linux signature: int getpwuid_r(uid_t uid, struct passwd *pwd, char *buf, size_t buflen, struct passwd **result); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1077) C client lib doesn't build on Solaris
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14547847#comment-14547847 ] Hudson commented on ZOOKEEPER-1077: --- FAILURE: Integrated in ZooKeeper-trunk #2695 (See [https://builds.apache.org/job/ZooKeeper-trunk/2695/]) ZOOKEEPER-1077: C client lib doesn't build on Solaris (Chris Nauroth via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1679951) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/c/Makefile.am * /zookeeper/trunk/src/c/configure.ac * /zookeeper/trunk/src/c/src/zk_log.c * /zookeeper/trunk/src/c/src/zookeeper.c * /zookeeper/trunk/src/c/tests/LibCMocks.cc * /zookeeper/trunk/src/c/tests/wrappers.opt C client lib doesn't build on Solaris - Key: ZOOKEEPER-1077 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1077 Project: ZooKeeper Issue Type: Bug Components: build, c client Affects Versions: 3.3.4 Environment: uname -a: SunOS [redacted] 5.10 Generic_142910-17 i86pc i386 i86pc GNU toolchain (gcc 3.4.3, GNU Make etc.) Reporter: Tadeusz Andrzej Kadłubowski Assignee: Chris Nauroth Priority: Critical Fix For: 3.4.7, 3.5.2, 3.6.0 Attachments: ZOOKEEPER-1077-branch-3.4.002.patch, ZOOKEEPER-1077.001.patch, ZOOKEEPER-1077.002.patch, zookeeper.patch Hello, Some minor trouble with building ZooKeeper C client library on Sun^H^H^HOracle Solaris 5.10. 1. You need to link against -lnsl -lsocket 2. ctime_r needs a buffer size. The signature is: char *ctime_r(const time_t *clock, char *buf, int buflen) 3. In zk_log.c you need to manually cast pid_t to int (-Werror can be cumbersome ;) ) 4. getpwuid_r()returns pointer to struct passwd, which works as the last parameter on Linux. Solaris signature: struct passwd *getpwuid_r(uid_t uid, struct passwd *pwd, char *buffer, int buflen); Linux signature: int getpwuid_r(uid_t uid, struct passwd *pwd, char *buf, size_t buflen, struct passwd **result); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1077) C client lib doesn't build on Solaris
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14525956#comment-14525956 ] Raul Gutierrez Segales commented on ZOOKEEPER-1077: --- Thanks for the clarifying - makes sense. C client lib doesn't build on Solaris - Key: ZOOKEEPER-1077 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1077 Project: ZooKeeper Issue Type: Bug Components: build, c client Affects Versions: 3.3.4 Environment: uname -a: SunOS [redacted] 5.10 Generic_142910-17 i86pc i386 i86pc GNU toolchain (gcc 3.4.3, GNU Make etc.) Reporter: Tadeusz Andrzej Kadłubowski Assignee: Chris Nauroth Priority: Critical Fix For: 3.4.7, 3.5.2, 3.6.0 Attachments: ZOOKEEPER-1077-branch-3.4.002.patch, ZOOKEEPER-1077.001.patch, ZOOKEEPER-1077.002.patch, zookeeper.patch Hello, Some minor trouble with building ZooKeeper C client library on Sun^H^H^HOracle Solaris 5.10. 1. You need to link against -lnsl -lsocket 2. ctime_r needs a buffer size. The signature is: char *ctime_r(const time_t *clock, char *buf, int buflen) 3. In zk_log.c you need to manually cast pid_t to int (-Werror can be cumbersome ;) ) 4. getpwuid_r()returns pointer to struct passwd, which works as the last parameter on Linux. Solaris signature: struct passwd *getpwuid_r(uid_t uid, struct passwd *pwd, char *buffer, int buflen); Linux signature: int getpwuid_r(uid_t uid, struct passwd *pwd, char *buf, size_t buflen, struct passwd **result); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1077) C client lib doesn't build on Solaris
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14525957#comment-14525957 ] Raul Gutierrez Segales commented on ZOOKEEPER-1077: --- +1, lgtm. [~michim], [~rakeshr], [~fpj]: could i get another review/+1 pls? i'll push to all branches afterwards. thanks! C client lib doesn't build on Solaris - Key: ZOOKEEPER-1077 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1077 Project: ZooKeeper Issue Type: Bug Components: build, c client Affects Versions: 3.3.4 Environment: uname -a: SunOS [redacted] 5.10 Generic_142910-17 i86pc i386 i86pc GNU toolchain (gcc 3.4.3, GNU Make etc.) Reporter: Tadeusz Andrzej Kadłubowski Assignee: Chris Nauroth Priority: Critical Fix For: 3.4.7, 3.5.2, 3.6.0 Attachments: ZOOKEEPER-1077-branch-3.4.002.patch, ZOOKEEPER-1077.001.patch, ZOOKEEPER-1077.002.patch, zookeeper.patch Hello, Some minor trouble with building ZooKeeper C client library on Sun^H^H^HOracle Solaris 5.10. 1. You need to link against -lnsl -lsocket 2. ctime_r needs a buffer size. The signature is: char *ctime_r(const time_t *clock, char *buf, int buflen) 3. In zk_log.c you need to manually cast pid_t to int (-Werror can be cumbersome ;) ) 4. getpwuid_r()returns pointer to struct passwd, which works as the last parameter on Linux. Solaris signature: struct passwd *getpwuid_r(uid_t uid, struct passwd *pwd, char *buffer, int buflen); Linux signature: int getpwuid_r(uid_t uid, struct passwd *pwd, char *buf, size_t buflen, struct passwd **result); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1077) C client lib doesn't build on Solaris
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14522820#comment-14522820 ] Raul Gutierrez Segales commented on ZOOKEEPER-1077: --- Thanks [~cnauroth] - could you backport this to the 3.4 branch as well? It would be nice to have this for the upcoming 3.4.7 release. C client lib doesn't build on Solaris - Key: ZOOKEEPER-1077 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1077 Project: ZooKeeper Issue Type: Bug Components: build, c client Affects Versions: 3.3.4 Environment: uname -a: SunOS [redacted] 5.10 Generic_142910-17 i86pc i386 i86pc GNU toolchain (gcc 3.4.3, GNU Make etc.) Reporter: Tadeusz Andrzej Kadłubowski Assignee: Chris Nauroth Priority: Critical Fix For: 3.5.2, 3.6.0 Attachments: ZOOKEEPER-1077.001.patch, zookeeper.patch Hello, Some minor trouble with building ZooKeeper C client library on Sun^H^H^HOracle Solaris 5.10. 1. You need to link against -lnsl -lsocket 2. ctime_r needs a buffer size. The signature is: char *ctime_r(const time_t *clock, char *buf, int buflen) 3. In zk_log.c you need to manually cast pid_t to int (-Werror can be cumbersome ;) ) 4. getpwuid_r()returns pointer to struct passwd, which works as the last parameter on Linux. Solaris signature: struct passwd *getpwuid_r(uid_t uid, struct passwd *pwd, char *buffer, int buflen); Linux signature: int getpwuid_r(uid_t uid, struct passwd *pwd, char *buf, size_t buflen, struct passwd **result); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1077) C client lib doesn't build on Solaris
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14522824#comment-14522824
]
Raul Gutierrez Segales commented on ZOOKEEPER-1077:
---
A few comments about the patch:
* cast the pid to long for use by the snprintf format string. - do we we want
to do this on all platforms?
* why is:
{noformat}
#define MSG_NOSIGNAL SO_NOSIGPIPE
{noformat}
dropped for Apple?
C client lib doesn't build on Solaris
-
Key: ZOOKEEPER-1077
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1077
Project: ZooKeeper
Issue Type: Bug
Components: build, c client
Affects Versions: 3.3.4
Environment: uname -a: SunOS [redacted] 5.10 Generic_142910-17 i86pc
i386 i86pc
GNU toolchain (gcc 3.4.3, GNU Make etc.)
Reporter: Tadeusz Andrzej Kadłubowski
Assignee: Chris Nauroth
Priority: Critical
Fix For: 3.5.2, 3.6.0
Attachments: ZOOKEEPER-1077.001.patch, zookeeper.patch
Hello,
Some minor trouble with building ZooKeeper C client library on
Sun^H^H^HOracle Solaris 5.10.
1. You need to link against -lnsl -lsocket
2. ctime_r needs a buffer size. The signature is: char *ctime_r(const time_t
*clock, char *buf, int buflen)
3. In zk_log.c you need to manually cast pid_t to int (-Werror can be
cumbersome ;) )
4. getpwuid_r()returns pointer to struct passwd, which works as the last
parameter on Linux.
Solaris signature: struct passwd *getpwuid_r(uid_t uid, struct passwd
*pwd, char *buffer, int buflen);
Linux signature: int getpwuid_r(uid_t uid, struct passwd *pwd, char *buf,
size_t buflen, struct passwd **result);
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1077) C client lib doesn't build on Solaris
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14522885#comment-14522885 ] Hadoop QA commented on ZOOKEEPER-1077: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12729722/ZOOKEEPER-1077.001.patch against trunk revision 1676359. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2663//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2663//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2663//console This message is automatically generated. C client lib doesn't build on Solaris - Key: ZOOKEEPER-1077 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1077 Project: ZooKeeper Issue Type: Bug Components: build, c client Affects Versions: 3.3.4 Environment: uname -a: SunOS [redacted] 5.10 Generic_142910-17 i86pc i386 i86pc GNU toolchain (gcc 3.4.3, GNU Make etc.) Reporter: Tadeusz Andrzej Kadłubowski Assignee: Chris Nauroth Priority: Critical Fix For: 3.5.2, 3.6.0 Attachments: ZOOKEEPER-1077.001.patch, zookeeper.patch Hello, Some minor trouble with building ZooKeeper C client library on Sun^H^H^HOracle Solaris 5.10. 1. You need to link against -lnsl -lsocket 2. ctime_r needs a buffer size. The signature is: char *ctime_r(const time_t *clock, char *buf, int buflen) 3. In zk_log.c you need to manually cast pid_t to int (-Werror can be cumbersome ;) ) 4. getpwuid_r()returns pointer to struct passwd, which works as the last parameter on Linux. Solaris signature: struct passwd *getpwuid_r(uid_t uid, struct passwd *pwd, char *buffer, int buflen); Linux signature: int getpwuid_r(uid_t uid, struct passwd *pwd, char *buf, size_t buflen, struct passwd **result); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1077) C client lib doesn't build on Solaris
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523865#comment-14523865 ] Hadoop QA commented on ZOOKEEPER-1077: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12729821/ZOOKEEPER-1077.002.patch against trunk revision 1676359. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 14 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2667//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2667//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2667//console This message is automatically generated. C client lib doesn't build on Solaris - Key: ZOOKEEPER-1077 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1077 Project: ZooKeeper Issue Type: Bug Components: build, c client Affects Versions: 3.3.4 Environment: uname -a: SunOS [redacted] 5.10 Generic_142910-17 i86pc i386 i86pc GNU toolchain (gcc 3.4.3, GNU Make etc.) Reporter: Tadeusz Andrzej Kadłubowski Assignee: Chris Nauroth Priority: Critical Fix For: 3.5.2, 3.6.0 Attachments: ZOOKEEPER-1077-branch-3.4.002.patch, ZOOKEEPER-1077.001.patch, ZOOKEEPER-1077.002.patch, zookeeper.patch Hello, Some minor trouble with building ZooKeeper C client library on Sun^H^H^HOracle Solaris 5.10. 1. You need to link against -lnsl -lsocket 2. ctime_r needs a buffer size. The signature is: char *ctime_r(const time_t *clock, char *buf, int buflen) 3. In zk_log.c you need to manually cast pid_t to int (-Werror can be cumbersome ;) ) 4. getpwuid_r()returns pointer to struct passwd, which works as the last parameter on Linux. Solaris signature: struct passwd *getpwuid_r(uid_t uid, struct passwd *pwd, char *buffer, int buflen); Linux signature: int getpwuid_r(uid_t uid, struct passwd *pwd, char *buf, size_t buflen, struct passwd **result); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1077) C client lib doesn't build on Solaris
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523845#comment-14523845 ] Hadoop QA commented on ZOOKEEPER-1077: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12729828/ZOOKEEPER-1077-branch-3.4.002.patch against trunk revision 1676359. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 15 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2668//console This message is automatically generated. C client lib doesn't build on Solaris - Key: ZOOKEEPER-1077 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1077 Project: ZooKeeper Issue Type: Bug Components: build, c client Affects Versions: 3.3.4 Environment: uname -a: SunOS [redacted] 5.10 Generic_142910-17 i86pc i386 i86pc GNU toolchain (gcc 3.4.3, GNU Make etc.) Reporter: Tadeusz Andrzej Kadłubowski Assignee: Chris Nauroth Priority: Critical Fix For: 3.5.2, 3.6.0 Attachments: ZOOKEEPER-1077-branch-3.4.002.patch, ZOOKEEPER-1077.001.patch, ZOOKEEPER-1077.002.patch, zookeeper.patch Hello, Some minor trouble with building ZooKeeper C client library on Sun^H^H^HOracle Solaris 5.10. 1. You need to link against -lnsl -lsocket 2. ctime_r needs a buffer size. The signature is: char *ctime_r(const time_t *clock, char *buf, int buflen) 3. In zk_log.c you need to manually cast pid_t to int (-Werror can be cumbersome ;) ) 4. getpwuid_r()returns pointer to struct passwd, which works as the last parameter on Linux. Solaris signature: struct passwd *getpwuid_r(uid_t uid, struct passwd *pwd, char *buffer, int buflen); Linux signature: int getpwuid_r(uid_t uid, struct passwd *pwd, char *buf, size_t buflen, struct passwd **result); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1077) C client lib doesn't build on Solaris
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898573#comment-13898573 ] Michi Mutsuzaki commented on ZOOKEEPER-1077: I'm moving this to 3.4.7. C client lib doesn't build on Solaris - Key: ZOOKEEPER-1077 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1077 Project: ZooKeeper Issue Type: Bug Components: build, c client Affects Versions: 3.3.4 Environment: uname -a: SunOS [redacted] 5.10 Generic_142910-17 i86pc i386 i86pc GNU toolchain (gcc 3.4.3, GNU Make etc.) Reporter: Tadeusz Andrzej Kadłubowski Assignee: Justin SB Priority: Critical Fix For: 3.4.7, 3.5.0 Attachments: zookeeper.patch Hello, Some minor trouble with building ZooKeeper C client library on Sun^H^H^HOracle Solaris 5.10. 1. You need to link against -lnsl -lsocket 2. ctime_r needs a buffer size. The signature is: char *ctime_r(const time_t *clock, char *buf, int buflen) 3. In zk_log.c you need to manually cast pid_t to int (-Werror can be cumbersome ;) ) 4. getpwuid_r()returns pointer to struct passwd, which works as the last parameter on Linux. Solaris signature: struct passwd *getpwuid_r(uid_t uid, struct passwd *pwd, char *buffer, int buflen); Linux signature: int getpwuid_r(uid_t uid, struct passwd *pwd, char *buf, size_t buflen, struct passwd **result); -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (ZOOKEEPER-1077) C client lib doesn't build on Solaris
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821298#comment-13821298 ] Flavio Junqueira commented on ZOOKEEPER-1077: - The solaris build on Jenkins is failing because of java tests and it seems to be a different one every time, so it is quite flaky. Any thoughts about how we fix it for 3.4.6 and trunk? C client lib doesn't build on Solaris - Key: ZOOKEEPER-1077 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1077 Project: ZooKeeper Issue Type: Bug Components: build, c client Affects Versions: 3.3.4 Environment: uname -a: SunOS [redacted] 5.10 Generic_142910-17 i86pc i386 i86pc GNU toolchain (gcc 3.4.3, GNU Make etc.) Reporter: Tadeusz Andrzej Kadłubowski Assignee: Justin SB Priority: Critical Fix For: 3.4.6, 3.5.0 Attachments: zookeeper.patch Hello, Some minor trouble with building ZooKeeper C client library on Sun^H^H^HOracle Solaris 5.10. 1. You need to link against -lnsl -lsocket 2. ctime_r needs a buffer size. The signature is: char *ctime_r(const time_t *clock, char *buf, int buflen) 3. In zk_log.c you need to manually cast pid_t to int (-Werror can be cumbersome ;) ) 4. getpwuid_r()returns pointer to struct passwd, which works as the last parameter on Linux. Solaris signature: struct passwd *getpwuid_r(uid_t uid, struct passwd *pwd, char *buffer, int buflen); Linux signature: int getpwuid_r(uid_t uid, struct passwd *pwd, char *buf, size_t buflen, struct passwd **result); -- This message was sent by Atlassian JIRA (v6.1#6144)
