[jira] [Commented] (ZOOKEEPER-1586) tarballs for zkfuse don't compile out of tree
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789810#comment-13789810 ] Patrick Hunt commented on ZOOKEEPER-1586: - Still an issue? Should we close this? (see my recent comment) tarballs for zkfuse don't compile out of tree - Key: ZOOKEEPER-1586 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1586 Project: ZooKeeper Issue Type: Bug Components: contrib-zkfuse Affects Versions: 3.5.0 Reporter: Raul Gutierrez Segales Assignee: Raul Gutierrez Segales Attachments: ZOOKEEPER-1586.patch -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1586) tarballs for zkfuse don't compile out of tree
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789827#comment-13789827
]
Raul Gutierrez Segales commented on ZOOKEEPER-1586:
---
Yes, I believe it is. Actually there are two issues: a) the tarball is created
with missing source files and b) (more importantly) the BUILD path for the C
libs is wrong.
Should be:
{noformat}
-AC_CHECK_LIB(zookeeper_mt, main, [ZOOKEEPER_LD=-L${ZOOKEEPER_PATH}/.libs
-lzookeeper_mt],,[-L${ZOOKEEPER_PATH}/.libs])
+ZOOKEEPER_BUILD_PATH=${BUILD_PATH}/../../../build/c
+AC_CHECK_LIB(zookeeper_mt, main,
[ZOOKEEPER_LD=-L${ZOOKEEPER_BUILD_PATH}/.libs
-lzookeeper_mt],,[-L${ZOOKEEPER_BUILD_PATH}/.libs])
{noformat}
And the third thing would be the configure.ac doesn't state that boost is
needed.
I'll update the patch.
tarballs for zkfuse don't compile out of tree
-
Key: ZOOKEEPER-1586
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1586
Project: ZooKeeper
Issue Type: Bug
Components: contrib-zkfuse
Affects Versions: 3.5.0
Reporter: Raul Gutierrez Segales
Assignee: Raul Gutierrez Segales
Attachments: ZOOKEEPER-1586.patch
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1586) tarballs for zkfuse don't compile out of tree
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789832#comment-13789832 ] Patrick Hunt commented on ZOOKEEPER-1586: - Is this an issue in 3.4 branch as well? (affects field says just trunk, please update the jira appropriately (if necessary)) thx. tarballs for zkfuse don't compile out of tree - Key: ZOOKEEPER-1586 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1586 Project: ZooKeeper Issue Type: Bug Components: contrib-zkfuse Affects Versions: 3.5.0 Reporter: Raul Gutierrez Segales Assignee: Raul Gutierrez Segales Attachments: ZOOKEEPER-1586.patch -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1586) tarballs for zkfuse don't compile out of tree
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13500077#comment-13500077 ] Hadoop QA commented on ZOOKEEPER-1586: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12554131/ZOOKEEPER-1586.patch against trunk revision 1410731. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1267//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1267//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1267//console This message is automatically generated. tarballs for zkfuse don't compile out of tree - Key: ZOOKEEPER-1586 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1586 Project: ZooKeeper Issue Type: Bug Components: contrib-zkfuse Affects Versions: 3.5.0 Reporter: Raul Gutierrez Segales Attachments: ZOOKEEPER-1586.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
