[jira] [Commented] (ZOOKEEPER-1636) c-client crash when zoo_amulti failed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715583#comment-16715583 ] Hudson commented on ZOOKEEPER-1636: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #303 (See [https://builds.apache.org/job/ZooKeeper-trunk/303/]) ZOOKEEPER-1636: cleanup completion list of a failed multi request (andor: rev b1fd480b2c8e0cc1429345ee04510d3849001c5c) * (edit) zookeeper-client/zookeeper-client-c/src/zookeeper.c * (edit) zookeeper-client/zookeeper-client-c/tests/TestMulti.cc > c-client crash when zoo_amulti failed > -- > > Key: ZOOKEEPER-1636 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1636 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.3 >Reporter: Thawan Kooburat >Assignee: Michael K. Edwards >Priority: Critical > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Attachments: ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, > ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > deserialize_response for multi operation don't handle the case where the > server fail to send back response. (Eg. when multi packet is too large) > c-client will try to process completion of all sub-request as if the > operation is successful and will eventually cause SIGSEGV -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-1636) c-client crash when zoo_amulti failed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715496#comment-16715496 ] Hudson commented on ZOOKEEPER-1636: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #142 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/142/]) ZOOKEEPER-1636: cleanup completion list of a failed multi request (andor: rev b1fd480b2c8e0cc1429345ee04510d3849001c5c) * (edit) zookeeper-client/zookeeper-client-c/tests/TestMulti.cc * (edit) zookeeper-client/zookeeper-client-c/src/zookeeper.c > c-client crash when zoo_amulti failed > -- > > Key: ZOOKEEPER-1636 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1636 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.3 >Reporter: Thawan Kooburat >Assignee: Michael K. Edwards >Priority: Critical > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Attachments: ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, > ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > deserialize_response for multi operation don't handle the case where the > server fail to send back response. (Eg. when multi packet is too large) > c-client will try to process completion of all sub-request as if the > operation is successful and will eventually cause SIGSEGV -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-1636) c-client crash when zoo_amulti failed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697290#comment-16697290 ] Michael K. Edwards commented on ZOOKEEPER-1636: --- Assigning this to me to help get this patch reviewed and landed. > c-client crash when zoo_amulti failed > -- > > Key: ZOOKEEPER-1636 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1636 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.3 >Reporter: Thawan Kooburat >Assignee: Michael K. Edwards >Priority: Critical > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Attachments: ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, > ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch > > Time Spent: 50m > Remaining Estimate: 0h > > deserialize_response for multi operation don't handle the case where the > server fail to send back response. (Eg. when multi packet is too large) > c-client will try to process completion of all sub-request as if the > operation is successful and will eventually cause SIGSEGV -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-1636) c-client crash when zoo_amulti failed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696263#comment-16696263 ] Michael K. Edwards commented on ZOOKEEPER-1636: --- #717 is Thawan's patch as a pull request against master. #713 is the same patch against branch-3.5. > c-client crash when zoo_amulti failed > -- > > Key: ZOOKEEPER-1636 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1636 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.3 >Reporter: Thawan Kooburat >Assignee: Thawan Kooburat >Priority: Critical > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Attachments: ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, > ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch > > Time Spent: 10m > Remaining Estimate: 0h > > deserialize_response for multi operation don't handle the case where the > server fail to send back response. (Eg. when multi packet is too large) > c-client will try to process completion of all sub-request as if the > operation is successful and will eventually cause SIGSEGV -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-1636) c-client crash when zoo_amulti failed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16695249#comment-16695249 ] Hadoop QA commented on ZOOKEEPER-1636: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12671215/ZOOKEEPER-1636.patch against trunk revision 1507f67a06175155003722297daeb60bc912af1d. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3711//console This message is automatically generated. > c-client crash when zoo_amulti failed > -- > > Key: ZOOKEEPER-1636 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1636 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.3 >Reporter: Thawan Kooburat >Assignee: Thawan Kooburat >Priority: Critical > Fix For: 3.6.0, 3.5.5 > > Attachments: ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, > ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch > > > deserialize_response for multi operation don't handle the case where the > server fail to send back response. (Eg. when multi packet is too large) > c-client will try to process completion of all sub-request as if the > operation is successful and will eventually cause SIGSEGV -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-1636) c-client crash when zoo_amulti failed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16695240#comment-16695240 ] Michael K. Edwards commented on ZOOKEEPER-1636: --- Rebased patch on top of the candidate fix for ZOOKEEPER-2778, to get a green build. See https://github.com/apache/zookeeper/pull/713 > c-client crash when zoo_amulti failed > -- > > Key: ZOOKEEPER-1636 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1636 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.3 >Reporter: Thawan Kooburat >Assignee: Thawan Kooburat >Priority: Critical > Fix For: 3.6.0, 3.5.5 > > Attachments: ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, > ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch > > > deserialize_response for multi operation don't handle the case where the > server fail to send back response. (Eg. when multi packet is too large) > c-client will try to process completion of all sub-request as if the > operation is successful and will eventually cause SIGSEGV -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-1636) c-client crash when zoo_amulti failed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343031#comment-15343031 ] Hadoop QA commented on ZOOKEEPER-1636: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12671215/ZOOKEEPER-1636.patch against trunk revision 1748630. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3232//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3232//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3232//console This message is automatically generated. > c-client crash when zoo_amulti failed > -- > > Key: ZOOKEEPER-1636 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1636 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.3 >Reporter: Thawan Kooburat >Assignee: Thawan Kooburat >Priority: Critical > Fix For: 3.6.0, 3.5.3 > > Attachments: ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, > ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch > > > deserialize_response for multi operation don't handle the case where the > server fail to send back response. (Eg. when multi packet is too large) > c-client will try to process completion of all sub-request as if the > operation is successful and will eventually cause SIGSEGV -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1636) c-client crash when zoo_amulti failed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491222#comment-14491222 ] Hadoop QA commented on ZOOKEEPER-1636: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12671215/ZOOKEEPER-1636.patch against trunk revision 1672934. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2622//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2622//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2622//console This message is automatically generated. > c-client crash when zoo_amulti failed > -- > > Key: ZOOKEEPER-1636 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1636 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.3 >Reporter: Thawan Kooburat >Assignee: Thawan Kooburat >Priority: Critical > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, > ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch > > > deserialize_response for multi operation don't handle the case where the > server fail to send back response. (Eg. when multi packet is too large) > c-client will try to process completion of all sub-request as if the > operation is successful and will eventually cause SIGSEGV -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1636) c-client crash when zoo_amulti failed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147811#comment-14147811 ] Flavio Junqueira commented on ZOOKEEPER-1636: - thanks for checking, [~marshall]. I'll generate the 3.4 patch and if I can get a +1 here, I'll check this one in. > c-client crash when zoo_amulti failed > -- > > Key: ZOOKEEPER-1636 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1636 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.3 >Reporter: Thawan Kooburat >Assignee: Thawan Kooburat >Priority: Critical > Fix For: 3.4.7, 3.5.1 > > Attachments: ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, > ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch > > > deserialize_response for multi operation don't handle the case where the > server fail to send back response. (Eg. when multi packet is too large) > c-client will try to process completion of all sub-request as if the > operation is successful and will eventually cause SIGSEGV -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1636) c-client crash when zoo_amulti failed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147804#comment-14147804 ] Marshall McMullen commented on ZOOKEEPER-1636: -- Fantastic find, patch and unit tests. Looks like great hardening around this code path to me. Nice job. > c-client crash when zoo_amulti failed > -- > > Key: ZOOKEEPER-1636 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1636 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.3 >Reporter: Thawan Kooburat >Assignee: Thawan Kooburat >Priority: Critical > Fix For: 3.4.7, 3.5.1 > > Attachments: ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, > ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch > > > deserialize_response for multi operation don't handle the case where the > server fail to send back response. (Eg. when multi packet is too large) > c-client will try to process completion of all sub-request as if the > operation is successful and will eventually cause SIGSEGV -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1636) c-client crash when zoo_amulti failed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147784#comment-14147784 ] Hadoop QA commented on ZOOKEEPER-1636: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12671215/ZOOKEEPER-1636.patch against trunk revision 1626008. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2351//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2351//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2351//console This message is automatically generated. > c-client crash when zoo_amulti failed > -- > > Key: ZOOKEEPER-1636 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1636 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.3 >Reporter: Thawan Kooburat >Assignee: Thawan Kooburat >Priority: Critical > Fix For: 3.4.7, 3.5.1 > > Attachments: ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, > ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch > > > deserialize_response for multi operation don't handle the case where the > server fail to send back response. (Eg. when multi packet is too large) > c-client will try to process completion of all sub-request as if the > operation is successful and will eventually cause SIGSEGV -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1636) c-client crash when zoo_amulti failed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147698#comment-14147698 ] Hadoop QA commented on ZOOKEEPER-1636: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12671206/ZOOKEEPER-1636.patch against trunk revision 1626008. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2350//console This message is automatically generated. > c-client crash when zoo_amulti failed > -- > > Key: ZOOKEEPER-1636 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1636 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.3 >Reporter: Thawan Kooburat >Assignee: Thawan Kooburat >Priority: Critical > Fix For: 3.4.7, 3.5.1 > > Attachments: ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, > ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch > > > deserialize_response for multi operation don't handle the case where the > server fail to send back response. (Eg. when multi packet is too large) > c-client will try to process completion of all sub-request as if the > operation is successful and will eventually cause SIGSEGV -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1636) c-client crash when zoo_amulti failed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569133#comment-13569133 ] Hadoop QA commented on ZOOKEEPER-1636: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12567637/ZOOKEEPER-1636.patch against trunk revision 1438375. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit. The applied patch generated 26 release audit warnings (more than the trunk's current 24 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1374//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1374//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1374//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1374//console This message is automatically generated. > c-client crash when zoo_amulti failed > -- > > Key: ZOOKEEPER-1636 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1636 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.3 >Reporter: Thawan Kooburat >Assignee: Thawan Kooburat >Priority: Critical > Attachments: ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch, > ZOOKEEPER-1636.patch > > > deserialize_response for multi operation don't handle the case where the > server fail to send back response. (Eg. when multi packet is too large) > c-client will try to process completion of all sub-request as if the > operation is successful and will eventually cause SIGSEGV -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1636) c-client crash when zoo_amulti failed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568431#comment-13568431 ] Hadoop QA commented on ZOOKEEPER-1636: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12567504/ZOOKEEPER-1636.patch against trunk revision 1438375. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit. The applied patch generated 26 release audit warnings (more than the trunk's current 24 warnings). -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1373//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1373//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1373//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1373//console This message is automatically generated. > c-client crash when zoo_amulti failed > -- > > Key: ZOOKEEPER-1636 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1636 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.3 >Reporter: Thawan Kooburat >Assignee: Thawan Kooburat >Priority: Critical > Attachments: ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch > > > deserialize_response for multi operation don't handle the case where the > server fail to send back response. (Eg. when multi packet is too large) > c-client will try to process completion of all sub-request as if the > operation is successful and will eventually cause SIGSEGV -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1636) c-client crash when zoo_amulti failed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568430#comment-13568430 ] Marshall McMullen commented on ZOOKEEPER-1636: -- [~thawan] This patch looks really good to me. In our environment where I implemented and tested the original multi op code we have an obscenely large jute buffer size so I never would have hit this bug. Really good find. Patch looks good to me and the unit test is an awesome addition. +1 for me. > c-client crash when zoo_amulti failed > -- > > Key: ZOOKEEPER-1636 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1636 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.3 >Reporter: Thawan Kooburat >Assignee: Thawan Kooburat >Priority: Critical > Attachments: ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch > > > deserialize_response for multi operation don't handle the case where the > server fail to send back response. (Eg. when multi packet is too large) > c-client will try to process completion of all sub-request as if the > operation is successful and will eventually cause SIGSEGV -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1636) c-client crash when zoo_amulti failed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568422#comment-13568422 ] Thawan Kooburat commented on ZOOKEEPER-1636: [~marshall] Do you have any comment on this patch? Seem to relate to multi and memory leak a bit. > c-client crash when zoo_amulti failed > -- > > Key: ZOOKEEPER-1636 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1636 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.3 >Reporter: Thawan Kooburat >Assignee: Thawan Kooburat >Priority: Critical > Attachments: ZOOKEEPER-1636.patch, ZOOKEEPER-1636.patch > > > deserialize_response for multi operation don't handle the case where the > server fail to send back response. (Eg. when multi packet is too large) > c-client will try to process completion of all sub-request as if the > operation is successful and will eventually cause SIGSEGV -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1636) c-client crash when zoo_amulti failed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13567358#comment-13567358 ] Hadoop QA commented on ZOOKEEPER-1636: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12567295/ZOOKEEPER-1636.patch against trunk revision 1438375. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit. The applied patch generated 26 release audit warnings (more than the trunk's current 24 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1370//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1370//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1370//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1370//console This message is automatically generated. > c-client crash when zoo_amulti failed > -- > > Key: ZOOKEEPER-1636 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1636 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.3 >Reporter: Thawan Kooburat >Assignee: Thawan Kooburat >Priority: Critical > Attachments: ZOOKEEPER-1636.patch > > > deserialize_response for multi operation don't handle the case where the > server fail to send back response. (Eg. when multi packet is too large) > c-client will try to process completion of all sub-request as if the > operation is successful and will eventually cause SIGSEGV -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
