[jira] [Commented] (ZOOKEEPER-1681) ZooKeeper 3.4.x can optionally use netty for nio but the pom does not declare the dep as optional
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471051#comment-16471051
]
Hadoop QA commented on ZOOKEEPER-1681:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12665883/ZOOKEEPER-1681.patch
against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3666//console
This message is automatically generated.
> ZooKeeper 3.4.x can optionally use netty for nio but the pom does not declare
> the dep as optional
> -
>
> Key: ZOOKEEPER-1681
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1681
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.0, 3.4.1, 3.4.2, 3.4.4, 3.4.5
>Reporter: John Sirois
>Assignee: Stevo Slavic
>Priority: Major
> Fix For: 3.6.0, 3.5.5
>
> Attachments: ZOOKEEPER-1681.patch
>
>
> For example in
> [3.4.5|http://search.maven.org/remotecontent?filepath=org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.pom]
> we see:
> {code}
> $ curl -sS
> http://search.maven.org/remotecontent?filepath=org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.pom
> | grep -B1 -A4 org.jboss.netty
>
> org.jboss.netty
> netty
> 3.2.2.Final
> compile
>
> {code}
> As a consumer I can depend on zookeeper with an exclude for
> org.jboss.netty#netty or I can let my transitive dep resolver pick a winner.
> This might be fine, except for those who might be using a more modern netty
> published under the newish io.netty groupId. With this twist you get both
> org.jboss.netty#netty;foo and io.netty#netty;bar on your classpath and
> runtime errors ensue from incompatibilities. unless you add an exclude
> against zookeeper (and clearly don't enable the zk netty nio handling.)
> I propose that this is a pom bug although this is debatable. Clearly as
> currently packaged zookeeper needs netty to compile, but I'd argue since it
> does not need netty to run, either the scope should be provided or optional
> or a zookeeper-netty lib should be broken out as an optional dependency and
> this new dep published by zookeeper can have a proper compile dependency on
> netty.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-1681) ZooKeeper 3.4.x can optionally use netty for nio but the pom does not declare the dep as optional
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342928#comment-15342928
]
Hadoop QA commented on ZOOKEEPER-1681:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12665883/ZOOKEEPER-1681.patch
against trunk revision 1748630.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3214//console
This message is automatically generated.
> ZooKeeper 3.4.x can optionally use netty for nio but the pom does not declare
> the dep as optional
> -
>
> Key: ZOOKEEPER-1681
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1681
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.0, 3.4.1, 3.4.2, 3.4.4, 3.4.5
>Reporter: John Sirois
>Assignee: Stevo Slavic
> Fix For: 3.6.0, 3.5.3
>
> Attachments: ZOOKEEPER-1681.patch
>
>
> For example in
> [3.4.5|http://search.maven.org/remotecontent?filepath=org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.pom]
> we see:
> {code}
> $ curl -sS
> http://search.maven.org/remotecontent?filepath=org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.pom
> | grep -B1 -A4 org.jboss.netty
>
> org.jboss.netty
> netty
> 3.2.2.Final
> compile
>
> {code}
> As a consumer I can depend on zookeeper with an exclude for
> org.jboss.netty#netty or I can let my transitive dep resolver pick a winner.
> This might be fine, except for those who might be using a more modern netty
> published under the newish io.netty groupId. With this twist you get both
> org.jboss.netty#netty;foo and io.netty#netty;bar on your classpath and
> runtime errors ensue from incompatibilities. unless you add an exclude
> against zookeeper (and clearly don't enable the zk netty nio handling.)
> I propose that this is a pom bug although this is debatable. Clearly as
> currently packaged zookeeper needs netty to compile, but I'd argue since it
> does not need netty to run, either the scope should be provided or optional
> or a zookeeper-netty lib should be broken out as an optional dependency and
> this new dep published by zookeeper can have a proper compile dependency on
> netty.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1681) ZooKeeper 3.4.x can optionally use netty for nio but the pom does not declare the dep as optional
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15177275#comment-15177275
]
Hadoop QA commented on ZOOKEEPER-1681:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12665883/ZOOKEEPER-1681.patch
against trunk revision 1733348.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3067//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3067//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3067//console
This message is automatically generated.
> ZooKeeper 3.4.x can optionally use netty for nio but the pom does not declare
> the dep as optional
> -
>
> Key: ZOOKEEPER-1681
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1681
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.0, 3.4.1, 3.4.2, 3.4.4, 3.4.5
>Reporter: John Sirois
>Assignee: Stevo Slavic
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-1681.patch
>
>
> For example in
> [3.4.5|http://search.maven.org/remotecontent?filepath=org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.pom]
> we see:
> {code}
> $ curl -sS
> http://search.maven.org/remotecontent?filepath=org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.pom
> | grep -B1 -A4 org.jboss.netty
>
> org.jboss.netty
> netty
> 3.2.2.Final
> compile
>
> {code}
> As a consumer I can depend on zookeeper with an exclude for
> org.jboss.netty#netty or I can let my transitive dep resolver pick a winner.
> This might be fine, except for those who might be using a more modern netty
> published under the newish io.netty groupId. With this twist you get both
> org.jboss.netty#netty;foo and io.netty#netty;bar on your classpath and
> runtime errors ensue from incompatibilities. unless you add an exclude
> against zookeeper (and clearly don't enable the zk netty nio handling.)
> I propose that this is a pom bug although this is debatable. Clearly as
> currently packaged zookeeper needs netty to compile, but I'd argue since it
> does not need netty to run, either the scope should be provided or optional
> or a zookeeper-netty lib should be broken out as an optional dependency and
> this new dep published by zookeeper can have a proper compile dependency on
> netty.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1681) ZooKeeper 3.4.x can optionally use netty for nio but the pom does not declare the dep as optional
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491246#comment-14491246
]
Hadoop QA commented on ZOOKEEPER-1681:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12665883/ZOOKEEPER-1681.patch
against trunk revision 1672934.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2611//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2611//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2611//console
This message is automatically generated.
ZooKeeper 3.4.x can optionally use netty for nio but the pom does not declare
the dep as optional
-
Key: ZOOKEEPER-1681
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1681
Project: ZooKeeper
Issue Type: Improvement
Affects Versions: 3.4.0, 3.4.1, 3.4.2, 3.4.4, 3.4.5
Reporter: John Sirois
Fix For: 3.5.2, 3.6.0
Attachments: ZOOKEEPER-1681.patch
For example in
[3.4.5|http://search.maven.org/remotecontent?filepath=org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.pom]
we see:
{code}
$ curl -sS
http://search.maven.org/remotecontent?filepath=org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.pom
| grep -B1 -A4 org.jboss.netty
dependency
groupIdorg.jboss.netty/groupId
artifactIdnetty/artifactId
version3.2.2.Final/version
scopecompile/scope
/dependency
{code}
As a consumer I can depend on zookeeper with an exclude for
org.jboss.netty#netty or I can let my transitive dep resolver pick a winner.
This might be fine, except for those who might be using a more modern netty
published under the newish io.netty groupId. With this twist you get both
org.jboss.netty#netty;foo and io.netty#netty;bar on your classpath and
runtime errors ensue from incompatibilities. unless you add an exclude
against zookeeper (and clearly don't enable the zk netty nio handling.)
I propose that this is a pom bug although this is debatable. Clearly as
currently packaged zookeeper needs netty to compile, but I'd argue since it
does not need netty to run, either the scope should be provided or optional
or a zookeeper-netty lib should be broken out as an optional dependency and
this new dep published by zookeeper can have a proper compile dependency on
netty.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1681) ZooKeeper 3.4.x can optionally use netty for nio but the pom does not declare the dep as optional
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118081#comment-14118081
]
Hadoop QA commented on ZOOKEEPER-1681:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12665883/ZOOKEEPER-1681.patch
against trunk revision 1621313.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2309//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2309//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2309//console
This message is automatically generated.
ZooKeeper 3.4.x can optionally use netty for nio but the pom does not declare
the dep as optional
-
Key: ZOOKEEPER-1681
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1681
Project: ZooKeeper
Issue Type: Improvement
Affects Versions: 3.4.0, 3.4.1, 3.4.2, 3.4.4, 3.4.5
Reporter: John Sirois
Fix For: 3.5.1
Attachments: ZOOKEEPER-1681.patch
For example in
[3.4.5|http://search.maven.org/remotecontent?filepath=org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.pom]
we see:
{code}
$ curl -sS
http://search.maven.org/remotecontent?filepath=org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.pom
| grep -B1 -A4 org.jboss.netty
dependency
groupIdorg.jboss.netty/groupId
artifactIdnetty/artifactId
version3.2.2.Final/version
scopecompile/scope
/dependency
{code}
As a consumer I can depend on zookeeper with an exclude for
org.jboss.netty#netty or I can let my transitive dep resolver pick a winner.
This might be fine, except for those who might be using a more modern netty
published under the newish io.netty groupId. With this twist you get both
org.jboss.netty#netty;foo and io.netty#netty;bar on your classpath and
runtime errors ensue from incompatibilities. unless you add an exclude
against zookeeper (and clearly don't enable the zk netty nio handling.)
I propose that this is a pom bug although this is debatable. Clearly as
currently packaged zookeeper needs netty to compile, but I'd argue since it
does not need netty to run, either the scope should be provided or optional
or a zookeeper-netty lib should be broken out as an optional dependency and
this new dep published by zookeeper can have a proper compile dependency on
netty.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1681) ZooKeeper 3.4.x can optionally use netty for nio but the pom does not declare the dep as optional
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13775636#comment-13775636
]
Raul Gutierrez Segales commented on ZOOKEEPER-1681:
---
I guess https://issues.apache.org/jira/browse/ZOOKEEPER-1763 would help.
ZooKeeper 3.4.x can optionally use netty for nio but the pom does not declare
the dep as optional
-
Key: ZOOKEEPER-1681
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1681
Project: ZooKeeper
Issue Type: Improvement
Affects Versions: 3.4.0, 3.4.1, 3.4.2, 3.4.4, 3.4.5
Reporter: John Sirois
Fix For: 3.5.0
For example in
[3.4.5|http://search.maven.org/remotecontent?filepath=org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.pom]
we see:
{code}
$ curl -sS
http://search.maven.org/remotecontent?filepath=org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.pom
| grep -B1 -A4 org.jboss.netty
dependency
groupIdorg.jboss.netty/groupId
artifactIdnetty/artifactId
version3.2.2.Final/version
scopecompile/scope
/dependency
{code}
As a consumer I can depend on zookeeper with an exclude for
org.jboss.netty#netty or I can let my transitive dep resolver pick a winner.
This might be fine, except for those who might be using a more modern netty
published under the newish io.netty groupId. With this twist you get both
org.jboss.netty#netty;foo and io.netty#netty;bar on your classpath and
runtime errors ensue from incompatibilities. unless you add an exclude
against zookeeper (and clearly don't enable the zk netty nio handling.)
I propose that this is a pom bug although this is debatable. Clearly as
currently packaged zookeeper needs netty to compile, but I'd argue since it
does not need netty to run, either the scope should be provided or optional
or a zookeeper-netty lib should be broken out as an optional dependency and
this new dep published by zookeeper can have a proper compile dependency on
netty.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1681) ZooKeeper 3.4.x can optionally use netty for nio but the pom does not declare the dep as optional
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13753649#comment-13753649
]
Flavio Junqueira commented on ZOOKEEPER-1681:
-
This one looks more like an improvement, so I'll move it to 3.5.0 and will
reclassify it. Please feel free to disagree!
ZooKeeper 3.4.x can optionally use netty for nio but the pom does not declare
the dep as optional
-
Key: ZOOKEEPER-1681
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1681
Project: ZooKeeper
Issue Type: Bug
Affects Versions: 3.4.0, 3.4.1, 3.4.2, 3.4.4, 3.4.5
Reporter: John Sirois
Fix For: 3.4.6
For example in
[3.4.5|http://search.maven.org/remotecontent?filepath=org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.pom]
we see:
{code}
$ curl -sS
http://search.maven.org/remotecontent?filepath=org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.pom
| grep -B1 -A4 org.jboss.netty
dependency
groupIdorg.jboss.netty/groupId
artifactIdnetty/artifactId
version3.2.2.Final/version
scopecompile/scope
/dependency
{code}
As a consumer I can depend on zookeeper with an exclude for
org.jboss.netty#netty or I can let my transitive dep resolver pick a winner.
This might be fine, except for those who might be using a more modern netty
published under the newish io.netty groupId. With this twist you get both
org.jboss.netty#netty;foo and io.netty#netty;bar on your classpath and
runtime errors ensue from incompatibilities. unless you add an exclude
against zookeeper (and clearly don't enable the zk netty nio handling.)
I propose that this is a pom bug although this is debatable. Clearly as
currently packaged zookeeper needs netty to compile, but I'd argue since it
does not need netty to run, either the scope should be provided or optional
or a zookeeper-netty lib should be broken out as an optional dependency and
this new dep published by zookeeper can have a proper compile dependency on
netty.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
